Guilherme Tadashi Maeoka [Sat, 9 Mar 2019 18:30:46 +0000 (15:30 -0300)]
staging: rtl8723bs: os_dep: Fix space in pointer definition
Pointer definition "foo * bar" should be "foo *bar".
Signed-off-by: Guilherme Tadashi Maeoka <gui.maeoka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Guilherme Tadashi Maeoka [Sat, 9 Mar 2019 18:30:43 +0000 (15:30 -0300)]
staging: rtl8723bs: os_dep: Fix assignment in if condition
Fix an assignment in if condition.
Signed-off-by: Guilherme Tadashi Maeoka <gui.maeoka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Sun, 17 Mar 2019 10:47:51 +0000 (16:17 +0530)]
staging: vt6655: rxtx.c: Remove unnecessary space after a cast
Issue found by checkpatch.pl semantic patch results for
rxtx.c. Remove unnecessary space after the cast.
CHECK:
No necessary space is required after a cast.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Sat, 16 Mar 2019 22:26:57 +0000 (22:26 +0000)]
staging: rtl8723bs: remove unused code
There are two final hunks of code that are only built
if SDIO_DYNAMIC_ALLOC_MEM is defined however this is never
defined and if it was the code would lead to dereferencing
an uninitialized pointer oldmem. It appears that a previous
commit
1babeb0c3e59 ("Staging: rtl8723bs: Remove dead code")
removed some of the dead code but not all of it. Clean this
up by removing the final hunks.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sidong Yang [Tue, 12 Mar 2019 14:11:50 +0000 (14:11 +0000)]
staging: rtl8192u: Add required spaces before open parenthesis
Fix error reported by checkpatch.pl
Signed-off-by: Sidong Yang <realwakka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alejandro Ismael Silva [Tue, 12 Mar 2019 12:35:27 +0000 (09:35 -0300)]
staging: vc04_services: Use tabs instead of spaces
This patch fixes the checkpatch.pl error:
WARNING: please, no spaces at the start of a line
in the interface/vchi directory.
Signed-off-by: Alejandro Ismael Silva <silva.alejandro.ismael@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Valdis Klētnieks [Tue, 12 Mar 2019 12:09:20 +0000 (08:09 -0400)]
staging: rtl8712 - fix up non-kerneldoc comments
Building with W=1 reports (among other things)
CC [M] drivers/staging/rtl8712/rtl871x_ioctl_linux.o
drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1106: warning: Cannot understand *
on line 1106 - I thought it was a doc line
CC [M] drivers/staging/rtl8712/os_intfs.o
drivers/staging/rtl8712/os_intfs.c:366: warning: Cannot understand *
on line 366 - I thought it was a doc line
drivers/staging/rtl8712/os_intfs.c:434: warning: Cannot understand *
on line 434 - I thought it was a doc line
Fix up the non-kerneldoc comments
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julio Bianco [Sat, 9 Mar 2019 17:08:53 +0000 (14:08 -0300)]
staging: erofs: add a new line after variable declaration
Add a new line after variable declaration
Signed-off-by: Julio Bianco <juliobianco@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Lazzati [Sat, 9 Mar 2019 18:18:27 +0000 (15:18 -0300)]
staging: octeon-usb octeon-hcd: Fix several typos.
I found that the comments had several typos such as "aenable", "internaly" and some others.
I fixed them all.
Signed-off-by: Laura Lazzati <laura.lazzati.15@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jeremy Sowden [Fri, 8 Mar 2019 08:49:51 +0000 (08:49 +0000)]
staging: fbtft: fixed format-string errors.
Added __printf attribute to declaration of fbtft_dbg_hex and fixed
mismatches between format-specifiers and arguments in several function
calls.
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hugo Lange [Sun, 3 Mar 2019 20:24:39 +0000 (20:24 +0000)]
staging: rtl8188eu: remove unnecessary braces from if/else
Removed unnecessary braces for single blocks.
Signed-off-by: Hugo Lange <hugolange7000@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jann Horn [Fri, 1 Mar 2019 20:11:24 +0000 (21:11 +0100)]
staging: rtl8723bs: use kernel_read() instead of open-coded version
Replace the manual call to f_op->read() under KERNEL_DS with kernel_read().
This also reduces the number of users of the legacy alias get_ds() for
KERNEL_DS.
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:15:01 +0000 (11:45 +0530)]
staging: rtl8723bs: hal: Modify comparison to constant in rtl8723bs_xmit.c
Modify comparison to true in file rtl8723bs_xmit in order to follow
kernel coding style of constant should appear on the right side.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:15:00 +0000 (11:45 +0530)]
staging: rtl8723bs: hal: Modify comparison to constant in hal_btcoex.c
Modify comparison to 0 in file hal_btcoex.c in order to follow kernel
coding style of constant should appear on right side.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:59 +0000 (11:44 +0530)]
staging: rtl8723bs: hal: Remove comparison to NULL in hal_btcoex.c
- Remove comparison to NULL in file hal_btcoex.c. Suggested by
Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:58 +0000 (11:44 +0530)]
staging: rtl8723bs: hal: Remove comparison to NULL in hal_com.c
Remove comparison to NULL in file hal_com.c. Suggested by Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:57 +0000 (11:44 +0530)]
staging: rtl8723bs: hal: Remove comparison to NULL in hal_com_phycfg.c
Remove comparison to NULL in file hal_com_phycfg.c. Suggested by Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:56 +0000 (11:44 +0530)]
staging: rtl8723bs: hal: Remove comparison to NULL in rtl8723b_cmd.c
Remove comparison to NULL in file rtl8723b_cmd.c. Suggested by
Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:55 +0000 (11:44 +0530)]
staging: rtl8723bs: hal:Remove comparison to NULL in rtl8723bs_xmit.c
Remove comparison to NULL in file rtl8723bs_xmit.c. Suggested by Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:54 +0000 (11:44 +0530)]
staging: rtl8723bs: hal: Remove comparison to NULL in rtl8723b_dm.c
Remove comparison to NULL in file rtl8723b_dm.c. Suggested by Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:53 +0000 (11:44 +0530)]
staging: rtl8723bs: hal: Remove comparison to NULL in rtl8723b_hal_init.c
Remove comparison to NULL in file rtl8723b_hal_init.c. Suggested by
Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:52 +0000 (11:44 +0530)]
staging: rtl8723bs: hal: Remove comparison to NULL in rtl8723bs_recv.c
Remove comparison to NULL in file rtl8723bs_recv.c. Suggested by
Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 17 Mar 2019 06:14:51 +0000 (11:44 +0530)]
staging: rtl8723bs: hal: Remove comparison to NULL in rtl8723b_rxdesc.c
Remove comparison to null in file rtl8723b_rxdesc.c. Suggested by Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Wed, 13 Mar 2019 15:32:05 +0000 (10:32 -0500)]
staging: sm750fb: Remove an unnecessary local variable in a function
Remove an unnecessary local variable in sm750_format_pll_reg function
and replace its initialization directly in return type.
Issue suggested by Coccinelle using ret.cocci.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Thu, 14 Mar 2019 18:25:14 +0000 (11:25 -0700)]
staging: mt7621-mmc: delele extra blank lines
Delete extra blank lines to mute checkpatch.pl check:
CHECK: Please don't use multiple blank lines
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri Dighole [Thu, 14 Mar 2019 12:18:03 +0000 (17:48 +0530)]
staging: rtlwifi: Replace 0 with false.
Replace 0 with false, Bool intializations should use true or false.
Detected by Coccinelle semantic patch boolinit.cocci.
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri Dighole [Wed, 13 Mar 2019 19:07:17 +0000 (00:37 +0530)]
staging: pi433: Remove unused variable.
Remove unused variable which is used to store return value,
Detected by Coccinelle semantic patch returnvar.cocci
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jules Irenge [Wed, 13 Mar 2019 14:53:20 +0000 (14:53 +0000)]
staging: rtl8192e: remove boilerplate license text
Remove boilerplate license text.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jules Irenge [Wed, 13 Mar 2019 14:53:19 +0000 (14:53 +0000)]
staging: rtl8192e: add SPDX GPL-2.0 license identifier
Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning
Issue found by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri Dighole [Wed, 13 Mar 2019 08:15:09 +0000 (13:45 +0530)]
staging: fbtft: line over 80 characters
Fix the checkpatch.pl warning
WARNING: line over 80 characters
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Wed, 13 Mar 2019 08:14:53 +0000 (01:14 -0700)]
staging: gasket: Replace macro __ATTR with __ATTR_NULL
Replace macro __ATTR with __ATTR_NULL since the former one is
unnecessary for gasket_sysfs_attr array terminator. Also silence the
checkpatch.pl warning:
WARNING:Symbolic permissions 'S_IRUGO' are not preferred. Consider using
octal
permissions '0444'.
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
NeilBrown [Mon, 11 Mar 2019 23:09:37 +0000 (10:09 +1100)]
staging: mt7621-dts: update ethernet settings.
The ethernet in mt7621 is now supported by
drivers/net/ethernet/mediatek/
which provides support for the integrated switch through DSA.
This requires some devicetree changes, and particularly allows
a board dts to identify which switch ports are present.
The second CPU interface - gmac1 - doesn't work yet, so the device
tree information may not be correct. The phy (which is present on the
gnubee-pc2) can negotiate and report connection speed etc, but no
traffic flows.
The gnubee-pc1 has two network ports which are 'black' and 'blue'.
There are connected to switch ports 0 and 4 respectively.
Signed-off-by: NeilBrown <neil@brown.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
NeilBrown [Mon, 11 Mar 2019 23:09:37 +0000 (10:09 +1100)]
staging: remove mt7621-eth
driver/net/ethernet/mediatek/ now supports this hardware,
so we don't need a separate driver.
Signed-off-by: NeilBrown <neil@brown.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Branden Bonaby [Tue, 12 Mar 2019 18:06:15 +0000 (14:06 -0400)]
staging: mt7621-pci: IF statement expression comparing to NULL
Remove comparison to NULL in the if statement expression
to match the Linux Kernel coding style.
CHECK: Comparison to NULL could be written "res"
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri Dighole [Tue, 12 Mar 2019 07:16:55 +0000 (12:46 +0530)]
staging: rtl8712: line over 80 characters.
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Branden Bonaby [Tue, 12 Mar 2019 02:48:06 +0000 (22:48 -0400)]
staging: octeon: Lines should not end with a '('
Start function arguments immediately after opening bracket.
CHECK: Lines should not end with a '('.
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Tue, 12 Mar 2019 08:10:39 +0000 (01:10 -0700)]
staging: most: Replace '--help--' in Kconfig file
Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Tue, 12 Mar 2019 09:35:11 +0000 (02:35 -0700)]
staging: netlogic: Remove unnecessary 'out of memory' message
Remove unnecessary 'out of memory' message to silence checkpatch.pl
warning:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Mon, 11 Mar 2019 15:41:41 +0000 (21:11 +0530)]
staging: rtl8192u: Adjust 'if' to follow Kernel coding Style
-Adjust spaces around if and the condition expression to
maintain Linux Kernel Coding style.
-Remove unnecessary braces around if-else as only single statement is executed.
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Mon, 11 Mar 2019 15:41:40 +0000 (21:11 +0530)]
staging: rtl8192u: Remove casts on the return values of list_entry
Remove casts return values of on all occurances of list_entry.
Casts on the return values of list_entry are useless.
list_entry is a macro and already casts its return value to the type
mentioned in its second argument.
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Mon, 11 Mar 2019 15:41:39 +0000 (21:11 +0530)]
staging: rtl8192u: Remove typedef for struct _RX_REORDER_ENTRY
-Avoid typedefs for structure types to maintain kernel coding style.
-Remove typedefs RX_REORDER_ENTRY and *PRX_REORDER_ENTRY of struct _RX_REORDER_ENTRY .
-Change Structure name _RX_REORDER_ENTRY to rx_reorder_entry to maintain Linux kernel Coding Style.
-Replace occurences of RX_REORDER_ENTRY to struct rx_reorder_entry.
-Replace occurences of PRX_REORDER_ENTRY to struct rx_reorder_entry *.
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Mon, 11 Mar 2019 15:41:38 +0000 (21:11 +0530)]
staging: rtl8192u: Remove typedef for struct _RT_LINK_DETECT_T
-Avoid typedefs for structure types to maintain kernel coding style.
-Remove typedefs RT_LINK_DETECT_T and *PRT_LINK_DETECT_T of struct _RT_LINK_DETECT_T.
-Change Structure name _RT_LINK_DETECT_T to rt_link_detect to maintain Linux kernel Coding Style.
-Replace occurence of RT_LINK_DETECT_T to struct rt_link_detect.
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Mon, 11 Mar 2019 15:41:37 +0000 (21:11 +0530)]
staging: rtl8192u: Remove typedef for struct _RT_POWER_SAVE_CONTROL
-Avoid typedefs for structure types to maintain kernel coding style.
-Remove typedefs RT_POWER_SAVE_CONTROL and *PRT_POWER_SAVE_CONTROL of struct _RT_POWER_SAVE_CONTROL.
-Change Structure name _RT_POWER_SAVE_CONTROL to rt_power_save_control to maintain Linux kernel Coding Style.
-Replace occurence of _RT_POWER_SAVE_CONTROL to struct rt_power_save_control.
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Mon, 11 Mar 2019 15:41:36 +0000 (21:11 +0530)]
staging: rtl8192u: Remove typedef for struct _IbssParms
-Avoid typedefs for structure types to maintain kernel coding style.
-Remove typedefs IbssParms and *PIbssParms of struct _IbssParms.
-Change Structure name _IbssParms to ibss_parms to maintain Linux kernel Coding Style.
-Replace occurence of IbssParms to struct ibss_parms.
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Mon, 11 Mar 2019 15:41:35 +0000 (21:11 +0530)]
staging: rtl8192u: Remove typedef for struct _bandwidth_autoswitch
-Avoid typedefs for structure types to maintain kernel coding style.
-Remove typedefs bandwidth_autoswitch and *pbandwidth_autoswitch of
struct _bandwidth_autoswitch.
-Change Structure name _bandwidth_autoswitch to bandwidth_autoswitch to
maintain Linux kernel Coding Style.
-Replace occurence of bandwidth_autoswitch to struct bandwidth_autoswitch.
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sat, 9 Mar 2019 15:15:06 +0000 (20:45 +0530)]
staging: wilc1000: remove unnecessary local variables
Remove unnecessary local variable "ret" and its assignments from
functions wilc_set_tx_power and wilc_get_tx_power. Suggested by
Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sat, 9 Mar 2019 17:51:36 +0000 (23:21 +0530)]
staging: media: zoran: remove unnecessary parentheses
Remove unnecessary parentheses from right hand side of
assignments. Suggested by Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sat, 9 Mar 2019 18:16:08 +0000 (23:46 +0530)]
staging: rtlwifi: phydm: remove unnecessary parentheses
Remove unnecessary parentheses around the right hand side of assignment
operator. Issue found using Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Debleena Sen [Sat, 9 Mar 2019 18:53:37 +0000 (10:53 -0800)]
staging: vboxvideo: Do not return -ENOSYS
New instances of ENOSYS are errors. ENOSYS should be used for nonexistent
syscalls only. Use ENODEV instead as there should not be any other
driver for a virtual device that might share buffers with vboxvideo.
In vbox_prime.c, replace all occurrences of -ENOSYS with -ENODEV to fix
checkpatch.pl warning:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Sun, 10 Mar 2019 18:38:36 +0000 (00:08 +0530)]
staging: sm750fb: Edit CamelCase in local variables
Edit CamelCase in local variables across 4 files:
- sm750fb/ddk750_chip.c
- sm750fb/ddk750_chip.h
- sm750fb/ddk750_dvi.c
- sm750fb/ddk750_sii164.c
to comply with the coding style. Also edit associated comments
accordingly.
Issue found with Checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Branden Bonaby [Mon, 11 Mar 2019 13:31:57 +0000 (09:31 -0400)]
staging: vt6655: line over 80 characters
Move function arguments that go over the 80 characters a line limit to a new line.
"WARNING: line over 80 characters".
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Sat, 9 Mar 2019 07:31:25 +0000 (23:31 -0800)]
staging: most: dim2: reg.h: Correct SPDX-License-Identifier
Correct SPDX-License-Identifier comment characters to silence
checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Sat, 9 Mar 2019 07:31:24 +0000 (23:31 -0800)]
staging: most: dim2: sysfs.h: Correct SPDX-License-Identifier
Correct SPDX-License-Identifier comment characters to silence
checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Sat, 9 Mar 2019 07:31:23 +0000 (23:31 -0800)]
staging: most: dim2: hal.h: Correct SPDX-License-Identifier
Correct SPDX-License-Identifier comment characters to silence
checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Sat, 9 Mar 2019 07:31:21 +0000 (23:31 -0800)]
staging: most: dim2: errors.h: Correct SPDX-License-Identifier
Correct SPDX-License-Identifier comment characters to silence
checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sat, 9 Mar 2019 09:31:58 +0000 (15:01 +0530)]
staging: octeon-usb: remove unnecessary variable frame_number
Remove unnecessary local variable "frame_number" and its assignments from function
cvmx_usb_get_frame_numbe. Suggested by Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri Dighole [Fri, 8 Mar 2019 15:31:28 +0000 (21:01 +0530)]
staging: fbtft: convert a macro to a function.
Convert a macro to an inline function to improve type safety and make
the code simpler.
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Thu, 7 Mar 2019 21:11:29 +0000 (15:11 -0600)]
staging: vt6655: Remove unused function prototype and definition
Remove the MACbIsRegBitsOn function, as it is never called in kernel tree.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Fri, 8 Mar 2019 02:01:13 +0000 (18:01 -0800)]
staging: most: usb: Change '--help--' to 'help' in Kconfig
Change '--help--' in Kconfig file to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jules Irenge [Fri, 8 Mar 2019 01:35:00 +0000 (01:35 +0000)]
staging: zoran: remove license boilerplate text
Remove license boilerplate text.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jules Irenge [Fri, 8 Mar 2019 01:34:59 +0000 (01:34 +0000)]
staging: zoran: add SPDX GPL-2.0+ license identifier
Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning.
Issue found by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yifeng Li [Sun, 3 Mar 2019 16:55:31 +0000 (00:55 +0800)]
staging: sm750fb: trivial comment indention fix.
In function sm750_hw_copyarea() of sm750_accel.c, there are
some comments in ASCII graphs, describing 4 possible scenarios
of overlapping areas when copying an area. However, the graphs
have broken indention.
The entire SiliconMotion series video controllers, including
SM501, SM712 and SM750 have similar 2D engines, yet, I have
not seen a single version of it with ASCII graphs properly
formatted...
Fix the the misleading ASCII graphs. It would eliminate the
confusions and improve code readability.
Signed-off-by: Yifeng Li <tomli@tomli.me>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Robert Eshleman [Wed, 6 Mar 2019 15:31:41 +0000 (07:31 -0800)]
staging: rtl8188eu: cleanup spacing style
This patch fixes a few spacing warnings from checkpatch.pl,
as well as an incorrect spacing between a function type and
the function name.
Signed-off-by: Robert Eshleman <bobbyeshleman@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Thu, 7 Mar 2019 11:42:33 +0000 (13:42 +0200)]
staging: media: davinci_vpfe: Fix alignment issues
Fix all the alignment issues in the file to
get rid of checkpatch warnings
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Thu, 7 Mar 2019 11:42:09 +0000 (13:42 +0200)]
staging: media: davinci_vpfe: Fix multiple line dereference
Fix multiple line dereference to improve readability
and avoid checkpatch warning
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Thu, 7 Mar 2019 11:41:45 +0000 (13:41 +0200)]
staging: media: davinci_vpfe: Fix comparison to NULL
Replace comparison to NULL with '!' operator
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Thu, 7 Mar 2019 20:00:08 +0000 (14:00 -0600)]
staging: vt6655: Remove an unused function prototype
Remove an unused function prototype as there is no such function in the
kernel tree.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Thu, 7 Mar 2019 19:23:40 +0000 (21:23 +0200)]
staging: vt6655: Fix malformed SPDX-License-Identifier tag
Replace "//" comment with "/**/" comment
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Thu, 7 Mar 2019 19:04:26 +0000 (21:04 +0200)]
staging: rtl8712: Replace NULL comparisons
Replace all NULL comparisons in the file
to get rid of checkpatch warnings
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Wed, 6 Mar 2019 12:06:40 +0000 (14:06 +0200)]
staging: vc04_services: bcm2835-camera: Fix logical continuations warnings
Break up lines after boolean operator
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Thu, 7 Mar 2019 10:25:48 +0000 (12:25 +0200)]
staging: speakup: Add spaces around operators
Add spaces around math operators to get rid of checkpatch warning
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Wed, 6 Mar 2019 22:48:09 +0000 (16:48 -0600)]
staging: fwserial: Convert macro into an inline function
Convert macro into an inline function to make codebase better
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Wed, 6 Mar 2019 12:32:05 +0000 (14:32 +0200)]
staging: speakup: Spaces around operator
Add spaces around bitwise AND operator
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri Dighole [Wed, 6 Mar 2019 11:12:22 +0000 (16:42 +0530)]
staging: fbtft: Remove unused #defines.
Remove unused #defines, which is detected while resolving `CHECK:
Avoid CamelCase` issue.
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Tue, 5 Mar 2019 22:48:28 +0000 (16:48 -0600)]
staging: vt6655: Align function declaration
Fix function return type and function arguments to improve readbility.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Tue, 5 Mar 2019 22:48:27 +0000 (16:48 -0600)]
staging: vt6655: Fix the warning line over 80 characters
Fix the checkpatch.pl warning
WARNING: line over 80 characters
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Tue, 5 Mar 2019 22:48:26 +0000 (16:48 -0600)]
staging: vt6655: mac.h: Fix comment style for SPDX-License Identifier
Modify comment style for header type file based on license identifier
syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Tue, 5 Mar 2019 22:48:25 +0000 (16:48 -0600)]
staging: vt6655: Remove unnecessary blank line
Fix the check issue provided by checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Tue, 5 Mar 2019 22:48:24 +0000 (16:48 -0600)]
staging: vt6655: key.h: Fix comment style for SPDX-License Identifier
Modify comment style for SPDX-License Identifier based on license
identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Tue, 5 Mar 2019 22:48:23 +0000 (16:48 -0600)]
staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Modify comment style of SPDX License Identifier for header file type, as
per the license identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Tue, 5 Mar 2019 16:31:58 +0000 (10:31 -0600)]
staging: vt6655: Fix space around binary operator
Fix the check as per Linux kernel style for use of spaces
CHECK: spaces preferred around that '-'
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Tue, 5 Mar 2019 16:31:57 +0000 (10:31 -0600)]
staging: vt6655: Fix spelling mistake
Fix the check for spelling mistake
CHECK: 'Regsiter' may be misspelled - perhaps 'Register'
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri Dighole [Wed, 6 Mar 2019 08:55:41 +0000 (14:25 +0530)]
staging: speakup: Comparison to NULL.
Fix coding style issues, detected by checkpatch.pl "CHECK: Comparison to
NULL could be written !tty->ops->write"
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Tue, 5 Mar 2019 16:23:16 +0000 (18:23 +0200)]
staging: vc04_services: bcm2835-camera: Fix multiple line dereference
Fix multiple line dereference to avoid checkpatch warnings
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Tue, 5 Mar 2019 15:50:55 +0000 (17:50 +0200)]
staging: vc04-services: bcm2835-audio: Fix alignment issues
Fix all the alignment with open parenthesis issues
detected by checkpatch
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Tue, 5 Mar 2019 15:24:49 +0000 (17:24 +0200)]
staging: vboxvideo: Fix open parenthesis at the end of line
Fix open parenthesis at the end of line
to improve readability
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Tue, 5 Mar 2019 12:55:55 +0000 (14:55 +0200)]
staging: ralink-gdma: Avoid unnecessary line continuations
Get rid of unnecessary line continuations in
boolean expressions, warning detected by checkpatch
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Tue, 5 Mar 2019 12:53:20 +0000 (14:53 +0200)]
staging: ralink-gdma: Replace from uint32_t to u32
Replace all uintr32_t with u32 to avoid getting
checkpatch warning
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Tue, 5 Mar 2019 12:50:06 +0000 (14:50 +0200)]
staging: ralink-gdma: Avoid unnecessary line continuations in string
Fix split string in multiple lines
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Tue, 5 Mar 2019 10:57:39 +0000 (12:57 +0200)]
staging: iio: Line over 80 characters
Fix line over 80 characters, warning by checkpatch
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Tue, 5 Mar 2019 03:25:35 +0000 (19:25 -0800)]
staging: r8712u: Replace '--help--' with 'help'
This patch replace '--help--' in Kconfig to silence checkpatch.pl
warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Mon, 4 Mar 2019 22:23:08 +0000 (00:23 +0200)]
staging: fbtft: Fix line over 80 characters
Fix line with over 80 characters to get rid of the warning
given by checkpatch
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Mon, 4 Mar 2019 19:45:56 +0000 (13:45 -0600)]
staging: vt6655: desc.h: Fix comment style of SPDX-License Identifier
Fix comment style of SPDX License Identifier for header file based on
License Identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Mon, 4 Mar 2019 19:45:55 +0000 (13:45 -0600)]
staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
Fix the comment style of SPDX License Identifier for header file based
on License Identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Mon, 4 Mar 2019 17:43:15 +0000 (23:13 +0530)]
staging: greybus: Change NULL comparison to Boolean Negation
Change NULL comparison to boolean negation. Issue found by Checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Mon, 4 Mar 2019 17:33:25 +0000 (19:33 +0200)]
staging: emxx_udc: Fix open parenthesis at the end of the line
warning detected by checkpatch.pl
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daniela Mormocea [Mon, 4 Mar 2019 17:12:02 +0000 (19:12 +0200)]
staging: emxx_udc: Fix equal sign alignment
Warning detected by checkpatch
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Debleena Sen [Mon, 4 Mar 2019 14:55:36 +0000 (06:55 -0800)]
staging: wilc1000: Fix line over 80 characters
Break the line after '+' to remove the checkpatch.pl warning. Remove
trailing whitespace after '+' if any:
WARNING: line over 80 characters
Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 3 Mar 2019 10:39:15 +0000 (16:09 +0530)]
staging: rtl8712: rename bSuspended to suspended
- Rename structure field bSuspended to suspended to avoid camelcase.
Suggested by checkpatch.
- Change type to bool as the variable is used as a boolean.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Sun, 3 Mar 2019 10:39:14 +0000 (16:09 +0530)]
staging: rtl8712: rename bSurpriseRemoved to surprise_removed
- Rename structure field bSurprisedRemoved to surprised_removed to avoid
camelcase. Suggested by checkpatch.
- Change type to bool as the variable is used as a boolean.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>