platform/upstream/libSkiaSharp.git
8 years agoUpdate SK_IMAGE_VERSION to 3
msarett [Tue, 23 Feb 2016 16:14:19 +0000 (08:14 -0800)]
Update SK_IMAGE_VERSION to 3

This includes two new test wbmps (that came from clients of BitmapFactory).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722263002

Review URL: https://codereview.chromium.org/1722263002

8 years agoMove SkUtils.h to src/core.
bungeman [Tue, 23 Feb 2016 15:34:25 +0000 (07:34 -0800)]
Move SkUtils.h to src/core.

Review URL: https://codereview.chromium.org/1722703003

8 years agoadded 'visible' attribute to skiaserve JSON
ethannicholas [Tue, 23 Feb 2016 14:53:37 +0000 (06:53 -0800)]
added 'visible' attribute to skiaserve JSON
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726663002

Review URL: https://codereview.chromium.org/1726663002

8 years agoUse new API instead of the deprecated ones.
yujieqin [Tue, 23 Feb 2016 14:49:38 +0000 (06:49 -0800)]
Use new API instead of the deprecated ones.

This change will allow us to remove the old API in follow up clean up.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728553002

Review URL: https://codereview.chromium.org/1728553002

8 years agoUpdate PIEX: Prepares support for uncompressed thumbnails
yujieqin [Tue, 23 Feb 2016 14:18:14 +0000 (06:18 -0800)]
Update PIEX: Prepares support for uncompressed thumbnails

The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate.

BUG=b/26894354
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723123002

Review URL: https://codereview.chromium.org/1723123002

8 years agoTurn on TURBO_HAS_CROP for Android framework
msarett [Tue, 23 Feb 2016 13:48:01 +0000 (05:48 -0800)]
Turn on TURBO_HAS_CROP for Android framework

https://buganizer.corp.google.com/u/0/issues/27290496
BUG=skia:4256
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721953002

Review URL: https://codereview.chromium.org/1721953002

8 years agoMake DM failures fatal
msarett [Tue, 23 Feb 2016 13:37:25 +0000 (05:37 -0800)]
Make DM failures fatal

We should now only be pushing Srcs for tests that we expect
to succeed.  So any failures should be treated as errors.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719293002

Review URL: https://codereview.chromium.org/1719293002

8 years agoAdd dest type hint to SkShader::ContextRec
fmalita [Tue, 23 Feb 2016 01:19:04 +0000 (17:19 -0800)]
Add dest type hint to SkShader::ContextRec

Let SkBlitter decide which dst type is optimal (PMColor vs PM4f), and
pass that info to shaders.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724503002

Review URL: https://codereview.chromium.org/1724503002

8 years agoremove unnecessary copies
mtklein [Tue, 23 Feb 2016 00:56:00 +0000 (16:56 -0800)]
remove unnecessary copies

these used to matter with pass-by-ref

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721153002

Review URL: https://codereview.chromium.org/1721153002

8 years agoRun no CPU benches in Debug trybots.
mtklein [Mon, 22 Feb 2016 22:59:59 +0000 (14:59 -0800)]
Run no CPU benches in Debug trybots.

They seem to just be wasting time on the CQ.

Hacking this into nanobench_flags.py makes it easy to back out.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720223002

Review URL: https://codereview.chromium.org/1720223002

8 years agoBetter encapsulation and vector calling convention.
herb [Mon, 22 Feb 2016 22:48:21 +0000 (14:48 -0800)]
Better encapsulation and vector calling convention.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723683002

Review URL: https://codereview.chromium.org/1723683002

8 years agoFix DM_INCLUDES after https://codereview.chromium.org/1688543002
benjaminwagner [Mon, 22 Feb 2016 21:30:39 +0000 (13:30 -0800)]
Fix DM_INCLUDES after https://codereview.chromium.org/1688543002

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719253002

Review URL: https://codereview.chromium.org/1719253002

8 years agoOnly use fake gamma with linear devices.
bungeman [Mon, 22 Feb 2016 21:20:28 +0000 (13:20 -0800)]
Only use fake gamma with linear devices.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711223003

Review URL: https://codereview.chromium.org/1711223003

8 years agoAdd spans for matrix ops.
herb [Mon, 22 Feb 2016 21:13:28 +0000 (13:13 -0800)]
Add spans for matrix ops.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722703002

Review URL: https://codereview.chromium.org/1722703002

8 years agofix unsigned/signed warning on linux for GrVkDescriptorPool::numPoolSizes()
bsalomon [Mon, 22 Feb 2016 21:09:26 +0000 (13:09 -0800)]
fix unsigned/signed warning on linux for GrVkDescriptorPool::numPoolSizes()

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724493002

Review URL: https://codereview.chromium.org/1724493002

8 years agoFix unsigned short UVs for Vulkan.
jvanverth [Mon, 22 Feb 2016 21:05:51 +0000 (13:05 -0800)]
Fix unsigned short UVs for Vulkan.

Modifies the attribute type to match GL.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723633003

Review URL: https://codereview.chromium.org/1723633003

8 years agoFix gyp-and-sync for windows
bsalomon [Mon, 22 Feb 2016 20:59:53 +0000 (12:59 -0800)]
Fix gyp-and-sync for windows
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715423003

Review URL: https://codereview.chromium.org/1715423003

8 years agofix misc asserts and checks found by fuzzer
reed [Mon, 22 Feb 2016 20:50:25 +0000 (12:50 -0800)]
fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719993002

Review URL: https://codereview.chromium.org/1719993002

8 years agoallow move/zero-line/close to draw caps
caryclark [Mon, 22 Feb 2016 20:44:54 +0000 (12:44 -0800)]
allow move/zero-line/close to draw caps

R=fmalita@chromium.org
BUG=skia:4784
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720953002

Review URL: https://codereview.chromium.org/1720953002

8 years agokill gm now that we can test srgb on all gms
reed [Mon, 22 Feb 2016 20:29:04 +0000 (12:29 -0800)]
kill gm now that we can test srgb on all gms

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719963004

TBR=

Review URL: https://codereview.chromium.org/1719963004

8 years agoUse new jpeg_crop_scanlines() API to optimize jpeg subset decodes
msarett [Mon, 22 Feb 2016 20:27:46 +0000 (12:27 -0800)]
Use new jpeg_crop_scanlines() API to optimize jpeg subset decodes

This was adapted from:
https://codereview.chromium.org/1530933003

Subset Decode Runtime (Original / Optimized) on Nexus 6P
TopLeft     0.51x
TopRight    0.56x
Middle      0.71x
BottomLeft  0.79x
BottomRight 0.79x

BUG=skia:4256
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719073002

Review URL: https://codereview.chromium.org/1719073002

8 years agoIncorporate Vulkan files into main gpu.gyp/gpu.gypi
bsalomon [Mon, 22 Feb 2016 20:13:19 +0000 (12:13 -0800)]
Incorporate Vulkan files into main gpu.gyp/gpu.gypi

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718273002

Review URL: https://codereview.chromium.org/1718273002

8 years agoUse unorm shorts for texture coordinates when rendering text.
jvanverth [Mon, 22 Feb 2016 19:25:32 +0000 (11:25 -0800)]
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063

Review URL: https://codereview.chromium.org/1713693002

8 years agoSimplify calculations in AADistanceFieldPathBatch::writePathVertices.
benjaminwagner [Mon, 22 Feb 2016 19:10:33 +0000 (11:10 -0800)]
Simplify calculations in AADistanceFieldPathBatch::writePathVertices.

No API changes.

BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715063002
TBR=reed

Review URL: https://codereview.chromium.org/1715063002

8 years agoAllow client to force an SkImage snapshot to be unique (and uniquely own its backing...
bsalomon [Mon, 22 Feb 2016 19:02:58 +0000 (11:02 -0800)]
Allow client to force an SkImage snapshot to be unique (and uniquely own its backing store).
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686163002

Review URL: https://codereview.chromium.org/1686163002

8 years agoAdd ContextRec param to SkShader::contextSize()
fmalita [Mon, 22 Feb 2016 18:39:41 +0000 (10:39 -0800)]
Add ContextRec param to SkShader::contextSize()

To facilitate upcoming context selection changes.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720933002

Review URL: https://codereview.chromium.org/1720933002

8 years agoremove dead unpremul checks
reed [Mon, 22 Feb 2016 18:25:45 +0000 (10:25 -0800)]
remove dead unpremul checks

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715333004

Review URL: https://codereview.chromium.org/1715333004

8 years agoFix to bazel build file to exclude vulkan files
egdaniel [Mon, 22 Feb 2016 18:07:54 +0000 (10:07 -0800)]
Fix to bazel build file to exclude vulkan files

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723593002

Review URL: https://codereview.chromium.org/1723593002

8 years agoskia.org internal links: Add link to Google3 Autoroller doc.
benjaminwagner [Mon, 22 Feb 2016 17:31:38 +0000 (09:31 -0800)]
skia.org internal links: Add link to Google3 Autoroller doc.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720943003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1720943003

Review URL: https://codereview.chromium.org/1720943003

8 years agoInitial linear gradient 4f impl
fmalita [Mon, 22 Feb 2016 17:12:33 +0000 (09:12 -0800)]
Initial linear gradient 4f impl

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1688543002

Review URL: https://codereview.chromium.org/1688543002

8 years agoadded mode=cpu|gpu to skiaserve JSON
ethannicholas [Mon, 22 Feb 2016 16:59:57 +0000 (08:59 -0800)]
added mode=cpu|gpu to skiaserve JSON
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719973002

Review URL: https://codereview.chromium.org/1719973002

8 years agoFix nanobench SKP flushes between loops
cdalton [Mon, 22 Feb 2016 16:08:25 +0000 (08:08 -0800)]
Fix nanobench SKP flushes between loops

Updates SKPBench to actually flush between draw loops, as this was the
original intent of the flush logic.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715873002

Review URL: https://codereview.chromium.org/1715873002

8 years agoAdd gl_SampleMask functionality to fragment builders
cdalton [Mon, 22 Feb 2016 15:55:44 +0000 (07:55 -0800)]
Add gl_SampleMask functionality to fragment builders

Adds methods for overriding and masking a fragment's sample mask.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690963003

Committed: https://skia.googlesource.com/skia/+/533cefe5b9c7cec2592fc7ca00ee4cf69a26c094

Review URL: https://codereview.chromium.org/1690963003

8 years agoRevert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https...
ethannicholas [Mon, 22 Feb 2016 15:42:18 +0000 (07:42 -0800)]
Revert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1719913002/ )

Reason for revert:
Looks to be causing failures in LayerTreeHostFilters* tests (https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/177297/steps/cc_unittests%20%28with%20patch%29/logs/stdio).

Original issue's description:
> fix misc asserts and checks found by fuzzer
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/653db51b440491b0fb1908bf5a43dcc89c90044d

TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1721743002

8 years agoRemove vulkan files from cmake build
egdaniel [Mon, 22 Feb 2016 15:19:10 +0000 (07:19 -0800)]
Remove vulkan files from cmake build

TBR=bsalomon@google.com
NOTRY=True

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1717313002

Review URL: https://codereview.chromium.org/1717313002

8 years agoclean-up dead code
reed [Mon, 22 Feb 2016 14:59:37 +0000 (06:59 -0800)]
clean-up dead code

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719773002

Review URL: https://codereview.chromium.org/1719773002

8 years agoAdd vulkan files into skia repo. This is an incomplete backend with only partial...
Greg Daniel [Mon, 22 Feb 2016 14:56:40 +0000 (09:56 -0500)]
Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time.

R=robertphillips@google.com
TBR=bsalomon@google.com

BUG=skia:4955
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002

Committed: https://skia.googlesource.com/skia/+/48cf268defad66f58f1aa03b4835e5583be96b2f

Review URL: https://codereview.chromium.org/1718693002

8 years agolots of sRGB and F16 blits
reed [Mon, 22 Feb 2016 14:42:31 +0000 (06:42 -0800)]
lots of sRGB and F16 blits

- generalize F16 xfermode procs
- spriteblits for F16 and sRGB
- saveLayer now respects colortype and profiletype

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686013002

Review URL: https://codereview.chromium.org/1685203002

8 years agofix misc asserts and checks found by fuzzer
reed [Mon, 22 Feb 2016 14:34:47 +0000 (06:34 -0800)]
fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002

TBR=

Review URL: https://codereview.chromium.org/1719913002

8 years agoadd SkGraphics::PurageAllCaches
reed [Mon, 22 Feb 2016 14:19:54 +0000 (06:19 -0800)]
add SkGraphics::PurageAllCaches

BUG=skia:4755
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722603002

TBR=

Review URL: https://codereview.chromium.org/1722603002

8 years agoRevert of Add vulkan files into skia repo. (patchset #2 id:20001 of https://coderevie...
egdaniel [Mon, 22 Feb 2016 14:17:52 +0000 (06:17 -0800)]
Revert of Add vulkan files into skia repo. (patchset #2 id:20001 of https://codereview.chromium.org/1718693002/ )

Reason for revert:
breaking builds

Original issue's description:
> Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time.
>
> R=robertphillips@google.com
> TBR=bsalomon@google.com
>
> BUG=skia:4955
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002
>
> Committed: https://skia.googlesource.com/skia/+/48cf268defad66f58f1aa03b4835e5583be96b2f

TBR=robertphillips@google.com,bsalomon@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4955

Review URL: https://codereview.chromium.org/1723503002

8 years agoAdd vulkan files into skia repo. This is an incomplete backend with only partial...
Greg Daniel [Mon, 22 Feb 2016 14:11:32 +0000 (09:11 -0500)]
Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time.

R=robertphillips@google.com
TBR=bsalomon@google.com

BUG=skia:4955
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002

Review URL: https://codereview.chromium.org/1718693002

8 years agoRevert of ix misc asserts and checks found by fuzzer (patchset #1 id:1 of https:...
reed [Mon, 22 Feb 2016 13:57:31 +0000 (05:57 -0800)]
Revert of ix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1723473002/ )

Reason for revert:
need to not land the canvas change yet

Original issue's description:
> Reland of ix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1713413002/ )
>
> Reason for revert:
> deps instability seemingly fixed. trying again.
>
> Original issue's description:
> > Revert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1713383002/ )
> >
> > Reason for revert:
> > speculative deps-roll fix
> >
> > Original issue's description:
> > > fix misc asserts and checks found by fuzzer
> > >
> > > BUG=skia:
> > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002
> > >
> > > TBR=robertphilips
> > >
> > > Committed: https://skia.googlesource.com/skia/+/00bea4ad310c4ec4dd95809b47ce3fbfa8fd0e1e
> >
> > TBR=robertphillips@google.com
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/d98ef6377269e3596423225ab922301ed40529a0
>
> TBR=robertphillips@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/75a73297cb44c65a9efcf5f212854cb457140e34

TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1723483002

8 years agoReland of ix misc asserts and checks found by fuzzer (patchset #1 id:1 of https:...
reed [Mon, 22 Feb 2016 13:54:53 +0000 (05:54 -0800)]
Reland of ix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1713413002/ )

Reason for revert:
deps instability seemingly fixed. trying again.

Original issue's description:
> Revert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1713383002/ )
>
> Reason for revert:
> speculative deps-roll fix
>
> Original issue's description:
> > fix misc asserts and checks found by fuzzer
> >
> > BUG=skia:
> > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002
> >
> > TBR=robertphilips
> >
> > Committed: https://skia.googlesource.com/skia/+/00bea4ad310c4ec4dd95809b47ce3fbfa8fd0e1e
>
> TBR=robertphillips@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d98ef6377269e3596423225ab922301ed40529a0

TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1723473002

8 years agofix race: this kCacheSize is probably not meant to be static
mtklein [Sun, 21 Feb 2016 21:36:50 +0000 (13:36 -0800)]
fix race: this kCacheSize is probably not meant to be static

TSAN sees us racing to intialize the static const kCacheSize.

This static const value depends on the runtime value image->getSize(), so there
is a race to set it.  I think this is unintentionally copy-paste from the other
tests that use a constant kCacheSize.  It's weird to intialize a constant based
on the first call to test_internal_purge(), though luckily we're always calling
it with same sized images today.

See these TSAN failures:
    https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN/builds/4937
    https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN/builds/4940/steps/dm/logs/stdio

TBR=robertphillips@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720743002

Review URL: https://codereview.chromium.org/1720743002

8 years agoSkNx: kth<...>() -> [...]
mtklein [Sun, 21 Feb 2016 18:54:19 +0000 (10:54 -0800)]
SkNx: kth<...>() -> [...]

Just some syntax cleanup.  No real change: kth<...>() was calling [...] already.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1714363002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1714363002

8 years agoRevert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https...
reed [Sun, 21 Feb 2016 18:27:49 +0000 (10:27 -0800)]
Revert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1713383002/ )

Reason for revert:
speculative deps-roll fix

Original issue's description:
> fix misc asserts and checks found by fuzzer
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002
>
> TBR=robertphilips
>
> Committed: https://skia.googlesource.com/skia/+/00bea4ad310c4ec4dd95809b47ce3fbfa8fd0e1e

TBR=robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1713413002

8 years agoUpdate SKP version
update-skps [Sun, 21 Feb 2016 08:43:52 +0000 (00:43 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715213002

Review URL: https://codereview.chromium.org/1715213002

8 years agorevert fuzzer fixes for canvas, need to investigate more
reed [Sun, 21 Feb 2016 02:48:58 +0000 (18:48 -0800)]
revert fuzzer fixes for canvas, need to investigate more

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1717943002

TBR=

Review URL: https://codereview.chromium.org/1717943002

8 years agofix misc asserts and checks found by fuzzer
reed [Sat, 20 Feb 2016 22:18:27 +0000 (14:18 -0800)]
fix misc asserts and checks found by fuzzer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002

TBR=robertphilips

Review URL: https://codereview.chromium.org/1713383002

8 years agoFix asserts found in SampleApp and update the tests with additional interesting numbers.
herb [Sat, 20 Feb 2016 00:54:12 +0000 (16:54 -0800)]
Fix asserts found in SampleApp and update the tests with additional interesting numbers.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1717743004

Review URL: https://codereview.chromium.org/1717743004

8 years agoChange type of SkScalerContext_FreeType::fScaleX/Y. All uses want FT_F26Dot6.
benjaminwagner [Fri, 19 Feb 2016 23:30:20 +0000 (15:30 -0800)]
Change type of SkScalerContext_FreeType::fScaleX/Y. All uses want FT_F26Dot6.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711053004

Review URL: https://codereview.chromium.org/1711053004

8 years agoAdd point spans, but fall back for all cases.
herb [Fri, 19 Feb 2016 22:39:47 +0000 (14:39 -0800)]
Add point spans, but fall back for all cases.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711963003

curr/maxrss     loops   min     median  mean    max     stddev  samples                 config  bench
  10/10  MB     1       481µs   504µs   512µs   580µs   6%      ▁▁▄▆▂▃▁▁▁▁▁▁▃▇█▅▃█▃▅    nonrendering    SkBitmapFPAffineXClampYClampFilterOrig
  10/10  MB     1       2.21ms  2.31ms  2.31ms  2.53ms  4%      ▁▁▆▃▃▃▄▅▂▁▄▁█▅▁▁▄▂▆▁    nonrendering    SkBitmapFPAffineXClampYClampFilterLinr
  10/10  MB     1       2.49ms  2.63ms  2.61ms  2.78ms  4%      ▄▃▇▄▅▇▆▁▆▁▁▁▅▂▁▄▃█▆▃    nonrendering    SkBitmapFPAffineXClampYClampFiltersRGB
  10/10  MB     2       150µs   151µs   153µs   162µs   2%      ▅▇▂▂▁▁▂▂▁▁▂▂▁▁▁▁▇█▂▁    nonrendering    SkBitmapFPAffineXClampYClampNearestOrig
  10/10  MB     1       552µs   553µs   562µs   658µs   4%      ▁▁▁▁▁▁▁▁▁▄▃▁▁▁▁▁▁▁▁█    nonrendering    SkBitmapFPAffineXClampYClampNearestLinr
  10/10  MB     1       718µs   742µs   748µs   808µs   4%      ▃▃▁▁▅▁▁▁▁▃▃▃▃▇▇▇▁▁▇█    nonrendering    SkBitmapFPAffineXClampYClampNearestsRGB
  10/10  MB     1       277µs   286µs   292µs   341µs   7%      █▁▁▁▁▁▁▁▁▁▃▂▃▃▆█▄▂▂▂    nonrendering    SkBitmapFPScaleXClampYClampFilterOrig
  10/10  MB     1       2.21ms  2.41ms  2.39ms  2.55ms  4%      ▄▆▃▅▇▂▁▁▇▅▆▅▅▆▄▅█▅▆▅    nonrendering    SkBitmapFPScaleXClampYClampFilterLinr
  10/10  MB     1       2.55ms  2.68ms  2.69ms  2.94ms  4%      ▂▃▁▁▄▄▅▅▄▃█▄▃▇▂▁▃▃▂▂    nonrendering    SkBitmapFPScaleXClampYClampFiltersRGB
  10/10  MB     4       59.9µs  60.6µs  61.6µs  71.1µs  5%      ▂▃▄▁▁▁▁█▇▁▂▁▁▁▁▁▁▁▁▁    nonrendering    SkBitmapFPScaleXClampYClampNearestOrig
  10/10  MB     1       534µs   560µs   559µs   613µs   5%      ▇▂▁▅▅▅█▅▅▃▁▁▁▁▂▄▅▁▁▁    nonrendering    SkBitmapFPScaleXClampYClampNearestLinr
  10/10  MB     1       639µs   658µs   666µs   731µs   5%      ▅█▃▂▃▇▆▁▁▁▁▁▂▁▁▁▁▄█▄    nonrendering    SkBitmapFPScaleXClampYClampNearestsRGB
  10/10  MB     4       61.6µs  65.7µs  65.5µs  70.4µs  5%      ▃▃▃█▆▆▂▂▂▅▄▄▇▄▁▂▁▄██    nonrendering    SkBitmapFPIdentityXClampYClampFilterOrig
  10/10  MB     1       2.22ms  2.34ms  2.35ms  2.57ms  3%      ▂█▅▄▃▃▃▄▂▄▄▄▂▄▁▆▃▁▄▃    nonrendering    SkBitmapFPIdentityXClampYClampFilterLinr
  10/10  MB     1       2.42ms  2.52ms  2.52ms  2.76ms  4%      ▁▁▄▂▄▄▃▅█▄▅▁▃▁▁▃▁▄▃▃    nonrendering    SkBitmapFPIdentityXClampYClampFiltersRGB
  10/10  MB     4       59.7µs  64.7µs  64.8µs  73.3µs  7%      ▂▂▄▁▂▁▁▂▁▁▆▄▆▆▇▄▆▇▂█    nonrendering    SkBitmapFPIdentityXClampYClampNearestOrig
  10/10  MB     1       376µs   388µs   387µs   429µs   4%      ▃▃▆▁▄▄▁▃█▁▁▁▁▁▃▃▄▁▁▁    nonrendering    SkBitmapFPIdentityXClampYClampNearestLinr
  10/10  MB     1       496µs   511µs   518µs   568µs   5%      ▂▆▆█▆▃▂▂█▇▃▁▁▁▁▁▁▁▁▁    nonrendering    SkBitmapFPIdentityXClampYClampNearestsRGB

Review URL: https://codereview.chromium.org/1711963003

8 years agoDM: remove unnecessary use of std::function
mtklein [Fri, 19 Feb 2016 22:27:14 +0000 (14:27 -0800)]
DM: remove unnecessary use of std::function

This draw_to_canvas() function doesn't need the power of std::function.

This skips a copy or two, which is nice, and seems to clear
up most of my MSAN problems.  Why?  I do not know.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718633002

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

Review URL: https://codereview.chromium.org/1718633002

8 years agoChanges to merge vulkan code
bsalomon [Fri, 19 Feb 2016 22:26:30 +0000 (14:26 -0800)]
Changes to merge vulkan code

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711793004

Review URL: https://codereview.chromium.org/1711793004

8 years agoCalculate translations to apply to vertices in batch
joshualitt [Fri, 19 Feb 2016 22:13:03 +0000 (14:13 -0800)]
Calculate translations to apply to vertices in batch

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716443005

Review URL: https://codereview.chromium.org/1716443005

8 years agocheck pm swizzle when extracting lcd coverage
reed [Fri, 19 Feb 2016 21:46:03 +0000 (13:46 -0800)]
check pm swizzle when extracting lcd coverage

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706283005

Review URL: https://codereview.chromium.org/1706283005

8 years agoremove supports4f flag for colorfilters
reed [Fri, 19 Feb 2016 21:38:53 +0000 (13:38 -0800)]
remove supports4f flag for colorfilters

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720443002

Review URL: https://codereview.chromium.org/1720443002

8 years agoInsert an empty image when we cannot decode
scroggo [Fri, 19 Feb 2016 20:08:41 +0000 (12:08 -0800)]
Insert an empty image when we cannot decode

In SKP deserialization, if there is a 0 byte encoded image, we insert
an empty image into the output SkPicture so that we can continue
deserializing. Do the same when our decoder cannot decode it. This may
be the result of a bug in our decoder, or in the stream serialization.
But it should not mean the entire stream is invalid.

BUG=skia:4691
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715853002

Review URL: https://codereview.chromium.org/1715853002

8 years agogyp_skia: use path python, be quiet
mtklein [Fri, 19 Feb 2016 19:43:57 +0000 (11:43 -0800)]
gyp_skia: use path python, be quiet

/usr/bin/python might not be python 2.x

I'm getting annoyed by scripts printing messages when there's no problem.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716493003

Review URL: https://codereview.chromium.org/1716493003

8 years agoUpdate libpng to 1.6.22beta
msarett [Fri, 19 Feb 2016 19:14:43 +0000 (11:14 -0800)]
Update libpng to 1.6.22beta

Intel SSE filter optimizations have been upstreamed.  Let's test on
the upstream version (which we can use in Android).

BUG=skia:4573
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710083007

Review URL: https://codereview.chromium.org/1710083007

8 years agoAdd GPU-backed SkImage case to ImageFilterCache unit test
robertphillips [Fri, 19 Feb 2016 18:41:12 +0000 (10:41 -0800)]
Add GPU-backed SkImage case to ImageFilterCache unit test

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713073002

Review URL: https://codereview.chromium.org/1713073002

8 years agoNEON f32 <-> f16 and f32 <-> u16
mtklein [Fri, 19 Feb 2016 17:40:24 +0000 (09:40 -0800)]
NEON f32 <-> f16 and f32 <-> u16

Adds f32 <-> f16 ARMv7 and ARMv8 NEON code.
Also adds NEON f32 <-> u16 code to make the comparison fair.

The NDK GCC does not support the ARMv8 NEON intrinsics needed to go fastest, so we use a tiny amount of inline assembly.

The ARMv7 half -> float is different enough from the SSE version that it does not make sense to use SkNx.

Still TODO:
ARMv7 float -> half.  Naively translating the SSE version results in 0x0000 where we'd expect a denormal output.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1700473003
CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Release-Trybot;client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1700473003

8 years agoadd back some basic configs to MSAN bot
mtklein [Fri, 19 Feb 2016 17:08:50 +0000 (09:08 -0800)]
add back some basic configs to MSAN bot

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706373004

Review URL: https://codereview.chromium.org/1706373004

8 years agoRevert of Use unorm shorts for texture coordinates when rendering text. (patchset...
jvanverth [Fri, 19 Feb 2016 16:43:26 +0000 (08:43 -0800)]
Revert of Use unorm shorts for texture coordinates when rendering text. (patchset #3 id:40001 of https://codereview.chromium.org/1713693002/ )

Reason for revert:
Causing issues with text on Mali 400s. Examples:  largeglyphblur, imageblurtiled. It appears that there are precision problems.

Original issue's description:
> Use unorm shorts for texture coordinates when rendering text.
>
> There are a couple of reasons for this:
> - Vulkan does not guarantee conversions from integral vertex attributes
>   to floating point shader variables
> - This may be faster and more precise on some platforms, as it avoids
>   the aforementioned conversion and changes a multiply by a very small
>   value to a multiply by a medium-sized value.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
> TBR=bsalomon@google.com
>
> Committed: https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063

TBR=joshualitt@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1709133003

8 years agoadded /enableGPU command to skiaserve
ethannicholas [Fri, 19 Feb 2016 16:40:59 +0000 (08:40 -0800)]
added /enableGPU command to skiaserve
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715503004

Review URL: https://codereview.chromium.org/1715503004

8 years agoUpdate SkImageFilter's cache to handle SkSpecialImages and add unit test
robertphillips [Fri, 19 Feb 2016 16:19:40 +0000 (08:19 -0800)]
Update SkImageFilter's cache to handle SkSpecialImages and add unit test

This is calved off of: https://codereview.chromium.org/1695823002/ (Get OffsetImageFilter really working with SkSpecialImages)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709263002
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/1709263002

8 years agofix iter to document close correctly
caryclark [Fri, 19 Feb 2016 15:40:34 +0000 (07:40 -0800)]
fix iter to document close correctly

R=reed@google.com
BUG=skia:4950
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1717623002

Review URL: https://codereview.chromium.org/1717623002

8 years agoUse unorm shorts for texture coordinates when rendering text.
jvanverth [Fri, 19 Feb 2016 14:35:22 +0000 (06:35 -0800)]
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/1713693002

8 years agoUpdate the version of libpng used by Skia tests
scroggo [Fri, 19 Feb 2016 14:33:07 +0000 (06:33 -0800)]
Update the version of libpng used by Skia tests

The version of libpng we were using has some security vulnerabilities.
Update to a newer version - 1.6.20 (http://sourceforge.net/p/libpng/code/ci/047737496a77eeb97f9991919dac08ca3c149711/).

Update pnglibconf.h. The new version is a copy of the newer version of
the file, with our /* custom settings */ tacked onto the end. (The
custom settings are unchanged from the last version.)

Update the LICENSE. The new version is a copy of the LICENSE that
libpng now includes as a separate file.

Update the README file to reflect the change in source of the LICENSE
file.

BUG=skia:4573
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1453373003

Review URL: https://codereview.chromium.org/1453373003

8 years agoTest build scheduler.
rmistry [Fri, 19 Feb 2016 11:47:53 +0000 (03:47 -0800)]
Test build scheduler.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711253003

NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1711253003

8 years agoremove xferu64 gm -- not needed now that the blitters are hooked up
reed [Fri, 19 Feb 2016 01:11:47 +0000 (17:11 -0800)]
remove xferu64 gm -- not needed now that the blitters are hooked up

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710283002

TBR=

Review URL: https://codereview.chromium.org/1710283002

8 years agofix red/blue order in 64bit blits
reed [Thu, 18 Feb 2016 22:52:17 +0000 (14:52 -0800)]
fix red/blue order in 64bit blits

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715513004

Review URL: https://codereview.chromium.org/1715513004

8 years agoSwitch to pixmap in API.
herb [Thu, 18 Feb 2016 21:55:02 +0000 (13:55 -0800)]
Switch to pixmap in API.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1712653002

Review URL: https://codereview.chromium.org/1712653002

8 years agoGrAuditTrail can now be enabled/disabled at runtime
ethannicholas [Thu, 18 Feb 2016 21:45:39 +0000 (13:45 -0800)]
GrAuditTrail can now be enabled/disabled at runtime
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1712753002

TBR=bsalomon@google.com
Doesn't actually change the public API

Review URL: https://codereview.chromium.org/1712753002

8 years agomake SkPM4f private
reed [Thu, 18 Feb 2016 20:39:14 +0000 (12:39 -0800)]
make SkPM4f private

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713653002

Review URL: https://codereview.chromium.org/1713653002

8 years agoAdd more specialized fragment builders
cdalton [Thu, 18 Feb 2016 20:37:07 +0000 (12:37 -0800)]
Add more specialized fragment builders

Adds specialized fragment builders for primitive and fragment
processors. Removes fragment-specific functionality from the Xfer
fragment builder.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709153002

Review URL: https://codereview.chromium.org/1709153002

8 years agoMove SkTInternalLList.h to src/core.
bungeman [Thu, 18 Feb 2016 19:53:18 +0000 (11:53 -0800)]
Move SkTInternalLList.h to src/core.

TBR=reed
Not intended for external use.

Review URL: https://codereview.chromium.org/1712563004

8 years agoMSAN: cut down to green
mtklein [Thu, 18 Feb 2016 19:42:00 +0000 (11:42 -0800)]
MSAN: cut down to green

I have no idea what's going on with the current bot failures.
This disables lots of things to get it green.
Probably more than necessary.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707873002

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

Review URL: https://codereview.chromium.org/1707873002

8 years agoMove SkTDStack.h to src/animator.
bungeman [Thu, 18 Feb 2016 19:01:13 +0000 (11:01 -0800)]
Move SkTDStack.h to src/animator.

This file is only used by animator and may or may not be sane. Move
the file from include/core to src/animator since no one else is using
it.

TBR=reed
Make it go away!

Review URL: https://codereview.chromium.org/1710083002

8 years agofixed SkDrawCommand JSON generation
ethannicholas [Thu, 18 Feb 2016 18:50:50 +0000 (10:50 -0800)]
fixed SkDrawCommand JSON generation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715443002

Review URL: https://codereview.chromium.org/1715443002

8 years agoadded server-side breakpoint support to skiaserve
ethannicholas [Thu, 18 Feb 2016 18:22:34 +0000 (10:22 -0800)]
added server-side breakpoint support to skiaserve
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707863003

Review URL: https://codereview.chromium.org/1707863003

8 years agoAdd luci-go isolate.sha1 files
borenet [Thu, 18 Feb 2016 18:13:14 +0000 (10:13 -0800)]
Add luci-go isolate.sha1 files

NOTRY=true
BUG=skia:3775, skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711013002

Review URL: https://codereview.chromium.org/1711013002

8 years agoMake build_command_buffer.py work on Windows
bsalomon [Thu, 18 Feb 2016 18:01:11 +0000 (10:01 -0800)]
Make build_command_buffer.py work on Windows

BUG=skia:4957
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710983002

Review URL: https://codereview.chromium.org/1710983002

8 years agocheck for zero conic weights in interp
caryclark [Thu, 18 Feb 2016 17:00:01 +0000 (09:00 -0800)]
check for zero conic weights in interp

this will fix the current (and uncover the next)
ASAN failure

TBR=tomhudson@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711813002

Review URL: https://codereview.chromium.org/1711813002

8 years agoMove SkTDArray to private.
bungeman [Thu, 18 Feb 2016 16:53:33 +0000 (08:53 -0800)]
Move SkTDArray to private.

TBR=reed
Moving to private is good.

Review URL: https://codereview.chromium.org/1707213002

8 years agoUpdate SkSpecialImage API
robertphillips [Thu, 18 Feb 2016 16:48:03 +0000 (08:48 -0800)]
Update SkSpecialImage API

This adds some temporary compatibility features:
   internal_getBM & internal_fromBM - to convert back & forth from Bitmaps in the ImageFilters
   internal_getProxy - to allow the special images to interface with the current ImagerFilter system

It also adds a unique ID, opaque flag and size method.
   The unique ID and size method are needed for the image filter's caching system.
   The opaque flag is need for swapping back & forth from Bitmaps

These are all calved off of https://codereview.chromium.org/1695823002/ (Get OffsetImageFilter really working with SkSpecialImages) which actually makes use of them.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705113002

Review URL: https://codereview.chromium.org/1705113002

8 years agolcd blits for sRGB
reed [Thu, 18 Feb 2016 16:16:33 +0000 (08:16 -0800)]
lcd blits for sRGB

Unimplemented for F16 for the moment, but not needed yet.
Surprisingly not much slower than current impl (not srgb correct)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707883002

Review URL: https://codereview.chromium.org/1707883002

8 years agoPort Skia recipe to normal Python scripts, move to Skia repo
borenet [Thu, 18 Feb 2016 16:05:48 +0000 (08:05 -0800)]
Port Skia recipe to normal Python scripts, move to Skia repo

BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703663002

Review URL: https://codereview.chromium.org/1703663002

8 years agoRemove FuzzPaeth now that we have some real Fuzzes.
mtklein [Thu, 18 Feb 2016 14:58:13 +0000 (06:58 -0800)]
Remove FuzzPaeth now that we have some real Fuzzes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711753002

Review URL: https://codereview.chromium.org/1711753002

8 years agoMake build_command_buffer.py work on Mac and Windows.
bsalomon [Thu, 18 Feb 2016 14:40:55 +0000 (06:40 -0800)]
Make build_command_buffer.py work on Mac and Windows.

Also specify GYP_GENERATORS and add flags to gclient sync to make it more likely to succeed.

BUG=skia:4957
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704193002

Review URL: https://codereview.chromium.org/1704193002

8 years agoCreate ParsePath API fuzz
kjlubick [Thu, 18 Feb 2016 14:27:38 +0000 (06:27 -0800)]
Create ParsePath API fuzz

This is based on https://codereview.chromium.org/1675053002

BUG=skia:4438
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1702383003

Review URL: https://codereview.chromium.org/1702383003

8 years agoremove legacy flags
caryclark [Thu, 18 Feb 2016 14:16:31 +0000 (06:16 -0800)]
remove legacy flags

R=fmalita@chromium.org
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707383002

Review URL: https://codereview.chromium.org/1707383002

8 years agofix asan error deref-ing null ptr
caryclark [Thu, 18 Feb 2016 14:13:25 +0000 (06:13 -0800)]
fix asan error deref-ing null ptr

TBR=tomhudson@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709023002

Review URL: https://codereview.chromium.org/1709023002

8 years agoRemove position from FrontBufferedStream
scroggo [Thu, 18 Feb 2016 13:59:25 +0000 (05:59 -0800)]
Remove position from FrontBufferedStream

When FrontBufferedStream was written, it implemented getPosition()
and returned true for hasPosition(). The CL that introduced it
(crrev.com/23717055) does not have any indication why, but I'm guessing
it was because it was easy to implement. None of our decoders rely on
this (only some tests do).

Now that we have a decoder (SkRawCodec) that expects to be able to seek
a stream if it has a position (which makes sense - SkStream.h
associates that with SkStreamSeekable, and there is no other way to
check to see if a stream is seekable), it is failing because
FrontBufferedStream reports it has a position and the decoder tries to
seek.

Remove FrontBufferedStream::hasPosition() (reverting to the default,
false) and ::getPosition() (so it will return 0).

Fix tests - do not call FrontBufferedStream::getPosition()

Update CodexTest to test using an FrontBufferedStream, like Android
does.

BUG=b/27218441
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703293002

Review URL: https://codereview.chromium.org/1703293002

8 years agoremove legacy bitmap filter
caryclark [Thu, 18 Feb 2016 13:45:33 +0000 (05:45 -0800)]
remove legacy bitmap filter

R=fmalita@chromium.org
BUG=skia:2261
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711683002

Review URL: https://codereview.chromium.org/1711683002

8 years agofix comma in GrAuditTrail json
joshualitt [Thu, 18 Feb 2016 13:04:39 +0000 (05:04 -0800)]
fix comma in GrAuditTrail json

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704133002

Review URL: https://codereview.chromium.org/1704133002

8 years agoadd interp path
caryclark [Thu, 18 Feb 2016 12:11:48 +0000 (04:11 -0800)]
add interp path

Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703943003

Review URL: https://codereview.chromium.org/1703943003

8 years agoAdd bilerp filtering.
herb [Thu, 18 Feb 2016 03:50:05 +0000 (19:50 -0800)]
Add bilerp filtering.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705203002

Review URL: https://codereview.chromium.org/1705203002

8 years agosome modes need clamping due to numerical imprecision
reed [Thu, 18 Feb 2016 02:02:49 +0000 (18:02 -0800)]
some modes need clamping due to numerical imprecision

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710453003

TBR=

Review URL: https://codereview.chromium.org/1710453003