platform/core/csapi/xsf.git
5 years agoImplement grouping for UWP CollectionView (#7697)
E.Z. Hart [Wed, 9 Oct 2019 17:56:18 +0000 (11:56 -0600)]
Implement grouping for UWP CollectionView (#7697)

* Implement grouping for UWP CollectionView

* Clean up CollectionViewSource on teardown

5 years ago[iOS] Fixed crash displaying strings in CarouselView (#7858)
Javier Suárez Ruiz [Wed, 9 Oct 2019 07:52:27 +0000 (09:52 +0200)]
[iOS] Fixed crash displaying strings in CarouselView (#7858)

* Added repro sample

* Fixed the crash on DequeueReusableCell registering the correct cell types

* Added instructions to the test

* Fixed wrong paths on Controls Issues projitems

5 years ago[iOS] Fix issue changing the ItemTemplate on CollectionView dynamically (#7743)
Javier Suárez Ruiz [Tue, 8 Oct 2019 18:06:07 +0000 (20:06 +0200)]
[iOS] Fix issue changing the ItemTemplate on CollectionView dynamically (#7743)

* Fixed Issue 7742: Change CollectionView ItemTemplate programmatically

* Fixed typo

* Removed invalid test

5 years ago[iOS] Alternative proposal for PR 7794 (#7811)
adrianknight89 [Tue, 8 Oct 2019 15:44:49 +0000 (10:44 -0500)]
[iOS] Alternative proposal for PR 7794 (#7811)

* emptyview fix

* fix

* added collectionview flag

* added using for List

* fix formatting

* fix formatting 2

* fix formatting 3

* fixes

* fix test

5 years ago[X] pass the RootAssembly to DT Context (#7853)
Stephane Delcroix [Mon, 7 Oct 2019 14:09:51 +0000 (16:09 +0200)]
[X] pass the RootAssembly to DT Context (#7853)

regression introduced by #7531

- fixes #7830

5 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 7 Oct 2019 09:54:46 +0000 (11:54 +0200)]
Merge branch '4.2.0' into 4.3.0

5 years ago[macOS] Fix Image Rotation issue (#7815) fixes #5395
melimion [Fri, 4 Oct 2019 14:08:45 +0000 (17:08 +0300)]
[macOS] Fix Image Rotation issue (#7815) fixes #5395

* AnchorPoint fix

* rotation and translationY direction fix

* clipping fix

* test added

* anchor point and position translation fixed

* test update

5 years ago[iOS] Fix hard crash when horizontal GridViewLayout is refreshed (#7612) fixes #7593
adrianknight89 [Fri, 4 Oct 2019 00:36:53 +0000 (19:36 -0500)]
[iOS] Fix hard crash when horizontal GridViewLayout is refreshed (#7612) fixes #7593

* fix refreshview issue

* fix path

* remove extra line after rebase

5 years ago[Android] Fix crash changing the Application MainPage (#7776) fixes #7283
Javier Suárez Ruiz [Fri, 4 Oct 2019 00:32:03 +0000 (02:32 +0200)]
[Android] Fix crash changing the Application MainPage (#7776) fixes #7283

* Fixed Issue 7283 - Fix crash changing the Application MainPage

* Update Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs

* Fix build

5 years agoRemove Material Frame Renderer from Frame element on dispose of renderer (#7752)...
Shane Neuville [Thu, 3 Oct 2019 23:20:07 +0000 (17:20 -0600)]
Remove Material Frame Renderer from Frame element on dispose of renderer (#7752) fixes #7339

* [iOS] remove renderer from Frame on dispose

* - add uitests

5 years agoFixed PeekAreaInsets not working on iOS (#7802)
Javier Suárez Ruiz [Thu, 3 Oct 2019 22:47:16 +0000 (00:47 +0200)]
Fixed PeekAreaInsets not working on iOS (#7802)

5 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Thu, 3 Oct 2019 12:35:23 +0000 (13:35 +0100)]
Merge branch '4.2.0' into 4.3.0

5 years agoMerge branch '4.1.0' into 4.2.0
Rui Marinho [Thu, 3 Oct 2019 12:34:25 +0000 (13:34 +0100)]
Merge branch '4.1.0' into 4.2.0

5 years agoRevert "ios: raise touch event on touchbegin. (#6989) fixes #3320" (#7787)
Rui Marinho [Thu, 3 Oct 2019 08:50:00 +0000 (09:50 +0100)]
Revert "ios: raise touch event on touchbegin. (#6989) fixes #3320" (#7787)

This reverts commit dca82ed828e3fc1b3fede8d376ea8c4abf56d4ca.

5 years agoUpdate Build.Locator (#7783)
Rui Marinho [Wed, 2 Oct 2019 19:33:03 +0000 (20:33 +0100)]
Update Build.Locator (#7783)

5 years agoRemove duplicate items
Rui Marinho [Wed, 2 Oct 2019 14:20:44 +0000 (15:20 +0100)]
Remove duplicate items

5 years agoFix merge
Rui Marinho [Wed, 2 Oct 2019 13:42:26 +0000 (14:42 +0100)]
Fix merge

5 years ago[X] send VisualTreeChanged for root (#7747)
Stephane Delcroix [Wed, 2 Oct 2019 13:13:24 +0000 (15:13 +0200)]
[X] send VisualTreeChanged for root (#7747)

5 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Wed, 2 Oct 2019 13:08:09 +0000 (15:08 +0200)]
Merge branch '4.2.0' into 4.3.0

5 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Wed, 2 Oct 2019 13:06:24 +0000 (15:06 +0200)]
Merge branch '4.1.0' into 4.2.0

5 years ago[HR] allow the HR test harness to clear cache (#7774)
Stephane Delcroix [Wed, 2 Oct 2019 12:40:36 +0000 (14:40 +0200)]
[HR] allow the HR test harness to clear cache (#7774)

5 years agoFixed clipping when using FontImageSource (#7607) fixes #6491 fixes #7469 fixes ...
Gerald Versluis [Wed, 2 Oct 2019 07:57:22 +0000 (09:57 +0200)]
Fixed clipping when using FontImageSource (#7607) fixes #6491 fixes #7469 fixes #7414

* Fixed issue

* Fixes #7469

5 years agoFixed crash setting the MainPage on teh OnStart method on UWP (#7749) fixes #7537
Javier Suárez Ruiz [Wed, 2 Oct 2019 07:56:00 +0000 (09:56 +0200)]
Fixed crash setting the MainPage on teh OnStart method on UWP (#7749) fixes #7537

5 years agoNRE fix reported in 7399 (#7704) fixes #7399
kingces95 [Wed, 2 Oct 2019 07:54:12 +0000 (00:54 -0700)]
NRE fix reported in 7399 (#7704) fixes #7399

5 years ago[UWP] Fix crash on Switch Renderer when a custom renderer provides Color objects...
Javier Suárez Ruiz [Wed, 2 Oct 2019 07:53:15 +0000 (09:53 +0200)]
[UWP] Fix crash on Switch Renderer when a custom renderer provides Color objects instead of Brush (#7760) fixes #7253

* Fixed 7253 -  UWP Switch custom Renderer using custom colors throws exception

* Fixed merge error in the code

5 years ago[ControlGallery] Add more CarouselView samples (#7677)
Javier Suárez Ruiz [Wed, 2 Oct 2019 00:20:56 +0000 (02:20 +0200)]
[ControlGallery] Add more CarouselView samples (#7677)

* Added new CarouselView Core Gallery sample

* Fixed typo

5 years agoFix use of ToolbarItem.Order on Android Shell (#7718)
Gerald Versluis [Tue, 1 Oct 2019 17:52:52 +0000 (19:52 +0200)]
Fix use of ToolbarItem.Order on Android Shell (#7718)

fixes #6127

5 years ago[UWP] Make EmptyView work in UWP CarouselView (#7724)
E.Z. Hart [Tue, 1 Oct 2019 16:12:09 +0000 (10:12 -0600)]
[UWP] Make EmptyView work in UWP CarouselView (#7724)

* Make EmptyView work in UWP CarouselView

* Update Xamarin.Forms.Core/Items/CarouselView.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
5 years agoios: raise touch event on touchbegin. (#6989) fixes #3320
v-haroha [Tue, 1 Oct 2019 15:59:59 +0000 (11:59 -0400)]
ios: raise touch event on touchbegin. (#6989) fixes #3320

* ios: raise touch event on touchbegin.

* bugfix - listview highlight on tap, select on tap release
updated touch gester to highlight on Touchbegin and select on touchend. Also remove highlight when tab view is scrolling.

* - fix CI

* - fix CI

5 years ago[Android/iOS] Expose CollectionView scroll listener (#7737)
adrianknight89 [Tue, 1 Oct 2019 15:43:03 +0000 (10:43 -0500)]
[Android/iOS] Expose CollectionView scroll listener (#7737)

* expose scroll listener

* expose ios delegator creation

5 years agoUpdate iOS MDP Tablet Renderer to use current APIS for Master Behavior (#7705) fixes...
Shane Neuville [Tue, 1 Oct 2019 15:35:56 +0000 (09:35 -0600)]
Update iOS MDP Tablet Renderer to use current APIS for Master Behavior (#7705) fixes #7556

* Update iOS MDP Tablet Renderer to current APIS for Master Behavior

* - fix build

5 years agoInvalidate layout on ViewCell if Measurements change (#7755)
Shane Neuville [Tue, 1 Oct 2019 15:21:08 +0000 (09:21 -0600)]
Invalidate layout on ViewCell if Measurements change (#7755)

5 years ago[Android] CarouselView problems updating ObservableCollection (#7693) fixes #7678
Javier Suárez Ruiz [Mon, 30 Sep 2019 18:07:21 +0000 (20:07 +0200)]
[Android] CarouselView problems updating ObservableCollection (#7693) fixes #7678

* Fixed 7678: [Android] CarouselView binded to a new ObservableCollection filled with Items does not render content

* Added test instructions

* Fixed build error

* Updated sample model name

5 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Mon, 30 Sep 2019 01:29:36 +0000 (02:29 +0100)]
Merge branch '4.2.0' into 4.3.0

5 years ago[Android] Fix FlowDirection for Labels (#7614) fixes #7512
adrianknight89 [Mon, 30 Sep 2019 00:56:22 +0000 (19:56 -0500)]
[Android] Fix FlowDirection for Labels (#7614) fixes #7512

* fix textview flow direction

* removed Details from model

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7512.xaml.cs

Co-Authored-By: Rui Marinho <me@ruimarinho.net>
5 years ago[Android] Remove ripple effect on CollectionView item when SelectionMode is None...
adrianknight89 [Sun, 29 Sep 2019 21:41:35 +0000 (16:41 -0500)]
[Android] Remove ripple effect on CollectionView item when SelectionMode is None (#7615)

* fix ripple effect

* revert changes in core

5 years agoHandle case where GetRenderer retuns null (#7566) Fixes #7563
Stuart Lang [Sun, 29 Sep 2019 21:01:37 +0000 (22:01 +0100)]
Handle case where GetRenderer retuns null (#7566)  Fixes #7563

5 years ago[Android/iOS] Handle dynamically switching between item layouts in CollectionView...
adrianknight89 [Sat, 28 Sep 2019 23:50:22 +0000 (18:50 -0500)]
[Android/iOS] Handle dynamically switching between item layouts in CollectionView (#7613) fixes #5354

* switch between item layouts

* drop private

* added ui test

5 years agoUWP fixes for lower target sdk on VS 2017 (#7722)
Shane Neuville [Sat, 28 Sep 2019 23:42:14 +0000 (17:42 -0600)]
UWP fixes for lower target sdk on VS 2017 (#7722)

* Set UWP to lower target framework

* - mono version

* - dotnet core

* - dotnet core

* - dotnet core

* - mono

* - remove sdks

* - new sdk for mac targets

* - mono path

* - fix mono version

* - update unit test

5 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Sat, 28 Sep 2019 01:27:54 +0000 (02:27 +0100)]
Merge branch '4.2.0' into 4.3.0

5 years agoSetup public and provisionator based provisioning of SDKS (#7458)
Shane Neuville [Sat, 28 Sep 2019 01:01:00 +0000 (19:01 -0600)]
Setup public and provisionator based provisioning of SDKS (#7458)

* general provisioning

* - remove android

* - add android in

* - split up provisioning

* Update build.cake

* - increment versions

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* - fix android

* - version

* - fix varialbes

* - NUGET_VERSION

* - set on parameters

* - fix parameters

* - nuget build step

* - fix powershell

* - merge UI Test fixes in

* - squash

* - cleanup provisionator

* - fix missing names

* - simplify

* - simplify

* - provisionator

* - provisionator

* JavaSDK build path hack

* - turn off default provisioning

* - windows image

* - remove sdk installs from cake

* - sdk manager installs

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* - conditional core

* - conditional core

* - change to conditions

* - make the same

* - add better naming

* - sdks

* - user better links

5 years ago[Android] Fixed issue changing the ItemTemplate on CarouselView (#7628) fixes #7395
Javier Suárez Ruiz [Fri, 27 Sep 2019 22:06:53 +0000 (00:06 +0200)]
[Android] Fixed issue changing the ItemTemplate on CarouselView (#7628) fixes #7395

* Fixed Issue 7395 - Changing ItemTemplate does not work as expected (Android)

* Added instructions to Issue7395

* Updated Core Gallery sample (instructions)

5 years agoFix NRE for 7301 (#7706)
kingces95 [Fri, 27 Sep 2019 20:28:46 +0000 (10:28 -1000)]
Fix NRE for 7301 (#7706)

5 years ago[UWP] Reduce allocations and fix memory leak in CollectionView (#7608)
E.Z. Hart [Fri, 27 Sep 2019 17:41:04 +0000 (11:41 -0600)]
[UWP] Reduce allocations and fix memory leak in CollectionView (#7608)

* Checkpoint

* Fix leak caused by CollectionViewSource

* Simplify ItemTemplateEnumerator

* Reduce allocations in simple IList source scenarios on UWP

* Revert debugging changes

5 years agoFix binding on test page to remove IsDragging errors
E.Z. Hart [Fri, 27 Sep 2019 15:56:42 +0000 (09:56 -0600)]
Fix binding on test page to remove IsDragging errors

5 years agoWait for test to load before scrolling images (#7702)
Shane Neuville [Fri, 27 Sep 2019 15:23:13 +0000 (09:23 -0600)]
Wait for test to load before scrolling images (#7702)

5 years ago[X] Pass the current assembly to parsing context (#7550)
Stephane Delcroix [Fri, 27 Sep 2019 05:59:52 +0000 (07:59 +0200)]
[X] Pass the current assembly to parsing context (#7550)

In case of Xaml-only RD, the rootAssembly is different from the assembly
of the rootType

- fixes #7531

5 years ago[RefreshView] Fire RefreshCommand setting IsRefreshing (#7398)
Javier Suárez Ruiz [Fri, 27 Sep 2019 05:19:12 +0000 (07:19 +0200)]
[RefreshView] Fire RefreshCommand setting IsRefreshing (#7398)

* refresh view ui tests

* Fixed issue notifying changes in IsRefreshing property

* Fire RefreshCommand setting IsRefreshing to true

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

* Update Xamarin.Forms.Core.UITests.Shared/UITestCategories.cs

* Added RefreshView UITests

* - ui test with swipe

* - change to drag

* - fix ui test

* - remove extra property changed event

5 years ago[Android] 28+ Make non-visible pickers work again (#7289)
Gerald Versluis [Fri, 27 Sep 2019 05:18:17 +0000 (22:18 -0700)]
[Android] 28+ Make non-visible pickers work again (#7289)

* Repro + fix

* Final fix

* Update Issue5159.cs

* Fixes #7311

* Test tweaks

* Update TimePickerRenderer.cs

* Revert "Update TimePickerRenderer.cs"

This reverts commit 06c1172d2501ec533cdf5b1eabafa1d402687980.

* Update TimePickerRenderer.cs

* Update TimePickerRenderer.cs

* - added instructions

5 years agoMerge branch '4.2.0' into 4.3.0
Samantha Houts [Fri, 27 Sep 2019 00:23:42 +0000 (17:23 -0700)]
Merge branch '4.2.0' into 4.3.0

5 years agoJavaSDK build path hack (#7707)
Shane Neuville [Fri, 27 Sep 2019 00:16:10 +0000 (18:16 -0600)]
JavaSDK build path hack (#7707)

5 years ago[iOS] Fix MeasureFirstItem for CollectionView (#7622)
adrianknight89 [Fri, 27 Sep 2019 00:16:03 +0000 (19:16 -0500)]
[iOS] Fix MeasureFirstItem for CollectionView (#7622)

* fix MeasureFirstItem

* added test

* changed file name

* fix path

* added text

* remove 5455

* drop private
fixes #7621

5 years ago[BUG/iOS] Fixed CollectionView Insets ItemSpacing (#7158)
Gerald Versluis [Thu, 26 Sep 2019 17:23:41 +0000 (10:23 -0700)]
[BUG/iOS] Fixed CollectionView Insets ItemSpacing (#7158)

* Fix 7035

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* Update ItemsViewLayout.cs

* Update test case to show span issue

* Update AppDelegate.cs

Remove test setting

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* Update Issue7035.xaml

5 years agofix android foreground tinting (#7682) fixes #7577
Shane Neuville [Thu, 26 Sep 2019 09:29:32 +0000 (03:29 -0600)]
fix android foreground tinting (#7682) fixes #7577

5 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Thu, 26 Sep 2019 09:12:54 +0000 (10:12 +0100)]
Merge branch '4.2.0' into 4.3.0

5 years agofix android apk path for ui tests (#7657)
Shane Neuville [Wed, 25 Sep 2019 16:49:26 +0000 (10:49 -0600)]
fix android apk path for ui tests (#7657)

5 years agoonly set elevation on Lollipop and up (#7662)
Shane Neuville [Wed, 25 Sep 2019 14:43:20 +0000 (08:43 -0600)]
only set elevation on Lollipop and up (#7662)

5 years agoTry catch Update Bitmap and equate null to empty for FontFamily Check (#7611) fixes...
Shane Neuville [Wed, 25 Sep 2019 00:35:33 +0000 (18:35 -0600)]
Try catch Update Bitmap and equate null to empty for FontFamily Check (#7611) fixes #7598 fixes #7597

5 years ago[iOS] Make button click easier to see when turning on CollectionView flag (#7617)
adrianknight89 [Tue, 24 Sep 2019 21:39:57 +0000 (16:39 -0500)]
[iOS] Make button click easier to see when turning on CollectionView flag (#7617)

* make button click easier to see

* remove private

* changed event handler name

5 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Tue, 24 Sep 2019 08:18:06 +0000 (10:18 +0200)]
Merge branch '4.2.0' into 4.3.0

5 years agoset android app to not clear data on restart (#7640)
Shane Neuville [Tue, 24 Sep 2019 00:32:55 +0000 (18:32 -0600)]
set android app to not clear data on restart (#7640)

5 years ago[Mac] Fix NRE on setting non-existing FontFamily (#7636) fixes #7582
Gerald Versluis [Mon, 23 Sep 2019 23:04:24 +0000 (01:04 +0200)]
[Mac] Fix NRE on setting non-existing FontFamily (#7636) fixes #7582

* Update FontExtensions.cs

* Added issue to gallery

5 years ago[iOS,Android] Better way to get CurrentItem (#7587)
Rui Marinho [Mon, 23 Sep 2019 23:02:47 +0000 (00:02 +0100)]
[iOS,Android] Better way to get CurrentItem  (#7587)

* [iOS] Fix finding center cell

* [UITests] Fix drag on vertical  

* [UItests] Make uitest more reliable

* [iOS] Simplify set current item

* [Android] Use scrolled to get CurrentItem

* [UITests] Fix UItests on api19 android

* [Android] Fix merge

5 years agoAdd retry logic for IsFocus test (#7619)
Shane Neuville [Mon, 23 Sep 2019 20:36:34 +0000 (14:36 -0600)]
Add retry logic for IsFocus test (#7619)

5 years ago[CarouselView] Fix CarouselView initial position on Android (#7592)
Javier Suárez Ruiz [Mon, 23 Sep 2019 06:17:44 +0000 (08:17 +0200)]
[CarouselView] Fix CarouselView initial position on Android (#7592)

* Fixed Android CarouselView initial position issue

5 years agoFinish ScrollTo implementations for CollectionView on UWP (#7509) partially implement...
E.Z. Hart [Fri, 20 Sep 2019 22:03:55 +0000 (16:03 -0600)]
Finish ScrollTo implementations for CollectionView on UWP (#7509) partially implements #3172

* Finish ScrollTo implementations for CollectionView on UWP

* Fix NRE when attempting to scroll to index greater than source length

5 years agoMake sure transition from empty CollectionView measures cell size; fixes #7472 (...
E.Z. Hart [Fri, 20 Sep 2019 17:37:15 +0000 (11:37 -0600)]
Make sure transition from empty CollectionView measures cell size; fixes #7472 (#7580)

fixes #7472
fixes #7548

5 years ago[Android] Fix ItemSpacing for last item in CollectionView (#7516)
adrianknight89 [Fri, 20 Sep 2019 16:57:05 +0000 (11:57 -0500)]
[Android] Fix ItemSpacing for last item in CollectionView (#7516)

* fix item spacing

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
5 years ago[X] do not fail on generic BP (#7588)
Stephane Delcroix [Thu, 19 Sep 2019 13:58:29 +0000 (15:58 +0200)]
[X] do not fail on generic BP (#7588)

While looking for a potential TypeConverter attribute on the static getter of a
generic attached BP, resolve the generic return type.

- fixes #7559

5 years ago[C] Fix TemplateBinding for non-logicalchildren (#7506)
Stephane Delcroix [Thu, 19 Sep 2019 10:33:32 +0000 (12:33 +0200)]
[C] Fix TemplateBinding for non-logicalchildren (#7506)

Spans, e.g., are no LogicalChildren of FormattedString, which is not a
LogicalChildren of Label. The newly introduced way of propagating the
TemplatedParent was top-down, using LogicalChildren, was not assigning
the correct TemplatedParent on Spans.

This reverts to a bottom-up lookup, hooking on ParentSet, like it used to
be.

As a side effect, the TemplateBindings are no longer updated on reparenting,
but this was the original behavior, and I can't think of a case where this
would be needed.

The regression to `{TemplateBinding}` was introduced by #4375.

- fixes #7494

5 years ago[X] avoid throwing in VisualDiagnostics (#7571)
Stephane Delcroix [Wed, 18 Sep 2019 14:41:18 +0000 (16:41 +0200)]
[X] avoid throwing in VisualDiagnostics (#7571)

this fixes a regression introduced in #7474

- fixes #7570

5 years agoremoved MatchParent value from Property Editor (#7551)
Pavel Yakovlev [Tue, 17 Sep 2019 22:50:33 +0000 (01:50 +0300)]
removed MatchParent value from Property Editor (#7551)

5 years ago[C] added intellisense for Keyboard property (#7553) fixes azdo 835646
Pavel Yakovlev [Tue, 17 Sep 2019 22:35:37 +0000 (01:35 +0300)]
[C] added intellisense for Keyboard property (#7553) fixes azdo 835646

5 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Tue, 17 Sep 2019 22:30:30 +0000 (23:30 +0100)]
Merge branch '4.2.0' into 4.3.0

5 years agoAdds UWP support to Shell (#6015)
Morten Nielsen [Tue, 17 Sep 2019 22:26:56 +0000 (15:26 -0700)]
Adds UWP support to Shell (#6015)

* Some basics to get started

* more renderers

* Fix titlebar color

* More shell stuff working

* Hacked some more UI in

* Fix null ref issue

* Move renderer registration outside common code (for now)

* Re-write of the renderers to better use a cleaner UWP approach

* Moved functionality around, bug fixesetc

* Added null check

* Added null-check on appearance and use default colors as fallback

* Handle change in flyout behavior to correctly turn the flyout on/off

* Handle the TabBarIsVisible property

* code formatting

* Ensure FlyoutHeader isn't show if the app starts up with a minimal pane

*  Throw if used on versions lower than Windows 10 1809

* Added null-check for when ShellContent isn't set

* Support tabs in FlyoutItems with Display AsMultipleItems by using the generated FlyoutGroupings instead

* Improve pane behavior and styling

* Undo Android change used during testing

* Fix platform support check

* Use FileImageSourcePathConverter on NavigationViewItem instead of a custom control (so I deleted ShellNavigationViewItemRenderer which is no longer needed).
Ensure `FileImageSourcePathConverter` won't throw if it didn't get a FileImageSource.
Move the flyout data templates into a resource so they can be overridden and compiled.

* Delete renamed file

* Use a resource instead of parsing a string template

* Handle search box property changes

* Update page title on property change

* Update bottombar when shellitems change

* Guard against API usage not present

* Platform check comments

* Fix problem running in release mode (use Bindable to generate XamlMetadata

* Trigger rebind of menu items source when collection changes

* Added support for Toolbar

* Fix searchbox behavior (still lacks expand/collapse feature)

* Add overload for defining the navigation transition

* Use different navigation transitions based on navigatin direction

* Hides header with show / hide nav command

* collapses header area on hide nav

* Move to use WinUI

* Fix runtime issues after merge.

* - rebase fixes

* - rebase fixes

* - fix spaces/tabs

* - flags, hide apis, delete assembly info

* - set flag on UWP CG

* - expose renderer creations and make them all public

* - formatting fixes

* - address PR comments

* - fix header so it's full width and swappable

5 years agoAdditional proguard classes (#7527) fixes #5742
Shane Neuville [Tue, 17 Sep 2019 22:12:16 +0000 (16:12 -0600)]
Additional proguard classes (#7527) fixes #5742

5 years ago[macOS] PushModalAsync a 2nd time causes a crash (#7250) fixes #6866
Andrei [Tue, 17 Sep 2019 21:40:21 +0000 (00:40 +0300)]
[macOS] PushModalAsync a 2nd time causes a crash (#7250) fixes #6866

* fixes https://github.com/xamarin/Xamarin.Forms/issues/6866

* fixed index boundaries to include 0 index

5 years agoImplement CarouselView on UWP (#7503)
Javier Suárez Ruiz [Tue, 17 Sep 2019 20:33:55 +0000 (22:33 +0200)]
Implement CarouselView on UWP (#7503)

* Implemented CarouselView on UWP

* Implemented CurrentItem on Carousel UWP

* Fixed ArgumentOutOfRangeException with the Carousel position

* Removed code to update the CurrentItem on UWP (review it to improve)

5 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Tue, 17 Sep 2019 20:31:01 +0000 (21:31 +0100)]
Merge branch '4.2.0' into 4.3.0

5 years agoCheck to see if the BeginRefresh request is no longer needed (#7514) fixes #7313
Shane Neuville [Tue, 17 Sep 2019 15:46:55 +0000 (09:46 -0600)]
Check to see if the BeginRefresh request is no longer needed (#7514) fixes #7313

* fix refresh to not fire twice

* - add automated ui test

5 years ago[Android] Refactor the code for setting reverse layout in ItemsViewRenderer (#7468)
adrianknight89 [Tue, 17 Sep 2019 12:42:36 +0000 (07:42 -0500)]
[Android] Refactor the code for setting reverse layout in ItemsViewRenderer (#7468)

* refactor

* fix

* remove the return keyword

5 years ago[Android/iOS] Update CollectionView when user changes out the header/footer (#7499)
Shane Neuville [Tue, 17 Sep 2019 09:32:57 +0000 (03:32 -0600)]
[Android/iOS] Update CollectionView when user changes out the header/footer (#7499)

* update cv when user changes out the header/footer

* - fix android to convert back from pixels on scroll
- fix iOS offset on scroll args to account for header size and content inset

* - fix for new api

* - fix redundant BP

5 years agoAdd null check when using tablet on MDP (#7513) fixes #7496
Shane Neuville [Tue, 17 Sep 2019 08:56:36 +0000 (02:56 -0600)]
Add null check when using tablet on MDP (#7513) fixes #7496

5 years agoRemove extra brace; fixes #7545 (#7546)
E.Z. Hart [Tue, 17 Sep 2019 08:41:00 +0000 (02:41 -0600)]
Remove extra brace; fixes #7545 (#7546)

5 years ago[iOS] Remove class variable from CarouselViewLayout whose value is always true (...
adrianknight89 [Tue, 17 Sep 2019 08:38:48 +0000 (03:38 -0500)]
[iOS] Remove class variable from CarouselViewLayout whose value is always true (#7484)

* remove unused variable

* comment change

5 years agoupdate unit test to nunit3 apis (#7543)
Shane Neuville [Tue, 17 Sep 2019 01:26:30 +0000 (19:26 -0600)]
update unit test to nunit3 apis (#7543)

5 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Tue, 17 Sep 2019 00:10:13 +0000 (01:10 +0100)]
Merge branch '4.2.0' into 4.3.0

5 years agoawait tasks on ViewUnitTests and update MSBuild Locator (#7542)
Shane Neuville [Mon, 16 Sep 2019 22:10:15 +0000 (16:10 -0600)]
await tasks on ViewUnitTests and update MSBuild Locator (#7542)

5 years ago[macOS] Only use default font size for Time/DatePicker to avoid clipping issues ...
Konrad Müller [Mon, 16 Sep 2019 21:06:49 +0000 (23:06 +0200)]
[macOS] Only use default font size for Time/DatePicker to avoid clipping issues (#7183)

* Only use default font size

* Always use default font size

* Remove duplicated code

* Remove extra spacing

5 years agoTweak unit test so it's more reliable and fix binlog path (#7530)
Shane Neuville [Mon, 16 Sep 2019 15:48:52 +0000 (09:48 -0600)]
Tweak unit test so it's more reliable and fix binlog path (#7530)

* tweak unit test and fix bl path

* - change test to use ThrowsAsync

* - fix for nunit 2

5 years agoFix horizontal layout issues introduced in 7456; fixes #7519 fixes #7524 (#7522)
E.Z. Hart [Mon, 16 Sep 2019 14:23:55 +0000 (08:23 -0600)]
Fix horizontal layout issues introduced in 7456; fixes #7519 fixes #7524 (#7522)

5 years agoImplement EmptyView on UWP (#7438)
E.Z. Hart [Mon, 16 Sep 2019 13:02:58 +0000 (07:02 -0600)]
Implement EmptyView on UWP (#7438)

5 years agoAdded Carousel SnapBehavior Core sample (#7444)
Javier Suárez Ruiz [Mon, 16 Sep 2019 12:13:07 +0000 (14:13 +0200)]
Added Carousel SnapBehavior Core sample (#7444)

5 years agomerge 4.2.0 into 4.3.0
ShaneN [Sun, 15 Sep 2019 00:52:56 +0000 (18:52 -0600)]
merge 4.2.0 into 4.3.0

5 years agoCheck if Control is ready before interacting with Native control (#7523)
Shane Neuville [Sun, 15 Sep 2019 00:40:55 +0000 (18:40 -0600)]
Check if Control is ready before interacting with Native control (#7523)

* Check if control is ready before setting Text

* - make 7.0 compatible

5 years agoRemove extra properties from CarouselView API (#7456)
E.Z. Hart [Fri, 13 Sep 2019 09:55:27 +0000 (03:55 -0600)]
Remove extra properties from CarouselView API (#7456)

* Remove Header/Footer properties from CarouselView

* Limit CarouselView to LinearItemsLayout

* Rework inheritance for UWP

* Split files by class

* Fix up Tizen renderer

5 years agoMerge branch '4.2.0' into 4.3.0
Samantha Houts [Thu, 12 Sep 2019 22:55:09 +0000 (15:55 -0700)]
Merge branch '4.2.0' into 4.3.0

5 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Thu, 12 Sep 2019 22:52:45 +0000 (15:52 -0700)]
Merge branch '4.1.0' into 4.2.0

5 years ago[xamlc] new <XFXamlCValidateOnly> MSBuild property for Debug builds (#7407)
Jonathan Peppers [Thu, 12 Sep 2019 22:36:35 +0000 (17:36 -0500)]
[xamlc] new <XFXamlCValidateOnly> MSBuild property for Debug builds (#7407)

XamlC is currently enabled for most Xamarin.Forms projects in `Debug`
and `Release` configurations. It enables faster startup/runtime
performance, XAML-syntax checking at build time--both quiet useful!

However, there is a build-time cost to using XamlC: each assembly is
loaded via Mono.Cecil, IL generated, and saved back to disk as an
additional step after Rosyln has compiled the assembly.

The proposal would be to add a new experimental MSBuild property, that
can be enabled for `Debug` mode such as:

    <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
      <!-- ... -->
      <XFXamlCValidateOnly>True</XFXamlCValidateOnly>
    </PropertyGroup>

This would do the following:

* `OptimizeIL` is skipped.
* Assemblies are analyzed, but no changes written to disk.
* No symbols are loaded via Mono.Cecil, we don't need them if we
  aren't writing back to disk!

This will improve build performance, and we don't lose the build-time
error checking for XAML.

Down the road, we could consider moving the MSBuild property to be the
default for `Debug` builds or change the Xamarin templates. I think it
would be wise to require developers to opt-in to try this out.

~~ Results ~~

I tested this change by building the ControlGallery after changing one
line of XAML:

    msbuild Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj /clp:performancesummary /p:XFXamlCValidateOnly=True

    Before:
    1979 ms  XamlCTask                                  1 calls
    After:
     923 ms  XamlCTask                                  1 calls

I *only* tested `Debug` builds.

Right, so it's faster. But let's keep the entire developer loop in
mind, how much slower is startup?

    Before:
    09-05 14:37:32.274  1169  1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s890ms
    09-05 14:38:30.178  1169  1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s848ms
    09-05 14:38:40.300  1169  1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s848ms
    After:
    09-05 14:40:38.512  1169  1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s894ms
    09-05 14:40:55.497  1169  1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s856ms
    09-05 14:41:03.754  1169  1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s897ms

After three runs, it seems this app suffers 25-50ms slowdown to
startup, and gains 1 second of build time improvement. A good net-win!

Other apps that have significantly more XAML will have different
results. I suspect the build time improvement will be even better, but
the hit to startup could be worse. With this setting opt-in, we can
experiment and find out.

5 years agoWarn on Styles validation instead of throwing exception (#7495)
Mahmoud Ali [Thu, 12 Sep 2019 22:36:02 +0000 (19:36 -0300)]
Warn on Styles validation instead of throwing exception (#7495)

* Warn on Styles validation instead of throwing exception

* Correct tests
fixes #6907