ap@apple.com [Wed, 14 Mar 2012 20:59:53 +0000 (20:59 +0000)]
WebProcess sometimes hits an assertion in SandboxExtensionTracker::didCommitProvisionalLoad after running regression tests
https://bugs.webkit.org/show_bug.cgi?id=81150
<rdar://problem/
11002254>
Reviewed by Anders Carlsson.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
It's not great, but for now we need to handle this case. Hopefully, some day we'll make
both WebKit2 processes better aware of what's going on with loading in WebCore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 20:57:36 +0000 (20:57 +0000)]
Clean up a few more baseline.
* platform/chromium-mac-snowleopard/css2.1/
20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates: Removed.
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 14 Mar 2012 20:52:42 +0000 (20:52 +0000)]
[Chromium] Layout Test compositing/repaint/opacity-between-absolute.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=79823
Reviewed by Adrienne Walker.
Source/WebCore:
LayerRendererChromium was storing a weak pointer to the current render surface in m_currentRenderSurface and
using this in useRenderSurface() to avoid rebinding if we called useRenderSurface() multiple times in a row on
the same surface. This pointer was never cleared, so if any subsequent surface landed at the same address this
caching would misbehave and we'd fail to correctly initialize the new render surface. The caching wasn't
actually buying us anything anyway since we only call useRenderSurface() once per surface per frame and we
always set the viewport for the default render surface.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 20:38:09 +0000 (20:38 +0000)]
WKTR doesn't have an implemenation of hasSpellingMarker yet.
Add more tests that rely on it to the WK2 Skipped list.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 14 Mar 2012 20:30:16 +0000 (20:30 +0000)]
Add the chromium lion bot to garden-o-matic and remove
the platform_move_to in builders.py since the Chromium Lion
port is now a normal port.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* Scripts/webkitpy/layout_tests/port/builders.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 20:22:55 +0000 (20:22 +0000)]
Frame flattening ASSERT(!needsLayout()) in FrameView::paintContents()
https://bugs.webkit.org/show_bug.cgi?id=80155
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.
Source/WebCore:
This patch ensures that an iframe only schedules and calls parent's layout,
when it is going to be flattened. Non-flattened iframe does not affect
parent's layout, so normal layout flow applies. isInSubframeLayoutWithFrameFlattening()
function has been added to test whether a particular child frame is changing
parent's layout. This function also ensures that scheduleRelayout() and layout()
are in sync of checking againts frame flattening.
Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html
* page/FrameView.cpp:
(WebCore::FrameView::avoidScrollbarCreation):
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
* page/FrameView.h:
(FrameView):
* rendering/RenderIFrame.h:
(RenderIFrame):
(WebCore::RenderIFrame::renderName):
LayoutTests:
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout-expected.txt: Added.
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Mar 2012 20:07:42 +0000 (20:07 +0000)]
Don't cap the scroll position if layout happens when a FrameView's overhangAmount is non-zero
https://bugs.webkit.org/show_bug.cgi?id=81146
<rdar://problem/
10850075>
Reviewed by Beth Dakin.
If layout happens when a page has a non-zero overhang amount, we shouldn't cap the scroll position
to be inside of the valid maximum/minimum scroll offsets because that will cause the page to jump back, which
can look really bad if layout happens in response to the page being scrolled.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 14 Mar 2012 19:58:02 +0000 (19:58 +0000)]
Add Lion failures in order to green the lion bot.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tommyw@google.com [Wed, 14 Mar 2012 19:53:23 +0000 (19:53 +0000)]
MediaStream API (JSEP): Introducing IceCandidate
https://bugs.webkit.org/show_bug.cgi?id=80699
Reviewed by Adam Barth.
Patch #2 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Adding the JS object IceCandidate and its WebCore/platform sibling IceCandidateDescriptor.
This object will be created both from JS and the embedder.
Not possible to test until the entire JSEP feature is commited.
* GNUmakefile.list.am:
* Modules/mediastream/IceCandidate.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::IceCandidate::create):
(WebCore::IceCandidate::IceCandidate):
(WebCore::IceCandidate::~IceCandidate):
(WebCore::IceCandidate::label):
(WebCore::IceCandidate::candidateLine):
(WebCore::IceCandidate::toSdp):
(WebCore::IceCandidate::descriptor):
* Modules/mediastream/IceCandidate.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(IceCandidate):
* Modules/mediastream/IceCandidate.idl: Added.
* WebCore.gypi:
* platform/mediastream/IceCandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::IceCandidateDescriptor::create):
(WebCore::IceCandidateDescriptor::IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::~IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::toSdp):
* platform/mediastream/IceCandidateDescriptor.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::label):
(WebCore::IceCandidateDescriptor::candidateLine):
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::constructSdp):
(WebCore):
* platform/mediastream/MediaStreamCenter.h:
(WebCore):
(MediaStreamCenter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 14 Mar 2012 19:51:26 +0000 (19:51 +0000)]
Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
Unreviewed, build fix.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.skipped_tests):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 14 Mar 2012 19:50:28 +0000 (19:50 +0000)]
background-visibility:hidden should create a RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=81134
Source/WebCore:
Reviewed by Dean Jackson.
Background-visibility:hidden has to create RenderLayers, because it's implemented
via compositing and/or paint short-circuiting in RenderLayer code.
Test: transforms/3d/general/background-visibility-layers.html
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasHiddenBackface):
* rendering/RenderTableRow.h:
LayoutTests:
Reviewed by Dean Jackson.
Test for background-visibility: hidden making a RenderLayer.
* transforms/3d/general/background-visibility-layers-actual.png: Added.
* transforms/3d/general/background-visibility-layers-actual.txt: Added.
* transforms/3d/general/background-visibility-layers.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 19:48:06 +0000 (19:48 +0000)]
[CSSRegions][CSSOM] Implement regionLayoutEvent
https://bugs.webkit.org/show_bug.cgi?id=78882
Patch by Raul Hudea <rhudea@adobe.com> on 2012-03-14
Reviewed by David Hyatt.
Source/WebCore:
Adding the regionLayoutEvent that is dispatch for all regions after each flow-thread layout.
Tests: fast/regions/region-event-add-to-flow.html
fast/regions/region-event-remove-from-dom.html
fast/regions/region-event-remove-from-flow.html
fast/regions/region-event.html
* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Added check for regionLayoutUpdate listeners
* dom/Document.h:
* dom/EventNames.h:
(WebCore):
* dom/Node.cpp:
(WebCore::Node::dispatchRegionLayoutUpdateEvent):
(WebCore):
* dom/Node.h:
(Node):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout): Start the event dispatch timer but only if there are regionLayoutUpdate listeners and there is at least one region that had its layout updated.
(WebCore::RenderFlowThread::computeOverflowStateForRegions): Mark regions that might had a layout update
(WebCore::RenderFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setDispatchRegionLayoutUpdateEvent):
(WebCore::RenderRegion::shouldDispatchRegionLayoutUpdateEvent):
(RenderRegion):
LayoutTests:
* fast/regions/region-event-add-to-flow-expected.txt: Added.
* fast/regions/region-event-add-to-flow.html: Added.
* fast/regions/region-event-expected.txt: Added.
* fast/regions/region-event-remove-from-dom-expected.txt: Added.
* fast/regions/region-event-remove-from-dom.html: Added.
* fast/regions/region-event-remove-from-flow-expected.txt: Added.
* fast/regions/region-event-remove-from-flow.html: Added.
* fast/regions/region-event.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Wed, 14 Mar 2012 19:45:31 +0000 (19:45 +0000)]
[Qt] Add support for vertical sliders in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=80179
This makes sliders using the "slider-vertical" appearance more sensible.
Reviewed by Simon Hausmann.
No new tests, since the mobile theme still isn't used in layout tests.
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
* platform/qt/RenderThemeQtMobile.h:
(StylePainterMobile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 14 Mar 2012 19:30:54 +0000 (19:30 +0000)]
Rebaseline chromium-lion tests that have "MISSING" results.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Mar 2012 19:26:11 +0000 (19:26 +0000)]
Fix UI process crash when a plug-in process crashes with a modal dialog showing
https://bugs.webkit.org/show_bug.cgi?id=81139
<rdar://problem/9641197>
Reviewed by Dan Bernstein.
When a plug-in process crashes, its corresponding PluginProcessProxy object is deleted immediately,
which is bad if we're currently running a nested run loop.
Fix this by making PluginProcessProxy ref-counted and protecting it before the call to -[NSApp runModalForWindow:].
* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::pluginProcessWithPath):
(WebKit::PluginProcessManager::getOrCreatePluginProcess):
* UIProcess/Plugins/PluginProcessManager.h:
(PluginProcessManager):
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::create):
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
* UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::setModalWindowIsShowing):
(WebKit::PluginProcessProxy::beginModal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 14 Mar 2012 19:24:19 +0000 (19:24 +0000)]
WebProcess spins beneath [QTMovie movieFileTypes:]
https://bugs.webkit.org/show_bug.cgi?id=81133
Reviewed by Eric Carlson.
No new tests; speculative fix for top WebProcess spin.
When checking to see if a given mime type is supported by QuickTime,
immediately exclude all types that do not begin with 'audio/' or 'video/'.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::supportsType):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 14 Mar 2012 19:10:47 +0000 (19:10 +0000)]
Update SVG baseline after work on <use> element. These results all
seem to be minor differences or progressions.
* platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.txt: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 14 Mar 2012 18:55:58 +0000 (18:55 +0000)]
Please add a way to manually skip some tests in NRWT
https://bugs.webkit.org/show_bug.cgi?id=81019
Reviewed by Ojan Vafai.
This patch implements the -i / --ignore-tests flag from ORWT
and refactors the test_expectations.py code slightly to handle
it.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.parse_expectations):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.__init__):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_add_skipped_tests):
(test_add_skipped_tests_duplicate):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_ignore_tests):
(MainTest.test_ignore_tests.assert_ignored):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 14 Mar 2012 18:53:34 +0000 (18:53 +0000)]
nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
https://bugs.webkit.org/show_bug.cgi?id=81028
Reviewed by Ojan Vafai.
The mac port had incorrect lookups for 'mac-lion' and
'mac-future' in some places. This patch fixes that and adds a
bunch of tests.
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.baseline_path):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest.assert_skipped_file_search_paths):
(MacTest.test_skipped_file_search_paths):
(_assert_search_path):
(test_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_file_search_paths):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 18:37:37 +0000 (18:37 +0000)]
WK2: Spelling tests that rely on getting the marked range or the marked count synchronously fail
https://bugs.webkit.org/show_bug.cgi?id=81138
Add some expected failing results for such tests to get the bots green.
* platform/mac-wk2/editing/spelling/markers-expected.txt: Added.
* platform/mac-wk2/editing/spelling/spelling-insert-html-expected.txt: Added.
* platform/mac-wk2/editing/spelling/spelling-unified-emulation-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 14 Mar 2012 18:33:16 +0000 (18:33 +0000)]
[Chromium] Unreviewed, remove expectations for non-crashing tests
https://bugs.webkit.org/show_bug.cgi?id=78038
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 18:29:32 +0000 (18:29 +0000)]
Make RenderIFrame::flattenFrame() return earlier, when frame flattening is disabled.
https://bugs.webkit.org/show_bug.cgi?id=80301
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.
Reorganize RenderIFrame flattenFrame() code, so that it returns
earlier for the normal use case, when frame flattening is disabled.
It also removes leftover null check.
No new tests, since there's no new functionality.
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 14 Mar 2012 18:12:29 +0000 (18:12 +0000)]
[chromium] Provide explicit polling API to check if the platform is capable of accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=80667
Reviewed by Darin Fisher.
Source/WebCore:
Query the platform to see if we can instantiate a context suitable for accelerating 2d canvas. If we can't, for
instance if we're on a system that can't preserve a context when the screensaver comes up, then immediately fall
back to software.
Covered by canvas layout tests in the virtual-gpu mode.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::shouldAccelerate):
* platform/chromium/PlatformSupport.h:
Source/WebKit/chromium:
* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::canAccelerate2dCanvas):
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::canAccelerate2dCanvas):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 18:03:01 +0000 (18:03 +0000)]
Support drag in mouse events for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68552
https://bugs.webkit.org/show_bug.cgi?id=69946
Add some tests that use eventSender.dragMode to the WK2 Skipped list.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 14 Mar 2012 17:56:59 +0000 (17:56 +0000)]
[GTK] Handle printing errors in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=77197
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
* platform/gtk/ErrorsGtk.cpp:
(WebCore::printError): Create a generic print error.
(WebCore::printerNotFoundError): Create a print error to notify
that the selected printer could not be found.
(WebCore::invalidPageRangeToPrint): Create a print error when the
selected page range is invalid and there are no pages to print.
* platform/gtk/ErrorsGtk.h:
(WebCore): Add print error doamin.
Source/WebKit2:
* UIProcess/API/gtk/WebKitError.cpp:
(webkit_print_error_quark): Add new error domain for print
errors.
* UIProcess/API/gtk/WebKitError.h: Ad print errors.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkit_print_operation_class_init): Add
WebKitPrintOperation::failed signal.
(drawPagesForPrintingCompleted): Emit WebKitPrintOperation::failed
when the print operation failed with the given error.
(webkitPrintOperationPrintPagesForFrame): Use
PrintFinishedCallback instead of a VoidCallback.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrint):
(testPrintOperationErrors): Test different print errors are
correctly reported.
(beforeAll):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Invalidate print finished callbacks
map.
(WebKit::WebPageProxy::printFinishedCallback): Callback called
when the print operation has finished in the web process.
(WebKit::WebPageProxy::processDidCrash): Invalidate print finished
callbacks map.
(WebKit::WebPageProxy::drawPagesForPrinting): Use a
PrintFinishedCallback instead of a VoidCallback.
* UIProcess/WebPageProxy.h:
(WebKit): Delcare PrintFinishedCallback as a generic callback.
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in: Use PrintFinishedCallback
instead of VoidCallback as callback argument of
DrawPagesForPrinting message.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Mark the data as invalid
when there are no pages to print.
(PrintPagesData): Add isValid parameter to mark the data struct as
invalid.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Call
printPagesDone() instead of printDone().
(WebKit::WebPrintOperationGtk::printPagesDone): Renamed.
(WebKit::WebPrintOperationGtk::printDone): Notify the UI process
that the print operation has finsihed.
(WebKit::WebPrintOperationGtk::print): Finish the print if the
PrintPagesData struct is not valid.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 17:32:27 +0000 (17:32 +0000)]
[EFL] Enable HTML5 Summary and Details elements
https://bugs.webkit.org/show_bug.cgi?id=81027
Enabling Summary and Details elements by default and removing related
tests from skip list since they should pass now.
.:
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.
* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:
LayoutTests:
Tests expectations from Ubuntu 11.10 using EFL from SVN. Hopefully the
same as the build bot.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
* platform/efl/fast/html/details-add-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-child-2-expected.txt: Added.
* platform/efl/fast/html/details-add-details-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-details-child-2-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-1-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-10-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-2-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-3-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-4-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-5-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-6-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-7-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-8-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-9-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-child-1-expected.txt: Added.
* platform/efl/fast/html/details-add-summary-child-2-expected.txt: Added.
* platform/efl/fast/html/details-nested-1-expected.txt: Added.
* platform/efl/fast/html/details-nested-2-expected.txt: Added.
* platform/efl/fast/html/details-no-summary1-expected.txt: Added.
* platform/efl/fast/html/details-no-summary2-expected.txt: Added.
* platform/efl/fast/html/details-no-summary3-expected.txt: Added.
* platform/efl/fast/html/details-no-summary4-expected.txt: Added.
* platform/efl/fast/html/details-open-javascript-expected.txt: Added.
* platform/efl/fast/html/details-open1-expected.txt: Added.
* platform/efl/fast/html/details-open2-expected.txt: Added.
* platform/efl/fast/html/details-open3-expected.txt: Added.
* platform/efl/fast/html/details-open4-expected.txt: Added.
* platform/efl/fast/html/details-open5-expected.txt: Added.
* platform/efl/fast/html/details-open6-expected.txt: Added.
* platform/efl/fast/html/details-position-expected.txt: Added.
* platform/efl/fast/html/details-remove-child-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-child-2-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-child-1-expected.txt: Added.
* platform/efl/fast/html/details-remove-summary-child-2-expected.txt: Added.
* platform/efl/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/efl/fast/html/details-replace-text-expected.txt: Added.
* platform/efl/fast/html/details-writing-mode-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 17:05:06 +0000 (17:05 +0000)]
[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-14
Reviewed by Rob Buis.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStorePrivate::isActive):
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(WebKit):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):
* Api/BackingStore.h:
* Api/WebPage.cpp:
(BlackBerry::WebKit::toWebCoreMouseEventType):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::activeNodeContext):
(BlackBerry::WebKit::WebPage::activeNodeContext):
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 14 Mar 2012 16:59:16 +0000 (16:59 +0000)]
Make SVGUseElement respect & support externalResourcesRequired
https://bugs.webkit.org/show_bug.cgi?id=81109
Reviewed by Rob Buis.
Source/WebCore:
Generalize the existing externalResourcesRequired support from SVGScriptElement
into SVGExternalResourcesRequired, so it can be shared with SVGUseElement, which
was lacking proper externalResourcesRequired support.
<use xlink:href="external.svg" onload="alert('hi')" externalResourcesRequired="true"/>
The onload handler now fires _after_ the external resources loaded, making it possible
to write reliable tests that switch from internal to external resources or the other
way around. Converted the new tests in svg/dynamic-updates/SVGUseElement* to listen
to SVGLoad events, to make them reliable.
We may be able to generalize this to cover SVGImageElement as well (the only other class which
is currently supporting externalResourcesRequired - but that's more involved, so I left it TODO).
Covered by existing tests and the changes to the new SVGUseElement tests.
* svg/SVGElement.h:
(SVGElement): Make haveLoadedRequiredResources() public so SVGExternalResourcesRequired can call it.
* svg/SVGExternalResourcesRequired.cpp: Refactored code from SVGScriptElement, 1:1 copies w/o changes.
(WebCore::SVGExternalResourcesRequired::handleAttributeChange):
(WebCore::SVGExternalResourcesRequired::dispatchLoadEvent):
(WebCore::SVGExternalResourcesRequired::insertedIntoDocument):
(WebCore::SVGExternalResourcesRequired::finishParsingChildren):
(WebCore::SVGExternalResourcesRequired::haveLoadedRequiredResources):
* svg/SVGExternalResourcesRequired.h: Add new virtual functions, that must be available in classes that inherit from SVGExternalResourcesRequired.
(WebCore::SVGExternalResourcesRequired::setHaveFiredLoadEvent):
(WebCore::SVGExternalResourcesRequired::isParserInserted):
(WebCore::SVGExternalResourcesRequired::haveFiredLoadEvent):
* svg/SVGScriptElement.cpp: Refactored externalResourcesRequired handling into SVGExternalResourcesRequired.
(WebCore::SVGScriptElement::svgAttributeChanged):
(WebCore::SVGScriptElement::insertedIntoDocument):
(WebCore::SVGScriptElement::finishParsingChildren):
* svg/SVGScriptElement.h: Ditto.
(WebCore::SVGScriptElement::haveLoadedRequiredResources):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::setHaveFiredLoadEvent):
(WebCore::SVGScriptElement::isParserInserted):
(WebCore::SVGScriptElement::haveFiredLoadEvent):
* svg/SVGTests.cpp: Fix obvious typo, that leads to an assertion. Always return true if we know the attributeName.
(WebCore::SVGTests::handleAttributeChange):
* svg/SVGTests.h:
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedIntoDocument): Remove ambigous call warning.
* svg/SVGUseElement.cpp: Support externalResourcesRequired="true/false" + dynamic changes of it. Covered by existing tests.
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::create):
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::finishParsingChildren):
(WebCore):
* svg/SVGUseElement.h: Ditto.
(WebCore::SVGUseElement::haveLoadedRequiredResources):
(WebCore::SVGUseElement::setHaveFiredLoadEvent):
(WebCore::SVGUseElement::isParserInserted):
(WebCore::SVGUseElement::haveFiredLoadEvent):
* svg/svgtags.in: Pass "bool wasInsertedByParser" to SVGUseElement constructor.
LayoutTests:
Fix flakiness of new external <use> tests introduced in r110676.
* platform/mac/svg/batik/masking/maskRegions-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
* svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt:
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt:
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js:
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js:
(repaintTest):
(externalLoadDone):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js:
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js:
(repaintTest):
(externalLoadDone):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 16:32:40 +0000 (16:32 +0000)]
Mac WK2: editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=81125
Add expected failing results for Mac WK2 to get the bots green.
* platform/mac-wk2/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 16:23:02 +0000 (16:23 +0000)]
[BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=81000
Source/JavaScriptCore:
Enable WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for BlackBerry.
Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.
* wtf/Platform.h:
Source/WebCore:
Add BlackBerry port for DisplayRefreshMonitor using AnimationFrameRateController.
Moved refreshDisplayOnMainThread to platform independant part of header.
Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.
requestAnimationFrame already covered by tests in LayoutTests/fast/animation.
* PlatformBlackBerry.cmake:
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
* platform/graphics/DisplayRefreshMonitor.h:
(WebCore):
(DisplayAnimationClient):
(WebCore::DisplayAnimationClient::~DisplayAnimationClient):
(DisplayRefreshMonitor):
* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Added.
(WebCore):
(WebCore::DisplayAnimationClient::DisplayAnimationClient):
(WebCore::DisplayAnimationClient::animationFrameChanged):
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::startAnimationClient):
(WebCore::DisplayRefreshMonitor::stopAnimationClient):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
Source/WebKit/blackberry:
Set the platform display ID, needed for DisplayRefreshMonitor.
Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 14 Mar 2012 16:21:05 +0000 (16:21 +0000)]
Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
https://bugs.webkit.org/show_bug.cgi?id=81056
Reviewed by Jessie Berlin.
Source/WebKit2:
Give the InjectedBundlePageFullScreenClient a first crack at beganEnterFullScreen and beganExitFullScreen:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
And call the client function if it exists; otherwise, continue to message the page:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
(WebKit::InjectedBundlePageFullScreenClient::beganEnterFullScreen):
(WebKit::InjectedBundlePageFullScreenClient::beganExitFullScreen):
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
Add a custom APIClientTraits for InjectedBundlePageFullScreenClient to handle the API number change.
* Shared/APIClientTraits.cpp:
* Shared/APIClientTraits.h:
Tools:
Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 14 Mar 2012 16:20:16 +0000 (16:20 +0000)]
Web Inspector: use class name indexes instead of class names when evaluating aggregates
https://bugs.webkit.org/show_bug.cgi?id=81100
Class name and type name indexes are now used when calculating class aggregates
in heap snapshots instead of string lookup followed by a string comparison.
Class names like "Window / www.webkit.org" are now left as is in the UI (it used
to be trimed to just "Window").
Reviewed by Pavel Feldman.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get classNameIndex):
(WebInspector.HeapSnapshotNode.prototype.hasType):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 14 Mar 2012 16:04:38 +0000 (16:04 +0000)]
Web Inspector: add didCancelFrame timeline event
https://bugs.webkit.org/show_bug.cgi?id=80994
Reviewed by Pavel Feldman.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
- add an ability to cancel certain timeline events, unless they've been followed by other events.
- implement didCancelFrame() event, fired when a platform decides not to render frame after didBeginFrame() was called.
Test: inspector/timeline/timeline-frames.html
* WebCore.exp.in:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCancelFrameImpl):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCancelFrame):
(WebCore):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCancelableRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):
(WebCore::InspectorTimelineAgent::cancelRecord):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
* testing/Internals.cpp:
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore):
(WebCore::Internals::emitInspectorDidCancelFrame):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit/chromium:
- add intrumentCanceFrame(), called when renderer decides not to
render frame after instrumentBeginFrame() was called.
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::instrumentCancelFrame):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentCancelFrame):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
- added test for didBeginFrame()/didCancelFrame()
* inspector/timeline/timeline-frames-expected.txt: Added.
* inspector/timeline/timeline-frames.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Wed, 14 Mar 2012 15:42:51 +0000 (15:42 +0000)]
The width and height of the scroll indicators in the MiniBrowser does not consider the offset margins. https://bugs.webkit.org/show_bug.cgi?id=81112
Reviewed by Kenneth Rohde Christiansen.
This patch fixes the issue by withdrawing two times the anchor
margins.
* MiniBrowser/qt/qml/ScrollIndicator.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 15:37:33 +0000 (15:37 +0000)]
Region can acquire an empty span by subtracting an empty Region
https://bugs.webkit.org/show_bug.cgi?id=81074
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-14
Reviewed by Anders Carlsson.
Source/WebCore:
Subtracting an empty Region B from a Region A can cause A to end
up with an empty span. This violates the rule that two Regions
that cover the exact same area should have equal spans and segments.
Unit test: RegionTest.emptySpan
* platform/graphics/Region.cpp:
(WebCore::Region::subtract):
Source/WebKit/chromium:
* tests/RegionTest.cpp:
(WebCore::TEST):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 14 Mar 2012 15:31:56 +0000 (15:31 +0000)]
[Textmap] Disable driver based BGRA swizzling for OpenGL/ES
Reviewed by Noam Rosenthal.
The current way of detecting swizzling support (check for GL_EXT_texture_format_BGRA8888)
is unfortunately not reliable. We need a better way of detection that (filed bug 81103).
In the meantime this patch reverts back to doing the swizzling in the texture mapper to
get pixels back onto the screen.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 14 Mar 2012 15:28:34 +0000 (15:28 +0000)]
[Qt] Deal with multiple paths in QMAKE_EXTRA_MODULE_FORWARDS
Reviewed by Simon Hausmann.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Wed, 14 Mar 2012 15:24:13 +0000 (15:24 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
https://bugs.webkit.org/show_bug.cgi?id=81086
Reviewed by Rob Buis.
Source/WebCore:
* platform/Cursor.h:
(WebCore):
(WebCore::Cursor::Cursor):
Add the BlackBerry specific PlatformCursor.
* platform/blackberry/PageClientBlackBerry.h:
There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly in this file.
(PageClientBlackBerry):
Source/WebKit/blackberry:
There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCursor):
* Api/WebPage_p.h:
(WebPagePrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 15:15:34 +0000 (15:15 +0000)]
[EFL] Implement LayoutTestController::clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=80142
Tools:
Adding missing implementation clearBackForwardList to EFL's
LayoutTestController. This implementation allows us to unskip
tests connected with history.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearBackForwardList): Implemented.
LayoutTests:
Unskip tests connected with clearBackForwardList.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 14 Mar 2012 15:02:14 +0000 (15:02 +0000)]
[Qt] RunLoopQt is missing reentrancy guards
https://bugs.webkit.org/show_bug.cgi?id=80982
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-14
Reviewed by Tor Arne Vestbø.
Avoid recursive calls to RunLoop::performWork() with a simple
counting mechanism, to avoid out-of-order message dispatching.
* platform/qt/RunLoopQt.cpp:
(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 14 Mar 2012 14:41:26 +0000 (14:41 +0000)]
Source/WebCore: Web Inspector: small improvement for HeapSnapshot performance ~12%.
https://bugs.webkit.org/show_bug.cgi?id=81033
Reviewed by Yury Semikhatsky.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.get nodeCount):
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
(WebInspector.HeapSnapshot.prototype.get nodeIndexes):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
Source/WebKit/chromium: Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.
Patch by Hajime Morrita <morrita@chromium.org> on 2012-03-13
* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):
LayoutTests: Return null when shouldAllowAccessToNode() fails
https://bugs.webkit.org/show_bug.cgi?id=80205
Patch by Kentaro Hara <haraken@chromium.org> on 2012-03-14
Reviewed by Adam Barth.
shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument
* http/tests/security/cross-frame-access-frameelement-expected.txt:
* http/tests/security/local-iFrame-from-remote.html:
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 13:23:10 +0000 (13:23 +0000)]
Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
https://bugs.webkit.org/show_bug.cgi?id=81093
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.
Fix build error introduced by r110669.
* platform/network/soup/DNSSoup.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 13:01:17 +0000 (13:01 +0000)]
Unreviewed rebaseline update for <use> related SVG files.
* platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Removed.
* platform/chromium-linux/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Removed.
* platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Removed.
* platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
* platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textEffect2-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
* platform/chromium-linux/svg/batik/text/textLength-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textPosition-expected.png:
* platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
* platform/chromium-linux/svg/batik/text/textProperties-expected.png:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/textStyles-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
* platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLayout2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textOnPath-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textStyles-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLayout2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textPosition-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/chromium-win/svg/batik/filters/feTile-expected.png:
* platform/chromium-win/svg/batik/filters/feTile-expected.txt:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
* platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
* platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/smallFonts-expected.png:
* platform/chromium-win/svg/batik/text/smallFonts-expected.txt:
* platform/chromium-win/svg/batik/text/textAnchor-expected.png:
* platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
* platform/chromium-win/svg/batik/text/textDecoration-expected.png:
* platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect-expected.png:
* platform/chromium-win/svg/batik/text/textEffect-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect2-expected.png:
* platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
* platform/chromium-win/svg/batik/text/textEffect3-expected.png:
* platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout-expected.png:
* platform/chromium-win/svg/batik/text/textLayout-expected.txt:
* platform/chromium-win/svg/batik/text/textLayout2-expected.png:
* platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
* platform/chromium-win/svg/batik/text/textLength-expected.png:
* platform/chromium-win/svg/batik/text/textLength-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPath-expected.png:
* platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition-expected.png:
* platform/chromium-win/svg/batik/text/textPosition-expected.txt:
* platform/chromium-win/svg/batik/text/textPosition2-expected.png:
* platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties-expected.png:
* platform/chromium-win/svg/batik/text/textProperties-expected.txt:
* platform/chromium-win/svg/batik/text/textProperties2-expected.png:
* platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
* platform/chromium-win/svg/batik/text/textStyles-expected.png:
* platform/chromium-win/svg/batik/text/textStyles-expected.txt:
* platform/chromium-win/svg/batik/text/verticalText-expected.png:
* platform/chromium-win/svg/batik/text/verticalText-expected.txt:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/mac-future/svg/batik/masking/maskRegions-expected.png: Removed.
* platform/mac/svg/batik/masking/maskRegions-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 12:41:37 +0000 (12:41 +0000)]
WebHTTPBody: Keep track of whether the data includes passwords.
https://bugs.webkit.org/show_bug.cgi?id=81003
Patch by Marja Hölttä <marja@google.com> on 2012-03-14
Reviewed by Darin Fisher.
This change enables Chrome to save HTTP bodies selectively, only
if they don't contain passwords.
Source/WebCore:
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Check if the data contains passwords.
* platform/network/FormData.cpp:
(WebCore::FormData::FormData): Added containsPasswordData, setContainsPasswordData.
* platform/network/FormData.h:
(WebCore::FormData::containsPasswordData): Added.
(WebCore::FormData::setHasPasswordData): Added.
(FormData):
Source/WebKit/chromium:
* public/platform/WebHTTPBody.h:
(WebHTTPBody): Added containsPasswordData, setContainsPasswordData.
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::containsPasswordData): Added.
(WebKit):
(WebKit::WebHTTPBody::setContainsPasswordData): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 14 Mar 2012 12:23:08 +0000 (12:23 +0000)]
Web Inspector: Add snippets tab to scripts navigator.
https://bugs.webkit.org/show_bug.cgi?id=81018
Reviewed by Pavel Feldman.
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.focus):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._createFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._scriptFolderIdentifier):
(WebInspector.NavigatorTreeOutline):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
* inspector/front-end/SnippetsModel.js:
LayoutTests:
* http/tests/inspector/debugger-test.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 14 Mar 2012 12:03:48 +0000 (12:03 +0000)]
Web Inspector: Copy on the Console gives a mangled result.
https://bugs.webkit.org/show_bug.cgi?id=81091
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):
LayoutTests:
* http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:
* http/tests/inspector/console-xhr-logging-async-expected.txt:
* http/tests/inspector/console-xhr-logging-expected.txt:
* inspector/console/console-assert-expected.txt:
* inspector/console/console-big-array-expected.txt:
* inspector/console/console-clear-expected.txt:
* inspector/console/console-command-clear-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-dirxml-expected.txt:
* inspector/console/console-external-array-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/console/console-log-before-inspector-open-expected.txt:
* inspector/console/console-log-document-proto-expected.txt:
* inspector/console/console-log-syntax-error-expected.txt:
* inspector/console/console-log-toString-object-expected.txt:
* inspector/console/console-nested-group-expected.txt:
* inspector/console/console-object-constructor-name-expected.txt:
* inspector/console/console-repeat-count-expected.txt:
* inspector/console/console-tests-expected.txt:
* inspector/console/console-trace-expected.txt:
* inspector/extensions/extensions-console-expected.txt:
* platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
* platform/chromium/http/tests/inspector/console-resource-errors-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
* platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt:
* platform/chromium/inspector/console/alert-toString-exception-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/chromium/inspector/console/console-format-expected.txt:
* platform/chromium/inspector/console/console-log-document-proto-expected.txt:
* platform/chromium/inspector/console/console-log-syntax-error-expected.txt:
* platform/chromium/inspector/console/console-object-constructor-name-expected.txt:
* platform/chromium/inspector/console/console-trace-in-eval-expected.txt:
* platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
* platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt:
* platform/qt/inspector/console/console-format-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 14 Mar 2012 12:00:44 +0000 (12:00 +0000)]
2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499
Reviewed by Zoltan Herczeg.
Rebaseline tests after r110676 using Generic RGB Profile on Lion, and update them after my fixes.
Replace xml:id with id everywhere, to make the new tiny tests work.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
* platform/mac/svg/batik/filters/feTile-expected.png:
* platform/mac/svg/batik/filters/filterRegions-expected.png:
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg:
* svg/custom/use-external-crash-expected.txt: Added.
* svg/custom/use-external-crash.svg: Added.
2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499
Reviewed by Zoltan Herczeg.
Follow-up fix after r110676.
Assertions are firing due last minute changes in isExternalURIReference.
Fix detecting local resources properly, when the given iri contains a /complex/path.
Use document->completeURL() instead, and compare with the document->url() to decide
if its a local reference or not.
If an external document load fails with an error (eg. file missing) don't assert
in debug builds, instead handle it gracefully.
I decided to clean the code up as well, to make it more safe & obvious.
Test: svg/custom/use-external-crash.svg
* svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::targetElementFromIRIString):
* svg/SVGURIReference.h:
(WebCore::SVGURIReference::isExternalURIReference):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::externalDocument):
(WebCore::SVGUseElement::buildPendingResource):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 11:56:47 +0000 (11:56 +0000)]
3D transformed surfaces with z>0 gets cropped
https://bugs.webkit.org/show_bug.cgi?id=81009
Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-03-14
Reviewed by Noam Rosenthal.
The scissor clipping in TextureMapperGL didn't take 3D transforms
into account when calculating the clipping region.
Now, it will bail out early if the transform is not affine.
No new tests. Tested by current compositing layout tests.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginScissorClip):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 14 Mar 2012 11:47:36 +0000 (11:47 +0000)]
[Qt] Rebaseline after r110667.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-14
Reviewed by Csaba Osztrogonác.
* platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 11:43:53 +0000 (11:43 +0000)]
[Qt] Unreviewed. Add platform specific expectaions after r110593
new file: LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.png
new file: LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.txt
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 11:39:46 +0000 (11:39 +0000)]
Unreviewed flakiness marking.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 11:06:09 +0000 (11:06 +0000)]
Unreviewed rebaselining expectations.
* platform/chromium-linux/svg/batik/filters/feTile-expected.png:
* platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textAnchor-expected.png:
* platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textEffect-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textLayout-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textLength-expected.png:
* platform/chromium-linux/svg/batik/text/textLength-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textPosition2-expected.png:
* platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.png:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/verticalText-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLength-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLength-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textPosition2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:44:51 +0000 (10:44 +0000)]
[Qt] svg/animations tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=80703
Unreviewd, skipp svg/animations/animate-elem-08-t-drt.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:31:37 +0000 (10:31 +0000)]
[Qt] Unreviewed, rebaseline after r110587.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 10:11:30 +0000 (10:11 +0000)]
Unreviewed build fix.
* html/track/TextTrackList.cpp:
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::owner): Changed return type from HTMLMediaElement* to Node* and uninlined.
* html/track/TextTrackList.h:
(TextTrackList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 14 Mar 2012 10:04:33 +0000 (10:04 +0000)]
Web Inspector: [InspectorIndexedDB] Remote object should be released when data view is removed/updated.
https://bugs.webkit.org/show_bug.cgi?id=81022
Reviewed by Pavel Feldman.
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.get statusBarItems):
(WebInspector.IDBDataView.prototype.clear):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBDatabaseTreeElement.prototype._objectStoreRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.clear):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement.prototype._indexRemoved):
(WebInspector.IDBObjectStoreTreeElement.prototype.clear):
(WebInspector.IDBIndexTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement.prototype.clear):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:02:17 +0000 (10:02 +0000)]
[Qt] Unreviewed. Update expectaions after r110676
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 14 Mar 2012 09:59:50 +0000 (09:59 +0000)]
Web Inspector: Introduce SnippetsScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80890
Reviewed by Pavel Feldman.
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._mappingForScript):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsModel.prototype.snippetForId):
(WebInspector.SnippetsModel.prototype.snippetForSourceURL):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype.uiSourceCodeList):
(WebInspector.SnippetsScriptMapping.prototype.addScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript.get if):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted):
(WebInspector.SnippetsScriptMapping.prototype.reset):
(WebInspector.SnippetContentProvider):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 14 Mar 2012 09:38:09 +0000 (09:38 +0000)]
Unreviewed, GTK svg rebaseline after r110676.
* platform/gtk/svg/batik/filters/feTile-expected.txt:
* platform/gtk/svg/batik/filters/filterRegions-expected.txt:
* platform/gtk/svg/batik/masking/maskRegions-expected.txt:
* platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
* platform/gtk/svg/batik/text/textAnchor-expected.txt:
* platform/gtk/svg/batik/text/textDecoration-expected.txt:
* platform/gtk/svg/batik/text/textEffect-expected.txt:
* platform/gtk/svg/batik/text/textEffect2-expected.txt:
* platform/gtk/svg/batik/text/textEffect3-expected.txt:
* platform/gtk/svg/batik/text/textFeatures-expected.txt:
* platform/gtk/svg/batik/text/textLayout-expected.txt:
* platform/gtk/svg/batik/text/textLayout2-expected.txt:
* platform/gtk/svg/batik/text/textLength-expected.txt:
* platform/gtk/svg/batik/text/textOnPath-expected.txt:
* platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/gtk/svg/batik/text/textPosition-expected.txt:
* platform/gtk/svg/batik/text/textPosition2-expected.txt:
* platform/gtk/svg/batik/text/textProperties-expected.txt:
* platform/gtk/svg/batik/text/textProperties2-expected.txt:
* platform/gtk/svg/batik/text/textStyles-expected.txt:
* platform/gtk/svg/batik/text/verticalText-expected.txt:
* platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/gtk/svg/hixie/error/014-expected.txt:
* platform/gtk/svg/hixie/use/002-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 14 Mar 2012 09:08:49 +0000 (09:08 +0000)]
2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update two pixel test results on Lion, now svg/ passes with --tolerance 0 again.
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/mac/svg/hixie/mixed/003-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 09:01:47 +0000 (09:01 +0000)]
Unreviewed, rolling out r110673.
http://trac.webkit.org/changeset/110673
https://bugs.webkit.org/show_bug.cgi?id=81090
"Qt minimal build broken" (Requested by yurys on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14
* inspector/CodeGeneratorInspector.py:
(CommandReturnPassModel.ByPointer.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(Generator.process_event):
(Generator.process_command):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
* inspector/ContentSearchUtils.h:
(ContentSearchUtils):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 14 Mar 2012 08:55:15 +0000 (08:55 +0000)]
Last buildfix for Qt after r110595. :)
Reviewed by Benjamin Poulain.
* Api/qwebpage.cpp:
* WebCoreSupport/GeolocationClientQt.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Wed, 14 Mar 2012 08:52:35 +0000 (08:52 +0000)]
External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499
Reviewed by Nikolas Zimmermann.
Source/WebCore:
This is a follow-up patch after r108785.
In this patch we bind the previously introduced CachedSVGDocument class
into the caching mechanism of SVGUseElement. The mode how external resources
are handled is similar to the processing of internal ones. We build the instance
and shadow tree the same way but we have to keep in mind that the requested resources
maybe not loaded yet. We can check it with cachedDocumentIsStillLoading() function.
SVGURIReference::targetElementFromIRIString() also need to be extended. The baseURI
computation needs to take the referenced documents URL into account, instead of the current documents.
The patch affects a lot of tests which have external resources especially in svg/batik. Because
of the size of that test refactor they will be commited in a follow-up patch.
Tests: svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg
svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg
svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg
svg/custom/use-extern-href.svg
svg/custom/use-referencing-an-image-expected.svg
svg/custom/use-referencing-an-image.svg
svg/custom/use-referencing-indirectly-itself-expected.svg
svg/custom/use-referencing-indirectly-itself.svg
svg/custom/use-referencing-itself-expected.svg
svg/custom/use-referencing-itself.svg
svg/dynamic-updates/SVGUseElement-dom-href1-attr.html
svg/dynamic-updates/SVGUseElement-dom-href2-attr.html
svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html
svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html
* loader/cache/CachedResourceLoader.cpp:
(WebCore):
(WebCore::CachedResourceLoader::requestSVGDocument):
* loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
* page/ContentSecurityPolicy.h:
* platform/KURL.cpp:
(WebCore::equalIgnoringFragmentIdentifier):
* platform/network/chromium/ResourceRequest.h:
* svg/SVGURIReference.cpp:
(WebCore::urlFromIRIStringWithFragmentIdentifier):
(WebCore):
(WebCore::SVGURIReference::targetElementFromIRIString):
* svg/SVGURIReference.h:
(SVGURIReference):
(WebCore::SVGURIReference::isExternalURIReference):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore):
(WebCore::SVGUseElement::referencedDocument):
(WebCore::SVGUseElement::externalDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::cachedDocumentIsStillLoading):
(WebCore::SVGUseElement::instanceTreeIsLoading):
* svg/SVGUseElement.h:
(WebCore):
(SVGUseElement):
LayoutTests:
Adding tests to check the new functionality of SVGUseElement what can use
sources from external URIs too. New tests in this patch cover the corner cases
of this feature: referencing resources directly and indirectly, changing
the referenced URI from an internal to an external one, handling
security issues like self referencing, self referencing across document, etc.
Furthermore the patch infer some rebaseline in svg/batik directory because
they use external resources.
* platform/chromium/test_expectations.txt:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/mac/svg/batik/filters/feTile-expected.png:
* platform/mac/svg/batik/filters/feTile-expected.txt:
* platform/mac/svg/batik/filters/filterRegions-expected.png:
* platform/mac/svg/batik/filters/filterRegions-expected.txt:
* platform/mac/svg/batik/masking/maskRegions-expected.png:
* platform/mac/svg/batik/masking/maskRegions-expected.txt:
* platform/mac/svg/batik/paints/gradientLimit-expected.png:
* platform/mac/svg/batik/paints/gradientLimit-expected.txt:
* platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/mac/svg/batik/paints/patternRegionA-expected.png:
* platform/mac/svg/batik/paints/patternRegionA-expected.txt:
* platform/mac/svg/batik/paints/patternRegions-expected.png:
* platform/mac/svg/batik/paints/patternRegions-expected.txt:
* platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/mac/svg/batik/text/longTextOnPath-expected.png:
* platform/mac/svg/batik/text/longTextOnPath-expected.txt:
* platform/mac/svg/batik/text/smallFonts-expected.png:
* platform/mac/svg/batik/text/smallFonts-expected.txt:
* platform/mac/svg/batik/text/textAnchor-expected.png:
* platform/mac/svg/batik/text/textAnchor-expected.txt:
* platform/mac/svg/batik/text/textDecoration-expected.png:
* platform/mac/svg/batik/text/textDecoration-expected.txt:
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect-expected.txt:
* platform/mac/svg/batik/text/textEffect2-expected.png:
* platform/mac/svg/batik/text/textEffect2-expected.txt:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.txt:
* platform/mac/svg/batik/text/textFeatures-expected.png:
* platform/mac/svg/batik/text/textFeatures-expected.txt:
* platform/mac/svg/batik/text/textLayout-expected.png:
* platform/mac/svg/batik/text/textLayout-expected.txt:
* platform/mac/svg/batik/text/textLayout2-expected.png:
* platform/mac/svg/batik/text/textLayout2-expected.txt:
* platform/mac/svg/batik/text/textLength-expected.png:
* platform/mac/svg/batik/text/textLength-expected.txt:
* platform/mac/svg/batik/text/textOnPath-expected.png:
* platform/mac/svg/batik/text/textOnPath-expected.txt:
* platform/mac/svg/batik/text/textOnPathSpaces-expected.png:
* platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/mac/svg/batik/text/textPosition-expected.png:
* platform/mac/svg/batik/text/textPosition-expected.txt:
* platform/mac/svg/batik/text/textPosition2-expected.png:
* platform/mac/svg/batik/text/textPosition2-expected.txt:
* platform/mac/svg/batik/text/textProperties-expected.png:
* platform/mac/svg/batik/text/textProperties-expected.txt:
* platform/mac/svg/batik/text/textProperties2-expected.png:
* platform/mac/svg/batik/text/textProperties2-expected.txt:
* platform/mac/svg/batik/text/textStyles-expected.png:
* platform/mac/svg/batik/text/textStyles-expected.txt:
* platform/mac/svg/batik/text/verticalText-expected.png:
* platform/mac/svg/batik/text/verticalText-expected.txt:
* platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
* platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/mac/svg/custom/use-extern-href-expected.png: Added.
* platform/mac/svg/custom/use-extern-href-expected.txt: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/mac/svg/hixie/error/014-expected.txt:
* platform/mac/svg/hixie/use/002-expected.png:
* platform/mac/svg/hixie/use/002-expected.txt:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg: Added.
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg: Added.
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg: Added.
* svg/batik/filters/filterRegions.svg:
* svg/batik/text/textProperties.svg:
* svg/batik/text/textProperties2.svg:
* svg/batik/text/textStyles.svg:
* svg/custom/resources/rgb.svg:
* svg/custom/use-extern-href.svg: Added.
* svg/custom/use-referencing-an-image-expected.svg: Added.
* svg/custom/use-referencing-an-image.svg: Added.
* svg/custom/use-referencing-indirectly-itself-expected.svg: Added.
* svg/custom/use-referencing-indirectly-itself.svg: Added.
* svg/custom/use-referencing-itself-expected.svg: Added.
* svg/custom/use-referencing-itself.svg: Added.
* svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-dom-href1-attr.html: Added.
* svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-dom-href2-attr.html: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js: Added.
(repaintTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 14 Mar 2012 08:32:39 +0000 (08:32 +0000)]
Unreviewed, skip a new failing inspector test in GTK and add new
baseline for a svg test.
* platform/gtk/Skipped:
* platform/gtk/svg/custom/delete-text-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 08:18:35 +0000 (08:18 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 08:04:18 +0000 (08:04 +0000)]
Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
https://bugs.webkit.org/show_bug.cgi?id=80789
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-14
Reviewed by Yury Semikhatsky.
OptOutput class is added for optional return parameters.
Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.
Debugger and Page domain is switched to strict mode.
* inspector/CodeGeneratorInspector.py:
(CommandReturnPassModel.ByPointer):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.__init__):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
* inspector/ContentSearchUtils.h:
(ContentSearchUtils):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 14 Mar 2012 08:04:02 +0000 (08:04 +0000)]
Unreviewed, GTK rebaseline after r110667.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Wed, 14 Mar 2012 07:32:07 +0000 (07:32 +0000)]
Unreviewed. Build fix for EFL after r110669.
* PlatformEfl.cmake: added DNSSoup.cpp
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Wed, 14 Mar 2012 07:23:49 +0000 (07:23 +0000)]
[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997
Reviewed by Martin Robinson.
This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.
No need for new tests as this just moves code around.
* GNUmakefile.list.am:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
* html/HTMLLinkElement.cpp:
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
* platform/network/DNS.h:
(WebCore):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/chromium/DNSChromium.cpp:
* platform/network/soup/DNSSoup.cpp: restored.
(WebCore):
(WebCore::prefetchDNS):
* platform/network/soup/ResourceHandleSoup.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 07:11:22 +0000 (07:11 +0000)]
GTK 32-bit Linux Release build failing after r110580 (from bug 80338)
https://bugs.webkit.org/show_bug.cgi?id=81063
Prospective build fix for GTK 32-bit Linux Release.
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-14
Reviewed by Martin Robinson.
* Source/autotools/symbols.filter: Adding symbol for ClientRectList(Vector<FloatQuad>) for
GTK 32-bit.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 14 Mar 2012 07:06:03 +0000 (07:06 +0000)]
Return null when shouldAllowAccessToNode() fails
https://bugs.webkit.org/show_bug.cgi?id=80205
Reviewed by Adam Barth.
shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument
Source/WebCore:
Tests: http/tests/security/local-iFrame-from-remote.html
http/tests/security/cross-frame-access-frameelement.html
http/tests/security/cross-frame-access-put.html
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
* bindings/scripts/test/JS/JSTestObj.cpp: Updated run-bindings-tests results.
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):
LayoutTests:
* http/tests/security/cross-frame-access-frameelement-expected.txt:
* http/tests/security/local-iFrame-from-remote.html:
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 07:02:49 +0000 (07:02 +0000)]
Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.
* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 06:54:01 +0000 (06:54 +0000)]
Source/WebCore: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.
This patch changes "labels" attribute behavior for hidden input type.
It returns null instead of NodeList of labels or empty node list.
Note: The HTML5 specification isn't clear for non-labelable element's "labels"
attribute return value. Firefox and Opera return empty node list. IE returns null.
No new tests. Existing tests are updated.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isLabelable): Added. Dispatch to InputType.
* html/HiddenInputType.h: Added isLabelable returning false.
* html/InputType.cpp:
(WebCore::InputType::isLabelable): Added. Returning true for all input types except for "hidden" type.
(WebCore):
* html/InputType.h:
(InputType): Added isLabelable declaration.
LayoutTests: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.
This patch changes expected text for null value of labels attribute
of hidden input type and labelable-elements to check null value for
the labels attribute of input type.
* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labelable-elements.html:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
* platform/chromium/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/forms/label/labelable-elements-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 14 Mar 2012 06:35:49 +0000 (06:35 +0000)]
[Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.
Source/WebCore:
This patch enables functionality of "labels" attribute for
HTMLOutputElement implemented in LabelableElement which use
isLabelable predicate whether an element can have label or not.
Update existing tests in fast/forms/label/ directory to cover
the "output" element with the "labels" attribute.
* html/HTMLOutputElement.h: Implement virtual method isLabelable.
LayoutTests:
This patch updates expectation for functioning the "labels"
attribute of the "output" elements which was not working
so far.
* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
* platform/chromium/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/forms/label/labelable-elements-expected.txt
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 14 Mar 2012 06:24:15 +0000 (06:24 +0000)]
Unreviewed, marking some tests flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Wed, 14 Mar 2012 03:19:02 +0000 (03:19 +0000)]
Move opacity clamping into RenderStyle setter.
https://bugs.webkit.org/show_bug.cgi?id=76966
Reviewed by Eric Seidel.
Covered by existing tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::setOpacity):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 14 Mar 2012 02:54:58 +0000 (02:54 +0000)]
ValueToInt32 speculation will cause OSR exits even when it does not have to
https://bugs.webkit.org/show_bug.cgi?id=81068
<rdar://problem/
11043926>
Reviewed by Anders Carlsson.
Two related changes:
1) ValueToInt32 will now always just defer to the non-speculative path, instead
of exiting, if it doesn't know what speculations to perform.
2) ValueToInt32 will speculate boolean if it sees this to be profitable.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateBoolean):
(Node):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:47:48 +0000 (02:47 +0000)]
More Windows build fixing
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:40:19 +0000 (02:40 +0000)]
Windows build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:12:25 +0000 (02:12 +0000)]
Type conversion of exponential part failed
https://bugs.webkit.org/show_bug.cgi?id=80673
Reviewed by Geoffrey Garen.
* parser/Lexer.cpp:
(JSC::::lex):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
(JSC):
(JSC::jsStrDecimalLiteral): Added another template argument that exposes whether or not
we accept trailing junk to clients of jsStrDecimalLiteral. Also added additional template
parameter for strtod to allow trailing spaces.
(JSC::toDouble):
(JSC::parseFloat): Accept trailing junk, as per the ECMA 262 spec (15.1.2.3).
* runtime/LiteralParser.cpp:
(JSC::::Lexer::lexNumber):
* tests/mozilla/expected.html: Update the expected page for run-javascriptcore-tests so that
we will run ecma/TypeConversion/9.3.1-3.js as a regression test now.
* wtf/dtoa.cpp:
(WTF):
(WTF::strtod): We also needed to sometimes accept trailing spaces to pass a few other tests that were
broken by changing the default allowance of trailing junk in jsStrDecimalLiteral.
* wtf/dtoa.h:
* wtf/dtoa/double-conversion.cc: When the AdvanceToNonspace function was lifted out of the
Chromium codebase, the person porting it only thought to check for spaces when skipping whitespace.
A few of our JSC tests check for other types of trailing whitespace, so I've added checks for those
here to cover those cases (horizontal tab, vertical tab, carriage return, form feed, and line feed).
* wtf/text/WTFString.cpp:
(WTF::toDoubleType): Disallow trailing spaces, as this breaks form input verification stuff.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
igor.o@sisa.samsung.com [Wed, 14 Mar 2012 01:38:08 +0000 (01:38 +0000)]
Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent
https://bugs.webkit.org/show_bug.cgi?id=80856
Extra part of the generated content handling logic out of RenderObjectChildList::updateBeforeAfterContent
Reviewed by Julien Chaffraix.
No change in behavior expected.
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterStyle):
(WebCore::createRenderForBeforeAfterContent):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderObjectChildList.h:
(WebCore):
(RenderObjectChildList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 14 Mar 2012 01:37:58 +0000 (01:37 +0000)]
FREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 14 Mar 2012 01:26:38 +0000 (01:26 +0000)]
Unreviewed, build fix since is_pod<> includes some header that I didn't know about.
Removing the assert for now.
* dfg/DFGOperations.h:
* llint/LLIntSlowPaths.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Mar 2012 01:09:47 +0000 (01:09 +0000)]
Find bouncy doesn’t hide when a subframe is scrolled
https://bugs.webkit.org/show_bug.cgi?id=81060
<rdar://problem/9365329>
Reviewed by Andreas Kling.
Instead of hiding the find indicator when pageDidScroll is called, add a check to FindController::drawRect and hide
the find indicator there if the find selection bounds have changed since the last call to drawRect.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
* WebProcess/WebPage/FindController.h:
(FindController):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pageDidScroll):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 01:07:29 +0000 (01:07 +0000)]
WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194
Skip yet another test that uses eventSender.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 14 Mar 2012 00:46:03 +0000 (00:46 +0000)]
Functions with C linkage should return POD types
https://bugs.webkit.org/show_bug.cgi?id=81061
Reviewed by Mark Rowe.
* dfg/DFGOperations.h:
* llint/LLIntSlowPaths.h:
(LLInt):
(SlowPathReturnType):
(JSC::LLInt::encodeResult):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 14 Mar 2012 00:36:34 +0000 (00:36 +0000)]
Remove duplicate GC functions from layout tests
https://bugs.webkit.org/show_bug.cgi?id=81047
Reviewed by Ojan Vafai.
* fast/canvas/webgl/shader-deleted-by-accessor.html:
* fast/dom/Window/customized-property-survives-gc.html:
* fast/dom/inline-event-attributes-lookup-removed-form.html:
* fast/dom/inline-event-attributes-lookup-removed.html:
* fast/dom/shadow/gc-shadow.html:
* fast/filesystem/resources/file-writer-gc-blob.js:
* fast/forms/input-image-submit.html:
* fast/forms/interactive-validation-remove-node-in-handler.html:
* fast/forms/select-set-length-with-mutation-remove.html:
* fast/js/resources/js-test-pre.js:
(gc.else.gcRec):
(gc):
* http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
* http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
* webaudio/mediaelementaudiosourcenode-gc.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 00:31:03 +0000 (00:31 +0000)]
WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689
Add more tests that use setEditingBehavior to the wk2 Skipped list.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 14 Mar 2012 00:28:46 +0000 (00:28 +0000)]
[chromium] Unreviewed, rebaseline fast/canvas/canvas-text-alignment
https://bugs.webkit.org/show_bug.cgi?id=78529
After r110620, root layer scrollbars are drawn opaque, so they no
longer differ between debug and release due to alpha values.
Rebaselining this test.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 14 Mar 2012 00:27:01 +0000 (00:27 +0000)]
* platform/mac/fast/js/global-constructors-expected.txt: Added Selection.toString and
WebKitMutationObserver.toString.
Selection got exposed in <http://trac.webkit.org/changeset/109306>, and
WebKitMutationObserver was probably failing for even longer.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 14 Mar 2012 00:18:43 +0000 (00:18 +0000)]
Fix potential crash when loading test results
https://bugs.webkit.org/show_bug.cgi?id=81062
<rdar://problem/
11041732>
Reviewed by Dean Jackson.
If RenderLayerBacking::isSimpleContainerCompositingLayer() is called early,
before the document has a documentElement(), then it crashes. Fix with
a null check on documentElement().
No test because it's timing dependent.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 14 Mar 2012 00:08:39 +0000 (00:08 +0000)]
platform/mac/fast/forms/input-appearance-spinbutton(-up) fail on Lion
https://bugs.webkit.org/show_bug.cgi?id=81058
Add unreviewed expected failing result (which may actually be correct) for mac.
* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 14 Mar 2012 00:06:53 +0000 (00:06 +0000)]
MediaStream is not enabled on Mac. Skip all related tests.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 13 Mar 2012 23:58:59 +0000 (23:58 +0000)]
<rdar://problem/
11025225> Assertion failure in RenderView::computeRectForRepaint() (!repaintContainer || repaintContainer == this) at store.apple.com
https://bugs.webkit.org/show_bug.cgi?id=81051
Reviewed by Simon Fraser.
.:
* ManualTests/inline-repaint-container.html: Added.
Source/WebCore:
Test: ManualTests/inline-repaint-container.html.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): This function was not handling the
case of the repaint container being a descendant of the containing block correctly, leading
to the assertion failure, but also to a correctness bug seen in the new test. If the repaint
container is a descendant of the containing block, just return the rect in the repaint
container coordinates.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 13 Mar 2012 23:57:32 +0000 (23:57 +0000)]
<rdar://problem/
11025217> [Mac] Assertion failure in collectComplexTextRunsForCharactersCoreText
https://bugs.webkit.org/show_bug.cgi?id=77044
Reviewed by Sam Weinig.
Source/WebCore:
Test: platform/mac/fast/text/core-text-fallback-to-unknown-font.html
Handle the case of Core Text choosing a fallback font that NSFontManager cannot find by name.
* platform/graphics/FontCache.h:
(FontCache): Made ComplexTextController a friend class.
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the
failing assertion, which was not true, and added code to handle the case where a font
cannot be found by name by using the font as returned from Core Text.
LayoutTests:
* platform/mac/fast/text/core-text-fallback-to-unknown-font-expected.txt: Added.
* platform/mac/fast/text/core-text-fallback-to-unknown-font.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Tue, 13 Mar 2012 23:56:45 +0000 (23:56 +0000)]
[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880
Reviewed by Adam Barth.
Source/WebCore:
We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.
To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8). Interfaces that have *IsReachable
also have a dependent life time (just like if V8DependentLifetime was present).
Second try. This time with an added include in TextTrackList.cpp.
No new tests. Covered by existing tests.
* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* css/CSSStyleSheet.idl:
* css/StyleSheet.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/track/TextTrackList.cpp:
* html/track/TextTrackList.idl:
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 13 Mar 2012 23:45:53 +0000 (23:45 +0000)]
MathML crash in WebCore::Node::previousSibling()
https://bugs.webkit.org/show_bug.cgi?id=80773
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-13
Reviewed by Julien Chaffraix.
Source/WebCore:
When adding child for msub render, if the child is mtr or mtd render,
we will creat an anonymous render as the container. As the anonymous
render's node is 0, accessing it directly can cause crash.
We should do a valid check of the node before using. In addition to
that, for msub, attach the anonymous render and it's children to render
tree. For msubsup, such kind of situation should never happen based on
the current codebase.
Test: mathml/msub-anonymous-child-render-crash.html
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):
LayoutTests:
* mathml/msub-anonymous-child-render-crash-expected.txt: Added.
* mathml/msub-anonymous-child-render-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Tue, 13 Mar 2012 23:43:07 +0000 (23:43 +0000)]
[CSSRegions]NamedFlow::getRegionsByContentNode should not return a live NodeList
https://bugs.webkit.org/show_bug.cgi?id=81021
Reviewed by Ryosuke Niwa.
Reverting the original patch as we need a better solution.
Source/WebCore:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Node.cpp:
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):
* dom/Node.h:
(Node):
* dom/NodeRareData.h:
(NodeListsNodeData):
* dom/RegionNodeList.cpp: Removed.
* dom/RegionNodeList.h: Removed.
* dom/WebKitNamedFlow.cpp:
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
* rendering/RenderFlowThread.cpp:
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
* fast/regions/get-regions-by-content-node-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-horiz-bt.html: Removed.
* fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-horiz-tb.html: Removed.
* fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-vert-lr.html: Removed.
* fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-vert-rl.html: Removed.
* fast/regions/get-regions-by-content-node.html: Removed.
* fast/regions/get-regions-by-content-node2-expected.txt: Removed.
* fast/regions/get-regions-by-content-node2.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Tue, 13 Mar 2012 23:39:11 +0000 (23:39 +0000)]
Support loading a WKPage from web archive data
https://bugs.webkit.org/show_bug.cgi?id=81044
This code was written by Jessie Berlin.
Reviewed by Brady Eidson.
* UIProcess/API/C/WKPage.cpp:
(WKPageLoadWebArchiveData): Added.
* UIProcess/API/C/WKPage.h: Added WKPageLoadWebArchiveData().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadWebArchiveData): Added.
* UIProcess/WebPageProxy.h: Added loadWebArchiveData().
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadWebArchiveData): Added.
* WebProcess/WebPage/WebPage.h: Added loadWebArchiveData().
* WebProcess/WebPage/WebPage.messages.in: Added LoadWebArchiveData message.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 13 Mar 2012 23:31:50 +0000 (23:31 +0000)]
Note that this test is flaky. The flakiness dashboard says that this
test has been flaky for a while.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc