platform/upstream/efl.git
4 years agoefl_ui_collection_view: support focus
Marcel Hollerbach [Mon, 16 Sep 2019 11:50:12 +0000 (13:50 +0200)]
efl_ui_collection_view: support focus

with this commit you can more or less use focus. The only uncaught case
for now is that if the object is not available, no focus can be set.
Navigating with focus on the screen however should be possible.

Differential Revision: https://phab.enlightenment.org/D9969

4 years agoelementary: add a basic test for MVVM infrastructure.
Cedric Bail [Fri, 20 Sep 2019 22:01:49 +0000 (15:01 -0700)]
elementary: add a basic test for MVVM infrastructure.

Differential Revision: https://phab.enlightenment.org/D10063

4 years agoelementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager...
Cedric Bail [Mon, 16 Sep 2019 06:18:50 +0000 (23:18 -0700)]
elementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager infrastructure.

Co-authored-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9960

4 years agoelementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View.
Cedric Bail [Thu, 19 Sep 2019 18:19:56 +0000 (11:19 -0700)]
elementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View.

Differential Revision: https://phab.enlightenment.org/D10035

4 years agoelementary: introduce Efl.Ui.CollectionView a generic listing View.
Cedric BAIL [Fri, 5 Jul 2019 21:03:13 +0000 (14:03 -0700)]
elementary: introduce Efl.Ui.CollectionView a generic listing View.

The idea of this widget is to provide to MVVM what Efl.Ui.Collection provide and
leverage the same shared logic for layout.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
Co-authored-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9958

4 years agoelementary: fix children removal in Efl.Ui.Select_Model by not remembering index...
Cedric Bail [Thu, 19 Sep 2019 02:39:44 +0000 (19:39 -0700)]
elementary: fix children removal in Efl.Ui.Select_Model by not remembering index and relying on underlayer infrastructure to do it for us.

Differential Revision: https://phab.enlightenment.org/D10034

4 years agoelementary: add an interface for asynchronous multi selection.
Cedric Bail [Sun, 15 Sep 2019 19:50:27 +0000 (12:50 -0700)]
elementary: add an interface for asynchronous multi selection.

This interface is currently focusing on being use by widget like
Efl.Ui.Collection_View or Efl.Ui.Select_Model. I have decided that
it should not be available along with Efl.Ui.Multi_Selectable.

Differential Revision: https://phab.enlightenment.org/D9957

4 years agoelementary: factorize all events emitted by a Efl.Ui.Collection into their own interface.
Cedric Bail [Sun, 15 Sep 2019 21:38:03 +0000 (14:38 -0700)]
elementary: factorize all events emitted by a Efl.Ui.Collection into their own interface.

For most event it is actually meaningful to share them with Efl.Ui.Collection_View so let's do it.

Differential Revision: https://phab.enlightenment.org/D9956

4 years agoelm: fix Efl.Ui errors not being registered
Daniel Kolesa [Tue, 24 Sep 2019 17:17:28 +0000 (19:17 +0200)]
elm: fix Efl.Ui errors not being registered

The implementation is necessary, but it wasn't being generated
and included by mistake.

4 years agoeolian: remove support for globals
Daniel Kolesa [Tue, 24 Sep 2019 15:06:24 +0000 (17:06 +0200)]
eolian: remove support for globals

This was meant to happen but did not previously happen. It is not
ideal to do it now but better do it while we still can.

In short, this removes one half of the variables API (keeps
constants as they are) and repurposes the API to be only for
constants. This is also better for consistency to match errors.

4 years agoefl: remove remaining instances of .eo global variables
Daniel Kolesa [Tue, 24 Sep 2019 15:46:56 +0000 (17:46 +0200)]
efl: remove remaining instances of .eo global variables

4 years agoeolian: always allow implementation for eot files
Daniel Kolesa [Tue, 24 Sep 2019 16:17:59 +0000 (18:17 +0200)]
eolian: always allow implementation for eot files

This is so the build system can unconditionally generate .eot.c
without worrying whether there's something to generate.

4 years agoEfl.Ui.Layout_Pack: fix obvious uninitialized variable
Xavi Artigas [Tue, 24 Sep 2019 15:57:00 +0000 (17:57 +0200)]
Efl.Ui.Layout_Pack: fix obvious uninitialized variable

Why did this ever work?

4 years agodoc: update ecore_filter_model description
Wonki Kim [Tue, 24 Sep 2019 15:20:43 +0000 (17:20 +0200)]
doc: update ecore_filter_model description

Summary: this patch updates single line description of ecore_filter_model.(T7717)

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10103

4 years agoeolian: remove global vars from tests
Daniel Kolesa [Tue, 24 Sep 2019 14:17:11 +0000 (16:17 +0200)]
eolian: remove global vars from tests

4 years agoefl: use new eolian error functionality instead of globals
Daniel Kolesa [Tue, 24 Sep 2019 13:52:34 +0000 (15:52 +0200)]
efl: use new eolian error functionality instead of globals

Also enable referencing errors in docs.

4 years agodeclare first round of classes stable
Marcel Hollerbach [Mon, 9 Sep 2019 09:23:04 +0000 (11:23 +0200)]
declare first round of classes stable

this stabelizes the "stableized" column of the efl: api workboard.

fixes T8208,
fixes T8158,
fixes T8156,
fixes T8025,
fixes T8024,
fixes T7976,
fixes T7946,
fixes T7928,
fixes T7923,
fixes T7905,
fixes T7902,
fixes T7901,
fixes T7900,
fixes T7898,
fixes T7897,
fixes T7895,
fixes T7894,
fixes T7893,
fixes T7891,
fixes T7880,
fixes T7873,
fixes T7869,
fixes T7867,
fixes T7865,
fixes T7862,
fixes T7854,
fixes T7847,
fixes T7881,
fixes T7870,
fixes T9086

Differential Revision: https://phab.enlightenment.org/D10008

4 years agoefl_ui_collection: this interface is not event used
Marcel Hollerbach [Tue, 24 Sep 2019 13:16:45 +0000 (15:16 +0200)]
efl_ui_collection: this interface is not event used

Differential Revision: https://phab.enlightenment.org/D10108

4 years agoefl_ui_win: default the window type to basic
Marcel Hollerbach [Fri, 20 Sep 2019 12:57:09 +0000 (14:57 +0200)]
efl_ui_win: default the window type to basic

normally when you create a window, you just want to have it beeing a
basic window. If not you still can set the window type.

ref T8229

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10049

4 years agoefl: make Efl.Ui.Factory.release work in batches.
Cedric Bail [Mon, 16 Sep 2019 05:39:05 +0000 (22:39 -0700)]
efl: make Efl.Ui.Factory.release work in batches.

This will enable better strategy in scheduling removal of object from the cache
instead of doing the throttling in the View as there is a better understanding
of the different layer the items are going to go through and where they will
consume time.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9955

4 years agoelementary: rework Efl.Ui.Factory to have another additional stage during releasing...
Cedric Bail [Mon, 16 Sep 2019 03:52:50 +0000 (20:52 -0700)]
elementary: rework Efl.Ui.Factory to have another additional stage during releasing of items.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9954

4 years agoefl: simplify logic for widget created by factory.
Cedric Bail [Mon, 16 Sep 2019 03:50:05 +0000 (20:50 -0700)]
efl: simplify logic for widget created by factory.

In an attempt to make things more complex than they should have been,
I tried to change the inheritance tree on the fly and assume widget would
rely on autodeleting its children. This is way more complex of a solution
than to let the View actually release all the child manually and just set
the window as the default parent.h

Co-authored-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9953

4 years agoefl: split Efl.Ui.Factory.create stage into constructing and building
Marcel Hollerbach [Tue, 3 Sep 2019 12:48:58 +0000 (14:48 +0200)]
efl: split Efl.Ui.Factory.create stage into constructing and building

constructing is called during construction time, building is called
after finalize. This is usefull for theme related properties that can
only be set after the theme is applied, which happens during finalize.
Being event allow the user of the factory to add more initialization
without needing to implement any new class.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9952

4 years agoelementary: Efl.Ui.Layout_Factory bind property during widget creation.
Cedric BAIL [Fri, 23 Aug 2019 21:51:54 +0000 (14:51 -0700)]
elementary: Efl.Ui.Layout_Factory bind property during widget creation.

In the same vain as previous patch this will initialize more of the widget during its
creation and reduce unecessary recalc.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9951

4 years agoelementary: Efl.Ui.Image_Factory bind property also during widget creation.
Cedric BAIL [Fri, 23 Aug 2019 21:48:14 +0000 (14:48 -0700)]
elementary: Efl.Ui.Image_Factory bind property also during widget creation.

In the same vain as previous patch this will initialize more of the widget during its
creation and reduce unecessary recalc.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9950

4 years agoecore: update Efl.Boolean_Model to handle children removal and shifting all necessary...
Cedric Bail [Thu, 19 Sep 2019 02:31:39 +0000 (19:31 -0700)]
ecore: update Efl.Boolean_Model to handle children removal and shifting all necessary boolean and index.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10033

4 years agoecore: correctly handle children removal in Efl.Composite_Model by updating all requi...
Cedric Bail [Thu, 19 Sep 2019 02:31:05 +0000 (19:31 -0700)]
ecore: correctly handle children removal in Efl.Composite_Model by updating all required index.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10032

4 years agoefl_gfx_path: Add optimized path command
JunsuChoi [Tue, 24 Sep 2019 02:52:30 +0000 (11:52 +0900)]
efl_gfx_path: Add optimized path command

Summary:
If 'L' is removed due to optimization, it should be supported like 3b1f7be
If the previous command is 'M', use 'L'.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10104

Change-Id: I91c39e240bcfacce3ad59faaf3c2adc9bd747a07

4 years agoevas vg: fix gradient stroke fill memory leaks.
Hermet Park [Tue, 24 Sep 2019 02:46:50 +0000 (11:46 +0900)]
evas vg: fix gradient stroke fill memory leaks.

There were continous creation of gradient objects,
We can stop it by caching it properly,

Also, fix mismatched ref/unref counts.

4 years agoefl-mono: Additional blank line between all methods.
Bruno da Silva Belo [Mon, 23 Sep 2019 23:50:27 +0000 (20:50 -0300)]
efl-mono: Additional blank line between all methods.

Summary:
For better indentation, adding a blank line in the end of
methods.

Test Plan:
using efl_ui_layout.eo.cs, efl_access_object.eo.cs, efl_part.eo.cs and efl_ui_factory_bind.eo.cs as references,
apply changes to the code then check the diffs of after and before of the references files

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, felipealmeida, lauromoura

Tags: PHID-PROJ-uhnmnvlvunw6jgoqdnd4, #efl_language_bindings, #refactoring

Maniphest Tasks: T8167

Differential Revision: https://phab.enlightenment.org/D9712

4 years agoelm_conform: initialize variables for resizing part. 52/214552/2 submit/tizen/20190924.053902
Hosang Kim [Tue, 24 Sep 2019 03:48:08 +0000 (12:48 +0900)]
elm_conform: initialize variables for resizing part.

Change-Id: I21ef8eb27f6a2c37aaa5ae190d8869a1ce2ce4cb

4 years agoefl_gfx_path: Add optimized path command 50/214550/1
JunsuChoi [Tue, 24 Sep 2019 02:52:30 +0000 (11:52 +0900)]
efl_gfx_path: Add optimized path command

Summary:
If 'L' is removed due to optimization, it should be supported like 3b1f7be
If the previous command is 'M', use 'L'.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10104

Change-Id: I97478dffc8c1612d3e60e905f4af37de0b6e5d9d

4 years agoefl_gfx_path: Support 'l' command for optimized path. 49/214549/1
JunsuChoi [Tue, 24 Sep 2019 01:20:43 +0000 (10:20 +0900)]
efl_gfx_path: Support 'l' command for optimized path.

Summary:
If there is no 'l' command for path optimization, refer to the previous cmd.
If the previous command is 'm', use 'l'.

Test Plan:
[Example SVG]
'''
<svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 40 40">
<g fill="none" fill-rule="evenodd">
<rect width="40" height="40" fill="#f00" opacity="0"/>
<path d="m12 20 13-12-13 12zm0 0 13 12-13-12z" fill-rule="nonzero" opacity=".12" stroke="#fff" stroke-linecap="round" stroke-linejoin="round" stroke-width="2"/>
</g>
</svg>
'''

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10074

Change-Id: I0e78949fcd0fdbff1d7a7314735319c2ce9924d4

4 years agoeo_mono: remove Efl.Access.Reading_Info_Type_Mask from workaround.cs 81/214481/2
Jaehyun Cho [Mon, 23 Sep 2019 08:06:20 +0000 (17:06 +0900)]
eo_mono: remove Efl.Access.Reading_Info_Type_Mask from workaround.cs

Since Efl.Access.Reading_Info_Type_Mask is defined in
efl_access_object.eo, the previous definition in workaround.cs is
removed.

Change-Id: I080a5c928318a7ba990d76d3e71cb9e831599414

4 years agoefl_canvas_object: set default value to false for not breaking compatibility 34/214534/1
WooHyun Jung [Tue, 24 Sep 2019 01:15:21 +0000 (10:15 +0900)]
efl_canvas_object: set default value to false for not breaking compatibility

@tizen_fix

Change-Id: I56e28fd87d92f5f6605297e24687f58cb4341184

4 years agobuild: resolve build error during migration submit/tizen/20190923.215628
Jongmin Lee [Mon, 23 Sep 2019 21:49:02 +0000 (06:49 +0900)]
build: resolve build error during migration

gl_generic module should be copmpiled prior to the other modules.

@tizen_fix

Change-Id: I8be4330792836b4ba18b7b0b2493d950950b0227

4 years agodocs: Add documentation for Efl.Ui.Scroller
Xavi Artigas [Mon, 23 Sep 2019 20:51:17 +0000 (16:51 -0400)]
docs: Add documentation for Efl.Ui.Scroller

Summary:
These docs were missing.
Ref T7891

Test Plan: Only docs changed

Reviewers: zmike, woohyun, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7891

Differential Revision: https://phab.enlightenment.org/D10019

4 years agoosx - require full opengl for gl support on osx
Carsten Haitzler (Rasterman) [Mon, 23 Sep 2019 20:14:50 +0000 (21:14 +0100)]
osx - require full opengl for gl support on osx

the default still is gl-es as documented. you need to explicitly turn
on full opengl to get gl support on osx because thats all the engine
does. document this exception for osx (having gl magically being full
on osx and gle-es elsewhere is another option but then we need
different os specific defaults for this which is kind of bad in other
ways).

4 years agotheme: add 'required' to efl/tab_pager group parts
Xavi Artigas [Mon, 23 Sep 2019 20:09:36 +0000 (16:09 -0400)]
theme: add 'required' to efl/tab_pager group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10087

4 years agoefl_ui_pack: allow NULL as existing parameter in after and before
Marcel Hollerbach [Mon, 23 Sep 2019 20:03:26 +0000 (16:03 -0400)]
efl_ui_pack: allow NULL as existing parameter in after and before

Summary:
with this commit all implementations of Efl.Pack_Linear to permit NULL
as existing parameter, this is verified with a spec test unit.

fixes T8210

Reviewers: zmike, segfaultxavi

Reviewed By: zmike

Subscribers: woohyun, Jaehyun_Cho, YOhoho, segfaultxavi, zmike, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8210

Differential Revision: https://phab.enlightenment.org/D10023

4 years agodoc: wrap comment for EFL_UI_CLICKABLE_PART_BIND docs in edc
Mike Blumenkrantz [Mon, 23 Sep 2019 20:09:22 +0000 (22:09 +0200)]
doc: wrap comment for EFL_UI_CLICKABLE_PART_BIND docs in edc

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10089

4 years agoci - osx - switch to full gl option on osx
Carsten Haitzler (Rasterman) [Mon, 23 Sep 2019 19:54:35 +0000 (20:54 +0100)]
ci - osx - switch to full gl option on osx

4 years agotheme: add 'required' to efl/button:anchor group parts
Xavi Artigas [Mon, 23 Sep 2019 19:27:50 +0000 (15:27 -0400)]
theme: add 'required' to efl/button:anchor group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10086

4 years agotests: Initialize variables and quiet warning.
Lauro Moura [Mon, 23 Sep 2019 19:27:49 +0000 (15:27 -0400)]
tests: Initialize variables and quiet warning.

Summary: The switch does not cover all Align enum values.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10085

4 years agotheme: add 'required' to efl/spin_button group parts
Xavi Artigas [Mon, 23 Sep 2019 19:27:47 +0000 (15:27 -0400)]
theme: add 'required' to efl/spin_button group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10084

4 years agotheme: add 'required' to efl/timepicker parts
Xavi Artigas [Mon, 23 Sep 2019 19:27:45 +0000 (15:27 -0400)]
theme: add 'required' to efl/timepicker parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10083

4 years agoefl: improve test in checking the return value during Eina_Value get operation.
Cedric Bail [Mon, 23 Sep 2019 19:27:34 +0000 (15:27 -0400)]
efl: improve test in checking the return value during Eina_Value get operation.

Summary: Depends on D10061

Reviewers: zmike, bu5hm4n, SanghyeonLee, segfaultxavi, felipealmeida, lauromoura

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10062

4 years agodocs: Clarify behavior of NULL in Efl.Pack_Linear.
Xavi Artigas [Mon, 23 Sep 2019 19:27:14 +0000 (15:27 -0400)]
docs: Clarify behavior of NULL in Efl.Pack_Linear.

Summary: Depends on D10023

Reviewers: zmike, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8210

Differential Revision: https://phab.enlightenment.org/D10024

4 years agobuild - update README and meson options to match echother in defaults
Carsten Haitzler (Rasterman) [Mon, 23 Sep 2019 17:59:27 +0000 (18:59 +0100)]
build - update README and meson options to match echother in defaults

update some defaults like move to gl-es by default, tslib off by
default as this really makes efl simpler to confgure ... by default
with less things to change to get stuff working.

4 years agotheme: add 'required' to efl/bg group parts
Mike Blumenkrantz [Fri, 20 Sep 2019 17:38:08 +0000 (13:38 -0400)]
theme: add 'required' to efl/bg group parts

ref T8231

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10056

4 years agotheme: add 'required' to efl/popup (and related group) parts
Mike Blumenkrantz [Fri, 20 Sep 2019 17:38:21 +0000 (13:38 -0400)]
theme: add 'required' to efl/popup (and related group) parts

ref T8231

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10057

4 years agotheme: add 'required' to efl/scroller group parts
Mike Blumenkrantz [Fri, 20 Sep 2019 17:56:23 +0000 (13:56 -0400)]
theme: add 'required' to efl/scroller group parts

ref T8231

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10058

4 years agotheme: add 'required' to efl/datepicker parts
Mike Blumenkrantz [Fri, 20 Sep 2019 17:59:32 +0000 (13:59 -0400)]
theme: add 'required' to efl/datepicker parts

ref T8231

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10059

4 years agoefl_ui_position_manager: review cache accesses
Marcel Hollerbach [Sat, 21 Sep 2019 09:06:26 +0000 (11:06 +0200)]
efl_ui_position_manager: review cache accesses

in position manager grid and list, there are caches for the sizes, so
the access within placing the item is faster. The cache sometimes is
invalidated, which means, it must be rebuild before accessing it.

This commit is the result of reviewing all the accesses, that the
correct item is available.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10065

4 years agoefl_ui_focus_managr_sub: fix a err message
Marcel Hollerbach [Sat, 21 Sep 2019 09:09:24 +0000 (11:09 +0200)]
efl_ui_focus_managr_sub: fix a err message

with this commit there are a few errors less, for the case a object is
destroyed while registered as a border element in the sub manager.
This adds a few more callbacks to the list of callbacks, however, i
could not messure a big performance impact.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10067

4 years agoecore_thread: Fix arguments to match with the function call.
Woochanlee [Mon, 23 Sep 2019 06:17:45 +0000 (06:17 +0000)]
ecore_thread: Fix arguments to match with the function call.

see the _eina_thread_internal() function

r = c->func((void*) c->data, eina_thread_self());

The second param has been missed in ecore_thread_worker, ecore_direct_worker functions.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10073

4 years agobuild: fix EFL_VERSION_MICRO define
Mike Blumenkrantz [Mon, 23 Sep 2019 14:06:26 +0000 (10:06 -0400)]
build: fix EFL_VERSION_MICRO define

this was never pulled in from the build system and thus was never actually
defined

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10078

4 years agoefl_ui/layout: move 'frozen' struct member to be a bool bitflag
Mike Blumenkrantz [Mon, 23 Sep 2019 13:30:03 +0000 (09:30 -0400)]
efl_ui/layout: move 'frozen' struct member to be a bool bitflag

this is already handled by edje, all we really want here is a flag
to avoid more eo lookups internally when calling canvas_group_change

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10079

4 years agocxx: Fix some warnings from -Wextra
Lauro Moura [Mon, 23 Sep 2019 16:33:52 +0000 (13:33 -0300)]
cxx: Fix some warnings from -Wextra

Summary:
- As we don't have C++17's [[fallthrough]], rely on GCC'd detection
  of fallthrough comments.

  See https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/

- Replaced some copy constructors with typecast operators.

  Previously, a constructor with remove_const/remove_cv were used
  to allow const iterators to be constructed from non-const iterators.
  This had the side effect of making these constructors actual copy
  constructors for non const lists. As we did not define other
  special constructors/operators, the rule of 5 were violated for these
  cases.

  This commit replaces these constructors with actual typecast operators
  that promote non const iterators to their const counterparts.

- Cast a Eina_Bool/bool narrowing conversion

- Add a missing break statement from D10050

Reviewers: zmike, brunobelo, felipealmeida

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9934

4 years agodocs: Efl.Ui.Widget_Scroller_Content updated docs
Xavi Artigas [Mon, 23 Sep 2019 16:05:07 +0000 (18:05 +0200)]
docs: Efl.Ui.Widget_Scroller_Content updated docs

Summary: Ref T8254

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8254

Differential Revision: https://phab.enlightenment.org/D10082

4 years agoeina_array: do not mix declaration and definition
Vincent Torri [Mon, 23 Sep 2019 14:00:25 +0000 (14:00 +0000)]
eina_array: do not mix declaration and definition

fix warning when used in C90 code.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10077

4 years agogesture: fix it not to lose information by dividing
Wonki Kim [Fri, 20 Sep 2019 05:26:41 +0000 (05:26 +0000)]
gesture: fix it not to lose information by dividing

division of integer by integer results integer.
this patch fix the case to make a division result more precise.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10039

4 years agotheme: efl/photocam -> efl/image_zoomable
Mike Blumenkrantz [Fri, 20 Sep 2019 16:51:18 +0000 (12:51 -0400)]
theme: efl/photocam -> efl/image_zoomable

the theme group for a class should match its class name

ref T8231

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10052

4 years agotheme: remove dead popup theme groups
Mike Blumenkrantz [Fri, 20 Sep 2019 17:01:04 +0000 (13:01 -0400)]
theme: remove dead popup theme groups

these widgets were removed

ref T8231

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10054

4 years agoeina_log: ensure that we do not spam journald with our intree binaries
Marcel Hollerbach [Mon, 23 Sep 2019 12:11:51 +0000 (14:11 +0200)]
eina_log: ensure that we do not spam journald with our intree binaries

EFL_RUN_IN_TREE is set for all binaries that are executed during build
time, and test suites. With this commit we are ensuring that we are not
sending messages during that time to journald, otherwise we would waste
a lot of time + we would create a lot of unneccessary log messages.

(eina test suite runtime with journald hook: 11.21s without journald
hook: 0.57s)

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10076

4 years agoeolian: allow read-only stringshare in events
Daniel Kolesa [Mon, 23 Sep 2019 13:26:23 +0000 (15:26 +0200)]
eolian: allow read-only stringshare in events

While the type cannot be moved to the callee, it at least provides
a hint that it's a stringshare, leeting people ref it instead of
copying.

4 years agoci: add back target to do out-of-tree test build
Mike Blumenkrantz [Thu, 19 Sep 2019 13:28:57 +0000 (09:28 -0400)]
ci: add back target to do out-of-tree test build

this is necessary in order to ensure that our headers are usable

ref T8228

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10036

4 years agoelementary: unref objects when memory allocation fails in factory
Jaehyun Cho [Thu, 19 Sep 2019 09:49:39 +0000 (09:49 +0000)]
elementary: unref objects when memory allocation fails in factory

The objects referenced are unreferenced when memory allocation fails in
elementary factory.

Differential Revision: https://phab.enlightenment.org/D9968

4 years agoector engine: +null checking.
Hermet Park [Mon, 23 Sep 2019 12:12:07 +0000 (21:12 +0900)]
ector engine: +null checking.

Null pixels is allowed when drawing region is 0,

In that case, the pixel buffer can be destroyed earlier by vg.

@fix

4 years agoefl_ui_tab_pager: fix infinite selected calls
Jaehyun Cho [Mon, 23 Sep 2019 10:37:10 +0000 (19:37 +0900)]
efl_ui_tab_pager: fix infinite selected calls

Since tab_pager's _select() and tab_bar's _selection_change_cb() cause
calling each other infinitely.

4 years agoelm_test: mark image_zoomable test as non-legacy
Mike Blumenkrantz [Mon, 23 Sep 2019 10:56:11 +0000 (12:56 +0200)]
elm_test: mark image_zoomable test as non-legacy

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10053

4 years agoeina_log: do not fallback to INFO when we run with systemd support
Marcel Hollerbach [Mon, 23 Sep 2019 07:42:22 +0000 (09:42 +0200)]
eina_log: do not fallback to INFO when we run with systemd support

INFO is a way too verbose log domain, this lead to the fact that we
spammed journald before the first frame with ~200-300 messages
(depending on the setup) which is quite a lot. Additionally, this also
lead to the fact that we often TIMEOUT our own tests.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10075

4 years agoelementary_codegen: check before use to avoid use after free
Stefan Schmidt [Fri, 20 Sep 2019 10:11:39 +0000 (12:11 +0200)]
elementary_codegen: check before use to avoid use after free

These might or might not have been freed already, depending on the
breaks form the above loop. Before we are having a use after free here
better check on it before free'ing another time.

Coverity IDs: 1402671, 1402701

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10047

4 years agoefl_ui_exact_model: fix always true condition
Stefan Schmidt [Fri, 20 Sep 2019 09:19:51 +0000 (11:19 +0200)]
efl_ui_exact_model: fix always true condition

The tbuf binbuffer has already been freed the line above, which means
this condition would always be true as !tbuf would always result in true.
As a result the rest of the function has never been executed.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10046

4 years agoefl_ui_selection_manager: free allocated memory after local use
Stefan Schmidt [Fri, 20 Sep 2019 08:46:02 +0000 (10:46 +0200)]
efl_ui_selection_manager: free allocated memory after local use

This temporary allocation is only used in this block and goes out of
scope when leaving. Make sure we free the resource before this happens.

Coverity ID: 1402653

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10045

4 years agoefl_ui_textpath: make sure variables are not uses uninitialized
Stefan Schmidt [Fri, 20 Sep 2019 08:36:17 +0000 (10:36 +0200)]
efl_ui_textpath: make sure variables are not uses uninitialized

First and last could have been uninitialized for their first use in some
cases. Make sure we set the x y coordinates to 0 to begin with.

Coverity IDs: 1401458, 1404747

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10044

4 years agoefl_ui_scrollable: remove ui_scrollable_interactive and move all into ui_scrollable
WooHyun Jung [Mon, 23 Sep 2019 08:48:02 +0000 (10:48 +0200)]
efl_ui_scrollable: remove ui_scrollable_interactive and move all into ui_scrollable

Summary:
Based on the discussion T7883, there is no reason to keep those
interfaces separately. So, now, efl_ui_scrollable will support
the events and methods together.

@ref T7883

Reviewers: eagleeye, bu5hm4n, zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7883

Differential Revision: https://phab.enlightenment.org/D10072

4 years agotest: Add a logic to check a size of Check
Wonki Kim [Sat, 21 Sep 2019 04:28:24 +0000 (04:28 +0000)]
test: Add a logic to check a size of Check

If I pack a check without any api calls into a box,
then it doesn't have the hint_min size which is defined on check edc.
I guess there are problems on sizing logic currently, so this patch helps people
to test the problem.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10038

4 years agoelm/layout: remove check for finalize in efl_canvas_group_change impl
Mike Blumenkrantz [Fri, 20 Sep 2019 13:04:16 +0000 (09:04 -0400)]
elm/layout: remove check for finalize in efl_canvas_group_change impl

this used to be a thing in order to prevent widgets from spamming themselves
with recalcs during construction, but since that's no longer possible we
can remove this and also resolve an issue where legacy widgets failed
to correctly calculate their min size if no text was set

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10043

4 years agoUse EFL version for doc tarball, not meson version
Ross Vandegrift [Sun, 22 Sep 2019 23:30:25 +0000 (23:30 +0000)]
Use EFL version for doc tarball, not meson version

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10070

4 years agodocs: Typos in Efl.Object
Xavi Artigas [Mon, 23 Sep 2019 08:41:46 +0000 (10:41 +0200)]
docs: Typos in Efl.Object

4 years agoefl_ui : fix possible memory leak on model compressing
SangHyeon Jade Lee [Fri, 20 Sep 2019 01:40:01 +0000 (10:40 +0900)]
efl_ui : fix possible memory leak on model compressing

Summary: fix memory leak of model compressing on binbuf and allocated data.

Reviewers: cedric, bu5hm4n, zmike

Reviewed By: cedric, zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10037

4 years agogenlist: skip unnecessary process call while genlist clearing 82/212782/3
SangHyeon Jade Lee [Tue, 27 Aug 2019 01:21:36 +0000 (10:21 +0900)]
genlist: skip unnecessary process call while genlist clearing

item_process is calling while genlist clearing when
the item is relatvely added.

skiping unnecessary process calls improve deletion performances.

Change-Id: Ic12c4ea190799a79fb2f369569b453d5061f8019
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
4 years agoelementary: fix derefrenced pointer accessing on adjusting item 92/214292/2
SangHyeon Jade Lee [Fri, 20 Sep 2019 01:55:26 +0000 (10:55 +0900)]
elementary: fix derefrenced pointer accessing on adjusting item

Change-Id: I2392de287318168c1097aa6826e0a54190bb8b3a
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
4 years agoelementary: prevent zero-division in gengrid internal circle patch position calculate 91/214291/2
SangHyeon Jade Lee [Fri, 20 Sep 2019 01:51:09 +0000 (10:51 +0900)]
elementary: prevent zero-division in gengrid internal circle patch position calculate

Change-Id: I130deac7a6b04d1bdb07aae1f51f10508162e4ee
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
4 years agobuild: resolve build error during migration submit/tizen/20190923.005744
Jongmin Lee [Sun, 22 Sep 2019 21:22:39 +0000 (06:22 +0900)]
build: resolve build error during migration

Change-Id: Id3d2437e84e3dbbebc45ff784f7e4b6345be7dc3

4 years agoefl_ui_collection: protect against invalid access
Marcel Hollerbach [Sat, 21 Sep 2019 09:08:46 +0000 (11:08 +0200)]
efl_ui_collection: protect against invalid access

i am not sure why this should ever happen. However, a error here is
better than a access out of the bounds of the array.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10066

4 years agoefl_ui_bg: implement load_controller and efl.gfx.image via composition
Marcel Hollerbach [Sat, 21 Sep 2019 08:15:18 +0000 (10:15 +0200)]
efl_ui_bg: implement load_controller and efl.gfx.image via composition

With this commit the API of load controller and efl.gfx.image is
implemented via composition, which makes eolians API checker happy

ref T7880

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10064

4 years agoefl_gfx_image: remove ptr()
Marcel Hollerbach [Sat, 21 Sep 2019 15:53:53 +0000 (17:53 +0200)]
efl_gfx_image: remove ptr()

this is not needed here, and not permitted in a none beta context.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10069

4 years agoefl_ui_image: implement Efl.Gfx.Image and Efl.Gfx.Image_Load_Controller
Marcel Hollerbach [Sat, 21 Sep 2019 15:37:07 +0000 (17:37 +0200)]
efl_ui_image: implement Efl.Gfx.Image and Efl.Gfx.Image_Load_Controller

at first i tried to implement that with composition, however, this does
not work, caused by the fact that the edje_object does not implement
efl.gfx.image nor load controller. which would mean i would have to
differentiate based on the type what kind of composition i would attach,
additionally, i would have to write an additional object which would
implement the correct behaviour.

To shortcut this overdone approach, this commit simply implements the
APIs in the image object.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10068

4 years agoelementary: make our tests work again
Marcel Hollerbach [Sat, 21 Sep 2019 11:10:53 +0000 (13:10 +0200)]
elementary: make our tests work again

73219114682f64fdbfe0809be3f2d991016dd3f1 moved the constructor to to
top, which leads to the fact that a few widgets cannot fetch the shared
data of the window. Which made the test suite fail.

With this commit we are just moving the sub_object_add after the
constructor, which fixes the flip crash.
This fixes the test suite

4 years agoefl ui widget - call parent constructor before doing more init
Carsten Haitzler (Rasterman) [Sat, 21 Sep 2019 09:26:46 +0000 (10:26 +0100)]
efl ui widget - call parent constructor before doing more init

the object is not properly set up yet for child classes -0 parent like
the main evas object or smart obj havent been constructed yet so call
this really early, not in the middle of construction of an efl ui
widget...

this fixes a segv in elementary_test -to filp where it segv's on
object construction where evas object ->cur/prev are NULL (not set up
yet).

4 years agocsharp: Guard hash usage behind EFL_BETA.
Lauro Moura [Fri, 20 Sep 2019 22:22:22 +0000 (19:22 -0300)]
csharp: Guard hash usage behind EFL_BETA.

Summary: After 718f3cd49586, hashes are currently beta-only.

Reviewers: zmike, brunobelo

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10060

4 years agoeolian_mono: add more verbs to generate C# method beginning with verb
Jaehyun Cho [Fri, 20 Sep 2019 22:14:02 +0000 (19:14 -0300)]
eolian_mono: add more verbs to generate C# method beginning with verb

Summary:
C# language binding generates C# method name beginning with verb by
checking verb list in name_helpers.hh.

Some verbs used in eo method are missing in the current verb list. So
they are added into the verb list.

In this scheme, there is a problem that some words can be used as a verb
in some methods but they also can be used as a noun in other methods.
(e.g. drag_start as a verb / cursor_word_start as a noun)

So "start" and "scroll" are not added to verb list in this patch.
To resolve the above problem, we may need a new eo syntax to rename or
reverse the name in language bindings.

Test Plan: Check C# method names in .eo.cs files if the name begins with verb.

Reviewers: felipealmeida, SanghyeonLee, woohyun, Jaehyun_Cho, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10001

4 years agoRevert "build: resolve build error"
Jongmin Lee [Fri, 20 Sep 2019 21:26:32 +0000 (06:26 +0900)]
Revert "build: resolve build error"

This reverts commit 11d6f49658f44a2ad09a76fa28095077a1b438a1.

4 years agoeolian: rename any_value_ptr -> any_value_ref for consistency
Daniel Kolesa [Fri, 20 Sep 2019 16:02:07 +0000 (18:02 +0200)]
eolian: rename any_value_ptr -> any_value_ref for consistency

4 years agoeolian: string(share) is always const, allow in events out of box
Daniel Kolesa [Fri, 20 Sep 2019 15:46:56 +0000 (17:46 +0200)]
eolian: string(share) is always const, allow in events out of box

4 years agoeolian: make hashes beta-only for now
Daniel Kolesa [Fri, 20 Sep 2019 15:03:58 +0000 (17:03 +0200)]
eolian: make hashes beta-only for now

They're not completely settled on and we don't even know if we want
them at all. So let's make them beta only for now.

Ref T8050.

4 years agoUse proper Eolian syntax for default values instead of docs
Xavi Artigas [Fri, 20 Sep 2019 14:38:18 +0000 (11:38 -0300)]
Use proper Eolian syntax for default values instead of docs

Summary:
Eolian supports reporting the defaults for parameters and return values, but in some
places we have been writing this information in the documentation instead.
This patch moves it to its proper place, where documentation generators can pick it up
and render it in a consistent manner.

Ref T8171

Reviewers: zmike, bu5hm4n, lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8171

Differential Revision: https://phab.enlightenment.org/D10051

4 years agocsharp: Add support for default param references in documentation
Lauro Moura [Fri, 20 Sep 2019 14:05:01 +0000 (16:05 +0200)]
csharp: Add support for default param references in documentation

Summary:
This also adds the information of default values in `parameter_def`.
This will help adding actual default parameter support in the C#
bindings.

Thanks to @segfaultxavi for improved formatting and escaping.

Fixes T8224

Reviewers: segfaultxavi, felipealmeida, brunobelo

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, segfaultxavi, #committers

Tags: #efl

Maniphest Tasks: T8224

Differential Revision: https://phab.enlightenment.org/D10050