Behdad Esfahbod [Thu, 24 Jan 2019 15:12:52 +0000 (16:12 +0100)]
Comment
Behdad Esfahbod [Thu, 24 Jan 2019 15:11:05 +0000 (16:11 +0100)]
Fix test
Behdad Esfahbod [Thu, 24 Jan 2019 15:08:33 +0000 (16:08 +0100)]
Form cluster for Emoji sub-region tag sequences
Fixes https://github.com/harfbuzz/harfbuzz/issues/1556
Behdad Esfahbod [Thu, 24 Jan 2019 11:50:38 +0000 (12:50 +0100)]
Fix macos tests with previous commit
Behdad Esfahbod [Thu, 24 Jan 2019 11:08:23 +0000 (12:08 +0100)]
Adjust mark offsets when zeroing from fallback mark positioning code
Adjust tests.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1532
Behdad Esfahbod [Wed, 23 Jan 2019 19:53:57 +0000 (20:53 +0100)]
[AAT] In InsertionChain, set mark to previous-position if inserting
Fixes MORX-31
Behdad Esfahbod [Wed, 23 Jan 2019 19:45:18 +0000 (20:45 +0100)]
[AAT] Re-enable tests MORX-31 and MORX-41
Behdad Esfahbod [Wed, 23 Jan 2019 19:36:07 +0000 (20:36 +0100)]
[AAT] Remove mark_set from InsertionChain
Behdad Esfahbod [Wed, 23 Jan 2019 19:30:48 +0000 (20:30 +0100)]
[test/text-rendering-tests] Update from upstream
Behdad Esfahbod [Tue, 22 Jan 2019 15:36:00 +0000 (16:36 +0100)]
More of previous
Behdad Esfahbod [Tue, 22 Jan 2019 15:30:07 +0000 (16:30 +0100)]
Fix sign-compare error resulted from promoting unsigned integers to signed larger ints
Clang and gcc know not to warn in these cases, but not nonmainstream compilers
Behdad Esfahbod [Tue, 22 Jan 2019 11:55:29 +0000 (12:55 +0100)]
Cast HB_UNTAG results to uint8_t
Behdad Esfahbod [Tue, 22 Jan 2019 11:52:23 +0000 (12:52 +0100)]
More -Wcast-error fix
Behdad Esfahbod [Tue, 22 Jan 2019 11:45:40 +0000 (12:45 +0100)]
Better fix for -Wcast-align errors
Behdad Esfahbod [Tue, 22 Jan 2019 11:43:12 +0000 (12:43 +0100)]
More -Wcast-error fixes
Behdad Esfahbod [Tue, 22 Jan 2019 11:40:18 +0000 (12:40 +0100)]
pragma GCC diagnostic error "-Wsign-compare"
Behdad Esfahbod [Tue, 22 Jan 2019 11:34:05 +0000 (12:34 +0100)]
Fix cast-align error
If compiler doesn't inline StructAtOffset, this was an error since we
only disable cast-align at call-site. So, move the cast out.
../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:146:85: required from here
../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:147:79: required from here
../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Behdad Esfahbod [Tue, 22 Jan 2019 11:29:05 +0000 (12:29 +0100)]
[CI] Remove gcc 4.2 bots
We don't support that version anymore.
Behdad Esfahbod [Tue, 22 Jan 2019 11:15:23 +0000 (12:15 +0100)]
Convert all other enum class consts to static constexpr
Fixes https://github.com/harfbuzz/harfbuzz/issues/1553
Behdad Esfahbod [Tue, 22 Jan 2019 11:11:24 +0000 (12:11 +0100)]
Convert unsigned enum class consts to static constexpr
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
Behdad Esfahbod [Tue, 22 Jan 2019 11:08:57 +0000 (12:08 +0100)]
Convert tag enum class consts to static constexpr
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
Behdad Esfahbod [Tue, 22 Jan 2019 11:07:43 +0000 (12:07 +0100)]
Convert boolean enum class consts to static constexpr
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
Behdad Esfahbod [Tue, 22 Jan 2019 11:05:35 +0000 (12:05 +0100)]
Make some enum constants unsigned
Behdad Esfahbod [Tue, 22 Jan 2019 11:02:06 +0000 (12:02 +0100)]
Whitespace
Behdad Esfahbod [Tue, 22 Jan 2019 11:00:44 +0000 (12:00 +0100)]
pragma GCC diagnostic error "-Wvla"
Alfie John [Tue, 22 Jan 2019 08:58:36 +0000 (19:58 +1100)]
Fix grammar
Alfie John [Tue, 22 Jan 2019 00:03:02 +0000 (00:03 +0000)]
Grammar fix
Behdad Esfahbod [Mon, 21 Jan 2019 01:09:10 +0000 (20:09 -0500)]
Remove wrongly added files
Behdad Esfahbod [Mon, 21 Jan 2019 00:51:08 +0000 (19:51 -0500)]
Use enum for class constant
Behdad Esfahbod [Mon, 21 Jan 2019 00:49:59 +0000 (19:49 -0500)]
[CFF] Use enum for tableTag
Behdad Esfahbod [Mon, 21 Jan 2019 00:47:52 +0000 (19:47 -0500)]
Use static constexpr for large class constants
Khaled Hosny [Mon, 21 Jan 2019 14:44:48 +0000 (16:44 +0200)]
Regular spaces will do
Alfie John [Mon, 21 Jan 2019 05:00:01 +0000 (05:00 +0000)]
Adding leading space for code example
Alfie John [Mon, 21 Jan 2019 04:54:27 +0000 (04:54 +0000)]
Fix description of example
Alfie John [Mon, 21 Jan 2019 04:47:05 +0000 (04:47 +0000)]
Added option to build docs to docs
Behdad Esfahbod [Sat, 19 Jan 2019 14:20:46 +0000 (09:20 -0500)]
Fix sign compare warnings
../../third_party/harfbuzz-ng/src/src/hb-map.hh(56,45): warning: comparison of integers of different signs: 'const hb_codepoint_t' (aka 'const unsigned int') and 'hb_map_t::(anonymous enum at ../../third_party/harfbuzz-ng/src/src/hb-map.hh:169:3)' [-Wsign-compare]
bool is_unused () const { return key == INVALID; }
Behdad Esfahbod [Sat, 19 Jan 2019 14:18:03 +0000 (09:18 -0500)]
Fix warning
warning: '_WIN64' is not defined, evaluates to 0 [-Wundef]
Ebrahim Byagowi [Sat, 19 Jan 2019 13:00:07 +0000 (16:30 +0330)]
[dwrite] Fix delete-non-virtual-dtor warning (#1550)
Behdad Esfahbod [Fri, 18 Jan 2019 19:59:18 +0000 (14:59 -0500)]
Remove TRACE_COLLECT_GLYPHS
Behdad Esfahbod [Fri, 18 Jan 2019 19:53:54 +0000 (14:53 -0500)]
[pragma] Only add if GCC or clang
Behdad Esfahbod [Fri, 18 Jan 2019 18:45:33 +0000 (13:45 -0500)]
[directwrite] More fix
Ebrahim Byagowi [Fri, 18 Jan 2019 18:25:21 +0000 (21:55 +0330)]
[dwrite] Try to fix delete-non-virtual-dtor warnings
Fixes #1548 hopefully
Behdad Esfahbod [Fri, 18 Jan 2019 17:53:06 +0000 (12:53 -0500)]
Remove tracing from closure
Behdad Esfahbod [Fri, 18 Jan 2019 17:48:01 +0000 (12:48 -0500)]
Fix -Wundef errors with __GNUC__
Fixes https://github.com/harfbuzz/harfbuzz/issues/1549
Michiharu Ariza [Fri, 18 Jan 2019 17:43:51 +0000 (09:43 -0800)]
init interp_env_t::hintmask_size
fixes issue #1547
Behdad Esfahbod [Fri, 18 Jan 2019 17:23:02 +0000 (12:23 -0500)]
[pragma] Enable error -Wdelete-non-virtual-dtor
Currently fails directwrite backend.
Behdad Esfahbod [Fri, 18 Jan 2019 17:22:07 +0000 (12:22 -0500)]
[directwrite] Fix error
hb-directwrite.cc: In constructor 'TextAnalysis::TextAnalysis(const wchar_t*, uint32_t, const wchar_t*, DWRITE_READING_DIRECTION)':
hb-directwrite.cc:489:18: error: 'TextAnalysis::mText' will be initialized after [-Werror=reorder]
const wchar_t* mText;
^~~~~
hb-directwrite.cc:488:12: error: 'uint32_t TextAnalysis::mTextLength' [-Werror=reorder]
uint32_t mTextLength;
^~~~~~~~~~~
hb-directwrite.cc:282:3: error: when initialized here [-Werror=reorder]
TextAnalysis (const wchar_t* text, uint32_t textLength,
^~~~~~~~~~~~
hb-directwrite.cc: In function 'hb_bool_t _hb_directwrite_shape_full(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, const hb_feature_t*, unsigned int, float)':
Behdad Esfahbod [Fri, 18 Jan 2019 15:08:23 +0000 (10:08 -0500)]
[pragma] More cast-align whitelist
Behdad Esfahbod [Fri, 18 Jan 2019 15:03:43 +0000 (10:03 -0500)]
[pragma] Allow cast-align in hb-font.cc
../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:144:85: required from here
../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:145:79: required from here
../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = int]':
Behdad Esfahbod [Fri, 18 Jan 2019 14:59:36 +0000 (09:59 -0500)]
[pragma] GCC diagnostic error "-Wreorder"
Behdad Esfahbod [Fri, 18 Jan 2019 14:53:16 +0000 (09:53 -0500)]
[pragma] GCC diagnostic warning "-Wmaybe-uninitialized"
Behdad Esfahbod [Fri, 18 Jan 2019 14:49:14 +0000 (09:49 -0500)]
[pragma] Massage more
Behdad Esfahbod [Fri, 18 Jan 2019 14:46:17 +0000 (09:46 -0500)]
[pragma] More
Behdad Esfahbod [Fri, 18 Jan 2019 14:28:22 +0000 (09:28 -0500)]
[pragma] Reorg again
https://github.com/harfbuzz/harfbuzz/issues/1546
Behdad Esfahbod [Fri, 18 Jan 2019 13:49:45 +0000 (08:49 -0500)]
[pragma] GCC diagnostic ignored "-Wunknown-warning-option"
Try at fixing https://github.com/harfbuzz/harfbuzz/issues/1546
Behdad Esfahbod [Fri, 18 Jan 2019 00:58:54 +0000 (19:58 -0500)]
[uniscribe] More warnings
Behdad Esfahbod [Fri, 18 Jan 2019 00:57:17 +0000 (19:57 -0500)]
[uniscribe] Fix warnings
Behdad Esfahbod [Fri, 18 Jan 2019 00:52:32 +0000 (19:52 -0500)]
Fix build
Behdad Esfahbod [Fri, 18 Jan 2019 00:33:41 +0000 (19:33 -0500)]
[pragma] GCC diagnostic ignored "-Wclass-memaccess"
Behdad Esfahbod [Fri, 18 Jan 2019 00:12:07 +0000 (19:12 -0500)]
[ci] Remove unnecessary warning declarations
clang -Weverything still left to be ported to pragmas
Behdad Esfahbod [Fri, 18 Jan 2019 00:03:33 +0000 (19:03 -0500)]
[pragma] ignored -Wunsafe-loop-optimizations // TODO fix
Behdad Esfahbod [Fri, 18 Jan 2019 00:02:06 +0000 (19:02 -0500)]
[pragma] error -Wclass-memaccess
Behdad Esfahbod [Thu, 17 Jan 2019 23:55:03 +0000 (18:55 -0500)]
[pragma] More
Behdad Esfahbod [Thu, 17 Jan 2019 23:47:32 +0000 (18:47 -0500)]
[pragma] More
Behdad Esfahbod [Thu, 17 Jan 2019 23:36:10 +0000 (18:36 -0500)]
[pragma] Flesh out more
Behdad Esfahbod [Thu, 17 Jan 2019 23:24:18 +0000 (18:24 -0500)]
Use NNOffsetTo<> in rest of places
Behdad Esfahbod [Thu, 17 Jan 2019 23:17:04 +0000 (18:17 -0500)]
Use NNOffsetTo<>
Behdad Esfahbod [Thu, 17 Jan 2019 23:10:38 +0000 (18:10 -0500)]
Add NNOffsetTo<>
Behdad Esfahbod [Thu, 17 Jan 2019 22:56:27 +0000 (17:56 -0500)]
[AAT] Comment
Behdad Esfahbod [Thu, 17 Jan 2019 22:49:55 +0000 (17:49 -0500)]
Comment
Behdad Esfahbod [Thu, 17 Jan 2019 22:47:29 +0000 (17:47 -0500)]
[AAT] Remove unused code
Behdad Esfahbod [Thu, 17 Jan 2019 22:44:39 +0000 (17:44 -0500)]
[AAT] Allow null in ankr lookupTable offset
Behdad Esfahbod [Thu, 17 Jan 2019 22:42:44 +0000 (17:42 -0500)]
[pragma GCC] Ignore -Wtype-limits
Behdad Esfahbod [Thu, 17 Jan 2019 21:07:27 +0000 (16:07 -0500)]
[ci] Remove -Werror from Travis
hb-machinery.hh:111:37: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Also ignore -Wtype-limits.
Behdad Esfahbod [Thu, 17 Jan 2019 20:27:31 +0000 (15:27 -0500)]
More GCC pragmas
Behdad Esfahbod [Thu, 17 Jan 2019 20:22:46 +0000 (15:22 -0500)]
Rename macro
Behdad Esfahbod [Thu, 17 Jan 2019 20:22:28 +0000 (15:22 -0500)]
Add more GCC warning pragmas
Behdad Esfahbod [Thu, 17 Jan 2019 20:08:36 +0000 (15:08 -0500)]
Move -Wcast-align to hb.hh
Behdad Esfahbod [Thu, 17 Jan 2019 20:04:44 +0000 (15:04 -0500)]
Add pragram GCC diagnostic ignored "-Wunused-macros"
Behdad Esfahbod [Thu, 17 Jan 2019 19:54:32 +0000 (14:54 -0500)]
[AAT] Fully sanitize ankr table at sanitize time
Third try to fix access. Followup
6879efc2c1596d11a6a6ad296f80063b558d5e0f
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
Behdad Esfahbod [Thu, 17 Jan 2019 19:06:37 +0000 (14:06 -0500)]
[AAT] Fix anchor bound checking, again
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
Behdad Esfahbod [Thu, 17 Jan 2019 19:06:32 +0000 (14:06 -0500)]
[aat] Minor
Behdad Esfahbod [Tue, 15 Jan 2019 18:58:19 +0000 (13:58 -0500)]
Improve overflow avoidance
Better fix for
480406cd3ef9e5ab8476ddfa04498bf23906c508
This way we behave the same on 32bit and 64bit archs.
Behdad Esfahbod [Tue, 15 Jan 2019 02:23:17 +0000 (18:23 -0800)]
fix FDSelect fuzzing bug (#1539)
Rewrote struct FDSelect3_4.ranges as ArrayOf
Updated FDSelect3_4::sanitize () to call ranges.sanitize ()
nRanges now a function to return a reference to ranges.len
Behdad Esfahbod [Tue, 15 Jan 2019 01:45:31 +0000 (20:45 -0500)]
Move _POSIX_SOURCE definition
Fixes https://github.com/harfbuzz/harfbuzz/issues/1308
Behdad Esfahbod [Mon, 14 Jan 2019 20:31:31 +0000 (15:31 -0500)]
[test] Add test for previous commit
Behdad Esfahbod [Mon, 14 Jan 2019 20:27:34 +0000 (15:27 -0500)]
Fix assertion on address overflow
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=917031
Behdad Esfahbod [Mon, 14 Jan 2019 20:09:14 +0000 (15:09 -0500)]
[AAT] Fix mort ContextualSubtable offset access
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12312
Behdad Esfahbod [Mon, 14 Jan 2019 19:37:36 +0000 (14:37 -0500)]
[AAT] Fix ankr table access
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=918340
Michiharu Ariza [Fri, 11 Jan 2019 23:27:35 +0000 (15:27 -0800)]
deleted a duplicate fontdicts_mod.fini() call (#1538)
Ebrahim Byagowi [Wed, 9 Jan 2019 12:31:11 +0000 (16:01 +0330)]
Add an initial .clang-format config
There are things can be improved on clang-format side I guess before
the full assertion, but is the best we can get for now I guess.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1536
Ebrahim Byagowi [Wed, 9 Jan 2019 12:26:32 +0000 (15:56 +0330)]
Minor, hack .editorconfig for vscode use
As VSCode and Atom https://github.com/Microsoft/vscode/issues/44438 don't support it
Michiharu Ariza [Tue, 8 Jan 2019 20:37:48 +0000 (12:37 -0800)]
fix leak in subset_enc_supp_codes (#1537)
oss-fuzz issue 12310
Ebrahim Byagowi [Fri, 4 Jan 2019 19:40:39 +0000 (23:10 +0330)]
[ci] Enable more of GCC compile warnings (#1533)
Nathan Willis [Mon, 3 Dec 2018 18:49:44 +0000 (12:49 -0600)]
Usermanual: small formatting and wording fixes.
Nathan Willis [Wed, 28 Nov 2018 19:48:38 +0000 (13:48 -0600)]
Usermanual: small updates.
cclauss [Mon, 31 Dec 2018 03:30:43 +0000 (04:30 +0100)]
CircleCI: Test for Python 3 syntax errors and undefined names (#1522)
Catch missing imports and errors like #1520 and #1521
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
Behdad Esfahbod [Sun, 30 Dec 2018 16:27:42 +0000 (11:27 -0500)]
Fix automake warnings
[skip ci]
cclauss [Sun, 30 Dec 2018 12:07:28 +0000 (13:07 +0100)]
print() is a function in Python 3 (#1520)
cclauss [Sun, 30 Dec 2018 11:58:34 +0000 (12:58 +0100)]
Python 3 fixes to gen-os2-unicode-ranges.py (#1521)
In Python 3, __reload()__ was moved and __sys.setdefaultencoding()__ because the default is already utf-8. Also __Error()__ is an _undefined name_ and __Exception()__ creates a generic exception.