Hermet Park [Thu, 19 Sep 2019 04:59:05 +0000 (13:59 +0900)]
evas mask: refactoring code.
This clearly separate the condition cases clear so that
the analizyer tool doesn't bother us anymore.
No logical changes.
Change-Id: I8e543993bec16270b81031264c1ddb771a0c825f
Hermet Park [Thu, 19 Sep 2019 04:39:48 +0000 (13:39 +0900)]
evas gl: remove unnecessary null check.
If we check reference validation, the rest of other usage
should keep the reference check as well.
Remove it since gl prorgram must be valid always here
to shutdown the static analyzer reporting this suspicous logic.
Change-Id: I26aea9b29756e36d36d5ea18415f07905849ffd9
Hermet Park [Thu, 19 Sep 2019 04:24:08 +0000 (13:24 +0900)]
evas map: disable the anti_aliasing code which can't be reached.
This anti-aliasing is a little buggy, should be improved.
But just leaving to fix later when it's necessary.
Change-Id: I00f4800e77562dc156b997a8206982f92fcc1d2d
Daniel Kolesa [Wed, 18 Sep 2019 17:46:58 +0000 (19:46 +0200)]
eolian: disallow void for out/inout for stable API
Mike Blumenkrantz [Thu, 5 Sep 2019 14:53:59 +0000 (10:53 -0400)]
tests/elm: add eventing test for normal check widget, verify api compatibility
legacy check widgets should not emit a "changed" event when using the api to
change the widget's state
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9852
Mike Blumenkrantz [Tue, 3 Sep 2019 18:56:24 +0000 (14:56 -0400)]
tests/check: add unit test for elm_toggle (check) callback
verify that the "changed" callback is triggered as expected
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9832
Mike Blumenkrantz [Wed, 18 Sep 2019 16:02:35 +0000 (12:02 -0400)]
elm/check: fix emission of legacy "changed" callback
legacy "check" and "toggle" widgets operate differently:
* check emits only the "toggle" event
* toggle emits "toggle", "on", "off"
legacy also must not emit events when the widget's state is changed
programmatically
to handle this effectively, check whether the event has been emitted for
each state when the signal is emitted from the theme, and track this
for subsequent uses to ensure that exactly one event is triggered
when it should be
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9831
Mike Blumenkrantz [Tue, 17 Sep 2019 18:00:19 +0000 (14:00 -0400)]
efl/radio/box: handle non-radio-objects
this improves the usefulness of radio box by presenting it as a box widget
which has the additional feature of being able to manage radio widgets
also fix all the image cases in elm_test which relied on there being only
a single box in the window
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9998
Mike Blumenkrantz [Mon, 16 Sep 2019 19:22:33 +0000 (15:22 -0400)]
build: firmly split legacy and unified API into Efl_Ui.h and Elementary.h
these headers should be usable independently without having one secretly
pull in the other
fix T7667
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9981
Mike Blumenkrantz [Mon, 16 Sep 2019 19:22:03 +0000 (15:22 -0400)]
build: remove efl_ui_calendar.h
this was somehow actually a legacy header which duplicated elm_calendar.h
...sort of
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9980
Mike Blumenkrantz [Mon, 16 Sep 2019 19:17:15 +0000 (15:17 -0400)]
build: use correct animation_view headers in Efl_Ui.h and Elementary.h
efl_ui_animation_view.h is the legacy header (but why?)
efl_ui_animation_view.eo.h is the unified header
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9979
Mike Blumenkrantz [Mon, 16 Sep 2019 19:10:34 +0000 (15:10 -0400)]
build: fix elm header usage
.c files in src/lib/elementary should only include elm_priv.h to ensure
that all the include ordering is correct and that all necessary headers
are pulled in
.c files outside of src/lib/elementary should include either/both
Efl_Ui.h, Elementary.h as needed
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9978
Mike Blumenkrantz [Mon, 16 Sep 2019 19:09:27 +0000 (15:09 -0400)]
elm/priv: fix this header
this should include emotion, since that component is used internally,
and it should not explicitly include api headers which should be in
public headers
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9977
Mike Blumenkrantz [Mon, 16 Sep 2019 19:08:13 +0000 (15:08 -0400)]
elm/widget: make this header usable without elm_priv.h again
supposedly this header should be usable if someone wants to create an
elm widget, so ensure that it can be included without issues
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9976
Mike Blumenkrantz [Mon, 16 Sep 2019 19:07:38 +0000 (15:07 -0400)]
efl_ui/image_zoomable: include header for internal pan
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9975
Mike Blumenkrantz [Mon, 16 Sep 2019 18:59:56 +0000 (14:59 -0400)]
elm/scrollable: unbreak this header
this is a legacy header, it can't include any unified api types
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9974
Mike Blumenkrantz [Mon, 16 Sep 2019 18:59:28 +0000 (14:59 -0400)]
build: add include guards for a couple elm headers
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9973
Mike Blumenkrantz [Mon, 16 Sep 2019 18:57:49 +0000 (14:57 -0400)]
efl_ui/win: fix prototype decls for eo api versions of autodel
this is still pretty broken, but at least the headers aren't
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9972
Mike Blumenkrantz [Mon, 16 Sep 2019 18:53:54 +0000 (14:53 -0400)]
build: use legacy api in places where legacy should be used
these seem to randomly have been changed when they shouldn't have
also install elm_clock_eo.h since this is required but we didn't install it
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9971
Xavi Artigas [Wed, 18 Sep 2019 14:05:17 +0000 (16:05 +0200)]
TABS
Hermet Park [Wed, 18 Sep 2019 12:51:14 +0000 (21:51 +0900)]
canvas vg: code refactoring.
remove unnecessary reference cooridnates.
Wonki Kim [Wed, 18 Sep 2019 12:21:02 +0000 (08:21 -0400)]
elm_config: fix to check if eet_open fails
Summary: this patch adds a guard block in case of failure of eet_open().
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9987
Marcel Hollerbach [Wed, 18 Sep 2019 12:21:00 +0000 (08:21 -0400)]
Revert "efl_io_model: remove custom counting logic"
Summary:
This reverts commit
d794a0d3d95c3addcb21df75606c444c6e3ed6d8.
This breaks Efl_Io_Model.
Reviewers: cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10003
Xavi Artigas [Wed, 18 Sep 2019 11:40:32 +0000 (13:40 +0200)]
Efl.ThreadIO: replace empty implementations with @pure_virtual
The implementation for call and call_async are empty on this mixin.
I think removing them and marking them as @pure_virtual in the EO file is cleaner.
Xavi Artigas [Wed, 18 Sep 2019 11:40:05 +0000 (13:40 +0200)]
docs: Update Efl.Threadio and Efl.Appthread
Woochanlee [Wed, 18 Sep 2019 10:51:40 +0000 (12:51 +0200)]
docs: Fill-in docs for Efl.Threadio, Efl.Appthread
Reviewers: myoungwoon, segfaultxavi
Subscribers: stefan_schmidt, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10000
Mike Blumenkrantz [Wed, 18 Sep 2019 08:08:58 +0000 (10:08 +0200)]
efl/image: merge preload and unload events into preload_state,changed
Summary:
this reduces the necessary event subscriptions for cases where someone
is likely to want to listen on these events
ref T7875
Depends on D9996
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D9997
Mike Blumenkrantz [Wed, 18 Sep 2019 08:08:56 +0000 (10:08 +0200)]
efl/image: rename "border" -> "border_insets"
Summary:
this is a clearer name which makes the intent of the API more obvious at
a glance
ref T7875
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D9996
Bruno da Silva Belo [Tue, 17 Sep 2019 22:35:31 +0000 (19:35 -0300)]
eolian-mono: add compiler's complaint methods.
Summary: New default checkers breaks mono's test.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9999
Bowon Ryu [Thu, 19 Sep 2019 09:05:02 +0000 (18:05 +0900)]
elm_slider: fix focus for legacy slider on tizen
@tizen fix
Change-Id: Ib8ed3bae13dbc34937d4d88db7fba0b4a56f2e9e
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Yeongjong Lee [Thu, 19 Sep 2019 04:36:10 +0000 (13:36 +0900)]
Revert "efl_ui_widget: reorder constructor code to fix event callback registration issue"
The issue has been fixed on
c7837260936a02cac6357c62b73ce7a7e8dcad59.
This reverts commit
6844f8731f47197f3906f02c080c69caaf3ada9f.
Change-Id: Idea67c4cf9aa79bf3cd1459958cf96711e0e1c40
Yeongjong Lee [Thu, 19 Sep 2019 06:43:01 +0000 (15:43 +0900)]
efl_ui_layout: restore sizing_eval logic to keep backward compatibility
efl_canvas_group_calculate should be called when sub_object size hint is
changed, because some widget(e.g. scroller) expect sub_objects have done
calculating size.
see also,
74a63bdc3900523e6648e3e8915c4577d7145e33.
Change-Id: I20743885bf74231868e6f621b3a8360f3370bd05
Woochanlee [Thu, 19 Sep 2019 06:15:23 +0000 (15:15 +0900)]
elm_spinner: Fix issue during migration.
_elm_spinner_efl_ui_widget_widget_event -> _elm_spinner_efl_ui_widget_widget_input_event_handler
Change-Id: I7ee32644424baab39473f908532b7ff668ef7e46
Hermet Park [Thu, 19 Sep 2019 04:59:05 +0000 (13:59 +0900)]
evas mask: refactoring code.
This clearly separate the condition cases clear so that
the analizyer tool doesn't bother us anymore.
No logical changes.
Change-Id: Ic267db0b52536cba7a7c1e771d7655fd84cf1f12
Yeongjong Lee [Thu, 19 Sep 2019 04:57:03 +0000 (13:57 +0900)]
ecore_device: remove unused variable
@tizen_fix
Change-Id: Idb1d256ebc4a9f4106a11917f88f24c520edff90
Yeongjong Lee [Thu, 19 Sep 2019 01:03:40 +0000 (10:03 +0900)]
ecore_device: initialize _ecore_devices to null in ecore_shutdown
eina_list will be freed in ecore_shutdown(eina_shutdown). if `_ecore_devices` is
used agian without being initialized to null after being freed, unexpected error
will occur. see example code. `ecore_device_add` is called during
`ecore_evas_new`.
```
static Ecore_Evas *ee = NULL;
static Eina_Bool
_timer_cb(void *data)
{
ecore_main_loop_quit();
return EINA_FALSE;
}
static void
setup(void)
{
ecore_evas_init();
ee = ecore_evas_new(NULL, 0, 0, 480, 200, NULL);
ecore_timer_add(0.1, _timer_cb, NULL);
ecore_main_loop_begin();
}
static void
teardown(void)
{
if (ee != NULL)
{
ecore_evas_free(ee);
}
ecore_evas_shutdown();
}
int
main(int argc, const char **argv)
{
setup();
teardown();
setup();
teardown();
return 0;
}
```
@tizen_fix
Change-Id: I9add945ec8184af2e0ed6b9ff4a84a62861710ac
Hermet Park [Thu, 19 Sep 2019 04:39:48 +0000 (13:39 +0900)]
evas gl: remove unnecessary null check.
If we check reference validation, the rest of other usage
should keep the reference check as well.
Remove it since gl prorgram must be valid always here
to shutdown the static analyzer reporting this suspicous logic.
Change-Id: Ia23a5e8d7325fd8aec2d21de9a5f995dfc81c576
Hermet Park [Thu, 19 Sep 2019 04:24:08 +0000 (13:24 +0900)]
evas map: disable the anti_aliasing code which can't be reached.
This anti-aliasing is a little buggy, should be improved.
But just leaving to fix later when it's necessary.
Change-Id: Ie984795b00514e012f1f1a99bfef41a41e1df5a2
Yeongjong Lee [Wed, 18 Sep 2019 04:05:28 +0000 (13:05 +0900)]
efl_ui_layout: call group_calculate in sizing_eval
`efl_canvas_group_calculate` should be called in _elm_layout_sizing_eval, not in
`_elm_layout_efl_canvas_group_change`.
@tizen_fix
ref
74a63bdc3900523e6648e3e8915c4577d7145e33
Change-Id: I33adf51258c15a0f2050cd9c82a1547d8a3e6ac5
Cedric Bail [Fri, 13 Sep 2019 17:43:42 +0000 (10:43 -0700)]
elementary: properly shutdown and cleanup Efl.Ui.Position_Manager.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9946
Cedric Bail [Sun, 15 Sep 2019 05:22:27 +0000 (22:22 -0700)]
elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set
Model do not own the Eina_Value when it is set on them. They can make a copy of it,
but shouldn't free it.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9945
Cedric Bail [Mon, 16 Sep 2019 05:37:59 +0000 (22:37 -0700)]
ecore: remove unused variable after code migration. Fix warning.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9944
Cedric Bail [Sun, 15 Sep 2019 02:13:04 +0000 (19:13 -0700)]
eina: prevent leak of Eina_Value internal allocation.
eina_value_copy assume the given Eina_Value as target is not initialized
when it copy the source in it. In eina_value_reference_copy we were initialising
before calling eina_value_copy which would then override and leak the internal
pointer no fault of the users.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9943
Cedric Bail [Sat, 14 Sep 2019 17:52:37 +0000 (10:52 -0700)]
eina: turn on Eina_Mempool tests for OneBig too.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9940
Cedric Bail [Sat, 14 Sep 2019 17:49:28 +0000 (10:49 -0700)]
eina: fix free support in eina OneBig mempool.
We use an Eina_Trash to store freed pointer, which require the item size
to be at least the size of a pointer. There wasn't any test suite enable
for OneBig mempool and we never used free on a small item size...
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9939
Cedric Bail [Sat, 14 Sep 2019 17:16:56 +0000 (10:16 -0700)]
eina: fix eina_mempool_from to not report pointer that have never been allocated as allocated.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9938
Marcel Hollerbach [Tue, 17 Sep 2019 13:51:19 +0000 (15:51 +0200)]
efl_ui_widget_part_bg: improve docs
Reviewers: segfaultxavi, zmike
Reviewed By: segfaultxavi
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9990
Marcel Hollerbach [Tue, 17 Sep 2019 12:16:14 +0000 (14:16 +0200)]
efl_ui_image: implement missing API
the API calls have not been implemented, this revision implements these
APIs as redirects to the image if those are a edje object.
Normally this should be a calling the legacy edje API. However, this is
here really hard as imitating the correct callback behaviour is hard.
And the correct behaviour with the eina value type is also just leading
to copying the implementation from edje. So in order to keep the amount
of code low here, this just uses the efl-api to redirect the requests.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9989
Chris Michael [Tue, 17 Sep 2019 13:35:43 +0000 (09:35 -0400)]
tests/ecore_wl2: Fix resource leak
Small patch to fix resource leak pointed out by Coverity
Fixes Coverity CID1403883
Chris Michael [Tue, 17 Sep 2019 13:23:46 +0000 (09:23 -0400)]
efl_ui_caching_factory: Fix resource leaks
Small patch to fix resource leaks pointed out by Coverity
Fixes Coverity CID1404762
Chris Michael [Tue, 17 Sep 2019 13:21:15 +0000 (09:21 -0400)]
efl_ui_widget_factory: Fix resource leaks
Small patch to fix resource leaks pointed out by Coverity
Fixes Coverity CID1404766
JunsuChoi [Tue, 17 Sep 2019 12:18:47 +0000 (21:18 +0900)]
evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue
Summary:
Crash depending on LOCALE when using strtod.
So change to eina_convert_strtod_c which is made to prevent strtod problem.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9988
Change-Id: I83d92054db29758ecaca9b08bfca700500857798
Daniel Kolesa [Tue, 17 Sep 2019 11:48:15 +0000 (13:48 +0200)]
eolian: skip funcs from beta-classes when unimplemented-checking
Marcel Hollerbach [Tue, 17 Sep 2019 08:56:42 +0000 (10:56 +0200)]
efl_ui_multi_selectable: remove SINGLE_ALWAYS
this should get a better solution later on. There is also no real usage
for that.
ref T7922
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9985
Daniel Kolesa [Tue, 17 Sep 2019 10:36:13 +0000 (12:36 +0200)]
eolian: enable unimplemented function errors for stable API
Carsten Haitzler (Rasterman) [Tue, 17 Sep 2019 10:30:17 +0000 (11:30 +0100)]
evas - in case handle scope data being null
apbbb saw something that had this scope return null ... so handel -
but it shouldn't get this far... can't figure out why though.
Marcel Hollerbach [Tue, 17 Sep 2019 10:26:01 +0000 (12:26 +0200)]
efl_ui_table: protect again negative tests
Summary:
these tests are checking for errors, which is fine, we should expect a
error here
Depends on D9983
Reviewers: SanghyeonLee, cedric, zmike, segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9984
Marcel Hollerbach [Tue, 17 Sep 2019 10:25:59 +0000 (12:25 +0200)]
efl_ui_box: make this test expect the errors it is triggering
Summary:
there are checks for testing that something is not possible, which is
fine. However, the errors should be expected
Reviewers: SanghyeonLee, cedric, zmike, segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9983
Xavi Artigas [Tue, 17 Sep 2019 10:02:19 +0000 (12:02 +0200)]
mono-docs: Allow embedding examples in XML format
XML examples must provide their own <example> and <code> tags, and these
tags MUST be escaped: \< \> \" etc.
This is more inconvenient, but it allows adding explanatory text outside
the <code> and inside the <example>.
Examples are first looked for in XML format, and if not found, in CS format.
Hermet Park [Tue, 17 Sep 2019 03:01:25 +0000 (12:01 +0900)]
ector: refer exact stride size for jumping buffer lines.
Actual buffer and used width size could be different,
stride must be referred.
Change-Id: I06d8cf5c0b84a266c8c4260804da6a2b979e98ea
JunsuChoi [Tue, 17 Sep 2019 12:18:47 +0000 (21:18 +0900)]
evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue
Summary:
Crash depending on LOCALE when using strtod.
So change to eina_convert_strtod_c which is made to prevent strtod problem.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9988
Change-Id: If02ab894a40da21ba372ed033d155718b1834d78
jeon [Mon, 16 Sep 2019 10:45:13 +0000 (19:45 +0900)]
ecore_evas: fix invalid function usage
- _ecore_evas_mouse_move_with_multi_ifo_process is a
(Ecore_Event_Mouse_With_Multi_Cb) type function
Change-Id: I45852a92c5be74b4b9c36831bc4880a11207a209
Hermet Park [Tue, 17 Sep 2019 03:01:25 +0000 (12:01 +0900)]
ector: refer exact stride size for jumping buffer lines.
Actual buffer and used width size could be different,
stride must be referred.
Change-Id: I37d476223fe63aebda063d60ad05f7cba73f2cb0
Jongmin Lee [Mon, 16 Sep 2019 21:18:22 +0000 (06:18 +0900)]
efl.ui.scrollable: fix event name for scrollable
@tizen_fix
Change-Id: I829c20c5fbc42424c3c2307ea425e8bb169cfee1
Mike Blumenkrantz [Mon, 16 Sep 2019 18:19:43 +0000 (14:19 -0400)]
Revert "cxx: Fix some warnings from -Wextra"
This reverts commit
bdb8505f3b7318b024530d1f9559c91978a3b421.
more review pending on this
Lauro Moura [Mon, 16 Sep 2019 16:41:37 +0000 (12:41 -0400)]
cxx: Fix some warnings from -Wextra
Summary:
- As we don't have C++17's [[fallthrough]], rely on GCC'd detection
of fallthrough comments.
See https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
- Add some missing copy assignment operators as reported by
-Wdeprecated-copy
- Cast a Eina_Bool/bool narrowing conversion
Reviewers: zmike, brunobelo, felipealmeida
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9934
Xavi Artigas [Mon, 16 Sep 2019 16:10:09 +0000 (18:10 +0200)]
efl_ui_format: fix some more harmless Coverity warnings
1403023 Unchecked return value
1403024 Unchecked return value
1403026 Unchecked return value
If the eina value conversion fails the default value (0) will be used, which is already a good default.
ERRs have been added so the developer has a hint of what is happening.
Marcel Hollerbach [Mon, 16 Sep 2019 15:49:43 +0000 (17:49 +0200)]
efl_ui_focus_manager_calc: fix resource leaks
this fixes CIDs 1396965 & 1396984
Xavi Artigas [Mon, 16 Sep 2019 15:44:56 +0000 (17:44 +0200)]
docs: Update Efl.Ui.Box_Stack docs
Marcel Hollerbach [Mon, 16 Sep 2019 15:19:49 +0000 (17:19 +0200)]
efl_ui_*: fix dereferencing of possible NULL values
this fixes CID 1404763 & 1404751 & 1403904
Xavi Artigas [Mon, 16 Sep 2019 14:53:16 +0000 (16:53 +0200)]
docs: Clarify event emission in Image.Gfx.Image_Load_Controller
And minor formatting.
Xavi Artigas [Mon, 16 Sep 2019 14:01:31 +0000 (10:01 -0400)]
elm/datepicker, timepicker: Fix uninitialized vars
Summary:
Should fix all timepicker and datepicker uninitializer variable usage detected by Coverity:
1396954 Uninitialized scalar variable: efl_ui_timepicker.c
1396978 Uninitialized scalar variable: efl_ui_timepicker.c
1397006 Uninitialized scalar variable: efl_ui_timepicker.c
1396979 Uninitialized scalar variable: efl_ui_datepicker.c
1404748 Uninitialized scalar variable: efl_ui_datepicker.c
1404757 Uninitialized scalar variable: efl_ui_datepicker.c
Test Plan: Everything builds and passes tests. Coverity should complain less.
Reviewers: stefan_schmidt, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9967
Wonki Kim [Mon, 16 Sep 2019 13:57:36 +0000 (09:57 -0400)]
elm_config: fix a missing of free after using
Summary: safed_bindings will leak by going out the function without freeing.
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9966
Daniel Kolesa [Mon, 16 Sep 2019 13:27:04 +0000 (15:27 +0200)]
eolian: drop @ctor_param and the associated APIs
This has been unused for a while, and has been just lingering
around the code, so drop it so it doesn't make it into a release.
Stefan Schmidt [Mon, 16 Sep 2019 11:48:37 +0000 (13:48 +0200)]
release: Update NEWS and bump version for 1.23.0-beta2 release
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:36 +0000 (12:56 +0200)]
efl_ui_slider: improve docs
Summary: Depends on D9964
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9965
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:35 +0000 (12:56 +0200)]
efl_ui_check: improve docs
Summary: Depends on D9963
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9964
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:27 +0000 (12:56 +0200)]
efl_ui_button: improve docs
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9963
Xavi Artigas [Mon, 16 Sep 2019 10:37:59 +0000 (12:37 +0200)]
efl_ui_widget: remove misleading comments
Summary:
We settled for the focus_allow name.
The other APIs are not internal, they are protected, and this is
noted, no need to say that again.
Additionally it is not helpfull to have commented out c_prefix
definitions.
Depends on D9936
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9937
Marcel Hollerbach [Mon, 16 Sep 2019 10:28:33 +0000 (12:28 +0200)]
efl_ui_widget: remove wrong docs
Summary:
this is not true anymore, this has been reverted due to how legacy
works. *yey*
Depends on D9935
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9936
Marcel Hollerbach [Mon, 16 Sep 2019 10:22:28 +0000 (12:22 +0200)]
efl_ui_widget: improve docs
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9935
Xavi Artigas [Mon, 16 Sep 2019 10:13:45 +0000 (12:13 +0200)]
docs: Update docs for Efl.Pack_Layout
Hosang Kim [Mon, 16 Sep 2019 09:50:12 +0000 (11:50 +0200)]
efl.ui.scrollable: fix event name for scrollable
Summary:
Event name is applied in the past tense.
Meaning of 'stop' is 'stop it early', so I changed it to 'finish'
Test Plan: elementary_test -> efl.ui.scroller
Reviewers: segfaultxavi, woohyun
Reviewed By: segfaultxavi
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9859
Stefan Schmidt [Mon, 16 Sep 2019 07:42:03 +0000 (09:42 +0200)]
eina: fix spelling in new eina_file_statgen API
Introduced in
9b294d6284f the new eina_file_statgen_* API has a typo in
its disable function. Fixing this before it gets out into a release.
Thanks goes to the https://abi-laboratory.pro service for offering their
great API/ABI reports to the open source communities to help finding such
things!
Differential Revision: https://phab.enlightenment.org/D9962
Stefan Schmidt [Mon, 16 Sep 2019 09:09:02 +0000 (11:09 +0200)]
ci: travis: let Coverity scan run be executed every night until release
Normally we only have this running on Saturday, which is fine for the
normal development cycle. Being close to a release now I would like to
get result updates every day. This will be switched back to weekly after
the 1.23 release.
Mike Blumenkrantz [Mon, 16 Sep 2019 09:08:23 +0000 (11:08 +0200)]
efl/image: Efl.Gfx.Border_Fill_Mode -> Efl.Gfx.Center_Fill_Mode
Summary:
rename this to match its function
ref T7926, T7875
Depends on D9932
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7926, T7875
Differential Revision: https://phab.enlightenment.org/D9933
Xavi Artigas [Mon, 16 Sep 2019 09:06:02 +0000 (11:06 +0200)]
efl/image: Efl.Gfx.Image_Scale_Type -> Efl.Gfx.Image_Scale_Method
ref T7927, T7875
Depends on D9931
Mike Blumenkrantz [Mon, 16 Sep 2019 09:01:01 +0000 (11:01 +0200)]
efl/image: add size event info for image,resized event
Summary:
this saves a manual lookup
ref T7875
Depends on D9930
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D9931
Mike Blumenkrantz [Mon, 16 Sep 2019 08:58:24 +0000 (10:58 +0200)]
efl/image: image,resize -> image,resized
Summary:
events should always be past tense verbs
ref T7875
Depends on D9929
Reviewers: segfaultxavi
Subscribers: kimcinoo, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D9930
Mike Blumenkrantz [Mon, 16 Sep 2019 08:42:27 +0000 (10:42 +0200)]
efl/image: improve docs
Summary:
this adds more docs for the overall interface as well as improvements to
existing docs
ref T7717
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D9929
Carsten Haitzler (Rasterman) [Mon, 16 Sep 2019 00:47:05 +0000 (01:47 +0100)]
evas - rsvg loader - comment out deprecated func from rsvg we don't need
it seesm we don't need this. unref should shut down the rsvg obj
anyway, and rsvg_handle_close() has been deprecated since 2.46
Carsten Haitzler (Rasterman) [Mon, 16 Sep 2019 00:26:16 +0000 (01:26 +0100)]
edje - physics - remove warning of unused arg if physics disabled
simple warning removal. no core changes.
Yeongjong Lee [Mon, 16 Sep 2019 06:04:57 +0000 (15:04 +0900)]
efl_access_text: enable EFL_BETA_API_SUPPORT define to use beta apis
since
4c531e262a440b79fc8e210d945bb8e7614aec2f,
Efl.Access.Text_Attribute and Efl.Access.Text_Range struct marked @beta.
EFL_BETA_API_SUPPORT is needed to use `Efl_Access_Text_Attribute`,
`Efl_Access_Text_Attribute` struct.
@tizen_fix
Change-Id: I0d49a63f7b76199c7e1b714252895fc1ec0310b1
Hermet Park [Wed, 11 Sep 2019 04:12:08 +0000 (13:12 +0900)]
ector: removed cairo backend.
For reducing maintainability burden,
We drop supporting cairo backend.
The default backend is to software implementation from now.
It's well maintained so far and works good.x
Change-Id: Ia512df505f91e7918878afd690da178632308fc4
Hermet Park [Wed, 11 Sep 2019 03:00:28 +0000 (12:00 +0900)]
ector: don't alloc memory if the size is 0.
Change-Id: I3c55022dfeca81fb328cbdcdc20d080922617e59
Hermet Park [Wed, 11 Sep 2019 02:59:21 +0000 (11:59 +0900)]
ector: code refactoring.
more neat and clean code, no logical changes.
Change-Id: I0bfcb2c8cb6ad0a76fc9f186b83152dbb98472e7
Yeongjong Lee [Mon, 16 Sep 2019 01:13:54 +0000 (10:13 +0900)]
bump up to 1.23.0
Change-Id: I95b8525f42d1ed7ee31a92fe5c59ecfc05a29733
Yeongjong Lee [Mon, 16 Sep 2019 01:00:25 +0000 (10:00 +0900)]
efl_ui_widget: fix eo build error of tizen only type
@tizen_fix
Change-Id: I29d3e140df8cd6715ef94d9eea37d75bf3cf8dc6
Yeongjong Lee [Sun, 15 Sep 2019 23:40:21 +0000 (08:40 +0900)]
efl_ui_win: remove needless legacy keyword
@tizen_fix
Change-Id: If70d22b1d6622a3fdbdb8aed83e87fcf0404e0f4
Lauro Moura [Fri, 13 Sep 2019 22:22:39 +0000 (19:22 -0300)]
csharp: Fix Hash.DelByValue
Summary:
The C function `eina_hash_del_by_data` requires the same value that was
passed to the `add` function. As C# hashes store stuff through pointers
due to marshalling, this makes it hard to pass the same pointer for it.
So this functionality is implemented at C# level instead of relying on
the native function directly.
Fixes T8198
Thanks to @brunobelo and @singh.amitesh for the test case.
Reviewers: singh.amitesh, felipealmeida, brunobelo
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers, singh.amitesh, brunobelo
Tags: #efl
Maniphest Tasks: T8198
Differential Revision: https://phab.enlightenment.org/D9853