Tomasz Czekala [Tue, 27 Jan 2015 11:58:38 +0000 (12:58 +0100)]
Changed mime override callback to be called per context and added user_data
Whenever a new URLRequest is created, it is delegated via
ResourceThrottleEfl to our PolicyResponseDelegateEfl, where we postpone
the request and are able to check and handle the mime type of the
request on the UI thread. We ask the client if the mime_type should be
changed and if yes, we push the new mime type to MimeOverrideManagerEfl
and resume the URLRequest. Later on a
ResourceDispatcherHostDelegateEfl::ShouldOverrideMimeType call we deploy
the new overridden mime type on IO thread.
Mime override callback was global for the browser and didn't have
user_data, this patch changes it to be per context and adds user_data.
This patch is based on http://165.213.202.130:8080/#/c/72514/
Together with: I1baa8e92c0b2bea44fc0332c3e034f16f4efa428
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9463
Reviewed by: Antonio Gomes, Janusz Majnert, Min-Soo Koo, Piotr Tworek, SeungSeop Park
Change-Id: I3881faaf5fcf4d29c44a120d4723133095042b41
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Karol Furmaniak [Thu, 22 Jan 2015 08:53:42 +0000 (09:53 +0100)]
Fix updating repo when switch to existing branch.
Calling sync_repos.sh when current branch is not target branch
cause error:
fatal: A branch named 'xxx' already exists.
Changing 'git checkout' option from '-b' to '-B' fix this.
Reviewed by: Jaesik Chang, Piotr Grad, Piotr Tworek, SeungSeop Park
Change-Id: I81b9647bcfbe7dbd6b7ff2e3eb6e9e27557ce64c
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Marcin Strakowski [Fri, 16 Jan 2015 14:34:28 +0000 (15:34 +0100)]
Translation "Select all" for context menu.
No translation for text "Select all". Instead string ID actual
name is now shown.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9715
Reviewed by: Jaesik Chang, Piotr Tworek
Change-Id: If37fb27d87bb6ee125f1ae1f3659733d8264c365
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
ws29.jung [Fri, 23 Jan 2015 10:18:10 +0000 (19:18 +0900)]
Revert "[SPIN][Temporary] Removed the TTS dependency from EFL port"
This reverts commit
4c4c4f461a39b37d4fd46d5e1f9d3e5a7f71a2a8.
TTS build break fixed
Commit #74386 has to be merged before this
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10512
Conflicts:
packaging/chromium-efl.spec
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park
Change-Id: Idc6d836a6dc52836e4d0494e2840d5582423b2d3
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Piotr Tworek [Mon, 26 Jan 2015 09:55:29 +0000 (10:55 +0100)]
Upgrade EFL version for desktop to 1.9.5.
Right now desktop seems to use the oldest version of EFL of all
platforms chromium-efl currently supports. As a result some functions
which are present on TV or mobile can't be used on desktop. To avoid
introducing extra sets of defines around such functions upgrade desktop
EFL and Elementary to their newest versions from 1.9.x branch.
Due to jhbuild limitations for this patch to make any effect
out.x64/Dependencies directory has to be removed manually. Jhbuild can
only build packages, but it does not support package upgrades.
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park
Change-Id: I2c00a3875d12b4f06abe036bb09fe096a23755ef
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Grad [Sun, 25 Jan 2015 12:03:36 +0000 (13:03 +0100)]
[M34-Merge] 'Load images' settings option fixed.
EWK API expects to not show images - not only to not download images.
original commit:
http://165.213.202.130:8080/#/c/69544/
Reviewed by: Hyunhak Kim, Piotr Grad, SeungSeop Park
Change-Id: I216d20a8190bf44812ba4e0fc52185ab5db706ee
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Karol Furmaniak [Thu, 15 Jan 2015 09:33:09 +0000 (10:33 +0100)]
Update magnifier screen using GetSnapshotAsync.
[Problem] Magnifier screen is blank because
EWebView::GetSnapShotForRect func is not implemented.
[Solution] Added updating magnifier screen using
EWebView::GetSnapshotAsync.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8773
Reviewed by: DONGJUN KiM, Piotr Grad, SeungSeop Park
Change-Id: I37604e2567d136439a5501f0654e8cc58edc66de
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
sonal.g1@samsung.com [Mon, 19 Jan 2015 15:33:56 +0000 (21:03 +0530)]
[Tizen][WebRTC] Fix rotation for Video Captured from Camera
Handled rotation for captured video. Before this change, video was not getting
rotated when device was rotated. Now device rotation will reflect in video
stream.
Reviewed by: Min-Soo Koo, SeungSeop Park, Venugopal S M
Change-Id: Ic1f81e90e557e15265c911f6dcdbda790771594d
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
Marcin Strakowski [Fri, 23 Jan 2015 10:19:07 +0000 (11:19 +0100)]
No markup data copied
Added markups handling to clipboard.
As a result images and images mixed with text
are now available at clipboard.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9053
Reviewed by: Piotr Grad, Piotr Tworek, SeungSeop Park
Change-Id: Ib2b1a9300c619466c5ff3e09bd33cd02775f09b8
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
amit.kumar8 [Tue, 20 Jan 2015 14:50:14 +0000 (20:20 +0530)]
Trace Controller for Tizen/blink
Adding mechanism for tizen/blink to take traces from already running
application.
m34 patch:
Original Author: prashant.n
Original Patch : http://165.213.202.130:8080/#/c/69076/ and
http://165.213.202.130:8080/#/c/69496/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10571
Reviewed by: Prashant Nevase, venu musham
Change-Id: Ie39fbb1894ebade5ae3e7a1bb1895f567509702e
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
mohan [Tue, 27 Jan 2015 13:39:00 +0000 (19:09 +0530)]
Revert "fixup! Porting of async snapshot functionality for Tizen platform"
This reverts commit
0e84589d308fd0639af0ed7b846a2963a283aa86.
Change-Id: I64865d81da00c84a3f5ea6857a26427101a87e9c
Signed-off-by: mohan <mohan.reddy@samsung.com>
amit.kumar8 [Fri, 23 Jan 2015 09:26:10 +0000 (14:56 +0530)]
Implement gpu info collector efl (chromium-efl)
This is gpu_info_collector implementation for efl port.
As in Linux port, we use libpci to get the gpu information
and it does not work for Tizen.
So we need a separate implementation for getting the gpu
information in efl.
The gpu information is needed for disabling multisampling feature
bu adding entry in the gpu_driver_bug_list_json.cc
m34 patch:
Original Commit:
e998dd80676ee33bcb5da645580ca24fb7339dc5
Original Author: das.kulajit <das.kulajit@samsung.com>
Reviewed by: Prashant Nevase, venu musham
Change-Id: I715e8a3b7da03d27b8396a799700a71c89d94988
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
Karol Furmaniak [Thu, 15 Jan 2015 09:23:18 +0000 (10:23 +0100)]
fixup! Porting of async snapshot functionality for Tizen platform
Added conversion from evas coords to blink coords.
Reviewed by: Jaesik Chang, Piotr Grad
Change-Id: I3629abef313147921f1e992e07d00b8ba72a6fa1
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Tomasz Czekala [Tue, 27 Jan 2015 09:13:16 +0000 (10:13 +0100)]
[M34-Merge]Migrate patches to fix ewk_settings_scripts_window_open_set
This patch is porting following patches:
http://suprem.sec.samsung.net/gerrit/#/c/6759/
http://165.213.202.130:8080/#/c/69930/
by Kamil Klimek
http://165.213.202.130:8080/#/c/70410/
http://165.213.202.130:8080/#/c/70737/
by Piotr Tworek
Together with: I4086107b1ee3e788752ed6d79a39d37784ee4184
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10415
Reviewed by: DONGJUN KiM, Piotr Tworek
Change-Id: Ifebe53719fd411d0fcd40c1058c373bbb35c2749
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Kamil Klimek [Tue, 22 Jul 2014 12:53:24 +0000 (14:53 +0200)]
[M34-Merge] Fixed text selection related issues
Text selection was not handled as expected in chromium-ewk and
chromium-efl. This commit fixes few issues with text selection
synchronization between render process and browser process
Issue: CBWEBVIEW-161 CBWEBVIEW-220, CBWEBVIEW-504
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9544
Reviewed by: Janusz Majnert, Piotr Tworek
Change-Id: Idf98a5bcd356919c77944e1b244ada9e79e7a25d
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Jongsoo Yoon [Mon, 26 Jan 2015 13:07:46 +0000 (22:07 +0900)]
Update S_TRUNK_OWNERS of chromium-efl
Update Reviewers list for each Technical Group.
Modified: src/S_TRUNK_OWNERS
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10764
Change-Id: I0f5afc7f31b5fa179c2ec15317514ccff54487ea
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
Wojciech Bielawski [Mon, 26 Jan 2015 08:48:56 +0000 (09:48 +0100)]
Refactor implementation of ewk_geolocation_permission* API
Corrected behaviour of
GeolocationPermissionContextEfl::RequestPermissionOnUIThread. Previously it
wrongly called SendGeolocationPermissionResponse callback even when the API
embeder made a decision in his callback.
Geolocation private implementation refactored to use common
Ewk_Suspendable_Object implementation.
In addition unit test implementation refactor.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9524
Reviewed by: Piotr Tworek, arno renevier
Change-Id: Ib1674d06f3c2f48ddea009c842e30643cdf1c64c
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Michał Obrembski [Tue, 13 Jan 2015 13:19:43 +0000 (14:19 +0100)]
Added callback for Autofill Profiles changed.
This patch introduces new EWK callback Ewk_Context_Form_Autofill_Profile_Changed_Callback
which is called when profiles operation (modify/add/remove) is done in engine.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10077
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park
Change-Id: If9bac21c9a81036513bcbc9e342d93379372e02a
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Tomasz Czekala [Fri, 23 Jan 2015 14:28:28 +0000 (15:28 +0100)]
Remove synchronous image hit test tests
Doing synchronous hit test of an image requires copying that SKIA bitmap between
renderer process and browser process and now making that copy causes crashes and
is disabled, so this functionality doesn't work and we're removing that check
because synchronous hit tests are deprecated.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9525
Reviewed by: Janusz Majnert, Piotr Tworek
Change-Id: Ifc96fee18534bfb21f359df0b25305c53ac7f8f1
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Jongsoo Yoon [Mon, 26 Jan 2015 02:26:45 +0000 (11:26 +0900)]
Not display mini_browser icon.
The official test browser for chromium-efl will be changed
to Reference browser from mini_browser.
This patch set the Icon of mini_browser to be not displayed
in order to avoid confusing.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10744
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: Id67888132d335e85261483f663bdf2ee5c2aaeee
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
Dongjun Kim [Fri, 23 Jan 2015 11:31:11 +0000 (20:31 +0900)]
[M34-Merge] Add interface for sending appID to WRT
We need to add new function for sending application id to WRT.
It is a requirement from WRT.
So, we add DynamicSetWidgetInfo() for this.
Original patch:
http://165.213.202.130:8080/#/c/70427/7
BUG : http://107.108.218.239/bugzilla/show_bug.cgi?id=6168
Reviewed by: Min-Soo Koo, Piotr Tworek
Change-Id: Ic58c75caf69e2133f3c8ee091a18fed9424cf915
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Michał Obrembski [Mon, 22 Dec 2014 13:27:47 +0000 (14:27 +0100)]
Implement support for autofill feature.
This patch adds all autofill
functionality to the browser, such as Autofill Profiles, Form Password
Generation, Form Password save.
Merged patches:
a60760ca50a4deeaa0b56e4bc093de597ea3740f
Fix for APIs for Form Autofill Profiles.
Author: Jan Zakrzewski <j.zakrzewski@samsung.com> 2014-06-23 13:12:20
http://165.213.202.130:8080/#/c/68885/
fixup! Crash when adding profile
Author: Piotr Grad <p.grad@samsung.com> 2014-08-28 16:11:40
http://165.213.202.130:8080/#/c/69737/
fixup! Fix autofill profiles management
Author: Robert Jadczak <r.jadczak@samsung.com> 2014-09-20 14:35:20
Reviewed by: Piotr Grad, Piotr Tworek, arno renevier
Change-Id: I2de842151904438f3e75ecdb58087b816f2c47a9
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Kamil Lysik [Wed, 7 Jan 2015 10:56:24 +0000 (11:56 +0100)]
ewk_settings_text_autosizing_font_scale_factor_set argument check
Since non-positive font scale factor is invalid make sure the function
returns false (indicating error) when the caller is specifying
such value.
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Signed-off-by: Kamil Lysik <k.lysik@samsung.com>
Change-Id: I7966f825b0e04e3646a1ae939bb004a55454bfd2
KangYong Park [Thu, 22 Jan 2015 10:23:13 +0000 (19:23 +0900)]
Add library path to run layout_test
For layout_test, content_shell is used.
And it needs to import some libraries for running content_shell.
This patch adds the path of necessary libraries automatically.
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I0ae20390a3964cce09e6099ceb3319420ea82411
Signed-off-by: KangYong Park <kaka.park@samsung.com>
Kamil Klimek [Thu, 22 Jan 2015 19:22:09 +0000 (20:22 +0100)]
Fixed WebInspector inability to early report errors
This is a little bit hacky implementation of port check, because in some
conditions it may happen that port will be taken between the check and
initialization of WebInspector on proper thread. Unfortunetly sockets
can't be passed between threads. They strictly belong to the thread they
were created.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9549
Reviewed by: Janusz Majnert, Piotr Tworek
Change-Id: Iadac46a3152f96e944a274fb1a9afedc6260f386
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
ws29.jung [Wed, 21 Jan 2015 11:20:27 +0000 (20:20 +0900)]
[SPIN] TTS build break fix
Build break occured because tts engine was updated from 0.2.39 to 0.2.41,
so some functions argument and return type has been changed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10512
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: Id013071ed332b0ececf60aa6abde19bdd98fa04f
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Lukasz Krok [Fri, 23 Jan 2015 09:13:43 +0000 (10:13 +0100)]
Fix for utc_blink_ewk_error_code_get* tests
The utc_blink_ewk_error_code_get* tests previous implementation
intention was to cause load error by cancelling resource loading.
As cancelling loading is normal stituation, it shouldn't be treated
as error. It was corrected in I8f4e828bfcc63377678e475f44131dbc749b9c7f
change. Because of the change utc_blink_ewk_error_code_get* tests
stopped to pass.
This commit removes resource loading cancellation from tests logic.
Instead of google.com, "page_that_does_not_exist" is now set as url.
Such url usage causes SERVICE_TEMPORARILY_UNAVAILABLE error code.
If device has no network connection, NETWORK_ERROR code is produced.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10191
Reviewed by: Janusz Majnert, Piotr Tworek
Change-Id: I1503f966bd782815760ca6a7fbf129d1e1400102
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Kamil Klimek [Thu, 22 Jan 2015 14:04:06 +0000 (15:04 +0100)]
Refactor EWK APIs controlling initial value of list-style-position CSS property
This commit re-enables the ewk_settings_initial_list_style_position_{get|set}
API calls by removing EWK_BRINGUP define guards.
This API is not implemented on engine site. It only toggles a flag
inside WebPreferences.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9533
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Change-Id: I5e7e1c825cc1ccac305e10eb05318617c0417e9e
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Wojciech Wiśniewski [Tue, 13 Jan 2015 12:48:12 +0000 (13:48 +0100)]
Do not destroy GLSharedContextEflPrivate instance on exit.
Destructor of GLSharedContextEflPrivate instance is firing on content_shell_efl exit time.
This destructor is calling evas_gl_surface_destroy, but EFL at this time is deinitialized already
and calling this function causes segfault.
The solution is simply to not destory GLSharedContextEflPrivate instance (it's static global
object, and we are exiting anyway).
Reviewed by: Daniel Waślicki, Min-Soo Koo, Viatcheslav Ostapenko
Change-Id: I43f9608eafea1c7502ce1219e6c8a8576aa1face
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
hyunjune.kim [Fri, 23 Jan 2015 04:52:40 +0000 (13:52 +0900)]
The build break when gcc-link by the libcap fixed.
The build breaks which related to libcap occured in i586 target.
So add a code which is the following
export LDFLAGS="$LDFLAGS -L/lib".
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10518
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I0cc0b35c05bdf61e5bb8e21fabf94a377721a276
Signed-off-by: hyunjune.kim <hyunjune.kim@samsung.com>
Lukasz Krok [Thu, 22 Jan 2015 15:05:38 +0000 (16:05 +0100)]
Changing test page loading type in utc_blink_ewk_view_screenshot_contents_get* tests
Instead of google.com, static html page code will be loaded.
The reason behind this change is that sometimes test failed
because of connection problems, for instance when a script rebooted
device and did not manage to establish internet connection before
executing the test.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10624
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: Ideca7340cf8a196d98bf8236ee58a49800f7010e
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
hyungsun.ryu [Thu, 22 Jan 2015 11:09:25 +0000 (20:09 +0900)]
Remove ffmpeg dependency
Chromium-efl uses gstreamer instead of ffmpeg.
So we don't need to build ffmepg any more.
- removed ffmpeg in chromium-efl.spec
- added a variable to skip ffmpeg build
Bug : http://107.108.218.239/bugzilla/show_bug.cgi?id=10516
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I1e5aafab2e3da6e3b13d7636131aefacafa3e81a
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
Filip Piechocki [Tue, 20 Jan 2015 16:24:59 +0000 (17:24 +0100)]
Get rid of C++11 features in EWK tests.
Due to the GCC downgrade (4.8 -> 4.6) on Tizen 2.4
repositories ewk_certificate_policy_decision_suspend test
failed to compile because of the C++11 features used which
are not implemented yet in current GCC version.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9518
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I32b9b9995c348b35a7331dd3b665808969870923
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Maciej Skrzypkowski [Fri, 19 Dec 2014 15:22:12 +0000 (16:22 +0100)]
IME stays on screen when pushed search button on IME
Fixed hidding keypad after clicking loupe icon when editing text in input field:
<form>
<input type="search">
</form>
Added setting focus in WebContentsDelegateEfl::DidFinishLoad, removed
setting focus from mini_browser.c.
Deleted setting useKeyPadWithoutUserAction to false from mini browser,
now it's true (as default). It seems that setting this flag to false is no longer
needed and if it's false than hiding keypad after form submit is prevented.
Updated to current sources.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9708
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Change-Id: I39bc3b63c00bd3d8d6fda227226c0ddae2923740
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Lukasz Krok [Mon, 19 Jan 2015 08:42:26 +0000 (09:42 +0100)]
fixup! Fix ewk_view_orientation_send API
During patch review on dev/master some improvements to the fix
were introduced. This patch migrates the improvements to beta.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9541
Reviewed by: Antonio Gomes, Daniel Waślicki, Piotr Tworek
Change-Id: I9b28cb4ede25770b1d98b42702f218b9b1188f7f
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Tomasz Czekala [Wed, 21 Jan 2015 11:38:02 +0000 (12:38 +0100)]
Remove device_scale_factor() from RenderWidgetHostViewEfl
RenderWidgetHostViewEfl shouldn't provide the device scale factor, because
device scale factor is a parameter of the screen and is available when
rwhv is not present and can be read from gfx::Display.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10458
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: I92b4a64069836c014be33ab3e3cb966f4ff7c7a2
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Karol Furmaniak [Mon, 6 Oct 2014 11:05:26 +0000 (13:05 +0200)]
IME is not shown when clipboard window is visible.
[Problem] When clipboard window is visible, there is
no possibility to show IME keyboard. It should be visible
after tap on input field.
[Solution] Added implementation of IsClipboardWindowOpened
method. It depends on ecore_x_e_illume_clipboard_state_get.
With this patch clipboard window is closed, when user tap
on not focused input field.
Also added closing clipboard window when webview is out of
focus.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9716
This is a cherry-pick from: http://165.213.202.130:8080/#/c/70395/
Reviewed by: Piotr Grad, SeungSeop Park, commitbot
Change-Id: I42726064071255579504774345311cd954263244
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Kamil Klimek [Tue, 20 Jan 2015 13:46:20 +0000 (14:46 +0100)]
Fix crash related to magnifier
In some conditions animator object could outlive magnifier instance. This
lead to a crash caused by accessing freed memory.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10563
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: Icf8026909795dce85df1c2a2abc616f0ad1c0404
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Youngcheol Kang [Mon, 19 Jan 2015 10:05:17 +0000 (19:05 +0900)]
[SPIN][Temporary] Removed the error codes which happened in ffmpeg
The build breaks which related to ffmpeg occured in i586.
But ffmpeg has no .git repository. (src/third_party/ffmpeg)
By temporary solution, the patch file will be applied before a build.
This patchset is the temporary patch.
This issue will be fixed by the multimedia team.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10516
Change-Id: Ifc14bfcab58f2adc730a6b0bc7ac5b3acf8f650d
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Piotr Tworek [Fri, 16 Jan 2015 11:59:24 +0000 (12:59 +0100)]
fixup! Upmerge of ME & MSE with in impl/
An example why clang diagnostic output is supperior to gcc:
warning: 'CONTENT_BROWSER_MEDIA_MEDIA_WEB_CONTENTS_OBSERVER__TIZEN_H_'
is used as a header guard here, followed by #define of a different macro
[-Wheader-guard]
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ifb3e35fd557b953d929337aa1a4a7686622d49d7
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Youngcheol Kang [Wed, 21 Jan 2015 07:22:14 +0000 (16:22 +0900)]
fixup! [SPIN] Removed the libhaptic dependency in the OBS environments
The emulator does not support libhaptic.
Because of this, the libhaptic is only used by the arm target.
Change-Id: Iff247af2bd9c582ea4edb37104d1bd4468379f60
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Mon, 19 Jan 2015 03:46:52 +0000 (12:46 +0900)]
[SPIN] Removed the libhaptic dependency in the OBS environments
The OBS doesn't support the libhaptic package.
The libhaptic is used only in the local environments.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10508
Change-Id: I3311b0c4ee5cfafa8bf0fc40fd5a29af17f8ed10
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Mon, 19 Jan 2015 03:35:54 +0000 (12:35 +0900)]
Removed the vpx dependency from chromium-efl.spec
The multimedia used the internal vpx in the chromium
instead of the system vpx.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10506
Change-Id: I27a1de482bf2766025f9b5a8ed0a560c4a73995e
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Arnaud Renevier [Mon, 1 Dec 2014 19:26:47 +0000 (11:26 -0800)]
ecore_x_init was not called
Currently, HAVE_ECORE_X is never set, and then, ecore_x_init is never
called from within ewk_init. Then, when we call ecore_x_display_get, the
display returned is null. This problem is not visible with
efl_webview_app because ecore_x_init is called indirectly (via a call to
elm_init). But for example, wrt does not call elm_init and triggers the
bug.
The proposed solution is to always consider that we're using ecore_x. It
is currently true for all our platforms.
This patch also fixes a logic error: ecore_imf_shutdown() should be
called whether or not ecore-x is available.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9394
Reviewed by: Antonio Gomes, Piotr Tworek, arno renevier, commitbot
Change-Id: I5a41083f8e3cffe456fb638cd713d27a42d37620
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Youngcheol Kang [Mon, 19 Jan 2015 02:43:05 +0000 (11:43 +0900)]
[SPIN] Added the build script for Tizen Emulator (i586)
Added the below changes for i586 build
- Added the build_emulator.sh file
- Added the ninja files
- Added the codes for i586 build in the gbs.conf file.
- Added the codes for i586 build in the chromiul-efl.spec file.
- Added the guide for i586 build in the Readme.md file.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10509
Reviewed by: Piotr Tworek, Youngbok Yoon
Change-Id: If032bb14ce214914c196e8ad85f0a80b8ac71788
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Mon, 19 Jan 2015 10:17:15 +0000 (19:17 +0900)]
[SPIN][Temporary] Removed the error codes which happened in libvpx
The build breaks which related to libvpx occured in i586 target.
But libvpx has no .git repository. (src/third_party/libvpx)
By temporary solution, the patch file will be applied before a build
This patchset is the temporary patch.
This issue will be fixed by the multimedia team.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10517
Reviewed by: Piotr Tworek, SeungSeop Park, Youngbok Yoon
Change-Id: Iebf09882c7cfe4607a3dec83288535eff7517f1c
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Mon, 19 Jan 2015 05:17:49 +0000 (14:17 +0900)]
[SPIN][Temporary] Removed the TTS dependency from EFL port
Because of the tts upversion, the build breaks were occured in the OBS.
This patchset is the temporary patch.
This issue will be fixed by the multimedia team.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10512
Reviewed by: Piotr Tworek, SeungSeop Park, Youngbok Yoon
Change-Id: I848fd0cbcccaa80e7b7151ec6dcdc9868cc00f13
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Mon, 19 Jan 2015 03:40:36 +0000 (12:40 +0900)]
Removed the capi-telephony-network-info dependency from chromium-efl.spec file
The capi-telephony-network-info package is not used from EFL port.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10507
Change-Id: I0459d5413ccdbb310bff972b6396e8a25e11c64b
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Karol Furmaniak [Tue, 20 Jan 2015 07:54:30 +0000 (08:54 +0100)]
fixup! fixup! [M34-Merge] Migrated chromium-efl internals to asynchrounous hit tests
Fixed broken x,y coords in EWebView::EvasToBlinkCords.
Reviewed by: Piotr Grad, SeungSeop Park
Change-Id: I66a0b68fca2ec2806b4f30260e2d9c9c54f8c6cf
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Arnaud Renevier [Fri, 31 Oct 2014 12:26:32 +0000 (13:26 +0100)]
Changing method of obtaining paths
This patch contain changes for user data, cache and web database
directory.
This is code migration from m34 beta to DEV. It is needed in order to
pass wrt feature tests
Original patch: http://165.213.202.130:8080/#/c/71391/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5194
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6210
Reviewed by: Antonio Gomes, Piotr Tworek
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Change-Id: Icba2d5386a574cd69d7ed1f76469126c5a7741a4
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Wojciech Bielawski [Mon, 19 Jan 2015 12:21:27 +0000 (13:21 +0100)]
fixup! Implementation of ewk_home_directory_set API.
Applied changes after review on dev/master branch
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9555
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: I4c54926f92e03aede254ad483c6223af4aa0b304
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
SeungSeop Park [Sat, 17 Jan 2015 02:05:05 +0000 (11:05 +0900)]
fixup! [SPIN] Switch to Tizen 2.4 Platform version
Patch fixes two things.
1. Add new define TIZEN_V_2_4 and resurrect the codes that were
under legacy TIZEN_V_2_3 guard.
2. Change default value for gyp variable chromium_efl_tizen_version as 2.4.
This is necessary for SPIN OBS build where we cannot pass additional
defines to gbs command as we did in build/build_mobile.sh.
Reviewed by: Min-Soo Koo, Piotr Tworek
Change-Id: Iffe905682b4d043f6927f71d1fe1c0043f018e15
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Daniel Waślicki [Thu, 15 Jan 2015 12:31:41 +0000 (13:31 +0100)]
Reset pointer to BackForwardList on renderer crash
When renderer process will crash, new WebContents object
is created in order to open a page which informs that process
has crashed. WebContents object has NavigationControllerImpl
fiel. After creation of a new WebContents, old one is deleted
and along with it NavigationControllerImpl is. Thus any action
on it causes segmentation fault. We need to simply reset
NavigationController object. Also we need to reset
whole BackForwardList object, because we need to register
navigation notifications in a new context.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10304
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: I708b30c6db8c74284e30f078b8b04f39dff084cd
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Youngcheol Kang [Fri, 16 Jan 2015 10:36:15 +0000 (19:36 +0900)]
[SPIN] Switch to Tizen 2.4 Platform version
Change mobile's base gbs repo to Tizen 2.4 repo, which is generated
from SPIN OBS.
Supplement repo is required due to missing packages for now, but will be
removed once we finish to set up the OBS environment.
Reviewed by: Hyungsun Ryu, Piotr Tworek, Youngbok Yoon
Change-Id: I47c6178ac82acb87b9ff81457c5191d63abfccba
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
hyungsun.ryu [Thu, 15 Jan 2015 14:13:40 +0000 (23:13 +0900)]
[SPIN]Disable CAPI port for MediaElement
We can't use CAPI product APIs in SPIN because SPIN only supports
public APIs.
But MediaElement using CAPI must use product APIs.
Hence, MediaElement using Gstreamer will be temporarily used
instead of CAPI port for MediaElement.
- added 'tizen_multimedia_use_capi_for_me' gyp variable
- modified gypi files to switch between CAPI and Gstreamer
Reviewed by: Antonio Gomes, Hyungsun Ryu, Piotr Tworek, SeungSeop Park
Change-Id: Ia87477b25efb0ef7f60fc85f8d0f5be521e614e0
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
Tomasz Czekala [Fri, 16 Jan 2015 12:42:41 +0000 (13:42 +0100)]
fixup! [M34-Merge] Migrated chromium-efl internals to asynchrounous hit tests
When render widget host view was not present and ewk_view_hit_test_new was run,
we had crash, or hang.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9747
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: I262b4dd938b8bf4685740af3f1e7e3670f1c52e5
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
hh4813.kim [Wed, 14 Jan 2015 16:42:07 +0000 (08:42 -0800)]
[SPIN] Hotfix for build with gcc 4.6.3
Revert "fixup! [Tizen] Switch chromium-efl / mobile development to GCC 4.8"
-This reverts commit
8ffb97b642f4326e6da671b392942c2f5353dbb8.
Revert "fixup! [Tizen] Switch chromium-efl / mobile development to GCC 4.8"
-This reverts commit
053bb9dd81b79db39b7431358f815d6bb3d71640.
Revert "[Tizen] Switch chromium-efl / mobile development to GCC 4.8"
-This reverts commit
7e92be3cc650f8aed1a47599f3da2ae579f92ace.
Add GCC_4_6_X flag for mobile
Together with: I21e033ef68941f29164546c7dd8ce6e1e9b1aa57
Together with: I7718511dcb9ae9f12a02daf84827a04705ddafe5
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park
Change-Id: I7c0e993d375cea1516a295249462b9e4bb1b04d3
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Piotr Grad [Wed, 19 Nov 2014 15:14:33 +0000 (16:14 +0100)]
[Tizen][M34 merge] Implementation for selection controller/context menu
This patch includes commits merged from M34 beta branch related to text
selection/context menu. This brings up functionalities like showing and hiding
context menu and selection controller when needed. Also related code for
magnifier and clipboard is merged with this commit. This commit covers partial
solution for WCS test suite.
Original patches:
1) fixup! Add 'Select/Select All' functionality to the context menu
http://165.213.202.130:8080/#/c/69545/
2) Clipboard and paste option available without data
http://165.213.202.130:8080/#/c/70862/
3) Magnifier is to big on latest Z910F platform
http://165.213.202.130:8080/#/c/70904/
4) Magnifier is not aligned correctly to the edge of screen
http://165.213.202.130:8080/#/c/71022/
5) fixup! Fix for the problem that context menu appears when text selection
is done from JavaScript.
http://165.213.202.130:8080/#/c/70874/
http://165.213.202.130:8080/#/c/71196/
6) Fix problem that context menu does not appear
http://165.213.202.130:8080/#/c/70501/
7) Context menu and text selection not appearing
http://165.213.202.130:8080/#/c/71674/
8) Prevent adding custom selection menu items in editable field
http://165.213.202.130:8080/#/c/71726/
9) Context menu was not shown back after acked tap event
http://165.213.202.130:8080/#/c/71722/
10)Fix for browser crash
http://165.213.202.130:8080/#/c/72188/
11)[WCS][TC1] Large handler can be moved to previous page.
http://165.213.202.130:8080/#/c/72637/
12)fixup! Fix for Edge Effect
http://165.213.202.130:8080/#/c/70663/
13)fixup! Refactor navigating via selection handlers.
http://165.213.202.130:8080/#/c/69944/
14)IME is not shown when clipboard window is visible.
http://165.213.202.130:8080/#/c/70395/
15)Selection handler is not shown after tap into input field.
http://165.213.202.130:8080/#/c/70372/
16)Added hiding selection after focus out event.
http://165.213.202.130:8080/#/c/71905/
17)Add possibility to paste image from clipboard
http://165.213.202.130:8080/#/c/70608/
Reviewed by: Piotr Grad, Piotr Tworek, SeungSeop Park
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8773
Change-Id: I8a31d77af5e43ddd95846788e9135666bb2da8a9
Signed-off-by: Piotr Grad <p.grad@samsung.com>
venu musham [Fri, 16 Jan 2015 04:53:08 +0000 (13:53 +0900)]
fixup! Fix for graphics on tizen/desktop
Evas_Object is defined as _Eo in evas version 1.12. In evas version
below 1.12 it is defined as _Evas_Object. fixup declarations of
_Evas_Object by including Evas.h, it defines Evas_Object.
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: I9bfecb44c478a6eb43dc655833ec43cffd1062c7
Signed-off-by: venu musham <venu.musham@samsung.com>
msu.koo [Wed, 12 Nov 2014 12:01:26 +0000 (21:01 +0900)]
[Tizen][WebRTC] Enable H/W accelerated H.264 support for WebRTC on Tizen
- Implemented TizenVideoDecodeAccelerator.
- Implemented TizenVideoEncodeAccelerator.
Current implementation uses xvimagesink without linking with
Native Texture Surface.
Surface adaptation is on progress at
http://107.108.218.239/bugzilla/show_bug.cgi?id=9181
Together with: I292dabd6acc376fcbe6040d19a5dabbbc5ee3a0f
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8362
Reviewed by: SeungSeop Park, Viatcheslav Ostapenko
Reviewed by: Min-Soo Koo, Vinod Keshav
Change-Id: I2feae6d6929d64473e4be6a259ca4780609e4e3c
Signed-off-by: msu.koo <msu.koo@samsung.com>
Daniel Waślicki [Tue, 13 Jan 2015 14:08:27 +0000 (15:08 +0100)]
fixup! [Tizen] Implement tizen specific battery status manager.
Battery full/empty Callbacks were registered vice versa.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10330
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: I11a3751a896055a739f669a014e501c05c40a796
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
Tomasz Czekala [Thu, 15 Jan 2015 11:31:22 +0000 (12:31 +0100)]
Implementation of ewk_notification_policies_removed.
This API function is for removing entries from the internal
engine's cache, while the real storage of the policies is
done on the client side (such as 'browser'). I've implemented
the cache (std::map) and added implementation of
webkitNotifications.checkPermission() to use this cache to check
for the permission (this was not implemented at all and
default implementation in blink returns always 'Allowed').
As the permission checking is done in the IO thread I've
made the NotificationControllerEfl a RefCountedThreadSafe
object, so it can be passed with the ResourceContext and
accessed without webview. To make this permissions cache
feature complete we need a function to set the initial state
(which e.g. browser could read from its database) - for
this purpose there is ewk_notification_cached_permissions_set()
function and this commit contains fuctionality needed by this
function.
EWK API regarding Notification's functionality is updated
in this patch. The "notification,permission,request" smart
callback is removed and replaced with a user defined callback
set with ewk_view_notification_permission_callback_set().
Other functions added in this patch:
ewk_notification_permission_reply
Following functions are now deprecated:
ewk_notification_permission_request_set
ewk_notification_permission_request_suspend
This patch is a merge of the following patches:
http://165.213.202.130:8080/#/c/69294/
http://165.213.202.130:8080/#/c/70194/
http://165.213.202.130:8080/#/c/72200/
by Filip Piechocki
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9559
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Tworek
Change-Id: I34c818a7f09735bcbf4aec4298851a2002e7bbc1
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Antonio Gomes [Thu, 15 Jan 2015 16:44:58 +0000 (08:44 -0800)]
Stop autogenerating chromium-efl.pc
As part of an earlier build system refactor [1],
we stopped using a static .pc file so that we
could export all chromium-efl defines to chromium-ewk
build system, as part of chromium-efl's pkgconfig cflags.
At this point, chromium-efl used GYP and chromium-ewk CMake.
After the build system integration [2], the situation
was fixed (defines were shared between both modules),
but we continued to export all internal defines in
chromium-efl.pc.
As a result, third-party apps that actually need to
deal with chromium-efl.pc, were wrongly having unrelated
defines set.
Particularly, in chromium-rgl beta/m40 branch, where "override"
and "final" are defined to nil due to compiler (GCC 4.6) limitations,
some ecore headers (namely Ecore_X.h) got affected, as the token
"override" was being used in its defitions.
Patch fixes that by switching back to a static
chromium-efl.pc file, and remove related code
that used to auto generate the pc file.
It allows the t-browser (beta/m34 branch) to build
out of the box on top of chromium-efl (beta/m40).
[1] http://165.213.202.130:8080/#/c/68779/
[2] http://165.213.202.130:8080/#/c/70211/
Reviewed by: Antonio Gomes, Piotr Tworek, Viatcheslav Ostapenko
Change-Id: I171233ab5c9812e9dd4a08cbbfcada3332fcce75
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
venu musham [Thu, 15 Jan 2015 05:49:07 +0000 (14:49 +0900)]
[SPIN] Add missing libdrm library in tizen 2.4
Add libdrm library needed by pixmap intialization. In tizen 2.3
libdrm is added with libdri2 implicitly, it is missing in tizen 2.4.
Reviewed by: Antonio Gomes, Piotr Tworek, Prashant Nevase
Change-Id: I1bd66ecdea8448547e608f8384ec53c7bed607bf
Signed-off-by: venu musham <venu.musham@samsung.com>
Piotr Tworek [Thu, 11 Sep 2014 11:19:25 +0000 (13:19 +0200)]
fixup! Remove Aura and GTK dependencies
With aura gone the GetNativeView functions from RenderWidgetHostViewEfl
and WebContentsViewEfl can actuall return correct view objects. The
functions can and are called from content layer when it creates new popup
windows.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5815
Reviewed by: Youngbok Yoon, Janusz Majnert
Reviewed by: Janusz Majnert, Piotr Tworek, Youngbok Yoon, commitbot
Change-Id: I9f37dadbc717623a13b7c4ddee3923d24bd01778
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Szawdyński [Fri, 9 Jan 2015 10:45:04 +0000 (11:45 +0100)]
[M34-Merge] Make sure RenderWidgetHostViewEfl is fully initialized after Init call
Currently the RenderWidgetHostViewEfl::Init_EvasGL may not be called
during object initialization. This can take place when the content_image_
for the view has empty size. It often happens in cases where the widget
was created but not yet inserted into the layout tree of the application.
The direct result of such approach is that any code that needs to access
Evas_GL* properties of RWHVEFL needs to make sure the properties are actually
valid. One example of such code is EWebView::GetSnapshot function. Currently
it does not contain the necessary checks leading to seemingly random crashes
when switching tabs in EFL browser.
Instead of lazy initializing Evas_GL we can simply ensure that the initial
size of the widget is always specified. Besides simplifying RWHVEFL
initialization it'll also help us avoid potential future problems with invalid
Evas_GL objects. It'll also make sure that the application can always take a
snapshot of the current content.
The patch uses the official way of specifying initial content size offered by
content API (WebContents::CreateParams::initial_size).
To avoid code duplication the WebContents related initialization code is moved
into a common function EWebView::InitializeContent.
Original patch:
"Make sure RenderWidgetHostViewEfl is fully initailzied after Init call"
by Piotr Tworek, http://165.213.202.130:8080/#/c/69477/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10194
Reviewed by: Janusz Majnert, Piotr Tworek, SeungSeop Park
Change-Id: I1c2c9f53ac55e84ad7890fa74907de2d164193d7
Signed-off-by: Piotr Szawdyński <p.szawdynski@samsung.com>
Youngcheol Kang [Thu, 15 Jan 2015 00:26:27 +0000 (09:26 +0900)]
[SPIN] Enabled to use OpenSSL instead of NSS
In the SPIN environment, the NSS version is 3.12.
For resolving this issue, we determined to use OpenSSL instead of NSS.
NSS will be updated in 2 months by toolchain team.
This patchset will be reverted when NSS will be updated.
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Ifc3e2788cc7fde300e0e7892a4ff92456851a2fc
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Tomasz Czekala [Tue, 13 Jan 2015 11:23:48 +0000 (12:23 +0100)]
[Tizen][M34-Merged]Fix memory issue and bug of cookie manager.
Totally three patch merged from M34:
1.EWebContext was kept inside UrlRequestContextGetterEfl as reference.
This reference was accessed from different thread than it belonged to.
The only thing that was taken from EWebContext was cookie manager which
supports scoped_refptr template. It was changed the way CookieManager is
passed around from Ewk_Cookie_Manager and applied it to UrlRequestContextGetterEfl.
(original patch in M34 : http://suprem.sec.samsung.net/gerrit/#/c/6511/)
2.Both CookieManager and URLRequestContextGetterEfl kept scoped_refptr to
each other. It caused CookieManager and URLRequestContextGetterEfl were
never released.
(original patch in M34 : http://suprem.sec.samsung.net/gerrit/#/c/6665/)
3.Fixed possible memory corruption and cookie manager related bug.
In some cases i.e. when there are multiple views used some
ContentBrowserClientEfl APIs would be used on invalid cookie manager.
ContentBrowserClientEfl kept only EWebContext for last launched renderer.
(original patch in M34 : http://suprem.sec.samsung.net/gerrit/#/c/6664/)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10344
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I9934da250dabd974192aa20537fb58f2e5454f7f
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Piotr Tworek [Thu, 8 Jan 2015 13:17:04 +0000 (14:17 +0100)]
Make it possible to compile chromium-efl on desktop using clang
Chromium provided version of clang has certain adventages over GCC:
* The compiler checks the code for coding style violations. It treats
them as warnings.
* Diagnostic messages displayed by the compiler are much more readable.
They use colors to signify the type of problem (red - error, yellow -
warning, etc), add custom ASCI art like indicators showing where the
problem is, display tips how the problem can be fixed.
* Chromium.org has switched to clang as the default compiler some time
around M38.
This patch makes it easy to build chromium-efl using clang. It's enough
to pass --clang flag to build_desktop.sh. The feature uses clang version
shipped together with chromium sources so the user does not need to
install anything on his/her system.
Reviewed by: Antonio Gomes, SeungSeop Park (OOO ~ 4/Jan/2015), Viatcheslav Ostapenko
Reviewed by: Antonio Gomes, Daniel Waślicki, Kamil Klimek, SeungSeop Park
Change-Id: I2e3966098aa397b6712c761709880ed9a5fa5294
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Piotr Sieduszewski [Mon, 12 Jan 2015 13:32:37 +0000 (14:32 +0100)]
fixup! Refactor implementation for ewk_certificate_policy_decision* API
This patch removes many warnings about initialization order
in class _Ewk_Certificate_Policy_Decision.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9518
Reviewed by: Janusz Majnert, Piotr Tworek, SeungSeop Park
Change-Id: Idb37c4b286b24ae22c43933e77d4dca4c077c377
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Lukasz Krok [Thu, 18 Dec 2014 15:24:23 +0000 (16:24 +0100)]
Fix ewk_view_orientation_send API
The ewk_view_orientation_send API did not triggered orientationchanged event.
This patch fixes that.
Additionally, coresponding unit tests were refactored.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9541
Reviewed by: Min-Soo Koo, Piotr Tworek
Change-Id: I94ee975eb6cde25391a37dbfe370212e6b49cc17
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Piotr Tworek [Mon, 12 Jan 2015 14:36:49 +0000 (15:36 +0100)]
Link chromium-efl statically when building content_shell_efl
Currently content_shell_efl application is built on top of both original
content_shell_lib component and chromium-efl library. This solution
allows us to avoid modification to the upstream files and gain access to
new code added for EFL port purposes. Unfortunately the solution has some
drawbacks. The one I was originally aware was that some source
files are compiled into both libchromium-efl.so and content_shell_efl
binaries. In ideal world content_shell_efl should only be composed of
sources from src/content/shell directory. Unfortunately upstream gyp
files add dependencies on various content components which are of
static_library type. The same components are also used by chromium-efl
target. The dynamic linker can't possibly figure out that some of those
static libraries are alrady part of libchromium-efl shared library and
thus it can't eliminate them. As a result the content_shell_efl is
slightly bigger than it should actually be.
For m34 this did not seem to be a problem. In m40 however we've observed
crashes caused by GetContentClient() function returning NULL value.
This was especially strange considering the fact the function bsically
returns a value of a global variable g_client. We always initialize it
to non NULL value early in the application startup and we never clear it
during application lifetime. The problem is that the variable is defined
in a source file which is a part of content_common build target which
both content_shell_lib and chromium-efl targets depend on. The
SetContentClient and GetContentClient functions are not considered
public and are not marked with CONTENT_EXPORT. As a result they're
hidden inside chromium-efl binary. Whenever the getter function will be
invoked from any code present in the chromium-efl binary it'll refer to
it's own 'copy' of the global variable. Code from content_shell_efl
will have 'copy' of the same global variable. As a result during startup
we initialized the version present in the content_shell_efl binary, but
never touched the one from libchromium-efl. When later GetContentClient
happens to be called from code being part of libchromium-efl.so it'll
return the value of the second, unitialized g_client.
Since fixing those problems at their core would require some bigger
changes to content_shell gyp/gypi files this patch uses an alternative,
but also effective solution. It changes the type of chromium-efl target
from shared to static library in case of content_shell builds. This
means the linker will only get object files when producing
content_shell_efl binary and will be able to remove duplicated code
parts. It's very similar to the upstream solution where content_shell is
always one fat binary that is invoked for all process types.
The downside is longer build times when content_shell application is
enabled. Also the --cotent-shell flag should not be used when
making normal builds which are supposed to be used for purpose of
running chromium layout tests.
With this patch in place the amount of layout test failures on beta
branch goes down from around 12k to only 1701.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10219
Reviewed by: Antonio Gomes, Min-Soo Koo
Change-Id: Ia68841ce85bb3084c0376bce35b7ea95d1ca35ae
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Tomasz Czekala [Wed, 31 Dec 2014 14:09:18 +0000 (15:09 +0100)]
[M34-Merge] Migrated chromium-efl internals to asynchrounous hit tests
Synchronous hit tests may cause dead lock between renderer process and
browser process. This is port of the following patch
http://suprem.sec.samsung.net/gerrit/#/c/5908/ by Kamil Klimek
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9525
Reviewed by: Janusz Majnert, Piotr Tworek, arno renevier
Change-Id: Ia38d10d789f7ee675368ca13c7f4d7d815b97e7a
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Wojciech Wiśniewski [Fri, 2 Jan 2015 14:12:50 +0000 (15:12 +0100)]
fixup! [M40] Force define DL_ARM_NEON_OPTIONAL to bypass mobile/tv build break in M40.
Removing DL_ARM_NEON_OPTIONAL define from global chromium-efl.gypi file, because it causes build break in debug build.
Defining DL_ARM_NEON_OPTIONAL makes omxSP_FFTFwd_RToCCS_F32 and omxSP_FFTInv_CCSToR_F32 symbols
refer to function pointers, which are defined in src/third_party/openmax_dl/dl/sp/src/arm/detect.c ,
but this file is Android-specific and is not compiled for Tizen. Fortunately,
omxSP_FFTFwd_RToCCS_F32 and omxSP_FFTInv_CCSToR_F32 functions are used only in code
in src/third_party/webrtc/common_audio/real_fourier.cc , which turns out to be never used
and linker optimizes it away. But in debug mode it causes linking error.
The define was once needed when we didn't have arm_neon=1 in gyp. This was causing
that in openmax package (src/third_party/openmax_dl/dl/dl.gyp) neither DL_ARM_NEON nor
DL_ARM_NEON_OPTIONAL were defined. It resulted in omxSP_FFTFwd_RToCCS_F32 and
omxSP_FFTInv_CCSToR_F32 symbol being defined to VFP versions of the functions, and build error.
But now we have arm_neon=1 and this isn't needed anymore. omxSP_FFTFwd_RToCCS_F32 and
omxSP_FFTInv_CCSToR_F32 symbols will be defined to NEON versions of the functions
without runtime detection.
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park, arno renevier
Change-Id: Id1f9c3d87f19c472a00454abb7c63cf02ceabfb3
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
Michal Poteralski [Mon, 12 Jan 2015 07:04:58 +0000 (08:04 +0100)]
fixup! Minor improvements of desktop build scripts.
There is a fixup of patch which changed common.sh script argument name from
"content_shell" to "content-shell". Nevertheless, the argument name has not
been changed in README.md file, this fixup improves it.
Reviewed by: Antonio Gomes, Piotr Tworek
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Change-Id: I7ea0676f0f6170b03215a316f9ae9d57a416b91c
Signed-off-by: Michal Poteralski <m.poteralski@samsung.com>
Arnaud Renevier [Tue, 23 Dec 2014 23:48:49 +0000 (15:48 -0800)]
Check that rwhv is non non-null in EWebView::SetViewMode
EWebView::SetViewMode will crash if rwhv() is null. This patch postpones
the call until the view creation.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9746
Reviewed by: Antonio Gomes, Piotr Tworek
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Change-Id: I5a0c9706fc280a7165ae9747d45f8212d1a17526
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Piotr Szawdyński [Thu, 8 Jan 2015 16:39:55 +0000 (17:39 +0100)]
[M34-Merge] Attempt to gracefully handle renderer process crashes
The current chromium-efl tries to handle renderer process crashes by
invoking "webprocess,crashed" EFL callback on the EWebView. The callback
is expected to set the value of event_info to true and delete the
EWebView instance for which the crash did happen. After the callback is
invoked the crashed EWebView would be in an unusable state. Using it
would immediately cause the UI process to crash.
The problem with the current approach is only efl_webview_app actually
implements the callback. Other applications like mini_browser,
com.samsung.browser or com.samsung.email do not even register it. The
end result is webprocess crashes can actually bring down the entire app.
This defeats the purpose of chromium multi-process architecture.
This patch solves the problem by re-creating WebContents after the
renderer crash. The "webprocess,crashed" is now only used as a
notification mechanism. The embedder handling it is only responsible for
informing the user about the fact and possibly loading another page. If
it does not handle the callback the engine will show a simple error
page. The behaviour aligns chromium-efl with WebKitEfl behaviour.
Original patches:
1) "Attempt to gracefully handle renderer process crashes" by Piotr Tworek
http://165.213.202.130:8080/#/c/69203
2) "Handle rendenrer crashes in efl_webview_app properly" by Piotr Tworek
http://165.213.202.130:8080/#/c/69448
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10194
Reviewed by: Janusz Majnert, Min-Soo Koo
Change-Id: I52407fbcd672f7726fb34bb83e911e6a784a149c
Signed-off-by: Piotr Szawdyński <p.szawdynski@samsung.com>
Piotr Sieduszewski [Fri, 9 Jan 2015 15:49:56 +0000 (16:49 +0100)]
Test for ewk_geolocation_permission_reply
This test check accept and reject to access to localization data.
This test will fail if GPS is off or no received signal.
This is a cherry-pick from http://165.213.202.130:8080/73122
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9556
Reviewed by: Janusz Majnert, Min-Soo Koo, Piotr Tworek, commitbot
Change-Id: I1d69d8a5dca48c4741f5b8a41af2ce8ed0e03e9b
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Piotr Tworek [Fri, 9 Jan 2015 16:31:18 +0000 (17:31 +0100)]
Hide content_shell URL bar when running in test mode
A couple of layout tests fail because they expect the web contents to
have the a size of 800x600 px. This value is given to the application
during init stage, but EFL shell uses it as the size of the application
window. It means the value is divided between the webview and URL bar.
The size of the URL bar depends on the current EFL theme so we can't
easilt resize the window to compensate for the difference.
Fortunately the URL bar is not actually needed by the tests themselves.
We can simply disable it, when running them. To detect such situation
--dump-render-tree flag is used. Chromium always specifies it when
running layout tests. In fact the flag is used to enable layout
test specific code paths in the upstream content_shell code.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9684
Reviewed by: Antonio Gomes, Min-Soo Koo
Change-Id: I99f25b8ccd2f73677db94270ea4093f8d1d57dcf
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Wojciech Bielawski [Thu, 8 Jan 2015 13:10:05 +0000 (14:10 +0100)]
Refactor implementation for ewk_certificate_policy_decision* API
_Ewk_Certificate_Policy_Decision objects shall be destroyed after the user
takes decision with adequate API. Since policy decision may be suspended,
lifetime of _Ewk_Certificate_Policy_Decision needs to be passed over to API
functions. Similar behavior is needed for other API visible objects such as
_Ewk_Geolocation_Permission_Request, that's why common implementation is
provided in Ewk_Suspendable_Object class.
Modified tests:
utc_blink_ewk_certificate_policy_decision_ceritificate_pem_get_func
utc_blink_ewk_certificate_policy_decision_suspend_func
utc_blink_ewk_certificate_policy_decision_url_get_func
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9518
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: I80608c70247ebd02aac7b3bf1785b048143a3dcc
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Piotr Sieduszewski [Tue, 30 Dec 2014 10:57:52 +0000 (11:57 +0100)]
fixup! TC utc_blink_ewk_view_app_name_user_agent_set_func refactoring.
In case the 2nd argument is an empty string (not NULL)
ewk_view_application_name_for_user_aget_set should return EINA_TRUE.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9327
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: I39256561b5c54fc91f1095e0ec03b814b5e8b69b
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Wojciech Bielawski [Wed, 7 Jan 2015 13:47:29 +0000 (14:47 +0100)]
Implementation of unit tests for ewk_view_main_frame_get
New test added:
utc_blink_ewk_view_main_frame_get_func
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9577
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: Ib5ce656323fc0892f1b83853a956e25b3112e598
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Piotr Sieduszewski [Fri, 9 Jan 2015 12:30:01 +0000 (13:30 +0100)]
Test for ewk_autofill_profile_id_get
This test create 2 profiles, and check a id of it.
This reverts http://165.213.202.130:8080/71877
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9542
Reviewed by: Janusz Majnert, Piotr Tworek, SeungSeop Park, commitbot
Change-Id: Id958bf3a108b1a6b74d424f7e3a87166ab9015eb
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Piotr Tworek [Thu, 18 Dec 2014 13:07:35 +0000 (14:07 +0100)]
Minor improvements of desktop build scripts.
This is a collection of small fixes I've recently made while playing
with chromium-efl build_desktop.sh script. Those are:
1. Improve argument parsing. Previous code needed 2 forks and a pipe to
parse every single argument passed to the script. The same
functionality can be achieved by only using shell built-in commands.
It's more efficient and IMO easier to read.
2. Use integer comparison operations for variables which are supposed to
have only integer values.
3. Clean-up script help message.
4. Use find instead of inefficient for loop to find files newer than
jhbuild stamp.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Antonio Gomes, Kamil Klimek
Change-Id: If390100b05a362f4ac33a63684210d7990533068
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Yi Shen [Fri, 7 Nov 2014 19:22:13 +0000 (11:22 -0800)]
[Tizen][Dev] Enable favicon path in WebContentsDelegateEfl::DidFinishLoad
This patch 1) enables favicon path in DidFinishLoad() since no crash observed
anymore; 2) validates favicon before starting downloading it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7883
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Change-Id: I89f9c0ebac94fefd72f23a13aecd23ef7caa3bd8
Signed-off-by: Yi Shen <yi.shen@samsung.com>
msu.koo [Thu, 8 Jan 2015 07:18:23 +0000 (16:18 +0900)]
Revert "[Tizen][MM][Webrtc] Enable H/W accelerated H.264 support for WebRTC on Tizen"
To reflect the landed commit on dev, this commit is reverted.
This reverts commit
021c7e8a3f463970ea425eb28715c165160bc56a.
Together with: I561e35cb4ea2626a12b8d2a42f04f01bd12f9378
Reviewed by: Min-Soo Koo, Vinod Keshav
Change-Id: I98dbeed585f45fb57b36e38cbe5ead78193d7a01
Signed-off-by: msu.koo <msu.koo@samsung.com>
Balazs Kelemen [Wed, 10 Sep 2014 15:49:34 +0000 (11:49 -0400)]
Add support for cross-compilation
crosscompile is useful for development purposes. I do not intend to replace
gbs with this, just to help developers (including myself) doing their job quicker.
The idea is that once you built with gbs you can use it's build root together
with the tizen sdk to crosscompile for mobile.
Co-authored by Balazs Kelemen and Tomasz Olszak.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6110
Reviewed by: Balazs Kelemen, Piotr Tworek, SeungSeop Park
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Iff75f7e0917aa7141fb075d46a3734c94cbf5a8b
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Tomasz Czekala [Wed, 7 Jan 2015 14:35:15 +0000 (15:35 +0100)]
Remove Memory Sampler
Patch removes Memory Sampler EWK interface and mocks it's implementation.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9553
Reviewed by: Antonio Gomes, Janusz Majnert
Change-Id: I2ab75cd46034efb8c646e7eef0db369d926920c7
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Piotr Sieduszewski [Wed, 7 Jan 2015 08:00:00 +0000 (09:00 +0100)]
Implement EWK web context inspector APIs
Implementation of:
- ewk_context_inspector_server_start
- ewk_context_inspector_server_stop
Classes WebContext and EWebContest implement methods for starting and
stopping debug tools supported by a class DevToolsDelegateEfl
TC for ewk_context_inspector_server_start try start inspector server on:
- specified port and open url
- unspecified port and open url with returned port
- used port
TC for ewk_context_inspector_server_stop try:
- stop WebInspector without start (expexted fail).
- start WebInspector on port 11111 TCP and stop it.
To see if it's stopped:
- try open page on this port, and
- run WebInspector on the same port again.
This patch contains following patches:
http://165.213.202.130:8080/68795
http://165.213.202.130:8080/69030
http://165.213.202.130:8080/69486
http://165.213.202.130:8080/69059
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9549
Reviewed by: Janusz Majnert, Kamil Klimek, Min-Soo Koo, Piotr Tworek
Change-Id: Ib769a0d27fb45b4f90a8f8afa1722955f5c77eb4
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Filip Piechocki [Tue, 16 Dec 2014 14:03:40 +0000 (15:03 +0100)]
Fixed UTC for ewk_view_add_with_session_data.
The test was expecting that the webview won't be created
for the NULL session data, while according to WebKit-EFL code,
this should create empty webview. Current implementation
does exactly this, so the test case had to be fixed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9537
Reviewed by: Piotr Tworek, SeungSeop Park
Reviewed by: Janusz Majnert, Piotr Tworek, SeungSeop Park, commitbot
Change-Id: I50d64f7083457c834aba4bd2338d22dfdf48c056
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Wojciech Bielawski [Thu, 11 Dec 2014 15:50:30 +0000 (16:50 +0100)]
[M34-Merge] Implementation of properties required by ewk_settings_extra_feature_get/set API
Default properties values were taken from webkit-efl implementation.
Note that none of these properties is used so in fact they do not change
behaviour of webview. They're simply stored for future reference.
This is a cherry-pick from: http://165.213.202.130:8080/#/c/68642/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9531
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: Ia0a1d08cbd0f5701b859325bde393a6a10d3a820
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Tomasz Czekala [Mon, 22 Dec 2014 16:17:22 +0000 (17:17 +0100)]
Add support for error domain in Ewk_Error
This patch is a merge of the following patches:
http://suprem.sec.samsung.net/gerrit/#/c/4951/ by Kamil Klimek
http://165.213.202.130:8080/#/c/72583/ by Wojciech Bielawski
http://165.213.202.130:8080/#/c/70134/ by Piotr Tworek
http://165.213.202.130:8080/#/c/69708/ by Nguyen Van Canh
And fixes required for migrating to m40
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9850
Reviewed by: Janusz Majnert, Min-Soo Koo, Piotr Tworek
Change-Id: If8ad47e247a6909d08c67fd4830e0bf15065322e
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Lukasz Krok [Fri, 19 Dec 2014 14:46:29 +0000 (15:46 +0100)]
Changing way of test page loading in utc_blink_ewk_view_contents_pdf_get test
Loading google.com page by ewk_view_url_set() resulted with error:
"Unsafe attempt to load URL from frame with URL
http://www.google.pl/?gfe_rd=cr&ei=qzWUVKGhG4jBVLOZgsAP.
Domains, protocols and ports must match"
It looks like google.com page changed recently
and made cross-domain call in the test.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9539
Reviewed by: Janusz Majnert, Min-Soo Koo
Change-Id: I05d84269fe1885060bb62188086a8cd35bf0ff6a
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Filip Piechocki [Tue, 9 Dec 2014 15:33:12 +0000 (16:33 +0100)]
Improving ewk_shutdown and ewk_view_add to avoid potential crashes.
EwkGlobalData instance pointer was deleted in ewk_shutdown()
but not NULLed, so it was not reinitialized after calling
EwkGlobalData::Ensure() which may lead to crash. There was
not EINA_SAFETY_CHECK on Evas pointer in ewk_view_add which
may lead to invalid object creation and crash.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9253
Reviewed by: Antonio Gomes, Min-Soo Koo, Piotr Tworek, commitbot
Change-Id: I2a3ebeabd0f2141cb71eafb0304d83bcbbde9f5a
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Piotr Sieduszewski [Thu, 18 Dec 2014 13:34:32 +0000 (14:34 +0100)]
fixup! Allow local git clone in sync_repos.sh
It add exit error code to sync_reps.sh if it can't rebase,
for example when a file in src/ was modified.
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek, SeungSeop Park (OOO ~ 4/Jan/2015), commitbot
Change-Id: I6a128283b69e6cb16906439880d1c3535e3c9e2c
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
ws29.jung [Tue, 9 Dec 2014 10:16:07 +0000 (19:16 +0900)]
Implementation of Web Speech Feature
Issue: Migration of Web Speech Feature from M34 to M40
This patch enable the tts Web Speech feature in M40.
This structure is same as other platform's Web Speech Feature,
but it didn't have implemented speech synthesiszer object.
Also Tizen has it's own tts engine so we need to have class
that communicate with tts engine.
M34 Patch lists:
http://165.213.202.130:8080/#/c/71224/
http://165.213.202.130:8080/#/c/71751/
http://165.213.202.130:8080/#/c/72468/
Initialy it was implemented under src/ and impl/ folders,
but now everything has been moved into impl/.
However, this patch only enable M40 mobile feature, not TV.
Cherry-picked from merged code (M40 dev)
http://165.213.202.130:8080/#/c/72994/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9648
Reviewed by: Piotr Tworek, Viatcheslav Ostapenko
Reviewed by: Piotr Tworek, Viatcheslav Ostapenko, commitbot
Change-Id: I0b89b0490e2552c28c248808994bc396806c0e69
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Daniel Waślicki [Mon, 15 Dec 2014 10:30:28 +0000 (11:30 +0100)]
Scroll and zoom to focused editable element
Scroll to focused editable element on text input state changed.
It will cause that when input field is focused, page will be
scrolled and zoomed to this element.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9614
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park (OOO ~ 4/Jan/2015)
Change-Id: If4887013e97eba381112109295ec65aba751f6b6
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
SeungSeop Park [Fri, 19 Dec 2014 05:14:36 +0000 (14:14 +0900)]
Add owners for tizen beta/ branch.
Change-Id: I9baa7965ae6019fd27df2ec029230fd51e7d1a08
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Tomasz Czekala [Wed, 17 Dec 2014 09:22:37 +0000 (10:22 +0100)]
fixup! Add Tizen-platform implementation of RenderViewObserver
Adds internal pointer validation for WebNode objects.
In file render_view_observer_efl.cc, object WebNode is intensively used.
Its methods call is usually using corresponding calls of internal Node pointer.
Since class WebNode has default constructor it can have this internal pointer
uninitialized. It was the main cause of the crash in taping cases. Adding
validation of this internal Node pointer in function DoHitTest() (using
WebNode::isNull() method), solved problem.
This is a cherry-pick of the following patch:
http://165.213.202.130:8080/#/c/68604/ by Sergiy Prutskov
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9525
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: Ib623ae17bb658c9871c20a40545f83de292a5038
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
SeungSeop Park [Fri, 12 Dec 2014 09:22:17 +0000 (18:22 +0900)]
[M40 Beta] Setup Tizen Beta branch beta/m40_2214_t
Base chromium version is 40.0.2214.38 from linux beta channel.
Downstream patches have been rebased onto it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9805
Change-Id: I7bfb0545f8f77cd1eaa893833ad6d4cd20ba9c08
Signed-off-by: SeungSeop Park <sns.park@samsung.com>