platform/upstream/dotnet/runtime.git
6 years agoUse `FEATURE_ARG_SPLIT` to qualify handling of `GT_PUTARG_SPLIT`
Carol Eidt [Tue, 17 Jul 2018 04:45:47 +0000 (21:45 -0700)]
Use `FEATURE_ARG_SPLIT` to qualify handling of `GT_PUTARG_SPLIT`

Commit migrated from https://github.com/dotnet/coreclr/commit/8a6fe594c1f85c762ad94c3dd9b9828d3ae0459c

6 years agoPR Feedback
Carol Eidt [Mon, 16 Jul 2018 23:31:00 +0000 (16:31 -0700)]
PR Feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/c296f061a50c91bebad767aa1e5421d1646ce6a6

6 years agoEnsure BuildUse uses the correct reg number
Carol Eidt [Thu, 12 Jul 2018 19:51:06 +0000 (12:51 -0700)]
Ensure BuildUse uses the correct reg number

`BuildUse` was setting the regNumber for all of the uses of a multi-reg  node to the main/first regNum. This was missed because this results in a def/use conflict on that reg (the def was set correctly), which is generally resolved in favor of the def. The exception is when there is a kill of the register in between, in which case the use tries to allocate the register its been assigned, causing the `farthestRefPhysRegRecord != nullptr` assert (aka "a register can't be found to spill").
This fixes the specific issue, and adds additional asserts to identify future/additional such issues.
The new asserts depend upon all the regNums being appropriately when/if any are set, which wasn't always the case prior to register allocation.

Fix dotnet/coreclr#18153

Commit migrated from https://github.com/dotnet/coreclr/commit/b4470d75fa6ab4461607f2a0135cd118f466c2ef

6 years agoOptimize Double/Single.IsNegative
Jan Kotas [Wed, 11 Jul 2018 06:46:39 +0000 (23:46 -0700)]
Optimize Double/Single.IsNegative

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/874b694fa31c1ce92491f2191ed4a006c51ae2d4

6 years agoMake Number.Parsing.cs BigEndian friendly (dotnet/coreclr#18853)
Egor Bogatov [Wed, 11 Jul 2018 06:04:06 +0000 (09:04 +0300)]
Make Number.Parsing.cs BigEndian friendly (dotnet/coreclr#18853)

* Make Number.Parsing.cs BigEndian friendly

* Get rid of DoubleHelper

Commit migrated from https://github.com/dotnet/coreclr/commit/b3c98d54b3aba980c4ed38e87fd3f7a13e2598ee

6 years agoMerge pull request dotnet/coreclr#18861 from BruceForstall/FixShowLocalloc
Bruce Forstall [Wed, 11 Jul 2018 03:55:39 +0000 (20:55 -0700)]
Merge pull request dotnet/coreclr#18861 from BruceForstall/FixShowLocalloc

Fix ShowLocallocAlignment test for x86

Commit migrated from https://github.com/dotnet/coreclr/commit/9cd6e82f210aadbc4335f00263dd80fa8dcb44b3

6 years agoMerge pull request dotnet/coreclr#18860 from BruceForstall/ReEnable13731Tests
Bruce Forstall [Wed, 11 Jul 2018 03:55:02 +0000 (20:55 -0700)]
Merge pull request dotnet/coreclr#18860 from BruceForstall/ReEnable13731Tests

Re-enable tests for dotnet/coreclr#13731 which was closed long ago

Commit migrated from https://github.com/dotnet/coreclr/commit/b2abf26c41d1c56a6f86a4241713333e6fd8dd69

6 years agoAdjust JIT automated testing for tiered compilation (dotnet/coreclr#18828)
Noah Falk [Wed, 11 Jul 2018 01:33:57 +0000 (18:33 -0700)]
Adjust JIT automated testing for tiered compilation (dotnet/coreclr#18828)

Make it explicit that most JIT testing does not use tiered compilation regardless of the runtime default
Clone jitstress1/2 and r2r_jitstress1/2 test modes both with and without tiering.
Move the existing tieredcompilation test modes to have the same periodic scheduling as other jit test runs.

Commit migrated from https://github.com/dotnet/coreclr/commit/d5db5acff13e973bbe1764ba4cbaff5912df6fba

6 years agoFix ShowLocallocAlignment test for x86
Bruce Forstall [Tue, 10 Jul 2018 23:50:54 +0000 (16:50 -0700)]
Fix ShowLocallocAlignment test for x86

The required localloc alignment differs by platform. Teach the test
what the per-platform alignment requirement is.

Fixes dotnet/coreclr#7163

Commit migrated from https://github.com/dotnet/coreclr/commit/164f9c55ce4fec7b8236ee5c7c1d87de708f394b

6 years agoRe-enable tests for dotnet/coreclr#13731 which was closed long ago
Bruce Forstall [Tue, 10 Jul 2018 23:22:48 +0000 (16:22 -0700)]
Re-enable tests for dotnet/coreclr#13731 which was closed long ago

Commit migrated from https://github.com/dotnet/coreclr/commit/5635ab60e1b8c2cf582e549f6ee336ea6afafd3d

6 years agoRemove random.NextDouble() from JIT/HardwareIntrinsics tests (dotnet/coreclr#18838)
Egor Chesakov [Tue, 10 Jul 2018 23:15:15 +0000 (16:15 -0700)]
Remove random.NextDouble() from JIT/HardwareIntrinsics tests (dotnet/coreclr#18838)

* Add ProjectReference to CoreCLRTestLibrary.csproj in the corresponding C# project files
* Replace usages of random.NextDouble() from GenerateTests.csx with CoreCLRTestLibrary.Generator.GetSingle()/GetDouble()
* Regenerate test files

Commit migrated from https://github.com/dotnet/coreclr/commit/a211090331c5e4830bb037fb078d199e2234b865

6 years agoInitial implementation of method fixup parser (dotnet/coreclr#18749)
Tomáš Rylek [Tue, 10 Jul 2018 21:48:25 +0000 (23:48 +0200)]
Initial implementation of method fixup parser (dotnet/coreclr#18749)

* Initial implementation of method fixup parser

I'm working on this right now in the CoreRT R2R compiler so I'm
adding the relevant structures and algorithms to the dumper
to let me analyze various R2R files and their method fixups.

I have locally verified that this shows reasonable fixup info
for my Hello World repro compiled both using the CoreRT R2R
compiled and using crossgen.

Thanks

Tomas

* Improvements in signature dumping

Signature dumping was slightly imprecise - the signature field
was named "Section" in the dump and it was displaying a dword,
however signatures are logically arbitrary byte streams.

Sadly I'm aware of no easy way to detect the length of an
arbitrary signature without adding a multitude of dedicated
parsers for the different signature types used by different
fixup / helper types so for now I'm displaying an 8-byte sample.

I have also made the formatting of the import section entries
more compact to make the list easier to read in the presence
of a larger number of fixups and I added support for displaying
the entry offset (as this is what the method fixups indirectly
refer to via the fixup indices).

Thanks

Tomas

* Move NibbleReader into a separate source file

Based on Amy's PR feedback I'm moving NibbleReader into a separate
source file. After all, I have a counterpart NibbleWriter.cs
in the R2R compiler codebase.

Thanks

Tomas

* Remove unnecessary usings from the new NibbleReader.cs file

As an additional bit of cleanup I used the VS refactoring tool
to remove unnecessary usings from the new NibbleReader source file.

Thanks

Tomas

Commit migrated from https://github.com/dotnet/coreclr/commit/f39809b6e560450daa299d7566ca6d861cb2c270

6 years agoFixing encodeXmmRegAsIval to ensure the result meets the "fits in imm8" check
Tanner Gooding [Tue, 10 Jul 2018 04:46:41 +0000 (21:46 -0700)]
Fixing encodeXmmRegAsIval to ensure the result meets the "fits in imm8" check

Commit migrated from https://github.com/dotnet/coreclr/commit/52d8382f819cdc66e01c2e2fdd6dd3c6c6cd4fee

6 years agoMerge pull request dotnet/coreclr#18805 from CarolEidt/Fix18746
Carol Eidt [Tue, 10 Jul 2018 20:33:02 +0000 (13:33 -0700)]
Merge pull request dotnet/coreclr#18805 from CarolEidt/Fix18746

Don't change PUTARG_REG spill type on arm64

Commit migrated from https://github.com/dotnet/coreclr/commit/eb405392acacf6f5b72601521ec4ac5106d1e2ba

6 years agoFix two issues in Marshal.SecureStringToBSTR (dotnet/coreclr#18851)
Stephen Toub [Tue, 10 Jul 2018 20:02:06 +0000 (16:02 -0400)]
Fix two issues in Marshal.SecureStringToBSTR (dotnet/coreclr#18851)

1. It wasn't synchronized, even though other operations on SecureString are in order to avoid concurrency problems leading to memory corruption issues (and it's synchronized on netfx).

2. It wasn't throwing an ObjectDisposedException if the instance was disposed.

Commit migrated from https://github.com/dotnet/coreclr/commit/cb005bd771122d919587c646aaebfce7176b36db

6 years agoMerge pull request dotnet/coreclr#18812 from briansull/fix_610014
Brian Sullivan [Tue, 10 Jul 2018 20:01:41 +0000 (13:01 -0700)]
Merge pull request dotnet/coreclr#18812 from briansull/fix_610014

Fix 610014

Commit migrated from https://github.com/dotnet/coreclr/commit/75c64dc83879c87ff0a170eced907f7ed2b8fbd5

6 years agoMerge pull request dotnet/coreclr#18653 from acmyu/build
Amy [Tue, 10 Jul 2018 18:10:08 +0000 (11:10 -0700)]
Merge pull request dotnet/coreclr#18653 from acmyu/build

R2RDump - Build integration

Commit migrated from https://github.com/dotnet/coreclr/commit/7920cf173d88bc5c56c7f8ab856dd91627dd0832

6 years agoRegenerating the x86 HWIntrinsic tests to cover struct field scenarios
Tanner Gooding [Tue, 10 Jul 2018 01:42:01 +0000 (18:42 -0700)]
Regenerating the x86 HWIntrinsic tests to cover struct field scenarios

Commit migrated from https://github.com/dotnet/coreclr/commit/6de41e2f4ffd8971d767e2aadb195f8c51286479

6 years agoUpdating the x86 HWIntrinsic test templates to test struct field scenarios
Tanner Gooding [Tue, 10 Jul 2018 01:41:28 +0000 (18:41 -0700)]
Updating the x86 HWIntrinsic test templates to test struct field scenarios

Commit migrated from https://github.com/dotnet/coreclr/commit/2d7baf26bcb149610f261b7eeee5d59c19cfc1be

6 years agoMove BinaryReader to shared CoreLib partition (dotnet/coreclr#18845)
Jan Kotas [Tue, 10 Jul 2018 11:13:04 +0000 (04:13 -0700)]
Move BinaryReader to shared CoreLib partition (dotnet/coreclr#18845)

Commit migrated from https://github.com/dotnet/coreclr/commit/dab0d7108e8b0091e1d7f526cab7dc9bcb71710a

6 years agoExclude failing CoreFx test (dotnet/coreclr#18844)
Amy [Tue, 10 Jul 2018 08:49:54 +0000 (01:49 -0700)]
Exclude failing CoreFx test (dotnet/coreclr#18844)

Commit migrated from https://github.com/dotnet/coreclr/commit/39229d58944ce415108e1f6e59a4ab5c77e93226

6 years agoUpdated fix for VSO 610014
Brian Sullivan [Fri, 6 Jul 2018 21:33:36 +0000 (14:33 -0700)]
Updated fix for VSO 610014

Commit migrated from https://github.com/dotnet/coreclr/commit/295e24c01618ff3196e7bd7df60c21099ef28872

6 years agoFixing a call to emitIns_SIMD_R_R_AR_R to pass arguments in the correct order
Tanner Gooding [Sat, 7 Jul 2018 20:02:32 +0000 (13:02 -0700)]
Fixing a call to emitIns_SIMD_R_R_AR_R to pass arguments in the correct order

Commit migrated from https://github.com/dotnet/coreclr/commit/23f7cb061460fc238992845e5757b1516f64c5cb

6 years agoExclude failing CoreFx test
Amy Yu [Mon, 9 Jul 2018 23:36:39 +0000 (16:36 -0700)]
Exclude failing CoreFx test

Commit migrated from https://github.com/dotnet/coreclr/commit/0cde2fb55bf7a809b207dbf04612bc9db808df62

6 years agoUpdating InstructionSet_BMI1/2 to be controlled by the COMPlus_EnableAVX flag and...
Tanner Gooding [Sat, 7 Jul 2018 14:11:51 +0000 (07:11 -0700)]
Updating InstructionSet_BMI1/2 to be controlled by the COMPlus_EnableAVX flag and fixing formatting issues

Commit migrated from https://github.com/dotnet/coreclr/commit/52f9c8a5258267168c97ebb54bce729b26ea3c30

6 years agoAdding tests for the ParallelBitDeposit and ParallelBitExtract Bmi2 HWIntrinsics
Tanner Gooding [Fri, 6 Jul 2018 16:29:33 +0000 (09:29 -0700)]
Adding tests for the ParallelBitDeposit and ParallelBitExtract Bmi2 HWIntrinsics

Commit migrated from https://github.com/dotnet/coreclr/commit/d5901fb25c06cfbf01961486f736f90ad254a06d

6 years agoImplementing the ParallelBitDeposit and ParallelBitExtract Bmi2 HWIntrinsics
Tanner Gooding [Fri, 6 Jul 2018 15:31:10 +0000 (08:31 -0700)]
Implementing the ParallelBitDeposit and ParallelBitExtract Bmi2 HWIntrinsics

Commit migrated from https://github.com/dotnet/coreclr/commit/5ec86ef02448839f02bd94dad8ef662e55770a19

6 years agoAdding tests for the AndNot, ExtractLowestSetBit, GetMaskUpToLowestSetBit, and ResetL...
Tanner Gooding [Fri, 6 Jul 2018 06:36:30 +0000 (23:36 -0700)]
Adding tests for the AndNot, ExtractLowestSetBit, GetMaskUpToLowestSetBit, and ResetLowestSetBit x86 HWIntrinsics

Commit migrated from https://github.com/dotnet/coreclr/commit/a1a58001acecb3779f06087d93470bcf515c2cf6

6 years agoImplementing the AndNot, ExtractLowestSetBit, GetMaskUpToLowestSetBit, and ResetLowes...
Tanner Gooding [Fri, 6 Jul 2018 06:34:58 +0000 (23:34 -0700)]
Implementing the AndNot, ExtractLowestSetBit, GetMaskUpToLowestSetBit, and ResetLowestSetBit x86 HWIntrinsics

Commit migrated from https://github.com/dotnet/coreclr/commit/a27def0c523fab5468bd25d9f72b069b07fc3317

6 years agoAdding tests for the x86 TrailingZeroCount HWintrinsic
Tanner Gooding [Wed, 4 Jul 2018 23:32:55 +0000 (16:32 -0700)]
Adding tests for the x86 TrailingZeroCount HWintrinsic

Commit migrated from https://github.com/dotnet/coreclr/commit/e60ad4d0db2a899fc52c30382deac063cef0a942

6 years agoImplementing the x86 TrailingZeroCount HWIntrinsic
Tanner Gooding [Wed, 4 Jul 2018 23:32:27 +0000 (16:32 -0700)]
Implementing the x86 TrailingZeroCount HWIntrinsic

Commit migrated from https://github.com/dotnet/coreclr/commit/a58184ff85db3c60014dbc5d05831131c2355fb0

6 years agoRenaming ScalarUnOpTest to ScalarSimdUnOpTest
Tanner Gooding [Wed, 4 Jul 2018 14:55:28 +0000 (07:55 -0700)]
Renaming ScalarUnOpTest to ScalarSimdUnOpTest

Commit migrated from https://github.com/dotnet/coreclr/commit/7bec88e95e9836e37cc62fb7797e2addf507fc23

6 years agoFix serialization type in NotFiniteNumberException (dotnet/coreclr#18833)
Viktor Hofer [Mon, 9 Jul 2018 21:41:07 +0000 (23:41 +0200)]
Fix serialization type in NotFiniteNumberException (dotnet/coreclr#18833)

Commit migrated from https://github.com/dotnet/coreclr/commit/fca544faf6e89b934ef7db71659968c459d0b5ed

6 years agoFix test errors
Amy Yu [Tue, 3 Jul 2018 19:59:22 +0000 (12:59 -0700)]
Fix test errors

Commit migrated from https://github.com/dotnet/coreclr/commit/98dd60aa14d4f52cc88b7f47379b1f90948ca26f

6 years agoUse BuildManagedTools argument instead of environment variable, removed unneeded...
Amy Yu [Tue, 3 Jul 2018 19:13:51 +0000 (12:13 -0700)]
Use BuildManagedTools argument instead of environment variable, removed unneeded flags

Commit migrated from https://github.com/dotnet/coreclr/commit/a7358133ec2544de4c4ddce5a1f75a8f449cb2ef

6 years agoAdd R2RDump to build.proj, running dotnet restore before target build
Amy Yu [Tue, 3 Jul 2018 00:45:00 +0000 (17:45 -0700)]
Add R2RDump to build.proj, running dotnet restore before target build

Commit migrated from https://github.com/dotnet/coreclr/commit/a5fbfa57fe7c9dc83d7f7bd4b464b97ffeed35d4

6 years agoCoreFX CI Unix Staging commit (dotnet/coreclr#18750)
Andon Andonov [Mon, 9 Jul 2018 17:45:24 +0000 (10:45 -0700)]
CoreFX CI Unix Staging commit (dotnet/coreclr#18750)

* Modify netci.groovy

* Add script exit codes

* Ad PR Triggers for Ubuntu and OSX10.12

* Remove release PR triggers

* Rename arch

Remove IsJitStressTestScenario assert

* Add correct asserts

* Reformat conditions and add triggers for Release/Checked/Debug

* Change %WORKSPACE% to \${WORKSPACE}

Commit migrated from https://github.com/dotnet/coreclr/commit/7baedfdafb6979f48026ed7e01de4b6cc14b3bba

6 years agoFix a comment in the string.ToLower() method (dotnet/coreclr#18832)
HumanEquivalentUnit [Mon, 9 Jul 2018 15:22:38 +0000 (16:22 +0100)]
Fix a comment in the string.ToLower() method (dotnet/coreclr#18832)

Line 307 is lowercasing the current character, but the comment says "store the current character, upper-cased", fixed comment to say "store the current character, lower-cased".
(Equivalent and correct "upper-cased" comment is on line 252)

Commit migrated from https://github.com/dotnet/coreclr/commit/4349690ec1c81a28c14ba2801240c94f3f79dec4

6 years agoUndo unnecessary BinaryReader::ReadOneChar/InternalReadOneChar split (dotnet/coreclr...
Jan Kotas [Mon, 9 Jul 2018 13:50:13 +0000 (06:50 -0700)]
Undo unnecessary BinaryReader::ReadOneChar/InternalReadOneChar split (dotnet/coreclr#18830)

This method had misleading comment that this split is required for performance. It was the case when
InternalReadOneChar was called from other places in CoreLib. These calls do not exist anymore.

Commit migrated from https://github.com/dotnet/coreclr/commit/4aac6883e54d53b41567b6b999559901d7efd4ec

6 years agoMoved ManualResetEventSlim to shared (dotnet/coreclr#18799)
Anirudh Agnihotry [Mon, 9 Jul 2018 09:21:55 +0000 (02:21 -0700)]
Moved ManualResetEventSlim to shared (dotnet/coreclr#18799)

* Moved ManualResetEventSlim to shared

* covert System.int to System.Int32

Commit migrated from https://github.com/dotnet/coreclr/commit/82828f73b8fb3dbfb578c7206606a465f2cfeeb1

6 years agoCorrect AssemblyLoadContext comment (dotnet/coreclr#18809)
Rich Lander [Sun, 8 Jul 2018 21:56:41 +0000 (14:56 -0700)]
Correct AssemblyLoadContext comment (dotnet/coreclr#18809)

Commit migrated from https://github.com/dotnet/coreclr/commit/13a7e7044b475caac8219f9eb6d34f6fd892e970

6 years agoLastIndexOf corner case fix when span is empty (dotnet/coreclr#18826)
Viktor Hofer [Sun, 8 Jul 2018 17:41:40 +0000 (19:41 +0200)]
LastIndexOf corner case fix when span is empty (dotnet/coreclr#18826)

Commit migrated from https://github.com/dotnet/coreclr/commit/018dc20cc8f5815867c30b22a4973702ce4716c4

6 years agoFix Span LastIndexOf empty value handling
Viktor Hofer [Sun, 8 Jul 2018 13:41:26 +0000 (15:41 +0200)]
Fix Span LastIndexOf empty value handling

Commit migrated from https://github.com/dotnet/coreclr/commit/3f4e0c7d2a281c2232fde6421b4a9fc18e889eac

6 years agoTargetFrameworkName property initialized (dotnet/coreclr#18814)
Anirudh Agnihotry [Sat, 7 Jul 2018 01:47:46 +0000 (18:47 -0700)]
TargetFrameworkName property initialized (dotnet/coreclr#18814)

Commit migrated from https://github.com/dotnet/coreclr/commit/2dd9ba545f9bca84bae2d1181d6327f4e8d470a7

6 years agoImprove DateTime{Offset}.ParseExact performance for "O"/"o" roundtrip format (dotnet...
Stephen Toub [Fri, 6 Jul 2018 16:12:54 +0000 (12:12 -0400)]
Improve DateTime{Offset}.ParseExact performance for "O"/"o" roundtrip format (dotnet/coreclr#18800)

Ports the code used by Utf8Parser, modified to support things Utf8Parser doesn't but DateTime{Offset{.ParseExact do, such as single-digit offset hours.

Commit migrated from https://github.com/dotnet/coreclr/commit/e650d42d14f0b701fbbe7fb8f4eb05616c0cf53d

6 years agoMerge pull request dotnet/coreclr#18795 from BruceForstall/RemoveArmemJobs
Bruce Forstall [Fri, 6 Jul 2018 16:00:49 +0000 (09:00 -0700)]
Merge pull request dotnet/coreclr#18795 from BruceForstall/RemoveArmemJobs

Remove Ubuntu/Ubuntu16.04 emulator CI jobs

Commit migrated from https://github.com/dotnet/coreclr/commit/a0ad19ec7305542fd5d1cc63a3a5d791bde63ae8

6 years agoDon't change PUTARG_REG type on arm64
Carol Eidt [Fri, 6 Jul 2018 14:00:03 +0000 (07:00 -0700)]
Don't change PUTARG_REG type on arm64

Fix dotnet/coreclr#18746

Commit migrated from https://github.com/dotnet/coreclr/commit/025a975e67b9069c62a62803ed5e51588db128bf

6 years ago[ARM] Mention a clang-5.0 issue in the documentation (dotnet/coreclr#18803)
nkaretnikov2 [Fri, 6 Jul 2018 12:54:28 +0000 (15:54 +0300)]
[ARM] Mention a clang-5.0 issue in the documentation (dotnet/coreclr#18803)

Commit migrated from https://github.com/dotnet/coreclr/commit/777618952db7e68e6b8e867f087f62d24b1b6fe1

6 years agoMerge pull request dotnet/coreclr#18775 from briansull/add-noway-assert
Brian Sullivan [Thu, 5 Jul 2018 23:03:18 +0000 (16:03 -0700)]
Merge pull request dotnet/coreclr#18775 from briansull/add-noway-assert

Add noway asserts in gtNewZeroConNode and gtNewOneConNode

Commit migrated from https://github.com/dotnet/coreclr/commit/5922cd345fe5de97efaccf426381db4ac74bc53c

6 years agoRemove Ubuntu/Ubuntu16.04 emulator CI jobs
Bruce Forstall [Thu, 5 Jul 2018 22:07:14 +0000 (15:07 -0700)]
Remove Ubuntu/Ubuntu16.04 emulator CI jobs

Now that we have Ubuntu arm hardware in the lab, these are unnecessary.

The jobs have also been failing for months.

Commit migrated from https://github.com/dotnet/coreclr/commit/591a710cf43f96346570c73745cf58dd739e3713

6 years agoUpdate certain Marshal APIs to match exception thrown on .NET Framework (dotnet/corec...
Aaron Robinson [Thu, 5 Jul 2018 21:29:27 +0000 (14:29 -0700)]
Update certain Marshal APIs to match exception thrown on .NET Framework (dotnet/coreclr#18791)

Update certain Marshal APIs to match exception thrown on Desktop

Commit migrated from https://github.com/dotnet/coreclr/commit/c32eff71383529355f85c83c3caee1953501e2e1

6 years agoAdded noway asserts in gtNewZeroConNode and gtNewOneConNode
Brian Sullivan [Wed, 20 Jun 2018 23:51:15 +0000 (16:51 -0700)]
Added noway asserts in gtNewZeroConNode and gtNewOneConNode
Added source code change that was needed to service 4.7.2 in fgMorphRecursiveFastTailCallIntoLoop
Set zero/one to null after noway_assert

Commit migrated from https://github.com/dotnet/coreclr/commit/47c744ebc48cb6c0654f8c11a09870efe16984a3

6 years agoMerge pull request dotnet/coreclr#18793 from BruceForstall/UpdateLibUnwindIssue
Bruce Forstall [Thu, 5 Jul 2018 17:51:42 +0000 (10:51 -0700)]
Merge pull request dotnet/coreclr#18793 from BruceForstall/UpdateLibUnwindIssue

Update Linux ARM libunwind instructions

Commit migrated from https://github.com/dotnet/coreclr/commit/d9d56cccf7b972ee3986e1b8e5113c41df4323de

6 years agoUpdate Linux ARM libunwind instructions
Bruce Forstall [Thu, 5 Jul 2018 17:50:06 +0000 (10:50 -0700)]
Update Linux ARM libunwind instructions

Commit migrated from https://github.com/dotnet/coreclr/commit/5c2fbeda7afd01613c193ac65ecbf7605b7a6462

6 years agoEnable genFnCalleeRegArgs for Arm64 Varargs (dotnet/coreclr#18714)
Jarret Shook [Thu, 5 Jul 2018 16:46:51 +0000 (09:46 -0700)]
Enable genFnCalleeRegArgs for Arm64 Varargs (dotnet/coreclr#18714)

* Enable genFnCalleeRegArgs for Arm64 Varargs

Before the method would early out and incorrectly expect the usage
of all incoming arguments to be their homed stack slots. It is
instead possible for incoming arguments to be homed to different
integer registers.

The change will mangle the float types for vararg cases in the same
way that is done during lvaInitUserArgs and fgMorphArgs.

* Apply format patch

* Account for softfp case

* Address feedback

* Apply format patch

* Use standard function header for mangleVarArgsType

* Remove confusing comment

Commit migrated from https://github.com/dotnet/coreclr/commit/b1bda1bbc9a5fe9954938b4b627660d3acbe7504

6 years agoDelete dead code (dotnet/coreclr#18783)
Jan Kotas [Thu, 5 Jul 2018 06:04:02 +0000 (08:04 +0200)]
Delete dead code (dotnet/coreclr#18783)

- Leftover from unobserved exception desktop quirk
- Unnecessary calls to AppDomain.IsFinalizingForUnload(). They were actually never required even with AppDomain support because of Environment.HasShutdownStarted returns true during AppDomain unload.

Commit migrated from https://github.com/dotnet/coreclr/commit/cd1232d47cc028ebf6d22621ce63903a7e5c0e94

6 years agoImprove DateTime{Offset}.ParseExact{Multiple} performance for RFC1123 ("r") (dotnet...
Stephen Toub [Thu, 5 Jul 2018 01:38:05 +0000 (21:38 -0400)]
Improve DateTime{Offset}.ParseExact{Multiple} performance for RFC1123 ("r") (dotnet/coreclr#18771)

* Improve DateTime{Offset}.ParseExact{Multiple} performance for RFC1123 ("r")

Significantly improves the performance by porting and adapting the Utf8Parser code from corefx.  This optimizes for the (default) case of a DateTimeStyles.None; specifying any other style falls back to the normal parsing support, as that requires handling things such as arbitrary whitespace anywhere in the string.

* Address PR feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/9f9a37d04460559c3f91927f1297c8195411a0a3

6 years agoRe-enable jit regression test DevDiv_590771 (dotnet/coreclr#18724)
Andy Ayers [Wed, 4 Jul 2018 20:33:36 +0000 (13:33 -0700)]
Re-enable jit regression test DevDiv_590771 (dotnet/coreclr#18724)

The issue the test was hitting was worked around in dotnet/coreclr#18292.

Fixes dotnet/coreclr#17967.

Also add GitHub_18522_8 to the arm/arm64 lists (from dotnet/coreclr#18708).

Commit migrated from https://github.com/dotnet/coreclr/commit/2946fdf5c8d66b8fb9ce7c44cef86ba7f81c65db

6 years agoAdd LastIndexOf compareoptions overload (dotnet/coreclr#18652)
Viktor Hofer [Wed, 4 Jul 2018 18:56:25 +0000 (20:56 +0200)]
Add LastIndexOf compareoptions overload (dotnet/coreclr#18652)

* Add LastIndexOf compareoptions overload

Commit migrated from https://github.com/dotnet/coreclr/commit/4e645b1a24a9a6eeb5c9944ebbe1dd07ef6228e0

6 years agoAdding tests for the byte overload of Ssse3.Shuffle
Tanner Gooding [Sun, 1 Jul 2018 15:06:46 +0000 (08:06 -0700)]
Adding tests for the byte overload of Ssse3.Shuffle

Commit migrated from https://github.com/dotnet/coreclr/commit/8aee85b0313d51cb5b5faaa320ee24d22e515912

6 years agoAdding support for the `byte` overload of `Ssse3.Shuffle`
Tanner Gooding [Sun, 1 Jul 2018 15:01:49 +0000 (08:01 -0700)]
Adding support for the `byte` overload of `Ssse3.Shuffle`

Commit migrated from https://github.com/dotnet/coreclr/commit/d78b519676b88b4e5ae54224f5efa6866d000624

6 years agoRemove mention of security transparency from message and comment (dotnet/coreclr...
Jan Kotas [Wed, 4 Jul 2018 09:19:38 +0000 (11:19 +0200)]
Remove mention of security transparency from message and comment (dotnet/coreclr#18776)

Commit migrated from https://github.com/dotnet/coreclr/commit/4da00cf6cbe7d013af525d4c526f00c2f8edc7fe

6 years agocompGSReorderStackLayout is not supported when EnC is on (dotnet/coreclr#18713)
Andrew Au [Wed, 4 Jul 2018 06:12:54 +0000 (23:12 -0700)]
compGSReorderStackLayout is not supported when EnC is on (dotnet/coreclr#18713)

Commit migrated from https://github.com/dotnet/coreclr/commit/2ce3f25984f5110b1821d895dc99119501e19f52

6 years agoUpdate CoreClr, CoreFx to preview1-26704-01, preview1-26704-01, respectively (dotnet...
dotnet-maestro-bot [Wed, 4 Jul 2018 03:36:31 +0000 (20:36 -0700)]
Update CoreClr, CoreFx to preview1-26704-01, preview1-26704-01, respectively (dotnet/coreclr#18773)

Commit migrated from https://github.com/dotnet/coreclr/commit/78cdaf104dc5e92640f82e26f4ccde009f71ee0e

6 years agoDelete InternalsVisibleTo attributes from S.P.CoreLib (dotnet/coreclr#18697)
Luqun Lou [Wed, 4 Jul 2018 01:30:33 +0000 (18:30 -0700)]
Delete InternalsVisibleTo attributes from S.P.CoreLib (dotnet/coreclr#18697)

Commit migrated from https://github.com/dotnet/coreclr/commit/c5dce0a3c0c5046aacde93c7ee2e35371d15ad6f

6 years agoMerge pull request dotnet/coreclr#18504 from mikedn/comp-small
Bruce Forstall [Tue, 3 Jul 2018 22:53:28 +0000 (15:53 -0700)]
Merge pull request dotnet/coreclr#18504 from mikedn/comp-small

Make Compiler and CodeGen objects smaller

Commit migrated from https://github.com/dotnet/coreclr/commit/7d048c01f8eb4b7591f71556dff5cb4ae9a79d9a

6 years agoadd missing files to package properly on FreeBSD (dotnet/coreclr#18764)
Tomas Weinfurt [Tue, 3 Jul 2018 21:00:40 +0000 (14:00 -0700)]
add missing files to package properly on FreeBSD (dotnet/coreclr#18764)

Commit migrated from https://github.com/dotnet/coreclr/commit/8d32f87b74b90f7da03574f3d44a370319886681

6 years agoMerge pull request dotnet/coreclr#18768 from CarolEidt/RemoveIsMultiReg
Carol Eidt [Tue, 3 Jul 2018 20:02:07 +0000 (13:02 -0700)]
Merge pull request dotnet/coreclr#18768 from CarolEidt/RemoveIsMultiReg

Remove Interval::isMultiReg

Commit migrated from https://github.com/dotnet/coreclr/commit/dc8ee8c84cf51a474fbfc164f7efe825a7a7aece

6 years agoMerge pull request dotnet/coreclr#18766 from CarolEidt/Fix18765
Carol Eidt [Tue, 3 Jul 2018 19:21:11 +0000 (12:21 -0700)]
Merge pull request dotnet/coreclr#18766 from CarolEidt/Fix18765

Build uses for atomic ops

Commit migrated from https://github.com/dotnet/coreclr/commit/49e69bc67c26c2431653646af61d8bccb342a356

6 years agoMerge pull request dotnet/coreclr#18716 from BruceForstall/RemoveTstJobsFromViews
Bruce Forstall [Tue, 3 Jul 2018 17:27:00 +0000 (10:27 -0700)]
Merge pull request dotnet/coreclr#18716 from BruceForstall/RemoveTstJobsFromViews

Remove build-only and TST jobs from the Jenkins views

Commit migrated from https://github.com/dotnet/coreclr/commit/13f2f8ce261db0771f6b602e90f0a408cdd33142

6 years agoUpdate CoreClr, PgoData to preview1-26703-04, master-20180703-0030, respectively...
dotnet-maestro-bot [Tue, 3 Jul 2018 17:20:00 +0000 (10:20 -0700)]
Update CoreClr, PgoData to preview1-26703-04, master-20180703-0030, respectively (dotnet/coreclr#18761)

Commit migrated from https://github.com/dotnet/coreclr/commit/4a4cbc56e5d402e1a43a106c28aed2ec4a745e7b

6 years agoRemove Interval::isMultiReg
Carol Eidt [Tue, 3 Jul 2018 16:46:04 +0000 (09:46 -0700)]
Remove Interval::isMultiReg

This is no longer used after dotnet/coreclr#16517

Commit migrated from https://github.com/dotnet/coreclr/commit/5d01d2d16f4a4c9592002d7c76c19f01f2529140

6 years agoBuild uses for atomic ops
Carol Eidt [Tue, 3 Jul 2018 14:42:12 +0000 (07:42 -0700)]
Build uses for atomic ops

Fix dotnet/coreclr#18765

Commit migrated from https://github.com/dotnet/coreclr/commit/f780ddabeb75b2416723bd96f38b361c682c3038

6 years agoUse generic win-x86/win-x64 RIDs in stress_dependencies
Egor Chesakov [Tue, 3 Jul 2018 02:37:15 +0000 (19:37 -0700)]
Use generic win-x86/win-x64 RIDs in stress_dependencies

Commit migrated from https://github.com/dotnet/coreclr/commit/87120600c574caf37b4304c2d0725bd90856ab37

6 years agoAdd back most CreateInstance APIs to AppDomain and Activator (dotnet/coreclr#18751)
Marco Rossignoli [Tue, 3 Jul 2018 04:38:33 +0000 (06:38 +0200)]
Add back most CreateInstance APIs to AppDomain and Activator (dotnet/coreclr#18751)

* add ObjectHandle.cs

* add signature placeholder

* move CreateInstance from netfx

* move CreateInstanceFrom from netfx

* nit: visibility, text formatting

Commit migrated from https://github.com/dotnet/coreclr/commit/c7c50c5cd54b91c1f982fda8e5c8b21aead3f352

6 years agoUpdate CoreFX CI packages to NetcoreApp3 (dotnet/coreclr#18760)
Andon Andonov [Tue, 3 Jul 2018 03:20:38 +0000 (20:20 -0700)]
Update CoreFX CI packages to NetcoreApp3 (dotnet/coreclr#18760)

* Update to FX CI packages to NetcoreApp3

* Add Extra Dependencies

* Enable all tests fixed by change

Commit migrated from https://github.com/dotnet/coreclr/commit/f32c75e697e77340d581d577789cc530993abbc4

6 years agoUpdating SSE_StaticCast and AVX_StaticCast to set the correct type on the returned...
Tanner Gooding [Sat, 30 Jun 2018 05:21:22 +0000 (22:21 -0700)]
Updating SSE_StaticCast and AVX_StaticCast to set the correct type on the returned node.

Commit migrated from https://github.com/dotnet/coreclr/commit/e3292deddb16defb8d431ec456cf351dd95102c1

6 years agoFold away Sse.StaticCast and Avx.StaticCast in the importer
Tanner Gooding [Sun, 17 Jun 2018 15:58:20 +0000 (08:58 -0700)]
Fold away Sse.StaticCast and Avx.StaticCast in the importer

Commit migrated from https://github.com/dotnet/coreclr/commit/94edffc61a1cd7bf61fad5a4910d7cfb786b6f24

6 years agoAdding an Avx.StaticCast test (modified from the Sse.StaticCast test)
Tanner Gooding [Sun, 17 Jun 2018 15:57:51 +0000 (08:57 -0700)]
Adding an Avx.StaticCast test (modified from the Sse.StaticCast test)

Commit migrated from https://github.com/dotnet/coreclr/commit/bb027de97b1a17b24a599623779aacd7dd7054f3

6 years agoSuperPMI: add ability to exclude failing method contexts from replays (dotnet/coreclr...
Sergey Andreenko [Tue, 3 Jul 2018 00:32:59 +0000 (17:32 -0700)]
SuperPMI: add ability to exclude failing method contexts from replays (dotnet/coreclr#18721)

* format spmi

* rename mchFile to mchFileName

* refactor ProcessChildStdOut

* add a stub to exclude methods

Commit migrated from https://github.com/dotnet/coreclr/commit/15a6beb33de6f243d59f6b61ec90cfcb336f45af

6 years agoSet the activation context for the CoreRun application to what is defined (dotnet...
Aaron Robinson [Mon, 2 Jul 2018 23:21:59 +0000 (16:21 -0700)]
Set the activation context for the CoreRun application to what is defined (dotnet/coreclr#18728)

in the target managed assembly. This allows RegFree COM scenarios and ensures
the intended app manifest is used for the 'exe' scenario.

Commit migrated from https://github.com/dotnet/coreclr/commit/7222c56c42be22ecb0b61ce2d49e3e916ecdadb6

6 years agoDebug registers cannot be copied in user mode (dotnet/coreclr#18730)
Andrew Au [Mon, 2 Jul 2018 22:39:03 +0000 (15:39 -0700)]
Debug registers cannot be copied in user mode (dotnet/coreclr#18730)

Commit migrated from https://github.com/dotnet/coreclr/commit/5f306d6823b85ea65e1e955a490853f68dcca2a3

6 years agoDispatch Runtime Events to EventListener (dotnet/coreclr#18649)
Brian Robbins [Mon, 2 Jul 2018 22:08:32 +0000 (15:08 -0700)]
Dispatch Runtime Events to EventListener (dotnet/coreclr#18649)

Commit migrated from https://github.com/dotnet/coreclr/commit/b3b9d08529baaa7afdc38b3ede5dde1e456360b2

6 years agoUpdate BuildTools, CoreClr, PgoData to preview1-03002-01, preview1-26702-04, master...
dotnet-maestro-bot [Mon, 2 Jul 2018 21:02:48 +0000 (14:02 -0700)]
Update BuildTools, CoreClr, PgoData to preview1-03002-01, preview1-26702-04, master-20180702-0047, respectively (dotnet/coreclr#18731)

Commit migrated from https://github.com/dotnet/coreclr/commit/834799c12ec0d459638d694b08bf536adee070b5

6 years agoMove RuntimeIDArg initialization (dotnet/coreclr#18747)
Andon Andonov [Mon, 2 Jul 2018 20:54:58 +0000 (13:54 -0700)]
Move RuntimeIDArg initialization (dotnet/coreclr#18747)

Commit migrated from https://github.com/dotnet/coreclr/commit/a2d490dc5e23c69fae7bc3157b6e443587403548

6 years agoFixing up the Sse41.Insert float HWIntrinsics
Tanner Gooding [Sat, 30 Jun 2018 21:58:14 +0000 (14:58 -0700)]
Fixing up the Sse41.Insert float HWIntrinsics

Commit migrated from https://github.com/dotnet/coreclr/commit/a7167ddd15ded348137712705b4fab5852ca57db

6 years agoreenable fixed arm64 altjit tests (dotnet/coreclr#18722)
Sergey Andreenko [Mon, 2 Jul 2018 17:21:36 +0000 (10:21 -0700)]
reenable fixed arm64 altjit tests (dotnet/coreclr#18722)

Commit migrated from https://github.com/dotnet/coreclr/commit/e65d730368c3df9d099781153630f5c2c890bbb7

6 years agoAdd back DefinePInvokeMethod (dotnet/coreclr#18742)
Atsushi Kanamori [Mon, 2 Jul 2018 17:11:33 +0000 (10:11 -0700)]
Add back DefinePInvokeMethod (dotnet/coreclr#18742)

Commit migrated from https://github.com/dotnet/coreclr/commit/ad834bb427539c489ff354fa8f1ba5eb5981da41

6 years agoAdding back the tests for Avx.MaskLoad
Tanner Gooding [Sat, 30 Jun 2018 19:12:32 +0000 (12:12 -0700)]
Adding back the tests for Avx.MaskLoad

Commit migrated from https://github.com/dotnet/coreclr/commit/e524fbe359fe181259545611b883ee888d140b8f

6 years agoUpdating the Avx.Extract/Insert methods to throw PNSE when IsSupported is false
Tanner Gooding [Sat, 30 Jun 2018 19:10:40 +0000 (12:10 -0700)]
Updating the Avx.Extract/Insert methods to throw PNSE when IsSupported is false

a

Commit migrated from https://github.com/dotnet/coreclr/commit/50b2ac829a6d16cca84858ddae25de71b8d04708

6 years agoRemoving unnecessary `try/catch` blocks from the ExtractScalar and InsertScalar HWInt...
Tanner Gooding [Sat, 30 Jun 2018 18:28:47 +0000 (11:28 -0700)]
Removing unnecessary `try/catch` blocks from the ExtractScalar and InsertScalar HWIntrinsic test templates

Commit migrated from https://github.com/dotnet/coreclr/commit/1613245a1e5d844825ed67dc73698ffe2e3129fa

6 years agoTabs vs. spaces (dotnet/coreclr#18740)
dotnet-maestro-bot [Mon, 2 Jul 2018 09:32:47 +0000 (02:32 -0700)]
Tabs vs. spaces (dotnet/coreclr#18740)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/1310065f3726f5fe119b7a2f660a77f01104a1ef

6 years agoFix some build breaks seen with the older VS we use to build with on desktop. (dotnet...
Andy Ayers [Sun, 1 Jul 2018 22:43:16 +0000 (15:43 -0700)]
Fix some build breaks seen with the older VS we use to build with on desktop. (dotnet/coreclr#18736)

Commit migrated from https://github.com/dotnet/coreclr/commit/c80466d4caf2c2f411a2311fd3f45594812d1e0f

6 years agoFix recursive inlining of PInvoke stubs (dotnet/coreclr#18737)
Jan Kotas [Sun, 1 Jul 2018 13:02:04 +0000 (06:02 -0700)]
Fix recursive inlining of PInvoke stubs (dotnet/coreclr#18737)

PInvoke stubs can be inlined into a regular methods in CoreRT. PInvoke transition
has to be inlined as well when that happens. Otherwise, there is a risk of recursive
inlining in corner cases.

Commit migrated from https://github.com/dotnet/coreclr/commit/55023b7c1007c528b0147fe839cea5ac4a100e2f

6 years agoReplace compGetMemArray uses
Mike Danes [Sat, 30 Jun 2018 19:45:01 +0000 (22:45 +0300)]
Replace compGetMemArray uses

Commit migrated from https://github.com/dotnet/coreclr/commit/10729e1a8a65bf3669049bca234187cbaf1a2e70

6 years agoFix incorrect lvaTrackedToVarNum memset size
Mike Danes [Thu, 21 Jun 2018 18:36:47 +0000 (21:36 +0300)]
Fix incorrect lvaTrackedToVarNum memset size

Commit migrated from https://github.com/dotnet/coreclr/commit/40fdb3e34d4b304f6a4184fd18159deff303878a

6 years agoHandle the missing cache case in gtGetStructHandleForSIMD
Mike Danes [Mon, 18 Jun 2018 18:19:08 +0000 (21:19 +0300)]
Handle the missing cache case in gtGetStructHandleForSIMD

Commit migrated from https://github.com/dotnet/coreclr/commit/45c04164112cccfdde71dcd79dd769013547dcaa

6 years agoAllocate space for siLatestTrackedScopes on demand
Mike Danes [Sat, 16 Jun 2018 15:56:36 +0000 (18:56 +0300)]
Allocate space for siLatestTrackedScopes on demand

By the time siLatestTrackedScopes is needed the number of tracked variables is known so we can allocate an array of suitable size. Defaulting to lclMAX_TRACKED requires 4 kbytes and for many small methods that's a waste.

Commit migrated from https://github.com/dotnet/coreclr/commit/2e0cc331a72b2473317f9652646bcc6796ece449

6 years agoRemove Compiler::impSmallStack
Mike Danes [Sat, 16 Jun 2018 20:07:49 +0000 (23:07 +0300)]
Remove Compiler::impSmallStack

Memory allocation via ArenaAllocator is cheap so it's not worth having this inline array that ends up wasting 384 bytes when a larger stack is needed.

Care needs to be taken when inlining to avoid allocating a new stack every time - just steal the stack of the inliner compiler (after ensuring that it is large enough).

Commit migrated from https://github.com/dotnet/coreclr/commit/f26852e51fc4954a07296cb7b9d0206dca10f8a2

6 years agoCleanup hashBvGlobalData
Mike Danes [Sat, 16 Jun 2018 19:21:40 +0000 (22:21 +0300)]
Cleanup hashBvGlobalData

Each compiler object contains a hashBvGlobalData that's 80 bytes in size. Only 16 bytes are actually used - the hash and node free lists.
* hbvFreeVectorList is supposed to be used by hashBv::freeVector but nothing calls that and getNewVector does not attempt to use the free list
* hbvHashSizeLog2 is always 0
* hashBvNextIterator is used only in HbvNext and that function is never used

Commit migrated from https://github.com/dotnet/coreclr/commit/235bc725acdf8a66b19f1c51cfe83f573562f80d