David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Fix creating NTFS on raw devices"
This reverts commit
e180c5738e8d997090f29f67308f4ecb4fab1656.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "testsuite: Move to scsi_debug"
This reverts commit
337c180cd69e1ff3eb8fc2c1b77abdba5feb3967.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Also export UDISKS_DM_TARGET_PARAMS for 'multipath' target"
This reverts commit
e014838956eb2d926ce2db28b48d202e4fae9db7.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Add nilfs2 label rename"
This reverts commit
7a4a5e7f3ecb568a1670ec056d297e636e2a567f.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "udisks: fix a bug of unquoted/unescaped label string"
This reverts commit
0b4189b6d34d9ad1318381410e0d27edd10b7c62.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "partutil: Explicitly use PART_TYPE_UNKNOWN"
This reverts commit
5d07c97811138fa1542dd09f3178dad812b81a23.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Fix uninitialized variable in part-id"
This reverts commit
dd48c454f14b6063f8584631f04bf4528969a82b.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "testsuite: Check forced removal of LUKS encrypted device"
This reverts commit
5cf279606c8163b8cf65906b2028db711fba8f0b.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "testsuite: Test forced removal of standard devices"
This reverts commit
1decd59b128f44fffe88feae0644430419a69b23.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "udisks: Avoid deprecated polkit_authority_get() function"
This reverts commit
813578196f08c599c7e87c45aff808db0148303d.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Fix building with Linux 2.6.37"
This reverts commit
1f97cf90f30a6184486cee8877494eb828a34da4.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "testsuite: Check correct handling of labels with funny characters"
This reverts commit
8781f898aec9b098807cb6ce5c7d4115b3c2fdba.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "udisks: escape backslash for label string"
This reverts commit
3d420825ce14c3b867571c22413fd9bc48738a6e.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "testsuite: use shorter label for renaming"
This reverts commit
8fd70cff1aa2111212cc9d874a076fb9739dadf1.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Escape NTFS labels properly"
This reverts commit
774e8353e7753d118b449310c03d9f811cef7c3a.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "simplify validate_and_escape_label()"
This reverts commit
1c81be33e87e7dffde0c4c4b4ec278011710dbd9.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Fix hang on setting invalid VFAT labels"
This reverts commit
8048a1cb8ae2de37c9fe9b07cc28ebafa0de7231.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "update NEWS for 1.0.2 release"
This reverts commit
abc0e3d491435eded57a5b25cfef8cd40f9f6c1e.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Post-release version bump to 1.0.3"
This reverts commit
46da5bcaeecfb0d088a57061a293b43e0d13e45a.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Hide recovery partition on newer Lenovo machines"
This reverts commit
77fcb26a5088611f463314b7ff45c1822536cdac.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "testsuite: fix race in LVM"
This reverts commit
e40cc25ae1c0bd57f9e70de860349a44751f3aae.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "testsuite: Port to Python 3"
This reverts commit
0c452859956262155c8940433e00658ec5b1fbca.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "testsuite: Update assert statements"
This reverts commit
31c7236f751e80b285da04ba4379bb98f809cb44.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Ignore broken directory permissions on UDF media"
This reverts commit
2d1901f74725da29c7af7602e1c74faf55f14672.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Bug 32917 — EeePC 900 SD card reader icon looks like a usb stick in GNOME"
This reverts commit
d0cafeb4e9e64fcb660d11a197d8405f28bb5a95.
David Zeuthen [Fri, 26 Aug 2011 17:09:41 +0000 (13:09 -0400)]
Revert "Bug 32232 – CVE-2010-4661: Arbitrary kernel module load"
This reverts commit
c933a929f07421ec747cebb24d5e620fc2b97037.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Fix warning message"
This reverts commit
cf76dc036a7db0804bd22f731dadddf9e128f03a.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Fix all warnings caused by -Wunused-but-set-variable"
This reverts commit
75aa5d3b67ace13eba3d2e39f0806742e1fd7bb5.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Update comment about validating requested filesystem type"
This reverts commit
81cb4740de3ac2a790f1c093eba5f064ced0a2a5.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Nuke generated D-Bus code from distribution tarballs"
This reverts commit
89bdcc7686c4ef5aeba6ef4bce1be2b5b5c79bce.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Nuke the PolicyKit extension as that is now deprecated"
This reverts commit
fb08e3ab42152222795d271e76e57b1b9297a702.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Fix udisks --eject-options"
This reverts commit
4b4746ee28804cb50229c6c42457c4f80c60faca.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "throw_error(): Print error to stderr when being called internally"
This reverts commit
af80cd56e3b68cbc0de1fa1d03f9b2b2463aa514.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Support calling device_drive_eject() and device_filesystem_unmount() from daemon"
This reverts commit
378a755bbe24e1118caa6a278bcbc585213e7a05.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Remove blkid probing of device-mapper nodes"
This reverts commit
8f01c260f42f4478160b9baf45d8298b2f02421e.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Mark Realtek PCI flash card reader as such"
This reverts commit
361a2ce3f2fc0b6ef02ac11d31bf77a0a9354e70.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Add override for system internal property"
This reverts commit
156ebd5ca8f88b7a4772c03ed269ae30718f866d.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Add missing comma in fs whitelist"
This reverts commit
75b6187f77ca95ce435dd78f2ecb244af55e7faf.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Add "unmount" option to DriveEject"
This reverts commit
1c7d933431e49ff6840a388eb23134633155a442.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Bug 34710 — CD-ROM polling failed due to O_EXCL flag"
This reverts commit
2d0272eb3be71f6ee3f52c55a3d608764b675fb0.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Bug 38535 – A DeviceAutoMountHint attribute should be added to udisks"
This reverts commit
858adbac9dce63da52764b2d2157bc7782b304a5.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Add UDISKS_AUTOMOUNT_HINT to the udisks(7) man page"
This reverts commit
ce27a0f7e45cd66b18fcbfe1c8f38ef9e8d4e903.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Teach udisks(1) about the new automount hint and spell automount as one word"
This reverts commit
43392bd4b7c72892b08e49a6c0afaef9f572695a.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Update NEWS for release"
This reverts commit
c1e14e10f700c5a36d136004f3f3a04791cb8d9e.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Post-release version bump to 1.0.4"
This reverts commit
32c2f555e5a1ae4303bf1f7e7c229c891327ac77.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Fix typo in configure"
This reverts commit
91405103e0267c73c76f44be5e1de7169884d8c6.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Mark all rts_pstor devices as card readers"
This reverts commit
cd0644df1279a9a04c5ff15220381a64de0224fa.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Change the default for LVM2 and dm-multipath support to off"
This reverts commit
99de237eed6a026597e9b045527631c42ab86968.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Bug 24265 – Needs to create /var/run/udisks/ on demand"
This reverts commit
bd0e9b6f62957f7bc99d01edaedb45a2e8ed8ac8.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Update NEWS for release"
This reverts commit
36329d9548aa9d4016f919f4a19ed7c0d1fbeb11.
David Zeuthen [Fri, 26 Aug 2011 17:09:40 +0000 (13:09 -0400)]
Revert "Post-release version bump to 1.0.5"
This reverts commit
3cc1015e12c83165d838ca9e5d3ecb22ffb09b74.
David Zeuthen [Fri, 26 Aug 2011 15:49:14 +0000 (11:49 -0400)]
Post-release version bump to 1.0.5
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 26 Aug 2011 15:44:14 +0000 (11:44 -0400)]
Update NEWS for release
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 26 Aug 2011 15:32:42 +0000 (11:32 -0400)]
Bug 24265 – Needs to create /var/run/udisks/ on demand
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 26 Aug 2011 15:09:24 +0000 (11:09 -0400)]
Change the default for LVM2 and dm-multipath support to off
The udev integration in device-mapper (and its users) is not exactly
working well - for example, you need to run 'udevadm trigger' in order
for the /lib/udev/udisks-lvm-pv-export prober to kick
in. Additionally, the fact that we run said prober on new events is
causing a lot of problems because its use of liblvm and the fact that
liblvm cannot currently be safely used in the udev path.
Signed-off-by: David Zeuthen <davidz@redhat.com>
Signed-off-by: Kay Sievers <kay@redhat.com>
Ayan George [Thu, 21 Jul 2011 07:03:22 +0000 (09:03 +0200)]
Mark all rts_pstor devices as card readers
Generalize commit
361a2ce3 to apply to all card readers covered by the
rts_pstor driver.
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
Nicolas Lécureuil [Sat, 2 Jul 2011 22:30:26 +0000 (00:30 +0200)]
Fix typo in configure
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
David Zeuthen [Wed, 29 Jun 2011 14:17:30 +0000 (10:17 -0400)]
Post-release version bump to 1.0.4
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 29 Jun 2011 14:10:50 +0000 (10:10 -0400)]
Update NEWS for release
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 29 Jun 2011 14:09:19 +0000 (10:09 -0400)]
Teach udisks(1) about the new automount hint and spell automount as one word
It's automount, not "auto mount".
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 23 Jun 2011 17:27:59 +0000 (13:27 -0400)]
Add UDISKS_AUTOMOUNT_HINT to the udisks(7) man page
Signed-off-by: David Zeuthen <davidz@redhat.com>
Ayan George [Thu, 23 Jun 2011 17:27:06 +0000 (13:27 -0400)]
Bug 38535 – A DeviceAutoMountHint attribute should be added to udisks
With minor changes by David Zeuthen, see the bug for details.
https://bugs.freedesktop.org/show_bug.cgi?id=38535
Signed-off-by: David Zeuthen <davidz@redhat.com>
Martin Pitt [Sun, 19 Jun 2011 18:48:22 +0000 (20:48 +0200)]
Bug 34710 — CD-ROM polling failed due to O_EXCL flag
Newer kernels (2.6.38+) support in-kernel polling of CD-ROM/SD card devices.
udev 172 and later enable this feature by default:
http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=
c5a41da949
That will also handle the eject button properly and send out remove uevents,
which causes stale mounts to be cleaned up properly.
In-kernel polling avoids the userspace race conditions with accessing the
drive.
If kernel polling is not supported or enabled, fall back to the previous method
of unlocking the CD drive door right after mounting, to keep the hardware
button working.
Martin Pitt [Sun, 3 Apr 2011 22:07:03 +0000 (00:07 +0200)]
Add "unmount" option to DriveEject
DriveEject currently fails if there are mounted file systems on the drive. Add
an option "unmount" which will unmount any mounted file system on the drive to
be ejected first. The "eject" command conveniently already does this, so the
only thing we need to do here is to skip the "is mounted" check in
device_local_is_busy().
David Zeuthen [Mon, 9 May 2011 16:03:13 +0000 (12:03 -0400)]
Add missing comma in fs whitelist
https://bugs.freedesktop.org/show_bug.cgi?id=36361
Signed-off-by: David Zeuthen <davidz@redhat.com>
Martin Pitt [Wed, 4 May 2011 08:38:01 +0000 (10:38 +0200)]
Add override for system internal property
Check UDISKS_SYSTEM_INTERNAL udev property to override the usual bus type based
"is drive system internal?" detection.
Based on patch by Patrick Stewart <patstew@gmail.com>, thank you!
Ayan George [Tue, 3 May 2011 06:47:34 +0000 (08:47 +0200)]
Mark Realtek PCI flash card reader as such
https://launchpad.net/bugs/759963
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
Martin Pitt [Tue, 5 Apr 2011 20:16:00 +0000 (22:16 +0200)]
Remove blkid probing of device-mapper nodes
This was introduced years ago when udev rules were still something new, but
these workarounds really should not be in udev any longer.
lvm2 has shipped udev/13-dm-disk.rules with that blkid command for at least a
year (probably longer).
Martin Pitt [Sun, 3 Apr 2011 21:02:46 +0000 (23:02 +0200)]
Support calling device_drive_eject() and device_filesystem_unmount() from daemon
In device_drive_eject() and device_filesystem_unmount(), only specify a
PolicyKit action if we actually have a D-BUS invocation context. If not, the
method is called from within the daemon, so use a NULL PK action to avoid a
crash. This is similar to device_drive_ata_smart_refresh_data().
Use the throw_error() wrapper instead of direct dbus_g_method_return_error(),
to support NULL contexts.
Martin Pitt [Sun, 3 Apr 2011 20:55:26 +0000 (22:55 +0200)]
throw_error(): Print error to stderr when being called internally
throw_error() immediately returns for Device methods which are called
internally from the daemon (i. e. without an actual PolicyKit check), as we do
not have a D-BUS invocation context. Print out the error message in this case
as well.
Martin Pitt [Sun, 3 Apr 2011 22:04:36 +0000 (00:04 +0200)]
Fix udisks --eject-options
Pass the split option array to the D-BUS call, not the original unsplit string.
David Zeuthen [Tue, 15 Mar 2011 16:24:18 +0000 (12:24 -0400)]
Nuke the PolicyKit extension as that is now deprecated
Ideally we'd use the replacement interface but it's not a very big
deal to not have this. We'll revisit this in udisks version 2
(e.g. the work going on in the udisks-gdbus branch).
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Mar 2011 14:34:24 +0000 (10:34 -0400)]
Nuke generated D-Bus code from distribution tarballs
This avoids a nasty bug when using an older version of the dbus-glib
library than the version that was used to generate the code. Credit
goes to Tomáš Trnka <tomastrnka@gmx.com> for figuring this out in RH
bug #673544 comment 15. See
https://bugzilla.redhat.com/show_bug.cgi?id=673544
for more details
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Mar 2011 13:39:26 +0000 (09:39 -0400)]
Update comment about validating requested filesystem type
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Mar 2011 13:32:47 +0000 (09:32 -0400)]
Fix all warnings caused by -Wunused-but-set-variable
This is new with gcc 4.6.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Mar 2011 13:26:51 +0000 (09:26 -0400)]
Fix warning message
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Mar 2011 13:20:44 +0000 (09:20 -0400)]
Bug 32232 – CVE-2010-4661: Arbitrary kernel module load
Validate what is passed to the mount(8) command. In particular, only
allow either well-known filesystems, filesystems already loaded or
filesystem explicitly allowed by the administrator via the
/etc/filesystems file.
See https://bugs.freedesktop.org/show_bug.cgi?id=32232 for details.
Signed-off-by: David Zeuthen <davidz@redhat.com>
Sitsofe Wheeler [Thu, 10 Mar 2011 22:55:57 +0000 (23:55 +0100)]
Bug 32917 — EeePC 900 SD card reader icon looks like a usb stick in GNOME
Add missing rule for identifying SD card readers as such.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32917
Bug-Ubuntu: https://launchpad.net/bugs/460713
Martin Pitt [Thu, 24 Feb 2011 12:39:52 +0000 (13:39 +0100)]
Ignore broken directory permissions on UDF media
Some broken DVDs come with 0400 directory permissions, making them unreadable;
according to the UDF spec (http://www.osta.org/specs/pdf/udf260.pdf) directory
permissions are to be respected, but apparently Windows ignores those.
To work around this, override readonly UDF media with a dmode=0500, as on those
it doesn't really make sense to hide anything.
https://launchpad.net/bugs/635499
Martin Pitt [Thu, 24 Feb 2011 11:19:47 +0000 (12:19 +0100)]
testsuite: Update assert statements
assert_() and failIf() are deprecated in favor of assertTrue() and
assertFalse().
Martin Pitt [Thu, 24 Feb 2011 11:18:12 +0000 (12:18 +0100)]
testsuite: Port to Python 3
This now works with both Python 2 and 3.
Martin Pitt [Thu, 24 Feb 2011 10:09:45 +0000 (11:09 +0100)]
testsuite: fix race in LVM
Do an udev sync before getting the old list of devices, as there might still be
lingering updates from other tests; these appear as new devices in the delta
list and break the test.
Bastien Nocera [Sat, 16 Oct 2010 22:52:36 +0000 (23:52 +0100)]
Hide recovery partition on newer Lenovo machines
Hide the "SYSTEM RESERVED" recovery partition on newer Lenovo
machines.
https://bugs.freedesktop.org/show_bug.cgi?id=30930
Signed-off-by: David Zeuthen <davidz@redhat.com>
Martin Pitt [Thu, 2 Dec 2010 09:09:51 +0000 (10:09 +0100)]
Post-release version bump to 1.0.3
Martin Pitt [Thu, 2 Dec 2010 08:41:29 +0000 (09:41 +0100)]
update NEWS for 1.0.2 release
Martin Pitt [Sat, 6 Nov 2010 17:40:07 +0000 (13:40 -0400)]
Fix hang on setting invalid VFAT labels
VFAT does not support several characters in file names and labels, in
particular: " * / : < > ? \ |
(http://en.wikipedia.org/wiki/File_Allocation_Table)
When using one of those, mlabel interactively asks what to do, and thus causes
a hang. Now check for invalid characters and return a proper error instead.
Also update the test case to verify that we get an Error on invalid labels, and
that valid labels still work.
Martin Pitt [Sat, 6 Nov 2010 17:28:39 +0000 (13:28 -0400)]
simplify validate_and_escape_label()
Cleanup from 3d42082
Martin Pitt [Sat, 6 Nov 2010 17:13:35 +0000 (13:13 -0400)]
Escape NTFS labels properly
Caught by recent test suite update.
Martin Pitt [Sat, 6 Nov 2010 17:09:04 +0000 (13:09 -0400)]
testsuite: use shorter label for renaming
The previous one was too long for some file systems like XFS. This produced a
correct DBusException, but it's not what we primarily want to test for.
Jiro SEKIBA [Fri, 15 Oct 2010 04:48:07 +0000 (13:48 +0900)]
udisks: escape backslash for label string
validate_and_escape_label will only escapes '"'.
However, string '\"' will be escaped to '\\"' which leads unmatched
double quote for shell string in result.
This adds escaping '\' in validate_and_escape_label to avoid the problem.
Signed-off-by: Jiro SEKIBA <jir@unicus.jp>
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
Martin Pitt [Sat, 6 Nov 2010 17:00:27 +0000 (13:00 -0400)]
testsuite: Check correct handling of labels with funny characters
Try to change to a label containing backslashes and quotes. This will make
things fall over quite badly in a lot of cases right now.
Martin Pitt [Sat, 6 Nov 2010 16:42:09 +0000 (12:42 -0400)]
Fix building with Linux 2.6.37
<linux/fs.h> uses uint64_t without including it itself. Arguably a kernel bug,
but it costs us nothing to defend against it.
Marti Raudsepp [Wed, 20 Oct 2010 16:39:02 +0000 (19:39 +0300)]
udisks: Avoid deprecated polkit_authority_get() function
Use polkit_authority_get_sync() instead.
This was introduced in polkit-1 commit
322513b0d, thus bump the configure.ac
check to 0.97.
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
Martin Pitt [Sun, 24 Oct 2010 13:48:51 +0000 (09:48 -0400)]
testsuite: Test forced removal of standard devices
Corresponding to the previous test for forced removal of LUKS encrypted
devices, also test handling of forced removal for plain unencrypted devices.
Martin Pitt [Sun, 24 Oct 2010 13:31:51 +0000 (15:31 +0200)]
testsuite: Check forced removal of LUKS encrypted device
Add two new methods remove_device() and readd_devices() which simulate device
removal and readdition.
Add new test case for force-removal handling of a mounted LUKS device: verify
that it cleans up properly and device can be remounted again afterwards.
This reproduces the cleanup failure in bug 30332 and verifies that the fix for
tihs (
16529b69f) works.
Martin Pitt [Thu, 21 Oct 2010 07:35:29 +0000 (09:35 +0200)]
Fix uninitialized variable in part-id
With gcc 4.5:
part-id.c: In function ‘main’:
part-id.c:186:9: error: ‘partition_number’ may be used uninitialized in this function
This only affected the error path, where we would return an arbitrary value in
get_part_table_device_file()'s out_partition_number (but return a failure
result). No big deal, but let's initialize it for quiescing gcc.
Martin Pitt [Thu, 21 Oct 2010 07:33:00 +0000 (09:33 +0200)]
partutil: Explicitly use PART_TYPE_UNKNOWN
Previously we were comparing PartitionScheme values against the undefined enum
value -1, which causes a warning with gcc 4.5. Define -1 explicitly as
"PART_TYPE_UNKNOWN" and only use that in the code, which is cleaner.
Thanks to Marti Raudsepp for pointing this out!
Jiro SEKIBA [Fri, 15 Oct 2010 04:44:22 +0000 (13:44 +0900)]
udisks: fix a bug of unquoted/unescaped label string
This patch quotes/escapes label string for nilfs-tune.
Signed-off-by: Jiro SEKIBA <jir@unicus.jp>
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
Jiro SEKIBA [Thu, 14 Oct 2010 05:56:19 +0000 (14:56 +0900)]
Add nilfs2 label rename
Support renaming label of nilfs2 partition. Renaming is done by nilfs2-tune,
which is in nilfs2-util > 2.0.20.
This patch enables the label test excluded for lacking utility.
Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com>
David Zeuthen [Fri, 1 Oct 2010 16:02:24 +0000 (12:02 -0400)]
Also export UDISKS_DM_TARGET_PARAMS for 'multipath' target
This is safe - no key material or similar is ever exported
cf. CVE-2010-1149. Additionally, this unbreaks multipath support, see
http://people.freedesktop.org/~david/multipath-restored.png
Signed-off-by: David Zeuthen <davidz@redhat.com>