platform/core/csapi/xsf.git
5 years agoShell hamburger (#5961)
Shane Neuville [Thu, 25 Apr 2019 00:36:19 +0000 (18:36 -0600)]
Shell hamburger (#5961)

* Draw the hamburger if the user hasn't supplied an icon

* move variable

* remove excess code

* remove public

5 years agofix infinite loops and remove public apis (#5954)
Shane Neuville [Wed, 24 Apr 2019 22:25:12 +0000 (16:25 -0600)]
fix infinite loops and remove public apis (#5954)

* fix infinite loops and remove public apis

* - remove comments, fix location to not have implicit

* force uri to be relative on ios when no scheme specified

* address PR comments

* add error message

* reformat absolute uris

* additional suggestions

* Update Xamarin.Forms.Core/Shell/ShellNavigationState.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
5 years agoAllow CollectionView items to resize with their content (#5905)
E.Z. Hart [Wed, 24 Apr 2019 18:30:02 +0000 (12:30 -0600)]
Allow CollectionView items to resize with their content (#5905)

* Add gallery for reproing expanding DataTemplate content;
Allow ItemContentView on Android to expand with content;
Allow ItemContentView on iOS to expand with content;
Fixes #5647

* Improve instructions
Fixes #5721
Fixes #5521

* Apply suggestions from code review

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Clear binding contexts before recycling cells/viewholders.

5 years ago[Shell, iOS, Android] added tab order on Shell flyout menu items (#5930)
Pavel Yakovlev [Wed, 24 Apr 2019 02:33:09 +0000 (05:33 +0300)]
[Shell, iOS, Android] added tab order on Shell flyout menu items (#5930)

* [Shell, Android] added tab order on Shell flyout menu items

* [iOS mac] fix build

* support iOS

5 years agoAvoid LINQ exception (#5933)
Morten Nielsen [Tue, 23 Apr 2019 17:18:19 +0000 (10:18 -0700)]
Avoid LINQ exception (#5933)

* Avoid LINQ exception

If the back button in UWP is pressed, but there's nothing in the backstack, the `Last()` LINQ query will throw `System.InvalidOperationException: 'Sequence contains no elements`
This change avoids that, and just returns false that Forms didn't handle the event.

* Change to use LastOrDefault

5 years agoadd delay to 2951 (#5972)
Shane Neuville [Tue, 23 Apr 2019 17:13:20 +0000 (11:13 -0600)]
add delay to 2951 (#5972)

5 years ago[Android] move runtime registration of renderers to its own method (#5946)
Shane Neuville [Thu, 18 Apr 2019 15:25:58 +0000 (09:25 -0600)]
[Android] move runtime registration of renderers to its own method (#5946)

* move renderer registration to its own method

* - move to static

5 years ago[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934)...
Shane Neuville [Thu, 18 Apr 2019 15:25:31 +0000 (09:25 -0600)]
[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501

* propagate bindingcontext

* - add exception message and fix poorly named xaml file

* add ui test automation

* - fix unit test to represent new code

* - changed from ui test to unit test

* - propagate visual, parent, bc to titleview

* - style fixes

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Thu, 18 Apr 2019 15:15:48 +0000 (16:15 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fixes to yaml public build (#5948)
Rui Marinho [Thu, 18 Apr 2019 15:14:47 +0000 (16:14 +0100)]
[Build] Fixes to yaml public build (#5948)

* [Build] Don't sign on public builds

* [Build] Use vmImages

* [Build] Fix pool specification

* [Build] Revert back to pool name

* [Build] add osx demands

* [Build] Fix indentation

* [Build] Add more demands

* [Build] Try using certs

* [Build] Try use name

* cert password

* [Build] Add endpoint back

* [Build] Add VSTS feed as variable

* [Build] Add signing stuff

* Fix

* [Build] Try simplify Windows build

* [Build] Publish android apps

* [Build] Add signVmImage

5 years agoMove IElementConfiguration to an internal structure on Cell (#5850)
Shane Neuville [Wed, 17 Apr 2019 17:59:16 +0000 (11:59 -0600)]
Move IElementConfiguration to an internal structure on Cell (#5850)

* Move IElementConfiguration to an internal structure on Cell

* set custom ElementConfiguration to private

* fix comments

5 years agoRemove need for PressEnter on test 5535 because it crashes iOS 12 tests
E.Z. Hart [Wed, 17 Apr 2019 16:13:10 +0000 (10:13 -0600)]
Remove need for PressEnter on test 5535 because it crashes iOS 12 tests

5 years agos/SearchBoxVisiblity/SearchBoxVisibility/ from base 4.0.0 (#5931)
Larry O'Brien [Tue, 16 Apr 2019 22:04:55 +0000 (12:04 -1000)]
s/SearchBoxVisiblity/SearchBoxVisibility/ from base 4.0.0 (#5931)

* s/SearchBoxVisiblty/SearchBoxVisibility/

Fix typo in type name.

* s/Collapsable/Collapsible/

* Changed capitalization in comment

5 years agoremove used Group Header Template (#5906)
Shane Neuville [Tue, 16 Apr 2019 16:38:17 +0000 (10:38 -0600)]
remove used Group Header Template (#5906)

5 years ago[iOS] Fix usage of iOS11 api (#5893)
Rui Marinho [Mon, 15 Apr 2019 21:24:50 +0000 (22:24 +0100)]
[iOS] Fix usage of iOS11 api (#5893)

* [iOS] Fix usage of iOS11 api

* [iOS] Fix remaining calls to HomeIndicatorHidden feature

5 years ago[Shell] Hide Shell types from being browsable (#5915)
Shane Neuville [Mon, 15 Apr 2019 16:22:47 +0000 (10:22 -0600)]
[Shell] Hide Shell types from being browsable (#5915)

* set shell things to EditorBrowsable false

* - EditorBrowsable always

* delete tab content

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 13 Apr 2019 01:28:49 +0000 (18:28 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago- add explicit references back into nuspec (#5902)
Shane Neuville [Fri, 12 Apr 2019 23:25:54 +0000 (17:25 -0600)]
- add explicit references back into nuspec (#5902)

5 years ago[Android, shell] fixes visibility of tabs after their changes (#5896)
Pavel Yakovlev [Fri, 12 Apr 2019 16:33:33 +0000 (19:33 +0300)]
[Android, shell] fixes visibility of tabs after their changes (#5896)

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 11 Apr 2019 04:59:38 +0000 (21:59 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Add Platform Specific features for PrefersHomeIndicatorAutoHidden (#5717)
piotrkonowalski [Thu, 11 Apr 2019 04:58:34 +0000 (06:58 +0200)]
[iOS] Add Platform Specific features for PrefersHomeIndicatorAutoHidden (#5717)

fixes #5310

5 years ago[Shell] refactor of processing uris (#5852)
Shane Neuville [Thu, 11 Apr 2019 04:54:50 +0000 (22:54 -0600)]
[Shell] refactor of processing uris (#5852)

fixes #5790

5 years ago[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)
Samantha Houts [Thu, 11 Apr 2019 04:53:37 +0000 (21:53 -0700)]
[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)

fixes #2789

5 years agoPorting fix from 4794 to handle clip bounds on sub-API-19 Android; fixes #4790 (...
E.Z. Hart [Thu, 11 Apr 2019 04:28:11 +0000 (22:28 -0600)]
Porting fix from 4794 to handle clip bounds on sub-API-19 Android; fixes #4790 (#5863)

fixes #4790

5 years ago[Android] Null check on Switch TrackDrawable (#5851)
Samantha Houts [Thu, 11 Apr 2019 00:25:45 +0000 (17:25 -0700)]
[Android] Null check on Switch TrackDrawable (#5851)

* [Android] Null check on Switch TrackDrawable

fixes #5553

* Add a few more checks, dispose Drawable, fix copy/paste error

* Couple more for safety's sake

5 years ago[X] update Cecil (#5878)
Stephane Delcroix [Wed, 10 Apr 2019 23:10:54 +0000 (01:10 +0200)]
[X] update Cecil (#5878)

- fixes #5875

5 years ago[Android] Fix ObjectDisposedException on MasterDetailPageRenderer update (#4955)
Kevin Petit [Mon, 18 Feb 2019 11:24:26 +0000 (12:24 +0100)]
[Android] Fix ObjectDisposedException on MasterDetailPageRenderer update (#4955)

* Android - MasterDetailPageRenderer - Fix ObjectDisposedException on update.

* Fix update call to master.

* Move checks inside update methods.
Add HandleMasterPropertyChanged handler unsubscribing.

5 years agoMerge branch '3.6.0' into 4.0.0
Stephane Delcroix [Mon, 8 Apr 2019 19:09:04 +0000 (21:09 +0200)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Fix when we render the font icon image as original (#5753)
Rui Marinho [Mon, 8 Apr 2019 17:15:53 +0000 (18:15 +0100)]
[iOS] Fix when we render the font icon image as original (#5753)

fixes #5071

5 years ago[C] allow inheriting from Behavior (#5559)
Stephane Delcroix [Mon, 8 Apr 2019 17:15:14 +0000 (19:15 +0200)]
[C] allow inheriting from Behavior (#5559)

- fixes #5520

5 years agoupdate build script for mac and readme based on vs mac 2019 (#5827)
Shane Neuville [Mon, 8 Apr 2019 16:48:23 +0000 (10:48 -0600)]
update build script for mac and readme based on vs mac 2019 (#5827)

5 years ago[Android] fixes material placeholder (#5823)
Pavel Yakovlev [Sat, 6 Apr 2019 03:42:41 +0000 (06:42 +0300)]
[Android] fixes material placeholder (#5823)

5 years agoXamlLoader should not ignore x:TypeArguments on root node (#5804)
Tim Barham [Fri, 5 Apr 2019 05:31:28 +0000 (15:31 +1000)]
XamlLoader should not ignore x:TypeArguments on root node (#5804)

5 years ago[macOS] Fixes #5257 (#5262)
Andrei [Wed, 3 Apr 2019 17:00:48 +0000 (20:00 +0300)]
[macOS] Fixes #5257 (#5262)

5 years agoAllow EmptyView swapping in Android CollectionView (#5720) fixes #5535
E.Z. Hart [Wed, 3 Apr 2019 16:49:05 +0000 (10:49 -0600)]
Allow EmptyView swapping in Android CollectionView (#5720) fixes #5535

* Automated test for issue

* Fix empty view swapping for Android (fixes #5535)

* Remove private modifier

* Account for null Flags when setting flags for test

* Fix rebase issue

5 years ago[X] check for null on the parent property (#5796)
Stephane Delcroix [Wed, 3 Apr 2019 13:19:48 +0000 (15:19 +0200)]
[X] check for null on the parent property (#5796)

In case of value types in Compiled Binding Paths, we weren't checking
for null property on the right part of the path

before
```csharp
bindingExtension.TypedBinding = new TypedBinding<Gh5770, Color>(delegate(Gh5770 gh)
{
if (gh == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
Gh5770VM expr_24 = gh.MyContentViewModel;
return new ValueTuple<Color, bool>(expr_24.TextColor, true);
}, ..., ...);
```

after
```csharp
bindingExtension.TypedBinding = new TypedBinding<Gh5770, Color>(delegate(Gh5770 gh)
{
if (gh == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
Gh5770VM expr_24 = gh.MyContentViewModel;
if (expr_24 == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
return new ValueTuple<Color, bool>(expr_24.TextColor, true);
}, ..., ...);
```

- fixes #5770

5 years ago[X] resolve generic indexer types (#5794)
Stephane Delcroix [Wed, 3 Apr 2019 13:19:33 +0000 (15:19 +0200)]
[X] resolve generic indexer types (#5794)

- fixes #5510

5 years ago[C] SearchHandler.SelectedItem (#5775)
Stephane Delcroix [Wed, 3 Apr 2019 07:27:13 +0000 (09:27 +0200)]
[C] SearchHandler.SelectedItem (#5775)

- fixes #5712

5 years agotry to avoid merge conflicts in GitInfo.txt (#5715)
Stephane Delcroix [Wed, 3 Apr 2019 06:49:40 +0000 (08:49 +0200)]
try to avoid merge conflicts in GitInfo.txt (#5715)

5 years ago[Shell] propagate BindingContext to SearchHandler (#5730)
Stephane Delcroix [Wed, 3 Apr 2019 06:49:01 +0000 (08:49 +0200)]
[Shell] propagate BindingContext to SearchHandler (#5730)

- fixes #5705

5 years agofix reference to local folder (#5792)
Shane Neuville [Wed, 3 Apr 2019 02:13:35 +0000 (20:13 -0600)]
fix reference to local folder (#5792)

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Tue, 2 Apr 2019 17:28:23 +0000 (18:28 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Shell] propagate BC to BackButtonBehavior (#5743) fixes #5734
Stephane Delcroix [Tue, 2 Apr 2019 16:52:48 +0000 (18:52 +0200)]
[Shell] propagate BC to BackButtonBehavior (#5743) fixes #5734

- fixes #5734

no test, as it's straightforward, and mimics #5730

5 years ago[nuspec] Start using the 28.x versions of Android support (#5512)
Matthew Leibowitz [Tue, 2 Apr 2019 15:06:59 +0000 (17:06 +0200)]
[nuspec] Start using the 28.x versions of Android support (#5512)

5 years ago[C] change searchHandler bindingMode (#5776)
Stephane Delcroix [Tue, 2 Apr 2019 08:02:44 +0000 (10:02 +0200)]
[C] change searchHandler bindingMode (#5776)

Change the default BindingMode for some properties

- fixes #5706

5 years ago[UItest] Added dynamic view gallery (#5402)
Pavel Yakovlev [Tue, 2 Apr 2019 02:45:41 +0000 (05:45 +0300)]
[UItest] Added dynamic view gallery (#5402)

5 years agoFix UI test 4600 for Android/iOS; fixes #4943 (#5726)
E.Z. Hart [Tue, 2 Apr 2019 02:34:36 +0000 (20:34 -0600)]
Fix UI test 4600 for Android/iOS; fixes #4943 (#5726)

5 years agoExtend Control Gallery to allow for Shell UI Tests (#5740)
Shane Neuville [Mon, 1 Apr 2019 20:25:01 +0000 (14:25 -0600)]
Extend Control Gallery to allow for Shell UI Tests (#5740)

* enable UI tests for shell

* - fix test for ios shell

* - add scrollview so success is visible on ios

* - add instructions

* - add shell category

5 years agoAdd covariance back to IElementConfiguration (#5771)
Shane Neuville [Mon, 1 Apr 2019 20:07:59 +0000 (14:07 -0600)]
Add covariance back to IElementConfiguration (#5771)

* add covariance back

* - remove confusing comment

5 years agoCheck if Element parent is null before getting the padding insets (#5757)
Shane Neuville [Mon, 1 Apr 2019 08:53:53 +0000 (02:53 -0600)]
Check if Element parent is null before getting the padding insets (#5757)

* Check if Element parent is null before getting the padding insets

* - move if up earlier

5 years agoShell.CurrentShell is too many Shells (#5761)
Shane Neuville [Mon, 1 Apr 2019 08:52:18 +0000 (02:52 -0600)]
Shell.CurrentShell is too many Shells (#5761)

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 28 Mar 2019 00:13:02 +0000 (17:13 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Don't crash if no Thumbnail specified for AppLink (#5684)
Samantha Houts [Wed, 27 Mar 2019 23:41:38 +0000 (16:41 -0700)]
[iOS] Don't crash if no Thumbnail specified for AppLink (#5684)

* Add test for #5470

* [iOS] Don't crash if no Thumbnail specified for AppLink

fixes #5470

* Add braces

* fix test on Android

5 years agoRemoved dependency on modernhttpclient (#5390)
Andrei Nitescu [Wed, 27 Mar 2019 23:38:45 +0000 (01:38 +0200)]
Removed dependency on modernhttpclient (#5390)

fixes #1886

5 years ago[UWP] Fixes the casting crash of the FontImageSource (#5678)
Pavel Yakovlev [Wed, 27 Mar 2019 23:26:05 +0000 (02:26 +0300)]
[UWP] Fixes the casting crash of the FontImageSource (#5678)

5 years ago[visual] Add extra parameter to android visual constructors (#5289)
Shane Neuville [Wed, 27 Mar 2019 23:10:21 +0000 (17:10 -0600)]
[visual] Add extra parameter to android visual constructors (#5289)

* [visual] Add extra parameter to android visual constructors

* - add null check and constructor to Material Button Renderer to prove scenario

5 years agoHandle DataTemplateSelector on iOS/Android CollectionView (#5429)
E.Z. Hart [Wed, 27 Mar 2019 23:03:35 +0000 (17:03 -0600)]
Handle DataTemplateSelector on iOS/Android CollectionView (#5429)

* DataTemplateSelector working on Android for ItemTemplate and EmptyTemplate

* Demonstrate DataTemplateSelector working with EmptyViewTemplate

* Handle DataTemplateSelector on iOS CollectionView

* Add UI test
Fixes #4826

* Temporarily patching EditorRenderer to get tests running

* Add test for binding errors;
Fix binding errors on Android;

* Fix binding errors for iOS

* Add flag setting to allow UI test to run

* Fix rebase errors

5 years ago[C] alias shell names (#5624)
Stephane Delcroix [Wed, 27 Mar 2019 18:52:12 +0000 (19:52 +0100)]
[C] alias shell names (#5624)

* [C] alias shell names

* - change from ShellTab to Tab

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 27 Mar 2019 18:51:38 +0000 (18:51 +0000)]
Merge branch '3.6.0' into 4.0.0

5 years agoRe-enable "Treat warnings as errors" (#5602)
E.Z. Hart [Wed, 27 Mar 2019 18:38:38 +0000 (12:38 -0600)]
Re-enable "Treat warnings as errors" (#5602)

* Enable "treat warnings as errors"

* Remove unnecessary for loop

* Remove properties which already exist in base class

* Make property hiding explicit and obsolete hiding property

* Move Treat Warnings as Errors setting to props file

* Fix weird quotation changes in Xamarin.Forms.Build.Tasks.csproj

* Scrub empty WarningsAsErrors tags

* Remove unused variable

* Fix TearDown method hiding in UI tests

* Fix Id member hiding in test for Bugzilla32871

* Fix RootPage member hiding in Bugzilla51503

* Fix RooPage member hiding in Issue1483

* Disable warnings for deprecated OpenGL calls

* Fix member hiding in test view models

* Fix RootPage member hiding in Issue1931

* Fix Id member hiding in Bugzilla42620

* Fix AutomationId member hiding in Bugzilla57114

* Fix Layout member hiding in Bugzilla40911

* Remove unused variables from Bugzilla31114

* Remove unused variable

* Fix various unused variable warnings

* Disable warning to leave example code for reference

* Fix unused variable from macOS test

* Remove unused members

* Fix unused variable warnings

* Fixed unused property warnings

* Fix warnings for unused code

* Disable 'await' warning

* Remove unused variable

* Adding pragma directives for await warnings

* Remove member hiding

* Turn off global "Treat warnings as errors" in other platforms

* Use MarkerId instead of obsolete Id member

* Fix await warnings in WPF GeocoderBackend

* Add missing await

* Disable warning for unused event

5 years agoremove covariant out on IElementConfiguration (#5449) closes #5235
Shane Neuville [Wed, 27 Mar 2019 18:32:47 +0000 (12:32 -0600)]
remove covariant out on IElementConfiguration (#5449) closes #5235

5 years ago[Shell] Add FlyoutIcon (#5567) fixes #4766 fixes #4767 fixes #4845 fixes #5219
Rui Marinho [Wed, 27 Mar 2019 17:05:21 +0000 (17:05 +0000)]
[Shell] Add FlyoutIcon  (#5567) fixes #4766 fixes #4767 fixes #4845 fixes #5219

* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [iOS,Shell] Fix issue when disposing ToolbarItems  of old page

* [Controls] Add demo repo for #5466

* [Shell,Core] Fix navigating to a registered route

* [Shell,Core] Add better exception messages for wrong or non existing content fixes #5081

* [Core,Shell,iOS,Android] Add FlyoutIcon property

* [Controls] Make shell sample work on Android

* [Controls,Android] Add ImageSource support to FlyoutIcon

* [Android]Allow to set text on the back button

* [Android] Create default text back button

* [Controls] Add example to push with back button behavior

* [Android] Fix back button tint color

* [Android] Cleanup and refactor UpdateDrawerArrow

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>
* [iOS,Shell] Fix go back (Pop) when proving BackButtonBehavior

* [iOS] Check the ParentViewController since we were push to it

* [Android,iOS,Shell] Remove extra code implement feedback

* removed old code

* minor cleanup

5 years ago[Android] Fix various issues with material found by a full run of the UI Tests with...
Shane Neuville [Wed, 27 Mar 2019 16:07:15 +0000 (10:07 -0600)]
[Android] Fix various issues with material found by a full run of the UI Tests with Material active (#5676)

* - locate activity

* get tests to run

* - fix and force core gallery to work against default

* - fix check if control already disposed

* - fixing what automationid assigns to

* - input transparent fixes

* - fix sandbox back

* - set default visual back to default

* Update Xamarin.Forms.Material.Android/MaterialStepperRenderer.cs

* Update Xamarin.Forms.Material.Android/MaterialSliderRenderer.cs

* - fix core gallery ui tests to find container

* - ui test tweak

* - fix background color on pickers

* - suggested changes

* - suggested fix

5 years agobump
Stephane Delcroix [Wed, 27 Mar 2019 14:41:20 +0000 (15:41 +0100)]
bump

5 years agobump
Stephane Delcroix [Wed, 27 Mar 2019 14:40:50 +0000 (15:40 +0100)]
bump

5 years ago[Android] don't clear shell content because native page isn't visible (#5671) fixes...
Shane Neuville [Wed, 27 Mar 2019 11:58:35 +0000 (05:58 -0600)]
[Android] don't clear shell content because native page isn't visible (#5671) fixes #4684

* [Android] don't clear shell content because native page isn't visible

* - move checks up a line

5 years ago[CollectionView] Fixes for ObservableCollection usage on Android and iOS (#4664)
Rui Marinho [Tue, 26 Mar 2019 22:58:29 +0000 (22:58 +0000)]
[CollectionView] Fixes for ObservableCollection usage on Android and iOS (#4664)

* [Controls] Update CollectionView observable gallery

* [Controls] Add test case with timer to add items to ObservableCollection

* [Android] Implement IDisposable on IItemsViewSource

* [iOS] ObservableItemSource takes a IList

* [iOS] Update ItemsViewLayout.cs

* [Android] Implement review feedback

* [Controls] Fix adder

* [Build] Update submodule

* [Android] Make similar change to iOS for consistency

* [iOS] Unsubscribe from ObservableCollection on ItemsViewController

* [iOS] Dispose ItemsController

* [Build] Update submodule

5 years ago[Shell] Fix Register route and Navigate to it (#5564) fixes #5466
Rui Marinho [Tue, 26 Mar 2019 22:56:27 +0000 (22:56 +0000)]
[Shell] Fix Register route and Navigate to it (#5564) fixes #5466

* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [Shell,iOS] Fix toolbaritems on Shell

* [Controls] Add demo repo for #5466

* [Shell,Core] Fix navigating to a registered route

* [Controls] Fix android example add missing images

* nested routing

* [Controls] Fix build on pre app compact

5 years ago[Android] Fixes ObjectDisposedException when call Unfocus of Entry (#5670)
Pavel Yakovlev [Tue, 26 Mar 2019 18:42:05 +0000 (21:42 +0300)]
[Android] Fixes ObjectDisposedException when call Unfocus of Entry (#5670)

* [Android] Fixes ObjectDisposedException when call Unfocus of Entry

* address comment

* fix ui test

5 years ago[Build] Update verssion
Rui Marinho [Mon, 25 Mar 2019 14:42:52 +0000 (14:42 +0000)]
[Build] Update verssion

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Mon, 25 Mar 2019 14:42:29 +0000 (14:42 +0000)]
Merge branch '3.6.0' into 4.0.0

5 years agoMerge branch '3.5.0' into 3.6.0
Rui Marinho [Mon, 25 Mar 2019 11:54:50 +0000 (11:54 +0000)]
Merge branch '3.5.0' into 3.6.0

5 years ago[Build] Fix suffix check
Rui Marinho [Mon, 25 Mar 2019 11:47:05 +0000 (11:47 +0000)]
[Build] Fix suffix check

5 years agoMerge branch '3.5.0' into 3.6.0
Rui Marinho [Mon, 25 Mar 2019 11:06:21 +0000 (11:06 +0000)]
Merge branch '3.5.0' into 3.6.0

5 years ago[Update] Yaml build
Rui Marinho [Mon, 25 Mar 2019 11:05:22 +0000 (11:05 +0000)]
[Update] Yaml build

5 years agoAdd translated Intellisense files to NuGet package (#5672)
E.Z. Hart [Sun, 24 Mar 2019 20:05:01 +0000 (14:05 -0600)]
Add translated Intellisense files to NuGet package (#5672)

* WIP Experimenting with getting the translated Intellisense in the right places

* Set up nuspec to include Intellisense translations

* Use languages branch of submodule for now

* Update submodule

* Update submodule

* Updated submodule

* Update submodule

* Pull in translated docs from all the languages

5 years ago[Build] Update yaml build
Rui Marinho [Sun, 24 Mar 2019 19:51:25 +0000 (19:51 +0000)]
[Build] Update yaml build

5 years agoMerge branch '3.5.0' into 3.6.0
Rui Marinho [Sun, 24 Mar 2019 19:49:23 +0000 (19:49 +0000)]
Merge branch '3.5.0' into 3.6.0

5 years ago[iOS] Better fix for EstimatedRowHeight (#4365) fixes #4356
Rui Marinho [Sun, 24 Mar 2019 19:48:16 +0000 (19:48 +0000)]
[iOS] Better fix for EstimatedRowHeight  (#4365) fixes #4356

* [Controls] Add repo for issue #4356

* [iOS] Call UpdateEstimatedRowHeight on MainThread so it delays and reloads after the row is inserted

* [IOS] Try remove UpdateEstimatedRowHeight

* [iOS] Fix EstimatedRowHeight

* [iOS] Consolidate EstimatedRowHeight calculation on the ListviewDataSource

* [iOS] Fix InvalidateCache and clear estimatedRowHeight

* [iOS] Use bool for checking if is empty

Co-Authored-By: rmarinho <me@ruimarinho.net>
* Update Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>
* Update Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>
* Update Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>
* [iOS] Fix rebase

* [Build] Update submodule

* [Build] Remove xcode select

* [iOS] Don't disable EstimatedRowHeight on iOS10

5 years ago[UWP] fix throw exception when update switch color (#5633)
Pavel Yakovlev [Fri, 22 Mar 2019 22:25:10 +0000 (01:25 +0300)]
[UWP] fix throw exception when update switch color (#5633)

5 years agoMerge branch '3.4.0' into 3.5.0
Rui Marinho [Fri, 22 Mar 2019 16:07:42 +0000 (16:07 +0000)]
Merge branch '3.4.0' into 3.5.0

5 years ago[Build] Fix provision on yaml (#5660)
Rui Marinho [Fri, 22 Mar 2019 12:13:58 +0000 (12:13 +0000)]
[Build] Fix provision on yaml (#5660)

* [Build] Fix provision on yaml

* [Build] Update provisioning to use shared tasks

5 years agoRevert "Remove submodule"
Rui Marinho [Thu, 21 Mar 2019 20:08:43 +0000 (20:08 +0000)]
Revert "Remove submodule"

This reverts commit 6616000366ff9dd05de2ee91e2612600f63fd4f5.

5 years agoRemove submodule
Rui Marinho [Thu, 21 Mar 2019 20:08:18 +0000 (20:08 +0000)]
Remove submodule

5 years ago[GTK] Fix NavigationBar check for Layout calc (#5506)
mtz [Thu, 21 Mar 2019 00:08:13 +0000 (01:08 +0100)]
[GTK] Fix NavigationBar check for Layout calc (#5506)

The loop was exiting before current was being set.

fixes #4713

5 years agoMerge branch '3.5.0' into 3.6.0
ShaneN [Thu, 21 Mar 2019 16:58:10 +0000 (10:58 -0600)]
Merge branch '3.5.0' into 3.6.0

5 years agomerge 3.4 into 3.5
ShaneN [Thu, 21 Mar 2019 16:50:41 +0000 (10:50 -0600)]
merge 3.4 into 3.5

5 years ago[Android] Remove changes to IVisualElementRenderer so it remains backwards compatible...
Shane Neuville [Thu, 21 Mar 2019 16:46:55 +0000 (10:46 -0600)]
[Android] Remove changes to IVisualElementRenderer so it remains backwards compatible (#5619)

* [Android] Remove changes to IVisualElementRenderer so it remains backwards compatible (#5398)

* return IVisualElementRenderer to previous state

* set to internal

* remove extra change

* - ToUIBarButtonItem abi fix

* - page gallery

* - remove tizen from iphone configuration

5 years agoMerge branch '3.6.0' into 4.0.0
Stephane Delcroix [Thu, 21 Mar 2019 13:37:08 +0000 (14:37 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoMerge branch '3.5.0' into 3.6.0
Stephane Delcroix [Thu, 21 Mar 2019 13:35:44 +0000 (14:35 +0100)]
Merge branch '3.5.0' into 3.6.0

5 years agoFix BindableLayout's incorrect layout.children.add -> use insert (#5582)
Chris van de Steeg [Thu, 21 Mar 2019 13:24:31 +0000 (14:24 +0100)]
Fix BindableLayout's incorrect layout.children.add -> use insert (#5582)

* Fix incorrect layout.children.add -> use insert

* Modify unit test to match the problem with this issue

- fixes #5579

5 years agoSuppress warning for CharacterRangeForGlyphRange is obsolete (#5613) fixes #5246
Shane Neuville [Thu, 21 Mar 2019 11:12:18 +0000 (05:12 -0600)]
Suppress warning for CharacterRangeForGlyphRange is obsolete (#5613) fixes #5246

* switch to GetCharacterRange for spans

* suppress obsolete message

5 years ago[shell] Fix show DisplayAlert (#5491) fixes #5504
Pavel Yakovlev [Thu, 21 Mar 2019 10:03:50 +0000 (13:03 +0300)]
[shell] Fix show DisplayAlert (#5491) fixes #5504

* [shell, ios, tizen] fixes show alert

* - added helper extension
- fix navigation model

5 years agofix abi breaks (#5620) fixes #5288
Shane Neuville [Thu, 21 Mar 2019 10:00:59 +0000 (04:00 -0600)]
fix abi breaks (#5620) fixes #5288

5 years ago[Android] fixes redraw element when changing renderer (#5233)
Pavel Yakovlev [Wed, 20 Mar 2019 17:31:55 +0000 (20:31 +0300)]
[Android] fixes redraw element when changing renderer (#5233)

fixes #1760

5 years agoCentralize Theme Wrapper and fix sandbox to work with previewer (#5495)
Shane Neuville [Wed, 20 Mar 2019 17:11:16 +0000 (11:11 -0600)]
Centralize Theme Wrapper and fix sandbox to work with previewer (#5495)

* Centralize Theme Wrapper and fix sandbox to work with previewer

* simplify

* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs

5 years ago[Android] Fixes cancel Webview Navigation (#5458) fixes #4891 fixes #4919 closes...
Pavel Yakovlev [Tue, 19 Mar 2019 20:05:38 +0000 (23:05 +0300)]
[Android] Fixes cancel Webview Navigation (#5458) fixes #4891 fixes #4919 closes #5460

* [Android] Fixes cancel Webview Navigation

* - added fix 4891
- refactoring

* Fix obsolete message

Co-authored-by: Ralph Brackert <brackert@baselineconnect.com>
5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Tue, 19 Mar 2019 20:01:21 +0000 (13:01 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Controls] Fix build
Rui Marinho [Tue, 19 Mar 2019 20:00:02 +0000 (20:00 +0000)]
[Controls] Fix build

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Tue, 19 Mar 2019 18:58:17 +0000 (11:58 -0700)]
Merge branch '3.6.0' into 4.0.0