Stef Walter [Wed, 14 Nov 2012 10:04:04 +0000 (11:04 +0100)]
Don't print messages when creating default collection
* This is expected behavior, so don't complain.
https://bugzilla.gnome.org/show_bug.cgi?id=688165
Stef Walter [Wed, 14 Nov 2012 09:57:10 +0000 (10:57 +0100)]
Rework how we strip remote DBus errors
* This is necessary because sometimes we don't want to complain,
for expected errors, when running nested operations.
* The fact that we have to do this is silly, and soon there
will be a solution in glib itself.
https://bugzilla.gnome.org/show_bug.cgi?id=688165
Stef Walter [Wed, 14 Nov 2012 09:33:40 +0000 (10:33 +0100)]
Translated label for automatically created default keyrings
https://bugzilla.gnome.org/show_bug.cgi?id=688165
Stef Walter [Wed, 14 Nov 2012 09:30:48 +0000 (10:30 +0100)]
When storing a secret, create default keyring if necessary
* If the default keyring does not exist when storing a secret
try and create it.
* We handle both secrets that correctly return NoSuchObject
and ones that just return the silly DBus UnknownMethod error.
https://bugzilla.gnome.org/show_bug.cgi?id=688165
Stef Walter [Wed, 14 Nov 2012 09:35:13 +0000 (10:35 +0100)]
Fix collection creation bugs in mock service
* Guarantee that collections have unique paths
* Set the alias of new collections correctly
https://bugzilla.gnome.org/show_bug.cgi?id=688165
Stef Walter [Wed, 7 Nov 2012 22:15:44 +0000 (23:15 +0100)]
egg-hex: Bring over changes from gnome-keyring and gcr
Stef Walter [Tue, 6 Nov 2012 12:37:01 +0000 (13:37 +0100)]
Remove some unused test code
Stef Walter [Sat, 27 Oct 2012 10:46:59 +0000 (12:46 +0200)]
Share the memory pool with the gcr or libgnome-keyring library.
Stef Walter [Sat, 27 Oct 2012 09:58:13 +0000 (11:58 +0200)]
Bring over a new version of the secure memory code from gcr
* This allows libraries to share the pool if they have the same
version of the secure memory code.
Xi Wang [Mon, 22 Oct 2012 20:09:46 +0000 (16:09 -0400)]
Fix incorrect loop condition in egg_hkdf_perform()
This does not cause a change in behavior (as evidenced by tests,
at least on linux when built with gcc) but is more correct code,
and less likely to be miscompiled.
The condition (i < 256) in the following loop is always false since i
is of type guchar, which is at most 255.
guchar i;
...
for (i = 1; i < 256; ++i) { ... }
This patch changes i to a larger type gint.
Also in the loop we have:
gcry_md_write (md2, &i, 1);
change it to use gcry_md_putc().
Stef Walter [Mon, 22 Oct 2012 18:50:48 +0000 (20:50 +0200)]
Fix for glib deprecations
* g_type_init() was deprecated in glib 2.35.0
Stef Walter [Mon, 15 Oct 2012 12:31:36 +0000 (14:31 +0200)]
Release version 0.11
Stef Walter [Fri, 12 Oct 2012 09:27:34 +0000 (11:27 +0200)]
Better critical preconditions for invalid attributes
* When passing NULL for a string vararg attribute print
a critical warning.
* Make all attribute warnings critical
* Add tests for the various critical warnings
https://bugzilla.gnome.org/show_bug.cgi?id=686015
Stef Walter [Tue, 18 Sep 2012 10:34:23 +0000 (12:34 +0200)]
Release version 0.10
Piotr Drąg [Tue, 4 Sep 2012 16:58:07 +0000 (18:58 +0200)]
Updated Polish translation
Takeshi AIHANA [Sat, 1 Sep 2012 14:42:08 +0000 (23:42 +0900)]
Added Japanese translation.
Piotr Drąg [Thu, 23 Aug 2012 01:57:45 +0000 (03:57 +0200)]
Updated Polish translation
Stef Walter [Mon, 20 Aug 2012 14:00:06 +0000 (16:00 +0200)]
Release version 0.9
Stef Walter [Mon, 20 Aug 2012 13:58:26 +0000 (15:58 +0200)]
Fix gcc warning about uninitialized warning
Stef Walter [Thu, 16 Aug 2012 09:43:42 +0000 (11:43 +0200)]
Display vala enabled status when configuring
Evan Nemerson [Thu, 16 Aug 2012 07:26:34 +0000 (00:26 -0700)]
vala: use nodist sources for vala test cases
https://bugzilla.gnome.org/show_bug.cgi?id=681330
Stef Walter [Wed, 8 Aug 2012 08:40:30 +0000 (10:40 +0200)]
secret-tool: Add a manual page
https://bugzilla.gnome.org/show_bug.cgi?id=681434
Stef Walter [Wed, 8 Aug 2012 05:57:09 +0000 (07:57 +0200)]
build: Fix build without libgcrypt
* Needed to use m4_ifdef on the libgcrypt autoconf macro
https://bugzilla.gnome.org/show_bug.cgi?id=681330
Stef Walter [Mon, 6 Aug 2012 20:14:59 +0000 (22:14 +0200)]
Bump version number
Stef Walter [Mon, 6 Aug 2012 20:13:07 +0000 (22:13 +0200)]
Require valac in order to 'make distcheck'
* Otherwise problems with vala files not being distributed
https://bugzilla.gnome.org/show_bug.cgi?id=681330
Stef Walter [Mon, 6 Aug 2012 14:06:30 +0000 (16:06 +0200)]
Don't link to secure memory code twice
* This leads to problems with the tests not being able to free
non-pageable memory returned from libsecret-testable.so
Stef Walter [Mon, 6 Aug 2012 13:33:35 +0000 (15:33 +0200)]
More licensing tweaks
* Actually include in the tarball the other licenses for test code
* Refer to COPYING.TESTS not COPYING.GPL
https://bugzilla.gnome.org/show_bug.cgi?id=681302
Stef Walter [Mon, 6 Aug 2012 13:14:04 +0000 (15:14 +0200)]
Release version 0.8
Matthias Clasen [Sun, 5 Aug 2012 20:07:49 +0000 (16:07 -0400)]
Actually export SECRET_SCHEMA_NOTE
The regex for exported symbols was keeping the predefined
schemas from being available to outside users of the library.
This was showing up as a link error for seahorse, which is
trying to use SECRET_SCHEMA_NOTE.
https://bugzilla.gnome.org/show_bug.cgi?id=681255
Stef Walter [Mon, 6 Aug 2012 09:22:30 +0000 (11:22 +0200)]
Fix up libsecret licensing
* License libsecret under LGPL2.1+. We can do this because the
files that make up the library are either LGPL2.0+ or LGPL2.1+
* Correctly include a file which contains the full texts of the
various licenses used in the tests.
* Include license headers in some files that contained no license
headers.
https://bugzilla.gnome.org/show_bug.cgi?id=680781
Stef Walter [Tue, 31 Jul 2012 12:56:52 +0000 (14:56 +0200)]
Fix introspection tests
* Regressed due to hiding of internal symbols in libsecret.so and
creation of a separate libsecret-testable.so library
Stef Walter [Mon, 30 Jul 2012 14:53:08 +0000 (16:53 +0200)]
Support building with automake 1.12.x
https://bugzilla.gnome.org/show_bug.cgi?id=680839
Stef Walter [Mon, 30 Jul 2012 09:44:15 +0000 (11:44 +0200)]
secret-tool: Use the correct call to wipe password in memory
* Fixes crash
Stef Walter [Tue, 24 Jul 2012 04:24:05 +0000 (06:24 +0200)]
Set correct module flags on libsecret
* Pointed out by Robert Ancell
https://bugzilla.gnome.org/show_bug.cgi?id=680207
Stef Walter [Tue, 17 Jul 2012 08:14:27 +0000 (10:14 +0200)]
Initialize gettext in secret-tool
https://bugzilla.gnome.org/show_bug.cgi?id=680072
Stef Walter [Mon, 16 Jul 2012 10:54:59 +0000 (12:54 +0200)]
Release version 0.7
Stef Walter [Sat, 14 Jul 2012 11:25:39 +0000 (13:25 +0200)]
Match schema names for notes and network passwords
* These are old item types from libgnome-keyring, and
gnome-keyring-daemon has special code to generate the
schema for these types of items.
Stef Walter [Sat, 14 Jul 2012 11:23:16 +0000 (13:23 +0200)]
Remove multiple definitions of SecretCollection
https://bugzilla.gnome.org/show_bug.cgi?id=679913
Stef Walter [Sat, 14 Jul 2012 10:11:02 +0000 (12:11 +0200)]
Remove empty secret-unstable.h file
Stef Walter [Sat, 14 Jul 2012 10:09:38 +0000 (12:09 +0200)]
Add flags argument to secret_collection_for_alias()
* Can control whether items are loaded or not.
Stef Walter [Sat, 14 Jul 2012 10:09:10 +0000 (12:09 +0200)]
Correct flags for SecretCollection
* The SECRET_COLLECTION_LOAD_ITEMS flag was always set
Stef Walter [Sat, 14 Jul 2012 06:59:36 +0000 (08:59 +0200)]
Release version 0.6
Stef Walter [Sat, 14 Jul 2012 06:18:56 +0000 (08:18 +0200)]
Rename secret_password_remove() to secret_password_clear()
* It's clearer what happens here: we try to remove as many matching
passwords as possible.
* Also rename secret_service_remove() to secret_service_clear()
* Rename secret_password_clear() which used to wipe password memory
to secret_password_wipe().
Colin Walters [Fri, 13 Jul 2012 21:54:25 +0000 (17:54 -0400)]
build: Disable parallelism in tests
Colin Walters [Fri, 13 Jul 2012 21:50:22 +0000 (17:50 -0400)]
build: Fix parallel make issue
SecretUnstable.gir depends on Secret.gir, which in turn depends
on the stuff that was previously listed.
Stef Walter [Fri, 13 Jul 2012 14:08:36 +0000 (16:08 +0200)]
Properly refer to the fact that multiple passwords may be removed.
Colin Walters [Fri, 13 Jul 2012 13:10:13 +0000 (09:10 -0400)]
build: Various introspection-related build fixes
Don't set PKG_CONFIG_PATH, this breaks jhbuild; instead, use
--include-uninstalled to tell the scanner where to find internal
libraries.
Don't set _PACKAGES = gio-2.0; we already pick that up from the
Gio-2.0.gir.
https://bugzilla.gnome.org/show_bug.cgi?id=679852
Stef Walter [Fri, 13 Jul 2012 12:03:04 +0000 (14:03 +0200)]
Clearer warning when using unstable parts of API
Stef Walter [Fri, 13 Jul 2012 12:02:50 +0000 (14:02 +0200)]
The secret_attribute_build() functions are stable
Stef Walter [Fri, 13 Jul 2012 12:02:19 +0000 (14:02 +0200)]
The predefined secret schemas are stable
Stef Walter [Fri, 13 Jul 2012 11:33:36 +0000 (13:33 +0200)]
Search for mock-service-0.vapi in the right directory
Stef Walter [Fri, 13 Jul 2012 11:33:23 +0000 (13:33 +0200)]
Documentation fix for SecretItem:flags
Stef Walter [Fri, 13 Jul 2012 11:24:34 +0000 (13:24 +0200)]
Install headers to libsecret-1 instead of secret-1
* Clearer and more consistent
Stef Walter [Fri, 13 Jul 2012 11:02:17 +0000 (13:02 +0200)]
Update documentation for to have correct headers
* Add add more warnings to unstable API documentation
Stef Walter [Fri, 13 Jul 2012 10:48:41 +0000 (12:48 +0200)]
Release version 0.5
Stef Walter [Fri, 13 Jul 2012 10:26:23 +0000 (12:26 +0200)]
Add missing documentation for secret_item_get_schema_name()
Stef Walter [Fri, 13 Jul 2012 10:25:10 +0000 (12:25 +0200)]
More fixes for broken vapi and gir generation
* Man this is brittle
Stef Walter [Fri, 13 Jul 2012 10:24:35 +0000 (12:24 +0200)]
Bump the library major version number
* We want to settle on 1 after first stable release
* Since we're going to start patching projects we want this to have
the pkg-config file be libsecret-1
Stef Walter [Fri, 13 Jul 2012 10:01:06 +0000 (12:01 +0200)]
Document how to build with or use libsecret
Stef Walter [Fri, 13 Jul 2012 09:11:58 +0000 (11:11 +0200)]
Split the pkg-config files, gir, and vapi into stable/unstable
* C callers need to use libsecret-0 pkg-config file for stable and
libsecret-unstable for unstable stuff.
* Vala callers need to '--pkg libsecret-unstable' for unstable
* GObject Introspection callers need to use the SecretUnstable package
Stef Walter [Fri, 13 Jul 2012 08:32:36 +0000 (10:32 +0200)]
Rename the library subdirectory to libsecret
* Death by a thousand paper cuts from gir and vapi not liking
the fact that the secret.h file was not usable uninstalled
and installed in the same way.
Stef Walter [Thu, 12 Jul 2012 15:14:58 +0000 (17:14 +0200)]
Bump version number
Stef Walter [Thu, 12 Jul 2012 11:59:35 +0000 (13:59 +0200)]
Add flags for secret_item_create and secret_collection_create
* For future extensibility
Stef Walter [Thu, 12 Jul 2012 11:02:14 +0000 (13:02 +0200)]
Add secret_item_get_schema_name() function
* And add tests for schemas on items
Stef Walter [Thu, 12 Jul 2012 10:49:51 +0000 (12:49 +0200)]
Allow passing SecretSchema to secret_item_create() and set_attributes()
Stef Walter [Thu, 12 Jul 2012 10:38:50 +0000 (12:38 +0200)]
Rename secret_service_read_alias() to secret_collection_for_alias()
* Much more logical, especially in the future when arbitrary aliases
are implemented in gnome-keyring-daemon
Stef Walter [Thu, 12 Jul 2012 09:40:28 +0000 (11:40 +0200)]
Add documentation for how to migrate from libgnome-keyring
Evan Nemerson [Tue, 10 Jul 2012 20:02:19 +0000 (13:02 -0700)]
introspection: add several missing element-type annotations
https://bugzilla.gnome.org/show_bug.cgi?id=679090
Evan Nemerson [Thu, 28 Jun 2012 20:40:54 +0000 (13:40 -0700)]
vala: update metadata to reflect changes made by
89550876
Stef Walter [Tue, 10 Jul 2012 19:39:48 +0000 (21:39 +0200)]
Remove erroneus precondition
Stef Walter [Tue, 10 Jul 2012 19:38:48 +0000 (21:38 +0200)]
secret_service_remove() and secret_password_remove() remove multiple
* Remove all items that are not locked that match in a
secret_service_remove() and secret_password_remove().
Stef Walter [Tue, 10 Jul 2012 19:37:20 +0000 (21:37 +0200)]
Validate that we have attributes when looking up
* When matching items, make sure we have attributes if
no schema name was included in the match
* This is particularly important because we don't want to
remove all the items.
Stef Walter [Mon, 9 Jul 2012 09:36:24 +0000 (11:36 +0200)]
Release version 0.4
Stef Walter [Mon, 9 Jul 2012 06:46:11 +0000 (08:46 +0200)]
Implement per collection search
* Use the SearchItems dbus method on the Collection interface
* Tweak some issues with the service search code as well
Stef Walter [Mon, 9 Jul 2012 06:44:50 +0000 (08:44 +0200)]
Register secret service errors as DBus errors
* and strip remote error codes from error->message so that
they don't clutter things.
Martyn Russell [Sun, 8 Jul 2012 16:00:43 +0000 (17:00 +0100)]
Don't try to build test-vala-lang if !HAVE_INTROSPECTION or !ENABLE_VAPIGEN
* libsecret-@SECRET_MAJOR@.vapi is built only with those 2 defines and these
were not checked before depending that target for the test case
Found during jhbuild run
Stef Walter [Fri, 6 Jul 2012 08:40:22 +0000 (10:40 +0200)]
Get service correctly for secret_service_set_alias()
* We can't use secret_collection_get_service() since a NULL
collection can be passed in.
Stef Walter [Fri, 6 Jul 2012 08:21:04 +0000 (10:21 +0200)]
Fix up documentation
Stef Walter [Fri, 6 Jul 2012 08:08:27 +0000 (10:08 +0200)]
Disconnect the cached default SecretService if service goes away
* Because the session would no longer be valid if the service
was autostarted for the same SecretService proxy
Stef Walter [Fri, 6 Jul 2012 07:42:08 +0000 (09:42 +0200)]
Use collection aliases with secret_password_store() and friends
* Make SECRET_COLLECTION_DEFAULT and SECRET_COLLECTION_SESSION
be the simple aliases for those collections.
* Accept either an alias or a path in secret_password_store()
and secret_service_store() and friends.
Stef Walter [Fri, 6 Jul 2012 07:01:20 +0000 (09:01 +0200)]
Rename the functions that operate on a dbus item path
* They all contain '_dbus_path' in their name
* Move secret_service_get_session_path() to the paths functionality
* Move the secret_collection_new() and secret_item_new() functionality
to the path based section.
Stef Walter [Thu, 5 Jul 2012 21:31:47 +0000 (23:31 +0200)]
Make sure notifications come in for new objects before waiting
* In tests make sure notifications settle down before waiting
on new notifications. This fixes random test crashes.
* Using async here means all signals are delivered by the time
we get the new object.
Stef Walter [Thu, 5 Jul 2012 21:14:50 +0000 (23:14 +0200)]
Accept NULL as a SecretService parameter for many methods
* We use secret_service_get() to lookup the default
SecretService in these cases.
* Use this functionality in the secret_password_xxx()
functions to greatly simplify them.
Stef Walter [Thu, 5 Jul 2012 19:26:20 +0000 (21:26 +0200)]
Add secret_collection_load_items()
* And flags to prevent loading of items when creating a
SecretCollection object
* Rename secret_service_ensure_collections() to
secret_service_load_collections()
Stef Walter [Thu, 5 Jul 2012 18:29:28 +0000 (20:29 +0200)]
secret_service_search() accepts a SecretSchema
* For validation and adding the xdg:schema attribute
Stef Walter [Thu, 5 Jul 2012 17:08:09 +0000 (19:08 +0200)]
Make secret_service_search() able to unlock, load secrets
* Turn secret_service_search() and friends into a more convenient
API, so that callers can get attributes, unlocking, and secrets
if so desired.
* Also support retrieving either one secret, or all of them.
Stef Walter [Thu, 5 Jul 2012 17:03:37 +0000 (19:03 +0200)]
Update the "Locked" property of items/collections on lock/unlock
* Make sure this property is kept in sync so it can be used
immediately in the logic to retrieve secrets or other stuff.
* We don't wait for a PropertiesChanged, which may come later
Stef Walter [Thu, 5 Jul 2012 15:11:58 +0000 (17:11 +0200)]
Move secret_service_get_secrets() to secret_item_load_secrets()
* And cache the secrets on the items instead of returning
them in a GHashtable
Stef Walter [Thu, 5 Jul 2012 15:11:38 +0000 (17:11 +0200)]
Fix invalid pre-condition in secret_item_get_service()
Stef Walter [Thu, 5 Jul 2012 14:41:28 +0000 (16:41 +0200)]
Separate path based functionality
* Move the dbus object path based functionality into its
own file and own section of the documentation.
Stef Walter [Thu, 5 Jul 2012 13:40:57 +0000 (15:40 +0200)]
Don't continue initialization of SecretService if failed
* Don't open session or load collections on SecretService
if the first part of the initialization failed
Stef Walter [Thu, 5 Jul 2012 13:40:23 +0000 (15:40 +0200)]
Uninitialize the mutex in SecretService
* Fix resource leak
Stef Walter [Thu, 5 Jul 2012 13:38:38 +0000 (15:38 +0200)]
Keep a cached SecretValue on each SecretItem
* This item can be retrieved immediately and loaded asynchronously
* It can also be loaded during initialization of the SecretItem
object
Colin Walters [Thu, 28 Jun 2012 15:47:25 +0000 (11:47 -0400)]
build: Remove double usage of $(srcdir)
This is a regression introduced by commit
3bc89a8971463d21535db1294bdfaadf62761b9b.
Colin Walters [Thu, 28 Jun 2012 15:33:17 +0000 (11:33 -0400)]
build: Ensure aclocal finds our local macros
The vala bindings commit copied in vapigen.m4, but our autogen.sh
invocation was depending on it being found in the buildroot. This
ensures autogen.sh will work without vala.
Stef Walter [Thu, 28 Jun 2012 11:15:06 +0000 (13:15 +0200)]
Remove varargs SecretService methods
* The SecretService methods aren't used as frequently as the
password methods, and it's not really necessary to have a whole
bunch of extra varargs functions.
* Add varargs functions for building a GHashTable of attributes
Evan Nemerson [Thu, 28 Jun 2012 09:48:45 +0000 (02:48 -0700)]
Add Vala bindings.
https://bugzilla.gnome.org/show_bug.cgi?id=678846
Evan Nemerson [Thu, 28 Jun 2012 07:25:17 +0000 (00:25 -0700)]
Fix VPATH build.
Stef Walter [Thu, 28 Jun 2012 08:38:17 +0000 (10:38 +0200)]
Fix python tests when libsecret is not installed
Stef Walter [Thu, 28 Jun 2012 08:36:38 +0000 (10:36 +0200)]
Add varargs function: secret_schema_new vs. secret_schema_newv
* Rename secret_schema_new to secret_schema_newv which
accepts a GHashTable
* Make secret_schema_new accept varargs similar to the
password functions.
* This is useful from vala which supports varargs