dotnet-maestro[bot] [Mon, 8 Jan 2024 20:41:38 +0000 (12:41 -0800)]
[main] Update dependencies from dotnet/installer (#4451)
This pull request updates the following dependencies
[marker]: <> (Begin:
638f1194-0c1a-4d47-eb59-
08d8e4d5099b)
## From https://github.com/dotnet/installer
- **Subscription**:
638f1194-0c1a-4d47-eb59-
08d8e4d5099b
- **Build**:
20240108.1
- **Date Produced**: January 8, 2024 11:47:07 AM UTC
- **Commit**:
7e601e1c0b94986e101c0bd2d45fbf4bb1da909f
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Dotnet.Sdk.Internal**: [from 9.0.100-alpha.1.24055.6 to
9.0.100-alpha.1.24058.1][1]
[1]: https://github.com/dotnet/installer/compare/
ca1439c8ae...
7e601e1c0b
[DependencyUpdate]: <> (End)
[marker]: <> (End:
638f1194-0c1a-4d47-eb59-
08d8e4d5099b)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
kkeirstead [Mon, 8 Jan 2024 20:20:27 +0000 (12:20 -0800)]
Update `ConsoleExporterTests` To Use Updated `RatePayload` (#4454)
It looks like #4324 hadn't run a build in a while, and was checked in
without validating against the new tests in
https://github.com/dotnet/diagnostics/pull/4376 (causing the builds in
main to fail). I don't believe there are any other issues, but this
should give us a fresh build to confirm that.
kkeirstead [Mon, 8 Jan 2024 15:19:34 +0000 (07:19 -0800)]
Add Meter Tags, Instrument Tags, and Scopes to System Diagnostics Metrics (#4324)
dotnet-maestro[bot] [Sun, 7 Jan 2024 23:45:06 +0000 (15:45 -0800)]
[main] Update dependencies from dotnet/installer (#4448)
This pull request updates the following dependencies
[marker]: <> (Begin:
638f1194-0c1a-4d47-eb59-
08d8e4d5099b)
## From https://github.com/dotnet/installer
- **Subscription**:
638f1194-0c1a-4d47-eb59-
08d8e4d5099b
- **Build**:
20240105.6
- **Date Produced**: January 6, 2024 1:22:17 AM UTC
- **Commit**:
ca1439c8ae7f38b51cd0d2c70ba1f747ebf9e035
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Dotnet.Sdk.Internal**: [from 8.0.101-servicing.23614.6 to
9.0.100-alpha.1.24055.6][1]
[1]: https://github.com/dotnet/installer/compare/
461c776642...
ca1439c8ae
[DependencyUpdate]: <> (End)
[marker]: <> (End:
638f1194-0c1a-4d47-eb59-
08d8e4d5099b)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Sat, 6 Jan 2024 18:21:08 +0000 (10:21 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4447)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20240105.1
- **Date Produced**: January 5, 2024 5:52:20 PM UTC
- **Commit**:
ef691e3c401949dab9986a50d8288a6e489f72bb
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24053.1 to 9.0.0-alpha.1.24055.1][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
5f670e45d0...
ef691e3c40
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Noah Falk [Sat, 6 Jan 2024 01:05:29 +0000 (17:05 -0800)]
Add dotnet-counters console exporter tests (#4376)
Today all the testing of the console formatting is mostly manual. This
adds some automated testing of the formatting logic in preparation to
both refactor and make some design changes. The tests should make it
very obvious in the future when the output formatting intentionally
changes.
dotnet-maestro[bot] [Fri, 5 Jan 2024 09:45:06 +0000 (09:45 +0000)]
[main] Update dependencies from dotnet/installer (#4420)
[main] Update dependencies from dotnet/installer
dotnet-maestro[bot] [Fri, 5 Jan 2024 02:12:00 +0000 (02:12 +0000)]
[main] Update dependencies from dotnet/arcade (#4434)
[main] Update dependencies from dotnet/arcade
- Update Versions.props
Latest Microsoft.CodeAnalysis.NetAnalyzers version
- Update Versions.props
Undo previous commit.
- Fix a few things to enable testing against a .NET 9.0 SDK
- Restore single-file version
- Update 7.0 single-file version
dotnet-maestro[bot] [Thu, 4 Jan 2024 18:24:36 +0000 (10:24 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4445)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20240103.1
- **Date Produced**: January 3, 2024 5:53:23 PM UTC
- **Commit**:
5f670e45d060b25d5b07646dfcd94eae31893191
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24052.1 to 9.0.0-alpha.1.24053.1][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
5357f2bafb...
5f670e45d0
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 2 Jan 2024 19:13:02 +0000 (11:13 -0800)]
[main] Update dependencies from dotnet/symstore (#4441)
This pull request updates the following dependencies
[marker]: <> (Begin:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c
- **Build**:
20240101.1
- **Date Produced**: January 1, 2024 6:57:16 PM UTC
- **Commit**:
b26b065af8647262418c1ef4609de690a003bfa3
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.SymbolStore**: [from 1.0.461801 to 1.0.505101][1]
[1]: https://github.com/dotnet/symstore/compare/
a5237ea435...
b26b065af8
[DependencyUpdate]: <> (End)
[marker]: <> (End:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 2 Jan 2024 19:12:14 +0000 (11:12 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4442)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20240102.1
- **Date Produced**: January 2, 2024 8:59:47 AM UTC
- **Commit**:
5357f2bafb9e23858aa57136d38dbb113cdf81a2
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23627.2 to 9.0.0-alpha.1.24052.1][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
2a008ae4f4...
5357f2bafb
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Thu, 28 Dec 2023 01:03:20 +0000 (17:03 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4440)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20231227.2
- **Date Produced**: December 27, 2023 10:37:05 AM UTC
- **Commit**:
2a008ae4f42c0db384db5a4864752b2ff52d720b
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23618.2 to 9.0.0-alpha.1.23627.2][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
c49c1f4e46...
2a008ae4f4
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Mike McLaughlin [Sun, 24 Dec 2023 17:11:22 +0000 (09:11 -0800)]
Don't lock Microsoft.Diagnostics.DebugServices to 7.0 (#4439)
Mike McLaughlin [Sat, 23 Dec 2023 07:53:38 +0000 (23:53 -0800)]
Add CLRMA support to SOS. (#4437)
Add the CLRMA exports on SOS.dll. Implement the CLRMA interfaces on top
of ICrashInfoServices.
Update ICrashInfoService to be more generic and not JSON crash info
specific.
Renamed IManagedException to IException.
Add IStackFrame.GetMethodName replacing Offset/MethodName.
Cleanup/change name of SOSHost.INativeClient
Change TraceError used in extensions lib not to depend on SOS globals
being initialized
dotnet-maestro[bot] [Tue, 19 Dec 2023 18:39:42 +0000 (10:39 -0800)]
[main] Update dependencies from dotnet/symstore (#4435)
This pull request updates the following dependencies
[marker]: <> (Begin:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c
- **Build**:
20231218.1
- **Date Produced**: December 18, 2023 8:30:41 PM UTC
- **Commit**:
a5237ea435a344d9363de492d0374442ff9623ce
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.SymbolStore**: [from 1.0.461101 to 1.0.461801][1]
[1]: https://github.com/dotnet/symstore/compare/
f3e7fb5a0c...
a5237ea435
[DependencyUpdate]: <> (End)
[marker]: <> (End:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 19 Dec 2023 18:39:28 +0000 (10:39 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4436)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20231218.2
- **Date Produced**: December 18, 2023 3:22:39 PM UTC
- **Commit**:
c49c1f4e461b4b57d6d3449671942786bf8fcbb6
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23615.3 to 9.0.0-alpha.1.23618.2][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
ad27491492...
c49c1f4e46
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Sat, 16 Dec 2023 21:03:01 +0000 (13:03 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4433)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20231215.3
- **Date Produced**: December 15, 2023 7:04:58 PM UTC
- **Commit**:
ad274914920e8e51c5269d215a641e592af8182c
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23611.3 to 9.0.0-alpha.1.23615.3][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
2294642997...
ad27491492
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 12 Dec 2023 17:41:07 +0000 (09:41 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4432)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20231211.3
- **Date Produced**: December 11, 2023 10:47:18 PM UTC
- **Commit**:
229464299759d6667e8b907d9c321d31a8dcc123
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23608.1 to 9.0.0-alpha.1.23611.3][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
9e09ace189...
2294642997
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 12 Dec 2023 17:39:36 +0000 (09:39 -0800)]
[main] Update dependencies from dotnet/symstore (#4431)
This pull request updates the following dependencies
[marker]: <> (Begin:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c
- **Build**:
20231211.1
- **Date Produced**: December 11, 2023 6:40:38 PM UTC
- **Commit**:
f3e7fb5a0cf070f32dee1343427c0fed122de49b
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.SymbolStore**: [from 1.0.460401 to 1.0.461101][1]
[1]: https://github.com/dotnet/symstore/compare/
8b17b7a1a0...
f3e7fb5a0c
[DependencyUpdate]: <> (End)
[marker]: <> (End:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Mon, 11 Dec 2023 18:05:47 +0000 (10:05 -0800)]
[main] Update dependencies from dotnet/arcade (#4429)
This pull request updates the following dependencies
[marker]: <> (Begin:
6d3f346d-45bf-4275-0e83-
08d8e40a189f)
## From https://github.com/dotnet/arcade
- **Subscription**:
6d3f346d-45bf-4275-0e83-
08d8e40a189f
- **Build**:
20231207.2
- **Date Produced**: December 7, 2023 11:06:00 PM UTC
- **Commit**:
3faeb9817f465151aa4bbcdb315f0a6170206760
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.23601.1 to
9.0.0-beta.23607.2][1]
- **Microsoft.DotNet.CodeAnalysis**: [from 9.0.0-beta.23601.1 to
9.0.0-beta.23607.2][1]
[1]: https://github.com/dotnet/arcade/compare/
38aa367e01...
3faeb9817f
[DependencyUpdate]: <> (End)
[marker]: <> (End:
6d3f346d-45bf-4275-0e83-
08d8e40a189f)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Sat, 9 Dec 2023 20:20:57 +0000 (12:20 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4428)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20231208.1
- **Date Produced**: December 8, 2023 4:29:38 PM UTC
- **Commit**:
9e09ace1897546ac85dab114a6e1a5b6f773db7a
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23607.1 to 9.0.0-alpha.1.23608.1][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
c7796fc86b...
9e09ace189
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Ella Hathaway [Sat, 9 Dec 2023 02:28:18 +0000 (18:28 -0800)]
Remove Microsoft.SourceBuild.Intermediate from prebuilt baseline (#4427)
Prebuilt detection no longer detects Microsoft.SourceBuild.Intermediates
as prebuilts due to https://github.com/dotnet/arcade/pull/13935.
Addresses https://github.com/dotnet/source-build/issues/3010
dotnet-maestro[bot] [Fri, 8 Dec 2023 19:30:01 +0000 (11:30 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4426)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20231207.1
- **Date Produced**: December 7, 2023 9:26:18 PM UTC
- **Commit**:
c7796fc86b1cc2ad8be7ba7af8e19237d7d65d77
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23565.2 to 9.0.0-alpha.1.23607.1][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
b5ceed90b7...
c7796fc86b
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Jeff Handley [Thu, 7 Dec 2023 21:39:42 +0000 (13:39 -0800)]
Migrate to the Locker GitHub action for locking closed/stale issues/PRs (#4417)
This migrates away from the FabricBot implementation of a scheduled
search over closed issues and adopts the
[Locker](https://github.com/microsoft/vscode-github-triage-actions/?tab=readme-ov-file#locker)
GitHub action authored by the VS Code team.
The updated fabricbot.json was generated via
https://github.com/dotnet/fabricbot-config/pull/83. The workflow file
was implemented and tested at
https://github.com/dotnet/fabricbot-config/blob/main/.github/workflows/locker.yml.
Since this workflow uses the actions/checkout action, we need to ensure
the following GitHub Actions settings are enabled:
1. Allow enterprise, and select non-enterprise, actions and reusable
workflows
2. Allow actions created by GitHub
/cc @wtgodbe
Igor Bagdamyan [Tue, 5 Dec 2023 21:27:40 +0000 (00:27 +0300)]
An additional flag to parallel stacks to include runtime stacks to pstacks command (#4423)
This adds "-r" flag to include Runtime stacks to pstacks output
It will still ignore the frame if it's method is null. It's just a
matter of checking for both Runtime and Managed kinds
Sometimes it might be useful to have those too, for example like in
https://github.com/dotnet/diagnostics/issues/4418 when it is still
useful to know which threads are in locked state
dotnet-maestro[bot] [Tue, 5 Dec 2023 18:29:32 +0000 (10:29 -0800)]
[main] Update dependencies from dotnet/symstore (#4422)
This pull request updates the following dependencies
[marker]: <> (Begin:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c
- **Build**:
20231204.1
- **Date Produced**: December 4, 2023 7:23:41 PM UTC
- **Commit**:
8b17b7a1a0d86d0e748db791b163b2c21a7845c8
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.SymbolStore**: [from 1.0.457701 to 1.0.460401][1]
[1]: https://github.com/dotnet/symstore/compare/
94b6cc6e11...
8b17b7a1a0
[DependencyUpdate]: <> (End)
[marker]: <> (End:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Mon, 4 Dec 2023 14:13:32 +0000 (14:13 +0000)]
[main] Update dependencies from dotnet/arcade (#4419)
[main] Update dependencies from dotnet/arcade
Igor Bagdamyan [Sun, 3 Dec 2023 14:38:08 +0000 (17:38 +0300)]
Added dump referenced objects command (#4416)
This is something I've found useful in my latest investigation. I've
encountered a cache in the library we've used which happened ot be a
"dominator" e.g. referenced many many objects. It was useful to know
which objects were referenced. I think it can also be generally applied
to get information on how much stuff a single object is transivitely
referencing.
I wanted to make a DumpDominators command to automate such analysis
(e.g. find objects that keep many other objects alive) but I'm still not
sure how to do it. Calculations can take forever and there is a need to
filter out objects that aren't really interesting (e.g. it has no sense
to report static root as a dominator, it's obvious).
Also added an option to limit gcroots count as there were 403 roots of
an object I tried to analyze. Generally I don't think there is a need to
print that many roots so a limiting option is quite welcome.
Feel free to close this if you don't think this is helpful or have other
future plans of similar work
dotnet-maestro[bot] [Fri, 1 Dec 2023 22:15:53 +0000 (22:15 +0000)]
[main] Update dependencies from dotnet/arcade (#4407)
[main] Update dependencies from dotnet/arcade
- Update aspnetcore versions
dotnet-maestro[bot] [Tue, 28 Nov 2023 14:27:43 +0000 (14:27 +0000)]
[main] Update dependencies from dotnet/symstore (#4414)
[main] Update dependencies from dotnet/symstore
Tom McDonald [Wed, 22 Nov 2023 21:25:46 +0000 (16:25 -0500)]
Provide better error messages for IPC connect failures (#4406)
Dan Espinosa [Wed, 22 Nov 2023 07:41:31 +0000 (23:41 -0800)]
validate that providers are > 0 to provide clear error when using Diagnostics Client (#4411)
validate that providers are > 0 otherwise START Failed 0x80131384 get…s
thrown and it's not clear what the issue is.
The current behavior when an empty list of providers is provided is to
throw START Failed 0x80131384 (BadEncoding) and that doesn't make it
very clear about what the issue is. This PR proposes validating the
number of providers so developers know that they should be providing 1
provider at least.
Before:
<img width="677" alt="image"
src="https://github.com/dotnet/diagnostics/assets/
30415120/
0dfe0963-97ae-4f1a-8ce5-
46b992b55428">
After:
<img width="679" alt="image"
src="https://github.com/dotnet/diagnostics/assets/
30415120/
f171687b-eaa5-4bbb-945c-
16a43f4b97b0">
Co-authored-by: Daniel Espinosa <luespino@microsoft.com>
dotnet-maestro[bot] [Tue, 21 Nov 2023 17:58:15 +0000 (09:58 -0800)]
[main] Update dependencies from microsoft/clrmd (#4409)
This pull request updates the following dependencies
[marker]: <> (Begin:
cb58fe07-ae24-4e73-0e84-
08d8e40a189f)
## From https://github.com/microsoft/clrmd
- **Subscription**:
cb58fe07-ae24-4e73-0e84-
08d8e40a189f
- **Build**:
20231120.1
- **Date Produced**: November 20, 2023 6:34:45 PM UTC
- **Commit**:
b9b01f21c353f59908b1563e1f17831eaad41b28
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Diagnostics.Runtime**: [from 3.1.456501 to 3.1.457001][1]
- **Microsoft.Diagnostics.Runtime.Utilities**: [from 3.1.456501 to
3.1.457001][1]
[1]: https://github.com/microsoft/clrmd/compare/
49b694dbf8...
b9b01f21c3
[DependencyUpdate]: <> (End)
[marker]: <> (End:
cb58fe07-ae24-4e73-0e84-
08d8e40a189f)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 21 Nov 2023 14:24:09 +0000 (14:24 +0000)]
[main] Update dependencies from dotnet/symstore (#4410)
[main] Update dependencies from dotnet/symstore
Eugene Zhirov [Tue, 21 Nov 2023 08:27:55 +0000 (09:27 +0100)]
Add RequestStackwalk parameter to EventPipeSession (#4290)
Client-side of https://github.com/dotnet/runtime/pull/84077 and the
implementation of https://github.com/dotnet/diagnostics/issues/3696.
To simplify the interface I made `EventPipeSessionConfiguration` public
and introduced a new method in the DiagnosticsClient:
`Task<EventPipeSession>
StartEventPipeSessionAsync(EventPipeSessionConfiguration configuration,
CancellationToken token)`. This is the only method that supports
disabling the stackwalk so no additional overloads with a new bool
parameter and no synchronous counterpart. I believe it'd be easier to
use and maintain a single async method with the options rather than
creating more overloads or default parameters but I may not have all the
context here so please correct me if you think it's a bad idea.
To deal with the backward compatibility I only use `CollectTracingV3`
when necessary i.e. when `RequestStackwalk` option is set to false. I
think it's a good compromise between the added complexity and
potentially surprising behavior:
* when the client is old and the runtime is new everything works because
the runtime supports `CollectTracingV2`
* when the client is new but the runtime is old everything works until
the new option is used. When it's used the session won't start as
`CollectTracingV3` doesn't exist server side: there'd be no clear error
message but it's documented in the option summary.
* when both the client and the runtime are new either `CollectTracingV2`
or `CollectTracingV3` may be used transparently for the user
* we may use the same trick when we introduce `CollectTracingV4`
The alternative is to implement version negotiation of some sort but I'd
like to have your opinion before attempting this as handling the errors
correctly wouldn't be easy (f.e. in [my current
fork](https://github.com/criteo-forks/diagnostics/commit/
3946b4a88bbb08cdbbf4e71364fd46d32c4ab3dc#diff-e8365039cd36eae3dec611784fc7076be7dadeda1007733412aaaa63f40a748fR39)
I just hide the exception)
The testing turned out to be a bit complex as I needed to convert
EventPipe stream to `TraceLog` to be able to read the stacktraces. I
couldn't achieve that without writing data to a file. Afaiu the
stackwalk may not work correctly without the rundown that only happens
at the end of the session so I wonder if looking at the stacktraces with
a live session is even possible (though iirc netfw+ETW could do that
back in the days) ?
Thanks for your time !
Evgeny Morozov [Tue, 21 Nov 2023 08:20:03 +0000 (09:20 +0100)]
Make DiagnosticsClient.StartEventPipeSessionAsync public (#4394)
This allows user code to pass a cancellation token without wrapping the
call to StartEventPipeSession() in Task.Run() or similar. Resolves
#3727.
dotnet-maestro[bot] [Mon, 20 Nov 2023 14:20:10 +0000 (14:20 +0000)]
[main] Update dependencies from dotnet/installer (#4408)
[main] Update dependencies from dotnet/installer
dotnet-maestro[bot] [Thu, 16 Nov 2023 18:39:38 +0000 (18:39 +0000)]
[main] Update dependencies from dotnet/installer (#4374)
[main] Update dependencies from dotnet/installer
- Update Versions.props
dotnet-maestro[bot] [Thu, 16 Nov 2023 15:03:27 +0000 (15:03 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4405)
[main] Update dependencies from dotnet/source-build-reference-packages
dotnet-maestro[bot] [Thu, 16 Nov 2023 14:29:14 +0000 (14:29 +0000)]
[main] Update dependencies from microsoft/clrmd (#4404)
[main] Update dependencies from microsoft/clrmd
dotnet-maestro[bot] [Wed, 15 Nov 2023 14:46:55 +0000 (14:46 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4400)
[main] Update dependencies from dotnet/source-build-reference-packages
dotnet-maestro[bot] [Wed, 15 Nov 2023 14:23:45 +0000 (14:23 +0000)]
[main] Update dependencies from microsoft/clrmd (#4399)
[main] Update dependencies from microsoft/clrmd
dotnet-maestro[bot] [Tue, 14 Nov 2023 18:07:54 +0000 (10:07 -0800)]
[main] Update dependencies from dotnet/symstore (#4396)
This pull request updates the following dependencies
[marker]: <> (Begin:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c
- **Build**:
20231113.1
- **Date Produced**: November 13, 2023 6:49:55 PM UTC
- **Commit**:
ea785d63ff10aac8d882cc2c0bd22d5c1cb554fa
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.SymbolStore**: [from 1.0.455601 to 1.0.456301][1]
[1]: https://github.com/dotnet/symstore/compare/
18ccf59197...
ea785d63ff
[DependencyUpdate]: <> (End)
[marker]: <> (End:
678f7c5b-6647-4e77-0d75-
08d8e40a4c7c)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 14 Nov 2023 14:35:30 +0000 (14:35 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4397)
[main] Update dependencies from dotnet/source-build-reference-packages
mikelle-rogers [Tue, 14 Nov 2023 00:11:36 +0000 (16:11 -0800)]
Universal Time formatting (#4389)
In dotnet-counters JSON Exporter, change time formatting to universal
time formatting. Fixes #3905
dotnet-maestro[bot] [Mon, 13 Nov 2023 18:47:33 +0000 (18:47 +0000)]
[main] Update dependencies from dotnet/arcade (#4393)
[main] Update dependencies from dotnet/arcade
dotnet-maestro[bot] [Sun, 12 Nov 2023 02:28:40 +0000 (02:28 +0000)]
[main] Update dependencies from microsoft/clrmd (#4392)
[main] Update dependencies from microsoft/clrmd
- Manually bump version
dotnet-maestro[bot] [Thu, 9 Nov 2023 14:34:20 +0000 (14:34 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4391)
[main] Update dependencies from dotnet/source-build-reference-packages
Mikhail Kurinnoi [Wed, 8 Nov 2023 01:17:14 +0000 (04:17 +0300)]
[RISC-V] Implement SOS related code. (#4385)
Implement ICorDebug related `clrstack -i`.
Implement `clrstack -r` output.
Related PR in runtime: https://github.com/dotnet/runtime/pull/94454
```
> clrstack
OS Thread Id: 0x40614 (0)
Child SP IP Call Site
0000003FCBDD6F70 0000000000000000 [InlinedCallFrame:
0000003fcbdd6f70] Interop+Sys.<ReadStdin>g____PInvoke|44_0(Byte*, Int32)
0000003FCBDD6F70 0000003f32be5758 [InlinedCallFrame:
0000003fcbdd6f70] Interop+Sys.<ReadStdin>g____PInvoke|44_0(Byte*, Int32)
0000003FCBDD6F50 0000003F32BE5758 ILStubClass.IL_STUB_PInvoke(Byte*, Int32)
0000003FCBDD7050 0000003F32BE55BC Interop+Sys.ReadStdin(Byte*, Int32) [/home/runtime/src/libraries/System.Console/src/Microsoft.Interop.LibraryImportGenerator/Microsoft.Interop.LibraryImportGenerator/LibraryImports.g.cs @ 800]
0000003FCBDD7080 0000003F32BE5464 System.IO.StdInReader.ReadStdin(Byte*, Int32) [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 83]
0000003FCBDD70B0 0000003F32BE4FBC System.IO.StdInReader.ReadKey() [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 337]
0000003FCBDD7560 0000003F32BE3A24 System.IO.StdInReader.ReadLineCore(Boolean) [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 160]
0000003FCBDD7740 0000003F32BE3694 System.IO.StdInReader.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 90]
0000003FCBDD77A0 0000003F32BE353C System.IO.SyncTextReader.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/IO/SyncTextReader.cs @ 77]
0000003FCBDD77F0 0000003F32BE144C System.Console.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/Console.cs @ 752]
0000003FCBDD7820 0000003F32B9DFD0 TestApp.Program.Main(System.String[]) [/home/viewizard/Desktop/projects_test/test_hr/Program.cs @ 11]
```
```
> clrstack -i
Dumping managed stack and managed variables using ICorDebug.
=============================================================================
Child SP IP Call Site
0000003FCBDD6EF0 0000000000000000 [NativeStackFrame]
0000003FCBDD6F50 0000003f32be5758 0000003FCBDD6F70 (null) [Managed to Unmanaged transition:
0000003FCBDD6F70]
0000003FCBDD7050 0000003f32be55bc [DEFAULT] I4 Interop+Sys.ReadStdin(Ptr UI1,I4) (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD7080 0000003f32be5464 [DEFAULT] I4 System.IO.StdInReader.ReadStdin(Ptr UI1,I4) (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD70B0 0000003f32be4fbc [DEFAULT] [hasThis] ValueClass System.ConsoleKeyInfo System.IO.StdInReader.ReadKey() (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD7560 0000003f32be3a24 [DEFAULT] [hasThis] Boolean System.IO.StdInReader.ReadLineCore(Boolean) (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD7740 0000003f32be3694 [DEFAULT] [hasThis] String System.IO.StdInReader.ReadLine() (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD77A0 0000003f32be353c [DEFAULT] [hasThis] String System.IO.SyncTextReader.ReadLine() (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD77F0 0000003f32be144c [DEFAULT] String System.Console.ReadLine() (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD7820 0000003f32b9dfd0 [DEFAULT] Void TestApp.Program.Main(SZArray String) (/home/mkurinnoi/test_hr.dll)
0000003FCBDD7850 0000003fb1e2307e [NativeStackFrame]
Stack walk complete.
=============================================================================
```
CC @clamp03 @wscho77 @HJLeee @JongHeonChoi @t-mustafin @gbalykov
Mike McLaughlin [Tue, 7 Nov 2023 16:55:53 +0000 (08:55 -0800)]
Fix DumpStackObjects <bounds> error (#4384)
dotnet-maestro[bot] [Tue, 7 Nov 2023 14:26:42 +0000 (14:26 +0000)]
[main] Update dependencies from dotnet/symstore (#4386)
[main] Update dependencies from dotnet/symstore
dotnet-maestro[bot] [Tue, 7 Nov 2023 14:20:07 +0000 (14:20 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4387)
[main] Update dependencies from dotnet/source-build-reference-packages
dotnet-maestro[bot] [Mon, 6 Nov 2023 14:13:47 +0000 (14:13 +0000)]
[main] Update dependencies from dotnet/arcade (#4383)
[main] Update dependencies from dotnet/arcade
dotnet-maestro[bot] [Sat, 4 Nov 2023 13:22:51 +0000 (13:22 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4382)
[main] Update dependencies from dotnet/source-build-reference-packages
dotnet-maestro[bot] [Fri, 3 Nov 2023 13:05:33 +0000 (13:05 +0000)]
[main] Update dependencies from dotnet/symstore (#4381)
[main] Update dependencies from dotnet/symstore
Mitchell Hwang [Thu, 2 Nov 2023 23:07:01 +0000 (19:07 -0400)]
[tools][trace] Add stopping event options to dotnet-trace (#4363)
Fixes https://github.com/dotnet/diagnostics/issues/3125
This PR provides users another method to stop a dotnet-trace via a
stopping event similar to that of dotnet-monitor, originally implemented
in https://github.com/dotnet/dotnet-monitor/pull/2557.
Three arguments are added to the `dotnet-trace collect` command to
specify a stopping event:
| Argument | Description |
|----------|----------|
|`--stopping-event-provider-name` | A string, parsed as-is, that will
stop the trace upon hitting an event with the matching provider name.
For a more specific stopping event, additionally provide
`--stopping-event-event-name` and/or `--stopping-event-payload-filter`.
|
| `--stopping-event-event-name` | A string, parsed as-is, that will stop
the trace upon hitting an event with the matching event name. Requires
`--stopping-event-provider-name` to be set. For a more specific stopping
event, additionally provide `--stopping-event-payload-filter`. |
| `--stopping-event-payload-filter` | A string, parsed as
[payload_field_name]:[payload_field_value] pairs separated by commas,
that will stop the trace upon hitting an event with a matching payload.
Requires `--stopping-event-provider-name` and
`--stopping-event-event-name` to be set. |
Note: Though technically `--stopping-event-payload-filter` can be set
without needing a `--stopping-event-event-name`, this may lead to
mismatched payloads should another `TraceEvent` under the same provider
not have that particular payload field name. Until there is a good
reason to stop a trace given a payload filter regardless of the event
name, we require `--stopping-event-event-name` to be set whenever
`--stopping-event-payload-filter` is provided.
To stop a trace at a particular event, dotnet-monitor's
[approach](https://github.com/dotnet/dotnet-monitor/blob/
0820b6911f3ac47b6b5ec867ac906699e5c15787/src/Tools/dotnet-monitor/Trace/TraceUntilEventOperation.cs#L47)
using an
[EventMonitor](https://github.com/dotnet/diagnostics/blob/main/src/Microsoft.Diagnostics.Monitoring.EventPipe/EventMonitor.cs)
is adopted. Upon hitting a TraceEvent with a matching ProviderName,
EventName (if specified), and PayloadFilter (if specified), we trigger
dotnet-trace's fallback logic to stop the EventPipeSession before the
EventStream ends.
Note: As the EventStream is being parsed asynchronously, there will be
some events that pass through between the time a trace event matching
the specified stopping event arguments is parsed and the
EventPipeSession is stopped.
In addition, this PR modifies `EventMonitor` to use the
`ClrTraceEventParser` to parse `TraceEvent` objects under the
`Microsoft-Windows-DotNETRuntime` provider, and the
`DynamicTraceEventParser` otherwise. The `ClrTraceEventParser` is
generated to understand the ETW event manifest for
`Microsoft-Windows-DotNETRuntime` events. The previous implementation
defaulting to `DynamicTraceEventParser` would not work on non-Windows
platforms such as OSX which could not parse the payload to populate
`PayloadNames` and `PayloadValue(i)` because there was no manifest
available. On the other hand, Windows is able to locate manifest data
for known events through the OS.
-------------------
## Testing
With an Android App
``` C#
private static void PrintA()
{
Console.WriteLine("A");
Thread.Sleep(1000);
}
...
private static void PrintK()
{
Console.WriteLine("K");
Thread.Sleep(1000);
}
public static void Main(string[] args)
{
Console.WriteLine("Hello, Android!"); // logcat
PrintA();
PrintB();
PrintC();
PrintD();
PrintE();
PrintF();
PrintG();
PrintH();
PrintI();
PrintJ();
PrintK();
while (true)
{
Thread.Sleep(100);
}
}
```
Running dotnet-dsrouter to connect the diagnostic tooling with the
android device
`./artifacts/bin/dotnet-dsrouter/Debug/net6.0/dotnet-dsrouter android -v
debug`
Tracing with a stopping event args provided
`./artifacts/bin/dotnet-trace/Debug/net6.0/dotnet-trace collect -p 16683
--providers Microsoft-Windows-DotNETRuntime:0x1F000080018:5
--stopping-event-provider-name Microsoft-Windows-DotNETRuntime
--stopping-event-event-name Method/JittingStarted
--stopping-event-payload-filter MethodName:PrintA`
[dotnet-dsrouter_20231024_165648.nettrace.zip](https://github.com/dotnet/diagnostics/files/
13147788/dotnet-dsrouter_20231024_165648.nettrace.zip)
There are no `Method/JittingStarted` events with MethodName `PrintC`
through `PrintK` in the `.nettrace`, showing that the trace was indeed
stopped after seeing the `PrintA` event. The events after `PrintA` are
an artifact of the second note above. Below is the JITStats of the
.nettrace opened in perfview, showing that the last method was `PrintB`.
<img width="1128" alt="JITStatsPrintA"
src="https://github.com/dotnet/diagnostics/assets/
16830051/
1742baf4-b528-43c3-aef3-
b00a576f2fb8">
dotnet-maestro[bot] [Thu, 2 Nov 2023 13:20:41 +0000 (13:20 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4380)
[main] Update dependencies from dotnet/source-build-reference-packages
Lee Culver [Tue, 31 Oct 2023 22:26:48 +0000 (15:26 -0700)]
Allow ` in hex strings (#4379)
Update extension command parsing to allow a single \` in the middle of
addresses. We allow "\`0123" because the user might have copied the \`
marker in "0000\`0123". This makes commands more consistent since the
C++ based SOS commands allow for \` in the addresses.
Updated a location where we didn't use TryParseAddress but should have.
Feature request from the GC team.
Mikhail Kurinnoi [Tue, 31 Oct 2023 15:39:59 +0000 (18:39 +0300)]
[RISC-V] Add partial SOS 'clrstack' command implementation. (#4356)
Changes:
- add partial SOS 'clrstack' command implementation;
- add more RISC-V related code (some still not tested or NYI, but need
for proper SOS build);
This changes allow start and use dotnet-dump+SOS with current runtime
upstream on RISC-V board:
```
mkurinnoi@starfive:~$ ./dotnet/corerun ./tools/dotnet-dump.dll ps
221935 corerun /home/mkurinnoi/dotnet/corerun ./dotnet/corerun ./test_hr.dll
mkurinnoi@starfive:~$ ./dotnet/corerun ./tools/dotnet-dump.dll collect --process-id 221935
Writing full to /home/mkurinnoi/core_20231024_104410
Complete
mkurinnoi@starfive:~$ ./dotnet/corerun ./tools/dotnet-dump.dll analyze /home/mkurinnoi/core_20231024_104410
Loading core dump: /home/mkurinnoi/core_20231024_104410 ...
Ready to process analysis commands. Type 'help' to list available commands or 'help [command]' to get detailed help on a command.
Type 'quit' or 'exit' to exit the session.
> clrstack
OS Thread Id: 0x362ef (0)
Child SP IP Call Site
0000003FD9F44F70 0000000000000000 [InlinedCallFrame:
0000003fd9f44f70] Interop+Sys.<ReadStdin>g____PInvoke|44_0(Byte*, Int32)
0000003FD9F44F70 0000003f353b5370 [InlinedCallFrame:
0000003fd9f44f70] Interop+Sys.<ReadStdin>g____PInvoke|44_0(Byte*, Int32)
0000003FD9F44F50 0000003F353B5370 ILStubClass.IL_STUB_PInvoke(Byte*, Int32)
0000003FD9F45050 0000003F353B51D4 Interop+Sys.ReadStdin(Byte*, Int32) [/home/runtime/src/libraries/System.Console/src/Microsoft.Interop.LibraryImportGenerator/Microsoft.Interop.LibraryImportGenerator/LibraryImports.g.cs @ 800]
0000003FD9F45080 0000003F353B507C System.IO.StdInReader.ReadStdin(Byte*, Int32) [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 83]
0000003FD9F450B0 0000003F353B4BD4 System.IO.StdInReader.ReadKey() [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 337]
0000003FD9F45560 0000003F353B363C System.IO.StdInReader.ReadLineCore(Boolean) [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 160]
0000003FD9F45740 0000003F353B32AC System.IO.StdInReader.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 90]
0000003FD9F457A0 0000003F353B3154 System.IO.SyncTextReader.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/IO/SyncTextReader.cs @ 77]
0000003FD9F457F0 0000003F353B1064 System.Console.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/Console.cs @ 752]
0000003FD9F45820 0000003F3536DF10 TestApp.Program.Main(System.String[]) [/home/viewizard/Desktop/projects_test/test_hr/Program.cs @ 11]
> q
```
Note, I only start SOS commands implementation for RISC-V (almost
nothing work now).
CC @clamp03 @wscho77 @HJLeee @JongHeonChoi @t-mustafin @gbalykov
dotnet-maestro[bot] [Tue, 31 Oct 2023 13:39:10 +0000 (13:39 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4377)
[main] Update dependencies from dotnet/source-build-reference-packages
dotnet-maestro[bot] [Mon, 30 Oct 2023 13:23:50 +0000 (13:23 +0000)]
[main] Update dependencies from dotnet/arcade (#4373)
[main] Update dependencies from dotnet/arcade
dotnet-maestro[bot] [Sat, 28 Oct 2023 13:27:04 +0000 (13:27 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4372)
[main] Update dependencies from dotnet/source-build-reference-packages
dotnet-maestro[bot] [Thu, 26 Oct 2023 16:57:58 +0000 (09:57 -0700)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4367)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20231025.1
- **Date Produced**: October 25, 2023 9:35:01 PM UTC
- **Commit**:
93a261562a815434ceaae0e3c5c15fb6e457f9c4
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23523.4 to 9.0.0-alpha.1.23525.1][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
c397c475b3...
93a261562a
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Wed, 25 Oct 2023 13:21:58 +0000 (13:21 +0000)]
[main] Update dependencies from dotnet/runtime (#4366)
[main] Update dependencies from dotnet/runtime
dotnet-maestro[bot] [Wed, 25 Oct 2023 13:20:40 +0000 (13:20 +0000)]
[main] Update dependencies from dotnet/aspnetcore (#4364)
[main] Update dependencies from dotnet/aspnetcore
dotnet-maestro[bot] [Wed, 25 Oct 2023 13:06:06 +0000 (13:06 +0000)]
[main] Update dependencies from microsoft/clrmd (#4365)
[main] Update dependencies from microsoft/clrmd
Mike McLaughlin [Tue, 24 Oct 2023 23:09:57 +0000 (16:09 -0700)]
Update Versions.props (#4362)
Lee Culver [Tue, 24 Oct 2023 16:46:31 +0000 (09:46 -0700)]
Restore error message when the heap isn't walkable (#4361)
!dumpheap and !verifyheap used to warn you that the GC Heap was not
walkable. That error was lost when I converted the code from C++ to C#.
Added a way to override the error so that it doesn't become blocking
when we still want to validate or dump the parts of the heap that we
can.
dotnet-maestro[bot] [Tue, 24 Oct 2023 15:37:55 +0000 (08:37 -0700)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4360)
This pull request updates the following dependencies
[marker]: <> (Begin:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**:
8fefa124-13dd-4c66-7dae-
08d9c02d7834
- **Build**:
20231023.4
- **Date Produced**: October 23, 2023 7:46:43 PM UTC
- **Commit**:
c397c475b357738fbbf535f5c5ffb4d87c20aed0
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23519.2 to 9.0.0-alpha.1.23523.4][1]
[1]:
https://github.com/dotnet/source-build-reference-packages/compare/
d3fbf3c3d4...
c397c475b3
[DependencyUpdate]: <> (End)
[marker]: <> (End:
8fefa124-13dd-4c66-7dae-
08d9c02d7834)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 24 Oct 2023 13:19:25 +0000 (13:19 +0000)]
[main] Update dependencies from dotnet/runtime (#4359)
[main] Update dependencies from dotnet/runtime
dotnet-maestro[bot] [Tue, 24 Oct 2023 13:19:14 +0000 (13:19 +0000)]
[main] Update dependencies from dotnet/symstore (#4358)
[main] Update dependencies from dotnet/symstore
dotnet-maestro[bot] [Tue, 24 Oct 2023 13:18:37 +0000 (13:18 +0000)]
[main] Update dependencies from dotnet/aspnetcore (#4357)
[main] Update dependencies from dotnet/aspnetcore
Johan Lorensson [Mon, 23 Oct 2023 23:48:53 +0000 (01:48 +0200)]
Handle sessionId as ulong instead of long in EventPipeSession.cs. (#4345)
Session id is a uint64 in runtime as well as specified as a uint64 in
IPC protocol,
https://github.com/dotnet/diagnostics/blob/main/documentation/design-docs/ipc-protocol.md#returns-as-an-ipc-message-payload.
EventPipeSession.cs however handled it as a long instead of an ulong,
currently that doesn't affect release builds since it doesn't do much
with the id except passing it back to stop the session, but in debug
builds there is an assert that validates that session id > 0. On Android
physical devices it is not uncommon to get code and memory allocated at
high addresses, including having the high order bit set and when that
happens, EventPipeSession.cs will see a negative session id and assert
on debug builds.
Fix adjust session id as ulong inline with IPC protocol, it also makes
sure keyword serialized when starting a session is handled according to
IPC specification, but only when serialized into the payload, it will
still be typed as long inside EventPipeProvider since it is a public
property.
Johan Lorensson [Mon, 23 Oct 2023 23:46:55 +0000 (01:46 +0200)]
Fix ModuleLoadUnloadTraceData.ModuleID cast to be unchecked since its really a ulong member. (#4354)
The ModuleLoadUnload events ModuleID is typed as a uint64 in the
EventPipe manifest and emitted as a uint64 in the event payload.
However, the parsing logic in ModuleLoadUnloadTraceDataevent in trace
event:
https://github.com/microsoft/perfview/blob/
a6c87911fe1aef8f59c9ce54aa4e16a1be6db91e/src/TraceEvent/Parsers/ClrEtwAll.cs.base#L4963
handles it as a long. Android devices running arm64 can use pointer
tagging meaning that high bits can be set in 64-bit addresses and since
module id is a memory address, it will be returned as a negative long
from ModuleLoadUnload event and since all diagnostic tooling is build
with overflow checking enabled by default, casting it to a ulong will
trigger and overflow exception when high bit is set.
Fix is to do an unchecked cast in this case since the value should be
threated as a ulong in first place.
Fixes https://github.com/dotnet/diagnostics/issues/4348.
dotnet-maestro[bot] [Mon, 23 Oct 2023 20:08:02 +0000 (20:08 +0000)]
[main] Update dependencies from dotnet/installer (#4353)
[main] Update dependencies from dotnet/installer
- Update Versions.props
Mike McLaughlin [Mon, 23 Oct 2023 17:31:13 +0000 (10:31 -0700)]
Update Native AOT crash info with module base address (#4351)
dotnet-maestro[bot] [Mon, 23 Oct 2023 13:24:08 +0000 (13:24 +0000)]
[main] Update dependencies from dotnet/arcade (#4352)
[main] Update dependencies from dotnet/arcade
dotnet-maestro[bot] [Sat, 21 Oct 2023 13:13:37 +0000 (13:13 +0000)]
[main] Update dependencies from dotnet/aspnetcore (#4349)
[main] Update dependencies from dotnet/aspnetcore
dotnet-maestro[bot] [Sat, 21 Oct 2023 13:09:38 +0000 (13:09 +0000)]
[main] Update dependencies from dotnet/runtime (#4350)
[main] Update dependencies from dotnet/runtime
dotnet-maestro[bot] [Fri, 20 Oct 2023 17:20:43 +0000 (10:20 -0700)]
[main] Update dependencies from dotnet/aspnetcore (#4346)
This pull request updates the following dependencies
[marker]: <> (Begin:
319094f3-ed78-47c4-53e7-
08d8e409d87d)
## From https://github.com/dotnet/aspnetcore
- **Subscription**:
319094f3-ed78-47c4-53e7-
08d8e409d87d
- **Build**:
20231019.14
- **Date Produced**: October 20, 2023 5:00:06 AM UTC
- **Commit**:
e4ba445101d9bdae24baa6b332d19a11ac8922be
- **Branch**: refs/heads/release/8.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23518.6 to
8.0.0-rtm.23519.14][1]
- **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23518.6 to
8.0.0-rtm.23519.14][1]
[1]:
https://github.com/dotnet/aspnetcore/compare/
198857c8a2...
e4ba445101
[DependencyUpdate]: <> (End)
[marker]: <> (End:
319094f3-ed78-47c4-53e7-
08d8e409d87d)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Fri, 20 Oct 2023 13:43:29 +0000 (13:43 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4347)
[main] Update dependencies from dotnet/source-build-reference-packages
mikelle-rogers [Thu, 19 Oct 2023 21:49:51 +0000 (14:49 -0700)]
Retire Duplicate Documentation (#4341)
Retire duplicate documentation by redirecting to docs that will be updated.
fixes #515
---------
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Joe Schmitt [Thu, 19 Oct 2023 18:32:17 +0000 (11:32 -0700)]
Fix log scope construction (#4323)
This PR reworks how log scopes are reconstructed. The current
implementation has a several issues that results in it only working in
single-threaded contexts. Once multiple threads are involved, scopes
will be incorrectly associated to log messages in addition to scopes
being deleted early while they are still active.
I've described how the new approach works in the source code so it
doesn't get lost after this PR is merged. I've also left a comment with
a visual representation of edge cases with concurrent traces.
/cc @dotnet/dotnet-monitor
---------
Co-authored-by: Wiktor Kopec <wiktork@microsoft.com>
Johan Lorensson [Thu, 19 Oct 2023 16:55:27 +0000 (18:55 +0200)]
Fix dotnet-dsrouter Android port reverse local/remote ports. (#4342)
The use of automatic port forwarding on Android device used the same
port as local and remote, that should be possible, but turns out there
is some issue with `adb` around that configuration when running against
a physical Android device (works when using port forwarding/reverse
against Android emulator).
This PR change the port defaults and align to Xamarin Android
documentation as well as using different ports for local and remove when
using -`tcps` or -`tcpc` arguments together with `--forward-port
android`.
When running using the "Android" connect profile, `dotnet-dsrouter
android` we will default to 9001 as local/host and 9000 as remote/device
port.
When running with -`tcps` or -`tcpc` we will use passed port as
local/host port and then set the remote/device port to local/host port -
1 in call to `adb reverse|forward`.
Fixes https://github.com/dotnet/diagnostics/issues/4337
dotnet-maestro[bot] [Thu, 19 Oct 2023 16:10:58 +0000 (09:10 -0700)]
[main] Update dependencies from dotnet/aspnetcore (#4343)
This pull request updates the following dependencies
[marker]: <> (Begin:
319094f3-ed78-47c4-53e7-
08d8e409d87d)
## From https://github.com/dotnet/aspnetcore
- **Subscription**:
319094f3-ed78-47c4-53e7-
08d8e409d87d
- **Build**:
20231018.6
- **Date Produced**: October 18, 2023 11:05:03 PM UTC
- **Commit**:
198857c8a2211931739e6e08facfbab52f8dd023
- **Branch**: refs/heads/release/8.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23517.6 to
8.0.0-rtm.23518.6][1]
- **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23517.6 to
8.0.0-rtm.23518.6][1]
[1]:
https://github.com/dotnet/aspnetcore/compare/
e3aba084cd...
198857c8a2
[DependencyUpdate]: <> (End)
[marker]: <> (End:
319094f3-ed78-47c4-53e7-
08d8e409d87d)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Thu, 19 Oct 2023 16:10:46 +0000 (09:10 -0700)]
[main] Update dependencies from dotnet/runtime (#4344)
This pull request updates the following dependencies
[marker]: <> (Begin:
e4bfb556-e13c-47f6-eb5a-
08d8e4d5099b)
## From https://github.com/dotnet/runtime
- **Subscription**:
e4bfb556-e13c-47f6-eb5a-
08d8e4d5099b
- **Build**:
20231018.26
- **Date Produced**: October 19, 2023 7:20:11 AM UTC
- **Commit**:
c6e7ebdcb1b99c72990ae9f5ff95a75d5bb0f3ce
- **Branch**: refs/heads/release/8.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 8.0.0-rtm.23517.16 to
8.0.0-rtm.23518.26][1]
- **VS.Redist.Common.NetCore.SharedFramework.x64.8.0**: [from
8.0.0-rtm.23517.16 to 8.0.0-rtm.23518.26][1]
[1]: https://github.com/dotnet/runtime/compare/
6f7af556d2...
c6e7ebdcb1
[DependencyUpdate]: <> (End)
[marker]: <> (End:
e4bfb556-e13c-47f6-eb5a-
08d8e4d5099b)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Wed, 18 Oct 2023 16:49:10 +0000 (09:49 -0700)]
[main] Update dependencies from dotnet/aspnetcore (#4338)
This pull request updates the following dependencies
[marker]: <> (Begin:
319094f3-ed78-47c4-53e7-
08d8e409d87d)
## From https://github.com/dotnet/aspnetcore
- **Subscription**:
319094f3-ed78-47c4-53e7-
08d8e409d87d
- **Build**:
20231017.6
- **Date Produced**: October 17, 2023 5:56:46 PM UTC
- **Commit**:
e3aba084cde27f8e718b188e3e9f7239e63d5816
- **Branch**: refs/heads/release/8.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23516.6 to
8.0.0-rtm.23517.6][1]
- **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23516.6 to
8.0.0-rtm.23517.6][1]
[1]:
https://github.com/dotnet/aspnetcore/compare/
02bdf7077b...
e3aba084cd
[DependencyUpdate]: <> (End)
[marker]: <> (End:
319094f3-ed78-47c4-53e7-
08d8e409d87d)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Wed, 18 Oct 2023 13:28:42 +0000 (13:28 +0000)]
[main] Update dependencies from dotnet/runtime (#4340)
[main] Update dependencies from dotnet/runtime
dotnet-maestro[bot] [Wed, 18 Oct 2023 13:23:05 +0000 (13:23 +0000)]
[main] Update dependencies from microsoft/clrmd (#4339)
[main] Update dependencies from microsoft/clrmd
kkeirstead [Tue, 17 Oct 2023 20:59:18 +0000 (13:59 -0700)]
[Dotnet Monitor] Small Fix For SDM Triggers (#4332)
Small bug fix on the dotnet-monitor side from the unification work - we
previously didn't create a payload for `BeginInstrumentReporting`, and
thus only checked that a payload wasn't an error or the end of a
counter. The code now leverages the newly-added `IsValuePublishedEvent`
from the unification to only apply to the correct payloads.
dotnet-maestro[bot] [Tue, 17 Oct 2023 15:33:59 +0000 (08:33 -0700)]
[main] Update dependencies from dotnet/aspnetcore (#4333)
This pull request updates the following dependencies
[marker]: <> (Begin:
319094f3-ed78-47c4-53e7-
08d8e409d87d)
## From https://github.com/dotnet/aspnetcore
- **Subscription**:
319094f3-ed78-47c4-53e7-
08d8e409d87d
- **Build**:
20231016.6
- **Date Produced**: October 16, 2023 8:00:36 PM UTC
- **Commit**:
02bdf7077b8d96039bd39d6189a1abdefc41e65e
- **Branch**: refs/heads/release/8.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.AspNetCore.App.Ref**: [from 8.0.0-rtm.23514.1 to
8.0.0-rtm.23516.6][1]
- **Microsoft.AspNetCore.App.Ref.Internal**: [from 8.0.0-rtm.23514.1 to
8.0.0-rtm.23516.6][1]
[1]:
https://github.com/dotnet/aspnetcore/compare/
faf594a066...
02bdf7077b
[DependencyUpdate]: <> (End)
[marker]: <> (End:
319094f3-ed78-47c4-53e7-
08d8e409d87d)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Tue, 17 Oct 2023 13:45:57 +0000 (13:45 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4336)
[main] Update dependencies from dotnet/source-build-reference-packages
dotnet-maestro[bot] [Tue, 17 Oct 2023 13:24:49 +0000 (13:24 +0000)]
[main] Update dependencies from dotnet/runtime (#4335)
[main] Update dependencies from dotnet/runtime
dotnet-maestro[bot] [Tue, 17 Oct 2023 13:24:38 +0000 (13:24 +0000)]
[main] Update dependencies from dotnet/symstore (#4334)
[main] Update dependencies from dotnet/symstore
dotnet-maestro[bot] [Mon, 16 Oct 2023 18:16:41 +0000 (18:16 +0000)]
[main] Update dependencies from dotnet/installer (#4331)
[main] Update dependencies from dotnet/installer
- Update Versions.props
dotnet-maestro[bot] [Mon, 16 Oct 2023 13:24:40 +0000 (13:24 +0000)]
[main] Update dependencies from dotnet/arcade (#4330)
[main] Update dependencies from dotnet/arcade
dotnet-maestro[bot] [Sun, 15 Oct 2023 13:10:32 +0000 (13:10 +0000)]
[main] Update dependencies from dotnet/aspnetcore (#4329)
[main] Update dependencies from dotnet/aspnetcore
Lee Culver [Sat, 14 Oct 2023 16:46:32 +0000 (09:46 -0700)]
Additional !maddress fixes (#4325)
More issues found by the GC team. With this fix the output of !maddress
now exactly lines of with GC data structures.
dotnet-maestro[bot] [Sat, 14 Oct 2023 13:22:52 +0000 (13:22 +0000)]
[main] Update dependencies from dotnet/runtime (#4328)
[main] Update dependencies from dotnet/runtime
dotnet-maestro[bot] [Sat, 14 Oct 2023 13:17:09 +0000 (13:17 +0000)]
[main] Update dependencies from microsoft/clrmd (#4327)
[main] Update dependencies from microsoft/clrmd