platform/upstream/ofono.git
14 years agoFix: Rename Flag
Denis Kenzior [Fri, 23 Oct 2009 01:59:07 +0000 (20:59 -0500)]
Fix: Rename Flag

14 years agoDeactivate the context for removal if active
Denis Kenzior [Fri, 23 Oct 2009 01:32:36 +0000 (20:32 -0500)]
Deactivate the context for removal if active

14 years agoRefactor/Implement basic activate logic
Denis Kenzior [Fri, 23 Oct 2009 00:00:38 +0000 (19:00 -0500)]
Refactor/Implement basic activate logic

Not yet tested

14 years agoAdd stub of gprs context deactivated
Denis Kenzior [Thu, 22 Oct 2009 23:35:44 +0000 (18:35 -0500)]
Add stub of gprs context deactivated

14 years agoFix: Typos
Denis Kenzior [Thu, 22 Oct 2009 23:35:32 +0000 (18:35 -0500)]
Fix: Typos

14 years agoRefactor: Initialization code
Denis Kenzior [Thu, 22 Oct 2009 23:00:33 +0000 (18:00 -0500)]
Refactor: Initialization code

14 years agoAdd GPRS registration status implementation
Denis Kenzior [Thu, 22 Oct 2009 23:00:07 +0000 (18:00 -0500)]
Add GPRS registration status implementation

14 years agoRemove unused code
Denis Kenzior [Thu, 22 Oct 2009 22:56:42 +0000 (17:56 -0500)]
Remove unused code

14 years agoFix: Style
Denis Kenzior [Thu, 22 Oct 2009 22:50:30 +0000 (17:50 -0500)]
Fix: Style

14 years agoRemove unused functions
Denis Kenzior [Thu, 22 Oct 2009 22:50:20 +0000 (17:50 -0500)]
Remove unused functions

14 years agoRefactor: Deactivate all contexts function
Denis Kenzior [Thu, 22 Oct 2009 22:49:49 +0000 (17:49 -0500)]
Refactor: Deactivate all contexts function

14 years agoRemove unused function
Denis Kenzior [Thu, 22 Oct 2009 22:49:36 +0000 (17:49 -0500)]
Remove unused function

14 years agoRefactor: GPRS Remove Context function
Denis Kenzior [Thu, 22 Oct 2009 22:49:22 +0000 (17:49 -0500)]
Refactor: GPRS Remove Context function

14 years agoRefactor: GPRS CreateContext function
Denis Kenzior [Thu, 22 Oct 2009 22:48:39 +0000 (17:48 -0500)]
Refactor: GPRS CreateContext function

14 years agoRemove unused function
Denis Kenzior [Thu, 22 Oct 2009 22:46:50 +0000 (17:46 -0500)]
Remove unused function

14 years agoRefactor: context object path list
Denis Kenzior [Thu, 22 Oct 2009 22:46:10 +0000 (17:46 -0500)]
Refactor: context object path list

14 years agoRefactor: Context set_property function
Denis Kenzior [Thu, 22 Oct 2009 22:44:14 +0000 (17:44 -0500)]
Refactor: Context set_property function

14 years agoRefactor: Context get_properties
Denis Kenzior [Thu, 22 Oct 2009 22:42:40 +0000 (17:42 -0500)]
Refactor: Context get_properties

14 years agoRefactor: context finding by path
Denis Kenzior [Thu, 22 Oct 2009 22:42:01 +0000 (17:42 -0500)]
Refactor: context finding by path

14 years agoRemove unused function
Denis Kenzior [Thu, 22 Oct 2009 22:41:23 +0000 (17:41 -0500)]
Remove unused function

14 years agoAdd CID range function
Denis Kenzior [Thu, 22 Oct 2009 22:39:57 +0000 (17:39 -0500)]
Add CID range function

14 years agoRefactor: Primary Context dbus reg/unreg
Denis Kenzior [Thu, 22 Oct 2009 22:37:39 +0000 (17:37 -0500)]
Refactor: Primary Context dbus reg/unreg

14 years agoRefactor: Use ofono_bool_t instead of int
Denis Kenzior [Thu, 22 Oct 2009 22:23:44 +0000 (17:23 -0500)]
Refactor: Use ofono_bool_t instead of int

14 years agoRefactor: Rename GPRS type enums
Denis Kenzior [Thu, 22 Oct 2009 22:20:50 +0000 (17:20 -0500)]
Refactor: Rename GPRS type enums

14 years agoRefactor: Split up GPRS into two atoms
Denis Kenzior [Thu, 22 Oct 2009 22:14:50 +0000 (17:14 -0500)]
Refactor: Split up GPRS into two atoms

Split up GPRS into two atoms: GPRS and GPRS Context.  GPRS will handle
the areas of GPRS network registration, basic GPRS capability detection
and attach / detach.

GPRS Context will handle setting up / activating / deactivating the
indicidual contexts.

This will allow us to use the generic GPRS atom for most devices while
customizing the GPRS context accordingly.

14 years agoAdd InUse error type
Denis Kenzior [Thu, 22 Oct 2009 22:11:58 +0000 (17:11 -0500)]
Add InUse error type

14 years agoSecond round of renaming
Denis Kenzior [Tue, 20 Oct 2009 21:29:10 +0000 (16:29 -0500)]
Second round of renaming

14 years agoRefactor: First round of renaming
Denis Kenzior [Tue, 20 Oct 2009 18:09:54 +0000 (13:09 -0500)]
Refactor: First round of renaming

14 years agoRefactor: rename data-connection to gprs
Denis Kenzior [Tue, 20 Oct 2009 17:09:46 +0000 (12:09 -0500)]
Refactor: rename data-connection to gprs

Keep the name specific to GSM, other implementations will probably
require their own interfaces

14 years agoAdd GPRS support
Andrzej Zaborowski [Mon, 12 Oct 2009 21:35:59 +0000 (23:35 +0200)]
Add GPRS support

This commit implements the GPRS context setup and teardown according to
doc/dataconnectionmanager-api.txt

One issue with the AT implementation of the api is that "Powered" (a
read-write property) can be set independently of "Attached" (read-only
property) and remain set when "Attached" is clear.  The semantics would
be that the network doesn't have resources to let the modem attach,
but the modem waits for the resources to become available and then
attaches.  On AT the modem is in this state only when executing +CGATT,
so currently the code will rerun +CGATT as soon as the previous one
returns with error, probably starving other commands.  A possible
workaround would be for "Powered" to flip back to False after the modem
fails to attach once, or give up on having separate properties.
Alternatively we could re-try to attach periodically but on one modem
I've tried +CGATT fails after about 1 minute (that's the Calypso) and
on another only about 0.5s (Nokia phones with AT emulation).

When "Powered"  is set and "RoamingAllowed" is clear and we manage to
attach and find that we're roaming, ofono resets "Powered".

We may want to catch the user trying to dial *99***1# which is the
backwards compatibility quirk for old modems (same way ofono parses
USSD strings).

14 years agoFix: Invalid call state transition
Denis Kenzior [Fri, 23 Oct 2009 18:56:26 +0000 (13:56 -0500)]
Fix: Invalid call state transition

When an active and a waiting call exist, and the active is released the
waiting call becomes incoming.  This wasn't properly handled by the
generic at driver.

14 years agoReplace Glib type with standard C type
Zhang, Zhenhua [Fri, 23 Oct 2009 10:20:13 +0000 (18:20 +0800)]
Replace Glib type with standard C type

14 years agoHandle right bracket in next_unquoted_string
Zhenhua Zhang [Thu, 22 Oct 2009 16:47:08 +0000 (00:47 +0800)]
Handle right bracket in next_unquoted_string

14 years agoMention Ryan's contributions
Denis Kenzior [Thu, 22 Oct 2009 00:07:37 +0000 (19:07 -0500)]
Mention Ryan's contributions

14 years agoEnable / Disable CREAD functionality in gattty
Ryan Raasch [Wed, 21 Oct 2009 08:43:36 +0000 (10:43 +0200)]
Enable / Disable CREAD functionality in gattty

14 years agoMention Olivier's contributions
Denis Kenzior [Tue, 20 Oct 2009 15:32:28 +0000 (10:32 -0500)]
Mention Olivier's contributions

14 years agoMigrate from RFC2822 to ISO8601
Olivier Le Thanh Duong [Mon, 5 Oct 2009 17:10:25 +0000 (19:10 +0200)]
Migrate from RFC2822 to ISO8601

14 years agoDoc: Update modem api
Marko Saukko [Tue, 20 Oct 2009 06:25:38 +0000 (09:25 +0300)]
Doc: Update modem api

Add SetProperty and Powered property to modem-api.txt document.

14 years agoRename: drivers/hfpmodem/hfp.[ch] to hfpmodem.[ch]
Denis Kenzior [Tue, 20 Oct 2009 03:13:19 +0000 (22:13 -0500)]
Rename: drivers/hfpmodem/hfp.[ch] to hfpmodem.[ch]

Be more consistent with other drivers

14 years agoFix: Make 'make distcheck' happy again
Denis Kenzior [Mon, 19 Oct 2009 22:07:23 +0000 (17:07 -0500)]
Fix: Make 'make distcheck' happy again

14 years agoFix: Use debug instead of info
Denis Kenzior [Mon, 19 Oct 2009 22:00:32 +0000 (17:00 -0500)]
Fix: Use debug instead of info

14 years agoRefactor: Setup the HF features bitmap
Denis Kenzior [Mon, 19 Oct 2009 21:59:44 +0000 (16:59 -0500)]
Refactor: Setup the HF features bitmap

Do not use magic numbers unless strictly necessary

14 years agoRefactor: Don't store indicator names
Denis Kenzior [Mon, 19 Oct 2009 21:58:13 +0000 (16:58 -0500)]
Refactor: Don't store indicator names

We already know the indicators we're interested in from the
specification, malloc/free-ing the indicator names is thus pointless.
Instead save off the indicator index positions in an array.  Parse the
current values instead of storing the unparsed list.

14 years agoAdd initial glue code for hfp driver
Zhenhua Zhang [Sun, 18 Oct 2009 22:20:25 +0000 (06:20 +0800)]
Add initial glue code for hfp driver

14 years agoAdd test script for USSD
Denis Kenzior [Fri, 16 Oct 2009 22:44:11 +0000 (17:44 -0500)]
Add test script for USSD

14 years agoFix: Use proper printf format for string precision
Denis Kenzior [Fri, 16 Oct 2009 22:43:29 +0000 (17:43 -0500)]
Fix: Use proper printf format for string precision

14 years agoCleanup: Fixup USSD to use cbs_decode_dcs
Denis Kenzior [Fri, 16 Oct 2009 21:46:05 +0000 (16:46 -0500)]
Cleanup: Fixup USSD to use cbs_decode_dcs

Don't decode by hand, use existing function

14 years agoParse +CUSD responses.
Andrzej Zaborowski [Fri, 16 Oct 2009 22:45:15 +0000 (00:45 +0200)]
Parse +CUSD responses.

14 years agoFix: Stop crashing when unrefing chat in callback
Denis Kenzior [Fri, 16 Oct 2009 21:25:19 +0000 (16:25 -0500)]
Fix: Stop crashing when unrefing chat in callback

14 years agoRelease 0.8 0.8
Marcel Holtmann [Fri, 16 Oct 2009 20:18:31 +0000 (22:18 +0200)]
Release 0.8

14 years agoFix: Don't return NULL if message is empty
Denis Kenzior [Fri, 16 Oct 2009 18:19:11 +0000 (13:19 -0500)]
Fix: Don't return NULL if message is empty

Empty SMS messages are in sms_decode_text are returned as NULL, e.g.
error.  This shouldn't be the case, empty messages should be reported
and signaled.

14 years agoMention Marko's contribution
Denis Kenzior [Fri, 16 Oct 2009 18:07:35 +0000 (13:07 -0500)]
Mention Marko's contribution

14 years agoFix: Skip over empty messages
Andrzej Zaborowski [Mon, 12 Oct 2009 20:43:04 +0000 (22:43 +0200)]
Fix: Skip over empty messages

14 years agoFix: Emit debug message instead of an error
Andrzej Zaborowski [Mon, 12 Oct 2009 20:41:35 +0000 (22:41 +0200)]
Fix: Emit debug message instead of an error

SMS storage is frequently empty at startup, if this is the case, do not
use ofono_error, use ofono_debug instead.

14 years agoAlways return a string from telephony_error_to_str.
Andrzej Zaborowski [Mon, 12 Oct 2009 20:39:47 +0000 (22:39 +0200)]
Always return a string from telephony_error_to_str.

So that it can be used as a printf argument directly.

14 years agoRefactor: Move network registration status utils
Andrzej Zaborowski [Mon, 12 Oct 2009 20:37:14 +0000 (22:37 +0200)]
Refactor: Move network registration status utils

Move the status to string functions to common.c so that they can be
reused in data connection related network registration code.

14 years agoFix: Free converted string after use.
Andrzej Zaborowski [Fri, 16 Oct 2009 17:44:36 +0000 (19:44 +0200)]
Fix: Free converted string after use.

Also make sure we don't read beyond end of the string.

14 years agoAPI: Documentation fixes
Marko Saukko [Fri, 16 Oct 2009 09:47:48 +0000 (12:47 +0300)]
API: Documentation fixes

14 years agoFix conditional statement
Aki Niemi [Fri, 16 Oct 2009 11:02:27 +0000 (14:02 +0300)]
Fix conditional statement

14 years agoFix: restrict keyword use breaking distcheck
Aki Niemi [Fri, 16 Oct 2009 08:26:15 +0000 (11:26 +0300)]
Fix: restrict keyword use breaking distcheck

14 years agoisimodem/voicecall.c: initial version
Pekka Pessi [Fri, 9 Oct 2009 14:45:37 +0000 (17:45 +0300)]
isimodem/voicecall.c: initial version

Implementing all the voicecall methods. Tested with Nokia 2008 modems.

 - problems in call creation are probably not reported properly
 - deflect not implemented in modem, not properly tested

TODO: Clean up style issues and align with other drivers.

14 years agoRefactor sub-sub-block handling
Aki Niemi [Thu, 15 Oct 2009 12:13:16 +0000 (15:13 +0300)]
Refactor sub-sub-block handling

14 years agoSetup better debugging information for calypso
Denis Kenzior [Thu, 15 Oct 2009 20:57:12 +0000 (15:57 -0500)]
Setup better debugging information for calypso

14 years agoFix: Quiet a warning on some compilers
Denis Kenzior [Thu, 15 Oct 2009 20:56:48 +0000 (15:56 -0500)]
Fix: Quiet a warning on some compilers

14 years agoMultiplexer support for OpenMoko device
Denis Kenzior [Thu, 15 Oct 2009 03:30:31 +0000 (22:30 -0500)]
Multiplexer support for OpenMoko device

14 years agoFix: Do not leak chat memory
Denis Kenzior [Wed, 14 Oct 2009 22:00:20 +0000 (17:00 -0500)]
Fix: Do not leak chat memory

14 years agoFix: Do not leak chat references in case of error
Denis Kenzior [Wed, 14 Oct 2009 21:57:21 +0000 (16:57 -0500)]
Fix: Do not leak chat references in case of error

14 years agoFix: Cleanup debug formats
Denis Kenzior [Wed, 14 Oct 2009 21:34:59 +0000 (16:34 -0500)]
Fix: Cleanup debug formats

14 years agoFix: Do not send shutdown more than once
Denis Kenzior [Wed, 14 Oct 2009 21:34:35 +0000 (16:34 -0500)]
Fix: Do not send shutdown more than once

14 years agoFix: Be more paranoid in checking DLC validity
Denis Kenzior [Wed, 14 Oct 2009 21:03:36 +0000 (16:03 -0500)]
Fix: Be more paranoid in checking DLC validity

14 years agoUpdate unit tests for GSM 07.10 implementation
Denis Kenzior [Wed, 14 Oct 2009 20:54:10 +0000 (15:54 -0500)]
Update unit tests for GSM 07.10 implementation

14 years agoRefactor: Add driver model to GAtMux
Denis Kenzior [Wed, 14 Oct 2009 20:50:55 +0000 (15:50 -0500)]
Refactor: Add driver model to GAtMux

GAtMux can now be made to work with multiple multiplexing protocols.
Currently on the 27.010 (07.10) Advanced and Basic modes are supported.
However, further protocol support can be added by providing the
necessary driver functions for GAtMux

14 years agoFix: Quiet compiler warning
Denis Kenzior [Wed, 14 Oct 2009 18:28:17 +0000 (13:28 -0500)]
Fix: Quiet compiler warning

14 years agoForgot to add void* to get_data
Denis Kenzior [Mon, 12 Oct 2009 21:00:44 +0000 (16:00 -0500)]
Forgot to add void* to get_data

14 years agoForgot to add driverdata functions
Denis Kenzior [Mon, 12 Oct 2009 20:40:31 +0000 (15:40 -0500)]
Forgot to add driverdata functions

14 years agoRefactor: Enable multiplexer drivers for GAtMux
Denis Kenzior [Mon, 12 Oct 2009 20:31:44 +0000 (15:31 -0500)]
Refactor: Enable multiplexer drivers for GAtMux

14 years agoFix: Notify sources upon shutdown
Denis Kenzior [Mon, 12 Oct 2009 16:56:41 +0000 (11:56 -0500)]
Fix: Notify sources upon shutdown

14 years agoUpdate unit test for the new API
Denis Kenzior [Mon, 12 Oct 2009 03:36:23 +0000 (22:36 -0500)]
Update unit test for the new API

14 years agoAdd mux setup step to phonesim plugin
Denis Kenzior [Mon, 12 Oct 2009 03:35:49 +0000 (22:35 -0500)]
Add mux setup step to phonesim plugin

14 years agoAdd ability to open/close multiple DLCs
Denis Kenzior [Mon, 12 Oct 2009 03:34:31 +0000 (22:34 -0500)]
Add ability to open/close multiple DLCs

14 years agoFixup unit test to the new API
Denis Kenzior [Fri, 9 Oct 2009 22:17:03 +0000 (17:17 -0500)]
Fixup unit test to the new API

14 years agoRefactor: Add convenience method to start 0710 MUX
Denis Kenzior [Fri, 9 Oct 2009 22:15:58 +0000 (17:15 -0500)]
Refactor: Add convenience method to start 0710 MUX

Use an existing GAtChat that has been setup appropriately to conver the
channel into a MUX

14 years agoAdd ability to retrieve the atchat IOChannel
Denis Kenzior [Fri, 9 Oct 2009 19:57:14 +0000 (14:57 -0500)]
Add ability to retrieve the atchat IOChannel

14 years agoRemove more unused code
Denis Kenzior [Fri, 9 Oct 2009 19:32:59 +0000 (14:32 -0500)]
Remove more unused code

14 years agogisi: Add getter for sub-block data
Aki Niemi [Wed, 14 Oct 2009 19:15:10 +0000 (22:15 +0300)]
gisi: Add getter for sub-block data

Also fix indentation and change int->unsigned in the API.

14 years agoAdd isimodem drivers for call barring, forwarding and waiting
Alexander Kanavin [Thu, 8 Oct 2009 15:44:44 +0000 (18:44 +0300)]
Add isimodem drivers for call barring, forwarding and waiting

14 years agoRefactor subblock iterators.
Pekka Pessi [Thu, 8 Oct 2009 16:47:15 +0000 (19:47 +0300)]
Refactor subblock iterators.

Always initialize iterators.

Try to avoid pointer arithmetics on NULL; in other words, move all pointer
arithmetics inside g_isi_sb_iter_init().

There are 4 different ways for representing sub blocks in ISI message:
- 8-bit sub_blocks count, 8-bit sub_block_id/sub_block_len
- 16-bit sub_blocks count, 8-bit sub_block_id/sub_block_len
- 8-bit sub_blocks count, 16-bit sub_block_id/sub_block_len
- 16-bit sub_blocks count, 16-bit sub_block_id/sub_block_len

The compact form g_isi_sb_iter_init() supports 8-bit sub_block count before
start of the sub blocks themselves and 8-bit sub_block_id and sub_block_len.
The full form g_isi_sb_iter_init_full() with explicit longhdr and sub_block
count supports all other cases.

14 years agoMention Pekka's contributions
Denis Kenzior [Thu, 8 Oct 2009 17:58:31 +0000 (12:58 -0500)]
Mention Pekka's contributions

14 years agoRename function to express its purpose better
Denis Kenzior [Thu, 8 Oct 2009 17:57:01 +0000 (12:57 -0500)]
Rename function to express its purpose better

14 years agoAllow sending DTMF tones in alerting state
Pekka Pessi [Thu, 8 Oct 2009 16:59:53 +0000 (19:59 +0300)]
Allow sending DTMF tones in alerting state

2nd stage dialing may be done before call gets connected.

14 years agoUse swap_without_accept method, if present
Pekka Pessi [Thu, 8 Oct 2009 16:59:52 +0000 (19:59 +0300)]
Use swap_without_accept method, if present

14 years agoMention Zhenhua's contributions
Denis Kenzior [Thu, 8 Oct 2009 17:54:26 +0000 (12:54 -0500)]
Mention Zhenhua's contributions

14 years agoFix: Use DISC on dlc 0 instead of CLD
Denis Kenzior [Thu, 8 Oct 2009 17:49:12 +0000 (12:49 -0500)]
Fix: Use DISC on dlc 0 instead of CLD

Some MUX implementations do not seem to support Multiplexer Closedown
(CLD) command.  The standard specifies that sending DISC on DLC 0 should
act exactly the same as CLD.

14 years agoFix: Make compile on some obscure platforms
Denis Kenzior [Thu, 8 Oct 2009 05:07:32 +0000 (00:07 -0500)]
Fix: Make compile on some obscure platforms

14 years agoCleanup: Remove more dead code
Denis Kenzior [Wed, 7 Oct 2009 16:06:31 +0000 (11:06 -0500)]
Cleanup: Remove more dead code

14 years agoCleanup: Get rid of unused member
Denis Kenzior [Tue, 6 Oct 2009 23:21:01 +0000 (18:21 -0500)]
Cleanup: Get rid of unused member

ctx->server is never set to anything but 0.  This was intended to handle
server side functionality of the GSM 07.10 multiplexer, but never fully
implemented.  Since GAtMux is only really meant for the client side, we
can safely remove this dead code.

14 years agoGet rid of from_tty variant, use gattty instead
Denis Kenzior [Tue, 6 Oct 2009 23:14:11 +0000 (18:14 -0500)]
Get rid of from_tty variant, use gattty instead

14 years agogisi: use const and restrict in iter
Pekka Pessi [Wed, 30 Sep 2009 20:12:17 +0000 (23:12 +0300)]
gisi: use const and restrict in iter

14 years agoHack for reading EFSPN on isimodem sim driver
Jukka Saunamaki [Fri, 18 Sep 2009 06:43:34 +0000 (09:43 +0300)]
Hack for reading EFSPN on isimodem sim driver

In the absence of low-level access to the SIM card, we're adding this
hack to expose the SPN using ISI's high-level access instead.

14 years agoFix: Don't crash when cached ef structure differs
Denis Kenzior [Mon, 5 Oct 2009 21:20:55 +0000 (16:20 -0500)]
Fix: Don't crash when cached ef structure differs