Simon Pilgrim [Sun, 8 Nov 2020 13:36:42 +0000 (13:36 +0000)]
[GVN] Remove unused check-prefixes
Simon Pilgrim [Sun, 8 Nov 2020 13:34:07 +0000 (13:34 +0000)]
[InstCombine] Fix malformed CHECK32/64 test checks.
Simon Pilgrim [Sun, 8 Nov 2020 13:33:21 +0000 (13:33 +0000)]
[InstCombine] Remove unused check-prefixes
Just use default CHECK
Simon Pilgrim [Sun, 8 Nov 2020 13:30:18 +0000 (13:30 +0000)]
[PhaseOrdering] Remove unused check-prefixes
Just use default CHECK in most cases.
Simon Pilgrim [Sun, 8 Nov 2020 13:20:17 +0000 (13:20 +0000)]
[PhaseOrdering][X86] Remove unused check-prefixes
Just use default CHECK
Simon Pilgrim [Sun, 8 Nov 2020 13:07:45 +0000 (13:07 +0000)]
[DSE] Don't dereference a dyn_cast<> result - use cast<> instead. NFCI.
We were relying on the dyn_cast<> succeeding - better use cast<> and have it assert that its the correct type than dereference a null result.
Simon Pilgrim [Sun, 8 Nov 2020 13:06:07 +0000 (13:06 +0000)]
Don't dereference a dyn_cast<> result - use cast<> instead. NFCI.
We were relying on the dyn_cast<> succeeding - better use cast<> and have it assert that its the correct type than dereference a null result.
Simon Pilgrim [Sun, 8 Nov 2020 12:58:14 +0000 (12:58 +0000)]
[InstCombine] foldSelectFunnelShift - block poison in funnel shift value
As raised by @nlopes on D90382 - if this is not a rotate then the select was blocking poison from the 'shift-by-zero' non-TVal, but a funnel shift won't - so freeze it.
Simon Pilgrim [Sun, 8 Nov 2020 10:30:29 +0000 (10:30 +0000)]
[KnownBits] isNonZero() - avoid expensive countPopulation call. NFC.
We can just check for a null value.
Florian Hahn [Sun, 8 Nov 2020 11:37:36 +0000 (11:37 +0000)]
[LoopInterchange] Skip non SCEV-able operands in cost function.
This fixes a crash when trying to get a SCEV expression for operands
that are not SCEV-able.
Pedro Tammela [Thu, 5 Nov 2020 19:03:08 +0000 (19:03 +0000)]
[Reg2Mem] add support for the new pass manager
This patch refactors the pass to accomodate the new pass manager
boilerplate.
Differential Revision: https://reviews.llvm.org/D91005
Arthur Eubanks [Sun, 8 Nov 2020 08:18:42 +0000 (00:18 -0800)]
Revert "[NewPM] Provide method to run all pipeline callbacks, used for -O0"
This reverts commit
ae38540042668675dd16c642d850115f217ea59f.
As well as some follow-up test fixes.
The original change causes new-pass-manager.ll to fail when polly is enabled.
Craig Topper [Sun, 8 Nov 2020 06:44:53 +0000 (22:44 -0800)]
[X86] Improve lowering of fptoui
Invert the select condition when masking in the sign bit of a fptoui operation. Also, rather than lowering the sign mask to select/xor and expecting the select to get cleaned up later, directly lower to shift/xor.
Patch by Layton Kifer!
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D90658
Craig Topper [Sun, 8 Nov 2020 06:42:50 +0000 (22:42 -0800)]
[RISCV] Remove assertsexti32 from a couple B extension isel patterns that don't demanded the sign extended bits.
Alexander Shaposhnikov [Sun, 8 Nov 2020 03:58:19 +0000 (19:58 -0800)]
[llvm-objcopy][MachO] Minor refactoring of MachOLayoutBuilder
Move the implementation of getStringTableBuilderKind into
MachOLayoutBuilder.cpp. NFC.
Test plan: make check-all
Fangrui Song [Sun, 8 Nov 2020 04:17:41 +0000 (20:17 -0800)]
[ELF] --warn-backrefs-exclude: use toString to match the documentation
The pattern should patch `a.a(a.o)` instead of `a.a`
Fangrui Song [Sun, 8 Nov 2020 03:03:50 +0000 (19:03 -0800)]
[ELF] Test R_*_SIZE for non-SHF_ALLOC sections
Kazu Hirata [Sun, 8 Nov 2020 04:18:47 +0000 (20:18 -0800)]
[Mem2Reg] Use llvm::count instead of std::count (NFC)
Kazu Hirata [Sun, 8 Nov 2020 03:35:02 +0000 (19:35 -0800)]
[JumpThreading] Fix function names (NFC)
Stella Laurenzo [Sun, 8 Nov 2020 02:32:35 +0000 (18:32 -0800)]
Remove TOSA test passes from non test registration.
* Wires them in the same way that peer-dialect test passes are registered.
* Fixes the build for -DLLVM_INCLUDE_TESTS=OFF.
Differential Revision: https://reviews.llvm.org/D91022
Cornelius Aschermann [Sun, 8 Nov 2020 02:12:51 +0000 (18:12 -0800)]
[llvm-objcopy][MachO] Fix adding multiple sections
This diff fixes missing fields initialization (Size, VMSize).
Previously this resulted in broken binaries when multiple sections
were added in one tool's invocatation.
Test plan: make check-all
Differential revision: https://reviews.llvm.org/D90690
Carl Ritson [Sun, 8 Nov 2020 02:14:54 +0000 (11:14 +0900)]
[AMDGPU] SIWholeQuadMode fix mode insertion when SCC always defined
Fix a crash when SCC is defined until end of block and mode change
must be inserted in SCC live region.
Reviewed By: mceier
Differential Revision: https://reviews.llvm.org/D90997
Mehdi Amini [Sun, 8 Nov 2020 00:08:47 +0000 (00:08 +0000)]
Include the generated documentation for list of ops in the TOSA dialect
Stephen Kelly [Sat, 7 Nov 2020 22:25:00 +0000 (22:25 +0000)]
Fix dumping of explicit template specializations
This was missing from commit
7efe07a1 (Traverse-ignore explicit template
instantiations, 2020-11-06).
Craig Topper [Sat, 7 Nov 2020 22:20:28 +0000 (14:20 -0800)]
[RISCV] Add test cases showing missed opportunities to use sbset/sbclr/sbinv/sbext when the shift amount isn't masked to log2(xlen) bits. NFC
Out of bounds shifts are undefined and these instructions mask
their shift amount before use. So we don't need to see a mask
in order to select the instructions.
Renato Golin [Wed, 4 Nov 2020 13:15:59 +0000 (13:15 +0000)]
[docs] Adding a Support Policy
As discussed in the mailing list [1-4], we need a separation of support
tiers when requiring support from the whole community versus a
sub-community. Essentially, if a sub-community is active enough and
takes maintenance into their own internal costs without affecting other
parts of the community's maintenance costs, then code that is not
immediately relevant to all parts (ie. not released, actively tested,
etc) can still find its way into the LLVM main repository without major
pain points.
The main benefit is to reduce the maintenance cost that those
sub-communities have outside of LLVM (for example, in duplicating common
code, applying the same patches on top of multiple user repositories or
downstream projects).
This document outlines the components and responsibilities of the
sub-communities with regards to maintenance costs and how they affect
the rest of the community.
It also adds an addendum on removal policies, which expand the existing
"new target removal" policy into something more generic, to encompass
any piece of code, scripts or documents in the repository.
[1] http://lists.llvm.org/pipermail/llvm-dev/2020-October/146249.html
[2] http://lists.llvm.org/pipermail/llvm-dev/2020-November/146335.html
[3] http://lists.llvm.org/pipermail/llvm-dev/2020-October/146138.html
[4] http://lists.llvm.org/pipermail/llvm-dev/2020-November/146298.html
Craig Topper [Sat, 7 Nov 2020 19:50:52 +0000 (11:50 -0800)]
[RISCV] Use (not X) in instead of (xor X, -1) in isel patterns to improve readability. NFC
LLVM GN Syncbot [Sat, 7 Nov 2020 19:18:18 +0000 (19:18 +0000)]
[gn build] Port
d725f1ce531
Nathan James [Sat, 7 Nov 2020 19:18:01 +0000 (19:18 +0000)]
[clang-tidy] Use vfs::FileSystem when getting config
The config providers that look for configuration files currently take a pointer to a FileSystem in the constructor.
For some reason this isn't actually used when trying to read those configuration files, Essentially it just follows the behaviour of the real filesystem.
Using clang-tidy standalone this doesn't cause any issue.
But if its used as a library and the user wishes to use say an `InMemoryFileSystem` it will try to read the files from the disc instead.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D90992
Mehdi Amini [Sat, 7 Nov 2020 18:57:50 +0000 (18:57 +0000)]
Add missing dependency to TOSA library: fix build with -DBUILD_SHARED_LIBS=ON
Mehdi Amini [Sat, 7 Nov 2020 18:49:52 +0000 (18:49 +0000)]
Refactor TOSA Dialect CMake to use add_mlir_dialect/add_mlir_interface (NFC)
Jonas Devlieghere [Sat, 7 Nov 2020 18:45:17 +0000 (10:45 -0800)]
[DWARFLinker] Convert analyzeContextInfo to a work list (NFC)
Convert analyzeContextInfo to a work list using the same approach I used
to remove the recursion from lookForDIEsToKeep. This fixes the crash
reported in https://llvm.org/PR48029.
Tested using the reproducer attached to PR48029 as well as by comparing
the clang MD5 hashes before and after the change (with and without
gmodules).
Differential revision: https://reviews.llvm.org/D90873
Michał Górny [Sat, 7 Nov 2020 16:12:57 +0000 (17:12 +0100)]
[lldb] [test] Use skipUnlessDarwin for tests specific to Darwin
Use skipUnlessDarwin decorator for tests that are specific to Darwin,
instead of skipIf... for all other platforms. This should make it clear
that these tests are not supposed to work elsewhere. It will also make
these tests stop repeatedly popping up while I look for tests that could
be fixed on the platform in question.
Differential Revision: https://reviews.llvm.org/D91003
Michał Górny [Sat, 7 Nov 2020 17:24:32 +0000 (18:24 +0100)]
[lldb] [test] Un-skip one of TestRaise signals on fbsd
Stella Laurenzo [Sat, 7 Nov 2020 17:37:18 +0000 (09:37 -0800)]
NFC: (re-apply) Fix some post-review nits for the Tosa dialect.
This reverts commit
330398052d049f90e6cfac80ab8b765b158a3e61.
Differential Revision: https://reviews.llvm.org/D91006
Nikita Popov [Sat, 7 Nov 2020 17:29:47 +0000 (18:29 +0100)]
[BasicAA] Unify struct/other offset (NFC)
The distinction between StructOffset and OtherOffset has been
originally introduced by
82069c44ca39df9d506e16bfb0ca2481866dd0bb,
which applied different reasoning to both offset kinds. However,
this distinction was not actually correct, and has been fixed by
c84e77aeaefccb8d0c4c508b8017dcad80607f53. Since then, we only ever
consider the sum StructOffset + OtherOffset, so we may as well
store it in that form directly.
Stella Laurenzo [Sat, 7 Nov 2020 17:35:49 +0000 (09:35 -0800)]
Revert "NFC: Fix some post-review nits for the Tosa dialect."
* Introduced issue in debug builds.
This reverts commit
b5fcd06105dec2a7b0e4114d6ad4524fc54498c5.
Nikita Popov [Sat, 7 Nov 2020 16:48:41 +0000 (17:48 +0100)]
[BasicAA] Use smul_ov helper (NFCI)
Instead of performing the multiplication in double the bit width
and using active bits to determine overflow, use the existing
smul_ov() APInt method to detect overflow.
The smul_ov() implementation is not particularly efficient, but
it's still better than doing this a wide, usually 128-bit, type.
Stella Laurenzo [Sat, 7 Nov 2020 17:05:51 +0000 (09:05 -0800)]
[mlir][Python] Adapt to include property change in pybind11 v2.6.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D90955
Stella Laurenzo [Sat, 7 Nov 2020 16:54:31 +0000 (08:54 -0800)]
NFC: Fix some post-review nits for the Tosa dialect.
* Moved various loose functions to either the mlir::tosa namespace or made static
* Fixed an unused variable warning in TosaMakeBroadcastable.cpp.
Suraj Sudhir [Sat, 7 Nov 2020 16:35:27 +0000 (08:35 -0800)]
TOSA MLIR Dialect
This is the TOSA MLIR Dialect described in the following MLIR RFC: https://llvm.discourse.group/t/rfc-tosa-dialect-in-mlir/1971/24
Reviewed By: stellaraccident
Differential Revision: https://reviews.llvm.org/D90411
Melanie Blower [Sat, 7 Nov 2020 15:40:24 +0000 (07:40 -0800)]
[clang] Fix length threshold for MicrosoftMangle md5 hash
Reviewers: rnk, dblaikie
Differential Revision: https://reviews.llvm.org/D90714
Melanie Blower [Sat, 7 Nov 2020 15:32:34 +0000 (07:32 -0800)]
[clang] Improve Microsoft mangling lit test with dblaikie's suggestions
Nikita Popov [Sat, 7 Nov 2020 11:25:55 +0000 (12:25 +0100)]
[CaptureTracking] Add statistics (NFC)
Add basic statistics on the number of pointers that have been
determined to maybe capture / not capture.
Nikita Popov [Sat, 7 Nov 2020 10:47:31 +0000 (11:47 +0100)]
[CaptureTracking] Early abort on too many uses (NFCI)
If there are too many uses, we should directly return -- there's
no point in inspecting the remaining uses in the worklist, as we
have to conservatively assume a capture anyway. This also means
that tooManyUses() gets called exactly once, rather than
potentially many times.
This restores the behavior prior to
e9832dfdf366ddffba68164adb6855d17c9f87c1,
where this was accidentally changed while moving the AddUses logic
into a closure, thus making the return a return from the closure
rather than the whole function.
Nikita Popov [Sat, 7 Nov 2020 10:44:02 +0000 (11:44 +0100)]
[CaptureTrackingTest] Add missing override marker (NFC)
Nikita Popov [Sat, 7 Nov 2020 10:19:27 +0000 (11:19 +0100)]
[CaptureTracking] Correctly handle multiple uses in one instruction
If the same value is used multiple times in the same instruction,
CaptureTracking may end up reporting the wrong use as being captured,
and/or report the same use as being captured multiple times.
Make sure that all checks take the use operand number into account,
rather than performing unreliable comparisons against the used value.
I'm not sure whether this can cause any problems in practice, but
at least some capture trackers (ArgUsesTracker, AACaptureUseTracker)
do care about which call argument is captured.
George Mitenkov [Sat, 7 Nov 2020 09:27:03 +0000 (12:27 +0300)]
[MLIR][SPIRVToLLVM] Added module name conversion
Since SPIR-V module has an optional name, this patch
makes a change to pass it to `ModuleOp` during conversion.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D90904
Nikita Popov [Sat, 7 Nov 2020 09:13:49 +0000 (10:13 +0100)]
[CaptureTracking] Avoid duplicate shouldExplode() check (NFCI)
We check shouldExplore() before adding uses to the worklist, so
uses that should not be explored will not reach captured() in the
first place.
Jonas Devlieghere [Sat, 7 Nov 2020 07:22:29 +0000 (23:22 -0800)]
[DWARFLinker] Use union to reduce sizeof(WorklistItem) (NFC)
Reduce the size of the WorklistItem struct by using a struct.
Kazu Hirata [Sat, 7 Nov 2020 06:47:22 +0000 (22:47 -0800)]
[BranchProbabilityInfo] Simplify getEdgeProbability (NFC)
The patch simplifies BranchProbabilityInfo::getEdgeProbability by
handling two cases separately, depending on whether we have edge
probabilities.
- If we have edge probabilities, then add up probabilities for
successors being equal to Dst.
- Otherwise, return the number of ocurrences divided by the total
number of successors.
Differential Revision: https://reviews.llvm.org/D90980
Fangrui Song [Sat, 7 Nov 2020 06:19:37 +0000 (22:19 -0800)]
[test] Fix Other/new-pass-manager.ll with has different behaviors whether or not Polly is enabled
after D89158
Fangrui Song [Sat, 7 Nov 2020 05:55:10 +0000 (21:55 -0800)]
[test] Fix Other/new-pass-manager.ll & clang/test/Misc/loop-opt-setup.c
Atmn Patel [Sat, 7 Nov 2020 05:31:35 +0000 (00:31 -0500)]
Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops"
This reverts commit
0b17c6e4479d62bd4ff05c48d6cdf340b198832f. This patch
causes a compile-time error in SCEV.
Atmn Patel [Sat, 7 Nov 2020 05:29:42 +0000 (00:29 -0500)]
Revert "[CodeGen] Fixes sanitizer test"
This reverts commit
b1878b4641e06baa754ce6e3e0387b1e7d7dc143. This does
fix the test but it means that
ac73b73c1652 is not implemented
correctly. Reverting for now, and will be reverting the commit that
causes this to fail.
Fangrui Song [Sat, 7 Nov 2020 05:00:28 +0000 (21:00 -0800)]
AsmPrinter/Dwarf*: Use llvm::Register instead of unsigned
Atmn Patel [Sat, 7 Nov 2020 04:50:55 +0000 (23:50 -0500)]
[CodeGen] Fixes sanitizer test
By turning the loop into an infinite one, the loop can't be deleted
anymore so the test will continue to pass.
Fangrui Song [Sat, 7 Nov 2020 04:09:43 +0000 (20:09 -0800)]
[OpenMP] Fix -Wmisleading-indentation after D84192
Fangrui Song [Sat, 7 Nov 2020 04:02:56 +0000 (20:02 -0800)]
[AsmPrinter] Rename ByteStreamer::EmitInt8 to emitInt8
to be consistent with other emit*
Atmn Patel [Sat, 7 Nov 2020 03:36:47 +0000 (22:36 -0500)]
[LoopDeletion] Fixes failing test
The commit
0b17c6e4479d62bd4ff05c48d6cdf340b198832f occasionally causes this test to
fail, this fixes it.
Jonas Devlieghere [Sat, 7 Nov 2020 03:35:06 +0000 (19:35 -0800)]
[DWARFLinker] Add CompileUnit::getInfo helper that takes a DWARFDie (NFC)
Eliminate the need to go through the DIE index by passing the DIE to
CompileUnit::getInfo directly.
Before:
unsigned Idx = Unit->getOrigUnit().getDIEIndex(Die);
CompileUnit::DIEInfo &Info = Unit->getInfo(Idx);
After:
CompileUnit::DIEInfo &Info = Unit->getInfo(Die);
Atmn Patel [Sun, 25 Oct 2020 22:24:48 +0000 (18:24 -0400)]
[LoopDeletion] Allows deletion of possibly infinite side-effect free loops
From C11 and C++11 onwards, a forward-progress requirement has been
introduced for both languages. In the case of C, loops with non-constant
conditionals that do not have any observable side-effects (as defined by
6.8.5p6) can be assumed by the implementation to terminate, and in the
case of C++, this assumption extends to all functions. The clang
frontend will emit the `mustprogress` function attribute for C++
functions (D86233, D85393, D86841) and emit the loop metadata
`llvm.loop.mustprogress` for every loop in C11 or later that has a
non-constant conditional.
This patch modifies LoopDeletion so that only loops with
the `llvm.loop.mustprogress` metadata or loops contained in functions
that are required to make progress (`mustprogress` or `willreturn`) are
checked for observable side-effects. If these loops do not have an
observable side-effect, then we delete them.
Loops without observable side-effects that do not satisfy the above
conditions will not be deleted.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D86844
cchen [Sat, 7 Nov 2020 03:03:55 +0000 (21:03 -0600)]
[OpenMP5.0] map item can be non-contiguous for target update
In order not to modify the `tgt_target_data_update` information but still be
able to pass the extra information for non-contiguous map item (offset,
count, and stride for each dimension), this patch overload `arg` when
the maptype is set as `OMP_MAP_DESCRIPTOR`. The origin `arg` is for
passing the pointer information, however, the overloaded `arg` is an
array of descriptor_dim:
struct descriptor_dim {
int64_t offset;
int64_t count;
int64_t stride
};
and the array size is the same as dimension size. In addition, since we
have count and stride information in descriptor_dim, we can replace/overload the
`arg_size` parameter by using dimension size.
For supporting `stride` in array section, we use a dummy dimension in
descriptor to store the unit size. The formula for counting the stride
in dimension D_n: `unit size * (D_0 * D_1 ... * D_n-1) * D_n.stride`.
Demonstrate how it works:
```
double arr[3][4][5];
D0: { offset = 0, count = 1, stride = 8 } // offset, count, dimension size always be 0, 1, 1 for this extra dimension, stride is the unit size
D1: { offset = 0, count = 2, stride = 8 * 1 * 2 = 16 } // stride = unit size * (product of dimension size of D0) * D1.stride = 4 * 1 * 2 = 8
D2: { offset = 2, count = 2, stride = 8 * (1 * 5) * 1 = 40 } // stride = unit size * (product of dimension size of D0, D1) * D2.stride = 4 * 5 * 1 = 20
D3: { offset = 0, count = 2, stride = 8 * (1 * 5 * 4) * 2 = 320 } // stride = unit size * (product of dimension size of D0, D1, D2) * D3.stride = 4 * 25 * 2 = 200
// X here means we need to offload this data, therefore, runtime will transfer
// data from offset 80, 96, 120, 136, 400, 416, 440, 456
// Runtime patch: https://reviews.llvm.org/D82245
// OOOOO OOOOO OOOOO
// OOOOO OOOOO OOOOO
// XOXOO OOOOO XOXOO
// XOXOO OOOOO XOXOO
```
Reviewed By: ABataev
Differential Revision: https://reviews.llvm.org/D84192
cchen [Sat, 7 Nov 2020 02:54:49 +0000 (20:54 -0600)]
[libomptarget] Add support for target update non-contiguous
This patch is the runtime support for https://reviews.llvm.org/D84192.
In order not to modify the tgt_target_data_update information but still be
able to pass the extra information for non-contiguous map item (offset,
count, and stride for each dimension), this patch overload arg when
the maptype is set as OMP_TGT_MAPTYPE_DESCRIPTOR. The origin arg is for
passing the pointer information, however, the overloaded arg is an
array of descriptor_dim:
```
struct descriptor_dim {
int64_t offset;
int64_t count;
int64_t stride
};
```
and the array size is the dimension size. In addition, since we
have count and stride information in descriptor_dim, we can replace/overload the
arg_size parameter by using dimension size.
Reviewed By: grokos
Differential Revision: https://reviews.llvm.org/D82245
Mehdi Amini [Sat, 7 Nov 2020 01:34:43 +0000 (01:34 +0000)]
Don't link any LLVM/MLIR library to the C API unit-test
The tests are intended to exercise the public C API and will link to a
specific shared library exposing only the C API, this library itself may
link to libMLIR.so.
If we link some LLVM library statically in the test themselves, we end
up with duplicated cl::opt registrations in LLVM. A possible setup if
these libraries were needed could be to link libMLIR.so directly when
available and link statically when it isn't available (in which case the
libary exposing the C API would be statically link and isolated from the
cl::opt registry, hopefully).
Differential Revision: https://reviews.llvm.org/D90993
Atmn Patel [Fri, 6 Nov 2020 05:10:23 +0000 (00:10 -0500)]
[Inliner] Handle `mustprogress` functions
When inlining `mustprogress` functions, if the caller or the callee has
the attribute, we drop the function attribute. The loops that have the
`llvm.loop.mustprogress` metadata keep their metadata. We do not need to
add new loop metadata to inlined functions because the patch in D86841
already adds the relevant loop metadata in all of the necessary places.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D87262
Fangrui Song [Sat, 7 Nov 2020 00:49:51 +0000 (16:49 -0800)]
[test] -mtriple=x86_64-* -> -mtriple=x86_64
Stella Laurenzo [Sat, 7 Nov 2020 00:47:26 +0000 (16:47 -0800)]
[mlir][Python] Fix cmake typo keeping the extension from installing.
Siva Chandra Reddy [Fri, 6 Nov 2020 23:43:45 +0000 (15:43 -0800)]
[libc] Extend WrapperGen to emit aliases.
Reviewed By: michaelrj
Differential Revision: https://reviews.llvm.org/D90985
Zequan Wu [Fri, 6 Nov 2020 22:53:57 +0000 (14:53 -0800)]
[llvm-cov] Fix missing slash in -path-equivalence
Elvina Yakubova [Fri, 6 Nov 2020 22:50:43 +0000 (01:50 +0300)]
[AArch64] Add driver tests for HiSilicon's TSV110
Sean Silva [Thu, 5 Nov 2020 02:29:08 +0000 (18:29 -0800)]
[mlir][Linalg] Canonicalize duplicate args.
I ran into this pattern when converting elementwise ops like
`addf %arg0, %arg : tensor<?xf32>` to linalg. Redundant arguments can
also easily arise from linalg-fusion-for-tensor-ops.
Also, fix some small bugs in the logic in
LinalgStructuredOpsInterface.td.
Differential Revision: https://reviews.llvm.org/D90812
Louis Dionne [Fri, 6 Nov 2020 22:26:42 +0000 (17:26 -0500)]
Revert "Allow running back-deployment testing against libc++abi"
This reverts commit
4d79ef814aedb63, which broke a few build bots.
I'm reverting until I have time to investigate.
Elvina Yakubova [Fri, 6 Nov 2020 22:22:35 +0000 (01:22 +0300)]
[AArch64] Add pipeline model for HiSilicon's TSV110
This patch adds the scheduling and cost model for TSV110.
Reviewed by: SjoerdMeijer, bryanpkc
Differential Revision: https://reviews.llvm.org/D89972
Kazu Hirata [Fri, 6 Nov 2020 22:18:00 +0000 (14:18 -0800)]
[TableGen] Use llvm::is_contained (NFC)
Eric Astor [Fri, 6 Nov 2020 20:18:15 +0000 (15:18 -0500)]
[ms] [llvm-ml] Allow arbitrary strings as integer constants
MASM interprets strings in expression contexts as integers expressed in big-endian base-256, treating each character as its ASCII representation.
This completely eliminates the need to special-case single-character strings.
Reviewed By: thakis
Differential Revision: https://reviews.llvm.org/D90788
Atmn Patel [Sun, 25 Oct 2020 22:30:09 +0000 (18:30 -0400)]
[LoopDeletion] Remove dead loops with no exit blocks
Currently, LoopDeletion refuses to remove dead loops with no exit blocks
because it cannot statically determine the control flow after it removes
the block. This leads to miscompiles if the loop is an infinite loop and
should've been removed.
Differential Revision: https://reviews.llvm.org/D90115
Alexander Shaposhnikov [Fri, 6 Nov 2020 21:10:41 +0000 (13:10 -0800)]
[llvm-objcopy][MachO] Skip sections with zero offset
Some binaries can contain regular sections with zero offset and zero size.
This diff makes llvm-objcopy's handling of such sections consistent with
cctools's strip (which doesn't modify them),
previously the tool would allocate file space for them.
Test plan: make check-all
Differential revision: https://reviews.llvm.org/D90796
Jonas Devlieghere [Fri, 6 Nov 2020 21:04:55 +0000 (13:04 -0800)]
[debuginfo-tests] Skip optnone-loops.cpp on Darwin
This is failing on GreenDragon:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24745/
Stephen Kelly [Sat, 31 Oct 2020 00:41:16 +0000 (00:41 +0000)]
Add new matchers for dependent names in templates
Differential Revision: https://reviews.llvm.org/D90767
Mehdi Amini [Fri, 6 Nov 2020 20:46:09 +0000 (20:46 +0000)]
Fix gcc warning by removing extra `;` after a macro (NFC)
Rahman Lavaee [Fri, 6 Nov 2020 20:44:24 +0000 (12:44 -0800)]
[obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section.
YAML support allows us to better test the feature in the subsequent patches. The implementation is quite similar to the .stack_sizes section.
Reviewed By: jhenderson, grimar
Differential Revision: https://reviews.llvm.org/D88717
Nathan James [Fri, 6 Nov 2020 19:58:19 +0000 (19:58 +0000)]
[clangd] Set the User option for clang-tidy to mimick its behaviour
Probably not essential as afaik only one check uses this field. but still good to have consistent behaviour.
Reviewed By: sammccall
Differential Revision: https://reviews.llvm.org/D90552
Valentin Churavy [Fri, 6 Nov 2020 19:26:04 +0000 (14:26 -0500)]
Fix unwind info relocation with large code model on AArch64
Makes sure that the unwind info uses 64bits pcrel relocation if a large code model is specified and handle the corresponding relocation in the ExecutionEngine. This can happen with certain kernel configuration (the same as the one in https://reviews.llvm.org/D27609, found at least on the ArchLinux stock kernel and the one used on https://www.packet.net/) using the builtin JIT memory manager.
Co-authored-by: Yichao Yu <yyc1992@gmail.com>
Differential Revision: https://reviews.llvm.org/D27629
Siva Chandra Reddy [Fri, 6 Nov 2020 01:07:17 +0000 (17:07 -0800)]
[libc][WrapperGen] Replace the C _Noreturn annotation with C++ [[noreturn]].
Reviewed By: michaelrj
Differential Revision: https://reviews.llvm.org/D90900
Valentin Churavy [Fri, 6 Nov 2020 19:08:30 +0000 (14:08 -0500)]
[RTDYLD] support absolute relocations where needed
These appear in some sections, such as DWARF tables, since
RuntimeDyldELF explicitly maps to this as a sentinel value:
https://github.com/llvm/llvm-project/blob/
29d1fba7b5335d969e3e5daa84b7a25cd1fa75ef/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp#L1199
That could then be a source of problems if it tried to examine these
sections (for example, with either setProcessAllSections(true) or ORCv2 on i686).
Replaces https://reviews.llvm.org/D89241
Reviewed By: lhames, vchuravy
Differential Revision: https://reviews.llvm.org/D90722
Kazu Hirata [Fri, 6 Nov 2020 19:05:35 +0000 (11:05 -0800)]
[BranchProbabilityInfo] Use succ_size (NFC)
Craig Topper [Fri, 6 Nov 2020 18:29:22 +0000 (10:29 -0800)]
[RISCV] Add test case to show incorrect matching to sroiw when the or mask does not have 1s in the upper 32 bits.
The matching code for sroiw is truncating the mask to 32 bits before
checking its value. We need to check all 64 bits.
Quentin Colombet [Fri, 6 Nov 2020 18:25:16 +0000 (10:25 -0800)]
Prevent LICM and machineLICM from hoisting convergent operations
Results of convergent operations are implicitly affected by the
enclosing control flows and should not be hoisted out of arbitrary
loops.
Patch by Xiaoqing Wu <xiaoqing_wu@apple.com>
Differential Revision: https://reviews.llvm.org/D90361
Richard Howell [Fri, 6 Nov 2020 18:04:28 +0000 (10:04 -0800)]
[lldb] add a missing dependency on intrinsics_gen
Sometimes builds will fail with errors like:
```
In file included from /build/external/llvm-project/lldb/source/Symbol/SwiftASTContext.cpp:52:
In file included from /build/external/swift/include/swift/IRGen/Linking.h:22:
In file included from /build/external/swift/include/swift/SIL/SILFunction.h:24:
In file included from /build/external/swift/include/swift/SIL/SILBasicBlock.h:23:
In file included from /build/external/swift/include/swift/SIL/SILInstruction.h:21:
In file included from /build/external/swift/include/swift/AST/Builtins.h:24:
**/build/external/llvm-project/llvm/include/llvm/IR/Attributes.h:74:14: fatal error: 'llvm/IR/Attributes.inc' file not found**
**^~~~~~~~~~~~~~~~~~~~~~~~**
```
This change ensures the `Attributes.inc` file is generated before building `SwiftASTContext.cpp`.
Differential Revision: https://reviews.llvm.org/D90857
Alex Zinenko [Fri, 6 Nov 2020 10:00:13 +0000 (11:00 +0100)]
[mlir] Use PyValue instead of PyOpResult in Python operand container
The PyOpOperands container was erroneously constructing objects for
individual operands as PyOpResult. Operands in fact are just values,
which may or may not be results of another operation. The code would
eventually crash if the operand was a block argument. Add a test that
exercises the behavior that previously led to crashes.
Reviewed By: stellaraccident
Differential Revision: https://reviews.llvm.org/D90917
Alex Zinenko [Fri, 6 Nov 2020 17:59:58 +0000 (18:59 +0100)]
Revert "[mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so."
This reverts commit
80fe2f61fac9f72825f907637a9c63aca32d8f14.
Broke linkage with GNU ld. See original review thread for more details.
Nawrin Sultana [Fri, 6 Nov 2020 16:47:33 +0000 (10:47 -0600)]
[OpenMP] Fix potential division by 0
This patch fixes potential division by 0 in case hwloc does not
recognize cores (or architecture has no cores).
Patch by Andrey Churbanov
Differential Revision: https://reviews.llvm.org/D90954
Kostya Kortchinsky [Tue, 3 Nov 2020 19:21:15 +0000 (11:21 -0800)]
[scudo][standalone] Simplify populateFreelist
`populateFreelist` was more complicated that it needed to be. We used
to call to `populateBatches` that would do some internal shuffling and
add pointers one by one to the batches, but ultimately this was not
needed. We can get rid of `populateBatches`, and do processing in
bulk. This doesn't necessarily make things faster as this is not on the
hot path, but it makes the function cleaner.
Additionally clean up a couple of items, like `UNLIKELY`s and setting
`Exhausted` to `false` which can't happen.
Differential Revision: https://reviews.llvm.org/D90700
Simon Pilgrim [Fri, 6 Nov 2020 17:26:56 +0000 (17:26 +0000)]
[InstCombine] computeKnownBitsMul - use KnownBits::isNonZero() helper.
Avoid an expensive isKnownNonZero() call - this is a small cleanup before moving the extra NSW functionality from computeKnownBitsMul into KnownBits::computeForMul.
Simon Pilgrim [Fri, 6 Nov 2020 17:22:28 +0000 (17:22 +0000)]
[SLP][AMDGPU] Regenerate packed-math tests and remove unused check prefix
Simon Pilgrim [Fri, 6 Nov 2020 17:14:10 +0000 (17:14 +0000)]
[VectorCombine][X86] Removed unused check prefixes
Stella Laurenzo [Fri, 6 Nov 2020 06:37:47 +0000 (22:37 -0800)]
[mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so.
We were discussing on discord regarding the need for extension-based systems like Python to dynamically link against MLIR (or else you can only have one extension that depends on it). Currently, when I set that up, I piggy-backed off of the flag that enables build libLLVM.so and libMLIR.so and depended on libMLIR.so from the python extension if shared library building was enabled. However, this is less than ideal.
In the current setup, libMLIR.so exports both all symbols from the C++ API and the C-API. The former is a kitchen sink and the latter is curated. We should be splitting them and for things that are properly factored to depend on the C-API, they should have the option to *only* depend on the C-API, and we should build that shared library no matter what. Its presence isn't just an optimization: it is a key part of the system.
To do this right, I needed to:
* Introduce visibility macros into mlir-c/Support.h. These should work on both *nix and windows as-is.
* Create a new libMLIRPublicAPI.so with just the mlir-c object files.
* Compile the C-API with -fvisibility=hidden.
* Conditionally depend on the libMLIR.so from libMLIRPublicAPI.so if building libMLIR.so (otherwise, also links against the static libs and will produce a mondo libMLIRPublicAPI.so).
* Disable re-exporting of static library symbols that come in as transitive deps.
This gives us a dynamic linked C-API layer that is minimal and should work as-is on all platforms. Since we don't support libMLIR.so building on Windows yet (and it is not very DLL friendly), this will fall back to a mondo build of libMLIRPublicAPI.so, which has its uses (it is also the most size conscious way to go if you happen to know exactly what you need).
Sizes (release/stripped, Ubuntu 20.04):
Shared library build:
libMLIRPublicAPI.so: 121Kb
_mlir.cpython-38-x86_64-linux-gnu.so: 1.4Mb
mlir-capi-ir-test: 135Kb
libMLIR.so: 21Mb
Static build:
libMLIRPublicAPI.so: 5.5Mb (since this is a "static" build, this includes the MLIR implementation as non-exported code).
_mlir.cpython-38-x86_64-linux-gnu.so: 1.4Mb
mlir-capi-ir-test: 44Kb
Things like npcomp and circt which bring their own dialects/transforms/etc would still need the shared library build and code that links against libMLIR.so (since it is all C++ interop stuff), but hopefully things that only depend on the public C-API can just have the one narrow dep.
I spot checked everything with nm, and it looks good in terms of what is exporting/importing from each layer.
I'm not in a hurry to land this, but if it is controversial, I'll probably split off the Support.h and API visibility macro changes, since we should set that pattern regardless.
Reviewed By: mehdi_amini, benvanik
Differential Revision: https://reviews.llvm.org/D90824
Kevin P. Neal [Fri, 6 Nov 2020 15:44:13 +0000 (10:44 -0500)]
[FPEnv] Use strictfp metadata in casting nodes
The strictfp metadata was added to the casting AST nodes in D85960, but
we aren't using that metadata yet. This patch adds that support.
In order to avoid lots of ad-hoc passing around of the strictfp bits I
updated the IRBuilder when moving from a function that has the Expr* to a
function that lacks it. I believe we should switch to this pattern to keep
the strictfp support from being overly invasive.
For the purpose of testing that we're picking up the right metadata, I
also made my tests use a pragma to make the AST's strictfp metadata not
match the global strictfp metadata. This exposes issues that we need to
deal with in subsequent patches, and I believe this is the right method
for most all of our clang strictfp tests.
Differential Revision: https://reviews.llvm.org/D88913
Jay Foad [Fri, 6 Nov 2020 14:19:59 +0000 (14:19 +0000)]
[TableGen] Indentation and whitespace fixes in generated code. NFC.
Some of these were found by running clang-format over the generated
code, although that complains about far more issues than I have fixed
here.
Differential Revision: https://reviews.llvm.org/D90937