isl_stream_read_map: allow "not" at start of grouped expression

Reported-by: Vladimir Klebanov <vladimir@cost-ic0701.org>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_test: test_parse_map_equal: return result of test

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_pw_*_on_shared_domain: improve error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

link in new -lclangEdit when available

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_*alloc macros: return expression of desired type

The type information was dropped in 157122e (Check the ctx argument of the
memory macros, Tue Jun 7 16:15:15 2011 -0300).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_map_fixed_power and isl_union_map_fixed_power

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_token: change type of "type" field from enum isl_token_type to int

The field is also assigned values outside the enum.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_union_map_is_subset: properly handle non-obviously empty subsets

If the first argument of isl_union_map_is_subset contains an empty
set in some space that is not present in the second argument,
then isl_union_map_is_subset would incorrectly draw the conclusion
that the first is not a subset of the second.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_aff_cond: change first argument from an isl_set to an isl_pw_aff

An isl_pw_aff can also convey information about whether the expression
is defined.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_{lower,upper}_bound

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_aff_n_piece

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_indicator_function

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_affine_hull: consider points adjacent to any point found

This is usually a fairly cheap way of finding additional points in
the affine hull and may in some cases eliminate constraints with large
coefficients in the current approximation of the hull.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_has_dim_name

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc: minor clean-up

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_space_has_dim_name

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

configure.ac: remove spurious ","

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc: fix typo

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_set_sample: perform basis reduction at each level by default

Although always performing basis reduction can lead to slow-downs
on larger problems, only performing it once can result in some
relatively simple problems taking an inordinate amount of time.
We therefore revert back to the default from before 8db0a80
(isl_basic_set_sample: only perform basis reduction once,
Sun Aug 9 11:42:41 2009 +0200).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_is_subset

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_basic_map_is_subset

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_sample

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc: document *_sample functions

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_coalesce.c: wrap_in_facets: bail out if any of the facets are empty

It the tableau corresponding to a facet is empty, then we don't have
accurate information on the ridges and we can't call add_wraps.
The facet can have no integer points due to other constraints.
An alternative would be to temporarily treat the tableau as a rational
tableau.

Reported-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_test: test_coalesce_set: fail if coalescing failed

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_map_plain_is_single_valued

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_basic_map_partial_lexopt: properly normalize divs

We were only dividing out common divisors that also divide
the constant term, but we should ignore the constant term
while determining the greatest common divisor.

We already properly normalize the constraints and not properly
normalizing the divs could result in div constraints not being
recognized as such.  In particular, inside isl_map_affine_hull,
div constraints are added inside the call to isl_basic_map_overlying_set.
Usually, these constraints are removed again in remove_redundant_divs,
but they would remain if the the divs are not properly normalized.

Now, arguably, we shouldn't be adding div constraints inside
isl_map_affine_hull, but a proper normalization of divs is useful in any case.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_map_complement

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

scheduler: allow to bound the coefficients in the calculated schedule

isl already supports the bounding of the constant term of the calculated
schedule, but within polybench there are several cases where bounding
the coefficients of parameter and variable dimensions is also needed.

With a bound of 20 Polly can run the isl scheduler on all polybench 2.0 kernels
and takes for each less than 5 seconds, whereas without the bound five test
cases had scheduling times larger than 40 seconds. This is still slower, than
scheduling with gist simplified dependences but it yields better results.
The bounded, non-gist-simplified schedule yields for dynprog, lu, reg_detect
and trmm to faster code compared to scheduling with gist simplified
dependences. For gramschmidt it yields slower code.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_basic_set_non_trivial_lexmin: do not add cuts for all variables

We found a test case where adding cuts for all variables can increase
the time of the scheduling algorithm significantly (from ms to never
seen terminating). Even though we did not understand the problem
entirely, the intuition we have is the following:

When using isl_tab_basic_set_non_trivial_lexmin, the ILP problem is
(usually) not empty, but infinite. Adding all cuts, seems to increase
the objective function only in very small steps. Adding only one cut at
a time allows us to increase it with a step as big as possible.

This patch does not change the behaviour when calling
check_integer_feasible.  In case we're calling cut_to_integer_lexmin
from check_integer_feasible, if it takes a long time to compute, then
it's "usually" because the context is empty and it's just taking a long
time for us to discover that it's empty. We believe in that case it
could still make sense to add all cuts.

This patch was tested on polybench 2.0 with Polly and minimal fusion.
On the larger kernels, it could not solve any infinite scheduling time
problems, but it was able to speed up one test case by 2x and did not
yield increased scheduling time for the other test cases.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_fix_si: drop basic maps that have become empty

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map.c: extract out common remove_if_empty

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_coalesce: drop empty parts before checking the number of parts

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_convex_hull.c: uset_convex_hull_wrap_bounded: remove redundant constraints

The caller compute_facet expects the result to not contain any redundant
constraints.  The input to uset_convex_hull_wrap_bounded, however, might
contain redundant constraints so if this input consists of only one
basic set, we need to make sure redundant constraints are removed.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_realign: preserve (most) flags

In particular, preserve the ISL_BASIC_MAP_EMPTY flag.
Many parts of the code check for this flags so they do not have
to deal with the "1 = 0" constraint.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_printer_print_pw_aff test

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_foreach_lexopt: normalize isl_affs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_*_union_add: don't subtract non-overlapping cells

There is no point in subtracting a cell from another if their intersection
is empty.  It can only lead to a further subdivision of the other cell.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: skip constraints implied by div expression

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_is_div_constraint

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

Conflicts:
isl_output.c

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: fix printing in C format

In 3280c05 (make isl_pw_* object live in a map space,
Tue Aug 30 16:47:59 2011 +0200), the space in which objects live was
changed from that of its domain to that of a map, but
isl_printer_print_pw_aff was not changed accordingly.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_pw_aff: call isl_pw_aff_union_add instead of isl_pw_aff_add

We missed this in 7a86dd8 (rename isl_pw_aff_add to isl_pw_aff_union_add,
Thu Oct 13 12:16:45 2011 +0200).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_vertices.c: compute_chambers: avoid access to freed data structure

The problem was introduced in 328c78f (isl_tab_from_basic_map: preserve all
constraints in input when tracking, Mon Jan 16 16:55:44 2012 +0100).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_pw_multi_aff_coalesce

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_pw_multi_aff_domain

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_normalize: remove unused divs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_multi_aff_from_map: add a special case where result can be read off

If all output dimensions are uniquely defined in terms of the parameters
and input dimensions, we can directly read off the desired isl_pw_multi_aff.
This usually results in much simpler expressions.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

privately export isl_basic_map_plain_is_single_valued

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: simplify domain expression in C format

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_morph.c: fix typo in comment

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_basic_set_full_compression: detect equalities in input first

Without this explicit detection of equalities, some equalities
may be discovered in the middle of the computation, possibly
leading to the introduction of existentially quantified variables,
while callers of isl_basic_set_full_compression typically do not
want such variables.

Since the detection of equalities can in some cases be fairly expensive,
we may have to find a better way of dealing with this problem at some point.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_pw_qpolynomial: accept products of integer divisions

Before, we called accept_affine to parse an integer division that appears
inside a function, but accept_affine also parses a subsequent '*' and
then expects this '*' to be followed by a constant.
Call accept_div directly intead.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_union_set_product: call isl_set_product on entries

Before, we would simply delegate control to isl_union_map_product,
which calls isl_map_product on the entries.  This doesn't work
on isl_sets because they only have a "range" and no "domain".

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_pip.c: sol_add: skip empty contexts

If the context becomes non-empty inside find_solutions, we stop
looking for solutions since a89841a (isl_tab_pip.c: find_solutions: break
when context becomes empty, Sun Jan 31 18:29:12 2010 +0100), but
we still call sol_add.  We need to return from sol_add early in
such cases because there is nothing to do and, more importantly,
when a basic set is marked empty, its existentials are removed,
resulting in a mismatch in the number of dimensions.  In particular,
the basic set returned by sol_domain may not satisfy all assumptions
made by the remainder of sol_add.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_space_set_dim_id: also set id of parameter in nested spaces

A nested space is supposed to have the same parameters as
the nesting space, so if the id of a parameter in the nesting
space space changes, it has to be changed in the nested spaces too.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_space_set_dim_id: rename "dim" variable to "space"

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

scheduler: replace split_parallel by split_scaled option

The split_parallel option was ill-conceived.
The condition split_parallel looked for was too specific
and the implementation was wrong.  Part of this has been fixed
in 1b2fdb6 (schedule.c: split_parallel: avoid invalid memory accesses,
Mon Jan 30 15:23:18 2012 +0100), but the code could in principle
still produce an incorrect schedule because it didn't check the sizes
of the constant terms.

The new option essentially applies strip-mining and should therefore
be safe.  In particular, it is applied when the linear parts of the
schedules have a non-trivial common divisor.  The strip-mining is
then performed with respect to this common divisor.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_mat_scale_down_row

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Add isl_union_map_gist_range

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

scheduler: add an option to configure the level of fusing

We currently only support maximal (the old behavior) and minimal fusion.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

schedule.c: split_parallel: avoid invalid memory accesses

The original code incorrectly assumed that the schedules for
all statements have the same number of columns, i.e., that the
dimensions of the iteration domains of all statements are the same.

We fix this up by simply bailing out if we find this assumption not to hold.
We will improve the applicability of the transformation performed by
split_parallel in a subsequent patch.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

update for change in clang's HandleTopLevelDecl return type

In recent versions of clang, HandleTopLevelDecl should return a boolean
indicating whether parsing should continue.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

configure.ac: only link against libraries from LLVM analysis component

Before, we would link against all LLVM components, which would make
us depend on google-test.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

put annotations after "struct"

Recent versions of clang require the annotations to be placed after "struct".

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_pw_aff_non_zero_set: don't assume isl_pw_aff is total

Before, we would return the domain where the function is not zero
or undefined, whereas we should only return the domain where the function
is not zero.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_nonneg_basic_set and isl_aff_zero_basic_set: simplify result

The constructed constraint may be a tautology in which case it needs
to be simplified away, especially if it is an equality.

We probably want to perform this simplification in
isl_basic_set_from_constraint instead, but CLooG currently depends
on the resulting basic set not being simplified.
We would have to fix CLooG first before we can change this behavior.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_from_basic_map: preserve all constraints in input when tracking

If the user wants to keep track of a basic map representation of the tableau,
then we need to make sure that the initial tableau corresponds exactly to
the input.  In particular, we need to make sure that no (redundant) constraints
are removed.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_track_bmap: drop sanity checks in case of empty tab

If tab is empty, then we may not have added all constraints of "bmap"
and so the number of constraints in tab and bmap may be different.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_track_bmap: make sure we have a unique copy of the basic map

The basic map will be modified in place by isl_tab_add_ineq.
Some callers were passing a unique copy to isl_tab_track_bmap
already, but some others apparently were not.
It's safer to just let isl_tab_track_bmap take care of this.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_track_bmap: fix memory leak on error path

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_remove_unknown_divs: restart whenever div has been removed

The call to isl_basic_map_remove_dims may end up calling
isl_basic_map_simplify, which may in turn remove additional divs
if they no longer occur in any constraint.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_simple_hull: improve error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_multi_aff_drop_dims

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_multi_aff_drop_dims: handle removal of output dimensions

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_multi_aff_set_aff: improve error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_aff_set_tuple_id

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_aff_on_shared_domain: perform gist on results wrt shared domains

The shared domain may have extra constraints compared to the original
domains, which may help to simplify some of the integer divisions involved.
As a side effect, the gist operation may also simplify integer divisions
that could have been simplified even on a universe domain.
We should probably handle such cases much earlier during the construction
of isl_affs.

Reported-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_aff_project_domain_on_params

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_aff_align_params

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_aff: only print () when needed in C format

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_gist: normalize result

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_schedule.c: mark row constructed by compute_split_schedule as non-zero

compute_split_schedule is only called when no zero-distance schedule row
could be found on the entire graph.
We missed this part in ee1ca56 (isl_schedule.c: keep track of parallel loops,
Sun May 29 19:41:55 2011 +0200).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_project_out: properly handle named or nested spaces

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_arg_parse: reset all flags with same option name whenever a flag is set

Otherwise, there is no way to turn off a flag that is set by default.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_ctx_peek_options: special case isl_options_args

The isl_options_args options are always available, even
when they do not appear in ctx->user_opt.
Just return them instead of looking through ctx->user_opt.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_set_compute_vertices: set activity domain on single vertex

isl_basic_set_compute_vertices always sets the activity domains of
the vertices, except when there is only a single vertex.
Chnage vertices_0D to also set the activity domain in this case.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_morph_{dom,ran}_params: add missing isl_morph_cow

Usually, isl_morph_remove_{dom,ran}_dims will call isl_morph_cow for us,
but not when n == 0.

Reported-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info: allow user interaction to restrict potential sources

In particular, the user can register a callback that will be called
any time right before the last potential source is computed.
This should be useful for fuzzy array dataflow analysis.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info_compute_flow: store sink domain map in isl_access_info

We will be able to reuse this map in the next commit.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info_alloc: use isl_calloc to allocate structure

This makes it easier to add new (zero-by-default) fields.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>