platform/upstream/libSkiaSharp.git
8 years agoUpdate android_make to support both --gcc and --clang options.
djsollen [Mon, 7 Mar 2016 20:30:47 +0000 (12:30 -0800)]
Update android_make to support both --gcc and --clang options.

This CL also fixes all the errors that resulted from compiling
with clang and ccache.

BUG=skia:4948
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774503004

Review URL: https://codereview.chromium.org/1774503004

8 years agoadd virtual ~Effect()
mtklein [Mon, 7 Mar 2016 20:28:17 +0000 (12:28 -0800)]
add virtual ~Effect()

Today we make an sk_sp<Effect> from an sk_sp<EffectImpl>.
But when the sk_sp<Effect> dies, it calls ~Effect(), not ~EffectImpl().
Making ~Effect() virtual fixes this.

This should make our Google3 tests sized-delete clean, unblocking those folks.

Review URL: https://codereview.chromium.org/1769093002

8 years agoAttempt to combine batches in forward direction before flush
bsalomon [Mon, 7 Mar 2016 19:50:44 +0000 (11:50 -0800)]
Attempt to combine batches in forward direction before flush
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1763883005

Review URL: https://codereview.chromium.org/1763883005

8 years agolink with -rdynamic on Linux
mtklein [Mon, 7 Mar 2016 19:05:15 +0000 (11:05 -0800)]
link with -rdynamic on Linux

This lets our tools get symbols when they backtrace themselves.

Here's an example improved stack trace.
Notice there are symbols for some Skia methods now.

Stack trace:
    out/Release/dm() [0x5ec19b]
    out/Release/dm() [0x5ec209]
    /lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f6ae0ce2d40]
    /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x7f6ae0ce2cc9]
    /lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x7f6ae0ce60d8]
    out/Release/dm() [0xcd19f9]
    out/Release/dm() [0x8ca959]
    out/Release/dm(_ZN11XfermodesGM16onOnceBeforeDrawEv+0x70) [0x8cb640]
    out/Release/dm(_ZN6skiagm2GM4drawEP8SkCanvas+0x1c) [0x5fc81c]
    out/Release/dm(_ZNK2DM5GMSrc4drawEP8SkCanvas+0x73) [0x5f3563]
    out/Release/dm(_ZNK2DM10RasterSink4drawERKNS_3SrcEP8SkBitmapP9SkWStreamP8SkString+0xcc) [0x5f9eac]
    out/Release/dm(_ZN4Task3RunERKS_+0xd5) [0x5f1685]
    out/Release/dm() [0xa4d320]
    out/Release/dm() [0xcb66ba]
    /lib/x86_64-linux-gnu/libpthread.so.0(+0x8182) [0x7f6ae2667182]
    /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f6ae0da647d]

Today the same crash looks more like this.

Stack trace:
    out/Release/dm() [0x5ec19b]
    out/Release/dm() [0x5ec209]
    /lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f6ae0ce2d40]
    /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x39) [0x7f6ae0ce2cc9]
    /lib/x86_64-linux-gnu/libc.so.6(abort+0x148) [0x7f6ae0ce60d8]
    out/Release/dm() [0xcd19f9]
    out/Release/dm() [0x8ca959]
    out/Release/dm() [0x8cb640]
    out/Release/dm() [0x5fc81c]
    out/Release/dm() [0x5f3563]
    out/Release/dm() [0x5f9eac]
    out/Release/dm() [0x5f1685]
    out/Release/dm() [0xa4d320]
    out/Release/dm() [0xcb66ba]
    /lib/x86_64-linux-gnu/libpthread.so.0(+0x8182) [0x7f6ae2667182]
    /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f6ae0da647d]

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774593002

Review URL: https://codereview.chromium.org/1774593002

8 years agoSwarming bots: add build products whitelist
borenet [Mon, 7 Mar 2016 18:57:26 +0000 (10:57 -0800)]
Swarming bots: add build products whitelist

Should reduce output isolate size (and therefore upload time) for
compile task by ~10x

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768273002

Review URL: https://codereview.chromium.org/1768273002

8 years agoRework files and add test cases.
herb [Mon, 7 Mar 2016 17:17:47 +0000 (09:17 -0800)]
Rework files and add test cases.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757193002

Review URL: https://codereview.chromium.org/1757193002

8 years agoRevert of Update Skia's YUV API (patchset #5 id:160001 of https://codereview.chromium...
msarett [Mon, 7 Mar 2016 17:16:52 +0000 (09:16 -0800)]
Revert of Update Skia's YUV API (patchset #5 id:160001 of https://codereview.chromium.org/1716523002/ )

Reason for revert:
Blimp failures with manual roll in Chrome.

Original issue's description:
> Update Skia's YUV API
>
> We should match the recently designed API in SkCodec.
> https://codereview.chromium.org/1549473003/
>
> This requires changes in Chromium as well.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716523002
>
> Committed: https://skia.googlesource.com/skia/+/095d31c8a0eeb5d491febf064bc3c8a44e22b94f

TBR=scroggo@google.com,reed@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1775493002

8 years agoRevert of Add BigRectGM. (patchset #2 id:20001 of https://codereview.chromium.org...
benjaminwagner [Mon, 7 Mar 2016 17:09:19 +0000 (09:09 -0800)]
Revert of Add BigRectGM. (patchset #2 id:20001 of https://codereview.chromium.org/1758113005/ )

Reason for revert:
Causing ASAN failures. (I had expected float-cast ASAN failures, which are disabled right now, but we're also seeing integer overflows.)

Original issue's description:
> Add BigRectGM.
>
> BUG=skia:5060
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758113005
>
> Committed: https://skia.googlesource.com/skia/+/a9101eef5ffc5f329a5edc75fd67441d868b0e9b

TBR=mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5060

Review URL: https://codereview.chromium.org/1773593005

8 years agoUpdate Skia's YUV API
msarett [Mon, 7 Mar 2016 16:39:12 +0000 (08:39 -0800)]
Update Skia's YUV API

We should match the recently designed API in SkCodec.
https://codereview.chromium.org/1549473003/

This requires changes in Chromium as well.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1716523002

Review URL: https://codereview.chromium.org/1716523002

8 years agoAdd BigRectGM.
benjaminwagner [Mon, 7 Mar 2016 16:16:11 +0000 (08:16 -0800)]
Add BigRectGM.

BUG=skia:5060
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758113005

Review URL: https://codereview.chromium.org/1758113005

8 years agoUpdate SKP version
update-skps [Mon, 7 Mar 2016 15:28:08 +0000 (07:28 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769023002

Review URL: https://codereview.chromium.org/1769023002

8 years agoUse a smart pointer for SkColorSpace factories
msarett [Mon, 7 Mar 2016 15:09:03 +0000 (07:09 -0800)]
Use a smart pointer for SkColorSpace factories

This should fix master-skia in Android because we no longer need
to include src/core for SkCodec.h.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766413002

Review URL: https://codereview.chromium.org/1766413002

8 years agoAdd SkSpecialImage-based methods to SkImageFilter
robertphillips [Mon, 7 Mar 2016 12:51:10 +0000 (04:51 -0800)]
Add SkSpecialImage-based methods to SkImageFilter

This is calved off of https://codereview.chromium.org/1695823002/ (Get OffsetImageFilter really working with SkSpecialImages)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757983002

Review URL: https://codereview.chromium.org/1757983002

8 years agoAdd variants of the setters on SkPaint which take a sk_sp<effect>. At the same time...
reed [Mon, 7 Mar 2016 02:10:48 +0000 (18:10 -0800)]
Add variants of the setters on SkPaint which take a sk_sp<effect>. At the same time, change the internal storage to be sk_sp<effect>.

Follow-on CL might try to use = default for the constructors and assignment operators.

This reverts commit 992854d62e179a589aa7366e443246e3672c3248.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1770723002

Review URL: https://codereview.chromium.org/1770723002

8 years agoSkPDF: AutoTUnref<T> changes in use
halcanary [Sun, 6 Mar 2016 22:47:10 +0000 (14:47 -0800)]
SkPDF: AutoTUnref<T> changes in use

    ::detach()      -> ::release()
    ::operator T*() -> ::get()

This makes all use of AutoTUnref work the same as sk_sp.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772493002

Review URL: https://codereview.chromium.org/1772493002

8 years agoFix behavior of sk_sp::reset(T*) and add unittest.
reed [Sun, 6 Mar 2016 21:54:00 +0000 (13:54 -0800)]
Fix behavior of sk_sp::reset(T*) and add unittest.

Previously, sk_sp::reset(T* t) did not release its own reference
if its internal pointer was the same as 't'. This leaks a reference.
Now always release the current reference when non-nullptr.

Review URL: https://codereview.chromium.org/1767983002

8 years agoRevert of add setter on SkPaint that takes sk_sp (patchset #1 id:1 of https://coderev...
reed [Sun, 6 Mar 2016 01:51:45 +0000 (17:51 -0800)]
Revert of add setter on SkPaint that takes sk_sp (patchset #1 id:1 of https://codereview.chromium.org/1769803002/ )

Reason for revert:
investigate leak

Original issue's description:
> add setter on SkPaint that takes sk_sp
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769803002
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/a917eba6ea8a6936f2c9271e487b14d14b99c98e

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1771613002

8 years agoadd setter on SkPaint that takes sk_sp
reed [Sun, 6 Mar 2016 00:39:25 +0000 (16:39 -0800)]
add setter on SkPaint that takes sk_sp

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769803002

TBR=

Review URL: https://codereview.chromium.org/1769803002

8 years agosk_sp: fix contravariant constructors
halcanary [Sat, 5 Mar 2016 16:30:28 +0000 (08:30 -0800)]
sk_sp: fix contravariant constructors

TBR=reed
This is obviously correct and needs to be fixed.

Review URL: https://codereview.chromium.org/1771583002

8 years agoremove unneeded flag for annotations
reed [Sat, 5 Mar 2016 14:00:12 +0000 (06:00 -0800)]
remove unneeded flag for annotations

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1767783004

TBR=halcanary

Review URL: https://codereview.chromium.org/1767783004

8 years agoMove annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chrom...
reed [Sat, 5 Mar 2016 00:36:20 +0000 (16:36 -0800)]
Move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ )"

Need to land chrome change first https://codereview.chromium.org/1766723003/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758023003

TBR=

Review URL: https://codereview.chromium.org/1758023003

8 years agoFix stall in Vk clear
jvanverth [Fri, 4 Mar 2016 23:16:25 +0000 (15:16 -0800)]
Fix stall in Vk clear

TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765863003

Review URL: https://codereview.chromium.org/1765863003

8 years agoCheck libpng version before reading color space
msarett [Fri, 4 Mar 2016 22:20:49 +0000 (14:20 -0800)]
Check libpng version before reading color space

TBR=scroggo@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1767723003

Review URL: https://codereview.chromium.org/1767723003

8 years agoSkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*>
halcanary [Fri, 4 Mar 2016 21:53:22 +0000 (13:53 -0800)]
SkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*>

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1767713002

Review URL: https://codereview.chromium.org/1767713002

8 years agoSupport building Vulkan on Linux.
bsalomon [Fri, 4 Mar 2016 21:38:26 +0000 (13:38 -0800)]
Support building Vulkan on Linux.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761163003

Review URL: https://codereview.chromium.org/1761163003

8 years agoSet SkColorSpace object for PNGs and parse ICC profiles
msarett [Fri, 4 Mar 2016 21:27:35 +0000 (13:27 -0800)]
Set SkColorSpace object for PNGs and parse ICC profiles

Code for ICC profile parsing adapted from:
https://codereview.chromium.org/1707033002/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726823002

Review URL: https://codereview.chromium.org/1726823002

8 years agoTurn on gpu stats in debug builds.
bsalomon [Fri, 4 Mar 2016 21:15:29 +0000 (13:15 -0800)]
Turn on gpu stats in debug builds.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769633002

Review URL: https://codereview.chromium.org/1769633002

8 years agodisable linear pipeline for now (so bots don't crash)
reed [Fri, 4 Mar 2016 20:56:51 +0000 (12:56 -0800)]
disable linear pipeline for now (so bots don't crash)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766813002

TBR=

Review URL: https://codereview.chromium.org/1766813002

8 years agoIgnore backspace when appending to the filter string in SampleApp. Fixes a bug on...
brianosman [Fri, 4 Mar 2016 19:59:27 +0000 (11:59 -0800)]
Ignore backspace when appending to the filter string in SampleApp. Fixes a bug on Windows where the initial Backspace gets appended, causing no slides to match.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1767683002

Review URL: https://codereview.chromium.org/1767683002

8 years agoAdd support for new bitmapshader context (patchset #5 id:80001 of https://codereview...
reed [Fri, 4 Mar 2016 19:07:43 +0000 (11:07 -0800)]
Add support for new bitmapshader context (patchset #5 id:80001 of https://codereview.chromium.org/1757993002/ )"

This reverts commit cd660e1c07371d9cf97824245639b1c0b5ac92fc.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760123003

Review URL: https://codereview.chromium.org/1760123003

8 years agoRelocate the specialized linear gradient interval builder
fmalita [Fri, 4 Mar 2016 19:01:24 +0000 (11:01 -0800)]
Relocate the specialized linear gradient interval builder

The specialized interval setup works really well for (4f) linear
gradients, but it seems unlikely to benefit other gradient subclasses.

Since it gets in the way of a general/fallback gradient impl, let's move
this code to Sk4fLinearGradient.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1764183002

Review URL: https://codereview.chromium.org/1764183002

8 years agoSwarming tasks: print start and end time
borenet [Fri, 4 Mar 2016 18:58:20 +0000 (10:58 -0800)]
Swarming tasks: print start and end time

This will help determine how long each component of the task takes.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769583002

Review URL: https://codereview.chromium.org/1769583002

8 years agoFix SkiaServe gpu JSON to work with any reordering algorithm
joshualitt [Fri, 4 Mar 2016 18:45:05 +0000 (10:45 -0800)]
Fix SkiaServe gpu JSON to work with any reordering algorithm

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761003004

Review URL: https://codereview.chromium.org/1761003004

8 years agobreak out the tile and matrix strategies
herb [Fri, 4 Mar 2016 18:39:14 +0000 (10:39 -0800)]
break out the tile and matrix strategies

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765953002

Review URL: https://codereview.chromium.org/1765953002

8 years agoMake Cmake work with debug build
halcanary [Fri, 4 Mar 2016 16:30:05 +0000 (08:30 -0800)]
Make Cmake work with debug build

Before this CL, the following failed to link:

    cd .../skia
    git fetch
    git checkout origin/master
    git clean -ffdx
    SKIA="$PWD"
    cd $(mktemp -d);
    cmake "${SKIA}/cmake" -DCMAKE_BUILD_TYPE=Debug -G Ninja
    ninja
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757993006

Review URL: https://codereview.chromium.org/1757993006

8 years agoremove align16 calls in skhader context sizes. will handle this elsewhere as needed
reed [Fri, 4 Mar 2016 15:38:11 +0000 (07:38 -0800)]
remove align16 calls in skhader context sizes. will handle this elsewhere as needed

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1768433003

TBR=

basically reverts previous CL, but keeps the create --> onCreate change

Review URL: https://codereview.chromium.org/1768433003

8 years agoAdd a cache of GrVkSamplers in GrVkResourceProvider.
egdaniel [Fri, 4 Mar 2016 15:35:10 +0000 (07:35 -0800)]
Add a cache of GrVkSamplers in GrVkResourceProvider.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765523002

Review URL: https://codereview.chromium.org/1765523002

8 years agoRevert of Don't allow nullptr in texels array params (unless using a transfer buffer...
bsalomon [Fri, 4 Mar 2016 15:06:43 +0000 (07:06 -0800)]
Revert of Don't allow nullptr in texels array params (unless using a transfer buffer). (patchset #3 id:60001 of https://codereview.chromium.org/1765633002/ )

Reason for revert:
breaks vk build

Original issue's description:
> Don't allow nullptr in texels array params (unless using a transfer buffer).
>
> Require all levels in writePixels to have a non-nullptr.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765633002
>
> Committed: https://skia.googlesource.com/skia/+/8ee78f31b2a29a5f76403755ea17bad9be74a3ec

TBR=jvanverth@google.com,cblume@google.com,cblume@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1760343003

8 years agoFix SkRadialGradient center discontinuity
fmalita [Fri, 4 Mar 2016 14:29:35 +0000 (06:29 -0800)]
Fix SkRadialGradient center discontinuity

(AKA let's slow down radial gradients!)

Avoid discontinuities when r ~= 0.

BUG=skia:5052
R=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753133003

Review URL: https://codereview.chromium.org/1753133003

8 years agoDon't allow nullptr in texels array params (unless using a transfer buffer).
bsalomon [Fri, 4 Mar 2016 14:23:36 +0000 (06:23 -0800)]
Don't allow nullptr in texels array params (unless using a transfer buffer).

Require all levels in writePixels to have a non-nullptr.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1765633002

Review URL: https://codereview.chromium.org/1765633002

8 years agoFix YUV horizontal and vertical sampling checks
msarett [Fri, 4 Mar 2016 14:23:20 +0000 (06:23 -0800)]
Fix YUV horizontal and vertical sampling checks

The should fix crashes while decoding skps.

BUG=skia:4991
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766523002

Review URL: https://codereview.chromium.org/1766523002

8 years agoSwarming bots: setup for skipping download of build products
borenet [Fri, 4 Mar 2016 12:55:26 +0000 (04:55 -0800)]
Swarming bots: setup for skipping download of build products

Turns out it's pretty easy to pass the compile outputs to the test task by just adding the hash to the "includes" list in the .isolated file.  So the flow is:
1. Isolate skia repo
2. Run compile task, record hash of results
3. Isolate test inputs for DM. This writes a .isolated file
4. Edit the .isolated file from #3 to include the hash from #2
5. Upload the modified .isolated file to the isolate server
6. Trigger the swarming task for DM
7. Wait for DM task to finish, download results from isolate server
8. Upload results to GS as normal

I expect the swarming bots to break when this is committed due to the moved out directory.  The associated recipe change will fix them.

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759553003

Review URL: https://codereview.chromium.org/1759553003

8 years agoAvoid drawing NVPR DIF text when text size is 0
kkinnunen [Fri, 4 Mar 2016 08:12:33 +0000 (00:12 -0800)]
Avoid drawing NVPR DIF text when text size is 0

Avoid drawing text when using NVPR and device independent fonts.
The drawing calculations cause division by zero and produce NaNs
to transforms (due to fTextInverseRatio).

Reproed by top25desk_twitter.skp as well as the added testcase.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760163002

Review URL: https://codereview.chromium.org/1760163002

8 years agodisable assert for now
reed [Fri, 4 Mar 2016 03:43:50 +0000 (19:43 -0800)]
disable assert for now

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760373002

TBR=

Review URL: https://codereview.chromium.org/1760373002

8 years agoEnforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview...
reed [Fri, 4 Mar 2016 02:18:25 +0000 (18:18 -0800)]
Enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ )"

This reverts commit e38bcaf24b00066e167e03a5ac63cf828914d747.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1763973002

TBR=

Review URL: https://codereview.chromium.org/1763973002

8 years agoUse installed vulkan SDK and remove checked in SDK
bsalomon [Fri, 4 Mar 2016 00:38:22 +0000 (16:38 -0800)]
Use installed vulkan SDK and remove checked in SDK
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761643002

Review URL: https://codereview.chromium.org/1761643002

8 years agoPull and build shaderc rather than use checked in lib/header
bsalomon [Thu, 3 Mar 2016 23:43:03 +0000 (15:43 -0800)]
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760493003

Committed: https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2

Review URL: https://codereview.chromium.org/1760493003

8 years agoRevert of enforce 16byte alignment in shader contexts (patchset #1 id:1 of https...
halcanary [Thu, 3 Mar 2016 22:23:47 +0000 (14:23 -0800)]
Revert of enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ )

Reason for revert:

Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Debug failed dm:

....
    FYI: loaded 23439 distinct uninteresting hashes from 23439 lines
    Skipping config gpu: Don't understand 'gpu'.
    Skipping config msaa16: Don't understand 'msaa16'.
    168400 srcs * 7 sinks + 481 tests == 1179281 tasks
    0ns elapsed, 5 active, 1179276 queued, 55MB RAM, 55MB peak
        565 gm  xfermodes2
        565 gm  xfermodes
        565 gm  xfermodeimagefilter
        565 gm  xfermodes3
        565 gm  verylarge_picture_image
    c:\0\build\slave\workdir\build\skia\src\core\skshader.cpp:108:
        fatal error: ""(0 == ((size) & 15))""
    step returned non-zero exit code: 3
    @@@STEP_FAILURE@@@

Original issue's description:
> enforce 16byte alignment in shader contexts
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004
>
> Committed: https://skia.googlesource.com/skia/+/d812fb458807245daa812adb7af0733cf5b54d96

TBR=mtklein@google.com,fmalita@chromium.org,herb@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1759323002

8 years agoForce tiles in SampleApp to integer boundaries.
bungeman [Thu, 3 Mar 2016 21:32:38 +0000 (13:32 -0800)]
Force tiles in SampleApp to integer boundaries.

The current behavior is to create tiles from the rounded ideal tile size,
tell the tile that it's upper left pixel is at the ideal location, and
then draw those tiles at the ideal locations. As a result, the tiles are
be out of phase with each other internally and then actually drawn at
the rounded pixel location instead of the ideal location.

The new behavior is to always round up to get the tile size, make the
tile translation an integer offset, and then draw at the exact pixel.

This also modifies SampleApp to use the numeric keypad to provide an
extra manual 1/32 pixel translation for fine grained movement.

BUG=skia:5020

Review URL: https://codereview.chromium.org/1763833002

8 years agoenforce 16byte alignment in shader contexts
reed [Thu, 3 Mar 2016 21:25:25 +0000 (13:25 -0800)]
enforce 16byte alignment in shader contexts

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004

Review URL: https://codereview.chromium.org/1759653004

8 years agoRevert of respect sRGB when converting from sk to gr configs (patchset #1 id:1 of...
brianosman [Thu, 3 Mar 2016 20:52:54 +0000 (12:52 -0800)]
Revert of respect sRGB when converting from sk to gr configs (patchset #1 id:1 of https://codereview.chromium.org/1756913003/ )

Reason for revert:
Two major regressions from this change:
- Mac images may end up too bright, if they're correctly tagged as sRGB. That's a sub-set of a much larger issue where L32 mode needs to suppress sRGB -> Linear conversion of pretty much everything.
- Various low-end GPUs (Mali400 Android, iPad4) don't render in sRGB at all, causing tests to produce no output at all.

Original issue's description:
> respect sRGB when converting from sk to gr configs
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756913003
>
> Committed: https://skia.googlesource.com/skia/+/c6663dc36b157e40c8225130f5970a346f9ba7c3

TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1759653005

8 years agocmake: Exclude vulkan directory.
jcgregorio [Thu, 3 Mar 2016 20:46:12 +0000 (12:46 -0800)]
cmake: Exclude vulkan directory.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1763813002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Review URL: https://codereview.chromium.org/1763813002

8 years agoRemove dependency on SkJsonCanvas.h
joshualitt [Thu, 3 Mar 2016 19:39:38 +0000 (11:39 -0800)]
Remove dependency on SkJsonCanvas.h

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748183007
NOTRY=True

Review URL: https://codereview.chromium.org/1748183007

8 years agorewrite TArray test to not delete an SkSTArray via a SkTArray pointer.
mtklein [Thu, 3 Mar 2016 17:48:53 +0000 (09:48 -0800)]
rewrite TArray test to not delete an SkSTArray via a SkTArray pointer.

This should decouple our thinking around SkTArray, SkSTArray, vector, allocators, etc. from getting sized-deleter clean.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760933002

Review URL: https://codereview.chromium.org/1760933002

8 years agoRevert of add support for new bitmapshader context (patchset #5 id:80001 of https...
reed [Thu, 3 Mar 2016 17:36:50 +0000 (09:36 -0800)]
Revert of add support for new bitmapshader context (patchset #5 id:80001 of https://codereview.chromium.org/1757993002/ )

Reason for revert:
oops, need to update bench to know about the large size needed for the new shader

Original issue's description:
> add support for new bitmapshader context
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757993002
>
> Committed: https://skia.googlesource.com/skia/+/19cef56344b5a5f26f802d7be34c44af36b7e797

TBR=herb@google.com,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1763743002

8 years agoadd support for new bitmapshader context
reed [Thu, 3 Mar 2016 17:16:22 +0000 (09:16 -0800)]
add support for new bitmapshader context

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757993002

Review URL: https://codereview.chromium.org/1757993002

8 years agoRevert of move annotations to canvas virtual (patchset #8 id:140001 of https://codere...
reed [Thu, 3 Mar 2016 17:14:36 +0000 (09:14 -0800)]
Revert of move annotations to canvas virtual (patchset #8 id:140001 of https://codereview.chromium.org/1744103002/ )

Reason for revert:
need to update unittest in blink:

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=261368-1 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DENABLE_OILPAN=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DV8_SHARED -DUSING_V8_SHARED -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../../third_party/WebKit/public/web -I../../third_party/WebKit/Source/web -I../../third_party/WebKit/Source/web/src -I../../third_party/WebKit/public/web/mac -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../third_party/icu/source/common -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/libwebp -I../../third_party/zlib -I../../v8/include -Igen/blink -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O0 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/mac/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -fstack-protector-all  -c ../../third_party/WebKit/Source/core/page/PrintContextTest.cpp -o obj/third_party/WebKit/Source/core/page/webkit_unit_tests.PrintContextTest.o
../../third_party/WebKit/Source/core/page/PrintContextTest.cpp:54:20: error: no member named 'getAnnotation' in 'SkPaint'
        if (!paint.getAnnotation())
             ~~~~~ ^

Original issue's description:
> move annotations to canvas virtual
>
> In an effort to do it all at once, this change assumes that its ok to ignore annotations that were previously stored on paints in old SKP files (since this feature is only interesting to PDF printing).
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744103002
>
> Committed: https://skia.googlesource.com/skia/+/0eda2587cc9233066cb3f3fec08f35c061780f8e

TBR=halcanary@google.com,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1761793003

8 years agoRemove unused tools and unused includes of SkImageDecoder
msarett [Thu, 3 Mar 2016 16:38:26 +0000 (08:38 -0800)]
Remove unused tools and unused includes of SkImageDecoder

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760583003

Review URL: https://codereview.chromium.org/1760583003

8 years agomove annotations to canvas virtual
reed [Thu, 3 Mar 2016 16:13:54 +0000 (08:13 -0800)]
move annotations to canvas virtual

In an effort to do it all at once, this change assumes that its ok to ignore annotations that were previously stored on paints in old SKP files (since this feature is only interesting to PDF printing).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744103002

Review URL: https://codereview.chromium.org/1744103002

8 years agorespect sRGB when converting from sk to gr configs
reed [Thu, 3 Mar 2016 16:03:20 +0000 (08:03 -0800)]
respect sRGB when converting from sk to gr configs

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756913003

Review URL: https://codereview.chromium.org/1756913003

8 years agoAdd operator* and operator safe-bool to sk_sp.
bungeman [Thu, 3 Mar 2016 15:50:49 +0000 (07:50 -0800)]
Add operator* and operator safe-bool to sk_sp.

This greatly reduces the need to use '.get()' in conditionals.

Review URL: https://codereview.chromium.org/1760453004

8 years agoRevert of Implement support for using GL ES 3.0 with command buffer (patchset #6...
kkinnunen [Thu, 3 Mar 2016 15:39:48 +0000 (07:39 -0800)]
Revert of Implement support for using GL ES 3.0 with command buffer (patchset #6 id:100001 of https://codereview.chromium.org/1684413003/ )

Reason for revert:
The dependency, ES3 implementation in command_buffer_gles2, got reverted.

Original issue's description:
> Implement support for using GL ES 3.0 with command buffer
>
> Adds a new 'api': --config gpu(api=commandbuffer3) for dm/nanobench.
>
> BUG=skia:4943
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684413003
>
> Committed: https://skia.googlesource.com/skia/+/45c2c8166bbd84a87e29fdd344b39e36e8a28a3f

TBR=bsalomon@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:4943
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744963002

Review URL: https://codereview.chromium.org/1744963002

8 years agoVerify the full size returned by PIEX
yujieqin [Thu, 3 Mar 2016 15:38:27 +0000 (07:38 -0800)]
Verify the full size returned by PIEX

As the full size info is only optional, one needs to verify the values
before using them

BUG=b/27422694
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757273002

Review URL: https://codereview.chromium.org/1757273002

8 years agoRevert of Update DNG SDK version. (patchset #4 id:60001 of https://codereview.chromiu...
yujieqin [Thu, 3 Mar 2016 14:56:19 +0000 (06:56 -0800)]
Revert of Update DNG SDK version. (patchset #4 id:60001 of https://codereview.chromium.org/1748363004/ )

Reason for revert:
Sorry for breaking the build again...

Original issue's description:
> Update DNG SDK version.
>
> * Integrate integer overflow changes from security branch
>
> BUG=b/26535130
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004
>
> Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567
>
> Committed: https://skia.googlesource.com/skia/+/62c0f75159674087079140e09ef1396316577754

TBR=msarett@google.com,scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/26535130

Review URL: https://codereview.chromium.org/1755283004

8 years ago[Reland] Fix SkTwoPointConicalGradient zero-radius handling
fmalita [Thu, 3 Mar 2016 14:41:54 +0000 (06:41 -0800)]
[Reland] Fix SkTwoPointConicalGradient zero-radius handling

r == 0 is within valid gradient range, we shouldn't skip it.

BUG=skia:5023
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756573002

Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2

Review URL: https://codereview.chromium.org/1756573002

8 years agoUpdate DNG SDK version.
yujieqin [Thu, 3 Mar 2016 14:41:48 +0000 (06:41 -0800)]
Update DNG SDK version.

* Integrate integer overflow changes from security branch

BUG=b/26535130
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004

Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567

Review URL: https://codereview.chromium.org/1748363004

8 years agoRevert "Pull and build shaderc rather than use checked in lib/header"
Eric Boren [Thu, 3 Mar 2016 13:01:33 +0000 (08:01 -0500)]
Revert "Pull and build shaderc rather than use checked in lib/header"

This reverts commit 7d4490ecfa4d974003f675ef004e77f85ecfadd2.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757253002

Review URL: https://codereview.chromium.org/1757253002 .

8 years agoDisable ignored / moot configs in DM.
mtklein [Thu, 3 Mar 2016 01:15:15 +0000 (17:15 -0800)]
Disable ignored / moot configs in DM.

  - upright-matrix-* are ignored in Gold.  Let's stop wasting time.

  - twice-8888 is silly.  ViaTwice was added to help locally test caching / batching
    in the GPU backend.  Running it into a software backend is not testing anything
    interesting, and doing that on the bots is doubly uninteresting.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756333002

Review URL: https://codereview.chromium.org/1756333002

8 years agoPull and build shaderc rather than use checked in lib/header
bsalomon [Wed, 2 Mar 2016 23:59:23 +0000 (15:59 -0800)]
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760493003

Review URL: https://codereview.chromium.org/1760493003

8 years agoOnly modify abort behavior to avoid debugger dialog on windows for bot builds.
bsalomon [Wed, 2 Mar 2016 22:44:15 +0000 (14:44 -0800)]
Only modify abort behavior to avoid debugger dialog on windows for bot builds.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1752973003

Review URL: https://codereview.chromium.org/1752973003

8 years agoFix array in matrixconvolution shader
egdaniel [Wed, 2 Mar 2016 22:29:10 +0000 (14:29 -0800)]
Fix array in matrixconvolution shader

TBR=halcanary@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756353002

Review URL: https://codereview.chromium.org/1756353002

8 years agoPack float array uniforms into vec4 arrays
jvanverth [Wed, 2 Mar 2016 21:21:16 +0000 (13:21 -0800)]
Pack float array uniforms into vec4 arrays

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756583002

Review URL: https://codereview.chromium.org/1756583002

8 years agoUse VkPipelineCaches during VkPipeline creation
jvanverth [Wed, 2 Mar 2016 21:19:47 +0000 (13:19 -0800)]
Use VkPipelineCaches during VkPipeline creation

BUG=skia:5037
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756493002

Review URL: https://codereview.chromium.org/1756493002

8 years agoupdate SkSmallAllocator to force internal allocations to be 16-byte aligned
reed [Wed, 2 Mar 2016 21:03:46 +0000 (13:03 -0800)]
update SkSmallAllocator to force internal allocations to be 16-byte aligned

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755293002

Review URL: https://codereview.chromium.org/1755293002

8 years agoTemporarily disable ios compile bot
stephana [Wed, 2 Mar 2016 20:45:04 +0000 (12:45 -0800)]
Temporarily disable ios compile bot

BUG=skia:
TBR=rmistry
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757053002

Review URL: https://codereview.chromium.org/1757053002

8 years agoReplace some nullptrs with VK_NULL_HANDLE
jvanverth [Wed, 2 Mar 2016 20:08:22 +0000 (12:08 -0800)]
Replace some nullptrs with VK_NULL_HANDLE

Also ensures GrVkRenderPass.h ends with a LF.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758003002

NOTRY=true

Review URL: https://codereview.chromium.org/1758003002

8 years agoRetract GrDrawTarget and GrPipelineBuilder a bit more
robertphillips [Wed, 2 Mar 2016 19:36:59 +0000 (11:36 -0800)]
Retract GrDrawTarget and GrPipelineBuilder a bit more

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761523002
NOTRY=true

Review URL: https://codereview.chromium.org/1761523002

8 years agoGet Vk compiling post-MIP map changes
bsalomon [Wed, 2 Mar 2016 18:58:23 +0000 (10:58 -0800)]
Get Vk compiling post-MIP map changes
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761473002

NOTRY=true

Review URL: https://codereview.chromium.org/1761473002

8 years agofission bitmapprocstate
reed [Wed, 2 Mar 2016 17:49:02 +0000 (09:49 -0800)]
fission bitmapprocstate

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753903002

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1753903002

8 years agoBegin weaning GrClipMaskManager off of GrDrawTarget (take 2)
robertphillips [Wed, 2 Mar 2016 17:26:36 +0000 (09:26 -0800)]
Begin weaning GrClipMaskManager off of GrDrawTarget (take 2)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754563003

Committed: https://skia.googlesource.com/skia/+/86c60758e9e4f9e203d7462cb22b2a245a0f51bd

Review URL: https://codereview.chromium.org/1754563003

8 years agodebugger: Only bind to the localhost address by default.
jcgregorio [Wed, 2 Mar 2016 17:03:01 +0000 (09:03 -0800)]
debugger: Only bind to the localhost address by default.

Also add a flag to set the address.

Additionally print out the final address the user should visit in their browser.

R=joshualitt,ethannicholas
BUG=skia:

Review URL: https://codereview.chromium.org/1756903002

8 years ago4f gradient interval builder cleanup
fmalita [Wed, 2 Mar 2016 16:53:22 +0000 (08:53 -0800)]
4f gradient interval builder cleanup

Untangle the builder, for hopefully improved readability.

R=reed@google.com,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753853002

Review URL: https://codereview.chromium.org/1753853002

8 years agoRevert of Begin weaning GrClipMaskManager off of GrDrawTarget (take 2) (patchset...
robertphillips [Wed, 2 Mar 2016 16:53:12 +0000 (08:53 -0800)]
Revert of Begin weaning GrClipMaskManager off of GrDrawTarget (take 2) (patchset #7 id:120001 of https://codereview.chromium.org/1754563003/ )

Reason for revert:
fAuditTrail

Original issue's description:
> Begin weaning GrClipMaskManager off of GrDrawTarget (take 2)
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754563003
>
> Committed: https://skia.googlesource.com/skia/+/86c60758e9e4f9e203d7462cb22b2a245a0f51bd

TBR=joshualitt@chromium.org,bsalomon@google.com,joshualitt@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1754353002

8 years agoBegin weaning GrClipMaskManager off of GrDrawTarget (take 2)
robertphillips [Wed, 2 Mar 2016 16:43:13 +0000 (08:43 -0800)]
Begin weaning GrClipMaskManager off of GrDrawTarget (take 2)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754563003

Review URL: https://codereview.chromium.org/1754563003

8 years agoadd /img/n/m endpoint to skiaserve
joshualitt [Wed, 2 Mar 2016 16:32:37 +0000 (08:32 -0800)]
add /img/n/m endpoint to skiaserve

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1755563003

Review URL: https://codereview.chromium.org/1755563003

8 years agosk_sp: remove explicit operator bool()
halcanary [Wed, 2 Mar 2016 16:21:39 +0000 (08:21 -0800)]
sk_sp: remove explicit operator bool()

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757593005

Review URL: https://codereview.chromium.org/1757593005

8 years agoPartial revert of https://codereview.chromium.org/1738913002/ (Enable RAW codec for...
robertphillips [Wed, 2 Mar 2016 16:16:32 +0000 (08:16 -0800)]
Partial revert of https://codereview.chromium.org/1738913002/ (Enable RAW codec for Windows)

This un-breaks the MSVC 2015 build.

Review URL: https://codereview.chromium.org/1753243003

8 years agoWire up stack traces again
joshualitt [Wed, 2 Mar 2016 16:11:34 +0000 (08:11 -0800)]
Wire up stack traces again

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749163002

Review URL: https://codereview.chromium.org/1749163002

8 years agosk_sp: Covariant Move Constructor and Move Assignment
halcanary [Wed, 2 Mar 2016 16:11:26 +0000 (08:11 -0800)]
sk_sp: Covariant Move Constructor and Move Assignment

Also Covariant Copy Constructor, Copy Assignment,
and comparison operators.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1752093002

Review URL: https://codereview.chromium.org/1752093002

8 years agoSwarming bots: Add support for perf steps
borenet [Wed, 2 Mar 2016 16:06:27 +0000 (08:06 -0800)]
Swarming bots: Add support for perf steps

NOTRY=true
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754843002

Review URL: https://codereview.chromium.org/1754843002

8 years agosk_make_sp<T>()
halcanary [Wed, 2 Mar 2016 16:06:20 +0000 (08:06 -0800)]
sk_make_sp<T>()

because
    auto atm = sk_make_sp<SkAdvancedTypefaceMetrics>();
is better than
    sk_sp<SkAdvancedTypefaceMetrics> atm(new SkAdvancedTypefaceMetrics);

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1753973002

Review URL: https://codereview.chromium.org/1753973002

8 years agoRevert of Fix SkTwoPointConicalGradient zero-radius handling (patchset #2 id:20001...
fmalita [Wed, 2 Mar 2016 14:34:24 +0000 (06:34 -0800)]
Revert of Fix SkTwoPointConicalGradient zero-radius handling (patchset #2 id:20001 of https://codereview.chromium.org/1756573002/ )

Reason for revert:
One layout test shows a regression: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/83359/layout-test-results/fast/gradients/crash-on-zero-radius-diffs.html

Original issue's description:
> Fix SkTwoPointConicalGradient zero-radius handling
>
> r == 0 is within valid gradient range, we shouldn't skip it.
>
> BUG=skia:5023
> R=caryclark@google.com,reed@google.com
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756573002
>
> Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2

TBR=caryclark@google.com,reed@google.com,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5023

Review URL: https://codereview.chromium.org/1754113003

8 years agoRevert of Generate Signed Distance Field directly from vector path (patchset #13...
robertphillips [Wed, 2 Mar 2016 13:36:30 +0000 (05:36 -0800)]
Revert of Generate Signed Distance Field directly from vector path (patchset #13 id:240001 of https://codereview.chromium.org/1643143002/ )

Reason for revert:
This patch seems to be generating the assert:

GrDistanceFieldGenFromVector.cpp:748: fatal error: ""0 && \"Winding number should be zero at the end of a scan line.\"""

Original issue's description:
> Generate Signed Distance Field directly from vector path
>
> Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath.
> Currently only support even odd fill type.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002
>
> Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f

TBR=bsalomon@google.com,jvanverth@google.com,mtklein@google.com,wasim.abbas@arm.com,joel.liang@arm.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1757913002

8 years agoRevert of Update DNG SDK version. (patchset #3 id:40001 of https://codereview.chromiu...
yujieqin [Wed, 2 Mar 2016 12:57:09 +0000 (04:57 -0800)]
Revert of Update DNG SDK version. (patchset #3 id:40001 of https://codereview.chromium.org/1748363004/ )

Reason for revert:
This breaks the ChromeOS build. E.g. https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-CrOS_Link/builds/5215/steps/build%20most/logs/stdio

Original issue's description:
> Update DNG SDK version.
>
> * Integrate integer overflow changes from security branch
>
> BUG=b/26535130
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004
>
> Committed: https://skia.googlesource.com/skia/+/be2924ad17d47f4ed49666894d87571a28f89567

TBR=msarett@google.com,scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/26535130

Review URL: https://codereview.chromium.org/1755743003

8 years agoUpdate DNG SDK version.
yujieqin [Wed, 2 Mar 2016 11:30:38 +0000 (03:30 -0800)]
Update DNG SDK version.

* Integrate integer overflow changes from security branch

BUG=b/26535130
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1748363004

Review URL: https://codereview.chromium.org/1748363004

8 years agonanobench: Use device independent font flag for GPU configs
kkinnunen [Wed, 2 Mar 2016 07:41:26 +0000 (23:41 -0800)]
nanobench: Use device independent font flag for GPU configs

Actually use the device independent font flag that the user passes
via "--config 'gpu(dit=true,...)'"
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1747173002

Review URL: https://codereview.chromium.org/1747173002

8 years agoGenerate Signed Distance Field directly from vector path
joel.liang [Wed, 2 Mar 2016 02:29:32 +0000 (18:29 -0800)]
Generate Signed Distance Field directly from vector path

Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath.
Currently only support even odd fill type.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002

Review URL: https://codereview.chromium.org/1643143002

8 years agoIntroduce bilerp spans
herb [Tue, 1 Mar 2016 23:18:52 +0000 (15:18 -0800)]
Introduce bilerp spans

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1751943002

Review URL: https://codereview.chromium.org/1751943002

8 years agoSkFontHost_FreeType constructor to correctly release resources.
bungeman [Tue, 1 Mar 2016 23:15:09 +0000 (15:15 -0800)]
SkFontHost_FreeType constructor to correctly release resources.

BUG=chromium:589848

Review URL: https://codereview.chromium.org/1751883004

8 years agoForce values to 0.0f in QuadUVMatrix::set
robertphillips [Tue, 1 Mar 2016 22:49:44 +0000 (14:49 -0800)]
Force values to 0.0f in QuadUVMatrix::set

BUG=skia:5002
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749373002

Review URL: https://codereview.chromium.org/1749373002