platform/core/multimedia/libmm-utility.git
20 months agoFix potential buffer overflow 77/281877/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/hotfix/20221116.105434 accepted/tizen/unified/20220927.132306 tizen_7.0_m2_release
jiyong.min [Fri, 23 Sep 2022 00:49:13 +0000 (09:49 +0900)]
Fix potential buffer overflow

- The 'jpeg_write_raw_data()' write 16 lines(heights) due to  DCT size.
- If the height is not a multiple of 16, use rounddown of a multiple of 16
  and remaining height.

Change-Id: Ic4a747817fb543e0d77ec7c764d4c8ad99e4411c

20 months agoAdd coder log for GraphicsMagick 37/281137/5 accepted/tizen/unified/20220919.012613
jiyong.min [Tue, 13 Sep 2022 08:37:58 +0000 (17:37 +0900)]
Add coder log for GraphicsMagick

Change-Id: I9c8ec59b01b56ddbd6454488714709cf1e64bc3b

21 months agoBug fix. modify using wrong value of 'mm_util_resize_and_rotate_P_P' 62/280762/3
jiyong.min [Mon, 5 Sep 2022 01:33:03 +0000 (10:33 +0900)]
Bug fix. modify using wrong value of 'mm_util_resize_and_rotate_P_P'

 - This is the side-effect of 'Change-Id: Ia184d5b651cabebd1b3f2d5f55cde8f92817bee0'.

Change-Id: Ibbd90e9d27bd15dee55675c6b0350f53917df949

23 months agoBug fix: fix return type mismatch 91/277291/1 accepted/tizen/unified/20220711.173820 submit/tizen/20220705.013205 submit/tizen/20220705.034415 submit/tizen/20220710.230649
jiyong.min [Mon, 4 Jul 2022 23:11:43 +0000 (08:11 +0900)]
Bug fix: fix return type mismatch

Change-Id: I2c2fcdd021750dee0efc5d5342f5c82da6289314

23 months agoRefactoring: Integrate redundant checking the parameter and error handling 15/276915/13
jiyong.min [Tue, 28 Jun 2022 01:55:42 +0000 (10:55 +0900)]
Refactoring: Integrate redundant checking the parameter and error handling

 - Checking the parameter has been repeated at several functions.
   So it was moved to check in the internal function before actually used.

Change-Id: Ia184d5b651cabebd1b3f2d5f55cde8f92817bee0

23 months agoRefactoring: Integrate redundant test code 98/276698/18
jiyong.min [Thu, 23 Jun 2022 05:13:35 +0000 (14:13 +0900)]
Refactoring: Integrate redundant test code

Change-Id: I4a503bc12a691fe08fde0384155a77daf33a4df5

23 months agoRefactoring. Integrate converting string to unsigned int 25/276625/8
jiyong.min [Wed, 22 Jun 2022 06:36:53 +0000 (15:36 +0900)]
Refactoring. Integrate converting string to unsigned int

Change-Id: Ie6dc2ac3c2d3b88998460715daaefa1e03cab298

23 months agoRefactoring. Integrate redundant 'get_image_size' functions 19/276619/6
jiyong.min [Wed, 22 Jun 2022 03:55:24 +0000 (12:55 +0900)]
Refactoring. Integrate redundant 'get_image_size' functions

Change-Id: I9a262e261436e265c023060cec8433935031ea94

2 years agoAdd to get the num of threads from media-config 25/274525/5 accepted/tizen/unified/20220608.140042 submit/tizen/20220508.225238 submit/tizen/20220526.000316 submit/tizen/20220606.223347
jiyong.min [Mon, 2 May 2022 01:04:27 +0000 (10:04 +0900)]
Add to get the num of threads from media-config

Change-Id: I748320a5a02be3367c541b107233770f00db3685

2 years agoAdd 'IMG_CODEC_HEIF' 23/274523/1 accepted/tizen/unified/20220505.134645 submit/tizen/20220503.010702
jiyong.min [Sun, 1 May 2022 23:51:37 +0000 (08:51 +0900)]
Add 'IMG_CODEC_HEIF'

Change-Id: I2eebfb71cf89f8991256bca388751d447e55f317

2 years agoFix typo 'readed' and remove unused header 99/274299/2 accepted/tizen/unified/20220428.162639 submit/tizen/20220427.231424
jiyong.min [Tue, 26 Apr 2022 04:41:02 +0000 (13:41 +0900)]
Fix typo 'readed' and remove unused header

Change-Id: I5b023c27f4bcd030478cef661f18b1652b96e495

2 years agoRefactoring file I/O functions 34/274234/5
jiyong.min [Mon, 25 Apr 2022 06:28:34 +0000 (15:28 +0900)]
Refactoring file I/O functions

Change-Id: I5f9631d591d54447046f13f4d309d53f456da17f

2 years agoFix 'GError *error' memory leak 45/274145/2 accepted/tizen/unified/20220426.021424 submit/tizen/20220424.231651
jiyong.min [Fri, 22 Apr 2022 06:07:04 +0000 (15:07 +0900)]
Fix 'GError *error' memory leak

Change-Id: I44995a685e603fcf0fdbf5ab5148dc16f9230bc2

2 years agoRefactoring option validity check 39/273939/9
Seungbae Shin [Mon, 18 Apr 2022 11:37:20 +0000 (20:37 +0900)]
Refactoring option validity check

Change-Id: I2c52e90639fb1766e808c85143c1c9592e42ed29

2 years agoAdd JPEG-XL decode/encode functions 81/273681/14 accepted/tizen/unified/20220424.221513 submit/tizen/20220422.045752
jiyong.min [Tue, 12 Apr 2022 08:19:35 +0000 (17:19 +0900)]
Add JPEG-XL decode/encode functions

Change-Id: I970b99074965a0374cd61ecd2484091ba5e88d56

2 years agocode refactoring. move '_enc_opt_' functions from magick to common 59/273659/6
jiyong.min [Mon, 11 Apr 2022 07:41:33 +0000 (16:41 +0900)]
code refactoring. move '_enc_opt_' functions from magick to common

- To use the same function in new library,
 the functions have been moved from 'mmutil_magick' to 'mmutil_common'.

Change-Id: I7fa200722942c2196249ecd7f75acfbe0bd80a57

2 years agoUpdate debug message 25/270725/1
backto.kim [Tue, 8 Feb 2022 05:33:50 +0000 (14:33 +0900)]
Update debug message

Change-Id: I2a4a527d909cba242eb88a9b4d38172f2f8c0596

2 years agoRemove useless code 08/270708/3
backto.kim [Tue, 8 Feb 2022 03:22:29 +0000 (12:22 +0900)]
Remove useless code

As NEON is no longer used, there is no need for a code that distinguishes GST from NEON.

Change-Id: I8d803a9113f1e93db4be931638b4d9fd008e9680

2 years agoRemove unused NEON related code 01/270701/5
backto.kim [Tue, 8 Feb 2022 02:41:15 +0000 (11:41 +0900)]
Remove unused NEON related code

Change-Id: If08477432961b5115d5d6f1ce558a1e54d606792

2 years agoFix wrong function parameter type 02/270702/1
backto.kim [Tue, 8 Feb 2022 02:45:37 +0000 (11:45 +0900)]
Fix wrong function parameter type

Change-Id: I537f3b750ae846a5d5938008e776fba9642e9f46

2 years agoreplace g_memdup() to g_memdup2() 92/267892/2 accepted/tizen/unified/20211222.230459 submit/tizen/20211212.233427
Jiyong Min [Mon, 13 Dec 2021 04:17:50 +0000 (13:17 +0900)]
replace g_memdup() to g_memdup2()

  - g_memdup() was removed in glib2

Change-Id: I6b2554e5e48d582c978d70dc097a60078fa52b6d

2 years agobug fix. add the set of yuv colorspace for jpeg 03/260803/2 accepted/tizen/6.5/unified/20211028.115657 accepted/tizen/unified/20210707.070854 submit/tizen/20210706.071755 submit/tizen_6.5/20211028.162401 tizen_6.5.m2_release
Jiyong Min [Fri, 2 Jul 2021 04:11:36 +0000 (13:11 +0900)]
bug fix. add the set of yuv colorspace for jpeg

  [Problem]
    Decoding jpeg with yuv colorspace return broken image.
  [Cause]
    The j_color_space for yuv was not set.
  [Solution]
    We add the set of yuv colorspace for jpeg.

Change-Id: Ie5567948802c999ebdfddd998c02cee5edf3f03c

3 years agoAdd heif image decoder 72/255072/11 accepted/tizen/unified/20210317.115910 submit/tizen/20210316.062438
jiyong.min [Thu, 11 Mar 2021 22:42:31 +0000 (07:42 +0900)]
Add heif image decoder

Change-Id: I767494f893f5aa4c53de0a442137d2d9304d465f

3 years agoBuild error fix after applying GraphicsMagick 2.0.6 96/248896/4 accepted/tizen/unified/20201209.124934 submit/tizen/20201207.024518
hj kim [Thu, 3 Dec 2020 05:36:56 +0000 (14:36 +0900)]
Build error fix after applying GraphicsMagick 2.0.6

Change-Id: I66d9f0d078202d460ad8ea94161e8777d28903f6

3 years ago[0.2.4] add so file to package 89/245189/2 accepted/tizen/unified/20201102.124426 submit/tizen/20201028.052639
Eunhye Choi [Mon, 5 Oct 2020 07:41:53 +0000 (16:41 +0900)]
[0.2.4] add so file to package

- add common / imgp so file to package

Change-Id: I646fcf00de53b74e12e55e3191819c3c1dc8d09e

3 years agoFix memory leak for 'intermediate_image' 59/244159/2 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.114515 accepted/tizen/6.0/unified/hotfix/20201103.002757 accepted/tizen/unified/20200917.141755 submit/tizen/20200916.012329 submit/tizen/20200917.011112 submit/tizen_6.0/20201029.205104 submit/tizen_6.0_hotfix/20201102.192504 submit/tizen_6.0_hotfix/20201103.114804 tizen_6.0.m2_release
jiyong.min [Tue, 15 Sep 2020 09:30:06 +0000 (18:30 +0900)]
Fix memory leak for 'intermediate_image'

Change-Id: Ia8be69d954733c220e13a762fd601babe98e9b9c

3 years agoFix incorrect parameters for cropping image 58/243658/2 accepted/tizen/unified/20200910.123850 submit/tizen/20200909.052036
jiyong.min [Wed, 9 Sep 2020 02:59:31 +0000 (11:59 +0900)]
Fix incorrect parameters for cropping image

  - Problem:
    rotate_image with odd width/height image return error.

  - Cause:
    Cropping image for odd width/height image has incorrect parameters.

  - Solution:
    The start_x, start_y should be used for sx, sy of cropping image.

Change-Id: I8003dac4392823666bac98fa8a30771f367013e3

3 years agoMinor change and release version 0.2.2 53/243353/2 accepted/tizen/unified/20200908.003017 submit/tizen/20200907.045722
jiyong.min [Mon, 7 Sep 2020 02:57:17 +0000 (11:57 +0900)]
Minor change and release version 0.2.2

Change-Id: I5665cc1dd1200c9d3b3540e88e6c2e47dcfb80fc

3 years agoFix incorrect return for invalid parameter 42/243342/1
jiyong.min [Mon, 7 Sep 2020 01:21:39 +0000 (10:21 +0900)]
Fix incorrect return for invalid parameter

Change-Id: I7649e1dbe6ab51145be3372599ad1e86d8752955

3 years agoEnhance error handling for save functions in webp 41/243341/1
jiyong.min [Mon, 7 Sep 2020 01:16:56 +0000 (10:16 +0900)]
Enhance error handling for save functions in webp

  - Add to check invalid parameters
  - Add to check frame_count for no animation

Change-Id: Idc5875c9d8c3f3336f997a63746a35d7429d25a1

3 years agoAdd animated image encoder for both WEBP and GIF 00/239600/12 accepted/tizen/unified/20200828.121607 submit/tizen/20200827.013104
jiyong.min [Tue, 28 Jul 2020 05:21:21 +0000 (14:21 +0900)]
Add animated image encoder for both WEBP and GIF

  - Unify 'mm_util_anim_xxx' function for animated WEBP and GIF
  - Add 'anim_module_register' function for dlopen of each codec

Change-Id: I50bcd6c61228c1f3be92ef65e65ec4145825506a

3 years agoModify return error for not supported format 72/240372/4 accepted/tizen/unified/20200811.050353 accepted/tizen/unified/20200813.122640 submit/tizen/20200806.045222 submit/tizen/20200810.061454 submit/tizen/20200812.084418
jiyong.min [Thu, 6 Aug 2020 01:19:05 +0000 (10:19 +0900)]
Modify return error for not supported format

Change-Id: I053f6cc8875fee24fc9c88cf778167e5ecd2a4dc

3 years agoSupport new animation encoding function for WebP 05/237605/24
jiyong.min [Wed, 1 Jul 2020 23:11:35 +0000 (08:11 +0900)]
Support new animation encoding function for WebP

Change-Id: I2f7f481ca2ce518284eee3b1ffb0208f479d8c00

3 years agoAdd to use GraphicsMagick when webp format encoding and decoding 54/237654/18 submit/tizen/20200803.051111 submit/tizen/20200804.230708
jiyong.min [Thu, 2 Jul 2020 06:58:38 +0000 (15:58 +0900)]
Add to use GraphicsMagick when webp format encoding and decoding

Change-Id: Ic30a3d8d45a9a70fcdec37da60d7bb5069612f74

3 years agoFix 'g_readed_data' double free 00/239100/1 accepted/tizen/unified/20200723.161301 submit/tizen/20200722.020114
jiyong.min [Wed, 22 Jul 2020 00:12:05 +0000 (09:12 +0900)]
Fix 'g_readed_data' double free

Change-Id: Ib784ddeed989495eea06ce7c77d32d0d637b133a

3 years agoFix memory leak if function is called 93/239093/2
jiyong.min [Tue, 21 Jul 2020 22:51:40 +0000 (07:51 +0900)]
Fix memory leak if function is called

  - gif_file->filename in mm_util_gif_encode_set_file()
  - gif_file_h in mm_util_encode_to_gif_file()

Change-Id: I8c59125ff168f716124e7ce95a907016cf0ca107

3 years agoFix out of bound issue for 'signature_info' array 06/239006/6
jiyong.min [Tue, 21 Jul 2020 04:29:11 +0000 (13:29 +0900)]
Fix out of bound issue for 'signature_info' array

  - #IMG_CODEC_UNKNOWN_TYPE is larger than the size of 'signature_info' array.
    Because mm_util_img_codec_type increases sequentially no longer,
    we can't use '_type' for loop of 'signature_info' array.
    The size of 'signature_info' and index for loop have been added.

Change-Id: I2196238e83a78c397d59be8187f46cce221c860b

3 years agoRemove tabs and unused description 38/238738/3 accepted/tizen/unified/20200722.014854 submit/tizen/20200721.001655
jiyong.min [Fri, 17 Jul 2020 02:19:23 +0000 (11:19 +0900)]
Remove tabs and unused description

Change-Id: I3f4b4cdc0717a674f2174bbfdfdf1f2c3c4a5dcb

3 years agoUse GraphicksMagicK instead of libpng when png format encodeing and decoding 71/237971/11
hj kim [Tue, 7 Jul 2020 05:26:53 +0000 (14:26 +0900)]
Use GraphicksMagicK instead of libpng when png format encodeing and decoding

GraphicksMagicK supports PNG, so remove libpng dependency

Change-Id: Ie4f2ab40ea3425c37de319bbe8f82708800911ba

3 years agoFix wrong order 73/238673/3 accepted/tizen/unified/20200717.124749 submit/tizen/20200715.035035
hj kim [Thu, 16 Jul 2020 07:16:05 +0000 (16:16 +0900)]
Fix wrong order

Change-Id: I73fb5eb9192c1ee19f844e87cbdad5e672baa79e

3 years agoChange return value for not supported format 66/238666/4
hj kim [Thu, 16 Jul 2020 06:25:15 +0000 (15:25 +0900)]
Change return value for not supported format

Change-Id: I2af6391fe7ec30a251390a80c62130e3cd61aca2

3 years agoAdd APIs for encoding options to use Magick APIs. 49/238249/15
hj kim [Fri, 10 Jul 2020 03:48:04 +0000 (12:48 +0900)]
Add APIs for encoding options to use Magick APIs.

Now only BMP format uses MagicK for encoding.
Other formats such as PNG, WEBP, JPEG uses their own library. (eg. libjpeg, libpng etc)
But MagicK supports all those kind of formats. so we will cover all format with MagicK.
Each format has specific options when encoding but current functions didn't consider that.
So new APIs for encoding options has been added.

Change-Id: I1b5908d6176c5d55f7abcc68f88b3bebf07b9eb3

3 years agoVersion up (0.1.46 -> 0.1.47) 65/238265/1 accepted/tizen/unified/20200713.094503 submit/tizen/20200710.064028
hj kim [Fri, 10 Jul 2020 05:54:04 +0000 (14:54 +0900)]
Version up (0.1.46 -> 0.1.47)

Change-Id: Ie4ad75d0c7052b9044429d6da163b4b8c3a9f81b

3 years agoImprove __mm_util_get_map() 05/238205/4
hj kim [Thu, 9 Jul 2020 09:30:27 +0000 (18:30 +0900)]
Improve __mm_util_get_map()

Modify to return const char *

Change-Id: I1dd26c3904a88cb74fdaf73785386b67c61f7a63

3 years agoImprove __mm_util_constitute_image() 90/238190/6
hj kim [Thu, 9 Jul 2020 08:15:57 +0000 (17:15 +0900)]
Improve __mm_util_constitute_image()

Modify to get map info in this function. because this function can get map info from input handle

Change-Id: If0885ee02d5c1a21f6db29fdf609e35d7fdc049b

3 years agoChange function name __mm_util_write_image_to_buffer() to __mm_util_dispatch_image() 51/238251/3
hj kim [Fri, 10 Jul 2020 03:59:41 +0000 (12:59 +0900)]
Change function name __mm_util_write_image_to_buffer() to __mm_util_dispatch_image()

Change-Id: Id7b1a774915010c546fccf682b210ea668d06430

3 years agoImprove __mm_util_write_image_to_buffer() 87/238187/8
hj kim [Thu, 9 Jul 2020 07:49:34 +0000 (16:49 +0900)]
Improve __mm_util_write_image_to_buffer()

Unify duplicated API calls into __mm_util_write_image_to_buffer() and remove some parameters which can get from Image

Change-Id: If6110833c305fcc265618ac2f1f139ed45909c99

3 years agoRemove unhelpful msg 09/238009/3
hj kim [Tue, 7 Jul 2020 09:42:00 +0000 (18:42 +0900)]
Remove unhelpful msg

Change-Id: I56a0755f6635d3e9a9d8114960718b0b45afd6f7

3 years agoCode refactoring for 'mm_util_extract_image_info' 13/237213/13 accepted/tizen/unified/20200702.141801 submit/tizen/20200701.023736
jiyong.min [Fri, 26 Jun 2020 03:47:54 +0000 (12:47 +0900)]
Code refactoring for 'mm_util_extract_image_info'

Change-Id: I1024be716a81e647e4820d649ecf4cba5d6b509f

3 years agoCode cleanup. change the location of getting file extension and optimization 16/237116/5
jiyong.min [Thu, 25 Jun 2020 05:29:13 +0000 (14:29 +0900)]
Code cleanup. change the location of getting file extension and optimization

  - Only wbmp needs the file extension.

Change-Id: Ibb89b8d79c1561301fd4cdd77a474bc03a3eebc4

3 years agoCode cleanup. remove unnecessary code 15/237115/1
jiyong.min [Thu, 25 Jun 2020 05:17:06 +0000 (14:17 +0900)]
Code cleanup. remove unnecessary code

Change-Id: I79fcd37138d1739e30e2b00f3e7c1166377166fc

3 years agoRelease version 0.1.45 14/236314/1 accepted/tizen/unified/20200624.130223 submit/tizen/20200623.070108
jiyong.min [Tue, 16 Jun 2020 07:00:50 +0000 (16:00 +0900)]
Release version 0.1.45

Change-Id: I8d641ba8b07c4c22ff4546b74a87ae7dba55b9d9

3 years agoadd converting grayscale image into defaults when generating thumbnail 93/236093/6
jiyong.min [Mon, 15 Jun 2020 00:09:50 +0000 (09:09 +0900)]
add converting grayscale image into defaults when generating thumbnail

  Problem. A thumbnail of grayscale image was not visible
  - Cause: Grayscale image was not supported by graphics
  - Solution: Add converting grayscale into defaults(rgb or true-color)

Change-Id: Ibaa1617834de6646e673b6bbc82ae8ec403b5788

4 years agoCode cleanup for mm_util_image_h 11/234811/1
jiyong.min [Fri, 29 May 2020 03:18:44 +0000 (12:18 +0900)]
Code cleanup for mm_util_image_h

Change-Id: I4b41dcf9f1ff610edeef907884e1495687d15467

4 years agoRemove unused bmp codes 49/234749/2 accepted/tizen/unified/20200601.051557 submit/tizen/20200529.005835
hj kim [Thu, 28 May 2020 09:08:33 +0000 (18:08 +0900)]
Remove unused bmp codes

mmutil-bmp was just a wrapper of mmutil-magick.
and modules which used mmutil-bmp has been mofied to use mmutil-magick.
So remove it.

Change-Id: Ie3819fa4890308d7fbe9d4de94a33662b1bbc0ad

4 years agoFix unsuitable name 48/234748/1
hj kim [Thu, 28 May 2020 09:07:29 +0000 (18:07 +0900)]
Fix unsuitable name

Change-Id: Id2c07c745bf7157437aa448e185e087151ed6994

4 years agoFixed issue that the decoded image of 8-bit grayscale PNG was broken 85/234585/9 accepted/tizen/unified/20200529.124234 submit/tizen/20200528.071852
jiyong.min [Wed, 27 May 2020 08:07:04 +0000 (17:07 +0900)]
Fixed issue that the decoded image of 8-bit grayscale PNG was broken

  - cause:
    Libpng can trans gray to rgb if png is gray or gray with alpha.
    But decoding png set trans using 'png_set_gray_to_rgb()' if png is only
    grayscale with alpha.

  - solution:
    Set trans gray to rgb using 'png_set_gray_to_rgb' if png is gray or
    gray with alpha. Decoding the png should return only the rgba image,
    so converting rgb to rgba is also added.

Change-Id: Id99e25070890283e79af45f438dcb4c767575c3f

4 years agoRemove EXIF when creating thumbnails 05/233905/1
Minje Ahn [Wed, 20 May 2020 07:49:07 +0000 (16:49 +0900)]
Remove EXIF when creating thumbnails

Rotate image instead

Change-Id: I56b289ea683671f040d55daf17e818b7cc879599
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUnify rotate type enum 03/232203/6 accepted/tizen/unified/20200507.052252 submit/tizen/20200506.063025
jiyong.min [Wed, 29 Apr 2020 03:59:22 +0000 (12:59 +0900)]
Unify rotate type enum

  - 'mm_util_img_rotate_type' and 'mm_util_magick_rotate_type' had duplicated enum type.
    So we unified the type to 'mm_util_rotate_type_e'.

Change-Id: I48bf39b0b2e8731d4fa4ad3846c181a19712be99

4 years agoRemove out of memory related code by using glib APIs 83/230983/16 accepted/tizen/unified/20200429.032902 submit/tizen/20200428.070655
hj kim [Thu, 16 Apr 2020 09:32:00 +0000 (18:32 +0900)]
Remove out of memory related code by using glib APIs

glib's memory managed as below.
If any call to allocate memory fails, the application is terminated. This also means that there is no need to check if the call succeeded.

Change-Id: Ib9fc815db542efcf9c5e62e8cb6cc7df684b574b

4 years agoRemove unnecessary codes 47/232047/2
hj kim [Tue, 28 Apr 2020 01:31:50 +0000 (10:31 +0900)]
Remove unnecessary codes

Change-Id: I042a58439b3169ed2fd5455ccedcc3f56a2cbab7

4 years agoMerge "Use g_free directly and remove macro" into tizen
hj kim [Tue, 28 Apr 2020 00:42:18 +0000 (00:42 +0000)]
Merge "Use g_free directly and remove macro" into tizen

4 years agoUse g_free directly and remove macro 99/231999/3
hj kim [Mon, 27 Apr 2020 08:16:49 +0000 (17:16 +0900)]
Use g_free directly and remove macro

Change-Id: I98388a5d62c19b8029a58adc94da83f924fa150e

4 years agoUse g_free() instead of free() 98/231998/1
hj kim [Mon, 27 Apr 2020 08:10:29 +0000 (17:10 +0900)]
Use g_free() instead of free()

Change-Id: I617cae832883701249caf82606e37cf7b1a48aa9

4 years agoimprove __gif_make_color_map() not to use input parameter directly 51/231551/5
hj kim [Wed, 22 Apr 2020 09:24:19 +0000 (18:24 +0900)]
improve __gif_make_color_map() not to use input parameter directly

Change-Id: Iad6fab9bb9e60c4967c10d2a7999c2f7063094dc

4 years agoMerge "Fix wrong debug msg" into tizen
hj kim [Mon, 27 Apr 2020 03:17:59 +0000 (03:17 +0000)]
Merge "Fix wrong debug msg" into tizen

4 years agoFix wrong debug msg 13/231813/1
hj kim [Fri, 24 Apr 2020 08:41:46 +0000 (17:41 +0900)]
Fix wrong debug msg

Change-Id: I9dfd98dcfdca6bc53c4fda453c50dcd3a2bdca34

4 years agoFix wrong value assign 35/231735/3
hj kim [Fri, 24 Apr 2020 04:03:18 +0000 (04:03 +0000)]
Fix wrong value assign

This reverts commit 7558e56e65499de257a6056415ede8fb0eb1b2aa.

Change-Id: I11c9c4246d8a594cc5f41febaab81242d726e2d0

4 years agoRemove RGB_ALLOC() and RGB_FREE() 00/231600/1
hj kim [Thu, 23 Apr 2020 03:09:10 +0000 (12:09 +0900)]
Remove RGB_ALLOC() and RGB_FREE()

Change-Id: I74ba7e407f0e265d17329786601ef42f37fb0697

4 years agoFix memory leak 67/231067/2 accepted/tizen/unified/20200424.141608 submit/tizen/20200422.053736 submit/tizen/20200423.093243
hj kim [Fri, 17 Apr 2020 05:33:59 +0000 (14:33 +0900)]
Fix memory leak

when release resources by using mm_image_destroy_image(), data is not released when size is TEMP_DATA_SIZE

Change-Id: I0257257849a10a7a1dc78e1ddb042adb16575e84

4 years agoRemove unused API 59/231059/1
hj kim [Fri, 17 Apr 2020 05:22:52 +0000 (14:22 +0900)]
Remove unused API

Change-Id: I7762e27393ab31c7d809c0471b4b8dcbe1a9421b

4 years agoBump to 0.1.40 21/230921/2 accepted/tizen/unified/20200420.142650 submit/tizen/20200416.091150 submit/tizen/20200419.223245
jiyong.min [Thu, 16 Apr 2020 04:37:38 +0000 (13:37 +0900)]
Bump to 0.1.40

Change-Id: Iaa1f59c47c9996262565814c117d739c66af6c2a

4 years agoAdd new function to resize and rotate with exif orientation 20/230920/3
jiyong.min [Thu, 16 Apr 2020 04:36:28 +0000 (13:36 +0900)]
Add new function to resize and rotate with exif orientation

Change-Id: I9535f30314911e2ffab25978e1df874af851e570

4 years agoMigration to Opencv 4.2.0 85/229985/3 accepted/tizen/unified/20200417.152825 submit/tizen/20200407.083853 submit/tizen/20200410.044903 submit/tizen/20200414.011245
Tae-Young Chung [Tue, 7 Apr 2020 04:40:32 +0000 (13:40 +0900)]
Migration to Opencv 4.2.0

While migration, refactoring imgcv by changing
legacy opencv c api to c++.

Change-Id: I105315cda1aceee912a7576347de0466673af1e9
Signed-off-by: Tae-Young Chung <ty83.chung@samsung.com>
4 years agoUse DestroyImageList instead of DestroyImage 98/229198/4 accepted/tizen/unified/20200331.030826 submit/tizen/20200330.082244
Minje Ahn [Mon, 30 Mar 2020 08:06:39 +0000 (17:06 +0900)]
Use DestroyImageList instead of DestroyImage

If input image type is agif, returned Image structure is list.

Change-Id: Ibfbd7be3f6c253a80fe71ebd69fc614798d4d10a
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoReplace BMP encoder from libbmp to GraphicsMagick 13/228413/14
jiyong.min [Mon, 23 Mar 2020 02:40:13 +0000 (11:40 +0900)]
Replace BMP encoder from libbmp to GraphicsMagick

  - There are two open sources that have same BMP encoder, Libbmp and
    GraphicsMagick. Libbmp is only used for encoding BMP of libmm-utility.
    The libbmp can be removed from build after replacing it.

  - Libbmp dependency
    https://github.sec.samsung.net/pages/oslim/dash/dependency_checker/tizen60_common/libbmp.svg

Change-Id: Idd38cb29d47b27be7b27be5b388319af1561c690

4 years agoReplace BMP decoder from libnsbmp to GraphicsMagick 80/227980/9
jiyong.min [Wed, 18 Mar 2020 00:53:45 +0000 (09:53 +0900)]
Replace BMP decoder from libnsbmp to GraphicsMagick

  - There are two open sources that have same BMP decoder, Libnsbmp and
    GraphicsMagick. Libnsbmp is only used for decoding BMP of libmm-utility.
    Libnsbmp can be removed from the build after replacing it.

  - Libnsbmp dependency
    https://github.sec.samsung.net/pages/oslim/dash/dependency_checker/tizen60_common/libnsbmp.svg

Change-Id: I644c7ecb23724f67c1a82602aa09b71e2f8d2932

4 years agoRearrange 'ImageInfo' variables 79/227979/3
jiyong.min [Wed, 18 Mar 2020 00:39:05 +0000 (09:39 +0900)]
Rearrange 'ImageInfo' variables

Change-Id: I4cc4521edfcc8cfabd4780bc2d0742dc6994a8b1

4 years agoRemove void return and null check 73/227973/1
jiyong.min [Wed, 18 Mar 2020 00:29:26 +0000 (09:29 +0900)]
Remove void return and null check

Change-Id: I2352805413ea9c0ecb1512935b6c1649c65b44de

4 years agoRemove unused libraries from imgcv 72/227972/3
jiyong.min [Mon, 24 Feb 2020 03:39:08 +0000 (12:39 +0900)]
Remove unused libraries from imgcv

Change-Id: Ie5c68399bcb13f1bf9d91b0a490fd580a3df4a37

4 years agoFix coverity issue 47/224347/1 accepted/tizen/unified/20200211.055805 submit/tizen/20200210.061949
jiyong.min [Mon, 10 Feb 2020 04:30:09 +0000 (13:30 +0900)]
Fix coverity issue

 - Untrusted value as argument

Change-Id: I369d575a1299a0961ea9506fc42c552e71d48cab

4 years agoFix build error for giflib 5.1.9 74/223774/1
jiyong.min [Mon, 3 Feb 2020 23:29:45 +0000 (08:29 +0900)]
Fix build error for giflib 5.1.9

 - The 'gifutil' library has been added for deprecated 'GifQuantizeBuffer' function.
   It should be removed since giflib 5.2.0.

Change-Id: I263e3fa3cb4ae8622c70b16f4799f83429602141

4 years agoCode refactoring for internal functions 20/221220/7 accepted/tizen/unified/20200105.221208 submit/tizen/20200102.062143
jiyong.min [Mon, 30 Dec 2019 05:17:57 +0000 (14:17 +0900)]
Code refactoring for internal functions

Change-Id: I438990856d26110827c3158e12866958dfc6b73b

4 years agoFix build error for toolchin upgrade (GCC6->GCC9) 63/220963/4 accepted/tizen/unified/20191227.142830 submit/tizen/20191226.093041
hj kim [Thu, 26 Dec 2019 05:51:31 +0000 (14:51 +0900)]
Fix build error for toolchin upgrade (GCC6->GCC9)

Change-Id: I5bd86f90015b851060edd47e32e9fbde3e2fd35a

4 years agoBump version to 0.1.33 47/215147/2 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.021526 accepted/tizen/5.5/unified/mobile/hotfix/20201027.083712 accepted/tizen/unified/20191007.234912 submit/tizen/20191007.065948 submit/tizen_5.5/20191031.000004 submit/tizen_5.5_mobile_hotfix/20201026.185103 tizen_5.5.m2_release
jiyong.min [Wed, 2 Oct 2019 04:13:15 +0000 (13:13 +0900)]
Bump version to 0.1.33

 - decode/encode jpeg has been improved to reduce Cyclomatic Complexity

Change-Id: I083ed3f76b7c9608c77aa7dd5128d9212695c78d

4 years agoModify jpeg encode for yuv to reduce Cyclomatic Complexity 46/215146/1
jiyong.min [Wed, 2 Oct 2019 04:11:02 +0000 (13:11 +0900)]
Modify jpeg encode for yuv to reduce Cyclomatic Complexity

Change-Id: I1c39262ca93e0fe1daba718cfd9f1f4d3a64b598

4 years agoRename few variables and replace int to unsigned int 45/215145/1
jiyong.min [Wed, 2 Oct 2019 02:13:21 +0000 (11:13 +0900)]
Rename few variables and replace int to unsigned int

 - libjpeg use unsignd int for width & height

Change-Id: I5c8d2acf95e9c08f97a1ae093f81bdb682dd3f7b

4 years agoModify jpeg open and set parameters 44/215144/1
jiyong.min [Wed, 2 Oct 2019 01:50:47 +0000 (10:50 +0900)]
Modify jpeg open and set parameters

Change-Id: I1e0e07f2de6125e9062d3ed3bbfb191d480adaab

4 years agoModify getting rgb colorspace and buffer size 43/215143/1
jiyong.min [Wed, 2 Oct 2019 01:17:27 +0000 (10:17 +0900)]
Modify getting rgb colorspace and buffer size

Change-Id: Icc70a773c0b3214499726d3387fb8202b9420bd0

4 years agoModify duplicated code for error handler and resource release. 42/215142/1
jiyong.min [Wed, 2 Oct 2019 00:44:53 +0000 (09:44 +0900)]
Modify duplicated code for error handler and resource release.

Change-Id: I3f5d1b01ccfedf81fff80489a74c2a2459a90b85

4 years agoModify simple bugs and internal function name 41/215141/1
jiyong.min [Wed, 2 Oct 2019 00:34:54 +0000 (09:34 +0900)]
Modify simple bugs and internal function name

Change-Id: I7ae768144840b4c8ec895372215e9efe2fd84059

4 years agoBump version to 0.1.32 40/215140/1
jiyong.min [Wed, 2 Oct 2019 00:30:27 +0000 (09:30 +0900)]
Bump version to 0.1.32

 - reading gif has been improved

Change-Id: Iba712ef4dd3ded2a64958adea99967d93ed0e801

4 years agoImprove '__read_gif()' function to reduce Cyclomatic Complexity 22/214822/4
jiyong.min [Fri, 27 Sep 2019 00:41:29 +0000 (09:41 +0900)]
Improve '__read_gif()' function to reduce Cyclomatic Complexity

Change-Id: I1551e9c5019fcdb74aa7defb74ceb2245f823316

4 years agoDeallocate resouces to prevent resource leak 59/212059/2 accepted/tizen/unified/20190822.045404 submit/tizen/20190820.233532
jiyong.min [Wed, 14 Aug 2019 01:20:30 +0000 (10:20 +0900)]
Deallocate resouces to prevent resource leak

 - Resource leaks were detected by static analyzer

Change-Id: I94dfc503d0d364eb738b4ac1caff5f2a4d89d56f

5 years agoAdd message for mm_util_create_image() to debug wrong parameter 25/205725/2
jiyong.min [Wed, 8 May 2019 23:40:10 +0000 (08:40 +0900)]
Add message for mm_util_create_image() to debug wrong parameter

Change-Id: I940f18a179663ceae9b61e14919cb1ad1b430e60

5 years agoRemove unneccessary header and enumerable 04/203104/1
jiyong.min [Wed, 10 Apr 2019 01:58:32 +0000 (10:58 +0900)]
Remove unneccessary header and enumerable

 - mm_util_gif_private.h has been removed.
 - mm_util_gif_disposal has been replaced to defined value of giflib.

Change-Id: I79ab50593681010900bbb66b21c9fa3981990601

5 years agoFix 64-bit build error 90/202190/1 accepted/tizen/unified/20190326.073434 submit/tizen/20190325.074339
jiyong.min [Mon, 25 Mar 2019 22:20:23 +0000 (07:20 +0900)]
Fix 64-bit build error

Change-Id: Icb0bf922870660ce99c89f3acc7ee44702856bf8

5 years agoModify file permission in magick 29/201929/4
jiyong.min [Thu, 21 Mar 2019 04:01:02 +0000 (13:01 +0900)]
Modify file permission in magick

 - from 755 to 644

Change-Id: I7db52ee48ff995425276c516cf293ddbd8bf2108

5 years agoModify animated gif writing to file and to buffer 24/201924/5
jiyong.min [Thu, 21 Mar 2019 01:52:07 +0000 (10:52 +0900)]
Modify animated gif writing to file and to buffer

 - Encoding checked writing to file or to buffer during working. Encoding is
   no needed to check it because encoding use buffer to get intermediate output.
   After modifying it, it check writing to file or to buffer right before
   saving the final outcome.

Change-Id: I979720f1fe75dcdf9c2a08deb92e50b055cbfe68

5 years agoRename variables for buffer I/O in gif and png 10/201910/2
jiyong.min [Thu, 21 Mar 2019 01:22:28 +0000 (10:22 +0900)]
Rename variables for buffer I/O in gif and png

Change-Id: Ic30eb5dbd9731e7f7fd13561407741f348f36bf0