Yang Gu [Mon, 31 May 2010 11:13:22 +0000 (19:13 +0800)]
stktest: Add negative cases for setup menu
Yang Gu [Mon, 31 May 2010 11:13:21 +0000 (19:13 +0800)]
stk: Constraint the appearance of empty item
If empty item turns out, it must be the only item in the list.
So the following situations are deemed as invalid:
1. Two empty items
2. Valid item + empty item
3. empty + valid item
Denis Kenzior [Tue, 1 Jun 2010 19:01:48 +0000 (14:01 -0500)]
atgen: Don't use sim polling
Some modems get confused by the CSIM commands and reply with an error,
which we treat as sim not inserted.
Denis Kenzior [Tue, 1 Jun 2010 15:08:58 +0000 (10:08 -0500)]
test-sms: Add a unit test for the previous bugfix
Denis Kenzior [Tue, 1 Jun 2010 15:07:18 +0000 (10:07 -0500)]
smsutil: Don't overflow signed ints
We were overflowing the datatype which was causing the 31st segments to
be prepended at position 0. This resulted in (very) long messages being
improperly concatenated
Andrzej Zaborowski [Thu, 27 May 2010 04:59:59 +0000 (06:59 +0200)]
test-stkutil: Add Launch Browser response builder tests
Andrzej Zaborowski [Thu, 27 May 2010 04:59:58 +0000 (06:59 +0200)]
stkutil: Add Launch Browser response builder
Denis Kenzior [Fri, 28 May 2010 16:41:05 +0000 (11:41 -0500)]
test-stkutil: Fix issue with whitespace
Andrzej Zaborowski [Thu, 27 May 2010 04:59:57 +0000 (06:59 +0200)]
test-stkutil: Add Language Notification response
Andrzej Zaborowski [Thu, 27 May 2010 04:59:56 +0000 (06:59 +0200)]
stkutil: Add Language Notification response builder
Andrzej Zaborowski [Thu, 27 May 2010 04:59:55 +0000 (06:59 +0200)]
test-stkutil: Add the Send DTMF response tests
Andrzej Zaborowski [Thu, 27 May 2010 04:59:54 +0000 (06:59 +0200)]
stkutil: Add Send DTMF response builder support
Denis Kenzior [Fri, 28 May 2010 16:36:48 +0000 (11:36 -0500)]
stkutil: Fix comment style
Andrzej Zaborowski [Thu, 27 May 2010 04:59:53 +0000 (06:59 +0200)]
test-stkutil: Add Run AT Command response builder
Andrzej Zaborowski [Thu, 27 May 2010 04:59:52 +0000 (06:59 +0200)]
stkutil: Add the Run AT Command response builder
Andrzej Zaborowski [Thu, 27 May 2010 04:59:51 +0000 (06:59 +0200)]
test-stkutil: Add Set Up Idle Mode response builder
Andrzej Zaborowski [Thu, 27 May 2010 04:59:50 +0000 (06:59 +0200)]
stkutil: Add Set Up Idle Mode Text response builder
Andrzej Zaborowski [Thu, 27 May 2010 04:59:49 +0000 (06:59 +0200)]
test-stkutil: Add Timer Management response tests
Denis Kenzior [Fri, 28 May 2010 16:31:26 +0000 (11:31 -0500)]
stkutil: Fix style in build_dataobj_timer_value
Denis Kenzior [Fri, 28 May 2010 16:30:35 +0000 (11:30 -0500)]
stkutil: Fix style
Andrzej Zaborowski [Thu, 27 May 2010 04:59:48 +0000 (06:59 +0200)]
stkutil: Add the Timer Management response builder
Denis Kenzior [Fri, 28 May 2010 16:20:14 +0000 (11:20 -0500)]
stkutil: Use more understandable syntax
Denis Kenzior [Fri, 28 May 2010 15:57:57 +0000 (10:57 -0500)]
stkutil: Fix style
Denis Kenzior [Fri, 28 May 2010 15:57:37 +0000 (10:57 -0500)]
stkutil: Fix style in build_dataobj_location_info
Denis Kenzior [Fri, 28 May 2010 15:42:20 +0000 (10:42 -0500)]
stkutil: Fix some style issues with setup_call
Andrzej Zaborowski [Thu, 27 May 2010 04:59:47 +0000 (06:59 +0200)]
test-stkutil: Add a Set Up Event List response test
Andrzej Zaborowski [Thu, 27 May 2010 04:59:46 +0000 (06:59 +0200)]
stkutil: Add Set Up Event List response builder
Andrzej Zaborowski [Thu, 27 May 2010 04:59:45 +0000 (06:59 +0200)]
test-stkutil: Add Provide Local Info response tests
Andrzej Zaborowski [Thu, 27 May 2010 04:59:44 +0000 (06:59 +0200)]
stkutil: Add the Provide Local Info response builder
Andrzej Zaborowski [Thu, 27 May 2010 04:59:43 +0000 (06:59 +0200)]
test-stkutil: Add a Polling Off response test
Andrzej Zaborowski [Thu, 27 May 2010 04:59:42 +0000 (06:59 +0200)]
stkutil: Add Polling Off response builder support
Andrzej Zaborowski [Thu, 27 May 2010 04:59:41 +0000 (06:59 +0200)]
test-stkutil: Add Set Up Call response tests
Andrzej Zaborowski [Thu, 27 May 2010 04:59:40 +0000 (06:59 +0200)]
stkutil: Add Set Up Call response builder
Aki Niemi [Fri, 28 May 2010 15:16:41 +0000 (18:16 +0300)]
TODO: SMS Port Addressing Owner
Aki Niemi [Fri, 28 May 2010 15:08:09 +0000 (18:08 +0300)]
Add feature description for NITZ
Aki Niemi [Fri, 28 May 2010 15:07:59 +0000 (18:07 +0300)]
Remove NITZ from TODO
Denis Kenzior [Fri, 28 May 2010 14:50:53 +0000 (09:50 -0500)]
TODO: Don't use spam-protection
Per Marcel's suggestions
Inaky Perez-Gonzalez [Wed, 26 May 2010 19:49:25 +0000 (12:49 -0700)]
build: Fix install of udev rules in VPATH builds
When the build directory is different than the source directory, we
need to specify the source prefix to the original file we are
copying.
Inaky Perez-Gonzalez [Wed, 26 May 2010 19:49:23 +0000 (12:49 -0700)]
sms: Add some documentation
Add doc headers to ofono_sms_{create, register}
Inaky Perez-Gonzalez [Wed, 26 May 2010 19:49:22 +0000 (12:49 -0700)]
storage: add printf-like verification
Add __attribute__((format)) to {write, read}_file()
Inaky Perez-Gonzalez [Wed, 26 May 2010 19:49:16 +0000 (12:49 -0700)]
sms_send_message: add a short roadmap
Inaky Perez-Gonzalez [Wed, 26 May 2010 19:49:18 +0000 (12:49 -0700)]
smsutils: add some documentation
sms_assembly_add_fragment_backup: clarify how insertion spot is found
Pasi Miettinen [Fri, 28 May 2010 07:17:40 +0000 (10:17 +0300)]
TODO: Owner of Status report task
Pekka Pessi [Fri, 28 May 2010 09:30:06 +0000 (12:30 +0300)]
TODO: Flight mode owner
Marcel Holtmann [Fri, 28 May 2010 08:32:51 +0000 (10:32 +0200)]
Add array decoding for emergency numbers
Denis Kenzior [Thu, 27 May 2010 19:59:04 +0000 (14:59 -0500)]
test: Update list-modems to the new API
Denis Kenzior [Thu, 27 May 2010 19:58:29 +0000 (14:58 -0500)]
sim: move ServiceDiallingNumbers to ServiceNumbers
In line with the API documentation
Pekka Pessi [Thu, 27 May 2010 16:12:48 +0000 (19:12 +0300)]
isimodem: add set_online and post_online
Denis Kenzior [Thu, 27 May 2010 19:03:24 +0000 (14:03 -0500)]
isimodem: More cleanup of bad style
Pekka Pessi [Thu, 27 May 2010 16:12:47 +0000 (19:12 +0300)]
Fixed style issues in isimodem voicecall.
Pekka Pessi [Thu, 27 May 2010 16:12:46 +0000 (19:12 +0300)]
Eliminated bool, true and false from isimodem.
Pekka Pessi [Thu, 27 May 2010 16:12:45 +0000 (19:12 +0300)]
Eliminated bool, true and false from gisi
Pekka Pessi [Thu, 27 May 2010 16:12:43 +0000 (19:12 +0300)]
Use ofono_bool_t instead of bool in modem API.
Pekka Pessi [Thu, 27 May 2010 16:29:51 +0000 (19:29 +0300)]
modem: Fix inconsistent state
Keep modem state consistent if sim is removed while set_online
driver call is pending. This results in set_online callback being
called and modem entering an invalid state.
Denis Kenzior [Thu, 27 May 2010 17:36:47 +0000 (12:36 -0500)]
stkutil: Refactor parsing of data object lists
The old way wasn't working out for lists that are optional. This was
only a problem with the launch browser proactive command.
Yang Gu [Wed, 26 May 2010 14:39:14 +0000 (22:39 +0800)]
Move destructor prior to return
Yang Gu [Wed, 26 May 2010 14:39:13 +0000 (22:39 +0800)]
teststk: Add test for launch browser parser
Yang Gu [Wed, 26 May 2010 14:39:08 +0000 (22:39 +0800)]
stk: Add parser for launch browser commands
Denis Kenzior [Thu, 27 May 2010 14:26:45 +0000 (09:26 -0500)]
stkutil: Refactor SMS pdu parser
Denis Kenzior [Thu, 27 May 2010 14:25:48 +0000 (09:25 -0500)]
smsutil: add sms_decode_unpacked_stk_pdu function
Properly check the special 'packing required' sms pdus sent by SIM
toolkit.
Yang Gu [Wed, 26 May 2010 14:39:11 +0000 (22:39 +0800)]
stk: Fix the parser of send sms
Yang Gu [Wed, 26 May 2010 14:39:10 +0000 (22:39 +0800)]
test-stkutil: Add cases for send sms parser
Yang Gu [Wed, 26 May 2010 14:39:10 +0000 (22:39 +0800)]
smsutil: Check that udl is less than 140
Yang Gu [Wed, 26 May 2010 14:39:10 +0000 (22:39 +0800)]
teststk: Use check_common_text() to check string
Yang Gu [Wed, 26 May 2010 14:39:09 +0000 (22:39 +0800)]
teststk: Add check of len in byte array
Yang Gu [Thu, 27 May 2010 09:24:34 +0000 (17:24 +0800)]
teststk: Use sim bcd version
Yang Gu [Thu, 27 May 2010 09:24:33 +0000 (17:24 +0800)]
stk: Use sim bcd version
Pekka Pessi [Tue, 25 May 2010 21:14:41 +0000 (00:14 +0300)]
Add Online property to modem-api.txt
Pekka Pessi [Tue, 25 May 2010 21:14:39 +0000 (00:14 +0300)]
Add: test scripts online-modem and offline-modem
Denis Kenzior [Wed, 26 May 2010 22:45:06 +0000 (17:45 -0500)]
Fix: Go to online state if set_online is NULL
Denis Kenzior [Wed, 26 May 2010 22:43:01 +0000 (17:43 -0500)]
Refactor: no need for dummy_online_callback
Denis Kenzior [Wed, 26 May 2010 22:34:56 +0000 (17:34 -0500)]
Fix: Don't allow setting online before sim ready
Denis Kenzior [Wed, 26 May 2010 22:34:10 +0000 (17:34 -0500)]
Refactor: Break up set_online_callback
- Break up into two functions, one for online and one for offline
- No longer the need for online_pending variable
Denis Kenzior [Wed, 26 May 2010 22:32:28 +0000 (17:32 -0500)]
Add __ofono_error_not_available
Denis Kenzior [Wed, 26 May 2010 22:14:09 +0000 (17:14 -0500)]
Refactor: flush_atoms
The current implementation did not take care of the case where the head
of the list was removed
Denis Kenzior [Wed, 26 May 2010 20:19:07 +0000 (15:19 -0500)]
Refactor: Don't use ofono_ prefix
Only meant for oFono public API
Denis Kenzior [Wed, 26 May 2010 20:13:04 +0000 (15:13 -0500)]
Refactor: The macros are no longer needed
Denis Kenzior [Wed, 26 May 2010 20:09:40 +0000 (15:09 -0500)]
Refactor: Don't use ofono_ prefix
Only to be used for ofono public API
Denis Kenzior [Wed, 26 May 2010 20:09:11 +0000 (15:09 -0500)]
Refactor: Don't use ofono_ prefix
only meant for public API
Denis Kenzior [Wed, 26 May 2010 20:01:36 +0000 (15:01 -0500)]
Refactor: Don't use ofono_ prefix
ofono_ prefix is meant for public API
Denis Kenzior [Wed, 26 May 2010 19:25:38 +0000 (14:25 -0500)]
Fix: minor style issues
Pekka Pessi [Wed, 26 May 2010 14:58:06 +0000 (17:58 +0300)]
Add: Online property to modem
The online/offline state is changed with the new set_online() modem driver
method.
In order to track atoms, there are modem states as follows:
- OFONO_MODEM_STATE_POWER_OFF
- OFONO_MODEM_STATE_PRE_SIM
- OFONO_MODEM_STATE_OFFLINE
- OFONO_MODEM_STATE_ONLINE
Atoms are added with driver methods pre_sim(), post_sim() and post_online().
Atoms are removed by modem core when the state changes.
Marcel Holtmann [Wed, 26 May 2010 19:02:58 +0000 (21:02 +0200)]
Release 0.21
Marcel Holtmann [Wed, 26 May 2010 18:01:50 +0000 (20:01 +0200)]
Mention Kalle's contributions
Kalle Valo [Wed, 26 May 2010 15:36:21 +0000 (18:36 +0300)]
atmodem: fix crash during context deactivation
Ofono either crashed or busy looped with my Huawei E1552 3G modem when I
tried to deactivate GPRS context. The reason was that gcd->chat was
unreferenced already in setup_ppp() but the chat was still accessed
later in at_gprs_deactivate_primary().
To fix the problem, change the logic instead to suspend chat session
for PPP and resume when PPP has disconnected. Now it doesn't crash
anymore.
Deactivation still doesn't work properly with Huawei E1552, and most
probably with other Huawei modems, because the modem hangs up the chat
line after PPP deactivation. This needs to be fixed separately. The
workaround is to reboot the modem, for example physically unplug and plug
it in again.
Kalle Valo [Wed, 26 May 2010 15:36:15 +0000 (18:36 +0300)]
atmodem: refactor context deactivation
The old way of using CGACT is no longer needed. It is enough
that we shutdown PPP. Recommended by Denis.
Andrzej Zaborowski [Wed, 26 May 2010 03:59:40 +0000 (05:59 +0200)]
test-stkutil: Use gcc4.3 compatible initialisers.
Reformat according to ideas on IRC.
Aki Niemi [Wed, 26 May 2010 15:43:45 +0000 (18:43 +0300)]
Fix more-messages-to-send indicator
Set the mms indicator based on remaining segment count and not on the
message transmit queue status alone.
Denis Kenzior [Wed, 26 May 2010 15:00:02 +0000 (10:00 -0500)]
simutil: Make sim_adn_build use sim bcd
Denis Kenzior [Wed, 26 May 2010 14:58:47 +0000 (09:58 -0500)]
simutil: Add sim_encode_bcd_number
Denis Kenzior [Wed, 26 May 2010 14:51:51 +0000 (09:51 -0500)]
simutil: Make sim_adn_parse use sim bcd version
Denis Kenzior [Wed, 26 May 2010 14:50:51 +0000 (09:50 -0500)]
simutil: add sim_extract_bcd_number
Denis Kenzior [Wed, 26 May 2010 14:17:25 +0000 (09:17 -0500)]
smsutil: Update the doc for extract_bcd_number
Yang Gu [Wed, 19 May 2010 10:24:46 +0000 (18:24 +0800)]
teststk: Add test for language notification parser
Yang Gu [Wed, 19 May 2010 10:24:45 +0000 (18:24 +0800)]
stk: Add parser for language notification commands
Yang Gu [Wed, 19 May 2010 10:24:44 +0000 (18:24 +0800)]
test-stk: Add test for send dtmf parser
Yang Gu [Wed, 19 May 2010 10:24:43 +0000 (18:24 +0800)]
stk: Add parser for send dtmf commands
Yang Gu [Wed, 19 May 2010 10:24:42 +0000 (18:24 +0800)]
test-stk: Add test for run at command parser
Yang Gu [Wed, 19 May 2010 10:24:41 +0000 (18:24 +0800)]
stk: Add parser for run at command commands
Yang Gu [Wed, 19 May 2010 10:24:40 +0000 (18:24 +0800)]
test-stk: Add test for setup idle mode text parser