Felipe de Azevedo Piovezan [Sat, 17 Jun 2023 12:26:05 +0000 (08:26 -0400)]
[Coding style] Fix incorrect link syntax
Hui [Wed, 31 May 2023 09:49:56 +0000 (10:49 +0100)]
[libc++][NFC] Granularise <thread> header
- This was to make implementing jthread easier and requested in https://reviews.llvm.org/D151559
Differential Revision: https://reviews.llvm.org/D151792
Prajwal S N [Sat, 17 Jun 2023 10:02:32 +0000 (15:32 +0530)]
[docs] Fix link for static constructors article
It was previously present in the inline code block and did not work as a
hyperlink.
Reviewed By: yassingh
Differential Revision: https://reviews.llvm.org/D153061
Florian Hahn [Sat, 17 Jun 2023 09:15:15 +0000 (10:15 +0100)]
[AMDGPU] Update test after
abfeda5af329b58.
Florian Hahn [Sat, 17 Jun 2023 08:58:37 +0000 (09:58 +0100)]
[LSR] Consider post-inc form when creating extends/truncates.
GenerateTruncates at the moment creates extends/truncates for post-inc
uses of normalized expressions. For example, if an add rec of the form
{1,+,-1} is used outside the loop, the normalized form will use {1,+,-1}
instead of {0,+,-1}. When naively sign-extending the normalized
expression, it will get extended incorrectly to {1,+,-1} for the wider
type, if the backedge-taken count of the loop is 1.
To address this, the patch updates GenerateTruncates to check if the
LSRUse contains any fixups with PostIncLoops. If that's the case, first
de-normalize the expression, then perform the extend/truncate, then
normalize again.
There may be other places where similar checks are needed and the helper
can be generalized for those cases. I'd not be surprised if other subtle
mis-compiles are caused by this.
Fixes #38847.
Fixes #58039.
Fixes #62852.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D153004
Florian Hahn [Sat, 17 Jun 2023 08:56:59 +0000 (09:56 +0100)]
[LSR] Add test case for #58039.
Corentin Jabot [Sat, 17 Jun 2023 05:34:42 +0000 (08:34 +0300)]
[Clang] Add the list of core papers approved in Varna to the status page
Fangrui Song [Sat, 17 Jun 2023 06:46:36 +0000 (23:46 -0700)]
[Pseudo Probe] Make .pseudo_probe GC-able
* Add the SHF_LINK_ORDER flag so that the .pseudo_probe section is discarded when the associated text section is discarded.
* Add unique ID so that with `clang -ffunction-sections -fno-unique-section-names`, there is one separate .pseudo_probe for each text section (disambiguated by `.section ....,unique,id` in assembly)
The changes allow .pseudo_probe GC even if we don't place instrumented functions
in an IR comdat (see `getOrCreateFunctionComdat` in SampleProfileProbe.cpp).
Reviewed By: hoy
Differential Revision: https://reviews.llvm.org/D153189
Jay Foad [Fri, 16 Jun 2023 13:49:19 +0000 (14:49 +0100)]
[AMDGPU] Generate checks for load-constant tests
Differential Revision: https://reviews.llvm.org/D153139
Fangrui Song [Sat, 17 Jun 2023 05:19:32 +0000 (22:19 -0700)]
[bazel] Fix clang after D148094
Sergei Barannikov [Tue, 9 May 2023 15:55:59 +0000 (18:55 +0300)]
[clang][CodeGen] Break up TargetInfo.cpp [8/8]
This commit breaks up CodeGen/TargetInfo.cpp into a set of *.cpp files,
one file per target. There are no functional changes, mostly just code moving.
Non-code-moving changes are:
* A virtual destructor has been added to DefaultABIInfo to pin the vtable to a cpp file.
* A few methods of ABIInfo and DefaultABIInfo were split into declaration + definition
in order to reduce the number of transitive includes.
* Several functions that used to be static have been placed in clang::CodeGen
namespace so that they can be accessed from other cpp files.
RFC: https://discourse.llvm.org/t/rfc-splitting-clangs-targetinfo-cpp/69883
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D148094
Sergei Barannikov [Tue, 9 May 2023 15:41:05 +0000 (18:41 +0300)]
[clang][CodeGen] Break up TargetInfo.cpp [7/8]
Wrap calls to XXXTargetCodeGenInfo constructors into factory functions.
This allows moving implementations of TargetCodeGenInfo to dedicated cpp
files without a change.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D150215
Sindhu Chittireddy [Tue, 13 Jun 2023 21:37:58 +0000 (14:37 -0700)]
[NFC] Fix potential dereferencing of null return value.
Replace getAs with castAs and add assert if needed.
Differential Revision: https://reviews.llvm.org/D152977
Pranav Kant [Sat, 17 Jun 2023 02:57:46 +0000 (02:57 +0000)]
Weining Lu [Sat, 17 Jun 2023 01:46:40 +0000 (09:46 +0800)]
[LoongArch] Fix handling of the chain of CSRWR and CSRXCHG nodes
`LoongArchISD::CSRWR` has two results. The first is the result of
`loongarch.csrwr.[wd]` intrinsic and the second is the chain. But
currently the chain is not processed correctly when creating this
node, resulting in the `csrwr` instruction being optimized out when
the result is not used by anyone [1]. `LoongArchISD::CSRXCHG` has
the same issue.
This patch addresses this issue.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/loongarch/include/asm/loongarch.h?h=v6.4-rc6#n219
Reviewed By: hev
Differential Revision: https://reviews.llvm.org/D153120
Weining Lu [Sat, 17 Jun 2023 01:46:29 +0000 (09:46 +0800)]
[LoongArch][NFC] Precommit test for D153120 (the fix of CSRWR and CSRXCHG)
Reviewed By: xry111
Differential Revision: https://reviews.llvm.org/D153119
Ashay Rane [Fri, 16 Jun 2023 22:11:43 +0000 (17:11 -0500)]
[MLIR] Register all extensions in CAPI's RegisterEverything
The patch for promised interfaces (
a5ef51d7) doesn't register all
extensions in the CAPI's `mlirRegisterAllDialects()` function. This is
used by the MLIR Python bindings, causing downstream users of the Python
bindings to terminate abruptly. This patch adds the call to register
all extensions.
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D153174
LiaoChunyu [Sat, 17 Jun 2023 01:33:48 +0000 (09:33 +0800)]
[RISCV] Fold special case (xor (setcc constant, y, setlt), 1) -> (setcc y, constant + 1, setlt)
Improve D151719.
(xor (setcc constant, y, setlt), 1) -> (setcc y, constant + 1, setlt)
https://alive2.llvm.org/ce/z/BZNEia
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D152128
Matt Arsenault [Sat, 5 Nov 2022 20:07:49 +0000 (13:07 -0700)]
clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins
This makes the scope and ordering arguments actually do something.
Also add some new OpenCL tests since the existing HIP tests didn't
cover address spaces.
Fangrui Song [Sat, 17 Jun 2023 00:08:58 +0000 (17:08 -0700)]
[MC] Restore a special case to support limited A-B folding when A/B are in the same fragment being laided out
Add subsection-if.s to test what we can fold (in the same fragment) and what we cannot.
Fix https://github.com/ClangBuiltLinux/linux/issues/1876
Fixes:
4bdc7f7a331f82cca1637388cf68bdc5b32ab43b
Owen Pan [Wed, 14 Jun 2023 22:06:17 +0000 (15:06 -0700)]
Reland [clang-format] Fix overlapping whitespace replacements before PPDirective
If the first token of an annotated line already has a computed Newlines,
reuse it to avoid potential overlapping whitespace replacements before
preprocessor branching directives.
Fixes #62892.
Differential Revision: https://reviews.llvm.org/D151954
Daniel Thornburgh [Fri, 16 Jun 2023 23:54:43 +0000 (16:54 -0700)]
[Fuchsia] Forward libedit flags to stage2
Philip Reames [Fri, 16 Jun 2023 23:47:39 +0000 (16:47 -0700)]
[RISCV] Fix a latent miscompile in doPeepholeMaskedRVV
The code was using the tail policy being "agnostic" to select a instruction whose semantics were "undefined". This was almost always fine (as the pass through operand was usually implicit_def), but could in theory lead to a miscompile. I don't actually have a test case as it requires a later transform to exploit the wrong tail policy state, and I couldn't easily figure out to get vsetvli insertion to miscompile given the wrong state. This was spotted by inspection, and it may be a miscompile in theory only at the moment.
Note that this may cause regressions if there are instructions for which we either don't have a _TU pseudo form, or the _TU pseudo form is missing a policy operand. When I was first looking at this, I saw exactly that, and D153067 exists to add the missing policy operand I noticed.
As a later follow up, I want to always force the use of _TU, but it seemed good to fix the bug, then driven the _TU transition in a separate patch.
Differential Revision: https://reviews.llvm.org/D153070
Philip Reames [Fri, 16 Jun 2023 23:41:09 +0000 (16:41 -0700)]
[RISCV] Add a policy operand to VPseudoBinaryNoMaskTU [NFC]
This change adds a policy operand to the helper class which is used for binary ops like vadd, but also, possibly surprisingly, some of the vslide variants. This allows us to represent the tail agnostic state with this pseudo family - previously, we could only represent tail undefined and tail undisturbed. (Since these don't have a mask, they're always mask undefined.)
This is NFC because no current producer uses the tail agnostic state. This will change in an upcoming change to doPeepholeMaskedRVV.
Differential Revision: https://reviews.llvm.org/D153067
Diego Caballero [Fri, 16 Jun 2023 23:21:24 +0000 (23:21 +0000)]
[mlir][Vector] Fix 0-D tensor vectorization in Linalg
It looks like scalable vector support broke vectorization for 0-D
tensors and we didn't have any test coverting that case. This patch
provides a fix and a test.
Differential Revision: https://reviews.llvm.org/D153181
Owen Pan [Fri, 16 Jun 2023 23:33:36 +0000 (16:33 -0700)]
[clang-format][NFC] Use verifyGoogleFormat in FormatTest.cpp
Replaces verifyFormat(..., getGoogleStyle()) with
verifyGoogleFormat(...) in FormatTest.cpp.
Craig Topper [Fri, 16 Jun 2023 23:40:10 +0000 (16:40 -0700)]
[RISCV] Reduce alignment for __attribute__((riscv_rvv_vector_bits)) for LMUL<1 types.
Don't use an alignment larger than the vector size.
Luke Lau [Fri, 16 Jun 2023 23:31:35 +0000 (16:31 -0700)]
[RISCV] Refactor vecPolicyOp skip logic in doPeepholeMaskedRVV. NFC
We can just explicitly check if the new unmasked pseudo takes a policy
op, rather than implicitly relying on I->UnmaskedTUPseudo ==
I->UnmaskedPseudo. Split out from another patch to make the diff more
readable.
Differential Revision: https://reviews.llvm.org/D152961
Luke Lau [Fri, 16 Jun 2023 23:30:38 +0000 (16:30 -0700)]
[RISCV] Reuse RISCVDAGToDAGISel member TTI in doPeepholeMaskedRVV. NFC
Differential Revision: https://reviews.llvm.org/D152960
Daniel Thornburgh [Fri, 16 Jun 2023 23:34:26 +0000 (16:34 -0700)]
[Fuchsia] Forward terminfo flags to stage 2
Philip Reames [Fri, 16 Jun 2023 23:13:22 +0000 (16:13 -0700)]
[RISCV] Make all vector binops use the _TU pseudo form
This continues towards the goal spelled out in https://discourse.llvm.org/t/riscv-transition-in-vector-pseudo-structure-policy-variants/71295. This patch switches all the binary operations (no widen, no narrow, but both int and FP) to use the _TU + implicit_def passthrough form. Change is mechanical.
This only changes the unmasked variants. Masked variants will still go through doPeepholeMaskedRVV and end up in the unsuffixed/TA form. Fixing that will be a separate change.
Differential Revision: https://reviews.llvm.org/D152940
Nitin John Raj [Thu, 15 Jun 2023 02:10:44 +0000 (19:10 -0700)]
[RISCV] Introduce RISCVISD::VWMACC(U/SU)_VL opcode
Differential Revision: https://reviews.llvm.org/D153057
Owen Pan [Fri, 16 Jun 2023 07:00:43 +0000 (00:00 -0700)]
[clang-format][NFC] Clean up unit tests
This patch adds a verifyNoChange macro to verify code that won't
change after being formatted. (The code will not be messed up before
being formatted.) It then replaces EXPECT_EQ with verifyFormat
wherever applicable so that the code will be messed up before being
formatted. When the replacement fails the unit test, verifyFormat is
replaced with verifyNoChange.
Differential Revision: https://reviews.llvm.org/D153109
Matt Arsenault [Thu, 1 Jun 2023 22:11:24 +0000 (18:11 -0400)]
TTI: Add function to hasBranchDivergence
It my be possible to contextually ignore divergence in a function if
it's known to run single threaded.
Matt Arsenault [Fri, 2 Jun 2023 10:58:13 +0000 (06:58 -0400)]
UniformityAnalysis: Skip computation with no branch divergence
Check TTI before bothering to run the computation. Everything
will be assumed uniform by default.
Daniel Hoekwater [Tue, 13 Jun 2023 17:48:19 +0000 (10:48 -0700)]
Prevent out of range fixup encoding on AArch64
The range of a 21-bit signed integer is [-1048576, 1048575],
not [-2097152, 2097151].
Differential Revision: https://reviews.llvm.org/D152841
Krzysztof Parzyszek [Fri, 16 Jun 2023 22:20:31 +0000 (15:20 -0700)]
[Hexagon] Generate correct instruction for store i1, ($Rs<<$u2 + $Rt)
Fixes https://github.com/llvm/llvm-project/issues/63359
Matt Arsenault [Fri, 16 Jun 2023 22:13:07 +0000 (18:13 -0400)]
Revert "AMDGPU: Drop and auto-upgrade llvm.amdgcn.ldexp to llvm.ldexp"
This reverts commit
1159c670d40e3ef302264c681fe7e0268a550874.
Accidentally pushed wrong patch
Matt Arsenault [Fri, 28 Apr 2023 17:41:05 +0000 (13:41 -0400)]
AMDGPU: Drop and auto-upgrade llvm.amdgcn.ldexp to llvm.ldexp
Jonas Devlieghere [Fri, 16 Jun 2023 21:48:37 +0000 (14:48 -0700)]
[lldb] Fix Python test formatting (NFC)
All Python files in the LLVM repository were reformatted with Black [1].
Files inside the LLDB subproject were reformatted in
2238dcc39358. This
patch updates a handful of tests that were added or modified since then
and weren't formatted with Black.
[1] https://discourse.llvm.org/t/rfc-document-and-standardize-python-code-style/68257
Yaxun (Sam) Liu [Fri, 16 Jun 2023 04:36:00 +0000 (00:36 -0400)]
Fix diag for read-only target features
Currently the diag is emitted even when there is no
target feature specified on command line for OpenMP.
This is because the function to initialize feature map
is also used with cached feature string. The fix is to
only diag when the feature map is initialized with
feature strings from command line options.
Reviewed by: Joseph Huber, Matt Arsenault, Johannes Doerfert
Differential Revision: https://reviews.llvm.org/D153123
Jonas Devlieghere [Fri, 16 Jun 2023 21:41:00 +0000 (14:41 -0700)]
[lldb] Simplify logging in Process settings (NFC)
Alex Langford [Fri, 16 Jun 2023 21:17:32 +0000 (14:17 -0700)]
[lldb][NFCI] Avoid a few unnecessary ConstString constructions in StructuredDataDarwinLog
Process::GetStructuredDataPlugin takes a StringRef directly, no need to
convert them to ConstString first.
Jonas Devlieghere [Fri, 16 Jun 2023 20:57:20 +0000 (13:57 -0700)]
[dsymutil] Update DWARF 5 tests after
8119ab9bf78b
Update test affected by
8119ab9bf78b and address Adrian's post commit
review feedback.
Arthur Eubanks [Fri, 16 Jun 2023 20:48:27 +0000 (13:48 -0700)]
Revert "Revert "ValueTracking: Fix nan result handling for fmul""
This reverts commit
464dcab8a6c823c9cb462bf4107797b8173de088.
Going to fix forward size regression instead due to more dependent patches needing to be reverted otherwise.
Arthur Eubanks [Fri, 16 Jun 2023 20:48:20 +0000 (13:48 -0700)]
Revert "Revert "clang: Update tests after InstSimplify change""
This reverts commit
dd1c79b03004ae88ebead51aa021ab229ab0175c.
Going to fix forward size regression instead due to more dependent patches needing to be reverted otherwise.
Arthur Eubanks [Fri, 16 Jun 2023 20:48:08 +0000 (13:48 -0700)]
Revert "Revert "InstSimplify: Remove null parent checks""
This reverts commit
935c8b6f3a4dda0ff881ed86faaad9fe5b276d70.
Going to fix forward size regression instead due to more dependent patches needing to be reverted otherwise.
Arthur Eubanks [Fri, 16 Jun 2023 20:47:30 +0000 (13:47 -0700)]
Revert "Revert "InstSimplify: Require instruction be parented""
This reverts commit
0c03f48480f69b854f86d31235425b5cb71ac921.
Going to fix forward size regression instead due to more dependent patches needing to be reverted otherwise.
Christopher Ferris [Fri, 16 Jun 2023 01:52:59 +0000 (18:52 -0700)]
[scudo] Add mallopt to print stats to the log.
Reviewed By: Chia-hungDuan
Differential Revision: https://reviews.llvm.org/D153094
Alex Langford [Fri, 16 Jun 2023 20:27:51 +0000 (13:27 -0700)]
[DebugInfo][NFCI] Follow-up to
0356ceedf2e9
Krzysztof Parzyszek [Fri, 16 Jun 2023 19:51:48 +0000 (12:51 -0700)]
[Hexagon] Properly combine overlapping stores in HVC
Rashmi Mudduluru [Thu, 15 Jun 2023 23:45:28 +0000 (16:45 -0700)]
[-Wunsafe-buffer-usage] Do not emit fixits for C++ interfaces with C linkage
Differential Revision: https://reviews.llvm.org/D153064
Jonas Devlieghere [Fri, 16 Jun 2023 19:24:27 +0000 (12:24 -0700)]
[dsymutil] Fix .debug_addr index calculation
The DW_OP_addrx operation encodes a zero-based index into the
.debug_addr section. The index is relative to the DW_AT_addr_base
attribute of the associated compilation unit. In order to compute the
offset into the .debug_addr section and find the associated relocation,
we need to add the add the add base offset and multiply the index with
the address size.
This patch fixes a bug in this computation, where the multiplication was
omitted. This went unnoticed because for small test cases, the index for
interesting addresses (such as the main subprogram) is often zero.
rdar://
110881668
Differential revision: https://reviews.llvm.org/D153162
Joseph Huber [Fri, 2 Jun 2023 20:38:37 +0000 (15:38 -0500)]
[libc][Docs] Add some motivation for the GPU libc
This provides some basic motivation behind the GPU libc. Suggests are welcome.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D152028
Nathan Ridge [Fri, 9 Jun 2023 06:39:28 +0000 (02:39 -0400)]
[clangd] Handle DependentNameType in HeuristicResolver::resolveTypeToRecordDecl()
Fixes https://github.com/clangd/clangd/issues/1671
Differential Revision: https://reviews.llvm.org/D152645
Fangrui Song [Fri, 16 Jun 2023 19:15:06 +0000 (12:15 -0700)]
[RISCV] relaxDwarfCallFrameFragment: remove unneeded relocations for relaxation
If `evaluateAsAbsolute(Value, Layout.getAssembler())` returns true, we
know the address delta is a constant and can suppress relocations
(usually SET6/SUB6).
While here, replace one evaluateKnownAbsolute call (subtle for Mach-O
workarounds; avoid if possible) with evaluateAsAbsolute.
Joseph Huber [Fri, 16 Jun 2023 19:11:13 +0000 (14:11 -0500)]
[libc][Obvious] Fix problem with the variable used for the jobs
Summary:
There was an issue with the variable we were using to conditonally set
the job number for the GPU.
Youngsuk Kim [Fri, 16 Jun 2023 19:01:53 +0000 (22:01 +0300)]
[clang] Replace use of Type::getPointerTo() (NFC)
Partial progress towards replacing in-tree uses of `Type::getPointerTo()`.
This needs to be done before deprecating the API.
Reviewed By: nikic, barannikov88
Differential Revision: https://reviews.llvm.org/D152321
Joseph Huber [Fri, 16 Jun 2023 17:40:09 +0000 (12:40 -0500)]
[libc] Add an option to use a job pool for GPU tests
Currently the GPU has restrictions on how many tests can be run in
parallel due to resource constraints. However, building these tests can
take a long time so we want to be able to build them in parallel. This
patch introduces the option `LIBC_GPU_TEST_JOBS` which is set to the
number of threads to run in parallel.
Reviewed By: tra
Differential Revision: https://reviews.llvm.org/D153157
Fangrui Song [Fri, 16 Jun 2023 19:04:28 +0000 (12:04 -0700)]
[xray] Use L* instead of .L* for Mach-O
Note: Mach-O support is not yet done and check-xray is not allowed yet.
Matt Arsenault [Thu, 15 Jun 2023 17:14:08 +0000 (13:14 -0400)]
AMDGPU: Remove unnecessary Attributor overrides
Matt Arsenault [Mon, 13 Sep 2021 21:19:40 +0000 (17:19 -0400)]
AMDGPU: Propagate amdgpu-waves-per-eu with attributor
This will do a value range merging down the callgraph, unlike the
current pass which can only propagate values to undecorated functions
from a kernel.
This one is a bit weird due to the interaction with the implied range
from amdgpu-flat-workgroup-size. At the default group range of 1,1024,
the minimum implied bounds is 4 so this ends up introducing the
attribute on undecorated functions. We could probably simplify this by
ignoring it and propagating the raw values. The subtarget interaction
and the interaction with amdgpu-flat-workgroup-size only really clamp
invalid values (plus the lower bound doesn't seem to do anything as
far as I can tell anyway).
Aaron Ballman [Fri, 16 Jun 2023 19:01:42 +0000 (15:01 -0400)]
Diagnose incorrect use of scoped enumerations in format strings
Scoped enumerations in C++ do not undergo conversion to their
underlying type as part of default argument promotion, and so these
uses are UB. GCC correctly diagnoses them, and now Clang matches.
Fixes https://github.com/llvm/llvm-project/issues/38717
Volodymyr Sapsai [Fri, 16 Jun 2023 19:01:54 +0000 (12:01 -0700)]
Revert "[RISCV] relaxDwarfCallFrameFragment: remove unneeded relocations for relaxation"
Failing buildbot https://green.lab.llvm.org/green/job/clang-stage1-RA/34684/
This reverts commit
11ebe3d906558d93a607347de472e7718127f409.
Roland McGrath [Thu, 15 Jun 2023 22:38:05 +0000 (15:38 -0700)]
[fuzzer][fuchsia] Support RISC-V
Reviewed By: phosek
Differential Revision: https://reviews.llvm.org/D153082
Arthur Eubanks [Fri, 16 Jun 2023 18:13:46 +0000 (11:13 -0700)]
Revert "InstSimplify: Require instruction be parented"
This reverts commit
1536e299e63d7788f38117b0212ca50eb76d7a3b.
Causes large binary size regressions, see comments on https://reviews.llvm.org/rG1536e299e63d7788f38117b0212ca50eb76d7a3b.
Arthur Eubanks [Fri, 16 Jun 2023 18:13:15 +0000 (11:13 -0700)]
Revert "InstSimplify: Remove null parent checks"
This reverts commit
2ca21e8775dd16189bb4c00c3f9553f17578a63c.
Dependent commit to be reverted
Arthur Eubanks [Fri, 16 Jun 2023 18:12:58 +0000 (11:12 -0700)]
Revert "clang: Update tests after InstSimplify change"
This reverts commit
14c44dfbcf1d6f81c1cdaa90ed243b3d53147903.
Dependent commit to be reverted.
Arthur Eubanks [Fri, 16 Jun 2023 18:16:30 +0000 (11:16 -0700)]
Revert "ValueTracking: Fix nan result handling for fmul"
This reverts commit
a632ca4b00279baf18e72a171ec0ce526e9d80aa.
Dependent commit to be reverted
Craig Topper [Fri, 16 Jun 2023 18:22:44 +0000 (11:22 -0700)]
[RISCV] Refactor how we create separate instructions for F and Zfinx. NFC
Previously we had a ExtInfo_rr class that was instantiated for
every combination of types that can appear together along with
their predicates, suffixes, and decoder namespace.
This patch replaces this with a new ExtInfo class that contains
predicates, suffix, namespace, and the f16, f32, and f64 DAGOperands
implied by the predicates. The DAGOperand can be unset if
the predicate is not enough to distinquish it.
At every instruction instantiation we know whether the operands
are GPR, f16, f32, or f64 and can ask the ExtInfo for the relevant
DAGOperand.
The foreach loops of ExtInfo have been moved out of the classes to
be at the top level of the 3 files. This allows the file to pick
the f16/f32/f64 DAGOperand per instruction and pass it down to the
classes separately from the ExtInfo. The ExtInfo still needs to be
passed down to get suffix, predicates, and decoder namespace.
Reviewed By: sunshaoce
Differential Revision: https://reviews.llvm.org/D152948
Alex Langford [Wed, 14 Jun 2023 17:58:35 +0000 (10:58 -0700)]
[DebugInfo] Change DWARFDebugAbbrev initialization
I plan on adding better error handling to DWARFDebugAbbrev, but first I
want us to be able to better reason about a state of a DWARFDebugAbbrev.
I want us to be able to initialize a DWARFDebugAbbrev in its complete
state instead of creating it and then calling an `extract` method
manually. If its Data field is populated, then parsing is not complete.
If Data is `std::nullopt`, then parsing is done and this section is
"finalized" in some sense.
Additionally, I have removed the `clear()` method. This makes sense for other
classes like DWARFAbbreviationDeclaration where we may want to re-use an object
repeatedly to avoid repeated initializations and allocations, but for
DWARFDebugAbbrev we pretty much create one and stick with it.
Differential Revision: https://reviews.llvm.org/D152947
Dave Lee [Wed, 14 Jun 2023 20:41:11 +0000 (13:41 -0700)]
[lldb] De-virtualize applicable functions in ValueObject (NFC)
Remove `virtual` from `ValueObject` functions that aren't overridden.
One such function, `IsArrayItemForPointer`, is not called and so is instead deleted.
Differential Revision: https://reviews.llvm.org/D153088
Ingo Müller [Fri, 16 Jun 2023 15:28:44 +0000 (15:28 +0000)]
[mlir][async] Update comments about library registration. (NFC)
This updates the code comments about the library registration mechanism,
which changed in https://reviews.llvm.org/D153029, and which should have
updated as part of that patch.
Reviewed By: ingomueller-net
Differential Revision: https://reviews.llvm.org/D153147
Alan Zhao [Fri, 16 Jun 2023 17:58:17 +0000 (10:58 -0700)]
Revert "Revert "InstSimplify: Require instruction be parented""
This reverts commit
00264eac4d0938ae8a0826da38e4777be269124c.
Reason: caused a bunch of bots to break
Alex Langford [Fri, 16 Jun 2023 01:14:30 +0000 (18:14 -0700)]
[lldb][NFCI] Remove unused method Properties::GetSubProperty
Alex Langford [Wed, 14 Jun 2023 22:15:40 +0000 (15:15 -0700)]
[lldb][NFCI] Remove use of ConstString in ProcessStructReader
std::map<ConstString, FieldImpl> is naturally replaced with
`llvm::StringMap<FieldImpl>` here.
Differential Revision: https://reviews.llvm.org/D152968
Joseph Huber [Fri, 16 Jun 2023 13:42:27 +0000 (08:42 -0500)]
[libc][nfc] Silence two warnings in tests
These currently give warnings for unused variables or a default case
where everything is covered.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D153137
Alex Langford [Tue, 13 Jun 2023 18:01:24 +0000 (11:01 -0700)]
[lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas
Instead of writing boilerplate classes to serve as matchers for things
like `find_if` and `erase_if`, we can use lambdas. I believe this
simplifies the Listener class.
Differential Revision: https://reviews.llvm.org/D152846
Alex Langford [Thu, 15 Jun 2023 17:31:38 +0000 (10:31 -0700)]
[lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef
This method just takes its ConstString parameter and gets a StringRef
out of it. Let's just pass in a StringRef directly.
This also cleans up some logic in the callers to be a little easier to
read and to avoid unnecessary ConstString creation.
Differential Revision: https://reviews.llvm.org/D153054
Alan Zhao [Fri, 16 Jun 2023 17:35:52 +0000 (10:35 -0700)]
Revert "InstSimplify: Require instruction be parented"
This reverts commit
1536e299e63d7788f38117b0212ca50eb76d7a3b.
Reason: causes a regression in the inliner (see https://crbug.com/1454531 and https://reviews.llvm.org/rG1536e299e63d7788f38117b0212ca50eb76d7a3b#1217141)
Louis Dionne [Fri, 16 Jun 2023 17:30:50 +0000 (13:30 -0400)]
[libc++] Fix signedness comparison issue on GCC in a test
Paul Scoropan [Thu, 8 Jun 2023 17:36:50 +0000 (17:36 +0000)]
[Flang] Split PowerPC-specific code out of IntrinsicCall into PPCIntrinsicCall
This patch moves PPC intrinsic generator code to PPCIntrinsicCall.cpp. In order to move PowerPC intrinsic code out of IntrinsicCall.cpp, we need to also move some declarations to IntrinsicCall.h. handlers[] and mathOperations[] were also chosen to be moved to the IntrinsicCall header. Similarly, ppcHandlers[] and ppcMathOperations[] were moved to the PPCIntrinsicCall header. There are future patches coming up that will introduce many new PPC intrinsics, these will now be defined in PPCIntrinsicCall.
Reviewed By: jeanPerier
Differential Revision: https://reviews.llvm.org/D152460
Steven Wu [Thu, 15 Jun 2023 23:34:49 +0000 (16:34 -0700)]
[CMake] Add missing dependency in llvm Support unittests
Casting.cpp in llvm unittests includes "llvm/IR/User.h" which depends on
intrinsic_gen if using module because it needs to build IR module including
`Attributes.h`.
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D153048
Alex Zinenko [Thu, 15 Jun 2023 17:46:32 +0000 (19:46 +0200)]
[mlir] don't install tutorial libraries
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D153055
Craig Topper [Fri, 16 Jun 2023 16:22:49 +0000 (09:22 -0700)]
[RISCV] Treat __riscv_vsetvl_*(-1) as vlmax.
We already treat -1 passed to instruction intrinsics as vlmax, this
make vsetvli consistent.
Reviewed By: rogfer01
Differential Revision: https://reviews.llvm.org/D152954
Jay Foad [Thu, 15 Jun 2023 16:45:17 +0000 (17:45 +0100)]
[AMDGPU] Stop replacing amdgcn.ballot(1) with amdgcn.s.getreg(exec)
Rationale:
- It does not enable any further IR simplifications.
- It does not improve the generated code since the isel lowering of
ballot also has special cases for 0 and 1.
- getreg is "too powerful" since it can read from many different
registers, so its intrinsic properties have to be set very
conservatively.
There is also a correctness problem that getreg can read from exec but
it is currently not marked as convergent.
Differential Revision: https://reviews.llvm.org/D153047
Jingu Kang [Thu, 15 Jun 2023 16:19:35 +0000 (17:19 +0100)]
[AArch64] Try to convert vector shift operation into vector add operation
The vector shift instructions tend to be worse than ADD/SUB on AArch64 cores
so this patch supports tablegen patterns for below simple transformation.
x << 1 ==> x + x
Differential Revision: https://reviews.llvm.org/D153049
Joseph Huber [Tue, 6 Jun 2023 16:56:31 +0000 (11:56 -0500)]
[libc] Add a test for `fputs` to check using `stdout` and `stderr`
This patch adds a test directly for the `fputs` function similar to the
existing `puts` test. This lets us know that the default file pointers
are function and the `fputs` interface works.
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D152288
Felipe de Azevedo Piovezan [Mon, 12 Jun 2023 12:38:57 +0000 (08:38 -0400)]
[nfc][AppleTables] Rename iterator
We will soon need different kinds of iterators
We also use one of LLVM's iterator classes to implement some basic iterator
operations.
Differential Revision: https://reviews.llvm.org/D153065
Dan McGregor [Fri, 16 Jun 2023 15:47:00 +0000 (08:47 -0700)]
[clang] Apply -fmacro-prefix-map to anonymous tags in template arguments
When expanding template arguments for pretty function printing,
such as for __PRETTY_FUNCTION__, make TypePrinter apply
macro-prefix-map remapping to anonymous tags such as lambdas.
Fixes https://github.com/llvm/llvm-project/issues/63219
Reviewed By: MaskRay, aaron.ballman
Differential Revision: https://reviews.llvm.org/D152570
Wanyi Ye [Thu, 15 Jun 2023 22:18:06 +0000 (15:18 -0700)]
[llvm-gsymutil] Fix command descriptions introduced in upstream D148775 when switching to OptTable
[D148775](https://reviews.llvm.org/D148775) changed the help msg for `--addresses-from-stdin` option when switching to OptTable
This patch also fixed a small problem in the argument type error msg
Test Plan: NFC
Differential Revision: https://reviews.llvm.org/D153086
Alex Brachet [Thu, 15 Jun 2023 23:37:03 +0000 (23:37 +0000)]
[libc] Add LIBC_INLINE_VAR for inline variables
These are the only variables I could find that use LIBC_INLINE. Note, these are namespace scoped constexpr so local linkage is implied. inline is useful here to silence clang's unused-const-variable variable. For Fuchsia, the distinction between LIBC_INLINE and LIBC_INLINE_VAR is helpful because we define LIBC_INLINE as `[[gnu::always_inline]] inline` when building with gcc. This isn't meaningful on variables.
Alternatively, we could make these variables simply constexpr and also add `[[maybe_unused]]`
Reviewed By: sivachandra, mcgrathr
Differential Revision: https://reviews.llvm.org/D152951
Mark de Wever [Thu, 15 Jun 2023 15:38:32 +0000 (17:38 +0200)]
[Clang] Fixes a diagnostic typo.
Some small style updates as drive-by.
Reviewed By: ChuanqiXu
Differential Revision: https://reviews.llvm.org/D153038
Mark de Wever [Thu, 15 Jun 2023 17:28:23 +0000 (19:28 +0200)]
[libc++][doc] Move not yet adopted issues to C++26.
The development of C++23 is complete, so these issues will be adopted in
C++26 (or later).
Reviewed By: #libc, philnik
Differential Revision: https://reviews.llvm.org/D153053
Amaury Séchet [Fri, 16 Jun 2023 15:33:30 +0000 (15:33 +0000)]
[NFC] Autogenerate CodeGen/ARM/vlddup.ll
Fangrui Song [Fri, 16 Jun 2023 15:32:25 +0000 (08:32 -0700)]
[Driver] Allow warning for unclaimed TargetSpecific options
For unclaimed target-agnostic options, we can apply clang_ignored_gcc_optimization_f_Group
to accept but warn about them.
```
% clang -c -fexpensive-optimizations a.c
clang: warning: optimization flag '-fexpensive-optimizations' is not supported [-Wignored-optimization-argument]
```
For an unclaimed target-specific option, one target may want to accept but warn
about it. Add `llvm::opt::Arg::IgnoredTargetSpecific` to support this warning
need.
Close https://github.com/llvm/llvm-project/issues/63282
Reviewed By: mstorsjo
Differential Revision: https://reviews.llvm.org/D152856
Amaury Séchet [Fri, 16 Jun 2023 15:11:14 +0000 (15:11 +0000)]
[NFC] Autogenerate CodeGen/ARM/sub-cmp-peephole.ll
Florian Hahn [Fri, 16 Jun 2023 15:14:01 +0000 (16:14 +0100)]
[LV] Use VPValues when creating GEP with all invariant indices.
Update VPWidenGEPRecipe::execute to use the VPValue operands of the
recipe when creating the GEP instruction.
Fixes #63340.
LLVM GN Syncbot [Fri, 16 Jun 2023 14:54:49 +0000 (14:54 +0000)]
[gn build] Port
31eeba3f7c0e
Nikolas Klauser [Fri, 16 Jun 2023 14:50:54 +0000 (07:50 -0700)]
[libc++] Introduce __make_uninitialized_buffer and use it instead of get_temporary_buffer
This will also be used in some PSTL backends.
Reviewed By: ldionne, #libc, Mordante
Spies: arichardson, mstorsjo, Mordante, sstefan1, jplehr, libcxx-commits
Differential Revision: https://reviews.llvm.org/D152208