platform/upstream/freerdp.git
10 years agolibfreerdp-codec: fix and improve SRL decoder
Marc-André Moreau [Tue, 2 Sep 2014 22:15:36 +0000 (18:15 -0400)]
libfreerdp-codec: fix and improve SRL decoder

10 years agolibfreerdp-codec: add more progressive test functions
Marc-André Moreau [Tue, 2 Sep 2014 17:31:40 +0000 (13:31 -0400)]
libfreerdp-codec: add more progressive test functions

10 years agolibfreerdp-codec: add separate sign array
Marc-André Moreau [Thu, 28 Aug 2014 19:14:01 +0000 (15:14 -0400)]
libfreerdp-codec: add separate sign array

10 years agolibfreerdp-codec: add code for SRL parsing
Marc-André Moreau [Thu, 28 Aug 2014 16:14:28 +0000 (12:14 -0400)]
libfreerdp-codec: add code for SRL parsing

10 years agolibfreerdp-codec: start reading progressive RAW bytes
Marc-André Moreau [Wed, 27 Aug 2014 22:34:37 +0000 (18:34 -0400)]
libfreerdp-codec: start reading progressive RAW bytes

10 years agolibfreerdp-codec: start computing BitPos
Marc-André Moreau [Wed, 27 Aug 2014 21:02:15 +0000 (17:02 -0400)]
libfreerdp-codec: start computing BitPos

10 years agolibfreerdp-codec: fix progressive tile diffing
Marc-André Moreau [Wed, 27 Aug 2014 19:15:37 +0000 (15:15 -0400)]
libfreerdp-codec: fix progressive tile diffing

10 years agolibfreerdp-codec: fix sub-band diffing
Marc-André Moreau [Tue, 26 Aug 2014 20:15:22 +0000 (16:15 -0400)]
libfreerdp-codec: fix sub-band diffing

10 years agolibfreerdp-codec: partial YCbCr diffing support
Marc-André Moreau [Tue, 26 Aug 2014 18:36:33 +0000 (14:36 -0400)]
libfreerdp-codec: partial YCbCr diffing support

10 years agolibfreerdp-codec: fix progressive codec tile drawing offset, fix dequantization
Marc-André Moreau [Mon, 25 Aug 2014 23:50:42 +0000 (19:50 -0400)]
libfreerdp-codec: fix progressive codec tile drawing offset, fix dequantization

10 years agolibfreerdp-codec: make use of progressive quantization factors
Marc-André Moreau [Mon, 25 Aug 2014 21:58:38 +0000 (17:58 -0400)]
libfreerdp-codec: make use of progressive quantization factors

10 years agolibfreerdp-codec: fix progressive quantization shifts
Marc-André Moreau [Thu, 21 Aug 2014 23:43:37 +0000 (19:43 -0400)]
libfreerdp-codec: fix progressive quantization shifts

10 years agolibfreerdp-codec: partially working progressive iDWT
Marc-André Moreau [Thu, 21 Aug 2014 23:02:26 +0000 (19:02 -0400)]
libfreerdp-codec: partially working progressive iDWT

10 years agolibfreerdp-codec: fix crashes
Marc-André Moreau [Thu, 21 Aug 2014 21:14:10 +0000 (17:14 -0400)]
libfreerdp-codec: fix crashes

10 years agolibfreerdp-codec: improve progressive iDWT
Marc-André Moreau [Thu, 21 Aug 2014 20:05:39 +0000 (16:05 -0400)]
libfreerdp-codec: improve progressive iDWT

10 years agolibfreerdp-codec: start new progressive rfx iDWT functions
Marc-André Moreau [Wed, 20 Aug 2014 23:12:08 +0000 (19:12 -0400)]
libfreerdp-codec: start new progressive rfx iDWT functions

10 years agolibfreerdp-codec: intermediate progressive rfx iDWT
Marc-André Moreau [Wed, 20 Aug 2014 21:16:34 +0000 (17:16 -0400)]
libfreerdp-codec: intermediate progressive rfx iDWT

10 years agolibfreerdp-codec: start work on progressive inverse DWT
Marc-André Moreau [Tue, 19 Aug 2014 18:48:09 +0000 (14:48 -0400)]
libfreerdp-codec: start work on progressive inverse DWT

10 years agolibfreerdp-codec: optimize RemoteFX dequantization and differentiation
Marc-André Moreau [Tue, 19 Aug 2014 01:10:56 +0000 (21:10 -0400)]
libfreerdp-codec: optimize RemoteFX dequantization and differentiation

10 years agolibfreerdp-codec: start working on progressive dequantization
Marc-André Moreau [Mon, 18 Aug 2014 23:12:08 +0000 (19:12 -0400)]
libfreerdp-codec: start working on progressive dequantization

10 years agofreerdp: fix build warnings
Marc-André Moreau [Mon, 18 Aug 2014 21:25:48 +0000 (17:25 -0400)]
freerdp: fix build warnings

10 years agoMerge branch 'shadow' of github.com:awakecoding/FreeRDP
Marc-André Moreau [Mon, 18 Aug 2014 21:06:13 +0000 (17:06 -0400)]
Merge branch 'shadow' of github.com:awakecoding/FreeRDP

10 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Mon, 18 Aug 2014 20:23:45 +0000 (16:23 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP

10 years agoMerge pull request #2023 from ptsekov/software-gdi-improvements
Marc-André Moreau [Mon, 18 Aug 2014 20:22:23 +0000 (16:22 -0400)]
Merge pull request #2023 from ptsekov/software-gdi-improvements

Software GDI improvements

10 years agoMerge pull request #2022 from dbungert/percent
Marc-André Moreau [Mon, 18 Aug 2014 20:20:15 +0000 (16:20 -0400)]
Merge pull request #2022 from dbungert/percent

Restore window size by percent

10 years agoMerge pull request #2024 from repzilon/master
Marc-André Moreau [Mon, 18 Aug 2014 17:08:52 +0000 (13:08 -0400)]
Merge pull request #2024 from repzilon/master

uclibc build fixes and recompressed images

10 years agoMerge pull request #2045 from zhangzl2013/fix-cut-fold
Marc-André Moreau [Mon, 18 Aug 2014 17:06:58 +0000 (13:06 -0400)]
Merge pull request #2045 from zhangzl2013/fix-cut-fold

drive: fix contents lost when cut-paste a folder.

10 years agoMerge pull request #2044 from RonYaari/master
Marc-André Moreau [Mon, 18 Aug 2014 17:06:10 +0000 (13:06 -0400)]
Merge pull request #2044 from RonYaari/master

X11: fix toggle-fullscreen option functionality

10 years agoMerge pull request #2010 from hardening/list_return_value
Marc-André Moreau [Mon, 18 Aug 2014 17:05:18 +0000 (13:05 -0400)]
Merge pull request #2010 from hardening/list_return_value

Make LinkedList return errors when something fails

10 years agoMerge pull request #2038 from akallabeth/winpr-stacktrace
Marc-André Moreau [Mon, 18 Aug 2014 17:04:51 +0000 (13:04 -0400)]
Merge pull request #2038 from akallabeth/winpr-stacktrace

Winpr add stacktrace

10 years agodrive: fix contents lost when cut-paste a folder.
Zhang Zhaolong [Mon, 18 Aug 2014 08:00:34 +0000 (16:00 +0800)]
drive: fix contents lost when cut-paste a folder.

10 years agoX11: fix toggle-fullscreen option functionality
Ron Yaari [Mon, 18 Aug 2014 07:41:40 +0000 (10:41 +0300)]
X11: fix toggle-fullscreen option functionality

10 years agoRevert "X11: fix toggle-fullscreen option functionality"
Idan Freiberg [Mon, 18 Aug 2014 07:39:47 +0000 (10:39 +0300)]
Revert "X11: fix toggle-fullscreen option functionality"

This reverts commit 0c84c81401c041a249834c07b8f953d5b4dcabc5.

10 years agoX11: fix toggle-fullscreen option functionality
Ron Yaari [Mon, 18 Aug 2014 07:19:47 +0000 (10:19 +0300)]
X11: fix toggle-fullscreen option functionality

10 years agoshadow: fix race conditions
Marc-André Moreau [Fri, 15 Aug 2014 22:12:53 +0000 (18:12 -0400)]
shadow: fix race conditions

10 years agoshadow: fix build for Windows XP
Marc-André Moreau [Fri, 15 Aug 2014 20:06:08 +0000 (16:06 -0400)]
shadow: fix build for Windows XP

10 years agoshadow: initial working support for WDS+RDP backend
Marc-André Moreau [Fri, 15 Aug 2014 18:57:09 +0000 (14:57 -0400)]
shadow: initial working support for WDS+RDP backend

10 years agoshadow: fix WDS connectivity
Marc-André Moreau [Fri, 15 Aug 2014 18:15:53 +0000 (14:15 -0400)]
shadow: fix WDS connectivity

10 years agoshadow: fix RDP security
Marc-André Moreau [Fri, 15 Aug 2014 17:50:22 +0000 (13:50 -0400)]
shadow: fix RDP security

10 years agoMerge branch 'master' of github.com:awakecoding/FreeRDP into shadow
Marc-André Moreau [Fri, 15 Aug 2014 15:44:07 +0000 (11:44 -0400)]
Merge branch 'master' of github.com:awakecoding/FreeRDP into shadow

10 years agoMerge branch 'awakecoding' of github.com:vworkspace/FreeRDP
Marc-André Moreau [Fri, 15 Aug 2014 15:43:50 +0000 (11:43 -0400)]
Merge branch 'awakecoding' of github.com:vworkspace/FreeRDP

Conflicts:
libfreerdp/core/nego.c
libfreerdp/core/peer.c
winpr/libwinpr/synch/wait.c

10 years agoMerge pull request #2017 from ptsekov/Issue_2016
Hardening [Fri, 15 Aug 2014 07:21:12 +0000 (09:21 +0200)]
Merge pull request #2017 from ptsekov/Issue_2016

Honour user performance preferences.

10 years agoshadow: add more virtual channels to RDP backend like WDS API
Marc-André Moreau [Thu, 14 Aug 2014 23:23:48 +0000 (19:23 -0400)]
shadow: add more virtual channels to RDP backend like WDS API

10 years agoshadow: start RDP client backend for WDS
Marc-André Moreau [Thu, 14 Aug 2014 22:41:22 +0000 (18:41 -0400)]
shadow: start RDP client backend for WDS

10 years agoFix erronous use of colors in gdi_patblt().
Pavel Tsekov [Thu, 14 Aug 2014 17:21:49 +0000 (20:21 +0300)]
Fix erronous use of colors in gdi_patblt().
* libfreerdp/gdi/gdi.c:
(gdi_patblt): Fix a call to freerdp_mono_image_convert() which was
still passed colors in drawing order representation instead of GDI
representation.

10 years agoshadow: initial WDS working setup
Marc-André Moreau [Thu, 14 Aug 2014 17:10:43 +0000 (13:10 -0400)]
shadow: initial WDS working setup

10 years agoFix 1bpp -> 16bpp image conversion.
Pavel Tsekov [Thu, 14 Aug 2014 17:09:12 +0000 (20:09 +0300)]
Fix 1bpp -> 16bpp image conversion.
* libfreerdp/codec/color.c (freerdp_mono_image_convert): Update the
1bpp -> 16bpp conversion code to reflect the fact that the foreground
and the background colors are in GDI representation now.

10 years agoMerge pull request #1963 from akallabeth/async-update-to-lib
Norbert Federa [Thu, 14 Aug 2014 15:46:43 +0000 (17:46 +0200)]
Merge pull request #1963 from akallabeth/async-update-to-lib

Moved update thread from client to library.

10 years agoFixed license header, added correct copyright.
Armin Novak [Thu, 14 Aug 2014 08:42:10 +0000 (10:42 +0200)]
Fixed license header, added correct copyright.

10 years agoFixed missing argument checks in logger, fixed crashes if file not created.
Armin Novak [Thu, 14 Aug 2014 08:38:02 +0000 (10:38 +0200)]
Fixed missing argument checks in logger, fixed crashes if file not created.

10 years agoWinpr stacktrace header.
Armin Novak [Thu, 14 Aug 2014 08:37:48 +0000 (10:37 +0200)]
Winpr stacktrace header.

10 years agoAdded winpr functions to generate a stacktrace.
Armin Novak [Thu, 14 Aug 2014 08:36:50 +0000 (10:36 +0200)]
Added winpr functions to generate a stacktrace.
Added libcorkscrew headers for stacktrace on android.
Added execinfo.h detection for stacktrace on linux.

10 years agoshadow: improve WDS subsystem
Marc-André Moreau [Thu, 14 Aug 2014 00:12:09 +0000 (20:12 -0400)]
shadow: improve WDS subsystem

10 years agoshadow: start Windows Desktop Sharing API support
Marc-André Moreau [Wed, 13 Aug 2014 21:48:57 +0000 (17:48 -0400)]
shadow: start Windows Desktop Sharing API support

10 years agoFix conversion of 24bpp bitmaps to 32bpp fb when
Pavel Tsekov [Wed, 13 Aug 2014 21:31:15 +0000 (00:31 +0300)]
Fix conversion of 24bpp bitmaps to 32bpp fb when
CLRCONV_INVERT and/or CLRCONV_ALPHA is set.
* include/freerdp/codec/color.h (RGB32_to_BGR32): New inline function.
* libfreerdp/codec/color.c:
(freerdp_image_convert_24bpp): Fix CLRCONV_ALPHA and CLRCONV_INVERT
processing for 32bpp destination.
Unroll the conversion loop to process four pixels in one go using
32-bit load and store operations.

10 years agoFixed a FreeRDP server problem which prevented RDP security from being negotiated.
Mike McDonald [Wed, 13 Aug 2014 15:01:43 +0000 (11:01 -0400)]
Fixed a FreeRDP server problem which prevented RDP security from being negotiated.

10 years agoFixed typo in message
Mike McDonald [Wed, 13 Aug 2014 14:14:56 +0000 (10:14 -0400)]
Fixed typo in message

10 years agoMerge pull request #2037 from akallabeth/array-list-compare
Martin Fleisz [Wed, 13 Aug 2014 12:44:48 +0000 (14:44 +0200)]
Merge pull request #2037 from akallabeth/array-list-compare

Implemented comparison functions for ArrayList

10 years agoImplemented default fnObjectEquals function.
Armin Novak [Wed, 13 Aug 2014 12:15:17 +0000 (14:15 +0200)]
Implemented default fnObjectEquals function.
Implemented ArrayList_Contains.
ArrayList_IndexOf and ArrayList_LastIndexOf now use comparison function.

10 years agoshadow: move DXGI 1.2 code to separate file
Marc-André Moreau [Tue, 12 Aug 2014 23:22:42 +0000 (19:22 -0400)]
shadow: move DXGI 1.2 code to separate file

10 years agoshadow: improve DXGI support
Marc-André Moreau [Tue, 12 Aug 2014 20:57:58 +0000 (16:57 -0400)]
shadow: improve DXGI support

10 years agoMerge pull request #2035 from bmiklautz/fix/fingerprint
Bernhard Miklautz [Tue, 12 Aug 2014 13:54:44 +0000 (15:54 +0200)]
Merge pull request #2035 from bmiklautz/fix/fingerprint

crypto: fix fingerprint

10 years agocrypto: fix fingerprint
Bernhard Miklautz [Tue, 12 Aug 2014 13:40:53 +0000 (15:40 +0200)]
crypto: fix fingerprint

Latest logging changes introduced a problem with fingerprint generation.
The last byte wasn't added.

10 years agoserver: fix build on Windows
Marc-André Moreau [Mon, 11 Aug 2014 23:31:38 +0000 (19:31 -0400)]
server: fix build on Windows

10 years agoMerge branch 'master' of github.com:awakecoding/FreeRDP into shadow
Marc-André Moreau [Mon, 11 Aug 2014 23:22:33 +0000 (19:22 -0400)]
Merge branch 'master' of github.com:awakecoding/FreeRDP into shadow

Conflicts:
channels/encomsp/client/encomsp_main.c
libfreerdp/core/tcp.c
libfreerdp/crypto/certificate.c
server/Windows/CMakeLists.txt
server/X11/xf_cursor.c
server/X11/xf_input.c
server/X11/xf_interface.c
server/X11/xf_monitors.c
server/X11/xf_peer.c

10 years agoMerge branch 'shadow' of github.com:awakecoding/FreeRDP into shadow
Marc-André Moreau [Mon, 11 Aug 2014 23:09:00 +0000 (19:09 -0400)]
Merge branch 'shadow' of github.com:awakecoding/FreeRDP into shadow

10 years agoMerge pull request #2033 from awakecoding/master
Marc-André Moreau [Mon, 11 Aug 2014 23:08:08 +0000 (19:08 -0400)]
Merge pull request #2033 from awakecoding/master

RLGR, Progressive, RDP8.1 H264, MS-RDPEDISP

10 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Mon, 11 Aug 2014 23:01:15 +0000 (19:01 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP

10 years agoMerge pull request #1983 from ntwerdochlib/fileclip-updates
Marc-André Moreau [Mon, 11 Aug 2014 23:00:00 +0000 (19:00 -0400)]
Merge pull request #1983 from ntwerdochlib/fileclip-updates

clipboard: File clipping updates

10 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Mon, 11 Aug 2014 22:56:07 +0000 (18:56 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP

Conflicts:
include/freerdp/channels/log.h

10 years agoMerge pull request #2032 from ntwerdochlib/master
Marc-André Moreau [Mon, 11 Aug 2014 22:54:43 +0000 (18:54 -0400)]
Merge pull request #2032 from ntwerdochlib/master

Minor tweak to CLOG_PRINT macro.  Initialalize tag buffer to NULL.  Use ...

10 years agofreerdp: fix possible clog memory corruption
Marc-André Moreau [Mon, 11 Aug 2014 22:51:22 +0000 (18:51 -0400)]
freerdp: fix possible clog memory corruption

10 years agolibfreerdp-codec: cleanup and fix __lzcnt on Windows
Marc-André Moreau [Mon, 11 Aug 2014 22:48:42 +0000 (18:48 -0400)]
libfreerdp-codec: cleanup and fix __lzcnt on Windows

10 years agoMinor tweak to CLOG_PRINT macro. Initialalize tag buffer to NULL. Use strncat as...
Nicholas Twerdochlib [Mon, 11 Aug 2014 22:48:11 +0000 (18:48 -0400)]
Minor tweak to CLOG_PRINT macro.  Initialalize tag buffer to NULL.  Use strncat as a fail safe.

10 years agoMerge branch 'egfx' of github.com:awakecoding/FreeRDP
Marc-André Moreau [Mon, 11 Aug 2014 21:25:38 +0000 (17:25 -0400)]
Merge branch 'egfx' of github.com:awakecoding/FreeRDP

10 years agolibfreerdp-core: fix reconnection using client random
Marc-André Moreau [Mon, 11 Aug 2014 15:23:23 +0000 (11:23 -0400)]
libfreerdp-core: fix reconnection using client random

10 years agoMerge pull request #2027 from akallabeth/winpr-log
Marc-André Moreau [Mon, 11 Aug 2014 14:38:28 +0000 (10:38 -0400)]
Merge pull request #2027 from akallabeth/winpr-log

Replace stdout and logging defines with WLog, add logcat support

10 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Mon, 11 Aug 2014 14:36:07 +0000 (10:36 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP

Conflicts:
channels/disp/client/disp_main.c

10 years agoMerge pull request #1993 from bmiklautz/merge/from-stable-1.1
Marc-André Moreau [Mon, 11 Aug 2014 14:28:10 +0000 (10:28 -0400)]
Merge pull request #1993 from bmiklautz/merge/from-stable-1.1

Pick changes from stable-1.1 that are not yet on master

10 years agoFixed missing include.
Armin Novak [Mon, 11 Aug 2014 07:49:57 +0000 (09:49 +0200)]
Fixed missing include.

10 years agoFixed missing includes and invalid replacement.
Armin Novak [Mon, 11 Aug 2014 07:38:08 +0000 (09:38 +0200)]
Fixed missing includes and invalid replacement.

10 years agoReplaced fprintf with DEBUG_WARN
Armin Novak [Mon, 11 Aug 2014 07:19:47 +0000 (09:19 +0200)]
Replaced fprintf with DEBUG_WARN

10 years agoReplaced perror with DEBUG_WARN
Armin Novak [Mon, 11 Aug 2014 07:19:23 +0000 (09:19 +0200)]
Replaced perror with DEBUG_WARN

10 years agoFixed warnings for comm tests.
Armin Novak [Mon, 11 Aug 2014 07:17:56 +0000 (09:17 +0200)]
Fixed warnings for comm tests.

10 years agoUsing special log defines for channels now.
Armin Novak [Mon, 11 Aug 2014 07:12:01 +0000 (09:12 +0200)]
Using special log defines for channels now.

10 years agolibwinpr-synch: replace pthreads-based barrier implementation by interlocked operatio...
Marc-André Moreau [Sat, 9 Aug 2014 01:02:15 +0000 (21:02 -0400)]
libwinpr-synch: replace pthreads-based barrier implementation by interlocked operations + event and avoid deadlocks

10 years agoshadow: improve synchronization barrier usage
Marc-André Moreau [Sat, 9 Aug 2014 00:51:26 +0000 (20:51 -0400)]
shadow: improve synchronization barrier usage

10 years agoMerge remote-tracking branch 'upstream/master'
Rene Rheaume [Sat, 9 Aug 2014 00:18:44 +0000 (20:18 -0400)]
Merge remote-tracking branch 'upstream/master'

10 years agoChanged back the permissions to previous values
Rene Rheaume [Sat, 9 Aug 2014 00:14:56 +0000 (20:14 -0400)]
Changed back the permissions to previous values

10 years agoRecompressed images with FileOptimizer 6.8 (an open-source mass file recompression...
Rene Rheaume [Sat, 9 Aug 2014 00:12:25 +0000 (20:12 -0400)]
Recompressed images with FileOptimizer 6.8 (an open-source mass file recompression tool for Windows)

10 years agoshadow: make use of synchronization barrier
Marc-André Moreau [Fri, 8 Aug 2014 22:47:46 +0000 (18:47 -0400)]
shadow: make use of synchronization barrier

10 years agolibwinpr-synch: add initial synchronization barrier implementation
Marc-André Moreau [Fri, 8 Aug 2014 21:34:30 +0000 (17:34 -0400)]
libwinpr-synch: add initial synchronization barrier implementation

10 years agoMerge branch 'master' of git://github.com/awakecoding/FreeRDP
Benoit LeBlanc [Fri, 8 Aug 2014 15:42:53 +0000 (11:42 -0400)]
Merge branch 'master' of git://github.com/awakecoding/FreeRDP

10 years agoMerge pull request #2028 from v00d00/update-codecid
Bernhard Miklautz [Fri, 8 Aug 2014 13:06:48 +0000 (15:06 +0200)]
Merge pull request #2028 from v00d00/update-codecid

tmsf: CODEC_ID_* -> AV_CODEC_ID_*

10 years agoBackwards compat defines
Ian Whyman [Fri, 8 Aug 2014 12:05:06 +0000 (13:05 +0100)]
Backwards compat defines

10 years agoCODEC_ID_* -> AV_CODEC_ID_*
Ian Whyman [Fri, 8 Aug 2014 08:05:03 +0000 (09:05 +0100)]
CODEC_ID_* -> AV_CODEC_ID_*

10 years agoReplaced fprintf(stderr with DEBUG_WARN
Armin Novak [Thu, 7 Aug 2014 20:21:07 +0000 (22:21 +0200)]
Replaced fprintf(stderr with DEBUG_WARN

10 years agoReplaced fprintf(stderr with DEBUG_WARN
Armin Novak [Thu, 7 Aug 2014 20:20:53 +0000 (22:20 +0200)]
Replaced fprintf(stderr with DEBUG_WARN

10 years agoReplaced fprintf(stderr with DEBUG_WARN
Armin Novak [Thu, 7 Aug 2014 20:20:35 +0000 (22:20 +0200)]
Replaced fprintf(stderr with DEBUG_WARN

10 years agoReplaced fprintf(stderr with DEBUG_WARN
Armin Novak [Thu, 7 Aug 2014 20:20:13 +0000 (22:20 +0200)]
Replaced fprintf(stderr with DEBUG_WARN