Karol Herbst [Fri, 14 Apr 2023 22:18:20 +0000 (00:18 +0200)]
rusticl/mem: more region and origin validation
Fixes piglit's api@clenqueuefillimage test
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22506>
Karol Herbst [Fri, 14 Apr 2023 18:17:13 +0000 (20:17 +0200)]
rusticl: add create_pipe_box to better deal with pipe_box restrictions
This puts the CL -> pipe_box logic in one place and also make sure the
pipe_box is filled in correctly so we neither read out of bounds nor do
nothing at all.
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22506>
Weibin Wu [Fri, 14 Apr 2023 16:51:34 +0000 (11:51 -0500)]
winsys/gdi: GDI B5G6R5 display target support
Added RGB_565 support to GDI display target.
This is to fix the color corruption issue when showing 16-bit B5G6R5 framebuffer through GDI.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7637
Reviewed-by: Jesse Natalie jenatali@microsoft.com
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22507>
Jesse Natalie [Mon, 17 Apr 2023 17:45:43 +0000 (10:45 -0700)]
d3d12: Support blit texture uploads
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22542>
Jesse Natalie [Mon, 17 Apr 2023 19:06:39 +0000 (12:06 -0700)]
d3d12: Respect buffer offsets for sampler views
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22542>
Lionel Landwerlin [Fri, 7 Apr 2023 00:14:25 +0000 (17:14 -0700)]
anv: Work around the spec question about pipeline feedback vs GPL.
This gives anv the same behavior as turnip in not asserting, and just not
filling out feedback for those stages.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Emma Anholt [Fri, 7 Apr 2023 00:13:07 +0000 (17:13 -0700)]
anv: Refactor repeated pipeline creation feedback output code.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Emma Anholt [Thu, 6 Apr 2023 22:57:43 +0000 (15:57 -0700)]
anv: Only enable GPL if ANV_GPL=true, or if zink or DXVK are the engine.
Since there are concerns that the VK_EXT_GPL implementation may have
issues with mesh shading, disable it by default but give users a knob to
turn it on to experiment.
This doesn't automatically enable GPL use in zink, because we lack
extendedDynamicState2PatchControlPoints, but it means that you only need
to set ZINK_DEBUG=gpl and not both env vars.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Lionel Landwerlin [Mon, 28 Mar 2022 12:42:27 +0000 (15:42 +0300)]
anv: implement VK_EXT_graphics_pipeline_library
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Lionel Landwerlin [Wed, 6 Apr 2022 15:12:02 +0000 (18:12 +0300)]
anv: add dynamic buffer offsets support with independent sets
With independent sets, we're not able to compute immediate values for
the index at which to read anv_push_constants::dynamic_offsets to get
the offset of a dynamic buffer. This is because the pipeline layout
may not have all the descriptor set layouts when we compile the
shader.
To solve that issue, we insert a layer of indirection.
This reworks the dynamic buffer offset storage with a 2D array in
anv_cmd_pipeline_state :
dynamic_offsets[MAX_SETS][MAX_DYN_BUFFERS]
When the pipeline or the dynamic buffer offsets are updated, we
flatten that array into the
anv_push_constants::dynamic_offsets[MAX_DYN_BUFFERS] array.
For shaders compiled with independent sets, the bottom 6 bits of
element X in anv_push_constants::desc_sets[] is used to specify the
base offsets into the anv_push_constants::dynamic_offsets[] for the
set X.
The computation in the shader is now something like :
base_dyn_buffer_set_idx = anv_push_constants::desc_sets[set_idx] & 0x3f
dyn_buffer_offset = anv_push_constants::dynamic_offsets[base_dyn_buffer_set_idx + dynamic_buffer_idx]
It was suggested by Faith to use a different push constant buffer with
dynamic_offsets prepared for each stage when using independent sets
instead, but it feels easier to understand this way. And there is some
room for optimization if you are set X and that you know all the sets in
the range [0, X], then you can still avoid the indirection. Separate
push constant allocations per stage do have a CPU cost.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Lionel Landwerlin [Mon, 28 Mar 2022 12:35:43 +0000 (15:35 +0300)]
anv: move preprocessing of NIR right before compilation
For graphics pipelines, we'll need to load NIR for retained shaders.
We want to avoid as much processing as possible while doing that when
we're able to load ISA from cache.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Lionel Landwerlin [Fri, 25 Mar 2022 12:59:05 +0000 (14:59 +0200)]
anv: make input attachments available through bindless
With independent sets, we cannot bake into the shader the binding
table entry of input attachments anymore because that final location
is affected by multiple sets.
We can still access them by looking into the descriptor buffer. This
change enables the image handle to be stored in the descriptor buffer.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Lionel Landwerlin [Tue, 15 Mar 2022 13:50:31 +0000 (15:50 +0200)]
anv: move force shading rate writes checks
With variable fragment shading rate, the last pre-rasterization stage
is responsible to write the shading rate value.
The current checks is as follow :
If the fragment shader can be dispatched at variable shading rate,
look for the last pre-raster stage to force the write.
We change this to :
If we're the last pre-raster stage, force the write.
That way this works for pre-rasterization shaders compiled without a
fragment shader.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Lionel Landwerlin [Sat, 5 Mar 2022 23:00:25 +0000 (01:00 +0200)]
anv: introduce a base graphics pipeline object
Pipeline libraries and linked pipelines will inherit from this.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Lionel Landwerlin [Sun, 20 Feb 2022 18:46:17 +0000 (20:46 +0200)]
isl: don't set inconsistent fields for depth when using stencil only
Since Gfx12+ 3DSTATE_STENCIL_BUFFER gained its own
Width/Depth/Format/etc... fields. So don't set those fields but leave
the address/pitch to 0.
Issue found on simulation.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15637>
Sil Vilerino [Mon, 17 Apr 2023 15:50:30 +0000 (11:50 -0400)]
frontend/va: Add VAProfileH264High10
Acked-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22539>
Sil Vilerino [Mon, 17 Apr 2023 12:56:48 +0000 (08:56 -0400)]
d3d12: Support PIPE_VIDEO_CAP_ENC_QUALITY_LEVEL
Only return we support 1 quality level. The point of returning this
cap is that vlVaEndPicture will check for it and otherwise overwrite
some rate control parameters with defaults
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22530>
Sil Vilerino [Sat, 15 Apr 2023 22:27:29 +0000 (18:27 -0400)]
d3d12: Support PIPE_VIDEO_CAP_MIN_WIDTH/HEIGHT caps
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22530>
Sil Vilerino [Sun, 16 Apr 2023 17:20:55 +0000 (13:20 -0400)]
d3d12: Support QPMin/QPMax app params
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22530>
Sil Vilerino [Sat, 15 Apr 2023 20:10:30 +0000 (16:10 -0400)]
d3d12: Support rate control HRD and MaxFrameSize app params
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22530>
Sil Vilerino [Sat, 15 Apr 2023 19:43:52 +0000 (15:43 -0400)]
d3d12: Support QVBR rate control mode
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22530>
Sil Vilerino [Sun, 16 Apr 2023 17:20:26 +0000 (13:20 -0400)]
frontend/va: Allow distinction for Min/MaxQP params sent from app and frontend defaults
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22530>
Sil Vilerino [Sat, 15 Apr 2023 20:09:58 +0000 (16:09 -0400)]
frontend/va: Allow distinction for HRD params sent from app and frontend defaults
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22530>
Sil Vilerino [Sat, 15 Apr 2023 19:43:34 +0000 (15:43 -0400)]
frontend/va: Support QVBR rate control mode
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22530>
Patrick Lerda [Wed, 29 Mar 2023 19:55:47 +0000 (21:55 +0200)]
lima: fix refcnt imbalance related to framebuffer
Indeed, the current framebuffer hardcoded cleanup
is not sufficient.
For instance, this issue is triggered with:
"piglit/bin/fbo-depthstencil clear default_fb -samples=2 -auto"
while setting GALLIUM_REFCNT_LOG=refcnt.log.
cc: mesa-stable
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Erico Nunes <nunes.erico@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22234>
José Roberto de Souza [Wed, 23 Nov 2022 20:33:56 +0000 (12:33 -0800)]
build: Add Iris and ANV to ARM's auto-generated drivers
Xe KMD supports ARM CPUs, so we are now able to have Intel discrete
GPUs with ARM CPUs working.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22476>
José Roberto de Souza [Tue, 28 Mar 2023 15:49:30 +0000 (08:49 -0700)]
iris: Fix vm bind of imported bos from other GPUs
The imported buffer may be created in a device with different
memory alignment and this can cause vm bind to fail because bo
size is smaller than vm bind range aligned.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22476>
José Roberto de Souza [Tue, 14 Feb 2023 19:43:44 +0000 (11:43 -0800)]
iris: Implement batch_submit() in Xe kmd backend
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22476>
Nanley Chery [Mon, 10 Apr 2023 21:26:37 +0000 (14:26 -0700)]
iris/bufmgr: Handle flat_ccs for BO_ALLOC_ZEROED
We can't map the CCS memory region. So, rely on the kernel's zeroing of
new allocations. This is helpful when creating dmabufs that use
compression.
Cc: mesa-stable
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22487>
Nanley Chery [Mon, 10 Apr 2023 21:18:56 +0000 (14:18 -0700)]
iris/bufmgr: Add and use zero_bo
This simplifies the next patch.
Cc: mesa-stable
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22487>
Nanley Chery [Mon, 10 Apr 2023 19:39:42 +0000 (12:39 -0700)]
iris: Allocate ZEROED BOs for shared resources
A port of
cbee2d1102c ("i965/screen: Allocate ZEROED BOs for images").
Cc: mesa-stable
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22487>
Erico Nunes [Mon, 17 Apr 2023 14:06:02 +0000 (16:06 +0200)]
lima/ci: temporarily disable deqp-egl tests due to timeouts
A regression causing these tests to become unstable was introduced while
lima CI was disabled in the last days. It seems to be caused by the
latest kernel bump, but still needs more investigation.
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22531>
Sil Vilerino [Mon, 17 Apr 2023 14:54:09 +0000 (10:54 -0400)]
d3d12: Do not fail d3d12_screen creation if D3D12_FEATURE_D3D12_OPTIONS14 not available
Fixes:
52ee566bc550b4822c4a563e480e869b8228917b ("d3d12: Query device for D3D12_FEATURE_D3D12_OPTIONS14")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22534>
Leo Liu [Thu, 13 Apr 2023 15:29:39 +0000 (11:29 -0400)]
radeonsi: create a new context for transcode with multiple video engines
For CHIP_GFX1100, there are 2 VCN instances but using unified queue i.e.
decode and encode will go to HW via same ring type. With AMDGPU kernel
scheduler, since the trancode is sharing the same pipe context, so that
the gpu scheduler assign the decode and encode into the same VCN engine.
In order to use both engines with transcode case, the new pipe context will
be created when the case being detected, with that the transcode can be
load balanced with multiple VCN engines.
Signed-off-by: Leo Liu <leo.liu@amd.com>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22471>
José Roberto de Souza [Thu, 30 Mar 2023 19:13:11 +0000 (12:13 -0700)]
intel/common: Add gt_id to intel_engine_class
MTL and newer platforms on Xe kmd will have engines with gt_id != 0.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22477>
José Roberto de Souza [Fri, 14 Apr 2023 13:35:07 +0000 (06:35 -0700)]
iris: Fix close of exported bos
On commit
910e659e31cb ("iris: Add function to close gem bos") I used
iris_bo_close() to close exported bos with the wrong drm_fd.
Causing piglit ext_image_dma_buf_import.ext_image_dma_buf_import*
tests to crash during tear-down.
So here adding iris_bufmgr_bo_close() that will close bos that belongs
to bufmgr->fd and changing the parameters of iris_bo_close() to close
the bo of given fd.
Fixes:
910e659e31cb ("iris: Add function to close gem bos")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8836
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22501>
Lionel Landwerlin [Sat, 12 Nov 2022 22:24:11 +0000 (00:24 +0200)]
vulkan/overlay: deal with unknown pNext structures
To implement some of the features of the layer, we need to enable some
of the feature bits at device/command_buffer creation. To do so, we
need to edit some of the structures coming from the application. Most
of those are const so we need to clone them before edition.
This change disables some of the layer features if we run into a
situation where one of the structure we need to clone is unknown such
that we can't make a copy of it (since we don't know its size).
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7677
Cc: mesa-stable
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19897>
Erico Nunes [Sun, 26 Mar 2023 19:12:18 +0000 (21:12 +0200)]
lima: fix stringop-overflow warning
New versions of gcc output a warning about this code, apparently
because of the mix of signed and unsigned operations in the loop
condition. Rework the types to fix the warning.
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22129>
Patrick Lerda [Sat, 1 Apr 2023 21:08:09 +0000 (23:08 +0200)]
r600: fix refcnt imbalance related to evergreen_set_shader_images()
Indeed, the reference was overwritten.
For instance, this issue is triggered with:
"piglit/bin/shader_runner tests/spec/arb_shader_image_load_store/execution/write-to-rendered-image.shader_test -auto -fbo"
while setting GALLIUM_REFCNT_LOG=refcnt.log.
Fixes:
a6b379284365 ("r600: add core pieces of image support.")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22394>
Andres Calderon Jaramillo [Sat, 15 Apr 2023 06:34:14 +0000 (06:34 +0000)]
r600: Report multi-plane formats as unsupported
This is the analogous of
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9490 but for
r600.
Discoloration of NV12 video frames was observed in Chrome/ChromeOS and
the problem was tracked down to the fact that Mesa was following the
PIPE_FORMAT_R8_G8B8_420_UNORM/lower_yuv_external() path. The symptom is
that (for an unknown reason) the YUV-to-RGB conversion is using the
value of Y as the value of Y, U, and V. So, for example, if the input
value is YUV = (50, 120, 130), then what actually gets converted to RGB
is YUV = (50, 50, 50).
Considering that PIPE_FORMAT_R8_G8B8_420_UNORM was introduced for
freedreno
(https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6693) and it
is already being reported as unsupported for radeonsi, it's reasonable
to assume that GPUs targeted by r600 don't support this path either.
Note: I tested this patch with an AMD Palm device which follows the
evergreen_is_format_supported() path. I did not have access to a device
to test the r600_is_format_supported() path.
v2: Changed >= 2 to > 1.
Fixes:
826a10255f5 ("st/mesa: Add NV12 lowering to PIPE_FORMAT_R8_G8B8_420_UNORM")
Tested-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22511>
David Redondo [Fri, 14 Apr 2023 09:47:43 +0000 (11:47 +0200)]
egl/wayland: fix oob buffer access during buffer_fds clean up
After iterating through the number of planes in the above for
loop i is more than the number of planes which corresponds to
the size of the buffer_fds array.
Fixes:
967b9ad084e ("egl/wayland: for prime, allocate linear_copy from display GPU VRAM")
Signed-off-by: David Redondo <kde@david-redondo.de>
Reviewed-by: Simon Ser <contact@emersion.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22496>
Samuel Pitoiset [Thu, 13 Apr 2023 08:28:52 +0000 (10:28 +0200)]
radv: disable fast-clears with CMASK for 128-bit formats
This isn't supported according to RadeonSI.
This fixes a piglit test with Zink that uses a R32G32B32A32_SINT format
with MSAA 8x. This is because DCC fast-clears with MSAA require to
clear CMASK too.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7313
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22462>
Qiang Yu [Tue, 11 Apr 2023 11:39:28 +0000 (19:39 +0800)]
radeonsi: remove separate_prolog parameter
si_get_ps_prolog_key is only called by part mode shader now.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Tue, 11 Apr 2023 10:47:51 +0000 (18:47 +0800)]
radeonsi: restructure mono merged shader build
No function change, just refine to share more code.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Fri, 3 Mar 2023 07:09:25 +0000 (15:09 +0800)]
radeonsi: monolithic ps emit prolog in nir directly
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Fri, 3 Mar 2023 11:33:42 +0000 (19:33 +0800)]
radeonsi: handle lowered ps in scan_io_usage
si_update_shader_binary_info() will call into this function
to collect memory usage info after shader has been lowered
finally. To avoid assertion failure in nir_instr_as_intrinsic()
we have to check instruction type first.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Fri, 3 Mar 2023 04:06:16 +0000 (12:06 +0800)]
radeonsi: add si_nir_emit_polygon_stipple
Ported from si_llvm_emit_polygon_stipple().
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Fri, 3 Mar 2023 03:16:55 +0000 (11:16 +0800)]
radeonsi: add si_nir_lower_ps_color_input
For lowering legacy color inputs in PS.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Thu, 13 Apr 2023 02:43:48 +0000 (10:43 +0800)]
ac/llvm,radeonsi: lower ps color load in nir
Remove the color0/1 in ac_shader_abi which is used by
radeonsi only.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Thu, 2 Mar 2023 13:23:44 +0000 (21:23 +0800)]
ac/nir/ps: lower sample mask input when needed
Ported from si_llvm_build_ps_prolog().
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Thu, 2 Mar 2023 12:56:48 +0000 (20:56 +0800)]
ac/nir/ps: add force lower barycentric load options
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Thu, 2 Mar 2023 12:08:14 +0000 (20:08 +0800)]
ac/nir/ps: lower barycentric load when bc_optimize
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Thu, 2 Mar 2023 12:05:40 +0000 (20:05 +0800)]
radeonsi: implement nir_load_barycentric_optimize_amd
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Qiang Yu [Thu, 2 Mar 2023 12:04:52 +0000 (20:04 +0800)]
nir: add nir_load_barycentric_optimize_amd intrinsic
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21683>
Mike Blumenkrantz [Thu, 13 Apr 2023 17:54:24 +0000 (13:54 -0400)]
zink: make general bo allocation more robust by iterating
previously there was a fallback path here (broken by
f6d3a5755f6)
which would attempt to demote BAR allocations to other heaps on failure
to avoid oom
this was great, but it's not the most robust solution, which is to iterate
all the memory types matching the given heap and try them in addition to having
a demotion fallback
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22479>
Mike Blumenkrantz [Thu, 13 Apr 2023 17:56:55 +0000 (13:56 -0400)]
zink: restore BAR allocation failure demotion
this restores the fallback used when BAR allocation fails due to oom
by re-selecting memoryTypeIndex after the heap demotion
Fixes:
f6d3a5755f6 ("zink: zink_heap isn't 1-to-1 with memoryTypeIndex")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22479>
Mike Blumenkrantz [Thu, 13 Apr 2023 17:50:12 +0000 (13:50 -0400)]
zink: slightly rework memoryTypeIndex selection to pre-determine heap
should be no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22479>
Mike Blumenkrantz [Thu, 13 Apr 2023 17:48:54 +0000 (13:48 -0400)]
zink: move memoryTypeIndex selection down in general bo allocation
no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22479>
Erico Nunes [Sun, 16 Apr 2023 11:40:28 +0000 (13:40 +0200)]
Revert "ci: disable lima farm, currently out-of-space, needs to be fixed"
This reverts commit
78644c9bb0d3b7920f7676c6388b472510a54f0b.
Fixes:
78644c9bb0d3b7920f76 ("ci: disable lima farm, currently out-of-space, needs to be fixed")
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22513>
Eric Engestrom [Sun, 16 Apr 2023 19:48:56 +0000 (20:48 +0100)]
v3dv/ci: drop fixed failure from fails.txt
Fixes:
8976d8280ff45cd7f947 ("wsi: remove get_sorted_vk_formats duplication")
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22514>
David Heidelberg [Sun, 16 Apr 2023 00:28:57 +0000 (02:28 +0200)]
ci: uninstall libdrm from the GL and VK containers
Occasionally causing troubles on -valve jobs.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>
David Heidelberg [Sat, 15 Apr 2023 23:49:40 +0000 (01:49 +0200)]
ci: polish deqp-runner a bit
Plus cosmetics adjustments to pass more of shellcheck.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>
David Heidelberg [Sat, 15 Apr 2023 16:00:41 +0000 (18:00 +0200)]
ci/freedreno: fix the a530_piglit job and switch to Weston
If we count devices which running a530 with mainline kernel and Mesa,
it's probably mostly phones and tablets running on Wayland. Adapt to it.
Fixes:
83c2b26acf1e ("ci/freedreno: Switch the piglit job to using a deqp-runner suite.")
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>
David Heidelberg [Sat, 15 Apr 2023 13:50:45 +0000 (15:50 +0200)]
ci/freedreno: update a530 flakes, fails and skips
Add multiple skips for the:
- KHR-GLES31.core.pixelstoragemodes.teximage2d
- KHR-GLES31.core.pixelstoragemodes.teximage3d
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8837
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>
David Heidelberg [Sat, 15 Apr 2023 13:12:35 +0000 (15:12 +0200)]
ci/freedreno: a530 behaves stable in 6.3
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>
David Heidelberg [Wed, 12 Apr 2023 15:46:33 +0000 (17:46 +0200)]
ci: drop overriding new a530 firmware due to preemption issues with older kernel
Fixes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8825
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>
David Heidelberg [Thu, 13 Apr 2023 23:12:45 +0000 (01:12 +0200)]
ci/freedreno: do not restrict to 2 cpus on a530
Not needed for modern kernels (6.3+ for sure).
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>
David Heidelberg [Sun, 2 Apr 2023 13:32:26 +0000 (15:32 +0200)]
ci: bump kernel to the 6.3, support HDK 888 based on sm8350
- uprev to kernel 6.3-rc6
- add sm8350 support (needed for HDK 888)
- add missing patch for Asurada functionality
- enable CONFIG_ARM_SMMU_QCOM, since we dropped specific patch
worarounding need for it
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22255>
Emma Anholt [Mon, 3 Apr 2023 23:06:13 +0000 (16:06 -0700)]
tu/perfetto: s/MRTs/attachment_count/ in traces.
MRTs usually means >1 color buffers, so seeing "2" is surprising when
you're expecing just color and depth. Makes the output look more Vulkan.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>
Emma Anholt [Wed, 5 Apr 2023 22:52:04 +0000 (15:52 -0700)]
tu/perfetto: Drop unused arg to send_descriptors().
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>
Emma Anholt [Wed, 8 Mar 2023 20:30:24 +0000 (12:30 -0800)]
tu/perfetto: Use tu_CmdBeginDebugUtilsLabelEXT as a stage event in perfetto.
This lets zink mark points of interest (particularly its barriers and
blits) with some useful data, for presenting in perfetto traces.
Closes: #8487
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>
Emma Anholt [Wed, 29 Mar 2023 21:26:56 +0000 (14:26 -0700)]
tu/perfetto: Clean up an extra token paste to just use the arg being passed.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>
Emma Anholt [Wed, 29 Mar 2023 21:25:24 +0000 (14:25 -0700)]
tu/perfetto: Refactor code out of the macro, to stage_end.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22278>
Karol Herbst [Sat, 15 Apr 2023 01:48:16 +0000 (03:48 +0200)]
rusticl/event: drop work item before updating status
This fixes some CTS compiler tests where they relied on the cl_kernel
object to be released in time so it can recompile a program without
throwing CL_INVALID_OPERATION due to still having active kernel objects.
Fixes:
47a80d7ff4f ("rusticl/event: proper eventing support")
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22510>
Emma Anholt [Wed, 12 Apr 2023 19:13:24 +0000 (12:13 -0700)]
symbol_table: Prehash the key on insert, and reuse the entry on shadowing.
Mostly saves computing the hash twice, but while we're here there's no
need for shadowing to walk the table again.
Release Mesa build runtime of
KHR-Single-GL46.arrays_of_arrays_gl.SizedDeclarationsPrimitive -4.19869%
+/- 3.20231%
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451>
Emma Anholt [Wed, 12 Apr 2023 19:07:10 +0000 (12:07 -0700)]
symbol_table: Don't bother resetting the key on popping scope.
If you made a same-name symbol, then its name was just the name from the
parent scope anyway.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451>
Emma Anholt [Wed, 12 Apr 2023 18:55:13 +0000 (11:55 -0700)]
symbol_table: Don't maintain the HT as we're destroying the table.
Release Mesa build runtime of
KHR-Single-GL46.arrays_of_arrays_gl.SizedDeclarationsPrimitive -5.05801%
+/- 3.41206% (n=12)
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451>
Emma Anholt [Wed, 12 Apr 2023 18:30:24 +0000 (11:30 -0700)]
symbol_table: Store the symbol name in the same allocation as the symbol entry.
Saves an extra malloc. Release Mesa build runtime of
KHR-Single-GL46.arrays_of_arrays_gl.SizedDeclarationsPrimitive (which is a
lot of GLSL 4.60 builtin vars symbol table setup) -5.15821% +/- 3.19636%
(n=13).
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22451>
David Heidelberg [Fri, 14 Apr 2023 01:52:03 +0000 (03:52 +0200)]
ci/amd: update checksums after DXVK 2.1 update
Heaven got fixed with DXVK 2.1.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447>
David Heidelberg [Sat, 28 Jan 2023 08:15:13 +0000 (09:15 +0100)]
ci/dxvk: uprev to 2.1
Major uprev, requires VK 1.3 now.
Acked-by: Martin Roukala <martin.roukala@mupuf.org>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447>
David Heidelberg [Thu, 13 Apr 2023 22:17:13 +0000 (00:17 +0200)]
ci/amd: 4/5 runners TPad-C13 runners are online, restore most of the tests
Partial revert of
590959057c2b ("ci/amd: raven is currently downgraded
to 2 machines only, adapt")
Test which remains disabled: radeonsi-raven-va:amd64 (VAAPI testing).
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22447>
Lionel Landwerlin [Thu, 13 Apr 2023 18:29:36 +0000 (21:29 +0300)]
anv: enable blorp query reset for performance queries
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Felix DeGrood <felix.j.degrood@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22480>
Michel Dänzer [Wed, 12 Apr 2023 16:21:22 +0000 (18:21 +0200)]
ci: Drop executable permissions from backend compiler wrapper script
Not needed anymore, since the frontend scripts just source the backend
script now.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438>
Michel Dänzer [Wed, 12 Apr 2023 09:27:56 +0000 (11:27 +0200)]
ci: Remove shebang from backend compiler wrapper script
Not needed anymore, since the frontend scripts just source the backend
script now.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438>
Michel Dänzer [Wed, 12 Apr 2023 09:26:07 +0000 (11:26 +0200)]
ci: Use set -e in frontend compiler wrapper scripts.
I doubt the shebang line in the backend script has any effect now,
since the frontend scripts just source it directly.
v2:
* Use "set -e" instead of adding -e to shebang (Eric Engestrom)
v3:
* Apply to the clang wrapper scripts as well (Eric Engestrom)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438>
Michel Dänzer [Wed, 12 Apr 2023 09:24:13 +0000 (11:24 +0200)]
ci: Explicitly test for meson feature checks in compiler wrapper
The previous indirect method was more complicated and still error prone.
v2:
* Use "grep -E" (Eric Engestrom)
* Exclude spaces and slashes in the grep pattern, to avoid accidentally
matching across unrelated compiler arguments.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22438>
Jesse Natalie [Thu, 13 Apr 2023 21:02:58 +0000 (14:02 -0700)]
util: Delete Offset() macro from u_memory.h
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22494>
Caio Oliveira [Wed, 15 Mar 2023 16:50:16 +0000 (09:50 -0700)]
spirv/tests: Add test for single-block loop
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22509>
Jesse Natalie [Fri, 14 Apr 2023 16:21:26 +0000 (09:21 -0700)]
dzn: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504>
Jesse Natalie [Fri, 14 Apr 2023 16:21:21 +0000 (09:21 -0700)]
microsoft/clc: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504>
Jesse Natalie [Fri, 14 Apr 2023 16:21:04 +0000 (09:21 -0700)]
d3d12: Remove #if D3D12_SDK_VERSION blocks now that 610 is required
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22504>
Luc Ma [Fri, 14 Apr 2023 10:53:57 +0000 (18:53 +0800)]
meson: keep Mako version checking in accord with build msg
Fixes:
52194ae4df1 ("meson: Ensure that mako is >= 0.8.0")
Signed-off-by: Luc Ma <luc@sietium.com>
Reported-by: Terry Zhang <terry@sietium.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22499>
Sathishkumar S [Wed, 29 Mar 2023 10:58:50 +0000 (05:58 -0500)]
radeonsi/vcn: engage all jpeg engines on gfx940 for mjpeg decode
engage all available jpeg engines to decode mjpeg video frames
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388>
Sathishkumar S [Thu, 6 Apr 2023 07:46:46 +0000 (02:46 -0500)]
radeonsi/vcn: enable RGBP format on gfx940 jpeg
decode output format conversion to RGBP is supported on gfx940 jpeg.
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388>
Sathishkumar S [Wed, 29 Mar 2023 07:08:14 +0000 (02:08 -0500)]
frontends/va: add support for RGBP rt_format
check and enable RGBP rt_format and support VaImage creation for the RGBP/ARGB.
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388>
Sathishkumar S [Wed, 29 Mar 2023 07:03:38 +0000 (02:03 -0500)]
util/format: add planar3 r8_g8_b8_unorm pipe format
add pipe format to represent three plane 8bit RGB format
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22388>
Felix DeGrood [Mon, 20 Mar 2023 16:30:26 +0000 (16:30 +0000)]
docs: add INTEL_MEASURE=cpu
Update documentation about INTEL_MEASURE=cpu
Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>
Felix DeGrood [Thu, 23 Feb 2023 16:09:16 +0000 (16:09 +0000)]
iris: Enable INTEL_MEASURE=cpu
Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>
Felix DeGrood [Wed, 22 Feb 2023 19:29:28 +0000 (19:29 +0000)]
anv: Enable INTEL_MEASURE=cpu
Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>
Felix DeGrood [Wed, 22 Feb 2023 01:40:19 +0000 (01:40 +0000)]
intel: INTEL_MEASURE cpu mode
INTEL_MEASURE normally measures timing of GPU events. However, it
is sometimes useful to instead measure when these gfx API calls
were requested of the driver. INTEL_MEASURE cpu can be used in
in conjunction with other driver debug capabilities, like
INTEL_DEBUG=pc for analyzing stalls/flushes or when debugger is
attached, to track which frame you're currently on or where in
the frame you're at.
Initial commit, without plumbing into anv/iris.
"INTEL_MEASURE=cpu" will collect a cpu timestamp for each
INTEL_MEASURE event instead of GPU timestamps.
Reviewed-by: Mark Janes <markjanes@swizzler.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21505>