Nicolai Hähnle [Fri, 17 Feb 2017 15:38:02 +0000 (16:38 +0100)]
Fix shaders using reserved keywords incorrectly
"input" is a reserved keyword in GLSL 1.40 (and other versions,
for that matter); this test should never have passed for any
correct implementation.
"unsigned int" should be "uint".
Affects:
GL45-CTS.sparse_buffer_tests.BufferStorageTest
Modules: OpenGL
VK-GL-CTS Issue: 177
Change-Id: I68bba7548225ada7949182a1239d423eff15fc35
Eduardo Lima Mitev [Wed, 15 Feb 2017 11:37:31 +0000 (12:37 +0100)]
GetTextureSubImageTests: Remove m_texture_rectangle_compressed
GetTextureSubImage::Errors test attempts to setup a compressed texture
using GL_TEXTURE_RECTANGLE as target, during test preparation. This is
explicitly forbidden by the spec.
From OpenGL 4.5 PDF, section "8.7. COMPRESSED TEXTURE IMAGES", page 214:
"An INVALID_ENUM error is generated if the target parameter to any
of the CompressedTexImagenD commands is TEXTURE_RECTANGLE or
PROXY_TEXTURE_RECTANGLE ."
This patch removes the m_texture_rectangle_compressed texture from the
test, and all the associated test sub-cases.
Affects: GL45-CTS.get_texture_sub_image.errors_test
VK-GL-CTS issue: 169
Components: OpenGL
Change-Id: Ia3c2008cb948662f064dbc13fcd4d61c7d2caebf
Andres Gomez [Tue, 20 Dec 2016 17:25:46 +0000 (19:25 +0200)]
Unsized array of arrays in uniform block
From the GL_ARB_arrays_of_arrays spec:
"For unsized arrays, only the outermost dimension can be lacking a
size. A type that includes an unknown array size cannot be formed
into an array until it gets an explicit size."
This is later further detailed as per OpenGL® Shading Language 4.40.
From page 3 (page 9 of the PDF) of the GLSL 4.00 v9 spec:
"* Bug 11987: Allow array-of-array constructors and initialized
variables to have any dimension unsized (not just the outer
dimension) and get their size from the content of the constructor
or initializer."
From page 37 (page 43 of the PDF) of the GLSL 4.00 v9 spec:
" vec4 a[][] = { vec4[2](vec4(0.0), vec4(1.0)), // okay, size to
vec4[2](vec4(0.0), vec4(1.0)), // a[3][2]
vec4[2](vec4(0.0), vec4(1.0)) };"
From page 38 (page 44 of the PDF) of the GLSL 4.00 v9 spec:
"For implicitly-sized or run-time-sized arrays, only the outermost
dimension can be lacking a size. A type that includes an unknown
array size cannot be formed into an array until it gets an explicit
size, except for shader storage blocks where the only unsized array
member is the last member of the block."
Hence, in the absence of a constructor/initializer, unsized arrays are
only allowed for the outermost dimension of an AoA.
Affects:
GL43-CTS.arrays_of_arrays_gl.InteractionUniformBuffers3
Components: OpenGL
VK-GL-CTS issue: 146
Change-Id: Icbfe49c16e8ce7ffd55b92adede90405ac8e5f26
Andres Gomez [Tue, 20 Dec 2016 17:25:46 +0000 (19:25 +0200)]
Unsized array of arrays in shader storage block
From the GL_ARB_arrays_of_arrays spec:
"For unsized arrays, only the outermost dimension can be lacking a
size. A type that includes an unknown array size cannot be formed
into an array until it gets an explicit size."
This is later further detailed as per OpenGL® Shading Language 4.40.
From page 3 (page 9 of the PDF) of the GLSL 4.00 v9 spec:
"* Bug 11987: Allow array-of-array constructors and initialized
variables to have any dimension unsized (not just the outer
dimension) and get their size from the content of the constructor
or initializer."
From page 37 (page 43 of the PDF) of the GLSL 4.00 v9 spec:
" vec4 a[][] = { vec4[2](vec4(0.0), vec4(1.0)), // okay, size to
vec4[2](vec4(0.0), vec4(1.0)), // a[3][2]
vec4[2](vec4(0.0), vec4(1.0)) };"
From page 38 (page 44 of the PDF) of the GLSL 4.00 v9 spec:
"For implicitly-sized or run-time-sized arrays, only the outermost
dimension can be lacking a size. A type that includes an unknown
array size cannot be formed into an array until it gets an explicit
size, except for shader storage blocks where the only unsized array
member is the last member of the block."
Hence, in the absence of a constructor/initializer, unsized arrays are
only allowed for the outermost dimension of an AoA.
Affects:
GL43-CTS.arrays_of_arrays_gl.InteractionStorageBuffers3
Components: OpenGL
VK-GL-CTS issue: 145
Change-Id: Ic751b3ff52a84e3aee604552edf9441211890a11
Andres Gomez [Tue, 20 Dec 2016 16:57:57 +0000 (18:57 +0200)]
Unsized array of arrays in uniform variable
From the GL_ARB_arrays_of_arrays spec:
"For unsized arrays, only the outermost dimension can be lacking a
size. A type that includes an unknown array size cannot be formed
into an array until it gets an explicit size."
This is later further detailed as per OpenGL® Shading Language 4.40.
From page 3 (page 9 of the PDF) of the GLSL 4.00 v9 spec:
"* Bug 11987: Allow array-of-array constructors and initialized
variables to have any dimension unsized (not just the outer
dimension) and get their size from the content of the constructor
or initializer."
From page 37 (page 43 of the PDF) of the GLSL 4.00 v9 spec:
" vec4 a[][] = { vec4[2](vec4(0.0), vec4(1.0)), // okay, size to
vec4[2](vec4(0.0), vec4(1.0)), // a[3][2]
vec4[2](vec4(0.0), vec4(1.0)) };"
From page 38 (page 44 of the PDF) of the GLSL 4.00 v9 spec:
"For implicitly-sized or run-time-sized arrays, only the outermost
dimension can be lacking a size. A type that includes an unknown
array size cannot be formed into an array until it gets an explicit
size, except for shader storage blocks where the only unsized array
member is the last member of the block."
Hence, in the absence of a constructor/initializer, unsized arrays are
only allowed for the outermost dimension of an AoA.
Affects:
GL43-CTS.arrays_of_arrays_gl.InteractionUniforms2
Components: OpenGL
VK-GL-CTS issue: 144
Change-Id: Icd3e710f1bb69b35355a5c4172dc8839b9f98c82
Alejandro Piñeiro [Fri, 3 Feb 2017 17:33:02 +0000 (18:33 +0100)]
BufferStorageTests: do not unmap with MapOwner if not needed
This test uses the following method to call MapRange on a buffer:
Buffer::MapOwner Buffer::MapRange(glw::GLintptr offset,
glw::GLsizeiptr length,
glw::GLenum access)
It returns a MapOwner, that unmaps the buffer when it is destroyed.
For some tests, it is called like this:
{ /* start test */
{
buffer.MapRange(<params>);
} /* freed here */
/* Do stuff with the buffer. Assumes to be still mapped */
/* Checks the buffer */
} /* end test */
The problem with this approach is that as the Mapowner returned by
MapRange is not used, it is destroyed (on the previous code snippet at
"freed here"), and the buffer is unmapped unintentionally.
This patch gets out the call to MapRange, so it is not unmapped until
the end (on the code snippet, at "end test").
Fixes the following tests (only Mesa Intel driver tested):
GL45-CTS.buffer_storage.get_buffer_parameter
GL45-CTS.buffer_storage.map_persistent_buffer_sub_data
GL45-CTS.buffer_storage.map_persistent_read_pixels
Components: OpenGL
VK-GL-CTS issue: 148
Change-Id: I676eeaf0808e9bb19617bde7d658c14859f1357d
Maciej Jesionowski [Tue, 17 Jan 2017 15:36:33 +0000 (16:36 +0100)]
Add render to mipmaps tests
This test repeatedly draws into the same image using consecutive
mip levels as color and dept/stencil attachments. All mip levels
and array layers are exercised.
Modified tests:
dEQP-VK.pipeline.render_to_image.*
New tests:
dEQP-VK.pipeline.render_to_image.*.mipmap.*
Components: Vulkan
Vulkan CTS issue: 487, 535
Change-Id: I7e4b3c6978d069c0accc377e9ab6e9d05e8e3cc6
Maciej Jesionowski [Tue, 17 Jan 2017 15:36:33 +0000 (16:36 +0100)]
Add max size attachments tests
This test creates very big color, and depth/stencil attachments
in all possible dimensions and layers.
Original tests in the affected group were moved to *.small.*
subgroup.
Modified tests:
dEQP-VK.pipeline.render_to_image.*.small.*
New tests:
dEQP-VK.pipeline.render_to_image.*.huge.*
Components: Vulkan
Vulkan CTS issue: 451, 535
Change-Id: I1e3bd1f7a657ff837b830bbada539a1240b1fd04
Iago Toral Quiroga [Tue, 10 Jan 2017 11:50:23 +0000 (12:50 +0100)]
Add framebuffer attachment size tests
New tests:
- dEQP-VK.pipeline.framebuffer_attachment.*
VK-GL-CTS issue: 72
Components: Vulkan
Change-Id: Iab4c077d60471633688476a87570e779d56bcda8
Boris Zanin [Tue, 21 Feb 2017 11:56:07 +0000 (12:56 +0100)]
Build fix (uint32_t used instead of deUint32)
It looks like uint32_t is not used within the CTS.
Replacing it with deUint32 allows build to pass.
Components: Vulkan
VK-GL-CTS Issue #66
Change-Id: Ia23f3fb7fe87ec21349c46df52c7b9f83dd14a32
Boris Zanin [Mon, 13 Feb 2017 09:47:28 +0000 (10:47 +0100)]
Workaround SSL cert issues, enable python 3
* The script command line switch --insecure added to bypass SSL
certificate validity checks. Though bypassing is not recommended,
sometimes the issue can be resolved on the remote side only,
which we have no control over. For example please see
https://sourceforge.net/p/forge/site-support/14336/
The parameter is supported for pythons 2.7.9 and 3.4.3 and newer,
due to older versions of urlopen do not support context parameter
* Minor changes allow to run fetch_sources.py under both v2 and v3
pythons. Changes required due to python 3 prohibits statement-style
usage for print and forces print statements to be converted into
functions. Also urlopen() is in library urllib.request in python 3
Components: Framework
VK-GL-CTS Issue #64
Change-Id: If4354332ea19878f8f72352e2df5cac9ee254ac6
Marcin Kańtoch [Fri, 10 Feb 2017 09:43:52 +0000 (10:43 +0100)]
Fix incorrectly defined image memory barrier
In ResolveImageToImage::iterate() method a memory barrier is defined
to change the layout of source image. By mistake destination image
parameters are used to define subresource range. It causes validation
errors as in some cases the subresource range extends beyond
the dimensions of the source image.
The fix uses source image parameters to define the memory barrier.
Modified tests:
dEQP-VK.api.copy_and_blit.resolve_image.*
Components: Vulkan
VK-GL-CTS issue: 160
Change-Id: I0ef72fbc99b127129441b7c66b43afd7b5a1e0ef
Nicolai Hähnle [Thu, 2 Feb 2017 15:18:57 +0000 (16:18 +0100)]
Move DrawElementsBaseVertexTests to GL40 package
These tests make use of tessellation shaders, which were introduced
in 4.0.
The "using deqp::TestCaseGroup" is added to fix compilation:
gl3cTestPackages.cpp refers to glcts::TestCaseGroup. Similar using
directives are spread throughout the code base, one of them is in
esextcDrawElementsBaseVertexTests.hpp, which is no longer included.
Affects:
GL45-CTS.draw_elements_base_vertex_tests.*
Components: OpenGL
VK-GL-CTS issue: 28
Change-Id: I7fd2d2a641532ee4ac44ad2d71544ce08b9b69ec
Jason Ekstrand [Tue, 24 Jan 2017 01:44:17 +0000 (17:44 -0800)]
dEQP-VK: Enable b10g10r11 and e5b9g9r9 blitting tests
This enables 620 new tests for blitting to/from e5b9g9r9 and b10g10r10.
Looking through vulkan.gpuinfo.org, most implementations support the
BLIT_SRC_BIT on these formats. I have a branch of our driver that
supports BLIT_DST_BIT for these formats and the tests all work fine.
Change-Id: I964abad8c44d3d7cc52a79bbb73ee6b9833845d6
Pyry Haulos [Thu, 16 Feb 2017 19:24:18 +0000 (11:24 -0800)]
Fix dethread build for OS X and iOS
Change-Id: I6fb2f2af89d7568bd473597a0d413c3987e457ae
Pyry Haulos [Fri, 27 Jan 2017 17:02:12 +0000 (09:02 -0800)]
Fix atan2() precision tests and add to mustpass
atan2() had a bug where tests were rounding codomain -PI..PI inwards,
not outwards, causing it to reject perfectly valid roundings of constant
PI.
Changed tests:
dEQP-VK.glsl.builtin.precision.atan2.*
Change-Id: Ib75da103944f773dd819c459b9aa1257c58ca921
Components: Vulkan
Alexander Galazin [Tue, 14 Feb 2017 12:24:14 +0000 (13:24 +0100)]
Fix coding error in protocol detection
* add 'return' statement to detectProtocol
* call detectProtocol as a class member not as a global function
Components: Framework
Affects: KC CTS checkout
Change-Id: Id226166d0c35f6d10b23307e5cdec0fbd29102e8
Mika Isojärvi [Wed, 8 Feb 2017 00:37:51 +0000 (16:37 -0800)]
Add create functions for common Vulkan types.
These functions simplify creating the Vulkan objects by taking the
arguments directly instead of passing through struct. Multiple test
cases already reimplement these functions.
Change-Id: I09f6b0163b5aa2198617230767cd072185afe45c
Pyry Haulos [Mon, 13 Feb 2017 21:11:53 +0000 (13:11 -0800)]
Improve precision handling in texture.explicit_lod
This change improves precision requirement handling in
dEQP-VK.texture.explicit_lod test group by adding separate controls for
format conversion and filtering math.
Changed tests:
dEQP-VK.texture.explicit_lod.*
Components: Vulkan
Change-Id: Id64da1d63d87d02c73c757a3f2d5d50f2fbc19c0
Pyry Haulos [Mon, 13 Feb 2017 19:16:33 +0000 (11:16 -0800)]
Start new mustpass for Vulkan CTS 1.0.3
Vulkan CTS 1.0.2 mustpass is now archived under mustpass/1.0.2 and new
mustpass can be found under mustpass/1.0.3.
Components: Vulkan
Change-Id: I7c073dc7436a434558ba1710e01988377a8d686c
Pyry Haulos [Mon, 13 Feb 2017 19:06:24 +0000 (11:06 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: I0fc80b05b1d3a795fff26f6c971e57064d224478
Pyry Haulos [Mon, 13 Feb 2017 18:42:12 +0000 (10:42 -0800)]
Update Android CTS Vulkan mustpass
Following commits modify Vulkan CTS 1.0.2 mustpass:
*
fbaba83dbee101b3096ce33f21ae398efee3fa67
*
c09596ed4b8d17f057f77a42475d59c1ac126797
This change simply updates Android version of mustpass to match Khronos
Vulkan CTS 1.0.2 mustpass.
Change-Id: I79e2696ec4c457d11b59e03cf2a73977ab98d8d5
Components: AOSP
Pyry Haulos [Tue, 31 Jan 2017 00:02:32 +0000 (16:02 -0800)]
Update Android CTS Vulkan mustpass to match 1.0.2
This CL updates Android CTS mustpass for Vulkan to match Khronos Vulkan
CTS 1.0.2.0.
Change-Id: Ia2f82b5f6675c67940679eb98f59510f264d62bf
(cherry picked from commit
15f342274521c1be1032e993dbfd4a46b878f337)
Pyry Haulos [Mon, 13 Feb 2017 18:34:40 +0000 (10:34 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: Ie75f95c0972b43843398ca6d68fd39a538f23761
Pyry Haulos [Mon, 13 Feb 2017 18:34:37 +0000 (10:34 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: Ida077bae420c265f4a92d78d68b0f1c9b8d1c85c
Iago Toral Quiroga [Fri, 10 Feb 2017 10:35:52 +0000 (11:35 +0100)]
Write gl_PointSize value when it is undefined
gl_PointSize is undefined unless expicitly written to. The only
exception to this rule is the case when
shaderTessellationAndGeometryPointSize is disabled, in which case it
defaults to 1.0 for these stages.
Since we don't have access to the physical device features at shader
compile time, implement two variants of the tessellation evaluation
shader when point mode is enabled, one that writes gl_PointSize and
one that doesn't and decide the one we need at run time based on
whether the feature is enabled or not.
Components: Vulkan
Fixes VK-GL-CTS issue: 159
Affects:
dEQP-VK.tessellation.primitive_discard.*point_mode
Change-Id: Idadbc70a704f00ed601ff65afeb2a3edfbeb3f19
Iago Toral Quiroga [Thu, 2 Feb 2017 09:09:53 +0000 (10:09 +0100)]
Fix crashes in dEQP-VK.glsl.matrix.inverse.*
This is a regression caused by altering the value of the GRID_SIZE
in commit
2ba66fa2, which results in the inverse() tests generating
input matrices which determinant is zero, and thus, cannot be
inverted, which makes the tests hit an assertion.
This patch adds a mechanism for shader tests to specify a grid size
different from the default. This allows shader testst that are
sensitive to this value, such as matrix inverse tests, to define
their own requirements.
Fixes VK-GL-CTS isssue: 66
Components: Vulkan
Affects:
dEQP-VK.glsl.matrix.inverse.*
Change-Id: I31a34c2d156ee5b98d2de1b10ac4cec1a90d480e
Antia Puentes [Tue, 17 Jan 2017 20:30:31 +0000 (21:30 +0100)]
geometry_shader/api: Fix linking error
The tests redeclared the built-in 'gl_PerVertex' interface block in the
Vertex shader when run in a GL context. However, they did not redeclare
'in gl_PerVertex gl_in[]' and they used it, leading to an undesirable
linking error which is not what the test wished to check.
The patch adds the 'in gl_PerVertex gl_in[]' redeclaration to the
Geometry shader when the tests are run under GL.
From the GLSL 4.5 specification, "7.1 Built-In Language Variables"
(page 130):
"If multiple shaders using members of a built-in block belonging to
the same interface are linked together in the same program, they
must all redeclare the built-in block in the same way, as described
in section 4.3.9 “Interface Blocks” for interface-block matching, or
a link-time error will result. It will also be a link-time error if
some shaders in a program redeclare a specific built-in interface
block while another shader in that program does not redeclare that
interface block yet still uses a member of that interface block. If
a built-in block interface is formed across shaders in different
programs, the shaders must all redeclare the built-in block in the
same way (as described for a single program), or the values passed
along the interface are undefined."
VK-GL-CTS Issue: 130
Components: OpenGL
Affects:
GL44-CTS.geometry_shader.api.insufficient_emitted_vertices
GL44-CTS.geometry_shader.api.incompatible_draw_call_mode
GL45-CTS.geometry_shader.api.insufficient_emitted_vertices
GL45-CTS.geometry_shader.api.incompatible_draw_call_mode
Change-Id: I7d5f54b287b778e46376ef6ac9effcd90778705c
Nicolai Hähnle [Thu, 2 Feb 2017 15:43:40 +0000 (16:43 +0100)]
Take GL_MAX_IMAGE_SAMPLES into account
GL45-CTS.shader_texture_image_samples_tests.image_functional_test
tests imageSamples(), but binds images without checking whether their
number of samples are within the bounds allowed by
GL_MAX_IMAGE_SAMPLES.
This change brings the test in line with the shader_image_size_test,
which also skips unsupported sample counts.
Affects:
GL45-CTS.shader_texture_image_samples_tests.image_functional_test
Components: OpenGL
VK-GL-CTS issue: 29
Change-Id: Ia945a0f6472317f9014d4f820572eb006743450a
Adam Czupryna [Mon, 19 Dec 2016 15:07:42 +0000 (16:07 +0100)]
Add CTS_ARB_sparse_texture_clamp test specification proposal
This is CTS_ARB_sparse_texture_clamp test specification proposal.
components: OpenGL
VK-GL-CTS issue: 60
Change-Id: Ic11f1752e7f875d2cf55ad3fa4bf954c8a714fe3
Daniel Koch [Thu, 8 Dec 2016 07:24:40 +0000 (02:24 -0500)]
Enable GL support for Android build
- Add GL45Activity which creates a GL4.5 core activity
- Enable android build scripts to take 'gl' as argument for
-glcts-gtf-target
- update documentation for Android building and running
Components: Framework, AOSP, OpenGL
Change-Id: I2231adac800ac641287f157c712a25d9ddd66853
Pyry Haulos [Wed, 11 Jan 2017 23:11:26 +0000 (15:11 -0800)]
Android: Warn about inconsistent OpSMod and OpSRem
Change-Id: Ib0e32c55f9236e4f77ad461341329cce41c22e0a
Igor Ostrowski [Mon, 2 Jan 2017 16:41:30 +0000 (17:41 +0100)]
Add copy image to image and blit image tests with various image layouts. Refactor copy and blit tests generation.
Tests took into account only optimal layout cases. Added general and mixed ones.
Structure of all copy and blit tests was too flat. Lowered granularity of test groups.
New tests:
- dEQP-VK.api.copy_and_blit.image_to_image.all_formats.*optimal_optimal*
- dEQP-VK.api.copy_and_blit.image_to_image.all_formats.*optimal_general*
- dEQP-VK.api.copy_and_blit.image_to_image.all_formats.*general_optimal*
- dEQP-VK.api.copy_and_blit.image_to_image.all_formats.*general_general*
- dEQP-VK.api.copy_and_blit.blit_image.all_formats.*optimal_optimal*
- dEQP-VK.api.copy_and_blit.blit_image.all_formats.*optimal_general*
- dEQP-VK.api.copy_and_blit.blit_image.all_formats.*general_optimal*
- dEQP-VK.api.copy_and_blit.blit_image.all_formats.*general_general*
Affected tests:
- dEQP-VK.api.copy_and_blit.*
Components: Vulkan
Change-Id: I5724bb7c0a3ccb2e36319a20671761a9b16fe4ed
David Sodman [Tue, 6 Sep 2016 21:05:59 +0000 (14:05 -0700)]
Extend gl_FrontFacing tests
Update gl_FrontFacing tests to include more tests as well as to use the
vktDrawUtil utility class
Change-Id: If94fb552f5f9366c79ffa3fcac6f085611a23f65
David Sodman [Fri, 9 Sep 2016 02:58:35 +0000 (19:58 -0700)]
Add ability to generate images with the reference renderer
*Separate DrawContext into a DrawContext and DrawContextState to reflect
graphics API's are split between state and action parts
* Add abstract DrawContext class
Test: Test clipping and synchronization primitives
Change-Id: I9f3945c6c3de169325fadea7bf70a9d5d7bfd932
David Sodman [Thu, 1 Sep 2016 17:40:21 +0000 (10:40 -0700)]
Add Vulkan DrawContext utility class
This is the first in a series of changes to move the DrawContext class
for more general use.
Test: run clipping tests on Vulkan
Affects: dEQP-VK.clipping.*
Change-Id: Ia9b8953d25c10ec2a6c227bf300637dcd62ea898
Pyry Haulos [Thu, 9 Feb 2017 18:44:40 +0000 (10:44 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: I3d822f0aafe2cb7cfae6bd55e6d29303a7dad0cf
Marcin Kańtoch [Mon, 6 Feb 2017 09:25:56 +0000 (10:25 +0100)]
dEQP-VK.info.*image_format_properties2* VkImageUsageFlags fix
The usage flags loop iterator starts currently with 0, which is not
a valid image usage value. It is reported as an error by Validation
Layers.
The patch contains also a simple fix for iterating over valid sample
count flag bits.
Modified tests:
dEQP-VK.info.image_format_properties2*
dEQP-VK.info.sparse_image_format_properties2*
Components: Vulkan
VK-GL-CTS issue: 133
Change-Id: I0edbdbc389fa3bd9a71ca4d3b7777ede38a7b353
Pyry Haulos [Fri, 3 Feb 2017 21:25:48 +0000 (13:25 -0800)]
Android: Test that mandatory extensions are supported
Change-Id: Id0e44299f1d8441bf1e7ecc91d82d3b06400e7e6
Pyry Haulos [Tue, 17 Jan 2017 23:49:02 +0000 (15:49 -0800)]
Android: Test that no Vulkan layers are enumerated
Change-Id: I43dacf306b468485fc160f175160555b9cf1c86d
Pyry Haulos [Wed, 11 Jan 2017 23:02:19 +0000 (15:02 -0800)]
Android: Check KHX, GOOGLE, and ANDROID extensions
Change-Id: I6ee24e584666e1f2542adf35943a2973c9392ad9
Pyry Haulos [Thu, 9 Feb 2017 17:54:41 +0000 (09:54 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: Ia916f3edd0d85b78a7a109c0605908fd8c7793cb
Pyry Haulos [Thu, 9 Feb 2017 17:54:38 +0000 (09:54 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: I32aa09e131335c13262518708fd5970191aad77b
Dominik Witczak [Thu, 17 Nov 2016 12:10:19 +0000 (13:10 +0100)]
Fix memory management, image layout issues in uploadImageSparse()
Fixes an issue where ShaderRenderCaseInstance::uploadSparseImage()
would first configure sparse image bindings and then deallocate
the memory objects, prior to actually sampling the image.
Fixes an issue where the sparse image, after having been filled with
contents, would first be transitioned to SHADER_READ_ONLY_OPTIMAL
layout, and then used in a DS which was expecting it to be in
GENERLA layout.
Finally, the patch addresses a problem, where the function would not
correctly recognize the VK_SPARSE_IMAGE_FORMAT_SINGLE_MIPTAIL_BIT,
as reported by the running driver.
The change affects dEQP-VK.glsl.*sparse* tests
VK-GL-CTS issue: 156
Change-Id: Ie5717841fe0ef9c0672b5075380ff96bba9855b9
(cherry picked from commit
70fc0800efe725f4f91f4d03b09aa0e567dbb09c)
Slawomir Cygan [Tue, 10 Jan 2017 15:59:29 +0000 (16:59 +0100)]
Do not require unsupported sparse images in image_format_properties test
Affects tests: dEQP-VK.api.info.image_format_properties*
This change removes the requirement for supporting sparse residency images:
- with compressed format
- with non-color format
- with format of pixel size that is not power ot two (for example: RGB).
Additionally do not require 1D sparse residency images (not in spec),
and require 2D/3D residency images basing on the device capabilities.
Spec 28.1. Sparse Resource Features:
"A sparse image created using VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT
supports all non-compressed color formats with power-of-two element
size that non-sparse usage supports.
(...)
sparseResidencyImage2D: Support for creating 2D single-sampled VkImage
objects with VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT.
sparseResidencyImage3D: Support for creating 3D VkImage objects with
VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT.
"
Component: Vulkan
VK-GL-CTS Issue: 131
(cherry picked from commit
5534b44a15b530ece4b310e1dd935fb9b0cefeb6)
Change-Id: Ia2481fbcd12a32a6470af26df213a2f930c2e6db
Pyry Haulos [Wed, 8 Feb 2017 15:55:06 +0000 (07:55 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: Ib8da14734a8a60b9793b271eb675153af03375ce
Gerrit Code Review [Wed, 8 Feb 2017 15:53:46 +0000 (10:53 -0500)]
Merge "Merge vk-gl-cts/aosp-master into vk-gl-cts/master"
Iago Toral Quiroga [Wed, 1 Feb 2017 09:38:52 +0000 (10:38 +0100)]
Fix dEQP-VK.api.info.get_physical_device_properties2.properties
The test uses memcmp to compare structs that may include padding
bytes. Although the test initializes all bytes prior to calling any
Vulkan APIs, there is no guarantee that drivers won't write to the
padding bytes, for example if they write the properties to a local
variable and then memcpy into the result pointer, which is a valid
implementation.
This patch fixes the problem by reusing the offset table that we
already use in another test to obtain the offsets and sizes for all
struct fields and exclude any padding bytes during comparisons.
Affects:
dEQP-VK.api.info.get_physical_device_properties2.properties
VK-GL-CTS issue: 63
Components: Vulkan
Change-Id: I4417a95d41241523acd13adc739e739da9b0c2ed
Pyry Haulos [Mon, 6 Feb 2017 21:01:09 +0000 (13:01 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: I72b86a6a9762bcaaa149c4f533ef91487bb9bdbb
Pyry Haulos [Mon, 6 Feb 2017 21:01:07 +0000 (13:01 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: Ie39f778967a81af072e60194987d6e3978afb45e
Igor Ostrowski [Mon, 30 Jan 2017 13:08:45 +0000 (14:08 +0100)]
Fix XCB window dimensions setter
Make sure that dimension setter catched appropriate property notify event.
Components: Framework
VK-GL-CTS issue: 134
Change-Id: I4630175dffea57a54375fe6900df7dd3aa5823d4
Pyry Haulos [Mon, 6 Feb 2017 19:08:20 +0000 (11:08 -0800)]
Merge vk-gl-cts/aosp-master into vk-gl-cts/master
Components: Framework, AOSP
Change-Id: I792d9647eca05c0c6801b90dc0dfb7e0d0742daf
Pyry Haulos [Fri, 3 Feb 2017 22:05:00 +0000 (14:05 -0800)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/master
Change-Id: I330751b96e5102841161665fe82c8adb6ac0b382
Pyry Haulos [Wed, 1 Feb 2017 23:24:52 +0000 (15:24 -0800)]
Fix issues in Vulkan PointCoord test
* Fixed PointCoord calculation to follow spec.
* Made random point size generation code more robust. Existing code
resulted in rnd.getInt() being called with invalid range.
Changed: dEQP-VK.glsl.builtin_var.simple.pointcoord
Components: Vulkan
VK-GL-CTS issue: 68
Change-Id: I34f0c2c2ec5c8d759f22e81a1683c21572887c58
Mika Isojärvi [Wed, 18 Jan 2017 21:41:39 +0000 (13:41 -0800)]
Fix uint precision issue in pipeline barrier tests
Add missing highp qualifier for int types in fragment shaders.
Affected tests
dEQP-VK.memory.pipeline_barrier.host_write_uniform_buffer.*
dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.*
dEQP-VK.memory.pipeline_barrier.host_write_storage_buffer.*
dEQP-VK.memory.pipeline_barrier.host_write_storage_texel_buffer.*
dEQP-VK.memory.pipeline_barrier.transfer_dst_uniform_buffer.*
dEQP-VK.memory.pipeline_barrier.transfer_dst_uniform_texel_buffer.*
dEQP-VK.memory.pipeline_barrier.transfer_dst_storage_buffer.*
dEQP-VK.memory.pipeline_barrier.transfer_dst_storage_texel_buffer.*
dEQP-VK.memory.pipeline_barrier.all.*
dEQP-VK.memory.pipeline_barrier.all_device.*
VK-GL-CTS issue: 67
Change-Id: I9c78a1c19a06554dd86bf7dbb3c7bc3a96cb72dc
Pyry Haulos [Wed, 1 Feb 2017 22:46:11 +0000 (14:46 -0800)]
Update SPIR-V tools to ab03b87
This fixes SPIR-V tools build when git is configured to check out
windows-style line endings.
Generated SPIR-V binaries are not affected by this change.
VK-GL-CTS issue: 73
Change-Id: Ic1639a50a059211ad315a8b07f2279b50ed9a133
Pyry Haulos [Fri, 3 Feb 2017 21:25:48 +0000 (13:25 -0800)]
Android: Test that mandatory extensions are supported
Change-Id: Id0e44299f1d8441bf1e7ecc91d82d3b06400e7e6
Pyry Haulos [Tue, 17 Jan 2017 23:49:02 +0000 (15:49 -0800)]
Android: Test that no Vulkan layers are enumerated
Change-Id: I43dacf306b468485fc160f175160555b9cf1c86d
Pyry Haulos [Wed, 11 Jan 2017 23:02:19 +0000 (15:02 -0800)]
Android: Check KHX, GOOGLE, and ANDROID extensions
Change-Id: I6ee24e584666e1f2542adf35943a2973c9392ad9
Pyry Haulos [Fri, 27 Jan 2017 00:36:18 +0000 (16:36 -0800)]
Improve check_build_sanity.py
* All steps now respect --tmp-dir argument. This required adding
--build-dir and other args to mustpass scripts.
* --recipe command line argument allows running only a specific build
check recipe.
* --dump-recipes option allows printing out all recipes that are
supported in the current environment.
Components: Vulkan, Framework, AOSP
Change-Id: I6ba4f1369def14dc4ea6b398f367366549eecdc5
Pyry Haulos [Thu, 2 Feb 2017 19:20:07 +0000 (11:20 -0800)]
Auto-generate parts of Android.mk
This change moves LOCAL_SRC_FILES and LOCAL_C_INCLUDES from Android.mk
into AndroidGen.mk and adds a script to auto-generate AndroidGen.mk.
Components: AOSP
Change-Id: Ib51104e0bb5aeb297e1f6d4f1c9684fd040726c6
Pyry Haulos [Thu, 2 Feb 2017 19:21:28 +0000 (11:21 -0800)]
Simplify dethread build
dethread can be now built with simply adding all source files into the
project. This reduces complexity in build scripts.
Components: Framework
Change-Id: I18a342b9b42eb8d79145306ef7fd7c5897a2f92f
Arkadiusz Sarwa [Mon, 5 Dec 2016 09:04:32 +0000 (10:04 +0100)]
Add pipeline statistics queries test cases
New tests:
dEQP-VK.query_pool.statistics_query.*
Components: Vulkan
Vulkan-CTS issue: 524
Change-Id: I69d214a168150cb983da30fe8d24b0e6de15e003
Szilard Ledan [Fri, 18 Nov 2016 09:30:54 +0000 (10:30 +0100)]
Add ETC compressed format texture tests
Extended the 'updateTextureData' and 'updateTextureViewMipLevels' functions
in vktTextureTestUtil.cpp with format mapping of compressed formats.
New tests:
- dEQP-VK.texture.compressed.*
Affected tests:
- dEQP-VK.texture.*
Change-Id: I897e6523243acb7395a3660fee5797f6c0988bd4
Pyry Haulos [Thu, 2 Feb 2017 21:48:49 +0000 (13:48 -0800)]
Fix includes in vktApiGetMemoryCommitment.cpp
vktApiGetDeviceMemoryCommitment.cpp was including another implementation
(.cpp) file, while it should have been referencing headers.
Change-Id: I9b3b187682a0052fe62eebcc16bb25f902edc94b
Slawomir Cygan [Thu, 1 Dec 2016 18:05:49 +0000 (19:05 +0100)]
GL44-CTS.khr_debug: do not call missing functions and properly create texture
glCreateBuffers was introduced by DSA in GL45, however this test can run also
in GL44 mode. Do not call it.
Additionaly add glBindTexture call before glIsTexture, so texture is properly
created before check.
Changed tests:
GL44-CTS.khr_debug.*
Components: OpenGL
VK-GL-CTS Issue: 27
Change-Id: I8397bc10f64194cc7bce32f67260066b8101a3f6
Pyry Haulos [Tue, 17 Jan 2017 19:40:25 +0000 (11:40 -0800)]
Fix warning in getDeviceMemoryCommitment tests
Change-Id: I5697999b2d9d313b74a2d716abacc66fb5f19d8d
Treehugger Robot [Tue, 31 Jan 2017 01:45:31 +0000 (01:45 +0000)]
Merge "Update Android CTS Vulkan mustpass to match 1.0.2"
Pyry Haulos [Tue, 31 Jan 2017 00:02:32 +0000 (16:02 -0800)]
Update Android CTS Vulkan mustpass to match 1.0.2
This CL updates Android CTS mustpass for Vulkan to match Khronos Vulkan
CTS 1.0.2.0.
Change-Id: Ia2f82b5f6675c67940679eb98f59510f264d62bf
Michael Hadley [Wed, 14 Dec 2016 20:08:59 +0000 (20:08 +0000)]
Added gl_BoundingBox built-in type access tests
New tests:
- dEQP-GLES31.functional.debug.negative_coverage.callbacks.shader_directive.accessing_bounding_box_type
Change-Id: I8f47dfdfde631f36f6a515459867b59e3c210701
Michael Hadley [Thu, 1 Dec 2016 17:52:17 +0000 (17:52 +0000)]
Add SSBO block tests
New Tests:
- dEQP-GLES31.functional.debug.negative_coverage.callbacks.ssbo_block.ssbo_block.*
Change-Id: I60d52bc34d9211e93332dcc719535f1f5e4a0596
John Richardson [Wed, 23 Nov 2016 14:48:32 +0000 (14:48 +0000)]
Add tessellation shader stages to negative layout_binding tests
Tests groups added to:
- dEQP-GLES31.functional.layout_binding.negative.sampler.sampler2d.*.
- dEQP-GLES31.functional.layout_binding.negative.sampler.sampler3d.*.
- dEQP-GLES31.functional.layout_binding.negative.ubo.*.
- dEQP-GLES31.functional.layout_binding.negative.ssbo.*.
- dEQP-GLES31.functional.layout_binding.negative.image.image2d.*.
- dEQP-GLES31.functional.layout_binding.negative.image.image3d.*.
New tests (tess_control, tess_evalution):
- binding_neg
- binding_over_max
- binding_neg_array
- binding_over_max_array
Extended tests:
- binding_contradictory
- binding_contradictory_array
Change-Id: Ia6b66f1d5316e3bba376a8aea189074b60fbedb5
John Richardson [Wed, 9 Nov 2016 08:34:43 +0000 (08:34 +0000)]
Add new tessellation negative coverage tests
Test groups added to:
- dEQP-GLES31.functional.shaders.linkage.tessellation.varying.rules
- dEQP-GLES31.functional.shaders.linkage.tessellation.layout_declarations.rules (new)
- dEQP-GLES31.functional.shaders.linkage.tessellation.barriers.rules (new)
- dEQP-GLES31.functional.debug.negative_coverage.*.tessellation (new)
New tests:
- output_non_array
- invalid_patch_in_usage
- invalid_patch_out_usage
- invalid_per_patch_qualifier_usage
- output_block_non_array
- invalid_barrier_usage_within_control_flow
- invalid_barrier_usage_after_return
- primitive_mode_mismatch
- spacing_mode_mismatch
- vertex_order_mismatch
- vertex_count_mismatch
- single_tessellation_stage
- invalid_primitive_mode
- tessellation_not_active
- invalid_program_state
- get_programiv
- invalid_program_queries
- tessellation_control_invalid_vertex_count
Change-Id: I0c4f4b407bfe80e09546af51fdb2d184cf310757
Xin Li [Thu, 26 Jan 2017 18:55:24 +0000 (10:55 -0800)]
Merge nougat-mr1-cts-dev into master.
Xin Li [Thu, 26 Jan 2017 18:53:54 +0000 (10:53 -0800)]
Xin Li [Thu, 26 Jan 2017 18:28:31 +0000 (10:28 -0800)]
Merge commit '
2a9d42a651ef444f32f0a6e60711bb2c371d3fce' from
nougat-cts-mr1-dev to master.
Change-Id: I9ad6799aaae603a05c0cc65bcff60df8bff88a95
Alexander Galazin [Tue, 24 Jan 2017 18:55:24 +0000 (19:55 +0100)]
Use 'https' as default checkout protocol
If remote 'origin' doesn't exist,
fallback to 'https' to fetch external sources.
Components: Framework
VK-GL-CTS issue: 53
Change-Id: I80ee1ad9d526151ef5b9cc565015680681f2771f
Pyry Haulos [Fri, 20 Jan 2017 18:30:13 +0000 (10:30 -0800)]
Add eglChooseConfig() tests for EXT_pixel_format_float
These tests verify that eglChooseConfig() filters configs correctly
based on EGL_COLOR_COMPONENT_TYPE_EXT attribute.
Change-Id: Icaaffee69dd46a9044149c01c8fe8b7ec8928305
Pyry Haulos [Fri, 20 Jan 2017 19:04:46 +0000 (11:04 -0800)]
Add basic test for EGL_KHR_no_config_context
Change-Id: I14aa3f38ea8d2aaa224c13a992d41cf5ef546f6e
Pyry Haulos [Tue, 24 Jan 2017 17:07:51 +0000 (09:07 -0800)]
Merge aosp/upstream-vulkan-cts-1.0-dev into aosp/master
Change-Id: Ifee45dee9fe57a8386c468dfedfb822c329f2504
Pyry Haulos [Tue, 24 Jan 2017 00:32:35 +0000 (16:32 -0800)]
Merge vulkancts/vulkan-cts-1.0-dev into vulkancts/opengl-cts-dev
Change-Id: Iad6867155d0e94a63b4dfd259f17a811baab5520
Pyry Haulos [Tue, 24 Jan 2017 00:32:33 +0000 (16:32 -0800)]
Merge vulkancts/vulkan-cts-1.0.2 into vulkancts/vulkan-cts-1.0-dev
Change-Id: I930987be3bb947d4fe51d9b931ed882f04e45a19
Pyry Haulos [Tue, 24 Jan 2017 00:28:00 +0000 (16:28 -0800)]
Merge vulkancts/vulkan-cts-next-dev into vulkancts/vulkan-cts-1.0-dev
This merge introduces tests for 3 new extensions:
* VK_KHR_get_physical_device_properties2
* VK_KHR_shader_draw_parameters
* VK_KHR_maintenance1
Change-Id: I2190b1ee4f3600708abde820e678a830488093ab
Pyry Haulos [Tue, 24 Jan 2017 00:13:11 +0000 (16:13 -0800)]
Merge vulkancts/vulkan-cts-1.0-dev into vulkancts/vulkan-cts-next-dev
Change-Id: Ia827f021762fd1b9444fe8fac6a11b59780349cd
Tina Zhou [Mon, 23 Jan 2017 19:12:27 +0000 (19:12 +0000)]
Merge "x11: Call XInitThreads()" into nougat-cts-dev
am:
cbdbf95222
Change-Id: I2531e5a260f50c8bae1a756a61026a46ae253614
Chad Versace [Mon, 23 Jan 2017 19:12:25 +0000 (19:12 +0000)]
x11: Call XInitThreads()
am:
5d11c9d2c0
Change-Id: Ib89f9fbfaa7d0b3dcb590fc2ac20ff2c83e3fbad
Tina Zhou [Mon, 23 Jan 2017 19:12:12 +0000 (19:12 +0000)]
Merge "x11: Fix deadlock" into nougat-cts-dev
am:
34b869eeea
Change-Id: I5ffe988c3affcd3afeaf3c63b5011e42ef9a4ba1
Chad Versace [Mon, 23 Jan 2017 19:12:10 +0000 (19:12 +0000)]
x11: Fix deadlock
am:
5e863331b2
Change-Id: Ic938e269f89e59fc9ab8b43c97efcb49e0317180
Tina Zhou [Mon, 23 Jan 2017 19:11:49 +0000 (19:11 +0000)]
Merge "x11: Call XInitThreads()" into nougat-cts-dev
am:
cbdbf95222
Change-Id: I063e616e5eb47560c87e4e550cb41e29bddca05a
Chad Versace [Mon, 23 Jan 2017 19:11:47 +0000 (19:11 +0000)]
x11: Call XInitThreads()
am:
5d11c9d2c0
Change-Id: Ibdd37ad696a32e47d56e7138949cac34cb6245a8
Tina Zhou [Mon, 23 Jan 2017 19:11:34 +0000 (19:11 +0000)]
Merge "x11: Fix deadlock" into nougat-cts-dev
am:
34b869eeea
Change-Id: I7af8485bb0a56711f3dfe09bd16bf26bc7b5588a
Chad Versace [Mon, 23 Jan 2017 19:11:32 +0000 (19:11 +0000)]
x11: Fix deadlock
am:
5e863331b2
Change-Id: I1de362ce859395f3c7c932b1d6ad652925516dda
Tina Zhou [Mon, 23 Jan 2017 19:09:19 +0000 (19:09 +0000)]
Merge "x11: Call XInitThreads()" into nougat-cts-dev
Tina Zhou [Mon, 23 Jan 2017 19:06:21 +0000 (19:06 +0000)]
Merge "x11: Fix deadlock" into nougat-cts-dev
Alexander Galazin [Mon, 23 Jan 2017 00:51:34 +0000 (01:51 +0100)]
Merge vulkancts/opengl-cts-es-3.2.2 into vulkancts/opengl-cts-dev
Change-Id: Idbcb8437a3598c158d3e4f7d57000b6b668dcf05
Alexander Galazin [Fri, 20 Jan 2017 09:00:27 +0000 (10:00 +0100)]
Improve submission verification scripts
Do not report warnings if git logs match exactly the release tag commit
Components: Framework
Change-Id: I9833026c5924bd22adfce8d26de2314a52fd88b9
(cherry picked from commit
244a26241b3887ccdca2eccbd45b914d3b5e6883)
Kalle Raita [Sat, 21 Jan 2017 00:35:05 +0000 (00:35 +0000)]
CP: Remove two read-backs from copy image tests
am:
263e135474 -s ours
Change-Id: I3145b66433218cbd2d7a13452d2626cda66f001e
Kalle Raita [Sat, 21 Jan 2017 00:35:03 +0000 (00:35 +0000)]
CP: Non-compressed copy image target size (64,64,8
am:
7aff1a044f
Change-Id: I263ee368df721429983ace2e80a4ddeb17c2e2c3
Kalle Raita [Sat, 21 Jan 2017 00:23:35 +0000 (00:23 +0000)]
CP: Remove two read-backs from copy image tests
am:
263e135474
Change-Id: I9926edda54ffa5bdb0b5b7f9aeac08aab58237e8
Kalle Raita [Sat, 21 Jan 2017 00:23:33 +0000 (00:23 +0000)]
CP: Non-compressed copy image target size (64,64,8
am:
7aff1a044f
Change-Id: I55e1c77eb6558a7a396707cf541d529394be34b7