platform/upstream/gst-plugins-base.git
8 years agoplugins-bad: Fix example pipelines
Vineeth TM [Mon, 14 Dec 2015 02:09:46 +0000 (11:09 +0900)]
plugins-bad: Fix example pipelines

rename gst-launch --> gst-launch-1.0
replace old elements with new elements(ffmpegcolorspace -> videoconvert, ffenc_** -> avenc_**)
fix caps in examples

https://bugzilla.gnome.org/show_bug.cgi?id=759432

8 years agoaudiomixer: register function name for debugging just once
Tim-Philipp Müller [Tue, 24 Nov 2015 00:20:36 +0000 (00:20 +0000)]
audiomixer: register function name for debugging just once

Not every time aggregate is called...

9 years agoaudioaggregator: Improve log messages
Olivier Crête [Tue, 3 Nov 2015 00:40:28 +0000 (19:40 -0500)]
audioaggregator: Improve log messages

Make the level of log messages saner and improve some.

9 years agoliveadder: Make latency property be a uint in millisecs
Olivier Crête [Mon, 26 Oct 2015 23:58:04 +0000 (19:58 -0400)]
liveadder: Make latency property be a uint in millisecs

This restores roughly the same behaviour as the old liveadder element.
Except that the latency now also includes the output-buffer-duration.

https://bugzilla.gnome.org/show_bug.cgi?id=757050

9 years agoliveadder: latency property is an uint64 in audiomixer
Tim-Philipp Müller [Mon, 12 Oct 2015 08:36:29 +0000 (09:36 +0100)]
liveadder: latency property is an uint64 in audiomixer

9 years agoliveadder: Remove plugin, replace by compat subclass of audiomixer
Olivier Crête [Sun, 4 Oct 2015 23:55:36 +0000 (00:55 +0100)]
liveadder: Remove plugin, replace by compat subclass of audiomixer

New subclass with a similar behaviour as the old liveadder, but
a slightly different API as the latency is in nanoseconds, not
milliseconds. Also, the new liveadder has a effective latency that
is latency + output-buffer-duration. In practice, just setting a non-zero
latency with the new audiomixer gives you the right behavior in 99% of the
cases.

9 years agoaudioaggregator: Fix build error
Vineeth TM [Tue, 6 Oct 2015 23:48:15 +0000 (08:48 +0900)]
audioaggregator: Fix build error

Build error due to wrong argument type in debug message
aagg->priv->offset and next_offset are of type int64, but uint64
formatter is being used in logs. Changing all those to int64

https://bugzilla.gnome.org/show_bug.cgi?id=756065

9 years agoaudioaggregator: Select the initial offset based on the start segment position
Sebastian Dröge [Wed, 30 Sep 2015 17:01:21 +0000 (19:01 +0200)]
audioaggregator: Select the initial offset based on the start segment position

instead of always using 0. Otherwise we might output a lot of silence in the
beginning instead of outputting from the relevant position.

https://bugzilla.gnome.org/show_bug.cgi?id=755623

9 years agoaudiointerleave: typecast bit-mask to guint64 to fix segmentation fault
Vineeth TM [Wed, 30 Sep 2015 04:13:19 +0000 (13:13 +0900)]
audiointerleave: typecast bit-mask to guint64 to fix segmentation fault

While creating caps in audiointerleave tests, bitmask is being set as 0x9
This is resulting in segmentation fault. Fix the same by typecasting to guint64

https://bugzilla.gnome.org/show_bug.cgi?id=755840

9 years agoaudiomixer: fix deadlock when G_DISABLE_ASSERT is not defined
Tim-Philipp Müller [Sat, 26 Sep 2015 09:21:41 +0000 (10:21 +0100)]
audiomixer: fix deadlock when G_DISABLE_ASSERT is not defined

This makes the audiomixer unit test time out in master.
Broke with 587e7c4

9 years agoaudioaggregator: Stop using deprecated gst_segment_to_position()
Sebastian Dröge [Fri, 25 Sep 2015 22:17:55 +0000 (00:17 +0200)]
audioaggregator: Stop using deprecated gst_segment_to_position()

9 years agoaudioaggregator: Only skip the remaining part of a GAP buffer
Sebastian Dröge [Fri, 18 Sep 2015 16:00:05 +0000 (18:00 +0200)]
audioaggregator: Only skip the remaining part of a GAP buffer

We might've queued up a GAP buffer that is only partially inside the current
output buffer (i.e. we received it too late!). In that case we should only
skip the part of the GAP buffer that is inside the current output buffer, not
also the remaining part. Otherwise we forward this pad too far into the future
and break synchronization.

9 years agoDon't throw compiler warnings with G_DISABLE_ASSERT
Jan Schmidt [Thu, 17 Sep 2015 14:20:13 +0000 (00:20 +1000)]
Don't throw compiler warnings with G_DISABLE_ASSERT

Disable code that warns about unused variables when G_DISABLE_ASSERT
is defined, as it is in tarballs and pre-releases.

9 years agoaudioaggregator: Fix mixup of running times and segment positions
Sebastian Dröge [Fri, 11 Sep 2015 19:37:08 +0000 (21:37 +0200)]
audioaggregator: Fix mixup of running times and segment positions

We have to queue buffers based on their running time, not based on
the segment position.

Also return running time from GstAggregator::get_next_time() instead of
a segment position, as required by the API.

Also only update the segment position after we pushed a buffer, otherwise
we're going to push down a segment event with the next position already.

https://bugzilla.gnome.org/show_bug.cgi?id=753196

9 years agoaudioaggregator: Use stream time in the position query instead of segment position
Sebastian Dröge [Fri, 11 Sep 2015 14:56:40 +0000 (16:56 +0200)]
audioaggregator: Use stream time in the position query instead of segment position

https://bugzilla.gnome.org/show_bug.cgi?id=753196

9 years agotests: audiomixer: remove duplicated word in comment
hoonhee.lee [Fri, 21 Aug 2015 07:44:43 +0000 (16:44 +0900)]
tests: audiomixer: remove duplicated word in comment

https://bugzilla.gnome.org/show_bug.cgi?id=753915

9 years agotests: Add audiointerleave test to show that queuing works
Olivier Crête [Thu, 2 Jul 2015 22:37:28 +0000 (18:37 -0400)]
tests: Add audiointerleave test to show that queuing works

This tests fails without the queuing patch because incoming buffers are
not delivered before they are needed.

https://bugzilla.gnome.org/show_bug.cgi?id=745768

9 years agoaudiointerleave: Avoid caps processing if not yet negotiated
Olivier Crête [Thu, 2 Jul 2015 22:33:43 +0000 (18:33 -0400)]
audiointerleave: Avoid caps processing if not yet negotiated

https://bugzilla.gnome.org/show_bug.cgi?id=745768

9 years agoaudioaggregator: On timeout, resync pads with not enough data
Olivier Crête [Mon, 16 Mar 2015 21:06:46 +0000 (17:06 -0400)]
audioaggregator: On timeout, resync pads with not enough data

https://bugzilla.gnome.org/show_bug.cgi?id=745768

9 years agoaggregator: Queue "latency" buffers at each sink pad.
Olivier Crête [Sat, 7 Mar 2015 00:50:08 +0000 (19:50 -0500)]
aggregator: Queue "latency" buffers at each sink pad.

In the case where you have a source giving the GstAggregator smaller
buffers than it uses, when it reaches a timeout, it will consume the
first buffer, then try to read another buffer for the pad. If the
previous element is not fast enough, it may get the next buffer even
though it may be queued just before. To prevent that race, the easiest
solution is to move the queue inside the GstAggregatorPad itself. It
also means that there is no need for strange code cause by increasing
the min latency without increasing the max latency proportionally.

This also means queuing the synchronized events and possibly acting
on them on the src task.

https://bugzilla.gnome.org/show_bug.cgi?id=745768

9 years agoaudioaggregator: Register function name
Olivier Crête [Wed, 22 Jul 2015 23:27:19 +0000 (19:27 -0400)]
audioaggregator: Register function name

Otherwise, it sometimes segfaults with debugging enabled

9 years agoaudioaggregator: Use 1.0 style buffer allocation
Olivier Crête [Wed, 22 Jul 2015 23:26:42 +0000 (19:26 -0400)]
audioaggregator: Use 1.0 style buffer allocation

9 years agoaudioaggregator: Sync pad values before aggregating
Nirbheek Chauhan [Tue, 19 May 2015 10:38:08 +0000 (16:08 +0530)]
audioaggregator: Sync pad values before aggregating

We need to sync the pad values before taking the aggregator and pad locks
otherwise the element will just deadlock if there's any property changes
scheduled using GstController since that involves taking the aggregator and pad
locks.

Also add a test for this.

https://bugzilla.gnome.org/show_bug.cgi?id=749574

9 years agoaudioaggregator: Read output buffer duration with lock held
Olivier Crête [Wed, 22 Jul 2015 00:52:23 +0000 (20:52 -0400)]
audioaggregator: Read output buffer duration with lock held

9 years agoaudiomixer: fix misleading documentation copied from adder
Tim-Philipp Müller [Tue, 9 Jun 2015 13:37:36 +0000 (14:37 +0100)]
audiomixer: fix misleading documentation copied from adder

9 years agoRelease 1.5.1
Sebastian Dröge [Sun, 7 Jun 2015 08:55:35 +0000 (10:55 +0200)]
Release 1.5.1

9 years agotests: audiointerleave: test not setting positions
Olivier Crête [Tue, 2 Jun 2015 19:45:13 +0000 (15:45 -0400)]
tests: audiointerleave: test not setting positions

Disable "channel-positions-from-input", but without actually giving
a position table, so every position should be NONE

9 years agotests: Fix indentation in audiointerleave test
Olivier Crête [Tue, 2 Jun 2015 19:44:57 +0000 (15:44 -0400)]
tests: Fix indentation in audiointerleave test

9 years agoaudiointerleave: Always have "channels" be the actual pad count
Olivier Crête [Mon, 1 Jun 2015 23:43:20 +0000 (19:43 -0400)]
audiointerleave: Always have "channels" be the actual pad count

Don't force it anywhere

https://bugzilla.gnome.org/show_bug.cgi?id=750252

9 years agoaudiointerleave: Use the channel count from the set caps
Olivier Crête [Mon, 1 Jun 2015 23:42:49 +0000 (19:42 -0400)]
audiointerleave: Use the channel count from the set caps

This is the same number that was used to allocate the buffer

9 years agoRevert "doc: Workaround gtkdoc issue"
Stefan Sauer [Mon, 18 May 2015 18:16:32 +0000 (20:16 +0200)]
Revert "doc: Workaround gtkdoc issue"

This reverts commit ff6c736fe08e01f4320c4b02e811a0b57cf97cc1.

This is fixed by the gtk-doc 1.23 release.

<para> cannot contain <refsect2>:
http://www.docbook.org/tdg/en/html/para.html
http://www.docbook.org/tdg/en/html/refsect2.html

9 years agodoc: Workaround gtkdoc issue
Nicolas Dufresne [Sun, 17 May 2015 03:38:14 +0000 (23:38 -0400)]
doc: Workaround gtkdoc issue

With gtkdoc 1.22, the XML generator fails when a itemizedlist is
followed by a refsect2. Workaround the issue by wrapping the
refsect2 into para.

9 years agotests: fix type mismatch in varargs passing
Vincent Penquerc'h [Thu, 9 Apr 2015 15:20:44 +0000 (16:20 +0100)]
tests: fix type mismatch in varargs passing

A bitmask is 64 bits, but integer immediates are passed as int
in varargs, which happen to be 32 bit with high probability.

This triggered a valgrind jump-relies-on-uninitalized-value
report well away from the site, since it doesn't trigger on
stack accesses, and there must have been enough zeroes to stop
g_object_set at the right place.

9 years agoaudiomixer: Allow downstream caps with a non-default channel-mask
Olivier Crête [Thu, 2 Apr 2015 00:32:41 +0000 (20:32 -0400)]
audiomixer: Allow downstream caps with a non-default channel-mask

Instead of failing, take the downstream channel mask if the channel
count is 1.

9 years agoaudioaggregator: check sink caps are valid
Luis de Bethencourt [Tue, 24 Mar 2015 16:18:22 +0000 (16:18 +0000)]
audioaggregator: check sink caps are valid

9 years agoRevert "audioaggregator: check sink caps are valid"
Luis de Bethencourt [Tue, 24 Mar 2015 16:17:00 +0000 (16:17 +0000)]
Revert "audioaggregator: check sink caps are valid"

This reverts commit 6d4d0d1cdf7c7531fbf72ce39e1eab1260d20550.

Never put code with side effects into an assertion, it can be compiled out

9 years agoaudioaggregator: check sink caps are valid
Luis de Bethencourt [Tue, 24 Mar 2015 15:45:25 +0000 (15:45 +0000)]
audioaggregator: check sink caps are valid

CID #1291622

9 years agoaudiointerleave: Add unit tests
Olivier Crête [Fri, 14 Nov 2014 01:39:11 +0000 (20:39 -0500)]
audiointerleave: Add unit tests

Almost a copy of the "interleave" unit tests, improved to support
the thread on the src pad on GstAggregator.

https://bugzilla.gnome.org/show_bug.cgi?id=740236

9 years agoaudiointerleave: Set src caps in aggregate
Olivier Crête [Fri, 6 Mar 2015 18:49:48 +0000 (13:49 -0500)]
audiointerleave: Set src caps in aggregate

This prevents races between the setcaps of the sink pads

https://bugzilla.gnome.org/show_bug.cgi?id=740236

9 years agoaudiointerleave: Add interleave element based on audioaggregator
Olivier Crête [Thu, 13 Nov 2014 20:40:15 +0000 (15:40 -0500)]
audiointerleave: Add interleave element based on audioaggregator

https://bugzilla.gnome.org/show_bug.cgi?id=740236

9 years agoaudioaggregator: Print a message when a buffer is late
Olivier Crête [Fri, 6 Mar 2015 21:51:12 +0000 (16:51 -0500)]
audioaggregator: Print a message when a buffer is late

https://bugzilla.gnome.org/show_bug.cgi?id=740236

9 years agoaudioaggregator: Don't re-send the caps if they did not change
Olivier Crête [Sat, 15 Nov 2014 22:54:51 +0000 (17:54 -0500)]
audioaggregator: Don't re-send the caps if they did not change

https://bugzilla.gnome.org/show_bug.cgi?id=740236

9 years agoaudioaggregator: Split base class from audiomixer
Olivier Crête [Thu, 6 Nov 2014 22:15:17 +0000 (17:15 -0500)]
audioaggregator: Split base class from audiomixer

Also:
-  Don't modify size on early buffer
   The size is the size of the buffer, not of remaining part.
- Use the input caps when manipulating the input buffer
   Also store in in the sink pad
- Reply to the position query in bytes too
- Put GAP flag on output if all inputs are GAP data
- Only try to clip buffer if the incoming segment is in time or samples
- Use incoming segment with incoming timestamp
   Handle non-time segments and NONE timestamps
- Don't reset the position when pushing out new caps
- Make a number of member variables private
- Correctly handle case where no pad has a buffer
  If none of the pads have buffers that can be handled, don't claim to be EOS.
- Ensure proper locking
- Only support time segments

https://bugzilla.gnome.org/show_bug.cgi?id=740236

9 years agoaudiomixer: Release pad object lock before dropping buffer
Olivier Crête [Sun, 8 Mar 2015 03:08:40 +0000 (22:08 -0500)]
audiomixer: Release pad object lock before dropping buffer

Otherwise, the locking order is violated and deadlocks happen.

https://bugzilla.gnome.org/show_bug.cgi?id=745768

9 years agoaudiomixer: Only ignore pads with no buffers on timeout
Olivier Crête [Sat, 7 Mar 2015 01:22:13 +0000 (20:22 -0500)]
audiomixer: Only ignore pads with no buffers on timeout

When the timeout is reached, only ignore pads with no buffers, iterate
over the other pads until all buffers have been read. This is important
in the cases where the input buffers are smaller than the output buffer.

https://bugzilla.gnome.org/show_bug.cgi?id=745768

9 years agoaudiomixer: Only advance by the buffer size when a buffer is late
Olivier Crête [Sat, 7 Mar 2015 01:25:03 +0000 (20:25 -0500)]
audiomixer: Only advance by the buffer size when a buffer is late

https://bugzilla.gnome.org/show_bug.cgi?id=745768

9 years agoaudiomixer: Fix discont detection and buffer alignment code
Sebastian Dröge [Thu, 12 Mar 2015 17:11:31 +0000 (17:11 +0000)]
audiomixer: Fix discont detection and buffer alignment code

Actually accumulate the sample counter to check the accumulated error
between actual timestamps and expected ones instead of just resetting
the error back to 0 with every new buffer.

Also don't reset discont_time whenever we don't resync. The whole point of
discont_time is to remember when we first detected a discont until we actually
act on it a bit later if the discont stayed around for discont_wait time.

https://bugzilla.gnome.org/show_bug.cgi?id=746032

9 years agoaudiomixer: Add locking to fill_buffer and fix mix_buffer
Nirbheek Chauhan [Wed, 11 Mar 2015 20:19:58 +0000 (01:49 +0530)]
audiomixer: Add locking to fill_buffer and fix mix_buffer

The audiomixer pad struct fields may be changed from other threads

9 years agoaudiomixer: Mark a discont when we receive a new segment event
Nirbheek Chauhan [Wed, 11 Mar 2015 20:26:44 +0000 (01:56 +0530)]
audiomixer: Mark a discont when we receive a new segment event

This allows us to handle new segment events correctly; either by dropping
buffers or inserting silence; for example if the offset is changed on an srcpad
connected to audiomixer.

9 years agoRevert "audiomixer: Latency is twice the output buffer duration, not only once"
Sebastian Dröge [Wed, 4 Mar 2015 12:16:03 +0000 (13:16 +0100)]
Revert "audiomixer: Latency is twice the output buffer duration, not only once"

This reverts commit d387cf67df91b59540f32ee17b4c02f747969add.

The analysis was wrong: The first 20ms of latency are introduced by the source
already and put into the latency query, making it only necessary to cover the
additional 20ms of audiomixer inside audiomixer.

9 years agoaudiomixer: Latency is twice the output buffer duration, not only once
Sebastian Dröge [Tue, 3 Mar 2015 19:03:55 +0000 (20:03 +0100)]
audiomixer: Latency is twice the output buffer duration, not only once

Let's assume a source that outputs outputs 20ms buffers, and audiomixer having
a 20ms output buffer duration. However timestamps don't align perfectly, the
source buffers are offsetted by 5ms.

For our ASCII art picture, each letter is 5ms, each pipe is the start of a
20ms buffer. So what happens is the following:

0   20  40  60
OOOOOOOOOOOOOOOO
|   |   |   |

  5   25  45  65
  IIIIIIIIIIIIIIII
  |   |   |   |

This means that the second output buffer (20 to 40ms) only gets its last 5ms
at time 45ms (the timestamp of the next buffer is the time when the buffer
arrives). But if we only have a latency of 20ms, we would wait until 40ms
to generate the output buffer and miss the last 5ms of the input buffer.

9 years agoaudiomixer: use new gst_aggregator_pad_drop_buffer()
Tim-Philipp Müller [Fri, 13 Feb 2015 16:06:34 +0000 (16:06 +0000)]
audiomixer: use new gst_aggregator_pad_drop_buffer()

9 years agotests: remove GST_DISABLE_PARSE guards from two tests that don't require it
Tim-Philipp Müller [Thu, 12 Feb 2015 15:48:07 +0000 (15:48 +0000)]
tests: remove GST_DISABLE_PARSE guards from two tests that don't require it

9 years agoaudiomixer: calculate stream_time used to sync pad values correctly
Tim-Philipp Müller [Thu, 12 Feb 2015 11:26:44 +0000 (11:26 +0000)]
audiomixer: calculate stream_time used to sync pad values correctly

Use pad (input) segment to calculate the stream time from the
input timestamp, not the aggregator (output) segment.

9 years agoImprove and fix LATENCY query handling
Sebastian Dröge [Wed, 11 Feb 2015 13:16:21 +0000 (14:16 +0100)]
Improve and fix LATENCY query handling

This now follows the design docs everywhere, especially the maximum latency
handling.

https://bugzilla.gnome.org/show_bug.cgi?id=744106

9 years agoaudiomixer: remove now-unused base_time field in object structure
Tim-Philipp Müller [Thu, 5 Feb 2015 15:57:59 +0000 (15:57 +0000)]
audiomixer: remove now-unused base_time field in object structure

9 years agotests: audiomixer: add unit test for proper segment.base handling
Tim-Philipp Müller [Thu, 5 Feb 2015 15:23:04 +0000 (15:23 +0000)]
tests: audiomixer: add unit test for proper segment.base handling

As adjusted by gst_pad_set_offset(), or when doing segment seeks
or looping for example. See previous audiomixer commit.

9 years agoaudiomixer: Remove weird and wrong segment handling
Sebastian Dröge [Thu, 5 Feb 2015 15:02:54 +0000 (16:02 +0100)]
audiomixer: Remove weird and wrong segment handling

There's no reason why audiomixer should override the segment
base of upstream with whatever value it got from a SEEK event,
or even worse... with 0 if there was no SEEK event yet. This
broke synchronization if upstream provided a segment base other
than 0, e.g. when using pad offsets.
Also that this code did things conditional on the element's state
should've been a big warning already that something is just wrong.
If this breaks anything else now, let's fix it properly :)

Also don't do fancy segment position trickery when receiving a
segment event. It's just not correct.

9 years agoaggregator: Make the PAD_LOCK private
Thibault Saunier [Mon, 26 Jan 2015 10:29:08 +0000 (11:29 +0100)]
aggregator: Make the PAD_LOCK private

Instead of using the GST_OBJECT_LOCK we should have
a dedicated mutex for the pad as it is also associated
with the mutex on the EVENT_MUTEX on which we wait
in the _chain function of the pad.

The GstAggregatorPad.segment is still protected with the
GST_OBJECT_LOCK.

Remove the gst_aggregator_pad_peak_unlocked method as it does not make
sense anymore with a private lock.

https://bugzilla.gnome.org/show_bug.cgi?id=742684

9 years agoaggregator: Hide GstAggregatorPad buffer and EOS fileds
Thibault Saunier [Mon, 26 Jan 2015 10:25:54 +0000 (11:25 +0100)]
aggregator: Hide GstAggregatorPad buffer and EOS fileds

And add a getter for the EOS.

The user should always use the various getters to access
those fields

https://bugzilla.gnome.org/show_bug.cgi?id=742684

9 years agoaudiomixer: Make flush start/stop test non-racy
Olivier Crête [Thu, 22 Jan 2015 00:09:13 +0000 (19:09 -0500)]
audiomixer: Make flush start/stop test non-racy

The flush stop could have happened between the source trying
to push the segment event and the buffer, this would cause a warning.
Prevent that by taking the source's stream lock while flushing.

https://bugzilla.gnome.org/show_bug.cgi?id=742684

9 years agoaudiomixer: Replace racy timeout based tested with drain query
Olivier Crête [Thu, 22 Jan 2015 22:41:24 +0000 (17:41 -0500)]
audiomixer: Replace racy timeout based tested with drain query

Using the drain query, we can be certain that the buffer has done going
through the aggregator by taking the stream locks.

https://bugzilla.gnome.org/show_bug.cgi?id=742684

9 years agoaudiomixer: Avoid race in caps negotiation
Olivier Crête [Thu, 22 Jan 2015 00:32:34 +0000 (19:32 -0500)]
audiomixer: Avoid race in caps negotiation

With the current audiomixer, the input caps need to be the same,
otherwise there is an unavoidable race in the caps negotiation. So
enforce that using capsfilters

https://bugzilla.gnome.org/show_bug.cgi?id=742684

9 years agoaudiomixer: Clear GstAudioInfo the the caps
Olivier Crête [Wed, 21 Jan 2015 23:47:40 +0000 (18:47 -0500)]
audiomixer: Clear GstAudioInfo the the caps

When clearing the caps, also clear the matching GstAudioInfo

https://bugzilla.gnome.org/show_bug.cgi?id=742684

9 years agoaudiomixer: Don't reset caps on flush
Olivier Crête [Wed, 21 Jan 2015 23:39:24 +0000 (18:39 -0500)]
audiomixer: Don't reset caps on flush

A flush event doesn't invalidate the previous caps event.

https://bugzilla.gnome.org/show_bug.cgi?id=742684

9 years agoaggregator: Replace event lock with pad's object lock
Olivier Crête [Wed, 14 Jan 2015 19:35:15 +0000 (14:35 -0500)]
aggregator: Replace event lock with pad's object lock

Reduce the number of locks simplify code, what is protects
is exposed, but the lock was not.

Also means adding an _unlocked version of gst_aggregator_pad_steal_buffer().

https://bugzilla.gnome.org/show_bug.cgi?id=742684

9 years agoaudiomixer: update for aggregator start/stop vfunc change
Tim-Philipp Müller [Tue, 30 Dec 2014 18:01:34 +0000 (18:01 +0000)]
audiomixer: update for aggregator start/stop vfunc change

9 years agoaudiomixer: fix output-block-size property description
Tim-Philipp Müller [Tue, 30 Dec 2014 15:29:36 +0000 (15:29 +0000)]
audiomixer: fix output-block-size property description

9 years agoaudiomixer: Document the pad properties
Nirbheek Chauhan [Sat, 27 Dec 2014 10:19:39 +0000 (15:49 +0530)]
audiomixer: Document the pad properties

9 years agoaudiomixer: If getting a timeout before having caps, just advance our position
Sebastian Dröge [Tue, 23 Dec 2014 11:24:48 +0000 (12:24 +0100)]
audiomixer: If getting a timeout before having caps, just advance our position

This can happen if this is a live pipeline and no source produced any buffer
and sent no caps until the an output buffer should've been produced according
to the latency.

9 years agoaudiomixer: Make sure to release the current buffer in reset()
Sebastian Dröge [Tue, 23 Dec 2014 11:15:50 +0000 (12:15 +0100)]
audiomixer: Make sure to release the current buffer in reset()

If we didn't output the last one in aggregate because we were shutting down
earlier we might otherwise leak it.

9 years agoaudiomixer: Change blocksize property to output-buffer-duration in time format
Sebastian Dröge [Tue, 23 Dec 2014 10:45:50 +0000 (11:45 +0100)]
audiomixer: Change blocksize property to output-buffer-duration in time format

This makes the interface of audiomixer independent of the actual caps.

9 years agoaudiomixer: Use the src query implementation of aggregator as the default case
Sebastian Dröge [Mon, 22 Dec 2014 21:11:13 +0000 (22:11 +0100)]
audiomixer: Use the src query implementation of aggregator as the default case

9 years agoaudiomixer: fix build flag order
Stefan Sauer [Sun, 21 Dec 2014 12:47:25 +0000 (07:47 -0500)]
audiomixer: fix build flag order

Have the libraries/inlcudes from plugins-bad first to avoid picking up the installed version.
Fixes the build when the local api changed.

9 years agoaudiomixer: Track discont-time per pad instead of globally
Sebastian Dröge [Fri, 19 Dec 2014 12:04:58 +0000 (13:04 +0100)]
audiomixer: Track discont-time per pad instead of globally

We do discont handling per pad, not per element!

9 years agoaudiomixer: We're only EOS if all our pads are actually EOS
Sebastian Dröge [Thu, 18 Dec 2014 22:33:58 +0000 (23:33 +0100)]
audiomixer: We're only EOS if all our pads are actually EOS

Having a buffer or not on the pad is irrelevant.

9 years agoaudiomixer: The pad's size is always supposed to be the whole buffer size
Sebastian Dröge [Thu, 18 Dec 2014 21:42:14 +0000 (22:42 +0100)]
audiomixer: The pad's size is always supposed to be the whole buffer size

And the offset the offset into that buffer. Changing the size will
cause all kinds of assumptions to fail and cause crashes.

9 years agoaggregator: Add function to allow subclasses to set their own latency
Sebastian Dröge [Wed, 17 Dec 2014 18:51:32 +0000 (19:51 +0100)]
aggregator: Add function to allow subclasses to set their own latency

For audiomixer this is one blocksize, for videoaggregator this should
be the duration of one output frame.

9 years agoaudiomixer: Make sure to not have pads being behind the current offset
Sebastian Dröge [Wed, 17 Dec 2014 18:37:22 +0000 (19:37 +0100)]
audiomixer: Make sure to not have pads being behind the current offset

We would break sync between the different streams then.

9 years agoaggregator: Add a timeout parameter to ::aggregate()
Sebastian Dröge [Wed, 17 Dec 2014 16:54:09 +0000 (17:54 +0100)]
aggregator: Add a timeout parameter to ::aggregate()

When this is TRUE, we really have to produce output. This happens
in live mixing mode when we have to output something for the current
time, no matter if we have enough input or not.

9 years agoaudiomixer: Add queues after the (live) sources in the unit test
Sebastian Dröge [Wed, 17 Dec 2014 17:20:15 +0000 (18:20 +0100)]
audiomixer: Add queues after the (live) sources in the unit test

9 years agoaudiomixer: Implement get_next_time()
Sebastian Dröge [Tue, 16 Dec 2014 16:37:12 +0000 (17:37 +0100)]
audiomixer: Implement get_next_time()

9 years agoaudiomixer: Do not try to resize a buffer to a negative size on EOS
Thibault Saunier [Thu, 27 Nov 2014 15:43:39 +0000 (16:43 +0100)]
audiomixer: Do not try to resize a buffer to a negative size on EOS

10 years agotests: fix audiomixer test on big endian systems
Tim-Philipp Müller [Sat, 25 Oct 2014 17:50:42 +0000 (18:50 +0100)]
tests: fix audiomixer test on big endian systems

10 years agoaudiomixer: critical error for blocksize, timeout min/max values
Vineeth T M [Mon, 20 Oct 2014 12:55:08 +0000 (18:25 +0530)]
audiomixer: critical error for blocksize, timeout min/max values

Audiomixer blocksize, cant be 0, hence adjusting the minimum value to 1
timeout value of aggregator is defined with MAX of MAXINT64,
but it cannot cross G_MAXLONG * GST_SECOND - 1
Hence changed the max value of the same

https://bugzilla.gnome.org/show_bug.cgi?id=738845

10 years agotest: use G_GSIZE_FORMAT in audiomixer test
Aurélien Zanelli [Thu, 9 Oct 2014 12:51:56 +0000 (14:51 +0200)]
test: use G_GSIZE_FORMAT in audiomixer test

https://bugzilla.gnome.org/show_bug.cgi?id=738227

10 years agoaggregator: add latency query handling
Matthew Waters [Mon, 6 Oct 2014 10:46:24 +0000 (21:46 +1100)]
aggregator: add latency query handling

10 years agoaudiomixer: Handle seek event in READY state
Thibault Saunier [Mon, 6 Oct 2014 11:09:00 +0000 (13:09 +0200)]
audiomixer: Handle seek event in READY state

10 years agoaudiomixer: Set the sinkpad segments basetime after seeking
Thibault Saunier [Mon, 21 Jul 2014 09:07:19 +0000 (11:07 +0200)]
audiomixer: Set the sinkpad segments basetime after seeking

Otherwise stream offset and running time comparison will not be
correct, leading to segfaults after seeks

10 years agoaudiomixer: Port to GstAggregator
Thibault Saunier [Wed, 28 May 2014 14:29:37 +0000 (16:29 +0200)]
audiomixer: Port to GstAggregator

https://bugzilla.gnome.org/show_bug.cgi?id=737183

Co-Authored by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>

10 years agoRelease 1.3.1
Sebastian Dröge [Sat, 3 May 2014 16:16:21 +0000 (18:16 +0200)]
Release 1.3.1

10 years agoaudiomixer: set a group-id on the stream-start event
Stefan Sauer [Tue, 11 Mar 2014 21:36:01 +0000 (22:36 +0100)]
audiomixer: set a group-id on the stream-start event

Set a default group-id to fix a warning printed by the sink.

10 years agoaudiomixer: Remove some useless assignments and skip the current part of the buffer...
Sebastian Dröge [Thu, 16 Jan 2014 11:18:45 +0000 (12:18 +0100)]
audiomixer: Remove some useless assignments and skip the current part of the buffer if the pad is muted

10 years agoaudiomixer: Fix and simplify overlap calculation
Sebastian Dröge [Wed, 15 Jan 2014 22:30:28 +0000 (23:30 +0100)]
audiomixer: Fix and simplify overlap calculation

10 years agoaudiomixer: Also resync timestamps on the RESYNC flag
Sebastian Dröge [Thu, 19 Dec 2013 20:59:09 +0000 (21:59 +0100)]
audiomixer: Also resync timestamps on the RESYNC flag

11 years agoaudiomixer: Add unit test for handling unaligned buffers
Sebastian Dröge [Thu, 7 Nov 2013 13:12:17 +0000 (14:12 +0100)]
audiomixer: Add unit test for handling unaligned buffers

That is, buffers that start or end in the middle of an output block.

11 years agoaudiomixer: Fix EOS handling if we have some pending data
Sebastian Dröge [Thu, 7 Nov 2013 13:12:00 +0000 (14:12 +0100)]
audiomixer: Fix EOS handling if we have some pending data

11 years agoaudiomixer: Add test for the discont handling
Sebastian Dröge [Thu, 7 Nov 2013 12:57:35 +0000 (13:57 +0100)]
audiomixer: Add test for the discont handling

11 years agoaudiomixer: Refactor sync test to be more reusable
Sebastian Dröge [Thu, 7 Nov 2013 12:55:32 +0000 (13:55 +0100)]
audiomixer: Refactor sync test to be more reusable

11 years agoaudiomixer: Remove some racy-ness from the unit test
Sebastian Dröge [Thu, 7 Nov 2013 12:48:06 +0000 (13:48 +0100)]
audiomixer: Remove some racy-ness from the unit test

We might already be EOS when we start the mainloop, so only
set the pipeline to PLAYING from the main loop.