root [Wed, 28 Sep 2005 21:03:32 +0000 (23:03 +0200)]
[libmultipath] generic discovery.c:wait_for_file()
clearly state the wait for file (sysfs or device node) logic is needed
only for multipathd, because it races udev upon uevent broadcast.
for multipath(8), which is ran by udev *after* devnode creation,
wait_for_file() just returns "ok".
root [Wed, 28 Sep 2005 08:14:30 +0000 (10:14 +0200)]
[multipath] the multipath udev rule voids the blacklist logic
"%M:%m" moved to "%r/%k"
with the assumption already used that these nodes exist.
root [Wed, 28 Sep 2005 08:08:46 +0000 (10:08 +0200)]
[multipath] yet another unchecked devt2devname() return value
This one caused a multipath -ll with no cache loaded to wait for a
pathinfo(nul) to complete for a path discovered in the map but not
present anymore in sysfs.
root [Tue, 27 Sep 2005 22:29:26 +0000 (00:29 +0200)]
[multipath] fix maj:min scope definition to a non-existant dev_t
We didn't check the return value of dev_t to devname translator,
which caused the tentative discovery of a random device,
which stalled for 5sec before concluding it can't be scanned.
This bug hit bad with partitions for example.
root [Tue, 27 Sep 2005 14:42:03 +0000 (16:42 +0200)]
[build] will I have the build optimization right this time ?
Master Makefile linked multipathd with libmultipath objects built
without -DDAEMON ... wrong condlog define.
root [Tue, 27 Sep 2005 13:25:09 +0000 (15:25 +0200)]
[multipathd] shut a libdevmapper error message when adding paths
"device-mapper ioctl cmd 12 failed: No such device or address" was
reported upon path add because we tried to submit a device-mapper ioctl
before the map is ready to receive it (and loop till it works or timeout).
shut the libdevmapper for this case with dm_init_log(&dummy_log) during
this operation.
root [Tue, 27 Sep 2005 11:10:09 +0000 (13:10 +0200)]
[multipathd] dead maps garbage collector fix
The collector could fail to catch all dead maps and/or point mem outside the
maps vector : fix the iteration logic.
root [Tue, 27 Sep 2005 09:48:53 +0000 (11:48 +0200)]
[multipath] multipath.rules is happy with install mode 644
previously set to 755.
root [Tue, 27 Sep 2005 09:43:53 +0000 (11:43 +0200)]
[multipath] oops, messed the rules badly with unescaped CR
root [Tue, 27 Sep 2005 08:48:41 +0000 (10:48 +0200)]
[multipath] forgot to remove multipath.dev refs in Makefile
root [Tue, 27 Sep 2005 08:25:21 +0000 (10:25 +0200)]
[multipath] adapt to the new udev rules
dev.d/ and hotplug.d/ are deprecated.
Move multipath and multipath partitions triggers to rules.d/
Don't create /dev/ links anymore, we now use exclusively on /dev/mapper/
root [Mon, 26 Sep 2005 09:32:46 +0000 (11:32 +0200)]
[libmultipath] don't trust the path wwid from cache if pathinfo() fails
This kept the reduced map from loading when multipathd runs and a path
is failed or offline.
Also fix get_claimed() false positive returns by checking errno == EBUSY
root [Sat, 24 Sep 2005 17:42:39 +0000 (19:42 +0200)]
[libmultipath] fix multipath & multipathd startup corner case
I got a report about strange behaviour of "multipath -l" if one of the
devices that are used for multipathing is set offline.
In that case the code in libmultipath (discovery.c) just ends processing
and the output is incomplete.
Failing a pathinfo() now means the path is down.
If the device was really removed,
- we wouldn't discover it in multipath
- a "del" uevent would prevent further pathinfo() in multipathd
root [Wed, 21 Sep 2005 21:04:37 +0000 (23:04 +0200)]
[libmultipath] load default hwtable entries not overriden by configlets
Rationale from Edward Goggin, EMC :
"
I'm wondering why when I put "device {}" entries in the multipath conf file
I
lose all of the other entries setup in the libmultipath/hwtable.c file.
Devices
which do not match the vendor and model strings of the device entries I
setup in the conf file are all forced to pick up default multipath
attributes.
This approach forces me to know the attributes for all vendor/model device
types in my SAN configuration whenever I want to setup even a small change
in the device attributes for a single device type.
I would rather see the that the entries that are setup in the conf file
simply
override the ones setup in the hwtable.c file. Yet, entries already setup
in
the hwtable.c file which are not overridden remain valid. The only devices
which pick up defaults are ones for which there is not a device entry in
either the libmultipath/hwtable.c file or the multipath conf file.
"
root [Wed, 21 Sep 2005 20:01:56 +0000 (22:01 +0200)]
[libmultipath] set pgfailback in internal hwtable entries
Edward Goggin, EMC
root [Mon, 19 Sep 2005 19:25:25 +0000 (21:25 +0200)]
[libmultipath] add "default_path_checker" config file keyword
This will make for denser config files.
root [Sat, 17 Sep 2005 22:55:09 +0000 (00:55 +0200)]
[libmultipath] tweak the Symmetrix getuid callout default
May want to patch the EMC SYMMETRIX hw entry in
libmultipath/hwtable.c to use the "-ppre-spc3-83"
scsi_id option. Doing so will allow scsi_id to
return a UID derived from a version of a SCSI
Inquiry EVPD page 83 which is not compliant with
either SPC-2 or SPC-3 for an older model Symmetrix,
that is, models 4, 5 and some model sixes.
Edward Goggin, EMC
root [Sat, 17 Sep 2005 22:47:51 +0000 (00:47 +0200)]
[libmultipath] unix socket read/write loops fix
Those can tight loop. Do finer checks with errno.h to avoid that.
From Alasdair Kergon, Redhat.
root [Sat, 17 Sep 2005 21:53:47 +0000 (23:53 +0200)]
[libmultipath] remove absolete multipath_tool config keyword
multipathd used to call multipath(8), thus needed to know the callout path.
This is no longer the case, so clean it up.
root [Fri, 9 Sep 2005 10:32:01 +0000 (12:32 +0200)]
[multipathd] small fixes
- Remove_maps() did remove 1 out of 2 map.
Only called on exit code path ...
- LCKDBG define to print useful code line number when using cleanup
functions
- Warn when falling back to pthread_kill()
- Free the uevent struct in libmultipath/uevent.c receive loop, not
in the trigger anymore.
root [Thu, 8 Sep 2005 09:54:25 +0000 (11:54 +0200)]
[multipathd] discard uevents on partitions too
root [Thu, 8 Sep 2005 07:39:51 +0000 (09:39 +0200)]
[multipathd] rename misnamed "struct paths" to "struct vectors"
root [Fri, 26 Aug 2005 20:19:56 +0000 (22:19 +0200)]
[priority] update the alua prioritizer
Removes bitfields in the SCSI structs.
This didn't work on i386.
From Stefan Bader, IBM
root [Fri, 26 Aug 2005 20:06:42 +0000 (22:06 +0200)]
[priority] update pp_alua man page
and adapts the manpage to the new callout name.
From Stefan Bader, IBM.
root [Thu, 25 Aug 2005 07:01:23 +0000 (09:01 +0200)]
[multipathd] refuse to add blacklisted paths from CLI
root [Thu, 25 Aug 2005 06:59:29 +0000 (08:59 +0200)]
[multipathd] off-by-one buffer len error for cli.c:genhelp()
root [Wed, 24 Aug 2005 15:02:21 +0000 (17:02 +0200)]
update template config files for rr_weight
... and purge uneeded configlets :
All tested hardware should be in the hard-coded defaults, no need to keep
the defaults out-of-sync in the templates config files.
root [Wed, 24 Aug 2005 14:48:40 +0000 (16:48 +0200)]
[multipath] option to use priorities as weights in the round-robin scheduler
Disabled by default.
Synthax is "rr_weight = priorities", and is valid in the default{},
device{} and multipath{} blocks.
This is an interim solution before a cleaner "least queued scheduler".
To make this complete, the daemon should be able to "message" DM to
change the path weights when their prio changes. Probably not worth the
effort and spend time on another scheduler.
The core of this patch is in the multipath table setup :
if (mp->rr_weight && pp->priority)
minio = conf->rr_minio * pp->priority;
The rest is the config switch handling, and printing.
root [Wed, 24 Aug 2005 10:16:38 +0000 (12:16 +0200)]
[build] last optimisation broke the dlog() switch. fix.
dlog() contains #if DAEMON statements.
So debug.o needs rebuild between multipath(8) and multipathd(8) builds,
which did not happen anymore since the last optimisation.
root [Wed, 24 Aug 2005 06:21:42 +0000 (08:21 +0200)]
[libcheckers] add the directio checker
Created by Hannes Reinecke, Suse, mainly for DASD devices.
root [Tue, 23 Aug 2005 15:04:27 +0000 (17:04 +0200)]
[build] shut a find usage warning (again)
root [Tue, 23 Aug 2005 15:02:44 +0000 (17:02 +0200)]
[libmultipath] '\0'-terminate snprint_*() buffers
root [Tue, 23 Aug 2005 14:16:00 +0000 (16:16 +0200)]
[libmultipath] don't re-select when not necessary in path discovery
.getprio, .getuid and .checkfn were needlessly re-selected each time the
corresponding value was updated through discovery.c:pathinfo().
Now that we are more selective, we need to :
- flush the cached values for multipath(8)
- re-select them in case of multipathd(8) "reconfigure" CLI command
root [Tue, 23 Aug 2005 14:08:04 +0000 (16:08 +0200)]
[libmultipath] fix segfault in print.c when MAX_LINE_LEN is reached
root [Tue, 23 Aug 2005 12:11:38 +0000 (14:11 +0200)]
[libmultipath] remove offending "\n" in print.c
They are already dealt with in the format string
root [Tue, 23 Aug 2005 10:34:25 +0000 (12:34 +0200)]
[multipathd] update priorities upon path check
and failback if need be.
nice to see in action with pp_random and failover grouping policy :/
0IET_____ISCSI___________00000000d20600000b00000000000000: switch to path group #1
0IET_____ISCSI___________00000000d20600000b00000000000000: switch to path group #3
0IET_____ISCSI___________00000000d00600000b00000000000000: switch to path group #2
...
root [Tue, 23 Aug 2005 08:34:46 +0000 (10:34 +0200)]
[multipath] show path group priority value in '-ll' and map [re]load modes
Asked by Ed Goggin, EMC, to diagnose easily when failback may be opportune.
root [Tue, 23 Aug 2005 07:54:38 +0000 (09:54 +0200)]
[kpartx] shut a build warning
root [Fri, 19 Aug 2005 15:57:06 +0000 (17:57 +0200)]
[libmultipath] move snprint_[path|map]() to format based printing fns
* path format magics :
*
* %w : multipath uid
* %i : scsi tuple
* %d : device name
* %D : device major:minor
* %t : device mapper path status
* %T : checker path status
* %s : scsi strings
* %c : claimed
*
* map format magics :
*
* %w : multipath uid
* %d : DM device name
* %F : failback countdown
* %C : checker countdown
and update all callers (nice cleanup).
The printing buffer overflow checking is done right at last.
root [Fri, 19 Aug 2005 09:48:31 +0000 (11:48 +0200)]
[multipath] DM-claimed paths are not to be considered as claimed
Use the dmstate path field to guess if the path is used bythe DM
driver. This assumes disassemble_*() have been called before the guess.
root [Fri, 19 Aug 2005 09:38:35 +0000 (11:38 +0200)]
[libmultipath] comestic changes
In struct.h, moved a bunch of defines to enums :
- SYSFS_BUS_*
- [KEEP|FREE]_PATHS
- FAILBACK_*
Renamed *_RESERVED to *_UNDEF all over includes.
Update all users.
root [Thu, 18 Aug 2005 18:43:04 +0000 (20:43 +0200)]
[build] be smarter at guessing when libs rebuild is needed
Without breaking the klibc stuff.
Total build time shortened a lot on small systems.
root [Thu, 18 Aug 2005 18:40:33 +0000 (20:40 +0200)]
[build] remove uneeded path_priority/Makefile
now that we find out what dirs to go compile into, no need for
intermediate Makefile
root [Thu, 18 Aug 2005 18:22:37 +0000 (20:22 +0200)]
[build] be smarter at guessing BUILDDIRS
and remove now useless $INSTALLDIRS and $ALLDIRS
root [Wed, 17 Aug 2005 16:16:46 +0000 (18:16 +0200)]
[multipathd] fix occasional CLI output trailing garbage
caused by an off-by-one reply len calculation in show_paths()
and show_maps()
root [Wed, 17 Aug 2005 16:01:59 +0000 (18:01 +0200)]
[libmultipath] working claimed device detection
done with O_EXCL
root [Wed, 10 Aug 2005 16:41:09 +0000 (18:41 +0200)]
[getuid] add usb_id
Well, this is useful for testing with usb keys
root [Wed, 10 Aug 2005 16:38:11 +0000 (18:38 +0200)]
[libmultipath] simplify the blacklist handling
No need to carry along the regex string.
So no need for a "struct blentry".
Now a blist vector directly holds regex_t entries.
root [Wed, 10 Aug 2005 13:21:13 +0000 (15:21 +0200)]
[multipath] correct map size display
off-by-one shifting error.
root [Wed, 10 Aug 2005 12:43:43 +0000 (14:43 +0200)]
[libmultipath] support multipath maps >2TB
Size field moved to ULL in struct path and multipath, as per
$KSRC/drivers/block/genhd.c suggests /sys/block/*/size size is.
Users updated.
root [Thu, 28 Jul 2005 14:31:10 +0000 (16:31 +0200)]
[multipath] handle alias changes in config file
Now initiate a remove / add sequence upon alias change in the config file.
The daemon catches on.
root [Thu, 28 Jul 2005 07:43:58 +0000 (09:43 +0200)]
[multipathd] '-d' command line flag does not fork anymore
'-d' flag did instruct the daemon to send its output to stdout instead of
the the logger thread. It now also have the consequence to not fork, so
the daemon is easily breakable from the shell.
root [Thu, 28 Jul 2005 07:38:33 +0000 (09:38 +0200)]
[multipathd] add the reconfigure CLI command
root [Wed, 27 Jul 2005 09:27:42 +0000 (11:27 +0200)]
[libmultipath] socket filesystem location moved to /var/run
As per LSB directions, according to Lars.
root [Wed, 27 Jul 2005 09:14:23 +0000 (11:14 +0200)]
[libmultipath] third cut at output column aligning
- remove libcheckers/path_state.c (consolidated into libmultipath/print.c)
- move the path status printing to print.c
- so finaly rename print_*_id() to snprint_*()
Pondered using this status format :
iet_lun0 (0IET_____ISCSI___________00000000d00600000b00000000000000)
[size=67 GB][features="0"][hwhandler="0"]
\_ round-robin 0 E
\_ 1:0:0:1 sdb 8:16 AA.
\_ round-robin 0 E
\_ 2:0:0:1 sdd 8:48 AA.
\_ round-robin 0 E
\_ 24:0:0:1 sdf 8:80 AA.
\_ round-robin 0 E
\_ 25:0:0:1 sdh 8:112 AA.
but no consensus reached on the list.
Keep the old one for now, and git log for reference.
root [Wed, 27 Jul 2005 06:40:36 +0000 (08:40 +0200)]
[multipathd] fix 2 log issues
There are two log issues that I uncovered. #1 If the log is emptied when
the tail points to the very end of the log area, and the next message needs
to roll over to the start, it doesn't pull the head around too, so the head
is pointing at an empty message, causing you to print a priority 0 message
of nothing. #2 It is possible for the log to be totally full, and on the
next enqueue, have the log tail point to the log head, which causes the
entire existing log to be lost.
This patch fixes both.
-Ben Marzinski
root [Tue, 26 Jul 2005 12:22:20 +0000 (14:22 +0200)]
[libchecker] readsector0 compilation warning fix
sg_read() take an unsigned char array as param, where the checker
passed a char array.
root [Tue, 26 Jul 2005 09:19:41 +0000 (11:19 +0200)]
[libmultipath] second cut at output column aligning
Column-align the "show maps" CLI command ouput.
root [Mon, 25 Jul 2005 12:49:28 +0000 (14:49 +0200)]
[libmultipath] first cut at output column aligning
Introduce libmultipath/print.[ch]
Use it to column-align multipath output and multipathd CLI messages
root [Fri, 22 Jul 2005 16:01:02 +0000 (18:01 +0200)]
[multipathd] fix daemon crash in enable_group() be pp->pgindex is nul
if a path is added through uev_add_path, pgindex can be unset.
we can safely skip enable_group() in this case, because upon next map
reload, all PG will be enabled.
root [Fri, 22 Jul 2005 15:05:46 +0000 (17:05 +0200)]
[multipath] revoke pp->mpp after loading a "struct path" from the daemon
Fix the multipath configurator believing it has nothing to do because
pp->mpp is already set, ie pp is already coalesced.
root [Fri, 22 Jul 2005 10:18:08 +0000 (12:18 +0200)]
[multipathd] move the shutdown message down in the shutdown sequence
root [Fri, 22 Jul 2005 10:11:21 +0000 (12:11 +0200)]
[checkers] remove trailing '\n' in checker messages
root [Fri, 22 Jul 2005 08:07:55 +0000 (10:07 +0200)]
[libmultipath] condlog() not to enqueue uneeded logs
Message enqueueing didn't check for verbosity level.
Corrected.
root [Thu, 21 Jul 2005 21:35:23 +0000 (23:35 +0200)]
[multipathd] Two little issues with unix socket lsnr.
Multipathd was shutting down whenever I tried to start up gdb monitoring
on it, because uxlsnr code didn't like getting a signal.
Also, having a lot of overlapping calls to the uxlsnr code caused really
bad things to happen because of a linked list oversight.
This patch corrects both.
Benjamin Marzinski, Redhat
root [Thu, 21 Jul 2005 18:54:20 +0000 (20:54 +0200)]
[libmultipath] no need to msg when multipath can't connect to uxsock
root [Thu, 21 Jul 2005 15:58:45 +0000 (17:58 +0200)]
[multipath and multipathd] remove the path cache file logic
Replace by an Unix socket communication with the daemon.
The daemon has its pathvec always up-to-date, thanks to its
event-driven model.
As a side-effect, people who care about early userspace have now
2 options :
1) No daemon in early userspace, and disable hotplug-triggered multipath.
/sbin/multipath is ran once.
2) Start the daemon in early userspace, let multipath be hotplug-triggered
Comments welcome on dm-devel. It's not too late to revert the thing :/
root [Thu, 21 Jul 2005 06:42:50 +0000 (08:42 +0200)]
[multipathd] dead includes yearly clean up in main.c
root [Thu, 21 Jul 2005 06:34:06 +0000 (08:34 +0200)]
[multipathd] remove copy.[ch]
The only user was prepare_namespace(), gone.
root [Wed, 20 Jul 2005 09:03:42 +0000 (11:03 +0200)]
[libmultipath] add HSV110 to the hwtable
root [Wed, 20 Jul 2005 08:40:57 +0000 (10:40 +0200)]
[multipathd] uevent trigger to not react to "remove map"
... for now.
The DM event waiter thread pins the devmap kobj.
Thus no uevent is triggered upon map removal until the thread is reaped.
Chicken and egg.
We have the mpvec garbage collector now anyway.
root [Wed, 20 Jul 2005 08:35:23 +0000 (10:35 +0200)]
[build] 'find' warning fix
Recent versions of find (Debian SID for example) warn about order of
min/maxdepth params. So reorder to keep the bugger happy.
root [Wed, 20 Jul 2005 08:30:25 +0000 (10:30 +0200)]
[multipathd] SIGUSR1 to SIGHUP for alt thread cancelation
SIGUSR1 was not a good idea after all.
root [Wed, 20 Jul 2005 07:29:05 +0000 (09:29 +0200)]
[multipathd] race bugs
I was looking at the waitevent thread, and I noticed some issues. Since the
cancellation type is asynchronous, the thread can get cancelled at any
moment. This can cause bugs. For instance, the double removal of the dm task
structure that just got fixed can still show up if the thread were cancelled
after it was freed but before it was set to NULL, there were other issues
like this in update_multpath. It seems like the easiest way to fix this is to
set some defined cancellation points. So that's what this does.
Benjamin Marzinski, Redhat
root [Wed, 20 Jul 2005 07:23:59 +0000 (09:23 +0200)]
[multipathd] detach threads
since multipathd doesn't ever do pthread_joins, I made the threads
be detached, so that they can completely clean up once they exit. This
probably should get included, to plug a small memory leak.
Benjamin Marzinski, Redhat
root [Wed, 20 Jul 2005 07:21:27 +0000 (09:21 +0200)]
[multipathd] interim support for reaping DM events waiter threads
It is sort of late in the game for redhat to be making kernel patches for the
next release, so here is an alternate way of getting to break out of the
waitevent pthread.
Martin Marzinski, Redhat.
I merge the patch, mainly because some users will get stuck unkowing of
Ed's patch, and it doesn't get in the way when this kernel patch will be
merged.
root [Wed, 20 Jul 2005 06:42:20 +0000 (08:42 +0200)]
[multipathd] remove the private namespace and callout cache logic
Because,
1) Martin spoted some rough edges with it and pthread cancelations.
2) It was introduced at a time when path reinstate was done by
/sbin/multipath, which is not the case anymore.
3) It simplifies the design a fair bit and removes quite a lot of code.
I verified the path reinstate codepath, and it does only 1 dmt allocation
... no callbacks anymore.
root [Mon, 18 Jul 2005 22:29:55 +0000 (00:29 +0200)]
[libmultipath] get_word() to initialize *word to NULL early
mulitpathd was crashing when I entered an empty line at the CLI prompt,
because the output buffer from get_word was being checked to see if it
was NULL, but get_word never explicitly sets the buffer to NULL if there
is no word.
The patch fixes this.
-Ben Marzinski, Redhat
root [Fri, 15 Jul 2005 23:00:00 +0000 (01:00 +0200)]
[libmultipath] revert "remove queue_if_no_path for DGC hardware"
My mistake here. We still need this attribute in order to deal
with the possibility of having a transient period of time during
a ucode upgrade where all paths to a SCSI LU may appear to be
failed.
Edward Goggin, EMC.
root [Fri, 15 Jul 2005 22:56:34 +0000 (00:56 +0200)]
[multipathd] Ed's Friday assorted fixes
I've found the removal of a multipath map (or all of them for that matter)
to be troublesome for multipathd, particularly its waitevent pthreads.
The dm driver in the kernel was not waking up the dm event waiters so they
stayed in the kernel where each one held a reference on the mapped device
and its table. This held reference prevented the multipathd from receiving
either a uevent or a hotplug event for the removal of the multipath block
device -- since it is not removed in this case.
--- drivers/md/dm-ioctl.c.orig 2005-07-14 13:33:56.
000000000 -0500
+++ drivers/md/dm-ioctl.c 2005-07-14 22:01:04.
000000000 -0500
@@ -226,10 +226,22 @@
static void __hash_remove(struct hash_cell *hc)
{
+ struct dm_table *table;
+
/* remove from the dev hash */
list_del(&hc->uuid_list);
list_del(&hc->name_list);
unregister_with_devfs(hc);
+
+ /*
+ * Wakeup any dm event waiters.
+ */
+ table = dm_get_table(hc->md);
+ if (table) {
+ dm_table_event(table);
+ dm_table_put(table);
+ }
+
dm_put(hc->md);
if (hc->new_map)
dm_table_put(hc->new_map);
With dm-ioctl.c patched to wake up waiting dm event threads when a mapped
device is removed, multipathd has issues. Fixed 3 bugs
(1) update_multipath wasn't dealing with an error from setup_multipath.
Setup_multipath error path involved the call chain
update_multipath_strings->update_multipath_table->
dm_get_map->dm_task_run->ioctl.
Since the mpp structure for a block device could be deallocated in
setup_multipath, the multipathd could SIGSEGV when it referenced the
deallocated mpp memory in update_multipath.
(2) The waitevent pthread's dm task structure memory was getting
destroyed twice if it ever broke out of its waitevent loop due to the call
to waiteventloop returning < 0. I set wp->dmt to null after waiteventloop
called dm_task_destroy to prevent free_waiter from doing likewise.
(3) setup_multipath was not removing the mpp ptr from the allpaths->mpvec
vector if it deallocated the mpp structure memory due to the error
occurrence mentioned in (1).
This omission would cause multipathd mpvec_garbage_collector to SIGSEGV.
Fixed uev_add_map since it had the same issue.
Edward Goggin, EMC.
root [Thu, 14 Jul 2005 20:46:22 +0000 (22:46 +0200)]
[prioritizers] alua upgrade
I've got a small update for pp_alua which mainly adds a man page and the
ability to cope with "impatient users" (it can create its own devnode
since udev may not have created one, yet).
Stefan Bader, IBM.
root [Thu, 14 Jul 2005 20:19:00 +0000 (22:19 +0200)]
[libmultipath] more explicit dm-prereq() output
"prerequisite not met" was just not informative enough, as
proven by the mailing list traffic about that.
root [Wed, 13 Jul 2005 08:56:08 +0000 (10:56 +0200)]
[libmultipath] remove queue_if_no_path for DGC hardware.
Asked by Edward Goggin, EMC.
root [Sun, 10 Jul 2005 09:16:06 +0000 (11:16 +0200)]
[libchecker] add pstate_snprintf()
And use it in multipathd and multipath.
root [Sat, 9 Jul 2005 13:03:48 +0000 (15:03 +0200)]
[multipathd] add header white line to the CLI generic help message
More readable (my opinion)
root [Sat, 9 Jul 2005 12:56:21 +0000 (14:56 +0200)]
[multipathd] in debug mode, log the pathchecker values for each check
Somewhat asked by Edward Goggin, EMC
root [Sat, 9 Jul 2005 12:41:43 +0000 (14:41 +0200)]
[multipath] set an initial value to di_flag in main()
Could you initialize di_flag to 0 in main() of multipath/main.c or
else "multipath -l" and "multipath -ll" use a non-deterministic flags
value for path discovery?
Edward Goggin, EMC
root [Mon, 4 Jul 2005 07:35:15 +0000 (09:35 +0200)]
[libmultipath] possible daemon crash with pp->wwid == 0x0
It is possible for a path to have its .wwid empty in the daemon pathvec,
causing all sorts of trouble.
In disassemble_map(), update the pp->wwid with mpp->wwid for paths which
may not have been active at the time the getuid callout was run.
Spotted by Edward Goggin, EMC.
root [Mon, 4 Jul 2005 07:28:24 +0000 (09:28 +0200)]
[multipath] '-l' to never report checker state
Makes for a more consistent output.
Asked by Edward Goggin, EMC.
root [Fri, 1 Jul 2005 18:59:53 +0000 (20:59 +0200)]
[multipathd] Debian specific compilation error, pthread related
Move the locking out of upate_multipath(), up to its caller.
root [Fri, 1 Jul 2005 15:30:08 +0000 (17:30 +0200)]
[multipathd] memory and threading audit
Some leaks plugged.
Still, there is one left.
You can trigger it by submitting successive "add map $map" command to
the CLI. Each time RSS/VSZ take 32 units more.
Please help on this one.
root [Thu, 30 Jun 2005 09:38:57 +0000 (11:38 +0200)]
Tame warning when compiling with _DEBUG_
All about uncasted MALLOC()s when it is defined to dbg_malloc().
root [Thu, 30 Jun 2005 09:12:43 +0000 (11:12 +0200)]
[multipathd] don't free unallocated mem in cli.c
RHEL4 really doesn't like it.
root [Thu, 30 Jun 2005 09:11:10 +0000 (11:11 +0200)]
[multipathd] -lreadline needs -lcurses
well on RHEL4 at least.
So add it to the LDFLAGS
root [Wed, 29 Jun 2005 14:18:30 +0000 (16:18 +0200)]
[multipathd] merge a more versatile CLI parser
Synthax moved to :
list paths
list maps
add path $path
remove|del path $path
add map $map
remove|del map $map
switch|switchgroup map $map group $group
root [Fri, 24 Jun 2005 12:30:17 +0000 (14:30 +0200)]
[multipathd] uxsock patch
I was playing around with the CLI, and having some issues. Occasionally
commands wouldn't work, which was because multipathd was using string
functions on strings that weren't NULL terminated. Also, if you just typed
in junk for the name of the map to remove, it would always remove dm-0,
because atoi returned 0. I fixed those, added some moron-proofing checks,
and made multipathd reply "fail" if the command failed.
Here's the patch
Benjamin Marzinski, Redhat.
root [Fri, 24 Jun 2005 10:47:15 +0000 (12:47 +0200)]
[multipathd] assorted cleanups
- remove the superfluous dm_mapname() "target type" param
- log more errors in the devmapper wrapper library
- in "struct event_thread" move from "pthread * thread" to "pthread thread"
- introduce a pthread_cleanup function
- wrap the waiter thread dmt in the "struct event_thread" for cleanup
- put cancelation points around the WAIT ioctl
- introduce a garbage collector to remove dead entries in the mpvec
- use strdup instead of asprintf as the later produce warnings here
root [Fri, 24 Jun 2005 09:32:23 +0000 (11:32 +0200)]
[multipathd] shut a warning down
assignment used as test value in the readline loop.
root [Wed, 22 Jun 2005 13:04:27 +0000 (15:04 +0200)]
[multipath] map flushing to remove layered DM-partitioned too
"multipath -F" or "multipath -f $map" refused to remove a map if kpartx
layered partioned upon it. This patch should take care of that.
root [Wed, 22 Jun 2005 09:49:52 +0000 (11:49 +0200)]
[multipath] express the failback delay in seconds
Failback is still scheduled upon path going up and canceled upon paths
going down.