Leif-Julian Ovrelid [Thu, 8 Nov 2018 09:16:10 +0000 (10:16 +0100)]
Fix missing self dependency in renderpass tests
The dEQP-VK.renderpass.suballocation.formats and
dEQP-VK.renderpass.dedicated_allocation.formats tests were missing self
dependencies in some cases where they read then write one attachment
in one subpass. In cases with overlapping rendering this would give a
read-write-then-read-write situation, which neads a self dependency to
work reliably. Some of the tests were missing the self dependency, some
of them had the color attachment bits set when depending on depth, and
one case had a self dependency where it should not.
This patch adds a self dependency to two test cases that need it,
removes self dependency from a case that does not need it, and fixes
the depth tests to have the correct bits set.
Affects:
dEQP-VK.renderpass.suballocation.formats.*.input.*
dEQP-VK.renderpass.dedicated_allocation.formats.*.input.*
dEQP-VK.renderpass2.suballocation.formats.*.input.*
dEQP-VK.renderpass2.dedicated_allocation.formats.*.input.*
Components: Vulkan
VK-GL-CTS Issue: 1454
Change-Id: I4a9bec3ef6b088ab3a50d7f658867076f68788b9
Alexander Galazin [Thu, 8 Nov 2018 11:52:47 +0000 (12:52 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I7e4ffa1e9b7956f0c77ee9b8dfc3d958743c0929
Chad Versace [Mon, 15 Oct 2018 19:45:46 +0000 (12:45 -0700)]
Fix swapchain creation in dEQP-VK.wsi.*.swapchain.*
In the Vulkan 1.1.87 spec release, the release fixed a bug in
VkSwapchainCreateInfoKHR by adding the following VU:
* imageFormat, imageUsage, imageExtent, and imageArrayLayers must be
supported for VK_IMAGE_TYPE_2D VK_IMAGE_TILING_OPTIMAL images as
reported by vkGetPhysicalDeviceImageFormatProperties.
Jesse Hall authored the fix in response to behavior discovered by Chad
Versace while debugging failures in dEQP-VK.wsi.android.swapchain.* on
Intel Chrome OS devices. This patch fixes the failing tests to comply
with the spec bugfix.
Components: Vulkan
VK-GL-CTS Issue: 1395
Affects: dEQP-VK.wsi.*.swapchain.*
See-Also: https://gitlab.khronos.org/vulkan/vulkan/issues/1029
Change-Id: I959774833d03b63eb6e23fbd3a7ff33378b44110
(cherry picked from commit
49eab80e4a8b3af1790b9ac88b096aa9bffd193f)
Alexander Galazin [Thu, 1 Nov 2018 10:24:35 +0000 (11:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I5874225ecf8aae48bd833a15492668a83f985f38
Alexander Galazin [Thu, 1 Nov 2018 09:53:29 +0000 (10:53 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I587d40c09a99e93dd4cccf359ceba1dbf9ff47a9
Piotr Byszewski [Thu, 25 Oct 2018 14:50:20 +0000 (16:50 +0200)]
Correct vertex input tests on null driver
On Null driver all features are enabled and this triggered execution
of tests for 128 vertex attributes that are not commonly supported.
Tests allocate buffer for verification which is not big enough for
128 attributes. This causes memory corruption and crash.
This change resolves those issues.
Components: Vulkan
VK-GL-CTS issue: 1443
Affects:
dEQP-VK.pipeline.vertex_input.*
Change-Id: I9a89cc62fdd34f9da40ebf9d84e6cf5b5aed07d5
Piotr Byszewski [Tue, 23 Oct 2018 09:42:49 +0000 (11:42 +0200)]
Correct image properties tests on Null driver
On Null driver all features are enabled and this trigered some issues
with YCBCR format in image_format_properties tests. This change
resolves those issues.
VK-GL-CTS issue: 1438
Components: Vulkan
Change-Id: I3d1707438909ae4f5e828092a97a6380b615beca
Affects: dEQP-VK.api.info.image_format_properties.*
Alexander Galazin [Thu, 25 Oct 2018 15:03:10 +0000 (17:03 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I2d8288ee3b75ef786496453b0efa6591f4f5c0ad
Alexander Galazin [Thu, 25 Oct 2018 13:52:47 +0000 (15:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: Ic87368f606cb8ec126d42ec9f72b1baffcdcf950
Noah Fredriks [Wed, 11 Jul 2018 21:56:05 +0000 (17:56 -0400)]
Fix incomplete VkImageSubresourceRange
Pipeline image barrier arraySize doesn't include the entire image.
Affects: dEQP-VK.api.copy_and_blit.core.resolve_image.whole_array*
Components: Vulkan
VK-GL-CTS Issue: 910
Change-Id: I9974c9390478cf70f2238e03a7180fc81166f84e
Alexander Galazin [Thu, 25 Oct 2018 11:51:47 +0000 (13:51 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I116b300bfdd3ee78827aa671a737de007eb241ef
Slawomir Cygan [Mon, 22 Oct 2018 11:12:16 +0000 (13:12 +0200)]
Fix spelling on NotSupported error message
Components: Vulkan
VK-GL-CTS Issue: 1433
Affects: dEQP-VK.api.info.device_group.peer_memory_features
Change-Id: I42e2d7a50d2f74d706e42f0f196ff76c8446fa1c
Piotr Byszewski [Thu, 18 Oct 2018 09:55:56 +0000 (11:55 +0200)]
Correct copy_and_blit on Null driver
On Null driver all features are enabled which leads copy_and_blit
tests to be executed for incompatible image formats. This change
detects that and fails the verification to prevent hiting assertions
in the framework.
VK-GL-CTS issue: 1427
Components: Vulkan
Affects:
dEQP-VK.api.copy_and_blit.*
Change-Id: I0d105c297f5548175580434cc2a12fa53b69339d
Noah Fredriks [Wed, 11 Jul 2018 21:47:02 +0000 (17:47 -0400)]
Don't exhaust 32-bit host visible address space
If VkPhysicalDeviceGroupProperties::subsetAllocation is VK_FALSE, then
then devices in the device group will each consume memory. Adjust the
limit to account for this.
Affects: dEQP-VK.memory.allocation.basic.*
Components: Vulkan
VK-GL-CTS Issue: 1405
Change-Id: I0074c49855435dc3403b64ce85a180397c4ed955
Alexander Galazin [Fri, 5 Oct 2018 10:30:19 +0000 (12:30 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Iea478874f1c63e4ac841c7143690c0df44864d7a
Alexander Galazin [Fri, 5 Oct 2018 10:30:15 +0000 (12:30 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I24509b7943339682384362e4c839f66ca6a2d293
Alexander Galazin [Tue, 2 Oct 2018 12:53:42 +0000 (14:53 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Icb47ef51091c8e9137ab558e24f36658a19a42eb
Bas Nieuwenhuizen [Mon, 1 Oct 2018 11:32:59 +0000 (13:32 +0200)]
VK_KHR_incremental_present: Fix usage flags.
Besides swapchain support we also need
vkGetPhysicalDeviceImageFormatProperties support. Use just the
needed flags instead. As COLOR_ATTACHMENT is required in
VK_KHR_surface, we don't need to check for it.
Affected tests:
dEQP-VK.wsi.*.incremental_present.*
Components: Vulkan
VK-GL-CTS issue: 1395
Change-Id: I4dd0f95da0a8f31c11efe7ce58f12cfbe160a71e
Peter Quayle [Fri, 28 Sep 2018 16:10:04 +0000 (17:10 +0100)]
Fix timeout in dEQP-VK.wsi.android test
Changes in Android P have causes the workload in
dEQP-VK.wsi.android.swapchain.simulate_oom.min_image_count
to increase significantly, leading to timeouts on some platforms.
This is worked around by simply touching the watchdog timer
between cases.
Affects:
dEQP-VK.wsi.android.swapchain.simulate_oom.min_image_count
Components: Vulkan
VK-GL-CTS issue: 1383
Change-Id: If5da804796f85acd3c2b9709a5463951609168dc
Alexander Galazin [Tue, 25 Sep 2018 11:05:35 +0000 (13:05 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I4e418414ad3adf232f210cacb3e84881ae94d98e
Matthew Netsch [Wed, 5 Sep 2018 18:36:31 +0000 (14:36 -0400)]
Reduces percentage of heap used in memory tests
Heaps can be shared and even fragmented on real systems.
The current percentage of 50% is a little high to reasonably
account for these issues.
Components: Vulkan
VK-GL-CTS issue: 1342
Affects:
dEQP-VK.memory.device_group_allocation.random*
Change-Id: I9a9c7fff05a663facd142a61a505c38925912ed8
(cherry picked from commit
1dab6c690815c1640b7726e05211ec3ab244f935)
John Anthony [Wed, 19 Sep 2018 14:44:43 +0000 (16:44 +0200)]
Fix pipeline barrier issues in protected memory tests
Set correct stage mask for pipeline barriers, and remove pipeline
barriers that are not needed.
Components: Vulkan
VK-GL-CTS issue: 1373
Affects:
dEQP-VK.protected_memory.buffer.*
dEQP-VK.protected_memory.attachment.*
Change-Id: I6dae7ad02c66649281a35465939437a5fb26dd0e
Matthew Netsch [Fri, 7 Sep 2018 17:44:55 +0000 (13:44 -0400)]
Fixes WSI protected swapchain allocation tests
Will now throw not supported if swapchain config
cannot fit in the available heap space.
Changes available heap space to fixed 25% of total
reported heap size instead of the current
"total - 2 * imageSize"
Components: Vulkan
VK-GL-CTS issue: 1345
Affects:
dEQP-VK.protected_memory.interaction.wsi.android.swapchain.create.*
Change-Id: I6854ae29b4394d450e47cc78bfb905362a964ec4
(cherry picked from commit
f679b545b3b5f06bfb84069a4c712e3988204326)
Alexander Galazin [Fri, 21 Sep 2018 09:04:45 +0000 (11:04 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I9cb8925fdf0bea5cafa7460e7621d863c5e0de85
Marcin Kantoch [Wed, 19 Sep 2018 09:18:16 +0000 (11:18 +0200)]
2Darray compatible flag not allowed for 2D images
Fix for dEQP-VK.api.external.memory.*.image.info tests
incorrectly set create flag VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT
for 2D images
Components: Vulkan
Affects:
dEQP-VK.api.external.memory.*.image.info
VK-GL-CTS issue: 1362
Change-Id: I6863fc30177979b913c9e0d4b5814cb857764e27
Robert Tray [Fri, 14 Sep 2018 22:40:32 +0000 (16:40 -0600)]
Add screenLayout to AndroidManifest configChanges
Android P will generate screenLayout configuration changes for
AndroidTV devices when an orientation change happens.
Specify that dEQP will handle screenLayout config changes in the
manifest so the Android framework doesn't try to stop and restart dEQP.
dEQP can't handle a restart and just exits.
Components: AOSP
VK-GL-CTS issue: 1357
Change-Id: I0e4eb3a89f5dfb175cbeb32cc6c921a0fe99e477
Alexander Galazin [Wed, 19 Sep 2018 07:24:01 +0000 (09:24 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ieda52b4e886e4448634bdea91f0791548642d3b0
Alex Walters [Fri, 14 Sep 2018 10:44:55 +0000 (11:44 +0100)]
Add ASTC LDR error colour quality warning
Some hardware can output the HDR error colour (black) instead of the
LDR error colour (magenta). Valid compression blocks are rendered
correctly.
This change adds a second comparison mechanism if the initial *fast*
deMemCmp fails; the texture values are compared allowing for any value
matching an error colour to compare against the other error colour.
If such a match is detected the test will output a QualityWarning
instead of a Pass.
If the two compared values don't match, but are not both error colours
the test result is still a Fail.
Affects:
dEQP-VK.image.texel_view_compatible*astc*
Components: Vulkan
VK-GL-CTS issue: 1231
Change-Id: Ie14913de0f2f3cf7fed90c275e48c67181c1e7ff
Matthew Netsch [Fri, 7 Sep 2018 17:44:55 +0000 (13:44 -0400)]
Fixes WSI protected swapchain allocation tests
Will now throw not supported if swapchain config
cannot fit in the available heap space.
Changes available heap space to fixed 25% of total
reported heap size instead of the current
"total - 2 * imageSize"
Components: Vulkan
VK-GL-CTS issue: 1345
Affects:
dEQP-VK.protected_memory.interaction.wsi.android.swapchain.create.*
Change-Id: I6854ae29b4394d450e47cc78bfb905362a964ec4
Tony Wasserka [Tue, 3 Apr 2018 14:40:21 +0000 (15:40 +0100)]
Consider rounding mode differences in mipmap tests
The tests already tolerate a threshold for rounding mode differences
for the result of a downscaling vkCmdBlitImage, however the accumulated
difference between Round-To-Nearest and Round-To-Zero may exceed the
current threshold. With this change, the expected result is generated
from the preceding device-rendered mipmap instead, so any legitimate
error will always be within the threshold now.
Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.*_linear
Components: Vulkan
VK-GL-CTS issue: 1106
Change-Id: I0999419320d1b2384f42fbc8eddda29e79147bd4
(cherry picked from commit
b861ca1e6d4c002d4359a71dbff1cdf898e79aca)
Alexander Galazin [Fri, 14 Sep 2018 14:55:26 +0000 (16:55 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I3cf1ce3cb9da66c83e88048fb29a055ec196497e
Dzmitry Malyshau [Mon, 10 Sep 2018 00:40:54 +0000 (20:40 -0400)]
Test cube image blits with VK_IMAGE_CREATE_CUBE_COMPATIBLE flag.
The intent of blit tests with layer count = 6 was to test cubemap image support.
This PR adds the appropriate image creation flag for those tests.
Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.*
VK-GL-CTS issue: 1336
Components: Vulkan
Change-Id: I6ca0bb6905baebb4e6e6d3597e6e7c54d582473a
(cherry picked from commit
d8a05170a7ae7b6b284406f900b9609c7e71be14)
Liam Middlebrook [Tue, 11 Sep 2018 05:42:26 +0000 (22:42 -0700)]
Fix RobustnessVertexAccessInstance bounds check
The bounds check preformed by
VertexAccessInstance::isValueWithinVertexBufferOrZero() needs to round
the value rather than truncating it when encoding it. When
`value * 0x3FFu` is casted to a deUint32 it's possible for the result to
be truncated instead of rounded causing unintended test failures.
Affects: dEQP-VK.robustness.vertex_access.a2b10g10r10_unorm_pack32.draw.vertex_incomplete
Components: Vulkan
VK-GL-CTS issue: 1351
Change-Id: Ib034b3e29fdbbbd4670e2bbdedad07492abf5cd4
(cherry picked from commit
fed61233a802b5a8e7f6e634d0ef698e9155a94c)
Liam Middlebrook [Tue, 11 Sep 2018 05:42:26 +0000 (22:42 -0700)]
Fix RobustnessVertexAccessInstance bounds check
The bounds check preformed by
VertexAccessInstance::isValueWithinVertexBufferOrZero() needs to round
the value rather than truncating it when encoding it. When
`value * 0x3FFu` is casted to a deUint32 it's possible for the result to
be truncated instead of rounded causing unintended test failures.
Affects: dEQP-VK.robustness.vertex_access.a2b10g10r10_unorm_pack32.draw.vertex_incomplete
Components: Vulkan
VK-GL-CTS issue: 1351
Change-Id: Ib034b3e29fdbbbd4670e2bbdedad07492abf5cd4
Alexander Galazin [Thu, 6 Sep 2018 16:18:10 +0000 (18:18 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I717b207ec5642fb2f5a7deb9a91e52da7b3c862f
Alexander Galazin [Thu, 6 Sep 2018 15:48:31 +0000 (17:48 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I5a095ab6fddfaa9ce687f8627b58ec12176ba660
Matthew Netsch [Fri, 13 Jul 2018 15:10:54 +0000 (11:10 -0400)]
Fixes tessellation triangle check
Tessellators may produce inner vertices positioned
on the edge of a primitive when used with fractional
odd spacing and the inner tessellation level is one.
Point mode doesn't factor into this rule
Components: Vulkan
VK-GL-CTS Issue: 1273
Affects:
dEQP-VK.tessellation.primitive_discard.*
Change-Id: Ida8c75d4275403eaae8b52fe55f3ed9e61dd2d6e
Matthew Netsch [Wed, 5 Sep 2018 18:36:31 +0000 (14:36 -0400)]
Reduces percentage of heap used in memory tests
Heaps can be shared and even fragmented on real systems.
The current percentage of 50% is a little high to reasonably
account for these issues.
Components: Vulkan
VK-GL-CTS issue: 1342
Affects:
dEQP-VK.memory.device_group_allocation.random*
Change-Id: I9a9c7fff05a663facd142a61a505c38925912ed8
Alexander Galazin [Fri, 31 Aug 2018 07:52:20 +0000 (10:52 +0300)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I7e0e51ad6bbdebe2c0067cedbb8e0d3bca177fad
Petros Bantolas [Wed, 18 Jul 2018 10:19:04 +0000 (11:19 +0100)]
Fix subpixel precision for line geometry generation
Line geometry generation for rasterization tests wasn't taking the HW
subPixelPrecisionBits limit into account. Modified the triangle creation
routines to round those coordinates down to the driver provided
precision.
Affects:
dEQP-VK.rasterization.*line*
dEQP-GLES*.functional.rasterization.*line*
Components: Framework
VK-GL-CTS issue: 1274
Change-Id: I54af2f9606372bead2a8c7238588374101f80e55
Matthew Netsch [Tue, 28 Aug 2018 18:44:45 +0000 (14:44 -0400)]
Fixes memory allocation tests
Queries the platform specific alignment restrictions
with a temp buffer instead of estimating.
Components: Vulkan
VK-GL-CTS issue: 1259
Affects:
dEQP-VK.memory.allocation.basic.size_*
Change-Id: I272026f9e29b5606b8a4265ef0034752ac43a71a
John Anthony [Thu, 23 Aug 2018 14:11:13 +0000 (16:11 +0200)]
Incorrect enum values for VK_KHR_create_renderpass2
Some VkStructureType enum values added for VK_KHR_create_renderpass2 are
not in accordance with current Vulkan headers and the Vulkan
specification.
Components: Vulkan
VK-GL-CTS issue: 1321
Affects: dEQP-VK.*renderpass2.*
Change-Id: I51031d538bc427e56bbf56f603f200b513834d67
Aaron Bartholomew [Mon, 20 Aug 2018 19:28:42 +0000 (12:28 -0700)]
Improve wsi.incremental_present.* for low memory
This patch modifies the VK.wsi.incremental_present.* tests to alleviate
issues with memory use on memory constrained platforms
The issue is that the scale_down group in particular creates very large
swapchains & that the presentation engine may keep one or moreof the
swapchain images allocated until it is able to release them. Which means
that since this test does the following:
create swapchain, render some frames, destroy the swapchain, repeat
the high watermark for memory consumed by swapchain images will be higher
than the amount consumed by the single largest swapchain created.
This patch addresses these issues in two ways:
1) Reducing the size of the swapchain images allocated for scale down
tests to use the next power of two of the window size, instead of the
max extents reported by Vulkan
Max extents are already tested in other deqp tests & it's redundant
to do evaluate it again here; this change will make the test more
on functionality
2) Creates/Renders/Destroys a small dummy swapchain between each test
iteration in order to flush the memory held by the presentation
engine
Affects:
dEQP-VK.wsi.*.incremental_present.*
Components: Vulkan
VK-GL-CTS issue: 1179
Change-Id: Ib7e1a5d9110e7dabc0d0ced21b643389c2bf0328
(cherry picked from commit
a3ba2368fda1ecf8cc3d5c3136b5674a3414f472)
Ilya Zaytsev [Tue, 21 Aug 2018 14:46:48 +0000 (16:46 +0200)]
Fix issues in ProtectedMemCopyBufferToImage
Fixes the following issues:
* pipeline barriers were not correct: wrong stages and wrong access masks
were used
* R32G32B32A32_UINT image view was sampled from sampler2D
Affects: dEQP-VK.protected_memory.image.copy_buffer_to_image.*
Components: Vulkan
VK-GL-CTS issue: 1326
Change-Id: I9d7eb9f8d9c2dcda1d7dd1f3b0e68e71fcd8c8f9
Alexander Galazin [Fri, 24 Aug 2018 07:26:54 +0000 (09:26 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ie5d1d301b96c8eff6a7d974de13c1d35195d7b26
Alexander Galazin [Fri, 24 Aug 2018 07:26:51 +0000 (09:26 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I5b4bdc020c0dda7ec55aafd498cd1f1193b9c77b
Daniel Koch [Thu, 16 Aug 2018 02:55:06 +0000 (22:55 -0400)]
Fix copy/paste errors in opundef assembly tests
The tests were using %is_nan_0 repeatedly instead of %is_nan_<i>
Affects: dEQP-VK.spirv_assembly.instruction.graphics.opundef.*
(likely only the vec4float32 and matrix subsets)
Component: Vulkan
VK-GL-CTS: 1315
Change-Id: I2bed6e94f6867c424c5102ef3eeab8ac32021dcd
(cherry picked from commit
a46089154137e0939c02bdcabc74f5daa303ffb2)
Matthew Netsch [Wed, 8 Aug 2018 20:52:35 +0000 (16:52 -0400)]
Fixes geometry shader invocation dependency
dEQP-VK.tessellation.invariance.* updates a SSBO
expecting the implementation to execute the GS
once per primitive. Changes the test to allow
multiple invocations.
Components: Vulkan
VK-GL-CTS Issue: 1281
Affects:
dEQP-VK.tessellation.invariance.*
Change-Id: I6ed17a8afb413587bb38487ec9952f569a250193
Alexander Galazin [Tue, 7 Aug 2018 08:57:19 +0000 (10:57 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I3ebd996d37e078d937fe79ccc93718b51672e1c4
Simen Kaspersen [Wed, 1 Aug 2018 11:12:14 +0000 (13:12 +0200)]
Remove unconditional depth_clamping for 1.1.1
Changed depthClampEnable from VK_TRUE to VK_FALSE where it is not needed.
Depth clamp specific tests in builtin_var.fragdepth set as not supported for incompatible systems.
NB: Carries the same changes as 1.1.0 patch for depth_clamping, along with changes that are specific for 1.1.1.
Affects:
dEQP-VK.device_group.*
dEQP-VK.api.object_management.*.graphics_pipeline
dEQP-VK.binding_model.shader_access.*
dEQP-VK.glsl.builtin_var.fragdepth.*
dEQP-VK.synchronization.smoke.*
dEQP-VK.renderpass.*
dEQP-VK.spirv_assembly.*
dEQP-VK.api.smoke.unused_resolve_attachment
dEQP-VK.wsi.android.incremental_present.*
dEQP-VK.memory.pipeline_barrier.*
Components: Vulkan
VK-GL-CTS issue: 1286
Change-Id: I0e322c65561c25339fe56e3122401d92df7623a6
Simen Kaspersen [Mon, 30 Jul 2018 14:36:31 +0000 (16:36 +0200)]
Remove unconditional depth_clamping for 1.1.0
Changed depthClampEnable from VK_TRUE to VK_FALSE where it is not needed.
Depth clamp specific tests in builtin_var.fragdepth set as not supported for incompatible systems.
Affects:
dEQP-VK.device_group.*
dEQP-VK.api.object_management.*.graphics_pipeline
dEQP-VK.binding_model.shader_access.*
dEQP-VK.glsl.builtin_var.fragdepth.*
dEQP-VK.synchronization.smoke.*
dEQP-VK.renderpass.*
dEQP-VK.spirv_assembly.*
dEQP-VK.api.smoke.unused_resolve_attachment
dEQP-VK.wsi.android.incremental_present.*
dEQP-VK.memory.pipeline_barrier.*
Components: Vulkan
VK-GL-CTS issue: 1286
Change-Id: Ia869da75a74800543afb4f8fddd8bf5e8f7f4a7f
Alexander Galazin [Thu, 2 Aug 2018 08:27:48 +0000 (10:27 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I2b3ff32206b0408c16dd93bc643bdc9bf928dcda
Alexander Galazin [Thu, 2 Aug 2018 08:27:46 +0000 (10:27 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I178311e0fa4f5276ab325b65460074f60e42c222
Chris Forbes [Thu, 2 Aug 2018 00:16:17 +0000 (17:16 -0700)]
Fix build when SPIRV-Tools is not present
This function does not require SPIRV-Tools, and is still used when it
is not present.
Components: Framework
VK-GL-CTS: 1293
Change-Id: I9ce49db2e6e55e8d379c713c9fe39d15fb7ecbd6
Alexander Galazin [Tue, 3 Oct 2017 19:29:50 +0000 (21:29 +0200)]
Invalidate memory in draw tests
The test group writes to non-coherent device memory with device,
but fails to call the required invalidate on the region before
reading mapped memory with host.
Components: Vulkan
VK-GL-CTS issue: 529
Affects: dEQP-VK.draw.*
Change-Id: Icf4aa6ea80c8c046e41b37402457b7f094d7ae50
(cherry picked from commit
1ce6e233a6245a1cf81a2a4e88b87c5d381a119a)
Alexander Galazin [Fri, 20 Jul 2018 09:12:17 +0000 (11:12 +0200)]
Request queue with sparse support only when needed
Commit
a598fe87 added tests for sparse D/S/DS images and
at the same time turned many texture tests into NotSupported
on implementations what do not support sparse.
Components: Vulkan
Affects:
dEQP-VK.texture.compressed.*
dEQP-VK.glsl.texture_functions.texture.sparse*shadow*
dEQP-VK.glsl.texture_gather.*depth32f*sparse*
dEQP-VK.texture.shadow.*sparse*
VK-GL-CTS issue: 1277
Change-Id: I83392d4f1060efbe0b1eebb0dfa8c8d5306113db
Liam Middlebrook [Mon, 9 Jul 2018 19:27:02 +0000 (12:27 -0700)]
Don't fail DisplayPlaneProperties2 with no display
Instead, we should mark this test as not supported. The Vulkan spec
states that:
Devices must support at least one plane on each display
If there are no displays connected, the driver is allowed to return 0
planes.
VK-GL-CTS issue: 1271
Components: Vulkan
Change-Id: I097224fbdf3e25c921ac9b96d16954caab1bb895
Affects: dEQP-VK.wsi.display.get_display_plane_properties2
Arkadiusz Sarwa [Wed, 11 Jul 2018 14:47:23 +0000 (16:47 +0200)]
Fix 8bit uniform buffers arrays strides
Affects:
dEQP-VK.spirv_assembly.instruction.*.8bit_storage.*
Components: Vulkan
VK-GL-CTS issue: 1269
Change-Id: I3f761efbe6a7e5edc66bc6846eaf90ac4453bd78
Alexander Galazin [Fri, 13 Jul 2018 14:54:12 +0000 (16:54 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I92ddc3da6a7d67e926eb54beeaf1c190fcf7e87a
Sai Kiran Korwar [Tue, 3 Jul 2018 08:58:52 +0000 (14:28 +0530)]
Fix memory allocation tests
Use deviceMemoryAllocationGranularity to determine if some number
of allocations of a particular size will succeed.
This is useful on when platform specific alignment restrictions are
present.
Components: Vulkan
Affects: dEQP-VK.memory.allocation.basic.size_*
VK-GL-CTS issue: 1259
Change-Id: Iac4f2e7842a826bebf7c641fad1950f6c3d48946
Chris Forbes [Mon, 11 Jun 2018 22:50:16 +0000 (15:50 -0700)]
Allow two images worth of alignment slop in protected heap
We previously backed off by one image worth, but it's not enough in some
cases.
Components: Vulkan
VK-GL-CTS: 1262
Bug: b/
109757443
Test: dEQP-VK.protected_memory.interaction.wsi.android.swapchain.create#min_image_count
Change-Id: I01b3a72986e9f35b4ec15a146e4dc576758c02ce
(cherry picked from Android commit
0fd6d1afa4d00ffd3da1d2d1898f32d4e879209d)
Stephen Gallimore [Thu, 5 Jul 2018 13:40:13 +0000 (14:40 +0100)]
Protected memory image access tests not flushing staging buffer
Affected tests:
dEQP-VK.protected_memory.image.access.*
Components: Vulkan
VK-GL-CTS issue: 1264
Change-Id: I30a6e3b0118b6874b9bfdf625aadec9c0fe54710
Alexander Galazin [Sun, 8 Jul 2018 16:11:11 +0000 (18:11 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ifcbe9328d752355465f6ea56961e2b16205e6e12
Alexander Galazin [Sun, 8 Jul 2018 16:11:07 +0000 (18:11 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: Ie88a7283bd969891282983a549c6d18901a9ee7b
Marcin Rogucki [Wed, 25 Oct 2017 11:33:44 +0000 (13:33 +0200)]
gl_PrimitiveIDIn tests have sketchy loop bounds.
Components: Vulkan
VK-GL-CTS issue: 778
Updates:
dEQP-VK.geometry.basic.primitive_id_in
dEQP-VK.geometry.basic.primitive_id_in_restarted
Change-Id: Icd2be56814de18067ce058a5f2a1da80338f80d6
(cherry picked from commit
52b7de31e0bccf62ca28d820f4dc2d0d52793aa8)
Jarred Davies [Thu, 5 Apr 2018 09:51:23 +0000 (10:51 +0100)]
Drop linear filter requirement from YCbCr tests
Remove requirement for YCbCr base formats to support
VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_LINEAR_FILTER_BIT from
format_properties tests.
The standard does not require support for this feature
from any YCbCr format.
Affects:
dEQP-VK.api.info.format_properties.g8_b8_r8_3plane_420_unorm
dEQP-VK.api.info.format_properties.g8_b8r8_2plane_420_unorm
Components: Vulkan
VK-GL-CTS issue: 1090
Change-Id: I6fa1c6c7a7f9768c2001972ae1f04173310aa652
(cherry picked from commit
eab78dce0d08f4ec22cece6be8003f554ede5882)
Alexander Galazin [Fri, 6 Jul 2018 20:13:57 +0000 (22:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I02b6ca03cf03b1280440b8bcc497afc98f85037f
Alexander Galazin [Fri, 6 Jul 2018 20:06:52 +0000 (22:06 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I141a0abc53983443da9a5bb7c905538f1ddb4f22
Alexander Galazin [Fri, 6 Jul 2018 10:24:12 +0000 (12:24 +0200)]
Merge vk-gl-cts/github-vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: I29544b2f3f6b7bee65ac6ac1339eb52176efe5a5
Alexander Galazin [Fri, 6 Jul 2018 10:21:32 +0000 (12:21 +0200)]
Fix build error introduced by the previous commit
Components: Vulkan
Alexander Galazin [Wed, 4 Jul 2018 07:17:56 +0000 (09:17 +0200)]
Update SPIR-V tools and headers
Components: Framework
Change-Id: I6ed52b681738664ee471d78e59fc843c0b41319a
Chris Forbes [Fri, 2 Mar 2018 21:22:20 +0000 (13:22 -0800)]
Compile shaders for 1.0-compatible tests as SPIRV 1.0, not max supported
Components: Vulkan
VK-GL-CTS: 1232
Change-Id: I5a440f97f79be0e6d37d89018ae8b611e9d4e7c1
Maciej Jesionowski [Fri, 29 Jun 2018 09:52:54 +0000 (11:52 +0200)]
Check required peer memory features in sparse resources device group tests
This is a minimal fix to these cases to not use the memory in unsupported way.
The tests will return NotSupported if the required features are missing.
Affects:
dEQP-VK.sparse_resources.*device_group*
VK-GL-CTS issue: 1252
Components: Vulkan
Change-Id: Ia55509eef39c30e2283ba41d87ce55294edf6a17
Alexander Galazin [Mon, 25 Jun 2018 10:23:23 +0000 (12:23 +0200)]
Update SPIR-V tools/headers
Components: Framework
Change-Id: I3b67da0c17de5e637d44f0061b12b6024c940988
Arkadiusz Sarwa [Mon, 25 Jun 2018 07:52:17 +0000 (09:52 +0200)]
Fix: add extensions checking
Affects:
dEQP-VK.spirv_assembly.instruction.compute.*
Components: Vulkan
VK-GL-CTS issue: 1235
Change-Id: I816d832f4834fe61570f49648a9f92ebaca31a94
Arkadiusz Sarwa [Fri, 22 Jun 2018 10:40:40 +0000 (12:40 +0200)]
Fix: add extensions checking
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.*
Components: Vulkan
VK-GL-CTS issue: 1235
Change-Id: Ic312f6571534dfbb7117ca9f49b7c9067cfc04d6
Alexander Galazin [Fri, 22 Jun 2018 04:44:13 +0000 (00:44 -0400)]
Revert "Require geometry shader in multisample resolve"
This reverts commit
961ab17a006bccfa3b57ec34c8b88587482b78d3.
Change-Id: I3c7ae4d2b770b310ab264d270507a43beb2b30c1
Marcin Kańtoch [Thu, 7 Jun 2018 13:42:25 +0000 (15:42 +0200)]
Allowed device extensions list is missing entry
VK_KHR_create_renderpass2 is missing from the list of allowed
extensions in dEQP-VK.api.info.device.extensions test.
This causes the test to fail if the extension is exposed
in the driver.
Affects:
dEQP-VK.api.info.device.extensions
Components: Vulkan
VK-GL-CTS issue: 1208
Change-Id: I7024db0f775487b5601b5e8c82a807c58d070883
(cherry picked from commit
62deeb1fc1bcda275ff652c6466f9570a2fad75d)
Arkadiusz Sarwa [Mon, 22 Jan 2018 09:10:52 +0000 (10:10 +0100)]
Add tests for the VK_KHR_8bit_storage extension
Affect tests:
dEQP-VK.api.info.get_physical_device_properties2.features
Add tests:
dEQP-VK.spirv_assembly.instruction.compute.8bit_storage.*
dEQP-VK.spirv_assembly.instruction.graphics.8bit_storage.*
Components: Vulkan
VK-GL-CTS issue: 791
Change-Id: Ib29c03bf2cf59f70ad652f09bfa45260fef10e4f
(cherry picked from commit
dc7e8a60d7f241e64fcfde9648ba841f0db5ed79)
Boris Zanin [Fri, 18 May 2018 14:35:59 +0000 (16:35 +0200)]
Require geometry shader in multisample resolve
Updates tests:
* dEQP-VK.renderpass.suballocation.multisample_resolve.layers_3.*
* dEQP-VK.renderpass.suballocation.multisample_resolve.layers_6.*
* dEQP-VK.renderpass2.suballocation.multisample_resolve.layers_3.*
* dEQP-VK.renderpass2.suballocation.multisample_resolve.layers_6.*
Affects tests:
* dEQP-VK.renderpass.suballocation.multisample_resolve.*
Framework's Context class extended with function
* requireDeviceCoreFeature
Components: Vulkan, Framework
VK-GL-CTS issue: 1173
Change-Id: I8f4c8e85bf9ca97fa0a4024e132225714e281088
(cherry picked from commit
2584db9e45f73ade28f7b18614b32ac2ebef2d3a)
Boris Zanin [Tue, 20 Mar 2018 14:54:56 +0000 (15:54 +0100)]
Tests for VK_KHR_create_renderpass2: multiview
Add tests:
* dEQP-VK.multiview.renderpass2.*
Affects tests:
* dEQP-VK.multiview.*
Components: Vulkan
VK-GL-CTS issue: 1011
Change-Id: I6cd54231dae7ff30249ffb2f6f0799b1359f7790
Boris Zanin [Wed, 7 Mar 2018 10:37:46 +0000 (11:37 +0100)]
Tests for VK_KHR_create_renderpass2
Add tests:
* dEQP-VK.renderpass2.*
Affects tests:
* dEQP-VK.renderpass.*
Framework's Context class extended with functions
* requireDeviceExtension
* requireInstanceExtension
Components: Vulkan, Framework
VK-GL-CTS issue: 1011
Change-Id: I721563467dcd329f60da1b41e635feec228f5df2
Alexander Galazin [Thu, 21 Jun 2018 08:00:05 +0000 (10:00 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Iea6c9a56605b4c4407513face9be7fd4f61d3c83
Alexander Galazin [Fri, 15 Jun 2018 13:03:53 +0000 (15:03 +0200)]
Merge pull request #99 from AIOOB/patch-1
Require extension for the deviceFeatures2 test
Chris Forbes [Tue, 12 Jun 2018 18:03:59 +0000 (11:03 -0700)]
Fix protected memory buffer tests to do proper operation
Update and copy variants of these tests were doing the FILL operation
instead.
Change-Id: Iede9e71f50c1d2d5699b35ad9b86fc6237714977
Components: Vulkan
Affects: dEQP-VK.protected_memory.buffer.*
VK-GL-CTS: 1215
(cherry picked from commit
39fbe90f21cb24b46e1bbc2d49e75604453977c0)
Stephen Gallimore [Tue, 12 Jun 2018 14:35:46 +0000 (15:35 +0100)]
Memory binding tests not invaidating host memory before results check.
Affected tests:
dEQP-VK.memory.binding.*.buffer_*
Components: Vulkan
VK-GL-CTS issue: 1214
Change-Id: Ib347401ee818a42487df001f3ba76247b157321c
Prantit Lokre [Thu, 17 May 2018 18:41:16 +0000 (11:41 -0700)]
Fixes ycbcr copy tests to ignore padding
Copies are not expected to preserve the bits
in the padding for formats like R10X6.
Vulkan issue: 1122
Components: Vulkan
Affects:
dEQP-VK.ycbcr.copy.*
Change-Id: If617a32fbd4c690a0ef48e6831405fc674732865
Chris Forbes [Wed, 30 May 2018 16:26:57 +0000 (09:26 -0700)]
Don't rely on unspecified argument evaluation order in atomic swap tests
Bug: b/
78779994
Test: dEQP-VK.protected_memory.ssbo.ssbo_atomic.fragment.compswap.random.*
VK-GL-CTS: 1198
Components: Vulkan
Change-Id: Ifba8940745c28a32ca631beb374394a5e3fe508b
(cherry picked from Android commit
51e0000bcde19cee3c0e4686c0a3caec121b3c42)
Chris Forbes [Tue, 29 May 2018 19:26:19 +0000 (12:26 -0700)]
Request required 16bit storage features in UConvert/SConvert tests
These tests require specific features within the 16bit storage extension
Change-Id: I573b8ca69209ec36b3c249f5b9a638d4e7743209
Components: Vulkan
Bug: b/
78779994
VK-GL-CTS: 1195
Affects: dEQP-VK.spirv_assembly.instruction.compute.*
(cherry picked from Android commit
20426c97899d621fba9bcbae9374ec5439beedd6)
Dae Kim [Wed, 30 May 2018 12:55:30 +0000 (13:55 +0100)]
Added PointSize in shader used for drawing points
A SPIR-V assembly shader with undefined PointSize was being used with
point list topology.
Affects:
dEQP-VK.subgroups.*
Components: Vulkan
VK-GL-CTS issue: 1197
Change-Id: I2d38d367d413e205e00b32cdd96b8ca3ecf6eda4
Alexander Galazin [Mon, 28 May 2018 08:15:07 +0000 (10:15 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: If0ab08c681fd90e94d179ded910a531dcc518861
Slawomir Cygan [Wed, 18 Apr 2018 13:56:37 +0000 (15:56 +0200)]
Fix VkPipelineLayout use after free
The test destroys pipeline layout, used to create the graphics pipeline,
before the command buffer using this pipeline is recorded.
This is invalid according to spec:
"A VkPipelineLayout object must not be destroyed while any
command buffer that uses it is in the recording state."
Components: Vulkan
VK-GL-CTS Issue: 1134
Affects:
dEQP-VK.draw.differing_interpolation.*
Change-Id: I2dd692cfb69afaf0b9d6e8d8a29b86b945b7eaba
Joan Bonet Orantos [Tue, 22 May 2018 08:09:05 +0000 (10:09 +0200)]
Fix dependencies in vulkan pipeline test
The srcStageMask field in the subpass dependency was not strict
enough. This can cause that the incoming subpasses, that try to copy
samples from this subpass, may try to read content that may not be
written yet.
Affects:
dEQP-VK.pipeline.multisample.min_sample_shading.min_*
Components: Vulkan
VK-GL-CTS issue: 1185
Change-Id: Ide5e3d2a709e8fe26d23ada1d20bf2eb27beffd8
Alexander Galazin [Fri, 18 May 2018 13:01:32 +0000 (15:01 +0200)]
Whitelist VK_KHR_get_display_properties2
Components: Vulkan
Affects: dEQP-VK.api.info.device.extensions
Change-Id: Ic064e283e164cad2c9785ffe6253a2c192419668
Alexander Galazin [Fri, 18 May 2018 11:12:32 +0000 (13:12 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I4b35a41d666a707410f88f222c93b661f7d983a1
Jesse Hall [Wed, 16 May 2018 23:56:54 +0000 (16:56 -0700)]
Limit protected swapchain images based on memory
A surface's maxImageCount isn't based on the swapchain image extents
or format, so it's valid for swapchain creation to fail for
out-of-memory reasons even when the image count is within the
supported range.
This is particularly problematic for protected swapchains, since many
implementations have a limit on the total amount of protected memory
that can be allocated which is much smaller than total device memory.
This change estimates how much memory is used by protected swapchain
images, compares that to the size of heaps that support protected
memory types, and doesn't try to create swapchains that would have
more images than would fit within that size.
Components: Vulkan
VK-GL-CTS Issue: 1167
Affects:
dEQP-VK.protected_memory.interaction.wsi.*.swapchain.create.min_image_count
Change-Id: I6cc3bd25f7f22de8424f9e3375ade35fac26a884
Piers Daniell [Fri, 4 May 2018 22:53:25 +0000 (16:53 -0600)]
Don't use invalid sType as canary value for arrays
Using an invalid sType in an array is a violation of Vulkan
valid usage and will fail the test if validation layers
are enabled.
This CL also ensures the property structs passed into the
get functions have their sType initialized correctly.
Affects: dEQP-VK.wsi.display.*
Components: Vulkan
VK-GL-CTS issue: 1155
Change-Id: I4b9b00248265b2e3c7d0b2b652e98d2f0f5a0902
Graeme Leese [Thu, 26 Apr 2018 14:06:12 +0000 (15:06 +0100)]
Clear image layer 0 in memory commitment test
Components: Vulkan
Affected: dEQP-VK.api.get_memory_commitment.memory_commitment
VK-GL-CTS issue: 1151
Change-Id: I95676f18f91470248ac19270778b897626a31f2c
Ostrowski, Igor [Fri, 9 Feb 2018 10:56:15 +0000 (11:56 +0100)]
Add tests for VK_KHR_draw_indirect_count
This change add new tests for VK_KHR_draw_indirect_count
extension.
New Tests:
dEQP-VK.draw.indirect_draw.*.indirect_draw_count.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_first_instance.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_count_first_instance.*
dEQP-VK.draw.indirect_draw.*.indirect_draw_count_instanced.*
Affected tests:
dEQP-VK.api.info.device.extensions
Components: Vulkan, Framework
VK-GL-CTS issue: 1004
Change-Id: I3d53806eb1a45293a77b940d9c2fa540a6d83d50
(cherry picked from commit
7b47cd53c6656b866e7c3a3c0a590da85f3b2de1)
Tony Zlatinski [Thu, 3 May 2018 18:35:51 +0000 (13:35 -0500)]
Vulkan: Fix WIN32 NativeHandle importMemory leaks
importMemory(), incorrectly calls handle.disown()
that discards the reference that the handle originally
added via its copy constructor to the underlying memory
handle.
Affects:
dEQP-VK.api.external.memory.opaque_win32
Components: Vulkan
VK-GL-CTS issue: 1139
Change-Id: Idb5111b7efc2dfbf7d693d79b7ab57814329f33e