mtklein [Fri, 29 Jul 2016 17:41:37 +0000 (10:41 -0700)]
Add some GN builders to the CQ.
This parallels the set of bots we use to gate commits already.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2189283003
Review-Url: https://codereview.chromium.org/
2189283003
halcanary [Fri, 29 Jul 2016 17:13:18 +0000 (10:13 -0700)]
SkPDF: PDFStream has-a not is-a PDFDict
Motivation:
SkPDFStream and SkPDFSharedStream now work the same.
Also:
- move SkPDFStream into SkPDFTypes (it's a fundamental PDF type).
- minor refactor of SkPDFSharedStream
- SkPDFSharedStream takes unique_ptr to represent ownership
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2190883003
Review-Url: https://codereview.chromium.org/
2190883003
mtklein [Fri, 29 Jul 2016 17:10:15 +0000 (10:10 -0700)]
SkNx: add Sk4u
This lets us get at logical >> in a nicely principled way.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2197683002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2197683002
dvonbeck [Fri, 29 Jul 2016 16:53:56 +0000 (09:53 -0700)]
GrFP can express distance vector field req., program builder declares variable for it
This update allows fragment processors to require a field of vectors to the nearest edge. This requirement propagates:
- from child FPs to their parent
- from parent FPs to the GrPaint
- from GrPaint through the PipelineBuilder into GrPipeline
- acessed from GrPipeline by GrGLSLProgramBuilder
GrGLSL generates a variable for the distance vector and passes it down to the GeometryProcessor->emitCode() method.
This CL's base is the CL for adding the BevelNormalSource API: https://codereview.chromium.org/
2080993002
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2114993002
Review-Url: https://codereview.chromium.org/
2114993002
mtklein [Fri, 29 Jul 2016 16:10:31 +0000 (09:10 -0700)]
GN: components as static library instead of source set
This also puts the .a in the top-level of the ouptut directory, just
like we do for .so files. It's less required than for .sos, but it
does make it easier to find the .a.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2197633002
Review-Url: https://codereview.chromium.org/
2197633002
msarett [Fri, 29 Jul 2016 15:58:33 +0000 (08:58 -0700)]
Fix various SkColorSpace bugs
(1) Fixes serialization/deserialization of wacky SkColorSpaces
(2) Fix gamma equals checking
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2194903002
Review-Url: https://codereview.chromium.org/
2194903002
egdaniel [Fri, 29 Jul 2016 15:55:53 +0000 (08:55 -0700)]
Use HashSet instead of Dynamic hash for tracking vulkan resources
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2194823003
Review-Url: https://codereview.chromium.org/
2194823003
fmalita [Fri, 29 Jul 2016 15:52:03 +0000 (08:52 -0700)]
[SVGDom] Parse style attributes
Dispatch style-encoded (style="foo: bar; ...") attributes via normal
attribute setters.
R=reed@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2193663002
Review-Url: https://codereview.chromium.org/
2193663002
halcanary [Fri, 29 Jul 2016 15:41:33 +0000 (08:41 -0700)]
SkPDF: flip saveLayer rightside up
Broken in https://skia.googlesource.com/skia/+/4b1e17e
BUG=632574
TBR=tomhudson@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2197623002
Review-Url: https://codereview.chromium.org/
2197623002
mtklein [Fri, 29 Jul 2016 15:35:54 +0000 (08:35 -0700)]
GN: quick doc
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2192203002
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=
2192203002
Review-Url: https://codereview.chromium.org/
2192203002
robertphillips [Fri, 29 Jul 2016 15:28:25 +0000 (08:28 -0700)]
Remove GrContext::applyGamma
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2191323002
Review-Url: https://codereview.chromium.org/
2191323002
csmartdalton [Fri, 29 Jul 2016 15:14:20 +0000 (08:14 -0700)]
Add test configs for instanced rendering
Adds the following configs and enables them on select bots:
glinst, glinst4, glinstdit4, glinst16, glinstdit16,
esinst, esinst4, esinstdit4
Makes general changes to GrContextOptions, GrCaps, etc. to facilitate
this.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2182783004
Review-Url: https://codereview.chromium.org/
2182783004
egdaniel [Fri, 29 Jul 2016 14:36:52 +0000 (07:36 -0700)]
Merge ProgramDesc's for GL and Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184413002
Review-Url: https://codereview.chromium.org/
2184413002
msarett [Fri, 29 Jul 2016 13:23:33 +0000 (06:23 -0700)]
Add color space xform support to SkJpegCodec (includes F16!)
Also changes SkColorXform to support:
RGBA->RGBA
RGBA->BGRA
Instead of:
RGBA->SkPMColor
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2174493002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/
73d55332e2846dd05e9efdaa2f017bcc3872884b
Review-Url: https://codereview.chromium.org/
2174493002
mtklein [Fri, 29 Jul 2016 13:03:52 +0000 (06:03 -0700)]
GN: ccache+clang needs -Qunused-arguments
An alternative is to define CCACHE_CPP2, but
I thought I'd try this more visible way first.
(CCACHE_CPP2 may turn out to be required anyway
if we start seeing warnings about tautological compares.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2193203002
TBR=jcgregorio@google.com
NOTRY=true
Review-Url: https://codereview.chromium.org/
2193203002
mtklein [Fri, 29 Jul 2016 12:39:35 +0000 (05:39 -0700)]
GN: Always quote cc and cxx.
To fix:
ERROR at the command-line "--args":1:34: Unexpected token '+'
is_debug=true cc=clang cxx=clang++
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2193593003
Review-Url: https://codereview.chromium.org/
2193593003
mtklein [Fri, 29 Jul 2016 12:07:39 +0000 (05:07 -0700)]
GN: use ccache if available and the requested compiler.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2186553006
Review-Url: https://codereview.chromium.org/
2186553006
mtklein [Fri, 29 Jul 2016 02:14:07 +0000 (19:14 -0700)]
Add another GM to skip in serialize mode.
See https://luci-milo.appspot.com/swarming/task/
304ced7bada3b310/steps/dm/0/stdout
Also update .json.
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2196543002
Review-Url: https://codereview.chromium.org/
2196543002
msarett [Fri, 29 Jul 2016 00:11:18 +0000 (17:11 -0700)]
Revert of Add color space xform support to SkJpegCodec (includes F16!) (patchset #9 id:260001 of https://codereview.chromium.org/
2174493002/ )
Reason for revert:
Breaking MSAN
Original issue's description:
> Add color space xform support to SkJpegCodec (includes F16!)
>
> Also changes SkColorXform to support:
> RGBA->RGBA
> RGBA->BGRA
>
> Instead of:
> RGBA->SkPMColor
>
> TBR=reed@google.com
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2174493002
> CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
73d55332e2846dd05e9efdaa2f017bcc3872884b
TBR=mtklein@google.com,reed@google.com,herb@google.com,brianosman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2195523002
robertphillips [Thu, 28 Jul 2016 22:17:34 +0000 (15:17 -0700)]
Remove use of MakeRenderTargetDirect from view system
Here is the CL that sent me down the SkGammaColorFilter path
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2178353005
Review-Url: https://codereview.chromium.org/
2178353005
benjaminwagner [Thu, 28 Jul 2016 22:12:21 +0000 (15:12 -0700)]
Update public.bzl based on internal cl/
128616707.
TBR=mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2186373002
Review-Url: https://codereview.chromium.org/
2186373002
msarett [Thu, 28 Jul 2016 22:06:16 +0000 (15:06 -0700)]
Add color space xform support to SkJpegCodec (includes F16!)
Also changes SkColorXform to support:
RGBA->RGBA
RGBA->BGRA
Instead of:
RGBA->SkPMColor
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2174493002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/
2174493002
mtklein [Thu, 28 Jul 2016 21:58:07 +0000 (14:58 -0700)]
Make coverage.py optional for dm and nanobench _flags.py
It is better to test partially than not test at all.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184423002
Review-Url: https://codereview.chromium.org/
2184423002
mtklein [Thu, 28 Jul 2016 21:45:28 +0000 (14:45 -0700)]
Silence -Wclobbered in each file that needs it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184823009
Committed: https://skia.googlesource.com/skia/+/
03f704a343d7a82974f977eda8789a8c721c93e5
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86-Release-Trybot
Review-Url: https://codereview.chromium.org/
2184823009
halcanary [Thu, 28 Jul 2016 21:33:13 +0000 (14:33 -0700)]
SkPDF: drawText makes use of SkPaint.measureText() for alignment.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188303003
Review-Url: https://codereview.chromium.org/
2188303003
reed [Thu, 28 Jul 2016 21:26:13 +0000 (14:26 -0700)]
turn bitmaps into images during recording
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2185563003
Review-Url: https://codereview.chromium.org/
2185563003
mtklein [Thu, 28 Jul 2016 21:17:33 +0000 (14:17 -0700)]
GN: nanobench
Add nanobench, and while we're at it monobench to show off how cool
source_sets are... the bench files are only built once then linked
into both binaries. With GYP we build them twice. :/ Same deal
for GMs between nanobench and DM... build once, link twice.
nanobench uses SkImageEncoder to encode its .pngs, which requires
we link in the image encoders, which requires we get them all in.
That's the bulk of this.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2193513002
Review-Url: https://codereview.chromium.org/
2193513002
mtklein [Thu, 28 Jul 2016 20:59:59 +0000 (13:59 -0700)]
Revert of Silence -Wclobbered in each file that needs it. (patchset #2 id:20001 of https://codereview.chromium.org/
2184823009/ )
Reason for revert:
Jpeg strategy seems to be leading to crashes. Gonna go back to warning squelch.
Original issue's description:
> Silence -Wclobbered in each file that needs it.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184823009
>
> Committed: https://skia.googlesource.com/skia/+/
03f704a343d7a82974f977eda8789a8c721c93e5
TBR=msarett@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2188313003
bsalomon [Thu, 28 Jul 2016 20:37:31 +0000 (13:37 -0700)]
Serialize SkColorSpace into DeferredTextureImage
This fixes a memory leak that occurs when DeferredTextureImage is deallocated without being destroyed. It is intended to be stored in discarable memory and thus this has to be safe.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184823010
Review-Url: https://codereview.chromium.org/
2184823010
mtklein [Thu, 28 Jul 2016 18:57:30 +0000 (11:57 -0700)]
Silence -Wclobbered in each file that needs it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184823009
Review-Url: https://codereview.chromium.org/
2184823009
jcgregorio [Thu, 28 Jul 2016 18:55:51 +0000 (11:55 -0700)]
Fix expectations for GN bot.
BUG=skia:
Review-Url: https://codereview.chromium.org/
2191933002
bsalomon [Thu, 28 Jul 2016 18:49:12 +0000 (11:49 -0700)]
Remove unused render target members from GL and VK sk_app::WindowContext classes
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2191673002
Review-Url: https://codereview.chromium.org/
2191673002
csmartdalton [Thu, 28 Jul 2016 18:48:13 +0000 (11:48 -0700)]
Include NVPR configs in dm runs on TegraX1
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2174353008
Review-Url: https://codereview.chromium.org/
2174353008
mtklein [Thu, 28 Jul 2016 18:42:34 +0000 (11:42 -0700)]
GN: add abbreviated versions of the command line as descriptions.
This should help make the bot logs a little easier to read. (On the console
this wasn't much of a big deal, as Ninja auto-abbreviates when printing to an
interactive console.)
As usual, Ninja will print the full command when a task fails.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188263002
Review-Url: https://codereview.chromium.org/
2188263002
fmenozzi [Thu, 28 Jul 2016 17:59:49 +0000 (10:59 -0700)]
Add HardStopGradientBench_ScaleNumHardStops.cpp
Rename HardStopGradientBench.cpp to HardStopGradientBench_ScaleNumColors.cpp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2178913003
Review-Url: https://codereview.chromium.org/
2178913003
borenet [Thu, 28 Jul 2016 17:50:54 +0000 (10:50 -0700)]
Add swarmbucket_wrapper recipe
BUG=skia:5581
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2185203003
Review-Url: https://codereview.chromium.org/
2185203003
msarett [Thu, 28 Jul 2016 17:47:50 +0000 (10:47 -0700)]
Add writeToMemory() API to SkColorSpace
New API mirrors the form of similar APIs in SkRegion,
SkMatrix, etc.
This also fixes a bug:
SkImageInfo appears in a object that Chrome stores in
discardable memory. So when sk_sp<SkColorSpace> was added
to SkImageInfo a leak was introduced. We'll use this new
method and deserialize to store the SkColorSpace in the
discardable object.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2192903002
Review-Url: https://codereview.chromium.org/
2192903002
mtklein [Thu, 28 Jul 2016 16:58:44 +0000 (09:58 -0700)]
GN: fix mac build again
Hoping to land these using the other GN bots as trybots.
Don't know what magic was letting us get to webp's headers yesterday on Linux. Might have been using /usr/include's ?
The other change is the difference between some setups using #define SK_BUILD_FOR_MAC and others #define SK_BUILD_FOR_MAC 1. We want either to mean "we're Mac".
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2190713004
Review-Url: https://codereview.chromium.org/
2190713004
fmalita [Thu, 28 Jul 2016 16:47:24 +0000 (09:47 -0700)]
SkPaint intercept API for SkTextBlob and horizontal text
Add getPosTextHIntercepts(), getTextBlobIntercepts().
Consolidate the implementation in GetTextIntercepts<> template.
BUG=chormium:581456
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2186663004
Review-Url: https://codereview.chromium.org/
2186663004
mtklein [Thu, 28 Jul 2016 16:45:14 +0000 (09:45 -0700)]
Make both SK_API definition points identical and order independent.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2189983002
Review-Url: https://codereview.chromium.org/
2189983002
jcgregorio [Thu, 28 Jul 2016 16:38:59 +0000 (09:38 -0700)]
recipes: Add a GN flavor.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2189713003
Review-Url: https://codereview.chromium.org/
2189713003
robertphillips [Thu, 28 Jul 2016 16:20:33 +0000 (09:20 -0700)]
Add SkGammaColorFilter
WDYT about this as a means of replacing GrContext::applyGamma with a normal SkCanvas::drawImage?
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2190573002
Review-Url: https://codereview.chromium.org/
2190573002
borenet [Thu, 28 Jul 2016 15:58:38 +0000 (08:58 -0700)]
Fixes for SwarmBucket bot
- Print all build properties for debugging purposes.
- Use correct path root for swarmbucket.
- Write a dummy .gclient file if missing.
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2190933002
Review-Url: https://codereview.chromium.org/
2190933002
dvonbeck [Thu, 28 Jul 2016 15:58:19 +0000 (08:58 -0700)]
Added API for Bevel NormalSource.
This CL adds an API for Bevel normal source and a dummy implementation that returns a normal (0, 0, 1) every time.
This CL's base is the CL for accepting nullptrs: https://codereview.chromium.org/
2132113002
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2080993002
Review-Url: https://codereview.chromium.org/
2080993002
bsalomon [Thu, 28 Jul 2016 15:53:13 +0000 (08:53 -0700)]
Remove unused sk_app::WindowContext::presentRenderSurface
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184273002
Review-Url: https://codereview.chromium.org/
2184273002
egdaniel [Thu, 28 Jul 2016 15:53:07 +0000 (08:53 -0700)]
Don't call finish on GrDrawTarget if we drew no batches
This might give us some minor perf gains in vulkan since we won't be submitting
command buffers that we've added to batch draws to. Running nanobench this does
seem to happen pretty often.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2179903008
Review-Url: https://codereview.chromium.org/
2179903008
tomhudson [Thu, 28 Jul 2016 14:36:28 +0000 (07:36 -0700)]
Revert of align cap hairline first point (patchset #2 id:20001 of https://codereview.chromium.org/
2189583003/ )
Reason for revert:
Speculative revert in case this is blocking our roll.
Original issue's description:
> align cap hairline first point
>
> Hairlines with square caps move the endpoints out by 1/2 pixel.
> The last point needs to be the first adjusted point, instead
> of the point supplied to move to.
>
> R=fmalita@chromium.org
> TBR=reed@google.com
> BUG=617658
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2189583003
>
> Committed: https://skia.googlesource.com/skia/+/
52f85d4d09b815fce6bfe296a1dd2cbf8d792f05
TBR=fmalita@chromium.org,reed@google.com,caryclark@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617658
Review-Url: https://codereview.chromium.org/
2188483007
mtklein [Wed, 27 Jul 2016 21:59:08 +0000 (14:59 -0700)]
Turn on flags to enforce SK_API.
These flags hide symbols that are not marked with SK_API when linked into a
shared library. There's nominally no effect on static linking, but I'm
pretty sure the Mac linker takes some advantage of this too to run faster.
This makes component-build DM no longer link: it uses many non SK_API APIs.
Fiddle in contrast is just fine with our public APIs, so no need to restrict that.
It'll be fun finding out which of our other tools go which ways.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2180383003
Review-Url: https://codereview.chromium.org/
2180383003
halcanary [Wed, 27 Jul 2016 21:49:46 +0000 (14:49 -0700)]
SkPdf: SkPDFFormXObject de-class-ified.
We don't need an object, just a few standard fields on the
base class; the change lets us get rid of a bunch of
boilerplate code.
I think this also reduces the cognitive load of the SkPDF
internals.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2185803003
Review-Url: https://codereview.chromium.org/
2185803003
jcgregorio [Wed, 27 Jul 2016 21:34:06 +0000 (14:34 -0700)]
upload_bench_results - fix GS upload path.
_UploadJSONResults does '/'.join() so the trailing / is unnecessary.
BUG=skia:
R=borenet
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187903003
Review-Url: https://codereview.chromium.org/
2187903003
jvanverth [Wed, 27 Jul 2016 21:29:18 +0000 (14:29 -0700)]
Enable backend switching for Windows Viewer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184163003
Review-Url: https://codereview.chromium.org/
2184163003
halcanary [Wed, 27 Jul 2016 21:14:04 +0000 (14:14 -0700)]
SkPDF: refactor font subset: fewer copies
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2190643002
Review-Url: https://codereview.chromium.org/
2190643002
borenet [Wed, 27 Jul 2016 21:05:54 +0000 (14:05 -0700)]
Fix silently-failing compile
Ouch...
TBR=rmistry
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2191663002
Review-Url: https://codereview.chromium.org/
2191663002
mtklein [Wed, 27 Jul 2016 20:55:26 +0000 (13:55 -0700)]
GN: dm
This builds, links, and runs on Linux. Have not tried Mac.
I've tested is_debug={true,false} and is_component_build.
It's neat that the component build DM works, but it's also an indication I've missed an essential flag or two... it shouldn't work. :)
The GPU backend isn't working yet, but all the software configurations I've tried look good.
This fleshes out all the other parts of SkCodec too... I noticed we weren't able to decode gifs or webp.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188643002
Review-Url: https://codereview.chromium.org/
2188643002
msarett [Wed, 27 Jul 2016 20:51:46 +0000 (13:51 -0700)]
Expose more gamma info for UMA statistics
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188633003
Review-Url: https://codereview.chromium.org/
2188633003
csmartdalton [Wed, 27 Jul 2016 20:22:27 +0000 (13:22 -0700)]
Fix GrDrawContextPriv::stencilRect
Updates stencilRect to call drawNonAAFilledRect instead of
drawFilledRect. drawFilledRect can use coverage AA, which isn't
appropriate for stencil draws. Also modifies drawNonAAFilledRect to
take a "useHWAA" argument instead of trying to deduce whether it
should be used.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187583002
Review-Url: https://codereview.chromium.org/
2187583002
kjlubick [Wed, 27 Jul 2016 19:59:12 +0000 (12:59 -0700)]
Add Vulkan runtime dll
This gets copied into the out/ dir on compile and allows dm.exe to run anywhere, even if the Vulkan SDK is not installed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188543002
Review-Url: https://codereview.chromium.org/
2188543002
caryclark [Wed, 27 Jul 2016 19:50:09 +0000 (12:50 -0700)]
align cap hairline first point
Hairlines with square caps move the endpoints out by 1/2 pixel.
The last point needs to be the first adjusted point, instead
of the point supplied to move to.
R=fmalita@chromium.org
TBR=reed@google.com
BUG=617658
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2189583003
Review-Url: https://codereview.chromium.org/
2189583003
borenet [Wed, 27 Jul 2016 19:45:35 +0000 (12:45 -0700)]
Make the experimental SwarmBucket bot use the SkiaTriggers pool
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187023002
Review-Url: https://codereview.chromium.org/
2187023002
halcanary [Wed, 27 Jul 2016 19:28:55 +0000 (12:28 -0700)]
DEPS: sfntly 468cad5 → b18b09b
SfntlyWrapper::SubsetFont now takes TTC index, needed for SkPDF.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2186103002
Review-Url: https://codereview.chromium.org/
2186103002
robertphillips [Wed, 27 Jul 2016 19:13:51 +0000 (12:13 -0700)]
Rename GrContext's newDrawContext & drawContext to makeDrawContext
These both return sk_sp.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2186073002
Review-Url: https://codereview.chromium.org/
2186073002
bsalomon [Wed, 27 Jul 2016 19:07:43 +0000 (12:07 -0700)]
Make the yasm copy target be type 'none' rather than type 'executable'
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2182873005
Review-Url: https://codereview.chromium.org/
2182873005
caryclark [Wed, 27 Jul 2016 19:02:07 +0000 (12:02 -0700)]
require semi at the end of SkASSERT and friends
R=bungeman@google.com
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2185063002
Review-Url: https://codereview.chromium.org/
2185063002
mtklein [Wed, 27 Jul 2016 18:17:18 +0000 (11:17 -0700)]
GN: fixes for Mac
- Make fiddle build on Mac (skipping GL).
- Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
- Re-arrange third_party a bit so that our targets are Fuchsia/Chrome compatible.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184133002
NOTREECHECKS=true
This doesn't affect Chrome/Blink, so landing through the closed tree.
Review-Url: https://codereview.chromium.org/
2184133002
halcanary [Wed, 27 Jul 2016 18:12:23 +0000 (11:12 -0700)]
SkPDF: SkPDFStream takes a unique_ptr
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188623004
Review-Url: https://codereview.chromium.org/
2188623004
benjaminwagner [Wed, 27 Jul 2016 18:12:12 +0000 (11:12 -0700)]
Rename textual includes as *.inc.
This makes it easier to distinguish source files that can stand on their own vs files meant to be #included into other source files.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184143002
Review-Url: https://codereview.chromium.org/
2184143002
halcanary [Wed, 27 Jul 2016 17:13:25 +0000 (10:13 -0700)]
DEPS: ICU c291cde → ec9c113
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2189643003
Review-Url: https://codereview.chromium.org/
2189643003
halcanary [Wed, 27 Jul 2016 17:08:39 +0000 (10:08 -0700)]
DEPS: harfbuzz 1.2.7 → 1.3.0
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2179963005
Review-Url: https://codereview.chromium.org/
2179963005
halcanary [Wed, 27 Jul 2016 17:08:18 +0000 (10:08 -0700)]
DEPS: sfntly 130f832 → 468cad5
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2189643002
Review-Url: https://codereview.chromium.org/
2189643002
borenet [Wed, 27 Jul 2016 16:36:17 +0000 (09:36 -0700)]
Include "revision" tag for all Swarming tasks
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2186993002
Review-Url: https://codereview.chromium.org/
2186993002
brianosman [Wed, 27 Jul 2016 16:21:51 +0000 (09:21 -0700)]
Fix ParseConfigs_ViaParsing test when skia_angle=1
The handling of angle-gl changes with SK_ANGLE. We don't have any bots
that test this particular combination, but I see it all the time while
running DM for other things.
Previously considered changing things so that the config parsing results
are consistent, regardless of GYP_DEFINES, but this is much simpler (and
more consistent with the other code we already have for testing config
parsing).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2183323004
Review-Url: https://codereview.chromium.org/
2183323004
bsalomon [Wed, 27 Jul 2016 15:58:31 +0000 (08:58 -0700)]
Fix leak of srgb/adobesrgb colorspace objects
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2185043002
Review-Url: https://codereview.chromium.org/
2185043002
borenet [Wed, 27 Jul 2016 15:51:55 +0000 (08:51 -0700)]
Fix Perf data upload
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187603005
Review-Url: https://codereview.chromium.org/
2187603005
bsalomon [Wed, 27 Jul 2016 15:50:12 +0000 (08:50 -0700)]
SW backend for viewer on Windows
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2182273002
Review-Url: https://codereview.chromium.org/
2182273002
caryclark [Wed, 27 Jul 2016 15:46:10 +0000 (08:46 -0700)]
fuzz wednesday
Add debug 'skip assert' access to SkCoincidentSpans.
That permits suppressing asserts to make it easier
to detect when this fuzz data generates unparsable
data.
TBR=reed@google.com
BUG=631564, 631992
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2186973002
Review-Url: https://codereview.chromium.org/
2186973002
mtklein [Wed, 27 Jul 2016 15:40:45 +0000 (08:40 -0700)]
Clean up some unused atomic routines.
AtomicTest was the only use of sk_atomic_add().
AtomicInc64 bench was the only use of sk_atomic_inc(int64_t*).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2183473005
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot
Review-Url: https://codereview.chromium.org/
2183473005
egdaniel [Wed, 27 Jul 2016 15:03:57 +0000 (08:03 -0700)]
Add gyp define to enable vulkan debug layers
On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.
With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.
TBR=djsollen@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2185953003
Review-Url: https://codereview.chromium.org/
2185953003
borenet [Wed, 27 Jul 2016 14:02:08 +0000 (07:02 -0700)]
Tweaks for the experimental SwarmBucket bot
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2181073005
Review-Url: https://codereview.chromium.org/
2181073005
mtklein [Wed, 27 Jul 2016 12:35:28 +0000 (05:35 -0700)]
Extend __mulodi4() hack to 32-bit x86.
This gets the Android-Clang-x86 perf bot from failing on __mulodi4() to failing on the next problem...
See https://luci-milo.appspot.com/swarming/task/
3042e5f68636f810/steps/nanobench/0/stdout
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2190493002
Review-Url: https://codereview.chromium.org/
2190493002
brianosman [Wed, 27 Jul 2016 12:25:26 +0000 (05:25 -0700)]
Simplify color space xform storage and usage (float[] vs. SkMatrix44)
Public API is really just internal.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2185533005
TBR=bsalomon@google.com
Review-Url: https://codereview.chromium.org/
2185533005
borenet [Wed, 27 Jul 2016 12:21:45 +0000 (05:21 -0700)]
Fix Housekeeper-PerCommit
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2183023004
Review-Url: https://codereview.chromium.org/
2183023004
mtklein [Wed, 27 Jul 2016 11:14:07 +0000 (04:14 -0700)]
Only run recipe simulation tests if infra/ changes.
This should lessen the need for mortals to have coverage.py,
and saves 1.8s (of 3.6s) on my desktop for this non-infra change.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187713002
Review-Url: https://codereview.chromium.org/
2187713002
reed [Wed, 27 Jul 2016 02:42:04 +0000 (19:42 -0700)]
add unittests for roundtripping premul
BUG=skia:5579
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2179123005
Review-Url: https://codereview.chromium.org/
2179123005
fmalita [Wed, 27 Jul 2016 01:46:34 +0000 (18:46 -0700)]
Initial SVG model
A minimal subset needed to render tiger.svg: <svg>, <g>, <path>, 'd', 'fill'/'stroke' (color-only), 'transform'.
R=reed@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164193002
Review-Url: https://codereview.chromium.org/
2164193002
csmartdalton [Wed, 27 Jul 2016 00:05:47 +0000 (17:05 -0700)]
Implement coverage AA for skewed rects with local coords
Adds a path fallback for rects with local coords that can't be drawn
with an analytic shader. This is accomplished by modifying the view
matrix and then drawing the local rect/quad.
BUG=skia:5500, 7508
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2183223002
Review-Url: https://codereview.chromium.org/
2183223002
jcgregorio [Tue, 26 Jul 2016 21:10:17 +0000 (14:10 -0700)]
Avoid warnings on GCC 4.8.4
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2183243002
[mtklein adds...]
TBR=reed@google.com
No public API changes.
Review-Url: https://codereview.chromium.org/
2183243002
mtklein [Tue, 26 Jul 2016 20:55:45 +0000 (13:55 -0700)]
Start on fiddle.
Mostly stolen from Joe.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188493002
Review-Url: https://codereview.chromium.org/
2188493002
msarett [Tue, 26 Jul 2016 20:46:15 +0000 (13:46 -0700)]
Make yasm-android executable
TBR=mtklein@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188583002
Review-Url: https://codereview.chromium.org/
2188583002
msarett [Tue, 26 Jul 2016 20:33:46 +0000 (13:33 -0700)]
Rename yasm binary and make it executable
TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187663002
Review-Url: https://codereview.chromium.org/
2187663002
jvanverth [Tue, 26 Jul 2016 20:33:07 +0000 (13:33 -0700)]
Update iOS to new SkSurface interface
BUG=skia:5558
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2179363003
Review-Url: https://codereview.chromium.org/
2179363003
mtklein [Tue, 26 Jul 2016 20:05:30 +0000 (13:05 -0700)]
Start measuring f16 and srgb speed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2181073003
Review-Url: https://codereview.chromium.org/
2181073003
bsalomon [Tue, 26 Jul 2016 19:56:32 +0000 (12:56 -0700)]
Add sw support to viewer on Linux.
This doesn't yet do anything with srgb/colorspace.
Replaces the --vulkan flag with --backend which takes 'gl', 'vk', or 'sw'.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2165813002
Review-Url: https://codereview.chromium.org/
2165813002
mtklein [Tue, 26 Jul 2016 19:41:27 +0000 (12:41 -0700)]
Move SkJSONCPP.h to tools. It tool-only.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2184483003
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
TBR=reed@google.com
Review-Url: https://codereview.chromium.org/
2184483003
reed [Tue, 26 Jul 2016 19:21:10 +0000 (12:21 -0700)]
don't specialize drawBitmapRect for minirecorder; no longer called by blink
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2183193002
Review-Url: https://codereview.chromium.org/
2183193002
bsalomon [Tue, 26 Jul 2016 19:02:50 +0000 (12:02 -0700)]
Use Windowing system-specific WindowContext factories.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2169543002
Review-Url: https://codereview.chromium.org/
2169543002
borenet [Tue, 26 Jul 2016 18:52:17 +0000 (11:52 -0700)]
Move Skia recipes from build repo
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2175373002
Review-Url: https://codereview.chromium.org/
2175373002
robertphillips [Tue, 26 Jul 2016 18:38:17 +0000 (11:38 -0700)]
Reduce usage of MakeRenderTargetDirect
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187573002
Review-Url: https://codereview.chromium.org/
2187573002
brianosman [Tue, 26 Jul 2016 18:36:05 +0000 (11:36 -0700)]
Remove SkSurfaceProps gamma-correctness flag entirely.
This is no longer required - gamma-correctness is now just based on the
presence or absence of a color space.
Public API change is just removal of (unused) flag.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2188463002
TBR=bsalomon@google.com
Review-Url: https://codereview.chromium.org/
2188463002
msarett [Tue, 26 Jul 2016 18:24:28 +0000 (11:24 -0700)]
Fix yasm for Android build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2180333002
Review-Url: https://codereview.chromium.org/
2180333002
borenet [Tue, 26 Jul 2016 18:11:50 +0000 (11:11 -0700)]
Fix docs for checking out Skia
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2179023003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
2179023003
Review-Url: https://codereview.chromium.org/
2179023003