commit-bot@chromium.org [Mon, 21 Oct 2013 15:59:26 +0000 (15:59 +0000)]
Magnifier gpu path fix
The y axis was inverted for the offset, which should have been computed on the other side of the magnifying rectangle.
BUG=
R=bsalomon@google.com, senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
28273005
git-svn-id: http://skia.googlecode.com/svn/trunk@11883
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 21 Oct 2013 15:41:55 +0000 (15:41 +0000)]
First round of matrixconvolution rebaselines.
TBR=robertphillips
Review URL: https://codereview.chromium.org/
32823002
git-svn-id: http://skia.googlecode.com/svn/trunk@11882
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 21 Oct 2013 14:48:23 +0000 (14:48 +0000)]
Fix GrProgramsTest to not generate tests with too many TexCoord references
Make GrProgramsTest check how many texture coordinate sets are
available and select random effects up until the amount runs out.
Otherwise, following effect sequence would fail the shader compilation
when Skia is compiled with nv_path_rendering on (eg. when fixed
function codepath is used):
* Stage 0: TextureDomain (1 texcoord)
* Stage 1: Convolution (1 texcoord)
* Stage 2: Bitmap Alpha Threshold (2 texcoords)
* Stage 3: DisplacementMap (2 texcoords)
* Stage 4: Config Conversion (1 texcoords)
* Stage 5: Two-Point Conical Gradient (2 texcoords)
This would use more texture coordinate sets than 8, which is fairly
common amount currently.
R=bsalomon@google.com, cdalton@nvidia.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
32403002
git-svn-id: http://skia.googlecode.com/svn/trunk@11881
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 21 Oct 2013 14:48:17 +0000 (14:48 +0000)]
Apply matrix early in draw bitmap
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
30593003
git-svn-id: http://skia.googlecode.com/svn/trunk@11880
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 Oct 2013 14:31:20 +0000 (14:31 +0000)]
scope ComputeIsOpaque with SkBitmap
BUG=
Review URL: https://codereview.chromium.org/
32653002
git-svn-id: http://skia.googlecode.com/svn/trunk@11879
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 Oct 2013 14:12:13 +0000 (14:12 +0000)]
change ERROR label to BAD_CONFIG -- avoid windows complaint
BUG=
Review URL: https://codereview.chromium.org/
32623002
git-svn-id: http://skia.googlecode.com/svn/trunk@11878
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 Oct 2013 14:00:07 +0000 (14:00 +0000)]
store SkAlphaType inside SkBitmap, on road to support unpremul
BUG=
R=bsalomon@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
25275004
git-svn-id: http://skia.googlecode.com/svn/trunk@11877
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 21 Oct 2013 12:26:10 +0000 (12:26 +0000)]
Reverting revert of r11862 (Constify SkFlattenable::getFactory()) or reverting r11871.
git-svn-id: http://skia.googlecode.com/svn/trunk@11876
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 21 Oct 2013 00:15:15 +0000 (00:15 +0000)]
A few stragglers for r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/
31333002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11875
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 20 Oct 2013 23:53:11 +0000 (23:53 +0000)]
More rebaselines for r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/
31323002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11874
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 20 Oct 2013 23:06:40 +0000 (23:06 +0000)]
rebaselines after r1187 (Fix cubic->quad RR corner regression)
https://codereview.chromium.org/
31313002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11873
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Sun, 20 Oct 2013 20:21:19 +0000 (20:21 +0000)]
Fix for cropped matrix convolution for BottomLeft render targets.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
31083002
git-svn-id: http://skia.googlecode.com/svn/trunk@11872
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 20 Oct 2013 13:34:21 +0000 (13:34 +0000)]
Reverted due to Chromium compilation failures. Please see:
https://codereview.chromium.org/
30973002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11871
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 20 Oct 2013 13:11:16 +0000 (13:11 +0000)]
Fix cubic->quad RR corner regression
https://codereview.chromium.org/
29673002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11870
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 19 Oct 2013 07:02:35 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11869
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 18 Oct 2013 21:04:51 +0000 (21:04 +0000)]
Revert "[PDF] Add unpremultiply support and a GM (try3)."
This is crashing in some configurations, can now repro.
This reverts commit
12add177d0ab7bbac97f5093c9382924d88bde8c.
Review URL: https://codereview.chromium.org/
29903002
git-svn-id: http://skia.googlecode.com/svn/trunk@11868
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 18 Oct 2013 20:52:44 +0000 (20:52 +0000)]
DM: add --writePath
For fun, make the output prettier, hiding ", N failures" unless there is one.
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
29293003
git-svn-id: http://skia.googlecode.com/svn/trunk@11867
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 18 Oct 2013 20:18:29 +0000 (20:18 +0000)]
[PDF] Add unpremultiply support and a GM (try3).
This is a resubmit of https://codereview.chromium.org/
22831039 which was
reverted because it causes issues on Windows.
BUG=chromium:175548
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
29193003
git-svn-id: http://skia.googlecode.com/svn/trunk@11866
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 18 Oct 2013 20:16:34 +0000 (20:16 +0000)]
Revert "PDF: support perspective in simple shaders. (this version does not work well with tilling)"
Accidentally committed the wrong git branch.
This reverts commit
76839c65670df8a863041a82a4b61502e78af043.
Review URL: https://codereview.chromium.org/
29743002
git-svn-id: http://skia.googlecode.com/svn/trunk@11865
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 18 Oct 2013 20:14:08 +0000 (20:14 +0000)]
PDF: support perspective in simple shaders. (this version does not work well with tilling)
Review URL: https://codereview.chromium.org/
26389006
git-svn-id: http://skia.googlecode.com/svn/trunk@11864
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 18 Oct 2013 20:08:14 +0000 (20:08 +0000)]
Implement crop rect support for SkMatrixConvolutionImageFilter.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
27471002
git-svn-id: http://skia.googlecode.com/svn/trunk@11863
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 18 Oct 2013 19:37:55 +0000 (19:37 +0000)]
Constify SkFlattenable::getFactory().
This allows us to also constify the argument of
SkFlattenableWriteBuffer::writeFlattenable() - which I've recently found
myself const-casting for no apparent good reason.
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
29143005
git-svn-id: http://skia.googlecode.com/svn/trunk@11862
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 18 Oct 2013 18:36:25 +0000 (18:36 +0000)]
Revert r11860, which was supposed to just be a whitespace change (argh)
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
29603002
git-svn-id: http://skia.googlecode.com/svn/trunk@11861
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 18 Oct 2013 18:33:03 +0000 (18:33 +0000)]
Whitespace change to trigger buildbots after https://code.google.com/p/skia/source/detail?r=11859
git-svn-id: http://skia.googlecode.com/svn/trunk@11860
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 18 Oct 2013 16:10:03 +0000 (16:10 +0000)]
Revert "[PDF] Add unpremultiply support and a GM."
This reverts commit
f746273b8ba282f548a6eaffb45b11b6f468aa8e.
Review URL: https://codereview.chromium.org/
29343002
git-svn-id: http://skia.googlecode.com/svn/trunk@11858
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 18 Oct 2013 15:53:03 +0000 (15:53 +0000)]
[PDF] Add unpremultiply support and a GM.
This is a resubmit of https://codereview.chromium.org/
22831039 which was
reverted because it causes issues on Windows.
BUG=chromium:175548
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
27518003
git-svn-id: http://skia.googlecode.com/svn/trunk@11857
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 18 Oct 2013 15:47:28 +0000 (15:47 +0000)]
rebaseline gpu complex clip tests
Review URL: https://codereview.chromium.org/
29303002
git-svn-id: http://skia.googlecode.com/svn/trunk@11856
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 18 Oct 2013 14:55:47 +0000 (14:55 +0000)]
GM: add --ignoreFailuresFile as an alternative to --ignoreTests
(moved from old review at https://codereview.chromium.org/
27752002/ )
This will allow the user to specify the tests to ignore failure on as a file,
rather than listing them out in the command line (and thus busting the
line length limit on Android).
BUG=skia:1730
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
29203002
git-svn-id: http://skia.googlecode.com/svn/trunk@11855
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 18 Oct 2013 14:19:19 +0000 (14:19 +0000)]
SkThreadPool: allow for Runnables that add other Runnables to the pool.
There's a scenario that we're currently not allowing for, but I'd really like to use in DM:
1) client calls add(SomeRunnable*) several times
2) client calls wait()
3) any of the runnables added by the client _themselves_ call add(SomeOtherRunnable*)
4-inf) maybe those SomeOtherRunnables too call add(SomeCrazyThirdRunnable*), etc.
Right now in this scenario we'll assert in debug mode in step 3) when we call
add() and we're waiting to stop, and do strange unspecified things in release
mode.
The old threadpool had basically two states: running, and waiting to stop. If
a thread saw we were waiting to stop and the queue was empty, that thread shut
down. This wasn't accounting for any work that other threads might be doing;
potentially they were about to add to the queue.
So now we have three states: running, waiting, and halting. When the client
calls wait() (or the destructor triggers), we move into waiting. When a thread
notices we're _really_ done, that is, have an empty queue and there are no
active threads, we move into halting. The halting state actually triggers the
threads to stop, which wait() is patiently join()ing on.
BUG=
R=bungeman@google.com, bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
26389005
git-svn-id: http://skia.googlecode.com/svn/trunk@11852
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 18 Oct 2013 07:01:59 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11850
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 17 Oct 2013 19:35:09 +0000 (19:35 +0000)]
Make SkImageFilter::asNewEffect() (and all derived-class overrides) protected.
R=bsalomon@google.com, bsalomon
Review URL: https://codereview.chromium.org/
26937006
git-svn-id: http://skia.googlecode.com/svn/trunk@11847
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 17:56:10 +0000 (17:56 +0000)]
Add texture filtering override to debugger
https://codereview.chromium.org/
27716003/
git-svn-id: http://skia.googlecode.com/svn/trunk@11846
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 17:34:20 +0000 (17:34 +0000)]
Revert r11842 (call drawRect to try GrAARectRenderer if the path is a rect - https://codereview.chromium.org/
23484007) due to changes to the following GM images:
inverse_paths
pathopsinverse
git-svn-id: http://skia.googlecode.com/svn/trunk@11845
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Oct 2013 16:29:41 +0000 (16:29 +0000)]
Add support for GL_CHROMIUM_renderbuffer_format_BGRA8888
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
27525006
git-svn-id: http://skia.googlecode.com/svn/trunk@11844
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Oct 2013 16:29:34 +0000 (16:29 +0000)]
ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs
Xfermode: NEON implementation of SIMD procs
This patch contains a NEON implementation for a number of Xfermodes.
It provides a big speedup on Xfermode benchmarks (currently up to 3x
with gcc4.7 but up to 10x when gcc produces optimal code for it).
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=11777
Committed: http://code.google.com/p/skia/source/detail?r=11813
R=djsollen@google.com, mtklein@google.com, reed@google.com, robertphillips@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/
26627004
git-svn-id: http://skia.googlecode.com/svn/trunk@11843
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 17 Oct 2013 16:29:21 +0000 (16:29 +0000)]
If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance.
R=bsalomon@google.com, robertphillips@google.com, reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
23484007
git-svn-id: http://skia.googlecode.com/svn/trunk@11842
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 16:29:25 +0000 (16:29 +0000)]
Disable r11835 (Replace cubic round rect corners with quads) due to performance regression
git-svn-id: http://skia.googlecode.com/svn/trunk@11841
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 16:28:11 +0000 (16:28 +0000)]
Revert 11839 (rebaseline images after r11835) due to performance regression in 11835
git-svn-id: http://skia.googlecode.com/svn/trunk@11840
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 15:23:26 +0000 (15:23 +0000)]
rebaseline images after r11835
https://codereview.chromium.org/
27722002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11839
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 13:17:04 +0000 (13:17 +0000)]
Added nested_bw to suppression list
git-svn-id: http://skia.googlecode.com/svn/trunk@11838
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Thu, 17 Oct 2013 12:34:54 +0000 (12:34 +0000)]
rebaseline stragglers from repeated radial gradient tweak
BUG=
Review URL: https://codereview.chromium.org/
27700002
git-svn-id: http://skia.googlecode.com/svn/trunk@11837
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 12:27:55 +0000 (12:27 +0000)]
Fix typo in ignored-tests file
git-svn-id: http://skia.googlecode.com/svn/trunk@11836
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 12:17:27 +0000 (12:17 +0000)]
Replace cubic round rect corners with quads
https://codereview.chromium.org/
26372006/
git-svn-id: http://skia.googlecode.com/svn/trunk@11835
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 17 Oct 2013 07:02:33 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11834
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 17 Oct 2013 00:09:17 +0000 (00:09 +0000)]
Reverting r11813 (ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs - https://codereview.chromium.org/
26627004) due to Chromium compilation faliures.
git-svn-id: http://skia.googlecode.com/svn/trunk@11833
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Oct 2013 21:27:18 +0000 (21:27 +0000)]
Initial baselines for skbug1719
Review URL: https://codereview.chromium.org/
27212004
git-svn-id: http://skia.googlecode.com/svn/trunk@11832
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 16 Oct 2013 21:23:18 +0000 (21:23 +0000)]
tools/rebaseline.py --tests xfermodes3 drawbitmaprect scaled_tilemode_gradient tilemode_gradient
BUG=
Review URL: https://codereview.chromium.org/
26233006
git-svn-id: http://skia.googlecode.com/svn/trunk@11831
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Oct 2013 20:45:00 +0000 (20:45 +0000)]
update drawbitmap gm (part 2)
Review URL: https://codereview.chromium.org/
26435005
git-svn-id: http://skia.googlecode.com/svn/trunk@11830
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Oct 2013 19:49:17 +0000 (19:49 +0000)]
Updates to SkPDFDevice and SkDocument classes.
Update the SkDocument interface to allow for 1) abort won't emit pdf, 2) close can report success/failure, 3) SkCanvasSimplifier interface that will be used to simplify perspective for SkpDFDevice, 4) prepare to deprecate SkPDFDevice constructor, and route gm and render_pdfs to use SkDocument::Create pdf interface instead. modified: gm/gmmain.cpp modified: gyp/core.gyp modified: gyp/core.gypi new file: include/core/SkCanvasSimplifier.h modified: include/core/SkDocument.h new file: include/pdf/SkPDFCallbacks.h modified: include/pdf/SkPDFDevice.h new file: src/core/SkCanvasSimplifier.cpp modified: src/doc/SkDocument.cpp modified: src/doc/SkDocument_PDF.cpp modified: src/pdf/SkPDFDevice.cpp modified: src/pdf/SkPDFShader.cpp modified: src/utils/SkLua.cpp modified: tools/PdfRenderer.cpp modified: tools/PdfRenderer.h modified: tools/render_pdfs_main.cpp modified: tools/skhello.cpp
BUG=
Review URL: https://codereview.chromium.org/
24615006
git-svn-id: http://skia.googlecode.com/svn/trunk@11829
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 16 Oct 2013 19:34:27 +0000 (19:34 +0000)]
Build fix fo windows only
Build fix
git-svn-id: http://skia.googlecode.com/svn/trunk@11828
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@google.com [Wed, 16 Oct 2013 19:14:42 +0000 (19:14 +0000)]
Build fix for chromium shared component build
BUG=304265
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
27082003
git-svn-id: http://skia.googlecode.com/svn/trunk@11827
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 19:13:38 +0000 (19:13 +0000)]
DM: duh, don't calculate digests unless we're going to look at them.
This doesn't cut the runtime significantly (~6s either way) but it does cut the CPU time down from ~10s to ~6s.
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
27476007
git-svn-id: http://skia.googlecode.com/svn/trunk@11826
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Oct 2013 19:13:29 +0000 (19:13 +0000)]
catch the other case where we need to see if fScaledBitmap.lockPixels() might have failed
2nd-half clone of https://codereview.chromium.org/
26273006/
BUG=chromium:295895
Review URL: https://codereview.chromium.org/
26973006
git-svn-id: http://skia.googlecode.com/svn/trunk@11825
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 18:59:44 +0000 (18:59 +0000)]
Clear out SK_SCALAR_IS_FLOAT from SkRadialGradient, and merge the logic for radial_mirror and radial_repeat.
New radial/repeated bench is 10-20x faster now using float instead of fixed; the rest are unaffected.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
26410003
git-svn-id: http://skia.googlecode.com/svn/trunk@11824
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 16 Oct 2013 18:36:49 +0000 (18:36 +0000)]
add initial support ofr multi-threaded execution
Review URL: https://codereview.chromium.org/
27541003
git-svn-id: http://skia.googlecode.com/svn/trunk@11823
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 16 Oct 2013 18:32:35 +0000 (18:32 +0000)]
Implement perspective for bitmaps in pdf.
R=vandebo@chromium.org
Review URL: https://codereview.chromium.org/
27236007
git-svn-id: http://skia.googlecode.com/svn/trunk@11822
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 18:21:03 +0000 (18:21 +0000)]
Fix DM build failures:
- forgot tool_main;
- skip building where skia_gpu is false;
- lots of scalar -> int warnings;
- stray return on a void method;
- stifle warning about a uint32_t cast to bool
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
26468005
git-svn-id: http://skia.googlecode.com/svn/trunk@11821
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 16 Oct 2013 18:15:34 +0000 (18:15 +0000)]
Split out GrBitmapTextContext from GrTextContext.
This is a stepping stone to having a variety of different text context types
(bitmaps, distance fields, NV path rendering).
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
27199002
git-svn-id: http://skia.googlecode.com/svn/trunk@11820
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 16 Oct 2013 18:07:48 +0000 (18:07 +0000)]
Make CropRect immutable after construction.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
27490005
git-svn-id: http://skia.googlecode.com/svn/trunk@11819
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 16 Oct 2013 17:53:18 +0000 (17:53 +0000)]
Add display of filterLevel to debugger
https://codereview.chromium.org/
27525002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11818
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 16 Oct 2013 17:48:11 +0000 (17:48 +0000)]
Third wave of Win64 warning cleanup
https://codereview.chromium.org/
27487003/
git-svn-id: http://skia.googlecode.com/svn/trunk@11817
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Oct 2013 17:34:17 +0000 (17:34 +0000)]
check of fScaledBitmap failed to lock
BUG=
Review URL: https://codereview.chromium.org/
27530003
git-svn-id: http://skia.googlecode.com/svn/trunk@11816
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 17:02:28 +0000 (17:02 +0000)]
Remove unused header SkImageTypes.h
R=reed@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
27281003
git-svn-id: http://skia.googlecode.com/svn/trunk@11815
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 16 Oct 2013 16:25:21 +0000 (16:25 +0000)]
More displacement GM rebaselines. Also remove displacement from ignored-tests.txt, since it should now be passing on all platforms.
TBR=
Review URL: https://codereview.chromium.org/
27533003
git-svn-id: http://skia.googlecode.com/svn/trunk@11814
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 16:24:08 +0000 (16:24 +0000)]
ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs
Xfermode: NEON implementation of SIMD procs
This patch contains a NEON implementation for a number of Xfermodes.
It provides a big speedup on Xfermode benchmarks (currently up to 3x
with gcc4.7 but up to 10x when gcc produces optimal code for it).
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=11777
R=djsollen@google.com, mtklein@google.com, reed@google.com, robertphillips@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/
26627004
git-svn-id: http://skia.googlecode.com/svn/trunk@11813
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 16 Oct 2013 15:46:00 +0000 (15:46 +0000)]
Remove support for SK_CROP_RECT_IS_INT, now that it is no longer used in Blink or Chrome.
BUG=
R=reed@google.com, reed
Review URL: https://codereview.chromium.org/
27521002
git-svn-id: http://skia.googlecode.com/svn/trunk@11812
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 15:15:58 +0000 (15:15 +0000)]
Add hooks for external run-time reference adoption checks to SkRefCnt.
The reference adoption checks are to help detect memory
leaks and bad usage when using SkRefCnt subclasses with
Blink's RefPtr.
BUG=crbug.com/304265
R=reed@google.com, bungeman@google.com
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
25432003
git-svn-id: http://skia.googlecode.com/svn/trunk@11811
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Oct 2013 15:14:04 +0000 (15:14 +0000)]
add disabled tests, in pref for experimental isRect behavior
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
27513003
git-svn-id: http://skia.googlecode.com/svn/trunk@11810
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Oct 2013 15:10:45 +0000 (15:10 +0000)]
Add --add-ignored option to rebaseline.py
R=senorblanco@chromium.org, epoger@google.com
BUG=skia:1600
Review URL: https://codereview.chromium.org/
27517002
git-svn-id: http://skia.googlecode.com/svn/trunk@11809
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 16 Oct 2013 15:00:11 +0000 (15:00 +0000)]
Update skpdiff to include a name with each file.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
27512002
git-svn-id: http://skia.googlecode.com/svn/trunk@11808
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 14:43:12 +0000 (14:43 +0000)]
Make sure attribute indexes are correct after restoring vertex attributes
Fix an assert due to
GrDrawState::CommonState::fFixedFunctionVertexAttribIndices getting
out of sync. The assertion in GrDrawState::CommonState::operator==
would fire after using AutoVertexAttribRestore.
AutoVertexAttribRestore would change GrDrawState::fCommon.fVAPtr and
fVACount without updating
GrDrawState::fCommon.fFixedFunctionVertexAttribIndices.
R=jvanverth@google.com, bsalomon@google.com, robertphillips@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
26922004
git-svn-id: http://skia.googlecode.com/svn/trunk@11807
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 16 Oct 2013 14:15:32 +0000 (14:15 +0000)]
Rebaseline complexclip tests on GPU and remove them from ignored-tests
Review URL: https://codereview.chromium.org/
27515002
git-svn-id: http://skia.googlecode.com/svn/trunk@11806
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 13:53:54 +0000 (13:53 +0000)]
detach blur result texture when it is the same texture used to render path mask
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
26968006
git-svn-id: http://skia.googlecode.com/svn/trunk@11805
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 16 Oct 2013 13:18:43 +0000 (13:18 +0000)]
remove dm from everything
git-svn-id: http://skia.googlecode.com/svn/trunk@11804
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 16 Oct 2013 13:05:06 +0000 (13:05 +0000)]
force readbuffer clients to use specialized readFoo for flattenables
BUG=
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
26702002
git-svn-id: http://skia.googlecode.com/svn/trunk@11803
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 16 Oct 2013 13:02:15 +0000 (13:02 +0000)]
dm is like gm, but faster and with fewer features.
This is sort of the near-minimal proof-of-concept skeleton.
- It can run existing GMs.
- It supports most configs (just not PDF).
- --replay is the only "fancy" feature it currently supports
Hopefully you will be disturbed by its speed.
BUG=
R=epoger@google.com
Review URL: https://codereview.chromium.org/
22839016
git-svn-id: http://skia.googlecode.com/svn/trunk@11802
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 16 Oct 2013 11:50:50 +0000 (11:50 +0000)]
texdata gm: allocate gTextureData on the heap.
This GM is triggering a stack overflow on my laptop when I run it with dm. As
I understand it, the default stack size on a Mac is 64K, but this allocates 640K.
BUG=
R=bsalomon@google.com, robertphillips@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
26440006
git-svn-id: http://skia.googlecode.com/svn/trunk@11801
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 16 Oct 2013 07:02:24 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11800
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 16 Oct 2013 01:12:38 +0000 (01:12 +0000)]
Reverting r11777 (ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs) due to Chromium compilation failure
git-svn-id: http://skia.googlecode.com/svn/trunk@11799
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Oct 2013 23:01:08 +0000 (23:01 +0000)]
Guard colorNames variable under SK_SUPPORT_UNITTEST.
That way clang does not complain with unneeded-internal-declaration warning,
because otherwise to clang this variable is unused and thus it won't
emit code for it.
The warning is:
../../src/utils/SkParseColor.cpp:35:3: error: variable 'colorNames' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
} colorNames[] = {
R=bsalomon@google.com, robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
27229004
git-svn-id: http://skia.googlecode.com/svn/trunk@11798
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 15 Oct 2013 23:00:26 +0000 (23:00 +0000)]
More new baselines for displacement GM.
TBR=
Review URL: https://codereview.chromium.org/
27420003
git-svn-id: http://skia.googlecode.com/svn/trunk@11797
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 15 Oct 2013 22:08:53 +0000 (22:08 +0000)]
Fix test name in ignored-tests.txt
git-svn-id: http://skia.googlecode.com/svn/trunk@11796
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 15 Oct 2013 21:40:50 +0000 (21:40 +0000)]
First round of new baselines for displacement GM.
TBR=bsalomon
BUG=
Review URL: https://codereview.chromium.org/
27411002
git-svn-id: http://skia.googlecode.com/svn/trunk@11795
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 15 Oct 2013 21:20:26 +0000 (21:20 +0000)]
Add failing complex clip gpu tests to ignored-tests.txt
git-svn-id: http://skia.googlecode.com/svn/trunk@11794
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 15 Oct 2013 20:58:50 +0000 (20:58 +0000)]
rebaseline some of the complex clip aa gpu tests and direct write blurs
git-svn-id: http://skia.googlecode.com/svn/trunk@11793
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Oct 2013 20:39:57 +0000 (20:39 +0000)]
Remove SkDataTable from SkFlattenable hierarchy.
As far as I can tell, we never really needed this. No code outside the unit
test calls this code.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
26223009
git-svn-id: http://skia.googlecode.com/svn/trunk@11792
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Oct 2013 20:36:16 +0000 (20:36 +0000)]
Remove SkColorTable from SkFlattenable hierarchy.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
27392002
git-svn-id: http://skia.googlecode.com/svn/trunk@11791
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 15 Oct 2013 20:29:37 +0000 (20:29 +0000)]
Truly ignore failures in skimage.
If the expectation is set to ignore failures, do not return a
negative 1 (indicating a failure) when a successful decode
does not match the expectation.
If the file could not be decoded at all, report this to the
user depending on the input expectations file:
No expectations:
Report failure. The user wanted to know if the file could be
decoded.
Expectations expected a valid result:
Report failure. The decode should have matched the result.
Empty expectations:
Print a message that the expectation was missing, but still
return success from skimage, since this is a newly added file
(i.e. it has no expectation yet).
Ignore failure:
Return success from skimage, since it is a known failure.
Update the self tests to ensure these behaviors.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
22293006
git-svn-id: http://skia.googlecode.com/svn/trunk@11790
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Oct 2013 20:14:00 +0000 (20:14 +0000)]
return false if we can't scale, to force us to try to lock the original and then proceed
BUG=
R=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/
27382002
git-svn-id: http://skia.googlecode.com/svn/trunk@11789
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 15 Oct 2013 20:10:33 +0000 (20:10 +0000)]
rebaseline_server: add --editable and --reload flags
This is a variation on the --browseonly flag we came up with in
https://codereview.chromium.org/
24274003/#msg6 .
The long-lived "view only" server will probably be run like this:
server.py --export --reload 300
And when rebaselining you'll run your own server like this:
server.py --editable
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/
27218005
git-svn-id: http://skia.googlecode.com/svn/trunk@11788
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Oct 2013 20:05:24 +0000 (20:05 +0000)]
test for failing pixelref (crashes, so disable for now)
test for a pixelref that fails to lock
BUG=
Review URL: https://codereview.chromium.org/
26539012
git-svn-id: http://skia.googlecode.com/svn/trunk@11787
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Oct 2013 20:04:07 +0000 (20:04 +0000)]
Turn clear-to-white-then-intersect clips into clear-to-black-then-replace
R=robertphillips@google.com, brian@thesalomons.net
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
27170003
git-svn-id: http://skia.googlecode.com/svn/trunk@11786
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Oct 2013 20:03:59 +0000 (20:03 +0000)]
Remove obsolete CityHash conditional.
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
26172003
git-svn-id: http://skia.googlecode.com/svn/trunk@11785
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 15 Oct 2013 19:30:58 +0000 (19:30 +0000)]
Fix Win warning-as-error.
TBR=edisonn
BUG=
Review URL: https://codereview.chromium.org/
27391002
git-svn-id: http://skia.googlecode.com/svn/trunk@11783
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 15 Oct 2013 19:02:43 +0000 (19:02 +0000)]
Add crop rect support for SkDisplacementMapEffect (raster and GPU paths).
Covered by new test cases added to displacement GM (will require rebaseline).
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
26531002
git-svn-id: http://skia.googlecode.com/svn/trunk@11782
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 15 Oct 2013 18:50:00 +0000 (18:50 +0000)]
Fix off by one error in last advanceCount in SkFontHost_FreeType.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
27338003
git-svn-id: http://skia.googlecode.com/svn/trunk@11781
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 15 Oct 2013 17:51:38 +0000 (17:51 +0000)]
gpu rebaselines
Review URL: https://codereview.chromium.org/
27347004
git-svn-id: http://skia.googlecode.com/svn/trunk@11779
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 15 Oct 2013 17:47:36 +0000 (17:47 +0000)]
Second wave of Win64 warning cleanup
https://codereview.chromium.org/
27343002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11778
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 15 Oct 2013 16:18:40 +0000 (16:18 +0000)]
ARM Skia NEON patches - 30 - Xfermode: NEON modeprocs
Xfermode: NEON implementation of SIMD procs
This patch contains a NEON implementation for a number of Xfermodes.
It provides a big speedup on Xfermode benchmarks (currently up to 3x
with gcc4.7 but up to 10x when gcc produces optimal code for it).
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com, reed@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/
26627004
git-svn-id: http://skia.googlecode.com/svn/trunk@11777
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 15 Oct 2013 15:44:35 +0000 (15:44 +0000)]
account for inverse-paths when we prealloc storage in the rgn-builder
test inversepath->rgn
BUG=
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
27222005
git-svn-id: http://skia.googlecode.com/svn/trunk@11776
2bbb7eff-a529-9590-31e7-
b0007b416f81