Tero Rintaluoma [Mon, 28 Mar 2011 06:51:51 +0000 (09:51 +0300)]
Half pixel variance further optimized for ARMv6
Half pixel interpolations optimized in variance calculations. Separate
function calls to vp8_filter_block2d_bil_x_pass_armv6 are avoided.On
average, performance improvement is 6-7% for VGA@30fps sequences.
Change-Id: Idb5f118a9d51548e824719d2cfe5be0fa6996628
Johann [Thu, 24 Mar 2011 18:06:36 +0000 (11:06 -0700)]
Merge "use asm_offsets with vp8_regular_quantize_b_sse2"
Johann [Thu, 10 Feb 2011 19:57:43 +0000 (14:57 -0500)]
use asm_offsets with vp8_regular_quantize_b_sse2
remove helper function and avoid shadowing all the arguments to the
stack on 64bit systems
when running with --good --cpu-used=0:
~2% on linux x86 and x86_64
~2% on win32 x86 msys and visual studio
more on darwin10 x86_64
significantly more on
x86_64-win64-vs9
Change-Id: Ib7be12edf511fbf2922f191afd5b33b19a0c4ae6
Johann [Wed, 23 Mar 2011 14:52:51 +0000 (07:52 -0700)]
Merge "ARMv6 optimized fdct4x4"
John Koleszar [Mon, 21 Mar 2011 19:29:11 +0000 (12:29 -0700)]
Merge "Allow specifying --end-usage by enum name"
John Koleszar [Mon, 21 Mar 2011 16:12:58 +0000 (09:12 -0700)]
Merge "vpx_codec_dec_init: check that the iface is a decoder"
John Koleszar [Mon, 21 Mar 2011 15:46:15 +0000 (11:46 -0400)]
vpx_codec_dec_init: check that the iface is a decoder
Make sure the given interface is actually a decoder interface before
initializing it.
Change-Id: Ie48d737f2956cc2f0891666de5ea87251e96bc49
Yunqing Wang [Mon, 21 Mar 2011 14:41:31 +0000 (07:41 -0700)]
Merge "Fix multithreaded encoding for 1 MB wide frame"
John Koleszar [Fri, 11 Mar 2011 18:01:02 +0000 (13:01 -0500)]
Remove unused vp8_get4x4sse_cs_mmx declaration
This declaration did not match the prototype_sad() prototype, but was
unused in this translation unit, so it is removed instead. Fixes
issue 290.
Change-Id: I168854f88a85f73ca9aaf61d1e5dc0f43fc3fdb3
John Koleszar [Mon, 21 Mar 2011 11:51:51 +0000 (04:51 -0700)]
Merge "Increase static linkage, remove unused functions"
John Koleszar [Mon, 21 Mar 2011 11:50:42 +0000 (07:50 -0400)]
Allow specifying --end-usage by enum name
Map an enum to the --end-usage values, so you can specify
--end-usage=cq instead of --end-usage=2. The numerical values still
work for historical scripts, etc, but this is more user friendly.
Change-Id: I445ecd9638f801f5924a71eabf449bee293cdd34
Tero Rintaluoma [Mon, 21 Mar 2011 11:33:45 +0000 (13:33 +0200)]
ARMv6 optimized fdct4x4
Optimized fdct4x4 (8x4) for ARMv6 instruction set.
- No interlocks in Cortex-A8 pipeline
- One interlock cycle in ARM11 pipeline
- About 2.16 times faster than current C-code compiled with -O3
Change-Id: I60484ecd144365da45bb68a960d30196b59952b8
Attila Nagy [Fri, 18 Mar 2011 08:44:08 +0000 (10:44 +0200)]
Fix multithreaded encoding for 1 MB wide frame
Thread synchronization was not correct when frame width was 1 MB.
Number of allocated encoding threads is limited by the sync_range.
There is no point having more because each thread lags sync_range MBs
behind the thread processing the row above.
http://code.google.com/p/webm/issues/detail?id=302
Change-Id: Icaf67a883beecc5ebf2f11e9be47b6997fdf6f26
John Koleszar [Thu, 17 Mar 2011 21:07:59 +0000 (17:07 -0400)]
Increase static linkage, remove unused functions
A large number of functions were defined with external linkage, even
though they were only used from within one file. This patch changes
their linkage to static and removes the vp8_ prefix from their names,
which should make it more obvious to the reader that the function is
contained within the current translation unit. Functions that were
not referenced were removed.
These symbols were identified by:
$ nm -A libvpx.a | sort -k3 | uniq -c -f2 | grep ' [A-Z] ' \
| sort | grep '^ *1 '
Change-Id: I59609f58ab65312012c047036ae1e0634f795779
Ralph Giles [Thu, 17 Mar 2011 07:23:36 +0000 (00:23 -0700)]
Set bounds from the array when iterating mmaps.
The mmap allocation code in vp8_dx_iface.c was inconsistent.
The static array vp8_mem_req_segs defines two descriptors,
but only the first is real. The second is a sentinel and
isn't actually allocated, so vpx_codec_alg_priv is declared
with mmaps[NELEMENTS(vp8_mem_req_segs)-1]. Some functions
use this reduced upper bound when iterating though the mmap
array, but these two functions did not.
Instead, this commit calls NELEMENTS(...->mmaps) to directly
query the bounds of the dereferenced array.
This fixes an array-bounds warning from gcc 4.6 on
vp8_xma_set_mmap.
Change-Id: I918e2721b401d134c1a9764c978912bdb3188be1
Ralph Giles [Thu, 17 Mar 2011 01:30:22 +0000 (18:30 -0700)]
Remove commented-out VP6 code from vp8_finalize_mmaps
Change-Id: I48642c380353043bed96026f56de5908fcee270a
John Koleszar [Thu, 17 Mar 2011 21:25:04 +0000 (14:25 -0700)]
Merge "Fix "used uninitialized" warning in vp8_pack_bitstream()"
John Koleszar [Thu, 29 Jul 2010 21:04:39 +0000 (17:04 -0400)]
apple: include proper mach primatives
Fixes implicit declaration warning for 'mach_task_self'. This change
is an update to Change I9991dedd1ccfddc092eca86705ecbc3b764b799d,
which fixed this issue for the decoder but not the encoder.
Change-Id: I9df033e81f9520c4f975b7a7cf6c643d12e87c96
Attila Nagy [Wed, 16 Mar 2011 10:56:52 +0000 (12:56 +0200)]
Remove echoing in obj_int_extract rule
Change-Id: I9965170b40e2f32e9d84895c33a529b0d7dacdc1
Attila Nagy [Wed, 9 Mar 2011 12:26:24 +0000 (14:26 +0200)]
Add vp8_variance8x8_armv6 and vp8_sub_pixel_variance8x8_armv6 functions
Change-Id: I08edaffc62514907fa5e90e1689269e467c857f5
Gaute Strokkenes [Tue, 15 Mar 2011 12:20:54 +0000 (12:20 +0000)]
Avoid misspelling "dependent".
Change-Id: Ib0c280e1fcfd977e11e4390807b2c8077a87500c
John Koleszar [Mon, 14 Mar 2011 21:13:53 +0000 (14:13 -0700)]
Merge "Fix an unused variable warning."
Ralph Giles [Mon, 14 Mar 2011 17:50:19 +0000 (10:50 -0700)]
Improve grammar in a comment.
Change-Id: I18bfda6d420626f2718e096e338c1d0bf0ba029d
Johann [Mon, 14 Mar 2011 15:10:24 +0000 (11:10 -0400)]
obj_int_extract: win64 does not prefix symbols
obj_int_extract was unconditionally skipping the first character in the
symbol. make sure it's actually an '_' first
Change-Id: Icfe527eb8a0028faeabaa1dcedf8cd8f51c92754
Johann [Mon, 14 Mar 2011 19:47:42 +0000 (12:47 -0700)]
Merge "Add vp8_mse16x16_armv6 function"
Attila Nagy [Tue, 8 Mar 2011 12:48:20 +0000 (14:48 +0200)]
Add vp8_mse16x16_armv6 function
Change-Id: I77e9f2f521a71089228f96e2db72524189364ffb
Rafael Ávila de Espíndola [Sat, 5 Mar 2011 20:36:40 +0000 (15:36 -0500)]
Fix build with xcode4 and simplify GLOBAL.
Without this change I get link errors in firefox's libxul. It looks
like the linker expect a particular pattern for getting the GOT. This
patch changes webm to use the same pattern used by the compiler.
Change-Id: Iea8c2e134ad45c1dc7d221ff885a8429bfa4e057
Johann [Fri, 11 Mar 2011 18:23:48 +0000 (10:23 -0800)]
Merge "Move build_intra_predictors_mby to RTCD framework"
John Koleszar [Fri, 11 Mar 2011 16:35:38 +0000 (11:35 -0500)]
Move build_intra_predictors_mby to RTCD framework
The vp8_build_intra_predictors_mby and vp8_build_intra_predictors_mby_s
functions had global function pointers rather than using the RTCD
framework. This can show up as a potential data race with tools such as
helgrind. See https://bugzilla.mozilla.org/show_bug.cgi?id=640935
for an example.
Change-Id: I29c407f828ac2bddfc039f852f138de5de888534
Johann [Fri, 11 Mar 2011 16:29:00 +0000 (08:29 -0800)]
Merge "ARMv6 optimized quantization"
John Koleszar [Fri, 11 Mar 2011 16:28:05 +0000 (08:28 -0800)]
Merge "Only enable ssim_opt.asm on X86_64"
John Koleszar [Fri, 11 Mar 2011 16:27:08 +0000 (11:27 -0500)]
Only enable ssim_opt.asm on X86_64
Fix compiling on 32 bit x86.
Change-Id: I6210573e1d9287ac49acbe3d7e5181e309316107
Paul Wilkins [Fri, 11 Mar 2011 14:51:40 +0000 (14:51 +0000)]
Clean up of vp8_init_config()
Clean up vp8_init_config() a bit and remove null pointer case,
as this code can't be called any more and is not an adequate
trap anyway, as a null pointer would cause exceptions before
hitting the test.
Change-Id: I937c00167cc039b3aa3f645f29c319d58ae8d3ee
John Koleszar [Fri, 11 Mar 2011 16:06:09 +0000 (08:06 -0800)]
Merge "1 Pass CQ and VBR bug fixes"
Paul Wilkins [Thu, 10 Mar 2011 16:11:39 +0000 (16:11 +0000)]
1 Pass CQ and VBR bug fixes
Issue 291 highlighted the fact that CQ mode was not working
as expected in 1 pass mode,
This commit fixes that specific problem but in so doing I also
uncovered an overflow issue in the VBR code for 1 pass and
some data values not being correctly initialized.
For some clips (particularly short clips), the resulting
improvement is dramatic.
Change-Id: Ieefd6c6e4776eb8f1b0550dbfdfb72f86b33c960
John Koleszar [Fri, 11 Mar 2011 14:06:04 +0000 (06:06 -0800)]
Merge "Fix incorrect macroblock counts in twopass rate control"
Yunqing Wang [Fri, 11 Mar 2011 13:56:02 +0000 (05:56 -0800)]
Merge "Align SAD output array to be 16-byte aligned"
John Koleszar [Fri, 11 Mar 2011 13:54:00 +0000 (05:54 -0800)]
Merge "vp8cx - psnr converted to call assemblerized sse"
John Koleszar [Fri, 11 Mar 2011 13:53:41 +0000 (05:53 -0800)]
Merge "vp8cx- alternate ssim function with optimizations"
Jim Bankoski [Tue, 8 Mar 2011 20:23:40 +0000 (15:23 -0500)]
vp8cx - psnr converted to call assemblerized sse
Change-Id: Ie388d4618c44b131f96b9fe526618b457f020dfa
Jim Bankoski [Tue, 8 Mar 2011 14:05:18 +0000 (09:05 -0500)]
vp8cx- alternate ssim function with optimizations
Change-Id: I91921b0a90dbaddc7010380b038955be347964b3
Yunqing Wang [Fri, 11 Mar 2011 13:24:23 +0000 (08:24 -0500)]
Align SAD output array to be 16-byte aligned
Use aligned store.
Change-Id: Icab4c0c53da811d0c52bb7e8134927f249ba2499
Yunqing Wang [Fri, 11 Mar 2011 12:55:05 +0000 (04:55 -0800)]
Merge "Encoder loopfilter running in its own thread"
Attila Nagy [Fri, 11 Mar 2011 10:34:57 +0000 (12:34 +0200)]
Fix "used uninitialized" warning in vp8_pack_bitstream()
Change-Id: Iadcbdba717439f47a2c24e65fd69a3a1464174b5
Attila Nagy [Fri, 25 Feb 2011 11:42:05 +0000 (13:42 +0200)]
Encoder loopfilter running in its own thread
In multithreaded mode the loopfilter is running in its own thread (filter level
calculation and frame filtering). Filtering is mostly done in parallel with the
bitstream packing. Before starting the packing the loopfilter level has
to be calculated. Also any needed reference frame copying is done in the
filter thread.
Currently the encoder will create n+1 threads, where n > 1 is the number of
threads specified by application and 1 is the extra filter thread. With n = 1
the encoder runs in single thread mode. There will never be more than n threads
running concurrently.
Change-Id: I4fb29b559a40275d6d3babb8727245c40fba931b
Tero Rintaluoma [Mon, 7 Mar 2011 09:12:56 +0000 (11:12 +0200)]
ARMv6 optimized quantization
Adds new ARMv6 optimized function vp8_fast_quantize_b_armv6
to the encoder.
Change-Id: I40277ec8f82e8a6cbc453cf295a0cc9b2504b21e
Johann [Wed, 2 Mar 2011 14:44:39 +0000 (09:44 -0500)]
obj_int_extract for Visual Studio
Enable extraction of assembly offsets from compiled examples in MSVS.
This will allow us to remove some stub functions from x86 assembly since
we will be able to reliably determine structure offsets at compile time.
see ARM code for examples:
vp8/encoder/arm/armv5te/
vpx_scale/arm/neon/
Change-Id: I1852dc6b56ede0bf1dddb5552196222a7c6a902f
Adrian Grange [Thu, 10 Mar 2011 20:43:49 +0000 (12:43 -0800)]
Added missing format specifier in print statement
Printout of firstpass stats for frame had one fewer
format specifiers than arguments.
Change-Id: I5a42c85aa79c471e1a70afd75e24a91546b7a1cd
Adrian Grange [Thu, 10 Mar 2011 19:32:48 +0000 (11:32 -0800)]
Removed firstpass motion map
The firstpass motion map consists of an 8-bit flag for
each MB indicating how strongly the firstpass code
believes it should be filtered during the second pass
ARNR filtering.
For long or large format material the motion map can
become extremely large and hamper the operation of
the encoding process.
This change removes the motion map altogether, leaving
the second pass to rely on the magnitude of the motion
compensated error to determine the filter weight to
use for the MB during ARNR filtering.
Tests on the derf set indicate that the effect of this
change is neutral, with some small wins and losses. The
motion map has therefore been removed based on
a cost/benefit evaluation.
Change-Id: I53e07d236f5ce09a6f0c54e7c4ffbb490fb870f6
James Berry [Thu, 10 Mar 2011 16:13:44 +0000 (11:13 -0500)]
Fix incorrect macroblock counts in twopass rate control
The previous calculation of macroblock count (w*h)/256
is not correct when the width/height are not multiples of
16. Use the precalculated macroblock count from
cpi->common instead. This manifested itself as a divide
by zero when the number of pixels was less than 256.
num_mbs updated in estimate_max_q, estimate_q,
estimate_kf_group_q, and estimate_cq
Change-Id: I92ff98587864c801b1ee5485cfead964673a9973
Yunqing Wang [Wed, 9 Mar 2011 20:26:37 +0000 (12:26 -0800)]
Merge "Add vp8_sub_pixel_variance16x8_ssse3 function"
John Koleszar [Wed, 9 Mar 2011 19:11:28 +0000 (14:11 -0500)]
Merge branch 'bali'
Change-Id: Icf18b4981afb12ef255fca431d4ba45860dd22c9
John Koleszar [Wed, 9 Mar 2011 18:43:31 +0000 (13:43 -0500)]
Add missing filter.h to build system
Missing file causes 'make dist' to not include a complete copy of the
source.
Change-Id: I3f55aeb5a86d0e81234e4e4588cb8086ba4cfc4a
Johann [Wed, 9 Mar 2011 17:44:48 +0000 (09:44 -0800)]
Merge "fix obj_int_extract for MinGW"
Yunqing Wang [Wed, 9 Mar 2011 16:16:30 +0000 (11:16 -0500)]
Add vp8_sub_pixel_variance16x8_ssse3 function
Added SSSE3 function
Change-Id: I8c304c92458618d93fda3a2f62bd09ccb63e75ad
Yunqing Wang [Wed, 9 Mar 2011 15:45:03 +0000 (10:45 -0500)]
Remove unused functions
Removed some unused functions
Change-Id: Ifdfc27453e53cfc75997b38492901d193a16b245
Yunqing Wang [Wed, 9 Mar 2011 15:23:06 +0000 (07:23 -0800)]
Merge "Improve SSE2 half-pixel filter funtions"
John Koleszar [Wed, 9 Mar 2011 13:07:11 +0000 (05:07 -0800)]
Merge "Configuration updates:Making a clear distinction between Init and Change"
Ralph Giles [Tue, 8 Mar 2011 22:51:23 +0000 (14:51 -0800)]
Fix an unused variable warning.
Move the update of the loopfilter info to the same block where it
is used. GCC 4.5 is not able trace the initialization of the local
filter_info across the other calls between the two conditionals on
pbi->common and issues an uninitialized variable warning.
Change-Id: Ie4487b3714a096b3fb21608f6b0c74e745e3c6fc
Johann [Tue, 8 Mar 2011 22:41:45 +0000 (17:41 -0500)]
fix obj_int_extract for MinGW
failed to find headers in the source directory
output to stdout instead of a hardcoded file
MinGW doesn't support _sopen_s
_fstat catches non-existant files
Change-Id: I24e0aacc6f6f26e6bcfc25f9ee7821aa3c8cc7e7
Yunqing Wang [Tue, 8 Mar 2011 21:25:06 +0000 (16:25 -0500)]
Improve SSE2 half-pixel filter funtions
Rewrote these functions to process 16 pixels once instead of 8.
Change-Id: Ic67e80124467a446a3df4cfecfb76a4248602adb
Johann [Tue, 8 Mar 2011 20:29:32 +0000 (12:29 -0800)]
Merge "64bit mach-o support"
Yunqing Wang [Tue, 8 Mar 2011 20:26:58 +0000 (12:26 -0800)]
Merge "Add zero offset checking in SSE2 sub-pixel filter function"
Yunqing Wang [Tue, 8 Mar 2011 20:22:07 +0000 (15:22 -0500)]
Add zero offset checking in SSE2 sub-pixel filter function
Skip filter at zero offset.
Change-Id: I95fc7e211869bc0ab5bcfb7ab2e3259d1c0ccf38
Yunqing Wang [Tue, 8 Mar 2011 18:58:30 +0000 (10:58 -0800)]
Merge "Write SSSE3 sub-pixel filter function"
Yunqing Wang [Fri, 4 Mar 2011 00:02:45 +0000 (19:02 -0500)]
Write SSSE3 sub-pixel filter function
1. Process 16 pixels at one time instead of 8.
2. Add check for both xoffset =0 and yoffset=0, which happens
during motion search.
This change gave encoder 1%~3% performance gain.
Change-Id: Idaa39506b48f4f8b2fbbeb45aae8226fa32afb3e
Johann [Wed, 23 Feb 2011 21:08:10 +0000 (16:08 -0500)]
64bit mach-o support
enable parsing 64bit mach-o files (OS X)
also fixes --enable-debug issue!
Change-Id: I250ee69745cd2365e3e63264f9365cd58fbb6678
Johann [Wed, 23 Feb 2011 22:07:35 +0000 (17:07 -0500)]
64bit elf support
enable parsing 64bit elf files
Change-Id: I7981f4769cf1b822f288fe2e32166254e4394bab
Ralph Giles [Tue, 8 Mar 2011 15:14:12 +0000 (07:14 -0800)]
Fix a multi-line format-string warning.
GCC 4.5 and 4.6 both issue a warning about the multi-line format
string introduced in
bc9c30a0, which also changed the whitespace
in the associated stt file by line-wrapping the long format string.
Instead, use multiple string constants, which the compiler will
concatenate. This maintains the original formatting, but remains
legible within the standard line length.
Change-Id: I27c9f92d46be82d408105a3a4091f145f677e00e
Paul Wilkins [Tue, 8 Mar 2011 14:46:22 +0000 (14:46 +0000)]
Corrected minor typos.
Change-Id: Icc9f12bd1e1bdaf51256dc8a90d08aa9be89ef34
Paul Wilkins [Tue, 8 Mar 2011 14:40:11 +0000 (06:40 -0800)]
Merge changes I00c3e823,If8bca004
* changes:
Improved key frame detection.
Improved KF insertion after fades to still.
John Koleszar [Tue, 8 Mar 2011 01:58:37 +0000 (20:58 -0500)]
correct zbin boost for splitmv mode
Disable zbin boost in SPLITMV mode as intended. Was incorrectly looking
at vp8_ref_frame_order instead of vp8_mode_order when comparing against
SPLITMV. This condition should have always been false, as SPLITMV is
not in the range of valid reference frames.
Change-Id: I0408cc7595eff68f00efef6d008e79f5b60d14bf
John Koleszar [Mon, 7 Mar 2011 21:25:28 +0000 (13:25 -0800)]
Merge "Fix format-string warning"
Ralph Giles [Mon, 7 Mar 2011 21:00:05 +0000 (13:00 -0800)]
Fix format-string warning
Cast size_t to (unsigned long) and print it with the %lu format
string, which is more portable than C99's explict %zu for size_t.
This truncates on Windows x64 but otherwise works on 32 and 64 bit
platforms. In practice the stats file is unlikely to be so large.
Change-Id: I0432b3acf85fc6ba4ad50640942e1ca4614b21cb
Paul Wilkins [Mon, 7 Mar 2011 15:58:07 +0000 (15:58 +0000)]
Improved key frame detection.
In some cases where clips have been encoded with
borders (eg. some wide-screen content where there is a
border top and bottom and slide shows containing portrait
format photographs (border left and right)) key frames were
not being correctly detected.
The new code looks to measure cases where a portion of
the image can be coded equally easily using intra or inter
modes and where the resulting error score is also very low.
These "neutral" areas are then discounted in the key frame
detection code.
Change-Id: I00c3e8230772b8213cdc08020e1990cf83b780d8
Paul Wilkins [Mon, 7 Mar 2011 15:11:09 +0000 (15:11 +0000)]
Improved KF insertion after fades to still.
This code extends what was previously done for GFs, to pick
cases where insertion of a key frame after a fade (or other
transition or complex motion) followed by a still section, will
be beneficial and will reduce the number of forced key frames.
Change-Id: If8bca00457f0d5f83dc3318a587f61c17d90f135
John Koleszar [Fri, 4 Mar 2011 19:32:24 +0000 (14:32 -0500)]
Update CHANGELOG for v0.9.6 (Bali) release
Change-Id: I7d1e7db1866d829f6d4c6638d1c20e99959cc9a3
John Koleszar [Fri, 4 Mar 2011 16:12:06 +0000 (11:12 -0500)]
Update AUTHORS
Change-Id: I784ea2b9fabbec1e99d02e97209981ff1b18ac82
John Koleszar [Fri, 4 Mar 2011 16:11:15 +0000 (11:11 -0500)]
Update .mailmap
Add mappings for Tom Finegan, Tero Rintaluoma
Change-Id: I014ad5bb7c8eb8261808d98ec0d4f77a8e7c3f35
Johann [Fri, 4 Mar 2011 14:01:46 +0000 (06:01 -0800)]
Merge "examples: use function to get iface pointers"
Johann [Fri, 4 Mar 2011 13:59:31 +0000 (05:59 -0800)]
Merge "change CFLAGS for 64 bit icc builds"
John Koleszar [Fri, 4 Mar 2011 13:51:39 +0000 (08:51 -0500)]
cosmetic: clean up comments for new vp8dx controls
Rename the common control id enum vp8_{dec,com}_control_id,
move VP8_DECODER_CTRL_ID_START to common, wrap long lines.
Change-Id: I659abc62f10aa389d496f7f43950775db0ef2f9f
John Koleszar [Fri, 4 Mar 2011 13:44:54 +0000 (05:44 -0800)]
Merge "clean up msvs project generation"
John Koleszar [Fri, 4 Mar 2011 13:40:33 +0000 (05:40 -0800)]
Merge "Fixing divide by zero"
John Koleszar [Fri, 4 Mar 2011 13:39:40 +0000 (05:39 -0800)]
Merge "Fix drastic undershoot in long form content"
John Koleszar [Fri, 4 Mar 2011 13:38:26 +0000 (05:38 -0800)]
Merge "documentation: minor updates to vp8 (en|de)coder"
John Koleszar [Fri, 4 Mar 2011 13:28:38 +0000 (05:28 -0800)]
Merge "Fix counter of fixed keyframe distance"
Mikhal Shemer [Tue, 1 Mar 2011 23:07:47 +0000 (15:07 -0800)]
Configuration updates:Making a clear distinction between Init and Change
Change-Id: I7b2fb326e1aabc08b032177a7b914a5b8bb7376f
Mikhal Shemer [Tue, 1 Mar 2011 22:59:22 +0000 (14:59 -0800)]
Fixing divide by zero
Change-Id: I9d8a98a2f7ed1e3116d0bae35164618c41998bac
John Koleszar [Wed, 2 Mar 2011 22:02:44 +0000 (17:02 -0500)]
Fix drastic undershoot in long form content
When the modified_error_left accumulator exceeds INT_MAX, an incorrect
cast to int resulted in a negative value, causing the rate control to
allocate no bits to that keyframe group, leading to severe undershoot
and subsequent poor quality.
This error was exposed by the recent change to the rolling target and
actual spend accumulators in commit
305be4e4 which fixed them to
actually calculate the average value rather than be re-initialized
on every frame to the average per-frame bitrate. When this bug was
triggered, the target bitrate could be 0, so the rolling target
becomes small, which causes the undershoot. The code prior to
305be4e4
did not exhibit this behavior because the rolling target was always
set to a reasonable value and was independent of the actual target
bitrate. With this patch, the actual target bitrate is calculated
correctly, and the rate control tracks as expected.
This cast was likely added to silence a compiler warning on a comparison
between a double (modified_error_left) and an int (0). Instead, this
patch removes the cast and changes the comparison to be against 0.0,
which should prevent the warning from reoccuring.
This fixes issue #289. Special thanks to gnafu for his efforts in
reporting and debugging this fix.
Change-Id: Ie5cc1a7b516c578a76c3a50c892a6f04a11621fe
Johann [Mon, 28 Feb 2011 19:13:39 +0000 (14:13 -0500)]
clean up msvs project generation
add visual studio 9 to --help
remove cpp, cxx, hpp, hxx files from filter
add the ability to target project names. this will be necessary to
enable obj_int_extract
Change-Id: I407583320d8b67a0df40c07221838c42678792f7
Johann [Wed, 2 Mar 2011 13:48:46 +0000 (05:48 -0800)]
Merge "ARMv6 optimized half pixel variance calculations"
John Koleszar [Tue, 1 Mar 2011 01:16:14 +0000 (20:16 -0500)]
change CFLAGS for 64 bit icc builds
AMD64 only implies SSE2, not SSE3. There aren't any known cases where
icc was generating SSE3 instructions since all the vectorizable code
is already in handwritten asm, so this fix is included mostly for
correctness. Fixes issue #259.
Change-Id: I993335a4740b68b559035305fb52ca725a6beaff
John Koleszar [Tue, 1 Mar 2011 01:06:56 +0000 (20:06 -0500)]
examples: use function to get iface pointers
MSVC can't pass the address of global variables in a DLL correctly
across DLL boundaries. This patch allows linking the examples to
a libvpx dll build. Fixes issue #268.
Change-Id: I1c52d076cfc68efb3efdfba019f12d53c5019f58
Yunqing Wang [Mon, 28 Feb 2011 19:42:28 +0000 (11:42 -0800)]
Merge "Add prefetch before variance calculation"
Scott LaVarnway [Mon, 28 Feb 2011 18:16:32 +0000 (10:16 -0800)]
Merge "Avoid double copying of key frames into alt and golden buffer"
Yunqing Wang [Tue, 22 Feb 2011 23:01:08 +0000 (18:01 -0500)]
Add prefetch before variance calculation
This improved encoding performance by 0.5% (good, speed 1) to
1.5% (good, speed 5).
Change-Id: I843d72a0d68a90b5f694adf770943e4a4618f50e
John Koleszar [Mon, 28 Feb 2011 15:18:41 +0000 (07:18 -0800)]
Merge "Remove examples.doxy dep w/--disable-examples"
Johann [Fri, 25 Feb 2011 19:44:18 +0000 (11:44 -0800)]
Merge "Remove a second check for invalid ptr in vp8_get_compressed_data"
Aaron Watry [Fri, 25 Feb 2011 15:11:27 +0000 (10:11 -0500)]
Fix crash on Sparc Solaris.
Sparc on Solaris requires memory copies in reconinter.c to be aligned.
Change-Id: I6c5b75fb80d6fd501ae4b41b533c3109c2f32be2