Javier Suárez Ruiz [Fri, 27 Sep 2019 22:06:53 +0000 (00:06 +0200)]
[Android] Fixed issue changing the ItemTemplate on CarouselView (#7628) fixes #7395
* Fixed Issue 7395 - Changing ItemTemplate does not work as expected (Android)
* Added instructions to Issue7395
* Updated Core Gallery sample (instructions)
E.Z. Hart [Fri, 27 Sep 2019 17:41:04 +0000 (11:41 -0600)]
[UWP] Reduce allocations and fix memory leak in CollectionView (#7608)
* Checkpoint
* Fix leak caused by CollectionViewSource
* Simplify ItemTemplateEnumerator
* Reduce allocations in simple IList source scenarios on UWP
* Revert debugging changes
E.Z. Hart [Fri, 27 Sep 2019 15:56:42 +0000 (09:56 -0600)]
Fix binding on test page to remove IsDragging errors
Shane Neuville [Fri, 27 Sep 2019 15:23:13 +0000 (09:23 -0600)]
Wait for test to load before scrolling images (#7702)
Stephane Delcroix [Fri, 27 Sep 2019 05:59:52 +0000 (07:59 +0200)]
[X] Pass the current assembly to parsing context (#7550)
In case of Xaml-only RD, the rootAssembly is different from the assembly
of the rootType
- fixes #7531
Javier Suárez Ruiz [Fri, 27 Sep 2019 05:19:12 +0000 (07:19 +0200)]
[RefreshView] Fire RefreshCommand setting IsRefreshing (#7398)
* refresh view ui tests
* Fixed issue notifying changes in IsRefreshing property
* Fire RefreshCommand setting IsRefreshing to true
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
* Update Xamarin.Forms.Core.UITests.Shared/UITestCategories.cs
* Added RefreshView UITests
* - ui test with swipe
* - change to drag
* - fix ui test
* - remove extra property changed event
Samantha Houts [Fri, 27 Sep 2019 00:23:42 +0000 (17:23 -0700)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Fri, 27 Sep 2019 00:16:10 +0000 (18:16 -0600)]
JavaSDK build path hack (#7707)
adrianknight89 [Fri, 27 Sep 2019 00:16:03 +0000 (19:16 -0500)]
[iOS] Fix MeasureFirstItem for CollectionView (#7622)
* fix MeasureFirstItem
* added test
* changed file name
* fix path
* added text
* remove 5455
* drop private
fixes #7621
Gerald Versluis [Thu, 26 Sep 2019 17:23:41 +0000 (10:23 -0700)]
[BUG/iOS] Fixed CollectionView Insets ItemSpacing (#7158)
* Fix 7035
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
* Update ItemsViewLayout.cs
* Update test case to show span issue
* Update AppDelegate.cs
Remove test setting
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
* Update Issue7035.xaml
Shane Neuville [Thu, 26 Sep 2019 09:29:32 +0000 (03:29 -0600)]
fix android foreground tinting (#7682) fixes #7577
Rui Marinho [Thu, 26 Sep 2019 09:12:54 +0000 (10:12 +0100)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Wed, 25 Sep 2019 16:49:26 +0000 (10:49 -0600)]
fix android apk path for ui tests (#7657)
Shane Neuville [Wed, 25 Sep 2019 14:43:20 +0000 (08:43 -0600)]
only set elevation on Lollipop and up (#7662)
Shane Neuville [Wed, 25 Sep 2019 00:35:33 +0000 (18:35 -0600)]
Try catch Update Bitmap and equate null to empty for FontFamily Check (#7611) fixes #7598 fixes #7597
adrianknight89 [Tue, 24 Sep 2019 21:39:57 +0000 (16:39 -0500)]
[iOS] Make button click easier to see when turning on CollectionView flag (#7617)
* make button click easier to see
* remove private
* changed event handler name
Stephane Delcroix [Tue, 24 Sep 2019 08:18:06 +0000 (10:18 +0200)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Tue, 24 Sep 2019 00:32:55 +0000 (18:32 -0600)]
set android app to not clear data on restart (#7640)
Gerald Versluis [Mon, 23 Sep 2019 23:04:24 +0000 (01:04 +0200)]
[Mac] Fix NRE on setting non-existing FontFamily (#7636) fixes #7582
* Update FontExtensions.cs
* Added issue to gallery
Rui Marinho [Mon, 23 Sep 2019 23:02:47 +0000 (00:02 +0100)]
[iOS,Android] Better way to get CurrentItem (#7587)
* [iOS] Fix finding center cell
* [UITests] Fix drag on vertical
* [UItests] Make uitest more reliable
* [iOS] Simplify set current item
* [Android] Use scrolled to get CurrentItem
* [UITests] Fix UItests on api19 android
* [Android] Fix merge
Shane Neuville [Mon, 23 Sep 2019 20:36:34 +0000 (14:36 -0600)]
Add retry logic for IsFocus test (#7619)
Javier Suárez Ruiz [Mon, 23 Sep 2019 06:17:44 +0000 (08:17 +0200)]
[CarouselView] Fix CarouselView initial position on Android (#7592)
* Fixed Android CarouselView initial position issue
E.Z. Hart [Fri, 20 Sep 2019 22:03:55 +0000 (16:03 -0600)]
Finish ScrollTo implementations for CollectionView on UWP (#7509) partially implements #3172
* Finish ScrollTo implementations for CollectionView on UWP
* Fix NRE when attempting to scroll to index greater than source length
E.Z. Hart [Fri, 20 Sep 2019 17:37:15 +0000 (11:37 -0600)]
Make sure transition from empty CollectionView measures cell size; fixes #7472 (#7580)
fixes #7472
fixes #7548
adrianknight89 [Fri, 20 Sep 2019 16:57:05 +0000 (11:57 -0500)]
[Android] Fix ItemSpacing for last item in CollectionView (#7516)
* fix item spacing
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
Stephane Delcroix [Thu, 19 Sep 2019 13:58:29 +0000 (15:58 +0200)]
[X] do not fail on generic BP (#7588)
While looking for a potential TypeConverter attribute on the static getter of a
generic attached BP, resolve the generic return type.
- fixes #7559
Stephane Delcroix [Thu, 19 Sep 2019 10:33:32 +0000 (12:33 +0200)]
[C] Fix TemplateBinding for non-logicalchildren (#7506)
Spans, e.g., are no LogicalChildren of FormattedString, which is not a
LogicalChildren of Label. The newly introduced way of propagating the
TemplatedParent was top-down, using LogicalChildren, was not assigning
the correct TemplatedParent on Spans.
This reverts to a bottom-up lookup, hooking on ParentSet, like it used to
be.
As a side effect, the TemplateBindings are no longer updated on reparenting,
but this was the original behavior, and I can't think of a case where this
would be needed.
The regression to `{TemplateBinding}` was introduced by #4375.
- fixes #7494
Stephane Delcroix [Wed, 18 Sep 2019 14:41:18 +0000 (16:41 +0200)]
[X] avoid throwing in VisualDiagnostics (#7571)
this fixes a regression introduced in #7474
- fixes #7570
Pavel Yakovlev [Tue, 17 Sep 2019 22:50:33 +0000 (01:50 +0300)]
removed MatchParent value from Property Editor (#7551)
Pavel Yakovlev [Tue, 17 Sep 2019 22:35:37 +0000 (01:35 +0300)]
[C] added intellisense for Keyboard property (#7553) fixes azdo 835646
Rui Marinho [Tue, 17 Sep 2019 22:30:30 +0000 (23:30 +0100)]
Merge branch '4.2.0' into 4.3.0
Morten Nielsen [Tue, 17 Sep 2019 22:26:56 +0000 (15:26 -0700)]
Adds UWP support to Shell (#6015)
* Some basics to get started
* more renderers
* Fix titlebar color
* More shell stuff working
* Hacked some more UI in
* Fix null ref issue
* Move renderer registration outside common code (for now)
* Re-write of the renderers to better use a cleaner UWP approach
* Moved functionality around, bug fixesetc
* Added null check
* Added null-check on appearance and use default colors as fallback
* Handle change in flyout behavior to correctly turn the flyout on/off
* Handle the TabBarIsVisible property
* code formatting
* Ensure FlyoutHeader isn't show if the app starts up with a minimal pane
* Throw if used on versions lower than Windows 10 1809
* Added null-check for when ShellContent isn't set
* Support tabs in FlyoutItems with Display AsMultipleItems by using the generated FlyoutGroupings instead
* Improve pane behavior and styling
* Undo Android change used during testing
* Fix platform support check
* Use FileImageSourcePathConverter on NavigationViewItem instead of a custom control (so I deleted ShellNavigationViewItemRenderer which is no longer needed).
Ensure `FileImageSourcePathConverter` won't throw if it didn't get a FileImageSource.
Move the flyout data templates into a resource so they can be overridden and compiled.
* Delete renamed file
* Use a resource instead of parsing a string template
* Handle search box property changes
* Update page title on property change
* Update bottombar when shellitems change
* Guard against API usage not present
* Platform check comments
* Fix problem running in release mode (use Bindable to generate XamlMetadata
* Trigger rebind of menu items source when collection changes
* Added support for Toolbar
* Fix searchbox behavior (still lacks expand/collapse feature)
* Add overload for defining the navigation transition
* Use different navigation transitions based on navigatin direction
* Hides header with show / hide nav command
* collapses header area on hide nav
* Move to use WinUI
* Fix runtime issues after merge.
* - rebase fixes
* - rebase fixes
* - fix spaces/tabs
* - flags, hide apis, delete assembly info
* - set flag on UWP CG
* - expose renderer creations and make them all public
* - formatting fixes
* - address PR comments
* - fix header so it's full width and swappable
Shane Neuville [Tue, 17 Sep 2019 22:12:16 +0000 (16:12 -0600)]
Additional proguard classes (#7527) fixes #5742
Andrei [Tue, 17 Sep 2019 21:40:21 +0000 (00:40 +0300)]
[macOS] PushModalAsync a 2nd time causes a crash (#7250) fixes #6866
* fixes https://github.com/xamarin/Xamarin.Forms/issues/6866
* fixed index boundaries to include 0 index
Javier Suárez Ruiz [Tue, 17 Sep 2019 20:33:55 +0000 (22:33 +0200)]
Implement CarouselView on UWP (#7503)
* Implemented CarouselView on UWP
* Implemented CurrentItem on Carousel UWP
* Fixed ArgumentOutOfRangeException with the Carousel position
* Removed code to update the CurrentItem on UWP (review it to improve)
Rui Marinho [Tue, 17 Sep 2019 20:31:01 +0000 (21:31 +0100)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Tue, 17 Sep 2019 15:46:55 +0000 (09:46 -0600)]
Check to see if the BeginRefresh request is no longer needed (#7514) fixes #7313
* fix refresh to not fire twice
* - add automated ui test
adrianknight89 [Tue, 17 Sep 2019 12:42:36 +0000 (07:42 -0500)]
[Android] Refactor the code for setting reverse layout in ItemsViewRenderer (#7468)
* refactor
* fix
* remove the return keyword
Shane Neuville [Tue, 17 Sep 2019 09:32:57 +0000 (03:32 -0600)]
[Android/iOS] Update CollectionView when user changes out the header/footer (#7499)
* update cv when user changes out the header/footer
* - fix android to convert back from pixels on scroll
- fix iOS offset on scroll args to account for header size and content inset
* - fix for new api
* - fix redundant BP
Shane Neuville [Tue, 17 Sep 2019 08:56:36 +0000 (02:56 -0600)]
Add null check when using tablet on MDP (#7513) fixes #7496
E.Z. Hart [Tue, 17 Sep 2019 08:41:00 +0000 (02:41 -0600)]
Remove extra brace; fixes #7545 (#7546)
adrianknight89 [Tue, 17 Sep 2019 08:38:48 +0000 (03:38 -0500)]
[iOS] Remove class variable from CarouselViewLayout whose value is always true (#7484)
* remove unused variable
* comment change
Shane Neuville [Tue, 17 Sep 2019 01:26:30 +0000 (19:26 -0600)]
update unit test to nunit3 apis (#7543)
Rui Marinho [Tue, 17 Sep 2019 00:10:13 +0000 (01:10 +0100)]
Merge branch '4.2.0' into 4.3.0
Shane Neuville [Mon, 16 Sep 2019 22:10:15 +0000 (16:10 -0600)]
await tasks on ViewUnitTests and update MSBuild Locator (#7542)
Konrad Müller [Mon, 16 Sep 2019 21:06:49 +0000 (23:06 +0200)]
[macOS] Only use default font size for Time/DatePicker to avoid clipping issues (#7183)
* Only use default font size
* Always use default font size
* Remove duplicated code
* Remove extra spacing
Shane Neuville [Mon, 16 Sep 2019 15:48:52 +0000 (09:48 -0600)]
Tweak unit test so it's more reliable and fix binlog path (#7530)
* tweak unit test and fix bl path
* - change test to use ThrowsAsync
* - fix for nunit 2
E.Z. Hart [Mon, 16 Sep 2019 14:23:55 +0000 (08:23 -0600)]
Fix horizontal layout issues introduced in 7456; fixes #7519 fixes #7524 (#7522)
E.Z. Hart [Mon, 16 Sep 2019 13:02:58 +0000 (07:02 -0600)]
Implement EmptyView on UWP (#7438)
Javier Suárez Ruiz [Mon, 16 Sep 2019 12:13:07 +0000 (14:13 +0200)]
Added Carousel SnapBehavior Core sample (#7444)
ShaneN [Sun, 15 Sep 2019 00:52:56 +0000 (18:52 -0600)]
merge 4.2.0 into 4.3.0
Shane Neuville [Sun, 15 Sep 2019 00:40:55 +0000 (18:40 -0600)]
Check if Control is ready before interacting with Native control (#7523)
* Check if control is ready before setting Text
* - make 7.0 compatible
E.Z. Hart [Fri, 13 Sep 2019 09:55:27 +0000 (03:55 -0600)]
Remove extra properties from CarouselView API (#7456)
* Remove Header/Footer properties from CarouselView
* Limit CarouselView to LinearItemsLayout
* Rework inheritance for UWP
* Split files by class
* Fix up Tizen renderer
Samantha Houts [Thu, 12 Sep 2019 22:55:09 +0000 (15:55 -0700)]
Merge branch '4.2.0' into 4.3.0
Samantha Houts [Thu, 12 Sep 2019 22:52:45 +0000 (15:52 -0700)]
Merge branch '4.1.0' into 4.2.0
Jonathan Peppers [Thu, 12 Sep 2019 22:36:35 +0000 (17:36 -0500)]
[xamlc] new <XFXamlCValidateOnly> MSBuild property for Debug builds (#7407)
XamlC is currently enabled for most Xamarin.Forms projects in `Debug`
and `Release` configurations. It enables faster startup/runtime
performance, XAML-syntax checking at build time--both quiet useful!
However, there is a build-time cost to using XamlC: each assembly is
loaded via Mono.Cecil, IL generated, and saved back to disk as an
additional step after Rosyln has compiled the assembly.
The proposal would be to add a new experimental MSBuild property, that
can be enabled for `Debug` mode such as:
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<!-- ... -->
<XFXamlCValidateOnly>True</XFXamlCValidateOnly>
</PropertyGroup>
This would do the following:
* `OptimizeIL` is skipped.
* Assemblies are analyzed, but no changes written to disk.
* No symbols are loaded via Mono.Cecil, we don't need them if we
aren't writing back to disk!
This will improve build performance, and we don't lose the build-time
error checking for XAML.
Down the road, we could consider moving the MSBuild property to be the
default for `Debug` builds or change the Xamarin templates. I think it
would be wise to require developers to opt-in to try this out.
~~ Results ~~
I tested this change by building the ControlGallery after changing one
line of XAML:
msbuild Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj /clp:performancesummary /p:XFXamlCValidateOnly=True
Before:
1979 ms XamlCTask 1 calls
After:
923 ms XamlCTask 1 calls
I *only* tested `Debug` builds.
Right, so it's faster. But let's keep the entire developer loop in
mind, how much slower is startup?
Before:
09-05 14:37:32.274 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s890ms
09-05 14:38:30.178 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s848ms
09-05 14:38:40.300 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s848ms
After:
09-05 14:40:38.512 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s894ms
09-05 14:40:55.497 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s856ms
09-05 14:41:03.754 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s897ms
After three runs, it seems this app suffers 25-50ms slowdown to
startup, and gains 1 second of build time improvement. A good net-win!
Other apps that have significantly more XAML will have different
results. I suspect the build time improvement will be even better, but
the hit to startup could be worse. With this setting opt-in, we can
experiment and find out.
Mahmoud Ali [Thu, 12 Sep 2019 22:36:02 +0000 (19:36 -0300)]
Warn on Styles validation instead of throwing exception (#7495)
* Warn on Styles validation instead of throwing exception
* Correct tests
fixes #6907
Shane Neuville [Thu, 12 Sep 2019 21:27:04 +0000 (15:27 -0600)]
add check to see if ShellContent is Visible one (#7460)
Shane Neuville [Thu, 12 Sep 2019 20:06:39 +0000 (14:06 -0600)]
fix NRE on _itemsSource when using IEnumerable (#7480)
Samantha Houts [Thu, 12 Sep 2019 20:02:49 +0000 (13:02 -0700)]
[iOS] If ListView is disposed before callback happens, return early (#7428)
* Add test case
* Update Issue7371.cs
* Update Issue7371.cs
* [iOS] If ListView is disposed before callback happens, return early
fixes #7371
Stephane Delcroix [Thu, 12 Sep 2019 00:35:40 +0000 (02:35 +0200)]
visualDiagnostics (#7474)
Javier Suárez Ruiz [Wed, 11 Sep 2019 23:40:26 +0000 (01:40 +0200)]
Hide some CarouselView methods from IntelliSense (#7475)
* Hide SetCurrentItem and SetIsDragging CarouselView methods from Intellisense
* Added required using to use EditorBrowsable
E.Z. Hart [Wed, 11 Sep 2019 23:31:29 +0000 (17:31 -0600)]
Leave BindingContext intact when recycling TemplatedItemViewHolder (#7426) fixes #6889
Fixes #6889
Shane Neuville [Wed, 11 Sep 2019 17:29:17 +0000 (11:29 -0600)]
Fix direction of walking when calculating effective FlyoutBehavior (#7459)
* fix direction of walking
* Update Xamarin.Forms.Core/Shell/Shell.cs
Shane Neuville [Wed, 11 Sep 2019 16:28:21 +0000 (10:28 -0600)]
move await to Begin Invoke and check for disposed (#7192)
Shane Neuville [Wed, 11 Sep 2019 07:14:27 +0000 (01:14 -0600)]
Wrong type checked after casting to type being searched for (#7461)
* wrong type checked when searching for parent
* Update Xamarin.Forms.Platform.Android/ViewExtensions.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* - add api level check for ui tests
- fixes #7329
Shane Neuville [Wed, 11 Sep 2019 07:10:59 +0000 (01:10 -0600)]
Dispose of HttpResponseMessage after stream is used (#7431)
- fixes #7248
ShaneN [Tue, 10 Sep 2019 21:32:39 +0000 (15:32 -0600)]
Merge 4.2.0 into 4.3.0
Shane Neuville [Tue, 10 Sep 2019 21:25:17 +0000 (15:25 -0600)]
Update support libraries from 28.0.0.1 to 28.0.0.3 (#7389)
* update support to 28.0.0.3
* - bump sandbox support versions
* - update nuspecs
Shane Neuville [Tue, 10 Sep 2019 15:05:55 +0000 (09:05 -0600)]
[Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332) (#7031)
* [Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332)
* - increment test nugets
* - adapter folder
* - uitest version
* add wait for 34632
E.Z. Hart [Mon, 9 Sep 2019 15:46:07 +0000 (09:46 -0600)]
[iOS] More intelligent cell resizing (#7285)
* More intelligent cell resizing; fix infinite layout loop and crash;
Reuse template views instead of re-creating them every time;
Fixes #7128
* Fix attribute ambiguity
* Drop trailing 'and'
E.Z. Hart [Mon, 9 Sep 2019 11:00:04 +0000 (05:00 -0600)]
Implement Move, Replace, and Reset for UWP CollectionView collection changes (#7384)
Stephane Delcroix [Mon, 9 Sep 2019 07:50:17 +0000 (09:50 +0200)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Sat, 7 Sep 2019 22:07:50 +0000 (23:07 +0100)]
[UItests] Fix CarouselView tests (#7379)
* Update testcloud agent
* [UITests] Fix uitests for CarouselView
* [UITests] Fix the rest of uitests for the position
* [UITests] Use the drag api to swipe the Carousel
* Update CarouselViewUITests.cs
* [Uitests] Enable CarouselViewVertical
* [UITests] Try a new fix for UITests
Shane Neuville [Sat, 7 Sep 2019 07:11:41 +0000 (01:11 -0600)]
[UWP] RefreshView (#7319)
* UWP Swipe Refresh implementation
* - target platform warnings for UWP
* - move dictionary registration to code
* - remove SkipMicrosoftUIXamlCheckTargetPlatformVersion
Shane Neuville [Sat, 7 Sep 2019 07:09:47 +0000 (01:09 -0600)]
Queue Page.Display actions until platform is ready (#7316)
* Queue Page.Display actions until platform is ready
* - fix click
* - set IsPlatformEnabled enabled for Display tests
Rui Marinho [Thu, 5 Sep 2019 23:33:50 +0000 (00:33 +0100)]
[Build] Bump msbuild locator move to VS2019 (#7415)
* Bump msbuild locator
* Update test adapter
* Update build-windows.yml
* Update azure-pipelines.yml
* Update build-windows.yml
Samantha Houts [Thu, 5 Sep 2019 17:27:20 +0000 (10:27 -0700)]
Merge branch '4.2.0' into 4.3.0
Stephane Delcroix [Thu, 5 Sep 2019 12:18:03 +0000 (14:18 +0200)]
[X] do not throw here
Shane Neuville [Thu, 5 Sep 2019 00:28:24 +0000 (18:28 -0600)]
Fix RTL behavior for MasterDetailsPage when running on iOS 13 iPads (#7271)
* Fix RTL on iOS 13 tablets with MDP
* - add backgrounding extension for iOS
fixes #7224
fixes #7266
Javier Suárez Ruiz [Wed, 4 Sep 2019 22:52:21 +0000 (00:52 +0200)]
Fixed issue updating the PeekAreaInsets property value (#7382)
Javier Suárez Ruiz [Wed, 4 Sep 2019 13:48:51 +0000 (15:48 +0200)]
[Android, iOS] Fix CarouselView Issues (#7366)
* Fixed CarouselViewGalleries sample on Android
* Protect NRE setting the CurrentItem
* Fixed issue changing the ItemsSource
* Fixed issues with NumberOfSideItems and PeekAreaInsects properties on Android
* Fixed formatting
* Fix ItemSpacing issue on Android
* Fixed vertical peek insets iOS
* Center item after change ItemSpacing
Improve IsSwipeEnabled logic on Android (disable swipe but not touch)
* Update max slider value when item count is updated
* Update CarouselCodeGallery.cs
* NoOfSideItems in test page
Shane Neuville [Tue, 3 Sep 2019 23:52:42 +0000 (17:52 -0600)]
Fix iOS footer and header to layout left and right for horizontal layout (#7308) fixes #7246
* fix iOS footer and header to layout left and right for horizontal layout
* - however much
Stephane Delcroix [Tue, 3 Sep 2019 20:45:22 +0000 (22:45 +0200)]
[X] Reuse baseclass namescope if it exists (#7356)
* [X] chain debug ctors
* unit test for 7097
* [X] Reuse baseclass namescope if it exists
If a xaml control derives from another xaml control, thy both should share the same
NameScope. This add a check if the xaml root already has a NameScope (set by the base)
and reuses it.
This fixes 2 regressions introduced by #7040 and some other unreported edge cases.
- fixes #7097
- fixes #7286
* avoid repeting linq queries
E.Z. Hart [Tue, 3 Sep 2019 17:03:16 +0000 (11:03 -0600)]
Verify sections exist before calling NumberOfItemsInSection; fixes #7338 (#7354)
fixes #7338
Kevin Petit [Tue, 3 Sep 2019 16:25:46 +0000 (18:25 +0200)]
[Android] Correctly dispose TabbedPageRenderer (#4974)
* Correctly dispose TabbedPageRenderer.
The fragments created are now removed and the listeners are now correctly cleaned during dispose.
* Added issue UI test.
* Fix carousel fragment manager and pager disposing.
* Fix test 2338 implementation.
* Apply review.
* Set to null fragmentManager on dispose.
* Use GetFragmentManager extension method.
Co-Authored-By: Shane Neuville <shane94@hotmail.com>
* Revert some changes.
* Apply review comment.
bentmar [Mon, 2 Sep 2019 20:26:57 +0000 (22:26 +0200)]
[Android] fix animations not animating (#7298)
* [Android] fix animations not animating
fixes #7255
fixes #7291
fixes #7278
I found that if the Animation duration scale setting has never been changed in the developer settings, the scale we get will allways be 0. So instead of defaulting to 0 we default to 1. This means if i havent touched the setting it will behave as it did pre 4.2.
Also if somehow the context is null, we should default to enabling animations since this is far more "normal" than disabling animations.
* Update Xamarin.Forms.Platform.Android/AndroidTicker.cs
Co-Authored-By: Javier Suárez Ruiz <javiersuarezruiz@hotmail.com>
* Fix code
* Use tabs, return false if fail, enable warning
Shane Neuville [Mon, 2 Sep 2019 16:30:06 +0000 (10:30 -0600)]
[Android] Check if Shell Flyout header is null before trying to use it (#7333)
* Check if flyout header is null
* - remove mono args from csproj
Rui Marinho [Mon, 2 Sep 2019 16:04:57 +0000 (17:04 +0100)]
[iOS] Fix Scrolled, don't use UITableView delegate (#7328)
Stephane Delcroix [Mon, 2 Sep 2019 10:27:44 +0000 (12:27 +0200)]
try fo fix CI builds
Stephane Delcroix [Mon, 2 Sep 2019 08:22:59 +0000 (10:22 +0200)]
Merge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 2 Sep 2019 08:22:06 +0000 (10:22 +0200)]
fix merge issue
Stephane Delcroix [Mon, 2 Sep 2019 06:56:41 +0000 (08:56 +0200)]
Merge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 2 Sep 2019 06:39:59 +0000 (08:39 +0200)]
Merge branch '4.1.0' into 4.2.0
Stephane Delcroix [Mon, 2 Sep 2019 06:38:00 +0000 (08:38 +0200)]
Merge branch '4.0.0' into 4.1.0
Stephane Delcroix [Sun, 1 Sep 2019 21:01:44 +0000 (23:01 +0200)]
[X] Detect empty property value in markups (#7190)
- fixes #7187
kingces95 [Thu, 29 Aug 2019 23:39:49 +0000 (13:39 -1000)]
Fix NRE for gh 4267 (#7306)
Rui Marinho [Thu, 29 Aug 2019 23:26:23 +0000 (00:26 +0100)]
[Feature] CarouselView (#5044)
* [Spec] Draft carousel
* [Core,Spec] Add IndicatorsView
* [iOS] IndicatorsViewRenderer and CarouselVieRenderer draft
* [Controls] Fix controls gallery linker
* [Core] Remove extra file
* Fix Remove IITemsSource
* [iOS] Implement Scroll and selected item
* [iOS,Android,Core] Refactor to use CurrentItem on CarouselView
* [iOS,Core] Add NumberOfVisbileItems
* [iOS,Core] Add IsScrolling and IsDragging
* [iOS,Core] Add Visual state for carousel items
* [iOS,Core] Add padding to CarouselView
* [iOS,Controls] Fix sample, disable selection on CarouselViewController
* [Core] Add Delta to ScrolledDirectionEventArgs
* Update SelectableItemsViewRenderer.cs
* [Controls] Refactor Carousel examples
* [Controls] Fix csproj
* [iOS] Fix bug with insets with carouselview padding
* [Controls] Fix vm for CarouselXamlGallery
* [Controls] Collection Carousel type demo
* [Core] Add other CarouselView Layouts
* Fix Carousel rebase (#6518)
* Fix rebase Android
* Fix rebase iOS
* Update ItemSizingStrategy
* [Core] Add ItemSizingStrategy None
* [iOS] Allow to override ReuseId and RegisterCells from ItemsViewController
* Remove IndicatorsView
* Remove ICarouselViewController
* Implemented IsDragging on Android
* Implemented Scrolled for Android
* Removed Spacing methods
Spacing is now available on a lower level and we don't need to worry about it
* Fix rebase
* [UnitTests] Add basic CarouselView unit tests
* [iOS] Update CarouselViewLayout
* [iOS,Core] Remove Padding and add PeekAreaInsets
* [iOS] Fix peek area insets update on CarouselView
* [iOS,Core] Remove extra scroll code update
* [iOS] Fix bug ScrollAnimationEnded missing
* [Core] Mark BPK as private
* [Core] Rename NumberOfSideItems
* Update ItemsViewRenderer.cs
* [Android] Remove scroll direction update
* First small UI tests
* [iOS] Carousel Apply suggestions from code review
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* More UI tests and plumbing
* Fix build errors
* [Android] Fix CarouselView sizing on Android
* Implemented IsSwipeEnabled iOS
* Implemented bounce iOS
* Merged with scroll changes ItemsView
* Implemented IsBounceEnabled Android
* [Android] Update position
* Update App.cs
* Added CarouselView Core Gallery sample
* Update ItemsViewController.cs
* Fixed Core Gallery problems with Linker
* Added more CarouselView properties to the Core Gallery sample
* Added new CarouselView sample adding and removing items, etc.
* [Android]Add spacing inset for fist and last item
* [Android] ScrollTo and center item on carousel
* Spelling and not breaking build
* [Android]Use SnapHelper to get centered view
* Make Position work (again) for iOS
* Rebase from master (fixed conflicts)
Fixed Android bug related with the first item inset calcs.
fixes #4996
Shane Neuville [Thu, 29 Aug 2019 21:09:34 +0000 (15:09 -0600)]
[Android/iOS] RefreshView (#7214)
* Swipe To Refresh
* pull in pull to refresh
* api changes
* Added RefreshView CoreGallery and Gallery Samples (using ScrollView, ListView, CollectionView, etc.)
* Code refactoring in RefreshViewRenderer (iOS)
* Updated RefreshView Android Renderer
* Fixed RefreshView Android samples in Core Gallery
* Added initial RefreshView UWP implementation
* Added another UWP RefreshView renderer using WinUI NuGet controls (RefreshContainer)
* - additional linker settings
* - uwp fixes
* - disable SkipMicrosoftUIXamlCheckTargetPlatformVersion check
* Update .nuspec/Xamarin.Forms.targets
* Limited RefreshView in Android to support only content using scroll.
Small changes in RefreshView iOS renderer.
Updated Core Gallery RefreshView samples.
* Fixed Visualizer colors in UWP RefreshView
* Added UWP RefreshPullDirection Platform Specific
* Small changes in code syntax in iOS renderer.
* Removed some unnecessary curly braces .
* Register effect provider in iOS RefreshView
* Changes in RefreshView UWP Dispose
* Added conditional code to manage the refresh control differently if it is iOS 10 or higher.
* Fixed error in Android Core Gallery (Linker)
Code refactoring and small changes (PR Feedback)
* Changes disposing the Android renderer
* - fix SkipMicrosoftUIXamlCheckTargetPlatformVersion so it can be turned off
* Removed UWP RefreshView renderer and Platform Specific
* - remove winui from nuspec
* - remove skip checks from targets
* - remove XamlControlsResources
* - remove skip check on UAP platform
* Revert changes in Android Core Gallery manifiest
* Revert unnecessary space in UAP Platform csproj
* Removed unnecessary new line in UWP Resources
* Simplified RefreshView iOS Renderer.
fixes #5882
Samantha Houts [Thu, 29 Aug 2019 18:39:40 +0000 (11:39 -0700)]
[iOS] Fix accessibility regressions with hidden views, WebViews, and layouts (#7213)
* [iOS] Allows views that don't implement ITabStop to be accessible
Also added ITabStop to the WebView renderers
fixes #6894
* [iOS] Don't exclude layouts from a11y tree
fixes #7053
* Add test for 7053
* Add test for 6894
* [iOS] Clear accessibility elements when visibility changes
fixes #6929
* Add test for 6929
* Update Issue6894.cs