profile/ivi/qtdeclarative.git
13 years agoFix VisualDataModel auto test failure.
Andrew den Exter [Mon, 15 Aug 2011 03:30:09 +0000 (13:30 +1000)]
Fix VisualDataModel auto test failure.

Set the DynamicMetaObject flag when constructing an extended type.
Fixes failure introduced in 038619bf2c5e7d2c18a6f463cd994d8b3831e61f.

Change-Id: Idbbbec8f9ec3792b2765639781dba1696fce0a49
Reviewed-on: http://codereview.qt.nokia.com/2927
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
13 years agoRemove \since tags
Alan Alpert [Thu, 11 Aug 2011 09:38:37 +0000 (19:38 +1000)]
Remove \since tags

It's a new module, of course they're new in this version.

Change-Id: I8bce4d452161cd581c046fec62a41cac4e0609ed
Reviewed-on: http://codereview.qt.nokia.com/2854
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoRefactor BasicEmitter into Emitter
Alan Alpert [Thu, 11 Aug 2011 09:36:07 +0000 (19:36 +1000)]
Refactor BasicEmitter into Emitter

No real point having a separate class, and it makes the docs more
complex.

Change-Id: I48aa7bafce541b0b5b792351adb5edf77fc67de2
Reviewed-on: http://codereview.qt.nokia.com/2853
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
13 years agoSameGame refactor
Alan Alpert [Wed, 10 Aug 2011 03:24:37 +0000 (13:24 +1000)]
SameGame refactor

A little more imperative with dialogs controlled from script, but better
separation of GameArea and UI. Also removes old highscore script that
was never used.

Change-Id: Ib244acc90b0fc92b3a6534169e429b6acef0838e
Reviewed-on: http://codereview.qt.nokia.com/2798
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
13 years agoFix race condition in processJobs()
Bea Lam [Thu, 11 Aug 2011 03:26:15 +0000 (13:26 +1000)]
Fix race condition in processJobs()

Don't modify list of running jobs when a job is aborted since the job
may have just started. Wait till the next time processJobs() is invoked
for a new job and discard the aborted job at that time.

(cherry picked from commit f55ecc080d0c5eca4e65a235c63ab13867c86874
in 4.8)

Task-number: QTBUG-20841
Change-Id: Icb4cd089505c0634d3fec023b52c61bbc878404f
Reviewed-on: http://codereview.qt.nokia.com/2837
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoFixed QSGNode leak.
Kim Motoyoshi Kalland [Fri, 12 Aug 2011 11:25:27 +0000 (13:25 +0200)]
Fixed QSGNode leak.

QSGItem was setting its node pointer to 0 without deleting it.

Change-Id: I8b52d02069410b1dfc0057f926a52c946ef348a2
Reviewed-on: http://codereview.qt.nokia.com/2910
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
13 years agoUse the correct export macros
Lars Knoll [Mon, 8 Aug 2011 13:38:21 +0000 (15:38 +0200)]
Use the correct export macros

Otherwise we'll get problems when compiling
on Windows.

Change-Id: I2a366da3cd4cd08ba8bc8d9c8c81409737bee697
Reviewed-on: http://codereview.qt.nokia.com/2752
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoCompile.
Bjørn Erik Nilsen [Thu, 11 Aug 2011 13:23:33 +0000 (15:23 +0200)]
Compile.

Change-Id: I13f95b415b28467617c4ca804e706082150d253e
Reviewed-on: http://codereview.qt.nokia.com/2870
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bjørn Erik Nilsen <bjorn.nilsen@nokia.com>
13 years agoAdded a faster subpixel antialiasing material for distance field text.
Yoann Lopes [Thu, 11 Aug 2011 11:37:23 +0000 (13:37 +0200)]
Added a faster subpixel antialiasing material for distance field text.

Based on two texture samples instead of five.
Can be enabled with qmlscene --text-subpixel-antialiasing-lowq

Change-Id: I726f73d812b93aa9ca38ce142d1e97b9a40d200a
Reviewed-on: http://codereview.qt.nokia.com/2861
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yoann Lopes <yoann.lopes@nokia.com>
13 years agoReplace QScriptBagContainer by QIntrusiveList
Kent Hansen [Thu, 4 Aug 2011 12:19:26 +0000 (14:19 +0200)]
Replace QScriptBagContainer by QIntrusiveList

QIntrusiveList effectively does the same as
QScriptBagContainer, without the need to inherit a
Node class. Let's avoid the code duplication.

However, QIntrusiveList::remove() and insert()
are less strict than QScriptBagContainer; introduce
QScriptIntrusiveList that performs the same sanity
checks (no duplicate insertion, etc). Ideally these
checks would be merged into QIntrusiveList.

Also rename QJSValuePrivate::reinitialize() to
invalidate(), and make it not call
engine->unregisterValue(this) any more. Values are
only invalidated at engine destruction time, and
it's the engine's responsibility to erase the list.

Change-Id: I60fc61ee8f90a716a285b1dd1bf4d6a08a9349df
Reviewed-on: http://codereview.qt.nokia.com/2628
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
13 years agoSet IsDirect flag of property cache data if appropriate
Kent Hansen [Thu, 11 Aug 2011 07:15:38 +0000 (09:15 +0200)]
Set IsDirect flag of property cache data if appropriate

The IsDirect flag was only set in
QDeclarativePropertyCache::append(), but it should be
set in create() as well.

Change-Id: I43c980e5f7e01e44ade662c11c2daf7a9a44d299
Reviewed-on: http://codereview.qt.nokia.com/2844
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoGuard QML-specific handling of value type property access
Kent Hansen [Thu, 11 Aug 2011 07:28:22 +0000 (09:28 +0200)]
Guard QML-specific handling of value type property access

When using QJSEngine, there is no QDeclarativeEngine
associated with the QV8Engine, so check if it's there first.

This was causing the QJS qobject bindings autotest to crash.

Change-Id: If2c1d414d615bfbe93580d06555f5c17b0e41eef
Reviewed-on: http://codereview.qt.nokia.com/2845
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoRemove initialization warnings
Gunnar Sletta [Thu, 11 Aug 2011 05:38:55 +0000 (07:38 +0200)]
Remove initialization warnings

Change-Id: Ie11a91034174b248b564fa5d8af8905a79b6eacf
Reviewed-on: http://codereview.qt.nokia.com/2841
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kim M. Kalland <kim.kalland@nokia.com>
13 years agoRespect $$QT.declarative.bins
Rohan McGovern [Wed, 10 Aug 2011 05:06:35 +0000 (15:06 +1000)]
Respect $$QT.declarative.bins

A module's tools should build directly into $$QT.<module>.bins, just
like its libraries and plugins.

Change-Id: Ic5e885ae0fe99220e07fd643d9bb5b28008e0fa5
Reviewed-on: http://codereview.qt.nokia.com/2802
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
13 years agoMigrate part of QtScript benchmarks to QtDeclarative
Jedrzej Nowacki [Fri, 5 Aug 2011 15:21:20 +0000 (17:21 +0200)]
Migrate part of QtScript benchmarks to QtDeclarative

Benchmarks for QJSValue QJSEngine and for QJSValueIterator were added.

Change-Id: Ie52a3e8f5a461add3269d41d6e9a1a9bfb0c7abd
Reviewed-on: http://codereview.qt.nokia.com/2705
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoCode cleanup: unify QRegExp conversion.
Jedrzej Nowacki [Thu, 4 Aug 2011 13:13:47 +0000 (15:13 +0200)]
Code cleanup: unify QRegExp conversion.

Remove duplicated code for QRegExp conversion.

Change-Id: Ic0a6b68a317404ac6d1695f0220f257046b4ba80
Reviewed-on: http://codereview.qt.nokia.com/2703
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoAdd missing check in QJSValue::property
Jedrzej Nowacki [Thu, 4 Aug 2011 11:20:12 +0000 (13:20 +0200)]
Add missing check in QJSValue::property

Only an object can have a property.

Change-Id: I032cf3a08f777b6b47cb5a417fa796059bfc9ef5
Reviewed-on: http://codereview.qt.nokia.com/2702
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoCode cleanup: unify string conversions.
Jedrzej Nowacki [Thu, 4 Aug 2011 09:21:57 +0000 (11:21 +0200)]
Code cleanup: unify string conversions.

Unify string conversions when there is not any external string wrapper.

Change-Id: I6665e33c968b9d1c6ad86595639967ddcd257667
Reviewed-on: http://codereview.qt.nokia.com/2701
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoCode cleanup.
Jedrzej Nowacki [Thu, 4 Aug 2011 09:17:01 +0000 (11:17 +0200)]
Code cleanup.

Remove redundant else conditions.

Change-Id: I5795bd931d9204a31e0edfea0d3489c119db1020
Reviewed-on: http://codereview.qt.nokia.com/2700
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoReplace duplicated code by a function call.
Jedrzej Nowacki [Thu, 4 Aug 2011 09:12:48 +0000 (11:12 +0200)]
Replace duplicated code by a function call.

According to comment the code was copied from QtScript. As the
implementation is merged to QtDeclarative we can use common code path.

Change-Id: Id603ef0207a1356f8c010a35fe601568a03aac48
Reviewed-on: http://codereview.qt.nokia.com/2699
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoQSGDistanceFieldGlyphCache code refactoring.
Yoann Lopes [Tue, 9 Aug 2011 14:03:42 +0000 (16:03 +0200)]
QSGDistanceFieldGlyphCache code refactoring.

The distance field glyph caches are now contained in the QSGContext.

Change-Id: Ifc5d155917314b1cc5905ef86fdad0bbc5635c7d
Reviewed-on: http://codereview.qt.nokia.com/2787
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
13 years agoAdd support for individual row and column spacing to Grid object.
Glenn Watson [Wed, 10 Aug 2011 03:51:32 +0000 (13:51 +1000)]
Add support for individual row and column spacing to Grid object.

Add rowSpacing and columnSpacing properties to QML Grid object. If
these are specified, use them when laying out the grid. If they are
not specified, default to using the spacing property that was
previously used, so it is backwards compatible.

Task-number: QTBUG-11876
Change-Id: I5c809e89fe124d8d5ea1667b273f19e2c37ff18a
Reviewed-on: http://codereview.qt.nokia.com/2797
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoMake distance field text more easily configurable.
Yoann Lopes [Tue, 9 Aug 2011 09:39:40 +0000 (11:39 +0200)]
Make distance field text more easily configurable.

Custom functions can be provided to compute the distance field threshold
value and antialiasing range.

Change-Id: Ie2ec8160d81671dedf72f0c72c3a5cbdf04d993a
Reviewed-on: http://codereview.qt.nokia.com/2772
Reviewed-by: Yoann Lopes <yoann.lopes@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoAdd documentation
Alan Alpert [Mon, 8 Aug 2011 08:03:31 +0000 (18:03 +1000)]
Add documentation

Copy the documentation back to the scenegraph items, and update it to
the new module syntax.

Change-Id: I5d030a231f991a209a8593ddb069e1b6cd03580e
Reviewed-on: http://codereview.qt.nokia.com/2735
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
13 years agoCopy the docs for QtQuick 1
Alan Alpert [Tue, 9 Aug 2011 01:49:57 +0000 (11:49 +1000)]
Copy the docs for QtQuick 1

Change-Id: Iaaaaaaa13726fa471f94fc7f809911164df24544
Reviewed-on: http://codereview.qt.nokia.com/2755
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
13 years agoRevise QDeclarativeChangeSet.
Andrew den Exter [Mon, 8 Aug 2011 01:57:39 +0000 (11:57 +1000)]
Revise QDeclarativeChangeSet.

Represent moves as associated Removes and Inserts instead of discrete
actions.  Add API for applying a set of changes to another change set.

Change-Id: Id97c1648c7480023dbfef325150bb81c2fea95c0
Reviewed-on: http://codereview.qt.nokia.com/2720
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
13 years agoAdd combustion to examples launcher
Alan Alpert [Wed, 3 Aug 2011 01:29:56 +0000 (11:29 +1000)]
Add combustion to examples launcher

Change-Id: Ie6a7e825afac9a969a71487b93800180ff3be90d
Reviewed-on: http://codereview.qt.nokia.com/2532
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoparse args earlier
Charles Yin [Mon, 8 Aug 2011 01:35:48 +0000 (11:35 +1000)]
parse args earlier

Change-Id: Ie0869d3f70d1e898a9b0635e28bcad2e92fa607c
Reviewed-on: http://codereview.qt.nokia.com/2718
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
13 years agoremove app bundle config for mac
Charles Yin [Mon, 8 Aug 2011 01:35:01 +0000 (11:35 +1000)]
remove app bundle config for mac

Change-Id: I3b526dc556f714b5df712699f64b6bdc51971554
Reviewed-on: http://codereview.qt.nokia.com/2717
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
13 years agoFix broken test (view did not have focus set)
Bea Lam [Mon, 8 Aug 2011 01:15:30 +0000 (11:15 +1000)]
Fix broken test (view did not have focus set)

Change-Id: I25e68df061510deadd946d1a034c114dfd0b4f1c
Reviewed-on: http://codereview.qt.nokia.com/2715
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoadd dummy notify signals to remove warnings
Charles Yin [Mon, 8 Aug 2011 00:12:27 +0000 (10:12 +1000)]
add dummy notify signals to remove warnings

Change-Id: Id8eca4ca2d72a1b3a4293d6ed19ef7f3fdb02d37
Reviewed-on: http://codereview.qt.nokia.com/2712
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agodon't create QApplication if there is already one there
Charles Yin [Sun, 7 Aug 2011 23:45:52 +0000 (09:45 +1000)]
don't create QApplication if there is already one there

Change-Id: Iaf9ebf6855992962abfb3452dc398149af15bbbc
Reviewed-on: http://codereview.qt.nokia.com/2711
Reviewed-by: Charles Yin <charles.yin@nokia.com>
13 years agoShow header/footer if current index is set to first/last item or row
Bea Lam [Fri, 5 Aug 2011 05:48:16 +0000 (15:48 +1000)]
Show header/footer if current index is set to first/last item or row

Task-number: QTBUG-17853
Change-Id: I1d679cee31d6ee2a4bb2f2bf90f73eb12898189b
Reviewed-on: http://codereview.qt.nokia.com/2664
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoListView with StrictlyEnforceRange skips over items
Martin Jones [Fri, 5 Aug 2011 03:44:38 +0000 (13:44 +1000)]
ListView with StrictlyEnforceRange skips over items

When list item size varies smaller items next to larger
items may not be able to become the current item.  Ensure
the snap item is found using the correct range, i.e.
half of previous item above snap pos and half of next item
below.

Change-Id: I52ae235e6b801bda48fcb636bb4150ab643715e8
Fixes: QTBUG-20745
Reviewed-on: http://codereview.qt.nokia.com/2650
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoAdd missing license headers.
Jason McDonald [Thu, 4 Aug 2011 07:42:36 +0000 (17:42 +1000)]
Add missing license headers.

Change-Id: Ib71e988f6a0d87f1f9afe407e206eaa68137a537
Reviewed-on: http://codereview.qt.nokia.com/2604
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoFix outdated license headers.
Jason McDonald [Thu, 4 Aug 2011 06:20:18 +0000 (16:20 +1000)]
Fix outdated license headers.

Change-Id: I81fd41433b03b13befe0b5c68ec248ea71e8c235
Reviewed-on: http://codereview.qt.nokia.com/2596
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoDon't cache model data in VisualDataModel.
Andrew den Exter [Tue, 2 Aug 2011 05:19:06 +0000 (15:19 +1000)]
Don't cache model data in VisualDataModel.

VisualDataModel doesn't have any way to monitor the lifetime of objects
cached other than relying on the source model to emit a changed signal.
If the model doesn't do this or a pointer property is referenced after
an item has been removed from the model then cache can return a stale
pointer.  This can be avoided by querying the model directly whenever
a property is accessed.

Task-number: QTBUG-18036

Change-Id: I7688174c2337cb5c0f77eb7d31a01f4aa958071b
Reviewed-on: http://codereview.qt.nokia.com/2647
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoMove shell example from QtScript to QtDeclarative.
Jedrzej Nowacki [Tue, 2 Aug 2011 07:52:43 +0000 (09:52 +0200)]
Move shell example from QtScript to QtDeclarative.

The example is interesting as debugging tool too.

Change-Id: I9ba69a85f21b776bbfcc65469c8a0e90426f21fd
Reviewed-on: http://codereview.qt.nokia.com/2495
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
13 years agoRemove dead code from QJSValuePrivate
Kent Hansen [Thu, 4 Aug 2011 11:42:15 +0000 (13:42 +0200)]
Remove dead code from QJSValuePrivate

reinitialize() was used to implement setGlobalObject()
and setScriptClass() in the QtScript/V8 port, but those
functions will not be part of the new JS API.

Change-Id: I030d371659136a407636c7a13afe7623a60a2837
Reviewed-on: http://codereview.qt.nokia.com/2623
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
13 years agoMove QJSValue InvalidValue definition to "inline" header
Kent Hansen [Thu, 4 Aug 2011 11:16:12 +0000 (13:16 +0200)]
Move QJSValue InvalidValue definition to "inline" header

Avoid warning "inline function ‘QJSValuePrivate::QJSValuePrivate()’
used but never defined" when only qjsvalue_p.h is included
for a compilation unit.

Change-Id: I75bb49dedbfcedf5f71c25210371f03663572b46
Reviewed-on: http://codereview.qt.nokia.com/2620
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
13 years agoAdd QIntrusiveList::contains() function
Kent Hansen [Wed, 3 Aug 2011 13:05:25 +0000 (15:05 +0200)]
Add QIntrusiveList::contains() function

QIntrusiveList is nice, but it needs a contains() function.

Change-Id: I17adf63db080ffd39acac18cd8ecb23e48d76ed6
Reviewed-on: http://codereview.qt.nokia.com/2569
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoRemove dead code.
Jedrzej Nowacki [Wed, 3 Aug 2011 15:07:17 +0000 (17:07 +0200)]
Remove dead code.

Structure was not used.

Change-Id: Ib3a67f8a1850c211bb0b0700c10153eb9ab6441a
Reviewed-on: http://codereview.qt.nokia.com/2583
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoFix ListView refill() where delegate size == 0
Bea Lam [Wed, 3 Aug 2011 05:40:58 +0000 (15:40 +1000)]
Fix ListView refill() where delegate size == 0

When refilling, if a delegate item is positioned at the start of the
buffer, it should only be removed if its height is > 0. Otherwise
refill() will constantly remove it in removeNonVisibleItems() and
add it again in the next frame in addVisibleItems().

Regression from aa99d4f5cb4f1f512d1db90536752b518dbea449

Task-number: QTBUG-20712
Change-Id: I21d25fde21e0b559a378c9e202ace58947417a4d
Reviewed-on: http://codereview.qt.nokia.com/2541
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoImproved support for multiple to/from values in Transition.
Michael Brasser [Thu, 4 Aug 2011 03:51:24 +0000 (13:51 +1000)]
Improved support for multiple to/from values in Transition.

Trim the strings (previously "state1,state2" would work, but not
"state1, state2", and document the feature.

Task-number: QTBUG-14713
Change-Id: Ie0c5f803754751008c3e1bf766f08914f743338f
Reviewed-on: http://codereview.qt.nokia.com/2592
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoRework threading internals in XmlListModel to avoid global static
Bea Lam [Thu, 4 Aug 2011 05:02:37 +0000 (15:02 +1000)]
Rework threading internals in XmlListModel to avoid global static

QTBUG-20629 reports a crash on destruction of XmlListModel when
cleaning up the global static for the QDeclarativeXmlQuery object.

The fix restructures the internals to be like the threading structure
used for QDeclarativePixmapReader which doesn't use a global static.

Task-number: QTBUG-20629
Reviewed-by: Martin Jones
(cherry picked from commit 422f4e8ec53b917fad09a3e671fd93048dde72ed in
qt-qml-staging:master)

Change-Id: Ic26164947abab67ec9d8f1ae68c20961e7af8a2b
Reviewed-on: http://codereview.qt.nokia.com/2595
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoImprove error messages from compiler for signals and slots
Chris Adams [Wed, 3 Aug 2011 04:00:57 +0000 (14:00 +1000)]
Improve error messages from compiler for signals and slots

This commit ensures that correct line and column information is
provided in some cases (duplicate signal or method name, etc).

Task-number: QTBUG-15076
Change-Id: I483bdc92ef4f1d1d2ff565bb957385fd495672da
Reviewed-on: http://codereview.qt.nokia.com/1619
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoHonour the resettable flag of aliased properties
Chris Adams [Tue, 12 Jul 2011 04:05:24 +0000 (14:05 +1000)]
Honour the resettable flag of aliased properties

Previously, alias properties were not considered isResettable even
if the property they alias is resettable.  This commit ensures that
the IsResettable flag is set for alias properties iff the aliased
property is resettable, and that it is honoured during property
reset operations.

Task-number: QTBUG-18182
Change-Id: I9cab11923a952df72e976a48489a78b24a34314f
Reviewed-on: http://codereview.qt.nokia.com/1471
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoAdd enabled property to Transition.
Michael Brasser [Thu, 4 Aug 2011 00:30:46 +0000 (10:30 +1000)]
Add enabled property to Transition.

Task-number: QTBUG-14488
Change-Id: I3619a0d26e99e2c19f50a63013dedc151b07154c
Reviewed-on: http://codereview.qt.nokia.com/2591
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoFix crash in QDeclarativeProperty
Chris Adams [Wed, 3 Aug 2011 05:45:47 +0000 (15:45 +1000)]
Fix crash in QDeclarativeProperty

This commit ensures that we don't attempt to dereference a null
pointer in QDeclarativeProperty.  It also fixes a unit test failure
by adding appropriate test files.
Related to commit 9f9b23fd7943a3d125cb1cc9f333ce430b2706ea

Task-number: QTBUG-14697
Change-Id: Ic60521e46401835029e293349a00610342d0d58f
Reviewed-on: http://codereview.qt.nokia.com/2538
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoTypo
Aaron Kennedy [Tue, 2 Aug 2011 00:46:23 +0000 (10:46 +1000)]
Typo

Change-Id: I8be86a999eed0cc028415027e888515377cd37ad
Reviewed-on: http://codereview.qt.nokia.com/2461
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoImprove QJSValueIterator implementation.
Jedrzej Nowacki [Tue, 2 Aug 2011 11:14:26 +0000 (13:14 +0200)]
Improve QJSValueIterator implementation.

The old implementation was a hack, it had some memory leak (in case of
deleted engine) and performance problems (for example all names were
copied to separate QList instance instead of reusing v8::Array).

Change-Id: Ic70ad511127a8c05df3c627e4496083004c6452a
Reviewed-on: http://codereview.qt.nokia.com/2512
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
13 years agoRemove FIXME from the v8base.pri
Peter Varga [Mon, 30 May 2011 14:23:29 +0000 (16:23 +0200)]
Remove FIXME from the v8base.pri

Check the version of gcc and use -fno-strict-aliasing flag when it's
4.5.

Merge-request: 1
(This patch was cherry-pick from QtScript module)
Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Change-Id: I0086ec374c7cfd4c0842198734318c915c6cea8d
Reviewed-on: http://codereview.qt.nokia.com/2515
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
13 years agoAdd some guidelines for declaring objects as properties of Components.
Andrew den Exter [Wed, 3 Aug 2011 05:51:06 +0000 (15:51 +1000)]
Add some guidelines for declaring objects as properties of Components.

Task-number: QTBUG-20198
Change-Id: Id8ba8901be6c4f06974d1afd32f1932f867e2544
Reviewed-on: http://codereview.qt.nokia.com/2540
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoPrevent Binding from crashing when its target object is deleted.
Michael Brasser [Wed, 3 Aug 2011 01:01:52 +0000 (11:01 +1000)]
Prevent Binding from crashing when its target object is deleted.

Task-number: QTBUG-20692
Change-Id: Ia9a3d532c45baf01b8c20c7aac9ef373942a75d8
Reviewed-on: http://codereview.qt.nokia.com/2531
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoqmltest: Fix SignalSpy to use TestUtil helper functions
Caio Marcelo de Oliveira Filho [Tue, 2 Aug 2011 23:31:19 +0000 (20:31 -0300)]
qmltest: Fix SignalSpy to use TestUtil helper functions

Previously the callerFile() and callerLine() functions were exposed as
properties of the QtTest module, but now they are available in the
TestUtil component. TestCase was updated but SignalSpy wasn't.

Change-Id: Ic3f35e6f096b28c443e8aadaa78732a8a15dc284
Reviewed-on: http://codereview.qt.nokia.com/2528
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
13 years agoEnable tst_QJSEngine::stacktrace test.
Jedrzej Nowacki [Mon, 1 Aug 2011 11:31:19 +0000 (13:31 +0200)]
Enable tst_QJSEngine::stacktrace test.

The test can be enabled because QJSValueIterator is back.

Change-Id: I33a84b0e584137ecff0d65c2a6152ca972e863f1
Reviewed-on: http://codereview.qt.nokia.com/2440
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
13 years agoEnable globalObjectProperties_enumerate test.
Jedrzej Nowacki [Mon, 1 Aug 2011 10:48:34 +0000 (12:48 +0200)]
Enable globalObjectProperties_enumerate test.

The test can be enabled because QJSValueIterator is back.

Change-Id: I81220ea17470663dab799eb818168480d2df1a54
Reviewed-on: http://codereview.qt.nokia.com/2439
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
13 years agoIntroduced a CONFIG option that enables declarative debug services
Thorbjørn Lindeijer [Mon, 18 Apr 2011 15:20:49 +0000 (17:20 +0200)]
Introduced a CONFIG option that enables declarative debug services

This replaces the need for applications to explicitly make a call to
enable the debug services, and rather does it in declarative.h when the
'declarative_debug' CONFIG option is used.

Done-with: Kai Koehne
Reviewed-by: Martin Jones
Reviewed-by: Michael Brasser
(cherry picked from commit 5517cc588c39814530b8bfd957821f55be42acf2)

Change-Id: Iacfc5a9b2ca0c2610288cf86f190b4a9950cacd1
Reviewed-on: http://codereview.qt.nokia.com/2436
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoAdd a currentItem property to PathView.
Andrew den Exter [Mon, 1 Aug 2011 03:09:10 +0000 (13:09 +1000)]
Add a currentItem property to PathView.

Task-number: QTBUG-16347
Change-Id: I6df4b2d7c5f325e84d54ed5befd66e20b64cc7e0
Reviewed-on: http://codereview.qt.nokia.com/2421
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoCancel mousearea pressed state when window is deactivated
Charles Yin [Fri, 29 Jul 2011 00:38:35 +0000 (10:38 +1000)]
Cancel mousearea pressed state when window is deactivated

Change-Id: I1cc21c338576a2ac3b1e8e282e8e4de3bc63759a
Task-number:QTBUG-19904
Reviewed-on: http://codereview.qt.nokia.com/2357
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoEnsure that the prototype chain is checked in property Get
Chris Adams [Tue, 12 Jul 2011 05:55:01 +0000 (15:55 +1000)]
Ensure that the prototype chain is checked in property Get

This commit ensures that the prototype chain is checked during
property Get operations on QObjects and other types in QML by
returning an empty handle from the property Get interceptor if
no valid property with the given name is found.

Task-number: QTBUG-20336
Change-Id: I670ee211c74c0fdcb68c3f91b29fcc0ea8b55d6f
Reviewed-on: http://codereview.qt.nokia.com/1477
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
13 years agoAdd support for comparing value-type properties
Chris Adams [Tue, 2 Aug 2011 00:04:16 +0000 (10:04 +1000)]
Add support for comparing value-type properties

This commit allows value-types to be compared with each other and
with variants.  It also adds a toString() function for each value
type, to allow conversion to (and comparison with) string.

Task-number: QTBUG-14731
Change-Id: I5bde2820917b2fe19b581724977398680617de34
Reviewed-on: http://codereview.qt.nokia.com/1636
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoFix content position for key navigation with StrictlyEnforceRange
Bea Lam [Mon, 1 Aug 2011 06:56:45 +0000 (16:56 +1000)]
Fix content position for key navigation with StrictlyEnforceRange

If a ListView had highlight ranges and StrictlyEnforceRange, but no
highlight item, the content would not move to the correct position
when incrementCurrentIndex() and decrementCurrentIndex() were invoked.

trackedPositionChanged() shouldn't take the current section pos into
account because this is already calculated by FxListItemSG::position()
(this wasn't the case when the code in trackedPositionChanged() was
originally written).

Task-number: QTBUG-20287
Change-Id: I1624b5afd1efbe27630349143b7af2b486cfa260
Reviewed-on: http://codereview.qt.nokia.com/2429
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agosync.profile: remove dependency on qtscript
Rohan McGovern [Sun, 31 Jul 2011 23:22:06 +0000 (09:22 +1000)]
sync.profile: remove dependency on qtscript

Since d410ad364ec0b8877797145c68a4d7c3c98ce1c0, qtdeclarative does not
depend on qtscript.

Change-Id: I29f6eed7fa399fab16eae9493b0dae4ad4d505d7
Reviewed-on: http://codereview.qt.nokia.com/2406
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoViews with no delegate crash when items are inserted.
Martin Jones [Tue, 2 Aug 2011 03:58:49 +0000 (13:58 +1000)]
Views with no delegate crash when items are inserted.

Check that we have a valid VisualModel before reacting to model
changes.

Change-Id: I6107e8fb8942a3625e501ab549a337f1affd4fbd
Fixes: QTBUG-20640
Reviewed-on: http://codereview.qt.nokia.com/2481
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoAllow descendant chains to simultaneously be hovered.
Alan Alpert [Mon, 1 Aug 2011 06:20:26 +0000 (16:20 +1000)]
Allow descendant chains to simultaneously be hovered.

Matches GV behaviour. Also fixes a bug in QSGMouseArea,
which we aren't fixing for QtQuick 1.

Task-number: QTBUG-18175
Change-Id: I4ecac7b908504f28de830732c731281407d7b0bc
Reviewed-on: http://codereview.qt.nokia.com/2422
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
13 years agoCall base class init() from QSGListViewPrivate
Bea Lam [Tue, 2 Aug 2011 00:53:52 +0000 (10:53 +1000)]
Call base class init() from QSGListViewPrivate

Regression from 9b5f9c8056186c9cf3c40dbac66e5f90369339dc when
QSGItemView was created.

Also fixed other reimplemented methods in QSGListViewPrivate to call
their base class functions (which are currently empty) and changed
some virtual methods in QSGItemViewPrivate to non-virtual where they
didn't need to be virtual.

Task-number: QTBUG-20679
Change-Id: I489593b3eab4f5bbb4126906f170342d1e8811cd
Reviewed-on: http://codereview.qt.nokia.com/2462
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoFix broken GridView moved() test
Bea Lam [Tue, 2 Aug 2011 04:36:12 +0000 (14:36 +1000)]
Fix broken GridView moved() test

Test values for moving multiple items were incorrect.

Change-Id: I184afee6c44df240ef39450c530ff5991cd591e5
Reviewed-on: http://codereview.qt.nokia.com/2485
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoNesting PathView and Flickable causes PathView to stop at wrong offset
Martin Jones [Mon, 1 Aug 2011 05:49:33 +0000 (15:49 +1000)]
Nesting PathView and Flickable causes PathView to stop at wrong offset

Don't stop current animation until a drag is actually initiated.
Also ensure we handle a stolen grab sensibly.

Change-Id: I0ad493595fb85e1c9bace2d805184f911341fce2
Fixes: QTBUG-19439
Reviewed-on: http://codereview.qt.nokia.com/2420
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
13 years agoView highlight could stop tracking currentItem.
Martin Jones [Mon, 1 Aug 2011 05:00:30 +0000 (15:00 +1000)]
View highlight could stop tracking currentItem.

This happens if the currentIndex is changed
while the view is moving.  The only time the highlight should
not move to the currentItem is in StrictlyEnforceRange mode when
the user is moving the view.

Change-Id: I4d04174c88cde180f9f8a01cbd33af3edbcc3d4d
Fixes: QTBUG-16936
Reviewed-on: http://codereview.qt.nokia.com/2416
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoAllow custom parser types to still get signal handlers generated
Alan Alpert [Mon, 1 Aug 2011 08:26:57 +0000 (18:26 +1000)]
Allow custom parser types to still get signal handlers generated

Specifically, QDeclarativeListModelParser ought to have this behaviour.

Task-number: QTBUG-19763
Change-Id: I9d6ee07d1e17a027b254b87d20d1a93795c55744
Reviewed-on: http://codereview.qt.nokia.com/2431
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoDon't enable qmlscene compability mode for commented out imports.
Andrew den Exter [Mon, 1 Aug 2011 06:27:01 +0000 (16:27 +1000)]
Don't enable qmlscene compability mode for commented out imports.

Valid import statements should be at the start of a line, maybe
preceded by some white space.

Task-number: QTBUG-20649
Change-Id: I1944bce0d30e680ebdb0798f5ae4e8c91a057a13
Reviewed-on: http://codereview.qt.nokia.com/2423
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agodefine for timing
Gunnar Sletta [Mon, 1 Aug 2011 11:30:46 +0000 (13:30 +0200)]
define for timing

Change-Id: Id91e47be0c2706de7871f3492725c577063ae5fb
Reviewed-on: http://codereview.qt.nokia.com/2438
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
13 years agoAdd Image changes to whatsnew.qdoc
Yann Bodson [Mon, 1 Aug 2011 04:57:12 +0000 (14:57 +1000)]
Add Image changes to whatsnew.qdoc

Change-Id: Ie197d8a6a927d9250ca975ae602b827fb894f39e
Reviewed-on: http://codereview.qt.nokia.com/2415
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
13 years agoFix Binding to correctly restore bindings even when a binding loop is involved.
Michael Brasser [Mon, 1 Aug 2011 02:32:10 +0000 (12:32 +1000)]
Fix Binding to correctly restore bindings even when a binding loop is involved.

Change-Id: Ie8f9731d9f4834d8b94272ef792dc7ad0235ce78
Reviewed-on: http://codereview.qt.nokia.com/2409
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoCorrectly pause animation when paused in starting ScriptAction.
Michael Brasser [Mon, 1 Aug 2011 00:43:54 +0000 (10:43 +1000)]
Correctly pause animation when paused in starting ScriptAction.

Task-number: QTBUG-13598
Change-Id: Ibd54f4e014eff301b57451081b7f7b35d1bed740
Reviewed-on: http://codereview.qt.nokia.com/2408
Reviewed-by: Charles Yin <charles.yin@nokia.com>
13 years agoMerge the QJSEngine and QJSValue development branch into master.
Simon Hausmann [Fri, 29 Jul 2011 08:25:44 +0000 (10:25 +0200)]
Merge the QJSEngine and QJSValue development branch into 

This replaces the dependency to QtScript with two new builtin classes
QJSValue and QJSEngine.

This is still work in progress, development continues now in the master branch.

Change-Id: I7f5487feb45c972f25a22b10cc81b9218b9805de
Reviewed-on: http://codereview.qt.nokia.com/2299
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
13 years agoBump the XmlListModel get test import to QtQuick 2.0.
Andrew den Exter [Fri, 29 Jul 2011 07:49:04 +0000 (17:49 +1000)]
Bump the XmlListModel get test import to QtQuick 2.0.

Change-Id: I62d65f24fac2b56b7f3efff5dc6e2e9056f53edd
Reviewed-on: http://codereview.qt.nokia.com/2383
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
13 years agoDocument (lack of) support for sharing animation instances.
Michael Brasser [Fri, 29 Jul 2011 06:55:22 +0000 (16:55 +1000)]
Document (lack of) support for sharing animation instances.

Task-number: QTBUG-19040
Change-Id: Iacbd16bdf48c95bc9e84cac3bd3f704c35a03707
Reviewed-on: http://codereview.qt.nokia.com/2381
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoEnsure bindings on pause work correctly.
Michael Brasser [Fri, 29 Jul 2011 03:10:25 +0000 (13:10 +1000)]
Ensure bindings on pause work correctly.

Defer the actual pause, in the same way we defer the actual start.

Task-number: QTBUG-19080
Change-Id: I500e5aa6678cbb5321979fda31f60d6d6e19a61e
Reviewed-on: http://codereview.qt.nokia.com/2366
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
13 years agoDoc
Aaron Kennedy [Fri, 29 Jul 2011 04:17:11 +0000 (14:17 +1000)]
Doc

Change-Id: I46c4ec5f41e5a1074d8c01f883409ee439bd09e2
Task-number: QTBUG-19741
Reviewed-on: http://codereview.qt.nokia.com/2368
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoMark objects from Component.createObject() as destructible
Aaron Kennedy [Fri, 29 Jul 2011 03:53:35 +0000 (13:53 +1000)]
Mark objects from Component.createObject() as destructible

Change-Id: I00a1a2b5cca80c3e2ea097690cadf21581e1356d
Task-number: QTBUG-20626
Reviewed-on: http://codereview.qt.nokia.com/2367
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoFix alias warnings in QDeclarativeCompiler
Aaron Kennedy [Fri, 29 Jul 2011 02:28:09 +0000 (12:28 +1000)]
Fix alias warnings in QDeclarativeCompiler

Task-number: QTBUG-19736 QTBUG-19693

Change-Id: Ice6b9e0d4f11c75350a3028af5d2479d435d1f69
Reviewed-on: http://codereview.qt.nokia.com/2364
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoFix alias warnings in QV8QObjectWrapper
Aaron Kennedy [Fri, 29 Jul 2011 02:28:03 +0000 (12:28 +1000)]
Fix alias warnings in QV8QObjectWrapper

Task-number: QTBUG-19736 QTBUG-19693

Change-Id: I4f6c56dc4f60224dd79e669099c198b883429f54
Reviewed-on: http://codereview.qt.nokia.com/2363
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoFix alias warnings in V4
Aaron Kennedy [Fri, 29 Jul 2011 02:28:00 +0000 (12:28 +1000)]
Fix alias warnings in V4

Task-number: QTBUG-19736 QTBUG-19693

Change-Id: I6b9c2c167bfe60bcd3c5af7d53ec79c5eec60b74
Reviewed-on: http://codereview.qt.nokia.com/2362
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoFix alias warnings in QDeclarativeVME
Aaron Kennedy [Fri, 29 Jul 2011 02:27:54 +0000 (12:27 +1000)]
Fix alias warnings in QDeclarativeVME

Task-number: QTBUG-19736 QTBUG-19693

Change-Id: Ieab2c7274852b39fc4222132dedc738ab663d4f9
Reviewed-on: http://codereview.qt.nokia.com/2361
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoAdd sourceComponentChanged signal to Loader
Yann Bodson [Fri, 29 Jul 2011 04:41:16 +0000 (14:41 +1000)]
Add sourceComponentChanged signal to Loader

When setting the 'sourceComponent' property in Loader, we emit
a sourceChanged signal with source == "". We should emit
sourceComponentChanged instead.

Task-number: QTBUG-20628
Change-Id: If5f8f389b7dc214e729b366d82fe4d32827408ee
Reviewed-on: http://codereview.qt.nokia.com/2371
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoDocument state fast-forwarding.
Michael Brasser [Thu, 7 Jul 2011 03:10:35 +0000 (13:10 +1000)]
Document state fast-forwarding.

Task-number: QTBUG-16049

Change-Id: Ib64cc8ec9396d426e623481a69f5a4a1b0fe5ec5
Reviewed-on: http://codereview.qt.nokia.com/2370
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoDocument how to have two MouseAreas simultaneously hovered.
Michael Brasser [Fri, 29 Jul 2011 04:40:59 +0000 (14:40 +1000)]
Document how to have two MouseAreas simultaneously hovered.

Task-number: QTBUG-17228
Change-Id: Icfb3774429f0f19084f126a0b87699f1d03220f6
Reviewed-on: http://codereview.qt.nokia.com/2369
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoFix alias warnings in QDeclarativeV8Handle
Aaron Kennedy [Fri, 29 Jul 2011 02:27:40 +0000 (12:27 +1000)]
Fix alias warnings in QDeclarativeV8Handle

Task-number: QTBUG-19736 QTBUG-19693

Change-Id: I1fd1a3146aa7be933f60917a562211142c2460bc
Reviewed-on: http://codereview.qt.nokia.com/2360
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoFix alias warnings in QDeclarativeGuard
Aaron Kennedy [Thu, 28 Jul 2011 08:39:34 +0000 (18:39 +1000)]
Fix alias warnings in QDeclarativeGuard

Task-number: QTBUG-19736 QTBUG-19693

Change-Id: Id3aefe56bc1e33757b8c407f2022b49cc136f00b
Reviewed-on: http://codereview.qt.nokia.com/2359
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoCorrectly set ending path percent if none is provided.
Michael Brasser [Fri, 29 Jul 2011 00:41:47 +0000 (10:41 +1000)]
Correctly set ending path percent if none is provided.

Task-number: QTBUG-19818
Change-Id: I5377551d041b593864d56e4449c133deb47d3b45
Reviewed-on: http://codereview.qt.nokia.com/2358
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoClicking on a disabled ListView's delegate breaks mouse interaction
Martin Jones [Thu, 28 Jul 2011 23:29:04 +0000 (09:29 +1000)]
Clicking on a disabled ListView's delegate breaks mouse interaction

A disabled Flickable should not filter children.

Change-Id: I9f0d8fbfd0922b5c6a9eaffa69212867359f79e0
Fixes: QTBUG-20584
Reviewed-on: http://codereview.qt.nokia.com/2354
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
13 years agoCode cleanup
Alan Alpert [Fri, 29 Jul 2011 00:35:58 +0000 (10:35 +1000)]
Code cleanup

Change-Id: I97ecc41fcb7255981c863996064cf6d6bae7ebbb
Reviewed-on: http://codereview.qt.nokia.com/2356
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
13 years agoAdd .arg() for Javascript String type
Charles Yin [Tue, 26 Jul 2011 00:47:13 +0000 (10:47 +1000)]
Add .arg() for Javascript String type

Change-Id: I973032189c40bfa4d5450396f5bad1a7c81ac68b
Task-number:QTBUG-16734
Reviewed-by:Michael Brasser
Reviewed-on: http://codereview.qt.nokia.com/2134
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
13 years agoXmlListModel.status is Ready right after creation (should be Null)
Charles Yin [Wed, 27 Jul 2011 02:07:42 +0000 (12:07 +1000)]
XmlListModel.status is Ready right after creation (should be Null)

And whenever both the source the xml properties are empty, the status
should be Null as well.

Change-Id: I62936d9389b524833422a871b596b99cc93cc734
Task-number:QTBUG-18724
Reviewed-by:Michael Brasser
Reviewed-on: http://codereview.qt.nokia.com/2231
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
13 years agoremove motionchart demo (uncompleted)
Charles Yin [Wed, 27 Jul 2011 03:03:59 +0000 (13:03 +1000)]
remove motionchart demo (uncompleted)

Change-Id: I4e6b068ca9ceb0b7f76a6548d1b7a8789bc4bf39
Reviewed-on: http://codereview.qt.nokia.com/2237
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
13 years agoJump to same model index (if it exists) when the model changes
Alan Alpert [Thu, 28 Jul 2011 10:11:52 +0000 (20:11 +1000)]
Jump to same model index (if it exists) when the model changes

For PathView, ListView does this already.

Task-number: QTBUG-19059
Change-Id: Id09087ad372e46661794b0cb15cb30fc88802c4b
Reviewed-on: http://codereview.qt.nokia.com/2330
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoAugment SpringAnimation::damping documentation
Alan Alpert [Thu, 28 Jul 2011 10:21:58 +0000 (20:21 +1000)]
Augment SpringAnimation::damping documentation

Task-number: QTBUG-20120

Change-Id: Ifaa0e7eaa0f61052680338a6cfd35bb6aca63157
Reviewed-on: http://codereview.qt.nokia.com/2333
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
13 years agoDocument stops as default property of Gradient
Alan Alpert [Thu, 28 Jul 2011 06:59:23 +0000 (16:59 +1000)]
Document stops as default property of Gradient

This will hopefully be copied to the QtQuick2 item when we write docs
for them.

Task-number: QTBUG-16045
Change-Id: I427b468630b59bd4bd6eca907ab12a66ee219d29
Reviewed-on: http://codereview.qt.nokia.com/2320
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>