Lars Knoll [Wed, 6 Mar 2013 10:19:02 +0000 (11:19 +0100)]
Fix a bug in Persistent::New
Change-Id: Iac13aa897e64bca6b50ea90bd5e2804e2212e008
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Wed, 6 Mar 2013 10:18:56 +0000 (11:18 +0100)]
Cleanups
Change-Id: Ifbe085eea9f1f605af0b802f299f82f24a14e9b1
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Wed, 6 Mar 2013 08:55:15 +0000 (09:55 +0100)]
Add stubs for all the methods in the v8 API
Qt Qml and Qt Quick now link against V4 :)
Change-Id: I8320875bdeab91d800fbf530b0d57a67dc872188
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 5 Mar 2013 21:41:49 +0000 (22:41 +0100)]
Simplify conversion between VM::Value and V8::Value
Also implement the Exception class and ThrowException.
Change-Id: Ib9ca804cb82288d9da8b74f6cd3c38ecd61dbc1b
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 5 Mar 2013 21:21:40 +0000 (22:21 +0100)]
Implement v8::Undefined/Null/True/False
Change-Id: I831e3b5e53d06edcbce57d37fc43995154b26305
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 5 Mar 2013 19:28:06 +0000 (20:28 +0100)]
Remove API not used by Qml
Change-Id: Ibd202369f320c2db501d7a900941f0734326db7d
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Tue, 5 Mar 2013 16:13:15 +0000 (17:13 +0100)]
Make a V8 hello world actually work.
Change-Id: Ia80004d2104e72e7c871be3582cab26ca9e493bf
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Tue, 5 Mar 2013 15:37:08 +0000 (16:37 +0100)]
Implement v8::Script::Run()
Change-Id: I7456e0a5e389216aac84d3ca9d66cc1e7f688008
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Tue, 5 Mar 2013 15:11:22 +0000 (16:11 +0100)]
Move function execution into a little ExecutionEngine::run helper function
This will allow for re-use from the v8 wrapper API.
Change-Id: I2330432dad43d7fd7af6147e96a0cbbb340cd917
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 15 Feb 2013 13:59:34 +0000 (14:59 +0100)]
Initial v8'ish API wrappers for QML integration
The goal is for these wrappers to exist only for a limited period
of time until all of QML is ported to use pure v4vm.
Change-Id: I4568420a2116420ae6f45bc5eb1e3d464a7c4cc3
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Tue, 5 Mar 2013 12:12:37 +0000 (13:12 +0100)]
Add support for associating external resources with garbage collected JS objects
Change-Id: Ib09096b684997ac77902e3cc50458092e2f569a2
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 15 Feb 2013 13:58:01 +0000 (14:58 +0100)]
Remove unused wtf inclusion from qv4managed.h
This allows including this header file outside of the module, i.e. in
a qml integration.
Change-Id: I0aed18d76dfacfdf5e615cc12f3d2904fcef9091
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Tue, 5 Mar 2013 11:49:35 +0000 (12:49 +0100)]
Rename qv4ir_p.h to qv4jsir_p.h to avoid conflict with qtdeclarative
Change-Id: I0e222141232f191e47950318f8262144de486703
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Mon, 4 Mar 2013 14:30:40 +0000 (15:30 +0100)]
Cleanup unwind handler
Store the platform specific unwind info (CIE/FDE on Linux/Mac x86/x86-64) directly
inside the VM::Function and therefore make all the functions of UnwindHelper static.
Also calculate the function size correctly.
Change-Id: If6a6b92a250044c6799218ef3506f34d630674c7
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Mon, 4 Mar 2013 11:14:54 +0000 (12:14 +0100)]
Cleanup: Rename __builtin_delete_exception_handler
This IR builtin function no more deletes an exception handler, instead it tells
the back-end to stop try catching exceptions. In MASM and Moth this is
implemented by returning from the nested function call initiated by the try.
Change-Id: Ia8336c998817a73aeed03f4a05d4b592cc9143ad
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Mon, 4 Mar 2013 11:12:21 +0000 (12:12 +0100)]
Cleanup: Get rid of manual unwind stack
Instead of doing the ExecutionContext unwinding at the time of throw, do it
at the time of catch, conveniently through an accept() method of the Exception
object. That allows us to get rid of the separate handler registration stack.
The only tricky part are that some execution contexts are allocated on the stack.
When exceptions are thrown through that, we have to catch, unwinding up until that
point (or rather the parent of the stack allocated context that's going to be
deleted) and then simply rethrow.
This patch also gets rid of the __builtin_delete_exception_handler. The next patch
will rename the remainder to what it really does now.
Change-Id: I00bb113b3a2fe24f7054c03fdfb8fed5cc1258b1
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Erik Verbruggen [Mon, 4 Mar 2013 10:17:55 +0000 (11:17 +0100)]
Fix IR control flow after a throw statement.
A throw statement in a try block will now jump to the catch/finally, and
a throw statement outside will jump to the exit block. This follows what
happens during run-time, which fixes liveness issues with the
return-temp of calls to builtin_create_exception_handler.
Change-Id: I70f14f03f0431d3fc962c22984d4f486a1d81c7d
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Mon, 4 Mar 2013 08:32:16 +0000 (09:32 +0100)]
Fix off-by-one in assertion for argc/args in calls.
When a call is done with 1 argument, it is not copied into the outgoing
args array, but passed by-reference. So when it happens to be the last
element in the stack frame, then args + argc == stackSize (because argc
is 1).
Change-Id: Idb769c95e9066c24a9d93cdcc24e13d3a9acc995
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Mon, 4 Mar 2013 10:48:49 +0000 (11:48 +0100)]
Optimise array construction
Cache the InternalClass for ArrayObject and
use it directly in the constructor.
Change-Id: I17346045cd14852c400c7f3886414953e4dff869
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Mon, 4 Mar 2013 10:47:59 +0000 (11:47 +0100)]
Small optimisation for string concatenation
The real fix will require a string class that can hold
several substrings.
Change-Id: I0e23f248048781b0f623d01087397afaeefcc97a
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Fri, 1 Mar 2013 13:34:56 +0000 (14:34 +0100)]
Do not re-use temp for both parameter and result.
Change-Id: Iffd50459bc55960ac5cef1e246cd3d2664565a8a
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Erik Verbruggen [Fri, 1 Mar 2013 13:28:46 +0000 (14:28 +0100)]
Moved isNegative(double) into another header.
So it can be used in codegen.
Change-Id: Iba1294a58cf6785eb9c37b34c39c4ec0281cd694
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Erik Verbruggen [Fri, 1 Mar 2013 13:26:35 +0000 (14:26 +0100)]
Remove shared subexpressions from the function's IR code.
Change-Id: I4502eb9c86aba14142f1ae15f1ba560255a2cb6a
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Erik Verbruggen [Mon, 4 Mar 2013 08:05:38 +0000 (09:05 +0100)]
Fix warning about unused parameter.
Change-Id: Ia94e1ac073dc16a0eb9841677343dbaddad923ae
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 1 Mar 2013 16:04:21 +0000 (17:04 +0100)]
Implement JavaScript exceptions using C++ exceptions
Instead of registering catch handlers with setjmp and throwing JS exceptions
with longjmp, they are now thrown and caught as C++ exceptions. This allows for
tight interoperability between C++ and JS in the future and allows for clear
semantics with regards to cleaning up memory in the engine when throwing
exceptions. (destructors are guaranteed to be called, unlike with
setjmp/longjmp).
The recent unwind table additions allow for the exceptions to be thrown through
JIT generated code.
Catching the exception is done by re-using the existing IR semantics where the
beginning of a try block is marked by registering an exception handler.
Execution after the registration continues conditionally, based on the return
value of builtin_create_exception_handler. A return value of is 0 the try
block(s) are executed. If an exception is thrown during that time, execution
resumes at the point where builtin_create_exception_handler returns, but with a
return value of 1. If an exception is thrown within the catch handler, the
execution resumes again at the same point, but the inCatch IR variable will
guide execution straight to the finally block(s), which calls
delete_exception_handler.
In the JIT as well as the interpreter this is implemented by entering a C++
code section that contains a C++ try {} catch {} block, in which the calling
function is called again and continues right at the next instruction (or the
interpreter loop is recursively entered). An exception will throw us out of
that scope and back into the try {} catch {} wrapper, which can call again
into the calling function.
The IR guarantees that delete_exception_handler is always called, regardless of
how the try or catch blocks are terminated. That is where in the JIT and
interpreter we return from the nested function call and return back into the
original stack frame, effectively unregistering the catch handler.
Further cleanups with regards to the naming and the exception handler stack
will come in subsequent patches, this is merely the minimal patch set to
change to the new mechanism.
This patch set breaks ARM until ARM exception handler tables are implemented.
The interpreter changes are based on a patchset from Erik
from https://codereview.qt-project.org/#change,45750
Change-Id: I543f2bd37b2186f7e48ffcab177d57b5ce932a0c
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Lars Knoll [Sat, 2 Mar 2013 23:50:33 +0000 (00:50 +0100)]
Fix builtin_define_property
Commit
72c1fe5822aa65f4a3f70f78e058fb7e3154a4b6 broke
object literals that uses numbers as keys (e.g.
{ "2": "bla" }. This fixes it while keeping the faster
code path.
Change-Id: I0e89eb6e03da6a2e55d833ac0ad956f35e597297
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Sun, 3 Mar 2013 09:20:05 +0000 (10:20 +0100)]
Fix crashes on ia32 with array literals
prepareVariableArguments uses copyValue to copy/initialize the
arguments for a variable arguments call. Previously it called
copyValue with only temps as source, which on ia32 is implemented
as
(1) load temp from memory into FP reg
(2) store FP reg into destination memory location
After Gerrit change Id5757dd7a910be13db4958da7e449172ec1b04ae the
source of copyValue can now also be an IR::Expr and hence a constant
value. On ia32 it is unfortunately not possible to load a constant
floating point value into an FP reg right away. However in this
very situation it's sufficient to store the correct VM::Value in
the destination memory address right away. This is now done using
a template specialization of copyValue.
The old code compiled because we accidentally picked the
loadDouble(const void *address) overload of MASM, with address
pointing to the IR::Expr :)
Change-Id: Ie43f9be432cfcb844cc5e706e63bd3e91e857bac
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Lars Knoll [Fri, 1 Mar 2013 15:47:07 +0000 (16:47 +0100)]
More efficient initialization of array literals
Initialize array literals in one go instead of going
through repeated calls to the runtime for each value.
This gives quite a nice speed improvement on the splay
tree benchmark.
Change-Id: Id5757dd7a910be13db4958da7e449172ec1b04ae
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Sat, 2 Mar 2013 23:54:48 +0000 (00:54 +0100)]
Skip some really slow tests
The test cases themself finish in ~10-20 secs. Unfortunately
__deregister_frame seems to be extremely slow if you have many
functions (as is the case in these tests). It takes many minutes
to then clean up the engine and deregister all frames.
Change-Id: Idaa829f64c91d324e650b1d22b94dec6becad3d4
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Fri, 1 Mar 2013 14:02:46 +0000 (15:02 +0100)]
Minor optimisation: Avoid some function calls
Change-Id: Ie30b95af01c6623262fbbd93f51c115262531fe8
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Fri, 1 Mar 2013 22:16:03 +0000 (23:16 +0100)]
Fix crashes on ia32
sizeof(VM::String) != sizeof(VM::String*) :)
Change-Id: I1e59de64ad5f73e478519c618f28806c151d94f5
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Erik Verbruggen [Fri, 1 Mar 2013 14:09:17 +0000 (15:09 +0100)]
Implemented DaylightSavingTA for Windows.
Change-Id: I5421c325a307e11837fd8135a6306b519fe29ad4
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Fri, 1 Mar 2013 13:03:04 +0000 (14:03 +0100)]
Save some overhead in builtin_define_property
Change-Id: I632b8a5e46bc8119789acde6362cfd8e86ce901b
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Fri, 1 Mar 2013 12:34:52 +0000 (13:34 +0100)]
Don't spend all the time in gc in some cases
Some test cases actually caused the GC to get triggered
too often. This could happen if a GC run would collect up
very few freed objects. In that case the next GC run would
get triggered after these few objects where used up.
The commit adds a count to make sure we don't trigger GC too
early.
Change-Id: Ia51056e33869b072e801c0be02807a5d40ef97c9
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Wed, 27 Feb 2013 19:14:00 +0000 (20:14 +0100)]
[masm] Fix build on ARM
Allocate a LocalsRegister here, too
Change-Id: I1f05f52948616e4979beb8935f6b4e46791a6937
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 22 Feb 2013 16:15:58 +0000 (17:15 +0100)]
Tool to generate FDE and CIE tables using libdwarf
This makes it easier to generate the right magic bits and bytes
across different architectures.
Change-Id: I83cf8f348f4ea92febfe463e1ffd627808e1bb44
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 14:27:41 +0000 (15:27 +0100)]
Enable DW2 unwind helper on MacOS.
Change-Id: I1c1671d0b3953ce2e8f57bbf68023731470e3da1
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 14:27:20 +0000 (15:27 +0100)]
Fix null-unwind helper compilation.
Change-Id: I82af0ae373157d412b138334c8d80fa6e17591df
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 12:50:17 +0000 (13:50 +0100)]
Do not generate udis86 files when udis86 is disabled.
Change-Id: Iaed45c949d29ac81a60adec3437f2790d23a58d5
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Thu, 21 Feb 2013 13:30:35 +0000 (14:30 +0100)]
Add class to help the platform unwind JIT code.
Currently only x86_64 and x86 is supported.
Change-Id: I80fe60543b71e7073a0666d5ebb10144a75a488c
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 12:07:21 +0000 (13:07 +0100)]
Fix warning about unused parameter.
Change-Id: Ic8f95211b29fd5b3f4ffa4bc931fc15f004b30b1
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 12:07:00 +0000 (13:07 +0100)]
Add overloaded destructor to suppress warning on MSVC.
main.cpp(357) : warning C4291: 'void *QQmlJS::VM::Managed::operator new(size_t,QQmlJS::VM::MemoryManager *)' : no matching operator delete found; memory will not be freed if initialization throws an exception
d:\dev\v4vm\src\v4\qv4managed.h(112) : see declaration of 'QQmlJS::VM::Managed::operator new'
Change-Id: Idd7f54f257ae93fdf04ecbf3f938e3b2d981bf89
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 11:15:39 +0000 (12:15 +0100)]
Apparently MSVC needs EH enabled for SJLJ.
Change-Id: Ieab8157816237151dcfcf3eccfb3de177c4ad221
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 11:22:34 +0000 (12:22 +0100)]
Ignore by-produces of builds on Windows.
Change-Id: I0626a2ee0f29866b8fa4b37958d1288f50a476f6
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 11:19:53 +0000 (12:19 +0100)]
Replace STL function that MS deprecated.
Change-Id: I0577d2ae42a7593e4bc886345c97072523aacc48
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 11:18:51 +0000 (12:18 +0100)]
Mark throwing functions as no-return.
Now the compiler cannot only optimise for this, but also stop complaining
about callers not returning any value.
Change-Id: I71d98721f70849178613096408e959d7e24dca8a
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 11:17:38 +0000 (12:17 +0100)]
Add ToS retrieval and register saving for MSVC.
No __asm no cry.
Change-Id: I95f4df5d5ba9d04aa0bcc8d0b0b5901d51533d16
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Erik Verbruggen [Wed, 27 Feb 2013 11:16:19 +0000 (12:16 +0100)]
Fix declaration linkage type to be the same as the defenition.
Change-Id: I86c96bd4076b60b896803ee1c53c2ecf9aa86e1f
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Mon, 18 Feb 2013 21:30:42 +0000 (22:30 +0100)]
Fix crypto.js on arm
Due to our large amount of temps we also end up creating large stack frames and
thus add large constants to the stack pointer. That affects the encoding of the
immediates and MacroAssemblerARMv7 ASSERTs out for values that require
encoding.
This is unlikely to get fixed upstream and it's infact impossible to create a
testcase with JSC JIT due to the fact that it barely uses the stack frame.
I'd rather not patch the upstream file as it is a condition hard to find and
a patch easy to drop by accident. Instead this patch adds a simple workaround
that comes are low cost: Just load the immediate into a register and do the
addition.
Change-Id: Ia551a15d2f5f6243b295a9bfd19df778467189ec
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Tue, 26 Feb 2013 11:58:16 +0000 (12:58 +0100)]
[masm] Prepare local stack frame for new upcoming exception handling
Access local temps through a newly allocated LocalsRegister instead of the
regular frame pointer register. In the new exception handling we're going to
re-enter our function in the middle and want to access the same local temps,
but we can't do that through the stack frame pointer then, because that one
will _have_ to continue to point to the local stack frame in order for
unwinding to work properly.
Also the callee saved registers are now stored right below the stack
frame pointer instead of at the bottom of the stack. This way they
can be described easily in the unwind info as always relative to the
canonical frame address.
Change-Id: I53ef6291d99396577a72ceb9246f7ca3d99e5137
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Tue, 26 Feb 2013 11:49:38 +0000 (12:49 +0100)]
Fix build with clang
It tells us quite explicitly how it wants a default constructor
for VoidType :)
Change-Id: I854370c869f179da7f842fbf675e05678285630d
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Tue, 26 Feb 2013 11:45:47 +0000 (12:45 +0100)]
Fix failing assertion when running the test suite
The test suite does things like "1 instanceof 1" and expects a
type error to be thrown. Therefore we should not assert(!"unreachable")
when instanceof is called with a numberic constant but just fall back
to the run-time implementation, which does the right thing.
Change-Id: Iced93e679d56f4491d38c50b669e12dd160c220c
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Mon, 25 Feb 2013 09:13:46 +0000 (10:13 +0100)]
[masm] Implement sign text using cross-arch masm api
Use branchTest32 to implement the test for the sign bit in right
shift operations.
Change-Id: I07b3ead4d32761ee3d5f529259be5b5987b7ec5a
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Lars Knoll [Sun, 24 Feb 2013 21:31:58 +0000 (22:31 +0100)]
Some smaller optimisations
Ideally these checks should get inlined in the generated
assembly.
Change-Id: I4f63f7235a7d3bbdf8413df9f7d674104ff95b07
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Sat, 16 Feb 2013 22:27:07 +0000 (23:27 +0100)]
Small cleanup
Change-Id: I1733ad823ef00114b4544bb0bdf40fede4eea073
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Sat, 16 Feb 2013 22:26:16 +0000 (23:26 +0100)]
Fix the sameValue algorithm when comparing ints to doubles.
Change-Id: I96fb3e8c47a336ef4e0e3cab44e6dfd4d5aff70a
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Sat, 16 Feb 2013 19:44:53 +0000 (20:44 +0100)]
Fix inline assembly version of ushr
-1 >> 0 should return UINT_MAX, as the result is an
unsigned int according to spec. The only way the result
of the inline shr operation can be signed is by shifting
0 bytes. But the easiest implementation is to test the
result for signed-ness and then fall back to the slow
implementation.
Change-Id: Ic4614006d06cf01376ef95b6f23ca2c7216a2812
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Sat, 16 Feb 2013 12:19:36 +0000 (13:19 +0100)]
Store 0 constants as integers, not as doubles
Change-Id: Ibb49d1fd8221d65262b1c18b9833233ef97cee8e
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Thu, 21 Feb 2013 11:07:17 +0000 (12:07 +0100)]
Fix use of CPU(X86_64) to determine 64-bit architecture
Use QT_POINTER_SIZE == 8 instead
Change-Id: I7e3283132682c9f882b4d7b1ee067428bb23d42a
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Sun, 17 Feb 2013 21:21:51 +0000 (22:21 +0100)]
Port __qmljs_get_thisobject to new calling convention
Change-Id: I59a921d6838fd4e8419bf6cf62d5dca39e1142cd
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Sun, 17 Feb 2013 21:12:22 +0000 (22:12 +0100)]
[masm] Fix function name replacement in disassembly on ia32
Cast the void* to a quintptr, to make sure we call the right
QByteArray::number overload depending on the size of a pointer
on the archicture. Otherwise we generate 0x1324 strings that
we can't successfully replace with the function names in the
disassembler output.
Change-Id: Iddc82534487d93547b597d39286b92ffdff6da6c
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Sun, 17 Feb 2013 20:44:05 +0000 (21:44 +0100)]
[masm] Fix writing of return value on arm
On arm the pointer to the storage of the VM::Value to return is passed in r0.
The value in that register is destroyed soon after, so later when we want to
access it in visitRet() we'll get garbage.
To solve this we behave similar to gcc now, which upon function entry saves the
values of the registers used for parameter passing onto the stack. Except that
on arm we now do this before pushing the link register, which makes the stack
frame look identical to ia32. (old ebp / return address / arg 0 / arg 1 / ...)
With that we can theoretically access the pointer to the return value storage.
In practice we also need to change meaning of the addressForArgument() helper
function to only return the address of arguments on the stack. But that makes
sense since Address() is meaningless for values passed in registers.
Also tightened the #ifdef in visitRet() for determining whether to use the
return value register or not. That wasn't strictly necessary, but makes
the condition a bit clearer.
Change-Id: I6fbef6645275ebaa75484d666b4bbfd073f945a5
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Sun, 17 Feb 2013 20:36:02 +0000 (21:36 +0100)]
[masm] Fix function return on arm
Whether we should do ret(n) or ret should depend on whether the caller
provides the pointer to the return value as hidden first parameter or not.
That's the case on ia32 but not on x86-64 or arm, where the first parameter
register is used instead. So the correct preprocessor macro to use here
is ARGUMENTS_IN_REGISTERS instead of VALUE_FITS_IN_REGISTER.
Change-Id: I3a8a8fa316896848baca37626f87ed98c096e14a
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Sun, 17 Feb 2013 20:15:29 +0000 (21:15 +0100)]
[masm] Cleanup argument handling
Simplify the code for determining whether to push a function call parameter
onto the stack or into a register.
Change-Id: I3ab9230b8c0a3b2466c3000d89faf4fd79f927eb
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Sun, 17 Feb 2013 20:06:13 +0000 (21:06 +0100)]
[masm] Support inline ops on architectures without memory src operands
Change-Id: Idc4240c0fae35e42246f176536b9c16ee28123d2
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Sun, 17 Feb 2013 19:44:48 +0000 (20:44 +0100)]
[masm] Fix typo on register assignment
On ARM registers are in JSC::ARMRegisters instead of JSC::X86Registers :)
Change-Id: Ib11f0b3caa84a5015905f0a7937b4250c6f76c78
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Simon Hausmann [Sun, 17 Feb 2013 19:42:21 +0000 (20:42 +0100)]
[masm] Fix incorrect stack pointer adjustment when leaving function
Make sure to calculate the frame size when entering the function the
same way as when leaving it, otherwise the stack pointer adjustment
is wrong and we get nice crashes.
Change-Id: I19f953c3243cf6f1448ad95cad7587fbdca2ae6d
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Lars Knoll [Fri, 15 Feb 2013 23:15:34 +0000 (00:15 +0100)]
Minor cleanup
Change-Id: I8c3fea7c6b330c3e32b10c945f6e7b96a06daa8e
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Fri, 15 Feb 2013 12:36:49 +0000 (13:36 +0100)]
reference locals in outer functions by index
This makes V4 reference all variables in scopes
that are not the global scope by index. The JIT and
the interpreter walk up the scope chain to get the
correct reference.
Variables are only resolved by name for the global
scope, if the scope contains an eval statement (as
eval can define new variables) and inside with and
catch scopes.
Change-Id: Ib9f9d1a03d50124130aefd169eeb071533ba3520
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Fri, 15 Feb 2013 12:31:32 +0000 (13:31 +0100)]
Retain the proper nesting structure in the VM:Function objects
Change-Id: I83c0889be7fe354f96fca68f786ca2a05121bb56
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Fri, 15 Feb 2013 11:40:09 +0000 (12:40 +0100)]
Fix multiple variable assignments
When doing var foo = bar = 42; then we would assign 42 to bar and bar to foo,
resulting in the wrong value for foo if bar was read-only for example.
The spec says in 11.13.1.6 that the rval is to be returned, so we just do
that via the temp we already have.
Change-Id: I44ea895abe4796af10c371baac22c2b26f37b519
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 15 Feb 2013 08:54:10 +0000 (09:54 +0100)]
Port the remaining functions called from masm to pass-by-reference/pointer
Change-Id: I1ea15fc500d0d2168aded2b6a2739420eb007b45
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 15 Feb 2013 07:27:21 +0000 (08:27 +0100)]
[masm] Save guard const reference method calls
Introduce a Reference type next to PointerToValue for which we can ensure that
it's non-null using an assert. Otherwise implemented push(PointerToValue)
to push a null pointer if the temp is null, instead of asserting.
Change-Id: I70f15e39dd80a6b2c65630060cba35f3417c0634
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Fri, 15 Feb 2013 08:30:24 +0000 (09:30 +0100)]
Don't assert when running into the JS debugger statement
Instead use Q_UNIMPLEMENTED() that just prints a warning. This
really is missing functionality that in the meanwhile shouldn't cause
crashes due to failing assertions.
Change-Id: I85314d04e35af35b95dc81e9cbdd659d13f43798
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
Laszlo Papp [Thu, 14 Feb 2013 22:57:59 +0000 (22:57 +0000)]
Add the mandatory license file to be consistent and proper
See the following mailing list thread for further details:
http://lists.qt-project.org/pipermail/development/2013-February/009810.html
Change-Id: Iec80c7cbeeafca7d2cdd63eb9c918d8dedbc6cd0
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Lars Knoll [Thu, 14 Feb 2013 22:16:50 +0000 (23:16 +0100)]
cleanup __qmljs_to_boolean vs Value.toBoolean()
Change-Id: Ic93eed2d4e68972d373bf1521387331ce26bac43
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 22:04:12 +0000 (23:04 +0100)]
remove __qmljs_throw_type_error
Change-Id: Ib666fa478e3e306117b50afebbd7826fa5b0738e
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 22:00:11 +0000 (23:00 +0100)]
Various cleanups in the runtime
Remove unused code, inline where we only use a method
once.
Change-Id: I1896efc3f4d309082aff2f80f944e19c1ede2f50
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 20:41:49 +0000 (21:41 +0100)]
Fix a few more runtime signatures and optimise toObject conversion
Change-Id: Ibd1e4b7f2c9609b4ac08d75c8a0e2d5a86521605
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 19:58:10 +0000 (20:58 +0100)]
Adapt get/set_element to new calling convention
Change-Id: I5e2bca8ee2435bf678dbf9eb15172ed59c80b52e
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 15:18:01 +0000 (16:18 +0100)]
Ported closure init runtime functions to new calling convention
Change-Id: Icb5765069b296977480d896aacfbd09d64dbdad6
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 15:15:19 +0000 (16:15 +0100)]
Ported run-time exception throwing functions to new calling convention
Change-Id: Icc05eb78deb6d087a06f77d28b71fd49c9705e4c
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 15:11:16 +0000 (16:11 +0100)]
Fix argument order of unary ops
Change-Id: Id108c4b74f03cac8181a9308413b69e6bf1ef83e
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 15:04:15 +0000 (16:04 +0100)]
Ported built-in exception getter to new calling convention
Change-Id: Ica14229cfa280afba2003b3b50930c2986aa2f23
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 15:02:40 +0000 (16:02 +0100)]
Convert property deletion runtime functions to new calling convention
Change-Id: I312ccbd65d9aad5e8db349af94c00bed0fd73544
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 14:55:43 +0000 (15:55 +0100)]
Convert unary ops to new calling convention
Change-Id: I974fd474c4f35885e42dd219e2daa65098f4e0a1
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 14:47:06 +0000 (15:47 +0100)]
Convert construct runtime functions to new calling convention
Change-Id: I063508ff780d2f6371f77eca7138a09d78e1a45e
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Lars Knoll [Thu, 14 Feb 2013 14:00:06 +0000 (15:00 +0100)]
Move the destructor into the new vtable.
This makes all runtime structures fully non virtual.
Change-Id: I804568ca9bc33d4be0324ed542df8eab5892c0eb
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 13:21:37 +0000 (14:21 +0100)]
Remove another virtual.
Change-Id: Id83e7e5153160247b15c1506cb3c741cc6b77368
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 13:18:59 +0000 (14:18 +0100)]
Silence compiler
Change-Id: Id248400c50609811baebb1ea710210915e5274c9
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 13:18:34 +0000 (14:18 +0100)]
Remove another virtual
Change-Id: I185be24d4c09d2078c3459460875c4711bf17ddb
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 13:07:57 +0000 (14:07 +0100)]
Move call/construct over into the new vtable.
Change-Id: I4f58a1fac25440695bdc62a49adb51a887616a5c
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 10:53:23 +0000 (11:53 +0100)]
Remove another virtual and de-inline a call method
Change-Id: Ia7cc0bf9f4024a65020fef75666ae13d3691bc54
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 11:56:05 +0000 (12:56 +0100)]
Convert builtin type of functions to new calling convention
Change-Id: Ie0c9300eead2171c899bca54635e6fdf301385d3
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 12:28:49 +0000 (13:28 +0100)]
Converted calling runtime functions to new calling convention
Change-Id: I03837e9b392957bd64a6710c1b85b4429556ba06
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 11:29:16 +0000 (12:29 +0100)]
Fix print and gc in builtin v4 method
Also removed unused TestHarness stuff.
Change-Id: I6332d9a34f471df07cfa0e9709a203e99a48b524
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 11:16:30 +0000 (12:16 +0100)]
Convert builtin typeof to the new calling convention
Change-Id: I40f268c53dacf2ee188b3d1df9391df3e5e812f8
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Simon Hausmann [Thu, 14 Feb 2013 09:45:49 +0000 (10:45 +0100)]
Convert run-time functions that take a Value * for arguments to use a Value reference
This keeps the C++ implementation code simpler while still providing the same
(pointer based) calling convention.
Change-Id: Ib72acf1dfdf4638f6d109a0771fdafc921a544d2
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Lars Knoll [Thu, 14 Feb 2013 10:10:17 +0000 (11:10 +0100)]
Remove the virtual call(ctx) method
This is better handled in ScriptFunction and BuiltinFunctionOld.
Change-Id: Id896b1ddac47a9ce52e86abff901c87b7e627271
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Lars Knoll [Thu, 14 Feb 2013 10:02:57 +0000 (11:02 +0100)]
Don't use the slow call() method for Date()
Change-Id: Ifc29ef18a173a210a8831b87ba3f1adcbe9911d6
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>