dotnet-maestro-bot [Fri, 1 Feb 2019 18:07:37 +0000 (10:07 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19101.1, beta-27401-00, beta-27401-00, respectively (dotnet/corefx#35015)
Commit migrated from https://github.com/dotnet/corefx/commit/
bd3cb6968320e3f2fc0397036e7420e774e1b558
Filip Navara [Fri, 1 Feb 2019 12:52:54 +0000 (13:52 +0100)]
Fix time conversion in SystemNative_GetCpuUtilization (dotnet/corefx#35017)
Commit migrated from https://github.com/dotnet/corefx/commit/
0d41c895ff6e3094e1e8105a9bb6b4cf3d985bd7
David Shulman [Fri, 1 Feb 2019 01:31:03 +0000 (17:31 -0800)]
Enable TLS channel binding token for NTLM authentication on Linux (dotnet/corefx#34998)
This PR adds support for passing in the computed TLS channel binding
token (cbt) into the gssapi during NTLM authentication. This included
removing the code that threw the PlatformNotSupported exception.
No new tests were added to this PR since it requires machine changes
to test. However, I manually tested various combinations of NTLM
authentication including when the server requires (or NOT) the cbt
to be used. Currently only Windows Servers uses this functionality
as part of the "Extended Protection for Authentication" feature.
CurlHandler does not support using the cbt during NTLM authentication.
This is a problem with libcurl itself.
As part of this PR I removed a redundant assert and refactored the
SecChannelBindings structure into src/Common.
Fixes dotnet/corefx#34879
Commit migrated from https://github.com/dotnet/corefx/commit/
6575de65608c95717b2a032b689adae32378778f
Caesar Chen [Thu, 31 Jan 2019 23:55:40 +0000 (15:55 -0800)]
Diable System.Net.Http.FunctionalTests parallel execution on UAP run (dotnet/corefx#35004)
* diable parallel execution
* fix format....
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
5543097d8b6039dedffdcd8b8e713de38e5a1ece
dotnet-maestro-bot [Thu, 31 Jan 2019 23:37:13 +0000 (15:37 -0800)]
Update CoreFx to preview.19081.2 (dotnet/corefx#35005)
Commit migrated from https://github.com/dotnet/corefx/commit/
154e8eaad6b79393af8ac9745c7f49c92cfbbf7a
Stephen Toub [Thu, 31 Jan 2019 20:28:35 +0000 (15:28 -0500)]
Re-enable disabled DecimalTestData (dotnet/corefx#34975)
Commit migrated from https://github.com/dotnet/corefx/commit/
6e56a8fa5e237e5d9789a08918bf22d0fde4d785
Eric StJohn [Thu, 31 Jan 2019 20:07:42 +0000 (12:07 -0800)]
Refactor pre-test targets (dotnet/corefx#34973)
* Refactor pre-test targets
Moves pre-testing targets to their own project that builds after others, rather than as targets in dirs.proj.
Use the GenerateTestSharedFrameworkDepsFile from the CoreFxTesting package rather than from buildtools.
* Manually update Arcade to latest
Commit migrated from https://github.com/dotnet/corefx/commit/
f1336fa043309e587dee5e3d59ee04249ddff97b
dotnet-maestro-bot [Thu, 31 Jan 2019 17:10:21 +0000 (09:10 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19081.1, beta-27331-00, beta-27331-00, respectively (dotnet/corefx#34978)
Commit migrated from https://github.com/dotnet/corefx/commit/
e849d7a98d8137a0d0d325f7c610b36c3903250f
Stephen Toub [Thu, 31 Jan 2019 17:09:58 +0000 (12:09 -0500)]
Mirror changes from dotnet/coreclr (dotnet/corefx#34987)
* Reverting "Fixing up the UTF8Formatter and some tests to properly handle -0.0" (dotnet/corefx#22300)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Add managed implementation of GetSystemMaxDBCSCharSize (dotnet/corefx#22290)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
35a2040b73969b0d69a3cc0d358eb91c5238de26
Santiago Fernandez Madero [Thu, 31 Jan 2019 17:09:37 +0000 (09:09 -0800)]
Manual darc update for arcade and coreclr (dotnet/corefx#34977)
* Remove target to print MCUrl now that helix sdk always prints it
* Run darc update for dotnet/arcade
* Run darc update for dotnet\coreclr
* Fix build after Environment pushed down to coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
28c46ef8a123864178c099580b7eb3c8eda3f495
Stephen Toub [Thu, 31 Jan 2019 15:21:30 +0000 (10:21 -0500)]
Expose/test IAsyncDisposable.ConfigureAwait (dotnet/corefx#34783)
Commit migrated from https://github.com/dotnet/corefx/commit/
e6939de2997edf49444ac2c12ad22d5d5f6dea89
Stephen Toub [Wed, 30 Jan 2019 22:01:42 +0000 (17:01 -0500)]
Fix build break due to 'W'
Commit migrated from https://github.com/dotnet/corefx/commit/
94e9d02ad70b2224d012ac4a66eaa1f913ae4f29
Stephen Toub [Thu, 31 Jan 2019 14:46:39 +0000 (09:46 -0500)]
Fix several related inheritability bugs on Unix (dotnet/corefx#34967)
- AnonymousPipeServerStream accepts a HandleInheritability value. When it's set to None, both ends of the pipe are correctly created as O_CLOEXEC to prevent them from being inherited. However, when it's set to Inheritable, we're not marking either end of the pipe as O_CLOEXEC, which means both file descriptors are inherited by the child process. While technically that meets the letter of the law as to what the API requires, in the 99.9% use case the server handle really isn't intended to be inherited, and rather it's only the client handle that is; by allowing the server handle to also be inherited, when the server closes its end of the pipe, the client doesn't get an EOF or broken pipe, because it still has its dup of the file descriptor open, and will for the lifetime of the process. The fix is to always mark the server file descriptor as O_CLOEXEC even if the inheritability is set to Inheritable.
- NamedPipeServer/ClientStream is built on Socket. Previously, sockets defaulted to being inheritable, but we changed that for .NET Core 3.0, such that they're now not inherited. But the pipe code was written expecting the default of Inheritable, and has an if block that says "if inheritability requested was not inheritable, then set O_CLOEXEC"; that now needs to be flipped to say "if inheritability was requested, clear O_CLOEXEC".
- MemoryMappedFile has a similar issue. It tries to use shm_open to create the backing store, but shm_open defaults to having O_CLOEXEC set, and so if Inheritabile was requested, we're neglecting to clear the O_CLOEXEC flag.
Commit migrated from https://github.com/dotnet/corefx/commit/
e5d6c6fc20e72c9d5ba3214f99c25f418bcff0a0
Santiago Fernandez Madero [Thu, 31 Jan 2019 14:28:37 +0000 (06:28 -0800)]
Bring back hooks to AddRuntimeProjectReference from buildtools (dotnet/corefx#34979)
Commit migrated from https://github.com/dotnet/corefx/commit/
38b2d1d4e298a717d99adadcfb0803a8e2a0b04f
Stephen Toub [Thu, 31 Jan 2019 14:26:38 +0000 (09:26 -0500)]
Add test for new CancellationTokenSource(0) (dotnet/corefx#34832)
Validate correct behavior when a CTS is constructed to be immediately canceled via a 0 timeout.
Commit migrated from https://github.com/dotnet/corefx/commit/
fdf1d66f37cc09e2b9de05eadcaa14c9dd5fb223
dotnet-maestro-bot [Thu, 31 Jan 2019 04:31:22 +0000 (20:31 -0800)]
Update CoreFx, CoreFxOptimizationData to preview.19080.4, master-
20190130.3, respectively (dotnet/corefx#34971)
Commit migrated from https://github.com/dotnet/corefx/commit/
4e7ce8acfae39beab8c30053d3da95417b5a16dc
Stephen Toub [Thu, 31 Jan 2019 01:05:49 +0000 (20:05 -0500)]
Merge pull request dotnet/corefx#34956 from dotnet/darc-master-
53aad4d1-974a-49c0-b59b-
ba0be0d0481f
Update dependencies from dotnet/coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
9e074e4a3f3626fa953f36ab79e3cd3e6db1c9de
Aaron Robinson [Thu, 31 Jan 2019 01:03:40 +0000 (17:03 -0800)]
Handle the case where the Marshal.ThrowExceptionForHR is inlined in (dotnet/corefx#34968)
the test assembly and the Source isn't corlib.
Commit migrated from https://github.com/dotnet/corefx/commit/
09bac5feb0e4c2a015102e021536a031b8d10ef4
Stephen Toub [Wed, 30 Jan 2019 23:03:01 +0000 (18:03 -0500)]
Merge branch 'master' into darc-master-
53aad4d1-974a-49c0-b59b-
ba0be0d0481f
Commit migrated from https://github.com/dotnet/corefx/commit/
601b264612cdba4f4a1896324eaf5e34807c9113
Stephen Toub [Wed, 30 Jan 2019 22:46:23 +0000 (17:46 -0500)]
Disable decimal tests that'll fail until an updated coreclr arrives
Commit migrated from https://github.com/dotnet/corefx/commit/
709f3ab1178df667e10b3929d19c2dcf49da7c15
William Godbe [Wed, 30 Jan 2019 22:42:24 +0000 (14:42 -0800)]
Merge pull request dotnet/corefx#34796 from wtgodbe/ApiCompatNS21
Run APICompat for netstandard2.1 vs netcoreapp3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
ee57e77c81a18ced855685f519b521e6a34d9821
Sung Yoon Whang [Wed, 30 Jan 2019 21:45:22 +0000 (13:45 -0800)]
some misc typos and wording fixes in eventcounter tutorial (dotnet/corefx#34960)
Commit migrated from https://github.com/dotnet/corefx/commit/
7cbda74a0bbee1321c6966891bca6c7aba520aef
Max Kerr [Wed, 30 Jan 2019 21:40:28 +0000 (13:40 -0800)]
Improve handling of HTTP/2 frames received on closed stream (dotnet/corefx#34629)
* Basic support for GoAway frames.
* Review feedback.
* Remove go-away frame handling, add testing to ensure that the loopback server closes the connection instead.
* Remove comma.
* Change error code to reflect the actual failure mode.
* Correct swapped error codes.
Commit migrated from https://github.com/dotnet/corefx/commit/
47f6404357832466585f06d5c9ee07ed2f7a27a4
Eric StJohn [Wed, 30 Jan 2019 21:04:45 +0000 (13:04 -0800)]
Remove UpdateVSConfigurations (dotnet/corefx#34952)
* Update Microsoft.DotNet.Build.Tasks.Configuration to build
20190129.6
* Use UpdateVSConfigurations from arcade
Commit migrated from https://github.com/dotnet/corefx/commit/
d0997060a80f41d4c03c0f8cc2b8ce5ac40ec941
Tomas Weinfurt [Wed, 30 Jan 2019 20:58:02 +0000 (12:58 -0800)]
add Fact attribute instead of removed ConditionalFact (dotnet/corefx#34962)
Commit migrated from https://github.com/dotnet/corefx/commit/
dfd25d13a9d0f5f86d3964eb5bf6b33b7b22a3cc
wtgodbe [Wed, 30 Jan 2019 20:46:50 +0000 (12:46 -0800)]
Update comment
Commit migrated from https://github.com/dotnet/corefx/commit/
4fc403006af495aa8c66f528998703473c51e854
wtgodbe [Fri, 25 Jan 2019 00:00:58 +0000 (16:00 -0800)]
Update baseline files
Commit migrated from https://github.com/dotnet/corefx/commit/
5f251504a1a523bed7f81d6aff86fbc2a8409aeb
wtgodbe [Fri, 18 Jan 2019 00:01:06 +0000 (16:01 -0800)]
Run APICompat for netstandard2.1 vs netcoreapp3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
c05b1971dc2e554522218810f663f534b75934e6
Santiago Fernandez Madero [Wed, 30 Jan 2019 18:24:09 +0000 (10:24 -0800)]
Enable tests for UAPAOT x86 and x64 official builds (dotnet/corefx#34940)
* Enable tests for UAPAOT x86 and x64 official builds
* Manually update CoreFxTesting package
Commit migrated from https://github.com/dotnet/corefx/commit/
9e9bc17c701860ceb80525ea50aee9e08a7173a8
Jan Kotas [Wed, 30 Jan 2019 17:55:14 +0000 (09:55 -0800)]
Fix link to interop-pinvokes.md
Commit migrated from https://github.com/dotnet/corefx/commit/
c5118d8a571b75b6333893b7be8d4a0c77dedd1e
Stephen Toub [Wed, 30 Jan 2019 17:53:04 +0000 (12:53 -0500)]
Temporarily give System.Runtime.Extensions its own Environment.* copy (dotnet/corefx#34951)
The files were moved to shared to propagate them to coreclr. But changes being made in coreclr are going to break System.Runtime.Extensions when the files mirror back. As a temporary stop-gap, I'm creating local copies of the files and taking System.Runtime.Environment off of the shared copies. Then once coreclr builds with the updates and corefx consumes the updated coreclr, we'll just delete these temporary copies and remove the relevant entries entirely from System.Runtime.Extensions.
Commit migrated from https://github.com/dotnet/corefx/commit/
2f6536eb0a2f6ac246f99382d0235dffd75eb1c4
dotnet-maestro-bot [Wed, 30 Jan 2019 14:20:08 +0000 (06:20 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19079.11, beta-27330-00, beta-27330-00, respectively (dotnet/corefx#34936)
Commit migrated from https://github.com/dotnet/corefx/commit/
f30910f1bf38f0caaefcd443072b025cfe2c7293
Marco Rossignoli [Wed, 30 Jan 2019 12:48:28 +0000 (13:48 +0100)]
Flow Thread.CurrentPrincipal with ExecutionContext (dotnet/corefx#34747)
* flow Thread.CurrentPrincipal with ExecutionContext
* fix netfx test
* address PR feedback
* address PR feedback
* try to make test more reliable using StartNew(), removed from NetFramework
* address PR feedback
* nit: extraline
* add null set test
* nit: extraline, again...
* rename test
* apply Stephen fix
* nit: typos
* address PR feedback
* nit: update comment
Commit migrated from https://github.com/dotnet/corefx/commit/
bab35ecc6f3f94215705d109d5094c1b3c461992
Meir Blachman [Wed, 30 Jan 2019 12:45:32 +0000 (14:45 +0200)]
removed project-priorities link from docs readme (dotnet/corefx#34945)
Commit migrated from https://github.com/dotnet/corefx/commit/
d02107dcf324fb52312add364d743b1a15d1e7ff
Ahson Khan [Wed, 30 Jan 2019 12:43:02 +0000 (04:43 -0800)]
Seed the porting guide for going from Json.NET to System.Text.Json. (dotnet/corefx#34944)
* Seed the porting guide for going from Json.NET to System.Text.Json.
* Fix heading capitalization.
Commit migrated from https://github.com/dotnet/corefx/commit/
aa9b7c2632ae07b68c109b051faf35ea38491c63
Tomas Weinfurt [Wed, 30 Jan 2019 03:14:29 +0000 (19:14 -0800)]
add instrumentation for intermittent DNS failures (dotnet/corefx#34934)
* add instrumentation for dotnet/corefx#32797
* actually retry the lookup
* use PlatformID.Unix
Commit migrated from https://github.com/dotnet/corefx/commit/
673fe7880790e79549266cea25a385af82917b6e
Santiago Fernandez Madero [Wed, 30 Jan 2019 02:12:48 +0000 (18:12 -0800)]
Change helix queues for package testing to be RS4 (dotnet/corefx#34911)
Commit migrated from https://github.com/dotnet/corefx/commit/
9df66573b5b80362b21103d44bc87c40042e9662
Afsaneh Rafighi [Wed, 30 Jan 2019 02:04:50 +0000 (18:04 -0800)]
update area owners (dotnet/corefx#34939)
Commit migrated from https://github.com/dotnet/corefx/commit/
50a05b377cc9c4e1082de132955740d80a713b87
Maryam Ariyan [Wed, 30 Jan 2019 00:42:13 +0000 (16:42 -0800)]
Add System.Reflection.Emit.DynamicILInfo (dotnet/corefx#34532)
Commit migrated from https://github.com/dotnet/corefx/commit/
5f177b6dce0724f3a2a2c114ba9df86987f13002
Viktor Hofer [Tue, 29 Jan 2019 19:00:25 +0000 (20:00 +0100)]
Restore missing xunit package in aot builds (dotnet/corefx#34923)
* Include missing xunit package for aot builds
* remove obsolete condition
Commit migrated from https://github.com/dotnet/corefx/commit/
a8218c53907e01109a5bbf7d8d6ef741040b41ec
Viktor Hofer [Tue, 29 Jan 2019 16:43:01 +0000 (17:43 +0100)]
Make global tools work with helix (dotnet/corefx#34913)
* Make global tools work with helix
* Add runtime dependencies as target inputs
Commit migrated from https://github.com/dotnet/corefx/commit/
409c4b936defb81c09c0ed41fa3881200be14af1
Santiago Fernandez Madero [Tue, 29 Jan 2019 14:07:28 +0000 (06:07 -0800)]
Add outerloop legs in new CI definitions (dotnet/corefx#34871)
* Add outerloop legs in new CI definitions
* Add Linux Debug matrix to outerloop testing
Commit migrated from https://github.com/dotnet/corefx/commit/
bfc29eda3da9e9dfb5f31708ce57f0c6a74d7816
dotnet-maestro-bot [Tue, 29 Jan 2019 14:04:25 +0000 (06:04 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19078.4, beta-27329-00, beta-27329-00, respectively (dotnet/corefx#34916)
Commit migrated from https://github.com/dotnet/corefx/commit/
6cb6d133d2ad8f62720753739131d3fd2570e4b3
Marco Rossignoli [Tue, 29 Jan 2019 03:55:08 +0000 (04:55 +0100)]
Add Helix definition to guide (dotnet/corefx#34888)
* add Helix definition
* move to glossary.md
* address PR feedback
* add Azure DevOps guide
* Nits
Commit migrated from https://github.com/dotnet/corefx/commit/
ddea95ce4e99c09cf48f132c17a68b70cf98a625
Austin Wise [Tue, 29 Jan 2019 02:24:56 +0000 (18:24 -0800)]
Correct link to example review (dotnet/corefx#34914)
Commit migrated from https://github.com/dotnet/corefx/commit/
3574c12100a719d767bfabf69b52c2be290a99a3
dotnet-maestro-bot [Tue, 29 Jan 2019 01:18:34 +0000 (17:18 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19078.2, beta-27328-00, beta-27328-00, respectively (dotnet/corefx#34907)
Commit migrated from https://github.com/dotnet/corefx/commit/
be21a3ec9a40a17bffdeda27747463daf997b212
Viktor Hofer [Mon, 28 Jan 2019 23:27:52 +0000 (00:27 +0100)]
Bump UAPTools version (dotnet/corefx#34819)
Commit migrated from https://github.com/dotnet/corefx/commit/
fcc3a911fde8cdde9ab02d2d258909e82fdd123a
Eric StJohn [Mon, 28 Jan 2019 22:18:49 +0000 (14:18 -0800)]
Remove buildtools imports from Directory.Build.* (dotnet/corefx#34001)
* Remove buildtools imports from Directory.Build.*
Remove buildtools imports and implement remaining functionality in CoreFx.
I was able to do most of what BuildTools was doing with 3 exceptions, which will be split into separate issues.
1. Test shared framework deps file: GenerateDepsJson. We need to port this task to arcade or change how we test to not need it.
2. codeOptimization.targets -> should be moved to arcade, work is pending.
3. optionalTooling.targets -> move to a CSProj that is restored by the official build workflow.
* Address feedack, fix unix and UAP build issues
* Fix UWP, Tizen, and AllConfigurations build
* Remove buildtools dependency from package testing
* Remove a few more buildtools dependencies
* Eliminate RunningOnUnix property
* Remove NuGetTargetMoniker from shims.proj
* Remove ResourcesFolderPath
* Fix Microsoft.XmlSerializer.Generator.Tests
* Specify NuGetTargetMoniker for shims
* Remove a couple remaining ToolsDir uses
Commit migrated from https://github.com/dotnet/corefx/commit/
49d249fa023e8575dba7e35febb4446e4fa13f98
Viktor Hofer [Mon, 28 Jan 2019 19:40:35 +0000 (20:40 +0100)]
Disable coverage status checks for project and patch (dotnet/corefx#34901)
Commit migrated from https://github.com/dotnet/corefx/commit/
f70e98cb00b30184e26976b46573a8a7cbaddced
Stephen Toub [Mon, 28 Jan 2019 19:24:56 +0000 (14:24 -0500)]
Add IAsyncDisposable implementations to refs (dotnet/corefx#34898)
Apparently when I added the DisposeAsync methods to the refs, I didn't actually mark the corresponding types as implementing the interface. This fixes that.
Commit migrated from https://github.com/dotnet/corefx/commit/
672d6b0145fca5ac5ef99ea2b9f661e45470ea73
Viktor Hofer [Mon, 28 Jan 2019 14:15:01 +0000 (15:15 +0100)]
Add codecov yml configuration (dotnet/corefx#34896)
Commit migrated from https://github.com/dotnet/corefx/commit/
88d519be4dcda815b906ec0ff654d7ae0452e84e
David Shulman [Sun, 27 Jan 2019 23:41:53 +0000 (15:41 -0800)]
Fix GSSAPI error handling (dotnet/corefx#34883)
This PR addresses 3 issues in GSSAPI error handling:
* Fixes an uninitialized variable when calling gss_display_status().
This was causing the major statuscode error message to always return
'An invalid status code was supplied'.
* If the minor statuscode is 0 (GSS_S_COMPLETE), we shouldn't be calling
for the minor statuscode error message text. That is why we were always getting
'Unknown error' for that text.
* Added more text (help text) to certain errors returned from GSSAPI
such as when the NTLM plugin is not installed.
No new tests were added to this PR since it requires machine changes
to test. However, I manually tested various combinations of errors
including when 'gss-ntlmssp' is installed or not.
In terms of dotnet/corefx#34877, the exception message goes from:
>GSSAPI operation failed with error - An invalid status code was supplied (Unknown error).
to
>GSSAPI operation failed with error - An unsupported mechanism was requested. NTLM authentication requires the GSSAPI plugin 'gss-ntlmssp'.
Fixes dotnet/corefx#34877
Commit migrated from https://github.com/dotnet/corefx/commit/
eec001d96a68376c0e504eb7635c8edec196f90f
Maryam Ariyan [Sat, 26 Jan 2019 14:26:19 +0000 (06:26 -0800)]
Add test using short timeout throws WebException (dotnet/corefx#34856)
* Add test using short timeout throwing WebException
Fixes: dotnet/corefx#34849
* Make test conditional and target internal location
* code cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
a3df534fca15e6053aab748e020006a5cb3b0d31
Stephen Toub [Sat, 26 Jan 2019 11:26:35 +0000 (06:26 -0500)]
Factor WinRT GetFolderPath into static accessible via reflection (dotnet/corefx#34873)
Commit migrated from https://github.com/dotnet/corefx/commit/
3fc7efd29ce1fbc57c95eb0b82267b2ad0f7e3ff
Ahson Khan [Sat, 26 Jan 2019 09:31:49 +0000 (01:31 -0800)]
Update the Benchmarking docs and add workflow for making optimizations within S.P.CoreLib (dotnet/corefx#34836)
* Update the Benchmarking docs and add workflow for making optimizations
within S.P.CoreLib
* Move the S.P.Corelib workflow to a subheading.
* Address PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
2cb82bb953f8e304c3f75556d4263a5ea546d122
Anirudh Agnihotry [Sat, 26 Jan 2019 02:52:12 +0000 (18:52 -0800)]
setnanoseconds disabled for mac (dotnet/corefx#34870)
Commit migrated from https://github.com/dotnet/corefx/commit/
d68361f04cd8851b0e6fa58b5a7bd429cd26db58
Wraith2 [Sat, 26 Jan 2019 01:50:38 +0000 (01:50 +0000)]
add conditinal include for ThreadPool assembly in netcoreapp (dotnet/corefx#34865)
Commit migrated from https://github.com/dotnet/corefx/commit/
65313c5b64fc20faa8f80490727c113c4531fe82
Santiago Fernandez Madero [Sat, 26 Jan 2019 00:23:35 +0000 (16:23 -0800)]
Temporary disable FreeBSD leg (dotnet/corefx#34869)
Commit migrated from https://github.com/dotnet/corefx/commit/
0f657bae5fb93eba0da331fa3e7cd1c56eb4850c
Maryam Ariyan [Fri, 25 Jan 2019 22:58:25 +0000 (14:58 -0800)]
- Skip test for Nano: WindowAndCursorProps/Title_Get_Windows_NoNulls (dotnet/corefx#34861)
- Switch back expected vs actual in assert
Fixes dotnet/corefx#34755
Commit migrated from https://github.com/dotnet/corefx/commit/
826469ca02dbc41ff2ce9369398aea5c19ea1158
Santiago Fernandez Madero [Fri, 25 Jan 2019 22:32:50 +0000 (14:32 -0800)]
Use helix to run package tests (dotnet/corefx#34764)
* Use helix to run package tests
* PR Feedback and fix typo in helix.yml
* Define RestoreSources in packageTest.targets
* Remove restore sources item group and move the property to packageTest.targets
* Use less busy queue, change sendtohelix conditions to use targetgroup
* Move HelixCommand assignment out of target now that is not needed
* Disable azure pipelines reporter for all configurations test results
* PR Feedback and use dotnet blob feed as restore source
Commit migrated from https://github.com/dotnet/corefx/commit/
ebfa30454ba9a1dcca6293166cbe486175ec17f1
Santiago Fernandez Madero [Fri, 25 Jan 2019 21:00:34 +0000 (13:00 -0800)]
Run ubuntu arm tests in 16.04 for official builds (dotnet/corefx#34862)
Commit migrated from https://github.com/dotnet/corefx/commit/
bae407b2a043499c6879fb790d989b0d8ae0e1f6
Tomas Weinfurt [Fri, 25 Jan 2019 20:42:40 +0000 (12:42 -0800)]
cannot log in remote test exec (dotnet/corefx#34860)
Commit migrated from https://github.com/dotnet/corefx/commit/
d905417a3d969543c5067943686e9f3e59f9a695
Ben Adams [Fri, 25 Jan 2019 20:11:21 +0000 (21:11 +0100)]
Extend SequenceCompareTo_byte for longer vector lengths (dotnet/corefx#34742)
* Extend SequenceCompareTo_byte for longer vector lengths
* Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
585e3297d8b861ecaf5100da941a7a922a08a6fd
Stephen Toub [Fri, 25 Jan 2019 20:00:33 +0000 (15:00 -0500)]
Make more SoundPlayer tests conditional (dotnet/corefx#34854)
Commit migrated from https://github.com/dotnet/corefx/commit/
0fee9027bb97aa8dcda5cbc23f15d923e4b19d34
Swaroop Sridhar [Fri, 25 Jan 2019 19:58:53 +0000 (11:58 -0800)]
Expose NativeLibrary Resolver Callback (dotnet/corefx#34686)
Expose the APIs to set the Native Library resolver callback.
API Review:
https://github.com/dotnet/corefx/issues/32015
Implementation:
https://github.com/dotnet/coreclr/blob/master/src/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.cs
Tests:
https://github.com/dotnet/coreclr/blob/master/tests/src/Interop/NativeLibraryResolveCallback/CallbackTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
bcb76015585c91a1dfa63df68ef392bed317e8dd
dotnet-maestro[bot] [Fri, 25 Jan 2019 19:41:24 +0000 (11:41 -0800)]
Update dependencies from dotnet/core-setup (dotnet/corefx#34843)
* Update dependencies from https://github.com/dotnet/core-setup build
20190124.5
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview-27324-5
- Microsoft.NETCore.DotNetHost - 3.0.0-preview-27324-5
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview-27324-5
* Update package tests to use dotnet blob feed instead of myget
Commit migrated from https://github.com/dotnet/corefx/commit/
1c2b743bdc5644af8ebe4657fa22c64f188dc2cd
Steve Harter [Fri, 25 Jan 2019 17:56:11 +0000 (11:56 -0600)]
Remove S.R.CS.Unsafe dependency from MetadataLoadContext (dotnet/corefx#34813)
Commit migrated from https://github.com/dotnet/corefx/commit/
ab8b458b6b48ea67fba128f7eb6b42cdb97771c0
Eric StJohn [Fri, 25 Jan 2019 16:59:14 +0000 (08:59 -0800)]
Set DisableImplicitFrameworkReferences for all projects (dotnet/corefx#34786)
* Set DisableImplicitFrameworkReferences for all projects
The SDK added targets which require the assets file when framework reference items are set.
We can disable the implicit FrameworkReference item in order to prevent these from running.
* Don't rely on implicit VB imports
DisableImplicitFrameworkReferences also doubles as DisableImplicitNamespaceImports.
Rather than enable this I think it's better just to stop relying on the default imports.
* Add missing reference to EventLog
Commit migrated from https://github.com/dotnet/corefx/commit/
6653c5fe2adc7c7fca962df3fdc6675354726951
Stephen Toub [Fri, 25 Jan 2019 16:38:00 +0000 (11:38 -0500)]
Disable arm64 PR leg until it's working again (dotnet/corefx#34846)
Commit migrated from https://github.com/dotnet/corefx/commit/
ecc19fbeade10699fcae5192dfe67be02bf3c673
Filip Navara [Fri, 25 Jan 2019 14:37:13 +0000 (15:37 +0100)]
[System.Native] Add SystemNative_GetCpuUtilization (dotnet/corefx#34806)
* Add SystemNative_GetCpuUtilization.
* Update sysconf call to match CoreCLR.
Commit migrated from https://github.com/dotnet/corefx/commit/
26a4a61c99b2e2cbec52f10a230fd6436807f6e6
Jan Kotas [Fri, 25 Jan 2019 01:01:09 +0000 (17:01 -0800)]
Rename TplEtwProvider to TplEventSource (dotnet/coreclrdotnet/corefx#22194)
* Rename TplEtwProvider to TplEventSource
* Rename etwLog to log
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
016839c18266f33eaa6784a9725c542de151eac1
Dan Moseley [Fri, 25 Jan 2019 03:47:46 +0000 (19:47 -0800)]
Fix uap test (dotnet/corefx#34827)
Commit migrated from https://github.com/dotnet/corefx/commit/
3c127cf75ae1915b2b2cd7e898ac9f57524a9c79
Stephen Toub [Fri, 25 Jan 2019 03:43:22 +0000 (22:43 -0500)]
Fix culture handling in legacy System.Json library (dotnet/corefx#34811)
* Fix System.Json code using NumberFormatInfo.InvariantInfo
The intention here was obviously to use invariant culture, but NumberFormatInfo will be ignored for various primitive types that don't respect NFI, e.g. TimeSpan, which respects DateTimeFormatInfo.
* Fix handling of culture in System.Json tests
In particular, CultureInfo.CurrentCulture should not be modified in-process in tests, as on UWP it bleeds across threads.
Commit migrated from https://github.com/dotnet/corefx/commit/
f398b6f7c3d08d8e437939cbd9ef29cb3beda1db
Maryam Ariyan [Fri, 25 Jan 2019 01:06:44 +0000 (17:06 -0800)]
Test Fix: Add IsSoundPlaySupported condition to skip on Nano (dotnet/corefx#34820)
* Test Fix: Add IsSoundPlaySupported condition to skip on Nano
Fixes: dotnet/corefx#34808
* Removed Helpers class
Commit migrated from https://github.com/dotnet/corefx/commit/
dfb8fd883963de134fd09b54c61ac8da5ad573bf
Jose Perez Rodriguez [Fri, 25 Jan 2019 00:34:25 +0000 (16:34 -0800)]
Nesting source package files for a better experience when consuming it. (dotnet/corefx#34812)
Commit migrated from https://github.com/dotnet/corefx/commit/
c70cfa6d5600f01df3a15c151c18539f52e9bfd0
Stephen Toub [Fri, 25 Jan 2019 00:21:39 +0000 (19:21 -0500)]
Replace thread aborts in SoundPlayer (dotnet/corefx#34815)
This only addresses the issue of SoundPlayer using Thread.Abort, replacing it with cancellation.
Commit migrated from https://github.com/dotnet/corefx/commit/
2100e4f54637c124bdf880c7c036b4c79053e72f
David Shulman [Thu, 24 Jan 2019 21:45:39 +0000 (13:45 -0800)]
Fix SslStream channel binding token (dotnet/corefx#34814)
While working on Enterprise Scenario testing I discovered a bug in how the Unix layer generates
the channel binding token. It was using the wrong prefix for 'Endpoint' tokens.
Fixed 'Endpoint' token generation and added more detailed tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
c6b4a1c39d91943dc536c3621d43d2bf88aca487
Tomas Weinfurt [Thu, 24 Jan 2019 17:58:13 +0000 (09:58 -0800)]
support for fragmentation Ping option on Unix (dotnet/corefx#34435)
* add support for fragmentation Ping option on Unix
* add missing project file
* small adjustments
* fix typo
* feedback from review
* remove no longer needed import
* remove changes to HttpCookieProtocolTests pulled in by mistake
Commit migrated from https://github.com/dotnet/corefx/commit/
8fea941db55fd79635fde1a54058620ddac16961
Tomas Weinfurt [Thu, 24 Jan 2019 17:57:49 +0000 (09:57 -0800)]
collect some info about SendRecvPollSync_TcpListener_Socket() test run (dotnet/corefx#34751)
* add instrumentation for test run
* improve output
Commit migrated from https://github.com/dotnet/corefx/commit/
bd3b5d2f1de9f4a9e6bbc0f154085de7f8228375
Ahson Khan [Thu, 24 Jan 2019 14:13:05 +0000 (06:13 -0800)]
Make ReadToEnd static helper resilient against stream.Length changes. (dotnet/corefx#34798)
Commit migrated from https://github.com/dotnet/corefx/commit/
49109de03f113bb87117a4e3aaa9ffabc5c06bfb
Santiago Fernandez Madero [Thu, 24 Jan 2019 13:22:52 +0000 (05:22 -0800)]
Set MaxRetryCount to 4 for both Windows and non-Windows jobs (dotnet/corefx#34792)
Commit migrated from https://github.com/dotnet/corefx/commit/
fd21fbc661a26eab435a9925fc243616a1798362
Maryam Ariyan [Thu, 24 Jan 2019 13:19:49 +0000 (05:19 -0800)]
Test fix for Nano: WindowAndCursorProps/Title_Get_Windows_NoNulls (dotnet/corefx#34755)
* Modifying assertion code for Nano on WindowAndCursorProps/Title_Get_Windows_NoNulls
Fixes: dotnet/corefx#34717
* Change Contains to Equal
Commit migrated from https://github.com/dotnet/corefx/commit/
0c437d886f194d34caf20c3078e27c6ce26d4119
Viktor [Thu, 24 Jan 2019 12:05:06 +0000 (13:05 +0100)]
Disable ApartmentState on UAP
Commit migrated from https://github.com/dotnet/corefx/commit/
a33d75aec0daff5e6a043352d443ce6270f6660c
Viktor Hofer [Thu, 24 Jan 2019 11:56:47 +0000 (12:56 +0100)]
Fix UapAot runs (dotnet/corefx#34678)
* Fix UapAot runs
* Darc update from build '
20190124.1'
Commit migrated from https://github.com/dotnet/corefx/commit/
4adc562336698dfc77e9fd3553c569c72cfc94f4
Matt Mitchell [Thu, 24 Jan 2019 06:01:30 +0000 (22:01 -0800)]
Merge pull request dotnet/corefx#34757 from dotnet/darc-master-
b26a5f18-f603-49aa-822a-
9931dbe2063d
Update dependencies from dotnet/coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
d40bfe3ec3d16f6d4ba2a0ab1e8a5d691d3e7fdc
Santiago Fernandez Madero [Thu, 24 Jan 2019 04:35:52 +0000 (20:35 -0800)]
Merge branch 'master' into darc-master-
b26a5f18-f603-49aa-822a-
9931dbe2063d
Commit migrated from https://github.com/dotnet/corefx/commit/
1ac555fc95a09f4e001703762f6b7f6d6d464ec2
Jan Kotas [Sun, 20 Jan 2019 00:50:37 +0000 (16:50 -0800)]
Test for negative offset passed to ArrayWithOffset
Fixes dotnet/corefx#34699
Commit migrated from https://github.com/dotnet/corefx/commit/
6168758a66ad6bb9584305eccee8b1601299ef03
Dan Moseley [Thu, 24 Jan 2019 02:09:18 +0000 (18:09 -0800)]
Increase timeout in Process test (dotnet/corefx#34753)
Commit migrated from https://github.com/dotnet/corefx/commit/
ef23e3317ca6e83f1e959ab265a8e59fb8a6dcd9
Stephen Toub [Thu, 24 Jan 2019 02:07:21 +0000 (21:07 -0500)]
Filter apphost rather than trying to have nuget suppress it (dotnet/corefx#34785)
NuGet wasn't honoring the Exclude=all across runtime dependencies
but I can make this simpler by just telling depproj filtering
target to remove the file.
Commit migrated from https://github.com/dotnet/corefx/commit/
0f6c2fc52b969309308faf442fc77ef99f370344
dotnet-maestro-bot [Thu, 24 Jan 2019 02:07:01 +0000 (18:07 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19073.1, beta-27323-00, beta-27323-00, respectively (dotnet/corefx#34748)
Commit migrated from https://github.com/dotnet/corefx/commit/
e95daf2da50c826c9931e0b7d483551d448cffda
Maryam Ariyan [Thu, 24 Jan 2019 01:19:21 +0000 (17:19 -0800)]
Expose System.Media.SoundPlayer in System.Windows.Extensions (dotnet/corefx#34649)
* Port System.Media members
* Add System.Media tests
Commit migrated from https://github.com/dotnet/corefx/commit/
438e6af0b9d69610b25417da41ea00b2830d1b0d
Maryam Ariyan [Thu, 24 Jan 2019 01:15:26 +0000 (17:15 -0800)]
Add lock around timersSignalled (dotnet/corefx#34790)
Fixes: dotnet/corefx#22108
Commit migrated from https://github.com/dotnet/corefx/commit/
8c7771a74510479afc7417041cb5208354164ff6
Tarek Mahmoud Sayed [Tue, 22 Jan 2019 23:44:24 +0000 (15:44 -0800)]
Reduce the time spent in System.Linq.Parallel.Tests
A couple of tests are failing because running for long time. The change here is to reduce the time spent there to avoid such failures in the outerloop runs
Commit migrated from https://github.com/dotnet/corefx/commit/
1c7b52620676d3578d940d00f2768678d289f8e4
Stephen Toub [Wed, 23 Jan 2019 23:34:30 +0000 (18:34 -0500)]
Fix build warnings for System.Threading.Channels ref (dotnet/corefx#34787)
Commit migrated from https://github.com/dotnet/corefx/commit/
f00a336700b207f51b83a1a0201c6353fdaff7a8
Eric St. John [Wed, 23 Jan 2019 20:52:35 +0000 (12:52 -0800)]
Filter apphost rather than trying to have nuget suppress it
NuGet wasn't honoring the Exclude=all across runtime dependencies
but I can make this simpler by just telling depproj filtering
target to remove the file.
Commit migrated from https://github.com/dotnet/corefx/commit/
16e45eea9a85c206ca7ec6b4ebc18a4a5187cd55
Dan Moseley [Wed, 23 Jan 2019 20:03:00 +0000 (12:03 -0800)]
Make TimerFiring test more robust to machine disturbances (dotnet/corefx#34762)
* Retries around timer test
* bug
* Add delay
Commit migrated from https://github.com/dotnet/corefx/commit/
81be7f52b9d0769e3fd5058292af53aa892de7c3
Jose Perez Rodriguez [Wed, 23 Jan 2019 19:23:13 +0000 (11:23 -0800)]
Adding alpine 3.8 to the RID graph (dotnet/corefx#34758)
* Adding alpine 3.8 to the RID graph
* Adding alpine 3.9 to the RID graph
Commit migrated from https://github.com/dotnet/corefx/commit/
47f042960fa1b9c651ca1370d5548852ffdcd339
Santiago Fernandez Madero [Wed, 23 Jan 2019 18:38:59 +0000 (10:38 -0800)]
Update testing with private CoreCLR bits
Remove the `--` to pass in `/p:CoreCLROverridePath` to `build.cmd` as it no longer needed.
Commit migrated from https://github.com/dotnet/corefx/commit/
0e7236fda21a07302b14030c82f79bb981c723a6
Stephen Toub [Wed, 23 Jan 2019 15:55:26 +0000 (10:55 -0500)]
Add ChannelReader.ReadAllAsync to System.Threading.Channels (dotnet/corefx#34756)
* Add ChannelReader.ReadAllAsync to System.Threading.Channels
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
abc7e38a7a6bb0eed6a972127438685d7e9cbc98
Ahson Khan [Wed, 23 Jan 2019 08:19:01 +0000 (00:19 -0800)]
Add try/catch OOM around large tests and exclude tests on x86 (dotnet/corefx#34763)
* Add try/catch OOM around large tests and exclude tests on x86
* Address PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
bc0cfc49d1a8c1681fb09603f3389ef65342d542