Mike Blumenkrantz [Mon, 22 Apr 2019 11:21:58 +0000 (07:21 -0400)]
autotools: add lib/evas/common/evas_map_image_internal_high.c to dist
Summary: ref
84e162b01f542f31bc1c6dfc0f190eb965211229
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D8676
Wonki Kim [Mon, 22 Apr 2019 11:06:58 +0000 (07:06 -0400)]
ecore_wl2_input: fix a way it works when it has multiple input devices
Summary:
if there are multiple input devices, especially touch and mouse type devices simultaneous.
a logic can't recognize the current input device in _ecore_wl2_input_mouse_move_send function.
because focus.touch would not be cleared even touch actions from user has finished.
This patch clears input->focus.touch if users release their finger from touch device.
Reviewers: raster, eagleeye, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8673
Yeongjong Lee [Mon, 22 Apr 2019 02:00:33 +0000 (11:00 +0900)]
efl_access: remove all legacy usage from eo files
@tizen_fix
Change-Id: I6ce352eb4839d73788e67fd6e605401521e0a128
Yeongjong Lee [Thu, 18 Apr 2019 08:22:44 +0000 (08:22 +0000)]
ui.table: remove leagcy evas_table from Efl.Ui.Table
Remove evas_table.
This expect to improve performance by removing internal function call related
evas_table.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8615
Yeongjong Lee [Wed, 17 Apr 2019 08:24:25 +0000 (08:24 +0000)]
ui.relative_layout: replace evas_object_event_callback_xxx with efl_event_callback_xxx
remove legacy function
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8630
Cedric BAIL [Tue, 2 Apr 2019 18:42:48 +0000 (11:42 -0700)]
elementary: fix another instances of no parent for Efl.Io.Model.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8539
Cedric BAIL [Tue, 2 Apr 2019 17:04:32 +0000 (10:04 -0700)]
elementary: fix elm_fileselector_entry model_get to be properly build with a parent and synchronously.
This fix the following warning:
ERR<12924>:eo ../src/lib/eo/eo.c:880 _efl_add_internal_start() Creation of 'Efl.Io.Model' object at line 443 in '../src/lib/elementary/elc_fileselector_entry.c' is done without parent. This should use efl_add_ref.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8536
Cedric BAIL [Tue, 2 Apr 2019 19:30:45 +0000 (12:30 -0700)]
elementary: add a queue to postpone object destruction when necessary.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8540
Cedric BAIL [Thu, 18 Apr 2019 23:17:05 +0000 (16:17 -0700)]
elementary: enforce Efl.IoModel as a base type for fileselector.
On the long run, we might just want to have an Efl.Model dedicated to
be used by fileselector and inherit Efl.IoModel from it. At the moment,
we don't, but I think it is still best to rely on this assumption to
make the fileselector code simpler.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8654
Cedric BAIL [Thu, 18 Apr 2019 23:16:26 +0000 (16:16 -0700)]
eio: rely on inheritance and reflection for Efl.IoModel path property.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8653
Cedric BAIL [Thu, 18 Apr 2019 23:15:16 +0000 (16:15 -0700)]
ecore: implement reflection for Efl.LoopModel properties.
This enable relying on Eo reflection capabilities to expose Efl.Model properties.
Should make API nicer to maintain.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8652
Marcel Hollerbach [Wed, 17 Apr 2019 12:45:19 +0000 (14:45 +0200)]
efl_ui_spec: add tests for efl.content
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8640
Marcel Hollerbach [Wed, 17 Apr 2019 14:41:33 +0000 (16:41 +0200)]
elm_part_helper: emit changed events when content is changed
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8639
Marcel Hollerbach [Wed, 17 Apr 2019 16:52:31 +0000 (18:52 +0200)]
efl_ui_win: do not error when NULL is setted as content
NULL is valid, and the sub_object code does refuse to allow NULL, hence
we need this check here.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8638
Marcel Hollerbach [Wed, 17 Apr 2019 16:51:32 +0000 (18:51 +0200)]
efl_ui_layout: only delete and unparent objects here when alive
something else might cause the object to get magically revived. Once the
object is invalidated, some things are able to set a parent again, which
causes the widget to continue with refcount 1 and a parent.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8637
Marcel Hollerbach [Wed, 17 Apr 2019 15:43:21 +0000 (17:43 +0200)]
efl_ui_panel: redo content handling
before the events where not emitted correctly. Additionally input values
like 0x1 have been accepted as valid.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8636
Hermet Park [Fri, 19 Apr 2019 06:21:07 +0000 (15:21 +0900)]
evas svg: code refactoring.
reorder data fields to packing memory fit.
JunsuChoi [Fri, 19 Apr 2019 06:07:11 +0000 (15:07 +0900)]
vg_common_svg : Implement gradientTransform property of linearGradient
Summary:
Svg parser gets transformation matrix information from svg.
If there is a matrix, calculate matrix operations
on the start and end points of the gradient.
TODO: We should implement gradientTransform of radialGradient.
Test Plan: N/A
Reviewers: Hermet, smohanty
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8663
JunsuChoi [Fri, 19 Apr 2019 04:56:48 +0000 (13:56 +0900)]
vg_common_svg: Prevent duplicate operations for percentage value
Summary:
x1, y1, x2 and y2 of Svg_Linear_Gradient structure must be a percentage value.(0 ~ 1)
but these variables are reused with efl_gfx_gradient_linear_start/end_set/get
and duplicate operations occur.
Test Plan: N/A
Reviewers: Hermet, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8662
Cedric BAIL [Thu, 28 Mar 2019 19:42:45 +0000 (12:42 -0700)]
elementary: ensure that the parent model is still alive when resolving future for fileselector.
This future where relying on the parent model being alive to work (efl_parent_get). For
that reason we should have been using efl_future_then with the parent Model as a measure
to make sure this is always the case.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8500
Cedric BAIL [Thu, 4 Apr 2019 00:24:22 +0000 (17:24 -0700)]
ecore: move property string definition to shared headers for Efl.Composite_Model.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8568
Vincent Torri [Thu, 18 Apr 2019 18:48:12 +0000 (14:48 -0400)]
Evil tests: remove tests of functions provided by mingw-w64
Summary: mingw-w64 developpers already tests basename and dirname
Test Plan: compilation
Reviewers: zmike, raster
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8649
Daniel Kolesa [Thu, 18 Apr 2019 17:35:36 +0000 (19:35 +0200)]
eolian: remove legacy generation from tests
Mike Blumenkrantz [Thu, 18 Apr 2019 16:35:52 +0000 (12:35 -0400)]
ci: disable mingw build temporarily
Summary: this cannot succeed until the docker image is rebuilt
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8648
Marcel Hollerbach [Thu, 18 Apr 2019 13:31:57 +0000 (09:31 -0400)]
meson: unbreak cxx header installation
Summary:
before we had *correct* fileds in the subdir: keyword. However,
install_dir: was wrong, so *this* time, this seems right.
Reviewers: cedric, zmike, segfaultxavi, raster
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8634
Vincent Torri [Thu, 18 Apr 2019 13:31:51 +0000 (09:31 -0400)]
Windows: remove fnmatch and regex in Evil and use the ones in regex DLL installed by ewpi
Test Plan: compilation with autotools and meson (at least as far as it can go)
Reviewers: zmike, raster
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8646
Vincent Torri [Thu, 18 Apr 2019 13:29:31 +0000 (09:29 -0400)]
ecore_sdl: fix detection of sdl with meson build
Summary: SDL 2.* pkconfig file is sdl2, not sdl
Test Plan: meson configuration
Reviewers: zmike, raster
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8647
Daniel Kolesa [Thu, 18 Apr 2019 16:10:45 +0000 (18:10 +0200)]
eolian_gen: remove support for legacy header file generation
Daniel Kolesa [Thu, 18 Apr 2019 15:55:06 +0000 (17:55 +0200)]
autotools: remove usage of eolian_gen .eo.legacy.h generation
Daniel Kolesa [Thu, 18 Apr 2019 15:50:42 +0000 (17:50 +0200)]
meson: remove usage of eolian_gen .eo.legacy.h generation
Daniel Kolesa [Thu, 18 Apr 2019 15:08:47 +0000 (17:08 +0200)]
elm_scroller_legacy: remove generated legacy include
Instead replace with the type definitions in this place. It is
not included from anywhere else, so it's fine.
Mike Blumenkrantz [Tue, 16 Apr 2019 12:34:09 +0000 (08:34 -0400)]
tests: add api coverage for evas image
verify that legacy apis function as expected when using legacy api to
load and unload images
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8619
Mike Blumenkrantz [Thu, 18 Apr 2019 13:05:31 +0000 (09:05 -0400)]
evas: implement Efl.File.unload for evas image classes
this fixes unloading images using the evas_object_image_file_set legacy
api
ref D8616
Differential Revision: https://phab.enlightenment.org/D8618
Daniel Kolesa [Thu, 18 Apr 2019 13:45:44 +0000 (15:45 +0200)]
evas_legacy: remove unused generated legacy includes
These define types never used in Evas_Legacy.h.
Daniel Kolesa [Thu, 18 Apr 2019 13:31:55 +0000 (15:31 +0200)]
efl_ui_layout, elm_layout_legacy: add missing/remove unused include
The efl_ui_layout.eo.h header was incorrectly not included in
Elementary.h, which resulted in build failures after the legacy
and otherwise unused efl_ui_layout.eo.legacy.h include was removed.
Daniel Kolesa [Thu, 18 Apr 2019 13:28:59 +0000 (15:28 +0200)]
elm_progressbar_legacy: remove unused include
This does not define anything useful.
Daniel Kolesa [Thu, 18 Apr 2019 13:27:50 +0000 (15:27 +0200)]
efl_ui_slider: remove unused legacy header include
This does not define anything useful.
Daniel Kolesa [Thu, 18 Apr 2019 13:24:58 +0000 (15:24 +0200)]
elm_image_legacy: remove bad "legacy" include
This only contains some Efl_ structures and typedefs now, hidden
behind a BETA_API define. It has no place in legacy.
Christopher Michael [Thu, 18 Apr 2019 13:10:49 +0000 (09:10 -0400)]
ecore-drm2: Fix API function parameters for background color set
Passing int as parameters here is too small for left shifting the
colors so make these parameters uint64_t
Christopher Michael [Thu, 18 Apr 2019 13:07:17 +0000 (09:07 -0400)]
ecore-drm2: Update printf format to match changed value type
Commit
8e0c4d83edd changed the atomic property value type to be
uint64_t so we need to update the printf's to reflect that
Christopher Michael [Mon, 1 Apr 2019 14:28:40 +0000 (10:28 -0400)]
ecore-drm2: Add API function to set crtc background color
This patch adds a new API function we can be called in order to set
the crtc background color of a given output.
@feature
Christopher Michael [Mon, 1 Apr 2019 12:41:38 +0000 (08:41 -0400)]
ecore-drm2: Fill in crtc background color (if supported) during atomic
commits
Small patch to add the crtc background_color property (if supported)
to any atomic tests/commits
@feature
Christopher Michael [Mon, 1 Apr 2019 12:40:14 +0000 (08:40 -0400)]
ecore-drm2: Add background_color to crtc atomic properties
This patch adds a new field to the crtc atomic state which will be
used to support crtc background_color property, and also fills in that
state during crtc atomic state fill.
@feature
Christopher Michael [Mon, 1 Apr 2019 12:13:32 +0000 (08:13 -0400)]
ecore-drm2: Make atomic property values support uint64_t
Some Atomic property values are actually uint64_t, so fix the
structure to reflect that.
@fix
Hermet Park [Thu, 18 Apr 2019 11:08:16 +0000 (20:08 +0900)]
evas gl: move to floating point coordinate system.
Summary:
GL engine has used integer coordinates system since it's born though
OpenGL basically uses floating point vertex coordinates system.
There were many dissatisfaction, complaints about this
since object's transition is jiggled, not perfectly smooth.
It's obvious because Positioning must be stepping with integer units
without any subpixel rendering.
Our gl engine currently supports msaa options and evas map allows to
have double precivion coordinates system, our engine must do handle this over as well,
to work together.
If you don't like change,
We could switch behaviors optionally (turn on, only when msaa is enabled)
But I think it's pointless using integer coordinates system in GL thesedays.
It just make code complex to maintain.
There will be an additional patch coming for SW backend map behavior soon.
Left: before patch
Right: after patch
{
F3694624}
Reviewers: #committers, raster
Reviewed By: #committers, raster
Subscribers: raster, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8552
Change-Id: Icd0d0abc8805b1654c99e2e2171ba45a7a2e98d8
Hermet Park [Thu, 18 Apr 2019 10:30:33 +0000 (19:30 +0900)]
evas map: move to floating point coordinate system in high-quality drawing.
evas map has used integer coodinate system since it's born,
since object's transition is jiggled, not perfectly smooth.
It's obvious because Positioning must be stepping with integer units
without any subpixel rendering.
Currently, this patch is a sort of preparatory to improve this,
only valid for high-quality evas map (smooth + anti-aliasing)
Carsten Haitzler (Rasterman) [Thu, 18 Apr 2019 10:33:10 +0000 (11:33 +0100)]
eina vpath - fix windows warning as simply as possible
the warning is wrong - so keep things simple
Hermet Park [Thu, 18 Apr 2019 10:21:18 +0000 (19:21 +0900)]
canvas map: remove the workaround code.
Summary:
the perspective could be handled in the gl backend,
Here map coordinates don't need to get perspective ones but
local coordinates instead as it does same to integer coordinates.
I have no idea origin issues exactly,
but this changed fx, fy values are working correctly in client side.
Reviewers: devilhorns, #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8563
Hermet Park [Thu, 18 Apr 2019 09:51:16 +0000 (18:51 +0900)]
evas common: small optimization.
don't repeat computing every iteration.
Marcel Hollerbach [Thu, 18 Apr 2019 07:50:43 +0000 (09:50 +0200)]
Revert "tests: add api coverage for evas image"
This reverts commit
cf70826b33a6840f884c090e911f501c758931a7.
This test cannot work right now because the fix has not landed.
Xavi Artigas [Wed, 17 Apr 2019 15:02:12 +0000 (15:02 +0000)]
docs: Clarify Efl.Content behavior
Now we need to make sure implementations actually follow this behavior.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8635
Yeongjong Lee [Wed, 17 Apr 2019 08:15:15 +0000 (08:15 +0000)]
efl/elm_scroller: apply color_set correctly
hit_rect/event_rect should ignore color_set.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8629
Yeongjong Lee [Fri, 12 Apr 2019 05:38:00 +0000 (05:38 +0000)]
ui.widget: remove elm_widget_sub_object_parent_add from each of widgets
since commit
a1addad60e, To add myself as a sub object of parent object will be
done in Efl.Ui.Widget constructor.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8280
Ali Alzyod [Tue, 9 Apr 2019 15:17:13 +0000 (15:17 +0000)]
Freeing Global Memory list on destructor
Issue with global list item, used to same styles. (in destructor we do not remove styles from it, which will cause memory leak)
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8578
Hermet Park [Thu, 18 Apr 2019 06:08:35 +0000 (15:08 +0900)]
evas map: shut up annoying compile warnings.
These variables must be logically initialized,
but compiler couldn't catch it, prints warnings.
Mike Blumenkrantz [Thu, 18 Apr 2019 00:59:58 +0000 (09:59 +0900)]
tests: add api coverage for evas image
Summary:
verify that legacy apis function as expected when using legacy api to
load and unload images
Depends on D8618
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8619
Vincent Torri [Wed, 17 Apr 2019 21:31:21 +0000 (17:31 -0400)]
ecore_win32: use AddClipboardFormatListener and RemoveClipboardFormatListener explicitely
instead of loading them from user32.dll
Summary: current mingw-w64 declare these functions
Test Plan: compilation
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8644
Vincent Torri [Wed, 17 Apr 2019 19:45:50 +0000 (15:45 -0400)]
ecore_win32: remove explicit define of WM_CLIPBOARDUPDATE
Summary: since ewpi is used, a newer mingw-w64 is used, which defines WM_CLIPBOARDUPDATE
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8643
Mike Blumenkrantz [Wed, 17 Apr 2019 19:45:35 +0000 (15:45 -0400)]
build: use only BUILD_ECORE_IMF_XIM as a define
Summary:
meson and autotools were a bit out of sync with this, resulting in
unexpected behavior
Reviewers: billiob
Reviewed By: billiob
Subscribers: billiob, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8641
Carsten Haitzler (Rasterman) [Wed, 17 Apr 2019 15:39:52 +0000 (16:39 +0100)]
eina vpath - clear up vpath to handle env vars that are too big as fatal
Vincent Torri [Wed, 17 Apr 2019 14:30:34 +0000 (15:30 +0100)]
eina_vpath: port to Windows
Test Plan: test example
Reviewers: raster, cedric, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8633
Cedric BAIL [Wed, 17 Apr 2019 16:35:06 +0000 (12:35 -0400)]
eio: remove unecessary printf from tests.
Summary: Depends on D8539
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8542
Boris Faure [Wed, 17 Apr 2019 15:18:56 +0000 (11:18 -0400)]
autotools: remove all usage of evas_image_loader_tgv_(cflags|libs)
Summary:
these are empty variables which are apparently causing build errors for
some users in certain cases
Finishes work from
c2ae61ed0dd367bd589eb73c4bfe2f68dac92d23 (
https://phab.enlightenment.org/D7876 )
Reviewers: zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8623
Vincent Torri [Wed, 17 Apr 2019 14:45:07 +0000 (10:45 -0400)]
efl-net.pc.in : honor datarootdir
Reviewers: raster, zmike
Reviewed By: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8632
Marcel Hollerbach [Thu, 4 Apr 2019 11:30:40 +0000 (13:30 +0200)]
behavior-tests: add Efl.Ui.Table
there are no tests for Efl.Pack_Table for now, so here comes unification
for Efl.Pack tests.
Differential Revision: https://phab.enlightenment.org/D8557
Marcel Hollerbach [Thu, 4 Apr 2019 11:46:53 +0000 (13:46 +0200)]
efl_ui_table: remove callbacks when item is removed
everything else is wrong.
Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8556
Marcel Hollerbach [Thu, 4 Apr 2019 11:30:08 +0000 (13:30 +0200)]
efl_ui_table: correctly delete all items when clearing / unpacking
otherwise we do not clear the internals, and fail to get the count to 0.
Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8555
Marcel Hollerbach [Thu, 4 Apr 2019 11:24:59 +0000 (13:24 +0200)]
efl_ui_table: hardening of pack_at function
_pack_at is used to add new subobjects to the table. When a object is
already part of this table, then we should not add it again. Additional,
when there is already a gi structure, but the parent is something else,
then we should NOT just reuse this struct, otherwise we might use a
struct reference that we do not own. The struct could be owned by
another table widget.
The test must be adjusted, before we did not error on adding a widget
twice. Now we do (just like in box). Hence we should not do that in
test.
Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8554
Marcel Hollerbach [Fri, 29 Mar 2019 07:14:05 +0000 (08:14 +0100)]
elm: here comes a new testsuite
We have two elementary test suite, what is more obvious than just adding
a third one! This testsuite aims for establishing a standard behaviour
for the interfaces we have added in efl now. This first part here brings
a few testcases for Efl.Pack which are currently only passing for
Efl.Ui.Box. More widgets will be added afterwards.
The testcases themself are not defined after what worked or did not
work, but rather what made sence (in my opinion ^_^).
ref T7767
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8518
Marcel Hollerbach [Mon, 1 Apr 2019 12:45:19 +0000 (14:45 +0200)]
efl_ui_box: print more errors,
when a element is added two times, we should print an error. Same for
removing a child that is not part of this container.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8522
Marcel Hollerbach [Sun, 31 Mar 2019 16:12:48 +0000 (18:12 +0200)]
efl_ui_widget: we should ensure that every subobject is a gfx entity
we are calling visible_set on them later on, this will drop errors,
additionally this safes us from checking this in the widget-container
code.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8520
Yeongjong Lee [Fri, 12 Apr 2019 10:18:04 +0000 (10:18 +0000)]
ui.box: remove leagcy evas_box from Efl.Ui.Box
Remove legacy stuff from Efl.Ui.Box.
This expect to improve performance by removing internal function call related
evas_box.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8417
Yeongjong Lee [Fri, 12 Apr 2019 07:03:28 +0000 (07:03 +0000)]
efl.pack_linear: Clarify behavior and docs
Some APIs accept both positive and negative indices when accessing items.
This patch changes the documentation for the lower limit from `-(count - 1)` to
`-count` to allow accessing the very first item.
For example (content_count = 5):
| |first item| | | |last item|
|positive index| 0 | 1| 2| 3| 4 |
|negative index| -5 |-4|-3|-2| -1 |
If negative indices are limited to be >= -4 the first item cannot be accessed
using negative indices.
Also, range limit of `pack_at` is removed for usability.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8433
Jaehyun Cho [Wed, 17 Apr 2019 06:00:58 +0000 (15:00 +0900)]
efl_ui_pager: fix to delete component objects when pager is deleted
Pager creates Efl.Canvas.Rectangle objects when pager is constructed.
Since the parent of these component objects is evas, these component
objects are not deleted automatically when pager is deleted.
These component objects cause event block after pager is deleted.
(e.g. click event is blocked)
To resolve this issue, these component objects are deleted manually when
pager is deleted.
Jaehyun Cho [Wed, 17 Apr 2019 01:41:55 +0000 (10:41 +0900)]
Revert "Revert "elm - fix harmless warning for clean build""
This reverts commit
d2eebb6f5faebc76a1a13494fd0721e8d63af410.
To restore
e3d2a0cf1235beceb3b403e42d2dafed4b4e90e5 which implements
features during feature freeze period, the revert commit is reverted.
Jaehyun Cho [Wed, 17 Apr 2019 01:41:50 +0000 (10:41 +0900)]
Revert "Revert "test/efl_ui_pager: fix demo""
This reverts commit
f652bf932837846c5911c26992196213780394df.
To restore
d3bb1a7342b2725c585d90557926e0c433058e50 which implements
features during feature freeze period, the revert commit is reverted.
Jaehyun Cho [Wed, 17 Apr 2019 01:41:43 +0000 (10:41 +0900)]
Revert "Revert "test/efl_ui_pager_scroll: fix demo""
This reverts commit
5742caa6016bf0ea852059546ded493c2d52b1a7.
To restore
30bd541bf264d369e2a96d27fa3ff5139c360e26 which implements
features during feature freeze period, the revert commit is reverted.
Jaehyun Cho [Wed, 17 Apr 2019 01:41:38 +0000 (10:41 +0900)]
Revert "Revert "efl_ui_pager: implement unpack_all/clear function""
This reverts commit
b28f1e034b7ecbe7966b0d2b9687d8e22245837c.
To restore
74c48f029632d2260816b4cb3de6dbb40a29f040 which implements
features during feature freeze period, the revert commit is reverted.
Jaehyun Cho [Wed, 17 Apr 2019 01:41:32 +0000 (10:41 +0900)]
Revert "Revert "efl_ui_pager: implement unpack_at function""
This reverts commit
a10e1bc597f00865514f30d84268963dcbf3f599.
To restore
913a5bff66dd7a58753ccae1474657ec33350e43 which implements
features during feature freeze period, the revert commit is reverted.
Hermet Park [Wed, 24 Apr 2019 05:01:06 +0000 (14:01 +0900)]
evas wbmp: fix wrong calc order.
Double check patch again, since my wrong logical thinking,
Every width must be considered to rounding up fiting 8 bits.
this new compuation must be correct.
Change-Id: I112b88560b97e7e413f24b6d17ecaff3588d280e
Hermet Park [Wed, 24 Apr 2019 04:19:12 +0000 (13:19 +0900)]
eolian: remove unreachable code.
Change-Id: I488e77800e2bc682a8b79268065f5f6500eefcb7
Hermet Park [Wed, 24 Apr 2019 01:18:57 +0000 (10:18 +0900)]
evas wbmp loader: coming previous patch with fixing wrong calc.
Those bits must be rounded if they are not fit to 8 bits.
Change-Id: I04fff0d46fb5228e2107ce0207cc8b1245ba678c
see:
68fe9ec6bf60b4730ad7fdbf2698dc7aa130b94d
Hermet Park [Tue, 23 Apr 2019 12:31:06 +0000 (21:31 +0900)]
evas wbmp: remove unnecessary size overflow.
since this patch
68fe9ec6bf60b4730ad7fdbf2698dc7aa130b94d
it checks size validation earlier,
this varification doesn't need anymore...
Change-Id: I395f664efebf6c0ccaaea1b5cd7882917ab276f5
Hermet Park [Tue, 23 Apr 2019 10:04:21 +0000 (19:04 +0900)]
evas image: check format more strong way for wbmp.
wbmp format doesn't have any tags for verifying file header,
It's easy to pass other format headers if they have the first 1 byte 0x0,
This ocassionally brings wrong result (= succeeed loading image),
if unknown file format is tried.
So, to make it sure, here verify the size of image additionally.
if the image size is not expected, It returns fail as the result.
This problem is actually happened in this scenario.
open any mpeg file with elm_image.
elm_image_file_set() will return true though it fails to read data.
since wbmp make it pass to succeed.
@fix
Change-Id: I56a117e1b161d1dd13c512cb9a48d92a7b6caf33
Jaehyun Cho [Fri, 19 Apr 2019 03:14:54 +0000 (12:14 +0900)]
efl_mono: install libeflcustomexportsmono.so to support EflSharp by meson
EflSharp application installed by dotnet requires
libeflcustomexportsmono.so files to be executed.
To support EflSharp application, libeflcustomexportsmono.so files are
installed without --enable-csharp-bindings option by meson build.
Change-Id: I00f6486e00f2dc6b4269c684df7c5ece462c8ff8
Shinwoo Kim [Mon, 22 Apr 2019 02:53:50 +0000 (11:53 +0900)]
Efl.Ui.Animation_View: remove double free
Following step makes SIGABORT by double free.
1. elm_animation_view_add
2. elm_animation_view_file_set
3. evas_object_del
The first free occurs in
(gdb) bt
#0 eina_stringshare_del
#1 _efl_ui_animation_view_efl_canvas_group_group_del
#2 efl_canvas_group_del
#3 evas_object_smart_del
#4 _efl_canvas_object_efl_object_invalidate
#5 efl_invalidate
#6 _efl_ui_widget_efl_object_invalidate
#7 efl_invalidate
#8 _efl_invalidate
#9 _efl_object_parent_set
#10 efl_parent_set
#11 efl_parent_set
#12 efl_del
#13 elm_main
#14 main
the second free occurs in
(gdb) bt
#0 eina_stringshare_del
#1 _efl_file_efl_object_destructor
#2 efl_destructor
#3 efl_destructor
#4 _efl_del_internal
#5 _efl_unref_internal
#6 efl_del
#7 evas_object_del
#8 _efl_ui_widget_efl_canvas_group_group_del
#9 efl_canvas_group_del
#10 efl_canvas_group_del
#11 evas_object_smart_del
#12 _efl_canvas_object_efl_object_invalidate
#13 efl_invalidate
#14 _efl_ui_widget_efl_object_invalidate
#15 efl_invalidate
#16 _efl_invalidate
#17 _efl_object_parent_set
#18 efl_parent_set
#19 efl_parent_set
#20 efl_del
#21 elm_main
#22 main
Change-Id: Iabedaacc6fc82f87e5d4d78bc4a20030419148aa
Woochanlee [Mon, 22 Apr 2019 09:48:26 +0000 (18:48 +0900)]
elm_genlist: Avoid edje recalc in no size, position changed case.
Change-Id: Id6019f34bcca5c4cdad3c9bef4a976c328517fef
Wonki Kim [Wed, 17 Apr 2019 10:27:30 +0000 (19:27 +0900)]
meson: modify meson definitions for gl_generic module
in tizen environment, gl_generic module can't be dynamically loadded,
because some symbols are not linked.
so this patch modify meson definitions to build gl_generic
as static linked library . it's workaround.
and also there are some sources that exist on tizen only. this patch appends them.
@tizen_only
Change-Id: I50a5ee74a684a93a102698cdb276e03e0b1d8134
Shinwoo Kim [Fri, 19 Apr 2019 08:18:26 +0000 (17:18 +0900)]
Revert "edje_calc: make INTP use TO_INT_ROUND"
Summary:
This reverts commit
be00af9bc3d534ede3965693618684fe38fd8786 which has
incorrect calculation. For more information please refer to:
https://phab.enlightenment.org/D8665
Reviewers: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8666
Change-Id: I878418da20ade0396ee218579452e7ded882ffa8
Taehyub Kim [Fri, 19 Apr 2019 07:17:03 +0000 (16:17 +0900)]
elc_popup: fix theme logic for the label in popup
Change-Id: Ibc3156f805532c36e2934cb78e962b9ae10ac6ff
Jaehyun Cho [Thu, 18 Apr 2019 07:35:23 +0000 (16:35 +0900)]
efl_mono: install libeflcustomexportsmono.so to support EflSharp
EflSharp application installed by dotnet requires
libeflcustomexportsmono.so files to be executed.
To support EflSharp application, libeflcustomexportsmono.so files are
installed without --enable-csharp-bindings option.
Change-Id: I3f4bcc95d86fb2366363b49db2c9b684a0dafac3
Shinwoo Kim [Thu, 18 Apr 2019 00:28:57 +0000 (09:28 +0900)]
doc: follow document policy for deprecated API
(1) The @deprecated should come first than other information.
(2) The @brief should follow just after @deprecated
(3) Use correct version information for ACR
Change-Id: Ia7bc8469bd89449fef80ca6ac284ec39bf0b589c
JunsuChoi [Thu, 18 Apr 2019 01:22:34 +0000 (10:22 +0900)]
vg_json: Set multiple mask from json
Summary:
This patch supports multiple masks for multiple attributes on a layer.
Make main_mask_layer and make each mask EFL_CANVAS_VG_CONTAINER_CLASS and connect them.
main_mask_layer is made for masks
The masks are composited into main_mask_layer in order.
main_mask_layer exists for the intersect option in last order
This can be optimized later, and is created and used temporarily in this patch.
Test Plan:
If there are three masks, they can be created as below.
mask_set(clayer, main_mask);
mask_set(main_mask, mask_1);
mask_set(mask_1, mask_2);
mask_set(mask_2, mask_3);
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, kimcinoo, #reviewers, smohanty, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8507
Change-Id: I5a75640308a69e8e7e50800ff2444d6078c4fe4d
Taehyub Kim [Wed, 17 Apr 2019 07:52:13 +0000 (16:52 +0900)]
elm_notify: fix theme apply logic for new return value
Summary: fix theme apply logic for new return value
Test Plan: 1. run elementary_test for elm_notify and elm_popup
Reviewers: Jaehyun_Cho, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8628
Change-Id: I25deb0148fa7f49e597b016f00dc099480b0f430
Radoslaw Cybulski [Wed, 17 Apr 2019 12:20:14 +0000 (14:20 +0200)]
Remove warnings, when used legacy gesture enum
Change-Id: I22f4f3c48806473c1f7f4170d84bea805d82194d
Wonki Kim [Wed, 17 Apr 2019 07:35:11 +0000 (16:35 +0900)]
spec: remove a dependency on gnutls package.
efl doesn't use gnutls library for crypto lib.
so that this patch removes a dependency definition for it.
Change-Id: I08fcbe70f2acea613ca332f98425f27704d181f1
Shinwoo Kim [Wed, 17 Apr 2019 04:38:02 +0000 (13:38 +0900)]
Revert "Remove and update deprecated API"
This reverts commit
95be425c35e82b73058e7ec161cb7ce94fcea6ff.
The ACR-1373 is still ongoing.
Change-Id: I6decc97b7d5add811077fee0ef5f4af105505af2
Shinwoo Kim [Wed, 17 Apr 2019 03:47:20 +0000 (12:47 +0900)]
Migration: fix build errors
(1) Fix duplicate message definition error of po files
(2) Define EFL_BUILD to define EFL_PACK_LAYOUT_PROTECTED which makes lines
using efl_pack_layout_update do not have build error.
Change-Id: I0179d4c0f3b4133459359e2bc729efec0524b67b
Vincent Torri [Tue, 16 Apr 2019 16:59:10 +0000 (17:59 +0100)]
evil: remove tmp and home dir get
Summary: eina implement them for all OSes
Test Plan: compilation
Reviewers: raster, cedric, zmike
Reviewed By: raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8621
Mike Blumenkrantz [Tue, 16 Apr 2019 12:55:11 +0000 (08:55 -0400)]
efl_ui_image: fix warning about calling smooth_scale_set on non-image
Summary: this is triggered during object construction when no image exists
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8617