platform/upstream/efl.git
4 years agoeo : fix 8e6e1860c3, _efl_object_event_future_scheduler_get(…) returns a pointer
Jérémy Zurcher [Wed, 12 Feb 2020 08:08:59 +0000 (09:08 +0100)]
eo : fix 8e6e1860c3, _efl_object_event_future_scheduler_get(…) returns a pointer

4 years agoevas: remove redundant conditions.
Wonki Kim [Wed, 12 Feb 2020 07:48:16 +0000 (16:48 +0900)]
evas: remove redundant conditions.

Summary:
conditions of the inner and outer statement are identical.
this patch removes a condition of them.

Reviewers: jsuya, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11324

4 years agoeo: remove potentional NULL dereferencing
Wonki Kim [Wed, 12 Feb 2020 07:47:33 +0000 (16:47 +0900)]
eo: remove potentional NULL dereferencing

Summary: this patch removes a potentional NULL dereferencing

Reviewers: jsuya, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11325

4 years agoedje_cc : remove potential NULL dereferencing
Wonki Kim [Wed, 12 Feb 2020 07:47:00 +0000 (16:47 +0900)]
edje_cc : remove potential NULL dereferencing

Summary: this patch removes potential NULL deferencing in edje_cc

Reviewers: jsuya, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11326

4 years agoefl_ui_position_manager_list: add NULL check for memory allocation
Yeongjong Lee [Wed, 12 Feb 2020 07:45:40 +0000 (16:45 +0900)]
efl_ui_position_manager_list: add NULL check for memory allocation

Reviewers: Jaehyun_Cho, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11312

4 years agoevas_render: initialize variable
Shinwoo Kim [Tue, 11 Feb 2020 14:03:43 +0000 (09:03 -0500)]
evas_render: initialize variable

Summary:
evas_object_image_load_region_get could be called with following stack.

(#0) evas_object_image_load_region_get
(#1) evas_render_proxy_subrender
(#2) evas_filter_context_proxy_render_all
(#3) evas_filter_object_render
(#4) evas_object_text_render

This means that evas_object_image_load_region_get is called by text object.
In this case, the load region value has garbabe, and it leads to invalid
memory access which is detected by Assan(T8610).

This patch initialize variable before using evas_object_image_load_region_set.

Reviewers: Hermet, jsuya, bu5hm4n, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11316

4 years agoevas proxy: make it work for load_region
Shinwoo Kim [Tue, 4 Feb 2020 03:14:23 +0000 (12:14 +0900)]
evas proxy: make it work for load_region

Summary:
This makes a proxy object use a selective region of a source object.
So far a proxy has not worked for load_region at all.
This should be better solution than https://phab.enlightenment.org/D10604
introducing new interface.

This is useful when the source is too big to allocate a proxy surface.
This will be used by elm_scroller to solve following issue.

[Issue]
If size of elm_sclloer content is too big, then the proxy of
elm_scroller to show loop effect does not work. Because
evas_gl_common_image_surface_new does not allow
bigger size surface than max_texture_size

Reviewers: Hermet, jsuya

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10626

Change-Id: I9a8d80eca88a5f2d1d1c1b5425294bcd4017bfa9

4 years agowearable_position_mgr: remove a potentional null dereferencing 47/224647/1
Wonki Kim [Wed, 12 Feb 2020 06:06:07 +0000 (15:06 +0900)]
wearable_position_mgr: remove a potentional null dereferencing

this patch removes a potentional null dereferencing

Change-Id: I6e5fc8fb3aef8376435eb0682c21720fc5a95c24

4 years agoRevert "genlist :disable source clip set to prevent unwanted clipping issue on proxy" 09/224609/2
Hermet Park [Wed, 12 Feb 2020 03:23:06 +0000 (12:23 +0900)]
Revert "genlist :disable source clip set to prevent unwanted clipping issue on proxy"

This reverts commit b2acde3ac2c7da734abeb71e2dd070aa08180876.

Fixed proxy regression bug - d5d9e9a9aafad398c82c5302f36c1be8db53d455

Change-Id: Ie185ef59f19ec15c5405185a63071ecf034856df

4 years agoRevert "Revert "eolian: enforce that list<> can only be used with @beta API."" 96/223596/4
Yeongjong Lee [Fri, 31 Jan 2020 05:24:13 +0000 (14:24 +0900)]
Revert "Revert "eolian: enforce that list<> can only be used with @beta API.""

Build error has been fixed by 8c28c4c6cc6164819d521e9834af537f4978f1ee.

This reverts commit e77fe8c40b8e0b26bc1b86734f304d9a7825ea4b.

Change-Id: I3ed3b7ad9c3b01612b573f34bfc2eb5b1dadb612

4 years agoeolian: finally error on missing since tags 02/224602/1
Marcel Hollerbach [Fri, 31 Jan 2020 15:47:46 +0000 (16:47 +0100)]
eolian: finally error on missing since tags

this is actaully usefull ... for people not forgetting things.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11266

Change-Id: Iae2c685be54e282201b2ffa1ef02b77ffb497a33

4 years agoevas_canvas3d_types: mark @beta Evas.Real 01/224601/1
Yeongjong Lee [Wed, 12 Feb 2020 02:37:12 +0000 (11:37 +0900)]
evas_canvas3d_types: mark @beta Evas.Real

No build error anymore.
ref commit 10b2e407d0a002ef4bc5987cbdafea5fd62952e6.

@tizen_fix
Change-Id: I69fce86a6ba8019a73604eec0689f5a04a956fbc

4 years agoecore_input_device: add since tags for ecore_input_device enums 00/224600/1
Yeongjong Lee [Wed, 12 Feb 2020 02:34:55 +0000 (11:34 +0900)]
ecore_input_device: add since tags for ecore_input_device enums

@tizen_fix

Change-Id: I3403b7e1043e160feee0497cee9659d5a163f945

4 years agoexactness: make it optional and disble it by default
Jongmin Lee [Tue, 11 Feb 2020 22:15:18 +0000 (07:15 +0900)]
exactness: make it optional and disble it by default

@tizen_only

Change-Id: I3b5d3c904c9c10db73ec7533232004f0b26b872b

4 years agoelm perf_test: fix warning of implicit conversion of floating point
Yeongjong Lee [Tue, 11 Feb 2020 13:56:34 +0000 (08:56 -0500)]
elm perf_test: fix warning of implicit conversion of floating point

Summary:
The result of integral division is converted into floating point.
In order to fix this warning, it changes denominator to double from integer.

Reviewers: Jaehyun_Cho, Hermet, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11313

4 years agoefl.canvas.textblock: allow all white spaces in style string not just space
Ali Alzyod [Tue, 11 Feb 2020 11:03:00 +0000 (12:03 +0100)]
efl.canvas.textblock: allow all white spaces in style string not just space

Summary:
style string can contain any kind of white spaces and it will be fine

For example
```
"font=sans font_size=30 color=red "
```
Is the same as
```
"font=sans\tfont_size=30\n  color=red "
```

Reviewers: woohyun, segfaultxavi, tasn, zmike

Reviewed By: segfaultxavi

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8532

Differential Revision: https://phab.enlightenment.org/D11303

4 years agodocs: ecore_animator's default framerate is 60 not 30
Xavi Artigas [Tue, 11 Feb 2020 10:03:49 +0000 (11:03 +0100)]
docs: ecore_animator's default framerate is 60 not 30

This was changed in 81242af6f95 without updating the docs.

4 years agoexactness_player: make use of PATH_MAX define instead of posix variant
Stefan Schmidt [Mon, 10 Feb 2020 11:10:43 +0000 (12:10 +0100)]
exactness_player: make use of PATH_MAX define instead of posix variant

The use of _POSIX_ has lead to a compile problem on old Ubuntu (16.04)
versions. We use PATH_MAX everywhere else so follow suit here.

Fixes T8613

Reviewed-by: Ali Alzyod <ali198724@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11305

4 years agoelm_code_widget: Display cursor within widget.
Alastair Poole [Sun, 9 Feb 2020 21:14:42 +0000 (21:14 +0000)]
elm_code_widget: Display cursor within widget.

Only render the cursor when its within the bounds of the
widget.

4 years agoefl: `eina_value_list_vinsert` assumes that the position is always valid
Lucas Cavalcante de Sousa [Fri, 7 Feb 2020 18:52:15 +0000 (13:52 -0500)]
efl: `eina_value_list_vinsert` assumes that the position is always valid

Summary:
The eina_value_list_vinsert at src/lib/eina_inline_value.x was not checking if the desired position was valid:
When inserting in an empty list in any out of bounds position it actually createded a list with the head being the desired value.
When inserting in a non-empty list in an out of bounds position caused a c error.
Now both cases return EINA_FALSE

Ref T8611

Test Plan:
Meson configured with -Dbindings=mono,cxx -Dmono-beta=true, and tests runned
with ninja test all.

Reviewers: felipealmeida, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8611

Differential Revision: https://phab.enlightenment.org/D11301

4 years agoexactness: fix osx build
Marcel Hollerbach [Fri, 7 Feb 2020 14:04:03 +0000 (15:04 +0100)]
exactness: fix osx build

edje depends on more than just edje_cc.

4 years agoefl.ui.textbox: prevent longpress + right click from working on scrollbars
Ali Alzyod [Fri, 7 Feb 2020 13:15:20 +0000 (14:15 +0100)]
efl.ui.textbox: prevent longpress + right click from working on scrollbars

summary_: Longpress and right click one textbox scrollbars will not show up the menu.

Reviewers: woohyun, bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8604

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11295

4 years agoexactness: cleanup some coding style isues
Stefan Schmidt [Fri, 31 Jan 2020 12:35:54 +0000 (13:35 +0100)]
exactness: cleanup some coding style isues

Just a few that I spotted when looking over the code.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11290

4 years agoexactness: fix init/shutdown handling of efl components in various binaries
Stefan Schmidt [Fri, 31 Jan 2020 12:34:23 +0000 (13:34 +0100)]
exactness: fix init/shutdown handling of efl components in various binaries

The init/shutdown handling for efl libraries was a bit sloppy and
unbalanced in the exactness binaries. Switching over to use
ecore_eas_init/shutdown here instead of doing all libs individually.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11289

4 years agoexactness: remove unused code
Stefan Schmidt [Fri, 31 Jan 2020 12:32:24 +0000 (13:32 +0100)]
exactness: remove unused code

Either commented out, blank lines or no needed includes.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11288

4 years agoexactness: remove no longer needed EO and BETA API defines
Stefan Schmidt [Fri, 31 Jan 2020 12:29:28 +0000 (13:29 +0100)]
exactness: remove no longer needed EO and BETA API defines

This has been in place during development and not updated for recent
changes and merge into efl master.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11287

4 years agoexactness: print out statistics at the end of the run
Stefan Schmidt [Wed, 16 Jan 2019 14:41:50 +0000 (15:41 +0100)]
exactness: print out statistics at the end of the run

Given a better overview after the wall of text we are seeing from
starting and stopping jobs in parallel.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11286

4 years agoexactness: import code from external repo into efl.git
Daniel Zaoui [Mon, 24 Dec 2018 20:51:52 +0000 (22:51 +0200)]
exactness: import code from external repo into efl.git

Exactness has been developed in a separate git repo for many years. This
finally moves it over into efl. Having it in tree allows us for easier
testing with our current main target elementary_test and integration
into our CI system (patches for this are work in progress already).

We are only importing the lib and binary for test execution, not the
full set of test data. This is would be over 500MB and thus it will stay
in a different repo and only made available during the actual testing.

[The original patch was made by Daniel Zaoui. Over the course of review
and testing it got extended with build fixes for API changes and mingw
compilation support from Stefan Schmidt and Michael Blumenkrantz]

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11285

4 years agoelementary: build elementary_test additionally as shared object
Stefan Schmidt [Tue, 4 Feb 2020 10:41:17 +0000 (11:41 +0100)]
elementary: build elementary_test additionally as shared object

For our exactness testing we are dlopen() the elementary_test
executable. Until glibc 2.30 this was posible with -pie, but it changed
in the glibc version. They no longer allow these executables to be
dlopen()'ed.

As a workaround for now we are building elementary_test also as a shared
object file which we load and use in the exactness testing process.

The code came from Marcel Hollerbach and I only tested it and fixed up a
small detail.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11284

4 years agoeolian: fix missing stringshare_ref
Daniel Kolesa [Thu, 6 Feb 2020 13:43:38 +0000 (14:43 +0100)]
eolian: fix missing stringshare_ref

This was properly applied to all cases except this one where it
was overlooked/forgotten. That resulted in the @c_name() feature
with enums being broken because of bad memory.

Fixes T8596.

4 years agoEvas Textblock: update obstacle test
abdulleh Ghujeh [Thu, 6 Feb 2020 06:36:30 +0000 (15:36 +0900)]
Evas Textblock: update obstacle test

Summary:
Update the test to check that the first character is rendered after the obstacle.
To ensure that the obstacle feature keeps working correctly.

Reviewers: ali.alzyod, woohyun

Reviewed By: ali.alzyod

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11033

4 years agoeolian_cxx: fix a last few since errors
Marcel Hollerbach [Wed, 5 Feb 2020 18:42:44 +0000 (19:42 +0100)]
eolian_cxx: fix a last few since errors

sinace has to be > 1.22 and the tests need to reflect that.

4 years agodocs: Remove incorrect doc tag
Xavi Artigas [Wed, 5 Feb 2020 17:53:43 +0000 (18:53 +0100)]
docs: Remove incorrect doc tag

This was breaking build with cxx bindings enabled.

4 years agoevas_object_textbox: deal with <br> <tab> without closing '/'
ali [Wed, 5 Feb 2020 16:01:52 +0000 (16:01 +0000)]
evas_object_textbox: deal with <br> <tab> without closing '/'

This causes many issues because textbox functions deals with <br> <tab> differently depending that user write them with or without '/' at the end (for example <br> vs <br/>)
while most functionaliity are the same (like viewing <br> and <br/> are the same).
cursor dealing with these tags can be differently.
now we will assume <br> <tab> are already have there own closing tag, even if it is missing

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11293

4 years agobindings-cxx: fix missing @since tags at stable c#/cpp tests
Lucas Cavalcante de Sousa [Wed, 5 Feb 2020 14:58:17 +0000 (11:58 -0300)]
bindings-cxx: fix missing @since tags at stable c#/cpp tests

Story:
This revision got landed twice, I do not know what happend, but when i
wanted to land that initially with git phab, something reseted the state
of this revision to the initial version, and also changed the
authorship. This time, this commit contains all changes, and the correct
authorship, sorry for the noise.

Summary:
Add @since tags at stable (not tagged with @beta) `.eo` c#/c++ tests. Doing so,
eolian_enforce_since shouldn't accuse at stable tests.
Depends on D11264
Resolves T8600

Reviewers: zmike, segfaultxavi, woohyun, bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8600

Differential Revision: https://phab.enlightenment.org/D11265

4 years agoeot files: fixup all since tags
Marcel Hollerbach [Wed, 5 Feb 2020 15:23:51 +0000 (16:23 +0100)]
eot files: fixup all since tags

these tags have been wrong. eolian does not allow anything < 1.22

4 years agoeolian: fix all remaining since errors
Marcel Hollerbach [Wed, 5 Feb 2020 15:22:59 +0000 (16:22 +0100)]
eolian: fix all remaining since errors

eolian checked for since tags that are invalid by its own rules. This is
now fixed.

4 years agobindings: fix missing @since tags & docs
Marcel Hollerbach [Tue, 4 Feb 2020 15:15:59 +0000 (12:15 -0300)]
bindings: fix missing @since tags & docs

summary_: Depends on D11264

Reviewers: zmike, segfaultxavi, woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11265

4 years agoefl/gesture: remove unused manager function
Mike Blumenkrantz [Wed, 29 Jan 2020 19:08:32 +0000 (14:08 -0500)]
efl/gesture: remove unused manager function

no functional changes

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11244

4 years agoevas/object: remove weird gesture manager method
Mike Blumenkrantz [Wed, 29 Jan 2020 19:07:16 +0000 (14:07 -0500)]
evas/object: remove weird gesture manager method

these two objects have zero relation, and I don't know why this ever
existed

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11243

4 years agoefl/gesture: free object gesture list in destructor
Mike Blumenkrantz [Wed, 29 Jan 2020 18:32:53 +0000 (13:32 -0500)]
efl/gesture: free object gesture list in destructor

leak--

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11242

4 years agoefl/gesture: use array instead of list for garbage gesture objects
Mike Blumenkrantz [Wed, 29 Jan 2020 18:19:14 +0000 (13:19 -0500)]
efl/gesture: use array instead of list for garbage gesture objects

this is always a full iteration so we don't actually need a list

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11241

4 years agoefl/gesture: fix gesture object cleanup when unregistering a recognizer
Mike Blumenkrantz [Wed, 29 Jan 2020 18:09:36 +0000 (13:09 -0500)]
efl/gesture: fix gesture object cleanup when unregistering a recognizer

these objects need to be cleaned up immediately outside of event
processing to avoid having them automatically deleted later on and
triggering a double delete

Differential Revision: https://phab.enlightenment.org/D11240

4 years agotests/gesture: add second custom recognizer test
Mike Blumenkrantz [Wed, 29 Jan 2020 16:50:57 +0000 (11:50 -0500)]
tests/gesture: add second custom recognizer test

ensure that this functionality works

Differential Revision: https://phab.enlightenment.org/D11239

4 years agotests/elm: add explicit printf for event cb assert failure
Mike Blumenkrantz [Wed, 29 Jan 2020 16:07:23 +0000 (11:07 -0500)]
tests/elm: add explicit printf for event cb assert failure

efl explodes when this assert fails and presents bizarre errors which
obscure the actual test failure, so add a more explicit message as a
reminder to check this instead of trying to dive into insanity

Differential Revision: https://phab.enlightenment.org/D11238

4 years agotests/gesture: add custom recognizer test
Mike Blumenkrantz [Tue, 28 Jan 2020 19:23:27 +0000 (14:23 -0500)]
tests/gesture: add custom recognizer test

adds a very small implementation of a custom recognizer, registers it,
verifies events are processing as they should, then removes it

Differential Revision: https://phab.enlightenment.org/D11224

4 years agoefl/gesture: implement custom gesture recognizer framework
Mike Blumenkrantz [Tue, 28 Jan 2020 18:52:23 +0000 (13:52 -0500)]
efl/gesture: implement custom gesture recognizer framework

this adds support for creating custom (out of tree) gesture recognizers by
adding an abstract recognizer class that can be inherited and reused

docs TBA

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11223

4 years agoefl/gesture: break out gesture processing code into separate function
Mike Blumenkrantz [Tue, 28 Jan 2020 18:33:11 +0000 (13:33 -0500)]
efl/gesture: break out gesture processing code into separate function

this will get reused shortly

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11222

4 years agoefl/gesture: remove manager's recognizer_get method
Mike Blumenkrantz [Tue, 28 Jan 2020 17:56:41 +0000 (12:56 -0500)]
efl/gesture: remove manager's recognizer_get method

this exposes internal objects that we shouldn't be exposing

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11221

4 years agotests/gesture: change random momentum cb to be useful momentum cb
Mike Blumenkrantz [Tue, 28 Jan 2020 14:45:42 +0000 (09:45 -0500)]
tests/gesture: change random momentum cb to be useful momentum cb

verify that we get 1 event here and also that callback removal works

Differential Revision: https://phab.enlightenment.org/D11220

4 years agotests/gesture: add a 10-touch tap test
Mike Blumenkrantz [Mon, 27 Jan 2020 18:40:52 +0000 (13:40 -0500)]
tests/gesture: add a 10-touch tap test

this tests the robustness of existing gesture recognizers

Differential Revision: https://phab.enlightenment.org/D11209

4 years agoefl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer
Mike Blumenkrantz [Mon, 27 Jan 2020 18:40:02 +0000 (13:40 -0500)]
efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer

if we have not begun to process a zoom gesture by this point, then we should
not be emitting a cancel result

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11208

4 years agoefl/gesture: ignore successive press events in zoom recognizer when canceled
Mike Blumenkrantz [Mon, 27 Jan 2020 18:38:45 +0000 (13:38 -0500)]
efl/gesture: ignore successive press events in zoom recognizer when canceled

cancel is used to indicate that a gesture which has begun to trigger has been
canceled, so if we have already canceled then we should not re-cancel here

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11207

4 years agoefl/gesture: ignore multi-touch end events in tap gesture recognizer
Mike Blumenkrantz [Mon, 27 Jan 2020 18:37:25 +0000 (13:37 -0500)]
efl/gesture: ignore multi-touch end events in tap gesture recognizer

we only care about the last touch unpress event, so we should be ignoring
every other event instead of canceling, as we are also ignoring the
multi-touch press events

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11206

4 years agoefl/gesture: avoid direct double access in structs
Mike Blumenkrantz [Mon, 27 Jan 2020 14:27:41 +0000 (09:27 -0500)]
efl/gesture: avoid direct double access in structs

this is functionally wrong (the comparison fails) and also causes SIGBUS on
arm

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11198

4 years agoefl/gesture: reorder gesture private structs
Mike Blumenkrantz [Mon, 27 Jan 2020 14:27:05 +0000 (09:27 -0500)]
efl/gesture: reorder gesture private structs

order based on descending member size

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11197

4 years agoefl/gesture: remove 'gesture' member from recognizer data struct
Mike Blumenkrantz [Fri, 24 Jan 2020 19:12:46 +0000 (14:12 -0500)]
efl/gesture: remove 'gesture' member from recognizer data struct

this was never used

ref T8503

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11178

4 years agoefl/gesture: remove 'manager' member from recognizer data struct
Mike Blumenkrantz [Fri, 24 Jan 2020 19:11:01 +0000 (14:11 -0500)]
efl/gesture: remove 'manager' member from recognizer data struct

this can be fetched using efl_provider_find from the recognizer

ref T8503

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11177

4 years agoefl/gesture: remove 'config' property from recognizers
Mike Blumenkrantz [Fri, 24 Jan 2020 19:06:42 +0000 (14:06 -0500)]
efl/gesture: remove 'config' property from recognizers

this is a manager functionality, and recognizers are always child objects of
managers

ref T8503

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11176

4 years agoefl/gesture: expose 'continues' as a public property for recognizers
Mike Blumenkrantz [Fri, 24 Jan 2020 18:58:40 +0000 (13:58 -0500)]
efl/gesture: expose 'continues' as a public property for recognizers

we still access this using private data in the in-tree recognizers, but
now it's also accessible normally to custom recognizers

ref T8503

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11175

4 years agoefl/gesture: add an event to notify when a config value has been changed
Mike Blumenkrantz [Fri, 24 Jan 2020 18:38:49 +0000 (13:38 -0500)]
efl/gesture: add an event to notify when a config value has been changed

recognizers should be storing config values internally to avoid overhead
of multiple eo/hash lookups on every event

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11174

4 years agoefl/gesture: move finger_size into private structs of recognizers
Mike Blumenkrantz [Fri, 24 Jan 2020 18:34:45 +0000 (13:34 -0500)]
efl/gesture: move finger_size into private structs of recognizers

we must write these recognizers using publicly available apis to ensure
that we don't accidentally start using private struct data

this requires a lot of changes to properly manage the config value for finger
size and update the recognizer data when changed (which external recognizers
will need to monitor an event to achieve) and then also to change some
recognizers so they don't use memset and unset the finger_size value

ref TT8503

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11173

4 years agotests/gesture: add zoom and pinch tests
Mike Blumenkrantz [Thu, 23 Jan 2020 20:21:22 +0000 (15:21 -0500)]
tests/gesture: add zoom and pinch tests

basic tests verifying completion of the gestures

Differential Revision: https://phab.enlightenment.org/D11170

4 years agoefl/gesture: discard non-press events for all touch points if unseen previously
Mike Blumenkrantz [Thu, 23 Jan 2020 20:20:12 +0000 (15:20 -0500)]
efl/gesture: discard non-press events for all touch points if unseen previously

not sure why this was restricted to first touch point previously, but the logic
applies to all points as we don't want to be tracking input for a touch we
haven't gotten a down for

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11169

4 years agoefl/gesture: add 'pressed' state info for touch data
Mike Blumenkrantz [Thu, 23 Jan 2020 20:18:58 +0000 (15:18 -0500)]
efl/gesture: add 'pressed' state info for touch data

since we retain touch info for the duration of a touch sequence, including
after a touch point has been unpressed, it's necessary to track the current
state of each point and then use that to accurately determine the number of
touches active

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11168

4 years agoefl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch
Mike Blumenkrantz [Thu, 23 Jan 2020 20:18:09 +0000 (15:18 -0500)]
efl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch

canceling without a proper reset breaks the recognizer for successive events

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11167

4 years agotests/elm: add util function for doing pinch motions
Mike Blumenkrantz [Wed, 22 Jan 2020 18:56:07 +0000 (13:56 -0500)]
tests/elm: add util function for doing pinch motions

simple function which takes start points and vectors for 2 touches

Differential Revision: https://phab.enlightenment.org/D11166

4 years agoefl/gesture: more accurately handle flick/momentum recognition with multi-touch
Mike Blumenkrantz [Wed, 22 Jan 2020 18:51:44 +0000 (13:51 -0500)]
efl/gesture: more accurately handle flick/momentum recognition with multi-touch

if we have one of these gestures where we are flicking/momentuming with multiple
touch points, we want to permit this so long as the touch points are moving vaguely
in the same direction, e.g., press -> swipe with 2 fingers

with this, we now cancel these gestures with multi-touch active if we detect motion
with subsequent touch events that doesn't match the vector of the "active" press
for which we are monitoring events

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11165

4 years agoefl/gesture: break out _direction_get() into helper function
Mike Blumenkrantz [Wed, 22 Jan 2020 18:51:02 +0000 (13:51 -0500)]
efl/gesture: break out _direction_get() into helper function

this is useful in multiple places, no functional changes

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11164

4 years agoevas/events: fix multi-touch object targeting on touch down events
Mike Blumenkrantz [Wed, 22 Jan 2020 18:48:39 +0000 (13:48 -0500)]
evas/events: fix multi-touch object targeting on touch down events

a touch press is both a touch and a move event, which means the canvas must
update its list of target objects on the first touch press to avoid using the
wrong objects when processing events

@fix

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D11163

4 years agoefl/gesture: correct config value name for glayer_double_tap_timeout
Mike Blumenkrantz [Wed, 22 Jan 2020 14:57:15 +0000 (09:57 -0500)]
efl/gesture: correct config value name for glayer_double_tap_timeout

typo--

Reviewed-by: Hermet Park <<hermetpark@gmail.com>>
Differential Revision: https://phab.enlightenment.org/D11155

4 years agotests/gesture: add extra event callback to verify event multiplication is fixed
Mike Blumenkrantz [Tue, 21 Jan 2020 19:53:50 +0000 (14:53 -0500)]
tests/gesture: add extra event callback to verify event multiplication is fixed

Differential Revision: https://phab.enlightenment.org/D11145

4 years agoefl/gesture: redo (and make stupider) hash usage in gesture manager
Mike Blumenkrantz [Tue, 21 Jan 2020 19:51:16 +0000 (14:51 -0500)]
efl/gesture: redo (and make stupider) hash usage in gesture manager

this rewrites the gesture event dispatcher to use a hash of hashes for
tracking which events are being watched on a given object to avoid:
* dispatching n gesture events per object to each callback, where n is the
  number of gesture callbacks for any given type
* removing all gesture callbacks when only one callback is removed

this is not smart code. it should be improved at some time, but that time
is not now.

Differential Revision: https://phab.enlightenment.org/D11144

4 years agoefl/gesture: add touch_count property for gesture event info
Mike Blumenkrantz [Fri, 17 Jan 2020 15:18:23 +0000 (10:18 -0500)]
efl/gesture: add touch_count property for gesture event info

this allows us to provide the number of touch points active in any gesture
so we can detect e.g., double-tap with two fingers

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11126

4 years agotests/gesture: add gesture tests for basic multi-touch tap events
Mike Blumenkrantz [Mon, 13 Jan 2020 20:10:40 +0000 (15:10 -0500)]
tests/gesture: add gesture tests for basic multi-touch tap events

Differential Revision: https://phab.enlightenment.org/D11090

4 years agotests/elm: add util functions for doing multi-touch events
Mike Blumenkrantz [Mon, 13 Jan 2020 20:10:09 +0000 (15:10 -0500)]
tests/elm: add util functions for doing multi-touch events

Differential Revision: https://phab.enlightenment.org/D11089

4 years agoefl/gesture: fix zoom to ignore single press events and not crash
Mike Blumenkrantz [Mon, 13 Jan 2020 20:09:17 +0000 (15:09 -0500)]
efl/gesture: fix zoom to ignore single press events and not crash

zoom requires two fingers for a pinch, so skip the first press

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11088

4 years agoefl/gesture: restrict flick and momentum gestures to original touch point
Mike Blumenkrantz [Mon, 13 Jan 2020 20:08:16 +0000 (15:08 -0500)]
efl/gesture: restrict flick and momentum gestures to original touch point

if multiple fingers are pressed down, filter and use only the first finger
to make gesture recognizing more accurate

this may change later once tests develop

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11087

4 years agoefl/gesture: handle multi-touch press for tap gestures
Mike Blumenkrantz [Mon, 13 Jan 2020 20:07:17 +0000 (15:07 -0500)]
efl/gesture: handle multi-touch press for tap gestures

any time multiple fingers are pressed down at the same time, we should
treat this as a single gesture like if only one finger was pressed

Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11086

4 years agomove stabelized items out of @beta
Marcel Hollerbach [Fri, 31 Jan 2020 15:11:57 +0000 (16:11 +0100)]
move stabelized items out of @beta

fixes T8570
fixes T8567
fixes T8566
fixes T8521
fixes T8501
fixes T8460
fixes T8455
fixes T8454
fixes T8254
fixes T7945
fixes T7944
fixes T7943
fixes T7942
fixes T7941
fixes T7940
fixes T7939
fixes T7938
fixes T7937
fixes T7936
fixes T7935
fixes T7934
fixes T7933
fixes T7858
fixes T7857
fixes T7856
fixes T7855
fixes T8599

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11264

4 years agoefl_canvas_textblock: incorrect value returned for underline dashed gap
abdulleh Ghujeh [Tue, 4 Feb 2020 08:56:17 +0000 (08:56 +0000)]
efl_canvas_textblock: incorrect value returned for underline dashed gap

the function text_underline_dashed_gap_get return underline_dash_width value instead of underline_dash_gap value.
this patch return the correct value.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11277

4 years agosoftware_evas_engine: Remove unnecessary member for ector_surface_set
JunsuChoi [Wed, 5 Feb 2020 01:47:14 +0000 (10:47 +0900)]
software_evas_engine: Remove unnecessary member for ector_surface_set

Summary:
The clear of the Evas_Thread_Command_Ector_Surface structure is an unmanaged variable.
When ector calls _draw_thread_ector_surface_set and it checks the clear value.
the clear value is garbage value. This can cause the pixels to fail to initialize.
This is why afterimages remain after updating shapes while using ector surfaces.

Test Plan:
./build/src/examples/evas/efl-canvas-vg-simple
1 - Basic Shape test
Scale up 's' or do something

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11278

4 years agoefl.canvas.textblock: update style strings
Ali Alzyod [Tue, 4 Feb 2020 16:45:32 +0000 (17:45 +0100)]
efl.canvas.textblock: update style strings

Summary:
Update

backing -> background_type
backing_color -> background_color
underline_dash_color -> underline_dashed_color
underline - > underline_type
strikethrough - > strikethrough_type
style -> (effect_type + shadow_direction)
underline_dash_width -> underline_dashed_width
underline_dashed_gap -> underline_dashed_gap

**+prevent unified APIs from supporting legacy style tags, and prevent legacy APIs from the ability to use new unified tags**

Reviewers: zmike, woohyun, segfaultxavi, bu5hm4n, cedric

Reviewed By: segfaultxavi, bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8523

Differential Revision: https://phab.enlightenment.org/D11188

4 years agoefl.input.text: add underscore for enums names
ali [Tue, 4 Feb 2020 15:40:59 +0000 (16:40 +0100)]
efl.input.text: add underscore for enums names

Summary:
(Efl.Input_Text.Panel_Layout_Type) phonenumber -> phone_number
(Efl.Input_Text.Panel_Layout_Type) numberonly     ->number_only
(Efl.Input_Text.Capitalize_Type) allcharacter -> all
(Efl.Input_Text.Panel_Layout_Normal_Variation_Type) filename -> file_name
(Efl.Input_Text.Panel_Layout_Password_Variation_Type) numberonly-> number_only

Reviewers: segfaultxavi, woohyun, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8541

Differential Revision: https://phab.enlightenment.org/D11280

4 years agoefl_text_change_info: change text change type property( bool -> enum)
abdulleh Ghujeh [Mon, 3 Feb 2020 09:57:57 +0000 (09:57 +0000)]
efl_text_change_info: change text change type property( bool -> enum)

changed the insertion property to be an enum instead of a boolean property.
this will be clearer for usage and provide the ability to add more types in the future.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11272

4 years agocsharp: implement GetChildrenIndex for GenericModel
Yeongjong Lee [Tue, 4 Feb 2020 08:17:27 +0000 (17:17 +0900)]
csharp: implement GetChildrenIndex for GenericModel

Summary: This patch will fix EFL# build error.

Reviewers: felipealmeida, woohyun, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11269

4 years agoefl.ui.textbox: add and use keyboard bindings
Ali Alzyod [Sun, 2 Feb 2020 14:07:45 +0000 (14:07 +0000)]
efl.ui.textbox: add and use keyboard bindings

As other widgets, efl.ui.textbox will use keyboard bindings instead of listen to keyboard events

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11236

4 years agoelm_config: add helper method for copying widget key bindings
Marcel Hollerbach [Fri, 31 Jan 2020 13:55:56 +0000 (14:55 +0100)]
elm_config: add helper method for copying widget key bindings

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11262

4 years agoelm_config: fix wrong update code
Marcel Hollerbach [Fri, 31 Jan 2020 13:39:38 +0000 (14:39 +0100)]
elm_config: fix wrong update code

the version here was wrong, probebly a missmatch between hex. & dec and
a off by one error. This is fixing that problem and does not just copy
all keybindings.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11261

4 years agoevas proxy: make it work for File_Save.save
Shinwoo Kim [Tue, 4 Feb 2020 03:06:37 +0000 (12:06 +0900)]
evas proxy: make it work for File_Save.save

Summary:
File_Save.save does not work for proxy object from following commit.

   c53f152 evas: Make save() work on snapshots

Test Plan:
1. Add an image object and set source object.
evas_object_image_source_set(obj, source);

2. Save the object as a file when you need.
evas_object_image_save(obj, "./file_name.png", NULL, NULL);

Reviewers: cedric, Hermet, jsuya

Reviewed By: Hermet

Subscribers: zmike, subodh6129, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10629

4 years agocanvas proxy: fix broken proxy source clip set behavior. 69/224569/1
Hermet Park [Tue, 11 Feb 2020 12:44:52 +0000 (21:44 +0900)]
canvas proxy: fix broken proxy source clip set behavior.

Some internal logic has been wrongly changed while it's on refactoring.

Fixed by reverting it.

Change-Id: Iefa0455633cb45dba8f3b9b6f36065c3a54f5da8

4 years agoRevert "ecore_wl2: API classification for make it public."
Woochanlee [Tue, 11 Feb 2020 07:23:16 +0000 (16:23 +0900)]
Revert "ecore_wl2: API classification for make it public."

This reverts commit 13e3f766296a65be36f13dbda40f9a5cbec90e0f.

4 years agoRevert "ecore_wl2: Move Wayland header into Ecore_Wl2 header for test."
Woochanlee [Tue, 11 Feb 2020 07:23:06 +0000 (16:23 +0900)]
Revert "ecore_wl2: Move Wayland header into Ecore_Wl2 header for test."

This reverts commit a44f333c1a909c0a74bb12e443e3595f5948f776.

4 years agoRevert "ecore_wl2: Creates internal header for legacy user."
Woochanlee [Tue, 11 Feb 2020 07:22:52 +0000 (16:22 +0900)]
Revert "ecore_wl2: Creates internal header for legacy user."

This reverts commit a2f96e0795e2c20bfcc2901cd070db15ce31f7c7.

4 years agoecore_wl2: Creates internal header for legacy user. 16/224516/1 submit/tizen/20200211.071840
Woochanlee [Tue, 11 Feb 2020 07:17:07 +0000 (16:17 +0900)]
ecore_wl2: Creates internal header for legacy user.

Change-Id: I005cc709d24cf877b24a8e919434e928624996c3

4 years agoecore_wl2: Move Wayland header into Ecore_Wl2 header for test. 14/224514/1 submit/tizen/20200211.070535
Woochanlee [Tue, 11 Feb 2020 07:02:27 +0000 (16:02 +0900)]
ecore_wl2: Move Wayland header into Ecore_Wl2 header for test.

Change-Id: I1271e0c787dd3b50f312d58cba767739f26a0976

4 years agoecore_wl2: API classification for make it public. 04/224504/1 submit/tizen/20200211.063445
Woochanlee [Tue, 11 Feb 2020 06:31:21 +0000 (15:31 +0900)]
ecore_wl2: API classification for make it public.

Change-Id: Id976bbd57ae1d743d3248c79e996866d2846c56b

4 years agoefl_ui_widget: set comment to unreacable code 93/224493/2
WooHyun Jung [Tue, 11 Feb 2020 04:01:25 +0000 (13:01 +0900)]
efl_ui_widget: set comment to unreacable code

@tizen_fix

Change-Id: I948cada6fdff489a795d90ce27c2a04d61070620

4 years agoelm_focus_legacy: set comment to unreachable code 85/224485/1
WooHyun Jung [Tue, 11 Feb 2020 02:11:42 +0000 (11:11 +0900)]
elm_focus_legacy: set comment to unreachable code

@tizen_fix

Change-Id: I3082d86fac12794c686ff9e0dd1c69056246c39d

4 years agoevas object: + null check for safety 41/224441/1
Hermet Park [Mon, 10 Feb 2020 12:23:20 +0000 (21:23 +0900)]
evas object: + null check for safety

Change-Id: I7633a4668ed84ee8b4d51544906163f4b8286e0c