Not Zed [Wed, 3 Sep 2003 18:05:54 +0000 (18:05 +0000)]
** See bug #47765.
2003-08-20 Not Zed <NotZed@Ximian.com>
** See bug #47765.
* camel-folder-search.h: Removed match1 member.
* camel-folder-search.c (camel_folder_search_match_expression):
use current directly rather than match1. This method isn't used
anywhere anyway.
(search_not): remove match1 stuff.
(search_match_all): properly handle the match-all against 1
message as a scalar result, not an array result.
2003-09-03 Not Zed <NotZed@Ximian.com>
* camel-http-stream.c (camel_http_stream_set_proxy): handle NULL
proxy_url - unset the proxy.
Not Zed [Sat, 30 Aug 2003 01:04:38 +0000 (01:04 +0000)]
removed debug printfs.
2003-08-29 Not Zed <NotZed@Ximian.com>
* camel-object.c (camel_object_state_write):
(cobject_getv):
(cobject_setv, cobject_state_read, cobject_state_read)
(cobject_state_write): removed debug printfs.
Not Zed [Sat, 30 Aug 2003 00:54:16 +0000 (00:54 +0000)]
Need to copy the local properties list before passing it out, since it's
2003-08-29 Not Zed <NotZed@Ximian.com>
* providers/local/camel-local-folder.c (local_getv): Need to copy
the local properties list before passing it out, since it's freed.
Not Zed [Wed, 27 Aug 2003 19:50:25 +0000 (19:50 +0000)]
implement PERSISTENT_PROPERTIES, for index mode.
2003-08-27 Not Zed <NotZed@Ximian.com>
* providers/local/camel-local-folder.c (local_getv): implement
PERSISTENT_PROPERTIES, for index mode.
* camel-object.c (cobject_state_read): Also add property reading,
and bump version to 1.
(cobject_state_write): add persistent property writing.
2003-08-26 Not Zed <NotZed@Ximian.com>
* camel-folder.c (folder_getv): chain up properly.
* camel-file-utils.c (camel_file_util_savename): helper to create
a .#filename filename.
* providers/local/camel-local-folder.c
(camel_local_folder_construct): init meta-data for local folders.
(local_getv): chain up properly, if args are not processed, rather
than don't if they aren't.
2003-08-23 Not Zed <NotZed@Ximian.com>
* camel-object.c (cobject_class_init): added a new event,
meta_changed.
(camel_object_meta_set, camel_object_meta_get): meta-data api.
(camel_object_free_hooks): Free meta-data if it is set on the
object.
* providers/local/camel-local-folder.c
(camel_local_folder_get_type): setup a property list for local
folders, just 'index_body' at present.
Jeffrey Stedfast [Tue, 26 Aug 2003 18:16:51 +0000 (18:16 +0000)]
temporarily reverting my camel namespace patches until after we merge in some of the other branches
Jeffrey Stedfast [Tue, 26 Aug 2003 17:52:59 +0000 (17:52 +0000)]
reverted some namespacing changes to internal functions
Jeffrey Stedfast [Tue, 26 Aug 2003 16:06:03 +0000 (16:06 +0000)]
s/HSCAN_/CAMEL_MIME_PARSER_STATE_/g and
2003-08-26 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-parser.[c,h]: s/HSCAN_/CAMEL_MIME_PARSER_STATE_/g and
s/_header_state/_camel_mime_parser_state/g
* camel-filter-driver.c: Same.
* camel-folder-summary.c: Here too.
* camel-http-stream.c: And here.
* camel-mime-message.c: ...
* camel-mime-part-utils.c: ...
* camel-mime-part.c: ...
* camel-movemail.c: ...
* camel-multipart-signed.c: ...
* camel-multipart.c: ...
* providers/local/camel-mbox-folder.c: ...
* providers/local/camel-mbox-summary.c: ...
* providers/local/camel-mh-summary.c: ...
* providers/nntp/camel-nntp-summary.c: ...
* providers/pop3/camel-pop3-folder.c: ...
Jeffrey Stedfast [Mon, 25 Aug 2003 21:01:55 +0000 (21:01 +0000)]
Namespaced.
2003-08-25 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-utils.[c,h]: Namespaced.
* camel-data-wrapper.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-digest-folder.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-filter-driver.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-filter-search.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-folder-search.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-folder-summary.[c,h]: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-http-stream.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-http-stream.h: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-internet-address.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-medium.[c,h]: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-mime-message.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-mime-parser.[c,h]: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-mime-part-utils.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-mime-part.[c,h]: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-movemail.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-multipart-encrypted.c: updated for namespace changed made
to camel-mime-utils.[c,h]
* camel-multipart-signed.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-multipart.c: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-search-private.[c,h]: updated for namespace changed made to
camel-mime-utils.[c,h]
* camel-types.h: updated for namespace changed made to
camel-mime-utils.[c,h]
* providers/imap/camel-imap-folder.c: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/imap/camel-imap-store-summary.c: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/imap/camel-imap-utils.c: updated for namespace changed
made to camel-mime-utils.[c,h]
* providers/imapp/camel-imapp-utils.[c,h]: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/local/camel-local-summary.[c,h]: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/local/camel-maildir-summary.c: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/local/camel-mbox-summary.c: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/local/camel-spool-summary.h: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/nntp/camel-nntp-summary.c: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/nntp/camel-nntp-utils.c: updated for namespace changed
made to camel-mime-utils.[c,h]
* providers/pop3/camel-pop3-folder.c: updated for namespace
changed made to camel-mime-utils.[c,h]
* providers/sendmail/camel-sendmail-transport.c: updated for
namespace changed made to camel-mime-utils.[c,h]
* providers/smtp/camel-smtp-transport.c: updated for namespace
changed made to camel-mime-utils.[c,h]
Jeffrey Stedfast [Mon, 25 Aug 2003 15:09:34 +0000 (15:09 +0000)]
Added some more error checking for reading/writing to the pipes. Fixes bug
2003-08-25 Jeffrey Stedfast <fejj@ximian.com>
* camel-filter-driver.c (pipe_to_system): Added some more error
checking for reading/writing to the pipes. Fixes bug #47880.
`
Jeffrey Stedfast [Thu, 21 Aug 2003 16:20:14 +0000 (16:20 +0000)]
Don't poke wrapper->stream directly, use
2003-08-21 Jeffrey Stedfast <fejj@ximian.com>
* camel-data-wrapper.c (decode_to_stream): Don't poke
wrapper->stream directly, use camel_data_wrapper_write_to_stream()
instead as this simplifies things and makes the imap data wrapper
implementation Just Work (tm).
* providers/imap/camel-imap-wrapper.c: changed prototype of
write_to_stream() to return ssize_t.
Jeffrey Stedfast [Wed, 20 Aug 2003 17:39:37 +0000 (17:39 +0000)]
Make sure to ref the stream. Fixes bug #47749.
2003-08-20 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-wrapper.c (imap_wrapper_hydrate): Make
sure to ref the stream. Fixes bug #47749.
Jeffrey Stedfast [Tue, 19 Aug 2003 15:44:33 +0000 (15:44 +0000)]
return 77 when gpg isn't available rather than 127
also fixed to import the keys from the correct location
Not Zed [Tue, 19 Aug 2003 02:36:31 +0000 (02:36 +0000)]
Various fixes to make it work.
2003-08-18 Not Zed <NotZed@Ximian.com>
* camel-http-stream.c: Various fixes to make it work.
* tests/smime/pgp-mime.c (main): added missing 'ret' variable.
* providers/smtp/camel-smtp-transport.c (connect_to_server):
* providers/imapp/camel-imapp-store.c (connect_to_server:
* providers/imap/camel-imap-store.c (connect_to_server):
* providers/pop3/camel-pop3-store.c (connect_to_server):
* camel-http-stream.c (http_connect): change service->session for
tcp_stream_ssl_new.
* camel-tcp-stream-ssl.c: Changed service to session, and fix some
refcounting of it.
include camel-operation.h
Not Zed [Fri, 15 Aug 2003 20:57:30 +0000 (20:57 +0000)]
** See bug #47634.
2003-08-15 Not Zed <NotZed@Ximian.com>
** See bug #47634.
* tests/lib/messages.c (test_message_compare): check
write_to_stream returns.
(message_dump_rec): helper to dump message structure.
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): dont set content
encoding here.
(camel_mime_part_construct_content_from_parser): set it here
instead, on every part. basically same as setting the
mime_type_field always.
* camel-multipart-signed.c (camel_multipart_signed_class_init):
* camel-mime-message.c (camel_mime_message_class_init):
* camel-multipart.c (camel_multipart_class_init): override
decode_to_stream to always do the same as write_to_stream, since
we can never be encoded.
Jeffrey Stedfast [Fri, 15 Aug 2003 18:27:55 +0000 (18:27 +0000)]
Don't attach any filters to decode base64/qp/etc.
2003-08-15 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-wrapper.c (imap_wrapper_hydrate):
Don't attach any filters to decode base64/qp/etc.
Jeffrey Stedfast [Thu, 14 Aug 2003 04:35:22 +0000 (04:35 +0000)]
Save errno when flushing/unreffing the filter stream.
2003-08-14 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-part.c (write_to_stream): Save errno when
flushing/unreffing the filter stream.
Jeffrey Stedfast [Wed, 13 Aug 2003 16:41:18 +0000 (16:41 +0000)]
If the content is base64/qp/uu/etc encoded but the part is 7bit/8bit/(or
2003-08-13 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-part.c (write_to_stream): If the content is
base64/qp/uu/etc encoded but the part is 7bit/8bit/(or otherwise
non-encoded), set reencode to TRUE so that we decode the original
content stream. Fixes a bug noticed on
evolution-patches@ximian.com where a patch had a
Content-Transfer-Encoding of 7bit but was base64 encoded.
Not Zed [Wed, 13 Aug 2003 16:40:12 +0000 (16:40 +0000)]
Fix the range check, we were stopping removal of 1 or 2 removals, for some
2003-08-13 Not Zed <NotZed@Ximian.com>
* camel-folder-summary.c (camel_folder_summary_remove_range): Fix
the range check, we were stopping removal of 1 or 2 removals, for
some odd and completely uncomprehensible reason. Perhaps debug
left in?
2003-08-13 Not Zed <NotZed@Ximian.com>
** See bug #47517.
* camel-vee-folder.c (vee_sync): Always rebuild folder on any
sync, not just expunge ones.
Not Zed [Mon, 11 Aug 2003 20:41:33 +0000 (20:41 +0000)]
force connect manually so basics work.
2003-08-11 Not Zed <NotZed@Ximian.com>
* providers/imapp/camel-imapp-store.c (imap_get_folder_info):
force connect manually so basics work.
** See bug #45505.
* camel-service.c (camel_gethostbyname): duh, pthread_create
returns the error code directly, not via errno.
(camel_gethostbyaddr): Same, also properly handle the failure
case.
2003-08-01 Not Zed <NotZed@Ximian.com>
** See bug #47208.
* camel-filter-search.c (match_all): match-all with no arguments
should always return TRUE.
* camel-folder-search.c (camel_folder_search_execute_expression):
print a warning when we get an invalid result type & fixed a leak
for that case.
Jeffrey Stedfast [Mon, 11 Aug 2003 20:18:16 +0000 (20:18 +0000)]
updated mime-tests README
Jeffrey Stedfast [Mon, 11 Aug 2003 17:57:45 +0000 (17:57 +0000)]
New test suite for the mime parser (which is where the below 2 fixes were
* tests/message/test4.c: New test suite for the mime parser (which
is where the below 2 fixes were noticed).
* camel-mime-parser.c (folder_boundary_check): Calculate 'len' by
subtracting the boundary start from inend rather than 'atleast'.
(folder_scan_content): Calculate 'inend' differently depending on
the EOF state.
2003-08-08 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-filter-tohtml.c (html_convert): Rather than checking
*inptr == '\n', check inptr >= inend - this gets rid of an Invalid
Read report from valgrind.
* camel-mime-part.c (write_to_stream): Don't necessarily re-encode
just because the encodings differ. Need to look into making it so
that message/rfc822 and multipart parts ignore the
Content-Transfer-Encoding header and just keep their 'encoding'
bits set to DEFAULT.
2003-08-05 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-folder.c (get_content): Updated.
* camel-mime-message.c (camel_mime_message_init): Don't override
the mime_type here.
(process_header): Updated to use CamelDataWrapper's mime_type
field.
(find_best_encoding): Same.
(best_encoding): Here too.
* camel-digest-folder.c (camel_digest_folder_new): Updated for
CamelMimePart::content_type change.
* camel-mime-part.c (camel_mime_part_init): Override our parent
class's default mime_type.
(camel_mime_part_finalize): Don't need to unref the content_type
anymore.
(process_header): Updated to use CamelDataWrapper's mime_type
field.
(camel_mime_part_set_filename): Same.
(camel_mime_part_get_filename): Same.
(camel_mime_part_get_content_type): Same.
(set_content_object): Here too.
(write_to_stream): Updated.
(construct_from_parser): Updated.
* camel-mime-part.h: Remove the content_type field.
2003-07-31 Jeffrey Stedfast <fejj@ximian.com>
* tests/lib/messages.c (test_message_compare_content): If the
chunks differ, perform a hexdump on the data being compared so
that we may analyse it easier.
* camel-multipart-signed.c (write_to_stream): Return ssize_t.
* camel-mime-utils.h: Added the CamelMimePartEncodingType enum
here.
* camel-mime-part.h: Removed the CamelMimePartEncodingType enum
from here.
* camel-mime-part.c (write_to_stream): Updated to return
ssize_t. Also minor changes to only re-encode the content stream
if the charset or encoding changed (this way we write it out in
the original raw form if nothing changed).
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): Drastically
simplify. We no longer scan html content to try and find the
charset, nor do we care about converting the content to UTF-8 and
handling broken windows charsets.
* camel-mime-message.c (find_best_encoding): Use
decode_to_stream() here. Also updated to not assume the content
charset is UTF-8 since it is very likely not the case anymore
since data-wrappers no longer are converted to UTF-8 at parse
time.
* camel-folder-summary.c (summary_build_content_info_message): Use
decode_to_stream instead here too.
* camel-folder-search.c (match_words_1message): Use
decode_to_stream instead of write_to_stream so we can search the
contents.
* camel-data-wrapper.c (camel_data_wrapper_init): Set the default
encoding to DEFAULT.
(write_to_stream): Updated to return ssize_t
(camel_data_wrapper_decode_to_stream): New virtual function to
decode a data wrapper to a stream (results in nearly identical
behaviour to the old write_to_stream method).
(decode_to_stream): Default implementation of above virtual
method. Decodes base64/qp/etc streams.
* camel-data-wrapper.h: Removed the rawtext bit and added an
encoding member.
Michael Zucci [Fri, 1 Aug 2003 21:08:03 +0000 (21:08 +0000)]
add optional imapp compile
Michael Zucci [Fri, 1 Aug 2003 21:07:43 +0000 (21:07 +0000)]
experimental, non-working imap implementation
Jeffrey Stedfast [Fri, 1 Aug 2003 19:31:31 +0000 (19:31 +0000)]
oops, s/gpgfoo/gpg/
Jeffrey Stedfast [Fri, 1 Aug 2003 19:30:50 +0000 (19:30 +0000)]
updated
Jeffrey Stedfast [Fri, 1 Aug 2003 19:13:20 +0000 (19:13 +0000)]
Same.
2003-08-01 Jeffrey Stedfast <fejj@ximian.com>
* tests/smime/pgp-mime.c: Same.
* tests/smime/pgp.c: Updated to build and to import some custom
gpg keys for use with testing.
Jeffrey Stedfast [Wed, 30 Jul 2003 17:26:30 +0000 (17:26 +0000)]
oops, this too
Jeffrey Stedfast [Wed, 30 Jul 2003 17:25:01 +0000 (17:25 +0000)]
Also updated.
2003-07-30 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-message.c (write_to_stream): Also updated.
* camel-data-wrapper.c (write_to_stream): This should return ssize_t
* camel-multipart-signed.c (write_to_stream): Updated.
* camel-multipart.c (write_to_stream): Same.
* camel-mime-part.c (write_to_stream): Here too.
Suresh Chandrasekharan [Tue, 29 Jul 2003 13:52:43 +0000 (13:52 +0000)]
Fix for #46168 'some additional locale aliases required for chinese
2003-07-11 Suresh Chandrasekharan <suresh.chandrasekharan@sun.com>
* camel-iconv.c: Fix for #46168 'some additional locale aliases
required for chinese support'.
2003-07-25 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-utils.c (header_decode_word): Revert NotZed's fix for
bug #42170 - this causes even more problems than it solves. See
bug #46331 for info. Basically, each address header would be
converted to UTF-8 twice which means no raw 8bit address header
would render correctly.
(header_decode_mailbox): Perform a sanity check on the resultant
addr->str to make sure that it is valid UTF-8, if not convert it
to UTF-8. Fixes bug #42170.
Jeffrey Stedfast [Wed, 23 Jul 2003 17:21:57 +0000 (17:21 +0000)]
Revert my previous changes to this function.
2003-07-23 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-message.c (find_best_encoding): Revert my previous
changes to this function.
* camel-mime-utils.h: Revert previous changes.
* camel-mime-part.h: Revert previous changes.
* camel-mime-part-utils.c: Revert previous changes.
* camel-data-wrapper.c (camel_data_wrapper_init): Revert previous
changes.
(write_to_stream): Revert previous changes.
Dan Winship [Wed, 23 Jul 2003 14:57:22 +0000 (14:57 +0000)]
#include camel-file-utils.h for camel_read()
* camel-block-file.c: #include camel-file-utils.h for camel_read()
* camel-uid-cache.c (camel_uid_cache_save): Remove unused variable
and label.
* camel-url.c: #include camel-string-utils.h for camel_strdown
* providers/pop3/camel-pop3-store.c (pop3_try_authenticate): Cast
an (unsigned char *) to (char *) to fix a warning
Jeffrey Stedfast [Thu, 17 Jul 2003 20:12:12 +0000 (20:12 +0000)]
Updated to convert to/from the correct charset (since content is no longer
2003-07-17 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-message.c (find_best_encoding): Updated to convert
to/from the correct charset (since content is no longer
necessarily in UTF-8).
(best_encoding): Free the charset string when we're done with it.
Jeffrey Stedfast [Thu, 17 Jul 2003 19:17:42 +0000 (19:17 +0000)]
Increment the seekable stream position by the number of bytes read. Oops.
2003-07-17 Jeffrey Stedfast <fejj@ximian.com>
* camel-stream-fs.c (stream_read): Increment the seekable stream
position by the number of bytes read. Oops.
(stream_write): Same here.
Jeffrey Stedfast [Thu, 17 Jul 2003 19:14:51 +0000 (19:14 +0000)]
Increment the seekable stream position by the number of bytes read. Oops.
2003-07-17 Jeffrey Stedfast <fejj@ximian.com>
* camel-stream-fs.c (stream_read): Increment the seekable stream
position by the number of bytes read. Oops.
Timo Sirainen [Thu, 17 Jul 2003 06:31:35 +0000 (06:31 +0000)]
** See bug #42573
2003-07-17 Timo Sirainen <tss@iki.fi>
** See bug #42573
* providers/imap/camel-imap-folder.c (do_append): Only free the
response after we have finished the literal request, otherwise we
could try processing folder updates incorrectly.
Jeffrey Stedfast [Wed, 16 Jul 2003 20:45:26 +0000 (20:45 +0000)]
Add the CamelMimePartEncodingType definition here.
2003-07-14 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-utils.h: Add the CamelMimePartEncodingType definition
here.
* camel-mime-part.h: Remove the CamelMimePartEncodingType
definition.
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): Don't do any of the
auto-detection we used to do here anymore. Just read the content
into a memory buffer and record the encoding type.
(camel_mime_part_construct_content_from_parser): Don't mangle the
Content-Type struct here anymore.
* camel-data-wrapper.c (camel_data_wrapper_init): Init encoding to
DEFAULT.
(write_to_stream): If the stream needs to be decoded, decode it.
Jeffrey Stedfast [Wed, 16 Jul 2003 02:32:30 +0000 (02:32 +0000)]
If we read 0 bytes, then set eos to TRUE.
2003-07-15 Jeffrey Stedfast <fejj@ximian.com>
* camel-stream-fs.c (stream_read): If we read 0 bytes, then set
eos to TRUE.
Jeffrey Stedfast [Wed, 9 Jul 2003 20:10:31 +0000 (20:10 +0000)]
removed camel-pkcs7-context.[c,h] - no longer useful
Jeffrey Stedfast [Wed, 9 Jul 2003 20:07:38 +0000 (20:07 +0000)]
removed camel-smime-utils.[c,h] which are no longer useful
Jeffrey Stedfast [Wed, 9 Jul 2003 19:34:15 +0000 (19:34 +0000)]
removed #ifndef ENABLE_THREADS
Jeffrey Stedfast [Wed, 9 Jul 2003 19:32:43 +0000 (19:32 +0000)]
removed #ifdef ENABLE_THREADS
Jeffrey Stedfast [Wed, 9 Jul 2003 19:21:59 +0000 (19:21 +0000)]
Get rid of the #ifdef ENABLE_THREADS since we no longer plan to
2003-07-09 Jeffrey Stedfast <fejj@ximian.com>
Get rid of the #ifdef ENABLE_THREADS since
we no longer plan to support/maintain this.
* providers/nntp/camel-nntp-store.c: Here.
* providers/nntp/camel-nntp-newsrc.c: And here.
* providers/nntp/camel-nntp-folder.c: Same.
* providers/local/camel-local-folder.c: And here.
Jeffrey Stedfast [Wed, 9 Jul 2003 19:05:13 +0000 (19:05 +0000)]
Get rid of the #ifdef ENABLE_THREADS since we no longer plan to
2003-07-09 Jeffrey Stedfast <fejj@ximian.com>
* camel-block-file.c: Get rid of the #ifdef ENABLE_THREADS since
we no longer plan to support/maintain this.
* camel.c: Same.
* camel-certdb.c: Here too.
* camel-charset-map.c: And here.
* camel-cipher-context.c: "
* camel-data-wrapper.c: "
* camel-digest-folder.c: "
* camel-exception.c: "
* camel-folder.c: "
* camel-folder-summary.c: "
* camel-lock-client.c: "
* camel-mime-utils.c: "
* camel-object.c: "
* camel-operation.c: "
* camel-partition-table.c: "
* camel-sasl-popb4smtp.c: "
* camel-service.c: "
* camel-session.c: "
* camel-store.c: "
* camel-store-summary.c: "
* camel-text-index.c: "
* camel-transport.c: "
* camel-vee-folder.c: "
* camel-tcp-stream-openssl.c: Removed pthread.h, it isn't needed.
Larry Ewing [Wed, 9 Jul 2003 12:49:59 +0000 (12:49 +0000)]
remove reference to camel-pgp-mime.h
2003-07-09 Larry Ewing <lewing@ximian.com>
* camel.h: remove reference to camel-pgp-mime.h
Jeffrey Stedfast [Tue, 8 Jul 2003 19:29:58 +0000 (19:29 +0000)]
Removed.
2003-07-08 Jeffrey Stedfast <fejj@ximian.com>
* camel-pgp-mime.[c,h]: Removed.
Jeffrey Stedfast [Tue, 8 Jul 2003 18:36:40 +0000 (18:36 +0000)]
Updated (new copy/paste from e-iconv).
2003-07-08 Jeffrey Stedfast <fejj@ximian.com>
* camel-iconv.c: Updated (new copy/paste from e-iconv).
* camel-block-file.c (camel_block_file_get_block): Use
camel_read() rather than libc read.
* camel-tcp-stream-raw.c (stream_read): Use camel_read().
(stream_write): Use camel_write().
* camel-stream-fs.c (stream_read): Use camel_read().
(stream_write): Use camel_write().
Jeffrey Stedfast [Tue, 8 Jul 2003 17:48:32 +0000 (17:48 +0000)]
Use camel_read(). (stream_write): Use camel_write().
2003-07-08 Jeffrey Stedfast <fejj@ximian.com>
* camel-tcp-stream-raw.c (stream_read): Use camel_read().
(stream_write): Use camel_write().
* camel-stream-fs.c (stream_read): Use camel_read().
(stream_write): Use camel_write().
Jeffrey Stedfast [Mon, 7 Jul 2003 20:58:24 +0000 (20:58 +0000)]
Use camel_mkdir().
2003-07-07 Jeffrey Stedfast <fejj@ximian.com>
* providers/nntp/camel-nntp-folder.c (camel_nntp_folder_new): Use
camel_mkdir().
* providers/imap/camel-imap-folder.c (camel_imap_folder_new): Use
camel_mkdir().
* camel-session.c (get_storage_path): Use camel_mkdir().
* camel-store.c (camel_mkdir_hier): Removed.
* camel-data-cache.c (camel_data_cache_new): Updated to use
camel_mkdir().
(data_cache_path): Same.
* camel-file-utils.c (camel_mkdir): Renamed and documented.
(camel_file_util_safe_filename): Documented.
(camel_read): Moved here from camel-io.c
(camel_write): Same.
* camel-io.[c,h]: Removed.
* camel-uid-cache.c (camel_uid_cache_new): Use the
camel-file-utils.c version of mkdir.
Jeffrey Stedfast [Mon, 7 Jul 2003 19:20:25 +0000 (19:20 +0000)]
removed debug printfs
Jeffrey Stedfast [Mon, 7 Jul 2003 19:18:57 +0000 (19:18 +0000)]
Updated for string-utils namespace changes.
2003-07-07 Jeffrey Stedfast <fejj@ximian.com>
* camel-session.c (camel_session_init): Updated for string-utils
namespace changes.
* camel-provider.c: Updated for string-utils namespace changes.
* camel-mime-part.c (init_header_name_table): Updated for
string-utils namespace changes.
* camel-mime-message.c (camel_mime_message_class_init): Updated
for string-utils namespace changes.
(camel_mime_message_init): Same.
* camel-mime-filter-enriched.c
(camel_mime_filter_enriched_class_init): Updated for string-utils
namespace changes.
* camel-folder-summary.c (camel_folder_summary_init): Updated for
string-utils namespace changes.
* camel-string-utils.[c,h]: Renamed from string-utils.[c,h] and
also namespaced all functions.
Jeffrey Stedfast [Wed, 2 Jul 2003 23:43:12 +0000 (23:43 +0000)]
Don't quote the charset value, the qop value, nor the response value.
2003-07-01 Jeffrey Stedfast <fejj@ximian.com>
* camel-sasl-digest-md5.c (digest_response): Don't quote the
charset value, the qop value, nor the response value. Fixes bug
#45712.
Jeffrey Stedfast [Wed, 2 Jul 2003 16:47:29 +0000 (16:47 +0000)]
Use gmtime_r() instead of using gmtime() and memcpy() to try and be
2003-07-01 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-utils.c (header_format_date): Use gmtime_r() instead
of using gmtime() and memcpy() to try and be "atomic".
Dan Winship [Tue, 1 Jul 2003 18:47:04 +0000 (18:47 +0000)]
free the summary hash
* camel-folder-search.c (camel_folder_search_finalize): free the
summary hash
David Woodhouse [Tue, 1 Jul 2003 18:10:17 +0000 (18:10 +0000)]
Put day of week into outgoing email.
2003-06-24 David Woodhouse <dwmw2@infradead.org>
* camel-mime-utils.c (header_format_date): Put day of week into
outgoing email.
Jeffrey Stedfast [Wed, 25 Jun 2003 15:43:46 +0000 (15:43 +0000)]
Added prototype for camel_folder_summary_remove_range().
2003-06-25 Jeffrey Stedfast <fejj@ximian.com>
* camel-folder-summary.h: Added prototype for
camel_folder_summary_remove_range().
2003-06-25 Not Zed <NotZed@Ximian.com>
** See bug #45386
* camel-service.c (camel_gethostbyname, camel_gethostbyaddr): Make
sure we have an exception that we test against.
Not Zed [Wed, 25 Jun 2003 10:20:09 +0000 (10:20 +0000)]
** See bug #43887
2003-06-20 Not Zed <NotZed@Ximian.com>
** See bug #43887
* camel-mime-filter-enriched.c (camel_enriched_to_html): simple
wrapper to convert enriched to html in one go.
Not Zed [Fri, 20 Jun 2003 05:04:58 +0000 (05:04 +0000)]
** See bug #31745
2003-06-16 Not Zed <NotZed@Ximian.com>
** See bug #31745
* providers/imap/camel-imap-store-summary.c
(camel_imap_store_summary_namespace_new): Workaround a shell bug -
if the namespace has '#' in it, then strip it.
Not Zed [Fri, 20 Jun 2003 03:53:35 +0000 (03:53 +0000)]
if we got cancelled, the message is floating, so free it. (struct
2003-06-18 Not Zed <NotZed@Ximian.com>
* camel-service.c (get_hostbyaddr, get_hostbyname): if we got
cancelled, the message is floating, so free it.
(struct _lookup_msg): Add a cancelled tag.
(camel_gethostbyname, camel_gethostbyaddr): if we get a
failure/cancel, cancel the lookup thread and detach, so we dont
have to wait for it to return. cleanup changed to handle the case
where we didn't get a reply message.
Jeffrey Stedfast [Wed, 18 Jun 2003 17:55:40 +0000 (17:55 +0000)]
Made static (to match the prototype).
2003-06-13 Jeffrey Stedfast <fejj@ximian.com>
* providers/pop3/camel-pop3-folder.c (pop3_finalize): Made static
(to match the prototype).
Larry Ewing [Wed, 18 Jun 2003 15:13:12 +0000 (15:13 +0000)]
don't leak the summary when reloading it. Fixes a very large leak.
2003-06-13 Larry Ewing <lewing@ximian.com>
* camel-folder-thread.c (camel_folder_thread_messages_apply):
don't leak the summary when reloading it. Fixes a very large
leak.
Not Zed [Wed, 18 Jun 2003 06:14:09 +0000 (06:14 +0000)]
Calculate ranges to remove folder info's more efficiently. affects
2003-06-17 Not Zed <NotZed@Ximian.com>
* camel-vee-folder.c (vee_folder_remove_folder): Calculate ranges
to remove folder info's more efficiently. affects shutdown
performance on big vfolders signifinantly.
(vee_folder_build_folder): do the same here, when rebuilding a
folder's definition.
* camel-folder-summary.c (camel_folder_summary_remove_index): new
function to drop a range of index entries in one hit.
Not Zed [Tue, 17 Jun 2003 03:20:59 +0000 (03:20 +0000)]
** See bug #44322
2003-06-16 Not Zed <NotZed@Ximian.com>
** See bug #44322
* providers/imap/camel-imap-command.c (imap_command_strdup_vprintf):
If we are outputting a folder name, make sure we calculate buffer
size based on the raw/utf7 version
** See bug #44121
* camel-multipart-signed.c (signed_get_part): If we can't parse
the content, but we have a stream, just use that as the content.
Jeffrey Stedfast [Fri, 13 Jun 2003 19:06:52 +0000 (19:06 +0000)]
Fix for bug #40788.
2003-06-05 Jeffrey Stedfast <fejj@ximian.com>
Fix for bug #40788.
* providers/pop3/camel-pop3-engine.c (camel_pop3_engine_new): Now
takes a flags argument. Currently there is only 1 flag which can
be used to disable Pop3 server extensions.
(get_capabilities): Don't check for Pop3 server extensions if the
DISABLE_EXTENSIONS flag is set on the engine.
(camel_pop3_engine_iterate): If we get a response that is neither
+OK nor -ERR, default to treating it like a -ERR.
* providers/pop3/camel-pop3-store.c (connect_to_server): Check for
the disable_extensions param.
* providers/pop3/camel-pop3-provider.c: Define a checkbox to
disable all POP3 extension support.
Ettore Perazzoli [Thu, 12 Jun 2003 21:13:56 +0000 (21:13 +0000)]
Put the ChangeLog.pre-1-4 in the Makefiles.
Jeffrey Stedfast [Thu, 12 Jun 2003 04:48:05 +0000 (04:48 +0000)]
Partial fix for bug #44457.
2003-06-11 Jeffrey Stedfast <fejj@ximian.com>
Partial fix for bug #44457.
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): Make sure to set
rawtext to FALSE if we successfully convert the text to UTF-8.
* camel-data-wrapper.c (camel_data_wrapper_init): Default the
value of rawtext to TRUE instead of FALSE. This way if the mailer
decides to try displaying a non-textual part as text, it knows
that it needs to convert the content to UTF-8.
Jeffrey Stedfast [Wed, 11 Jun 2003 20:36:06 +0000 (20:36 +0000)]
some days you just wish you had that subatomic 100 megaton kill-o-zap bomb.
2003-06-04 Jeffrey Stedfast <fejj@ximian.com>
* camel-uid-cache.c (camel_uid_cache_new): Create the directory
with mode 0777 and the cache file itself with mode 0666. Let the
user's umask filter the permissions. Instead of saving the fd on
the Cache object, instead save the filename. Use camel_read()
instead of expecting read() to just always work without getting an
EINTR/etc.
(maybe_write_uid): Don't do anything if cache->fd == -1, this
means an error has occured in a previous callback. Replace the 2
calls to write() with camel_write() and check their return
values. If either of them fails, set cache->fd to -1 (GHashTable
doesn't give us a way to abort foreach'ing thru the table).
(camel_uid_cache_save): Save to a temp file instead of overwriting
the original. Do proper error checking, etc. Also added some
smarts about whether to try and overwrite the old cache even if we
haven't successfully saved all the uids in the cache.
(camel_uid_cache_destroy): Free the cache->filename, no longer
need to close (cache->fd).
Larry Ewing [Wed, 11 Jun 2003 19:38:33 +0000 (19:38 +0000)]
use g_utf8_strdown properly.
2003-06-11 Larry Ewing <lewing@ximian.com>
* camel-text-index.c (text_index_normalise): use g_utf8_strdown properly.
Jeffrey Stedfast [Wed, 11 Jun 2003 15:59:30 +0000 (15:59 +0000)]
Add the CAMEL_BESTENC_TEXT bit to enctype if the part is a text part.
2003-06-09 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-message.c (find_best_encoding): Add the
CAMEL_BESTENC_TEXT bit to enctype if the part is a text part.
* camel-mime-filter-bestenc.c
(camel_mime_filter_bestenc_get_best_encoding): If we have any
nul-bytes or if the content is non-text and contains any 8bit
octets, we need to use base64. Fixes bug #44344.
Ettore Perazzoli [Mon, 9 Jun 2003 17:31:12 +0000 (17:31 +0000)]
Roll over ChangeLogs.
Jeffrey Stedfast [Sun, 1 Jun 2003 23:49:29 +0000 (23:49 +0000)]
Turn off debugging.
2003-06-01 Jeffrey Stedfast <fejj@ximian.com>
* broken-date-parser.c (d): Turn off debugging.
* providers/pop3/camel-pop3-engine.c (get_capabilities): Move the
code that prepends the 'password' authtype to the auth list so
that we don't add it again when regetting the capabilities.
Jeffrey Stedfast [Fri, 30 May 2003 15:50:07 +0000 (15:50 +0000)]
Turned off a debugging printf.
2003-05-30 Jeffrey Stedfast <fejj@ximian.com>
* camel-filter-driver.c (run_only_once): Turned off a debugging
printf.
Jeffrey Stedfast [Wed, 28 May 2003 00:42:19 +0000 (00:42 +0000)]
This should finish fixing all variations of bug #42854, which, funnily
2003-05-27 Jeffrey Stedfast <fejj@ximian.com>
This should finish fixing all variations of bug #42854, which,
funnily enough specified "copying" as the scenario for reproducing
this bug, but somehow I found/fixed it only for expunging for some
reason? I can't even guess as to how this happened. Oh well,
expunging needed fixing either way.
* providers/imap/camel-imap-folder.c (imap_transfer_online): Sort
the uids here too (just like I had fixed for expunge a week or so
ago).
(imap_transfer_resyncing): Sort them here too.
(imap_search_by_uids): Sort here too, even though I don't think it
is necessary. Can't hurt.
(imap_expunge_uids_offline): Might as well sort here too.
Jeffrey Stedfast [Thu, 22 May 2003 20:17:02 +0000 (20:17 +0000)]
Lets try this again. We don't actually want to free the key here, because
2003-05-22 Jeffrey Stedfast <fejj@ximian.com>
* camel-object.c (camel_object_bag_destroy): Lets try this
again. We don't actually want to free the key here, because
camel_object_bag_remove() does that for us. This should fix bug
#43406 properly.
Jeffrey Stedfast [Wed, 21 May 2003 15:32:37 +0000 (15:32 +0000)]
Create a second GPtrArray for the keys. We don't want to use
2003-05-20 Jeffrey Stedfast <fejj@ximian.com>
* camel-object.c (camel_object_bag_destroy): Create a second
GPtrArray for the keys. We don't want to use bag->free_key() on
the object. Fixes bug #43406.
Jeffrey Stedfast [Tue, 20 May 2003 15:59:55 +0000 (15:59 +0000)]
Only display a warning if errno != EINVAL (EINVAL means there was a
2003-05-19 Jeffrey Stedfast <fejj@ximian.com>
* camel-folder-summary.c (camel_folder_summary_load): Only display
a warning if errno != EINVAL (EINVAL means there was a version
mismatch, so we don't really need to warn here since we are
supposed to be able to handle this situation).
(perform_content_info_load): Turn off debugging message.
(summary_assign_uid): Turn off uid-clash warning.
(camel_folder_summary_decode_token): Turn off debug messages.
(summary_header_load): Turn off version-mismatch warning.
Jeffrey Stedfast [Mon, 19 May 2003 17:20:04 +0000 (17:20 +0000)]
fixed ChangeLog
Jeremy Katz [Fri, 16 May 2003 18:47:59 +0000 (18:47 +0000)]
Ensure cmdbuf is initialized to avoid compiler warning.
2003-05-16 Jeremy Katz <katzj@redhat.com>
* providers/smtp/camel-smtp-transport.c (smtp_helo): Ensure cmdbuf
is initialized to avoid compiler warning.
* providers/local/camel-mbox-summary.c (summary_header_load): Cast
folder_size to uint32 to fix warning.
(camel_mbox_summary_sync_mbox): Update for new API.
* providers/imap/camel-imap-utils.c (parse_params):
imap_parse_nstring expects size_t, not int
(imap_body_decode): Likewise.
* camel-stream-filter.c (do_read): presize needs to be size_t
instead of int.
(do_write): Likewise.
* camel-seekable-substream.c (stream_read): Return ssize_t instead
of int to match prototypes.
(stream_write): Likewise.
* camel-mime-part.c (construct_from_parser): len needs to be
size_t instead of int.
* camel-mime-parser.c (folder_scan_step): datalength needs to be a
size_t* instead of an int* to make dependent APIs safe.
(camel_mime_parser_step): Likewise.
(folder_scan_content): Likewise.
* camel-mime-parser.h: Likewise.
* camel-mime-message.c (camel_mime_message_class_init): Use glib
macro for pointer/int conversions.
(construct_from_parser): Update for new API.
* camel-folder-summary.c
(camel_folder_summary_info_new_from_parser): Update len to be
size_t for new API.
(summary_build_content_info): Likewise.
* camel-http-stream.c (http_get_headers): Likewise.
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): Likewise.
* camel-multipart-signed.c (signed_construct_from_parser): Likewise.
* camel-multipart.c (construct_from_parser): Likewise.
* camel-folder-search.c (match_words_index): Use glib macros for
pointer/int conversions.
* camel-html-parser.c (tokenise_setup): Likewise.
(convert_entity): Likewise.
* camel-block-file.c (block_hash_func): Likewise.
(camel_block_file_get_block): Likewise.
(camel_block_file_get_block): Likewise.
(camel_block_file_detach_block): Likewise.
* camel-session.c (session_thread_msg_new): Likewise.
(session_thread_msg_free): Likewise.
(session_thread_wait): Likewise.
* camel-text-index.c (text_index_compress_nosync): Likewise.
(text_index_compress_nosync): Likewise.
(camel_text_index_validate): Likewise.
* camel-vee-folder.c (vee_folder_remove_folder): Likewise.
(unmatched_check_uid): Likewise.
(folder_added_uid): Likewise.
(vee_folder_build_folder): Likewise.
(folder_changed_add_uid): Likewise.
(folder_changed_remove_uid): Likewise.
* providers/imap/camel-imap-search.c (imap_body_contains): Likewise.
* providers/pop3/camel-pop3-folder.c (cmd_list): Likewise.
(cmd_uidl): Likewise.
* camel-data-cache.c (data_cache_init): Cast to CamelCopyFunc.
Fixes a warning.
Not Zed [Thu, 15 May 2003 23:30:06 +0000 (23:30 +0000)]
Simplistic quick-fix for #42710. Add a charset argument. If the data is 8
2003-05-15 Not Zed <NotZed@Ximian.com>
* camel-mime-utils.c (header_decode_word): Simplistic quick-fix
for #42710. Add a charset argument. If the data is 8 bit, try to
decode into the passed in charset (i.e. the message header?), at
worst, fall back to latin1, similarly to header_decode_text.
Fixed all callers to pass in a charset if available, or NULL.
Jeffrey Stedfast [Thu, 15 May 2003 18:05:14 +0000 (18:05 +0000)]
Only delete the index if it is non-NULL. Fixes bug #42763.
2003-05-13 Jeffrey Stedfast <fejj@ximian.com>
* providers/local/camel-local-folder.c (local_delete): Only delete
the index if it is non-NULL. Fixes bug #42763.
Not Zed [Thu, 15 May 2003 01:00:56 +0000 (01:00 +0000)]
** See bug #42540
2003-05-14 Not Zed <NotZed@Ximian.com>
** See bug #42540
* camel-service.c (camel_gethostbyname): pre-initialise the error
return to invalid, so if we cancel, we definetly get a bad result.
Also, for a valid return against result, not herr.
(camel_gethostbyaddr): Likewise.
Jeffrey Stedfast [Wed, 14 May 2003 17:53:47 +0000 (17:53 +0000)]
Added a note to the comment block for this function noting that uids MUST
2003-05-13 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-utils.c (imap_uid_array_to_set): Added
a note to the comment block for this function noting that uids
MUST be in sorted order.
* providers/imap/camel-imap-folder.c (imap_expunge_uids_online):
Sort the uids before splitting them into UID set chunks. The code
that splits the uid array into sets expects the uids to be in
sorted order. Fixes bug #42854.
* providers/imap/camel-imap-command.c (imap_command_start):
Re-enable camel_verbose_debug logging.
Jeffrey Stedfast [Tue, 13 May 2003 18:10:12 +0000 (18:10 +0000)]
If host->h_name is NULL or an empty string, default back to using the IP
2003-05-12 Jeffrey Stedfast <fejj@ximian.com>
* providers/smtp/camel-smtp-transport.c (smtp_helo): If
host->h_name is NULL or an empty string, default back to using the
IP address rather than the hostname in the EHLO command.
Ettore Perazzoli [Tue, 13 May 2003 16:03:19 +0000 (16:03 +0000)]
Disable debugging.
* providers/imap/camel-imap-folder.c (d): Disable debugging.
* providers/imap/camel-imap-command.c (d): Disable debugging.
* providers/imap/camel-imap-search.c (d): Disable debugging.
Dan Winship [Sun, 4 May 2003 19:11:39 +0000 (19:11 +0000)]
Don't call g_utf8_validate on an empty message. Fixes a warning.
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): Don't call
g_utf8_validate on an empty message. Fixes a warning.
Jeffrey Stedfast [Fri, 2 May 2003 17:37:11 +0000 (17:37 +0000)]
Workaround for POS mailers like the one in bug #42045.
2003-05-01 Jeffrey Stedfast <fejj@ximian.com>
Workaround for POS mailers like the one in bug #42045.
* camel-mime-utils.c (header_decode_date): Make sure the numeric
timezone is between -1200 and 1200, otherwise it is invalid.
* broken-date-parser.c (get_tzone): Make sure the numeric timezone
is between -1200 and 1200, otherwise it is invalid.
Dan Winship [Wed, 30 Apr 2003 15:35:28 +0000 (15:35 +0000)]
Remove camel-lock.c from here because it upsets automake 1.6 for some
* Makefile.am (camel_lock_helper_SOURCES): Remove camel-lock.c
from here because it upsets automake 1.6 for some reason
(camel_lock_helper_LDADD): Add camel-lock.o here
Jeremy Katz [Wed, 30 Apr 2003 03:09:15 +0000 (03:09 +0000)]
body_len needs to be a size_t instead of int
2003-04-29 Jeremy Katz <katzj@redhat.com>
* providers/imap/camel-imap-folder.c (parse_fetch_response):
body_len needs to be a size_t instead of int
Jeffrey Stedfast [Thu, 24 Apr 2003 17:41:28 +0000 (17:41 +0000)]
Disable debugging printfs.
2003-04-22 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-utils.c: Disable debugging printfs.
Not Zed [Thu, 24 Apr 2003 01:51:20 +0000 (01:51 +0000)]
only free the host if it was set. removes a run-time warning.
2003-04-23 Not Zed <NotZed@Ximian.com>
* providers/smtp/camel-smtp-transport.c (smtp_helo): only free the
host if it was set. removes a run-time warning.
Jeffrey Stedfast [Wed, 23 Apr 2003 18:16:23 +0000 (18:16 +0000)]
fixed merge conflicts in ChangeLog
Jeffrey Stedfast [Wed, 23 Apr 2003 18:14:54 +0000 (18:14 +0000)]
#if 0 out some code that parsed the namespaces since the results aren't
2003-04-22 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-store.c (imap_connect_online): #if 0
out some code that parsed the namespaces since the results aren't
used and they generate debugging output.
Not Zed [Wed, 23 Apr 2003 04:44:58 +0000 (04:44 +0000)]
oops, the service owns the url after we construct it.
2003-04-23 Not Zed <NotZed@Ximian.com>
* camel-session.c (get_service): oops, the service owns the url
after we construct it.
Not Zed [Wed, 23 Apr 2003 01:34:03 +0000 (01:34 +0000)]
** Should fix #41629, #41448, et al.
2003-04-22 Not Zed <NotZed@Ximian.com>
** Should fix #41629, #41448, et al.
* tests/folder/test10.c: a new torture test for object bag
creation/unreffing.
* camel-url.c (camel_url_copy): new function to copy a url.
* camel-object.c (camel_object_bag_new): add arguments for key
copy and key free functions. Fixed all callers.
(camel_object_bag_destroy): fix a memleak, free the bag key.
(camel_object_bag_get, camel_object_bag_reserve)
(camel_object_bag_abort, save_bag, save_object): Make the key a
void type, rather than char *.
(camel_object_bag_add): As above, and also copy the key.
(camel_object_bag_remove_unlocked): free the key using
bag->free_key.
* camel-session.c (register_provider)
(camel_session_destroy_provider, get_service): Changed to use an
object bag instead of a hash table for the service 'cache'.
(service_cache_remove): Removed, no longer required.
Jeffrey Stedfast [Tue, 22 Apr 2003 18:13:49 +0000 (18:13 +0000)]
Don't set seen_eof1 here anymore once we get a trust metric.
2003-04-21 Jeffrey Stedfast <fejj@ximian.com>
* camel-gpg-context.c (gpg_ctx_parse_status): Don't set seen_eof1
here anymore once we get a trust metric.
(gpg_ctx_new): Init seen_eof1 to TRUE here.
(gpg_ctx_set_ostream): Change seen_eof1 to FALSE here this way we
only ever have to set this if we are expecting output.
(gpg_ctx_parse_status): Don't set seen_eof1 for importing either.
(gpg_ctx_op_step): Only FD_SET() those fd's that we have not yet
finished reading.
Not Zed [Sat, 19 Apr 2003 03:15:54 +0000 (03:15 +0000)]
** for #40989
2003-04-17 Not Zed <NotZed@Ximian.com>
** for #40989
* camel-text-index.c (text_index_delete): delete the block
file/key file directly, not just its files.
* providers/local/camel-local-folder.c (local_delete): implement,
just delete the index file if it exists.
camel-store-delete-folder will delete other data (maybe it all
should be done here).
* camel-block-file.c (camel_key_file_finalise): keep lock around
decrementing key file use count.
(camel_key_file_delete): new function to delete the key file (&
close it off).
(key_file_use): if we've been deleted, always fail.
(camel_block_file_finalise): only close the file if its a valid
fd.
(block_file_use): if we've been deleted, always fail.
(camel_block_file_delete): delete the block file & close.
(struct _CamelBlockFilePrivate): fix the !ENABLE_THREADS case to
still compile this.
Jeffrey Stedfast [Thu, 17 Apr 2003 16:43:07 +0000 (16:43 +0000)]
Urls are unlikely to end with punctuation or closing braces, so strip any
2003-04-16 Jeffrey Stedfast <fejj@ximian.com>
* camel-url-scanner.c (camel_url_web_end): Urls are unlikely to
end with punctuation or closing braces, so strip any of those off
the end of the url. Fixes bug #41461.
* tests/mime-filter/data/html.1.out: Removed a trailing \n at the
end of the file, this is incorrect (since out input file does not
contain one).
* camel-mime-filter-tohtml.c (html_convert): Only output a <br> if
we found an eoln in the input. Along the same lines, don't write a
'\n' to the output buffer unless we've encountered that eoln in
the input. Fixes bug #41407.
Not Zed [Thu, 17 Apr 2003 03:09:37 +0000 (03:09 +0000)]
Dont assume adding 1 to line length will go to the next line. e.g. for dos
2003-04-17 Not Zed <NotZed@Ximian.com>
* camel-multipart-signed.c (parse_content): Dont assume adding 1
to line length will go to the next line. e.g. for dos lines that
end in \r\n. Fix for #41163.
(parse_boundary): util function to help above.
Jeffrey Stedfast [Wed, 16 Apr 2003 17:02:10 +0000 (17:02 +0000)]
The gpg child process exiting does not necessarily mean that we've ready
2003-04-15 Jeffrey Stedfast <fejj@ximian.com>
* camel-gpg-context.c (gpg_verify): The gpg child process exiting
does not necessarily mean that we've ready everything that we can
from its pipes, so don't use gpg_ctx_op_exited() as a loop-exit
condition. If for some reason the gpg child process does exit (due
to an error), gpg_ctx_op_step() will eventually fail (as soon as
it has finished reading any data in the pipes) and cause the loop
to be terminated anyway. This fixes truncation of the gpg --verify
stderr output that Evolution displays as the "validity report"
(for lack of a better description).
(gpg_ctx_op_step): Removed some debugging printf's
(gpg_ctx_get_diagnostics): Use a bitfield to decide if we've
already flushed the diagnostics stream, much simpler (plus we have
plenty of bits to spare so might as well use them).
(gpg_ctx_new): Fixed another logic bug which determined whether or
not we should convert the gpg output from the locale charset into
UTF-8.
Jeffrey Stedfast [Thu, 10 Apr 2003 17:13:15 +0000 (17:13 +0000)]
Turn off debugging if CAMEL_VERBOSE_DEBUG isn't set.
2003-04-10 Jeffrey Stedfast <fejj@ximian.com>
* providers/smtp/camel-smtp-transport.c: Turn off debugging if
CAMEL_VERBOSE_DEBUG isn't set.
Not Zed [Thu, 10 Apr 2003 11:35:00 +0000 (11:35 +0000)]
filter data test cases.
2003-04-10 Not Zed <NotZed@Ximian.com>
* tests/mime-filter/data: filter data test cases.
* tests/mime-filter/test-tohtml.c: New test for html filter.
** See bug #40969
* camel-mime-filter-tohtml.c (html_convert): Change the logic
slightly, scan a whole line within the main loop.