commit-queue@webkit.org [Fri, 13 Apr 2012 11:11:59 +0000 (11:11 +0000)]
Enabling/disabling delegates scrolling when page has no composited content asserts on WK1.
https://bugs.webkit.org/show_bug.cgi?id=83860
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
WK2 has compositing mode on all the time, while Wk1 turns it on only when
the page has composited content. This patch ensures that, when delegates scrolling behavior
is changed, backing stores are cleared only when there's an actual composition,
similarly to what CachedFrame does.
Test: fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html
* page/FrameView.cpp:
(WebCore::FrameView::delegatesScrollingDidChange):
LayoutTests:
* fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts-expected.txt: Added.
* fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Fri, 13 Apr 2012 11:09:29 +0000 (11:09 +0000)]
[chromium] Add WebKit API to access <datalist> options
https://bugs.webkit.org/show_bug.cgi?id=83762
Introduce WebInputElement::dataListOptions so we can implement a UI for datalist.
Reviewed by Kent Tamura.
* public/WebInputElement.h:
(WebKit):
(WebInputElement):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::dataListOptions): Added. Returns a WebNodeCollection containing WebOptionElements.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 10:39:29 +0000 (10:39 +0000)]
Unreviewed, GTK baselines for tests now being runned since the
migration to test_expectations.
* platform/gtk/css3/font-feature-settings-rendering-expected.txt: Added.
* platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt: Added.
* platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/gtk/fast/dom/gc-10-expected.txt: Added.
* platform/gtk/fast/forms/date/date-appearance-expected.txt: Added.
* platform/gtk/fast/images/exif-orientation-css-expected.txt: Added.
* platform/gtk/fast/images/exif-orientation-expected.txt: Added.
* platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
* platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
* platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Added.
* platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Added.
* platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Added.
* platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Added.
* platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Added.
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
* platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-character-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-first-word-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-locale-expected.txt: Added.
* platform/gtk/fast/text/hyphens-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-126-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-127-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-65-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-82-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-84-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-87-expected.txt: Added.
* platform/gtk/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Added.
* platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Added.
* platform/gtk/test_expectations.txt: Mark a media/track test flaky.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Apr 2012 10:37:51 +0000 (10:37 +0000)]
[Qt] Fix build on OS X
We were manually including the directories needed from WTF, instead of
using the WEBKIT qmake variable to add dependencies, which also adds
other tricks from WTF.pri, such as the right include paths for ICU.
Reviewed by Simon Hausmann.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 10:23:18 +0000 (10:23 +0000)]
New suppression.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 10:11:10 +0000 (10:11 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt: Skip two media tests trigger flakiness.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 10:10:41 +0000 (10:10 +0000)]
Web Inspector: Line number is not displayed while debugging javascript
https://bugs.webkit.org/show_bug.cgi?id=83786
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-13
Reviewed by Pavel Feldman.
Changed the textViewer.css to start displaying the line number with
appropriate color property. Added outline property for enhanced view
No additional test cases required for the above fix.
* inspector/front-end/Images/breakpointConditionalCounterBorder.png:
* inspector/front-end/Images/breakpointCounterBorder.png:
* inspector/front-end/Images/programCounterBorder.png:
* inspector/front-end/textViewer.css:
(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 09:37:09 +0000 (09:37 +0000)]
Now test sometimes crashes in Debug on XP too.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 13 Apr 2012 09:15:27 +0000 (09:15 +0000)]
Add a runtime flag for <input type=date>
https://bugs.webkit.org/show_bug.cgi?id=83853
Reviewed by Adam Barth.
Source/WebCore:
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled): Added.
* html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
Don't register type=date if !RuntimeEnabledFeatures::inputTypeDateEnabled()
Source/WebKit/chromium:
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures): Add enableInputTypeDate() and isInputTypeDateEnabled().
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableInputTypeDate): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateEnabled): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 09:12:58 +0000 (09:12 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt: Skip failing new
encrypted-media test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 08:58:52 +0000 (08:58 +0000)]
Rebaselines.
Unreviewed.
* platform/chromium-mac/fast/ruby/nested-ruby-expected.txt: Added.
* platform/chromium-mac/fast/text/international/002-expected.png: Added.
* platform/chromium-mac/fast/text/international/002-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 08:57:33 +0000 (08:57 +0000)]
JSDocument::setLocation does too much bare-handed lifting
https://bugs.webkit.org/show_bug.cgi?id=83850
Reviewed by Sam Weinig.
As part of auditing all the ways of kicking off a navigation, I
happened to read JSDocument::setLocation, which uses very old patterns.
This patch updates it to do things the "modern" way. There shouldn't
be any behavior change.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 08:55:30 +0000 (08:55 +0000)]
Rebaselines.
Unreviewed.
* platform/chromium-win/platform/chromium/compositing/filters: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 08:44:30 +0000 (08:44 +0000)]
Unreviewed, GTK rebaseline.
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Fri, 13 Apr 2012 08:39:58 +0000 (08:39 +0000)]
Background width (or height) is wrong if width (or height) * zoom < 1.
https://bugs.webkit.org/show_bug.cgi?id=83350
Reviewed by Nikolas Zimmermann.
Source/WebCore:
calculateImageIntrinsicDimension will return wrong size if the calculated size is 0.
0 is used for expressing unspecfied, so the method returns the box width(height) instead.
Since CachedImage has already similar code, we moved it to IntSize and shared it.
Tests: fast/css/zoom-background-repeat-x-expected.html
fast/css/zoom-background-repeat-x.html
fast/css/zoom-background-repeat-y-expected.html
fast/css/zoom-background-repeat-y.html
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
* platform/graphics/IntSize.h:
(IntSize):
(WebCore::IntSize::scale):
(WebCore::IntSize::clampToMinimumSize):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
LayoutTests:
* fast/css/zoom-background-repeat-x-expected.html: Added.
* fast/css/zoom-background-repeat-x.html: Added.
* fast/css/zoom-background-repeat-y-expected.html: Added.
* fast/css/zoom-background-repeat-y.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 07:56:20 +0000 (07:56 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 07:53:46 +0000 (07:53 +0000)]
Prepare submitForm for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83838
Reviewed by Ryosuke Niwa.
Previously, FrameLoader::submitForm called FrameTree::find and
Document::canNavigate separately. This patch refactors this function
to call findFrameForNavigation, which does both checks.
This doesn't change any behavior today, but it prepares us to implement
seamless navigation. Once the seamless branch lands, this change will
be tested by seamless-form-* in https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
For context, see:
https://github.com/eseidel/webkit/commit/
3f27340577ac91b2cc0a834dd2c6fdfcac296c32
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 13 Apr 2012 07:35:40 +0000 (07:35 +0000)]
Should clear an invalid string in a date field on blur
https://bugs.webkit.org/show_bug.cgi?id=83863
Reviewed by Kentaro Hara.
Source/WebCore:
Test: fast/forms/date/input-date-commit-valid-only.html
* html/DateInputType.cpp:
(WebCore::DateInputType::handleBlurEvent):
Reset the visible value. The code is same as NumberInputType::handleBlurEvent().
LayoutTests:
* fast/forms/date/input-date-commit-valid-only-expected.txt: Added.
* fast/forms/date/input-date-commit-valid-only.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 13 Apr 2012 07:30:57 +0000 (07:30 +0000)]
[Chromium] <input type=date> tests should pass.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 13 Apr 2012 06:33:14 +0000 (06:33 +0000)]
Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
https://bugs.webkit.org/show_bug.cgi?id=83685
Reviewed by Kentaro Hara.
Remove the followings from input files:
- multi line comments /*...*/ (.js and .css)
- single line comment //... (.js)
- repeating whitespace (.js and .css)
- leading and trailing whitespace (.js and .css)
- empty lines (.js and .css)
This doesn't work for arbitrary JavaScript or CSS inputs, but
works well for expected input files like
css/make-css-file-arrays.pl
* make-file-arrays.py:
(strip_whitespace_and_comments):
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 06:19:01 +0000 (06:19 +0000)]
Mark test as also crashing.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 06:14:59 +0000 (06:14 +0000)]
Chromium: Fix scrollbar tickmark drawing on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=83844
Patch by Sailesh Agrawal <sail@chromium.org> on 2012-04-12
Reviewed by James Robinson.
On Mountain Lion overlay scrollbars have a new expanded mode. In expanded mode the scrolllbar is slightly wider which causes the tickmarks to look incorrect. Fix was to explicitly enter expanded mode to get the correct look.
Screenshots:
broken: http://i.imgur.com/PDKYH.png
fixed: http://i.imgur.com/utp0Y.png
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint): Called setExpanded if API is available.
* platform/mac/NSScrollerImpDetails.h: Exposed the isExpanded: API.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 06:11:56 +0000 (06:11 +0000)]
Rebaselines.
Unreviewed.
* platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 06:08:21 +0000 (06:08 +0000)]
Rebaselines.
Unreviewed.
* platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 13 Apr 2012 06:07:40 +0000 (06:07 +0000)]
LocalizedDateICU should ignore timezones
https://bugs.webkit.org/show_bug.cgi?id=83859
Reviewed by Hajime Morita.
udat_parse() and udat_format() shift the input date by the offset of the
default timezone. We don't need this behavior for type=date. So we
specify "GMT" to udat_open().
No new tests. This behavior depends on the timezone setting of the local machine.
* platform/text/LocalizedDateICU.cpp:
(WebCore::createShortDateFormatter):
Added. Common factory functio for UDateFormat. Use "GMT" instead of the
default timezone.
(WebCore::parseLocalizedDate): Use createShortDateFormatter().
(WebCore::formatLocalizedDate): ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 13 Apr 2012 06:00:09 +0000 (06:00 +0000)]
[GTK] Enable WebKit2 by default in configure
https://bugs.webkit.org/show_bug.cgi?id=83753
Reviewed by Martin Robinson.
* configure.ac:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 05:37:01 +0000 (05:37 +0000)]
Rebaselines.
Unreviewed.
* fast/media/mq-min-pixel-ratio-expected.txt: Added.
* fast/reflections/reflection-masks-expected.txt: Added.
* fast/reflections/reflection-masks-opacity-expected.txt: Added.
* fast/reflections/reflection-masks-outset-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png:
* platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png:
* platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png:
* platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png:
* platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
* platform/chromium-mac-leopard/fast/media/mq-min-pixel-ratio-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-direction-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-masks-opacity-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png:
* platform/chromium-mac-leopard/svg/custom/createImageElement-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/chromium-mac-leopard/svg/custom/js-update-image-and-display-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/js-update-image-and-display2-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/js-update-image-and-display3-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/js-update-image-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/text-image-opacity-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
* platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/masks/direct-image-mask-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png:
* platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
* platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
* platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
* platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/css3/filters/effect-contrast-expected.png:
* platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
* platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
* platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/css3/filters/effect-invert-expected.png:
* platform/chromium-mac/css3/filters/effect-invert-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-opacity-expected.png:
* platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/css3/filters/effect-saturate-expected.png:
* platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-sepia-expected.png:
* platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png:
* platform/chromium-mac/css3/filters/regions-expanding-expected.png:
* platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
* platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/reflections/reflection-masks-outset-expected.png:
* platform/chromium-mac/platform/chromium/virtual/threaded: Added.
* platform/chromium-mac/platform/chromium/virtual/threaded/compositing: Added.
* platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility: Added.
* platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-mac/svg/custom/createImageElement-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/createImageElement2-expected.png:
* platform/chromium-mac/svg/custom/focus-ring-expected.png:
* platform/chromium-mac/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/js-update-image-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
* platform/efl/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
* platform/efl/fast/reflections/reflection-masks-expected.txt: Removed.
* platform/efl/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
* platform/efl/fast/reflections/reflection-masks-outset-expected.png: Removed.
* platform/efl/fast/reflections/reflection-masks-outset-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.txt: Removed.
* platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.txt: Removed.
* platform/gtk/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
* platform/gtk/fast/reflections/reflection-masks-outset-expected.png: Removed.
* platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Removed.
* platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/mac/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
* platform/qt/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
* platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 05:31:20 +0000 (05:31 +0000)]
Prepare window.location for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83843
Reviewed by Eric Seidel.
This patch refactors window.location to flow through
FrameLoader::findFrameForNavigation, which is where we're going to
implement the seamless navigation redirect. This patch shouldn't cause
any observable changes in behavior today, but it will make all the
seamless-window-location* tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
pass once we merge the seamlesss branch. See
https://github.com/eseidel/webkit/commit/
a6e708fa6c643b156397e9a287b40a0868c7959c
for context.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::locationAccessorSetter):
* page/Location.cpp:
(WebCore::Location::setHref):
(WebCore::Location::setProtocol):
(WebCore::Location::setHost):
(WebCore::Location::setHostname):
(WebCore::Location::setPort):
(WebCore::Location::setPathname):
(WebCore::Location::setSearch):
(WebCore::Location::setHash):
(WebCore::Location::assign):
(WebCore::Location::replace):
(WebCore::Location::setLocation):
(WebCore):
* page/Location.h:
(Location):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Fri, 13 Apr 2012 05:28:44 +0000 (05:28 +0000)]
[chromium] Background filters for composited layers
https://bugs.webkit.org/show_bug.cgi?id=80046
Reviewed by Adrienne Walker.
Source/WebCore:
Adds background filters to LayerChromium/CCLayerImpl. These filters are
applied to any pixels in the contents behind the layer and seen through
it.
This is done by adding a backgroundTexture() to the render surface, which
holds the read-back contents of the target framebuffer, background filter
applied, in the surface's own coordinate space. Then this is drawn back
into the frame buffer before the contents of the surface itself is drawn.
Tests: platform/chromium/compositing/filters/background-filter-blur-off-axis.html
platform/chromium/compositing/filters/background-filter-blur-outsets.html
platform/chromium/compositing/filters/background-filter-blur.html
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBackgroundFilters):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::backgroundFilters):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderSurface):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::useManagedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setBackgroundFilters):
(WebCore::RenderSurfaceChromium::backgroundFilters):
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setBackgroundFilters):
(WebCore):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::backgroundFilters):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::prepareBackgroundTexture):
(WebCore):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::computeDeviceTransform):
(WebCore::CCRenderSurface::computeDeviceBoundingBox):
(WebCore::CCRenderSurface::computeReadbackDeviceBoundingBox):
(WebCore::CCRenderSurface::readbackDeviceContentRect):
(WebCore::copyTextureToFramebuffer):
(WebCore::CCRenderSurface::copyDeviceToBackgroundTexture):
(WebCore::getSkBitmapTextureId):
(WebCore::CCRenderSurface::drawContents):
(WebCore::CCRenderSurface::drawReplica):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
(WebCore::CCRenderSurface::applyFilters):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
(WebCore::CCRenderSurface::setBackgroundFilters):
(WebCore::CCRenderSurface::backgroundFilters):
(WebCore::CCRenderSurface::backgroundTexture):
* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::setBackgroundBlurOnNode):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit/chromium:
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
LayoutTests:
* platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
* platform/chromium/compositing/filters/background-filter-blur-expected.txt: Added.
* platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
* platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Added.
* platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Added.
* platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
* platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
* platform/chromium/compositing/filters/background-filter-blur-outsets.html: Added.
* platform/chromium/compositing/filters/background-filter-blur.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 04:39:58 +0000 (04:39 +0000)]
Remove V8DOMWindowShell::setLocation
https://bugs.webkit.org/show_bug.cgi?id=83833
Reviewed by Eric Seidel.
V8DOMWindowShell::setLocation is only used by document.location. It's
more direct for document.location to call Location::setHref directly.
This integrates correctly with the navigation rules for
<iframe seamless>.
(See https://github.com/eseidel/webkit/compare/master...seamless for
more context about the connection with seamless.)
Reviewed on GitHub:
https://github.com/abarth/webkit/commit/
48601729d53a6ac39df5a43b22218c91330c3f61
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorSetter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Fri, 13 Apr 2012 04:19:42 +0000 (04:19 +0000)]
Prepare functions in LengthFunctions.h for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83726
Reviewed by Eric Seidel.
Preparing the functions that live in LengthFunctions for sub-pixel layout, which entails
using and returning LayoutUnits instead of integers. There are a number of rendering
classes that are laid out using integers -- see https://trac.webkit.org/wiki/LayoutUnit
for details -- so this also adds integer-specific versions of the length functions for
explicit use in those classes.
No new tests. No change in behavior.
* css/LengthFunctions.h:
(WebCore): Using LayoutUnits for sub-pixel precision and adding integer-specific versions
of minimumValueForLength and valueForLength that truncate.
* css/LengthFunctions.cpp:
(WebCore):
* dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Document sizes are integral.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layOutAxis): The frame tree continues to be integral.
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::timerFired): RenderMarquee scrolling uses integral values.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Table layout is integral.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 03:51:43 +0000 (03:51 +0000)]
Unreviewed, rolling out r114075.
http://trac.webkit.org/changeset/114075
https://bugs.webkit.org/show_bug.cgi?id=83857
Breaks compile (Requested by jamesr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12
Source/Platform:
* Platform.gypi:
Source/WebCore:
* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/VideoFrameChromium.cpp: Renamed from Source/Platform/chromium/src/WebVideoFrame.cpp.
(WebCore):
(WebCore::VideoFrameChromium::~VideoFrameChromium):
* platform/graphics/chromium/VideoFrameChromium.h: Copied from Source/Platform/chromium/public/WebVideoFrame.h.
(WebCore):
(VideoFrameChromium):
* platform/graphics/chromium/VideoFrameProvider.h:
(VideoFrameProvider):
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
Source/WebKit/chromium:
* WebKit.gyp:
* public/WebVideoFrame.h:
(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):
* src/AssertMatchingEnums.cpp:
* src/VideoFrameChromiumImpl.cpp: Added.
(WebKit):
(WebKit::VideoFrameChromiumImpl::toWebVideoFrame):
(WebKit::VideoFrameChromiumImpl::VideoFrameChromiumImpl):
(WebKit::VideoFrameChromiumImpl::format):
(WebKit::VideoFrameChromiumImpl::width):
(WebKit::VideoFrameChromiumImpl::height):
(WebKit::VideoFrameChromiumImpl::planes):
(WebKit::VideoFrameChromiumImpl::stride):
(WebKit::VideoFrameChromiumImpl::data):
(WebKit::VideoFrameChromiumImpl::requiredTextureSize):
(WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
(WebKit::VideoFrameChromiumImpl::textureId):
(WebKit::VideoFrameChromiumImpl::textureTarget):
* src/VideoFrameChromiumImpl.h: Renamed from Source/Platform/chromium/public/WebVideoFrame.h.
(WebKit):
(VideoFrameChromiumImpl):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 03:47:20 +0000 (03:47 +0000)]
Use _self to represnet self-navigation, like in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=83834
Reviewed by Eric Seidel.
This patch aligns the internal state representation of the FrameLoader
more closely with the HTML5 spec. Both the null string and "_self"
represent self-navigation, but the HTML5 spec distinguishes them when
navigating seamless iframes. In that case, "_self" is explicit
self-navigation, whereas a null string will get redirected to the
"master" frame (the closest enclosing non-seamless frame).
This patch shouldn't have any observable behavior changes, but it will
be useful when we merge in the seamless branch from GitHub.
(See https://github.com/eseidel/webkit/commit/
df0e71fcacdb0e7e45fe669afe1314cec5b76523
which contains this change.)
Once the seamless branch lands, this change will be tested by a number
of tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
including seamless-hyperlink.html.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 13 Apr 2012 03:11:20 +0000 (03:11 +0000)]
Extract PerfTest class from PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83847
Reviewed by Hajime Morita.
Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
that was previously represented by a tuple.
Also moved the logic to determine whether a given test is chromium style or not from run() to
_collect_tests(). And moved the output parsing algorithms for parser style and chromium style
tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
add new types of tests more easily.
* Scripts/webkitpy/performance_tests/perftest.py: Added.
(PerfTest):
(PerfTest.__init__):
(PerfTest.test_name):
(PerfTest.dirname):
(PerfTest.path_or_url):
(PerfTest._should_ignore_line_in_parser_test_result):
(PerfTest.parse_output):
(ChromiumStylePerfTest):
(ChromiumStylePerfTest.__init__):
(ChromiumStylePerfTest.parse_output):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(run_test):
(_tests_for_runner):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(_collect_tests_and_sort_test_name):
(test_collect_tests):
(test_collect_tests_with_skipped_list):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 13 Apr 2012 02:52:59 +0000 (02:52 +0000)]
[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851
Reviewed by Adam Barth.
Source/Platform:
Move WebVideoFrame API into Platform.
* Platform.gypi:
* chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.
(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):
* chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.
(WebKit):
Source/WebCore:
Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).
Covered by existing media/ and compositing/ layout tests.
* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/VideoFrameProvider.h:
(VideoFrameProvider):
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebKit):
Source/WebKit/chromium:
Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.
* WebKit.gyp:
* public/WebVideoFrame.h:
* src/AssertMatchingEnums.cpp:
* src/VideoFrameChromiumImpl.cpp: Removed.
* src/VideoFrameChromiumImpl.h: Removed.
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Apr 2012 02:51:18 +0000 (02:51 +0000)]
REGRESSION (r113900): Text tests started failing
https://bugs.webkit.org/show_bug.cgi?id=83724
Reviewed by Dan Bernstein.
Source/WebCore:
* Resources/DefaultFonts.plist.in: Use serif fonts for standard family again,
and updated the list with better fonts for Japanese.
LayoutTests:
* platform/mac/Skipped: unskip the tests.
* platform/mac/fast/ruby/nested-ruby-expected.png:
* platform/mac/fast/ruby/nested-ruby-expected.txt:
* platform/mac/fast/text/international/002-expected.png:
* platform/mac/fast/text/international/002-expected.txt:
Updated for minor rendering differences.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 13 Apr 2012 02:30:03 +0000 (02:30 +0000)]
Improve replaceUsingStringSearch() for case of a single character searchValue
https://bugs.webkit.org/show_bug.cgi?id=83738
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.
This patch improves replaceUsingStringSearch() with the following:
-Add a special case for single character search, taking advantage of the faster WTF::find().
-Inline replaceUsingStringSearch().
-Use StringImpl::create() instead of UString::substringSharingImpl() since we know we are in the bounds
by definition.
This gives less than 1% improvement for the multicharacter replace.
The single character search show about 9% improvement.
* runtime/StringPrototype.cpp:
(JSC::replaceUsingStringSearch):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 13 Apr 2012 02:25:32 +0000 (02:25 +0000)]
Inline StringImpl::find(UChar, ...)
https://bugs.webkit.org/show_bug.cgi?id=83737
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.
The implementation of StringImpl::find() is a simple branch before invoking one of
two inline functions. The overhead of having a function for StringImpl::find() is significant.
It is better to let the compiler decide if that should be inlined or not.
* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:
(StringImpl):
(WTF::find):
(WTF):
(WTF::reverseFind):
(WTF::StringImpl::find):
* wtf/text/WTFString.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Fri, 13 Apr 2012 02:12:40 +0000 (02:12 +0000)]
Versioning.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Apr 2012 01:54:08 +0000 (01:54 +0000)]
Preprocessing text files with modern clang treats double slashes in comments
https://bugs.webkit.org/show_bug.cgi?id=83827
Reviewed by Mark Rowe.
Source/WebCore:
* DerivedSources.make: Pass appropriate flags to both llvm and gcc.
Source/WebKit2:
* DerivedSources.make: Pass appropriate flags to both llvm and gcc.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 01:32:36 +0000 (01:32 +0000)]
Add Encrypted Media Extensions events and errors to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82974
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-12
Reviewed by Adam Barth.
The new events and errors are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#events.
Source/WebCore:
Tests: fast/events/constructors/media-key-event-constructor.html
media/encrypted-media/encrypted-media-constants.html
media/encrypted-media/encrypted-media-events.html
* WebCore.gypi:
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
* bindings/v8/Dictionary.h:
(WebCore):
(Dictionary):
* dom/EventNames.h:
(WebCore):
* dom/EventNames.in:
* html/HTMLAttributeNames.in:
* html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerKeyAdded):
(WebCore::HTMLMediaElement::mediaPlayerKeyError):
(WebCore::HTMLMediaElement::mediaPlayerKeyMessage):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLMediaElement.idl:
* html/MediaError.h:
* html/MediaError.idl:
* html/MediaKeyError.h: Added.
(WebCore):
(MediaKeyError):
(WebCore::MediaKeyError::create):
(WebCore::MediaKeyError::code):
(WebCore::MediaKeyError::MediaKeyError):
* html/MediaKeyError.idl: Added.
* html/MediaKeyEvent.cpp: Added.
(WebCore):
(WebCore::MediaKeyEventInit::MediaKeyEventInit):
(WebCore::MediaKeyEvent::MediaKeyEvent):
(WebCore::MediaKeyEvent::~MediaKeyEvent):
(WebCore::MediaKeyEvent::interfaceName):
* html/MediaKeyEvent.h: Added.
(WebCore):
(MediaKeyEventInit):
(MediaKeyEvent):
(WebCore::MediaKeyEvent::create):
(WebCore::MediaKeyEvent::keySystem):
(WebCore::MediaKeyEvent::sessionId):
(WebCore::MediaKeyEvent::initData):
(WebCore::MediaKeyEvent::message):
(WebCore::MediaKeyEvent::defaultURL):
(WebCore::MediaKeyEvent::errorCode):
(WebCore::MediaKeyEvent::systemCode):
* html/MediaKeyEvent.idl: Added.
* page/DOMWindow.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore):
(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::keyError):
(WebCore::MediaPlayer::keyMessage):
(WebCore::MediaPlayer::keyNeeded):
* platform/graphics/MediaPlayer.h:
(MediaPlayerClient):
(WebCore::MediaPlayerClient::mediaPlayerKeyAdded):
(WebCore::MediaPlayerClient::mediaPlayerKeyError):
(WebCore::MediaPlayerClient::mediaPlayerKeyMessage):
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
(MediaPlayer):
Source/WebKit/chromium:
* public/WebMediaPlayerClient.h:
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::keyAdded):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::keyError):
(WebKit::WebMediaPlayerClientImpl::keyMessage):
(WebKit::WebMediaPlayerClientImpl::keyNeeded):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
LayoutTests:
* fast/events/constructors/media-key-event-constructor-expected.txt: Added.
* fast/events/constructors/media-key-event-constructor.html: Added.
* fast/js/resources/js-test-pre.js:
(shouldBeZero):
(shouldBeEmptyString):
* media/encrypted-media/encrypted-media-constants-expected.txt: Added.
* media/encrypted-media/encrypted-media-constants.html: Added.
* media/encrypted-media/encrypted-media-events-expected.txt: Added.
* media/encrypted-media/encrypted-media-events.html: Added.
* media/video-test.js:
(testExpected):
(testArraysEqual):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 13 Apr 2012 01:26:17 +0000 (01:26 +0000)]
Reset the user preferred language overrides in Internals::reset
https://bugs.webkit.org/show_bug.cgi?id=83845
Reviewed by Ryosuke Niwa.
We don't want setting the language override in one test to affect subsequent tests,
so make sure to reset it in Internals::reset.
* testing/Internals.cpp:
(WebCore::Internals::reset):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 01:11:16 +0000 (01:11 +0000)]
Make layout tests not access apache on localhost:80
https://bugs.webkit.org/show_bug.cgi?id=82197
Patch by Pablo Flouret <pablof@motorola.com> on 2012-04-12
Reviewed by Ryosuke Niwa.
It pollutes the logs of people running a local webserver, and has the
potential for changing the results of tests run locally.
* fast/dom/onerror-img.html:
* fast/js/custom-constructors-expected.txt:
* fast/js/script-tests/custom-constructors.js:
* fast/notifications/notifications-double-show.html:
* fast/notifications/notifications-with-permission.html:
* fast/notifications/notifications-without-permission.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 13 Apr 2012 01:08:21 +0000 (01:08 +0000)]
[chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite()
https://bugs.webkit.org/show_bug.cgi?id=83837
Reviewed by James Robinson.
- merge CCSingleThreadProxy::commitIfNeeded() and CCSingleThreadProxy::doComposite() into commitAndComposite()
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback): call site updated.
(WebCore::CCSingleThreadProxy::compositeImmediately): ditto.
(WebCore::CCSingleThreadProxy::commitAndComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Fri, 13 Apr 2012 01:07:27 +0000 (01:07 +0000)]
Remove FrameLoader:m_isLoadingMainResource, since it is always
false at the only point it is checked.
https://bugs.webkit.org/show_bug.cgi?id=83819
Reviewed by Adam Barth.
No new tests, no functionality change intended.
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::end): Merge with endIfNotLoadingMainResource(), always end, assert that we're still attached.
* loader/DocumentWriter.h:
* loader/FrameLoader.cpp:
* loader/FrameLoader.h: Remove isLoadingMainResource(), didEndDocument(), and m_isLoadingMainResource.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Fri, 13 Apr 2012 00:58:30 +0000 (00:58 +0000)]
XMLSerializer().serializeToString() doesn't generate the XML declaration markup like Opera and Firefox
https://bugs.webkit.org/show_bug.cgi?id=83432
Reviewed by Ryosuke Niwa.
Source/WebCore:
Serialize the xml declaration exactly as parsed, if present in the document.
Test: fast/dom/dom-parse-serialize-xmldecl.html
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setXMLStandalone): update xmlStandalone to either yes or no.
* dom/Document.h:
(WebCore::Document::xmlStandalone):
(WebCore::Document::xmlStandaloneStatus): xmlStandalone can be unspecified, yes or no.
(WebCore::Document::hasXMLDeclaration): test if xml declaration is present.
(WebCore::Document::setHasXMLDeclaration):
(Document):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendXMLDeclaration): write xml declaration if present.
(WebCore):
(WebCore::MarkupAccumulator::appendStartMarkup):
* editing/MarkupAccumulator.h:
(MarkupAccumulator):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.
LayoutTests:
Verify that xml declaration gets serialized if present. The updated test results are improvements.
* fast/dom/dom-parse-serialize-display-expected.txt:
* fast/dom/dom-parse-serialize-expected.txt:
* fast/dom/dom-parse-serialize-xmldecl-expected.txt: Added.
* fast/dom/dom-parse-serialize-xmldecl.html: Added.
* fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* fast/xsl/xslt-processor-expected.txt:
* http/tests/xmlhttprequest/xml-encoding-expected.txt:
* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 00:42:37 +0000 (00:42 +0000)]
window.open should prepare for seamless navigation by using findFrameForNavigation
https://bugs.webkit.org/show_bug.cgi?id=83835
Reviewed by Ryosuke Niwa.
Before this patch, window.open called FrameTree::find and
Document::canNavigate separately. This patch refactors the code to
call FrameLoader::findFrameForNavigation, which does both. This
refactoring prepares window.open to understand seamless navigation,
which will happen in findFrameForNavigation.
This patch should have no behavior change today, but once we merge the
seamless branch, this change will be tested by
https://github.com/eseidel/webkit/blob/seamless/LayoutTests/fast/frames/seamless/seamless-window-open.html
See https://github.com/eseidel/webkit/commit/
a0d8b7defbb63047912aefbc8e22bca4f0638c37 for context.
* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
(WebCore::createWindow):
* loader/FrameLoader.h:
(FrameLoader):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 00:26:23 +0000 (00:26 +0000)]
Convert layout test resource PNGs to sRGB. Some tests, such as
compositing/color-matching/image-color-matching.html, expect that
images with an RGB profile will not be altered when displayed. However,
some of the resources have RGB profiles that are different from sRGB
and actually should change when displayed with color profile support.
https://bugs.webkit.org/show_bug.cgi?id=83799
Patch by Tony Payne <tpayne@chromium.org> on 2012-04-12
Reviewed by Adam Barth.
* compositing/resources/thiswayup.png:
* css3/filters/resources/reference.png:
* fast/media/resources/apple_logo_half_size.png:
* fast/reflections/resources/kate.png:
* svg/as-border-image/resources/large-tiles.png:
* svg/custom/resources/green-checker.png:
* svg/custom/resources/red-checker.png:
* svg/wicd/resources/test-svg-child-object-rightsizing.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Fri, 13 Apr 2012 00:09:40 +0000 (00:09 +0000)]
StructureStubInfo::reset() causes leaks of PolymorphicAccessStructureList and ExecutableMemoryHandle objects
https://bugs.webkit.org/show_bug.cgi?id=83823
Reviewed by Gavin Barraclough.
Put the clearing of the accessType to after the call to deref() so that
deref() can use the accessType to delete referenced objects as needed.
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::reset):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Fri, 13 Apr 2012 00:03:22 +0000 (00:03 +0000)]
[Chromium] Marking fast/regions/region-overflow-break.html as image failure on Mac.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 12 Apr 2012 23:58:44 +0000 (23:58 +0000)]
REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important'
https://bugs.webkit.org/show_bug.cgi?id=83832
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Shipping versions of iAd Producer rely on the pre-r102262 behavior of
respecting '!important' when specified in a CSSStyleDeclaration
property setter. Restore this quirky behavior for versions of the app
that expect it.
* WebCore.exp.in: Export
Settings::setShouldRespectPriorityInCSSAttributeSetters().
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::putDelegate): If
setShouldRespectPriorityInCSSAttributeSetters() is true, restore the
pre-r102262 behavior wherein we attempt to parse '!important' out of
the property value.
* page/Settings.cpp:
(WebCore::Settings::setShouldRespectPriorityInCSSAttributeSetters):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
* page/Settings.h:
Source/WebKit/mac:
* Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first
version of WebKit.framework to ignore '!important' in
CSSStyleDeclaration property setters.
* WebView/WebView.mm:
(shouldRespectPriorityInCSSAttributeSetters):
(-[WebView _commonInitializationWithFrameName:groupName:]): Enable a
quirk to restore pre-r102262 behavior if the application is iAd Producer
and was linked against a version of WebKit.framework that had the old behavior.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achicu@adobe.com [Thu, 12 Apr 2012 23:55:25 +0000 (23:55 +0000)]
REGRESSION(112745) [CSS Filters] Memory use explosion for offscreen filtered elements
https://bugs.webkit.org/show_bug.cgi?id=83815
Reviewed by Simon Fraser.
Source/WebCore:
The filtered area used to be the dirty rect intersected by the bounding box of the
layer. During a previous change that behavior was lost, so adding it back now.
Also, removing the memory buffers used to compute filters after the filter is computed.
They are deleted next time the filter is applied anyway, so there's no need to keep the
memory for them.
Test: css3/filters/offscreen-filters-memory-usage.html
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::prepare):
(WebCore):
(WebCore::FilterEffectRenderer::clearIntermediateResults):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
* rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
LayoutTests:
Adding a test that creates a lot of layers outside the viewport. The memory should not grow
and the browser should not crash.
* css3/filters/offscreen-filters-memory-usage-expected.txt: Added.
* css3/filters/offscreen-filters-memory-usage.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 12 Apr 2012 23:10:02 +0000 (23:10 +0000)]
[WinCairo] Build fix after Windows export definition file change.
* win/WebKit2CFLite.def: This file needs to be kept in sync with
WebKit2.def (aside from the WebKitInterface exports.)
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 12 Apr 2012 23:08:01 +0000 (23:08 +0000)]
[WinCairo] Build fix after addition of openTypeTable.
* platform/graphics/FontPlatformData.h:
(FontPlatformData): The openTypeTable declaration is needed
for WinCairo as well.
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore):
(WebCore::FontPlatformData::openTypeTable): The implementation
of openTypeTable is needed for non-CG builds.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Thu, 12 Apr 2012 23:00:16 +0000 (23:00 +0000)]
Image failures due to text rendering change.
Bug filed and test flagged failing.
https://bugs.webkit.org/show_bug.cgi?id=83826
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 12 Apr 2012 22:28:03 +0000 (22:28 +0000)]
[Qt] Fix WebKit1 build with V8
https://bugs.webkit.org/show_bug.cgi?id=83322
Reviewed by Adam Barth.
Source/JavaScriptCore:
* yarr/yarr.pri:
Source/WebCore:
Make it possible to build WebKit1 with v8.
WebKit2 is not covered yet so it need to be disabled.
To build webkit with --v8 one need a qtjsbackend with
an up-to-date copy of v8. Thanks to Peter Varga such
a public repository is available on gitorious:
https://qt.gitorious.org/~stampho/qt/stamphos-qtjsbackend.
This patch contains some build fix with !ENABLE(INSPECTOR)
from it's previous version. These are not necessary now
but I kept them because they makes sense.
No change in behaviour so no new tests.
* DerivedSources.pri:
* Target.pri:
* WebCore.pri:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptControllerQt.cpp:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::retainedDOMInfo):
(WebCore::ScriptProfiler::initialize):
* bindings/v8/ScriptState.cpp:
(WebCore::evalEnabled):
(WebCore::setEvalEnabled):
* bindings/v8/V8Binding.cpp:
(WebCore):
* bindings/v8/V8Binding.h:
(V8BindingPerIsolateData):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8GCForContextDispose.cpp:
(WebCore::V8GCForContextDispose::pseudoIdleTimerFired):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
* config.h:
* editing/TextIterator.cpp:
* html/MediaFragmentURIParser.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
* platform/qt/PlatformSupportQt.cpp:
(WebCore::PlatformSupport::popupsAllowed):
Source/WebKit/qt:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didCreateScriptContext):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::allowScriptExtension):
* WebCoreSupport/InitWebCoreQt.cpp:
Source/WTF:
* wtf/StdLibExtras.h:
(WTF):
Tools:
* DumpRenderTree/qt/DumpRenderTree.pro:
* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 22:19:15 +0000 (22:19 +0000)]
IndexedDB: Refactor cursor iteration to remove duplicate code
https://bugs.webkit.org/show_bug.cgi?id=83302
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-12
Reviewed by Ojan Vafai.
No new tests, no behavior changes.
* Modules/indexeddb/IDBBackingStore.h:
(Cursor):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 12 Apr 2012 21:54:21 +0000 (21:54 +0000)]
More rebaselining.
* platform/mac/fast/dom/Window/window-properties-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 12 Apr 2012 21:39:23 +0000 (21:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=83821
Move dfg repatching properties of structure stub info into a union
Reviewed by Oliver Hunt.
We want to be able to have similar properties for the baseline JIT, some restructuring to prepare for this.
* bytecode/StructureStubInfo.h:
(StructureStubInfo):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 12 Apr 2012 21:38:38 +0000 (21:38 +0000)]
Delete a bunch of unused, copy & pasted values in JIT.h
https://bugs.webkit.org/show_bug.cgi?id=83822
Reviewed by Oliver Hunt.
The only architecture we support the JSVALUE64 JIT on is x86-64, all the patch offsets for other architectures are just nonsense.
* jit/JIT.h:
(JIT):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 12 Apr 2012 21:19:39 +0000 (21:19 +0000)]
[Chromium] Flaky svg/W3C-SVG-1.1/filters-conv-01-f.svg
https://bugs.webkit.org/show_bug.cgi?id=83820
Unreviewed Chromium test expectations.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
* platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Thu, 12 Apr 2012 21:15:55 +0000 (21:15 +0000)]
Add support for [ArrayClass] and use that on NodeList
https://bugs.webkit.org/show_bug.cgi?id=
Reviewed by Adam Barth.
Attempt to reland r113931. Now with more updated test expectations.
With this patch NodeLists now have Array.prototype on their prototype chain which allows
methods such as forEach and map to work on NodeLists.
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-nodelist
For V8 we need to set a flag on the WrapperTypeInfo since V8 uses FunctionTemplates which
does not allow setting the prototype to a non FunctionTemplate so the prototype is therefore
set when the constructor is created.
For JSC we just pass the right prototype object when creating the NodeList prototype. JSC has
a bug (81588) that prevents toString to work as specced on Array.prototype.toString. This
causes test failures in the tests until that has been fixed.
Source/WebCore:
Test: fast/dom/NodeList/node-list-array-class.html
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Include ArrayPrototype.h if an ArrayClass.
(GenerateImplementation): If ArrayClass use arrayPrototype as prototype.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation): Adds a flag to the WrapperTypeInfo.
* bindings/scripts/IDLAttributes.txt:: Adds new attribute: ArrayClass.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::createPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::init): Get the array prototype too.
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): If this is an ArrayClass we need to
set the `[[Prototype]]`.
* bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/WrapperTypeInfo.h:
(WrapperTypeInfo):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* dom/NodeList.idl:
LayoutTests:
* fast/dom/HTMLSelectElement/named-options-expected.txt:
* fast/dom/HTMLSelectElement/script-tests/named-options.js:
* fast/dom/NodeList/node-list-array-class-expected.txt: Added.
* fast/dom/NodeList/node-list-array-class.html: Added.
* fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
* fast/dom/everything-to-string-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/js/recursion-limit-equal-expected.txt:
* inspector/console/command-line-api-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* jquery/traversing-expected.txt:
* platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Copied from LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt.
* platform/chromium/fast/dom/everything-to-string-expected.txt: Copied from LayoutTests/fast/dom/everything-to-string-expected.txt.
* platform/chromium/inspector/console/command-line-api-expected.txt: Copied from LayoutTests/inspector/console/command-line-api-expected.txt.
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/chromium/jquery/traversing-expected.txt: Copied from LayoutTests/jquery/traversing-expected.txt.
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 21:14:07 +0000 (21:14 +0000)]
[BlackBerry] Web Inspector cookie expiry is showing the wrong date.
https://bugs.webkit.org/show_bug.cgi?id=83814
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-12
Reviewed by Rob Buis.
The internal representation for expiry is seconds, we need to convert it
to milliseconds by multiplying by 1000.
The value from this method doesn't get used anywhere except Web Inspector.
Manually tested with Web Inspector by examining the CookieItemView in the Resources Panel.
* platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::appendWebCoreCookie):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 12 Apr 2012 21:11:37 +0000 (21:11 +0000)]
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256
Reviewed by Kentaro Hara.
This is an attempt to reland r112318, which was rolled out due to suspicion of OOM issues.
I've landed the refactoring bits of r112318 as separate changes,
so that this patch contains only the change in which map setter is called.
Binding tests have been updated with new output.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters): Call appropriate V8DOMWrapper::setJSWrapperFor*
to set up wrapper mapping and remove call to leakRef() which is handled
in V8DOMWrapper.
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 12 Apr 2012 21:09:48 +0000 (21:09 +0000)]
chromium windows + linux svg tests failing after r65665
https://bugs.webkit.org/show_bug.cgi?id=44278
Unreviewed Chromium test expectations update.
Looks like a result of the Skia switch plus some font adjustments.
* platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
* platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
* platform/chromium-mac/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-win/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-win/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 12 Apr 2012 21:06:50 +0000 (21:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=83817
This patch modifies RenderText so that it scans all of its characters up front to
determine whether or not the simple code path can be used for measurement/rendering
of the text for the whole run.
TextRun now has an additional field that indicates that the character scan is not
required, since the entire RenderText is known to be simple. This boolean is set
when constructing the TextRun from the places that make TextRuns from RenderTexts.
The character scan has been refactored into a static Font method so that it can be
called by RenderText. The scan of individual TextRuns is also done using the same method
so that the code is shared.
Reviewed by Dan Bernstein.
* platform/graphics/Font.cpp:
(WebCore::Font::codePath):
(WebCore::Font::characterRangeCodePath):
* platform/graphics/Font.h:
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::characterScanForCodePath):
(WebCore::TextRun::setCharacterScanForCodePath):
(TextRun):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::constructTextRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::textWidth):
* rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::width):
(WebCore::RenderText::computeCanUseSimpleFontCodePath):
(WebCore):
* rendering/RenderText.h:
(RenderText):
(WebCore::RenderText::canUseSimpleFontCodePath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 12 Apr 2012 20:56:47 +0000 (20:56 +0000)]
Make AccessibilityObject::size non-virtual and fix platform accessibility code's LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83803
Reviewed by Eric Seidel.
AccessibilityObject::size was virtual with a number of overloads, but all the implementations were
redundant. Avoiding the virtual thunk and code duplication by declaring it non-virtual and only
implementing it in AccessibilityObject.
Also adding a pixelSnappedSize method that returns an IntSize, and using it in platform
accessibility code.
No new tests. No change in behavior.
* accessibility/AccessibilityMenuListOption.h:
(WebCore::AccessibilityMenuListOption::canHaveChildren):
* accessibility/AccessibilityMenuListPopup.h:
(WebCore::AccessibilityMenuListPopup::elementRect):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::pixelSnappedSize):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilitySlider.cpp:
(WebCore):
* accessibility/AccessibilitySlider.h:
(AccessibilitySliderThumb):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore):
* accessibility/AccessibilityTableColumn.h:
(AccessibilityTableColumn):
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore):
* accessibility/AccessibilityTableHeaderContainer.h:
(AccessibilityTableHeaderContainer):
* accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:
(webkitAccessibleComponentGetExtents):
* accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImagePosition):
(webkitAccessibleImageGetImageSize):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 12 Apr 2012 20:55:09 +0000 (20:55 +0000)]
some clip paths broken on chromium win/linux after r65729
https://bugs.webkit.org/show_bug.cgi?id=44341
Unreviewed Chromium expectations update.
These tests are now matching the mac results, and the new results on
the bots look correct. Some changes are just font metric changes.
* platform/chromium-linux/svg/clip-path/clip-path-childs-clipped-expected.png:
* platform/chromium-linux/svg/clip-path/clip-path-pixelation-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
* platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
* platform/chromium-win/svg/clip-path/clip-path-childs-clipped-expected.png:
* platform/chromium-win/svg/clip-path/clip-path-pixelation-expected.png: Added.
* platform/chromium-win/svg/clip-path/clip-path-pixelation-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 12 Apr 2012 20:35:18 +0000 (20:35 +0000)]
ThreadingWin: Mutex::unlock() can be "over-unlocked".
https://bugs.webkit.org/show_bug.cgi?id=83725
Reviewed by David Levin.
In order to support the behavior of pthread_mutex_trylock(), the Windows Mutex class includes
a recursion counter which is incremented in Mutex::lock(), decremented in Mutex::unlock(),
and checked in Mutex::tryLock(). If the mutex is "over-unlocked", the counter wraps around to
MAX_INT, and subsequent calls to Mutex::trylock() will fail. Raise an ASSERT in this situation
so the "over-unlock" will be caught.
* wtf/ThreadingWin.cpp:
(WTF::Mutex::unlock): ASSERT if unlocking a non-locked mutex.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 12 Apr 2012 20:31:51 +0000 (20:31 +0000)]
[Chromium] filters/feDisplacementMap.svg crossHatch pattern improperly drawn
https://bugs.webkit.org/show_bug.cgi?id=83810
Unreviewed Chromium expectations update.
These test results match Firefox, and I see no reason to believe they
are incorrect.
* platform/chromium-linux-x86/svg/filters/feDisplacementMap-expected.png: Added.
* platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Added.
* platform/chromium-win-vista/svg/filters/feDisplacementMap-expected.png: Added.
* platform/chromium-win-xp/svg/filters/feDisplacementMap-expected.png: Added.
* platform/chromium-win/svg/filters/feDisplacementMap-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
annacc@chromium.org [Thu, 12 Apr 2012 20:29:50 +0000 (20:29 +0000)]
Update HTMLMediaElement's index of cues when TextTrack.mode changes to
and from TextTrack::DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=83377
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. Instead updated media/track/track-mode.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackModeChanged):
Add the track's cues to the index when the mode changes to HIDDEN or SHOWING.
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::textTrackRemoveCues):
Fix a copy pasta error.
* html/track/TextTrack.cpp:
(WebCore::TextTrack::setMode):
Remove the track's cues from the index when the mode changes to DISABLED.
LayoutTests:
* media/track/track-mode-expected.txt:
* media/track/track-mode.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 20:26:49 +0000 (20:26 +0000)]
Unreviewed, rolling out r114005.
http://trac.webkit.org/changeset/114005
https://bugs.webkit.org/show_bug.cgi?id=83809
This patch may have unveiled other bugs, need to investigate
(Requested by vrk on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12
* media/video-seek-past-end-paused-expected.txt:
* media/video-seek-past-end-paused.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 20:23:30 +0000 (20:23 +0000)]
Allow certain Char events in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=83330
Patch by Cem Kocagil <cem.kocagil@gmail.com> on 2012-04-12
Reviewed by Alexey Proskuryakov.
* page/EventHandler.cpp:
(WebCore::EventHandler::isKeyEventAllowedInFullScreen):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 12 Apr 2012 20:04:06 +0000 (20:04 +0000)]
Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509
Unreviewed Chromium expectations update (after all this time).
* platform/chromium-win/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 20:01:22 +0000 (20:01 +0000)]
IndexedDB: Attributes for a cursor "run past the end" should be undefined.
https://bugs.webkit.org/show_bug.cgi?id=83492
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-12
Reviewed by Ojan Vafai.
Source/WebCore:
This brings us up to spec with respect to when it's ok to call
cursor.continue() and the various behaviors around it:
If you call it more than once, continue() throws an exception.
The values of key/primaryKey/value are consistent, whether or not
continue has been called, meaning that if continue() results in
data being loaded from the backing store, that data does not
affect the cursor until the success callback has completed.
Calls to update() and delete() can happen before continue(), but
not afterwards.
Test: storage/indexeddb/cursor-continue-validity.html
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):
(WebCore::IDBCursor::setGotValue):
(WebCore):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
LayoutTests:
* storage/indexeddb/cursor-continue-validity-expected.txt: Added.
* storage/indexeddb/cursor-continue-validity.html: Added.
* storage/indexeddb/resources/cursor-continue-validity.js: Added.
* storage/indexeddb/resources/mozilla/cursors-expected.txt:
* storage/indexeddb/resources/shared.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Thu, 12 Apr 2012 19:58:10 +0000 (19:58 +0000)]
Media engine should not be told to prepare for playback if media loading is not allowed
https://bugs.webkit.org/show_bug.cgi?id=83620
Reviewed by Dan Bernstein.
Source/WebCore:
Test: media/video-load-require-user-gesture.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load): Early return if user gesture requirement is not met.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setMediaPlaybackRequiresUserGesture): Moved the method here from
Internals to be with the rest of the Internals methods that expose preferences.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
* testing/Internals.cpp: Moved setMediaPlaybackRequiresUserGesture to InternalSettings.
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
* media/video-load-require-user-gesture-expected.txt: Added.
* media/video-load-require-user-gesture.html: Added.
* media/video-play-require-user-gesture.html: Update for move of setMediaPlaybackRequiresUserGesture
from window.internals to window.internals.settings.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 19:54:21 +0000 (19:54 +0000)]
[CSS Exclusions] Add flag to enable / disable exclusions at runtime
https://bugs.webkit.org/show_bug.cgi?id=83313
Patch by Bear Travis <betravis@adobe.com> on 2012-04-12
Reviewed by Ryosuke Niwa.
.:
Adding the GTK symbols
* Source/autotools/symbols.filter:
Source/WebCore:
Adding setCSSExclusionsEnabled/cssExclusionsEnabled that is true by default.
The CSS parser will not accept values for the exclusions properties when
cssExclusionsEnabled is false. However, you will still get the default value
in the computed style.
Test: fast/exclusions/css-exclusions-disabled.html
* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(RuntimeEnabledFeatures):
* css/CSSParser.cpp:
(WebCore::isSimpleLengthValue):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
Source/WebKit2:
Adding windows symbols
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
Adding a test to cover CSS parsing, which is the only piece of exclusions
work in place. Updating other exclusions test to explicitly enable the
feature.
* fast/exclusions/css-exclusions-disabled-expected.txt: Added.
* fast/exclusions/css-exclusions-disabled.html: Added.
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
* fast/exclusions/script-tests/wrap-flow-parsing.js:
* fast/exclusions/script-tests/wrap-margin-parsing.js:
* fast/exclusions/script-tests/wrap-padding-parsing.js:
* fast/exclusions/script-tests/wrap-parsing.js:
* fast/exclusions/script-tests/wrap-through-parsing.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 12 Apr 2012 19:50:46 +0000 (19:50 +0000)]
[Chromium] Layout test svg/text/font-size-below-point-five.svg needs rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83806
Unreviewed Chromium test expectations update.
* platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
* platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.png: Added.
* platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/text/font-size-below-point-five-expected.png: Removed.
* platform/chromium-mac/svg/text/font-size-below-point-five-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 12 Apr 2012 19:35:09 +0000 (19:35 +0000)]
Add fast/frames/flattening/frameset-flattening-simple.html to the Skipped list.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Thu, 12 Apr 2012 19:27:36 +0000 (19:27 +0000)]
[Chromium] LayoutTest update for several Mac filter tests
https://bugs.webkit.org/show_bug.cgi?id=83717
Unreviewed Chromium test expectations update.
Second attempt, now leaving some tests as flakey.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Thu, 12 Apr 2012 19:27:28 +0000 (19:27 +0000)]
Move Archive processing to DocumentLoader, instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=83055
Reviewed by Adam Barth.
No new tests, no functionality change intended.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::maybeCreateArchive): Renamed from
FrameLoader::finishedLoadingDocument(). Returns true if an archive
was created.
(WebCore::DocumentLoader::setArchive):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL): Add a check for whether an archive url
should be returned, so that we don't need special handling in Document and
FrameLoader for overriding the document url later.
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData): Remove archive special cases, since
DocumentLoader::documentURL() will return the right thing for legacy archives
and maybeCreateArchive() will override the base url for mhtml.
(WebCore::FrameLoader::loadArchive):
* loader/FrameLoader.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 12 Apr 2012 19:23:58 +0000 (19:23 +0000)]
Update test results after r113945.
* fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 12 Apr 2012 19:19:13 +0000 (19:19 +0000)]
test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
https://bugs.webkit.org/show_bug.cgi?id=83583
Reviewed by Philippe Normand
Updated the unit test to ignore the hours and minutes of the
localtime for time(0), since we can't easily guarantee which
timezone we're in or what timezone rules were in effect on
1/1/1970; this should be mostly fine since we can trust that
time.localtime() will work, although there is the possibility
that we'll screw up the time formatting of which field is the
hours and which is the minutes.
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(VerboseTest):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Thu, 12 Apr 2012 19:16:49 +0000 (19:16 +0000)]
Source/WebCore: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Due to incorrect merge by me when landing r113233, call to find got replaces with call to add in
checking for duplicates in ObjectPool when serializing.
Reviewed by Dean Jackson.
Covered by existing tests.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::checkForDuplicate):
LayoutTests: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Bug fixed, unskipping tests.
Reviewed by Dean Jackson.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 19:07:07 +0000 (19:07 +0000)]
Don't modify shared style objects in RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=83736
Patch by David Barton <dbarton@mathscribe.com> on 2012-04-12
Reviewed by Julien Chaffraix.
Source/WebCore:
To leave room for the radical sign and absolutely positioned "index", we switch to using
intrinsic padding. RenderMathMLRoot.cpp is also cleaned up and prepared for merging with
RenderMathMLSquareRoot.cpp. The base and index are no longer wrapped in extra renderers,
and the child renderers are now in the same order as in the DOM. Some padding/placement
terms are unified and debugged.
Tested by existing tests in roots.xhtml.
* css/mathml.css:
(mroot):
(mroot > * + *):
(mroot > * + mrow, mroot > * + mfenced):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore):
(WebCore::RenderMathMLRoot::index):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):
* rendering/mathml/RenderMathMLRoot.h:
(RenderMathMLRoot):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore):
(WebCore::RenderMathMLSquareRoot::paint):
LayoutTests:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 19:03:38 +0000 (19:03 +0000)]
[BlackBerry] Web Inspector messages incorrectly converted
https://bugs.webkit.org/show_bug.cgi?id=83796
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-12
Reviewed by Rob Buis.
The JSON sent over from the remote Web Inspector front-end was being
mis interpreted as ISO-8859-1. This caused all non ascii characters to
become garbled when using the String constructor, so we use fromtUTF8 instead.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tsepez@chromium.org [Thu, 12 Apr 2012 18:57:22 +0000 (18:57 +0000)]
Typos in LayoutTests/http/tests/security/xssAuditor/script-tag-inside-svg-tag*.html
https://bugs.webkit.org/show_bug.cgi?id=83794
Reviewed by Adam Barth.
Several changes needed to make the XSS in these test cases fire against actual
vulnerable browsers. The tests were still valid, but it is more helpful to see
the XSS pop up.
* http/tests/security/xssAuditor/script-tag-inside-svg-tag.html:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html:
* http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 12 Apr 2012 18:54:22 +0000 (18:54 +0000)]
Remove unused WebKit1 SPI for suppressing incremental rendering.
https://bugs.webkit.org/show_bug.cgi?id=83801
Reviewed by Simon Fraser.
This SPI is unused and has been replaced by API ([setS|s]uppressesIncrementalRendering).
* WebView/WebPreferences.mm:
* WebView/WebPreferencesPrivate.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 12 Apr 2012 18:51:21 +0000 (18:51 +0000)]
Unreviewed, GTK test_expectations.
* platform/gtk/test_expectations.txt: Flaky tests list update.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 12 Apr 2012 18:32:41 +0000 (18:32 +0000)]
Build fix.
* page/mac/SettingsMac.mm:
(WebCore::defaultFontFamilyDictionary):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 12 Apr 2012 18:28:55 +0000 (18:28 +0000)]
Remove style sheet argument from StyleRuleImport constructor
https://bugs.webkit.org/show_bug.cgi?id=83740
Reviewed by Andreas Kling.
The style sheet is set when the rule is added to one. The parser does not need to know about it.
* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::StyleRuleImport):
* css/CSSImportRule.h:
(StyleRuleImport):
(WebCore::StyleRuleImport::setParentStyleSheet):
* css/CSSParser.cpp:
(WebCore::CSSParser::createImportRule):
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vrk@chromium.org [Thu, 12 Apr 2012 18:24:52 +0000 (18:24 +0000)]
Remove setTimeout from media/video-seek-past-end-paused.html and fix other minor issues
https://bugs.webkit.org/show_bug.cgi?id=83505
The test had an arbitrary performance expectation to start playing in 200 ms,
which caused the layout test to fail for Chromium when the Chromium's
audio buffer size increased.
This CL removes that expectation and fixes some HTML and grammar mistakes.
Reviewed by Eric Carlson.
* media/video-seek-past-end-paused-expected.txt:
* media/video-seek-past-end-paused.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 12 Apr 2012 18:11:28 +0000 (18:11 +0000)]
REGRESSION (r113900): In nightly builds, Safari Webpage Preview Fetcher crashes in Settings::initializeDefaultFontFamilies() due to uncaught exception (sandbox preventing access to fonts plist)
https://bugs.webkit.org/show_bug.cgi?id=83792
<rdar://problem/
11234002>
Reviewed by Dan Bernstein.
* page/mac/SettingsMac.mm: (WebCore::defaultFontFamilyDictionary): Bail out without setting
font preferences if the process doesn't have read access to WebCore.framework.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 18:10:52 +0000 (18:10 +0000)]
Add an EFL Debug Buildbot to the master configuration
https://bugs.webkit.org/show_bug.cgi?id=82711
Forgot to add EFL Linux Debug to scheduler.
Patch by Dominik Rottsches <dominik.rottsches@linux.intel.com> on 2012-04-12
Reviewed by Philippe Normand.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
efidler@rim.com [Thu, 12 Apr 2012 17:47:48 +0000 (17:47 +0000)]
[BlackBerry] Set up default fonts for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=83775
Reviewed by Antonio Gomes.
* PlatformBlackBerry.cmake:
* page/Settings.cpp:
(WebCore):
* page/blackberry/SettingsBlackBerry.cpp: Added.
(WebCore):
(WebCore::Settings::initializeDefaultFontFamilies):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 12 Apr 2012 17:23:45 +0000 (17:23 +0000)]
Implement Dictionary.h on mac (83472)
https://bugs.webkit.org/show_bug.cgi?id=83472
<rdar://problem/
11209766>
Reviewed by Kentaro Hara.
A difference between Dictionary and JSDictionary makes it difficult to merge the two together and avoid
creating a confusing API. The boolean returned by Dictionary::get() represents whether the
property was found. The boolean returned by JSDictionary::tryGetProperty() represents whether an
exception was thrown.
* WebCore.xcodeproj/project.pbxproj: Add Dictionary.h and Dictionary.cpp.
* bindings/js/Dictionary.cpp: Added.
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::get):
* bindings/js/Dictionary.h: Leverage JSDictionary's functionality to obtain the data.
(WebCore::Dictionary::isObject): Mark an unimplemented.
(WebCore::Dictionary::isUndefinedOrNull): Mark an unimplemented.
(WebCore::Dictionary::getWithUndefinedOrNullCheck): Mark an unimplemented.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::tryGetProperty): Convert to a const function.
* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::isValid):
(WebCore::JSDictionary::tryGetProperty): Convert to a const function.
(WebCore::JSDictionary::get): Similar to tryGetProperty(), but returns true if the
property was found, converting the value succeeded and the out parameter "result" was set.
(WebCore::JSDictionary::tryGetPropertyAndResult): Refactor tryGetProperty() to return the enum directly.
Change bindings scripts to use Dictionary constructor.
* bindings/js/IDBBindingUtilities.cpp: Remove createDictionaryFromValue().
* bindings/js/IDBBindingUtilities.h: Remove createDictionaryFromValue().
* bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative): Update to remove IDBBindingUtilities.h dependency, and use Dictionary constructor.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Update expected generated output.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 17:16:46 +0000 (17:16 +0000)]
[chromium] Fix threaded compositor HUD crash
https://bugs.webkit.org/show_bug.cgi?id=83778
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-12
Reviewed by James Robinson.
Don't try to read font metrics in threaded compositing mode, since we
currently can't render HUD text with the threaded compositor.
HUD is not testable in WebKit.
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::drawHudContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 12 Apr 2012 17:09:02 +0000 (17:09 +0000)]
Unreviewed, GTK test_expectations.
* platform/gtk/test_expectations.txt: Marking 2 media tests flaky.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 17:02:51 +0000 (17:02 +0000)]
[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83713
Patch by David Alcala <dalcala@adobe.com> on 2012-04-12
Reviewed by Dirk Schulze.
* fast/regions/region-overflow-break-expected.html: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-break-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-break-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-break-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-break-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 12 Apr 2012 17:02:38 +0000 (17:02 +0000)]
Add an EFL Debug Buildbot to the master configuration
https://bugs.webkit.org/show_bug.cgi?id=82711
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-12
Reviewed by Philippe Normand.
Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
* BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc