platform/upstream/ninja.git
10 years agoMerge pull request #790 from nico/relnotes2
Nico Weber [Fri, 27 Jun 2014 20:37:11 +0000 (13:37 -0700)]
Merge pull request #790 from nico/relnotes2

expand RELEASING a bit

10 years agoexpand RELEASING a bit
Nico Weber [Fri, 27 Jun 2014 20:29:16 +0000 (13:29 -0700)]
expand RELEASING a bit

10 years agomark this 1.5.0.git, update RELEASING
Nico Weber [Fri, 27 Jun 2014 20:15:57 +0000 (13:15 -0700)]
mark this 1.5.0.git, update RELEASING

10 years agoMerge pull request #789 from nico/dontwin
Nico Weber [Fri, 27 Jun 2014 20:07:54 +0000 (13:07 -0700)]
Merge pull request #789 from nico/dontwin

Rename -d nowinstatcache to -d nostatcache; might become useful elsewhere (#787)

10 years agoRename -d nowinstatcache to -d nostatcache; might become useful elsewhere (#787)
Nico Weber [Fri, 27 Jun 2014 20:03:41 +0000 (13:03 -0700)]
Rename -d nowinstatcache to -d nostatcache; might become useful elsewhere (#787)

10 years agoMerge pull request #786 from donkopotamus/patch-1
Nico Weber [Thu, 26 Jun 2014 05:12:01 +0000 (22:12 -0700)]
Merge pull request #786 from donkopotamus/patch-1

Update ninja-mode for emacs to handle hyphens in rule names

10 years agoUpdate ninja-mode for emacs to handle hyphens in rule names
donkopotamus [Thu, 26 Jun 2014 04:34:35 +0000 (16:34 +1200)]
Update ninja-mode for emacs to handle hyphens in rule names

10 years agoMerge pull request #785 from nico/unused
Nico Weber [Wed, 25 Jun 2014 00:57:28 +0000 (17:57 -0700)]
Merge pull request #785 from nico/unused

Fix -Wunused-result warning for chdir on linux.

10 years agoFix -Wunused-result warning for chdir on linux.
Nico Weber [Wed, 25 Jun 2014 00:49:22 +0000 (17:49 -0700)]
Fix -Wunused-result warning for chdir on linux.

10 years agoMerge pull request #784 from nico/statkeep
Nico Weber [Fri, 20 Jun 2014 14:30:10 +0000 (07:30 -0700)]
Merge pull request #784 from nico/statkeep

do not delete files from the logs that still exist on disk

10 years agodo not delete files from the logs that still exist on disk
Nico Weber [Thu, 19 Jun 2014 23:09:50 +0000 (16:09 -0700)]
do not delete files from the logs that still exist on disk

This is to keep the possibility of maybe having a tool that deletes
old files in the future, or for having a tool which exposes this
information to generators so they can do that.

See https://github.com/martine/ninja/pull/697#issuecomment-37140762
and the discussion on #762.

Idea from @maximuska!

10 years agomake Stat() a const method
Nico Weber [Thu, 19 Jun 2014 23:00:35 +0000 (16:00 -0700)]
make Stat() a const method

10 years agoMerge pull request #783 from sgraham/findexinfobasic
Nico Weber [Thu, 19 Jun 2014 19:21:33 +0000 (12:21 -0700)]
Merge pull request #783 from sgraham/findexinfobasic

use local definition of FindExInfoBasic for earlier sdks

10 years agouse local definition of FindExInfoBasic for earlier sdks
Scott Graham [Thu, 19 Jun 2014 18:22:44 +0000 (11:22 -0700)]
use local definition of FindExInfoBasic for earlier sdks

10 years agoMerge pull request #782 from sgraham/warning-on-81sdk
Nico Weber [Mon, 16 Jun 2014 18:11:00 +0000 (11:11 -0700)]
Merge pull request #782 from sgraham/warning-on-81sdk

suppress warning on win8.1 sdk

10 years agosuppress warning on win8.1 sdk
Scott Graham [Mon, 16 Jun 2014 17:56:24 +0000 (10:56 -0700)]
suppress warning on win8.1 sdk

10 years agoMerge pull request #781 from nico/cleaner
Nico Weber [Mon, 16 Jun 2014 17:33:23 +0000 (10:33 -0700)]
Merge pull request #781 from nico/cleaner

simplify statcache code more

10 years agosimplify statcache code more
Nico Weber [Mon, 16 Jun 2014 17:27:10 +0000 (10:27 -0700)]
simplify statcache code more

10 years agoMerge pull request #780 from nico/versioncheck
Nico Weber [Mon, 16 Jun 2014 17:10:04 +0000 (10:10 -0700)]
Merge pull request #780 from nico/versioncheck

only use FindExInfoBasic on win7+

10 years agoonly use FindExInfoBasic on win7+
Nico Weber [Mon, 16 Jun 2014 16:59:16 +0000 (09:59 -0700)]
only use FindExInfoBasic on win7+

10 years agoMerge pull request #779 from nico/statcache
Nico Weber [Sun, 15 Jun 2014 23:01:49 +0000 (16:01 -0700)]
Merge pull request #779 from nico/statcache

Use FindFirstFileEx() for stat()ing files on Windows.

10 years agos/hFind/find_handle/
Nico Weber [Sun, 15 Jun 2014 23:00:13 +0000 (16:00 -0700)]
s/hFind/find_handle/

10 years agoadd missing _WIN32 checks
Nico Weber [Sun, 15 Jun 2014 22:26:37 +0000 (15:26 -0700)]
add missing _WIN32 checks

10 years agomake bool exist everywhere, for simpler calling code
Nico Weber [Sun, 15 Jun 2014 22:16:50 +0000 (15:16 -0700)]
make bool exist everywhere, for simpler calling code

10 years agoadd some statcache tests
Nico Weber [Sun, 15 Jun 2014 21:42:42 +0000 (14:42 -0700)]
add some statcache tests

10 years agoFree cache memory once it's no longer used.
Nico Weber [Sun, 15 Jun 2014 21:11:27 +0000 (14:11 -0700)]
Free cache memory once it's no longer used.

Doesn't slow down empty build times measurably, and
saves some memory on non-empty builds.

10 years agoerror checking
Nico Weber [Sun, 15 Jun 2014 05:18:28 +0000 (22:18 -0700)]
error checking

10 years agoon by default
Nico Weber [Sun, 15 Jun 2014 05:11:31 +0000 (22:11 -0700)]
on by default

10 years agocomment
Nico Weber [Sun, 15 Jun 2014 05:07:04 +0000 (22:07 -0700)]
comment

10 years agomake win-only
Nico Weber [Sun, 15 Jun 2014 05:05:09 +0000 (22:05 -0700)]
make win-only

10 years agosimplify more, move behind flag
Nico Weber [Sun, 15 Jun 2014 04:50:05 +0000 (21:50 -0700)]
simplify more, move behind flag

10 years agomore minor cleanups
Nico Weber [Sun, 15 Jun 2014 04:38:44 +0000 (21:38 -0700)]
more minor cleanups

10 years agomore minor cleanups
Nico Weber [Sun, 15 Jun 2014 04:36:30 +0000 (21:36 -0700)]
more minor cleanups

10 years agominor cleanups
Nico Weber [Sun, 15 Jun 2014 04:29:18 +0000 (21:29 -0700)]
minor cleanups

10 years agoTurn on stat cache. Empty builds of chrome on my laptop 4s -> 1.3s (!)
Nico Weber [Sun, 25 May 2014 04:36:57 +0000 (21:36 -0700)]
Turn on stat cache. Empty builds of chrome on my laptop 4s -> 1.3s (!)

10 years agoAdd a stat cache. Demo-quality, and disabled atm.
Nico Weber [Sun, 25 May 2014 04:17:35 +0000 (21:17 -0700)]
Add a stat cache. Demo-quality, and disabled atm.

10 years agoMerge pull request #778 from nico/spellrsp
Nico Weber [Sun, 15 Jun 2014 05:50:54 +0000 (22:50 -0700)]
Merge pull request #778 from nico/spellrsp

spellcheck "keeprsp" in -d options

10 years agospellcheck "keeprsp" in -d options
Nico Weber [Sun, 15 Jun 2014 05:49:01 +0000 (22:49 -0700)]
spellcheck "keeprsp" in -d options

10 years agoMerge pull request #777 from nico/winconf
Nico Weber [Sun, 15 Jun 2014 05:47:27 +0000 (22:47 -0700)]
Merge pull request #777 from nico/winconf

create a slightly nicer build.ninja on windows

10 years agocreate a slightly nicer build.ninja on windows
Nico Weber [Sun, 15 Jun 2014 05:47:05 +0000 (22:47 -0700)]
create a slightly nicer build.ninja on windows

10 years agoVersion 1.4 of the vim syntax file was merged.
Nico Weber [Thu, 12 Jun 2014 20:22:35 +0000 (13:22 -0700)]
Version 1.4 of the vim syntax file was merged.

See https://code.google.com/p/vim/source/detail?r=92751673cc37c9ef4d1ad1ac4d42d36faa67f88f

10 years agoMerge pull request #770 from debfx/master
Evan Martin [Fri, 30 May 2014 23:24:28 +0000 (16:24 -0700)]
Merge pull request #770 from debfx/master

Use unversioned \ 1gnukfreebsd platform.

10 years agoUse unversioned \ 1gnukfreebsd platform.
Felix Geyer [Fri, 30 May 2014 20:59:02 +0000 (22:59 +0200)]
Use unversioned \ 1gnukfreebsd platform.

10 years agoMerge pull request #769 from nico/plus
Nico Weber [Fri, 30 May 2014 17:41:45 +0000 (10:41 -0700)]
Merge pull request #769 from nico/plus

Allow + in filenames without escaping

10 years agoAllow + in filenames without escaping
Nico Weber [Fri, 30 May 2014 01:14:48 +0000 (03:14 +0200)]
Allow + in filenames without escaping

Due to #690, file.c++ used to be escaped. + seems as safe as -, so allow
it to not be escaped, to keep compile command lines with a fairly common
extension slightly cleaner.

10 years agoMerge pull request #768 from nico/vimsyn
Nico Weber [Fri, 30 May 2014 00:58:33 +0000 (17:58 -0700)]
Merge pull request #768 from nico/vimsyn

vim syntax: Correctly highlight $$a as ($$)a instead of $($a).

10 years agoMerge pull request #767 from nico/esc_deprspfile
Nico Weber [Thu, 29 May 2014 23:58:09 +0000 (16:58 -0700)]
Merge pull request #767 from nico/esc_deprspfile

Make "depfile=$out.d" work if $out contains escaped characters, rspfile ...

10 years agoreword manual for depfile/rspfile escaping change
Nico Weber [Sat, 24 May 2014 22:52:52 +0000 (15:52 -0700)]
reword manual for depfile/rspfile escaping change

10 years agoMake "depfile=$out.d" work if $out contains escaped characters, rspfile too.
Nico Weber [Wed, 21 May 2014 22:07:47 +0000 (15:07 -0700)]
Make "depfile=$out.d" work if $out contains escaped characters, rspfile too.

Fixes #730.  This has always been broken, but due to #690 more paths are now
escaped (e.g. paths containing + characters, like file.c++).  Also see
discussion in #689.

The approach is to give EdgeEnv an enum deciding on whether or not to escape
file names, and provide functions that evaluate depfile and rspfile with that
set that to kNoEscape.  (depfile=$out.d doesn't make sense on edges with
multiple outputs.)

This should be relatively safe, as $in and $out can't be used on edges, only
on rules (#687).

10 years agoMerge pull request #766 from nico/cleanup
Nico Weber [Wed, 21 May 2014 21:17:44 +0000 (14:17 -0700)]
Merge pull request #766 from nico/cleanup

CleanTest cleanups:

10 years agoCleanTest cleanups:
Nico Weber [Wed, 21 May 2014 21:16:18 +0000 (14:16 -0700)]
CleanTest cleanups:
* $in only makes sense on rules, not edges (see issue #687)
* Remove unneccesary clear() line at end of test

10 years agoMerge pull request #764 from nico/winconsole
Nico Weber [Sun, 18 May 2014 22:17:44 +0000 (15:17 -0700)]
Merge pull request #764 from nico/winconsole

Implement pool=console support on Windows.

10 years agowin console wip: Fix comments based on review feedback.
Nico Weber [Sun, 18 May 2014 00:20:20 +0000 (17:20 -0700)]
win console wip: Fix comments based on review feedback.

10 years agowin console wip: resolve FIXME
Nico Weber [Wed, 14 May 2014 10:00:34 +0000 (03:00 -0700)]
win console wip: resolve FIXME

10 years agovim syntax: Correctly highlight $$a as ($$)a instead of $($a).
Nico Weber [Tue, 13 May 2014 21:51:51 +0000 (23:51 +0200)]
vim syntax: Correctly highlight $$a as ($$)a instead of $($a).

10 years agowin console wip: ctrl-c should reach commands running in console pools
Nico Weber [Tue, 13 May 2014 19:58:01 +0000 (12:58 -0700)]
win console wip: ctrl-c should reach commands running in console pools

10 years agowin console wip: enable test
Nico Weber [Tue, 13 May 2014 19:47:08 +0000 (12:47 -0700)]
win console wip: enable test

10 years agowip for console pool on windows
Nico Weber [Tue, 13 May 2014 19:35:52 +0000 (12:35 -0700)]
wip for console pool on windows

10 years agoMerge pull request #761 from maximuska/proposed/depfile_parser_fixes
Nico Weber [Thu, 8 May 2014 00:11:37 +0000 (17:11 -0700)]
Merge pull request #761 from maximuska/proposed/depfile_parser_fixes

Allow paths with '{' '}' in depfiles

10 years agoAllow paths with '{' '}' in depfiles
Maxim Kalaev [Wed, 7 May 2014 17:56:32 +0000 (20:56 +0300)]
Allow paths with '{' '}' in depfiles

10 years agoMerge pull request #756 from ronnychevalier/rc/zsh_completion
Nico Weber [Mon, 5 May 2014 22:54:26 +0000 (15:54 -0700)]
Merge pull request #756 from ronnychevalier/rc/zsh_completion

improve zsh completion

10 years agoMerge pull request #758 from mathstuf/dev/fix-compdb-abort
Nico Weber [Mon, 5 May 2014 22:51:11 +0000 (15:51 -0700)]
Merge pull request #758 from mathstuf/dev/fix-compdb-abort

compdb: check that inputs is not empty

10 years agocompdb: check that inputs is not empty
Ben Boeckel [Mon, 5 May 2014 19:00:26 +0000 (15:00 -0400)]
compdb: check that inputs is not empty

10 years agoMerge pull request #757 from cjdrake/master
Nico Weber [Mon, 5 May 2014 03:25:57 +0000 (20:25 -0700)]
Merge pull request #757 from cjdrake/master

Stylistic changes to ninja_syntax.py

10 years agoGet rid of unused import
Chris Drake [Mon, 5 May 2014 01:35:28 +0000 (18:35 -0700)]
Get rid of unused import

10 years agoUse consistent indentation conventions
Chris Drake [Mon, 5 May 2014 01:34:55 +0000 (18:34 -0700)]
Use consistent indentation conventions

10 years agoimprove zsh completion
Ronny Chevalier [Sun, 4 May 2014 02:55:40 +0000 (04:55 +0200)]
improve zsh completion

10 years agoMerge pull request #753 from nico/nlacc
Nico Weber [Thu, 1 May 2014 15:50:21 +0000 (08:50 -0700)]
Merge pull request #753 from nico/nlacc

Accept \r\n line endings in depfiles.

10 years agoAccept \r\n line endings in depfiles.
Nico Weber [Thu, 1 May 2014 03:46:12 +0000 (20:46 -0700)]
Accept \r\n line endings in depfiles.

Fixes #752.

10 years agoMerge pull request #748 from nocnokneo/bash-completion-for-f-and-C
Nico Weber [Wed, 30 Apr 2014 19:10:54 +0000 (12:10 -0700)]
Merge pull request #748 from nocnokneo/bash-completion-for-f-and-C

Support completion of arguments to -f and -C options

10 years agoFix getopts barfing over the terminal when trying to complete -f and -C
Taylor Braun-Jones [Sun, 27 Apr 2014 22:31:40 +0000 (18:31 -0400)]
Fix getopts barfing over the terminal when trying to complete -f and -C

Note that this is only applicable for when bash_completion is
unavailable.

10 years agoSupport completion of arguments to -f and -C options
Taylor Braun-Jones [Fri, 25 Apr 2014 18:20:42 +0000 (14:20 -0400)]
Support completion of arguments to -f and -C options

Note: This is only available for bash_completion users.

10 years agoMerge pull request #750 from nico/perfwin
Nico Weber [Sun, 27 Apr 2014 19:57:56 +0000 (12:57 -0700)]
Merge pull request #750 from nico/perfwin

Make manifest_parser_perftest build on Windows.

10 years agoMake manifest_parser_perftest build on Windows.
Nico Weber [Sun, 27 Apr 2014 19:57:25 +0000 (12:57 -0700)]
Make manifest_parser_perftest build on Windows.

10 years agoMerge pull request #747 from nocnokneo/master
Nico Weber [Fri, 25 Apr 2014 21:06:03 +0000 (14:06 -0700)]
Merge pull request #747 from nocnokneo/master

Fix bash-completion support for -C option to expand tilde

10 years agoStyle: Fix inconsistent indentation
Taylor Braun-Jones [Fri, 25 Apr 2014 17:59:53 +0000 (13:59 -0400)]
Style: Fix inconsistent indentation

10 years agoFix bash-completion support for -C option to expand tilde
Taylor Braun-Jones [Fri, 25 Apr 2014 17:50:09 +0000 (13:50 -0400)]
Fix bash-completion support for -C option to expand tilde

10 years agoMerge pull request #714 from pcc/console-pool
Nico Weber [Thu, 17 Apr 2014 18:46:21 +0000 (11:46 -0700)]
Merge pull request #714 from pcc/console-pool

Introduce the "console" pool

10 years agoMerge pull request #715 from nico/lazyenv
Nico Weber [Thu, 17 Apr 2014 05:28:53 +0000 (22:28 -0700)]
Merge pull request #715 from nico/lazyenv

Allocate per-edge BindingEnvs lazily.

10 years agoMerge pull request #742 from nico/maniperf
Nico Weber [Thu, 17 Apr 2014 05:17:52 +0000 (22:17 -0700)]
Merge pull request #742 from nico/maniperf

Add a manifest parsing perftest.

10 years agoManifest perftest: Try to make it build on Linux.
Nico Weber [Thu, 17 Apr 2014 05:15:09 +0000 (22:15 -0700)]
Manifest perftest: Try to make it build on Linux.

10 years agoManifest perftest: Pull manifest parsing into own function.
Nico Weber [Thu, 17 Apr 2014 05:12:30 +0000 (22:12 -0700)]
Manifest perftest: Pull manifest parsing into own function.

10 years agoAdd manifest_parser_perftest to .gitignore.
Nico Weber [Thu, 17 Apr 2014 05:06:34 +0000 (22:06 -0700)]
Add manifest_parser_perftest to .gitignore.

10 years agoManifest perftest: Also measure command evaluation time.
Nico Weber [Thu, 17 Apr 2014 05:05:32 +0000 (22:05 -0700)]
Manifest perftest: Also measure command evaluation time.

10 years agoAdd a simple manifest parsing perftest.
Nico Weber [Thu, 17 Apr 2014 04:56:49 +0000 (21:56 -0700)]
Add a simple manifest parsing perftest.

10 years agoMerge pull request #741 from nicolasdespres/propagate-file-rename-to-gitignore
Nico Weber [Wed, 16 Apr 2014 17:02:26 +0000 (10:02 -0700)]
Merge pull request #741 from nicolasdespres/propagate-file-rename-to-gitignore

Propagate file rename to gitignore.

10 years agoPropagate file rename to gitignore.
Nicolas Despres [Wed, 16 Apr 2014 06:24:38 +0000 (08:24 +0200)]
Propagate file rename to gitignore.

This was introduced by 68a4bb27d1a747b240ea68cd320a51dbd261ed14.

10 years agoMerge pull request #740 from nico/formatfile
Nico Weber [Wed, 16 Apr 2014 05:09:23 +0000 (22:09 -0700)]
Merge pull request #740 from nico/formatfile

Add a .clang-format file.

10 years agoAdd a .clang-format file.
Nico Weber [Wed, 16 Apr 2014 05:06:01 +0000 (22:06 -0700)]
Add a .clang-format file.

This isn't meant to be authoritative. It's good enough to let the
"indent current line using clang-format" hotkey do the right thing often
enough to be useful.

10 years agoMerge pull request #739 from nico/ren
Nico Weber [Wed, 16 Apr 2014 00:47:28 +0000 (17:47 -0700)]
Merge pull request #739 from nico/ren

Rename parser_perftest to depfile_parser_perftest.

10 years agoRename parser_perftest to depfile_parser_perftest.
Nico Weber [Wed, 16 Apr 2014 00:43:03 +0000 (17:43 -0700)]
Rename parser_perftest to depfile_parser_perftest.

10 years agoMerge pull request #737 from sorbits/bash-completion-fixes
Nico Weber [Tue, 15 Apr 2014 19:00:01 +0000 (12:00 -0700)]
Merge pull request #737 from sorbits/bash-completion-fixes

Bash completion fixes

10 years agoExpand the -C argument via ‘eval’ in bash completion
Allan Odgaard [Tue, 15 Apr 2014 07:27:37 +0000 (14:27 +0700)]
Expand the -C argument via ‘eval’ in bash completion

Previously completion would not work for ‘ninja -C $HOME/Source/foo targ‸’.

We still do not support using tilde in the directory argument.

10 years agoFix bash completion when using command options
Allan Odgaard [Tue, 15 Apr 2014 07:23:47 +0000 (14:23 +0700)]
Fix bash completion when using command options

By quoting the ‘line’ variable we are making it a single word, but ‘getopts’ wants each option as its own word.

Previously bash completion would output an error for a line like: ‘ninja -vn targ‸’.

In addition to removing the quotes (to enable word expansion) I also used it as a regular variable, as that is what it is (not an array).

10 years agoMerge pull request #734 from sgraham/no-stderr
Nico Weber [Mon, 14 Apr 2014 21:09:51 +0000 (14:09 -0700)]
Merge pull request #734 from sgraham/no-stderr

CLParser shouldn't read stderr

10 years agoCLParser shouldn't read stderr
Scott Graham [Mon, 14 Apr 2014 20:37:06 +0000 (13:37 -0700)]
CLParser shouldn't read stderr

10 years agoMerge pull request #722 from nico/manifestgen
Nico Weber [Mon, 14 Apr 2014 17:43:15 +0000 (10:43 -0700)]
Merge pull request #722 from nico/manifestgen

add a script to generate large synthetic manifests

10 years agoMerge pull request #732 from bratell-at-opera/bratell/fewer_list_copies_20140414
Nico Weber [Mon, 14 Apr 2014 15:39:21 +0000 (08:39 -0700)]
Merge pull request #732 from bratell-at-opera/bratell/fewer_list_copies_20140414

performance: Writer.build should copy less.

10 years agoperformance: Writer.build should copy less.
Daniel Bratell [Mon, 14 Apr 2014 11:52:02 +0000 (13:52 +0200)]
performance: Writer.build should copy less.

The build method copies the input lists several times. That
cost about 0.1s in the gyp generation for the Chromium project for
no gain.

10 years agoMerge pull request #699 from mostynb/avoid_useless_mkdir_failure
Nico Weber [Mon, 7 Apr 2014 15:22:07 +0000 (08:22 -0700)]
Merge pull request #699 from mostynb/avoid_useless_mkdir_failure

don't Fail if trying to mkdir when the dir already exists