Tanu Kaskinen [Fri, 15 Nov 2013 14:29:37 +0000 (16:29 +0200)]
bluetooth: Use a helper function for setting device_info_valid
The helper function doesn't yet bring much benefits in this form, but
I'll add more functionality later.
Parin Porecha [Tue, 19 Nov 2013 20:59:39 +0000 (11:59 -0900)]
protocol-native: Express XOR asserts more concisely
7 instances of the roundabout asserts were found,
All of them have been replaced with appropriate XOR asserts.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=47493
Tanu Kaskinen [Fri, 15 Nov 2013 12:23:27 +0000 (14:23 +0200)]
bluetooth: Remove a redundant variable
Pierre Ossman [Fri, 20 Sep 2013 08:13:41 +0000 (10:13 +0200)]
Revert "core: Transparently handle non-blocking sockets on Windows"
This reverts commit
c327850d9e4479a0572b7baaf8dafd737586e5a1 as
the workaround in that commit is no longer needed after the real
bug has been fixed.
Conflicts:
src/pulsecore/core-util.c
Pierre Ossman [Fri, 20 Sep 2013 08:10:50 +0000 (10:10 +0200)]
core: make sure win32 sockets remain blocking
Commit 7e344b5 hade the side effect of forcing every socket to
be non-blocking on Windows. This is because of a (documented)
side effect of WSAEventSelect(). So we need to make sure to restore
blocking behaviour afterwards for relevant sockets.
Alexander Couzens [Mon, 16 Sep 2013 12:08:14 +0000 (14:08 +0200)]
tunnel-new: add cookie module argument
When connecting to a remote server your local generated authentication
cookie is used. If remote server's cookie is different from your local
one you aren't allowed to connect. You can use the cookie argument
or define a wider acl in remote server configuration for
module-native-protocol.
Tanu Kaskinen [Thu, 14 Nov 2013 08:53:44 +0000 (10:53 +0200)]
sink-input, source-output: Don't assume that proplist has been initialized in free()
It's bad form to assume in free() that any member of the struct has
been initialized. I ran into problems with this when I reordered
things in pa_sink_input_new() and pa_source_output_new().
Peter Meerwald [Sun, 21 Jul 2013 21:14:45 +0000 (23:14 +0200)]
resampler: Cleanup, index of memchunks is not used
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Sun, 21 Jul 2013 21:14:44 +0000 (23:14 +0200)]
resampler: Prepare to have leftover data in different output buffers
leftover_buf points to the output buffer of a stage containing leftover
data; similar for leftover_buf_size and have_leftover
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Sun, 21 Jul 2013 21:14:43 +0000 (23:14 +0200)]
resampler: Add fit_buf() helper funtion for buffer allocation
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Sun, 21 Jul 2013 21:14:42 +0000 (23:14 +0200)]
resampler: Cleanup, rename xxxx_buf_samples to xxxx_buf_size
we measure the capacity of a buffer in bytes, not samples
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Sun, 21 Jul 2013 21:14:41 +0000 (23:14 +0200)]
resampler: Handle leftover samples, use new return value
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Sun, 21 Jul 2013 21:14:40 +0000 (23:14 +0200)]
resampler: Change interface, resampler may return the number of leftover frames
some resampler implementations (e.g. libsamplerate and ffmpeg) do not consume
the entire input buffer; the impl_resample() function now has a return value
returning the number of frames in the input buffer not processed
these frames must be saved in appropriate buffer and presented together with
new input data
also change the parameter names from in_samples, out_samples to in_n_frames,
out_n_frames, respectively (n_frames = samples / channels)
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Sun, 21 Jul 2013 21:14:39 +0000 (23:14 +0200)]
resampler: Introduce work_channels
work_channels is the number of channels in the resampler stage
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Peter Meerwald [Sun, 21 Jul 2013 21:14:38 +0000 (23:14 +0200)]
resampler: Introduce work frame size (w_fz)
w_fz represents the number of bytes per frame in the resampler stage
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Luiz Augusto von Dentz [Sun, 3 Nov 2013 13:05:34 +0000 (15:05 +0200)]
card: Only set active_profile with available profile
When a card is being created and no profile has been assigned
pa_card_new will attempt to select one from the list but it does that
without checking the available flag which can lead to select profiles
not available.
Luiz Augusto von Dentz [Mon, 4 Nov 2013 17:41:22 +0000 (19:41 +0200)]
introspect: Fix ABI break introduced by b98a2e1
The size of pa_card_profile_info cannot change even if it just a field
appended to end because each entry is appended to a contiguous memory
and accessed by offset this may lead clients to access invalid data.
To fix a new struct called pa_card_profile_info2 is introduced and shall
be used for now on while pa_card_profile_info shall be considered
deprecated but it is still mantained for backward compatibility.
A new field called profiles2 is introduced to pa_card_info, this new field
is an array of pointers to pa_card_profile_info2 so it should be possible
to append new fields to the end of the pa_card_profile_info2 without
breaking binary compatibility as the entries are not accessed by offset.
David Henningsson [Mon, 14 Oct 2013 14:06:45 +0000 (16:06 +0200)]
alsa-mixer: Add internal surround speaker elements
These kcontrol names have started to show up lately, in
combination with surround internal speakers.
BugLink: https://bugs.launchpad.net/bugs/1236965
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
João Paulo Rechi Vita [Tue, 29 Oct 2013 20:50:43 +0000 (17:50 -0300)]
console-kit: Remove logging of every message on the bus
Peter Meerwald [Tue, 16 Jul 2013 20:00:35 +0000 (22:00 +0200)]
tests: Extract PA_CPU_TEST* macros to separate header
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Pierre Ossman [Fri, 1 Nov 2013 13:50:51 +0000 (14:50 +0100)]
daemon conf: "high-priority" setting isn't respected
The code got removed by accident during the cleanup in commit
9c438bcac671. So
this patch is needed to bring it back and make things work like documented.
poljar (Damir Jelić) [Thu, 15 Aug 2013 12:08:44 +0000 (14:08 +0200)]
zsh-completion: Add --monitor-stream completion to pacat
Tanu Kaskinen [Fri, 4 Oct 2013 10:39:40 +0000 (13:39 +0300)]
simple: Improve pa_simple_read() documentation
There was a question in IRC about whether pa_simple_read() blocks or
not. It's already documented on the simple API overview page, but it's
good to say it also in the function reference. As a bonus, I added
some additional details to the documentation too.
Tanu Kaskinen [Sun, 29 Sep 2013 15:49:23 +0000 (18:49 +0300)]
bluetooth: Fix variable constness
The string points to memory inside a DBusMessage, so we don't own the string.
Tanu Kaskinen [Sun, 29 Sep 2013 15:49:22 +0000 (18:49 +0300)]
bluetooth: Remove adapter_remove_all()
The function was redundant, because all it did was call adapter_free()
for each adapter in the hashmap, and that can be delegated to
pa_hashmap when freeing or emptying it.
poljar (Damir Jelić) [Thu, 15 Aug 2013 12:08:43 +0000 (14:08 +0200)]
zsh-completion: Fix pacat device completion
The pacat completion didn't complete the right devices for the --record
and --playback flags.
This patch fixes this and makes the device completion for pacat easily
expandable.
poljar (Damir Jelić) [Thu, 15 Aug 2013 12:08:42 +0000 (14:08 +0200)]
bash-completion: Add --monitor-stream completion to pacat
Peter Meerwald [Thu, 8 Aug 2013 06:19:34 +0000 (08:19 +0200)]
modargs: Add pa_modargs_get_sample_rate()
return sample rate from the "rate" module argument
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Thu, 8 Aug 2013 06:19:33 +0000 (08:19 +0200)]
modargs: Add pa_modargs_get_resample_method()
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Ben Brewer [Thu, 25 Jul 2013 12:44:29 +0000 (13:44 +0100)]
mainloop, glib-mainloop: time_restart could cause incorrect event ordering
This fixes a bug where calling time_restart can leave the current event
in the cache, even though the restart scheduled the event in the future.
This would cause the event to get executed more frequently than it should.
Peter Meerwald [Tue, 16 Jul 2013 15:09:14 +0000 (17:09 +0200)]
tests: Resampler output memchunk may be reset (zero)
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Peter Meerwald [Tue, 16 Jul 2013 15:09:13 +0000 (17:09 +0200)]
memblock: Fix typo in description of pa_memblock_unref_fixed(), cleanup
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Rafael Ferreira [Tue, 22 Oct 2013 21:54:24 +0000 (19:54 -0200)]
Updated Brazilian Portuguese translation
Signed-off-by: Rafael Ferreira <rafael.f.f1@gmail.com>
João Paulo Rechi Vita [Mon, 14 Oct 2013 19:18:03 +0000 (16:18 -0300)]
bluetooth: Track discovery modules by index
Previously module-bluez5-discover and module-bluez4-discover were being
tracked using their pa_module pointer. But during daemon shutdown these
modules are unloaded before module-bluetooth-discover, leaving stale
pointers in module-bluetooth-discover's userdata. To avoid this problem
this commit makes module-bluetooth-discover keep track of
module-bluez5-discover and module-bluez4-discovery by their indexes.
Tanu Kaskinen [Sat, 12 Oct 2013 09:45:58 +0000 (12:45 +0300)]
build-sys: Print CPPFLAGS in configure
I needed this for verifying that the conditional defining of
_FORTIFY_SOURCE works.
Tanu Kaskinen [Sat, 12 Oct 2013 09:45:09 +0000 (12:45 +0300)]
build-sys: Don't define _FORTIFY_SOURCE when building with -O0
Kiran Krishnappa [Thu, 10 Oct 2013 06:30:09 +0000 (23:30 -0700)]
sndfile-util: fix format for 24bit depth wav files
PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not
handled in pa_sndfile_readf and writef function. paplay/parecord
used to get aborted for 24bit depth wav files
Jan Alexander Steffens (heftig) [Wed, 9 Oct 2013 18:29:39 +0000 (20:29 +0200)]
alsa: Fix crash when loading bare ALSA sink/source
module-alsa-{sink,source}.c call pa_alsa_{sink,source}_new with
mapping set to NULL. Guard against this, like the rest of the
function does.
module-alsa-card does not use NULL, so this went unnoticed so far.
Anton Lundin [Wed, 18 Sep 2013 14:22:00 +0000 (16:22 +0200)]
build-sys: Fix building with Android toolchain
Signed-off-by: Anton Lundin <glance@acc.umu.se>
Alexander Couzens [Mon, 16 Sep 2013 11:06:27 +0000 (13:06 +0200)]
tunnel-sink-new: Fix a possible crash
When the creation of u->thread fails, then pa_thread_mq_done() in
pa__done() will crash, because pa_thread_mq_init() was never called.
Allocating the thread_mq object separately, instead of embedding it
in the userdata struct, allows pa__done() to call pa_thread_mq_done()
only when necessary.
Alexander Couzens [Mon, 16 Sep 2013 11:06:34 +0000 (13:06 +0200)]
tunnel-sink-new: remove switch-default from state change callbacks
Using default sections for switch(state) in state change callbacks will prevent
useful compiler warnings for non-handled cases
David Henningsson [Mon, 23 Sep 2013 11:40:26 +0000 (13:40 +0200)]
alsa-mixer: Drop all unused paths, not only unsupported paths
This is a cleaner solution, because it also removes paths that are
being removed because they are subsets of other paths.
Otherwise, the lingering paths could cause jack detection related
assertion failures.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=69676
Reported-and-tested-by: Kalev Lember <kalevlember@gmail.com>
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Arun Raghavan [Mon, 30 Sep 2013 12:40:34 +0000 (18:10 +0530)]
i18n: Update bluetooth bits in POTFILES
David Henningsson [Fri, 27 Sep 2013 08:22:53 +0000 (10:22 +0200)]
default/system.pa: Do not load module-dbus-protocol
The author of this module, Tanu Kaskinen, has said that this module
"is not suitable for general use". Also, it is still causing crashes
on card removal (see bug 69871).
Qpaeq, and possibly other tools, use this module - but they can load
the module manually if they still wish to use it.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Arun Raghavan [Mon, 30 Sep 2013 09:45:36 +0000 (15:15 +0530)]
alsa-ucm: Fix bad rate check
Need to check the rate value for being > 0 not the return value of
pa_atou().
Arun Raghavan [Mon, 30 Sep 2013 03:02:16 +0000 (08:32 +0530)]
alsa-ucm: Don't allow Playback/CaptureRate to be 0
This was a review comment on the original patch that I missed fixing.
Tanu Kaskinen [Sun, 29 Sep 2013 16:47:16 +0000 (19:47 +0300)]
bluetooth: Add a comment about messing with the IDLE suspend cause
Arun Raghavan [Fri, 20 Sep 2013 11:57:32 +0000 (17:27 +0530)]
hashmap: Add a key+value iterator
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:59 +0000 (19:45 -0300)]
bluetooth: Revive module-bluetooth-discover
Create a wrapper module called module-bluetooth-discover to avoid
breaking backward-compatibility of default.pa. This wrapper may
eventually be dropped altoghether with BlueZ 4 support.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:58 +0000 (19:45 -0300)]
cli-command: Use pa_module_exists() in .ifexists
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:57 +0000 (19:45 -0300)]
module: Create pa_module_exists()
This new function checks if a certain module name is available in the
system.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:56 +0000 (19:45 -0300)]
bluetooth: Fail to load driver if discovery module is not loaded
For quite some time now the device driver module doesn't work well
without the discovery module, so for the BlueZ 5 support we'll prevent
the device driver module to be loaded if the discovery module is not
loaded.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:55 +0000 (19:45 -0300)]
bluetooth: Implement get_n_used() for module-bluez5-device
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:54 +0000 (19:45 -0300)]
bluetooth: Handle changes to BlueZ 5 transports state
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:53 +0000 (19:45 -0300)]
bluetooth: Process source messages for BlueZ 5 cards
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:52 +0000 (19:45 -0300)]
bluetooth: Process sink messages for BlueZ 5 cards
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:51 +0000 (19:45 -0300)]
bluetooth: Create I/O thread function for BlueZ 5 cards
Create the thread function, the render and push functions for A2DP, the
process message function for communication between the I/O thread and
the main thread, and other helper functions related to them.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:50 +0000 (19:45 -0300)]
bluetooth: Set card profile for BlueZ 5 cards
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:49 +0000 (19:45 -0300)]
bluetooth: Start / stop I/O thread for BlueZ 5 cards
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:48 +0000 (19:45 -0300)]
bluetooth: Create source for BlueZ 5 cards
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:47 +0000 (19:45 -0300)]
bluetooth: Create sink for BlueZ 5 cards
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:46 +0000 (19:45 -0300)]
bluetooth: Initialize profiles for BlueZ 5 cards
Initialized the currently active profile, configure and acquire the
transport.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:45 +0000 (19:45 -0300)]
bluetooth: Create BlueZ 5 card profile for each audio UUID
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:44 +0000 (19:45 -0300)]
bluetooth: Create BlueZ 5 card ports
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:43 +0000 (19:45 -0300)]
bluetooth: Create BlueZ 5 card
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:42 +0000 (19:45 -0300)]
bluetooth: Unload module-bluez5-device on device's disconnection
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:41 +0000 (19:45 -0300)]
bluetooth: Get BlueZ 5 device object
Get the remote device information stored in pa_bluetooth_discovery. This
also creates the mandatory parameter 'path' for module-bluez5-device,
which is used to inform the object path of the remote device in BlueZ on
the module load.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:40 +0000 (19:45 -0300)]
bluetooth: Create module-bluez5-device
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:39 +0000 (19:45 -0300)]
bluetooth: Track devices in module-bluez5-discover
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:38 +0000 (19:45 -0300)]
bluetooth: Handle PropertiesChanged for org.bluez.MediaTransport1
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:37 +0000 (19:45 -0300)]
bluetooth: Handle PropertiesChanged for org.bluez.Device1
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:36 +0000 (19:45 -0300)]
bluetooth: Protect from a misbehaving bluetoothd
bluetoothd always send the GetManagedObjects() reply messages with the
objects array argument following an in-depth order starting from the
root. That means parents will always be known at the time their children
objects are parsed, if clients parse the objects in the same order they
appear in the array, as we do in PulseAudio.
This commit tries to protect PulseAudio in the case bluetoothd changes
that behavior for some reason. It hasn't been tested, since this
situation never occurs.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:35 +0000 (19:45 -0300)]
bluetooth: Parse BlueZ 5 device properties
This code is based on previous work by Mikel Astiz.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:34 +0000 (19:45 -0300)]
bluetooth: Handle PropertiesChanged for org.bluez.Adapter1
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:33 +0000 (19:45 -0300)]
bluetooth: Register endpoints with BlueZ 5 adapter
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:32 +0000 (19:45 -0300)]
bluetooth: Parse BlueZ 5 adapter properties
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:31 +0000 (19:45 -0300)]
bluetooth: Parse BlueZ 5 D-Bus interfaces
Parse the arguments of the InterfacesAdded signal and the
GetManagedObjects() reply.
This code is based on previous work by Mikel Astiz.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:30 +0000 (19:45 -0300)]
bluetooth: Handle InterfacesAdded and InterfacesRemoved
This code is based on previous work by Mikel Astiz.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:29 +0000 (19:45 -0300)]
bluetooth: Create a function to remove only one adapter object
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:28 +0000 (19:45 -0300)]
bluetooth: Get managed objects
Get objects from the BlueZ 5 object manager. This code is based on
previous work by Mikel Astiz.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:27 +0000 (19:45 -0300)]
bluetooth: Add utility function to send D-Bus messages with reply
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:26 +0000 (19:45 -0300)]
bluetooth: Implement org.bluez.MediaEndpoint1.ClearConfiguration()
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:25 +0000 (19:45 -0300)]
bluetooth: Implement org.bluez.MediaEndpoint1.SelectConfiguration()
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:24 +0000 (19:45 -0300)]
bluetooth: Implement org.bluez.MediaEndpoint1.SetConfiguration()
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:23 +0000 (19:45 -0300)]
bluetooth: Register MediaEndpoint1 objects with D-Bus
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:22 +0000 (19:45 -0300)]
bluetooth: Create pa_bluetooth_transport for BlueZ 5 support
Create the pa_bluetooth_transport structure to store information about
the bluetooth transport and utility functions to manipulate this
structure. The acquire() and release() operations are function pointers
in the pa_bluetooth_transport structure to make possible for different
transport backends to provide different implementations of these
operations. Thre is also a userdata field for the transport backend
provide data for the acquire/release functions.
This commit also creates a new function
pa_bluetooth_device_any_transport_connected() to check if there is any
audio connection between the host and a remote device.
João Paulo Rechi Vita [Tue, 24 Sep 2013 22:45:21 +0000 (19:45 -0300)]
bluetooth: Remove all devices and adapters when org.bluez goes away
João Paulo Rechi Vita [Wed, 18 Sep 2013 21:16:58 +0000 (16:16 -0500)]
bluetooth: Create pa_bluetooth_device for BlueZ 5 support
Create a structure pa_bluetooth_device to store information about the
bluetooth device and utility functions to manipulate this structure.
João Paulo Rechi Vita [Wed, 18 Sep 2013 21:16:57 +0000 (16:16 -0500)]
bluetooth: Create pa_bluetooth_adapter for BlueZ 5 support
João Paulo Rechi Vita [Wed, 18 Sep 2013 21:16:56 +0000 (16:16 -0500)]
bluetooth: Create infrastrucure for bluetooth hooks
Create a pa_bluetooth_hook enum type and API to get pa_hooks from the
opaque pa_bluetooth_discovery struct.
João Paulo Rechi Vita [Wed, 18 Sep 2013 21:16:55 +0000 (16:16 -0500)]
bluetooth: Track org.bluez for BlueZ 5
João Paulo Rechi Vita [Tue, 13 Aug 2013 04:54:00 +0000 (01:54 -0300)]
bluetooth: Create pa_bluetooth_discovery for BlueZ 5
pa_bluetooth_discovery is the struct that holds information about known
Bluetooth audio devices and other information about the Bluetooth stack.
This commit also creates bluez5-util.[ch], which will hold a lot of
utility functions to help with the BlueZ 5 support.
João Paulo Rechi Vita [Tue, 13 Aug 2013 04:53:59 +0000 (01:53 -0300)]
bluetooth: Create stub for module-bluez5-discover
João Paulo Rechi Vita [Fri, 16 Aug 2013 12:40:54 +0000 (09:40 -0300)]
build: Add support for enabling/disabling BlueZ 5 support
João Paulo Rechi Vita [Fri, 16 Aug 2013 12:31:45 +0000 (09:31 -0300)]
build: Make the build of bluetooth modules BlueZ 4 specific
João Paulo Rechi Vita [Fri, 16 Aug 2013 12:30:41 +0000 (09:30 -0300)]
bluetooth: Remove module-bluetooth-proximity
module-bluetooth-proximity has not worked for quite a while, since it
uses pre-BlueZ4 APIs. Nobody complained since then, which is a good
indication that it doesn't have much users. Even the original commit
message refers to it more as a toy than as something of great use: "add
new fun module that automatically mutes your audio devices when you
leave with your bluetooth phone, and unmutes when you come back"
Removing it we completely remove the dependency on libbluetooth.
João Paulo Rechi Vita [Thu, 15 Aug 2013 19:17:26 +0000 (16:17 -0300)]
bluetooth: Prefix BlueZ 4 card profiles enum with PA_BLUEZ4_
Also typedef the enum as pa_bluez4_profile_t.
João Paulo Rechi Vita [Tue, 13 Aug 2013 04:53:55 +0000 (01:53 -0300)]
bluetooth: Register BlueZ 4 endpoints in a separate object path
We need diferent object paths for BlueZ 4 and BlueZ 5 endpoints to avoid
crashing the daemon in the case both modules are loaded in parallel.
João Paulo Rechi Vita [Tue, 13 Aug 2013 04:53:54 +0000 (01:53 -0300)]
bluetooth: Name BlueZ 4 symbols accordingly
We need diferent symbol prefixing for the current BlueZ 4 support and
the new BlueZ 5 support which is about to enter the codebase, to avoid
symbol clashing and crashing the daemon in the case both modules are
loaded at the same time.
This commit replaces all pa_bluetooth_ and pa_bt_ (for consistency)
prefixes with pa_bluez4_, for both lower-case and upper-case, what was
done with the following sed commands:
$ sed -i s/pa_bluetooth_/pa_bluez4_/g src/modules/bluetooth/*bluez4*
$ sed -i s/PA_BLUETOOTH_/PA_BLUEZ4_/g src/modules/bluetooth/*bluez4*
$ sed -i s/pa_bt_/pa_bluez4_/g src/modules/bluetooth/*bluez4*
$ sed -i s/PA_BT_/PA_BLUEZ4_/g src/modules/bluetooth/*bluez4*
João Paulo Rechi Vita [Tue, 13 Aug 2013 04:53:53 +0000 (01:53 -0300)]
bluetooth: Rename shared struct to make it BlueZ 4 specific