Lennart Poettering [Tue, 5 Mar 2013 17:59:14 +0000 (18:59 +0100)]
update TODO
Lennart Poettering [Tue, 5 Mar 2013 17:53:21 +0000 (18:53 +0100)]
journald: introduce new "systemd-journal" group and make it own the journal files
Previously all journal files were owned by "adm". In order to allow
specific users to read the journal files without granting it access to
the full "adm" powers, introduce a new specific group for this.
"systemd-journal" has to be created by the packaging scripts manually at
installation time. It's a good idea to assign a static UID/GID to this
group, since /var/log/journal might be shared across machines via NFS.
This commit also grants read access to the journal files by default to
members of the "wheel" and "adm" groups via file system ACLs, since
these "almost-root" groups should be able to see what's going on on the
system. These ACLs are created by "make install". Packagers probably
need to duplicate this logic in their postinst scripts.
This also adds documentation how to grant access to the journal to
additional users or groups via fs ACLs.
Lennart Poettering [Tue, 5 Mar 2013 14:02:38 +0000 (15:02 +0100)]
journald: stpcpy() + mempcpy() are awesome
Lennart Poettering [Tue, 5 Mar 2013 13:36:57 +0000 (14:36 +0100)]
journald: drop splitting-by-audit entirely
Thinking about it we should probably not hide bugs by falling back to
audit when we have our own session information anyway.
Lennart Poettering [Tue, 5 Mar 2013 13:27:34 +0000 (14:27 +0100)]
journald: be a bit more careful when spitting up journals by user id
Lennart Poettering [Tue, 5 Mar 2013 13:23:22 +0000 (14:23 +0100)]
journald: check session owner UID rather then audit ID when splitting up journal files
We should always go by our own cgroup hierarchy before using foreign
schemes such as audit, so let's do that for the split out logic too.
Harald Hoyer [Tue, 5 Mar 2013 05:45:06 +0000 (06:45 +0100)]
Revert "fstab-generator: place initrd /sysroot mounts in initrd-fs.target"
This reverts commit
8330847e949fc0c26b16910e5240eef1fe2c330a.
Conflicts:
src/fstab-generator/fstab-generator.c
Lennart Poettering [Tue, 5 Mar 2013 03:10:19 +0000 (04:10 +0100)]
update TODO
Lennart Poettering [Tue, 5 Mar 2013 02:29:54 +0000 (03:29 +0100)]
logind: when registering a new session always use previous session info from cgroup path rather than audit
Previously for cases like "su" or "sudo" where a session is attempted to
be created from within an existing one we used the audit session ID to
detect this and in such a case we simple returned the session data of
the original session a second time.
With this change we will now use the cgroup path of the calling path to
determine the old session, i.e. we only rely on our own session
identification scheme, instead of audits.
We will continue to keep the audit session ID and ours in sync however,
to avoid unnecessary confusion.
Michael Biebl [Mon, 4 Mar 2013 22:20:16 +0000 (23:20 +0100)]
build-sys: build and install systemd-coredumpctl conditionally
If coredump support is disabled via --disable-coredump, do not build and
install the systemd-coredumpctl binary and man page.
Harald Hoyer [Mon, 4 Mar 2013 20:00:56 +0000 (21:00 +0100)]
fstab-generator: only handle block devices with root= kernel command line parameter
skip s.th. like root=nfs:... root=iscsi:... root=nbd:...
Harald Hoyer [Mon, 4 Mar 2013 18:04:32 +0000 (19:04 +0100)]
fstab-generator: place initrd /sysroot mounts in initrd-fs.target
also do not overwrite /sysroot*.mount units already generated from fstab
Harald Hoyer [Mon, 4 Mar 2013 18:03:05 +0000 (19:03 +0100)]
units/initrd-*: require initrd-fs.target rather than local-fs.target
Harald Hoyer [Mon, 4 Mar 2013 18:01:05 +0000 (19:01 +0100)]
add initrd-fs.target and initrd-fs-pre.target
Zbigniew Jędrzejewski-Szmek [Mon, 4 Mar 2013 18:16:38 +0000 (13:16 -0500)]
build-sys: do not install pam_systemd(8) without PAM
Zbigniew Jędrzejewski-Szmek [Mon, 4 Mar 2013 17:57:12 +0000 (12:57 -0500)]
build-sys: do not install logind manpages when disabled
The condition was wrong: HAVE_PAM -> ENABLE_LOGIND.
Kay Sievers [Mon, 4 Mar 2013 15:13:19 +0000 (16:13 +0100)]
ProFUSION got bought by Intel
Kay Sievers [Mon, 4 Mar 2013 14:17:45 +0000 (15:17 +0100)]
journal: split journal uid only when audit uid data is valid
Michal Schmidt [Mon, 4 Mar 2013 13:38:51 +0000 (14:38 +0100)]
core/manager: fix conditions to start and stop watching running jobs
Harald encountered division by zero in manager_print_jobs_in_progress.
Clearly we had the watch enabled when we shouldn't - there were no
running jobs in m->jobs, only waiting ones. This is either a deadlock,
or maybe some of them would be detected as runnable in the next dispatch
of the run queue. In any case we mustn't crash.
Fix it by starting and stopping the watch based on n_running_jobs
instead of the number of all jobs.
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 23:42:52 +0000 (18:42 -0500)]
tmpfiles: use cleanup func. to save a few lines
Lukas Nykryn [Fri, 1 Mar 2013 17:29:59 +0000 (18:29 +0100)]
tmpfiles: move exclamation mark into right place
Unary not has higher precedence than comparisons,
so the condition was bogus.
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 06:32:34 +0000 (01:32 -0500)]
core/path: install inotify watches top-down instead of bottom-up
When watches are installed from the bottom, it is always possible
to race, and miss a file creation event. The race can be avoided
if a watch is first established for a parent directory, and then for
the file in the directory. If the file is created in the time between,
the watch on the parent directory will fire.
Some messages (mostly at debug level) are added to help diagnose
pidfile issues.
Should fix https://bugzilla.redhat.com/show_bug.cgi?id=917075.
Michael Biebl [Mon, 4 Mar 2013 01:13:34 +0000 (02:13 +0100)]
build-sys: be more tolerant if dbus directories do not exist
use readlink -m instead of -f since we might be building in a minimal
chroot where those directories do not actually exist and readlink -f
would return an empty string.
Michael Biebl [Mon, 4 Mar 2013 00:39:22 +0000 (01:39 +0100)]
build-sys: resolve absolute path for the dbus directories
/usr/share/dbus-1/system-services simply looks a lot nicer then
/usr/share/dbus-1/services/../system-services
Michael Biebl [Mon, 4 Mar 2013 00:38:16 +0000 (01:38 +0100)]
build-sys: replace backticks `` with $()
for consistencies sake use $() everywhere
Michael Biebl [Sun, 3 Mar 2013 20:32:49 +0000 (21:32 +0100)]
build-sys: don't hard code bash-completion directory
Michael Biebl [Sun, 3 Mar 2013 20:27:44 +0000 (21:27 +0100)]
build-sys: use $PKG_CONFIG instead of calling the pkg-config binary directly
Rob Clark [Sun, 3 Mar 2013 17:55:08 +0000 (12:55 -0500)]
udev: fix segfault with android rndis
The android gadget driver for network tethering over rndis somehow has a
parent device with a null subsystem. Probably this is bug in android driver,
but it is easy enough to make systemd/udev behave gracefully and not
segfault. And this will help for making linux distros with systemd
(like fedora) work on android devices.
Kay Sievers [Sun, 3 Mar 2013 17:35:22 +0000 (18:35 +0100)]
udev: remove database conversion code
Kay Sievers [Sun, 3 Mar 2013 17:20:09 +0000 (18:20 +0100)]
udev: firmware - do not created /run/udev/firmware-missing/
The userspace firmware loader is deprecated now, and will be entirely
removed when we depend on a kernel version with the built-in firmware
loader available.
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 01:14:21 +0000 (20:14 -0500)]
journald: do not barf when setting RateLimitInterval=0
Assertion 'interval > 0 || burst == 0' failed at src/journal/journald-rate-limit.c:78, function journal_rate_limit_new(). Aborting.
Zbigniew Jędrzejewski-Szmek [Sat, 2 Mar 2013 13:28:58 +0000 (08:28 -0500)]
core/service: use cleanup functions, wrap lines
Zbigniew Jędrzejewski-Szmek [Sun, 3 Mar 2013 06:49:11 +0000 (01:49 -0500)]
core/path: catch errors when adding watches
Errors because of oom conditions or descriptor exhaustion should not
be ignored. We probably cannot recover from those conditions.
Current behaviour wrt. insufficient permissions is described in the
man page. It might make sense in case of user sessions, so I left
it as is.
Zbigniew Jędrzejewski-Szmek [Fri, 1 Mar 2013 23:04:36 +0000 (18:04 -0500)]
core/path: modernize style
Zbigniew Jędrzejewski-Szmek [Fri, 1 Mar 2013 22:58:56 +0000 (17:58 -0500)]
core/path: use automatic cleanup
... and fix bogus return code on malloc failure.
Zbigniew Jędrzejewski-Szmek [Fri, 1 Mar 2013 22:44:25 +0000 (17:44 -0500)]
core/path: fix a leak in success path
... and use automatic cleanup.
Michael Biebl [Sun, 3 Mar 2013 13:40:49 +0000 (14:40 +0100)]
Update TODO
Michael Biebl [Sat, 2 Mar 2013 21:34:01 +0000 (22:34 +0100)]
bash-completion: split completions and move to new location
Split the large bash completion script into separate, smaller files each
named after the binary it is used for and move the files to
/usr/share/bash-completion/completions. This way the completions can be
loaded on demand and we only install the completions for the tools we
actually build. The old path /etc/bash_completion.d/ is deprecated and
will disappear in the future.
Michal Schmidt [Sat, 2 Mar 2013 12:16:27 +0000 (13:16 +0100)]
job: print the "OK" status messages in normal green
The "OK" status messages should not draw attention to themselves.
It's better if they're not printed in bright/bold. Leave that
to errors and warnings.
Use a plain inconspicuous enterprisey green.
Michal Schmidt [Sat, 2 Mar 2013 11:44:41 +0000 (12:44 +0100)]
manager: turn a superfluous check into assert
The crash that the check prevented has been fixed by commit 9e9e2b7.
Michal Schmidt [Sat, 2 Mar 2013 11:29:04 +0000 (12:29 +0100)]
unit: count deserialized job only after it's definitely installed
Installation of a deserialized job may fail (though purely in theory),
so increase the running job counter only when succeeding.
Tom Gundersen [Sun, 24 Feb 2013 16:40:36 +0000 (17:40 +0100)]
initrd: add unit files needed for basic systemd-in-initrd support
This will:
* mount all configured filesystems (typically the rootfs on /sysroot)
* reload the configuration to pick up anything from the mounted fs (typically
/sysroot/etc/fstab)
* mount any newly configured filesystems (typically /usr on /sysroot/usr, if
applicable)
* shut-down and clean-up any daemons running in the initramfs (typically udevd)
* switch-root to /sysroot and start the real init
For an example of what files should be included in an initramfs based on this
see
<https://mailman.archlinux.org/pipermail/arch-projects/2013-February/003628.html>.
Cc: Harald Hoyer <harald.hoyer@gmail.com>
Cc: Dave Reisner <d@falconindy.com>
Tom Gundersen [Fri, 22 Feb 2013 10:52:36 +0000 (11:52 +0100)]
fstab-generator: initrd - mount selected entries from /sysroot/etc/fstab
We only mount "/usr" and entries marked with "x-initrd.mount".
This (together with the right unit files) is needed in the initramfs in order to
natively support mounting /usr (and friends) from the initramfs.
The way it is meant to work is:
* wait for sysroot.mount to be mounted
* do a daemon-reload to generate sysroot-usr.mount (++) from /sysroot/etc/fstab
* wait for sysroot-usr.mount to be mounted
* switch-root
Cc: Harald Hoyer <harald.hoyer@gmail.com>
Cc: Dave Reisner <d@falconindy.com>
Lukas Nykryn [Fri, 1 Mar 2013 17:29:58 +0000 (18:29 +0100)]
systemctl: check if iterator was initialized succesfully
Lukas Nykryn [Fri, 1 Mar 2013 17:30:01 +0000 (18:30 +0100)]
manager: print p and then free it
Lukas Nykryn [Fri, 1 Mar 2013 17:30:00 +0000 (18:30 +0100)]
systemd-analyze: free unit_times only if it is not NULL
Lukas Nykryn [Fri, 1 Mar 2013 17:29:57 +0000 (18:29 +0100)]
systemd-python: add missing check for return of PyDict_SetItem in _reader.c
Tom Gundersen [Fri, 1 Mar 2013 20:15:51 +0000 (21:15 +0100)]
fstab-generator: drop rootwait support
I originally added this to stay as compatible as possible with the kernel, but
as Lennart argued it is not really useful in the initramfs, so let's drop it (we
already don't support 'rootdealy').
Lennart Poettering [Fri, 1 Mar 2013 18:21:47 +0000 (19:21 +0100)]
update TODO
Mantas Mikulėnas [Sun, 17 Feb 2013 19:00:34 +0000 (21:00 +0200)]
inhibit: make the output more readable
The columnar output can become pretty horrible. When GNOME inhibits
power/suspend/hibernate keys, the "WHAT" column's text extends to "WHO"
and even "WHY". At the same time, all texts in "WHY" are of the form
GNOME handlin...sses
Receiving sle...ions
GNOME needs t...reen
This patch splits each inhibit entry into four lines, allowing the full
text to fit in a normal-width terminal.
Lennart Poettering [Fri, 1 Mar 2013 14:19:00 +0000 (15:19 +0100)]
coredump: bump coredump truncation size from 24M to 768M
In the long run we really should make this runtime configurable.
Michal Schmidt [Fri, 1 Mar 2013 13:47:46 +0000 (14:47 +0100)]
core: fix running jobs counters after reload/reexec
All active units will call unit_notify() during coldplug, so we just
make sure we're counting from zero again and get the correct result for
n_on_console.
For n_running_jobs we likewise reset it to zero and then count
the running jobs as we encounter them in deserialization.
Harald Hoyer [Fri, 1 Mar 2013 16:49:06 +0000 (17:49 +0100)]
fstab-generator: set "ro" as default for sysroot.mount
Harald Hoyer [Fri, 1 Mar 2013 16:05:58 +0000 (17:05 +0100)]
fstab-generator: fix commit 92094b7
Oleksii Shevchuk [Wed, 13 Feb 2013 22:49:26 +0000 (00:49 +0200)]
unit: fix the race in deserialization.
unit_notify is fired in deserelization code (particulary in
service_set_state). Units passed in random order, and there is possibility,
that unit with StopWhenUnneeded=yes passed before it actual dependecies. In
that case unit will be stopped as unneeded, because deps in UNIT_INACTIVE state
yet.
So, reuse similar logic (unit.c:1421) to avoid this race
Harald Hoyer [Fri, 1 Mar 2013 13:58:32 +0000 (14:58 +0100)]
fstab-generator: parse_new_root_from_proc_cmdline() don't use "defaults"
Don't use "defaults" as default option string.
"defaults,<anyotheroption>" does not
even work for the mount unit mount options.
Harald Hoyer [Fri, 1 Mar 2013 13:57:16 +0000 (14:57 +0100)]
manager: prevent segfault in manager_print_jobs_in_progress()
Harald Hoyer [Fri, 1 Mar 2013 10:33:14 +0000 (11:33 +0100)]
cryptsetup-generator: fix the kernel command line strategy for luks.uuid
If rd.luks.uuid or luks.uuid is specified on the kernel command, only
generate units for these UUIDs. Additionally use the information in
/etc/crypttab unless rd.luks.crypttab=0 or luks.crypttab=0 is specified.
Lennart Poettering [Fri, 1 Mar 2013 13:54:55 +0000 (14:54 +0100)]
specifier: when resolving specifier strings when loading configuration, don't misunderstand parse failures as OOM
http://lists.freedesktop.org/archives/systemd-devel/2013-February/009179.html
Frederic Crozat [Thu, 21 Feb 2013 15:09:40 +0000 (16:09 +0100)]
fstab,mount: detect rbind as bind mount
Correctly detect rbind mount option as bind mount.
Fixes https://bugzilla.novell.com/show_bug.cgi?id=804575.
Daniel Wallace [Fri, 1 Mar 2013 13:39:04 +0000 (14:39 +0100)]
journalctl: add --user-unit= switch
Add --user-unit= to make it possible to query for user logs by the name
of the service.
Lennart Poettering [Fri, 1 Mar 2013 13:07:20 +0000 (14:07 +0100)]
path-lookup: downgrade again the messages where we log for units
This partially reverts
7ad94c716d6403233d04c4d37cb14df958c9b65d.
After that commit commands such as "systemctl enable" and friends
printed the search path information multiple times in its output, which
is ugly.
If we want the search paths to be printed at a higher log level, then we
should do this in PID 1 only, i.e. split the printing out of the normal
path lookup logic and invoke that explicitly from PID 1 but not in the
auxiliary tools.
Lennart Poettering [Fri, 1 Mar 2013 13:04:18 +0000 (14:04 +0100)]
Revert "systemctl: try to reload daemon after enable/disable only when not running in a chroot"
This reverts commit
5522a1fa876f1ab94a2accaadca824799fdf2cab.
I am an idiot, the chroot case was already filtered out, so no point in
checking this again.
Lennart Poettering [Fri, 1 Mar 2013 12:59:49 +0000 (13:59 +0100)]
systemctl: try to reload daemon after enable/disable only when not running in a chroot
http://lists.freedesktop.org/archives/systemd-devel/2013-February/009208.html
Lukas Nykryn [Wed, 27 Feb 2013 15:26:59 +0000 (16:26 +0100)]
pager: add K to less environment
Using less as a pager sometimes breaks terminal when output
is interrupted by ctrl-c.
Reproducer: run 'sudo journalctl' ctrl-c.
Thanks mbriza@redhat.com for the solution.
Lukas Nykryn [Fri, 1 Mar 2013 09:27:10 +0000 (10:27 +0100)]
journalctl: add --reverse option to show the newest lines first
Zbigniew Jędrzejewski-Szmek [Fri, 1 Mar 2013 00:53:42 +0000 (19:53 -0500)]
Merge branch 'python-systemd-reader'
* python-systemd-reader:
python-systemd: rename Journal to Reader
build-sys: upload python documentation to freedesktop.org
systemd-python: add Journal class for reading journal
python: build html docs using sphinx
journalct: also print Python code in --new-id
python: utilize uuid.UUID in logging
python: add systemd.id128 module
... and 34 other commits
In short: python module systemd.id128 is added, and existing
systemd.journal gains a new class systemd.journal.Reader, which can be
used to iterate over journal entries. Documentation is provided, and
accessible under e.g.
pydoc3 systemd.journal.Reader
or
firefox http://www.freedesktop.org/software/systemd/man/python-systemd/
Zbigniew Jędrzejewski-Szmek [Fri, 1 Mar 2013 00:32:31 +0000 (19:32 -0500)]
python-systemd: rename Journal to Reader
It seems inevitable that we'll also grow a writing interface,
and then it'll be cumbersome to have a "Journal" for reading,
and a "Writer" for writing.
Zbigniew Jędrzejewski-Szmek [Sat, 23 Feb 2013 00:11:36 +0000 (01:11 +0100)]
systemd-python: return both parts of sd_journal_get_monotonic_usec
In Python 3, a named tuple is used. In Python 2, a simple
tuple is used. In either case, the pair is (timestamp, bootid).
Zbigniew Jędrzejewski-Szmek [Fri, 22 Feb 2013 12:33:06 +0000 (13:33 +0100)]
python-systemd: check all errors and use automatic cleanup
__REALTIME_TIMESTAMP and __MONOTONIC_TIMESTAMP return ints.
It doesn't make sense to convert to string, just to convert
back to a number later on.
Also try to follow systemd rules for indentation.
Zbigniew Jędrzejewski-Szmek [Thu, 21 Feb 2013 17:10:08 +0000 (18:10 +0100)]
build-sys: upload python documentation to freedesktop.org
Zbigniew Jędrzejewski-Szmek [Thu, 21 Feb 2013 14:08:01 +0000 (15:08 +0100)]
systemd-python: hide ChainMap import
Zbigniew Jędrzejewski-Szmek [Thu, 21 Feb 2013 14:07:39 +0000 (15:07 +0100)]
systemd-python: document attributes
In id128 it would be better to add everything automatically, but
sphinx cannot do this right now.
Zbigniew Jędrzejewski-Szmek [Thu, 21 Feb 2013 13:23:57 +0000 (14:23 +0100)]
systemd-python: use PyModule_AddObject in id128
Zbigniew Jędrzejewski-Szmek [Wed, 20 Feb 2013 08:20:35 +0000 (09:20 +0100)]
build-sys: make sphinx support uncoditional
It needs to be invoked explicitly, so there's no need to check
explicitly.
Zbigniew Jędrzejewski-Szmek [Wed, 20 Feb 2013 04:03:32 +0000 (23:03 -0500)]
systemd-python: polish the docstrings
Lennart Poettering [Thu, 28 Feb 2013 18:55:48 +0000 (19:55 +0100)]
man: clarify systemctl --property= documentation a bit
Lennart Poettering [Thu, 28 Feb 2013 12:48:53 +0000 (13:48 +0100)]
update TODO
Zbigniew Jędrzejewski-Szmek [Thu, 28 Feb 2013 03:38:26 +0000 (22:38 -0500)]
man: fix docbook in systemd-activate(8)
Zbigniew Jędrzejewski-Szmek [Thu, 28 Feb 2013 03:25:40 +0000 (22:25 -0500)]
man: document systemd-nspawn behaviour with -b
Cf.
cb96a2c69 and
1ddf879a.
Zbigniew Jędrzejewski-Szmek [Sat, 23 Feb 2013 16:52:04 +0000 (17:52 +0100)]
systemd-activate: add a socket-activation test tool
Zbigniew Jędrzejewski-Szmek [Sat, 23 Feb 2013 13:44:16 +0000 (14:44 +0100)]
nspawn: environment would be truncated with TERM unset
Zbigniew Jędrzejewski-Szmek [Thu, 28 Feb 2013 02:31:02 +0000 (21:31 -0500)]
man: drop rhs parts in snippets in directive index
- --exit-if-exists=file
+ --exit-if-exists=
etc.
Zbigniew Jędrzejewski-Szmek [Thu, 28 Feb 2013 01:16:38 +0000 (20:16 -0500)]
build-sys: fix update-man-rules for vpath builds
Zbigniew Jędrzejewski-Szmek [Thu, 28 Feb 2013 02:48:34 +0000 (21:48 -0500)]
build-sys: tell Makefile.am to distribute kernel-install
Michal Schmidt [Wed, 27 Feb 2013 23:03:22 +0000 (00:03 +0100)]
core/manager: print status messages about running jobs
Sometimes the boot gets stuck until a timeout hits. The usual timeouts
are on the order of minutes, so users may lose patience.
Print animated status messages telling the names of units with running
jobs to make it easy to see what systemd is waiting for.
The animation looks cooler with a shorter interval, but 1 s is OK and
should not be too hard on slow serial console users.
Michal Schmidt [Wed, 27 Feb 2013 23:01:10 +0000 (00:01 +0100)]
core: count active units that may mind our printing to /dev/console
Michal Schmidt [Thu, 28 Feb 2013 00:36:55 +0000 (01:36 +0100)]
core/execute: determine if ExecContext may fiddle with /dev/console
There is some guesswork, but it should work satisfactorily for the
purpose of knowing when to suppress printing of status messages.
Michal Schmidt [Thu, 28 Feb 2013 00:35:47 +0000 (01:35 +0100)]
core/execute: add internal is_terminal_output()
Similar to already existing is_terminal_input().
Note that the only current user (connect_logger_as) is never called
for EXEC_OUTPUT_TTY, so it won't mind whether we accept it.
Michal Schmidt [Thu, 28 Feb 2013 00:30:38 +0000 (01:30 +0100)]
util: split resolving of /dev/console into a new function
Michal Schmidt [Wed, 27 Feb 2013 22:58:10 +0000 (23:58 +0100)]
core/unit: use a temp variable for manager pointer in unit_notify()
Michal Schmidt [Wed, 27 Feb 2013 21:52:43 +0000 (22:52 +0100)]
util, core: add support for ephemeral status lines
Ephemeral status lines do not end with a newline and they expect to be
overwritten by the next printed status line.
Michal Schmidt [Wed, 27 Feb 2013 22:31:35 +0000 (23:31 +0100)]
core/transaction: replace a bare status_printf()
Like other status messages, this one too should not be printed
unconditionally, but it should take the manager state into account.
unit_status_printf() does that.
Michal Schmidt [Wed, 27 Feb 2013 21:54:14 +0000 (22:54 +0100)]
core: redefine unit_status_printf()
Take advantage of the fact that almost all callers want to pass unit
description as the last parameter. Those who don't can use the more
flexible manager_status_printf().
Michal Schmidt [Wed, 27 Feb 2013 23:14:47 +0000 (00:14 +0100)]
core/manager: make a couple of functions static
They're not used outside manager.c anymore.
Michal Schmidt [Wed, 27 Feb 2013 23:14:40 +0000 (00:14 +0100)]
core: add manager_status_printf()
unit_status_printf() checks the state of the manager, not of the unit
as such. Move it to manager.c and rename it to manager_status_printf().
Temporarily keep unit_status_printf as a wrapper macro.
Michal Schmidt [Tue, 26 Feb 2013 11:09:41 +0000 (12:09 +0100)]
core: keep track of the number of JOB_RUNNING jobs
Lennart Poettering [Wed, 27 Feb 2013 18:37:04 +0000 (19:37 +0100)]
man: document the new systemctl cgroup commands
Lennart Poettering [Wed, 27 Feb 2013 17:58:56 +0000 (18:58 +0100)]
systemctl: fix minimal number of params for new cgroup commands
Lennart Poettering [Wed, 27 Feb 2013 17:56:25 +0000 (18:56 +0100)]
update TODO