Jonas Devlieghere [Mon, 19 Oct 2020 21:29:59 +0000 (14:29 -0700)]
[FileCollector] Move interface into FileCollectorBase (NFC)
For the reproducers in LLDB we want to switch to an "immediate mode"
FileCollector that writes every file encountered straight to disk so we
can generate the actual mapping out-of-process. This patch moves the
interface into a separate base class.
Differential revision: https://reviews.llvm.org/D89742
Max Kazantsev [Mon, 19 Oct 2020 11:15:39 +0000 (18:15 +0700)]
[SCEV] Recommit "Use nw flag and symbolic iteration count to sharpen ranges of AddRecs", attempt 2
Fixed wrapping range case & proof methods reduced to constant range
checks to save compile time.
Differential Revision: https://reviews.llvm.org/D89381
Richard Smith [Tue, 20 Oct 2020 04:29:13 +0000 (21:29 -0700)]
Refactor tracking of constant initializers for variables.
Instead of framing the interface around whether the variable is an ICE
(which is only interesting in C++98), primarily track whether the
initializer is a constant initializer (which is interesting in all C++
language modes).
No functionality change intended.
Arthur Eubanks [Tue, 20 Oct 2020 04:24:03 +0000 (21:24 -0700)]
[NPM][StackSafetyAnalysis] Pin uses of -analyze to legacy PM
Tests already have corresponding NPM RUN lines.
Kai Luo [Tue, 20 Oct 2020 03:43:59 +0000 (03:43 +0000)]
[PowerPC] Add test case for missing `nsw` flag. NFC.
Serguei Katkov [Fri, 16 Oct 2020 07:23:02 +0000 (14:23 +0700)]
[IRCE] Do not transform if loop has small number of iterations
IRCE has some overhead for runtime checks and in case number of iteration is small
the overhead can kill the benefit from optimizations.
This CL bases on BlockFrequencyInfo of pre-header and header to estimate the
number of loop iterations. If it is less than irce-min-estimated-iters we do not transform the loop.
Probably it is better to make more complex cost model but for simplicity it seems the be enough.
The usage of BFI is added only for new pass manager and tries to use it efficiently.
Reviewers: ebrevnov, dantrushin, asbirlea, mkazantsev
Reviewed By: mkazantsev
Subscribers: llvm-commits, fhahn
Differential Revision: https://reviews.llvm.org/D89541
Geoffrey Martin-Noble [Tue, 20 Oct 2020 02:20:16 +0000 (19:20 -0700)]
Add llvm_unreachable to avoid MSVC warning
Without this I get a warning about not all paths returning.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D89760
Richard Smith [Tue, 20 Oct 2020 03:13:35 +0000 (20:13 -0700)]
Fixup clang-tidy after recent Clang change.
Lang Hames [Tue, 20 Oct 2020 02:53:38 +0000 (19:53 -0700)]
[ORC] Remove commented out methods accidentally left in in
069919c9ba3.
Thanks for spotting this Mehdi!
Qiu Chaofan [Tue, 20 Oct 2020 02:13:01 +0000 (10:13 +0800)]
[DAGCombiner] Tighten reasscociation of visitFMA
From LangRef, FMF contract should not enable reassociating to form
arbitrary contractions. So it should not help rearrange nodes like
(fma (fmul x, c1), c2, y) into (fma x, c1*c2, y).
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D89527
Richard Smith [Tue, 20 Oct 2020 02:01:48 +0000 (19:01 -0700)]
Ensure that checkInitIsICE is called exactly once for every variable
for which it matters.
This is a step towards separating checking for a constant initializer
(in which std::is_constant_evaluated returns true) and any other
evaluation of a variable initializer (in which it returns false).
Volodymyr Sapsai [Tue, 20 Oct 2020 01:25:35 +0000 (18:25 -0700)]
Revert "Reland "[Modules] Add stats to measure performance of building and loading modules.""
This reverts commit
4000c9ee18ecebe3ff0f197af8c1fb434ad986e5.
Test "LLVM :: Other/statistic.ll" is failing on Windows.
Wang, Pengfei [Tue, 20 Oct 2020 00:58:22 +0000 (08:58 +0800)]
[X86] Fix assert fail when element type is i1.
extract_vector_elt will turn type vxi1 into i8, which triggers the assertion fail.
Since we don't really handle vxi1 cases in below code, we can just return from here.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D89096
Douglas Yung [Tue, 20 Oct 2020 01:17:34 +0000 (18:17 -0700)]
Add option to use older clang ABI behavior when passing certain union types as function arguments
Recently commit D78699 (commit
26cfb6e562f1), fixed clang's behavior with respect
to passing a union type through a register to correctly follow the ABI. However,
this is an ABI breaking change with earlier versions of the clang compiler, so we
should add an -fclang-abi-compat option to address this. Additionally, the PS4 ABI
requires the older behavior, so that is added as well.
This change adds a Ver11 value to the ClangABI enum that when it is set (or the
target is the PS4 triple), we skip the ABI fix introduced in D78699.
Differential Revision: https://reviews.llvm.org/D89747
Kostya Kortchinsky [Mon, 19 Oct 2020 18:54:43 +0000 (11:54 -0700)]
[GWP-ASan] Cleanup (NFC)
Cleaning up some of the GWP-ASan code base:
- lots of headers didn't have the correct file name
- adding `#ifdef` guard to `utilities.h`
- correcting an `#ifdef` guard based on actual file name
- removing an extra `;`
- clang-format'ing the code (`-style=llvm`)
Differential Revision: https://reviews.llvm.org/D89721
Duncan P. N. Exon Smith [Wed, 14 Oct 2020 16:37:19 +0000 (12:37 -0400)]
clang/Lex: Stop using SourceManager::getBuffer
Update clang/lib/Lex to stop relying on a `MemoryBuffer*`, using the
`MemoryBufferRef` from `getBufferOrNone` since both locations had logic
for checking validity of the buffer. There's potentially a functionality
change, since the logic was wrong (it checked for `nullptr`, which was
never returned by the old API), but if that was reachable the new
behaviour should be better.
Differential Revision: https://reviews.llvm.org/D89402
Casey Carter [Mon, 19 Oct 2020 23:20:59 +0000 (16:20 -0700)]
[libc++][test] MSVC has no __PRETTY_FUNCTION__
Use `__FUNCSIG__` instead when compiling with MSVC. While we're touching `makeTypeIDImp`, remove the warning suppression for C4640 "construction of local static object is not thread safe" since C1XX now correctly constant-initializes `id`.
Casey Carter [Mon, 19 Oct 2020 22:43:11 +0000 (15:43 -0700)]
[libc++][test] Test nonconforming atomic_fetch_XXX overloads only on libc++
The Standard doesn't include the
```c++
template<class T>
T* atomic_fetch_meow(atomic<T*>, ...);
```
templates these tests are testing.
(See https://bugs.llvm.org/show_bug.cgi?id=47908)
Casey Carter [Mon, 19 Oct 2020 22:32:57 +0000 (15:32 -0700)]
[libc++][test] Silence MSVC "comparison of signed and unsigned" warning
Casey Carter [Mon, 19 Oct 2020 22:25:35 +0000 (15:25 -0700)]
[libc++][test] test allocator<const T> extension only on libc++
Casey Carter [Mon, 19 Oct 2020 22:24:50 +0000 (15:24 -0700)]
[libc++][test] Don't violate precondition [atomics.flag]/6
... which forbids passing `memory_order_release` or `memory_order_acq_rel` to either overload of `atomic_flag_test_explicit`.
Casey Carter [Mon, 19 Oct 2020 22:18:01 +0000 (15:18 -0700)]
[libc++][test] atomic<T> requires trivially copyable T
The author of these tests apparently forgot that `atomic_{,un}signed_lock_free` are already specializations of `atomic`.
Casey Carter [Mon, 19 Oct 2020 22:12:27 +0000 (15:12 -0700)]
[libc++][test] Pass correct ordering to std::merge
The predicate passed to `merge` must induce a strict weak ordering on its arguments.
Casey Carter [Mon, 19 Oct 2020 22:10:39 +0000 (15:10 -0700)]
[libc++][test] Spell "TEST_CONSTEXPR_CXX17" correctly
These three algorithm tests are incorrectly using `_LIBCPP_CONSTEXPR_AFTER_CXX17` instead of `TEST_CONSTEXPR_CXX17`.
Duncan P. N. Exon Smith [Tue, 20 Oct 2020 00:07:25 +0000 (20:07 -0400)]
lldb: Update for change in `clang::Lexer`'s constructor
b3eff6b7bb31e7ef059a3d238de138849839fbbd updated `Lexer::Lexer` to take
`clang::MemoryBufferRef` instead of `clang::MemoryBuffer*`. Update LLDB
to fix the bots.
Nico Weber [Tue, 20 Oct 2020 00:01:06 +0000 (20:01 -0400)]
Revert "[gn build] (manually) port
d09b08919ca"
This reverts commit
4d2d287a030fe81a5bf9d982ed8ea26fe3bcee6b.
d09b08919ca got reverted in
7ecd60bb702.
Volodymyr Sapsai [Mon, 19 Oct 2020 23:25:45 +0000 (16:25 -0700)]
[hmaptool] Fix `NameError: global name 'num_buckets' is not defined` in `action_dump`.
Jon Chesterfield [Mon, 19 Oct 2020 23:23:44 +0000 (00:23 +0100)]
[libomptarget][amdgcn] Implement missing symbols in deviceRTL
[libomptarget][amdgcn] Implement missing symbols in deviceRTL
Malloc, wtime are stubs. Malloc needs a hostrpc implementation which is
a work in progress, wtime needs some experimentation to find out the
multiplier to get a time in seconds as documentation is scarce.
Reviewed By: ronlieb
Differential Revision: https://reviews.llvm.org/D89725
Evgenii Stepanov [Mon, 19 Oct 2020 22:53:34 +0000 (15:53 -0700)]
Revert "[Sanitizers] Remove OpenBSD support" + 1
Revert "Fix compiler-rt build on Windows after D89640"
This reverts commit
a7acee89d68473183cc5021d952a56cdf0ae27d3.
This reverts commit
d09b08919ca6e206cd981fdea8b19b1d1188e325.
Reason: breaks Linux / x86_64 build.
Duncan P. N. Exon Smith [Wed, 14 Oct 2020 15:11:09 +0000 (11:11 -0400)]
Lexer: Update the Lexer to use MemoryBufferRef, NFC
Update `Lexer` / `Lexer::Lexer` to use `MemoryBufferRef` instead of
`MemoryBuffer*`. Callers that were acquiring a `MemoryBuffer*` via
`SourceManager::getBuffer` were updated, such that if they checked
`Invalid` they use `getBufferOrNone` and otherwise `getBufferOrFake`.
Differential Revision: https://reviews.llvm.org/D89398
Sean Silva [Mon, 19 Oct 2020 01:34:05 +0000 (18:34 -0700)]
[mlir] Use dynamic_tensor_from_elements in shape.broadcast conversion
Now, convert-shape-to-std doesn't internally create memrefs, which was
previously a bit of a layering violation. The conversion to memrefs
should logically happen as part of bufferization.
Differential Revision: https://reviews.llvm.org/D89669
Sean Silva [Mon, 19 Oct 2020 04:10:55 +0000 (21:10 -0700)]
[mlir][DialectConversion] Fix recursive `clone` calls.
The framework was not tracking ops created in any regions of the cloned
op.
Differential Revision: https://reviews.llvm.org/D89668
Sean Silva [Fri, 16 Oct 2020 22:57:27 +0000 (15:57 -0700)]
[mlir] Add std.dynamic_tensor_from_elements bufferization.
It's unfortunate that this requires adding a dependency on scf dialect
to std bufferization (and hence all of std transforms). This is a bit
perilous. We might want a lib/Transforms/Bufferize/ with a separate
bufferization library per dialect?
Differential Revision: https://reviews.llvm.org/D89667
Sean Silva [Fri, 16 Oct 2020 20:50:34 +0000 (13:50 -0700)]
[mlir] Add some more std bufferize patterns.
Add bufferizations for extract_element and tensor_from_elements.
Differential Revision: https://reviews.llvm.org/D89594
Volodymyr Sapsai [Mon, 19 Oct 2020 20:39:47 +0000 (13:39 -0700)]
Reland "[Modules] Add stats to measure performance of building and loading modules."
Measure amount of high-level or fixed-cost operations performed during
building/loading modules and during header search. High-level operations
like building a module or processing a .pcm file are motivated by
previous issues where clang was re-building modules or re-reading .pcm
files unnecessarily. Fixed-cost operations like `stat` calls are tracked
because clang cannot change how long each operation takes but it can
perform fewer of such operations to improve the compile time.
Also tracking such stats over time can help us detect compile-time
regressions. Added stats are more stable than the actual measured
compilation time, so expect the detected regressions to be less noisy.
On relanding drop stats in MemoryBuffer.cpp as their value is pretty low
but affects a lot of clients and many of those aren't interested in
modules and header search.
rdar://problem/
55715134
Reviewed By: aprantl, bruno
Differential Revision: https://reviews.llvm.org/D86895
Stanislav Mekhanoshin [Thu, 15 Oct 2020 21:57:34 +0000 (14:57 -0700)]
[AMDGPU] flat scratch ST addressing mode on gfx10
GFX10 enables third addressing mode for flat scratch instructions,
an ST mode. In that mode both register operands are omitted and
only swizzled offset is used in addition to flat_scratch base.
Differential Revision: https://reviews.llvm.org/D89501
Walter Erquinigo [Wed, 14 Oct 2020 17:25:39 +0000 (10:25 -0700)]
[trace] rename ThreadIntelPT into TraceTrace
Renamed ThreadIntelPT to TreaceThread, making it a top-level class. I noticed that this class can and shuld work for any trace plugin and there's nothing intel-pt specific in it.
With that TraceThread change, I was able to move most of the json file parsing logic to the base class TraceSessionFileParser, which makes adding new plug-ins easier.
This originally was part of https://reviews.llvm.org/D89283
Differential Revision: https://reviews.llvm.org/D89408
Jordan Rupprecht [Mon, 19 Oct 2020 22:11:37 +0000 (15:11 -0700)]
[NFC] Inline assertion-only variable
Sergei Trofimovich [Mon, 19 Oct 2020 21:51:12 +0000 (22:51 +0100)]
[VE] Fix initializer visibility
Before the change attempt to link libLTO.so against shared
LLVM library failed as:
```
[ 76%] Linking CXX shared library ../../lib/libLTO.so
... /usr/bin/cmake -E cmake_link_script CMakeFiles/LTO.dir/link.txt --verbose=1
c++ -o ...libLTO.so.12git ...ibLLVM-12git.so
ld: CMakeFiles/LTO.dir/lto.cpp.o: in function `llvm::InitializeAllTargetInfos()':
include/llvm/Config/Targets.def:31: undefined reference to `LLVMInitializeVETargetInfo'
```
It happens because on linux llvm build system sets default
symbol visibility to "hidden". The fix is to set visibility
back to "default" for exported APIs with LLVM_EXTERNAL_VISIBILITY.
Bug: https://bugs.llvm.org/show_bug.cgi?id=47847
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D89633
Yaxun (Sam) Liu [Wed, 23 Sep 2020 22:00:23 +0000 (18:00 -0400)]
Recommit "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions"
This recommits
7f1f89ec8d9944559042bb6d3b1132eabe3409de and
40df06cdafc010002fc9cfe1dda73d689b7d27a6 with bug fixes for
memory sanitizer failure and Tensile build failure.
Yaxun (Sam) Liu [Wed, 23 Sep 2020 20:16:00 +0000 (16:16 -0400)]
[NFC] Refactor DiagnosticBuilder and PartialDiagnostic
PartialDiagnostic misses some functions compared to DiagnosticBuilder.
This patch refactors DiagnosticBuilder and PartialDiagnostic, extracts
the common functionality so that the streaming << operators are
shared.
Differential Revision: https://reviews.llvm.org/D84362
Amy Huang [Mon, 19 Oct 2020 21:31:17 +0000 (14:31 -0700)]
[NPM] Port module-debuginfo pass to the new pass manager
Port pass to NPM and update tests in DebugInfo/Generic.
Differential Revision: https://reviews.llvm.org/D89730
Roman Lebedev [Mon, 19 Oct 2020 19:28:44 +0000 (22:28 +0300)]
[NFCI][SCEV] Always refer to enum SCEVTypes as enum, not integer
The main tricky thing here is forward-declaring the enum:
we have to specify it's underlying data type.
In particular, this avoids the danger of switching over the SCEVTypes,
but actually switching over an integer, and not being notified
when some case is not handled.
I have updated most of such switches to be exaustive and not have
a default case, where it's pretty obvious to be the intent,
however not all of them.
Roman Lebedev [Mon, 19 Oct 2020 20:41:26 +0000 (23:41 +0300)]
[NFC][SCEV] BuildConstantFromSCEV(): reformat, NFC
Makes diff in next commit more readable
Roman Lebedev [Mon, 19 Oct 2020 19:39:55 +0000 (22:39 +0300)]
[NFC][SCEVExpander] isHighCostExpansionHelper(): rewrite as a switch
If we switch over an enum, compiler can easily issue a diagnostic
if some case is not handled. However with an if cascade that isn't so.
Experimental evidence suggests new behavior to be superior.
Dávid Bolvanský [Mon, 19 Oct 2020 21:08:27 +0000 (23:08 +0200)]
[Intrinsics] Added writeonly attribute to the first arg of llvm.memmove
D18714 introduced writeonly attribute:
"Also start using the attribute for memset, memcpy, and memmove intrinsics,
and remove their special-casing in BasicAliasAnalysis."
But actually, writeonly was not attached to memmove - oversight, it seems.
So let's add it. As we can see, this helps DSE to eliminate redundant stores.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D89724
Martin Storsjö [Sun, 18 Oct 2020 20:19:29 +0000 (23:19 +0300)]
[libcxx] [test] Use _putenv instead of setenv/unsetenv on windows
Move the functions to the helper header and keep the arch specific
logic there.
Differential Revision: https://reviews.llvm.org/D89681
Martin Storsjö [Sun, 18 Oct 2020 19:47:50 +0000 (22:47 +0300)]
[libcxx] [test] Fix all remaining issues with fs::path::string_type being wstring
Use fs::path as variable type instead of std::string, when the input
potentially is a path, as they can't be implicitly converted back to
string.
Differential Revision: https://reviews.llvm.org/D89674
Martin Storsjö [Tue, 13 Oct 2020 18:42:31 +0000 (21:42 +0300)]
[libcxx] [test] Fix filesystem_test_helper.h to compile for windows
Use .string() instead of .native() in places where we want to combine
paths with std::string.
Convert some methods to take a fs::path as parameter instead of
std::string, for cases where they are called with paths as
parameters (which can't be implicitly converted to std::string if
the path's string_type is wstring).
Differential Revision: https://reviews.llvm.org/D89530
Martin Storsjö [Mon, 19 Oct 2020 08:44:19 +0000 (11:44 +0300)]
[libcxx] [test] Mark tests that require specific allocation behaviours as libcpp only
This fixes/silences a few failures on libstdc++ on linux.
Differential Revision: https://reviews.llvm.org/D89676
Martin Storsjö [Mon, 19 Oct 2020 08:07:31 +0000 (11:07 +0300)]
[libcxx] [test] Exclude domain socket tests on windows, like bsd/darwin
Differential Revision: https://reviews.llvm.org/D89673
Martin Storsjö [Mon, 19 Oct 2020 07:58:31 +0000 (10:58 +0300)]
[libcxx] [test] Add LIBCPP_ONLY() around another test for an implementation detail
Differential Revision: https://reviews.llvm.org/D89675
Martin Storsjö [Mon, 19 Oct 2020 08:46:08 +0000 (11:46 +0300)]
[libcxx] [test] Don't require fs::path::operator(string_type&&) to be noexcept
Mark this as a libcpp specific test; the standard doesn't say that
this method should be noexcept.
Differential Revision: https://reviews.llvm.org/D89677
Martin Storsjö [Mon, 19 Oct 2020 08:46:58 +0000 (11:46 +0300)]
[libcxx] [test] Allow fs::permissions(path, perms, perm_options, error_code) to be noexcept
The standard doesn't declare this overload as noexcept, but doesn't
either say that it strictly cannot be noexcept either. The function
doesn't throw on errors that are signaled via error_code, but the
standard says that it may throw a bad_alloc.
This fixes an error with libstdc++ on linux.
Differential Revision: https://reviews.llvm.org/D89678
Martin Storsjö [Mon, 19 Oct 2020 08:49:17 +0000 (11:49 +0300)]
[libcxx] [test] Do error printfs to stderr in filesystems tests
This makes them more readable in llvm-lit's output on failures.
This only applies the change on the filesystem test subdir.
Differential Revision: https://reviews.llvm.org/D89680
Martin Storsjö [Mon, 19 Oct 2020 13:10:18 +0000 (16:10 +0300)]
[clang] Automatically link against oldnames just as linking against libcmt
Differential Revision: https://reviews.llvm.org/D89702
Duncan P. N. Exon Smith [Wed, 14 Oct 2020 16:58:19 +0000 (12:58 -0400)]
clang/{Format,Rewrite}: Stop using SourceManager::getBuffer, NFC
Update clang/lib/Format and clang/lib/Rewrite to use a `MemoryBufferRef`
from `getBufferOrFake` instead of `MemoryBuffer*` from `getBuffer`.
No functionality change here, since the call sites weren't checking if
the buffer was valid.
Differential Revision: https://reviews.llvm.org/D89406
Evgenii Stepanov [Thu, 15 Oct 2020 23:10:42 +0000 (16:10 -0700)]
Add alloca size threshold for StackTagging initializer merging.
Summary:
Initializer merging generates pretty inefficient code for large allocas
that also happens to trigger an exponential algorithm somewhere in
Machine Instruction Scheduler. See https://bugs.llvm.org/show_bug.cgi?id=47867.
This change adds an upper limit for the alloca size. The default limit
is selected such that worst case size of memtag-generated code is
similar to non-memtag (but because of the ISA quirks, this case is
realized at the different value of alloca size, ex. memset inlining
triggers at sizes below 512, but stack tagging instructions are 2x
shorter, so limit is approx. 256).
We could try harder to emit more compact code with initializer merging,
but that would only affect large, sparsely initialized allocas, and
those are doing fine already.
Reviewers: vitalybuka, pcc
Subscribers: llvm-commits
Arthur Eubanks [Mon, 19 Oct 2020 20:09:39 +0000 (13:09 -0700)]
[test][NPM] Fix already-vectorized.ll under NPM
The NPM runs SpeculateAroundPHIs which breaks critical edges, causing a
branch we check for to not directly jump back to the same block.
Craig Topper [Mon, 19 Oct 2020 19:03:04 +0000 (12:03 -0700)]
[SelectionDAG][X86] Enable SimplifySetCC CTPOP transforms for vector splats
This enables these transforms for vectors:
(ctpop x) u< 2 -> (x & x-1) == 0
(ctpop x) u> 1 -> (x & x-1) != 0
(ctpop x) == 1 --> (x != 0) && ((x & x-1) == 0)
(ctpop x) != 1 --> (x == 0) || ((x & x-1) != 0)
All enabled if CTPOP isn't Legal. This differs from the scalar
behavior where the first two are done unconditionally and the
last two are done if CTPOP isn't Legal or Custom. The Legal
check produced better results for vectors based on X86's
custom handling. Might be worth re-visiting scalars here.
I disabled the looking through truncate for vectors. The
code that creates new setcc can use the same result VT as the
original setcc even if we truncated the input. That may work
work for most scalars, but definitely wouldn't work for vectors
unless it was a vector of i1.
Fixes or at least improves PR47825
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D89346
Craig Topper [Mon, 19 Oct 2020 18:50:47 +0000 (11:50 -0700)]
[X86] Add i32->float and i64->double bitcast pseudo instructions to store folding table.
We have pseudo instructions we use for bitcasts between these types.
We have them in the load folding table, but not the store folding
table. This adds them there so they can be used for stack spills.
I added an exact size check so that we don't fold when the stack slot
is larger than the GPR. Otherwise the upper bits in the stack slot
would be garbage. That would be fine for Eli's test case in PR47874,
but I'm not sure its safe in general.
A step towards fixing PR47874. Next steps are to change the ADDSSrr_Int
pseudo instructions to use FR32 as the second source register class
instead of VR128. That will keep the coalescer from promoting the
register class of the bitcast instruction which will make the stack
slot 4 bytes instead of 16 bytes.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D89656
Matt Arsenault [Sat, 17 Oct 2020 14:12:30 +0000 (10:12 -0400)]
Fix typo
Lang Hames [Mon, 19 Oct 2020 18:55:08 +0000 (11:55 -0700)]
[ORC] Fix a missing include.
Arthur Eubanks [Mon, 19 Oct 2020 19:04:31 +0000 (12:04 -0700)]
[NPM][test] Fix some LoopVectorize tests under NPM
Nikita Popov [Mon, 19 Oct 2020 18:51:37 +0000 (20:51 +0200)]
[BatchAA] Add test for incorrect phi cycle result (NFC)
AA computes the correct result for phi/a1 aliasing, while BatchAA
produces an incorrect result depening on which queries have been
performed beforehand.
Tony [Mon, 19 Oct 2020 17:19:30 +0000 (17:19 +0000)]
[AMDGPU] Correct comment typo in SIMemoryLegaliizer.cpp
Arthur Eubanks [Mon, 19 Oct 2020 18:28:45 +0000 (11:28 -0700)]
[NPM][opt] Run -O# after other passes in legacy PM compatibility mode
Generally tests run -O# before other passes, not after.
Valentin Clement [Mon, 19 Oct 2020 18:47:12 +0000 (14:47 -0400)]
[flang][openacc] Switch to use TODO from D88909
Use the Todo.h header file introduce in D88909 to marke part of the lowering that are
not done yet.
Reviewed By: jeanPerier
Differential Revision: https://reviews.llvm.org/D88915
Alexandre Ganea [Mon, 19 Oct 2020 18:27:41 +0000 (14:27 -0400)]
[LLDB][TestSuite] Improve skipIfWindowsAndNonEnglish in decorators.py
Differential Revision: https://reviews.llvm.org/D89716
Cameron McInally [Mon, 19 Oct 2020 18:26:29 +0000 (13:26 -0500)]
[SVE] Update vector reduction intrinsics in new tests.
Remove `experimental` from the intrinsic names.
Michael Jones [Tue, 13 Oct 2020 23:20:50 +0000 (23:20 +0000)]
[libc] Add LLVM libc specific functions to llvm_libc_ext.td.
Also moved most of the common type definitions from libc/spec/stdc.td
to libc/spec/spec.td so that they can be used to list functions in llvm_libc_ext.td.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D89436
Jay Foad [Mon, 19 Oct 2020 15:34:54 +0000 (16:34 +0100)]
[AMDGPU] Remove MUL_LOHI_U24/MUL_LOHI_I24
These were introduced in r279902 on the grounds that using separate
MUL_U24/MUL_I24 and MULHI_U24/MULHI_I24 nodes would introduce multiple
uses of the operands, which would prevent SimplifyDemandedBits from
simplifying the operands.
This has since been fixed by D24672 "AMDGPU/SI: Use new SimplifyDemandedBits helper for multi-use operations"
No functional change intended. At least it has no effect on lit tests.
Differential Revision: https://reviews.llvm.org/D89706
Joseph Huber [Mon, 19 Oct 2020 13:07:02 +0000 (09:07 -0400)]
[OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts
The changes made in D88594 caused the test OpenMP/driver.c to fail on a 32-bit host becuase it was offloading to a 64-bit architecture by default. The offloading test was moved to a new file and a feature was added to the lit config to check for a 64-bit host.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D89696
Atmn Patel [Mon, 19 Oct 2020 17:29:10 +0000 (13:29 -0400)]
[LangRef] Define mustprogress attribute
LLVM IR currently assumes some form of forward progress. This form is
not explicitly defined anywhere, and is the cause of miscompilations
in most languages that are not C++11 or later. This implicit forward progress
guarantee can not be opted out of on a function level nor on a loop
level. Languages such as C (C11 and later), C++ (pre-C++11), and Rust
have different forward progress requirements and this needs to be
evident in the IR.
Specifically, C11 and onwards (6.8.5, Paragraph 6) states that "An
iteration statement whose controlling expression is not a constant
expression, that performs no input/output operations, does not access
volatile objects, and performs no synchronization or atomic operations
in its body, controlling expression, or (in the case of for statement)
its expression-3, may be assumed by the implementation to terminate."
C++11 and onwards does not have this assumption, and instead assumes
that every thread must make progress as defined in [intro.progress] when
it comes to scheduling.
This was initially brought up in [0] as a bug, a solution was presented
in [1] which is the current workaround, and the predecessor to this
change was [2].
After defining a notion of forward progress for IR, there are two
options to address this:
1) Set the default to assuming Forward Progress and provide an opt-out for functions and an opt-in for loops.
2) Set the default to not assuming Forward Progress and provide an opt-in for functions, and an opt-in for loops.
Option 2) has been selected because only C++11 and onwards have a
forward progress requirement and it makes sense for them to opt-into it
via the defined `mustprogress` function attribute. The `mustprogress`
function attribute indicates that the function is required to make
forward progress as defined. This is sharply in contrast to the status
quo where this is implicitly assumed. In addition, `willreturn` implies `mustprogress`.
The background for why this definition was chosen is in [3] and for why
the option was chosen is in [4] and the corresponding thread(s). The implementation is in D85393, the
clang patch is in D86841, the LoopDeletion patch is in D86844, the
Inliner patches are in D87180 and D87262, and there will be more
incoming.
[0] https://bugs.llvm.org/show_bug.cgi?id=965#c25
[1] https://lists.llvm.org/pipermail/llvm-dev/2017-October/118558.html
[2] https://reviews.llvm.org/D65718
[3] https://lists.llvm.org/pipermail/llvm-dev/2020-September/144919.html
[4] https://lists.llvm.org/pipermail/llvm-dev/2020-September/145023.html
Reviewed By: jdoerfert, efriedma, nikic
Differential Revision: https://reviews.llvm.org/D86233
Mikhail Maltsev [Mon, 19 Oct 2020 17:30:51 +0000 (18:30 +0100)]
[clang] Use SourceLocation as key in std::map, NFCI
SourceLocation implements `operator<`, so `SourceLocation`-s can be used
as keys in `std::map` directly, there is no need to extract the internal
representation.
Since the `operator<` simply compares the internal representations of
its operands, this patch does not introduce any functional changes.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D89705
Florian Hahn [Mon, 19 Oct 2020 16:25:34 +0000 (17:25 +0100)]
[SCEV] Add tests where assumes can be used to improve tripe multiple.
This patch adds a set of tests where information from assumes can be
used to improve the trip multiple.
See PR47904.
Louis Dionne [Fri, 16 Oct 2020 18:19:39 +0000 (14:19 -0400)]
[libc++] Add more tests for operator<< on std::complex
Amy Kwan [Thu, 15 Oct 2020 16:24:21 +0000 (11:24 -0500)]
[DAGCombiner][PowerPC] Remove isMulhCheaperThanMulShift TLI hook, Use isOperationLegalOrCustom directly instead.
MULH is often expanded on targets.
This patch removes the isMulhCheaperThanMulShift hook and uses
isOperationLegalOrCustom instead.
Differential Revision: https://reviews.llvm.org/D80485
Jonas Devlieghere [Mon, 19 Oct 2020 17:18:20 +0000 (10:18 -0700)]
[llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools
For testing purposes I need a way to build and install FileCheck and
yaml2obj. I had to choose between making FileCheck an LLVM tool and
making obj2yaml and yaml2obj utilities. I think the distinction is
rather arbitrary but my understanding is that tools are things meant for
the toolchain while utilities are more used for things like testing,
which is the case here.
The functional difference is that these tools now end up in the
${LLVM_UTILS_INSTALL_DIR}, which defaults to the ${LLVM_TOOLS_INSTALL_DIR}.
Unless you specified a different value or you added obj2yaml and
yaml2obj to ${LLVM_TOOLCHAIN_TOOLS}, this patch shouldn't change
anything.
Differential revision: https://reviews.llvm.org/D89357
Tony [Mon, 19 Oct 2020 01:04:06 +0000 (01:04 +0000)]
[AMDGPU] Simplify cumode handling in SIMemoryLegalizer
Differential Revision: https://reviews.llvm.org/D89663
Tony [Sat, 17 Oct 2020 22:38:04 +0000 (22:38 +0000)]
[AMDGPU] Extend hip-toolchin-features.hip test
- Extend hip-toolchin-features.hip to also check the lld attributes
are passed correctly.
- Add check for cumode attributes.
Differential Revision: https://reviews.llvm.org/D89636
Tony [Sat, 17 Oct 2020 21:59:54 +0000 (21:59 +0000)]
[AMDGPU] Correct hsa-diag-v3.s test
- Use file_check -LABEL markers to prevent false positives being
reported due to messages from different tests causing success to be
reported.
- Add checks for all the run commands for more robust testing.
- Add checks for the absence of errors.
- Name and order tests more sensibly.
Differential Revision: https://reviews.llvm.org/D89635
Mircea Trofin [Mon, 19 Oct 2020 16:13:47 +0000 (09:13 -0700)]
[NFC][MC] Type [MC]Register uses in MachineTraceMetrics
Differential Revision: https://reviews.llvm.org/D89710
Alex Richardson [Mon, 19 Oct 2020 16:22:54 +0000 (17:22 +0100)]
[libc++] Skip tests using constexpr destructors with older clang versions
It appears that the released version of clang that supports constexpr
destructors is clang 10 and the oldest one that accepts -std=c++2a is 5,
so mark these as UNSUPPORTED for clang-5 to clang-9.
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D89704
sameeran joshi [Tue, 6 Oct 2020 04:51:06 +0000 (10:21 +0530)]
[Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct.
From OpenACC 3.0 Standards document
840 • A program may not branch into or out of an OpenACC parallel construct.
Exits are allowed provided it does not cause an exit outside the parallel region.
Test case exits out of the inner do loop, but it is still inside the parallel region.
Patch tries to extract labels from block attached to a construct,
If the exit is to a label not in the collected list then flags an error.
Reviewed By: tskeith
Differential Revision: https://reviews.llvm.org/D87906
Louis Dionne [Fri, 16 Oct 2020 14:33:18 +0000 (10:33 -0400)]
[libc++] Refactor the fuzzing tests
Define all the fuzzing tests in libcxx/test/libcxx/fuzzing, and get
rid of the ad-hoc libcxx/fuzzing directory, which wasn't properly
integrated with the build system or test suite.
As a fly-by change, this also reduces the dependencies of fuzzing tests
on large library components like <iostream>, to make them work on more
platforms.
Lang Hames [Mon, 19 Oct 2020 15:45:38 +0000 (08:45 -0700)]
[ORC] Fix unused variable warning.
Simon Pilgrim [Mon, 19 Oct 2020 16:05:38 +0000 (17:05 +0100)]
[InstCombine] foldOrOfICmps - only fold (icmp_eq B, 0) | (icmp_ult/gt A, B) for integer types
Fixes a number of stage2 buildbots that were failing when I generalized the m_ConstantInt() logic - that didn't match for pointer types but m_Zero() does......
Mircea Trofin [Sat, 17 Oct 2020 15:40:44 +0000 (08:40 -0700)]
[ML] Add final reward logging facility.
Allow logging final rewards. A final reward is logged only once, and is
serialized as all-zero values, except for the last one.
Differential Revision: https://reviews.llvm.org/D89626
Nabeel Omer [Mon, 19 Oct 2020 15:38:49 +0000 (16:38 +0100)]
[Dexter][NFC] Add Missing Commands to Commands.md Contents
NFC patch simply updates the commands.md documentation contents with missing
links to the DexLimitSteps and DexLabel command documentation.
Differential Revision: https://reviews.llvm.org/D89689
Author: Nabeel Omer <nabeel.omer@sony.com>
Louis Dionne [Tue, 1 Oct 2019 13:34:58 +0000 (09:34 -0400)]
[libc++] Define new/delete in libc++abi only by default
Previously, we would define new/delete in both libc++ and libc++abi.
Not only does this cause code bloat, but also it's technically an ODR
violation since we don't know which operator will be selected. Furthermore,
since those are weak definitions, we should strive to have as few of them
as possible (to improve load times).
My preferred choice would have been to put the operators in libc++ only
by default, however that would create a circular dependency between
libc++ and libc++abi, which GNU linkers don't handle.
Folks who want to ship new/delete in libc++ instead of libc++abi are
free to do so by turning on LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS at
CMake configure time.
On Apple platforms, this shouldn't be an ABI break because we re-export
the new/delete symbols from libc++abi. This change actually makes libc++
behave closer to the system libc++ shipped on Apple platforms.
On other platforms, this is an ABI break for people linking against libc++
but not libc++abi. However, vendors have been consulted in D68269 and no
objection was raised. Furthermore, the definitions can be controlled to
appear in libc++ instead with the CMake option.
Differential Revision: https://reviews.llvm.org/D68269
Casey Carter [Mon, 19 Oct 2020 15:33:58 +0000 (08:33 -0700)]
[libc++][test] Portably silence warnings
... in `<numbers>` tests with `[[maybe_unused]]`.
Alex Richardson [Mon, 19 Oct 2020 15:21:10 +0000 (16:21 +0100)]
[lit] Avoid calling realpath() for every printed message
I did some profiling of lit while trying to optimize the libc++ test
startup for remote hosts and it turns out that there is a realpath() call
for every message printed and this shows up in the profile.
The inspect.getframeinfo() function calls realpath() internally and
moreover we don't need most of the other information returned from it.
This patch uses inspect.getsourcefile() and os.path.abspath() to remove
../ from the path instead. Not resolving symlinks reduces the startup time
for running a single test with lit by about 50ms for me.
Reviewed By: ldionne, yln
Differential Revision: https://reviews.llvm.org/D89186
Simon Pilgrim [Mon, 19 Oct 2020 15:03:21 +0000 (16:03 +0100)]
Revert rGa704d8238c86bac: "[InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3)) uniform vector support"
This reverts commit
a704d8238c86bac524f14adb6b04e0908a324e15.
Causing stage2 build failures on some bots.
Nathan James [Mon, 19 Oct 2020 14:57:46 +0000 (15:57 +0100)]
[clang-tidy] Add scoped enum constants to identifier naming check
Added option `ScopedEnumConstant(Prefix|Case|Suffix)` to readability-identitied-naming.
This controls the style for constants in scoped enums, declared as enum (class|struct).
If this option is unspecified the EnumConstant style will be used instead.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D89407
Peter Steinfeld [Sat, 17 Oct 2020 01:27:51 +0000 (18:27 -0700)]
[flang] Add name match checks for interface procedures
We had neglected to check for name mismatches for procedure definitions that
appear in interfaces.
I also changed label11.f90 to an error test since I think they're better than
"FileCheck" tests.
Differential Revision: https://reviews.llvm.org/D89611
Sam McCall [Mon, 19 Oct 2020 14:45:32 +0000 (16:45 +0200)]
[clangd] Add test for structured-binding completion. NFC
George Mitenkov [Mon, 19 Oct 2020 14:20:11 +0000 (17:20 +0300)]
[MLIR][SPIRVToLLVM] Updated documentation for composite ops
Added a section on composite ops (`spv.CompositeExtract` and
`spv.CompositeInsert`) conversion.
Reviewed By: antiagainst
Differential Revision: https://reviews.llvm.org/D89658
Simon Pilgrim [Mon, 19 Oct 2020 14:41:07 +0000 (15:41 +0100)]
[InstCombine] Add (icmp ne A, 0) | (icmp ne B, 0) --> (icmp ne (A|B), 0) vector support
Scalar cases were already being handled by foldLogOpOfMaskedICmps (so this was dead code), but refactoring to support non-uniform vectors will take some time, so tweak this fold in the meantime.
Aaron Ballman [Mon, 19 Oct 2020 14:36:15 +0000 (10:36 -0400)]
Revert "Extend tests of run-clang-tidy"
This reverts commit
627c01bee0deb353b3e3e90c1b8d0b6d73464466.
Some failing build bots:
http://lab.llvm.org:8011/#/builders/109/builds/690
http://lab.llvm.org:8011/#/builders/14/builds/476