Cristian Rodríguez [Tue, 12 May 2015 02:30:38 +0000 (23:30 -0300)]
core: fix memory leak in manager_run_generators()
If systemd is built with GCC address sanitizer or leak sanitizer
the following memory leak ocurs:
May 12 02:02:46 linux.site systemd[326]: =================================================================
May 12 02:02:46 linux.site systemd[326]: ==326==ERROR: LeakSanitizer: detected memory leaks
May 12 02:02:46 linux.site systemd[326]: Direct leak of 101 byte(s) in 3 object(s) allocated from:
May 12 02:02:46 linux.site systemd[326]: #0 0x7fd1f504993f in strdup (/usr/lib64/libasan.so.2+0x6293f)
May 12 02:02:46 linux.site systemd[326]: #1 0x55d6ffac5336 in strv_new_ap src/shared/strv.c:163
May 12 02:02:46 linux.site systemd[326]: #2 0x55d6ffac56a9 in strv_new src/shared/strv.c:185
May 12 02:02:46 linux.site systemd[326]: #3 0x55d6ffa80272 in generator_paths src/shared/path-lookup.c:223
May 12 02:02:46 linux.site systemd[326]: #4 0x55d6ff9bdb0f in manager_run_generators src/core/manager.c:2828
May 12 02:02:46 linux.site systemd[326]: #5 0x55d6ff9b1a10 in manager_startup src/core/manager.c:1121
May 12 02:02:46 linux.site systemd[326]: #6 0x55d6ff9a78e3 in main src/core/main.c:1667
May 12 02:02:46 linux.site systemd[326]: #7 0x7fd1f394e8c4 in __libc_start_main (/lib64/libc.so.6+0x208c4)
May 12 02:02:46 linux.site systemd[326]: Direct leak of 29 byte(s) in 1 object(s) allocated from:
May 12 02:02:46 linux.site systemd[326]: #0 0x7fd1f504993f in strdup (/usr/lib64/libasan.so.2+0x6293f)
May 12 02:02:46 linux.site systemd[326]: #1 0x55d6ffac5288 in strv_new_ap src/shared/strv.c:152
May 12 02:02:46 linux.site systemd[326]: #2 0x55d6ffac56a9 in strv_new src/shared/strv.c:185
May 12 02:02:46 linux.site systemd[326]: #3 0x55d6ffa80272 in generator_paths src/shared/path-lookup.c:223
May 12 02:02:46 linux.site systemd[326]: #4 0x55d6ff9bdb0f in manager_run_generators src/core/manager.c:2828
May 12 02:02:46 linux.site systemd[326]: #5 0x55d6ff9b1a10 in manager_startup src/core/manager.c:1121
May 12 02:02:46 linux.site systemd[326]: #6 0x55d6ff9a78e3 in main src/core/main.c:1667
May 12 02:02:46 linux.site systemd[326]: #7 0x7fd1f394e8c4 in __libc_start_main (/lib64/libc.so.6+0x208c4)
May 12 02:02:46 linux.site systemd[326]: SUMMARY: AddressSanitizer: 130 byte(s) leaked in 4 allocation(s).
There is a leak due to the the use of cleanup_free instead _cleanup_strv_free_
Iago López Galeiras [Wed, 13 May 2015 13:45:49 +0000 (15:45 +0200)]
nspawn: skip symlink to a combined cgroup hierarchy if it already exists
If a symlink to a combined cgroup hierarchy already exists and points to
the right path, skip it. This avoids an error when the cgroups are set
manually before calling nspawn.
Iago López Galeiras [Wed, 13 May 2015 13:45:48 +0000 (15:45 +0200)]
nspawn: only mount the cgroup root if it's not already mounted
This allows the user to set the cgroups manually before calling nspawn.
Dimitri John Ledkov [Wed, 13 May 2015 13:43:04 +0000 (14:43 +0100)]
Default to /usr/bin/u?mount, configurable, rather than hard-coded /bin/u?mount.
Lennart Poettering [Wed, 13 May 2015 12:40:37 +0000 (14:40 +0200)]
core: never create device depencies for /dev/root mounts
http://lists.freedesktop.org/archives/systemd-devel/2015-May/031658.html
Lennart Poettering [Wed, 13 May 2015 12:04:55 +0000 (14:04 +0200)]
nspawn: rework custom mount point order, and add support for overlayfs
Previously all bind mount mounts were applied in the order specified,
followed by all tmpfs mounts in the order specified. This is
problematic, if bind mounts shall be placed within tmpfs mounts.
This patch hence reworks the custom mount point logic, and alwas applies
them in strict prefix-first order. This means the order of mounts
specified on the command line becomes irrelevant, the right operation
will always be executed.
While we are at it this commit also adds native support for overlayfs
mounts, as supported by recent kernels.
Cristian Rodríguez [Mon, 11 May 2015 18:37:47 +0000 (15:37 -0300)]
modules-load: fix memory leak
=================================================================
==64281==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x7f623c961c4a in malloc (/usr/lib64/libasan.so.2+0x96c4a)
#1 0x5651f79ad34e in malloc_multiply (/home/crrodriguez/scm/systemd/systemd-modules-load+0x2134e)
#2 0x5651f79b02d6 in strjoin (/home/crrodriguez/scm/systemd/systemd-modules-load+0x242d6)
#3 0x5651f79be1f5 in files_add (/home/crrodriguez/scm/systemd/systemd-modules-load+0x321f5)
#4 0x5651f79be6a3 in conf_files_list_strv_internal (/home/crrodriguez/scm/systemd/systemd-modules-load+0x326a3)
#5 0x5651f79bea24 in conf_files_list_nulstr (/home/crrodriguez/scm/systemd/systemd-modules-load+0x32a24)
#6 0x5651f79ad01a in main (/home/crrodriguez/scm/systemd/systemd-modules-load+0x2101a)
#7 0x7f623c11586f in __libc_start_main (/lib64/libc.so.6+0x2086f)
SUMMARY: AddressSanitizer: 32 byte(s) leaked in 1 allocation(s).
This happens due to the wrong cleanup attribute is used (free vs strv_free)
Cristian Rodríguez [Mon, 11 May 2015 18:01:37 +0000 (15:01 -0300)]
shared: Use O_EXCL with O_TMPFILE in open_tmpfile
In this usecase, the file will never be materialized
with linkat().
Thomas Hindoe Paaboel Andersen [Tue, 28 Apr 2015 18:59:36 +0000 (20:59 +0200)]
fsck: add enum with fsck exit codes
Tom Gundersen [Tue, 12 May 2015 17:06:33 +0000 (19:06 +0200)]
udevd: manager - move a few global variables into the Manager object
Tom Gundersen [Tue, 12 May 2015 16:37:04 +0000 (18:37 +0200)]
udevd: pass a Manager objcet to event handlers
Stop relying on global variables in event handlers, and move them
all to a Manager object instead.
Kay Sievers [Tue, 12 May 2015 15:58:59 +0000 (17:58 +0200)]
boot: function parameters are separated by comma
Tom Gundersen [Tue, 12 May 2015 15:21:51 +0000 (17:21 +0200)]
core: drop redundant logging about notification messages
Before:
May 12 17:11:22 tomegun-x2402 systemd[1]: systemd-udevd.service: Got notification message for unit.
May 12 17:11:22 tomegun-x2402 systemd[1]: systemd-udevd.service: Got notification message from PID 195 (READY=1)
May 12 17:11:22 tomegun-x2402 systemd[1]: systemd-udevd.service: Ggot READY=1
After:
May 12 17:11:22 tomegun-x2402 systemd[1]: systemd-udevd.service: Got notification message from PID 195 (READY=1)
Tom Gundersen [Tue, 12 May 2015 14:57:01 +0000 (16:57 +0200)]
udevd: remove stale comment
Tom Gundersen [Tue, 12 May 2015 14:55:29 +0000 (16:55 +0200)]
udevd: explicitly update queue file before answering to ping
This avoids updating the flag files twice for every loop, and also removes another dependency
in the main-loop, so we are freer to reshufle it as we want.
Tom Gundersen [Tue, 12 May 2015 14:51:31 +0000 (16:51 +0200)]
udevd: explicitly read out uevents we create ourselves
Rather than skippling ctrl handling whenever we have handlede inotify events
(and hence may have synthesized a 'change' event), just call the uevent
handling explicitly from on_inotify() so that the event queue is up-to-date.
Tom Gundersen [Tue, 12 May 2015 12:54:52 +0000 (14:54 +0200)]
udevd: move to sd-event-style event handlers
Tom Gundersen [Mon, 11 May 2015 22:22:29 +0000 (00:22 +0200)]
networkd: network_get - allow udev_device to be NULL
In containers we never have udev devices, so drop the assert.
This fixes an assertion introduced in
af3aa302741b6edb0729925febb5f8bc26721fe3.
Tom Gundersen [Mon, 11 May 2015 20:17:49 +0000 (22:17 +0200)]
udevd: make udev_ctrl_connection global
This allows us to simplify the ctrl_msg handler. Eventually all this global state should move to
a Manager object or so.
Thomas Hindoe Paaboel Andersen [Mon, 11 May 2015 21:52:29 +0000 (23:52 +0200)]
systemctl: fix check for template units
A typo from
7410616c. We want to ignore EINVAL but only catch errors.
Lennart Poettering [Mon, 11 May 2015 20:56:31 +0000 (22:56 +0200)]
update TODO
Lennart Poettering [Mon, 11 May 2015 20:53:54 +0000 (22:53 +0200)]
install: when exporting prefix InstallInfo to become UnitFileInstallInfo
All other types exported from install.h should be namespaces like this,
hence namespace InstallInfo the same way.
Also, remove external forward definition of UnitFileScope type.
Lennart Poettering [Mon, 11 May 2015 20:51:49 +0000 (22:51 +0200)]
core: rename SystemdRunningAs to ManagerRunningAs
It's primarily just a property of the Manager object after all, and we
try to refer to PID 1 as "manager" instead of "systemd", hence let's to
stick to this here too.
Lennart Poettering [Mon, 11 May 2015 20:28:52 +0000 (22:28 +0200)]
unit: move unit_warn_if_dir_nonempty() and friend to unit.c
The call is only used by the mount and automount unit types, but that's
already enough to consider it generic unit functionality, hence move it
out of mount.c and into unit.c.
Lennart Poettering [Mon, 11 May 2015 18:38:21 +0000 (20:38 +0200)]
core,network: major per-object logging rework
This changes log_unit_info() (and friends) to take a real Unit* object
insted of just a unit name as parameter. The call will now prefix all
logged messages with the unit name, thus allowing the unit name to be
dropped from the various passed romat strings, simplifying invocations
drastically, and unifying log output across messages. Also, UNIT= vs.
USER_UNIT= is now derived from the Manager object attached to the Unit
object, instead of getpid(). This has the benefit of correcting the
field for --test runs.
Also contains a couple of other logging improvements:
- Drops a couple of strerror() invocations in favour of using %m.
- Not only .mount units now warn if a symlinks exist for the mount
point already, .automount units do that too, now.
- A few invocations of log_struct() that didn't actually pass any
additional structured data have been replaced by simpler invocations
of log_unit_info() and friends.
- For structured data a new LOG_UNIT_MESSAGE() macro has been added,
that works like LOG_MESSAGE() but prefixes the message with the unit
name. Similar, there's now LOG_LINK_MESSAGE() and
LOG_NETDEV_MESSAGE().
- For structured data new LOG_UNIT_ID(), LOG_LINK_INTERFACE(),
LOG_NETDEV_INTERFACE() macros have been added that generate the
necessary per object fields. The old log_unit_struct() call has been
removed in favour of these new macros used in raw log_struct()
invocations. In addition to removing one more function call this
allows generated structured log messages that contain two object
fields, as necessary for example for network interfaces that are
joined into another network interface, and whose messages shall be
indexed by both.
- The LOG_ERRNO() macro has been removed, in favour of
log_struct_errno(). The latter has the benefit of ensuring that %m in
format strings is properly resolved to the specified error number.
- A number of logging messages have been converted to use
log_unit_info() instead of log_info()
- The client code in sysv-generator no longer #includes core code from
src/core/.
- log_unit_full_errno() has been removed, log_unit_full() instead takes
an errno now, too.
- log_unit_info(), log_link_info(), log_netdev_info() and friends, now
avoid double evaluation of their parameters
Lennart Poettering [Mon, 11 May 2015 18:13:37 +0000 (20:13 +0200)]
core: always initialize ExecParamters.bus_endpoint_fd to -1
Otherwise it might be passed in as 0, which is a valid fd, but usually
does not refer to a real endpoint.
Lennart Poettering [Mon, 11 May 2015 20:08:28 +0000 (22:08 +0200)]
units: order nspawn containers after network.target
This way we know that any bridges and other user-created network devices
are in place, and can be properly added to the container.
In the long run this should be dropped, and replaced by direct calls
inside nspawn that cause the devices to be created when necessary.
Lennart Poettering [Mon, 11 May 2015 18:09:58 +0000 (20:09 +0200)]
util: optimize free_and_strdup() if NOP
Under the assumption that strcmp() is cheaper than memory allocation,
let's avoid the allocation, if the new value is identical to the old.
Lennart Poettering [Thu, 7 May 2015 21:37:32 +0000 (14:37 -0700)]
nspawn: pass on kill signal setting to contaner scope
Let's just pass on what the user set for us.
Lennart Poettering [Thu, 7 May 2015 21:33:12 +0000 (14:33 -0700)]
update TODO
Thomas Hindoe Paaboel Andersen [Mon, 11 May 2015 19:41:31 +0000 (21:41 +0200)]
test-libudev: fix leak in error case
CID# 1297428
Thomas Hindoe Paaboel Andersen [Mon, 11 May 2015 19:01:51 +0000 (21:01 +0200)]
swap: avoid null pointer dereference
CID#1297436
Torstein Husebø [Mon, 11 May 2015 11:49:29 +0000 (13:49 +0200)]
treewide: Correct typos and spell plural of bus consistent
Zbigniew Jędrzejewski-Szmek [Wed, 6 May 2015 05:09:53 +0000 (01:09 -0400)]
Generate systemd-fsck-root.service in the initramfs
In the initrafms, generate a systemd-fsck-root.service to replace
systemd-fsck@<sysroot-device>.service. This way, after we transition
to the real root, systemd-fsck-root.service is marked as already done.
This introduces an unnecessary synchronization point, because
systemd-fsck@* is ordered after systemd-fsck-root also in the
initramfs. In practice this shouldn't be a problem.
https://bugzilla.redhat.com/show_bug.cgi?id=1201979
C.f.
956eaf2b8d6c9999024705ddadc7393bc707de02.
Zbigniew Jędrzejewski-Szmek [Sat, 9 May 2015 23:46:15 +0000 (19:46 -0400)]
man: fix typos in previous comimt
Zbigniew Jędrzejewski-Szmek [Sat, 9 May 2015 21:20:51 +0000 (16:20 -0500)]
man: document forwarding to syslog better
https://bugzilla.redhat.com/show_bug.cgi?id=1147651
Cristian Rodríguez [Sat, 9 May 2015 17:08:43 +0000 (14:08 -0300)]
buildsys: *_la_CPPFLAGS takes $(AM_CPPFLAGS) not $(AM_CFLAGS)
Thomas Hindoe Paaboel Andersen [Thu, 7 May 2015 05:26:34 +0000 (07:26 +0200)]
udevd: remove unused function
Tom Gundersen [Wed, 6 May 2015 21:36:36 +0000 (23:36 +0200)]
udevd: don't explicitly count the number of workers
Simply query the size of the hashmap keeping all the worker contexts instead.
Tom Gundersen [Wed, 6 May 2015 21:26:25 +0000 (23:26 +0200)]
udevd: keep workers in a hashmap rather than a list
This makes the code somewhat more readable.
Tom Gundersen [Mon, 27 Apr 2015 09:43:31 +0000 (11:43 +0200)]
udevd: worker - drop reference counting
Make the worker context have the same life-span as the worker process. It is created on fork()
and free'd on SIGCHLD.
The change means that we can get worker_returned() for a worker context that is no longer around,
this is not a problem and we can just drop the message. The only use for worker_returned() is to
know to reschedule events to workers that are still around, so if the worker has already exited
it is not important to keep track of. We still print a debug statement in this case to be on the
safe side.
Thomas Hindoe Paaboel Andersen [Wed, 6 May 2015 17:56:29 +0000 (19:56 +0200)]
device: avoid null pointer dereference
David Herrmann [Wed, 6 May 2015 16:59:03 +0000 (18:59 +0200)]
udev: fix weird coding-style
Eeeew!
Thomas Hindoe Paaboel Andersen [Wed, 6 May 2015 16:37:06 +0000 (18:37 +0200)]
test-libudev: add error handling
CID#1296244
Tom Gundersen [Wed, 6 May 2015 15:36:39 +0000 (17:36 +0200)]
udevd: worker - allow passing NULL to worker_unref()
Tom Gundersen [Tue, 21 Apr 2015 13:53:10 +0000 (15:53 +0200)]
udevd: worker - use _exit() rather than exit()
Follow the coding style and avoid the exit handlers.
Tom Gundersen [Mon, 27 Apr 2015 12:56:21 +0000 (14:56 +0200)]
udevd: modernize error handling
We never return magic exit codes, but just EXIT_FAILUER or EXIT_SUCCESS.
Tom Gundersen [Fri, 17 Apr 2015 21:18:24 +0000 (23:18 +0200)]
udevd: use kernel cmdline parser
Tom Gundersen [Mon, 27 Apr 2015 10:14:38 +0000 (12:14 +0200)]
udevd: worker - move some fields from the worker to the event
Tom Gundersen [Mon, 27 Apr 2015 09:33:41 +0000 (11:33 +0200)]
udevd: worker - introduce worker_attach_event()
Tom Gundersen [Mon, 27 Apr 2015 09:26:47 +0000 (11:26 +0200)]
udevd: worker - make refcounting clearer
Take and drop explicit references where it makes sense.
Tom Gundersen [Mon, 27 Apr 2015 09:11:58 +0000 (11:11 +0200)]
udevd: worker - only allocate the worker struct in the main process
This is not used in the worker, so avoid having to free it there.
Tom Gundersen [Mon, 27 Apr 2015 09:08:38 +0000 (11:08 +0200)]
udevd: rename worker_new() to worker_spawn()
Tom Gundersen [Sat, 25 Apr 2015 23:40:12 +0000 (01:40 +0200)]
udevd: don't track worker exitcode
We used to use this to track failed events so they could be retriggered,
but that is no longer done, so the code can be dropped.
David Herrmann [Wed, 6 May 2015 16:29:41 +0000 (18:29 +0200)]
Update TODO
Susant Sahani [Wed, 6 May 2015 06:15:13 +0000 (11:45 +0530)]
udev: fix coding style
Daniel Buch [Wed, 6 May 2015 08:28:08 +0000 (10:28 +0200)]
systemctl: null-initialize pointer with cleanup attribute
Thomas Hindoe Paaboel Andersen [Wed, 6 May 2015 16:23:11 +0000 (18:23 +0200)]
machinectl: remove unused variable
David Herrmann [Wed, 6 May 2015 16:18:43 +0000 (18:18 +0200)]
bus: don't switch to kdbus if not requested
Whenever systemd is re-executed, it tries to create a system bus via
kdbus. If the system did not have kdbus loaded during bootup, but the
module is loaded later on manually, this will cause two system buses
running (kdbus and dbus-daemon in parallel).
This patch makes sure we never try to create kdbus buses if it wasn't
explicitly requested on the command-line.
Zbigniew Jędrzejewski-Szmek [Wed, 6 May 2015 04:44:52 +0000 (23:44 -0500)]
timedated: remove unnecessary goto
Not needed since
99f861310d3f05f4.
Michael Olbrich [Thu, 30 Apr 2015 18:50:38 +0000 (20:50 +0200)]
tmpfiles: try to handle read-only file systems gracefully
On read-only filesystems trying to create the target will not fail with
EEXIST but with EROFS. Handle EROFS by checking if the target already
exists, and if empty when truncating.
This avoids reporting errors if tmpfiles doesn't actually needs to do
anything.
[zj: revert condition to whitelist rather then blacklisting, and add goto
to avoid stat'ting twice.]
Michael Olbrich [Thu, 30 Apr 2015 18:28:37 +0000 (20:28 +0200)]
shared/utmp-wtmp: fix copy/paste error
Zbigniew Jędrzejewski-Szmek [Wed, 6 May 2015 02:41:42 +0000 (22:41 -0400)]
Add audit type generated files to gitignore
They are not currently used, but the Makefile rules don't know that.
It's easier to ignore them, then to special-case creation rules.
Colin Walters [Mon, 4 May 2015 20:12:46 +0000 (16:12 -0400)]
lockfile-util.[ch]: Split out from util.[ch]
Continuing the general trend of splitting up util.[ch]. I specifically
want to reuse this code in https://github.com/GNOME/libglnx and
having it split up will make future copy-pasting easier.
Seth Jennings [Tue, 5 May 2015 18:31:01 +0000 (13:31 -0500)]
Fix permissions on /run/systemd/nspawn/locks
machined is getting an EACCES when trying to create the lock file for
images because the mode on /run/systemd/nspawn/locks is 0600.
mkdir("/run/systemd/nspawn/locks", 0600) = -1 EEXIST (File exists)
stat("/run/systemd/nspawn/locks", {st_mode=S_IFDIR|0600, st_size=40, ...}) = 0
open("/run/systemd/nspawn/locks/inode-41:256", O_RDWR|O_CREAT|O_NOCTTY|O_NOFOLLOW|O_CLOEXEC, 0600) = -1 EACCES (Permission denied)
This commit adjusts the mode to 0700 to correct the issue.
Torstein Husebø [Thu, 30 Apr 2015 09:57:09 +0000 (11:57 +0200)]
treewide: fix typos
Lennart Poettering [Tue, 5 May 2015 20:48:57 +0000 (13:48 -0700)]
update TODO
Lennart Poettering [Tue, 5 May 2015 20:48:28 +0000 (13:48 -0700)]
man: document that nspawn -x, --template= and machinectl clone leave hostname and machine id unmodified
Lennart Poettering [Tue, 5 May 2015 20:41:31 +0000 (13:41 -0700)]
man: nspawn is used in production these days, admit that
Previously, the man page suggested to only use nspawn for testing,
building, and debugging things. However, it is nowadays used in
production and used as building block for rocket, hence let's just admit
that it's pretty much production ready.
Lennart Poettering [Tue, 5 May 2015 20:39:14 +0000 (13:39 -0700)]
core: be more strict when manipulating slices names and unescaping paths from unit names
Let's better be safe then sorry.
Lennart Poettering [Sat, 2 May 2015 15:42:55 +0000 (17:42 +0200)]
core: bus name units should not allow aliases or instances
Lennart Poettering [Thu, 30 Apr 2015 18:21:00 +0000 (20:21 +0200)]
core: rework unit name validation and manipulation logic
A variety of changes:
- Make sure all our calls distuingish OOM from other errors if OOM is
not the only error possible.
- Be much stricter when parsing escaped paths, do not accept trailing or
leading escaped slashes.
- Change unit validation to take a bit mask for allowing plain names,
instance names or template names or an combination thereof.
- Refuse manipulating invalid unit name
Lennart Poettering [Thu, 30 Apr 2015 17:44:10 +0000 (19:44 +0200)]
util: be a bit safer in path_is_safe()
We should be more strict when verifying paths with path_is_safe() for
potentially dangerous constructs, and that includes lengths of
PATH_MAX-1 and larger. Be more accurate here.
Lennart Poettering [Thu, 30 Apr 2015 17:42:48 +0000 (19:42 +0200)]
cgroup-util: be more strict when processing slice unit names
Kay Sievers [Tue, 5 May 2015 20:05:46 +0000 (22:05 +0200)]
build-sys: remove left-over
Stephen Gallagher [Wed, 29 Apr 2015 12:19:05 +0000 (08:19 -0400)]
Add VARIANT as a standard value for /etc/os-release
Some distributions (such as Fedora) are using the VARIANT field to
indicate to select packages which of several default configurations
they should be using. For example, VARIANT=Server provides a
different default firewall configuration (blocking basically
everything but SSH and the management console) whereas
VARIANT=Workstation opens many other ports for application
compatibility.
By adding this patch to the manual pages, we can standardize on a
cross-distribution mechanism for accomplishing this.
Fedora implementation details are available at
https://fedoraproject.org/wiki/Packaging:Per-Product_Configuration
(David: drop double paranthesis)
Zbigniew Jędrzejewski-Szmek [Sat, 2 May 2015 17:01:29 +0000 (12:01 -0500)]
generators: rename add_{root,usr}_mount to add_{sysroot,sysroot_usr}_mount
This makes it obvious that those functions are only usable in the
initramfs.
Also, add a warning when noauto, nofail, or automount is used for the
root fs, instead of silently ignoring. Using those options would be a
sign of significant misconfiguration, and if we bother to check for
them, than let's go all the way and complain.
Other various small cleanups and reformattings elsewhere.
Patrik Flykt [Fri, 10 Apr 2015 11:03:18 +0000 (14:03 +0300)]
network: Implement fallback DHCPv6 prefix handling for older kernels
When setting IPv6 addresses acquired by DHCPv6, systemd-networkd sets
the IFA_F_NOPREFIXROUTE flag in the IFA_FLAGS netlink attribute. As
the flag and the attribute are present starting with Linux 3.14, older
kernels will need systemd-network to manage prefix route expiry.
By default, DHCPv6 addresses are first assigned setting the
IFA_F_NOPREFIXROUTE flag in the IFA_FLAGS netlink attribute. Should
the address assignment fail, the same assignment is tried without
the IFA_FLAGS attribute. Should also the second attempt fail, an error
is printed and address assignment ends with failure. As successful use
of the IFA_FLAGS netlink attribute is recorded in the Link structure,
the DHCPv6 code will know if the kernel or systemd-network fallback
code handles expiring prefixes.
The prefix expiration and IPv6 address updating fallback code is
resurrected from the parts deleted with commit
47d45d3cde45d6545367570264e4e3636bc9e345.
This patch can be removed once the minimum kernel requirements are
greater than or equal to 3.14.
Zbigniew Jędrzejewski-Szmek [Sat, 2 May 2015 17:01:28 +0000 (12:01 -0500)]
fstab-generator: fix memleak
filtered was used to store an allocated string twice. The first allocation was
thus lost. The string is not needed for anything, so simply skip the allocation.
Fixup for
deb0a77cf0b409141c4.
Zbigniew Jędrzejewski-Szmek [Sat, 2 May 2015 17:01:28 +0000 (12:01 -0500)]
man: use utf-8 in systemd-remount-fs.service(8)
Thomas Hindoe Paaboel Andersen [Thu, 30 Apr 2015 18:10:31 +0000 (20:10 +0200)]
terminal: update for simpler sd-bus api's
Lennart Poettering [Thu, 30 Apr 2015 10:35:15 +0000 (12:35 +0200)]
update TODO
Lennart Poettering [Thu, 30 Apr 2015 10:33:54 +0000 (12:33 +0200)]
core: simplify %r and %R logic a bit
Do not calculate the cgroup path manually, just use normal unit fields
and calls for that.
Lennart Poettering [Thu, 30 Apr 2015 10:33:35 +0000 (12:33 +0200)]
core: catch some special cases in cg_slice_to_path()
Lennart Poettering [Thu, 30 Apr 2015 10:01:19 +0000 (12:01 +0200)]
sym: adding missing symbols to .sym file
Lennart Poettering [Thu, 30 Apr 2015 09:58:06 +0000 (11:58 +0200)]
sd-bus,sd-login: add api for querying the slice within the the user systemd instance of a process
units are organized in slice trees, not only for the system instance,
but also for user systemd instances, expose this properly.
Lennart Poettering [Wed, 29 Apr 2015 23:54:18 +0000 (01:54 +0200)]
update TODO
Lennart Poettering [Wed, 29 Apr 2015 23:52:39 +0000 (01:52 +0200)]
man: update sd_bus_open() documentation
Update for current function prototypes.
Also, document -ESOCKTNOSUPPORT as being returned when protocol version
mismatches are detected.
Lennart Poettering [Wed, 29 Apr 2015 23:29:00 +0000 (01:29 +0200)]
core: simplify unit type detection logic
Introduce a new call unit_type_supported() and make use of it
everywhere.
Also, drop Manager parameter from per-type supported method prototype.
Lennart Poettering [Wed, 29 Apr 2015 23:24:48 +0000 (01:24 +0200)]
sd-bus: when we get ENOTTY on the HELLO ioctl assume incompatible API version
As perparation for future incompatible kdbus kernel API changes.
Lennart Poettering [Wed, 29 Apr 2015 22:49:31 +0000 (00:49 +0200)]
update TODO
Lennart Poettering [Wed, 29 Apr 2015 22:47:41 +0000 (00:47 +0200)]
core: rework cgroup path parse logic
Various cleanups, be stricter when parsing unit paths.
Most importantly: return the root slice "-.slice" when asked for slice
of paths that contain no slice component.
Susant Sahani [Wed, 22 Apr 2015 08:44:56 +0000 (14:14 +0530)]
networkd: add man for vti6 tunnel
Susant Sahani [Wed, 22 Apr 2015 08:44:55 +0000 (14:14 +0530)]
networkd: introduce vti6 tunnel
This patch add support to create vti6 tunnel
test:
vt6.network
[Match]
Name=wlan0
[Network]
Tunnel=ip6vti
vti6.netdev
[NetDev]
Name=ip6vti
Kind=vti6
[Tunnel]
Local=2a00:ffde:4567:edde::4987
Remote=2001:473:fece:cafe::5179
ip link
11: ip6_vti0@NONE: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT
group default
link/tunnel6 :: brd ::
12: ip6vti@wlan0: <POINTOPOINT,NOARP> mtu 1500 qdisc noop state DOWN
mode DEFAULT group default
link/tunnel6 2a00:ffde:4567:edde::4987 peer 2001:473:fece:cafe::5179
Susant Sahani [Wed, 22 Apr 2015 08:44:54 +0000 (14:14 +0530)]
networkd: tunnel improve logging
Replaces a lof ot strerror() usage with log_netdev_error_errno()
Lennart Poettering [Wed, 29 Apr 2015 19:45:45 +0000 (21:45 +0200)]
man: document when the various sd-login.h calls return ENXIO
Lennart Poettering [Wed, 29 Apr 2015 19:44:55 +0000 (21:44 +0200)]
man: document when the sd_bus_creds_xxx() calls return ENXIO
Lennart Poettering [Wed, 29 Apr 2015 19:40:54 +0000 (21:40 +0200)]
sd-bus: properly handle creds that are known but undefined for a process
A number of fields do not apply to all processes, including: there a
processes without a controlling tty, without parent process, without
service, user services or session. To distuingish these cases from the
case where we simply don't have the data, always return ENXIO for them,
while returning ENODATA for the case where we really lack the
information.
Also update the credentials dumping code to show this properly. Fields
that are known but do not apply are now shown as "n/a".
Note that this also changes some of the calls in process-util.c and
cgroup-util.c to return ENXIO for these cases.
Mantas Mikulėnas [Wed, 29 Apr 2015 18:29:18 +0000 (21:29 +0300)]
core: fix event source annotations
These looked like a mass-replace gone slightly wrong – two statements
with no { }'s, and no error checking.
Lennart Poettering [Wed, 29 Apr 2015 17:10:09 +0000 (19:10 +0200)]
tree-wide: get rid of a few more explicit bus parameters