Tim-Philipp Müller [Wed, 23 Nov 2011 20:03:32 +0000 (20:03 +0000)]
basevideodecoder: add API to drop a frame and post a QoS message on the bus
https://bugzilla.gnome.org/show_bug.cgi?id=640017
API: gst_base_video_decoder_drop_frame()
Tim-Philipp Müller [Tue, 22 Nov 2011 23:04:49 +0000 (23:04 +0000)]
docs: fix comment in gst_base_video_decoder_get_max_decode_time() docs
Tim-Philipp Müller [Tue, 22 Nov 2011 19:57:07 +0000 (19:57 +0000)]
basevideodecoder: fix weird event list handling
Get rid of weird code that copies a list manually, taking
ownership of the elements and then frees the old list. Instead,
just take over the old list entirely. (If the intent was to
reverse the list, one could use g_list_reverse() instead).
Then, push events in the list out from last to first (since they
were prepended as they came in) instead of just pushing out the
last in the list and leaking the others.
Sebastian Dröge [Fri, 25 Nov 2011 10:31:58 +0000 (11:31 +0100)]
omxaudioenc: Use audio base classes from gst-plugins-base instead of having our own copies
Sebastian Dröge [Fri, 18 Nov 2011 18:00:31 +0000 (10:00 -0800)]
omxaudioenc: First set ports to flushing before waiting for the srcpad streaming thread to finish
Sebastian Dröge [Fri, 18 Nov 2011 17:59:43 +0000 (09:59 -0800)]
omxvideoenc: First set ports to flushing before waiting for the srcpad streaming thread to finish
Sebastian Dröge [Fri, 18 Nov 2011 17:58:58 +0000 (09:58 -0800)]
omxvideodec: First set ports to flushing before waiting for the srcpad streaming thread to finish
Sebastian Dröge [Thu, 17 Nov 2011 22:38:54 +0000 (14:38 -0800)]
omx: Only disabling of a port is like flushing, enabling is like unflushing
Sebastian Dröge [Thu, 17 Nov 2011 21:33:35 +0000 (13:33 -0800)]
omx: Enabling/disabling a port is also like flushing
The component returns all buffers to us and shouldn't get any
new buffers passed anymore.
Sebastian Dröge [Thu, 17 Nov 2011 19:26:33 +0000 (11:26 -0800)]
omxaudioenc: Signal the drain GCond even if downstream returned an error
Sebastian Dröge [Thu, 17 Nov 2011 19:26:20 +0000 (11:26 -0800)]
omxvideoenc: Signal the drain GCond even if downstream returned an error
Sebastian Dröge [Thu, 17 Nov 2011 19:25:52 +0000 (11:25 -0800)]
omxvideodec: Signal the drain GCond even if downstream returned an error
Sebastian Dröge [Thu, 17 Nov 2011 18:34:19 +0000 (10:34 -0800)]
basevideoencoder: Only call ::reset once in READY->PAUSED
Sebastian Dröge [Thu, 17 Nov 2011 18:19:35 +0000 (10:19 -0800)]
omxaudioenc: Shutdown component in PAUSED->READY and deallocate buffers
Sebastian Dröge [Thu, 17 Nov 2011 18:19:30 +0000 (10:19 -0800)]
omxvideoenc: Shutdown component in PAUSED->READY and deallocate buffers
Sebastian Dröge [Thu, 17 Nov 2011 18:19:10 +0000 (10:19 -0800)]
omxvideodec: Shutdown component in PAUSED->READY and deallocate buffers
Sebastian Dröge [Wed, 16 Nov 2011 20:02:08 +0000 (12:02 -0800)]
omxvideoenc: Set force_keyframe to FALSE after handling it
There's no reason why the base class should forward the event
further downstream if we already handled it and will insert a
keyframe.
Sebastian Dröge [Wed, 16 Nov 2011 19:21:25 +0000 (11:21 -0800)]
omxvideodec: Always push buffers downstream, even if we didn't find a corresponding GstVideoFrame
Sebastian Dröge [Tue, 15 Nov 2011 17:47:55 +0000 (09:47 -0800)]
omx: Fix debug level for flushing in wrong state from ERROR to DEBUG
It's not really an error and doesn't matter at all if flush is called
when the component is not running.
Sebastian Dröge [Tue, 15 Nov 2011 16:40:07 +0000 (08:40 -0800)]
omxh264enc: Detect bytestream stream format and don't put SPS/PPS into the caps for this format
Sebastian Dröge [Tue, 15 Nov 2011 16:28:32 +0000 (08:28 -0800)]
omxvideoenc: Add vfunc for handling the output frames
This can be used by subclasses to override the buffer flags
or to handle some frames differently than the default behaviour.
Sebastian Dröge [Mon, 14 Nov 2011 20:50:26 +0000 (12:50 -0800)]
omxvideodec: Don't release buffers twice if dropping because of QoS
Sebastian Dröge [Mon, 14 Nov 2011 17:13:06 +0000 (09:13 -0800)]
omx: Add XXX to the nOffset reset hack comment for QCOM
Sebastian Dröge [Thu, 10 Nov 2011 14:18:08 +0000 (15:18 +0100)]
omxaudioenc: Make srcpad caps setting threadsafe
Sebastian Dröge [Thu, 10 Nov 2011 14:17:56 +0000 (15:17 +0100)]
omxvideoenc: Make srcpad caps setting threadsafe
Sebastian Dröge [Thu, 10 Nov 2011 14:17:41 +0000 (15:17 +0100)]
omxvideodec: Make srcpad caps setting threadsafe
Sebastian Dröge [Thu, 10 Nov 2011 14:10:14 +0000 (15:10 +0100)]
omxaudioenc: Make the srcpad task and the sinkpad streaming thread handling threadsafe
Sebastian Dröge [Thu, 10 Nov 2011 14:03:05 +0000 (15:03 +0100)]
omxaudioenc: Always flush the ports and make sure no processing is happening in ::flush
This fixes a race condition that happened when seeking
very often in a short period of time.
Sebastian Dröge [Thu, 10 Nov 2011 14:02:22 +0000 (15:02 +0100)]
omxvideoenc: Always flush the ports and make sure no processing is happening in ::reset
This fixes a race condition that happened when seeking
very often in a short period of time.
Sebastian Dröge [Thu, 10 Nov 2011 14:01:36 +0000 (15:01 +0100)]
omxvideoenc: Fix minor race condition when draining after upstream signalled EOS
Sebastian Dröge [Thu, 10 Nov 2011 13:56:19 +0000 (14:56 +0100)]
omxaudioenc: Improve EOS handling
If downstream return UNEXPECTED we should still signal the
drain cond because nothing will trigger this again later.
Sebastian Dröge [Thu, 10 Nov 2011 13:56:11 +0000 (14:56 +0100)]
omxvideoenc: Improve EOS handling
If downstream return UNEXPECTED we should still signal the
drain cond because nothing will trigger this again later.
Sebastian Dröge [Thu, 10 Nov 2011 13:54:33 +0000 (14:54 +0100)]
omxaudioenc: Improve debugging of EOS and draining
Sebastian Dröge [Thu, 10 Nov 2011 13:54:17 +0000 (14:54 +0100)]
omxvideoenc: Improve debugging of EOS and draining
Sebastian Dröge [Thu, 10 Nov 2011 13:51:06 +0000 (14:51 +0100)]
omxvideodec: Log if acquiring buffer for EOS failed
Sebastian Dröge [Thu, 10 Nov 2011 13:42:13 +0000 (14:42 +0100)]
omxvideodec: The component is not started in READY
Sebastian Dröge [Thu, 10 Nov 2011 13:39:40 +0000 (14:39 +0100)]
omxaudioenc: No need to signal the drain cond when going from READY to PAUSED
Also the component is not started in READY
Sebastian Dröge [Thu, 10 Nov 2011 13:40:56 +0000 (14:40 +0100)]
omxvideoenc: No need to signal the drain cond when going from READY to PAUSED
Also the component is not started in READY.
Sebastian Dröge [Wed, 9 Nov 2011 14:46:02 +0000 (15:46 +0100)]
omxvideodec: Always flush the ports and make sure no processing is happening in ::reset
This fixes a race condition that happened when seeking
very often in a short period of time.
Sebastian Dröge [Wed, 9 Nov 2011 14:45:20 +0000 (15:45 +0100)]
omxvideodec: Fix minor race condition when draining after upstream signalled EOS
Sebastian Dröge [Wed, 9 Nov 2011 14:44:11 +0000 (15:44 +0100)]
omxvideodec: Improve EOS handling
If downstream return UNEXPECTED we should still signal the
drain cond because nothing will trigger this again later.
Sebastian Dröge [Wed, 9 Nov 2011 14:43:32 +0000 (15:43 +0100)]
omxvideodec: Improve debugging of EOS and draining
Sebastian Dröge [Wed, 9 Nov 2011 14:42:46 +0000 (15:42 +0100)]
omxvideodec: The component is not started already when going from READY to PAUSED
Sebastian Dröge [Wed, 9 Nov 2011 14:42:13 +0000 (15:42 +0100)]
omxvideodec: No need to signal the drain cond when going from READY to PAUSED
Sebastian Dröge [Wed, 9 Nov 2011 14:41:02 +0000 (15:41 +0100)]
omx: Always reset buffer flags for output ports, even in flushing/error state
Sebastian Dröge [Wed, 9 Nov 2011 08:00:57 +0000 (09:00 +0100)]
omxvideodec: Improve debugging in case of QoS-related frame drops
Sebastian Dröge [Tue, 8 Nov 2011 11:46:31 +0000 (12:46 +0100)]
omxvideoenc: Release the video codec stream lock before acquiring an input buffer
Otherwise the srcpad task might block on this lock and
no buffers ever become available again.
Sebastian Dröge [Tue, 8 Nov 2011 11:45:16 +0000 (12:45 +0100)]
omxaudioenc: Release the audio encoder stream lock before acquiring an input buffer
Otherwise the srcpad task might block on this lock and
no buffers ever become available again.
Sebastian Dröge [Tue, 8 Nov 2011 11:42:58 +0000 (12:42 +0100)]
omxvideodec: Release the video codec stream lock before acquiring an input buffer
Otherwise the srcpad task might block on this lock and
no buffers ever become available again.
Sebastian Dröge [Tue, 8 Nov 2011 10:07:01 +0000 (11:07 +0100)]
omxaudioenc: Don't try to drain the component after EOS
And don't send EOS twice in any case. This most likely
will cause the component to not output it again and
is not necessary anyway.
Sebastian Dröge [Tue, 8 Nov 2011 10:03:29 +0000 (11:03 +0100)]
omxvideoenc: Don't try to drain the component after EOS
And don't send EOS twice in any case. This most likely
will cause the component to not output it again and
is not necessary anyway.
Sebastian Dröge [Tue, 8 Nov 2011 09:46:36 +0000 (10:46 +0100)]
omxvideodec: Don't try to drain the component after EOS
And don't send EOS twice in any case. This most likely
will cause the component to not output it again and
is not necessary anyway.
Sebastian Dröge [Tue, 8 Nov 2011 08:09:28 +0000 (09:09 +0100)]
omxvideodec: Implement dropping of too late frames via QoS
Sebastian Dröge [Tue, 8 Nov 2011 07:31:58 +0000 (08:31 +0100)]
omxaudioenc: Minor code refactoring
Sebastian Dröge [Tue, 8 Nov 2011 07:31:43 +0000 (08:31 +0100)]
omxvideoenc: Minor code refactoring
Sebastian Dröge [Tue, 8 Nov 2011 07:31:32 +0000 (08:31 +0100)]
omxvideodec: Make sure to always release buffers back to OMX
Sebastian Dröge [Tue, 8 Nov 2011 07:24:19 +0000 (08:24 +0100)]
omx: Also properly release buffers when in error state
Jonas Larsson [Tue, 8 Nov 2011 07:22:08 +0000 (08:22 +0100)]
omx: Properly release buffers during flushing
We can't pass them back to OMX_FillThisBuffer() or OMX_EmptyThisBuffer()
but instead of doing nothing we have to put them back into our queue.
Otherwise the buffer is leaked and we will have too few buffers in
the future.
Sebastian Dröge [Mon, 7 Nov 2011 13:00:47 +0000 (14:00 +0100)]
omxvideodec: Free pending frames after draining component
Sebastian Dröge [Mon, 7 Nov 2011 13:00:35 +0000 (14:00 +0100)]
omxvideoenc: Free pending frames after draining the component
Sebastian Dröge [Mon, 7 Nov 2011 10:07:01 +0000 (11:07 +0100)]
omxvideoenc: Make handling and usage of the base video codec frames threadsafe
Sebastian Dröge [Mon, 7 Nov 2011 10:05:29 +0000 (11:05 +0100)]
omxvideoenc: Fix deadlock between srcpad stream lock and ::reset()
Sebastian Dröge [Mon, 7 Nov 2011 10:04:27 +0000 (11:04 +0100)]
omxvideoenc: Make handling and usage of the base video codec frames threadsafe
Sebastian Dröge [Mon, 7 Nov 2011 09:58:44 +0000 (10:58 +0100)]
omxvideoenc: Free all pending frames after draining the component
Sebastian Dröge [Mon, 7 Nov 2011 09:58:24 +0000 (10:58 +0100)]
omxvideodec: Always free all pending frames when caps changes require reconfiguration
Sebastian Dröge [Fri, 4 Nov 2011 08:43:48 +0000 (09:43 +0100)]
omxaudioenc: Only drain the component a single time and only after processing started
Sebastian Dröge [Fri, 4 Nov 2011 08:43:32 +0000 (09:43 +0100)]
omxvideodec: Only drain the component a single time and only after processing started
Sebastian Dröge [Fri, 4 Nov 2011 08:43:12 +0000 (09:43 +0100)]
omxvideoenc: Only drain the component a single time and only after processing started
Sebastian Dröge [Fri, 4 Nov 2011 08:04:16 +0000 (09:04 +0100)]
omx: Reset buffer flags to 0 after it was consumed by the component or the element
Some implementations don't reset the flags and the standard is not
really clear on the expected behaviour. Let's just always reset the
flags as they're not valid at this point anymore.
Sebastian Dröge [Wed, 2 Nov 2011 12:50:14 +0000 (13:50 +0100)]
omxvideoenc: Better handling of encoder parameters
Only set them if necessary and allow to use the component
defaults.
Sebastian Dröge [Wed, 2 Nov 2011 12:22:50 +0000 (13:22 +0100)]
omxvideoenc: Make unsupported bitrate/quantizer settings less fatal
Sebastian Dröge [Wed, 2 Nov 2011 09:39:50 +0000 (10:39 +0100)]
omxvideodec: If no stride was set for the OMX output port assume GStreamer stride
This is not really correct but there's nothing else we could do.
Sebastian Dröge [Wed, 2 Nov 2011 09:39:10 +0000 (10:39 +0100)]
omxvideoenc: If no stride was set for the OMX input port assume GStreamer stride
This is not really correct but there's nothing else we could do.
Sebastian Dröge [Tue, 1 Nov 2011 15:46:09 +0000 (16:46 +0100)]
omxaudioenc: Implement draining of the component and use it
This makes sure that all buffers are encoded and pushed downstream
before flushing the ports and losing some buffers.
Sebastian Dröge [Tue, 1 Nov 2011 15:41:46 +0000 (16:41 +0100)]
omxvideoenc: Implement draining of the component and use it
This makes sure that all buffers are encoded and pushed downstream
before flushing the ports and losing some buffers.
Sebastian Dröge [Tue, 1 Nov 2011 15:08:59 +0000 (16:08 +0100)]
omxvideodec: Implement draining of the component and use it
This makes sure that all buffers are decoded and pushed downstream
before flushing the ports and losing some buffers.
Sebastian Dröge [Thu, 20 Oct 2011 12:32:40 +0000 (14:32 +0200)]
omxvideodec: Fix deadlock if ::reset is called before finding the corresponding frame of a decoded buffer
Sebastian Dröge [Tue, 1 Nov 2011 14:10:12 +0000 (15:10 +0100)]
omxaudioenc: Forward downstream flow returns to upstream
Sebastian Dröge [Tue, 1 Nov 2011 14:10:01 +0000 (15:10 +0100)]
omxvideoenc: Forward downstream flow returns to upstream
Sebastian Dröge [Tue, 1 Nov 2011 12:58:38 +0000 (13:58 +0100)]
omxvideodec: Forward downstream flow returns to upstream
Sebastian Dröge [Tue, 25 Oct 2011 12:23:38 +0000 (14:23 +0200)]
omx: Add minimal README file
Sebastian Dröge [Thu, 20 Oct 2011 13:21:07 +0000 (15:21 +0200)]
omxvideodec: Fix deadlock caused by calling reset while the loop function does something with the base video codec stream lock
Sebastian Dröge [Thu, 20 Oct 2011 13:20:47 +0000 (15:20 +0200)]
omxvideoenc: Fix deadlock caused by calling reset while the loop function does something with the base video codec stream lock
Sebastian Dröge [Thu, 20 Oct 2011 12:30:38 +0000 (14:30 +0200)]
omxvideodec: Move locking at the correct place
Sebastian Dröge [Fri, 14 Oct 2011 08:27:47 +0000 (10:27 +0200)]
omx: Remove QCOM hack to reset nOffset in EmptyBufferDone
This is now done in a generic way that does not require any
hacks because it will work without any side effects on any
OMX implementation.
Sebastian Dröge [Fri, 14 Oct 2011 08:26:00 +0000 (10:26 +0200)]
omx: Reset nOffset to 0 in EmptyBufferDone if nFilledLen is 0
Some OMX implementations don't reset nOffset when the complete
buffer is emptied but instead only reset nFilledLen. We reset
nOffset to 0 if nFilledLen == 0, which is safe to do because
the offset *must* be 0 if the buffer is not filled at all.
Seen in QCOM's OMX implementation.
Sebastian Dröge [Tue, 4 Oct 2011 08:56:33 +0000 (10:56 +0200)]
omxvideoenc: If one parameter/configuration is not supported don't skip the next
Sebastian Dröge [Mon, 3 Oct 2011 07:12:44 +0000 (09:12 +0200)]
omxh264dec: Require stream-format=byte-stream
Other stream-formats are unlikely to be supported by OMX components.
Sebastian Dröge [Thu, 29 Sep 2011 08:37:32 +0000 (10:37 +0200)]
omxvideodec: Add API for subclasses to prepare/convert frames
Sebastian Dröge [Tue, 27 Sep 2011 13:08:54 +0000 (15:08 +0200)]
omxaudioenc: Switch to Idle first and wait before switching to Loaded and deallocating buffers
Allocating buffers before the Idle state is reached can lead to crashes.
Sebastian Dröge [Tue, 27 Sep 2011 13:08:44 +0000 (15:08 +0200)]
omxvideoenc: Switch to Idle first and wait before switching to Loaded and deallocating buffers
Allocating buffers before the Idle state is reached can lead to crashes.
Sebastian Dröge [Tue, 27 Sep 2011 13:05:19 +0000 (15:05 +0200)]
omxvideodec: Switch to Idle first and wait before switching to Loaded and deallocating buffers
Allocating buffers before the Idle state is reached can lead to crashes.
Sebastian Dröge [Tue, 27 Sep 2011 12:15:06 +0000 (14:15 +0200)]
omxvideodec: New hack for QCOM to recreate the component instead of reconfiguring it on caps changes
Sebastian Dröge [Tue, 27 Sep 2011 10:13:56 +0000 (12:13 +0200)]
omx: Change a g_assert() into a GST_WARNING_OBJECT()
Sebastian Dröge [Mon, 26 Sep 2011 11:04:18 +0000 (13:04 +0200)]
omx: Add hack for Qualcomm's OMX implementation to manually reset nOffset in EmptyBufferDone
Sebastian Dröge [Fri, 23 Sep 2011 15:02:49 +0000 (17:02 +0200)]
omxaudioenc: Add a check to prevent a zero-sized OMX buffer
Sebastian Dröge [Fri, 23 Sep 2011 15:02:19 +0000 (17:02 +0200)]
omxvideoenc: Add some more checks for correct OMX buffer sizes
Sebastian Dröge [Fri, 23 Sep 2011 13:53:49 +0000 (15:53 +0200)]
omxvideodec: Add some more checks for OMX buffer sizes
Sebastian Dröge [Wed, 14 Sep 2011 08:15:38 +0000 (10:15 +0200)]
omx: Wait until the Executing state is reached before calling OMX_FillThisBuffer()
This correctly works around the QCOM race condition that happens when calling
FTB after setting the new state and before reaching it.
Sebastian Dröge [Fri, 2 Sep 2011 12:43:43 +0000 (14:43 +0200)]
omxvideodec: Negotiate video format with downstream and what the component claims to support