jashook [Wed, 16 Mar 2016 02:24:17 +0000 (19:24 -0700)]
Remove release only check.
Allows debug and checked builds to run tests on arm64 machines.
William Godbe [Tue, 15 Mar 2016 22:30:20 +0000 (15:30 -0700)]
Merge pull request #3741 from wtgodbe/r2r
Fix file-too-long errors caused by adding R2R tests to CI
wtgodbe [Tue, 15 Mar 2016 21:56:16 +0000 (14:56 -0700)]
Fix file-too-long errors caused by adding R2R tests to CI
Rahul Kumar [Tue, 15 Mar 2016 20:35:30 +0000 (13:35 -0700)]
Merge pull request #3706 from rahku/fixbug
fix dir of disabled test
William Godbe [Tue, 15 Mar 2016 20:09:53 +0000 (13:09 -0700)]
Merge pull request #3705 from wtgodbe/r2r
Enable pri0 crossgen build/tests per-commit, and pri1 by trigger phrase
Gaurav Khanna [Tue, 15 Mar 2016 19:35:25 +0000 (12:35 -0700)]
Merge pull request #3729 from gkhanna79/FixNugetPackage
Fix 3724 - Include Runtime.json in redirection package
Rahul Kumar [Tue, 15 Mar 2016 19:17:29 +0000 (12:17 -0700)]
Merge pull request #3711 from rahku/Helix
Add dependency to apisets correctly
wtgodbe [Mon, 14 Mar 2016 23:10:10 +0000 (16:10 -0700)]
Enable pri0 crossgen build/tests per-commit, and pri1 by trigger phrase
Rahul Kumar [Mon, 14 Mar 2016 21:40:55 +0000 (14:40 -0700)]
Add dependency to apisets correctly
Update version of apisets
Jan Kotas [Tue, 15 Mar 2016 16:14:00 +0000 (09:14 -0700)]
Merge pull request #3719 from dotnet-bot/from-tfs
Merge changes from TFS
Gaurav Khanna [Tue, 15 Mar 2016 15:04:53 +0000 (08:04 -0700)]
Fix 3724 - Include Runtime.json in redirection package
Gaurav Khanna [Tue, 15 Mar 2016 14:26:05 +0000 (07:26 -0700)]
Merge pull request #3720 from gkhanna79/FixTestTimeOut
Fix timeout determination for tests
Russ Keldorph [Tue, 15 Mar 2016 14:17:56 +0000 (07:17 -0700)]
Merge pull request #3694 from RussKeldorph/stresstags
Exclude doublearray/* from GCStress runs
Kyungwoo Lee [Tue, 15 Mar 2016 13:38:36 +0000 (06:38 -0700)]
Merge pull request #3680 from mikedn/bad-disasm
Fix some JIT disassembly issues
Kyungwoo Lee [Tue, 15 Mar 2016 13:38:04 +0000 (06:38 -0700)]
Merge pull request #3698 from kyulee1/Fixovf
ARM64: Fix genJumpToThrowHlpBlk
Kyungwoo Lee [Tue, 15 Mar 2016 13:35:34 +0000 (06:35 -0700)]
Merge pull request #3692 from kyulee1/fixuint2float
ARM64: Fix casting unsigned int to double
Gaurav Khanna [Tue, 15 Mar 2016 03:36:14 +0000 (20:36 -0700)]
Fix timeout determination for tests
Jan Kotas [Tue, 15 Mar 2016 03:10:55 +0000 (20:10 -0700)]
Merge pull request #3699 from jkotas/tests
Test fixes
Rama krishnan Raghupathy [Tue, 15 Mar 2016 01:53:57 +0000 (18:53 -0700)]
Merge pull request #3634 from ramarag/testbuild
Enabling standalone builds for Test Project of any Priority
William Godbe [Tue, 15 Mar 2016 00:31:44 +0000 (17:31 -0700)]
Merge pull request #3702 from wtgodbe/disableEH
Disable failing Hardware EH test on non-windows
Rama krishnan Raghupathy [Mon, 14 Mar 2016 23:49:25 +0000 (16:49 -0700)]
Merge pull request #3654 from ramarag/lttngperf
Using StackString to improve memory consumption in Lttng EventProvider
Rahul Kumar [Mon, 14 Mar 2016 23:47:56 +0000 (16:47 -0700)]
fix dir of disabled test
wtgodbe [Mon, 14 Mar 2016 22:28:03 +0000 (15:28 -0700)]
Disable failing Hardware EH test on non-windows
Tarek Mahmoud Sayed [Mon, 14 Mar 2016 22:02:01 +0000 (15:02 -0700)]
Merge pull request #3695 from tarekgh/FixUmAlQuraCalendarStaticDataInitialization
Fix UmAlQuraCalendar static data initilaization
Alex Ghiondea [Mon, 14 Mar 2016 21:47:38 +0000 (14:47 -0700)]
Make sure that the AppContext.GetData method is part of model.xml.
This was missed in the previous check-in.
[tfs-changeset:
1585251]
Jan Kotas [Mon, 14 Mar 2016 21:24:09 +0000 (14:24 -0700)]
Add latent Roslyn dependency to project.json
Roslyn loads System.Security.Cryptography.Algorithms via reflection
Jan Kotas [Sun, 13 Mar 2016 13:03:17 +0000 (06:03 -0700)]
Delete bad tests
These tests depend on Thread.Abort and reflection emit APIs that are not part of supported .NET Core surface
Kyungwoo Lee [Mon, 14 Mar 2016 21:05:40 +0000 (14:05 -0700)]
Merge pull request #3679 from kyulee1/fixgchole
ARM64: Fix GC hole in indirect call site
Kyungwoo Lee [Mon, 14 Mar 2016 20:53:07 +0000 (13:53 -0700)]
ARM64: Fix genJumpToThrowHlpBlk
This is additional fix to https://github.com/dotnet/coreclr/issues/3667.
When JIT invokes this API with direct jump (EJ_jmp), JIT also tries to
circumvent the target by reversing the jump kind in debug path.
In this case, actually we should directly invoke the target.
Before (Fail)
```
b G_M36945_IG03
bl CORINFO_HELP_THROWDIVZERO
G_M36945_IG03:
```
After (Pass)
```
bl CORINFO_HELP_THROWDIVZERO
```
Alex Ghiondea [Mon, 14 Mar 2016 20:34:43 +0000 (13:34 -0700)]
Expose AppDomain.GetData via AppContext.
This is useful in certain scenarios where there is a need for information to be passed using the AppDomain.GetData methods.
[tfs-changeset:
1585237]
Brian Sullivan [Mon, 14 Mar 2016 20:00:30 +0000 (13:00 -0700)]
Merge pull request #3696 from briansull/update-tests-lst
Update tests lst for ARM64
Brian Sullivan [Mon, 14 Mar 2016 19:57:39 +0000 (12:57 -0700)]
Merge branch 'master' into update-tests-lst
Brian Sullivan [Mon, 14 Mar 2016 19:56:18 +0000 (12:56 -0700)]
Updated with NEW_PASS tests
dotnet-bot [Mon, 14 Mar 2016 19:40:41 +0000 (12:40 -0700)]
ILAsm/ILDAsm packages
This creates packages for ILAsm/ILDAsm respectively.
These tools depend on CoreCLR, so they are tied together with the same version.
Note we use ProjectK build for packaging Windows binaries so these tools are basically desktop one while cross-platform binaries are from Github build as usual.
When CoreCLR packaging and publication are migrated to Github build, so will these tools.
[tfs-changeset:
1585183]
Kyungwoo Lee [Mon, 14 Mar 2016 18:06:11 +0000 (11:06 -0700)]
ARM64: Fix GC hole in indirect call site
This fixes dotnet#3663.
Indirect call (```br``` or ```blr```) target is encoded with a register
which the first operand internally represents.
Unfortunately, call sites use the first two operands to hold GC
callee-save registers.
So, this GC register information was overridden by the call target operand
in the indirect(virtual) call sites.
The fix is to use 3rd/4th operands instead of 1st/2nd operands to hold GC info.
Ideally we should use different field name and also ensure constness when
we set up the operand so that it's never written more than once.
https://github.com/dotnet/coreclr/issues/3693 is filed.
Tarek Mahmoud Sayed [Mon, 14 Mar 2016 19:28:17 +0000 (12:28 -0700)]
Fix UmAlQuraCalendar static data initilaization
The current way of declaring the static data is cauing null reference exception
when the static constructor get called. the reason is the static initialization
method InitDateMapping is using the static array rawData which is not really
get initilaized yet when InitDateMapping execute.
The fix is moving rawData inside InitDateMapping.
https://github.com/dotnet/corefx/issues/6774#issuecomment-
196044580
Kyungwoo Lee [Mon, 14 Mar 2016 18:21:27 +0000 (11:21 -0700)]
Merge pull request #3687 from kyulee1/fixzeroinit
ARM64: Fix ZeroInit of Locals
Russ Keldorph [Mon, 14 Mar 2016 18:09:49 +0000 (11:09 -0700)]
Exclude doublearray/* from GCStress runs
Doublearray tests are incompatible with GCStress.
Fixes #2759
Kyungwoo Lee [Mon, 14 Mar 2016 17:12:34 +0000 (10:12 -0700)]
ARM64: Fix casting unsigned int to double
When casting unsigned int to double, JIT emitted ```scvtf``` instead of ```uscvtf```.
The issue was JIT used dst type instead of src type for checking the sign.
This fixes a part of https://github.com/dotnet/coreclr/issues/3667.
Russ Keldorph [Mon, 14 Mar 2016 16:41:36 +0000 (09:41 -0700)]
Merge pull request #3659 from RussKeldorph/stresstags
Add test mode exclusions
Mike Danes [Fri, 4 Mar 2016 20:23:17 +0000 (22:23 +0200)]
Fix some JIT disassembly issues
1. (v)movsd operands were messed up in disassembly:
vmovsd qword ptr [rsp+28H]ymm0, qword ptr
instead of
vmovsd qword ptr [rsp+28H], ymm0
2. cvtxx2yy insructions had GPR names prefixed with x/y:
vcvtsi2ss ymm0, yrcx
vcvttss2si yrsi, ymm6
Kyungwoo Lee [Sun, 13 Mar 2016 20:11:18 +0000 (13:11 -0700)]
ARM64: Fix ZeroInit of Locals
When zero-initializing locals, JIT emits wrong instruction sequence --
e.g, 28 byte zero-intialization as shown below.
The issue was JIT passed wrong arguments to emitIns_R_R_I.
Before (Fail)
```
stp xzr, xzr, [x2],#16
str xzr, [x2,#2] --> just two byte offset (no x2 post-increment)
str wzr, [x2]
```
After (Pass)
```
stp xzr, xzr, [x2],#16
str xzr, [x2],#8
str wzr, [x2]
```
Jan Kotas [Sun, 13 Mar 2016 21:55:50 +0000 (14:55 -0700)]
Merge pull request #3685 from jkotas/ifdefs
Fix ifdefs
Tarek Mahmoud Sayed [Sun, 13 Mar 2016 20:47:07 +0000 (13:47 -0700)]
Merge pull request #3662 from tarekgh/FixGetYearForJapaneseCalendar
Fix calculating the calendar year in JapaneseLunisolarCalendar
Kyungwoo Lee [Sun, 13 Mar 2016 20:10:06 +0000 (13:10 -0700)]
Merge pull request #3673 from briansull/update-tests-lst
ARM64: Major Update for new tests to run using Smarty.exe
Jan Kotas [Sun, 13 Mar 2016 19:09:22 +0000 (12:09 -0700)]
Remove remaining strongname validation on Windows
CodeCLR always skips strongname validation. Some code for strong name validation was still compiled for Windows, but not for Unix. This change removes the differences between Windows and Unix by never compiling the strong name validation code in.
Jan Kotas [Sun, 13 Mar 2016 13:03:17 +0000 (06:03 -0700)]
Remove incorrect use of FEATURE_LEGACYSURFACE ifdef
Sergiy Kuryata [Sun, 13 Mar 2016 06:17:12 +0000 (22:17 -0800)]
Merge pull request #3683 from sergiy-k/runtestsfix1
Exclude netcore50aot assemblies in runtests.sh
Russ Keldorph [Fri, 11 Mar 2016 00:34:47 +0000 (16:34 -0800)]
Add test mode exclusions
Add the ability to exclude individual tests that are incompatible with
certain test modes. If a test is incompatible with or too slow under
GCStress, add
<GCStressIncompatible>true</GCStressIncompatible>
as a property to the test's project file. If a test requires optimization
or is sensitive to precise optimization patterns, use
<JitOptimizationSensitive>true</JitOptimizationSensitive>
Sergiy Kuryata [Sun, 13 Mar 2016 03:47:48 +0000 (19:47 -0800)]
Exclude netcore50aot assemblies in runtests.sh
Jan Kotas [Sat, 12 Mar 2016 07:26:24 +0000 (23:26 -0800)]
Merge pull request #3671 from brianrob/multicorejitthread
Use Default Stack Size for Multi-Core JIT Playback Thread
Sergiy Kuryata [Sat, 12 Mar 2016 04:18:52 +0000 (20:18 -0800)]
Merge pull request #3678 from sergiy-k/runtestsfix
Patch the runtests.sh script to work around an issue with corefx assemblies
Jan Kotas [Sat, 12 Mar 2016 03:49:27 +0000 (19:49 -0800)]
Merge pull request #3674 from jkotas/tail-call
Fallback to JIT for explicit tailcalls in R2R
Sergiy Kuryata [Sat, 12 Mar 2016 02:17:15 +0000 (18:17 -0800)]
Patch the runtests.sh script to work around an issue with corefx assemblies
Change https://github.com/dotnet/corefx/pull/6779 in CoreFx added corert
assemblies to the mix of assemblies that are built for CoreCLR on Unix
which broke the logic in runtest.sh that creates an overlay for running
tests. This change creates a work around for the problem.
Jan Kotas [Sat, 12 Mar 2016 00:39:41 +0000 (16:39 -0800)]
Merge pull request #3590 from jkotas/deadcode
Delete dead code
Chris McKinsey [Fri, 11 Mar 2016 23:46:56 +0000 (15:46 -0800)]
Merge pull request #3631 from cmckinsey/DevDiv_199169
Fix bad codegen for initblk with large fill value
Matt Mitchell [Fri, 11 Mar 2016 23:17:45 +0000 (15:17 -0800)]
Merge pull request #3675 from mmitche/fix-names
Fix name on trigger
Matt Mitchell [Fri, 11 Mar 2016 23:16:30 +0000 (15:16 -0800)]
Fix name on trigger
Jan Kotas [Fri, 11 Mar 2016 22:52:58 +0000 (14:52 -0800)]
Fallback to JIT for explicit tailcalls in R2R
Brian Sullivan [Fri, 11 Mar 2016 22:27:25 +0000 (14:27 -0800)]
Major Update for new tests
Updated Tests.lst and preserved Categories tags
We can run all of the Pro, Pri1 tests
We currently run only the ones that were passing
from the previous Tests.lst file
DDCloud [Fri, 11 Mar 2016 03:39:22 +0000 (19:39 -0800)]
Using StackString to improve memory consumption in Lttng EventProvider
Matt Mitchell [Fri, 11 Mar 2016 22:09:13 +0000 (14:09 -0800)]
Merge pull request #3672 from mmitche/update-badges
Update badges to point to new master branch jobs
Matt Mitchell [Fri, 11 Mar 2016 22:02:50 +0000 (14:02 -0800)]
Update badges to point to new master branch jobs
Matt Mitchell [Fri, 11 Mar 2016 21:14:34 +0000 (13:14 -0800)]
Merge pull request #3197 from mmitche/branchify
[Do Not Merge] Move coreclr to branch model
Jan Kotas [Fri, 11 Mar 2016 19:14:49 +0000 (11:14 -0800)]
Merge pull request #3658 from leemgs/upstream-doc-crossbuild
Documentation: Remove the "patching Urcu" section
Tarek Mahmoud Sayed [Fri, 11 Mar 2016 18:44:48 +0000 (10:44 -0800)]
Fix calculating the calendar year in JapaneseLunisolarCalendar
The months in this calendar is lunar months. We can have the case when a new era
starts in the middle of a month which means part of the month will belong to one
era and the rest will belong to the new era. When calculating the calendar year
number for dates which in the rest of the month and exist in the new started era,
we should still use the old era info instead of the new era info because
the rest of the month still belong to the year of last era.
Example of such date is Feb 2nd 1989. Using such date while the era starts
on Jan 8th 1989 make this date belong to that new era which it is part of
the month started with previous era. Using the new era info will have the year
we are calculating equal to the era offset (i.e. year = m_EraInfo[i].yearOffset)
and we’ll end returning zero for the year. The fix is to use the previous era
info to calculate the year
issue https://github.com/dotnet/corefx/issues/6775
Sejong Oh [Fri, 11 Mar 2016 19:04:24 +0000 (11:04 -0800)]
Merge pull request #3645 from sejongoh/increase_gctest_time_out
Increase timeout and crond schedule for GC stress testing
Matt Mitchell [Fri, 11 Mar 2016 18:45:32 +0000 (10:45 -0800)]
Move coreclr to branched CI model
This moves coreclr to the branch-based CI model. In this model, instead of having the CI generate jobs out of dotnet/coreclr's master branch for all branches (using all sorts of odd naming suffixes of course), the master CI lists tell the CI which branches it should look at for CI config info. It passes the branch name to the netci file, which then can use it to tell the SCM to pull code from specific branches or set branch specific PR triggers.
Brian Sullivan [Fri, 11 Mar 2016 18:03:03 +0000 (10:03 -0800)]
Merge pull request #3653 from briansull/migrate-tags
Add migrate-tags.py script for migrating Smarty tags
Sean Gillespie [Fri, 11 Mar 2016 17:57:38 +0000 (09:57 -0800)]
Merge pull request #3252 from mjp41/master
Fixed parent pointers becoming corrupt in GC benchmark for Red/Black trees
Brian Sullivan [Fri, 11 Mar 2016 17:52:27 +0000 (09:52 -0800)]
Added Header and other Codereview feedback
Geunsik Lim [Fri, 11 Mar 2016 10:30:12 +0000 (19:30 +0900)]
Documentation: Remove Patching Urcu Section
Atomic function parameter types Urcu is already fixed.
We don't need any manual patching for the cross build.
Let's remove this section from now on.
Signed-off-by: Geunsik Lim geunsik.lim@samsung.com
Signed-off-by: Prajwal A N an.prajwal@samsung.com
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com
Sejong Oh [Thu, 10 Mar 2016 23:57:09 +0000 (15:57 -0800)]
a This is a combination of 2 commits.
Increase timeout and crond schedule for GC stress testing
Sejong Oh [Fri, 11 Mar 2016 07:31:18 +0000 (23:31 -0800)]
Merge pull request #3630 from sejongoh/pull_down_coredistool_windows
Pull down coredistool package on Windows
Brian Robbins [Fri, 11 Mar 2016 06:35:56 +0000 (22:35 -0800)]
Update Multi-Core JIT to use the default stack size for the JIT playback thread.
Brian Sullivan [Fri, 11 Mar 2016 03:31:35 +0000 (19:31 -0800)]
Add migrate-tags.py script for migrating Smarty tags
Also added a test case for the script
Chris McKinsey [Wed, 9 Mar 2016 23:03:48 +0000 (15:03 -0800)]
Fix bad codegen for initblk with large fill value
When the initialization value of an init block is constant we attempt to
generate an inline expansion sequences to execute the stores. In order to
generate wider stores the constant value is expanded so that each byte
position holds the initial byte value. In some cases the constant on the
initblk may be a value not in the range of 0..255 and this constant
expansion will generate the wrong value. This change fixes the x64, x86,
and arm64 (comment only) expanses to use only the lower byte value of this
constant. The ARM32 backend already does this, and the other JIT32/JIT64
JITs shipping in Desktop also do this correctly.
Rama Krishnan Raghupathy [Thu, 10 Mar 2016 23:45:22 +0000 (15:45 -0800)]
Enabling standalone builds for Test Project of any Priority
Sergiy Kuryata [Fri, 11 Mar 2016 02:02:04 +0000 (18:02 -0800)]
Merge pull request #3647 from dagood/fix-pri1-test-dependencies
Fix priority 1 tests: add missing dependencies
Andy Ayers [Fri, 11 Mar 2016 02:01:36 +0000 (18:01 -0800)]
Merge pull request #3632 from AndyAyersMS/InlineRefactorMoveProfitability
Inline refactoring: move profitability assessment to LegacyPolicy
Rahul Kumar [Fri, 11 Mar 2016 01:55:27 +0000 (17:55 -0800)]
Merge pull request #3652 from rahku/EHTestPort
exclude test baseservices\exceptions\regressions\Dev11\147911
Rahul Kumar [Fri, 11 Mar 2016 01:03:11 +0000 (17:03 -0800)]
exclude test baseservices\exceptions\regressions\Dev11\147911
John Chen [Fri, 11 Mar 2016 00:42:28 +0000 (16:42 -0800)]
Merge pull request #3644 from JohnChen0/master
Fix a GC hole in a Ready-to-Run helper
Davis Goodin [Fri, 11 Mar 2016 00:04:53 +0000 (18:04 -0600)]
Add new dependencies to tests where package upgrade moved types.
Eugene Rozenfeld [Thu, 10 Mar 2016 23:19:24 +0000 (15:19 -0800)]
Merge pull request #3641 from erozenfeld/GetCORSystemDirectoryInternaLFix
Fix for a bug in GetCORSystemDirectoryInternaL
Sejong Oh [Wed, 9 Mar 2016 02:11:57 +0000 (18:11 -0800)]
Pull down coredistool package on Windows
Rahul Kumar [Thu, 10 Mar 2016 23:05:34 +0000 (15:05 -0800)]
Merge pull request #3640 from rahku/EHTestPort
Fix arm64 build break
John Chen (CLR) [Thu, 10 Mar 2016 23:04:44 +0000 (15:04 -0800)]
Fix a GC hole in a Ready-to-Run helper
Assembly routines DelayLoad_Helper* were putting an argument at a
wrong location on the stack. This resulted in a GC hole that caused
random crashes, such as dotnet/cli#1785 and dotnet/roslyn#9632.
Aditya Mandaleeka [Thu, 10 Mar 2016 22:29:43 +0000 (14:29 -0800)]
Merge pull request #3603 from bendono/doc
Fix spelling and grammar.
Eugene Rozenfeld [Thu, 10 Mar 2016 21:05:23 +0000 (13:05 -0800)]
Fix for a bug in GetCORSystemDirectoryInternaL
Change
7045ca7a6de381b382a709dc0a61f49ca713d160 introduced a bug in
GetCORSystemDirectoryInternaL. The second parameter of GetRuntimeDirectory
is in/out so passing a pointer to an uninitialized cchBuffer was wrong.
The fix is to initialize cchBuffer to MAX_PATH - 1.
This was causing failures in some non CoreClr ngen scenarios.
Matthew Parkinson [Thu, 10 Mar 2016 20:37:41 +0000 (20:37 +0000)]
Addressing code review feedback.
Jan Vorlicek [Thu, 10 Mar 2016 20:32:38 +0000 (21:32 +0100)]
Merge pull request #3639 from svick/patch-1
Remove incorrect escaping in example in BOTR
Rahul Kumar [Thu, 10 Mar 2016 19:55:30 +0000 (11:55 -0800)]
Fix arm64 build break
Sejong Oh [Thu, 10 Mar 2016 19:08:15 +0000 (11:08 -0800)]
Merge pull request #3638 from sejongoh/quick_path_fix_for_init_tool_sh
Fix shell command to execute init-tool.sh on CI
Petr Onderka [Thu, 10 Mar 2016 18:32:25 +0000 (19:32 +0100)]
Remove incorrect escaping in example in BOTR
The example was casting to `ArrayMethodDesc\*` (note the backslash, possibly there to avoid italics formatting in some previous version?), which doesn't make sense. Now it casts to `ArrayMethodDesc*`.
Also, since I'm already changing this snippet, enable syntax highlighting as C++ for it.
Davis Goodin [Thu, 10 Mar 2016 18:13:45 +0000 (12:13 -0600)]
Merge pull request #3589 from dagood/test-dependency-validation
Add dependency validation/tooled-upgrade and make dependencies valid under new rules
Sejong Oh [Thu, 10 Mar 2016 17:39:10 +0000 (09:39 -0800)]
Fix shell command to execute init-tool.sh on CI
Davis Goodin [Thu, 10 Mar 2016 15:28:41 +0000 (09:28 -0600)]
Fix the centralized GC test project.jsons and other new project.jsons from merge.
Davis Goodin [Wed, 9 Mar 2016 22:45:07 +0000 (16:45 -0600)]
Upgrade new test project.json files from merge.
Davis Goodin [Tue, 8 Mar 2016 17:52:24 +0000 (11:52 -0600)]
Add documentation for dependency validation.