platform/upstream/libffi.git
13 years agoFix symbol prefix for ffi_closure_SYSV_inner on Darwin.
Landon Fuller [Sun, 19 Sep 2010 17:42:36 +0000 (10:42 -0700)]
Fix symbol prefix for ffi_closure_SYSV_inner on Darwin.

13 years agoWhitespace/comment fixes.
Landon Fuller [Sun, 19 Sep 2010 16:35:04 +0000 (09:35 -0700)]
Whitespace/comment fixes.

13 years agoFix the script name (build-iphone.sh -> build-ios.sh)
Landon Fuller [Sun, 19 Sep 2010 16:04:34 +0000 (09:04 -0700)]
Fix the script name (build-iphone.sh -> build-ios.sh)

13 years agoUpdate the autogenerated autoconf/automake files.
Landon Fuller [Sun, 19 Sep 2010 16:03:52 +0000 (09:03 -0700)]
Update the autogenerated autoconf/automake files.

13 years agoUpdate automake/autoconf to conditionally build src/arm/trampoline.S if FFI_EXEC_TRAM...
Landon Fuller [Sun, 19 Sep 2010 16:02:05 +0000 (09:02 -0700)]
Update automake/autoconf to conditionally build src/arm/trampoline.S if FFI_EXEC_TRAMPOLINE_TABLE is enabled.

13 years agoAdd the trampoline table generated by gentramp.sh
Landon Fuller [Sun, 19 Sep 2010 15:52:33 +0000 (08:52 -0700)]
Add the trampoline table generated by gentramp.sh

13 years agoAdd a shell script that generates the ARM trampoline page.
Landon Fuller [Sun, 19 Sep 2010 15:38:19 +0000 (08:38 -0700)]
Add a shell script that generates the ARM trampoline page.

This generates a page of 340 trampolines, aligned within one page. The
trampolines use pc-relative addressing to reference config data
(context, jump address) from a page placed directly prior to the
trampoline page. This can be used on systems -- such as iOS -- that do not
support writable, executable memory by remapping the executable page
containing the trampolines directly above a newly allocated writable
config page.

13 years agoUpdate autoconf files
Landon Fuller [Sun, 19 Sep 2010 01:12:19 +0000 (18:12 -0700)]
Update autoconf files

13 years agoAdd autoconf check for W^X platforms that require a trampoline table.
Landon Fuller [Sun, 19 Sep 2010 01:08:14 +0000 (18:08 -0700)]
Add autoconf check for W^X platforms that require a trampoline table.

This adds the FFI_EXEC_TRAMPOLINE_TABLE. The flag is enabled for
arm-apple-darwin, where PROT_EXEC on writable (or formerly writable) pages is
not permitted for sandboxed binaries.

13 years agoUse the correct host triple for arm/darwin
Landon Fuller [Sun, 19 Sep 2010 01:02:25 +0000 (18:02 -0700)]
Use the correct host triple for arm/darwin

13 years agoAdd missing UNWIND entry; disables .pad on non-EABI targets.
Landon Fuller [Sat, 18 Sep 2010 23:38:03 +0000 (16:38 -0700)]
Add missing UNWIND entry; disables .pad on non-EABI targets.

13 years agoApple assembler support; fixed most gas/ELF-isms.
Landon Fuller [Sat, 18 Sep 2010 23:21:32 +0000 (16:21 -0700)]
Apple assembler support; fixed most gas/ELF-isms.

13 years agoFix placement of the __APPLE__ macro.
Landon Fuller [Sat, 18 Sep 2010 22:38:06 +0000 (15:38 -0700)]
Fix placement of the __APPLE__ macro.

13 years agoWork-around libffi's FP ABI detection.
Landon Fuller [Sat, 18 Sep 2010 22:32:08 +0000 (15:32 -0700)]
Work-around libffi's FP ABI detection.

On iOS, we must use the AAPCS floating point return value calling
conventions. libffi's ARM implementation will only use these conventions
if __SOFTFP__ is defined, which is not the case when GCC's
-mfloat-abi defaults to 'softfp' instead of 'soft'. To work around this
we manually define __SOFTFP__ for Apple platforms in the ARM-specific
sysv.S.

See also:
  http://developer.apple.com/library/ios/#documentation/Xcode/Conceptual/iPhoneOSABIReference/Introduction/Introduction.html
  http://infocenter.arm.com/help/topic/com.arm.doc.ihi0042d/IHI0042D_aapcs.pdf

13 years agoAdd a stub iOS build script to drive autoconf
Landon Fuller [Sat, 18 Sep 2010 21:44:24 +0000 (14:44 -0700)]
Add a stub iOS build script to drive autoconf

13 years agoRestore execute permissions
Anthony Green [Fri, 6 Aug 2010 05:35:12 +0000 (01:35 -0400)]
Restore execute permissions

13 years agoFix win64-struct-args patch
Anthony Green [Thu, 5 Aug 2010 19:19:00 +0000 (15:19 -0400)]
Fix win64-struct-args patch

13 years agoFix debug build for windows
Anthony Green [Thu, 5 Aug 2010 18:56:53 +0000 (14:56 -0400)]
Fix debug build for windows

13 years agoDon't use -safeseh with ml64
Anthony Green [Thu, 5 Aug 2010 13:02:41 +0000 (09:02 -0400)]
Don't use -safeseh with ml64

13 years agostdcall-x86-closure-fix
Anthony Green [Thu, 5 Aug 2010 12:48:16 +0000 (08:48 -0400)]
stdcall-x86-closure-fix

13 years agodefine generic symbols carefully
Anthony Green [Thu, 5 Aug 2010 12:30:04 +0000 (08:30 -0400)]
define generic symbols carefully

13 years agodon't copy win64 struct args
Anthony Green [Thu, 5 Aug 2010 12:24:27 +0000 (08:24 -0400)]
don't copy win64 struct args

14 years agoFFI_LAST_ABI fix
Anthony Green [Fri, 23 Jul 2010 13:14:00 +0000 (09:14 -0400)]
FFI_LAST_ABI fix

14 years agorebase
Anthony Green [Mon, 12 Jul 2010 18:39:18 +0000 (14:39 -0400)]
rebase

14 years agoFix selinux test
Anthony Green [Sat, 10 Jul 2010 12:59:09 +0000 (08:59 -0400)]
Fix selinux test

14 years agoMicharl Kohler's spelling fixes
Anthony Green [Thu, 6 May 2010 00:14:56 +0000 (20:14 -0400)]
Micharl Kohler's spelling fixes

14 years agoRebase to latest GCC sources
Anthony Green [Tue, 13 Apr 2010 14:33:52 +0000 (10:33 -0400)]
Rebase to latest GCC sources

14 years agoRemove warnings and add OS/2 support
Anthony Green [Tue, 13 Apr 2010 14:19:28 +0000 (10:19 -0400)]
Remove warnings and add OS/2 support

14 years agoDan Witte's windows build fixes.
Anthony Green [Tue, 30 Mar 2010 12:30:22 +0000 (08:30 -0400)]
Dan Witte's windows build fixes.

14 years agoRemove junk file
Anthony Green [Mon, 15 Mar 2010 09:57:51 +0000 (05:57 -0400)]
Remove junk file

14 years agofix-comments patch
Anthony Green [Mon, 15 Mar 2010 09:57:24 +0000 (05:57 -0400)]
fix-comments patch

14 years agoRebuild Makefiles with automake 1.11.1 for CVE-2009-4029.
Anthony Green [Tue, 26 Jan 2010 21:48:56 +0000 (16:48 -0500)]
Rebuild Makefiles with automake 1.11.1 for CVE-2009-4029.

14 years agoMention recent changes in README
Anthony Green [Fri, 15 Jan 2010 16:35:37 +0000 (11:35 -0500)]
Mention recent changes in README

14 years agoAdd msvc.sh wrapper
Anthony Green [Fri, 15 Jan 2010 16:27:24 +0000 (11:27 -0500)]
Add msvc.sh wrapper

14 years agoMicrosoft Visual C port
Anthony Green [Fri, 15 Jan 2010 15:46:51 +0000 (10:46 -0500)]
Microsoft Visual C port

14 years agoAdd x86 Sun Studio compiler support
Anthony Green [Fri, 15 Jan 2010 14:48:33 +0000 (09:48 -0500)]
Add x86 Sun Studio compiler support

14 years agoAdd closure example doc
Anthony Green [Wed, 13 Jan 2010 07:56:19 +0000 (02:56 -0500)]
Add closure example doc

14 years agoRebase from GCC
Anthony Green [Tue, 12 Jan 2010 14:14:14 +0000 (09:14 -0500)]
Rebase from GCC

14 years agoAdd x86-64 MingW to README
Anthony Green [Fri, 1 Jan 2010 15:24:27 +0000 (10:24 -0500)]
Add x86-64 MingW to README

14 years agoReset quilt patches post 3.0.9 merge with GCC
Anthony Green [Fri, 1 Jan 2010 13:08:02 +0000 (08:08 -0500)]
Reset quilt patches post 3.0.9 merge with GCC

14 years agoUpdate version v3.0.9
Anthony Green [Thu, 31 Dec 2009 16:32:40 +0000 (11:32 -0500)]
Update version

14 years agoFinal updates before 3.0.9
Anthony Green [Thu, 31 Dec 2009 12:43:22 +0000 (07:43 -0500)]
Final updates before 3.0.9

14 years agoreally 3.0.9rc12
Anthony Green [Tue, 29 Dec 2009 15:09:31 +0000 (10:09 -0500)]
really 3.0.9rc12

14 years ago3.0.9rc12
Anthony Green [Tue, 29 Dec 2009 15:06:04 +0000 (10:06 -0500)]
3.0.9rc12

14 years ago3.0.9rc11
Anthony Green [Mon, 28 Dec 2009 02:03:33 +0000 (21:03 -0500)]
3.0.9rc11

14 years agoHPUX support and avr32 test fixes.
Anthony Green [Sat, 26 Dec 2009 17:57:23 +0000 (12:57 -0500)]
HPUX support and avr32 test fixes.

14 years ago3.0.9rc9
Anthony Green [Sat, 26 Dec 2009 15:05:18 +0000 (10:05 -0500)]
3.0.9rc9

14 years agoRemove xfails for mips and arm
Anthony Green [Sat, 26 Dec 2009 14:58:03 +0000 (09:58 -0500)]
Remove xfails for mips and arm

14 years agoRemove a bunch of xfails.
Anthony Green [Sat, 26 Dec 2009 14:57:27 +0000 (09:57 -0500)]
Remove a bunch of xfails.

14 years agoFix huge_struct for solaris
Anthony Green [Sat, 26 Dec 2009 12:46:50 +0000 (07:46 -0500)]
Fix huge_struct for solaris

14 years ago3.0.9rc8
Anthony Green [Sat, 26 Dec 2009 12:23:04 +0000 (07:23 -0500)]
3.0.9rc8

14 years ago3.0.9rc8
Anthony Green [Sat, 26 Dec 2009 12:04:45 +0000 (07:04 -0500)]
3.0.9rc8

14 years agoRebase from GCC
Anthony Green [Sat, 26 Dec 2009 12:02:27 +0000 (07:02 -0500)]
Rebase from GCC

14 years agoAdd Andreas Schwab's powerpc fix
Anthony Green [Sat, 26 Dec 2009 11:51:33 +0000 (06:51 -0500)]
Add Andreas Schwab's powerpc fix

14 years ago3.0.9rc7
Anthony Green [Sat, 26 Dec 2009 02:52:28 +0000 (21:52 -0500)]
3.0.9rc7

14 years agoUpdated some mips XFAILs
Anthony Green [Fri, 25 Dec 2009 14:50:36 +0000 (09:50 -0500)]
Updated some mips XFAILs

14 years agoClean up ChangeLog.libffi for older patches.
Anthony Green [Fri, 25 Dec 2009 07:19:23 +0000 (02:19 -0500)]
Clean up ChangeLog.libffi for older patches.

14 years agoClean up undefine_AC_ARG_VAR_PRECIOUS patch.
Anthony Green [Fri, 25 Dec 2009 07:15:40 +0000 (02:15 -0500)]
Clean up undefine_AC_ARG_VAR_PRECIOUS patch.

14 years agoFix patches
Anthony Green [Fri, 25 Dec 2009 07:04:23 +0000 (02:04 -0500)]
Fix patches

14 years agoAdd windows support patch.
Anthony Green [Fri, 25 Dec 2009 06:39:00 +0000 (01:39 -0500)]
Add windows support patch.

14 years ago3.0.9rc6
Anthony Green [Fri, 25 Dec 2009 06:22:11 +0000 (01:22 -0500)]
3.0.9rc6

14 years ago3.0.9rc6
Anthony Green [Thu, 24 Dec 2009 12:22:44 +0000 (07:22 -0500)]
3.0.9rc6

14 years agoRelease 3.0.9rc5
Anthony Green [Thu, 24 Dec 2009 10:34:46 +0000 (05:34 -0500)]
Release 3.0.9rc5

14 years agoUpdate README
Anthony Green [Thu, 24 Dec 2009 06:09:32 +0000 (01:09 -0500)]
Update README

14 years agoUpdate missing changes for 3.0.9r4.
Anthony Green [Thu, 24 Dec 2009 05:22:00 +0000 (00:22 -0500)]
Update missing changes for 3.0.9r4.

14 years agoSwitch to quilt. Rebase to latest GCC.
Anthony Green [Thu, 24 Dec 2009 04:46:22 +0000 (23:46 -0500)]
Switch to quilt. Rebase to latest GCC.

14 years agoMerge branch 'master' of git@github.com:atgreen/libffi
Anthony Green [Mon, 5 Oct 2009 04:41:35 +0000 (00:41 -0400)]
Merge branch 'master' of git@github.com:atgreen/libffi

14 years agoMore clean up.
Anthony Green [Mon, 5 Oct 2009 04:29:33 +0000 (00:29 -0400)]
More clean up.

14 years agoClean up
Anthony Green [Mon, 5 Oct 2009 04:28:03 +0000 (00:28 -0400)]
Clean up

14 years agoFrom Jens Rehsack. Fix for 64-bit AIX.
Anthony Green [Mon, 5 Oct 2009 04:25:29 +0000 (00:25 -0400)]
From Jens Rehsack.  Fix for 64-bit AIX.

14 years agoFrom Abdulaziz Ghuloum. Adds special case for Snow Leopard.
Anthony Green [Mon, 5 Oct 2009 04:16:17 +0000 (00:16 -0400)]
From Abdulaziz Ghuloum.  Adds special case for Snow Leopard.

14 years agoFix detection of free/openbsd. From Alexis Ballier.
Anthony Green [Mon, 5 Oct 2009 03:57:29 +0000 (23:57 -0400)]
Fix detection of free/openbsd.  From Alexis Ballier.

14 years agoAVR support
Anthony Green [Mon, 5 Oct 2009 03:53:17 +0000 (23:53 -0400)]
AVR support

14 years agoInitial stand-alone patch.
Anthony Green [Mon, 5 Oct 2009 03:53:11 +0000 (23:53 -0400)]
Initial stand-alone patch.

14 years agoInitial commit
Anthony Green [Sun, 4 Oct 2009 12:11:33 +0000 (08:11 -0400)]
Initial commit

14 years agoUpdate version to 3.0.9rc1. Add more useful things to .gitignore.
Anthony Green [Sun, 4 Oct 2009 11:58:22 +0000 (07:58 -0400)]
Update version to 3.0.9rc1.  Add more useful things to .gitignore.

14 years agoAdd .gitignore
Anthony Green [Tue, 29 Sep 2009 16:07:26 +0000 (12:07 -0400)]
Add .gitignore

14 years agoRemove old CVSROOT files.
Anthony Green [Tue, 29 Sep 2009 15:13:02 +0000 (11:13 -0400)]
Remove old CVSROOT files.

14 years agoApply Dave Korn's cygwin/GCC changes
twall [Wed, 19 Aug 2009 12:57:34 +0000 (12:57 +0000)]
Apply Dave Korn's cygwin/GCC changes

15 years ago2009-06-16 Wim Lewis <wiml@hhhh.org>
aph [Tue, 16 Jun 2009 18:00:47 +0000 (18:00 +0000)]
2009-06-16  Wim Lewis  <wiml@hhhh.org>

* src/powerpc/ffi.c: Avoid clobbering cr3 and cr4, which are
supposed to be callee-saved.
* src/powerpc/sysv.S (small_struct_return_value): Fix overrun of
return buffer for odd-size structs.

15 years ago2009-06-16 Andreas Tobler <a.tobler@schweiz.org>
aph [Tue, 16 Jun 2009 17:41:47 +0000 (17:41 +0000)]
2009-06-16  Andreas Tobler  <a.tobler@schweiz.org>

PR libffi/40444
* testsuite/lib/libffi-dg.exp (libffi_target_compile): Add
allow_stack_execute for Darwin.

15 years ago2009-06-16 Andrew Haley <aph@redhat.com>
aph [Tue, 16 Jun 2009 16:17:52 +0000 (16:17 +0000)]
2009-06-16  Andrew Haley  <aph@redhat.com>

* configure.ac (TARGETDIR): Add missing blank lines.
* configure: Regenerate.

15 years ago2009-06-16 Andrew Haley <aph@redhat.com>
aph [Tue, 16 Jun 2009 09:59:02 +0000 (09:59 +0000)]
2009-06-16  Andrew Haley  <aph@redhat.com>

        * testsuite/libffi.call/cls_align_sint64.c,
        testsuite/libffi.call/cls_align_uint64.c,
        testsuite/libffi.call/cls_longdouble_va.c,
        testsuite/libffi.call/cls_ulonglong.c,
        testsuite/libffi.call/return_ll1.c,
        testsuite/libffi.call/stret_medium2.c: Fix printf format
        specifiers.
        * testsuite/libffi.call/huge_struct.c: Ad x86 XFAILs.
        * testsuite/libffi.call/float2.c: Fix dg-excess-errors.
        * testsuite/libffi.call/ffitest.h,
        testsuite/libffi.special/ffitestcxx.h (PRIdLL, PRIuLL): Define.

15 years ago2009-06-16 Andrew Haley <aph@redhat.com>
aph [Tue, 16 Jun 2009 09:44:54 +0000 (09:44 +0000)]
2009-06-16  Andrew Haley  <aph@redhat.com>

* testsuite/libffi.call/err_bad_typedef.c: xfail everywhere.
* testsuite/libffi.call/err_bad_abi.c: Likewise.

15 years ago2009-06-11 Kaz Kojima <kkojima@gcc.gnu.org>
aph [Fri, 12 Jun 2009 15:29:20 +0000 (15:29 +0000)]
2009-06-11  Kaz Kojima  <kkojima@gcc.gnu.org>

        * testsuite/libffi.call/cls_longdouble_va.c: Add xfail sh*-*-linux-*.
        * testsuite/libffi.call/err_bad_abi.c: Add xfail sh*-*-*.
        * testsuite/libffi.call/err_bad_typedef.c: Likewise.

15 years ago2009-06-12 Andrew Haley <aph@redhat.com>
aph [Fri, 12 Jun 2009 14:21:28 +0000 (14:21 +0000)]
2009-06-12  Andrew Haley  <aph@redhat.com>

        * ChangeLog.libffi: testsuite/libffi.call/cls_align_sint64.c,
        testsuite/libffi.call/cls_align_uint64.c,
        testsuite/libffi.call/cls_ulonglong.c,
        testsuite/libffi.call/return_ll1.c,
        testsuite/libffi.call/stret_medium2.c: Fix printf format
        specifiers.
        testsuite/libffi.special/unwindtest.cc: include stdint.h.

15 years agoupdate changelog
twall [Thu, 11 Jun 2009 14:27:42 +0000 (14:27 +0000)]
update changelog

15 years agouse ffi_closure_alloc instead of stack-based closure
twall [Thu, 11 Jun 2009 14:27:28 +0000 (14:27 +0000)]
use ffi_closure_alloc instead of stack-based closure

15 years agoremove unused extern
twall [Thu, 11 Jun 2009 14:26:23 +0000 (14:26 +0000)]
remove unused extern

15 years agoremove not-yet-applied changelog entries
twall [Thu, 11 Jun 2009 11:36:16 +0000 (11:36 +0000)]
remove not-yet-applied changelog entries

15 years agoadd win64 support
twall [Wed, 10 Jun 2009 10:42:36 +0000 (10:42 +0000)]
add win64 support

15 years ago2009-06-08 Andrew Haley <aph@redhat.com>
aph [Mon, 8 Jun 2009 16:50:49 +0000 (16:50 +0000)]
2009-06-08  Andrew Haley  <aph@redhat.com>

* testsuite/libffi.call/err_bad_abi.c: Add xfails.
* testsuite/libffi.call/cls_longdouble_va.c: Add xfails.
* testsuite/libffi.call/cls_dbls_struct.c: Add xfail x86_64-*-linux-*.
* testsuite/libffi.call/err_bad_typedef.c: Add xfails.

* testsuite/libffi.call/stret_medium2.c: Add __UNUSED__ to args.
* testsuite/libffi.call/stret_medium.c: Likewise.
* testsuite/libffi.call/stret_large2.c: Likewise.
* testsuite/libffi.call/stret_large.c:  Likewise.

15 years ago2009-06-05 Andrew Haley <aph@redhat.com>
aph [Fri, 5 Jun 2009 13:03:40 +0000 (13:03 +0000)]
2009-06-05  Andrew Haley  <aph@redhat.com>

        * src/x86/win32.S (_ffi_closure_STDCALL): Import from gcc.

15 years ago 2009-06-04 Andrew Haley <aph@redhat.com>
aph [Thu, 4 Jun 2009 16:29:58 +0000 (16:29 +0000)]
 2009-06-04  Andrew Haley  <aph@redhat.com>

        * src/powerpc/ffitarget.h: Fix misapplied merge from gcc.

15 years ago2009-06-04 Andrew Haley <aph@redhat.com>
aph [Thu, 4 Jun 2009 14:59:18 +0000 (14:59 +0000)]
2009-06-04  Andrew Haley  <aph@redhat.com>

* src/mips/o32.S,
src/mips/n32.S: Fix licence formatting.

15 years ago2009-06-04 Andrew Haley <aph@redhat.com>
aph [Thu, 4 Jun 2009 14:43:40 +0000 (14:43 +0000)]
2009-06-04  Andrew Haley  <aph@redhat.com>

* src/x86/darwin.S: Fix licence formatting.
src/x86/win32.S: Likewise.
src/sh64/sysv.S: Likewise.
src/sh/sysv.S: Likewise.

15 years ago2009-06-04 Andrew Haley <aph@redhat.com>
aph [Thu, 4 Jun 2009 14:39:20 +0000 (14:39 +0000)]
2009-06-04  Andrew Haley  <aph@redhat.com>

* src/sh64/ffi.c: Remove lint directives.  Was missing from merge
of Andreas Tobler's patch from 2006-04-22.

15 years ago2009-06-04 Andrew Haley <aph@redhat.com>
aph [Thu, 4 Jun 2009 10:45:51 +0000 (10:45 +0000)]
2009-06-04  Andrew Haley  <aph@redhat.com>

        * src/sh/ffi.c: Apply missing hunk from Alexandre Oliva's patch of
        2007-03-07.

15 years ago2009-05-22 Dave Korn <dave.korn.cygwin@gmail.com>
aph [Wed, 3 Jun 2009 17:42:56 +0000 (17:42 +0000)]
2009-05-22  Dave Korn  <dave.korn.cygwin@gmail.com>

       * src/x86/win32.S (_ffi_closure_STDCALL):  New function.
       (.eh_frame):  Add FDE for it.

2009-05-22  Dave Korn  <dave.korn.cygwin@gmail.com>

       * configure.ac:  Also check if assembler supports pc-relative
       relocs on X86_WIN32 targets.
       * configure:  Regenerate.
       * src/x86/win32.S (ffi_prep_args):  Declare extern, not global.
       (_ffi_call_SYSV):  Add missing function type symbol .def and
       add EH markup labels.
       (_ffi_call_STDCALL):  Likewise.
       (_ffi_closure_SYSV):  Likewise.
       (_ffi_closure_raw_SYSV):  Likewise.
       (.eh_frame):  Add hand-crafted EH data.

2008-11-21  Eric Botcazou  <ebotcazou@adacore.com>

       * src/sparc/ffi.c (ffi_prep_cif_machdep): Add support for
       signed/unsigned int8/16 return values.
       * src/sparc/v8.S (ffi_call_v8): Likewise.
       (ffi_closure_v8): Likewise.

2008-03-26  Kaz Kojima  <kkojima@gcc.gnu.org>

       * src/sh/sysv.S: Add .note.GNU-stack on Linux.
       * src/sh64/sysv.S: Likewise.

2008-03-26  Daniel Jacobowitz  <dan@debian.org>

       * src/arm/sysv.S: Fix ARM comment marker.

15 years agoproperly glob-match
twall [Sat, 27 Dec 2008 16:59:05 +0000 (16:59 +0000)]
properly glob-match