platform/upstream/automake.git
13 years agotest defs: new subroutine 'seq_', simulating GNU seq(1)
Stefano Lattarini [Sat, 16 Jul 2011 08:55:05 +0000 (10:55 +0200)]
test defs: new subroutine 'seq_', simulating GNU seq(1)

* tests/defs (seq_): New subroutine.
* tests/instmany.test: Use it.
* tests/instmany-mans.test: Likewise.
* tests/instmany-python.test: Likewise.
* tests/self-check-seq.test: New self test.
* tests/Makefile.am (TESTS): Update.

13 years agotests: remove duplication about testing of config.* aux files
Stefano Lattarini [Sat, 16 Jul 2011 08:50:24 +0000 (10:50 +0200)]
tests: remove duplication about testing of config.* aux files

* tests/add-missing.test: Also check that the `AC_CANONICAL_SYSTEM'
autoconf macro causes the `config.sub' and `config.guess' scripts
to be installed by `automake --add-missing'.  Since we are at it,
fix minor buglets and cosmetic issues in the `check_' function.
* tests/hosts.test: Removed, completely subsumed by the previous
test now.
* tests/Makefile.am (TESTS): Update.

13 years agotests: more uses of the 'unindent' subroutine
Stefano Lattarini [Sat, 16 Jul 2011 08:37:55 +0000 (10:37 +0200)]
tests: more uses of the 'unindent' subroutine

* tests/backcompat.test: Prefer `unindent' over plain `cat' for
here documents created from within a loop of if/else body.
* tests/backcompat2.test: Likewise.
* tests/backcompat4.test: Likewise.
* tests/init.test: Likewise.
* tests/instmany.test: Likewise.
* tests/instmany-mans.test: Likewise.
* tests/instmany-python.test: Likewise.
* tests/missing5.test: Likewise.
* tests/parallel-am2.test : Likewise.
* tests/parallel-am3.test : Likewise.
* tests/pr307.test: Likewise.
* tests/depend4.test: Likewise.  Since we are at it, normalize
other code formatting.
* tests/instfail-java.test: Prefer `echo' over `cat' + here-doc
inside a for loop.

13 years agotests: avoid '##'-style comments inside recipe commands
Stefano Lattarini [Sat, 16 Jul 2011 08:04:58 +0000 (10:04 +0200)]
tests: avoid '##'-style comments inside recipe commands

* tests/autodist.test: Do not whitespace-indent `##' comments when
they are embedded in a makefile rule: having them indented is not
part of the Automake API, and might cause failures with e.g., Tru64
make.
* tests/autodist-subdir.test: Likewise.
* tests/backcompat.test: Likewise.
* tests/backcompat6.test: Likewise.
* tests/colon7.test: Likewise.
* tests/posixsubst-scripts.test: Likewise.
* tests/posixsubst-sources.test: Likewise.

13 years agotests: tweak, improve and extend tests on lisp support
Stefano Lattarini [Fri, 15 Jul 2011 19:07:29 +0000 (21:07 +0200)]
tests: tweak, improve and extend tests on lisp support

* tests/lisp2.test: Prettify, and improve debugging output.  Make
grepping of automake stderr stricter.
* tests/lisp7.test: Ensure verbose printing of captured make
output.  Add trailing `:' command.
* tests/lisp8.test: Likewise.
* tests/lisp3.test: Likewise.  Also, check that `.el' files and
compiled `.elc' files get installed by "make install", and
uninstalled by "make uninstall".
* tests/lisp4.test: Ensure installed `.el' files gets removed by
"make uninstall".  Related changes.  Add trailing `:' command.
* tests/lisp5.test: Likewise.
* tests/lisp6.test: Use proper m4 quoting in configure.in.  Fix
use of blank lines, to improve clarity and symmetry.  Fix typo in
comment.  Add trailing `:' command.

13 years agotests: drop useless requirement in 'license.test'
Stefano Lattarini [Fri, 15 Jul 2011 14:45:33 +0000 (16:45 +0200)]
tests: drop useless requirement in 'license.test'

* tests/license.test: Drop  useless requirement "makeinfo".  Add
an extra blank line, for clarity.

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Fri, 8 Jul 2011 09:58:40 +0000 (11:58 +0200)]
Merge branch 'master' into testsuite-work

* master:
  fix typo in recent ChangeLog entry
  docs, tests: synchronize examples on silent-rules from config.site
  tests: fix weakness in 'tests-environment-backcompat.test'

13 years agoMerge branch 'maint'
Stefano Lattarini [Fri, 8 Jul 2011 09:57:19 +0000 (11:57 +0200)]
Merge branch 'maint'

* maint:
  fix typo in recent ChangeLog entry
  docs, tests: synchronize examples on silent-rules from config.site
  tests: fix weakness in 'tests-environment-backcompat.test'

13 years agoMerge branch 'fix-tests-environment-backcompat-example' into maint
Stefano Lattarini [Fri, 8 Jul 2011 08:48:23 +0000 (10:48 +0200)]
Merge branch 'fix-tests-environment-backcompat-example' into maint

* fix-tests-environment-backcompat-example:
  tests: fix weakness in 'tests-environment-backcompat.test'

13 years agoMerge branch 'fix-changelog-typo' into maint
Stefano Lattarini [Fri, 8 Jul 2011 08:48:22 +0000 (10:48 +0200)]
Merge branch 'fix-changelog-typo' into maint

* fix-changelog-typo:
  fix typo in recent ChangeLog entry

13 years agoMerge branch 'doc-silent-rules-reference-config-site-test' into maint
Stefano Lattarini [Fri, 8 Jul 2011 08:48:22 +0000 (10:48 +0200)]
Merge branch 'doc-silent-rules-reference-config-site-test' into maint

* doc-silent-rules-reference-config-site-test:
  docs, tests: synchronize examples on silent-rules from config.site

13 years agofix typo in recent ChangeLog entry
Stefano Lattarini [Fri, 8 Jul 2011 08:45:53 +0000 (10:45 +0200)]
fix typo in recent ChangeLog entry

13 years agodocs, tests: synchronize examples on silent-rules from config.site
Stefano Lattarini [Fri, 8 Jul 2011 08:43:33 +0000 (10:43 +0200)]
docs, tests: synchronize examples on silent-rules from config.site

* doc/automake.texi (Automake silent-rules Option): Reference test
'silent-configsite.test' in comments.

13 years agotests: fix weakness in 'tests-environment-backcompat.test'
Stefano Lattarini [Fri, 8 Jul 2011 08:34:54 +0000 (10:34 +0200)]
tests: fix weakness in 'tests-environment-backcompat.test'

* tests/tests-environment-backcompat.test: Do not override the
content of xfailing test `baz.test' with a "weaker" version that
fails unconditionally: the test must fail only when the 'strict'
pragma is in use, in order not to reduce coverage.

13 years agotests defs: more uses of $top_testsrcdir
Stefano Lattarini [Fri, 8 Jul 2011 08:23:38 +0000 (10:23 +0200)]
tests defs: more uses of $top_testsrcdir

* tests/autodist-stamp-vti.test: Use `$top_testsrcdir' instead
of `$testsrcdir/..'.
* tests/repeated-options.test: Likewise.
* tests/suffix5.test: Likewise.
* tests/vtexi3.test: Likewise.

13 years agoself tests: fix typo in comment
Stefano Lattarini [Fri, 8 Jul 2011 08:17:00 +0000 (10:17 +0200)]
self tests: fix typo in comment

* tests/self-check-exit.test: Fix typo in heading comments.

13 years agotests: remove redundant settings of `errexit' shell flag
Stefano Lattarini [Fri, 8 Jul 2011 08:14:38 +0000 (10:14 +0200)]
tests: remove redundant settings of `errexit' shell flag

* tests/amhello-binpkg.test: Do not set the `errexit' shell
flag, as it is already set by `tests/defs'.
* tests/amhello-cflags.test: Likewise.
* tests/amhello-cross-compile.test: Likewise.
* tests/ansi2knr-deprecation.test: Likewise.
* tests/autodist-no-duplicate.test: Likewise.
* tests/distcheck-configure-flags-am.test: Likewise.
* tests/distcheck-configure-flags-subpkg.test: Likewise.
* tests/distcheck-configure-flags.test: Likewise.
* tests/distcheck-hook.test: Likewise.
* tests/distcheck-hook2.test: Likewise.
* tests/parallel-tests-am_tests_environment.test: Likewise.
* tests/parallel-tests-harderror.test: Likewise.
* tests/parallel-tests-log-compiler-example.test: Likewise.
* tests/parallel-tests-log-override-1.test: Likewise.
* tests/parallel-tests-log-override-2.test: Likewise.
* tests/parallel-tests-log-override-recheck.test: Likewise.
* tests/primary-prefix-couples-documented-valid.test: Likewise.
* tests/primary-prefix-couples-force-valid.test: Likewise.
* tests/primary-prefix-invalid-couples.test: Likewise.
* tests/primary-prefix-valid-couples.test: Likewise.
* tests/remake-subdir-from-subdir.test: Likewise.
* tests/remake-subdir-gnu.test: Likewise.
* tests/remake-subdir-long-time.test: Likewise.
* tests/remake-subdir.test: Likewise.
* tests/remake-subdir2.test: Likewise.
* tests/silent-configsite.test: Likewise.
* tests/tests-environment-backcompat.test: Likewise.

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Fri, 8 Jul 2011 07:56:33 +0000 (09:56 +0200)]
Merge branch 'master' into testsuite-work

* master:
  tests: portability fixes in tests on amhello examples
  remake: add test ensuring that slower remakes don't hang
  remake: fix outdated comment in configure.am

13 years agoMerge branch 'maint'
Stefano Lattarini [Fri, 8 Jul 2011 07:54:38 +0000 (09:54 +0200)]
Merge branch 'maint'

* maint:
  tests: portability fixes in tests on amhello examples
  remake: add test ensuring that slower remakes don't hang
  remake: fix outdated comment in configure.am

13 years agoMerge branch 'fix-amhello-examples-tests' into maint
Stefano Lattarini [Fri, 8 Jul 2011 07:41:27 +0000 (09:41 +0200)]
Merge branch 'fix-amhello-examples-tests' into maint

* fix-amhello-examples-tests:
  tests: portability fixes in tests on amhello examples

13 years agotests: portability fixes in tests on amhello examples
Stefano Lattarini [Wed, 6 Jul 2011 08:31:03 +0000 (10:31 +0200)]
tests: portability fixes in tests on amhello examples

* tests/amhello-binpkg.test: Don't use "tar xzf too.tag.gz" to
extract a gzip-compressed tarball, that's unportable to some
tar implementations; use the "gzip -dc fo.tar.gz | tar xf -"
idiom instead.
* tests/amhello-cflags.test: Likewise.
* tests/amhello-cross-compile.test: Likewise.

Suggestion from Ralf Wildenhues.

13 years agoMerge branch 'remake-rules-non-GNU-make' into maint
Stefano Lattarini [Mon, 4 Jul 2011 09:44:39 +0000 (11:44 +0200)]
Merge branch 'remake-rules-non-GNU-make' into maint

* remake-rules-non-GNU-make:
  remake: add test ensuring that slower remakes don't hang
  remake: fix outdated comment in configure.am

13 years agoremake: add test ensuring that slower remakes don't hang
Stefano Lattarini [Mon, 4 Jul 2011 09:41:34 +0000 (11:41 +0200)]
remake: add test ensuring that slower remakes don't hang

* tests/remake-subdir-long-time.test: New test.
* tests/Makefile.am (TESTS): Update.

Suggestion by Ralf Wildenhues.

13 years agoremake: fix outdated comment in configure.am
Stefano Lattarini [Mon, 4 Jul 2011 08:54:02 +0000 (10:54 +0200)]
remake: fix outdated comment in configure.am

* lib/am/configure.am: Fix comment falsified by changes in
commit `v1.11-366-gbee9871'.

Suggestion by Ralf Wildenhues.

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Sun, 3 Jul 2011 13:46:55 +0000 (15:46 +0200)]
Merge branch 'master' into testsuite-work

* master:
  docs, tests: synchronize examples from docs to tests

13 years agoMerge branch 'maint'
Stefano Lattarini [Sun, 3 Jul 2011 13:45:02 +0000 (15:45 +0200)]
Merge branch 'maint'

* maint:
  docs, tests: synchronize examples from docs to tests

13 years agodocs, tests: synchronize examples from docs to tests
Stefano Lattarini [Thu, 30 Jun 2011 18:05:25 +0000 (20:05 +0200)]
docs, tests: synchronize examples from docs to tests

* tests/README (Writing test cases): Give suggestions on how to
keep test cases and examples in the documentation synchronized.
* doc/automake.texi: Improve or fix existing testcase-referencing
comments, and add many new ones.
* HACKING (Administrivia): Suggest to test complex examples and
idioms from the manual.
* tests/specflg8.test: Improve synchronization with the example
in the manual.
* tests/output11.test:Likewise.
* tests/txinfo21.test:Likewise.
* tests/interp.test: Likewise.  Since we are at it, and enable
the `errexit' shell flag, do related changes, and add trailing
`:'command.
* tests/amhello-cflags.test: New test.
* tests/amhello-cross-compile.test: Likewise.
* tests/amhello-binpkg.test: Likewise.
* tests/tests-environment-backcompat: Likewise.
* tests/parallel-tests-log-compiler-example.test: Likewise.
* tests/Makefile.am (TESTS): Update.

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Thu, 30 Jun 2011 23:06:18 +0000 (01:06 +0200)]
Merge branch 'master' into testsuite-work

* master:
  coverage: new test on parallel-tests TESTS runtime overriding

13 years agocoverage: new test on parallel-tests TESTS runtime overriding
Stefano Lattarini [Thu, 30 Jun 2011 14:37:19 +0000 (16:37 +0200)]
coverage: new test on parallel-tests TESTS runtime overriding

* tests/parallel-tests-cmdline-override.test: New test, check that
we can use indirections when overriding TESTS and TEST_LOGS from
the command line.
* tests/Makefile.am (TESTS): Update.

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Thu, 30 Jun 2011 15:23:58 +0000 (17:23 +0200)]
Merge branch 'master' into testsuite-work

* master:
  cosmetics: fix typos in recent ChangeLog entries
  docs: explain why AM_TESTS_ENVIRONMENT must be semicolon-terminated
  docs: fix unportable example of AM_TESTS_ENVIRONMENT usage

13 years agoMerge branch 'maint'
Stefano Lattarini [Thu, 30 Jun 2011 15:21:47 +0000 (17:21 +0200)]
Merge branch 'maint'

* maint:
  cosmetics: fix typos in recent ChangeLog entries

13 years agocosmetics: fix typos in recent ChangeLog entries
Stefano Lattarini [Thu, 30 Jun 2011 15:20:40 +0000 (17:20 +0200)]
cosmetics: fix typos in recent ChangeLog entries

13 years agoMerge branch 'am-tests-environment'
Stefano Lattarini [Wed, 29 Jun 2011 07:53:31 +0000 (09:53 +0200)]
Merge branch 'am-tests-environment'

* am-tests-environment:
  docs: explain why AM_TESTS_ENVIRONMENT must be semicolon-terminated
  docs: fix unportable example of AM_TESTS_ENVIRONMENT usage

13 years agodocs: explain why AM_TESTS_ENVIRONMENT must be semicolon-terminated
Stefano Lattarini [Wed, 29 Jun 2011 07:44:14 +0000 (09:44 +0200)]
docs: explain why AM_TESTS_ENVIRONMENT must be semicolon-terminated

* doc/automake.texi (Simple Tests using parallel-tests): Ditto, and
related adjustments.

Suggestion by Ralf Wildenhues.

13 years agodocs: fix unportable example of AM_TESTS_ENVIRONMENT usage
Stefano Lattarini [Thu, 23 Jun 2011 17:05:44 +0000 (19:05 +0200)]
docs: fix unportable example of AM_TESTS_ENVIRONMENT usage

* doc/automake.texi (Simple Tests using parallel-tests): The
old example on AM_TESTS_ENVIRONMENT relied on unportable shell
features, and in particular didn't work with various Korn
Shells (see also commit `v1.11-925-g29ca903').  Give another
example, simpler this time, but still inspired to real-world
usage (the GNU coreutils testsuite).

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Tue, 28 Jun 2011 10:01:04 +0000 (12:01 +0200)]
Merge branch 'master' into testsuite-work

* master:
  Revert "docs: parallel-tests is not experimental anymore"
  parallel-tests: stricter checks on DISABLE_HARD_ERRORS support
  docs: parallel-tests is not experimental anymore
  check: document and test $(TEST_SUITE_LOG) overriding

13 years agoMerge branch 'maint'
Stefano Lattarini [Tue, 28 Jun 2011 09:26:15 +0000 (11:26 +0200)]
Merge branch 'maint'

* maint:
  Revert "docs: parallel-tests is not experimental anymore"
  parallel-tests: stricter checks on DISABLE_HARD_ERRORS support
  docs: parallel-tests is not experimental anymore
  check: document and test $(TEST_SUITE_LOG) overriding

13 years agoMerge branch 'parallel-tests-maint' into maint
Stefano Lattarini [Tue, 28 Jun 2011 06:15:21 +0000 (08:15 +0200)]
Merge branch 'parallel-tests-maint' into maint

* parallel-tests-maint:
  Revert "docs: parallel-tests is not experimental anymore"
  parallel-tests: stricter checks on DISABLE_HARD_ERRORS support
  docs: parallel-tests is not experimental anymore
  check: document and test $(TEST_SUITE_LOG) overriding

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Mon, 27 Jun 2011 13:38:18 +0000 (15:38 +0200)]
Merge branch 'master' into testsuite-work

* master:
  docs: avoid a footnote, some related rewordings and improvements
  docs: minor cosmetic fixes
  help: improve text about automatically-distributed files
  refactor: split 'usage' subroutine in automake
  tests: fix bug in 'autodist.test'
  maintcheck: extend 'sc_tests_plain_*' checks
  tests: interactions between TESTS_ENVIRONMENT and LOG_COMPILER

13 years agoMerge branch 'maint'
Stefano Lattarini [Mon, 27 Jun 2011 13:36:37 +0000 (15:36 +0200)]
Merge branch 'maint'

* maint:
  docs: avoid a footnote, some related rewordings and improvements
  docs: minor cosmetic fixes

13 years agodocs: avoid a footnote, some related rewordings and improvements
Stefano Lattarini [Thu, 23 Jun 2011 21:31:27 +0000 (23:31 +0200)]
docs: avoid a footnote, some related rewordings and improvements

* doc/automake.texi (Dist): Reword the part about automatically
distributed files to avoid a footnote.  Since we are at it, extend
a bit, and add an example and a reference to a relevant test case.

13 years agotests: make 'subst-no-trailing-empty-line.test' more robust
Stefano Lattarini [Fri, 24 Jun 2011 08:14:30 +0000 (10:14 +0200)]
tests: make 'subst-no-trailing-empty-line.test' more robust

* tests/subst-no-trailing-empty-line.test: Strengthen existing
checks, to try more scenarios and be slightly stricter in some
grepping checks.

13 years agotests: fix an incomplete comment
Stefano Lattarini [Fri, 24 Jun 2011 07:50:30 +0000 (09:50 +0200)]
tests: fix an incomplete comment

* tests/subst-no-trailing-empty-line.test: Fix an incomplete
comment, and move it to a more proper place.  Minor cosmetic
fixes to other comments.

13 years agoRevert "docs: parallel-tests is not experimental anymore"
Stefano Lattarini [Fri, 24 Jun 2011 07:15:14 +0000 (09:15 +0200)]
Revert "docs: parallel-tests is not experimental anymore"

This reverts commit a9eef973b5ea47cc3495f1a8307d4f7b85aea46f.

It turned out that the current work to introduce TAP and SubUnit
support in Automake-generated testsuite harnesses will probably
require the introduction of slight incompatibilities in the
'parallel-tests' behaviour, starting from release 1.12 onward.
So it's advisable to continue to characterize the 'parallel-tests'
support as "experimental" in maintenance release 1.11.2.

Suggestion from Ralf Wildenhues.

13 years agodocs: minor cosmetic fixes
Stefano Lattarini [Thu, 23 Jun 2011 16:38:34 +0000 (18:38 +0200)]
docs: minor cosmetic fixes

* doc/automake.texi: Break few overly long lines, throughout the
file.
("Simple Tests"): Move @vindex for XFAIL_TESTS to the correct
position, i.e., before and not after the paragraph where it is
introduced.
("Options" @item ansi2knr): Use @pxref instead of @xref.  This
fixes a texinfo warning.
("Other things Automake recognizes" @item AM_C_PROTOTYPES): Use
@pxref instead of @ref.

13 years agoMerge branch 'maint'
Stefano Lattarini [Thu, 23 Jun 2011 08:52:08 +0000 (10:52 +0200)]
Merge branch 'maint'

* maint:
  help: improve text about automatically-distributed files
  refactor: split 'usage' subroutine in automake

13 years agohelp: improve text about automatically-distributed files
Stefano Lattarini [Wed, 12 Jan 2011 00:27:07 +0000 (01:27 +0100)]
help: improve text about automatically-distributed files

This change fixes automake bug#7819.

* automake.in (usage): Distinguish between files that are always
automatically distributed when found, and those which are only
"under certain conditions".
* doc/automake.texi (Basics of Distribution): Update accordingly.
* tests/autodist-subdir.test: Update.
* tests/autodist-no-duplicate.test: Likewise.
* tests/autodist.test: Likewise.
(configure.in): Remove useless call to AM_MAINTAINER_MODE.

13 years agorefactor: split 'usage' subroutine in automake
Stefano Lattarini [Wed, 12 Jan 2011 00:06:33 +0000 (01:06 +0100)]
refactor: split 'usage' subroutine in automake

This change is related to automake bug#7819.

* automake.in (print_autodist_files): New subroutine,
extracted from ...
(usage): ... this, which now uses it.
* tests/autodist-no-duplicate.test: New test.
* tests/Makefile.am (TESTS): Update.

13 years agoMerge branch 'maint'
Stefano Lattarini [Thu, 23 Jun 2011 08:34:39 +0000 (10:34 +0200)]
Merge branch 'maint'

* maint:
  tests: fix bug in 'autodist.test'

13 years agotests: fix bug in 'autodist.test'
Stefano Lattarini [Thu, 23 Jun 2011 08:32:12 +0000 (10:32 +0200)]
tests: fix bug in 'autodist.test'

* tests/autodist.test: Avoid spurious failure due to no
`defs-static' file being found in the parent directory.

13 years agoMerge branch 'maint'
Stefano Lattarini [Tue, 21 Jun 2011 20:24:26 +0000 (22:24 +0200)]
Merge branch 'maint'

13 years agomaintcheck: extend 'sc_tests_plain_*' checks
Stefano Lattarini [Mon, 20 Jun 2011 21:52:34 +0000 (23:52 +0200)]
maintcheck: extend 'sc_tests_plain_*' checks

* Makefile.am (sc_tests_plain_autom4te): New check.
(sc_tests_plain_autoreconf): Likewise.
(sc_tests_plain_autoheader): Likewise.
(syntax_check_rules): Update.

13 years agotests: interactions between TESTS_ENVIRONMENT and LOG_COMPILER
Stefano Lattarini [Tue, 21 Jun 2011 11:17:50 +0000 (13:17 +0200)]
tests: interactions between TESTS_ENVIRONMENT and LOG_COMPILER

* tests/tests-environment-and-log-compiler.test: New test,
checking that we can use variables and functions set by
TESTS_ENVIRONMENT and AM_TESTS_ENVIRONMENT in LOG_COMPILER
and LOG_FLAGS (for tests both with and without registered
extensions).
* tests/Makefile.am (TESTS): Update.

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Mon, 20 Jun 2011 15:00:54 +0000 (17:00 +0200)]
Merge branch 'master' into testsuite-work

* master:
  maintcheck: avoid few spurious failures

13 years agoMerge branch 'maint'
Stefano Lattarini [Mon, 20 Jun 2011 15:00:37 +0000 (17:00 +0200)]
Merge branch 'maint'

* maint:
  maintcheck: avoid few spurious failures

13 years agomaintcheck: avoid few spurious failures
Stefano Lattarini [Mon, 20 Jun 2011 14:58:22 +0000 (16:58 +0200)]
maintcheck: avoid few spurious failures

* tests/depmod-data.test: Use creative quoting to avoid
spuriously triggering the `sc_tests_Exit_not_exit' maintainer
check.  Commit `v1.11-900-g3453b8e' attempted to fix it, but
succeeded only partially.
* tests/cond33.test: Fix header comments, not to reference
obsolescent make variable `$(mkdir_p)'.
* tests/cond4.test: Rewrite "$MAKE exp=..." as "exp=.. $MAKE -e",
to please `sc_tests_overriding_macros_on_cmdline'
* tests/cond19.test: Likewise.
* tests/cond32.test: Likewise.
* tests/add-missing.test: Use "AUTOMAKE_fails" instead of
"$AUTOMAKE ... && Exit 1", to please `sc_tests_automake_fails'.

13 years agomaintcheck: avoid few spurious failures
Stefano Lattarini [Mon, 20 Jun 2011 14:42:10 +0000 (16:42 +0200)]
maintcheck: avoid few spurious failures

* Makefile.am (sc_tests_plain_aclocal, sc_tests_plain_perl,
sc_tests_plain_autoconf, sc_tests_plain_automake,
sc_tests_plain_autoupate): Be stricter in matching an erroneous
literal command, i.e., `aclocal', `automake', `perl', etc.

13 years agoMerge branch 'maint' into parallel-tests-maint
Stefano Lattarini [Mon, 20 Jun 2011 08:49:09 +0000 (10:49 +0200)]
Merge branch 'maint' into parallel-tests-maint

* maint:
  check: don't use multi-line coloring for the report
  ansi2knr: deprecate, it will go away in the next major release
  docs: primary/prefix combination "pkglib_PROGRAMS" is now invalid
  docs: replace obsolete @vindex entry with a useful one
  docs: AM_DISTCHECK_CONFIGURE_FLAGS is for corner cases

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Mon, 20 Jun 2011 08:48:11 +0000 (10:48 +0200)]
Merge branch 'master' into testsuite-work

* master:
  check: don't use multi-line coloring for the report
  ansi2knr: deprecate, it will go away in the next major release
  docs: primary/prefix combination "pkglib_PROGRAMS" is now invalid
  docs: replace obsolete @vindex entry with a useful one
  tests: more checks on portable fd redirection in TESTS_ENVIRONMENT
  docs: AM_DISTCHECK_CONFIGURE_FLAGS is for corner cases

13 years agoMerge branch 'maint'
Stefano Lattarini [Mon, 20 Jun 2011 08:46:09 +0000 (10:46 +0200)]
Merge branch 'maint'

* maint:
  check: don't use multi-line coloring for the report
  ansi2knr: deprecate, it will go away in the next major release
  docs: primary/prefix combination "pkglib_PROGRAMS" is now invalid
  docs: replace obsolete @vindex entry with a useful one
  docs: AM_DISTCHECK_CONFIGURE_FLAGS is for corner cases

13 years agocheck: don't use multi-line coloring for the report
Bert Wesarg [Fri, 17 Jun 2011 19:59:52 +0000 (21:59 +0200)]
check: don't use multi-line coloring for the report

"less -R" can't handle multi-line coloring as it is done for the
check reports of the serial and parallel testsuite, because of
performance reasons.  Thus, color each line of the check report
by its own.

* lib/am/check.am (am__text_box): Accept colors for lines, and
color each line by its own.
[%?PARALLEL_TESTS%] $(TEST_SUITE_LOG): Let am__text_box handle
the line coloring.
[!%?PARALLEL_TESTS%] $(check-TESTS): Color each report line by
its own.
* THANKS: Update.

13 years agoMerge branch 'am-distcheck-configure-flags' into maint
Stefano Lattarini [Mon, 20 Jun 2011 07:43:25 +0000 (09:43 +0200)]
Merge branch 'am-distcheck-configure-flags' into maint

13 years agoansi2knr: deprecate, it will go away in the next major release
Stefano Lattarini [Mon, 13 Jun 2011 19:27:35 +0000 (21:27 +0200)]
ansi2knr: deprecate, it will go away in the next major release

* doc/automake.texi: Loudly and repeatedly state that the old
de-ANSI-fication features are now deprecated and will be removed
in the next major Automake release.  Other related adjustments.
* lib/Automake/Options.pm (_process_option_list ): Give a warning
in the `obsolete' category when the `ansi2knr' option is used.
* m4/protos.m4 (AM_C_PROTOTYPES): Deprecate this macro: a warning
in the `obsolete' category will be emitted it if is used.
* tests/ansi2knr-deprecation.test: New test.
* tests/Makefile.am (TESTS): Update.
* tests/ansi.test: Adjust, by calling autoconf and/or automake
with the `-Wno-obsolete' flag.
* tests/ansi10.test: Likewise.
* tests/ansi2.test: Likewise.
* tests/ansi3.test: Likewise.
* tests/ansi3b.test: Likewise.
* tests/ansi4.test: Likewise.
* tests/ansi5.test: Likewise.
* tests/ansi6.test: Likewise.
* tests/ansi7.test: Likewise.
* tests/ansi8.test: Likewise.
* tests/ansi9.test: Likewise.
* tests/cxxansi.test: Likewise.
* tests/libobj8.test: Likewise.
* NEWS: Update about the future planned backward-incompatibility
due to the removal of de-ANSI-fication feature.

13 years agodocs: primary/prefix combination "pkglib_PROGRAMS" is now invalid
Stefano Lattarini [Sun, 19 Jun 2011 11:15:49 +0000 (13:15 +0200)]
docs: primary/prefix combination "pkglib_PROGRAMS" is now invalid

* doc/automake.texi (Program Sources): pkglib_PROGRAMS is not a
valid combination anymore, so don't document it.  Inconsistency
introduced in commit `v1.11-373-g9ca6326'.

13 years agodocs: replace obsolete @vindex entry with a useful one
Jim Meyering [Sun, 19 Jun 2011 10:32:59 +0000 (12:32 +0200)]
docs: replace obsolete @vindex entry with a useful one

* doc/automake.texi (Program Sources): Do not index obsolete
pkglib_PROGRAMS here.  Do index pkglibexec_PROGRAMS.

13 years agoMerge branch 'test-fd-redirect'
Stefano Lattarini [Sat, 18 Jun 2011 17:16:41 +0000 (19:16 +0200)]
Merge branch 'test-fd-redirect'

* test-fd-redirect:
  tests: more checks on portable fd redirection in TESTS_ENVIRONMENT

13 years agotests: more checks on portable fd redirection in TESTS_ENVIRONMENT
Stefano Lattarini [Sat, 18 Jun 2011 12:53:08 +0000 (14:53 +0200)]
tests: more checks on portable fd redirection in TESTS_ENVIRONMENT

* tests/tests-environment-fd-redirect.test: Extend by also using
a perl script among the tests.  Run the test shell script with
the `errexit' flag active.  Export `VERBOSE' to yes when running
"make check", to give more debugging information in case of
failures.  Look for a Korn Shell also in `/usr/bin', not on only
in `/bin'.

13 years agodocs: AM_DISTCHECK_CONFIGURE_FLAGS is for corner cases
Stefano Lattarini [Wed, 15 Jun 2011 08:50:03 +0000 (10:50 +0200)]
docs: AM_DISTCHECK_CONFIGURE_FLAGS is for corner cases

* doc/automake.texi (Checking the Distribution): Explain that the
developers should take care of making their code buildable without
requiring any special configure options, so that in general
AM_DISTCHECK_CONFIGURE_FLAGS shouldn't be used.  Give an example
of where its use is legitimate.

13 years agoMerge branch 'maint' into parallel-tests-maint
Stefano Lattarini [Thu, 16 Jun 2011 15:21:00 +0000 (17:21 +0200)]
Merge branch 'maint' into parallel-tests-maint

* maint:
  news: update w.r.t. introduction of AM_DISTCHECK_CONFIGURE_FLAGS
  tests: optimize tests on primary/prefix mismatch for speed
  Warnings about primary/prefix mismatch fixed and extended.
  maintcheck: DISTCHECK_CONFIGURE_FLAGS can be defined on make cmdline
  distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS
  docs: better documentation for silent make rules

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Thu, 16 Jun 2011 15:04:25 +0000 (17:04 +0200)]
Merge branch 'master' into testsuite-work

* master:
  tests: check portable fd redirection in TESTS_ENVIRONMENT
  news: update w.r.t. introduction of AM_DISTCHECK_CONFIGURE_FLAGS
  tests: optimize tests on primary/prefix mismatch for speed
  Warnings about primary/prefix mismatch fixed and extended.
  maintcheck: DISTCHECK_CONFIGURE_FLAGS can be defined on make cmdline
  distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS
  docs: better documentation for silent make rules

13 years agoMerge branch 'maint'
Stefano Lattarini [Thu, 16 Jun 2011 14:56:36 +0000 (16:56 +0200)]
Merge branch 'maint'

* maint:
  news: update w.r.t. introduction of AM_DISTCHECK_CONFIGURE_FLAGS
  tests: optimize tests on primary/prefix mismatch for speed
  Warnings about primary/prefix mismatch fixed and extended.
  maintcheck: DISTCHECK_CONFIGURE_FLAGS can be defined on make cmdline
  distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS
  docs: better documentation for silent make rules

13 years agotests: make test 'self-check-reexec.test' more portable
Stefano Lattarini [Thu, 16 Jun 2011 12:50:50 +0000 (14:50 +0200)]
tests: make test 'self-check-reexec.test' more portable

* tests/self-check-reexec.test: Rewrite not to require a Korn
Shell able to grok variable expansions such as `${.sh.version}';
Solaris 10 /bin/ksh fails on this for example.  Instead, just
require bash and a shell that is not bash.

13 years agoMerge branch 'tests-defs-fix-stderr-redirect-bug' into testsuite-work
Stefano Lattarini [Thu, 16 Jun 2011 08:41:49 +0000 (10:41 +0200)]
Merge branch 'tests-defs-fix-stderr-redirect-bug' into testsuite-work

13 years agotests: check portable fd redirection in TESTS_ENVIRONMENT
Stefano Lattarini [Tue, 14 Jun 2011 07:41:14 +0000 (09:41 +0200)]
tests: check portable fd redirection in TESTS_ENVIRONMENT

* tests/tests-environment-fd-redirect.test: New test.
* tests/Makefile.am (TESTS): Update.

Motivated by coreutils bug#8846:
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8846>
See also following CC:ed thread on bug-autoconf list:
 <http://lists.gnu.org/archive/html/bug-autoconf/2011-06/msg00002.html>

13 years agoMerge branch 'more-prefix-primary-diagnostic' into maint
Stefano Lattarini [Thu, 16 Jun 2011 08:29:32 +0000 (10:29 +0200)]
Merge branch 'more-prefix-primary-diagnostic' into maint

13 years agoMerge branch 'tests-more-shells' into testsuite-work
Stefano Lattarini [Thu, 16 Jun 2011 08:26:10 +0000 (10:26 +0200)]
Merge branch 'tests-more-shells' into testsuite-work

13 years agoregenerate tests/Makefile.in
Stefano Lattarini [Thu, 16 Jun 2011 08:25:59 +0000 (10:25 +0200)]
regenerate tests/Makefile.in

13 years agoMerge branch 'tests-more-shells' into testsuite-work
Stefano Lattarini [Thu, 16 Jun 2011 08:17:30 +0000 (10:17 +0200)]
Merge branch 'tests-more-shells' into testsuite-work

13 years agoMerge branch 'extend-coverage-for-add-missing' into testsuite-work
Stefano Lattarini [Thu, 16 Jun 2011 08:13:18 +0000 (10:13 +0200)]
Merge branch 'extend-coverage-for-add-missing' into testsuite-work

13 years agotests: few fixlets and improvements
Stefano Lattarini [Sun, 12 Jun 2011 17:35:53 +0000 (19:35 +0200)]
tests: few fixlets and improvements

* tests/cond31.test ($required): Remove `cc', it's not really
needed.
* tests/confh.test: Call autoheader too.  The lack of this call
wasn't causing spurious failures because, when make was called,
the automatic remake rules somehow ended up invoking it on our
behalf.
* tests/fn99subdir.test: Use $subdirname throughout, instead of
${subdirname}, for consistency with the rest of the testsuite.
Avoid an unnecessary subshell, which could also cause spurious
passes, being guarded by a trailing `|| Exit 1', which neutralize
the `errexit' flag.  Remove an unnecessary `|| Exit 1' guard.
* tests/insh2.test: Rewrite to avoid hackish Makefile.in munging,
and to also run configure and make.

13 years agotest defs: fix ksh-related portability bug in warning messages
Stefano Lattarini [Mon, 13 Jun 2011 20:42:25 +0000 (22:42 +0200)]
test defs: fix ksh-related portability bug in warning messages

Running "make check" normally prints a diagnostic to the outermost
stderr (usually a tty) to explain why a test is skipped, thus
giving better and faster feedback to the user.  It used to do
so by redirecting file descriptor 9 to stderr (via "exec 9>&2")
before invoking the test scripts, which then would write any skip
explanation to file descriptor 9 via the `skip_' function defined
in `tests/defs'.

However, various Korn Shells (at least Solaris 10's /bin/ksh and
Debian GNU/Linux's /bin/ksh) and the HP-UX's /bin/sh close open
file descriptors > 2 upon an `exec' system call; thus the effects
of "exec 9>&2" are cancelled upon fork-and-exec, so we would get
a "Bad file number" diagnostic and no skip explanation with those
shells.

The present change remedies this situation.

* tests/Makefile.am (AM_TESTS_ENVIRONMENT): Redirect more portably,
via a trailing "9>&2", rather than the prior "exec 9>&2; ...".  Add
explanatory comments.
* tests/defs (stderr_fileno_): Update the advice in comments.

Based on commit v8.12-82-g6b68745 "tests: accommodate HP-UX and
ksh-derived shells" in GNU coreutils.

Further references, with lots of discussion:
 <http://lists.gnu.org/archive/html/bug-autoconf/2011-06/msg00002.html>
 <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/22488>
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8846>

13 years agoMerge branch 'am-distcheck-configure-flags' into maint
Stefano Lattarini [Mon, 13 Jun 2011 19:42:06 +0000 (21:42 +0200)]
Merge branch 'am-distcheck-configure-flags' into maint

* am-distcheck-configure-flags:
  news: update w.r.t. introduction of AM_DISTCHECK_CONFIGURE_FLAGS

13 years agonews: update w.r.t. introduction of AM_DISTCHECK_CONFIGURE_FLAGS
Stefano Lattarini [Mon, 13 Jun 2011 19:40:57 +0000 (21:40 +0200)]
news: update w.r.t. introduction of AM_DISTCHECK_CONFIGURE_FLAGS

* NEWS (Miscellaneous changes): Update.

13 years agoMerge branch 'am-distcheck-configure-flags' into maint
Stefano Lattarini [Mon, 13 Jun 2011 18:16:16 +0000 (20:16 +0200)]
Merge branch 'am-distcheck-configure-flags' into maint

* am-distcheck-configure-flags:
  maintcheck: DISTCHECK_CONFIGURE_FLAGS can be defined on make cmdline
  distcheck: add support for AM_DISTCHECK_CONFIGURE_FLAGS

13 years agotests: extend tests on `--add-missing' and `--copy' a bit
Stefano Lattarini [Mon, 13 Jun 2011 17:42:52 +0000 (19:42 +0200)]
tests: extend tests on `--add-missing' and `--copy' a bit

* tests/add-missing.test: Fix typo in heading comments.  Try with
another testcase that install many (but not all) the auxiliary
scripts at once, and uses non-standard (but valid and documented)
setups (e.g., defining YACC in Makefile.am instead of calling
AC_PROG_YACC from configure.in).
* tests/copy.test: Reference `add-missing.test' in heading
comments.  Try few more test scenarios.

13 years agotests: remove 'test_prefer_config_shell' from the environment
Stefano Lattarini [Mon, 13 Jun 2011 16:19:53 +0000 (18:19 +0200)]
tests: remove 'test_prefer_config_shell' from the environment

Since commit `v1.11-910-g7df1a9b', the once user-overridable
variable `$test_prefer_config_shell' has become an internal
detail, and the test scripts now complain and bail out if it is
set in the environment.

* tests/Makefile.am (AM_TESTS_ENVIRONMENT): Unset the variable
`test_prefer_config_shell' if it is set in the environment.

13 years agotests: don't hard-code the test name in txinfo21.test
Stefano Lattarini [Mon, 13 Jun 2011 16:02:40 +0000 (18:02 +0200)]
tests: don't hard-code the test name in txinfo21.test

* tests/txinfo21.test: Use `$me' instead of hard-coding the
current testcase name "txinfo21".  Add a trailing `:' command
since we are at it.

13 years agotests: autogenerate list of wrapped tests for `lib/' shell scripts
Stefano Lattarini [Mon, 13 Jun 2011 12:48:57 +0000 (14:48 +0200)]
tests: autogenerate list of wrapped tests for `lib/' shell scripts

* tests/gen-config-shell-tests: New script, generates distributed
makefile snippet `tests/config-shell-tests.am' to list all tests
that use the `get_shell_script' function, with names mangled to
use suffix `-w.shtst', in ...
* tests/Makefile.am (config_shell_tests): ... this macro, whose
definition has been consequently removed from Makefile.am.
(EXTRA_DIST): Distribute the new script.
($(srcdir)/config-shell-tests.am): Generate using the new script.
(include): Include the `config-shell-tests.am' fragment.
* bootstrap: Invoke `tests/gen-config-shell-tests' to generate
`tests/config-shell-tests.am'.
* tests/.gitignore: Ignore `config-shell-tests.am'.
* tests/gen-parallel-tests: Fixlet in heading comments.

13 years agotests: test mdate-sh with /bin/sh too
Stefano Lattarini [Mon, 13 Jun 2011 10:21:52 +0000 (12:21 +0200)]
tests: test mdate-sh with /bin/sh too

* tests/mdate5.test: Fetch the `mdate-sh' script using the
`get_shell_script' function, and run it directly instead of
using `$SHELL'.
* tests/mdate6.test: Likewise.  Since we are at it, make checks
on the `mdate-sh' output stricter, remove now unneeded calls to
aclocal and automake and creation/extension of `configure.in',
`Makefile.am' and `textutils.tex' files, and add a trailing `:'
command.
* tests/Makefile.am (config_shell_tests): Add `mdate5-w.shtst'
and `mdate6-w.shtst'.

13 years agoMerge branch 'silent-rules-doc' into maint
Stefano Lattarini [Mon, 13 Jun 2011 09:07:20 +0000 (11:07 +0200)]
Merge branch 'silent-rules-doc' into maint

13 years agotests: optimize tests on primary/prefix mismatch for speed
Stefano Lattarini [Mon, 13 Jun 2011 08:51:57 +0000 (10:51 +0200)]
tests: optimize tests on primary/prefix mismatch for speed

* tests/primary-prefix-invalid-couples.test: Partial rewrite, in
order to use just a single automake invocation rather than one
invocation for each invalid primary/prefix couple.  This improves
the test script execution time by an order of magnitude.
Since we are at it, throw in some other improvements to avoid
unrelated automake warnings and failures that could potentially
cause false positives w.r.t. the automake exit status.

13 years agoMerge branch 'extend-coverage-for-add-missing' into testsuite-work
Stefano Lattarini [Sun, 12 Jun 2011 22:00:53 +0000 (00:00 +0200)]
Merge branch 'extend-coverage-for-add-missing' into testsuite-work

* extend-coverage-for-add-missing:
  tests: new test dedicated to `--add-missing' and `--copy'

13 years agoWarnings about primary/prefix mismatch fixed and extended.
Stefano Lattarini [Thu, 16 Dec 2010 18:23:06 +0000 (19:23 +0100)]
Warnings about primary/prefix mismatch fixed and extended.

* automake.in (%standard_prefix): Add `doc' and `locale'.
Rename `pkgdatadir' to `pkgdata'.  Similarly for`pkglibdir',
`pkgincludedir' and `pkglibexecdir'.
(handle_programs): List `pkglibexec', not `pkglib', among the
prefixes valid for the `PROGRAMS' primary.
(handle_data): List also `doc' among the prefixes valid for
the `DATA' primary.  This is required by automake's own build
system.
* tests/dirforbid.test: Test removed, superseded by ...
* tests/primary-prefix-invalid-couples.test: ... this new test.
* tests/primary-prefix-valid-couples.test: New test.
* tests/primary-prefix-documented-valid.test: Likewise.
* tests/primary-prefix-force-valid.test: Likewise.
* tests/java3.test: Adjusted, and extended a bit.
* tests/Makefile.am (TESTS): Updated.
* NEWS: Updated.

From a report by Eric Blake.

13 years agoMerge branch 'master' into testsuite-work
Stefano Lattarini [Sat, 11 Jun 2011 10:54:44 +0000 (12:54 +0200)]
Merge branch 'master' into testsuite-work

13 years agoMerge branch 'maint' into parallel-tests-maint
Stefano Lattarini [Sat, 11 Jun 2011 10:52:51 +0000 (12:52 +0200)]
Merge branch 'maint' into parallel-tests-maint

* maint:
  test defs: new function 'fatal_', for hard errors

13 years agoMerge branch 'maint'
Stefano Lattarini [Sat, 11 Jun 2011 10:47:56 +0000 (12:47 +0200)]
Merge branch 'maint'

* maint:
  test defs: new function 'fatal_', for hard errors

13 years agotestsuite: use 'fatal_' and 'framework_failure_' for hard errors
Stefano Lattarini [Tue, 7 Jun 2011 14:36:40 +0000 (16:36 +0200)]
testsuite: use 'fatal_' and 'framework_failure_' for hard errors

* tests/defs (require_xsi): Use `fatal_', not `framework_failure',
to report an invalid usage.
* tests/remake-gnulib-remove-header.test: Prefer using `fatal_'
with a proper error message over a direct call to `Exit 99'.
* tests/pr8365-remake-timing.test: Likewise.
* tests/cygnus-imply-foreign.test: Likewise.
* tests/missing6.test: Likewise.
* tests/cond8.test: Likewise.
* tests/cond33.test: Likewise.
* tests/python-virtualenv.test: Prefer using `framework_failure_'
with a proper error message over a direct call to `Exit 99'.
* tests/instspc-tests.sh: Prefer using `framework_failure_' and
`fatal_' over direct calls to `Exit 99'.
(fatal_): Define this (which is a simplified version of the one
in `tests/defs') for early uses (i.e., before `tests/defs'
gets sourced).
* tests/depmode-tests.sh: Likewise.  Also, simplify the
'get_depmodes' function and calls to it accordingly.

13 years agoself tests: check new 'fatal_' function
Stefano Lattarini [Tue, 7 Jun 2011 14:00:31 +0000 (16:00 +0200)]
self tests: check new 'fatal_' function

* tests/self-check-exit.test: Also check the new 'fatal_'
function.

13 years agoMerge branch 'maint' into testsuite-work
Stefano Lattarini [Sat, 11 Jun 2011 10:22:15 +0000 (12:22 +0200)]
Merge branch 'maint' into testsuite-work

* maint:
  test defs: new function 'fatal_', for hard errors

13 years agotests: new test dedicated to `--add-missing' and `--copy'
Stefano Lattarini [Tue, 7 Jun 2011 20:49:28 +0000 (22:49 +0200)]
tests: new test dedicated to `--add-missing' and `--copy'

* tests/add-missing.test: New test.
* tests/Makefile.am (TESTS): Update.

Suggested by Peter Rosin.