Ali Alzyod [Wed, 6 May 2020 11:33:42 +0000 (20:33 +0900)]
edje_textblock: content_fit size_range update
Summary: update size range will skip empty font_sizes
Reviewers: woohyun, bowonryu
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11507
Ali [Wed, 6 May 2020 11:30:14 +0000 (20:30 +0900)]
edje_textblock: optimize priority handling for content_fit options
Summary: this patch will reduce amount of unnessesary calculations, if user set both font_size_array and size_range for content fit.
Reviewers: woohyun, bowonryu
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11498
Ali Alzyod [Wed, 6 May 2020 09:40:37 +0000 (10:40 +0100)]
evas_textblock: clear paragraphs during markup_set
Summary: Clear paragraph during markup set, instead of waiting until next text layout to happen, this will release unused memory right away
Reviewers: woohyun, zmike, bu5hm4n, raster
Subscribers: raster, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11773
Jongmin Lee [Wed, 6 May 2020 01:37:11 +0000 (10:37 +0900)]
spec: resolve migration build error
Change-Id: I4085fb2b0d868cb39b10d81a50fd099bd03a4d76
Stefan Schmidt [Tue, 5 May 2020 13:02:29 +0000 (15:02 +0200)]
ci: travis: update more jobs to Fedora32 image
With the edje test suite problems resolved almost all jobs can be moved.
Mingw, exactness and asan need more testing and debugging.
Ali Alzyod [Tue, 5 May 2020 12:15:55 +0000 (12:15 +0000)]
tests: edje: Fedora32 system fail resolve
This test seems to fail on Fedora32, we increase font size margin to
prevent it from happening
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11776
Stefan Schmidt [Tue, 5 May 2020 11:50:53 +0000 (13:50 +0200)]
ci: travis: update first few jobs to Fedora32
The rest stays on 31 right now until we worked out some remaining
problems in test suites, asan, etc.
Stefan Schmidt [Tue, 5 May 2020 10:28:39 +0000 (11:28 +0100)]
ecore_drm: ensure we have the symbol available at the right place.
Summary:
Linking under Fedora32 toolchain got more picky. Ecore_drm_device.c
needs the symbol so make sure we have it there.
Reviewers: devilhorns, raster
Reviewed By: raster
Subscribers: raster, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11772
Marcel Hollerbach [Tue, 5 May 2020 08:53:15 +0000 (10:53 +0200)]
exactness_player: do not test for delay_ms
that is a unsigned int, if its 0 the timer is called as fast as
possible. Not doing that breaks exactness.
@fix
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11774
Ali Alzyod [Mon, 4 May 2020 19:25:07 +0000 (15:25 -0400)]
evas_textblock: optimize calculate main format once in layout setup stage
Summary:
This change based on discussion on D9533 , where @smohanty example shows that unnecessary calculation happened on textblock related to lay-outing
Where now _layout_setup will not calculate main format using (_format_fill) unless style has been changed.
expedite commit:
https://git.enlightenment.org/tools/expedite.git/commit/?id=
dc6c931dc2e6c240d3e240f24578980c689ab7fc
src/bin/textblock_text_fill_format.c
Test Plan:
```
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include <Eina.h>
#include <Efl.h>
#include <Elementary.h>
EAPI_MAIN int
elm_main(int argc, char **argv)
{
Evas_Object *win, *textblock;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("Main", "App");
elm_win_autodel_set(win, EINA_TRUE);
int l, r, t, b;
textblock = evas_object_textblock_add(evas_object_evas_get(win));
Evas_Textblock_Style *st = evas_textblock_style_new();
evas_textblock_style_set (st, "DEFAULT='font=Sans font_size=10 color=#000000 wrap=word align=left outline_color=#000 shadow_color=#fff8 shadow_color=#0002 glow2_color=#fe87 glow_color=#f214 underline_color=#00f linesize=40'");
evas_object_textblock_style_set(textblock, st);
int sizes[] = {600, 700};
evas_object_textblock_text_markup_set(textblock, "This test resize text block and keep style (style parsed only once)");
clock_t start, end;
start = clock();
for (int i = 0; i < 10000; i++)
{
evas_object_resize(textblock, sizes[i % 2], sizes[i % 2]);
evas_object_textblock_style_insets_get(textblock, &l, &r, &t, &b);
}
end = clock();
double total_Time1 = ((double)(end - start)) / CLOCKS_PER_SEC;
printf("total time = %f\n", total_Time1);
evas_object_size_hint_weight_set(textblock, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(textblock, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_show(textblock);
evas_object_move(textblock, 0, 0);
evas_object_resize(textblock, 640, 800);
evas_object_resize(win, 640, 800);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
**Old Code output : total time = 0.096900
New Code output : total time = 0.045580**
Reviewers: smohanty, woohyun, Hermet, bowonryu, cedric, bu5hm4n, zmike
Reviewed By: zmike
Subscribers: zmike, segfaultxavi, bu5hm4n, smohanty, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9536
Vincent Torri [Mon, 4 May 2020 13:21:03 +0000 (14:21 +0100)]
remove arguments of LOGFN in ecre_x and ecore_wayland as the are always the same
Reviewers: raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11769
Stefan Schmidt [Tue, 28 Apr 2020 12:04:18 +0000 (14:04 +0200)]
examples: cxx: remove forced warning on unfinished APIs
Personally I find it quite annoying to have these in every build.
Especially if they have not been attempted to get fixed even after we
started to stabilize some part of the unified API.
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11763
Carsten Haitzler (Rasterman) [Sun, 3 May 2020 14:34:42 +0000 (15:34 +0100)]
ecore_evas_x - fix maximize/unmaximize request corner case
state was not managed well.. this will fix that. also a test in
elementary for it to you can test it out.
@fix
Christopher Michael [Sat, 2 May 2020 18:44:59 +0000 (14:44 -0400)]
ecore-buffer: Fix formatting
NB: No functional changes
Christopher Michael [Fri, 1 May 2020 14:26:54 +0000 (10:26 -0400)]
ecore-drm2: Add support for using page_flip_handler2
In our current Ecore_Drm2_Context structure, we are missing support
for using page_flip_handler2. This patch adds that ability. This could
prove useful when working with ecore_drm2 as it allows
page_flip_handler callbacks to setup a handler for page_flip_handler2,
which when the callback gets received, passes back the crtc_id which
the pageflip occured on.
@feature
Carsten Haitzler (Rasterman) [Fri, 1 May 2020 11:50:53 +0000 (12:50 +0100)]
edje - don't set font sizes less than 1
this makes evas unhappy and results in noise.
@fix
Carsten Haitzler (Rasterman) [Thu, 30 Apr 2020 23:07:12 +0000 (00:07 +0100)]
build - remove useless header checks for uv.h
we check for uv.h - but never do anything with it. this is configure
noise that just confuses people into thinking we might do something.
we still have dead libuv support but it's enabled with HAVE_LIBUV and
we'd need to link to libuv too... which we don't do and we don't enable
this. removing libuv supporrt entirely is a totally different question
to raise. this here is just removing noise.
Stefan Schmidt [Thu, 30 Apr 2020 13:58:31 +0000 (15:58 +0200)]
exactness: remove no longer needed _evas_new()
This has been unused since the move to a preloaded lib and now makes
trouble durign compilation on Fedora32.
@fix
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11767
Marcel Hollerbach [Thu, 30 Apr 2020 13:22:01 +0000 (09:22 -0400)]
ecore_evas: only define these eina errors once
Summary:
they are not needed multiple times, infact this is creating multiple
definition errors.
@fix
Reviewers: stefan_schmidt, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11766
Marcel Hollerbach [Wed, 29 Apr 2020 15:47:05 +0000 (11:47 -0400)]
elm_fileselector: support expandable items
Summary:
the fileselector can store exactly 1 model and monitor that for changes,
which works normally just well. However, when we expand a items, another
model comes into play, which is not monitored, and no additional
reference is taken. Which means, _process_last will simply delete it,
and elements that did not come into play at the _populate call are never
displayed.
With this commit, we check that we do not have a parent item, and
explictly wait for the model to publish all its items, before we call
_process_last.
Additionally, that showed that the tracking of the list/grid item is
ultimatly buggy, as there is no assertion that the parent model is
really the parent directoy. Hence we need to hand pass the parent item
here, as a fallback option to set the correct parent item.
fixes T8689
Reviewers: zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8689
Differential Revision: https://phab.enlightenment.org/D11765
Xavi Artigas [Wed, 29 Apr 2020 15:32:41 +0000 (17:32 +0200)]
doxygen docs: Add missing group braces
Without them, these Evil docs had no group and therefore didn't appear anywhere.
Xavi Artigas [Wed, 29 Apr 2020 15:23:09 +0000 (17:23 +0200)]
doxygen docs: Add tests folder to EXAMPLE_PATH
One Emotion example is located in src/tests instead of src/examples
so look for examples in that folder too.
Xavi Artigas [Wed, 29 Apr 2020 15:14:35 +0000 (17:14 +0200)]
doxygen docs: add missing example references
Xavi Artigas [Wed, 29 Apr 2020 14:51:23 +0000 (16:51 +0200)]
doxygen docs: Fix reference to Elm_Start
Xavi Artigas [Wed, 29 Apr 2020 14:26:47 +0000 (16:26 +0200)]
doxygen docs: Replace broken URL with doxygen ref
Xavi Artigas [Wed, 29 Apr 2020 14:17:53 +0000 (16:17 +0200)]
doxygen docs: Fix missing links in Ecore_Drm
Ecore_Drm_Input had SOME docs, so a group for them is created.
Ecore_Drm_Sprite had NO DOCS at all, so the link is just removed.
This is a deprecated library anyway.
Xavi Artigas [Wed, 29 Apr 2020 13:39:52 +0000 (15:39 +0200)]
doxygen docs: Fix broken links in main page
Stefan Schmidt [Wed, 29 Apr 2020 13:47:36 +0000 (15:47 +0200)]
edje: efl: add new EFL_VERSION_1_25 define for new cycle
Allow things to be marked for the upcoming 1.25 release version while we
develop it.
Stefan Schmidt [Wed, 29 Apr 2020 10:14:20 +0000 (12:14 +0200)]
build: release freeeze over
Going back to normal development mode. Have fun!
Yeongjong Lee [Fri, 13 Mar 2020 04:28:29 +0000 (13:28 +0900)]
efl_net_dialer_unix: use compositor socket instead of socket4 for connection
since
80c7e8093f8c097b2999e07aa9934dd67509c8a1, fd is -1 when
efl_net_connect_async_with_fd_new is called. this patch change it to use
socket from E compositor because of tizen policy.
(See commit
ebfaab3e05f755428aaee021253c8e5255fd388f)
Also, This reverts commit
80c7e8093f8c097b2999e07aa9934dd67509c8a1.
@tizen_fix
Change-Id: Ie824d15ace426f91baa2a9ac1547481f000c5804
HyukSoon Choi [Fri, 10 Apr 2020 05:57:26 +0000 (14:57 +0900)]
genlist: need to custom fish_eye effect
Customisation of fish eye effect is required for spinner and more option
to achieve the UX
"vi_effect" in genlist: enable/disable all items opearation
"item_gap": padding values to be applied between items on fish eye effect in spinner
parameter 1: position adjustment for the n-1 and n+1 item to center item n
parameter 2: position adjustment for the n-2 and n+2 item to center item n
"proxy_gap": Padding for proxy for top and bottom item in more option
"proxy_top_offset": Offset adjustment for top item in more option
"proxy_color": To custom color transition
Change-Id: I1a7cfbb035daefca1173f83000c56c14ef9d7288
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
Godly T.Alias [Wed, 15 Apr 2020 05:09:54 +0000 (10:39 +0530)]
[Scrollable Interface] Fix for genlist item selection issue
Change-Id: I1261427ce251c676bcffc1090ecc6107f9be4466
Signed-off-by: Yukti Pandey <yukti.pandey@samsung.com>
Godly T.Alias [Tue, 14 Apr 2020 04:37:59 +0000 (10:07 +0530)]
[efl]Support for rotary event on page change.
Signed-off-by: Yukti Pandey <yukti.pandey@samsung.com>
Change-Id: I0a10ddf685522d5685ba1beab1bfa469b2adc96c
Godly T.Alias [Mon, 13 Apr 2020 08:08:07 +0000 (13:38 +0530)]
[efl] Fix for scroller not maintaining pan position on resize.
Signed-off-by: Yukti Pandey <yukti.pandey@samsung.com>
Change-Id: Iddbdb89c156ed14e0d3dfbb9787edb8715b1b81b
Prince Kumar Dubey [Tue, 21 Apr 2020 19:32:52 +0000 (01:02 +0530)]
[evas_textblock] Fix for [DEREF_OF_NULL.RET.ALLOC]
Change-Id: I46f5e585f0131273b6b3742b2175dd748d6214b5
Signed-off-by: Prince Kumar Dubey <prince.dubey@samsung.com>
Prince Kumar Dubey [Tue, 21 Apr 2020 17:34:08 +0000 (23:04 +0530)]
[elm_genlist] Fix for [DEREF_OF_NULL.RET.STAT]
Change-Id: I1bcf01456f66a169edc10f0a5b6f17acc7d679fd
Signed-off-by: Prince Kumar Dubey <prince.dubey@samsung.com>
Prince Kumar Dubey [Tue, 21 Apr 2020 12:41:33 +0000 (18:11 +0530)]
[elm_gengrid] To Fix [DEREF_OF_NULL.RET.ALLOC][NO_CAST.INTEGER_DIVISION]
Change-Id: I89d5960640338549705fb7cefd79f0f7efec429b
Signed-off-by: Prince Kumar Dubey <prince.dubey@samsung.com>
Prince Kumar Dubey [Tue, 21 Apr 2020 19:45:45 +0000 (01:15 +0530)]
[efl_ui_clock] Fix for [INTEGER_OVERFLOW]
Change-Id: I278d15b56a84fb0350f290b64b8b22b42336fc21
Signed-off-by: Prince Kumar Dubey <prince.dubey@samsung.com>
Nihar Raichada [Tue, 21 Apr 2020 10:47:41 +0000 (16:17 +0530)]
[elm_toolbar] To Fix [NULL.DEREF.RET.ALLOC]
There was no null check after memory allocation. Added that.
Change-Id: Id329d7c6dfcffd8c47f9083de0212d3c7f3696c2
Signed-off-by: Nihar Raichada <n.raichada@samsung.com>
SangHyeon Jade Lee [Thu, 23 Apr 2020 09:43:53 +0000 (18:43 +0900)]
genlist : remove unnecessary idle enterer deletion
item_queue is the function that called every item generation.
delete old idle enterer and create new enterer for every
item creation is unnecessary and also make performance worse.
Change-Id: Iea5f34304e3ce25a0c1952d31fca1fea17e09858
SangHyeon Jade Lee [Thu, 23 Apr 2020 09:33:15 +0000 (18:33 +0900)]
genlist: performance enhancement by refactoring realization logics
item realize and unrealize time can be reduced by removing
unnecessary view / proxy object creation.
we have cache for unrealized view / proxy,
but it will be filled by unrealization,
so we need to place item realization after unrealization.
this patch is tweak of change all the item realization
performed right after the every item unrealization done.
if there are so many unrealization,
cache can be overflow, which is double of block size.
but most of cases,
visible item counts are less than block size,
and worst scenario of screen refresh is every visible item changes,
so cache size will be big enough to perform the 1 frame unrealizaiton.
Change-Id: Ibad2f48efca829137d3a95b4110a998eb7533692
Godly T.Alias [Tue, 14 Apr 2020 13:33:42 +0000 (19:03 +0530)]
[Genlist] Focus bg hide need to be done only on scroll align unset
Change-Id: I57ed2f8e7fcf7cd6cdfd6488f31256f3f0665b59
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
Prince Kumar Dubey [Tue, 21 Apr 2020 12:13:20 +0000 (17:43 +0530)]
[elm_gengrid] Indentation corrected.
Change-Id: I0023e808b292ec83bc52a33a7de8079782ec7147
Signed-off-by: Prince Kumar Dubey <prince.dubey@samsung.com>
godlytalias14573465 [Tue, 21 Apr 2020 11:45:45 +0000 (17:15 +0530)]
Naviframe: Safety codes for null pointer dereferencing
Change-Id: Id6929d3c296395dee8f6e1f1c3f6e97f33953e90
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Seungwan Woo [Thu, 9 Apr 2020 01:37:24 +0000 (10:37 +0900)]
elm_config: comparing font overlay data on elm_config_reload()
to judge whether need to rescale or not.
for example, genlist item needs to recalc its own height
to fit change of font size
Change-Id: Ibe464c06a89734dc2da2093dcf40eb1f012db5b8
Signed-off-by: Seungwan Woo <s-w.woo@samsung.com>
Seungwan woo [Wed, 8 Apr 2020 06:31:57 +0000 (15:31 +0900)]
edje_entry: add haptic play support on cursor move
and anchor clicked sound
Change-Id: I84b928cf124a3e2ef4f308446d21bf6394b99025
Signed-off-by: Seungwan woo <s-w.woo@samsung.com>
godlytalias14573465 [Tue, 21 Apr 2020 12:33:47 +0000 (18:03 +0530)]
Genlist: Fix the view clear params
Change-Id: I599c20b7457ef19dd67a6440760b5b118b08312b
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Godly Thekkethottiyil Alias [Tue, 3 Mar 2020 10:29:19 +0000 (15:59 +0530)]
[Genlist] Avoid content deletion on reusable scenario
To avoid contents getting deleted during item update in reusable scenario,
removed content clearing from item_update, contents will be deleted on
content_realize if old content and new content passed is not same
Change-Id: I83159d7d5b4fd136d389826495342516eb3cbc7c
Signed-off-by: Godly Thekkethottiyil Alias <godly.talias@samsung.com>
SangHyeon Jade Lee [Mon, 20 Apr 2020 11:56:48 +0000 (20:56 +0900)]
genlist: set focus before item bring in or show
Change-Id: I1833258d2e7e540b7e963dfdc2d3afd9e1a9960a
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Stefan Schmidt [Wed, 29 Apr 2020 09:47:00 +0000 (11:47 +0200)]
release: Update NEWS and bump version for 1.24.0 release
Xavi Artigas [Wed, 29 Apr 2020 07:08:45 +0000 (09:08 +0200)]
doxygen docs: Add @since tags to EE selection API
This is the first time Ecore_Evas selection API is released so it has
earned some @since 1.24 tags.
Also, put these methods in their own group.
Xavi Artigas [Wed, 29 Apr 2020 06:41:02 +0000 (08:41 +0200)]
doxygen docs: Move CnP API out of the Remove Canvas group
The new CnP API had been wrongly added to the Remote Canvases group.
Daniel Kolesa [Tue, 28 Apr 2020 17:47:26 +0000 (19:47 +0200)]
eolian_gen: mark empty setter value params as unused
Daniel Kolesa [Tue, 28 Apr 2020 17:46:58 +0000 (19:46 +0200)]
eolian_gen: hack around function pointers generating unused params
Christopher Michael [Tue, 28 Apr 2020 15:54:07 +0000 (11:54 -0400)]
ecore-drm2: Change _output_crtc_find to accept an int
There is no reason to be passing the whole device structure here just
to get the fd
Christopher Michael [Tue, 28 Apr 2020 16:09:12 +0000 (12:09 -0400)]
ecore-evas: Fix formatting
NB: No functional changes
Christopher Michael [Tue, 28 Apr 2020 16:35:07 +0000 (12:35 -0400)]
ecore-evas-drm: Fix broken init count
We should not assume that there is only ever 1 drm ecore_evas here so
we need to handle init count properly
@fix
Marcel Hollerbach [Sun, 29 Sep 2019 16:04:51 +0000 (18:04 +0200)]
build: install eo files per default
in the last release we turned that off, because we started to stabelize
API back there, but the .eo file format wasnt ready yet.
Now, the file format is stable. And we stabelized more widgets, which
means, we should also install the .eo files per default.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10242
Boris Faure [Sat, 25 Apr 2020 13:03:30 +0000 (13:03 +0000)]
meson: allow debug-threads to be disabled in debug
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11756
Mike Blumenkrantz [Wed, 22 Apr 2020 17:18:25 +0000 (13:18 -0400)]
tests/elm: add more naviframe tests
some tests to explicitly verify callback and internal behavior
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11752
Mike Blumenkrantz [Wed, 22 Apr 2020 17:16:50 +0000 (13:16 -0400)]
tests/elm: add util callback for capturing event_info in smart callbacks
useful when we want to verify that e.g., a certain object item is passed
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11751
Mike Blumenkrantz [Wed, 22 Apr 2020 17:17:43 +0000 (13:17 -0400)]
tests/elm: add some more specific convenience macros for size checks
sometimes a test might only want to verify the width or height of an object
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11750
Mike Blumenkrantz [Wed, 22 Apr 2020 17:15:45 +0000 (13:15 -0400)]
tests/elm: check all objects for signal interface before calling signal funcs
just being extra paranoid here since there's some classes which implement
some layout/content interfaces without implementing signals
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11749
Mike Blumenkrantz [Wed, 22 Apr 2020 17:14:48 +0000 (13:14 -0400)]
tests/elm: add a list sizing test
basic test to ensure that list sizing is homogeneous and works as it
"should", even though list sizing internals are a black hole of lost time
and dreams
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11748
Mike Blumenkrantz [Wed, 22 Apr 2020 17:13:57 +0000 (13:13 -0400)]
elm/list: avoid erroring on non-elm item contents
putting raw evas and edje objects in here has historically been done,
so handle it without errors
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11747
Marcel Hollerbach [Sun, 26 Apr 2020 15:29:09 +0000 (17:29 +0200)]
efl_fileselector_entry: do not crash on a invalid model
something is happening during shutdown, when a fileselector was created
before. This is ending up in a strcmp to a NULL ptr, which crashes, with
the now, we ensure that we are not crashing anymore, when that is
happning.
TO solve this properly we should really fix the cause of a invalid model
beeing returned, however, i do not feel compftable doing that so short
before a release.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11762
Marcel Hollerbach [Sat, 18 Apr 2020 08:46:37 +0000 (10:46 +0200)]
efl_ui_focus_manager_calc: correctly flag elements used
when setting the relation from two widgets a<->b a is used as well as b.
This now correctly sets these flags.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11730
WooHyun Jung [Mon, 4 May 2020 01:59:33 +0000 (10:59 +0900)]
evas_font_query: fixed the wrong arrangement when white-char is on wrapping point
Current textblock does not have proper logic for processing line wrapping when -
1. white-char is on wrapping point
2. white-char is drawn with different font from the characters which are before and after it
So, this change would follow the old logic which assumes the font for white-character is
always cached by the current processing font.
After making proper changes in textblock, then this patch can be reverted.
@tizen_fix
Change-Id: I18f782402dafe64358c9094566ce41f96b8cbb84
Hermet Park [Wed, 29 Apr 2020 04:25:28 +0000 (13:25 +0900)]
canvas vg: Correct order of data free.
vfd data is firstly initialized and
must be freed in the last.
Change-Id: Ife3294933b601bfb7a293b409082a1282215a6d7
Lukasz Oleksak [Tue, 21 Apr 2020 07:28:20 +0000 (09:28 +0200)]
[atspi] Propagation of app_gesture_support attribute from content to base layout of naviframe_item
Change-Id: I65ba479fc0674dd918012a51096293f7f988a17e
Hermet Park [Tue, 28 Apr 2020 05:35:26 +0000 (14:35 +0900)]
canvas clip: replace hash to cached array.
Each child_map_across_mark() takes 0.026ms with eina_hash
we can reduce the performing time by replacing the hash to array to 0.0041ms in a device.
Before Average: 0.026ms
Mostly it takes 23 times in the scrolling. thus it takes 3%(0.48ms) in one frame rendering (16ms)
After Average: 0.0041ms
Mostly it takes 23 times in the scrolling. thus it takes 0.6%(0.096ms) in one frame rendering (16ms)
result: map calc 5x faster than original (0.384ms improved)
Thanks Subhransu for report this.
@optimization
Change-Id: Iba6d9addd0d092214dda4dd3f60e90b0aec1b8a7
Mike Blumenkrantz [Mon, 27 Apr 2020 13:46:45 +0000 (09:46 -0400)]
elm/cnp: remove const from static function return
this makes no sense
../src/lib/elementary/elm_cnp.c:54:15: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
54 | static inline const Elm_Sel_Format
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11759
Xavi Artigas [Mon, 27 Apr 2020 15:25:27 +0000 (17:25 +0200)]
doxygen docs: Fix most errors on Evas_Legacy.h
Oh boy... References to Unified API, horribly misshapen groups,
typos, invalid commands, invalid references, and on top of that,
Evas VG.
Xavi Artigas [Mon, 27 Apr 2020 13:54:10 +0000 (15:54 +0200)]
doxygen docs: Put Evas_Canvas legacy methods in the right group
"Evas_Group" does not exist, and "Evas" is a top-level group without content
(only subgroups). So I guess all these methods belong to the "Evas_Canvas" group.
This brings even more docs into existence, fixing multiple missing references.
Xavi Artigas [Mon, 27 Apr 2020 13:15:12 +0000 (15:15 +0200)]
doxygen docs: Fix invalid refs to Layout
All widgets copy&pasted the same description, including an invalid reference
to "Layout", which should be "Elm_Layout".
SOME of them had been fixed over the years but this commit fixes all of them.
This significantly reduces the number of Doxygen warnings and adds meaningful
links to the docs.
Xavi Artigas [Mon, 27 Apr 2020 11:40:27 +0000 (13:40 +0200)]
doxygen docs: Add missing Elementary group
Elementary has a main page (elementary_main) like other libs (Ecore, Evas...)
but it was missing a doxygen group like the other libs. This group is not
terribly useful but it is manually referenced from dozens of places, resulting
in lots of warnings.
I thought this solution is simpler than removing all the manual references.
Xavi Artigas [Mon, 27 Apr 2020 10:28:57 +0000 (12:28 +0200)]
doxygen docs: Match doc with correct enum for Render_Op
Docs did not match the intended enum value due to incorrect usage of the
doxygen tags.
Also, Evas_Render_Op was the only member of the top-level Evas group, so
I moved it inside one subgroup, where methods using it reside.
Xavi Artigas [Mon, 27 Apr 2020 10:05:17 +0000 (12:05 +0200)]
doxygen docs: Put APIs in correct group
"Evas_Object" does not exist as a group, so the docs for these 29 methods
did not show in the output.
Xavi Artigas [Mon, 27 Apr 2020 08:01:09 +0000 (10:01 +0200)]
doxygen docs: Document compositor sync API as deprecated
This is currently a NOP and we should remove this API later on.
Meanwhile, turn the note about this API being experimental into
a deprecation warning.
Woochanlee [Mon, 27 Apr 2020 10:46:54 +0000 (19:46 +0900)]
elm_spinner: list spinner signal clean up to following Common GUI.
Change-Id: If69ed24820c4a5d39cc8d5667f3050ebd16e5176
JunsuChoi [Mon, 27 Apr 2020 10:29:47 +0000 (19:29 +0900)]
efl_ui_image: Fix unnecessary unload of memfile_set.
Summary:
In D11392, fixed to call file_unload when doing memfile_set.
Therefore, "load,error" callback was called while unloading object
that was not loaded when first load with memfile_set.
So fix it to avoid unnecessary unloading.
Test Plan:
{
F3871804}
cp ./test_imge.c ./efl/
cd efl
gcc -o test_image test_image.c -g `pkg-config --cflags --libs elementary`
./test_image
Loading image...
Async file load failed.
Image is ready to show.
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11758
Change-Id: I5d30e5b35c08481cb2eaa7eb4a45d07e49433082
Hermet Park [Fri, 24 Apr 2020 12:26:25 +0000 (21:26 +0900)]
canvas gl: fix nutty code of partial rendering toggle.
clean up partial rendering code for maintaining
and makei it work properly while toggling.
Change-Id: I8827c2526397fb73c961a0f4449f2bacd6525418
Carsten Haitzler (Rasterman) [Sun, 26 Apr 2020 12:15:33 +0000 (13:15 +0100)]
elm - combobox - pretty borken but make it a little less
add some tests so i can see smaller comboboxes with padding and fix
the scaling which was broken.
Daniel Kolesa [Sun, 26 Apr 2020 00:29:35 +0000 (02:29 +0200)]
eolian: require opaque structs to be used by ref always
For now only in stable API.
Carsten Haitzler (Rasterman) [Sat, 25 Apr 2020 13:44:23 +0000 (14:44 +0100)]
efreet - work around conconforming apps putting startupwmclass in quotes
riot does
StartupWMClass="Riot"
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
does not allow for quoting here. you can quote fields in an exec line
- for shell and replacement purposes, but not other fields like this
above. this is a workaround a broken app so matching window to desktop
file works.
@fix
Carsten Haitzler (Rasterman) [Fri, 24 Apr 2020 23:19:08 +0000 (00:19 +0100)]
evas gl - fix coverity complaint in shader cache update
Carsten Haitzler (Rasterman) [Fri, 24 Apr 2020 15:54:11 +0000 (16:54 +0100)]
evas gl - shader cache was needless losing and overwriting
we were losing cached chaders and overwriting the cache all the time
when apps finished compiling new shaders and at other points... when
they should have already had a populated shader cache that was all
fine and happy. this fixes that so once the cache is fully populated
it wont write anymore and it wont lose existing shaders in the cache
@fix
Ali [Fri, 24 Apr 2020 11:55:12 +0000 (20:55 +0900)]
evas_gl_context: reduce conditions for image orientation check
Reviewers: woohyun, eunue, kimcinoo, Hermet
Reviewed By: Hermet
Subscribers: kimcinoo, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11755
Hermet Park [Fri, 24 Apr 2020 12:11:27 +0000 (21:11 +0900)]
canvas layer: +prevent null layer objects.
Change-Id: I7a822d314ee16e984db25aa0180b61affa0cdd8c
Hermet Park [Fri, 24 Apr 2020 12:00:39 +0000 (21:00 +0900)]
canvas layer: find the top item for only valids.
In some case, top layer doesn't have valid objects,
That case, we must find and return top object in the next layer.
Change-Id: I3c6fc8a683a1b3673a06f8e544a04809ed3a353e
Woochanlee [Fri, 24 Apr 2020 04:32:59 +0000 (13:32 +0900)]
elm_spinner: Implement Tizen_6.0 Common profile GUI.
Add internal API to enable scroll item align feature only in list spinner.
Enable scroll item align and valign in list spinner.
Spinner will sending signal to genlist for item font change.
Change-Id: I8b3d6fe38ce14e73502846df29b50dd09b707d2a
JunsuChoi [Thu, 23 Apr 2020 11:13:31 +0000 (20:13 +0900)]
evas_gl_common: Add env "EVAS_GL_TEXTURE_ATLAS_DISABLE" to control texture atlas for image upload
To disable texture atlas, calling setenv before elm_win_add
*This patch was added for a fix issue related to atlas image of product code.(tizen_4.0)
Change-Id: I422433c05244b785c96e7a9d52469cde7189cb83
Stefan Schmidt [Wed, 22 Apr 2020 15:44:04 +0000 (17:44 +0200)]
exactness: check action for NULL
If the given events list is NULL the data pointer would be as well. Make
sure we check for NULL here before accessing.
CID:
1419843
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11754
Stefan Schmidt [Fri, 17 Apr 2020 13:03:28 +0000 (15:03 +0200)]
exactness: use convinience ecore_file function to get dir
Instead of doing our own parsing here we should use ecore_file_dir_get()
which uses dirname() already to solve this.
CID:
1422196
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11727
Stefan Schmidt [Fri, 17 Apr 2020 12:34:21 +0000 (14:34 +0200)]
exactness: do not access potential NULL pointer
These to code lines should be in one block and not one exectued without
the if.
CID:
1422198
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11726
Carsten Haitzler (Rasterman) [Thu, 23 Apr 2020 10:38:20 +0000 (11:38 +0100)]
Revert "meson: do not install .eo files of not installed header files"
This reverts commit
d4946a0d072ff301026e6c56e095a87305def1a0.
install these - e builds against efl will fail if they try use
efl-canvas-wl without headers... :)
Ali [Wed, 22 Apr 2020 08:28:55 +0000 (08:28 +0000)]
EFl_Canvas_Text: add typedef for backward compatibility in legacy headers
Reviewed-by: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11744
Carsten Haitzler (Rasterman) [Wed, 22 Apr 2020 11:49:34 +0000 (12:49 +0100)]
ecore_file - address issue about false positive of finding a file in ./
it may report an exe is installed if it happens to be in cwd but cwd
isnt in path. the "full/relative" path handling case mishandled this.
fixes T8678
@fix
Maria Bialota [Wed, 22 Apr 2020 17:59:14 +0000 (19:59 +0200)]
[atspi] _accessible_reading_material_get: Added Efl.Access.Selection interface check before calling Selection method
Change-Id: I32852473f98445e7c2af177d74632ce077b45e0a
SangHyeon Jade Lee [Wed, 22 Apr 2020 07:08:44 +0000 (16:08 +0900)]
genlist : fix direction calc for adjust align get
Change-Id: I8aeb9067089c83327b583574dcc6f25073e38a61
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
(cherry picked from commit
dc3fa9f66766fbb008e327f837268b31136317b6)