Jan Kotas [Thu, 12 Nov 2015 14:33:14 +0000 (06:33 -0800)]
Merge pull request #2028 from dotnet/revert-2023-disable-x86-release
Revert "Disable x86 windows release build until it passes"
Eugene Rozenfeld [Thu, 12 Nov 2015 05:18:50 +0000 (21:18 -0800)]
Merge pull request #2027 from erozenfeld/RotationImprovements
Implement improvements for rotation matching.
Jan Kotas [Thu, 12 Nov 2015 04:34:39 +0000 (20:34 -0800)]
Revert "Disable x86 windows release build until it passes"
Jan Kotas [Thu, 12 Nov 2015 04:33:36 +0000 (20:33 -0800)]
Merge pull request #2025 from jkotas/fatal-error
Use volatile store for g_hrFatalError
Eugene Rozenfeld [Thu, 12 Nov 2015 03:15:55 +0000 (19:15 -0800)]
Implement improvements for rotation matching.
1. Recognize patterns with XOR instead of OR, e.g., (x << 5) ^ (x >> 27).
2. Recognize patterns with instance or static fields and ref params.
Only GTF_PERSISTENT_SIDE_EFFECTS (i.e., calls and assignments) and
GTF_ORDER_SIDEEFF (i.e., volatile accesses) prevent tree matching.
Before this change we used GTF_ALL_EFFECT.
Jan Kotas [Thu, 12 Nov 2015 01:48:49 +0000 (17:48 -0800)]
Use volatile store for g_hrFatalError
Senthil [Thu, 12 Nov 2015 01:41:22 +0000 (17:41 -0800)]
Merge pull request #1985 from schellap/master
Emit custom test launcher hook for custom test runners
Matt Mitchell [Wed, 11 Nov 2015 23:32:29 +0000 (15:32 -0800)]
Merge pull request #2023 from mmitche/disable-x86-release
Disable x86 windows release build until it passes
Matt Mitchell [Wed, 11 Nov 2015 23:24:44 +0000 (15:24 -0800)]
Disable x86 windows release build until it passes
To trigger in the meantime, say: 'test x86 windows release'
Jan Kotas [Wed, 11 Nov 2015 22:52:09 +0000 (14:52 -0800)]
Merge pull request #2015 from kouvel/TpaBinder
Fix a couple of issues involving assembly loading
Jan Kotas [Wed, 11 Nov 2015 22:51:55 +0000 (14:51 -0800)]
Merge pull request #2017 from dotnet-bot/from-tfs
Merge changes from TFS
Koundinya Veluri [Tue, 10 Nov 2015 18:35:30 +0000 (10:35 -0800)]
Fix a couple of issues involving assembly loading
Fixes #1740
- After an assembly is loaded through a custom load context, when its dependencies are being loaded and the dependencies are in an app folder but not on the TPA list, don't search app paths when using the TPA binder, and instead use the default binder for the dependent assembly to load dependencies through the same custom AssemblyLoadContext.
Fixes #1187
- In the AssemblyName created by AssemblyLoadContext.GetAssemblyName(), don't initialize the CodeBase property since it's not in the exposed surface area for .NET Core. If the AssemblyName is passed to Assembly.Load(), note that regardless of the path sent to GetAssemblyName(), default search orders are still used to load the assembly by name. A custom AssemblyLoadContext would need to be used to control where an assembly is loaded from.
- Fixed a couple of error messages that mentioned phone
Matt Mitchell [Wed, 11 Nov 2015 19:18:04 +0000 (11:18 -0800)]
Merge pull request #2019 from mmitche/no-pal-tests-for-x86
No pal tests for x86 windows nt
schellap [Sun, 1 Nov 2015 00:55:12 +0000 (17:55 -0700)]
Emit custom test launcher hook for custom test runners
Matt Mitchell [Wed, 11 Nov 2015 19:11:51 +0000 (11:11 -0800)]
No pal tests for x86 windows nt
Michelle McDaniel [Wed, 11 Nov 2015 16:31:37 +0000 (08:31 -0800)]
Merge pull request #2012 from adiaaida/x86failures
Add x86 build to PR test and remove xunit
Jan Kotas [Wed, 11 Nov 2015 05:11:11 +0000 (21:11 -0800)]
Merge pull request #2011 from kyulee1/fixbuild
Fix for build break
Aditya Mandaleeka [Wed, 11 Nov 2015 00:56:17 +0000 (16:56 -0800)]
Merge pull request #1928 from adityamandaleeka/jenkins_enable_unix
Exit runtest.sh with a failure code if any tests fail
Michelle McDaniel [Thu, 5 Nov 2015 01:00:55 +0000 (17:00 -0800)]
Add x86 build to PR test and remove xunit
This change adds an x86 build to the list of jobs started with each PR so
that we make sure we don't break the x86 build. Also remove xunit parsing
from x86 jobs since they do not run tests.
Kyungwoo Lee [Tue, 10 Nov 2015 23:21:59 +0000 (15:21 -0800)]
Fix for build break
When building llilc against coreclr in Linux, m_IsSlotTableFrozen is defined under _DEBUG
but it is used without guard "#ifdef _DEBUG"
This is fix for it.
Aditya Mandaleeka [Tue, 10 Nov 2015 23:17:35 +0000 (15:17 -0800)]
Temporarily disable StructABI test to unblock CI while issues are resolved
Richard L Ford [Tue, 10 Nov 2015 20:56:23 +0000 (12:56 -0800)]
Merge pull request #2006 from richardlford/gettypetypeofmatrix
Respond to review of gettypetypeofmatrix test.
Richard L Ford [Tue, 10 Nov 2015 18:08:07 +0000 (10:08 -0800)]
Respond to review of gettypetypeofmatrix test.
The automatic formatter missed putting "public" and
"static" in a canonical order, so do that manually.
Also remove a case of Hungarian notation.
Richard L Ford [Tue, 10 Nov 2015 17:56:43 +0000 (09:56 -0800)]
Merge pull request #2000 from richardlford/gettypetypeofmatrix
Add gettypetypeofmatrix test.
Matt Mitchell [Tue, 10 Nov 2015 17:17:45 +0000 (09:17 -0800)]
Merge pull request #1970 from mmitche/enbable-by-default
Enable coreclr tests by default
Matt Mitchell [Thu, 5 Nov 2015 20:00:02 +0000 (12:00 -0800)]
Enable coreclr tests by default
Jan Kotas [Tue, 10 Nov 2015 15:15:23 +0000 (07:15 -0800)]
Merge pull request #1999 from adityamandaleeka/remove_suspension
More PAL thread cleanup (last one)
dotnet-bot [Tue, 10 Nov 2015 01:10:35 +0000 (17:10 -0800)]
System.BitConverter.ToString(Byte[] value, Int32 startIndex, Int32 length) value is null message
[tfs-changeset: 1546665]
Richard L Ford [Mon, 9 Nov 2015 23:42:12 +0000 (15:42 -0800)]
Add gettypetypeofmatrix test.
Ported the JIT/Directed/gettypetypeof/gettypetypeofmatrix.cs
test from the desktop clr suite to coreclr.
Aditya Mandaleeka [Mon, 9 Nov 2015 23:32:41 +0000 (15:32 -0800)]
Remove InternalRand.
Aditya Mandaleeka [Sat, 7 Nov 2015 02:19:26 +0000 (18:19 -0800)]
Remove thread parameter from several more PAL functions.
Pat Gavlin [Mon, 9 Nov 2015 18:44:57 +0000 (10:44 -0800)]
Merge pull request #1998 from pgavlin/AddNinjaSupport
Add support for ninja to the CoreCLR build.
Jan Kotas [Mon, 9 Nov 2015 16:12:59 +0000 (08:12 -0800)]
Merge pull request #1994 from dotnet-bot/from-tfs
Merge changes from TFS
Pat Gavlin [Mon, 9 Nov 2015 04:00:30 +0000 (20:00 -0800)]
Add support for ninja to the CoreCLR build.
Just what it says on the tin.
Vance Morrison [Mon, 9 Nov 2015 03:14:50 +0000 (19:14 -0800)]
Merge pull request #1990 from stephentoub/fix_eventsource_typo
Fix a typo in EventSource_EventParametersMismatch error string
Vance Morrison [Mon, 9 Nov 2015 03:14:30 +0000 (19:14 -0800)]
Merge pull request #1988 from stephentoub/fix_eventsource_emptyarray
Fix exception when writing null/empty arrays to EventSource
Pallavi Taneja [Sun, 8 Nov 2015 23:34:22 +0000 (15:34 -0800)]
Expose Environment.GetCommandLineArgs in mscorlib
[tfs-changeset: 1546251]
Jan Kotas [Sun, 8 Nov 2015 20:38:35 +0000 (12:38 -0800)]
Merge pull request #1925 from akoeplinger/remove-env-helper
Remove Env helper class in tests
Jan Kotas [Sun, 8 Nov 2015 20:32:28 +0000 (12:32 -0800)]
Merge pull request #1926 from akoeplinger/fix-hardcoded-windows
Fix hardcoded Utilities.IsWindows property
Jan Kotas [Sun, 8 Nov 2015 20:29:16 +0000 (12:29 -0800)]
Merge pull request #1987 from bbowyersmyth/StringCodeComments
Improved and corrected some String code comments
stephentoub [Sat, 7 Nov 2015 20:45:35 +0000 (15:45 -0500)]
Fix a typo in EventSource_EventParametersMismatch error string
stephentoub [Sat, 7 Nov 2015 06:46:02 +0000 (22:46 -0800)]
Fix exception when writing null/empty array to EventSource
EventSource has two WriteEvent overloads that take a byte[]. If the
byte[] provided is null, it uses an empty array. It then tries to get the
address of the 0th element of the array, resulting in an
IndexOutOfRangeException. We could instead just use ```byte* blob =
arg1``` instead of ```byte* blob = &arg1[0]```, but doing so with an empty
array has undefined behavior in C#. Instead, we just special-case null
and empty arrays.
Bruce Bowyer-Smyth [Sat, 7 Nov 2015 04:34:21 +0000 (14:34 +1000)]
Improved and corrected some String code comments
Jan Kotas [Sat, 7 Nov 2015 03:31:09 +0000 (19:31 -0800)]
Merge pull request #1982 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Kotas [Sat, 7 Nov 2015 03:20:14 +0000 (19:20 -0800)]
Merge pull request #1984 from caslan/removeCSExports
Remove unneeded EnterCriticalSection / LeaveCriticalSection exports
Cagri [Sat, 7 Nov 2015 00:29:49 +0000 (16:29 -0800)]
Remove EnterCriticalSection / LeaveCriticalSection exports that are not needed
Jan Kotas [Fri, 6 Nov 2015 21:46:27 +0000 (13:46 -0800)]
Fix build break when NO_HOST_CPP_EH_ONLY is defined
[tfs-changeset: 1546051]
Aditya Mandaleeka [Fri, 6 Nov 2015 20:52:30 +0000 (12:52 -0800)]
Merge pull request #1959 from adityamandaleeka/remove_suspension
Remove thread parameter from a few more places in PAL
Eugene Zemtsov [Fri, 6 Nov 2015 20:02:08 +0000 (12:02 -0800)]
Merge pull request #1978 from Djuffin/debug-alloc-fix
Selective VirtualProtect in debugger heap for Realloc
Jan Vorlicek [Fri, 6 Nov 2015 19:40:58 +0000 (20:40 +0100)]
Merge pull request #1980 from pgavlin/StructABITests
Add some missing files.
Pat Gavlin [Fri, 6 Nov 2015 18:02:02 +0000 (10:02 -0800)]
Add some missing files.
The lack of these files causes the struct ABI tests to fail to build.
Nate Amundson [Fri, 6 Nov 2015 18:09:42 +0000 (12:09 -0600)]
Merge pull request #1905 from naamunds/XplatDoc
Add libcurl and libssl packages to instructions
Yi Zhang (CLR) [Fri, 6 Nov 2015 00:23:56 +0000 (16:23 -0800)]
Merge pull request #1841 from caslan/supportforBSTR
Add support for BSTRs on Unix
Pat Gavlin [Fri, 6 Nov 2015 00:23:45 +0000 (16:23 -0800)]
Merge pull request #1972 from pgavlin/StructABITests
Add some targeted by-value struct passing tests.
Eugene [Thu, 5 Nov 2015 22:42:54 +0000 (14:42 -0800)]
Selective VirtualProtect in debugger heap for Realloc
Chris [Thu, 5 Nov 2015 22:20:25 +0000 (14:20 -0800)]
Merge pull request #1963 from Djuffin/debug-alloc-fix
Restrict allocation of executable memory by DebuggerHeap
Matt Mitchell [Thu, 5 Nov 2015 21:58:18 +0000 (13:58 -0800)]
Merge pull request #1971 from AndyAyersMS/SimplfiyTest
Reduce number of threads used by the LocallocLarge test
Matt Mitchell [Thu, 5 Nov 2015 21:51:33 +0000 (13:51 -0800)]
Merge pull request #1976 from mmitche/unzip-params
Fix unzip arg order
Matt Mitchell [Thu, 5 Nov 2015 21:50:39 +0000 (13:50 -0800)]
Fix unzip arg order
Pat Gavlin [Thu, 5 Nov 2015 19:32:13 +0000 (11:32 -0800)]
Add some targeted by-value struct passing tests.
These tests target the SysV AMD64 ABI in particular, which relies on
field types to decide how to pass by-value structs.
Andy Ayers [Thu, 5 Nov 2015 20:03:00 +0000 (12:03 -0800)]
Reduce number of threads used by the LocallocLarge test
This test used to create ~3000 threads. Reduce that to ~300 while we sort out what is behind #1966.
Matt Mitchell [Thu, 5 Nov 2015 19:58:50 +0000 (11:58 -0800)]
Merge pull request #1968 from mmitche/reenable-coreclr-linux
Reenable coreclr tests by default on Linux
Matt Mitchell [Thu, 5 Nov 2015 17:47:17 +0000 (09:47 -0800)]
Update trigger phrases to be regex
Quieter zip and ignoring warnings while unzipping
Aditya Mandaleeka [Thu, 5 Nov 2015 19:28:18 +0000 (11:28 -0800)]
Fix casing of AssemblyName to match the name of the csproj.
Aditya Mandaleeka [Thu, 5 Nov 2015 19:27:33 +0000 (11:27 -0800)]
Disable a couple more tests temporarily prior to enabling CI runs.
Aditya Mandaleeka [Mon, 2 Nov 2015 23:37:07 +0000 (15:37 -0800)]
Exit with failure code if any tests fail.
Matt Mitchell [Thu, 5 Nov 2015 17:40:21 +0000 (09:40 -0800)]
Merge pull request #1967 from mmitche/use-unzip
Switch to using zip/unzip
Matt Mitchell [Thu, 5 Nov 2015 17:31:00 +0000 (09:31 -0800)]
Switch to using zip/unzip to avoid path length issues in the packer/unpacker
Mike McLaughlin [Thu, 5 Nov 2015 16:53:17 +0000 (08:53 -0800)]
Merge pull request #1961 from dotnet-bot/from-tfs
Merge changes from TFS
Stephen Toub [Thu, 5 Nov 2015 06:39:42 +0000 (22:39 -0800)]
Merge pull request #1958 from stephentoub/delete_consolehandler
Remove SetConsoleCtrlHandler from Unix PAL
Eugene [Thu, 5 Nov 2015 02:21:45 +0000 (18:21 -0800)]
Restrict allocation of executable memory by DebuggerHeap
DebuggerHeap is a common class that is used for both executable and
non-executable memory allocations by debugging infrustructure.
On Windows, OS supports concept of executable heap and CLR doesn't need
to do anything extra for each executable allocation. On Linux/OSX
this is not true. That's why this changes preserves fExecutable flag for each heap
and makes sure that we mark memory as executable only when it is necessary.
stephentoub [Wed, 4 Nov 2015 20:10:23 +0000 (12:10 -0800)]
Remove SetConsoleCtrlHandler from Unix PAL
Deleted SIGINT and SIGQUIT-related signal handling code, which means we no longer need to spin up a worker thread for all coreclr apps.
Make the debugger's SetConsoleCtrlHandler usage Windows-only (from offline conversation it sounded like we might choose to delete it entirely subsequently, but for now I've left it).
Removed all of the code related to SetConsoleCtrlHandler from the PAL.
Deleted all tests related to SetConsoleCtrlHandler from the palsuite.
Mike McLaughlin [Thu, 5 Nov 2015 00:35:26 +0000 (16:35 -0800)]
Merge pull request #1956 from dotnet-bot/from-tfs
Merge changes from TFS
Lubomir Litchev [Wed, 4 Nov 2015 23:39:26 +0000 (15:39 -0800)]
Merge pull request #1949 from LLITCHEV/SystemVStructsCleanup
Some code cleanup for the SystemVStructs work.
Mike McLaughlin [Wed, 4 Nov 2015 23:35:58 +0000 (15:35 -0800)]
Fix build break from CL#1544863 Part II
[tfs-changeset: 1545169]
Aditya Mandaleeka [Wed, 4 Nov 2015 20:47:52 +0000 (12:47 -0800)]
Remove thread parameter from shmfilelockmgr functions
Aditya Mandaleeka [Wed, 4 Nov 2015 03:21:51 +0000 (19:21 -0800)]
Remove thread parameter from some string functions in PAL.
Aditya Mandaleeka [Wed, 4 Nov 2015 03:18:32 +0000 (19:18 -0800)]
Remove thread parameter from virtual memory functions in PAL
Aditya Mandaleeka [Wed, 4 Nov 2015 02:02:56 +0000 (18:02 -0800)]
Remove thread parameter from some PAL initialization functions.
Aditya Mandaleeka [Wed, 4 Nov 2015 01:59:19 +0000 (17:59 -0800)]
Remove NativeVsnprintf and NativeVfprintf.
Mike McLaughlin [Wed, 4 Nov 2015 19:33:54 +0000 (11:33 -0800)]
Fix build break from CL# 1544863 (git PR #1946 merge commit
810b1162fff85075feb6cd5dd47b30e9f668ad38)
[tfs-changeset: 1545107]
Koundinya Veluri [Wed, 4 Nov 2015 17:36:41 +0000 (09:36 -0800)]
Merge pull request #1927 from kouvel/OacrFixes
Static analysis fixes
Mike McLaughlin [Wed, 4 Nov 2015 03:55:35 +0000 (19:55 -0800)]
Merge pull request #1946 from mikem8361/unwindi
Fix sos clrstack unwinding for the special HelperMethodFrame.
Mike McLaughlin [Fri, 16 Oct 2015 01:35:55 +0000 (18:35 -0700)]
Fix sos clrstack unwinding for the special HelperMethodFrame.
Add and implement new ICorDebugDataTarget4 unwind interface using lldb stack unwinder ABIs. The implementation
does a linear search of the native frames for the stack pointer provided. It doesn't happen often so the
performance is fine.
Stub out the DBI's ICorDebugDataTarget4 (in ShimDataTarget::VirtualUnwind) for now. Since PAL_VirtualUnwindOutOfProc
is disabled it makes sense to just return E_NOTIMPL.
Fix bpmd command so it doesn't stop in lldb when it isn't a CLRN exception (continues).
Jan Kotas [Wed, 4 Nov 2015 01:37:23 +0000 (17:37 -0800)]
Merge pull request #1939 from JohnChen0/platformID
Adjust platform IDs for Unix NIs
Jan Kotas [Wed, 4 Nov 2015 01:36:21 +0000 (17:36 -0800)]
Merge pull request #1942 from dotnet-bot/from-tfs
Merge changes from TFS
Lubomir Litchev [Fri, 23 Oct 2015 05:55:09 +0000 (22:55 -0700)]
Some code cleanup for the SystemVStructs work.
Aditya Mandaleeka [Tue, 3 Nov 2015 22:28:58 +0000 (14:28 -0800)]
Merge pull request #1940 from adityamandaleeka/remove_suspension
Clean up PAL File functions
Aditya Mandaleeka [Tue, 3 Nov 2015 20:02:01 +0000 (12:02 -0800)]
Remove some unnecessary file-related functions from PAL
Bryan P. Arant [Tue, 3 Nov 2015 21:57:59 +0000 (13:57 -0800)]
Merge pull request #1929 from bryanar/pr1-test-fix
Fixing Priority 1 Run-Only Linux tests that failed to run when built on a Linux box. The cause of the failure was that RunOnly tests were building scripts that were using absolute paths. The fix makes all pathing in the scripts relative.
John Chen [Tue, 3 Nov 2015 20:05:37 +0000 (12:05 -0800)]
Adjust platform IDs for Unix NIs
Previous change for native image platform IDs only works on x64 architecture.
Adjusted the code to work on all architectures.
Aditya Mandaleeka [Tue, 3 Nov 2015 19:56:28 +0000 (11:56 -0800)]
Remove thread parameter from file-related functions
Lubomir Litchev [Tue, 3 Nov 2015 19:02:13 +0000 (11:02 -0800)]
Merge pull request #1933 from LLITCHEV/Issue1831
Fix a bug in classification of structs with field holes.
Matt Mitchell [Tue, 3 Nov 2015 18:59:55 +0000 (10:59 -0800)]
Merge pull request #1936 from mmitche/disable-pr-test
Temporarily disable ubuntu coreclr release tests
Matt Mitchell [Tue, 3 Nov 2015 18:54:38 +0000 (10:54 -0800)]
Temporarily disable ubuntu coreclr release tests
Until file copy time issues are resolved (using unpacker) and tests fully pass
John Chen [Tue, 3 Nov 2015 18:23:19 +0000 (10:23 -0800)]
Fix assert / access violation in PEDeocder due to change from GitHub
Recent change on GitHub to modify platform ID of Unix platforms caused issues with desktop CLR.
[tfs-changeset: 1544631]
Lubomir Litchev [Mon, 2 Nov 2015 22:14:33 +0000 (14:14 -0800)]
Fix a bug in classification of structs with field holes.
There is a bug in classifying the register passing structs where field
layout leaves holes in the struct layout.
Matt Mitchell [Tue, 3 Nov 2015 16:33:12 +0000 (08:33 -0800)]
Merge pull request #1931 from mmitche/use-packer
Use the packer/unpacker for coreclr tests to reduce copy time
Matt Mitchell [Tue, 3 Nov 2015 16:25:47 +0000 (08:25 -0800)]
Use the packer/unpacker for coreclr tests to reduce copy time
Jan Vorlicek [Tue, 3 Nov 2015 10:42:23 +0000 (11:42 +0100)]
Merge pull request #1922 from janvorli/fix-multiple-exception-helpers
Fix handling of embedded scopes with multiple exception holders