platform/upstream/enlightenment.git
14 years agoadd sugusr1 to bring uo std config panel
Carsten Haitzler [Sat, 6 Feb 2010 09:47:17 +0000 (09:47 +0000)]
add sugusr1 to bring uo std config panel

SVN revision: 45929

14 years agosome infra for doing effects later
Carsten Haitzler [Sat, 6 Feb 2010 07:04:17 +0000 (07:04 +0000)]
some infra for doing effects later

SVN revision: 45926

14 years agoOops, that should have been show/hide bottom panel (according to fixme).
Christopher Michael [Sat, 6 Feb 2010 01:13:49 +0000 (01:13 +0000)]
Oops, that should have been show/hide bottom panel (according to fixme).

SVN revision: 45924

14 years agoAddress fixme for show/hide indicator window.
Christopher Michael [Sat, 6 Feb 2010 01:10:10 +0000 (01:10 +0000)]
Address fixme for show/hide indicator window.

SVN revision: 45923

14 years agodisable automagic to find exchange.
Gustavo Sverzut Barbieri [Fri, 5 Feb 2010 23:22:34 +0000 (23:22 +0000)]
disable automagic to find exchange.

This allows build systems to forcefully disable build using exchange
library, even if it was found in the system during compile.

SVN revision: 45917

14 years agomore opts.
Carsten Haitzler [Fri, 5 Feb 2010 13:12:24 +0000 (13:12 +0000)]
more opts.

SVN revision: 45899

14 years agoand set default values for new configs
Carsten Haitzler [Fri, 5 Feb 2010 12:28:46 +0000 (12:28 +0000)]
and set default values for new configs

SVN revision: 45898

14 years agomanh more compositor options... in pareparation for more. use toolbook.
Carsten Haitzler [Fri, 5 Feb 2010 12:25:23 +0000 (12:25 +0000)]
manh more compositor options... in pareparation for more. use toolbook.

SVN revision: 45897

14 years agofix toolbar bug in sizing
Carsten Haitzler [Fri, 5 Feb 2010 12:24:42 +0000 (12:24 +0000)]
fix toolbar bug in sizing

SVN revision: 45896

14 years agoand make arrows emit signals for advance items
Carsten Haitzler [Fri, 5 Feb 2010 10:22:42 +0000 (10:22 +0000)]
and make arrows emit signals for advance items

SVN revision: 45895

14 years agomake back./fwd arrow actuall advance items in toolbar
Carsten Haitzler [Fri, 5 Feb 2010 10:22:21 +0000 (10:22 +0000)]
make back./fwd arrow actuall advance items in toolbar

SVN revision: 45894

14 years agooh and make indicator instant-edit...
Carsten Haitzler [Fri, 5 Feb 2010 06:17:17 +0000 (06:17 +0000)]
oh and make indicator instant-edit...
and... better illume-home config with comp enabled...

SVN revision: 45892

14 years agosome stuff... hmmm.
Carsten Haitzler [Fri, 5 Feb 2010 06:12:02 +0000 (06:12 +0000)]
some stuff... hmmm.

SVN revision: 45890

14 years agoFixing make dist on enlightenment.
Luis Felipe Strano Moraes [Thu, 4 Feb 2010 16:42:04 +0000 (16:42 +0000)]
Fixing make dist on enlightenment.

SVN revision: 45877

14 years agoAdd default keybindings for audio buttons to work on laptops and multimedia keyboards.
toma [Thu, 4 Feb 2010 02:58:46 +0000 (02:58 +0000)]
Add default keybindings for audio buttons to work on laptops and multimedia keyboards.

SVN revision: 45860

14 years agoupdating catalan translations
Massimo Maiurana [Wed, 3 Feb 2010 20:09:54 +0000 (20:09 +0000)]
updating catalan translations

SVN revision: 45845

14 years agoRegistry config dialog into Settings Panel
Gustavo Sverzut Barbieri [Tue, 2 Feb 2010 18:29:37 +0000 (18:29 +0000)]
Registry config dialog into Settings Panel

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45816

14 years agoAdd dialog to configure connman
Gustavo Sverzut Barbieri [Tue, 2 Feb 2010 18:28:50 +0000 (18:28 +0000)]
Add dialog to configure connman

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45815

14 years agoRequest scan on all technologies upon start
Gustavo Sverzut Barbieri [Tue, 2 Feb 2010 17:41:02 +0000 (17:41 +0000)]
Request scan on all technologies upon start

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45814

14 years agoFix services list not being initialized
Gustavo Sverzut Barbieri [Tue, 2 Feb 2010 17:39:06 +0000 (17:39 +0000)]
Fix services list not being initialized

Services list must be initialized to NULL, otherwise when turning the
module back bad things may happen.

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45813

14 years agoAdd list of enabled technologies
Gustavo Sverzut Barbieri [Tue, 2 Feb 2010 17:36:51 +0000 (17:36 +0000)]
Add list of enabled technologies

Create a list with the names of enabled technologies and allow user
to determine if a certain technology is enabled.

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45812

14 years agoAdd list of available technologies
Gustavo Sverzut Barbieri [Tue, 2 Feb 2010 17:34:40 +0000 (17:34 +0000)]
Add list of available technologies

Add E_Connman_Technology struct and create a list inside
E_Connman_Module_Context which will keep track of all available
technologies.

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45811

14 years agoCreate _connman_service_new_list_item()
Gustavo Sverzut Barbieri [Tue, 2 Feb 2010 17:31:52 +0000 (17:31 +0000)]
Create _connman_service_new_list_item()

In order to be able to share item creation with config dialog.

SVN revision: 45810

14 years agocleaning - remove extra comments and debugs
Gustavo Sverzut Barbieri [Tue, 2 Feb 2010 17:29:40 +0000 (17:29 +0000)]
cleaning - remove extra comments and debugs

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45809

14 years agoeverything text plugin: only create item, when there is input
Hannes Janetzek [Tue, 2 Feb 2010 16:15:51 +0000 (16:15 +0000)]
everything text plugin: only create item, when there is input

SVN revision: 45808

14 years agoawesome new plugin for everything. 'text' creates an item for the text you type (=
Hannes Janetzek [Tue, 2 Feb 2010 16:06:42 +0000 (16:06 +0000)]
awesome new plugin for everything. 'text' creates an item for the text you type (=

SVN revision: 45807

14 years agoprovide plugindir for with pkg-config
Hannes Janetzek [Tue, 2 Feb 2010 14:03:56 +0000 (14:03 +0000)]
provide plugindir for with pkg-config

SVN revision: 45806

14 years agomore fixes! broke temp modules tempget
Carsten Haitzler [Tue, 2 Feb 2010 07:33:11 +0000 (07:33 +0000)]
more fixes! broke temp modules tempget

SVN revision: 45798

14 years agomore ecore-txt --
Carsten Haitzler [Tue, 2 Feb 2010 07:18:33 +0000 (07:18 +0000)]
more ecore-txt --

SVN revision: 45797

14 years agono mroe txt!
Carsten Haitzler [Tue, 2 Feb 2010 06:50:38 +0000 (06:50 +0000)]
no mroe txt!

SVN revision: 45795

14 years agoRemove Ecore_Txt
Sebastian Dransfeld [Tue, 2 Feb 2010 04:50:04 +0000 (04:50 +0000)]
Remove Ecore_Txt

SVN revision: 45791

14 years agoloose syncing option. in reality it will work fine. but not clean.
Carsten Haitzler [Mon, 1 Feb 2010 14:38:00 +0000 (14:38 +0000)]
loose syncing option. in reality it will work fine. but not clean.

SVN revision: 45776

14 years agoand dont set sync for your own windows! deadlock in compositing otherwise
Carsten Haitzler [Mon, 1 Feb 2010 14:16:27 +0000 (14:16 +0000)]
and dont set sync for your own windows! deadlock in compositing otherwise

SVN revision: 45774

14 years agoand now actually do the sync thing! awesomeness. this should mean (for
Carsten Haitzler [Mon, 1 Feb 2010 14:15:14 +0000 (14:15 +0000)]
and now actually do the sync thing! awesomeness. this should mean (for
borderless apps for now - using efl (ecore-evas/elm) tear-free rendeirng in
compositor.

SVN revision: 45773

14 years agofix comment
Hannes Janetzek [Mon, 1 Feb 2010 13:06:44 +0000 (13:06 +0000)]
fix comment

SVN revision: 45768

14 years agoMove setting window type until after window is shown.
Christopher Michael [Mon, 1 Feb 2010 06:55:19 +0000 (06:55 +0000)]
Move setting window type until after window is shown.

SVN revision: 45765

14 years agoSeems we cannot set the window type (for indicator) until After the window
Christopher Michael [Mon, 1 Feb 2010 06:54:34 +0000 (06:54 +0000)]
Seems we cannot set the window type (for indicator) until After the window
is shown, else E just overwrites whatever type we set.

SVN revision: 45764

14 years agoRemove unused variable.
Christopher Michael [Sun, 31 Jan 2010 19:52:03 +0000 (19:52 +0000)]
Remove unused variable.
Use PATH_MAX.

SVN revision: 45760

14 years agofind plugins for "everything" in $HOME/.e/e/everything_plugins
Hannes Janetzek [Sun, 31 Jan 2010 17:42:28 +0000 (17:42 +0000)]
find plugins for "everything" in $HOME/.e/e/everything_plugins

SVN revision: 45758

14 years agoallow the "limit compositor framerate to fixed e framerate" to be optional
Carsten Haitzler [Sun, 31 Jan 2010 13:05:56 +0000 (13:05 +0000)]
allow the "limit compositor framerate to fixed e framerate" to be optional

SVN revision: 45754

14 years agoupdating french and italian translations
Massimo Maiurana [Sun, 31 Jan 2010 09:51:05 +0000 (09:51 +0000)]
updating french and italian translations

SVN revision: 45751

14 years agoEcore_Str.h -> Eina
Sebastian Dransfeld [Sat, 30 Jan 2010 22:11:11 +0000 (22:11 +0000)]
Ecore_Str.h -> Eina

SVN revision: 45740

14 years agoDon't segfault if keyboard has no border.
Christopher Michael [Sat, 30 Jan 2010 20:16:58 +0000 (20:16 +0000)]
Don't segfault if keyboard has no border.

SVN revision: 45738

14 years agoFix keyboard dictionary list not showing on other zones.
Christopher Michael [Sat, 30 Jan 2010 06:13:54 +0000 (06:13 +0000)]
Fix keyboard dictionary list not showing on other zones.
Remove debugging (printfs).

SVN revision: 45729

14 years agoRemove unused variables.
Christopher Michael [Sat, 30 Jan 2010 02:11:48 +0000 (02:11 +0000)]
Remove unused variables.
Remove commented block (confirmed working without it).

SVN revision: 45727

14 years agoUse PATH_MAX.
Christopher Michael [Sat, 30 Jan 2010 02:01:15 +0000 (02:01 +0000)]
Use PATH_MAX.
No need to swallow the ilist twice.

SVN revision: 45726

14 years agoAdd more error trapping.
Christopher Michael [Fri, 29 Jan 2010 06:09:20 +0000 (06:09 +0000)]
Add more error trapping.

SVN revision: 45691

14 years agoAdd more error trapping.
Christopher Michael [Fri, 29 Jan 2010 06:04:11 +0000 (06:04 +0000)]
Add more error trapping.

SVN revision: 45690

14 years agomore trapping.
Christopher Michael [Fri, 29 Jan 2010 05:58:46 +0000 (05:58 +0000)]
more trapping.

SVN revision: 45688

14 years agoAdd some more error trapping.
Christopher Michael [Fri, 29 Jan 2010 05:57:40 +0000 (05:57 +0000)]
Add some more error trapping.

SVN revision: 45687

14 years agoMore error trapping.
Christopher Michael [Fri, 29 Jan 2010 05:54:47 +0000 (05:54 +0000)]
More error trapping.

SVN revision: 45686

14 years agoMore error trapping.
Christopher Michael [Fri, 29 Jan 2010 05:52:36 +0000 (05:52 +0000)]
More error trapping.

SVN revision: 45685

14 years agoE_FREE already sets variables to NULL.
Christopher Michael [Fri, 29 Jan 2010 05:44:21 +0000 (05:44 +0000)]
E_FREE already sets variables to NULL.

SVN revision: 45684

14 years agoMore possible error trapping.
Christopher Michael [Fri, 29 Jan 2010 05:42:55 +0000 (05:42 +0000)]
More possible error trapping.

SVN revision: 45683

14 years agoMore trapping.
Christopher Michael [Fri, 29 Jan 2010 05:41:20 +0000 (05:41 +0000)]
More trapping.

SVN revision: 45682

14 years agobetter trapping in dbus code (in case of unforseen problems)
Christopher Michael [Fri, 29 Jan 2010 05:31:08 +0000 (05:31 +0000)]
better trapping in dbus code (in case of unforseen problems)

SVN revision: 45680

14 years agoShutdown config subsystem if layout init fails.
Christopher Michael [Fri, 29 Jan 2010 05:07:37 +0000 (05:07 +0000)]
Shutdown config subsystem if layout init fails.
Do not allocate zones if zone count is zero.

SVN revision: 45679

14 years agoResize the dialog if it doesn't fit in the zone.
Christopher Michael [Fri, 29 Jan 2010 04:58:14 +0000 (04:58 +0000)]
Resize the dialog if it doesn't fit in the zone.

SVN revision: 45678

14 years agoDon't set icon or send messages if the focused border is not on the proper
Christopher Michael [Thu, 28 Jan 2010 18:24:30 +0000 (18:24 +0000)]
Don't set icon or send messages if the focused border is not on the proper
zone as kbd-toggle works on a per zone basis.

SVN revision: 45671

14 years agoAdd a comment.
Christopher Michael [Wed, 27 Jan 2010 20:17:25 +0000 (20:17 +0000)]
Add a comment.

SVN revision: 45645

14 years agoReset panel geometry for conformant apps when we close.
Christopher Michael [Wed, 27 Jan 2010 20:16:54 +0000 (20:16 +0000)]
Reset panel geometry for conformant apps when we close.

SVN revision: 45644

14 years agoRemove dead files.
Christopher Michael [Wed, 27 Jan 2010 20:13:54 +0000 (20:13 +0000)]
Remove dead files.

SVN revision: 45642

14 years agoRemove dead files.
Christopher Michael [Wed, 27 Jan 2010 20:11:17 +0000 (20:11 +0000)]
Remove dead files.

SVN revision: 45641

14 years agoSoftkey has no config options, remove from config profile.
Christopher Michael [Wed, 27 Jan 2010 20:09:03 +0000 (20:09 +0000)]
Softkey has no config options, remove from config profile.

SVN revision: 45639

14 years agoThese files do not belong in here.
Christopher Michael [Wed, 27 Jan 2010 20:08:14 +0000 (20:08 +0000)]
These files do not belong in here.

SVN revision: 45638

14 years agoNew indicator & softkey modules with lots of comments, an edc that gets
Christopher Michael [Wed, 27 Jan 2010 20:04:32 +0000 (20:04 +0000)]
New indicator & softkey modules with lots of comments, an edc that gets
compiled when the module is built, and cleaner code.

SVN revision: 45637

14 years agoRemove old indicator & softkey modules. New ones coming.
Christopher Michael [Wed, 27 Jan 2010 20:02:45 +0000 (20:02 +0000)]
Remove old indicator & softkey modules. New ones coming.

SVN revision: 45636

14 years agoOnly do "selected" cb when single_click_delay is 0
Sebastian Dransfeld [Wed, 27 Jan 2010 19:33:53 +0000 (19:33 +0000)]
Only do "selected" cb when single_click_delay is 0

If single_click_delay is activated, _e_fm2_mouse_1_handler will handle
"selected" cb

SVN revision: 45631

14 years agofix animator usage - now silky smooth!
Carsten Haitzler [Wed, 27 Jan 2010 15:29:51 +0000 (15:29 +0000)]
fix animator usage - now silky smooth!

SVN revision: 45629

14 years agodont unload - restarts handle that. too unsafe.
Carsten Haitzler [Wed, 27 Jan 2010 15:18:51 +0000 (15:18 +0000)]
dont unload - restarts handle that. too unsafe.

SVN revision: 45627

14 years agoReset top_shelf geometry hint when we close.
Christopher Michael [Wed, 27 Jan 2010 01:55:50 +0000 (01:55 +0000)]
Reset top_shelf geometry hint when we close.

SVN revision: 45613

14 years agoReset softkey window geometry when we close.
Christopher Michael [Wed, 27 Jan 2010 01:53:52 +0000 (01:53 +0000)]
Reset softkey window geometry when we close.

SVN revision: 45612

14 years agoFix custom layout mode for fullscreen apps.
Christopher Michael [Tue, 26 Jan 2010 22:37:55 +0000 (22:37 +0000)]
Fix custom layout mode for fullscreen apps.

SVN revision: 45606

14 years agoAdd more debugging (printfs).
Christopher Michael [Tue, 26 Jan 2010 21:15:07 +0000 (21:15 +0000)]
Add more debugging (printfs).

SVN revision: 45603

14 years agoAdd handler for when keyboard moves so we can destroy dictlist, etc.
Christopher Michael [Tue, 26 Jan 2010 20:52:30 +0000 (20:52 +0000)]
Add handler for when keyboard moves so we can destroy dictlist, etc.
Add some debug. Tracking an issue where keyboard dictlist does not show up
after it's moved to zone 1.

SVN revision: 45600

14 years agoFix up layout code wrt fullscreen apps, conformant apps, and vkbd.
Christopher Michael [Tue, 26 Jan 2010 20:13:34 +0000 (20:13 +0000)]
Fix up layout code wrt fullscreen apps, conformant apps, and vkbd.

SVN revision: 45598

14 years agoallow not installing /etc/enlightenment/sysactions.conf
Gustavo Sverzut Barbieri [Tue, 26 Jan 2010 18:21:09 +0000 (18:21 +0000)]
allow not installing /etc/enlightenment/sysactions.conf

We provide just a default, but distros should use their own version
with system specific groups and hibernate/suspend actions (pm-utils or
so)

SVN revision: 45596

14 years agoeina_module_free() already calls eina_module_unload(). There's no need
Gustavo Sverzut Barbieri [Tue, 26 Jan 2010 15:22:53 +0000 (15:22 +0000)]
eina_module_free() already calls eina_module_unload(). There's no need
to call it afterwards.

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45592

14 years agoevry_hist->subjects and evry_hist->actions has already been freed
Gustavo Sverzut Barbieri [Tue, 26 Jan 2010 15:21:57 +0000 (15:21 +0000)]
evry_hist->subjects and evry_hist->actions has already been freed
by evry_history_free(). Do not call eina_hash_foreach() again on
evry_history_unload since this will give an eina_magic_fail()
beacause they are already NULL.

By: Lucas De Marchi <lucas.demarchi@profusion.mobi>

SVN revision: 45591

14 years agomore help fixing
Vincent Torri [Tue, 26 Jan 2010 11:59:41 +0000 (11:59 +0000)]
more help fixing

SVN revision: 45585

14 years agofix configure help
Vincent Torri [Tue, 26 Jan 2010 11:54:09 +0000 (11:54 +0000)]
fix configure help

SVN revision: 45584

14 years agoCompletely fix conformant windows (wrt vkbd) in single layout mode.
Christopher Michael [Tue, 26 Jan 2010 10:50:51 +0000 (10:50 +0000)]
Completely fix conformant windows (wrt vkbd) in single layout mode.

SVN revision: 45580

14 years agoAllow conformant windows to work with vkbd in single layout mode (need to
Christopher Michael [Tue, 26 Jan 2010 10:16:29 +0000 (10:16 +0000)]
Allow conformant windows to work with vkbd in single layout mode (need to
handle dual mode still).

SVN revision: 45579

14 years agoFix elm_conformant not getting indicator size.
Christopher Michael [Tue, 26 Jan 2010 07:42:33 +0000 (07:42 +0000)]
Fix elm_conformant not getting indicator size.

SVN revision: 45572

14 years ago * ecore: Move ecore_job inside ecore.
Cedric BAIL [Mon, 25 Jan 2010 21:59:21 +0000 (21:59 +0000)]
* ecore: Move ecore_job inside ecore.

Patch from Albin "Lutin" Tonnerre <albin.tonnerre@gmail.com>.

SVN revision: 45570

14 years agoFix shelf numbering
Sebastian Dransfeld [Mon, 25 Jan 2010 19:37:13 +0000 (19:37 +0000)]
Fix shelf numbering

id must be unique. So if we have 2 zones with 1 shelf in each, hide 1
zone and add a new shelf, it must get id "hidden shelf" + 1

SVN revision: 45563

14 years agoupdate config with new fields/versions, add texture form pixmap option to gl
Carsten Haitzler [Mon, 25 Jan 2010 12:53:43 +0000 (12:53 +0000)]
update config with new fields/versions, add texture form pixmap option to gl
compositor

SVN revision: 45549

14 years agocleanup
Sebastian Dransfeld [Mon, 25 Jan 2010 09:37:30 +0000 (09:37 +0000)]
cleanup

SVN revision: 45547

14 years agocleanup
Sebastian Dransfeld [Mon, 25 Jan 2010 09:31:07 +0000 (09:31 +0000)]
cleanup

SVN revision: 45546

14 years agoconfig to turn off exec fail dialog
Carsten Haitzler [Mon, 25 Jan 2010 07:38:48 +0000 (07:38 +0000)]
config to turn off exec fail dialog

SVN revision: 45544

14 years agoMake config categories with custom icon locations actually display those icons.
Christopher Michael [Mon, 25 Jan 2010 02:51:57 +0000 (02:51 +0000)]
Make config categories with custom icon locations actually display those icons.
Make config items with custom icon locations actually display those icons.

SVN revision: 45541

14 years agoFix #483 again
Sebastian Dransfeld [Sun, 24 Jan 2010 21:20:32 +0000 (21:20 +0000)]
Fix #483 again

SVN revision: 45531

14 years agouse grabbed flag and pre-post swap callbacks.
Carsten Haitzler [Sun, 24 Jan 2010 11:05:18 +0000 (11:05 +0000)]
use grabbed flag and pre-post swap callbacks.

SVN revision: 45517

14 years agoAnd change pointer to "move" when dragging indicator window.
Christopher Michael [Sun, 24 Jan 2010 04:48:28 +0000 (04:48 +0000)]
And change pointer to "move" when dragging indicator window.

SVN revision: 45507

14 years agoAdd some signals for moving indicator so themes can do "pretty" stuff :)
Christopher Michael [Sun, 24 Jan 2010 04:24:35 +0000 (04:24 +0000)]
Add some signals for moving indicator so themes can do "pretty" stuff :)

SVN revision: 45506

14 years agoRemove e_mod_border (dead file).
Christopher Michael [Sat, 23 Jan 2010 21:31:06 +0000 (21:31 +0000)]
Remove e_mod_border (dead file).
Rework layout code for all modes:
       - Better layout code for dual modes.
       - Don't set focus if the border is already focused.
       - No need to call the 'back' method on border_delete.
       - Don't call focus_latest_set on border_focus_in.
         (not needed as it turns out).
Cleanup e_illume_border.c:
        - Free lists when done with them.
        - Check zones are valid.
        - Reduce variable usage.

SVN revision: 45503

14 years agoLock stacking of home windows & deselect an icon after it's started running.
Christopher Michael [Sat, 23 Jan 2010 21:08:57 +0000 (21:08 +0000)]
Lock stacking of home windows & deselect an icon after it's started running.

SVN revision: 45500

14 years agoOnly move resize edge windows in one func
Sebastian Dransfeld [Sat, 23 Jan 2010 20:11:55 +0000 (20:11 +0000)]
Only move resize edge windows in one func

SVN revision: 45499

14 years agoFix #483
Sebastian Dransfeld [Sat, 23 Jan 2010 20:06:02 +0000 (20:06 +0000)]
Fix #483

For corner shelves, detect movement in corner windows
Use ev->root.{x,y} as event coordinates, we do not care where the mouse
moves within the edge windows.
Convenience function for window -> edge detection.

SVN revision: 45498

14 years agoOnly flip if edge window present
Sebastian Dransfeld [Sat, 23 Jan 2010 18:33:24 +0000 (18:33 +0000)]
Only flip if edge window present

SVN revision: 45495