platform/upstream/efl.git
6 years agoexamples: edje: add forgotten edje-anchors example to build
Stefan Schmidt [Tue, 21 Aug 2018 18:27:49 +0000 (14:27 -0400)]
examples: edje: add forgotten edje-anchors example to build

Summary:
While this source was in tree it was never build. Adding it to the build
system.

Thanks Ross for spotting.
Depends on D6886

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6887

6 years agoexamples: edje: remove unreferenced file in examples
Stefan Schmidt [Tue, 21 Aug 2018 18:27:42 +0000 (14:27 -0400)]
examples: edje: remove unreferenced file in examples

Summary:
No reference to this one. Looks like a left over.
Depends on D6885

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6886

6 years agoexamples: eina: fix warnings in newly build examples
Stefan Schmidt [Tue, 21 Aug 2018 18:27:36 +0000 (14:27 -0400)]
examples: eina: fix warnings in newly build examples

Summary:
These examples ahve been in tree but not build for a long time. After
enabled them in the last commit these warnings popped up.
Depends on D6884

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6885

6 years agoexamples: eina: add missing example source files to dist
Stefan Schmidt [Tue, 21 Aug 2018 18:27:29 +0000 (14:27 -0400)]
examples: eina: add missing example source files to dist

Summary:
These have been missing from dist together with the xml resource file.
Adding them back to amke sure we ship them in our tarballs.

Thanks to Ross for spotting and reporting.
Depends on D6883

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6884

6 years agoexamples: evas: we had a couple of files missing in the tarballs
Stefan Schmidt [Tue, 21 Aug 2018 18:27:22 +0000 (14:27 -0400)]
examples: evas: we had a couple of files missing in the tarballs

Summary:
A few resource files and a README has not been taken into account during
dist. Make sure we list them correctly.

Thanks to Ross for spotting and reporting.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6883

6 years agocxx: Remove libeolian_cxx dependency on eo_cxx
Lauro Moura [Tue, 21 Aug 2018 18:21:43 +0000 (14:21 -0400)]
cxx: Remove libeolian_cxx dependency on eo_cxx

Summary: Fixes T7324

Reviewers: felipealmeida, bu5hm4n, zmike

Reviewed By: felipealmeida, bu5hm4n, zmike

Subscribers: segfaultxavi, cedric, #reviewers, #committers, zmike

Tags: #efl

Maniphest Tasks: T7324

Differential Revision: https://phab.enlightenment.org/D6881

6 years agoefl_ui_image: apply some image options as retained way.
Hermet Park [Tue, 21 Aug 2018 14:38:54 +0000 (10:38 -0400)]
efl_ui_image: apply some image options as retained way.

Summary:
load_size will be applied when file is set,
orientation, flip would be applied when starting sizing calc.

These will gurantee applying options whether image is preset or not.

This is a regression bug by ae51c81a686ca47c93eedc99beaf3a84f8a9cb96

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6855

6 years agoevas: remove render2
Mike Blumenkrantz [Tue, 21 Aug 2018 14:36:55 +0000 (10:36 -0400)]
evas: remove render2

Summary:
this is more or less a dead project, having not been actively developed
in over 2 years and instead forcing people to expend more time and energy
to keep it compiling across refactors

fix T7227

Reviewers: stefan_schmidt, Hermet, ManMower, devilhorns

Reviewed By: Hermet, devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7227

Differential Revision: https://phab.enlightenment.org/D6878

6 years agoelm/genlist: check for item invalidation after setting item focus on click
Mike Blumenkrantz [Tue, 21 Aug 2018 14:26:37 +0000 (10:26 -0400)]
elm/genlist: check for item invalidation after setting item focus on click

Summary:
if the item is deleted during a focus callback then the remainder of this function
must be skipped in order to avoid crashing when attempting to access deallocated
memory

ref T7292

Reviewers: SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7292

Differential Revision: https://phab.enlightenment.org/D6831

6 years agoelm/genlist: unset callbacks flag when destroying view object in unrealize
Mike Blumenkrantz [Tue, 21 Aug 2018 14:26:32 +0000 (10:26 -0400)]
elm/genlist: unset callbacks flag when destroying view object in unrealize

Summary:
failing to unset this prevents callbacks from being re-added when the item
is next realized, resulting in items which cannot be interacted with

ref T7292

Reviewers: SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7292

Differential Revision: https://phab.enlightenment.org/D6832

6 years agoci: explicitly clone and build an external app during distcheck
Mike Blumenkrantz [Mon, 6 Aug 2018 19:46:31 +0000 (15:46 -0400)]
ci: explicitly clone and build an external app during distcheck

Differential Revision: https://phab.enlightenment.org/D6789

6 years agoci: use distcheck script
Mike Blumenkrantz [Mon, 20 Aug 2018 21:01:32 +0000 (17:01 -0400)]
ci: use distcheck script

I forgot to enable this when I rebased the original version

Differential Revision: https://phab.enlightenment.org/D6877

6 years agoci: disable backtracing on log errors
Mike Blumenkrantz [Mon, 6 Aug 2018 19:40:54 +0000 (15:40 -0400)]
ci: disable backtracing on log errors

this is just spam that fills up the logs and sometimes causes builds to
abort when they reach the maximum log size

Differential Revision: https://phab.enlightenment.org/D6788

6 years agoui_spin_button: avoid duplicated calls.
Hermet Park [Tue, 21 Aug 2018 05:04:58 +0000 (14:04 +0900)]
ui_spin_button: avoid duplicated calls.

6 years agoefl_ui_spin_button: Addded direction feature.
Woochanlee [Tue, 21 Aug 2018 04:52:28 +0000 (13:52 +0900)]
efl_ui_spin_button: Addded direction feature.

Summary:
The Spin_Button class supports two types(horizontal, vertical).

User can use 'efl_ui_direction()' for spin_button.

@feature

Test Plan: elementary_test-> spin_button sample.

Reviewers: Hermet, Jaehyun_Cho

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6680

6 years agoefl_ui_focus_composition: remove unused variable
Yeongjong Lee [Tue, 21 Aug 2018 04:22:40 +0000 (13:22 +0900)]
efl_ui_focus_composition: remove unused variable

Summary: adapters variable has not been used since ac4d75a1a.

Reviewers: bu5hm4n, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6872

6 years agoecore_wl2_dmabuf: Depend on ecore_wl2
Derek Foreman [Mon, 20 Aug 2018 18:08:19 +0000 (14:08 -0400)]
ecore_wl2_dmabuf: Depend on ecore_wl2

Summary:
fix commit 87332f2e3ab2694f27913222ddadbadbca5c4d54 which added a
requirement to link with ecore_wl2 but no requirement that it be
built first.

ref T7327

@fix

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Maniphest Tasks: T7327

Differential Revision: https://phab.enlightenment.org/D6875

6 years agoefl_object: add call for getting invalidating
Marcel Hollerbach [Mon, 20 Aug 2018 17:15:56 +0000 (13:15 -0400)]
efl_object: add call for getting invalidating

Summary:
there is now invalidated & invalidating.

invalidated returns true when all children are invalidated, and the
object is / was requested to be invalidated.

invalidating return true when the object is called to be invalidated but
not all children are invalidated yet. However, the object is garanteed
to be invalidated in near future.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric

Tags: #efl, #do_not_merge

Differential Revision: https://phab.enlightenment.org/D6722

6 years agoecore_wl2_dmabuf: Link with ecore_wl2
Derek Foreman [Mon, 20 Aug 2018 17:06:57 +0000 (13:06 -0400)]
ecore_wl2_dmabuf: Link with ecore_wl2

Summary:
This generated .so file is only ever loaded with dlopen, so it hasn't
mattered that it doesn't appropriately link dependent libraries.

However, Debian builds this with strict linking, which breaks if the
.so doesn't depend on everything that supplies the functions it calls.

fix T7327

@fix

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Maniphest Tasks: T7327

Differential Revision: https://phab.enlightenment.org/D6874

6 years agoconfigure: do not drop to max loglevel 3
Marcel Hollerbach [Mon, 20 Aug 2018 17:02:08 +0000 (13:02 -0400)]
configure: do not drop to max loglevel 3

Summary:
For the actaul release this might be helpfull, however, we are in a
freeze, people are getting theire alpha releases, that might contain
bugs, its just makes the workflow of fixing faster if we can get and
see debugging output.

Reviewers: devilhorns, stefan_schmidt

Reviewed By: devilhorns

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6548

6 years agoeina_debug: switch to vpath
Marcel Hollerbach [Mon, 20 Aug 2018 16:59:15 +0000 (12:59 -0400)]
eina_debug: switch to vpath

Summary:
eina debug was using the xdg runtime dir in a wrong manner. Since the
directory should be only used by the user, and the directory should be
be subject of any other usage. Additionally, apps tend to create files
like: $XDG_RUNTIME_DIR/foo.bar which is probebly not what you want in
$HOME.

ref T7107

Depends on D6747

Reviewers: zmike, stefan_schmidt, #committers

Reviewed By: zmike, #committers

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7107

Differential Revision: https://phab.enlightenment.org/D6748

6 years agoefl_debugd: move to eina vpath
Marcel Hollerbach [Mon, 20 Aug 2018 16:58:50 +0000 (12:58 -0400)]
efl_debugd: move to eina vpath

Summary:
the logic here was against the xdg standard, thus we migrate to
eina_vpath which uses the correct xdg standard

Depends on D6746

Reviewers: zmike, stefan_schmidt, #committers

Reviewed By: zmike, #committers

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6747

6 years agoecore_con: migrate to eina_vpath
Marcel Hollerbach [Mon, 20 Aug 2018 16:58:35 +0000 (12:58 -0400)]
ecore_con: migrate to eina_vpath

Summary:
the logic here was against the xdg standard, thus we migrate to
eina_vpath which uses the correct xdg standard

Depends on D6745

Reviewers: zmike, stefan_schmidt, #committers

Reviewed By: zmike, #committers

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6746

6 years agoquicklaunch: use xdg abstraction instead of direct env var
Marcel Hollerbach [Mon, 20 Aug 2018 16:58:23 +0000 (12:58 -0400)]
quicklaunch: use xdg abstraction instead of direct env var

Summary:
there are defined ways what should happen in XDG_RUNTIME_DIR is not
defined, eina_vpath is the abstraction for doing this.

This ensures that the socket is created in the correct directory.

Depends on D6744

Reviewers: zmike, stefan_schmidt

Reviewed By: zmike

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6745

6 years agomove efreet xdg envvars to eina
Marcel Hollerbach [Mon, 20 Aug 2018 16:57:57 +0000 (12:57 -0400)]
move efreet xdg envvars to eina

Summary:
The contents of the XDG_ env vars are also usefull for eina subsystems,
thus we should init those env vars here.

Depends on D6751

Reviewers: zmike, stefan_schmidt, #committers

Reviewed By: zmike, #committers

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6744

6 years agoeina_vpath: introduce eina_vpath in style of snprintf
Marcel Hollerbach [Mon, 20 Aug 2018 16:56:51 +0000 (12:56 -0400)]
eina_vpath: introduce eina_vpath in style of snprintf

Summary:
this can be usefull for later regactor usages.

Depends on D6742

Reviewers: zmike, stefan_schmidt, #committers

Reviewed By: zmike, #committers

Subscribers: #reviewers, segfaultxavi, cedric, #committers, zmike

Tags: PHID-PROJ-55rnlag4d454jfmlmuhu

Differential Revision: https://phab.enlightenment.org/D6743

6 years agoeina_vpath: fix homedirectory fetching
Marcel Hollerbach [Mon, 20 Aug 2018 16:56:30 +0000 (12:56 -0400)]
eina_vpath: fix homedirectory fetching

Summary:
the fetching of the homedirectorty did not work. pw_dir was never
prepended. Additionally you would get a silent NULL string back
if the system does not support HAVE_GETPWENT.

ref T7107

Depends on D6737

Reviewers: zmike

Reviewed By: zmike

Subscribers: #reviewers, raster, vtorri, cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7107

Differential Revision: https://phab.enlightenment.org/D6742

6 years agoRevert "elm/win: move trigger for "shot" to first pre-render callback"
Stefan Schmidt [Mon, 20 Aug 2018 15:00:09 +0000 (11:00 -0400)]
Revert "elm/win: move trigger for "shot" to first pre-render callback"

Summary:
This reverts commit 93228108efaf6097ac680664bdb9158b5cf57499.

The original commit resulted in a hang during the use of the shot engine
in our make doc target. During the doc run we generate screenshots for
the documentation using the shot engine.

It is not a clean revert as other things changed since this got in, but
I verified that the screenshots for the documentation is generated
correctly again. This might leave open the original issue T6929 which
the now reverted commit tried to address.

Fixes T7166

Reviewers: zmike, JackDanielZ, xavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7166

Differential Revision: https://phab.enlightenment.org/D6873

6 years agoefl_ui_composition: remove all children in invalidate
Marcel Hollerbach [Mon, 6 Aug 2018 13:02:19 +0000 (15:02 +0200)]
efl_ui_composition: remove all children in invalidate

When the element that iherits from composition is invalidated, all items
should be unregistered.

fix T7213

Differential Revision: https://phab.enlightenment.org/D6755

6 years agoelm/win: check object class before using it
Shinwoo Kim [Mon, 20 Aug 2018 07:19:02 +0000 (16:19 +0900)]
elm/win: check object class before using it

Summary:
elm_win_focus_get with non Efl.Ui.Win object could return incorrect value.
If an object implements Efl.Ui.Focus.Object.focus { get; } then the return
value of elm_win_focus_get with this object depends upon the object status.

Reviewers: Hermet, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6868

6 years agoevas map: +comment for maintanance.
Hermet Park [Mon, 20 Aug 2018 05:39:37 +0000 (14:39 +0900)]
evas map: +comment for maintanance.

6 years agoscroller: remove unused ifdef blocks
Wonki Kim [Mon, 20 Aug 2018 04:56:46 +0000 (13:56 +0900)]
scroller: remove unused ifdef blocks

Summary:
there are unused ifdef blocks and also there is a variable that accessed from nowhere.
this patch removes both of theme.

related with D6567

Reviewers: Hermet, eagleeye, devilhorns

Reviewed By: Hermet

Subscribers: cedric, zmike

Tags: #efl, #do_not_merge

Differential Revision: https://phab.enlightenment.org/D6585

6 years agoconfigure: switch to dev mode again
Stefan Schmidt [Fri, 17 Aug 2018 23:11:23 +0000 (01:11 +0200)]
configure: switch to dev mode again

6 years agorelease: Update NEWS and bump version for 1.21.0 release
Stefan Schmidt [Fri, 17 Aug 2018 21:49:35 +0000 (23:49 +0200)]
release: Update NEWS and bump version for 1.21.0 release

6 years agoeio/sentry: destroy event handlers when deleting sentry
Mike Blumenkrantz [Wed, 15 Aug 2018 17:03:13 +0000 (13:03 -0400)]
eio/sentry: destroy event handlers when deleting sentry

this will crash due to invalid memory access if an event is triggered after
the sentry is destroyed

Differential Revision: https://phab.enlightenment.org/D6845

6 years agoci: use manual script for distcheck build
Mike Blumenkrantz [Thu, 2 Aug 2018 16:48:46 +0000 (12:48 -0400)]
ci: use manual script for distcheck build

this adds a script which reimplements the distcheck rule generated from
automake and runs that script instad of 'make distcheck'

the benefit of this is that the distcheck script can run tests multiple times
to avoid intermittent failures which could potentially cause build errors.
distcheck builds are by far the longest and most costly of all ci builds, so
it's important to reduce failure rates in these builds to the absolute minimum
in order to keep ci build times low

cibuildme

fix T7094

Differential Revision: https://phab.enlightenment.org/D6734

6 years agobuild: remove incorrect use of DEPENDENCIES for non-library file
Mike Blumenkrantz [Wed, 15 Aug 2018 12:38:19 +0000 (08:38 -0400)]
build: remove incorrect use of DEPENDENCIES for non-library file

if this is ever evaluated then it will trigger a build failure since it
is not a rule in this makefile which can ever be run

fix T6828

Differential Revision: https://phab.enlightenment.org/D6838

6 years agoci: always use same version numbering for every build
Mike Blumenkrantz [Wed, 15 Aug 2018 20:16:14 +0000 (16:16 -0400)]
ci: always use same version numbering for every build

if the version number ever changes then this destroys the entire ccache
as the version is used in various places in headers which are included
throughout the tree

Differential Revision: https://phab.enlightenment.org/D6848

6 years agoelm/list: correctly handle ELM_LIST_COMPRESS
Mike Blumenkrantz [Fri, 17 Aug 2018 15:11:08 +0000 (11:11 -0400)]
elm/list: correctly handle ELM_LIST_COMPRESS

according to the docs, this mode means that no content size hints should
be taken into account when calculating size hints for the overall object

fix T7313

Differential Revision: https://phab.enlightenment.org/D6860

6 years agoelm_code: fix crash on backspace and selection delete.
Alastair Poole [Fri, 17 Aug 2018 11:37:59 +0000 (11:37 +0000)]
elm_code: fix crash on backspace and selection delete.

FIx backspace issue and also issue involving the cursor
position and deleting/cutting/backspace of selected text.
Now that we properly move the cursor around when making a
selection, it's important that we place the cursor in a
valid position in the widget following the removal of text.

Previously the cursor always remained in a "safe" position
however now it's crucial to update this position when
necessary.

@fix T7259
Differential Revision: https://phab.enlightenment.org/D6835

6 years agoevas vg: prevent invalid access.
Hermet Park [Fri, 17 Aug 2018 19:12:19 +0000 (15:12 -0400)]
evas vg: prevent invalid access.

Summary:
Canvas allows objects become zombies.
Even though they were deleted they could be accessed by canvas
for second frames.

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6849

6 years agoefl_ui/format: revert some patches to fix some regressions
Mike Blumenkrantz [Fri, 17 Aug 2018 17:10:50 +0000 (18:10 +0100)]
efl_ui/format: revert some patches to fix some regressions

Summary:
it seems that the original patch in this case introduced a regression
where format strings ending with %% in progressbar would not be
displayed correctly. a followup patch attempted to resolve this, but
this second patch introduced another regression where some format strings
would always display 0%

fixing compiler warnings is always valued, but in the case where the
patch to fix the warning creates regressions then we will live with the
warnings instead

This reverts commit b4112b9735ce75bce95974a257aa1880fa52a6bf.
This reverts commit be770d37fb05b8486907796dd16f4635bceb4ce1.

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D6863

6 years agoefl_wl: Send unique keymap fds to clients
Derek Foreman [Fri, 17 Aug 2018 16:46:39 +0000 (12:46 -0400)]
efl_wl: Send unique keymap fds to clients

Summary:
Prevent wayland clients from being able to destroy the compositor's
singleton keymap by making individual copies for each client.

Reviewers: zmike, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6862

6 years agoecore_pipe: remove null check condition and fix segfualt on Windows
Yeongjong Lee [Fri, 17 Aug 2018 16:42:35 +0000 (12:42 -0400)]
ecore_pipe: remove null check condition and fix segfualt on Windows

Summary:
This reverts commit 4917910b4911905236fa099bbc16b833b056ca07.

4917910b break backward compatibility.

Reproduction:
   void pipe_handler(...);

   pipe = ecore_pipe_add(pipe_handler, NULL);
   ecore_pipe_write(pipe, NULL, 0);

Because of the null check condition, pipe_handler isn't called after 4917910b.
Some apps behavior which is written to expected to call pipe_handler was broken.

also, this patch fixed segfault during build on Windows

Test Plan: make on Windows

Reviewers: raster, zmike, vtorri

Reviewed By: zmike, vtorri

Subscribers: woohyun, cedric, #reviewers, #committers, zmike, vtorri

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6824

6 years agoeina_file: check copied using copied
Shinwoo Kim [Fri, 17 Aug 2018 16:42:18 +0000 (12:42 -0400)]
eina_file: check copied using copied

Summary:
From (1) "the following commit" message, the changed condition in this patch
should check if the virtualized file is copied or not.

In eina_file_virtualize
head_padded = 16 * ((sizeof(Eina_File) + slen + 15) / 16);
file->global_map = ((char *)file) + head_padded;

In eina_file_dup
file->global_map != (void*)(file->filename + strlen(file->filename) + 1)

Because of this discord condition makes eina_file_dup copies always.

(1) This is "the following commit":
commit 4766316935589b6191e047ad697ab10ae2027a43
Author: Cedric Bail <cedric@osg.samsung.com>
Date:   Wed Mar 8 10:13:36 2017 -0800

    eina: force copy of not copied virtualized file while doing an eina_file_dup.

    The other way around is pretty much impossible as you don't know who does
    an eina_file_dup and for how long they keep there reference.

    T5234

Reviewers: zmike, Hermet

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6857

6 years agoRevert this patch. It was not supposed to land yet as it was awaiting
Chris Michael [Fri, 17 Aug 2018 15:34:30 +0000 (11:34 -0400)]
Revert this patch. It was not supposed to land yet as it was awaiting
review

Revert "elementary: Check for valid focus manager before starting do loop"

This reverts commit 364ca1d2b2bb057da4d4d02dbeb2cbc2045b0ee3.

6 years agoelm/box_layout: rename variables
Mike Blumenkrantz [Fri, 17 Aug 2018 15:30:36 +0000 (11:30 -0400)]
elm/box_layout: rename variables

Summary:
the mnw and mnh variables were misleading in this context because they actually
refer to the max width and max height

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D6859

6 years agoelementary: Check for valid focus manager before starting do loop
Chris Michael [Mon, 13 Aug 2018 11:27:55 +0000 (07:27 -0400)]
elementary: Check for valid focus manager before starting do loop

Summary:
Apparently there are cases where efl_ui_focus_object_focus_manager_get
can return NULL. In order to trap for this, we can simply modify the
do loop slightly and check for a valid manager before we actually
start looping

Test Case: elementary_test -to "Panel Scrollable" and click Toggle
button

ref T7030

Depends on D6703

Reviewers: bu5hm4n, YOhoho

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl_widgets_focus

Maniphest Tasks: T7030

Differential Revision: https://phab.enlightenment.org/D6704

6 years agoelementary image: updated doc.
Hermet Park [Fri, 17 Aug 2018 02:27:56 +0000 (11:27 +0900)]
elementary image: updated doc.

6 years agoelm/code: use evas as parent for evas object creation
Mike Blumenkrantz [Thu, 16 Aug 2018 19:00:41 +0000 (20:00 +0100)]
elm/code: use evas as parent for evas object creation

Summary:
evas object types require an evas as the parent. this has always been
the case, though it has only begun to (again) be treated as an error
recently

fixes unit test failures

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets_code

Differential Revision: https://phab.enlightenment.org/D6852

6 years agotests/edje: fix object parenting for swallow tests
Mike Blumenkrantz [Thu, 16 Aug 2018 18:47:32 +0000 (19:47 +0100)]
tests/edje: fix object parenting for swallow tests

Summary:
recent safety check patches exposed issues here where tests were
incorrectly written to pass evas objects as edje object parents,
resulting in new test failures after this began to be detected and
treated as an error

Reviewers: netstar

Reviewed By: netstar

Subscribers: netstar, cedric, #reviewers, #committers

Tags: #efl_tests

Differential Revision: https://phab.enlightenment.org/D6851

6 years agoRemove EOLIAN_TESTS_EOS_GENERATED
Derek Foreman [Thu, 16 Aug 2018 17:39:34 +0000 (12:39 -0500)]
Remove EOLIAN_TESTS_EOS_GENERATED

Summary:
commit 74b56eedd1e0f7c51500bf880b59257ecea0bd0e added these to clean,
but the variable contains some non-generated files.

Turns out these files don't have to be part of the build at all, as
the tests that use them generate them in temp dirs.

Just remove the variable entirely.

Reviewers: bu5hm4n, zmike, q66

Reviewed By: bu5hm4n, zmike, q66

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6850

6 years agoecore_evas: Fix elm warnings when building without wayland support
Derek Foreman [Thu, 16 Aug 2018 14:17:23 +0000 (10:17 -0400)]
ecore_evas: Fix elm warnings when building without wayland support

Summary:
efl_ui_win.c only includes private ecore_evas headers when building
for wayland, but wayland canvas creation functions are called even
in non-wayland builds.

Move the "hidden" wayland APIs to the public header so they don't
mess up non-wayland builds.

Reviewers: devilhorns, zmike

Reviewed By: devilhorns, zmike

Subscribers: devilhorns, cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6822

6 years agotests/eio: disable efreet cache for eio tests
Mike Blumenkrantz [Thu, 16 Aug 2018 14:16:43 +0000 (10:16 -0400)]
tests/eio: disable efreet cache for eio tests

Summary:
having this enabled slows down test execution by a significant amount
for some reason

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl_tests

Differential Revision: https://phab.enlightenment.org/D6836

6 years agoedje/multisense: always return muted=true if multisense is disabled
Mike Blumenkrantz [Thu, 16 Aug 2018 14:16:34 +0000 (10:16 -0400)]
edje/multisense: always return muted=true if multisense is disabled

Summary:
there is no sound when multisense is disabled, so this is functionally
equivalent to the audio being muted

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl_layout_engine

Differential Revision: https://phab.enlightenment.org/D6837

6 years agoelm/config: return false when setting audio config if multisense is disabled
Mike Blumenkrantz [Thu, 16 Aug 2018 14:16:23 +0000 (10:16 -0400)]
elm/config: return false when setting audio config if multisense is disabled

Summary:
these operations cannot be completed if the support is not built in, so
return false in order to provide the correct state to the caller

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6839

6 years agoelm_code_line: fix potential crash.
Alastair Poole [Thu, 16 Aug 2018 14:12:35 +0000 (10:12 -0400)]
elm_code_line: fix potential crash.

Summary:
This can occur and thus malloc will return NULL when line->length is
0. Check for !line->length and return. Very difficult to reproduce, but
I had managed three times, and avoided a crash.

Reviewers: #committers, ajwillia.ms, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #reviewers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6842

6 years agoefl_ui_image: avoid a call to NULL
Yeongjong Lee [Thu, 16 Aug 2018 14:01:47 +0000 (10:01 -0400)]
efl_ui_image: avoid a call to NULL

Summary:
Image object isn't created on constructor anymore. so that it need to check
whether image object exist.

Reviewers: Hermet, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6834

6 years agoelm_image: create image object before call elm_image_object_get
Yeongjong Lee [Thu, 16 Aug 2018 14:01:37 +0000 (10:01 -0400)]
elm_image: create image object before call elm_image_object_get

Summary:
image object was created in group_add before 868e3308. if you call
elm_image_object_get before file_set, you can get NULL.
this patch avoid that.

Test Plan:
obj = elm_image_add(...);
img = elm_image_object_get(obj);

img should not be NULL.

Reviewers: Hermet, zmike

Reviewed By: zmike

Subscribers: JackDanielZ, cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6828

6 years agoci: disable notifications for canceled builds
Mike Blumenkrantz [Wed, 1 Aug 2018 17:37:50 +0000 (13:37 -0400)]
ci: disable notifications for canceled builds

canceled builds indicate that someone is actively watching a build,
likely in order to test changes. there's no point in spamming irc for
these events

Differential Revision: https://phab.enlightenment.org/D6730

6 years agoci: disable unnecessary build targets
Mike Blumenkrantz [Sun, 22 Jul 2018 05:22:06 +0000 (01:22 -0400)]
ci: disable unnecessary build targets

examples and install are both built by distcheck build, no need to also
build them in every other build

there's also no need to try building an app against the compiled libraries
since ci runs unit tests, requiring binaries to run after linking to the
libraries

Differential Revision: https://phab.enlightenment.org/D6663

6 years agoelm_image: add EINA_UNUSED to avoid build warning
Yeongjong Lee [Wed, 15 Aug 2018 16:48:44 +0000 (16:48 +0000)]
elm_image: add EINA_UNUSED to avoid build warning

Differential Revision: https://phab.enlightenment.org/D6844

6 years agotests/image: remove unused variable
Yeongjong Lee [Wed, 15 Aug 2018 16:44:22 +0000 (16:44 +0000)]
tests/image: remove unused variable

Differential Revision: https://phab.enlightenment.org/D6843

6 years agotests: add more info on failsafe timeout
Mike Blumenkrantz [Mon, 6 Aug 2018 21:42:40 +0000 (17:42 -0400)]
tests: add more info on failsafe timeout

if a test is continually deadlocking then it's useful to know which
test is failing to complete

Differential Revision: https://phab.enlightenment.org/D6785

6 years agotests: add failsafe timeout for tests running in fork mode
Mike Blumenkrantz [Mon, 30 Jul 2018 16:50:58 +0000 (12:50 -0400)]
tests: add failsafe timeout for tests running in fork mode

some tests manage to deadlock themselves on travis, seemingly due to some
hard to reproduce issues which are a result of the extremely low amount of
resources available on travis builds

this adds a simple 'timeout' process which does nothing but sleep(60);
and then returns. the exiting of this process will cause the main test
process to break out of the deadlock and then exit instead of timing out
a ci build

Differential Revision: https://phab.enlightenment.org/D6697

6 years agoevas textblock: add/apply cursor cluster APIs based on grapheme cluster 21/187421/1
Youngbok Shin [Mon, 20 Aug 2018 11:21:53 +0000 (07:21 -0400)]
evas textblock: add/apply cursor cluster APIs based on grapheme cluster

Summary:
Add a feature for moving cursor over a grapheme cluster.
It is applied to edje_entry.c and elm_entry.c for improving
cursor handling just like other modern text editors. ex) gedit
The patch on Evas needs to update libunibreak library.
So, the patch will update libunibreak, too.
@feature

Test Plan:
1. Put "ഹലോ" in your entry.
2. Your cursor can reach at the end of text from the beginning
   only in 2 right key event with this feature.

Reviewers: raster, cedric, jpeg, herdsman, zmike, devilhorns

Reviewed By: herdsman, zmike

Subscribers: #reviewers, #committers, zmike, bowonryu, woohyun

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D5490

Change-Id: I6f5a817bd946ae029bf7a081343174847d8c09fb

6 years agoefl_ui_tab_bar: implement select key bindings. 44/187244/1
Bowon Ryu [Tue, 21 Aug 2018 06:31:49 +0000 (15:31 +0900)]
efl_ui_tab_bar: implement select key bindings.

Summary:
by key bindings..
now we can select TAB with the Return/Space key.

Test Plan: elementary_test -to efl.ui.tab_pager

Reviewers: Jaehyun_Cho, Hermet

Reviewed By: Jaehyun_Cho

Subscribers: YOhoho, cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6779

Change-Id: I2f967ebf3307b8a935ce1ce3c2112d1d659953ba

6 years agoecore wayland: fix a regression bug of wayland_transparent_get().
Hermet Park [Fri, 17 Aug 2018 15:30:20 +0000 (11:30 -0400)]
ecore wayland: fix a regression bug of wayland_transparent_get().

Summary:
wayland transparent func was replaced with alpha's.

By this, transparent common attribute is no more valid,
ecore_evas_transparent_get() doesn't work.

This is a regression bug by 5af84afced98956198b9c316facb671e46b381c1

Reviewers: ManMower, devilhorns

Reviewed By: ManMower, devilhorns

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6856

Change-Id: Iba22504fa584f4e5b537f2c3b0e6423e72012648

6 years agoevas: check evas class instead of using evas_find
Yeongjong Lee [Thu, 16 Aug 2018 17:01:26 +0000 (13:01 -0400)]
evas: check evas class instead of using evas_find

Summary:
A object that is not evas class shouldn't use evas_find. it may occurs segfault.

ref c2e8b492b18bdecc2300ad051ba1406e40ad068f

Test Plan:
Evas *evas = evas_new();
evas_free(evas);
evas_object_line_add(evas);

Check weather there is segfault.

Reviewers: Hermet, raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6816

6 years agoelm_entry: Disable primary selection type, it is not supported yet 82/186982/2
Taehyub Kim [Fri, 17 Aug 2018 04:39:03 +0000 (13:39 +0900)]
elm_entry: Disable primary selection type, it is not supported yet

Change-Id: I0b97f7983a6af81a9eb04c8917fc4e71b7606b56

6 years agoeina: Add doxygen in/out tags for safepointer, safety_checks, slice, etc.
Bryce Harrington [Wed, 15 Aug 2018 08:54:17 +0000 (09:54 +0100)]
eina: Add doxygen in/out tags for safepointer, safety_checks, slice, etc.

Reviewers: netstar

Reviewed By: netstar

Subscribers: netstar, cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6833

6 years agoelm/list: use while() loop to iterate item list during smart delete
Mike Blumenkrantz [Wed, 15 Aug 2018 08:45:06 +0000 (09:45 +0100)]
elm/list: use while() loop to iterate item list during smart delete

Summary:
using EINA_LIST_FREE here double deletes 2 list items on every iteration
due to recursive list removals, which prevents some items from being
deleted as expected

fix T7266

Reviewers: netstar

Reviewed By: netstar

Subscribers: netstar, cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T7266

Differential Revision: https://phab.enlightenment.org/D6829

6 years agotests/elm: remove elm_test_helper.(c|h) files
Mike Blumenkrantz [Mon, 6 Aug 2018 18:26:08 +0000 (14:26 -0400)]
tests/elm: remove elm_test_helper.(c|h) files

these timer functions are only used by fileselector and I'm trying to consolidate
timer usage

no functional changes

Differential Revision: https://phab.enlightenment.org/D6768

6 years agotests/naviframe: add test to verify preserve_on_pop functionality
Mike Blumenkrantz [Mon, 6 Aug 2018 18:03:48 +0000 (14:03 -0400)]
tests/naviframe: add test to verify preserve_on_pop functionality

this adds a naviframe with button content and pushes/pops the stack
a couple times to see if a delete callback is called on the button

ref T7236

Differential Revision: https://phab.enlightenment.org/D6762

6 years agotests/eina: suppress deprecated api warnings for eina abi test
Mike Blumenkrantz [Tue, 14 Aug 2018 21:26:08 +0000 (17:26 -0400)]
tests/eina: suppress deprecated api warnings for eina abi test

Reviewers: devilhorns, ManMower

Reviewed By: ManMower

Subscribers: cedric, #reviewers, #committers

Tags: #efl_build

Differential Revision: https://phab.enlightenment.org/D6810

6 years agoevas: support wayland static engine loading
Marcel Hollerbach [Tue, 14 Aug 2018 21:12:07 +0000 (17:12 -0400)]
evas: support wayland static engine loading

Summary: This fixes static loading of the here changes engines.

Reviewers: ManMower, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6795

6 years agoelm/win: skip frame updating if csd is not active
Mike Blumenkrantz [Tue, 14 Aug 2018 21:11:53 +0000 (17:11 -0400)]
elm/win: skip frame updating if csd is not active

Summary:
this avoids extra recalcs and resizes when csd is not active, which has
the side benefit of not breaking the x11 engine's behavior--currently only
an issue because the ecore-evas x11 backend does not have an implementation
of ConfigureNotify event handling which is even remotely correct

these issues will be resolved in future patches

fix T7243
ref T7008

Reviewers: devilhorns, ManMower

Reviewed By: devilhorns, ManMower

Subscribers: ManMower, cedric, #reviewers, #committers

Tags: #efl_display_system

Maniphest Tasks: T7243, T7008

Differential Revision: https://phab.enlightenment.org/D6794

6 years agoecore-evas/x: rework draw_block unsetting from ConfigureNotify
Mike Blumenkrantz [Tue, 14 Aug 2018 21:11:31 +0000 (17:11 -0400)]
ecore-evas/x: rework draw_block unsetting from ConfigureNotify

Summary:
draw_block should only be unset if the event is triggered by the wm
or the window is an override, otherwise it prematurely begins rendering
the window at a size which may or may not be accurate

ref T7008

Reviewers: devilhorns, ManMower

Reviewed By: ManMower

Subscribers: ManMower, cedric, #reviewers, #committers

Tags: #efl_display_system

Maniphest Tasks: T7008

Differential Revision: https://phab.enlightenment.org/D6793

6 years agoecore/main: only update loop_time during loop iteration if the change is monotonic
Mike Blumenkrantz [Tue, 14 Aug 2018 21:09:32 +0000 (17:09 -0400)]
ecore/main: only update loop_time during loop iteration if the change is monotonic

Summary:
in the case where the user has called loop_time_set with a value in the future,
avoid setting the loop time to something that would potentially cause a callback
to occur with a loop_time value before a previous occurrence of that callback

@fix

Reviewers: ManMower

Reviewed By: ManMower

Subscribers: ManMower, #reviewers, cedric, #committers

Tags: #efl_main_loop

Differential Revision: https://phab.enlightenment.org/D6764

6 years agoeina_vpath: specilice the eina_vpath headers
Marcel Hollerbach [Tue, 14 Aug 2018 21:09:22 +0000 (17:09 -0400)]
eina_vpath: specilice the eina_vpath headers

Summary: For now its beta, and the since tag is added.

Reviewers: zmike

Reviewed By: zmike

Subscribers: #reviewers, kimcinoo, Hermet, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6751

6 years agobuild: fix evas static build of gl engines
Mike Blumenkrantz [Tue, 14 Aug 2018 21:09:11 +0000 (17:09 -0400)]
build: fix evas static build of gl engines

Summary:
when gl_common is built statically, the include directories for it need
to be added to the main evas library build

@fix

Reviewers: devilhorns, vtorri, ManMower

Reviewed By: ManMower

Subscribers: ManMower, #reviewers, cedric, #committers

Tags: #efl_build

Differential Revision: https://phab.enlightenment.org/D6681

6 years agoelm_panel: return instead of EINA_SAFETY_ON_FALSE_RETURN
Alastair Poole [Tue, 14 Aug 2018 19:48:27 +0000 (15:48 -0400)]
elm_panel: return instead of EINA_SAFETY_ON_FALSE_RETURN

Summary:
As with other checks in ELM return if object is not yet
finalized. This stops lots of console noise.

@fix T7265

Test Plan:
elementary_test: use panel test from console and view the noise
from EINA. Apply then do the same.

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #reviewers, zmike

Tags: #efl

Maniphest Tasks: T7265

Differential Revision: https://phab.enlightenment.org/D6826

6 years agoelementary: Check for valid cursor_rect when (un)setting focus
Chris Michael [Tue, 14 Aug 2018 14:45:30 +0000 (15:45 +0100)]
elementary: Check for valid cursor_rect when (un)setting focus

Summary:
As the cursor_rect for elm_code_widget is not created until the code
widget gets focus, we cannot just assume it is already there when
trying to emit a focus signal. The cursor_rect does not get created
until widget_cursor_update is called.

This fixes an issue where NULL is passed to efl_layout_signal_emit.

To test this, just launch elementary_test and click the Code Editor
test. As soon as you try to click into the Code Editor, this gets
triggered.

ref T7030

Reviewers: netstar, ajwillia.ms

Reviewed By: netstar

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7030

Differential Revision: https://phab.enlightenment.org/D6701

6 years agoedje: unset internal _need_imf flag on shutdown
Mike Blumenkrantz [Tue, 14 Aug 2018 14:45:13 +0000 (10:45 -0400)]
edje: unset internal _need_imf flag on shutdown

Summary:
failing to unset this causes the ecore_imf flag to go negative if edje
is ever completely shut down twice

@fix

Reviewers: ManMower

Reviewed By: ManMower

Subscribers: ManMower, #reviewers, cedric, #committers

Tags: #efl_layout_engine, #easy

Differential Revision: https://phab.enlightenment.org/D6763

6 years agotheme: add programs for deferred naviframe push/pop signals
Jaehyun Cho [Tue, 14 Aug 2018 14:19:16 +0000 (10:19 -0400)]
theme: add programs for deferred naviframe push/pop signals

Summary:
Naviframe provides deferred push/pop signals to begin transition effect and
not to emit signals frequently for transition callbacks.

To handle the deferred naviframe push/pop signals, programs which catch the
signals are added.

@fix

Test Plan: Test naviframe in elementary_test by pressing next and prev buttons.

Reviewers: zmike, Hermet

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6823

6 years agotests/genlist: add focus test
Yeongjong Lee [Thu, 9 Aug 2018 08:36:27 +0000 (08:36 +0000)]
tests/genlist: add focus test

This adds test for simulating focus state.
Differential Revision: https://phab.enlightenment.org/D6800

6 years agoefl_ui_focus_manager_calc: restore focus correctly if redirect gets NULL
Marcel Hollerbach [Thu, 9 Aug 2018 08:52:55 +0000 (10:52 +0200)]
efl_ui_focus_manager_calc: restore focus correctly if redirect gets NULL

Otherwise we might end up with focus beeing NULL.

Differential Revision: https://phab.enlightenment.org/D6803

6 years agoefl_ui_focus_manager_calc: fix unregistering the root of a redirect
Marcel Hollerbach [Thu, 9 Aug 2018 08:50:44 +0000 (10:50 +0200)]
efl_ui_focus_manager_calc: fix unregistering the root of a redirect

There is often a tree of elements registered in a manager that are
having all the same redirect element. Unserting the redirect property
just because the node has this redirect element is not helpfull as this
would break basically elm_tests button search. However, if it is the
container itself, then the redirect can be unset, as nothing else can
ever reach again the redirect manager.

ref D6800

Differential Revision: https://phab.enlightenment.org/D6802

6 years agoefl_ui_focus_manager: adjust pop history pop
Marcel Hollerbach [Thu, 9 Aug 2018 08:38:27 +0000 (10:38 +0200)]
efl_ui_focus_manager: adjust pop history pop

It now searches for a element if the focus stack is empty.

Differential Revision: https://phab.enlightenment.org/D6801

6 years agoefl-cxx: Add -Wno-shadow to disable huge warnings in C++
Felipe Magno de Almeida [Mon, 13 Aug 2018 15:12:44 +0000 (11:12 -0400)]
efl-cxx: Add -Wno-shadow to disable huge warnings in C++

Summary:
-Wno-shadow warnings disable a improper warning directive for C++, this is made because
it is common for people to use the same CFLAGS as CXXFLAGS, enabling, unadvertadly, the
smae warning for C and C++.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6821

6 years agoElementary test : add a checkbox to hide beta apis.
chris [Mon, 13 Aug 2018 14:55:52 +0000 (10:55 -0400)]
Elementary test : add a checkbox to hide beta apis.

Reviewers: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6817

6 years agoemotion: make intree running work
Marcel Hollerbach [Mon, 13 Aug 2018 13:57:47 +0000 (09:57 -0400)]
emotion: make intree running work

Summary:
before it would have only worked if there would have been the
architecture in the path, which was definitly not the case.
This fixes the problems.
Depends on D6795

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6819

6 years agoelm: bring back elm/uiclock
Xavi Artigas [Mon, 13 Aug 2018 11:03:39 +0000 (07:03 -0400)]
elm: bring back elm/uiclock

Summary:
It turns out elm/uiclock (which was removed in 89675c3219) is actually used,
at least by the datetime legacy widget. Removing this widget broke the
datetime_example test.
This commit reverts 89675c3219 and fixes the elm/uiclock part names:
- Part names are prefixed with 'elm.'
- efl_ui_clock.c (which is used for both the new efl and the legacy elm widgets)
  now looks for part names with 'efl.' and 'elm.' prefixes, and without any
  prefix, for compatibility with older themes.

Fixes T6928

Test Plan: the Datetime elementary_test (and all other clock-related tests) now work.

Reviewers: zmike, jsuya, CHAN, devilhorns, Jaehyun_Cho

Reviewed By: zmike, jsuya, CHAN

Subscribers: #reviewers, Jaehyun, Hermet, cedric, #committers

Tags: #efl

Maniphest Tasks: T6928

Differential Revision: https://phab.enlightenment.org/D6577

6 years agoelm/naviframe: implement invalidate method for naviframe items
Mike Blumenkrantz [Mon, 13 Aug 2018 06:07:31 +0000 (15:07 +0900)]
elm/naviframe: implement invalidate method for naviframe items

Summary:
move most of the _item_free() calls to the invalidate method and unset some
delete callbacks on content items to avoid invalid calls during deletion

calling any of this during the object destructor is invalid because the parent
object can no longer be accessed at this time

fix T7236

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: #reviewers, stefan_schmidt, cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7236

Differential Revision: https://phab.enlightenment.org/D6759

6 years agoeio: fix poll backend
Marcel Hollerbach [Sun, 12 Aug 2018 08:21:19 +0000 (10:21 +0200)]
eio: fix poll backend

it seems that this should have been a pop call, not the function
pointer. This key eina_array_pop is never used. Nor would the array get
smaller, so i assume this should be a pop call.

Differential Revision: https://phab.enlightenment.org/D6814

6 years agoelm_map: add EINA_UNUSED to avoid build warning
Yeongjong Lee [Fri, 10 Aug 2018 16:49:50 +0000 (12:49 -0400)]
elm_map: add EINA_UNUSED to avoid build warning

Test Plan: make

Reviewers: devilhorns, zmike

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6813

6 years agoevas gl_common: code refactoring.
Hermet Park [Fri, 10 Aug 2018 16:06:42 +0000 (12:06 -0400)]
evas gl_common: code refactoring.

Summary: use boolean instead int, no logic changes.

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6807

6 years agoee_wayland: Remove spurious manual_render
Derek Foreman [Fri, 10 Aug 2018 15:38:25 +0000 (11:38 -0400)]
ee_wayland: Remove spurious manual_render

Summary:
The line prior to this damages the canvas and should result in a render
anyway.

Forcing a manual render here (without regard to the manual_render_set
state) will cause a post render callback to fire for clients that
think they've disabled automatic rendering.

fix T7275

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers, zmike

Tags: #efl

Maniphest Tasks: T7275

Differential Revision: https://phab.enlightenment.org/D6809

6 years agoelm_image : Remove unnecessary test about image
JunsuChoi [Fri, 10 Aug 2018 02:02:16 +0000 (11:02 +0900)]
elm_image : Remove unnecessary test about image

Summary:
The elm_transit test is in test_transit.c.
Testing for elm_transit in test_image.c is unnecessary

Test Plan: elementary_test -to "image click"

Reviewers: Hermet, #reviewers, eunue

Reviewed By: Hermet, #reviewers

Subscribers: cedric, akanad, bowonryu, #reviewers, YOhoho, #committers, JackDanielZ, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6799

6 years agoecore-evas: make manual_render_set a no-op when setting the current value
Mike Blumenkrantz [Thu, 9 Aug 2018 19:51:41 +0000 (15:51 -0400)]
ecore-evas: make manual_render_set a no-op when setting the current value

Summary:
this should not take any action if the existing value of manual_render is
set to the passed value

Reviewers: devilhorns, kimcinoo, ManMower

Reviewed By: devilhorns, kimcinoo, ManMower

Subscribers: ManMower, cedric, #reviewers, #committers

Tags: #efl_display_system

Differential Revision: https://phab.enlightenment.org/D6786